[00:13:01] 3Wikipedia-App-iOS-App: Wikipedia App: [iOS] After removing a page from "Recents" section, loading that same article from Search or Saved Pages does not activate the page navigation at the bottom for that article - https://phabricator.wikimedia.org/T74987#974892 (10Deskana) The first and third points are fixed... [00:14:01] 3Wikipedia-App-iOS-App: Wikipedia App: [iOS] After removing a page from "Recents" section, loading that same article from Search or Saved Pages does not activate the page navigation at the bottom for that article - https://phabricator.wikimedia.org/T74987#974895 (10Deskana) p:5Triage>3Normal [00:14:59] kaldari: are we live? [00:15:35] DarTar: not yet [00:16:40] kaldari: kk [00:17:33] DarTar, leila, Maryana: one of the deployment servers is having problems, so Max is working with ops on that. That is currently blocking the deployment though. [00:17:45] noooo [00:17:54] :) [00:18:10] thanks for the update, kaldari. I'll wait patiently. :-) [00:22:00] kaldari, Maryana, leila: while we’re on it, I’m reorganizing the WikiGrok pages on Meta: [00:22:13] https://meta.wikimedia.org/wiki/Research:WikiGrok <- landing page [00:22:17] oh nice! [00:22:19] (still working on it) [00:22:26] DarTar: Thanks [00:22:30] but then I’d like to move individual experiments under subpages [00:22:36] do you want to link the user testing stuff that abbey + daisy have been doing? [00:22:37] like we did for GettingStarted [00:22:43] sounds good [00:22:57] like : https://meta.wikimedia.org/wiki/Research:WikiGrok/WG1 or /Test1 etc [00:23:04] would that work? [00:23:32] sounds good to me [00:23:44] DarTar: Might be best to use 2015-01-13_Test so it isn’t confusing [00:23:46] although wg is an unfortunate acronym that is highly overused in our world :) [00:24:30] kaldari: I rather like placeholders since they are easy to refer to [00:24:43] we had for GettingStarted a nice high level overview of all iterations [00:24:49] on the landing page [00:25:17] Maryana: agreed on wg, would you guys object to just /Test1 … /Test2 then? [00:25:40] kaldari: I guess there’s also the fact that I’m terrible with dates and 2015-01-13_Test sounds like a mouthful [00:26:05] yes? consensus? /Test1? {{done}} :) [00:26:10] yes! [00:26:20] we can rename them later, it’s a wiki [00:26:21] date strings make my eyes hurt [00:26:47] (03PS2) 10Mhurd: Tweaks to lead image text styling per Vibha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184725 [00:29:19] coreyfloyd: ^ hehe i ended up not commenting those bits out after all :) turns out i actually needed them. in future though, i’ll keep commented bits out [00:31:45] (03CR) 10Mhurd: "Look at the infobox on the Obama article. Because of some upstream css changes we need to use the css "stable" class." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184726 (owner: 10Mhurd) [00:32:10] bgerstle: coreyfloyd ^ couple small patches [00:32:17] dr0ptp4kt: ^ [00:32:23] k [00:32:39] mhurd is it all CSS changes? i'm not great w/ CSS [00:33:06] DarTar, I don't have a strong opinion and will be happy with your call. [00:33:37] bgerstle: it’s pretty easy to proof in this case. look at the first html table on the obama article before/after. you’ll see changes [00:33:48] mhurd: looking [00:34:57] bearND: hey time for quick hangout? [00:35:33] mhurd: batcave? [00:35:47] jdlrobson2: Uploading works for me on currently master of MF [00:35:56] currently=current [00:36:07] bearND: ya [00:37:34] bearND: https://gerrit.wikimedia.org/r/184726 [00:38:15] jdlrobson2: Do you mean cross-domain uploading specifically or local uploading? [00:38:15] kaldari: uploading cross domain [00:38:24] the whole uploads code is a big mess [00:38:43] jdlrobson2: I don’t have a way to test that locally at the moment :( [00:38:50] erg ok :-/ [00:45:43] 3Wikipedia-App-Android-App: Fast flick on "Read more" section should act like a fast flick anywhere else - https://phabricator.wikimedia.org/T86727#974970 (10Deskana) 3NEW [00:56:05] (03PS1) 10Bmansurov: WIP: Provide VisualEditor regardless of device size [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184822 (https://phabricator.wikimedia.org/T85630) [00:58:37] 3Mobile-Web: Main menu should be represented as a View incorporated in Skin - https://phabricator.wikimedia.org/T86238#975015 (10bmansurov) a:3bmansurov [01:02:39] mhurd ping [01:02:50] bgerstle: heya! [01:03:03] so, i'm putting together a cal event for the testing discussion [01:03:12] bgerstle: great! [01:03:14] i wanted to create a wiki article w/ a list of the technologies a know about and a brief description [01:03:24] which wiki is the best venue for that? [01:03:39] Deskana: ^ where would you recommend? [01:04:13] technologies *i* know about ** [01:04:29] wherever we keep our meeting minutes or whatever would be fine, i imagine [01:04:45] bgerstle: I'd put it somewhere in your user space on mediawiki.org probably [01:05:05] bgerstle: e.g. https://mediawiki.org/wiki/Special:MyPage/Testing technologies [01:05:14] hm [01:05:54] bgerstle: Although a formal meeting probably isn't necessary. I'm just going to grab relevant people at the all staff and introduce them to you. :) [01:05:59] kaldari, leila, Maryana, overhaul completed, check this out https://meta.wikimedia.org/wiki/Research:WikiGrok [01:06:23] I think I set up all the redirects we need, but be bold and fix anything I may have missed [01:06:28] DarTar: beautiful! [01:06:29] moizsyed ^^ [01:06:30] mhurd what do you think? should we just talk in person next week? [01:07:38] bgerstle: ah, sure why not. can start with that then once we chat in person we can put something on the calendar for next steps etc. [01:07:44] ok [01:07:47] bgerstle: time for quick hangout? [01:07:58] yeah sure [01:08:05] ring me whenever you're ready [01:20:10] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Tweaks to lead image text styling per Vibha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184725 (owner: 10Mhurd) [01:20:27] 3Wikipedia-App-iOS-App: iOS App: make "Username", "Password" and "Confirm password" fields required in order to submit account creation request - https://phabricator.wikimedia.org/T68944#975027 (10BGerstle-WMF) a:3BGerstle-WMF [01:20:57] (03PS3) 10Dr0ptp4kt: Fix for css body class. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184726 (owner: 10Mhurd) [01:21:06] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Fix for css body class. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184726 (owner: 10Mhurd) [01:24:28] DarTar, leila: WikiGrok is live for 16% of everyone [01:24:36] \o/ [01:24:49] wait, EL is down [01:24:52] if you want to force loading for testing add ?wikigrokversion=B or A to the URL [01:24:54] kidding :) [01:25:18] kaldari: does that also set a test flag? [01:26:07] DarTar: I don’t think so [01:26:10] (03PS3) 10Jdlrobson: WIP Hygiene: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 [01:26:12] (03PS8) 10Jdlrobson: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 [01:26:29] kaldari: ok, so let’s coordinate on a single test article for the purpose of testing [01:26:33] DarTar: if you use wikidataid=QXXXX that should set the testing flag as well, but it isn’t necessary on en.wiki [01:26:46] cool ok [01:26:58] DarTar: I tested on Wolf City [01:26:58] kaldari, does the size of the screen matter? [01:27:01] kaldari: also, I understand we removed the check for the viewport width [01:27:03] lzia: yes [01:27:18] DarTar: That hasn’t been merged yet. [01:27:19] ah, bad lzia – spreading false information [01:27:36] I said we should check with kaldari to make sure DarTar. no false information for you [01:27:39] ;-) [01:27:43] ok ok [01:28:41] feature request: embed WikiGrok campaigns on Wikipedia snippets on iOS8 [01:29:41] (03CR) 10jenkins-bot: [V: 04-1] WIP Hygiene: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [01:29:52] (03CR) 10jenkins-bot: [V: 04-1] Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [01:32:23] kaldari: I don’t see it live yet [01:32:32] should it load on https://en.m.wikipedia.org/wiki/Raymond_Chandler ? [01:32:36] 37 responses already [01:32:58] DarTar: Nope, not on that article [01:33:05] WikiGrok is on Crack though [01:33:10] ha, why not? [01:33:25] http://en.m.wikipedia.org/wiki/Crack_%28album%29 [01:33:46] Maryana, kaldari: logging the quote “WikiGrok is on Crack though” [01:34:00] oh, that's the subject line of the email i'm sending [01:34:02] :) [01:34:10] ha ha [01:34:21] kaldari: I don’t see it there either :( [01:34:32] loading .m on desktop browser [01:34:34] narrow window [01:34:53] and shouldn’t Chandler be eligible? [01:35:07] DarTar: You have to add wikigrokversion=B or A unless you’re in the 16% bucket [01:35:17] [01:35:22] alright [01:36:37] DarTar: Chandler is already both a writer and an author. (The author campaign is the one that tests having a negative condition, in this case ‘Doesn’t already have author claim’) [01:38:30] bearND: I'm noticing some strange issue with the gallery. [01:38:50] bearND: When you slide left and right it doesn't show things in the order that they were in in the article. [01:39:06] kaldari: alright, we already have 10x more widget impressions than during the entire beta test [01:39:20] unsurprising [01:45:37] mhurd dr0ptp4kt how do you guys feel about a small change to add "build/" folder to .gitignore? [01:46:00] bgerstle: open to it! what do you have in mind? [01:46:21] i usually have that on all my projects since i usually build w/in a "build" folder in CI as well as on my dev machine. makes it easy to find for retrieving build artifacts and the occasional Xcode-appeasing "nuke" [01:49:14] bgerstle: ah i see. bring the build folder into the project folder to make debugging easier, and gitignore it [01:49:32] yep [01:50:10] bgerstle: sounds legit. want to create a card in tech backlog and tag all of us so others can chime in? [01:50:30] sure [01:59:03] Deskana: we never had it in order of the article, I believe, but better check with dbrant when he's back. Not sure what order the API returns the results in [02:02:38] (03PS1) 10Bmansurov: WIP: Represent main menu as a View incorporated in Skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) [02:04:34] (03CR) 10jenkins-bot: [V: 04-1] WIP: Represent main menu as a View incorporated in Skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) (owner: 10Bmansurov) [02:09:23] (03CR) 10Bartosz Dziewoński: Infobox item editing using oojs-ui (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [06:56:04] (03CR) 10Florianschmidtwelzow: Hygiene: Don't add missleading class to SpecialUploads (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184718 (owner: 10Florianschmidtwelzow) [07:03:51] (03PS2) 10Florianschmidtwelzow: Hygiene: Don't add missleading class to SpecialUploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184718 [09:57:52] yo [09:59:17] * phuedx is brewing coffee [10:02:58] morning phuedx [10:16:59] hey joakino [10:17:01] how're you? [10:17:20] i'm fine! a bit stressed with the travel stuff [10:17:51] and you? [10:25:04] phuedx: do you know nunjabes? i've been enjoying it a lot lately [10:25:30] nopers [10:25:37] will listen [10:35:06] joakino: i'm currently listening to lights & motion [10:35:12] which ain't hip hop [10:35:19] cinematic post-rock [10:37:05] phuedx: very interesting [10:45:15] joakino: what's stressful about the travel stuff? [10:45:21] is it that you're coming to london first? [10:45:40] that leaves me less time yes [10:45:55] i have the flight the day after tomorrow, and haven't prepared anything yet [10:45:56] less time? [10:46:02] oh [10:46:02] to prepare [10:46:04] :/ [10:46:38] phuedx: btw i know my ESTA expires on april, so that should be fine, right? [10:47:03] yeah, because it doesn't expire during the period of your travel [10:47:06] i think there is no "3 months before expiry" type of thing, like with the passport [10:47:39] i should be fine then, as long as I can locate the passport xD [10:47:58] ! [10:48:05] important part of travel ;) [11:03:40] (03PS4) 10Jhernandez: WIP: Infinite scrolling on Special:EditWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184352 [11:06:49] (03CR) 10jenkins-bot: [V: 04-1] WIP: Infinite scrolling on Special:EditWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184352 (owner: 10Jhernandez) [11:07:06] (03CR) 10Jhernandez: [C: 04-1] "I've had to create a 'mobile.watchlist' entry on Resources since the scripts were on 'special.minerva' and they weren't picked up by the q" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184352 (owner: 10Jhernandez) [11:08:23] (03PS5) 10Jhernandez: WIP: Infinite scrolling on Special:EditWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184352 [11:36:34] (03CR) 10Esanders: Infobox item editing using oojs-ui (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [11:45:54] (03CR) 10Phuedx: [C: 04-1] "The spinner in the notification overlay (and maybe others) needs a top margin. 1em should do it. Whaddya think?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183632 (https://phabricator.wikimedia.org/T86041) (owner: 10Jdlrobson) [12:13:04] i'm going to start packing, i'll be around [12:44:43] gl joakino [15:35:46] phuedx: do you use the "Cherry pick to" button on a patch? [15:36:02] sometimes [15:36:04] but rarely [15:36:08] joakino: why do you ask? [15:36:21] phuedx: not sure about its use case [15:36:30] can i use it to get rid of dependent commits? [15:41:30] yeah, but i'd use rebase then [15:41:37] i cherry pick to release branches [15:41:42] that's all i've used it for [15:45:18] phuedx: oki [16:22:58] * FlorianSW waves around [16:31:01] hey FlorianSW :) [16:31:19] hey jdlrobson2 :) how are you? [16:31:40] good :) also hehe https://twitter.com/chris__martin/status/554918580643721216 [16:32:19] *yay :D And he's totally right :) [16:33:25] i can't wait for the 25th jan :-) 1 1/2 week :D [16:36:16] (03PS4) 10Jdlrobson: Hygiene: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 [16:36:18] (03PS9) 10Jdlrobson: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 [16:36:20] (03CR) 10Jdlrobson: Infobox item editing using oojs-ui (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [16:37:42] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [16:37:46] (03CR) 10jenkins-bot: [V: 04-1] Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [16:37:53] coreyfloyd: heya [16:38:15] i'm about to dig into my on-boarding task, but before i do i wanted to have a place to put our "code review" items [16:38:24] ideally in the same place so we don't end up writing up the same things :wink: [16:41:15] (03PS10) 10Jdlrobson: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 [16:41:34] @bgerstle: I just have mine in a markdown document for now. If you have an existing trello board, I can add stuff to it. [16:41:44] FlorianSW: :D [16:42:40] bgerstle: I gotta stop typing @ symbols - Slack reflex [16:43:14] coreyfloyd, bgerstle: BTW, welcome! :-) [16:43:19] coreyfloyd lol right there w/ you [16:43:24] James_F thanks! [16:43:39] (03CR) 10jenkins-bot: [V: 04-1] Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [16:44:27] (03PS5) 10Jdlrobson: Hygiene: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 [16:44:29] (03PS11) 10Jdlrobson: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 [16:45:57] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [16:46:01] coreyfloyd i wasn't sure what would be best: a wiki, google doc, or trello... [16:46:30] my first instinct would've probably been GH issues for each one, but don't know if these should necessarily be posted publicly [16:46:37] (03CR) 10jenkins-bot: [V: 04-1] Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [16:46:58] let's go w/ trello since it has a nice-enough markdown syntax and a good mentioning & commenting system [16:47:21] (side note/rant: why is it ok for us to use Trello but not GitHub?…) [16:47:57] coreyfloyd what do you think? [16:48:21] Yeah thats good - I'm not sure all items will be issues - more like discussions - I'm sure we will all have different opinions so trello seems good for that. [16:48:43] right [16:48:57] i'm just not familiar enough w/ mediawiki to know how to properly collaborate on something like this [16:50:25] James_F: thanks btw! [16:52:49] (03CR) 10Jdlrobson: "jdi :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183632 (https://phabricator.wikimedia.org/T86041) (owner: 10Jdlrobson) [16:53:18] (03Abandoned) 10Jdlrobson: Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [16:54:03] coreyfloyd you should have a notification, but here it is: https://trello.com/b/C3adox89/ios-on-boarding-code-review [16:54:29] we can add things to "new" as we find them, move issues to "pending" as they're being discussed, and then "resolved" when we've made a decision about what to do [16:54:45] morning all :) [16:54:52] hi brion :) [16:54:57] Hi brion V [16:57:05] heya brion [16:57:24] coreyfloyd FYI i sorta dumped all my "iOS" ideas which had some comments from Monte and others in there [16:57:35] it's a bit cluttered, open to suggestions for un-cluttering [16:58:26] apparently somebody got run over by a bart train so things aren’t running, i’ll be wfh for the standup today :( [17:00:15] (03PS1) 10Fjalapeno: Reset scroll position when searching bug T70230 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184910 [17:01:09] (03PS1) 10Fjalapeno: Only used cached article when navigating back/forward bug T70230 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184911 [17:02:28] :cry: [17:06:28] bgerstle: sounds good [17:08:12] phuedx, just picked up Dark Comedy again. Thanks to google music, I can see that played through that album 20 times while I was bumming around Europe after Wikimania :) [17:08:26] So, that was pretty awesome recommendation :) [17:08:44] \o/ [17:08:53] have you listened to 4NML HSPTL? [17:09:03] nope. /me searches [17:09:09] equally as good but a little bit dirtier [17:09:30] Oh! Another Open Mike Eagle! [17:41:10] (03CR) 10Brion VIBBER: [C: 04-1] "Looks like this will remove the cached version before we hit the network, so if we're offline it's not possible to load up a cached saved " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184911 (owner: 10Fjalapeno) [17:43:15] (03CR) 10Brion VIBBER: "I think the thing to do here is actually to only use the stored scroll position when we're loading a page following a back/forward discove" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184910 (owner: 10Fjalapeno) [17:43:53] (03CR) 10BearND: [C: 04-1] "Video playback works. :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) (owner: 10Dbrant) [17:47:04] bearND: can you give an example where clicking on a video in an article doesn't bring up the gallery? [17:47:19] dbrant: [[ace of spades]] [17:48:18] bearND: the "army footage"? it works for me... [17:49:28] dbrant: hmm, that's the only one i tried so far. Clicking on the image doesn't do anything. There is a link below it to download the video, which opens an app chooser [17:49:51] dbrant: I've only tried on my 5.0 device [17:50:09] bearND: that kinda sounds like an outdated patch... [17:51:11] dbrant: I've used PS7, which is the latest that got pushed [17:54:39] bearND: yep, ps7 should be correct; it doesn't sound like you're running the latest, because I've also removed the "Play media" link below the video, and you say you're still seeing it... [17:54:59] bearND: maybe an Android Studio glitch? [17:55:08] dbrant: ok, I'll rebuild and try again [17:58:31] Hey joakino and phuedx, what time do you guys get to SF on Tuesday? [17:59:00] kristenlans: 4:35 pm [17:59:43] to foundation hq laters [17:59:56] dbrant: ok, this works now. But it's missing any indication of the page that this is a video, something like the overlaid play button that desktop uses [18:00:29] bearND: agreed; we'll have to add something on for that. [18:02:56] (03CR) 10Jdlrobson: [C: 032] Hygiene: Don't add missleading class to SpecialUploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184718 (owner: 10Florianschmidtwelzow) [18:03:20] (03PS3) 10Jdlrobson: Hygiene: Kill obsolete profiling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184801 (owner: 10MaxSem) [18:04:00] (03CR) 10Jdlrobson: "MaxSem can you please add a link in the commit message to show where this became obsolete? This will help me judge whether this is the rig" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184801 (owner: 10MaxSem) [18:05:05] Wikidata descriptions from mobileview queries is live! https://en.wikipedia.org/w/api.php?action=mobileview&format=jsonfm&page=Food&prop=description [18:05:26] dbrant: bearND: ^ [18:05:43] mhurd: yeah! :) [18:05:59] :) i am so irrationally thrilled [18:06:16] (03Merged) 10jenkins-bot: Hygiene: Don't add missleading class to SpecialUploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184718 (owner: 10Florianschmidtwelzow) [18:07:24] jdlrobson2: hey [18:07:33] i'm with the foreign api [18:07:46] mhurd: bearND: yes!!! [18:08:08] jdlrobson2: i think i have a "fix" for the photo api to work locally, still not very happy [18:08:14] joakino: hey. i also got it working.. [18:08:19] lel [18:08:27] joakino: the code is horrible but if you got it working locally that helps me a lot :) [18:08:37] yesterday was a horrible day grappling with it [18:08:47] now there is just a weird qunit issue i need to work out [18:08:56] jdlrobson2: oki [18:09:00] jdlrobson2: it is a bit messy [18:09:15] yeh it's nasty. I'm hoping to have a session during dev summit to help people realise this [18:09:55] jdlrobson2: what do you need me to do [18:09:59] so that we don't overlap [18:10:23] (03CR) 10Jdlrobson: User friendly dates for wikidata infobox (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960) (owner: 10Bmansurov) [18:10:37] (03CR) 10Jdlrobson: [C: 032] Add Talk button url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184795 (https://phabricator.wikimedia.org/T69819) (owner: 10Bmansurov) [18:10:57] joakino: for Foreign api or dev summit? [18:11:20] (03PS6) 10Jhernandez: Hygiene: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [18:11:23] joakino: for foreign api i think i just need to make sure someone other than i understands it and can test it [18:11:57] (03Merged) 10jenkins-bot: Add Talk button url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184795 (https://phabricator.wikimedia.org/T69819) (owner: 10Bmansurov) [18:12:00] joakino: so token shouldn't be needed here -> https://gerrit.wikimedia.org/r/#/c/182134/5..6/javascripts/modules/uploads/PhotoApi.js [18:12:05] the post method does all the toen handling [18:12:24] (03CR) 10Jhernandez: "ps6 is how i've fixed the photo upload in-wiki, feel free to discard, since you already got it" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [18:12:33] yeah [18:12:51] jdlrobson2: ^ i've posted the patch, just for reference, it's hacky [18:12:56] thx [18:13:07] jdlrobson2: the good way would be overloading post on Api to get the edit token, right? [18:13:34] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [18:13:52] joakino: that would be the ideal way. not sure if it will work that way though :-/ [18:14:10] the thing that is weird is you have to get a token from the local api [18:14:14] and then a token from the endpoint api [18:14:19] and then another local api token [18:14:41] yeah, its 4 ajax calls to do anything [18:14:59] (03PS4) 10Florianschmidtwelzow: Add "add discussion" button to talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182397 (https://bugzilla.wikimedia.org/70614) [18:15:46] (03PS5) 10Florianschmidtwelzow: Add "add discussion" button to talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182397 (https://bugzilla.wikimedia.org/70614) [18:16:21] jdlrobson2: how would you test endpoint/no-endpoint for an api? I've got some with endpoint (nearby) and some local (photo), should I point wgMFPhotoUploadEndpoint to my local commons api url? [18:16:39] and swapping that var check if it works in both? [18:16:58] (03CR) 10Bmansurov: User friendly dates for wikidata infobox (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960) (owner: 10Bmansurov) [18:17:05] jdlrobson2: hi, ^ [18:17:19] (03PS5) 10Jdlrobson: Fix icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183632 (https://phabricator.wikimedia.org/T86041) [18:17:20] hey bmansurov [18:17:36] joakino: yeh so the way i've done it is painful [18:17:44] on vagrant install commons [18:17:48] then vagrant provision [18:17:50] done [18:17:53] create a new account just to be sure. [18:18:03] ok now navigate to http://en.wiki.local.wmftest.net:8080/ [18:18:04] done too, and uploaded image to test it [18:18:23] yes [18:18:25] 3Mobile-Web: Editing messed up in iOS 8 when you scroll - https://phabricator.wikimedia.org/T86553#976625 (10kaldari) 5Open>3Invalid a:3kaldari [18:18:29] mw.config.values.wgMFPhotoUploadEndpoint === "http://commons.wiki.local.wmftest.net:8080/w/api.php" [18:18:30] jdlrobson2, bmansurov, joakino: is it possible, that one of you run Special:JavaScriptTest/qunit on your local dev env with mobilefrontend master? :) [18:18:49] FlorianSW: it's broken for me - getting some issues in Skin js and some api requests [18:18:51] what about you [18:19:14] jdlrobson2: me too (i know why and upload a patch in some minutes), but i'm wondering about: [18:19:20] joakino: okay sweet. Did PS5 work for you? git fetch https://gerrit.wikimedia.org/r/mediawiki/extensions/MobileFrontend refs/changes/34/182134/5 && git checkout FETCH_HEAD [18:19:22] FlorianSW: +1, i've been seeing some weird stuff with wikigrok and skin too, i thought it was only me [18:19:24] https://gerrit.wikimedia.org/r/#/c/182397/3 [18:19:29] FlorianSW: you are a super star :) [18:19:48] jenkins doesn't run into the problem :P [18:19:58] FlorianSW: yeh it's possible jenkins is running a different setup [18:20:04] e.g. different installed extensions [18:20:27] jdlrobson2: what is the difference between enwiki and devwiki and mobilewiki? [18:20:47] joakino: hahaha i wish i knew. i'm guessing configuration [18:20:57] enwiki and commons seem to support the centralauth role though [18:21:05] which is what is needed for this cors stuff to work [18:21:13] jdlrobson2: hmm, maybe jenkins doesn't run wikigrok tests? [18:21:14] joakino: i moaned at Max about that [18:21:25] jdlrobson2: so how do i test after going to enwiki [18:21:33] and he said something about not wanting to touch vagrant wikidata again [18:21:43] joakino: so first you'll need to enable uploads [18:22:48] joakino: btw i have the RFC today around watchlist stuff. I'm hoping that will get some concrete steps/support [18:23:20] jdlrobson2: awesome [18:23:46] joakino: do you think there's any other spikes we should do before kick off. Do you feel the next 2 sprints are pretty actionable? [18:24:08] e.g. sprint 1: setting up viewing, sprint 2: new watching workflow [18:24:42] jdlrobson2: seems good to me, but the backendy side of things is a bit blurry [18:24:47] joakino: yeh :-/ [18:24:59] joakino: i think as a backup we might have to prepared to save in a wiki page (yuk) [18:25:17] hopefully it won't come to that [18:25:19] jdlrobson2: lol [18:25:35] it's probably worth exploring alternative data storage models in the absence of the backend though [18:25:41] * jdlrobson2 creates a spike [18:25:53] jdlrobson2: so are we doing a separate extension then? [18:27:11] (03PS1) 10Fjalapeno: Forcing the web view to reload a searched article without deleting the cache (per Brions code review comment). bug T70230 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184939 [18:27:45] jdlrobson2: how do i enable uploads on enwiki [18:28:21] joakino: it's up to us. Personally I dislike creating new extensions as it makes code harder to follow since the extension will end up being closely coupled to MobileFrontend anyway [18:28:37] awjr: with 2min to spare :) [18:28:44] joakino: so to enable uploads... [18:29:02] jdlrobson2: i have no preference or idea, i've just seen some grumbling around :p [18:29:04] tfinc :D we worked hard to ensure we'd keep within 30 mins :) [18:29:08] $wgGroupPermissions['*']['mf-uploadbutton'] = true; [18:30:22] mm why is my npm hanging [18:30:48] jdlrobson: here? settings.d/wikis/enwiki/LocalSettings.php [18:31:17] jdlrobson: its in protest for the iojs release http://iojs.org/ [18:31:36] 💩 [18:32:11] joakino: oh really? [18:32:16] feck [18:32:27] nope just trolling xd [18:32:33] WHHYY DOESNT IT WORK :( [18:33:04] jdlrobson jdlrobso_ clonesss [18:33:15] coreyfloyd: would you mind sqashing those 3 commits down to one? [18:33:21] jdlrobso_: npm install wfm [18:33:38] joakino: yeh just hangs for me no idea why [18:33:41] should i remove node_modules ? [18:33:49] or reboot? [18:33:52] xD [18:33:54] coreyfloyd: or is it just 2... [18:34:51] bbiab [18:35:03] jdlrobso_: you can probably safely remove node_modules (unless youve touched something you want), there is a cache in ~/.npm/ [18:35:25] mhurd: its 3. Do you always do patches as a single commit? [18:35:49] i'm due a reboot anyway. brb [18:37:54] coreyfloyd: not always, no hard rule. i think the reason it’s showing up in gerrit as two patches is you have a different “Change-Id:” in the commit message [18:38:22] fyi mobile web wikigrokkers, i'm adding some bugs from phab to trello, in case y'all run out of work [18:38:28] bmansurov: phuedx ^ [18:38:59] ok [18:39:08] joakino: reboot fixes everythign :) [18:39:23] FlorianSW: any idea what's wrong with qunit tests then? [18:39:46] the first problem: yes (Skin.js), but the second i'm still investigating [18:40:13] it's because wgArticlePath isn't set, but wikigrok uses a mw util function that needs it. [18:40:27] (03Abandoned) 10Fjalapeno: Only used cached article when navigating back/forward bug T70230 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184911 (owner: 10Fjalapeno) [18:40:31] coreyfloyd: my recommendation would be to abandon the second one, then amend the first leaving the “Change-Id:” as-is, then do “git review” again. that way the comments/discussion/changes are tracted in one place. does that make sense? [18:40:39] FlorianSW: does it declare mediawiki.util as an argument/ [18:40:49] *tracked* [18:40:51] * jdlrobson moans about extensions that depend on other extensions [18:40:56] * joakino goes 🚬 [18:42:08] jdlrobson: the problem is: https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki/mediawiki.util.js#L97 [18:42:22] which causes and exception if wgArticlePath isn't set [18:42:47] FlorianSW: why isn't it set? [18:43:11] jdlrobson: it's not part of mediawiki's qunit setup, and we never needed it :) [18:43:27] wait why is wikigrok using it?! [18:44:28] FlorianSW: do you have a fix for the skin issue? [18:45:06] jdlrobson: yap (i actually figure out, where wikigrok comes to use getUrl, but i missed much of the code changes in wikigrok :P) [18:45:39] can you post the skin issue? [18:45:46] it's blocking me from other debugging [18:45:57] by that i mean the fix for skin issue [18:46:13] mhurd: could you catch me up on the class="stable" issue? [18:47:45] mhurd: makes sense - but I had already abandoned the before you wrote it :( - is that ok? [18:47:57] (03PS1) 10Florianschmidtwelzow: Fix Skin qunit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184944 [18:47:59] jdlrobson: ^ [18:48:19] FlorianSW: \o/ [18:49:03] so weird that wasn't picked up by jenkins [18:49:54] yeah, but i'm wondering why :/ [18:50:06] (03CR) 10Jdlrobson: [C: 032] Fix Skin qunit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184944 (owner: 10Florianschmidtwelzow) [18:50:55] mm weird. i'm now getting errors with MobileFrontend modules/editor/EditorOverlay: #without-preview (1, 0, 1)Rerun [18:51:09] oO [18:51:23] (03Merged) 10jenkins-bot: Fix Skin qunit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184944 (owner: 10Florianschmidtwelzow) [18:51:51] jdlrobson: any error message? [18:52:06] for some reason it's comparing "Save" with "" [18:52:09] maybe a load order issue [18:52:31] jdlrobson: are you tackling the missing alpha icons? [18:52:48] if not, we can add it to the grok board [18:52:51] Maryana: no. i thought kaldari was. I'm still waiting on him emailing a report with the issue he hit during deployment [18:52:58] i have no idea what the issue was at the moment [18:53:16] there were two things [18:53:35] one had something to do with servers being down/ops issue. the other was that wikigrok just plain didn't work on testwiki [18:53:41] despite working on beta labs and in prod [18:53:48] so all i know is we deployed a change, we had errors in the log related to ResourceLoaderImageModule. I have no idea what those errors were though [18:53:58] until i have a post mortem report i cannot help [18:54:05] ok [18:54:13] and kaldari you said you'd do that [18:54:18] ok [18:54:46] coreyfloyd: ya no worries! [18:55:30] jdlrobson: It had to be a core dependency. I would suggest just restoring the code as it was before. [18:56:11] kaldari: are you gonna be in office later? let's get to bottom of this [18:56:21] jdlrobson: yes [18:56:26] i'm completely confused to be honest with what's on our servers due to all these lightning deploys and out of schedule wikigrok deployments [18:56:31] it seems like a complete mess to me [18:56:37] and it's no wonder stuff keeps breaking [18:56:50] moizsyed: have a few minutes to chat today? [18:56:51] jdlrobson: it is, so let’s move WikiGrok out of MF :) [18:56:58] kaldari: that doesn't help here [18:57:14] mhurd: yeah for sure [18:57:27] in fact i think it makes things worse, as you'll have to manage dependencies on core and mobilefrontend which provides all your frontend code [18:57:41] what i suspect is happening is core is running an older version of image module and that's incompatible with current master [18:57:48] based on the fact it works fine on beta labs [18:58:04] or possibly the image module hasn't been enabled on enwiki yet [18:58:13] but let's get to the bottom of this when you are in the office [18:58:16] jdlrobson: sure [18:58:58] i wasn't sure which card in phab relates to this, so i just made this: https://trello.com/c/0hmUdFNV/46-bug-icons-missing-in-alpha [18:59:07] feel free to use that to track your work as you investigate [18:59:16] (03CR) 10Fjalapeno: "@brion - note the current implementation of that method does not store the back/forward discover method to the history (which makes sense)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184910 (owner: 10Fjalapeno) [18:59:20] jdlrobson: to your failing test: the message is part of mobile.overlays so it should be loaded :/ [18:59:32] FlorianSW: ^ already got it :) [18:59:36] (03PS7) 10Jdlrobson: Hygiene: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 [18:59:39] (03PS1) 10Jdlrobson: Make sure InfoboxEditorOverlay has Overlay dependency loaded [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184948 [18:59:47] jdlrobson: ah, ok :) What was it? [18:59:59] FlorianSW: exactly what you said :) [19:00:01] tests passing for me now [19:00:08] :P great! [19:00:22] (03CR) 10Brion VIBBER: "Yeah, an ivar in WebViewController probably makes sense." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184910 (owner: 10Fjalapeno) [19:00:52] going to call it for the day [19:01:30] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [19:01:36] have a nice day people [19:01:42] see you joakino! :) [19:02:01] bai joakino [19:02:07] brion: you you have a minute to do a quick patch to put descriptions in data store? i added “description” to ArticleFetcher prop but it seems to not to be available. were we going to change MWKArticle “description” to “entitleDescription"? [19:02:27] oh crap i forgot to commit that didn’t i :D [19:02:29] ok lemme do that now mhurd [19:02:36] brion: yay! :) [19:02:49] yeah righ tnow it’ll probably get confused ;) [19:02:50] errgg tests still failing for that patch. whyhyhyhyhy [19:02:57] lemme double-check that the api returns are as expected [19:03:40] (03CR) 10Phuedx: [C: 032] Fix icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183632 (https://phabricator.wikimedia.org/T86041) (owner: 10Jdlrobson) [19:03:47] (03CR) 10MaxSem: "How about checking the functions beiong removed? ;)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184801 (owner: 10MaxSem) [19:04:04] MaxSem: all i'm asking for is a patch for future reference [19:04:29] i'm a busy man and i haven't always got time to search through core commits. all i'm asking is for you to make my life easier [19:04:50] ok good it comes back as expected. nice! lemme adjust the field name [19:05:32] bahhh xcode Y U NO USE MY PATH VARIABLE [19:05:40] hehe [19:05:50] welcome to xcode, where things only make sense the apple way [19:06:08] ╯‵Д′)╯彡┻━┻ [19:06:20] (03Merged) 10jenkins-bot: Fix icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183632 (https://phabricator.wikimedia.org/T86041) (owner: 10Jdlrobson) [19:06:20] ugh i keep breaking xcode by searching ;) got to be some way to exlucde all the .npm stuff from search [19:06:39] where's your .npm folder? [19:06:46] also, what's your .npm folder for? [19:07:24] https://trello.com/c/Yd8nkjNB/195-promote-new-infobox-styling-to-stable [19:08:24] brion i'm usually able to go tit-for-tat w/ xcode, and i've been able to work w/ more complex projects… but this seems to be a new issue [19:08:29] it's completely overriding the PATH variable [19:08:37] is there anything in the wiki project that could be doing that? [19:08:49] hmmmmm interesting [19:08:58] i don’t think so… [19:09:24] (03PS2) 10Bmansurov: Represent main menu as a View incorporated in Skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) [19:10:07] bgerstle: completely wiping it or not picking up /usr/local or sth? [19:10:26] brion, so i don't have stuff installed in usr/local :confused: [19:10:45] (03PS1) 10Brion VIBBER: description -> entityDescription [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184952 [19:11:00] bgerstle: ah i usually put brew/node/etc in there [19:11:05] i'm using a framework/tool called "boxen" which installs stuff "elsewhere" [19:11:07] yeah [19:11:12] scary :D [19:11:29] it uses puppet and has been really useful for replicating my environment across machines (including CI) [19:11:34] nice! [19:11:50] ./scripts/run-grunt.sh:PATH=${PATH}:/usr/local/bin [19:11:54] well that shouldn’t explode [19:12:04] no, because it "inherits" the current path [19:12:15] yeah…. weird [19:12:20] and i can see why you had to do it, because the build environment's path doesn't include it [19:12:25] EVEN though it's in /etc/paths [19:12:31] 3Mobile-Web: Images are top-aligned in image viewer - https://phabricator.wikimedia.org/T86800#976805 (10MaxSem) 3NEW [19:13:32] ¯\_(ツ)_/¯ [19:13:52] i even set PATH in launchctl [19:14:09] brion do we have a pastebin that we use? [19:14:25] bgerstle: i usually use github gists [19:14:33] any pastebin will do tho :) [19:14:46] k, looking for something a little more transient than a gist [19:15:14] here we are: http://pastebin.com/mgsmBDNZ [19:15:22] that's from the build output [19:15:35] interesting [19:15:49] so "bunch:of:xcode:nonsense:usr/bin:etc.." [19:16:05] /usr/bin* [19:16:38] bgerstle: is that in xcodebuild cli or build from the xcode gui? [19:16:53] GUI [19:17:00] i'm guessing it would work from command line [19:17:07] but i'd *like* to use Xcode GUI ;-) [19:17:23] coreyfloyd: abandon this as well? https://gerrit.wikimedia.org/r/#/c/184939/ [19:18:49] (03PS8) 10Jdlrobson: Hygiene: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 [19:18:51] (03PS1) 10Jdlrobson: Update to Watchstar tests to ensure user is spoofed as authenticated [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184961 [19:19:26] bgerstle: just for fun, try switching the ‘Always search user paths’ setting in build settings from ‘no’ to ‘yes’ and see if that does anything [19:19:42] brion: entitleDescription good to go? [19:19:44] i’m not sure whether it affects executable path as it’s worded very vaguely but hey worth a shot [19:19:47] mhurd: should be, how’s it look? [19:19:51] ok lemme mark it for ya [19:19:53] i highly doubt that's it, but i'll try. that's IIRC related to #import "" statements [19:20:01] (note quotes instead of angle brackets <>) [19:20:09] yeah that makes more sense [19:20:11] hmmmmmz [19:20:25] brion: looks like the “description” prop needs to be added yet… [19:20:41] mhurd: ? [19:20:54] brion: to the query parameters [19:20:57] (03PS2) 10Jdlrobson: Make sure InfoboxEditorOverlay has Overlay dependency loaded [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184948 [19:20:57] ah [19:20:59] oh yeah [19:21:13] (03PS2) 10Jdlrobson: Update to Watchstar tests to ensure user is spoofed as authenticated [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184961 [19:21:20] (03PS9) 10Jdlrobson: Hygiene: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 [19:21:24] (03CR) 10Bartosz Dziewoński: [C: 04-1] Infobox item editing using oojs-ui (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [19:22:05] aha [19:22:07] (03PS12) 10Jdlrobson: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 [19:22:25] let me try another project to see if it's something specific to this one [19:22:27] bgerstle: is this for the build scripts specifically? apparently they don’t run in standard shell so don’t get the standard path [19:22:54] brion that's correct, they run w/in xcode's build environment [19:23:15] but AFAIK (at least historically) that would inherit from the system (or shell if run from shell) [19:24:45] bgerstle: worst case, we can make a shell config file that you can drop your overridden path in and just source it from the scripts [19:24:53] seems like there should be a cleaner way though o_O [19:24:54] 3Mobile-Web: Overlay icons misaligned in alpha - https://phabricator.wikimedia.org/T86041#976882 (10Jdlrobson) 5Open>3Resolved [19:24:57] eek [19:24:57] yeah [19:25:05] SHIM ALL THE THINGS [19:25:10] 3Mobile-Web: If Javascript is disabled and an article doesn't have a talk page, we shouldn't show the talk page icon - https://phabricator.wikimedia.org/T69819#976886 (10Jdlrobson) 5Open>3Resolved [19:25:21] 3Mobile-Web: special:uploads not rendering on production - https://phabricator.wikimedia.org/T86400#976887 (10Jdlrobson) 5Open>3Resolved [19:26:05] well, good news, it doesn't appear to be wiki-specific! \o/ [19:26:45] :D hehe [19:26:46] (03PS1) 10Florianschmidtwelzow: Hygiene: Don't load senseless modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184963 [19:26:57] bgerstle: oh good! [19:27:02] jdlrobson: ^ i hope the commit message is understandable [19:27:09] but how the hell did this used to work.. [19:27:13] (03CR) 10jenkins-bot: [V: 04-1] Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [19:28:17] bgerstle: xcode isn’t bound by the laws of nature [19:28:34] yes, this i knew.. but it continues to bamboozle me [19:28:41] lol [19:29:27] haha [19:31:03] brion: i added descrip to the articlefetcher and it… WORKZSS!! if you already have patch for adding the param let me know - or i can submit one if you prefer [19:31:11] woooo [19:31:14] i’ll add [19:31:18] brion: k [19:31:27] that’s just in articlefetcher right? [19:31:31] brion: ya [19:32:28] (03PS1) 10Brion VIBBER: Fetch the description param from mobileview API [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184969 [19:32:31] (03Abandoned) 10Fjalapeno: Forcing the web view to reload a searched article without deleting the cache (per Brions code review comment). bug T70230 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184939 (owner: 10Fjalapeno) [19:32:40] (03Abandoned) 10Fjalapeno: Reset scroll position when searching bug T70230 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184910 (owner: 10Fjalapeno) [19:32:51] (03PS1) 10Fjalapeno: Reset scroll position when searching bug T70230 Only used cached article when navigating back/forward Forcing the web view to reload a searched article without deleting the cache (per Brions code review comment). Add property to track if navigation was du [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184970 [19:33:13] (03CR) 10Aude: "just to note, i think wikibase it self also has similar functionality." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [19:33:15] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184952 (owner: 10Brion VIBBER) [19:33:19] \o/ [19:33:29] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184969 (owner: 10Brion VIBBER) [19:33:54] brion: woohoo! … off to the races! descrip patches coming soon :) [19:34:00] :D awesome [19:34:01] times like these i want to switch to AppCode [19:34:33] bgerstle: i hear ya! [19:35:02] bgerstle: they even support swift and some interface builder-y stuffs these days… [19:35:13] sweet i keep meaning to try it out [19:37:07] 3Mobile-Web, MediaWiki-extensions-Thanks: Thanks button not loading on mobile - https://phabricator.wikimedia.org/T77929#976957 (10Jdlrobson) Is this the same issue as T86687 ? [19:38:23] 3Mobile-Web, MediaWiki-extensions-Thanks: Thanks button not loading on mobile - https://phabricator.wikimedia.org/T77929#976960 (10Florian) Yap :( Now it's in production on wikipedia. There are still flow tests failing, anyone an idea? [19:38:38] kaldari: if you want good evidence to why we shouldn't break stuff out into other extensions just take a look at Thanks [19:38:44] the most simple of features and it breaks regularly [19:38:54] (i'd actually suggest we move that code into mobile) [19:39:03] bbiab [19:39:08] 3Mobile-Web: Thanks is broken again - https://phabricator.wikimedia.org/T86687#976961 (10Florian) [19:39:09] 3Mobile-Web, MediaWiki-extensions-Thanks: Thanks button not loading on mobile - https://phabricator.wikimedia.org/T77929#976962 (10Florian) [19:39:10] morning kaldari. [19:39:46] what's the timestamp for the start of yesterday's test, kaldari? [19:40:17] leila: it’s in the email I sent [19:40:56] (03PS13) 10Jdlrobson: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 [19:41:24] thanks, kaldari [19:42:27] (03CR) 10Deskana: [C: 04-1] "Please amend the patch to do the following:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184970 (owner: 10Fjalapeno) [19:43:40] brion unfortunatley, i'm tempted to do what you suggested… "import" the user's shell environment variables [19:46:31] FWIW, i can see my _OTHER_ env variables in the script (since i launched the app from shell) [19:46:55] Xcode is just obliterating the path instead of inheriting from it, or at least even preserving it as a suffix >:( [19:46:59] :angry: [19:50:29] Updating my OS and I'm about to get kicked off IRC [19:50:31] Be back when it's done [19:50:38] 3Mobile-Web: Thanks is broken again - https://phabricator.wikimedia.org/T86687#977009 (10Jdlrobson) 5duplicate>3Open I haven't verified this fix yet but we should add some basic tests to the thanks extension before we close this. This breakage happens far too often. [19:50:57] 3Mobile-Web, MediaWiki-extensions-Thanks: Thanks is broken again (Mobile Thanks needs qunit tests) - https://phabricator.wikimedia.org/T86687#977014 (10Jdlrobson) [19:56:12] (03PS1) 10Florianschmidtwelzow: Fix some jsduck errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184980 [19:56:25] 3Mobile-Web, MediaWiki-extensions-Thanks: Thanks is broken again (Mobile Thanks needs qunit tests) - https://phabricator.wikimedia.org/T86687#977031 (10Mattflaschen) >>! In T86687#977009, @Jdlrobson wrote: > I haven't verified this fix yet but we should add some basic tests to the thanks extension before we clos... [19:56:47] brion as expected, running xcodebuild does the "right" thing: http://pastebin.com/vZ5Cn8EA [19:58:17] gonna head off -- g'night fo;kls [19:58:19] *folks [19:58:34] night phuedx thanks for surfing the awkwardness wave! [19:58:47] oh crap [19:58:55] (of our robot/bad connectivity meeting) [19:58:58] mhurd brion can haz dev certificate? [19:59:23] and invite to dev account? [19:59:41] see you, phuedx [19:59:56] (it was constructively interfering with my personal awkwardness wave) [20:00:04] TO THE BED CAVE! [20:01:10] (03PS2) 10Fjalapeno: Navigation and Caching behavior changes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184970 [20:02:04] bgerstle: we’ll have to ping brion for that when he’s back online [20:02:20] oh ok [20:02:21] whoops [20:05:35] mhurd you're not an admin for the dev account? [20:09:26] bb 1hour [20:10:20] k [20:10:41] ughh just had to symlink npm and grunt into /usr/local/bin [20:10:46] * bgerstle keeps repeating "it's temporary" to himself [20:16:04] (03CR) 10Bmansurov: [C: 032] Make sure InfoboxEditorOverlay has Overlay dependency loaded [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184948 (owner: 10Jdlrobson) [20:18:05] (03CR) 10Bmansurov: Fix some jsduck errors (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184980 (owner: 10Florianschmidtwelzow) [20:18:22] Is Max not in here or is he hiding under a different name? [20:20:36] (03Merged) 10jenkins-bot: Make sure InfoboxEditorOverlay has Overlay dependency loaded [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184948 (owner: 10Jdlrobson) [20:20:38] Deskana: OuKB [20:21:04] OuKB: I made a thing, and would appreciate a review. :-) https://gerrit.wikimedia.org/r/#/c/182886/ [20:22:34] RESTART TIEM [20:26:12] (03PS1) 10Dbrant: Use Wikidata description returned by MobileView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184987 [20:26:47] (03CR) 10Florianschmidtwelzow: Fix some jsduck errors (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184980 (owner: 10Florianschmidtwelzow) [20:26:59] (03PS1) 10Mhurd: Hook up lead image Wikidata descriptions! [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184988 [20:29:55] (03PS1) 10Mhurd: Update to latest upstream css. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184990 [20:32:18] (03CR) 10Mhurd: "Will test after lunch..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184970 (owner: 10Fjalapeno) [20:32:28] lunch and stuff brb etc [20:33:43] (03CR) 10Bmansurov: [C: 032] Update to Watchstar tests to ensure user is spoofed as authenticated [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184961 (owner: 10Jdlrobson) [20:35:06] (03Merged) 10jenkins-bot: Update to Watchstar tests to ensure user is spoofed as authenticated [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184961 (owner: 10Jdlrobson) [20:35:11] phuedx: btw thanks for the feedback gonna take a look at that later today [20:35:33] (03CR) 10Bmansurov: [C: 032] Fix some jsduck errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184980 (owner: 10Florianschmidtwelzow) [20:36:13] (03CR) 10Jdlrobson: [C: 04-1] "needs another rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183754 (https://phabricator.wikimedia.org/T85572) (owner: 10Bmansurov) [20:36:28] (03PS3) 10Jdlrobson: Represent main menu as a View incorporated in Skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) (owner: 10Bmansurov) [20:37:30] wow, i wanted to listen to something that wasn't on spotify, so… https://i.imgflip.com/ge7l7.jpg [20:39:52] mhurd is there an easy way to test account creation w/o affecting production? [20:40:01] et. al? :point_up: [20:42:07] (03CR) 10Bmansurov: [C: 04-1] "Since in alpha we show the WIkiGrok menu item in the sidebar, we need this module so that we can use it to load the next page. I think thi" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184963 (owner: 10Florianschmidtwelzow) [20:43:20] Deskana: bearND: I have a conflicting meeting during the Search patch evaluation... do you need me there? [if so, can we move it] [20:46:27] (03PS1) 10Deskana: Update COPYING file copyright year to 2015 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184992 [20:47:15] (03CR) 10Jdlrobson: "I can't see any visible problems but I was very surprised that this works. Please see my concerns." (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) (owner: 10Bmansurov) [20:47:32] (03PS1) 10Deskana: Update MITLICENCE.txt file copyright year to 2015 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184993 [20:47:56] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Introduce ForeignApi (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [20:48:43] (03CR) 10Jdlrobson: "Aude +100000" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [20:49:02] bgerstle: not that i’m aware of. when i tested i named the test accts “account_creation_test_xxx” so at least they were grouped by name [20:49:10] (03CR) 10BearND: [C: 032] Update COPYING file copyright year to 2015 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184992 (owner: 10Deskana) [20:49:36] hm, ok [20:49:40] (03Merged) 10jenkins-bot: Update COPYING file copyright year to 2015 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184992 (owner: 10Deskana) [20:49:55] (03CR) 10Deskana: [C: 032] "Trivial documentation fix" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184993 (owner: 10Deskana) [20:50:13] (03CR) 10Jdlrobson: Hygiene: Introduce ForeignApi (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [20:51:35] dbrant: That's really up to Deskana. I don't mind either way. Are you planning to come to the design review, right afterwards? [20:51:50] bearND: yes, I'll be there [20:51:55] cool [20:52:04] (03CR) 10Bmansurov: Represent main menu as a View incorporated in Skin (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) (owner: 10Bmansurov) [20:52:13] I thought I cancelled the design review. [20:52:13] STUPID GOOGLE CALENDAR [20:52:20] * Deskana sighs [20:52:48] Now I see why kristenlans changes meeting titles to say cancelled. [20:52:56] (03CR) 10Jdlrobson: "all i'm asking for is a link I know you have at your exposal. I would have +2ed that with the link but right now I'm too busy to go on a w" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184801 (owner: 10MaxSem) [20:53:14] (03PS6) 10Jdlrobson: Hygiene: Retrieve pageApi instance using module loader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183648 [20:54:00] (03CR) 10Jdlrobson: Hygiene: Retrieve pageApi instance using module loader (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183648 (owner: 10Jdlrobson) [20:54:16] (03PS2) 10Jdlrobson: Update ApiResult handling for mediawiki/core change I7b37295e [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie) [20:54:25] (03CR) 10Jdlrobson: "@MaxSem ?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie) [20:54:33] bearND, dbrant, mhurd, bgerstle, coreyfloyd, kristenlans: Design review is cancelled this week. [20:54:39] k [20:54:47] bearND, dbrant, mhurd, bgerstle, coreyfloyd, kristenlans: It appears that once again my cancelling has not removed it from anyone else's calendar. [20:54:55] (03PS1) 10Yurik: TLS support [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/184995 [20:55:01] (03PS2) 10Jdlrobson: Fix some jsduck errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184980 (owner: 10Florianschmidtwelzow) [20:55:04] kristenlans: Can you update the title of the invite to say "Cancelled"? I can't any more because it's gone from my calendar. [20:55:16] (03CR) 10jenkins-bot: [V: 04-1] TLS support [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/184995 (owner: 10Yurik) [20:55:43] Deskana: can we do the Search patch meeting at that time, then? [20:56:12] dbrant: Ah, you have a clash. [20:56:29] dbrant: Yes, I'll move it. [20:56:47] thx! [20:57:19] FlorianSW: still seeing issues on http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/158952 :-/ [20:58:38] (03CR) 10Dbrant: [C: 04-1] "Looks quite good; one note inline, and also it seems like it doesn't automatically do a full-text search when there are zero prefix result" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184692 (owner: 10BearND) [20:59:01] Deskana: done [20:59:10] kristenlans: Thank you. [20:59:19] kristenlans: Could you release the room too, so I can steal it? [20:59:23] jdlrobson: beta labs running an older version of Thanks (https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FThanks.git/f2eab99bb83b44f53d7c5ff6b71302a295be1f47), the change was merged in commit 7a3d154447f3dc14f1ab60d1aa20d697d22d7e7b beta labs running f2eab99bb83b44f53d7c5ff6b71302a295be1f47 [20:59:24] :) [21:00:06] jdlrobson: a gap of 3 minutes :P [21:05:02] jdlrobson: Here’s the core change we were missing regarding ResourceLoaderImageModule: https://gerrit.wikimedia.org/r/#/c/183725/2/includes/resourceloader/ResourceLoaderImageModule.php . Looks like the issue is that we aren’t setting the type. [21:06:35] mhurd: hey, so i think this is actually a bug in the API [21:06:42] the account creation thing, i mean [21:06:47] contradictory to what the phab ticket says [21:06:57] legoktm: ping [21:07:26] bgerstle: What's your bug? [21:07:44] seeing an un-parsed PLURAL when account creation fails [21:09:30] jdlrobson: actually it looks like we are setting the type, so not sure why it would be failing there... [21:10:12] bgerstle: Well the Android handles it by looking at the error code given by the API then pulling a message from its own strings. [21:10:35] bgerstle: Either way, making it so that users can only submit requests if they've actually filled the form in, which is what the task is asking for, is still required. :-) [21:10:55] jdlrobson: Ah, it’s because we don’t have any variants defined. So it was purely just a bug in core. [21:12:55] bgerstle: http://pastebin.com/Z1EyGtf3 [21:12:58] Deskana i see, i just mentioned this to mhurd, but IME it's better to make the client-side end thin/dumb and do things as much on the back end as possible. but for now we can do a workaround [21:13:16] right [21:14:38] Deskana do you know where i can find the different error codes returned by the backend? [21:14:47] or should i just check the fields manually on the app for now? [21:15:00] bgerstle: https://www.mediawiki.org/wiki/API:Account_creation [21:15:28] hmm [21:15:37] bgerstle: And this is what we handle on Android: http://pastebin.com/3ktrFu2g [21:15:51] bgerstle: That most recent paste is specifically for account creation on Android [21:16:42] i see [21:16:53] who would be the contact in the API team to talk about doing localization there? [21:17:28] Brad Jorsch, I guess? [21:17:33] Ownership of lots of stuff is... unclear. [21:17:36] not that i would pursue i tnow [21:17:51] ok [21:20:01] mhurd/Deskana: this problem will still occur if the user submits a non-empty password that's too short. unless you want me to hard-code a password limit on the client :confounded: [21:20:34] bgerstle: how short? [21:20:44] Hold on, let's take a step back here. [21:21:04] We're talking about this bug, right? https://phabricator.wikimedia.org/T68944 [21:21:14] yep [21:21:31] So when you say "this problem", what are you referring to specifically? [21:22:07] on the client, the most i can do is check (before submitting) that the password is at least 1 character long [21:22:12] i.e. not empty [21:22:13] but, [21:22:23] if the user (foolishly) enters "a" as a password [21:22:27] the back-end will (hopefully) still fail [21:22:33] and it will use the passwordtooshort code [21:22:46] so i can just keep telling them the password is "too short" until they hit the magic number [21:22:57] or the back-end could tell us what the password requirements are [21:23:02] same for special character requirements, etc. [21:23:25] It should, yes! [21:23:35] But it doesn't, and the reality is that it's not going to any time soon. [21:24:02] Maryana: Clean-up needed on floor 3 [21:24:11] ok, just wanted to be clear about the expected behavior for the workaround [21:24:15] So, practically, we should add our own message telling the users that their password is "too short", and file a bug against the API. [21:24:21] ok [21:24:26] Great. :-) [21:25:08] mhurd/Deskana is there any possibility of easily reusing the translations from android? [21:25:24] since i'm guessing they'll be identical anyway [21:25:40] bgerstle: no we’ll need separate ones [21:26:04] i was going to duplicate the Android code-handling logic Deskana pasted earlier [21:26:23] where we return a string for a given MediaWiki-API-Error [21:26:40] (03CR) 10Fjalapeno: [C: 031] Update to latest upstream css. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184990 (owner: 10Mhurd) [21:26:48] bgerstle: hi [21:27:00] hey legoktm, i just mentioned you earlier because you were on the ticket [21:27:09] we haven't met. i'm the new iOS dev [21:27:14] bgerstle: you can look at the strings.xml file here to see what the exact strings are Android uses: https://github.com/wikimedia/apps-android-wikipedia/blob/master/wikipedia/res/values/strings.xml [21:27:20] o/ welcome! [21:27:25] thanks bearND (i'm guessing you're bernd?) [21:27:37] bgerstle: yes, that's correct [21:27:40] bgerstle: which bug is this? [21:27:41] cool [21:27:51] https://phabricator.wikimedia.org/T68944 [21:28:31] the bug that causes the API to show an un-parsed plural in account creation errors [21:29:52] legoktm what do you work on? [21:31:29] bgerstle: I'm part of the MediaWiki Core team and tend to work on core things, admin tools like CentralAuth / AbuseFilter and dabble a bit in everything else [21:31:52] ohhh [21:32:03] MediaWiki Core is… the API back-end? [21:32:11] * bgerstle still learning [21:34:00] core is whatever's in the mediawiki/core git repo :P [21:34:02] https://www.mediawiki.org/wiki/Core [21:34:04] DarTar: https://www.mediawiki.org/wiki/Wikimedia_Engineering/2014-15_Goals/Q3 [21:34:47] Maryana: you around? [21:34:57] kaldari: yep, i'm in re7 [21:34:58] err [21:35:01] r37 [21:35:04] ok [21:35:22] are you free or meeting or both? [21:35:27] legoktm do you have any read on how quickly this could get fixed? or whether or not we should bother w/ a client-side workaround? [21:35:39] since you can ship this much faster than we can (i'm guessing, since you don't have to deal w/ Apple :wink: ) [21:35:43] bgerstle: so when I looked at that bug the API returns an error code and a human formated info message, except the info message is English only and had a raw {{PLURAL}} string that is typically parsed by the message parser. So I was suggesting that the client should have it's own localized messages, see if the error code matches and display it's own messages. [21:36:07] legoktm while that's possible, IMHO it's less than ideal [21:36:26] we're at the crossroads where i need to duplicate the android translations, which themselves are a (i'm assuming) a workaround for this [21:36:41] legoktm sorry, i'm in another meeting right now.. maybe we can have a hangout afterward to discuss? [21:36:43] if you'll still be around [21:36:50] there's a bug somewhere for having the API return localized error messages however that's blocked on a bunch of other stuff [21:37:02] hm, ok [21:37:45] blocked due to constrained resources or because of dependencies? [21:38:47] likely both [21:40:03] k [21:40:24] legoktm at the very least, can we file this issue so it's not forgotten and have a way to follow up on it? [21:40:34] (against core, i mean) [21:42:00] bgerstle: it's https://phabricator.wikimedia.org/T37074 [21:42:16] ok, thanks [21:56:26] (03CR) 10BearND: [C: 04-1] Use Wikidata description returned by MobileView. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184987 (owner: 10Dbrant) [21:57:50] (03PS1) 10BearND: Set "stable" class to body tags [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185063 [21:57:52] (03PS1) 10BearND: Update styles from vagrant [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185064 [22:08:29] 3MediaWiki-User-login-and-signup, MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), Mobile-Web: Captcha positioning is inconsistent between JavaScript and non-JavaScript users - https://phabricator.wikimedia.org/T85192#977428 (10Jdlrobson) Impacts #Mobile-Web [22:09:13] Deskana I believe that the room shoudl be released now :-) [22:16:37] kristenlans: We have another health check?!!?! [22:16:46] jdlrobson: nope, app team [22:16:52] aahh that wasn't clear [22:16:58] oh yeh see subject now [22:17:11] mm that should become a convention [22:18:13] where is kaldari ? [22:22:11] bearND: Legal have signed off on Share a Fact! [22:22:27] Deskana: :) [22:22:28] bearND: They just have two minor things they want us to do, which I'm making a Phab task for now. [22:30:33] nuria: You back from lunch yet? [22:30:42] kaldari: yesssir [22:33:57] 3Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Address requests for Tweet a Fact from Legal - https://phabricator.wikimedia.org/T86843#977515 (10Deskana) [22:35:03] (03PS3) 10Mhurd: Navigation and Caching behavior changes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184970 (owner: 10Fjalapeno) [22:35:57] 3Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Address requests for Share a Fact from Legal - https://phabricator.wikimedia.org/T86843#977520 (10Deskana) [22:36:45] nuria: So there’s a bit of a complication with changing the MobileWebUIClickTracking… Since we just refactored that code, any changes that we made in master would not be pushable to the cluster, unless we push up all the dependant changes (which touches tons of files and would be rather risky). Dario mentioned that it might be possible to just blacklist one of the Schemas on the valadium end of things, i.e. not write [22:36:45] any events for MobileWebUIClickTracking to the tables even if they are still being logged in the raw logs. That would at least give us time to scale down our usage of EventLogging through the regular deployment cycle. Maryana said she would be file with dropping that data entirely for a temporary period. Is that a good idea for a short-term solution, or not workable? [22:37:23] yes, i'm ok with a dip in that data collection as long as our a/b test can go on :) [22:40:58] kaldari: i see. There is no blacklisting on the other though [22:42:08] nuria: What do you guys do if there is a sudden spike in one Schema that brings everything down? Does it always require a code deployment to fix? [22:42:54] kaldari: yes, this is happen (to my knowledge) twice before, one was a major bug, another a "bad" sample rate [22:43:15] nuria: understood. I’ll see what we can do on our end [22:43:24] You have my sign-off to also temporarily blacklist MobileWikiAppToCInteraction if that helps. [22:43:52] kaldari: but i also get what i was saying in our meeting: throttling is needed, i think i filed a backlog item for this ages ago [22:43:53] Deskana: Sounds like there isn’t a mechanism for doing a temp blacklist according to nuria [22:44:02] Eurgh [22:44:13] kaldari: lemme see, issue is enwiki right? [22:44:19] yes [22:44:46] kaldari: as other wikis are no issue, when do pageviews to enwiki start to drop down within a day? [22:45:01] kaldari: do you know? [22:45:15] I’m not sure. [22:48:15] kaldari: alarms just went down, which means that throughput lowered lemme see [22:48:42] kaldari: we might be able to survive just fine, teh other two times this happened throughput was >500 [22:48:45] sustained [22:48:53] and that is not the case now [22:49:23] kaldari: give me some time to look at rates and whether we are dropping events OK ? the many improvements we have done gotta have had some effect [22:49:25] nuria: We only have one window today to make a change (in 1 hour) and I’m not sure if we would be able to get anything ready by then anyway :P [22:49:50] kaldari: yam, i am really not fond of fast changes with unforseen consequences [22:50:00] i rather take the known consequences [22:51:06] kaldari: when do you think you could get your changes with confidence? [22:51:40] nuria: by the same window tomorrow I think (0:00 UTC, 4pm PST) [22:52:19] i.e. 25 hours from now [22:52:32] ok, going with my experience it is not worth it to fast deploy changes to a tier-1 service (main website) to fix a tier-2 service (EL) [22:53:24] kaldari: so let's try for tomorrow and, in the meantime, i will see whether we dropped events Ok? [22:53:33] kaldari: makes sense? [22:54:00] nuria: sounds like a plan :) [22:54:13] kaldari: ok, will let you know. [22:54:38] cc Deskana (please read log) [22:54:55] (03PS6) 10BearND: Combine title and full text search [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184692 [22:55:30] thanks nuria! [22:55:39] np [22:55:40] Deskana: let's use the update patch ^ for the search eval [22:55:51] bearND: Roger. [22:57:56] Anyone know if the today's design meeting at 3pm is cancelled? [23:01:30] bearND: hey [23:01:33] bearND: you there [23:01:33] (03CR) 10Aaron Schulz: [C: 031] MWException -> Exception [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/184062 (owner: 10Ori.livneh) [23:01:42] dbrant|brb: https://github.com/aldenml [23:01:43] moizsyed_: on my way [23:02:31] moizsyed_: there is no design review today. Instead we're doing the search-patch review [23:02:44] moizsyed_: I'm the first on in the meeting [23:03:21] thanks [23:03:31] bearND: oh what room is that review? [23:03:52] bearND: Deskana: be there in a few [23:04:38] moizsyed: i think it's in R33 [23:07:34] (03PS2) 10Mhurd: Hook up lead image Wikidata descriptions! [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184988 [23:08:17] dr0ptp4kt: couple small patches in the q if you have a minute later [23:13:36] (03PS4) 10Bmansurov: Represent main menu as a View incorporated in Skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) [23:37:14] 3Mobile-Web: Update Schema:MobileWebWikiGrokError now that WikiGrok has changed - https://phabricator.wikimedia.org/T86855#977738 (10bmansurov) 3NEW [23:44:41] (03CR) 10Jdlrobson: Represent main menu as a View incorporated in Skin (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) (owner: 10Bmansurov) [23:44:48] (03PS4) 10Fjalapeno: Navigation and Caching behavior changes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184970 [23:45:32] 3Mobile-Web, MediaWiki-extensions-Thanks: Thanks button not loading on mobile - https://phabricator.wikimedia.org/T77929#977799 (10Jdlrobson) 5Open>3Resolved Loading on beta labs again. [23:45:59] 3Mobile-Web, MediaWiki-extensions-Thanks: Thanks is broken again (Mobile Thanks needs qunit tests) - https://phabricator.wikimedia.org/T86687#977802 (10Jdlrobson) This is fixed on beta labs but let's add a test to the #Thanks extension before calling this done. [23:46:50] 3Mobile-Web, MediaWiki-extensions-Thanks: Thanks is broken again (Mobile Thanks needs qunit tests) - https://phabricator.wikimedia.org/T86687#977805 (10Jdlrobson) a:3Jdlrobson [23:49:42] (03CR) 10Bmansurov: Represent main menu as a View incorporated in Skin (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) (owner: 10Bmansurov) [23:55:38] (03CR) 10Jdlrobson: Represent main menu as a View incorporated in Skin (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) (owner: 10Bmansurov) [23:56:11] (03CR) 10Deskana: [C: 031] Combine title and full text search [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184692 (owner: 10BearND) [23:57:35] 3Mobile-Web: Formatting of Thanks step is different in WikiGrok A and B - https://phabricator.wikimedia.org/T86613#977830 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [23:59:49] (03CR) 10Kaldari: Hygiene: Introduce ForeignApi (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson)