[00:04:19] 3Mobile-Web, MediaWiki-extensions-Thanks: Thanks button not loading on mobile - https://phabricator.wikimedia.org/T77929#977855 (10Florian) Yes, but it should be backported i think. Its now in production and wmf15 was branched before the merge of this (if i'm right, haven't checked from mobile phone), so the nex... [00:06:57] 3Mobile-Web, MediaWiki-extensions-Thanks: Thanks button not loading on mobile - https://phabricator.wikimedia.org/T77929#977866 (10Jdlrobson) Agreed @Florian can you mail mobile-l with subject "Lightning deploy needed" with the details to make sure we get this scheduled? Thanks dude! :-) [00:09:23] 3Mobile-Web, MediaWiki-extensions-Thanks: Thanks button not loading on mobile - https://phabricator.wikimedia.org/T77929#977893 (10Jdlrobson) Seems @Kaldari is SWAt deploying it now :) [00:10:21] (03CR) 10Kaldari: Hygiene: Introduce ForeignApi (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [00:11:44] kaldari: events are being logged again in qunit :( [00:11:44] widget-impression-success [00:11:49] i assume that's your doing [00:11:58] it could lead to breakages again due to unfinished async tests [00:12:11] oops [00:13:47] jdlrobson: how do you avoid that? just stub functions that do logging? [00:14:47] kaldari: yup we stub the logging functions [00:14:50] i can do that now [00:14:53] since i'm in that code [00:15:01] but would be great if you could merge sooner rather than later [00:15:26] 3Wikipedia-App-Android-App: 'Tap here to expand' - the label - https://phabricator.wikimedia.org/T86860#977968 (10Etonkovidova) [00:17:17] jdlrobson: sure, I can merge it today [00:18:36] mhurd: i can confirm that crash on edit [00:18:37] got a handle on it or shall i debug it? [00:18:37] (03CR) 10Jdlrobson: [C: 04-1] "Yeh the roulette code looks like it needs cleaning up but looks like it is actually needed in current form" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184963 (owner: 10Florianschmidtwelzow) [00:19:15] (03CR) 10Jdlrobson: [C: 032] Fix some jsduck errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184980 (owner: 10Florianschmidtwelzow) [00:19:24] brion: if you have a few cycles to spare that would be cool! :) [00:19:35] ok. lldb begin! [00:19:47] 3Wikipedia-App-Android-App: Expanding the references makes the "Read more" section invisible until you scroll - https://phabricator.wikimedia.org/T86861#977998 (10Deskana) 3NEW [00:20:11] (03PS6) 10Jdlrobson: Add "add discussion" button to talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182397 (https://bugzilla.wikimedia.org/70614) (owner: 10Florianschmidtwelzow) [00:20:15] brion: woohoo! [00:20:36] (03Merged) 10jenkins-bot: Fix some jsduck errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184980 (owner: 10Florianschmidtwelzow) [00:23:08] (03CR) 10Jdlrobson: [C: 04-1] "Looks good but some minor issues." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182397 (https://bugzilla.wikimedia.org/70614) (owner: 10Florianschmidtwelzow) [00:25:20] (03CR) 10Jdlrobson: "(Also you probably want to show the LoadingOverlay pre reload as it looks like the save didn't work and it is not clear a redirect is happ" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182397 (https://bugzilla.wikimedia.org/70614) (owner: 10Florianschmidtwelzow) [00:26:56] hm. first bug was easy, but it uncovered a second bug :D [00:28:01] aha found it [00:28:53] 3Wikipedia-App-Android-App: 'Tap here to expand' - the label should change when the section is expanded? - https://phabricator.wikimedia.org/T86860#978058 (10Etonkovidova) [00:29:20] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Update to latest upstream css. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184990 (owner: 10Mhurd) [00:29:47] ah think i found it [00:31:40] 3Wikipedia-App-Android-App: 'Tap here to expand' - the label should change when the section is expanded? - https://phabricator.wikimedia.org/T86860#978097 (10Etonkovidova) {F28670} [00:35:41] bmansurov: Any chance you can +2 this so that we don’t run into any merge conflicts from the WikiGrok C work: https://gerrit.wikimedia.org/r/#/c/184000/ [00:35:54] kaldari: ok let me see [00:37:49] (03CR) 10Bmansurov: [C: 032] Revising WikiGrok loading conditions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184000 (owner: 10Kaldari) [00:40:15] (03PS1) 10Brion VIBBER: Fix broken section edit [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185100 [00:43:16] (03Merged) 10jenkins-bot: Revising WikiGrok loading conditions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184000 (owner: 10Kaldari) [00:44:03] (03PS3) 10Dr0ptp4kt: Hook up lead image Wikidata descriptions! [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184988 (owner: 10Mhurd) [00:44:08] 3Mobile-Web, MediaWiki-extensions-Thanks: Thanks is broken again (Mobile Thanks needs qunit tests) - https://phabricator.wikimedia.org/T86687#978191 (10Jdlrobson) @MattFlaschen thanks to @hashar Thanks tests should run in MobileFrontend now on every commit so this https://gerrit.wikimedia.org/r/185093 qunit test... [00:44:17] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Hook up lead image Wikidata descriptions! [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184988 (owner: 10Mhurd) [00:45:52] 3Mobile-Web, MediaWiki-extensions-Thanks: Thanks is broken again (Mobile Thanks needs qunit tests) - https://phabricator.wikimedia.org/T86687#978197 (10Mattflaschen) >>! In T86687#978191, @Jdlrobson wrote: > @MattFlaschen thanks to @hashar Thanks tests should run in MobileFrontend now on every commit so this htt... [00:48:20] ergg is there is anyway to make qunit tests fail if you make an xhr request [00:49:32] maybe Krinkle knows ^ ? [00:50:52] jdlrobson: Why would you want to do that? [00:51:03] jdlrobson: If you use sinon mock, you can do whatever you want when an XHR is created. [00:51:10] see mediawiki.api.test in core [00:51:20] mediawiki.api.parse.test.js [00:51:48] inside the test, listen for xhrs and use the local scope assert object to make a fail [00:51:50] or throw [00:51:59] (well, can't throw) [00:52:16] actually, can throw! [00:52:19] mock is sync [00:52:45] Krinkle: yeh i'm aware of that but tests keep sneaking in that cause ajax requests [00:52:50] and don't cause the tests to fail [00:53:21] I just notice about 2 api requests due to bad tests getting merged. I was just wondering if there was any way to do a global test e.g. if you use $.ajax directly = FAIL [00:54:08] bearND: were you kicking off full text search if fewer than 6 prefix results? [00:54:55] mhurd: yes [00:55:35] mhurd: what's iOS doing wrt search? Do you have buttons for prefix and full text search? [00:55:45] jdlrobson: $.ajax should not be disallowed. [00:56:00] mediawiki.api.test internally uses that [00:56:03] the mock doesn't change that [00:56:26] jdlrobson: I don't know, other than to refer to code review and respond to issues as they happen. [00:56:34] Krinkle: yeh :-/ [00:56:35] bearND: no those were removed. i made the ios app do same supplemental-with-fulltext-results during the meeting earlier [00:56:38] that's what i figured [00:56:47] Krinkle: i'm just writing a patch to stop our qunit tests from hitting the api to get a random article and about 6 events being logged through EventLogging [00:56:55] bearND: had already unified the layouts [00:57:11] jdlrobson: The events are hitting production? [00:57:23] mhurd: ah, so you're ahead of us wrt search [00:57:39] Krinkle: i don't think EventLogging extension is installed for Jenkins jobs so they shouldn't be [00:57:44] k [00:57:51] but it's a possibility if someone set up the extension [00:58:31] mhurd: do you do it the same way my patch does it? prefix for first batch, the full text? what's the batch size? [00:58:33] bearND: no it wasn’t automatically doing the full text unless there were zero prefix results. now it does the same appending behavior [00:58:36] jdlrobson: It still shouldn't hit production. [00:58:50] (03PS1) 10Jdlrobson: Don't do API requests in QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185107 [00:58:51] jdlrobson: Why would anyone configure local EventLogging to point to bits? That has no purpose at all. [00:58:54] bearND: same, but i haven’t adjusted batch size yet [00:58:59] brb [01:00:51] mhurd: what's your current batch size? I think 15 would be great for caching since that's what MFE uses. I was just doing 20 for now since I didn't want to add a conditional for screen size (e.g. if can show > 15 results at a time, request x; else 15) [01:01:36] There are some Android devices that could show 16 [01:01:44] in portrait mode [01:02:09] bearND: checking... [01:02:25] either way, i think the old value of 12 was too low [01:02:55] bearND: whoa set to 24 on ios - i think that’s because we haven’t hooked up any query-continue stuffs [01:03:01] jdlrobson: I'm confused, that test looks very suspicous. [01:03:23] jdlrobson: Making api() respond empty seems like it should fail the test, or the test is wrong. [01:03:34] mhurd: I could go for 24 [01:03:34] Clearly the data is irrelevant. [01:03:41] jdlrobson: Wait, this is doing a visual etest of display=none? [01:03:44] How is that a unit test? [01:04:23] yeh that's also a good point. I hadn't noticed that. [01:05:58] bearND: maxsem says if you bump to 24 there shouldn’t be caching problems, but to keep in mind the results will take a bit longer to download because more data [01:06:33] (03PS2) 10Mhurd: Fix broken section edit [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185100 (owner: 10Brion VIBBER) [01:06:34] mhurd: would there be with 20? [01:06:55] bearND: i don’t think so [01:07:13] ah, good [01:07:17] bearND: according to what maxsem said. caching-wise anyway [01:07:30] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185100 (owner: 10Brion VIBBER) [01:08:07] (03CR) 10Jdlrobson: [C: 04-2] "Marking as -2 until dependency is merged." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie) [01:08:51] kaldari: https://gerrit.wikimedia.org/r/#/c/184811/1/javascripts/modules/infobox/Infobox.js you know more about i18n stuff [01:08:58] but i'm guessing this doesn't work right? [01:12:14] (03CR) 10Jdlrobson: [C: 032] "I stand corrected. We use futureLog for that now and yes agreed we shouldn't encourage this kind of thing as it slows down user experience" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184280 (owner: 10Ori.livneh) [01:13:34] (03Merged) 10jenkins-bot: Don't return a value from Schema.log [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184280 (owner: 10Ori.livneh) [01:27:04] 3UI-Standardization, Mobile-Web: OOjs UI uses different class names to mobile - leads to duplicate CSS - https://phabricator.wikimedia.org/T66973#978364 (10Jdforrester-WMF) p:5Triage>3Normal [01:29:53] (03CR) 10Kaldari: [C: 04-1] User friendly dates for wikidata infobox (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960) (owner: 10Bmansurov) [01:32:06] kaldari: so in ^ changing january to january-date will fix the problem? [01:32:17] or is there anything else? [01:33:02] bmansurov: I think that’s the best we can do currently [01:33:15] ok thanks [01:34:00] bmansurov: That will at least make the date+month part be formatted correctly for each language. [01:34:45] kaldari: sounds good [01:35:04] (03CR) 10MaxSem: [C: 04-1] "This should take precision into account, for example Darius the Great has only years of life. Also," [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960) (owner: 10Bmansurov) [01:36:00] (03PS5) 10Bmansurov: Represent main menu as a View incorporated in Skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) [01:38:03] (03CR) 10jenkins-bot: [V: 04-1] Represent main menu as a View incorporated in Skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) (owner: 10Bmansurov) [01:39:00] (03PS6) 10Bmansurov: Represent main menu as a View incorporated in Skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) [01:45:47] (03CR) 10Anomie: "Which dependency is that?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie) [01:54:06] (03PS1) 10Jdlrobson: Fix rendering issues with infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185111 [02:19:03] (03PS2) 10Bmansurov: User friendly dates for wikidata infobox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960) [02:21:09] (03PS1) 10Jdlrobson: New alpha infobox types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185114 [02:23:34] (03CR) 10Jdlrobson: [C: 031] "so... seems like a minor argument. Can we get this merged? Keen to demo it at dev summit." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [04:42:08] (03PS1) 10Mhurd: Seamlessly supplement prefix search results with full text results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185124 [07:23:19] 3Mobile-Web, MediaWiki-extensions-Thanks: Thanks button not loading on mobile - https://phabricator.wikimedia.org/T77929#978812 (10Florian) >>! In T77929#977893, @Jdlrobson wrote: > Seems @Kaldari is SWAt deploying it now :) Oh, great, thanks @kaldari :) [08:24:23] 3Mobile-Web, MediaWiki-extensions-Thanks: Thanks is broken again (Mobile Thanks needs qunit tests) - https://phabricator.wikimedia.org/T86687#978881 (10hashar) The job @Jdlrobson mentions is a shared one between mobile extensions but it is not including Thanks yet and it is only for the PHPUnit tests (not the qu... [08:24:53] (03CR) 10Florianschmidtwelzow: Add "add discussion" button to talk pages (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182397 (https://bugzilla.wikimedia.org/70614) (owner: 10Florianschmidtwelzow) [08:39:12] 3Analytics, Wikipedia-App-iOS-App, Language-Engineering, Wikipedia-App-Android-App, Mobile-Apps, MediaWiki-extensions-UniversalLanguageSelector, Mobile-Web: there should be a comparison of clicks count on interlanguage on different platforms - https://phabricator.wikimedia.org/T78351#978890 (10Amire80) [08:42:21] (03PS7) 10Florianschmidtwelzow: Add "add discussion" button to talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182397 (https://bugzilla.wikimedia.org/70614) [08:44:31] morning! [08:48:00] 3Analytics, Wikipedia-App-iOS-App, Language-Engineering, Wikipedia-App-Android-App, Mobile-Apps, MediaWiki-extensions-UniversalLanguageSelector, Mobile-Web: there should be a comparison of clicks count on interlanguage on different platforms - https://phabricator.wikimedia.org/T78351#978902 (10Amire80) [08:48:18] 3Analytics, Wikipedia-App-iOS-App, Language-Engineering, Wikipedia-App-Android-App, Mobile-Apps, MediaWiki-extensions-UniversalLanguageSelector, Mobile-Web: there should be a comparison of clicks count on interlanguage on different platforms - https://phabricator.wikimedia.org/T78351#843122 (10Amire80) [09:03:50] (03PS2) 10Florianschmidtwelzow: Hygiene: Load wikiRoulette only when needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184963 [09:14:46] 3Mobile-Web, MediaWiki-extensions-Thanks: Thanks is broken again (Mobile Thanks needs qunit tests) - https://phabricator.wikimedia.org/T86687#978943 (10hashar) So I crafted a patch ( https://gerrit.wikimedia.org/r/#/c/185132/ ) which let one run on an extension patch 'check experimental'. That injects that exte... [09:21:00] good morning phuedx & joakino [09:21:26] phuedx: joakino: will you be in SF next week? If so we should shake our hands, looking forward to meet some european folks [09:24:09] hashar: yeap, we will arrive on tuesday [09:24:11] and you? [09:24:16] Monday [09:24:39] there is a pub inside the hotel [09:24:52] so we will probably have some beers there in the evening [09:25:20] cool, but we wont be there :P [09:25:22] haha [09:26:24] and if you need a data plan for your mobile, there is a T-mobile shop next to the hotel [09:27:47] cool, thx hashar [09:27:50] which one do you get [09:55:39] 3Mobile-Web, MediaWiki-extensions-Thanks: Thanks is broken again (Mobile Thanks needs qunit tests) - https://phabricator.wikimedia.org/T86687#978961 (10hashar) So the last check of Thanks https://gerrit.wikimedia.org/r/#/c/55136/5/ is working: ``` mediawiki-extensions-hhvm SUCCESS in 26s mediawiki-extensions-ze... [09:55:56] 3Mobile-Web, Continuous-Integration, MediaWiki-extensions-Thanks: Thanks is broken again (Mobile Thanks needs qunit tests) - https://phabricator.wikimedia.org/T86687#978962 (10hashar) [09:56:09] 3Mobile-Web, Continuous-Integration, MediaWiki-extensions-Thanks: Thanks is broken again (Mobile Thanks needs qunit tests) - https://phabricator.wikimedia.org/T86687#978963 (10hashar) p:5Triage>3High [09:59:50] morning all [09:59:55] morning joakino, hashar [10:00:23] hashar: yeah, beer in the hotel + hellos sounds good [10:00:29] :-) [10:51:44] 3Mobile-Web, Continuous-Integration, MediaWiki-extensions-Thanks: Thanks is broken again (Mobile Thanks needs qunit tests) - https://phabricator.wikimedia.org/T86687#979129 (10hashar) I think that is solved, would let you close this task though. Adding a qunit job for thanks is {T86866}. [11:11:58] brb gonna reboot [11:20:17] back [11:20:17] that was interesting [11:20:29] fan span up to lift-off mode when i restarted [11:22:09] phuedx: yosemite? [11:22:36] joakino: yarrrp [11:22:50] i'm still on mavericks [11:22:52] i'm too afraid [11:23:04] join us [11:23:12] and hate your network connectivity ever more! [11:29:27] i've been awake since 4 am [11:33:53] (03PS10) 10Jhernandez: Hygiene: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [11:34:05] phuedx: why? [11:34:11] (03CR) 10Jhernandez: "Fixed comments." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [11:34:18] george isn't well [11:34:42] phuedx: oh! what is it? [11:34:50] common cold [11:34:59] he had a virus at the end of last week [11:35:02] so :( [11:36:49] (03CR) 10Jhernandez: "@jdlrobson comment?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [11:37:06] phuedx: hope he gets better [11:37:08] baby ok? [11:37:41] yeah, harry's fine [11:37:45] but he wakes up at 2 [11:37:46] ;) [11:38:01] lol [11:39:03] (03PS14) 10Jhernandez: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [12:11:58] (03CR) 10Phuedx: [C: 04-1] "I'm not convinced this is a positive change. I agree that this should be made more efficient (not loading WikiGrok Roulette all the time) " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184963 (owner: 10Florianschmidtwelzow) [12:27:26] (03CR) 10Phuedx: [C: 032] Don't do API requests in QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185107 (owner: 10Jdlrobson) [12:28:04] breaking for lunch [12:30:46] (03Merged) 10jenkins-bot: Don't do API requests in QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185107 (owner: 10Jdlrobson) [13:11:41] (03PS1) 10Jhernandez: Improve wikidata infobox style and template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185164 [13:13:02] (03CR) 10Jhernandez: "@jdlrobson I've improved the styling, more attractive demos always catch on better." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185164 (owner: 10Jhernandez) [15:05:40] (03CR) 10Phuedx: [C: 031] "+1 because this works but see inline for a few suggestions." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185111 (owner: 10Jdlrobson) [15:50:44] (03PS1) 10Bgerstle: use client-side localized account err descriptions [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185189 [15:51:40] coreyfloyd: trade ya one code review for one code review or other favor :wink: [15:52:53] (03CR) 10Phuedx: [C: 032] New alpha infobox types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185114 (owner: 10Jdlrobson) [15:53:58] hm, looks like there's some diff w/ some CSS files [15:54:03] i thought i fixed that during rebase [15:54:08] lemme try again [15:55:46] (03PS1) 10Bgerstle: add localized account creation error msgs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 [15:56:48] (03Abandoned) 10Bgerstle: use client-side localized account err descriptions [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185189 (owner: 10Bgerstle) [15:57:15] missing github already :disappointed: [15:58:50] you get used to it [15:58:58] watching github pull requests from afar [15:59:00] (03PS5) 10Fjalapeno: Navigation and Caching behavior changes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184970 [15:59:44] phuedx yeah, but this dance of abandoning changesets and such [16:00:00] was much simpler to just force-push to my PR if i needed to split changes into a separate PR [16:00:16] or even just add another commit that reverted the necessary changes [16:00:28] here i need to do the work, squash, push another change-set, add reviewers, etc. [16:00:46] all the conversation/comments (afaik) are lost between change-sets too [16:01:42] bgerstle: yeah - I'll take a look now - do you mine building and testing mine? Monte was able to break it yesterday. [16:01:50] yeah, sure [16:01:55] LTFL? [16:02:57] ? [16:06:26] sorry, coreyfloyd link-for-the-lazy [16:09:35] coreyfloyd is it this one? https://gerrit.wikimedia.org/r/#/c/184970/ [16:11:12] (03CR) 10Fjalapeno: "looks good, but there was a typo in the interfaceOrientation method." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 (owner: 10Bgerstle) [16:11:57] bgerstle: yeah that is it [16:12:06] k [16:12:53] coreyfloyd damnit man i'm a programmer not a writer! [16:13:06] aint nobody got time for proper spelling [16:13:52] lol [16:14:20] oh, also that's not my typo, so not my problem :wink: (j/k) [16:15:09] that's actually really bad, because not only was it not being called, we weren't even calling super [16:15:13] :confounded: [16:15:28] mo coding mo problems [16:15:43] that method's deprecated in iOS 8 anyway [16:28:00] coreyfloyd: bgerstle: are you using git-review? that lets you rewrite commits/rebase branches, and push a bunch of commits on the same patch, it adds a new patchset on the same gerrit url, so all comments and history of the commit is there [16:28:20] joakino we were told that multiple patch sets is confusing [16:28:30] but i'll give it a shot [16:28:36] bgerstle: indeed sometimes it is [16:28:56] joakino i guess we were told specifically if we rebase it mucks everything up [16:29:02] does rebasing through git-review help? [16:29:11] one good thing is that you can compare patchsets and see what has changed between them (one bad thing is that rebased changes show there too) [16:29:20] right :-/ [16:30:10] bgerstle: i think so, one thing i do is pull the latest commit/patch from a branch i have (git review -d xXXX) then I git rebase, change the commits as I please, and then git review, so it sends all the patches updated [16:30:16] joakino: yeah I am a little confused about what is the typical gerrit workflow - never used it before - just actually posted that to the mobile tech group - would like to see someone show us the ropes on how they use it [16:30:57] coreyfloyd: bgerstle i've been here just a few months, still getting used to it. it may improve once phabricator code review is set up [16:31:01] joakino yeah, i just don't like how much incidental complexity gerrit comes with [16:31:10] github is great because it follows whatever git conventions you want [16:31:20] gerrit adds all this other stuff you need to learn [16:31:23] bgerstle: are you a clojurist? [16:31:32] joakino an aspring one :wink: [16:31:47] bgerstle: agreed, with gerrit you work gerrit, not git [16:31:52] also an aspiring haskellier (haskellist? hask-o-naut?) [16:31:53] cool :D [16:32:14] joakino i'm guessing you saw my response to the code coverage thread? [16:32:34] bgerstle: yep haha [16:32:38] nice [16:38:00] lol http://www.quickmeme.com/img/fd/fd118a86d4102f0057d218163365945a3b3ad8c5fa38daaaaa79964d86b271a7.jpg [16:45:24] (03CR) 10Fjalapeno: [C: 031] "Left a couple comments - nothing stopping it. Mostly for my benefit." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185124 (owner: 10Mhurd) [16:48:33] In case anybody hates somebody: http://shipyourenemiesglitter.com [16:49:47] hahaha [16:49:49] that's awesome [16:50:01] joakino lol [16:50:09] NOW WHAT?! [16:50:32] i'd probably just say "ok, been nice talking with you..." [16:51:15] the glitter thing is awesome hahha [16:51:51] bgerstle: we'll mull over stuff with a bear in hand in a few days, i like pl talk [16:51:59] oh shi, * beer [16:52:08] * joakino hides [16:52:57] was gonna say… live dangerously much? [16:53:14] :bear: [16:53:29] if i drew, i'd make a nice comic strip from that one [16:58:39] incidentally, there's a comic strip called "bear in mind" [16:59:28] (03PS2) 10Bgerstle: add localized account creation error msgs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 [16:59:45] bgerstle: haskellier +1 [16:59:55] w00t [17:00:17] my favourite so far is rust: oxidizer [17:00:18] is there already a fn'l programming and/or haskell group of mediawiki employees? [17:00:26] also rustacean [17:00:29] hahaha [17:00:37] rustacean's good [17:00:54] what would an OCaml dev be..? [17:01:03] bgerstle: not sure if there's a group [17:01:07] scalamatician? [17:01:17] F-sharpist [17:01:22] but i'm an enthusiastic amateur [17:01:36] phuedx i'm still chipping away at LYAHFGG [17:01:43] ^ that [17:01:44] and codewars katas [17:01:49] also, programming haskell [17:01:57] ? [17:02:02] the book [17:02:04] not Real World Haskell [17:02:11] sorry [17:02:16] programming _in_ haskell [17:02:26] * phuedx doesn't reach for haskell when solving problems [17:02:36] (03CR) 10Fjalapeno: [C: 031] add localized account creation error msgs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 (owner: 10Bgerstle) [17:02:47] ^ that's why i remain an enthusiastic amateur [17:02:53] yeah [17:03:00] phuedx you follow thoughtbot and/or well-typed? [17:03:12] the former, not the latter [17:03:13] * phuedx googles [17:03:18] well-typed is a haskell consultancy [17:03:23] and they blog stuff too [17:03:40] coreyfloyd :beers: [17:03:48] i'll check yours out now [17:04:06] coreyfloyd whaddya think of that #if __IPHONE_OS_MIN_VERSION < … ? [17:04:21] hadn't thought to do that before, but makes a lot of since IMO [17:04:51] i.e. when we drop iOS 7, we automatically get a bunch of warnings (and errors if we're already that savvy) to clean out code that has turned to cruft [17:09:25] (03CR) 10Legoktm: [C: 04-1] add localized account creation error msgs (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 (owner: 10Bgerstle) [17:11:18] (03PS3) 10Bgerstle: add localized account creation error msgs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 (https://phabricator.wikimedia.org/T66944) [17:11:24] bgerstle: its cool - when we drop iOS 7, we'll still have to do a search for didRotateFromInterfaceOrientation: on the whole code base - but its nice to have a reminder in there once. [17:11:33] legoktm amended commit message :point_up: [17:11:52] coreyfloyd yeah, i guess we'll just search for deprecated warnings [17:11:56] (once we enable them) [17:12:06] bgerstle: I think the number is wrong now? [17:12:14] legoktm :confused: [17:12:26] indeed faulty assumption [17:12:35] bugzilla numbers != phab numbers [17:12:42] you have add 2000 [17:12:58] bug 1 --> T2001 [17:13:31] oh is ee, n/m [17:13:40] it's 68944 not 66944 [17:13:43] not sure where that typo happened [17:13:57] legoktm i just grabbed it from the resource ID in the URL [17:14:21] so for https://phabricator.wikimedia.org/T68944 [17:14:25] it should be T68944 [17:14:37] and the ref is bz6944 [17:14:41] 66944* [17:14:53] (hence the added 2000 in the "T notation") [17:15:21] (03PS4) 10Bgerstle: add localized account creation error msgs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 (https://phabricator.wikimedia.org/T68944) [17:15:47] :point_up: seems fixed now [17:15:53] ah and phabricator was updated :tada: [17:17:09] i'm guessing github also has webhooks for phab? :wink: :wink: [17:18:14] so coreyfloyd.. how do i "check out" your changes? [17:18:26] * bgerstle implicit rant about gerrit, again [17:19:43] i think i figured it ou [17:20:08] dbrant: Good morning! How goes the release? [17:20:42] Deskana: great! just finishing some final sanity checking. [17:20:53] dbrant: Excellent. Need anything from me? [17:21:12] Deskana: updated play store description? [17:21:36] \o [17:21:55] dbrant: Sure! [17:21:57] * Deskana writes [17:22:45] (03CR) 10Legoktm: add localized account creation error msgs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 (https://phabricator.wikimedia.org/T68944) (owner: 10Bgerstle) [17:23:21] Deskana: and who will send the note to mobile-l? [I've started drafting it] [17:23:58] dbrant: Go for it! [17:24:03] rgr [17:24:58] 3Continuous-Integration, Mobile-Web, MediaWiki-extensions-Thanks: Thanks is broken again (Mobile Thanks needs qunit tests) - https://phabricator.wikimedia.org/T86687#979821 (10Jdlrobson) Thanks @hashar Yup so once https://gerrit.wikimedia.org/r/#/c/185093/ is fixed than Thanks will have its first QUnit test. T... [17:25:54] (03CR) 10Mhurd: [C: 04-1] add localized account creation error msgs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 (https://phabricator.wikimedia.org/T68944) (owner: 10Bgerstle) [17:26:18] d'oh [17:27:00] mhurd what'd i do? [17:28:03] (03PS2) 10Jdlrobson: New alpha infobox types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185114 [17:28:04] coreyfloyd yikes this code is not easy to reason about [17:28:12] (03CR) 10Jdlrobson: [C: 032] "can safely be cherry picked" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185114 (owner: 10Jdlrobson) [17:28:20] dbrant: http://pastebin.com/Q1LgL5Uf [17:28:40] bgerstle: Monte's not on IRC right now and I'm kind of surprised he gave you a -1 with no explanation. :-) [17:28:43] Deskana: nice! thx [17:28:56] yeah [17:29:05] bgerstle: I did notice this in the qqq: "create_account_ip_throttle_error" = "MISSING DESCRIPTION; DO NOT COMMIT FILE YET"; [17:29:09] bgerstle: That should be fixed. :-) [17:29:16] just NO http://www.freeallimages.com/wp-content/uploads/2014/09/grumpy-cat-no-1.jpg [17:29:21] (03PS2) 10Jhernandez: Fix rendering issues with infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185111 (owner: 10Jdlrobson) [17:29:30] Deskana hrm, i just copied it from android, soo... [17:29:34] might need to file an issue there too ;-) [17:29:49] (03CR) 10Jhernandez: [C: 031] "Addressed comments, its a +2 to me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185111 (owner: 10Jdlrobson) [17:29:50] Hah. [17:29:52] joakino: woah nice job on the infobox [17:29:56] it might be valid in other languages, but not updated in qqq yet [17:30:00] lemme grep and get back to you [17:30:21] jdlrobson: :D, will have to merge template with the other patches but looks cool [17:30:35] joakino: we can merge separately [17:30:45] bgerstle: Ordinarily we wouldn't add the translations manually because they'll be overwritten by translatewiki updates but this could well be the one time that we want to do that since we already have translations on Android. [17:30:47] (03Merged) 10jenkins-bot: New alpha infobox types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185114 (owner: 10Jdlrobson) [17:30:55] as you know by now i like small patches very much in the github school of thought [17:31:05] to me commit histories are like neverending stories [17:31:37] (03CR) 10Deskana: [C: 04-1] "There are three messages in the qqq that need proper descriptions before this can be merged." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 (https://phabricator.wikimedia.org/T68944) (owner: 10Bgerstle) [17:31:39] (03CR) 10Jdlrobson: [C: 032] "huge improvement :-)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185164 (owner: 10Jhernandez) [17:31:40] Deskana that was my reasoning [17:31:54] ah, well there ya go [17:32:00] oh n/m that was you [17:32:01] joakino: next step i want to do is make the editing inline e.g. not via an overlay [17:32:16] Deskana although i wondered if there was a way to update Localized.strings from translate wiki? [17:32:26] we really need to work out how the overlayManager can be used for inline views [17:32:31] jdlrobson: seems doable [17:32:32] @bgerstle we were on a hangout - it actually was scrolling on pages it shoudlnt be [17:32:40] jdlrobson: also giving to wikidata-infobox margin: 0 1em looks good too, if you want to see it http://i.imgur.com/wwAOPfn.png [17:32:42] ok [17:32:44] joakino, jdlrobson: kicking the tyres on that patch (again) now [17:33:00] joakino: it all looks amazing to me :) [17:33:11] jdlrobson: github doesn't enforce small patches, sane developers do ;) [17:33:12] joakino: i think when we have inline editing that's the real win because you can refer to the article easily before editing [17:33:16] jdlrobson: OverlayManager.replaceCurrent ? [17:33:26] phuedx: thank you. i like you. I'm in an office where people give me a hard time for it [17:33:31] bgerstle: if you do some browsing around check and make sure that it doesn't scroll on pages that should load scrolled to the top [17:33:33] it's just what comes normal to me [17:33:37] or what you mean? [17:33:47] FlorianSW: Nearby JS is a good example [17:33:53] it's not an overlay [17:33:58] Deskana FYI there are translations for create_account_ip_throttle_error, so it seems qqq just needs to have an updated description. will add one now [17:33:59] but needs to be managed similarly [17:34:02] jdlrobson: so in the value cell, substitute it with the input lookup field, and change the edit button for a save one maybe? [17:34:06] the overlay manager assumes only one overlay can be visible at a time [17:34:07] coreyfloyd ok [17:34:18] coreyfloyd SORRY IT'S GETTING LOUD IN HERE [17:34:30] maybe we need a super special #wikimedia-ios channel [17:34:31] joakino: i was imagining when you click edit it would turn everything into editable fields [17:34:43] i still think it helps clarifying you are in reader mode / editor mode. [17:34:49] bgerstle: LOUD NOISES! :D [17:34:55] jdlrobson: and to save? swap the edit button with the save one? [17:35:05] *when you are editing [17:35:06] joakino: exactly [17:35:17] jdlrobson: http://s3-ec.buzzfed.com/static/enhanced/web04/2012/7/16/10/anigif_enhanced-buzz-11635-1342448084-11.gif [17:35:23] bgerstle: :) [17:35:29] http://localhost:8080/wiki/Albert Einstein?wikidataid=Q937&mobileaction=alpha < joakino looks awesome :D :D [17:35:32] i miss slack's inline gifs :disappointed: [17:35:38] can't wait to see this on production [17:35:38] cool, i'll have a stab at that tomorrow if you want, i'll be working offline in the morning (plane to london) [17:35:43] joakino: yeyy! [17:35:49] Say hi to london for me [17:36:01] will do :D [17:36:09] where will you be staying? [17:36:27] a hostel on friday, a friends house the rest of the days [17:36:36] do you know where the hostel is? [17:36:43] (03PS1) 10Deskana: Add descriptions for some previously undocumented translations. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185203 [17:36:53] bgerstle: You can use those descriptions if you want ^ [17:36:59] oh joakino what's the state of the watchlist infinite scroll [17:37:17] hokey doke [17:37:24] is it just the qunit tests? I can take a look at that today if you like [17:37:28] jdlrobson: i sent you an email, i need help with the modified date, not sure where to continue, thats the last thing left [17:37:37] shit i somehow missed that mail [17:37:39] qunit tests are 👍 [17:37:39] * jdlrobson looks [17:37:43] Deskana weird, i just grabbed the translations from master yesterday [17:37:54] wahhhhhh, we broke our editor in latest master [17:37:57] ahh there it is [17:37:58] bgerstle: Those strings were totally undocumented in Android it seems. [17:37:59] jdlrobson: ^ [17:38:00] oh, because you just added those [17:38:02] yeah [17:38:06] good catch :thumbs_up: [17:38:07] joakino: i'll sort out the rest [17:38:10] FlorianSW: we did? [17:38:10] :thumbsup:* [17:38:11] how ??! [17:38:21] eventlogging i suggest [17:38:21] jdlrobson: cool, thanks [17:38:22] wait... [17:38:28] usual questions 1) is it on mediawiki.org 2) is there a bug open? [17:38:55] Deskana mhurd dr0ptp4kt coreyfloyd i'm bailing out to #wikimedia-ios. join me if you share my distaste for loud noises :-P [17:39:04] jdlrobson: ah... no, cache problem :D [17:39:17] ok, all is awake now? :) [17:41:42] Deskana: the screenshots could also use an update... maybe we should pick an article with more colorful media than "iceberg" [17:41:53] 3MobileFrontend-alpha, Mobile-Web: Wikidata Infobox should properly format dates - https://phabricator.wikimedia.org/T85960#979867 (10Jdlrobson) [17:43:20] jdlrobson: argh, no, it's broken :/ https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/javascripts/modules/editor/EditorOverlayBase.js#L166 [17:43:29] Uncaught TypeError: Cannot read property 'always' of undefined [17:43:38] caused by https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/commit/6121c5d4fb322fb88cccc4c640316bbac666babb [17:43:58] FlorianSW: ah that was Ori's change. Doh. [17:44:12] FlorianSW: i have a quick meeting can you check if that made it out to mediawiki.org ? [17:44:15] if not we have plenty of time to fix [17:44:23] yap, on it [17:44:27] (03CR) 10jenkins-bot: [V: 04-1] Add descriptions for some previously undocumented translations. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185203 (owner: 10Deskana) [17:44:47] FlorianSW: i'll chat to Ori about it but on short term we should just revert that change [17:45:16] i will open a bug and you both to track this :) [17:46:07] Jenkins, what a bastard. [17:46:15] He gave my patch a -1 because of a bit of code I didn't even touch. [17:46:55] (03PS5) 10Bgerstle: add localized account creation error msgs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 (https://phabricator.wikimedia.org/T68944) [17:47:00] Deskana: checkstyle seems to behave really weirdly sometimes. [17:47:07] Deskana: jerkins [17:47:08] Deskana :point_up: [17:47:23] (03CR) 10Deskana: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185203 (owner: 10Deskana) [17:47:37] TRY AGAIN, JERKINS [17:48:23] hahaha [17:48:38] so hard to find good help these days [17:49:59] mhurd coreyfloyd i guess it's out of scope to do this kind of scroll-position tracking and reseting in the data model layer? [17:50:13] i.e. every time we invalidate the store w/ a new article, reset the scroll position? [17:50:27] or i guess, it's more than that [17:50:35] i just don't like adding extra state if we can avoid it [17:51:36] what about flipping the sol'n on its head: instead of checking for navigation and such, just force scroll position to 0 when loading a page from search? that way we can still use cached articles [17:52:13] 3Mobile-Web: Editor's onSaveComplete handler is broken (edit is saved but the user isn't redirected to it) - https://phabricator.wikimedia.org/T86941#979895 (10Florian) 3NEW [17:52:28] (03CR) 10Florianschmidtwelzow: "caused bug T86941" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184280 (owner: 10Ori.livneh) [17:52:55] wat [17:53:08] Now it gets a +2 [17:53:21] I'm not complaining, but considering I didn't change anything... [17:53:39] * dbrant waves at bearND [17:53:50] 3Mobile-Web: Editor's onSaveComplete handler is broken (edit is saved but the user isn't redirected to it) - https://phabricator.wikimedia.org/T86941#979902 (10Florian) p:5Triage>3High [17:55:47] hey dbrant and Deskana. Sorry for being late. DMV wait was horrible. How's it going? [17:56:57] bearND: I'm preparing to release based on the latest beta bump commit. Sound good? [17:57:14] dbrant: sure. go ahead [17:57:53] aww yiss [17:58:08] dbrant: you should also see the beta tag [17:58:14] gll [17:58:15] brb [17:58:17] oops [17:58:19] george's bath time [17:58:24] bearND: yep, got it [17:58:44] bgerstle, coreyfloyd: By the way, we have a monthly WMF-wide meeting in 1 hour. I'd advise watching: https://meta.wikimedia.org/wiki/WMF_Metrics_and_activities_meetings [17:58:46] bgerstle: hangout if a few? gotta grab my coffee :) [17:58:54] *in a few* [17:58:55] oh ok [17:59:25] bearND: No problem. Good timing really, I'm about to head in to the office. :-) [17:59:37] mhurd which calendar is that on? [17:59:47] bgerstle: none. informal [17:59:52] oh [18:00:01] so how were we supposed to know about it?.. [18:00:23] dbrant, bearND: Got everything you need from me for the release before I head off? [18:00:35] Deskana: think so! [18:00:56] bgerstle: oh, backing up, not a meeting, just me asking if you’d have a few minutes to chat :) [18:15:50] mhurd right, i was talking about the metrics etc. meeting [18:15:50] the hangout i understood [18:15:50] bgerstle: doh! my bad [18:15:51] Cool. Well, I'll be on email while I'm on the train. See you soon! [18:15:51] joakino "oh that's cool what can we say" x 5 ;-) [18:15:51] don't worry about it, go grab your :coffee: and we'll chat when you're ready [18:15:51] bgerstle: TO THE CAWFEE!!! [18:15:51] bgerstle: We normally send emails around about it. I guess the last one was sent last week before you joined. [18:15:51] jdlrobson: maybe something more dramatic like OH NOOOES [18:15:51] oh [18:15:51] In a bit! [18:15:51] joakino: haha :) [18:15:51] jdlrobson: meeting room connection issues? [18:15:52] nvm [18:15:52] rmoen: mm? [18:15:52] bgerstle: I suggested that as well - but after thinking about it, whether or not the VC should restore the scroll position based on if back/forward was tapped really does seem like a view layer responsibility and not really something that should affect the history. [18:15:52] jdlrobson: design meeting [18:15:53] bgerstle - I'm also against extra state… [18:15:53] coreyfloyd looking at it closer, there's a lot more that i'd like to discuss.. ;-) [18:15:53] coreyfloyd i can add you to the hangout when mhurd gets back [18:15:54] coreyfloyd TL;DR; block-based and/or chainable APIs [18:15:54] so we can see the sequence of events much more clearly [18:15:54] and make it easier load articles, then… do whatever [18:15:54] instead of storing lastScrollPosition and postLoadAction variables and making sure they're reset etc. [18:15:56] coreyfloyd for now though, maybe we can trade the extra state for an add'l parameter in the loadArticle API [18:15:56] hard to do w/ all the methods jumping around though :-/ i'll test it a bit and let you know what i find [18:15:56] bgerstle: yeah some sort of block callbacks could be good - help put the logic in a dingle place [18:15:56] or single even [18:15:57] i like dingle better, lol [18:15:57] bgerstle: to the batcave? [18:15:57] mhurd are we discussing my change, corey's or both? [18:16:36] bgerstle: yours for now, corey can join too [18:17:07] maybe we can talk about corey's later, i haven't actually tested it yet, but just looking at the code gave me a couple ideas. i'd like to try them out first [18:30:40] MaxSem, hey [18:30:48] yo [18:31:56] do you know if geodata coordinates are output in the dumps ('abstract.xml.gz')? [18:32:11] no idea [18:32:42] someone was asking and I suggested they just check the labs replicas instead [18:51:40] mornin' kaldari|2. [18:52:01] how did we end up solving EL issues yesterday, kaldari|2? [18:58:22] Deskana: bearND: IT'S AWAY!!!!11 [18:58:39] dbrant, bearND: Woohoo! [18:58:46] * dbrant high fives all around [18:58:48] \o/ [18:58:55] i'm heading out, gotta change cities [18:59:09] have a nice day [18:59:34] bgerstle: coreyfloyd sorry my machine crashed hard! [18:59:43] yikes! [19:00:45] bgerstle: coreyfloyd were you guys able to join the metrics meeting? [19:00:51] hangout [19:02:04] just starting now? [19:02:09] mhurd you have a link? [19:02:18] wasnt invited [19:02:28] coreyfloyd: It's an open hangout. [19:02:39] https://www.youtube.com/watch?v=53bG9mYMYE8&feature=youtu.be [19:02:43] There we go! [19:02:52] well, that's the youtube [19:02:54] not hangout [19:03:05] That's the correct way to view it [19:03:14] oh ok [19:03:14] Hangouts can't handle more than 15 people [19:03:35] bgerstle: coreyfloyd you guys were just welcomed as new teammates, in case you missed it :) [19:03:51] mhurd caught the tail end of it [19:04:00] :applause: [19:04:12] lol - yeah I missed it [19:04:14] :clap: * [19:05:10] bgerstle: coreyfloyd ping me if you don’t get testflight invite soon [19:05:40] k [19:08:02] k [19:08:49] Deskana: https://trello.com/c/NsB0NR7g/34-supplement-prefix-search-results-with-full-text-search-results [19:09:00] w00t machine learning! [19:09:08] Deskana: included in testflight last night [19:10:14] mhurd: aww yiss [19:10:21] mothafuckin testflight [19:15:53] microservices & comm protocols :thumbsup: [19:21:52] bgerstle: so cool! :) [19:27:15] Oh hey [19:27:21] What's this update for Wikipedia on my Nexus 5 [19:28:03] Oh, it's so pretty! [19:29:56] FUCK YEAAAAHH [19:30:08] I was just looking at today's featured article on the Android app [19:30:13] I noticed it didn't have a Wikidata description [19:30:18] So I went and added one [19:30:28] mhurd did a pull-to-refresh on the iOS app at the same time [19:30:33] And, oh look, a description! [19:30:39] INFRASTRUCTURE [19:46:12] Deskana: yesss! [19:57:50] Deskana: i fixed the description for one of the images listed in https://en.wikipedia.org/wiki/Susan_La_Flesche_Picotte but i'm not seeing the new description get picked up within the Android Alpha apps media viewer. when should i be able to see it? [19:57:50] Deskana: this image https://commons.wikimedia.org/wiki/File:First_Female_Medical_College_of_Pennsylvania_Building.JPG [19:57:50] Desc change from "as title -> First Female Medical College of Pennsylvania Building" [19:57:50] tfinc: Looking [19:57:51] tfinc: I guess there's just some caching going on there. [19:57:51] Deskana: what's the expected delay? [19:57:51] tfinc: It also shows the old description to me. [19:57:51] tfinc: A few days I think, last time I chatted to the Multimedia folks about this. [19:57:51] Deskana: it takes days for a change on Commons to be seen anywhere else ? [19:57:51] that is horrible [19:57:52] tfinc: The description is still the same on desktop MediaViewer, not showing your change [19:57:59] tfinc: So this isn't us, there's clearly some API thing here. [19:58:40] is the MediaViewer API that's doing the caching ? [19:59:04] tfinc: Yes. [19:59:34] marktraceur ^ [19:59:40] Ugh. [19:59:48] marktraceur: tl;dr description of a file on Commons was changed, API does not show said change [19:59:51] Yeah, it's cached [20:00:03] I'm not sure how long for. [20:00:03] marktraceur: what's the TTL on the cache ? [20:00:03] tgrrrrr where are you [20:00:20] He doesn't sit in here I think [20:00:26] Asked in -mm [20:00:38] Deskana: this is another article where our order for viewing images isn't consistent as well [20:00:42] marktraceur: thanks [20:03:47] I created tasks to track both of these issues [20:03:53] https://phabricator.wikimedia.org/T86955 - description caching [20:03:59] https://phabricator.wikimedia.org/T86954 - image ordering [20:04:33] tfinc, marktraceur: Thank you, gentlemen. [20:06:38] Deskana: excellent [20:06:42] 3Mobile-Web: Category overlay should separate content categories from adminstration categories - https://phabricator.wikimedia.org/T86496#980171 (10Florian) That's how the change, i will upload in few minutes, looks like: {F28865}{F28864} [20:07:08] tfinc: The nice thing is, Wikidata description updates come instantly. I tested that one myself. :-) [20:07:33] Deskana: good. our users the same behavior across our app [20:07:37] expect* [20:07:43] dbrant: Does this release include the refactoring to use the description returned by the mobileview API? [20:07:46] lets make sure to give it to them [20:08:29] Deskana: nope; that patch is dependent on bearND's new search patch. [20:09:38] mhurd Deskana i re-did my changes for the client-side account creation field verifiation [20:10:02] abandoned most of the localization and back-end response handling changes, simply checking if the fields are empty when user hits submit [20:10:14] if we want, we could create another card to add some dynamic feedback as the user fills out the form [20:10:40] i need to step out in a couple minutes to walk my dogs, any chance we could get some :eyes: on this real quick? [20:10:46] or are you guys going to get lunch now? [20:12:06] Deskana|Away: CMD data is cached for 12 hours for shared-DB data (Commons image queried on another wiki) [20:12:30] also stepping out for a bit [20:12:50] it is cached longer for local images but that cache is purged when the file description page is edited [20:14:09] i'm heading out now too, email if needed [20:25:45] (03PS1) 10Paladox: Convert to globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 [20:25:47] (03PS2) 10Paladox: Convert to globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 [20:25:51] (03CR) 10jenkins-bot: [V: 04-1] Convert to globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 (owner: 10Paladox) [20:25:57] (03CR) 10Kaldari: "@MaxSem: What do you think about splitting this into two patches? One for storing the responses and another for sending the responses to W" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [20:26:01] (03PS7) 10Jdlrobson: Hygiene: Retrieve pageApi instance using module loader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183648 [20:26:03] (03Abandoned) 10Florianschmidtwelzow: Hygiene: Load wikiRoulette only when needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184963 (owner: 10Florianschmidtwelzow) [20:26:09] (03PS3) 10Florianschmidtwelzow: Convert to globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 (owner: 10Paladox) [20:26:11] (03CR) 10Jdlrobson: [C: 04-1] "January 550 on http://localhost:8080/wiki/Darius%20the%20great?wikidataid=Q44387&mobileaction=alpha makes little sense." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960) (owner: 10Bmansurov) [20:26:15] (03PS1) 10Jdlrobson: Revert "Don't return a value from Schema.log" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185211 [20:26:22] (03PS2) 10Florianschmidtwelzow: Revert "Don't return a value from Schema.log" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185211 (https://phabricator.wikimedia.org/T86941) (owner: 10Jdlrobson) [20:26:30] (03CR) 10jenkins-bot: [V: 04-1] Convert to globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 (owner: 10Paladox) [20:26:43] (03CR) 10Bmansurov: [C: 031] Revert "Don't return a value from Schema.log" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185211 (https://phabricator.wikimedia.org/T86941) (owner: 10Jdlrobson) [20:26:58] (03PS4) 10Paladox: Convert to globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 [20:27:00] (03CR) 10jenkins-bot: [V: 04-1] Convert to globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 (owner: 10Paladox) [20:27:06] (03PS5) 10Paladox: Convert to globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 [20:27:08] (03CR) 10jenkins-bot: [V: 04-1] Convert to globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 (owner: 10Paladox) [20:27:10] (03PS6) 10Paladox: Convert to globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 [20:27:15] (03CR) 10jenkins-bot: [V: 04-1] Convert to globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 (owner: 10Paladox) [20:27:30] (03PS7) 10Paladox: Convert to globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 [20:27:36] (03CR) 10Paladox: "Please review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 (owner: 10Paladox) [20:27:40] (03CR) 10Paladox: "I have it set up https://packagist.org/packages/mediawiki/mobilefrontend here" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 (owner: 10Paladox) [20:27:57] (03PS8) 10Florianschmidtwelzow: Add "add discussion" button to talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182397 (https://bugzilla.wikimedia.org/70614) [20:27:59] 3Wikipedia-App-Android-App: Images are out of order in gallery view - https://phabricator.wikimedia.org/T86954#980194 (10Dbrant) Hmm, we're displaying the images in the order that the API gives to us. Ideally the API should return them in the correct order. (I'd like to avoid resorting to scrape the HTML for the... [20:29:19] (03CR) 10Jdlrobson: [C: 04-1] "Could we use array_merge to make this all cleaner?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 (owner: 10Paladox) [20:29:29] (03CR) 10Jdlrobson: Move modes.js into context.js (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183754 (https://phabricator.wikimedia.org/T85572) (owner: 10Bmansurov) [20:30:49] (03PS6) 10Bgerstle: account creation: client-side check for required fields [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 (https://phabricator.wikimedia.org/T68944) [20:30:53] (03PS7) 10Bgerstle: account creation: client-side check for required fields [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 (https://phabricator.wikimedia.org/T68944) [20:31:45] (03PS16) 10Florianschmidtwelzow: Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 [20:31:47] (03PS1) 10Florianschmidtwelzow: Group categories to content based and administrational ones [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185229 (https://phabricator.wikimedia.org/T86496) [20:31:53] (03PS6) 10Jdlrobson: Infinite scrolling on Special:EditWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184352 (owner: 10Jhernandez) [20:31:55] (03CR) 10jenkins-bot: [V: 04-1] Infinite scrolling on Special:EditWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184352 (owner: 10Jhernandez) [20:31:57] (03PS7) 10Jdlrobson: Infinite scrolling on Special:EditWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184352 (owner: 10Jhernandez) [20:31:59] (03CR) 10jenkins-bot: [V: 04-1] Infinite scrolling on Special:EditWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184352 (owner: 10Jhernandez) [20:32:01] (03CR) 10jenkins-bot: [V: 04-1] Group categories to content based and administrational ones [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185229 (https://phabricator.wikimedia.org/T86496) (owner: 10Florianschmidtwelzow) [20:32:03] (03CR) 10Florianschmidtwelzow: [C: 04-1] Group categories to content based and administrational ones (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185229 (https://phabricator.wikimedia.org/T86496) (owner: 10Florianschmidtwelzow) [20:33:35] (03PS3) 10Bmansurov: User friendly dates for wikidata infobox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960) [20:33:41] (03CR) 10jenkins-bot: [V: 04-1] User friendly dates for wikidata infobox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960) (owner: 10Bmansurov) [20:34:51] 3Wikipedia-App-Android-App, MediaWiki-extensions-CommonsMetadata, Multimedia: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#980199 (10Tgr) [20:34:55] (03PS4) 10Bmansurov: User friendly dates for wikidata infobox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960) [20:46:52] 3Wikipedia-App-Android-App, MediaWiki-extensions-CommonsMetadata, Multimedia: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#980246 (10Tgr) I discussed this with Aaron a while ago and he recommended using the shared memcached po... [20:47:00] (03PS8) 10Jdlrobson: Infinite scrolling on Special:EditWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184352 (owner: 10Jhernandez) [20:47:02] (03PS1) 10Jdlrobson: Regression: Show more link again on watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185241 [20:47:09] (03CR) 10Jdlrobson: [C: 031] Infinite scrolling on Special:EditWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184352 (owner: 10Jhernandez) [20:48:23] (03CR) 10jenkins-bot: [V: 04-1] Infinite scrolling on Special:EditWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184352 (owner: 10Jhernandez) [20:48:23] 3MobileFrontend-Feature-requests: Generalise infinite scroll code on uploads page so that Special:Watchlist can also use it - https://phabricator.wikimedia.org/T85491#980247 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson This was done in I3364cf3ea6a61c05df0f5bdf3fdf9748c27683a6 [20:55:41] 3MobileFrontend-Feature-requests: Features in MobileFrontend beta site - https://phabricator.wikimedia.org/T86961#980271 (10Jdlrobson) 3NEW [20:59:03] 3MobileFrontend-Feature-requests: Features in MobileFrontend beta site - https://phabricator.wikimedia.org/T86961#980288 (10Jdlrobson) [21:00:16] 3Mobile-Web: [Tracking] Features in MobileFrontend beta site - https://phabricator.wikimedia.org/T86961#980295 (10Jdlrobson) [21:02:53] Really cool app: http://www.bemyeyes.org [21:03:09] (03CR) 10Mhurd: "Added comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185124 (owner: 10Mhurd) [21:03:13] 3Mobile-Web: [Tracking] Features in alpha - https://phabricator.wikimedia.org/T86964#980307 (10Jdlrobson) 3NEW [21:03:27] coreyfloyd indeed, now _that's_ accessibility ;-P [21:03:52] dbrant: would you also push the mapping.tar.gz file to the releases site? See also https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Release_process [21:04:14] bearND|food: ah yes, will do [21:06:03] (03PS4) 10Brion VIBBER: [Work in progress] Activity indicator and background thread for conversion [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184716 [21:06:25] mhurd brion coreyfloyd dr0ptp4kt in line w/ my suggestion to .gitignore the "build" folder.. i'm noticing things in "assets" popping up a lot in diffs [21:06:50] i'll make a note to discuss this later, but just to make sure i'm not missing anything: those are all generated by things in www, right? [21:06:53] bgerstle: ah the assets files are probably the .css files we fetch from the network [21:06:57] if so, they should also be ignored (probably in the build folder) [21:07:04] they’re a bit ‘noisy’ because they include a cache key near the end [21:07:06] right [21:07:07] :-/ [21:07:12] (03CR) 10Dr0ptp4kt: [C: 031] "Works for me. Without did-you-mean to help fill in search terms containing non/unused words (e.g., "brownian einstein freq" returns no res" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185124 (owner: 10Mhurd) [21:07:19] (03PS6) 10Fjalapeno: Navigation and Caching behavior changes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184970 [21:07:39] bgerstle: yeah we have one script that fetches them into www, and the other that copies them into assets (or was it the other way around, crap :D) [21:08:07] 3MobileFrontend-Feature-requests: Add mobile editing support to Windows phone (IE9) - https://phabricator.wikimedia.org/T57599#980350 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson WONTFIX then. We can always revisit this. [21:08:11] gotchya, thanks brion! [21:11:25] mhurd: reposted my patch - let me know if it works for you. [21:11:29] 3Mobile-Web: Lots of background images not using data URI embedding - https://phabricator.wikimedia.org/T66101#980388 (10Jdlrobson) [21:11:37] 3Mobile-Web: Icons missing/broken on old Nokia phones (X3, C3) - https://phabricator.wikimedia.org/T52326#980390 (10Jdlrobson) [21:11:45] 3Mobile-Web: MobileFrontend extension does not support LdapAuthentication - https://phabricator.wikimedia.org/T65328#980392 (10Jdlrobson) [21:11:59] 3MediaWiki-extensions-OpenID, Mobile-Web: Mobile login not compatible with OpenID - https://phabricator.wikimedia.org/T54059#980395 (10Jdlrobson) [21:12:13] 3MediaWiki-extensions-LdapAuthentication, Mobile-Web: MobileFrontend extension does not support LdapAuthentication - https://phabricator.wikimedia.org/T65328#667944 (10Jdlrobson) [21:14:04] 3MediaWiki-Special-pages, Mobile-Web: Special:UserProfile shouldn't live in MobileFrontend - https://phabricator.wikimedia.org/T85929#980410 (10Jdlrobson) [21:14:37] 3Mobile-Web: Special:History should work on desktop - https://phabricator.wikimedia.org/T66939#980411 (10Jdlrobson) [21:15:46] 3MobileFrontend-Feature-requests: Design suggestions for mobile user profile page - https://phabricator.wikimedia.org/T75185#980414 (10Jdlrobson) [21:15:54] 3WMF-Design, MobileFrontend-Feature-requests: Design suggestions for mobile user profile page - https://phabricator.wikimedia.org/T75185#775209 (10Jdlrobson) [21:16:00] (03PS1) 10Kaldari: Sampling menu and search logging at 50% to reduce load on EventLogging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185246 [21:16:15] (03CR) 10Fjalapeno: Seamlessly supplement prefix search results with full text results. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185124 (owner: 10Mhurd) [21:18:09] (03PS5) 10Brion VIBBER: Activity indicator screen and background thread for conversion [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184716 [21:18:57] (03CR) 10Kaldari: Sampling menu and search logging at 50% to reduce load on EventLogging (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185246 (owner: 10Kaldari) [21:19:30] mhurd: ok i updated my patch for the data store upgrade, should be slightly more bulletproof [21:19:31] 3Mobile-Web: Uploads: cannot upload a photo - https://phabricator.wikimedia.org/T86348#980432 (10Jdlrobson) [21:19:39] as in, if one page fails it should skip over it instead of exploding :D [21:19:53] brion: awesome!!! [21:20:03] 3MediaWiki-ResourceLoader, Mobile-Web, MobileFrontend-Feature-requests: ResourceLoaderImage module css rules should be more configurable - https://phabricator.wikimedia.org/T78215#980435 (10Jdlrobson) [21:20:40] mhurd: want to do the data layer thing later today after the meeting thingy or tomorrow morning? [21:20:59] brion: tomorrow i guess? [21:21:03] 3Mobile-Web: "Desktop" in page footer of Special:Uploads returns Page unavailable - https://phabricator.wikimedia.org/T66986#980438 (10Jdlrobson) [21:21:14] 3Mobile-Web: Image taken in portrait mode is uploaded as landscape - https://phabricator.wikimedia.org/T71962#980440 (10Jdlrobson) [21:21:27] 3MobileFrontend-Feature-requests: Use GPS location to deliver locally relevant messages about copyright (for people uploading pictures) - https://phabricator.wikimedia.org/T70770#980442 (10Jdlrobson) [21:21:30] yeah that probably works better. let’s say after the standup, 10:30 or 11ish pacific? [21:21:38] 3Mobile-Web: Show duplicate error message - https://phabricator.wikimedia.org/T70296#980443 (10Jdlrobson) [21:21:40] nuria: How do the EventLogging levels look today? I finished some code to sample our logging, but it is based on the current codebase in master. I can backport it to wmf14 (the current version on en.wiki) if it's still needed. [21:21:57] 3Mobile-Web: Upstream ForeignAPI code in MobileFrontend into core - https://phabricator.wikimedia.org/T66636#980445 (10Jdlrobson) [21:21:59] bart’s gonna be shut down for a protest probably so i’ll probably be stuck remote again [21:22:05] 3Mobile-Web: Uploads AbuseFilter styling regression - https://phabricator.wikimedia.org/T65332#980448 (10Jdlrobson) [21:22:16] 3Mobile-Web: [Tracking] Consolidate Special:Uploads and Special:UploadWizard code - https://phabricator.wikimedia.org/T64638#980449 (10Jdlrobson) [21:22:18] brion: gah! BART! [21:22:25] 3Mobile-Web: File upload token errors - https://phabricator.wikimedia.org/T64587#980450 (10Jdlrobson) [21:22:29] you just have to walk past it ;) [21:22:32] kaldari: I think there is no need, we had no alarms today [21:22:34] 3Mobile-Web: AbuseFilterPanel on lead photo upload is too easy too ignore. - https://phabricator.wikimedia.org/T63976#980452 (10Jdlrobson) [21:22:43] 3Mobile-Web: Error toast rather than AbuseFilterPanel when photo upload itself triggers AbuseFilter - https://phabricator.wikimedia.org/T63975#980454 (10Jdlrobson) [21:22:43] kaldari: when are you guys planning to deploy your refactor? [21:22:52] 3Mobile-Web: Rethink the upload summaries for photo uploads from mobile - https://phabricator.wikimedia.org/T60983#980455 (10Jdlrobson) [21:23:01] 3Mobile-Web: Cannot easily retry upload - https://phabricator.wikimedia.org/T47377#980457 (10Jdlrobson) [21:23:29] the current master will be deployed to en.wiki on Jan 28. [21:23:33] nuria: ^ [21:24:05] kaldari: i see, until then, you "could" aply your patch, right? [21:24:11] *apply your patch [21:25:30] 3MediaWiki-User-login-and-signup, Mobile-Web, MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension): Captcha positioning is inconsistent between JavaScript and non-JavaScript users - https://phabricator.wikimedia.org/T85192#980483 (10Jdlrobson) Hey @Sumit I've left you some feedback on the patch. Once you've fold... [21:25:55] ok i gotta charge up then i’ll do a little more code review :D [21:26:06] sent calendar invites for 11am pacific for data layer sync [21:26:08] bbiab [21:26:14] nuria: If I swat deployed the current patch, it would go live on en.wiki on January 21st. The current patch is compatible with wmf15 and wmf16, but not wmf14 (the current en.wiki version). [21:27:07] nuria: So Jan 21 is the earliest possible, without a backport. [21:27:34] kaldari: I think that is fine, given that throughput has reduced i can see no urgency [21:27:58] nuria: Cool. If the situation changes, just let me know [21:28:00] (03PS9) 10Jdlrobson: Infinite scrolling on Special:EditWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184352 (owner: 10Jhernandez) [21:28:57] kaldari: will do, i did sent an e-mail today regarding loosing events and we did not loose any so we are good, our alarms are too tight now, but i'd like to get time to find the right threshold rather than ' welll... this could be it" [21:29:33] (03CR) 10Jdlrobson: [C: 032] "Since editing is currently broken I'll go ahead and +2 this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185211 (https://phabricator.wikimedia.org/T86941) (owner: 10Jdlrobson) [21:29:35] nuria: Yeah, I saw your email. Thanks for follow-up on it! [21:30:17] kaldari: will keep an eye on it and we'll touch base on the 21st, thanks for doing the changes. [21:30:27] (03CR) 10Mhurd: "Added comments." (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 (https://phabricator.wikimedia.org/T68944) (owner: 10Bgerstle) [21:30:35] nuria: Also, I talked with Maryana and Leila about requesting more muscle for our EventLogging system. [21:30:46] coreyfloyd mhurd brion FYI i created #wikimedia-ios [21:31:02] nuria: But obviously we don't want to fill it with data that isn't strictly needed. [21:31:19] (03Merged) 10jenkins-bot: Revert "Don't return a value from Schema.log" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185211 (https://phabricator.wikimedia.org/T86941) (owner: 10Jdlrobson) [21:31:34] kaldari: right, it is more often than not that there is "too much" data [21:32:28] bgerstle: my personal preference would be to use mobile, not ios specific channel. so many times we have discussions which the mobile web or android teams pick up on. thoughts? [21:32:38] kaldari: we see it on table sizes that become huge and impossible to analyze, i think we can probably do a lot more of events throughput wise but that is just ops, data wise we have no issues [21:32:51] *wikimedia-mobile* [21:32:52] i think for times when we're discussing iOS code review it helps from making this channel overly noisy [21:33:41] otherwise i tend to ignore this channel unless i'm mentioned [21:34:04] (03CR) 10Jdlrobson: [C: 04-1] "Easy solution: Just load the MainMenu code in the head of the document and initialise it on header-loaded." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) (owner: 10Bmansurov) [21:34:04] bgerstle: another problem is we have tools which are presently alerting *wikimedia-mobile*, and that noise is again something i find useful as non-ios folks can then poke and prod and comment on patches etc [21:35:10] i guess it's a tricky issue since it's a mixed repo [21:35:15] changes can involve mobile web or native [21:35:35] there are def times when mobile web & native conversations compete in here, though [21:35:52] w/e, it's cheap to have another room. it's there if we need it [21:35:58] bgerstle: Well, we don't expect everyone to read everything that's said in this channel. :-) [21:36:09] Deskana right, i'm just thinking about earlier this morning [21:36:14] there were around 6 people talking at once [21:36:24] (03CR) 10Jdlrobson: [C: 032] Add "add discussion" button to talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182397 (https://bugzilla.wikimedia.org/70614) (owner: 10Florianschmidtwelzow) [21:36:30] we don't necessarily have to decide [21:36:32] bgerstle: I think it'd fine to have a separate channel for breakouts, but as a general point of principle I'd prefer not to use that. [21:36:40] the room is there, if we use it, it stays [21:36:41] if not, it goes [21:36:49] bgerstle: And, rest assured, if I ever do need you for something, I will put your name at the start of every message I send. :-) [21:36:55] Deskana sure, this will be the default unless noisy [21:39:30] (03PS17) 10Jdlrobson: Add Possibility to add categories to a page using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [21:40:13] (03Merged) 10jenkins-bot: Add "add discussion" button to talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182397 (https://bugzilla.wikimedia.org/70614) (owner: 10Florianschmidtwelzow) [21:42:09] bmansurov: shame you don't have your sccript up and running :) [21:42:23] http://mobile-reportcard.wmflabs.org/#other-graphs-tab < could have caught the issue with main-menu-daily [21:43:09] jdlrobson: indeed [21:44:52] 3Analytics-EventLogging, Mobile-Web: Many of the mobile report cards are broken - https://phabricator.wikimedia.org/T86972#980586 (10Jdlrobson) 3NEW [21:46:56] (03CR) 10Mhurd: "Almost!" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184970 (owner: 10Fjalapeno) [21:48:05] (03CR) 10Jdlrobson: [C: 031] Add Possibility to add categories to a page using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [21:48:47] coreyfloyd: bgerstle i added some comments to your patches [21:49:14] 3MobileFrontend-Feature-requests: Can't easily add new section to user talk page - https://phabricator.wikimedia.org/T72614#980597 (10Jdlrobson) 5Open>3Resolved [21:49:56] k [21:50:13] jdlrobson: I'll try to get it up and running by the weekend [21:50:36] brion: looking over your patch… i’ve got one here as well: https://gerrit.wikimedia.org/r/#/c/185124/ [21:53:06] * brion looks [21:53:13] ooh nice [21:54:00] mhurd: time for a quick hangout? [21:54:57] (03CR) 10Bgerstle: "will address these now" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 (https://phabricator.wikimedia.org/T68944) (owner: 10Bgerstle) [21:58:14] (03CR) 10Brion VIBBER: "(inline note about prop vs method access)" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185124 (owner: 10Mhurd) [21:59:03] (03CR) 10Bgerstle: "SearchResultsController comments" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185124 (owner: 10Mhurd) [22:01:02] (03PS8) 10Bgerstle: account creation: client-side check for required fields [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 (https://phabricator.wikimedia.org/T68944) [22:02:07] (03CR) 10Bgerstle: [C: 04-1] "whoops just realized i forgot to update app localization keys!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 (https://phabricator.wikimedia.org/T68944) (owner: 10Bgerstle) [22:03:14] Deskana are you guys ok with rrom and connection etc. [22:03:35] Kristen: having issues… moment... [22:03:46] (03PS9) 10Bgerstle: account creation: client-side check for required fields [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 (https://phabricator.wikimedia.org/T68944) [22:06:03] https://etherpad.wikimedia.org/p/app_q3_health_check [22:06:09] https://docs.google.com/a/wikimedia.org/spreadsheets/d/1w68UX3VgZm_vKsYUNdB7AygumVoi84jGntc2DzHyE8Q/edit#gid=0 [22:08:37] Deskana: crappy + awesome = crawsome? [22:08:43] aweppy [22:08:51] cramehsome [22:10:06] awemehppy [22:11:18] Deskana: what are our best numbers to see handset/tablet/desktop traffic breakdown? [22:12:17] tfinc: You can view traffic breakdowns on Pentaho: http://pentaho.wmflabs.org/ [22:12:24] tfinc: Except you can't, because it's broken. [22:12:34] Deskana: ? [22:12:44] tfinc: It's a tool that Analytics uses. [22:12:51] tfinc: But it appears to be broken now. [22:12:58] DarTar: Good timing! Pentaho seems to be broken. [22:13:36] Deskana: can you report that to #wikimedia-analytics [22:14:02] there’s no expectation for it to be up as it’s just a POC but the data is available in SQL (staging db) [22:14:59] (03PS11) 10Jdlrobson: Hygiene: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 [22:15:13] tfinc: Then this will do you: https://play.google.com/apps/publish/?dev_acc=18062848292902787645#StatsPlace:p=org.wikipedia&statm=CURRENT_DEVICE_INSTALLS&statd=DEVICE_CLASS [22:15:21] 3Wikipedia-App-Android-App, MediaWiki-extensions-CommonsMetadata, Multimedia: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#980655 (10Tgr) > Actual: The image's description is cached for 12 hours Uh, seems like it's actually c... [22:15:52] jdlrobson: Weren't you once talking about per-page styling? There's a question about something similar in #mediawiki [22:15:56] Deskana: and what is most up to date for mobile web ? [22:16:05] marktraceur: what did you find out about the ttl ? [22:16:05] tfinc: I have no idea for Mobile Web. [22:16:26] kaldari: jdlrobson: where i can i see our latest per device type breakdown? handset/tablet/desktop ? [22:16:29] tfinc: I think tgr said it was 12 hours [22:16:34] k [22:17:52] tfinc: The last numbers I saw were from October. Not sure there is anything more recent. [22:18:03] kaldari: can you link me to those ? [22:20:26] (03PS7) 10Fjalapeno: Navigation and Caching behavior changes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184970 [22:22:53] 3Wikipedia-App-Android-App, MediaWiki-extensions-CommonsMetadata, Multimedia: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#980669 (10Deskana) >>! In T86955#980655, @Tgr wrote: >> Actual: The image's description is cached for 1... [22:23:40] tfinc: Shared doc with you. It lists percentage of user's with certain user agents for all user agents with more than 0.1% usage. [22:23:47] kaldari: thanks [22:24:49] tfinc: that's only for mobile web, BTW [22:25:08] kaldari: that's fine. the google dashboard has all of these for apps updated to this week [22:25:08] as I assume that's what you were asking for [22:25:42] (03CR) 10Bartosz Dziewoński: "Okay uh, so I changed my mind about how we're going to do the LookupInputWidget change, and now the plan includes renaming it and *then* f" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [22:26:49] Deskana: we're missing the hiring link at the bottom of the post [22:27:52] tfinc: I'll speak to Juliet. [22:27:54] jdlrobson: ping [22:28:01] Deskana: the post also doesn't link to any of our pages. lots of easy ones we can link to [22:28:06] thanks [22:29:03] (03CR) 10Florianschmidtwelzow: "Cross-copy comment from Bartosz Dziewoński (gerrit change 181225):" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [22:30:42] dbrant, seen https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8075975 ? [22:31:24] Krenair: yep, investigating [22:31:54] I tested it earlier and remove did not crash for me, reload did but with a different exception [22:32:19] Deskana: who gets the phab tasks if pentaho is down ? [22:32:38] tfinc: I have no idea. DarTar suggested mentioning it in #wikimedia-analytics [22:32:42] 3Wikipedia-App-Android-App, MediaWiki-extensions-CommonsMetadata, Multimedia: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#980731 (10Tgr) For Wikimedia wikis, the patch above should make all updates immediate. Is this an urgen... [22:33:16] Deskana: where would i go to get that archived disucssion? [22:33:29] mhurd: Which? [22:33:55] tfinc: ping kevinator or mforns [22:34:15] I know they were uploading a new cube [22:34:25] but I have no idea if this is related [22:34:34] * tfinc ponders what uploading a new "cube" means [22:35:27] Deskana: the lead image one [22:35:30] tfinc: creating a new data series with specific dimensions [22:35:45] (03CR) 10Kaldari: [C: 032] Hygiene: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [22:35:52] for example, we added a binary field called isSSL [22:36:04] (which we had to retire because the data was not accurate) [22:36:20] Krenair: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8075838 in which queue should this be moved to? :/ [22:36:37] mhurd: https://lists.wikimedia.org/pipermail/mobile-l/2014-December/008402.html [22:37:15] bgerstle: coreyfloyd ^ [22:38:07] bgerstle: coreyfloyd oops starting thread here: https://lists.wikimedia.org/pipermail/mobile-l/2014-December/008441.html [22:38:08] (03Merged) 10jenkins-bot: Hygiene: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [22:38:10] yawwwn [22:39:10] FlorianSW, I would try info-en [22:39:33] Krenair: moved, thanks :) [23:25:02] (03PS3) 10Phuedx: Fix rendering issues with infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185111 (owner: 10Jdlrobson) [23:25:08] (03CR) 10jenkins-bot: [V: 04-1] Fix rendering issues with infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185111 (owner: 10Jdlrobson) [23:27:02] (03CR) 10Phuedx: Fix rendering issues with infoboxes (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185111 (owner: 10Jdlrobson) [23:27:41] (03CR) 10Phuedx: "PS3 reinstates the PS1 change to Infobox.js." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185111 (owner: 10Jdlrobson) [23:33:01] (03PS4) 10Phuedx: Fix rendering issues with infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185111 (owner: 10Jdlrobson) [23:33:59] (03CR) 10Fjalapeno: "@Monte - I made the change to reset the article position after search (not just ignore it)." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184970 (owner: 10Fjalapeno) [23:35:04] (03CR) 10Bgerstle: "nit-picks, otherwise code seems OK" (034 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184716 (owner: 10Brion VIBBER) [23:37:05] (03PS5) 10Bmansurov: User friendly dates for wikidata infobox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960) [23:37:10] (03CR) 10jenkins-bot: [V: 04-1] User friendly dates for wikidata infobox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960) (owner: 10Bmansurov) [23:38:13] (03PS6) 10Bmansurov: User friendly dates for wikidata infobox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960) [23:38:22] (03CR) 10Phuedx: [C: 032] Fix rendering issues with infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185111 (owner: 10Jdlrobson) [23:38:37] (03CR) 10Phuedx: "PS5 was a rebase." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185111 (owner: 10Jdlrobson) [23:39:38] (03CR) 10jenkins-bot: [V: 04-1] User friendly dates for wikidata infobox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960) (owner: 10Bmansurov) [23:39:45] (03Merged) 10jenkins-bot: Fix rendering issues with infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185111 (owner: 10Jdlrobson) [23:39:47] (03CR) 10Jdlrobson: [C: 04-1] "separation of concerns etc" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185246 (owner: 10Kaldari) [23:41:12] (03CR) 10Bmansurov: Represent main menu as a View incorporated in Skin (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) (owner: 10Bmansurov) [23:41:17] jdlrobson: ^ [23:45:36] (03PS7) 10Bmansurov: User friendly dates for wikidata infobox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960)