[00:01:45] (03CR) 10Mhurd: [C: 031 V: 031] "Stabilize everything! :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185063 (owner: 10BearND) [00:03:12] (03CR) 10Bartosz Dziewoński: [C: 04-1] Add Possibility to add categories to a page using oojs-ui (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [00:03:37] (03PS1) 10Yurik: API analyticsconfig will return all historical items [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/185344 [00:03:56] (03CR) 10Yurik: [C: 032] API analyticsconfig will return all historical items [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/185344 (owner: 10Yurik) [00:06:30] (03PS7) 10Bmansurov: Represent main menu as a View incorporated in Skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) [00:06:37] (03Merged) 10jenkins-bot: API analyticsconfig will return all historical items [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/185344 (owner: 10Yurik) [00:06:43] (03PS16) 10Jdlrobson: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 [00:08:24] (03PS8) 10Bmansurov: Represent main menu as a View incorporated in Skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) [00:10:06] (03CR) 10jenkins-bot: [V: 04-1] Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [00:14:37] (03CR) 10Jdlrobson: [C: 04-1] "I still see this in core so please add a link to a discussion/patch that talks about why it is now obsolete" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184801 (owner: 10MaxSem) [00:15:01] jdlrobson, have you _looked_ at them [00:15:03] ???? [00:15:45] because you clearly haven't [00:16:27] tfinc: Recruiting notice has been added to the blog post. [00:16:32] Deskana: thank [00:16:33] s [00:18:44] jdlrobson, ? [00:19:54] (03CR) 10Mhurd: "Added a couple small notes. Gonna test now..." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184716 (owner: 10Brion VIBBER) [00:21:15] I'm SO tired. [00:22:08] Jolt? [00:22:13] (03CR) 10Trevor Parscal: [C: 04-1] Infobox item editing using oojs-ui (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [00:30:22] jdlrobson, ? [00:51:20] (03CR) 10Paladox: "Hi I doint know what extension.json is and what do you mean about packaging and telling the developers who develop for this extension" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 (owner: 10Paladox) [00:51:24] (03PS8) 10Paladox: Convert to globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 [01:01:05] (03CR) 10MaxSem: "> Hi I doint know what extension.json is" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 (owner: 10Paladox) [01:20:52] (03CR) 10Robmoen: Scrollable reference drawers (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (owner: 10Robmoen) [01:21:08] (03PS6) 10Robmoen: Scrollable reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 [01:23:07] (03CR) 10jenkins-bot: [V: 04-1] Scrollable reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (owner: 10Robmoen) [01:27:31] (03PS7) 10Robmoen: Scrollable reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 [01:28:20] dbrant: https://phabricator.wikimedia.org/T86079 [01:30:45] (03CR) 10jenkins-bot: [V: 04-1] Scrollable reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (owner: 10Robmoen) [01:34:37] (03PS4) 10Bmansurov: Move modes.js into context.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183754 (https://phabricator.wikimedia.org/T85572) [01:34:44] (03CR) 10jenkins-bot: [V: 04-1] Move modes.js into context.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183754 (https://phabricator.wikimedia.org/T85572) (owner: 10Bmansurov) [01:40:12] (03PS17) 10Jdlrobson: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 [01:40:24] (03PS5) 10Bmansurov: Move modes.js into context.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183754 (https://phabricator.wikimedia.org/T85572) [01:40:27] (03CR) 10Jdlrobson: Infobox item editing using oojs-ui (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [01:40:58] (03PS2) 10Jdlrobson: Improve wikidata infobox style and template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185164 (owner: 10Jhernandez) [01:42:16] (03CR) 10jenkins-bot: [V: 04-1] Move modes.js into context.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183754 (https://phabricator.wikimedia.org/T85572) (owner: 10Bmansurov) [01:48:32] (03PS1) 10Kaldari: Sample MobileWebClickTracking events at 50% (to reduce load on EventLogging) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185369 [01:48:38] (03CR) 10jenkins-bot: [V: 04-1] Sample MobileWebClickTracking events at 50% (to reduce load on EventLogging) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185369 (owner: 10Kaldari) [01:58:43] (03PS2) 10Kaldari: Sample MobileWebClickTracking events at 50% (to reduce load on EventLogging) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185246 [01:59:31] (03PS6) 10Bmansurov: WIP: Move modes.js into context.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183754 (https://phabricator.wikimedia.org/T85572) [02:00:26] (03PS3) 10Kaldari: Sample MobileWebClickTracking events at 50% (to reduce load on EventLogging) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185246 [02:01:28] mhurd: still online? [02:01:34] (03CR) 10jenkins-bot: [V: 04-1] WIP: Move modes.js into context.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183754 (https://phabricator.wikimedia.org/T85572) (owner: 10Bmansurov) [02:02:20] (03Abandoned) 10Kaldari: Sample MobileWebClickTracking events at 50% (to reduce load on EventLogging) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185369 (owner: 10Kaldari) [02:42:31] bgerstle: hey sorry i was in meetings [02:42:37] np [02:42:44] today’s been insane [02:42:53] bgerstle: what’s up [02:43:33] np we can talk tomorrow [02:43:54] bgerstle: cool - sorry i haven’t been able to do more review this afternoon [02:44:00] np [02:44:20] soon corey and i will be up to speed and reviewing each other's stuff in the morning EST :wink: [02:44:28] spread the load across time zones [02:44:55] we'll chat tomorrow :moon: [02:46:59] (03CR) 10Mhurd: "This is looking solid. Will test in morning." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 (https://phabricator.wikimedia.org/T68944) (owner: 10Bgerstle) [02:48:49] (03CR) 10Mhurd: "Looks legit. Will test in morning." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184970 (owner: 10Fjalapeno) [02:50:55] (03PS1) 10Yurik: Skip 'disabled' in analyticsconfig [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/185383 [02:51:15] (03CR) 10Yurik: [C: 032] Skip 'disabled' in analyticsconfig [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/185383 (owner: 10Yurik) [02:51:51] (03Merged) 10jenkins-bot: Skip 'disabled' in analyticsconfig [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/185383 (owner: 10Yurik) [02:53:58] 3Wikipedia-App-iOS-App, MediaWiki-API, Wikipedia-App-Android-App: generator=search API should return information about search suggestions, like list=search does - https://phabricator.wikimedia.org/T86982#981104 (10Deskana) >>! In T86982#981099, @Anomie wrote: > It's not a bug in the API either. A generator is su... [03:26:05] (03PS1) 10Yurik: Skip 'enabled' field in 'analyticsconfig' [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/185386 [03:26:16] (03CR) 10Yurik: [C: 032] Skip 'enabled' field in 'analyticsconfig' [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/185386 (owner: 10Yurik) [03:26:56] (03Merged) 10jenkins-bot: Skip 'enabled' field in 'analyticsconfig' [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/185386 (owner: 10Yurik) [05:33:50] (03CR) 10Florianschmidtwelzow: WIP: new extension registration (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183906 (owner: 10MaxSem) [05:35:47] (03CR) 10MaxSem: WIP: new extension registration (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183906 (owner: 10MaxSem) [09:43:23] (03PS1) 10Phuedx: Fix errors in MobileWebUploads schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185408 [09:45:25] (03PS2) 10Phuedx: Fix errors in MobileWebUploads schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185408 [10:22:58] morning all [11:20:12] (03CR) 10Phuedx: "If wgMFPhotoUploadEndpoint isn't set, then you can't upload a photo locally." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [11:25:13] (03CR) 10Phuedx: "… nor if you set wgMFPhotoUploadEndpoint to "http://127.0.0.1:8080/w/api.php"." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [11:25:45] 3Mobile-Web: Photo uploads broken locally - https://phabricator.wikimedia.org/T87006#981535 (10phuedx) 3NEW [11:33:00] Kristen: yt for realz? [11:36:21] thought not ;) [12:08:38] (03PS1) 10Phuedx: [WIP] Work around ForeignApi/mw.Api inconsistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185423 (https://phabricator.wikimedia.org/T87006) [13:07:55] 3Mobile-Web: Uploads: cannot upload a photo - https://phabricator.wikimedia.org/T86348#981691 (10phuedx) Whilst trying to verify/debug this, I discovered T87006. However, with the temporary fix for T87006 ([185423](https://gerrit.wikimedia.org/r/185423)) applied, I can't reproduce this on master. [13:09:40] 3Mobile-Web: Photo uploads broken locally - https://phabricator.wikimedia.org/T87006#981693 (10phuedx) a:3phuedx [13:10:45] 3Mobile-Web: Photo uploads broken locally - https://phabricator.wikimedia.org/T87006#981703 (10phuedx) [15:14:10] 3Mobile-Web: commons images are always "Last updated 0 seconds ago" - https://phabricator.wikimedia.org/T84906#981944 (10phuedx) AFAICT this is because `WikiFilePage` doesn't override `WikiPage#getTimestamp` and the latter will always return //now// for file pages. [15:37:47] 3Wikipedia-App-Android-App: Production release for Android Wikipedia app on 2015-01-15 - https://phabricator.wikimedia.org/T86690#981975 (10Dbrant) 5Open>3Resolved a:3Dbrant WORKSFORME [15:40:39] hi! [15:40:47] i've finally managed to get online [15:41:08] phuedx: what a shitty internet in most places man [15:41:24] joakino_LondonIn: inorite [15:41:27] where you at? [15:42:48] phuedx: i'm at one of the st christopher hostels, nearby london bridge [15:43:00] phuedx: how's george doing, just saw the email [15:43:06] oh really, i'm about 20 minutes bike ride from there [15:43:08] he's ok [15:43:25] he was awake at 6 am today, so i got a couple hours sleep after i fed harry [15:43:27] (03CR) 10Dbrant: [C: 032] Set "stable" class to body tags [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185063 (owner: 10BearND) [15:45:00] phuedx: i've had to connect to irc via web freenode... it is blocked in most places, they use this shit hotspot companies [15:45:16] bleh [15:53:00] (03CR) 10Dbrant: [C: 032] Update styles from vagrant [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185064 (owner: 10BearND) [15:53:40] (03Merged) 10jenkins-bot: Update styles from vagrant [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185064 (owner: 10BearND) [16:34:04] (03CR) 10Dbrant: [C: 032] Add descriptions for some previously undocumented translations. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185203 (owner: 10Deskana) [16:34:36] (03PS7) 10Dbrant: Combine title and full text search [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184692 (owner: 10BearND) [16:35:07] (03CR) 10Paladox: "Hi I didn't decide to add composer.json someone else did but didn't add globals to make it compatible with composer.json" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 (owner: 10Paladox) [16:38:57] joakino_LondonIn: yt? [16:44:18] phuedx: youtube? [16:44:22] what is yt [16:44:24] you there? [16:44:25] xD [16:44:27] ah ok [16:44:29] yes] [16:46:50] i may have found a bug with the search overlay, can you try and reproduce? [16:47:06] tell me [16:47:07] phuedx: [16:47:27] click search, click the "x", nothing happens, click off the overlay, browser navigates to nowhere [16:49:37] also, click search, search, click off the overlay, nothing happens, click off the overlay, browser navigates to nowhere [16:51:59] ok… [16:52:04] now i can't reproduce it [16:57:14] 3Wikipedia-App-iOS-App: Wikipedia App: [iOS] After removing a page from "Recents" section, loading that same article from Search or Saved Pages does not activate the page navigation at the bottom for that article - https://phabricator.wikimedia.org/T74987#982109 (10Fjalapeno) Looked into this and the #2 doesn'... [16:59:59] phuedx: seems to work fine [17:00:35] joakino_LondonIn: module hadn't fully loaded when i clicked something a few times [17:00:46] my vagrant wasn't completing a file for some reason [17:02:22] phuedx: it is super slow... it happens to me too, i think its loading but it's not finished [17:02:32] it takes like 15 seconds to refresh [17:13:36] jesus i can't even send a patch [17:13:40] everything takes ages [17:20:43] blocked porrrtsss [17:30:39] hey kaldari|2 [17:31:00] gotta go guys [17:31:08] bb [17:31:21] sent an email with what I've done today and complaining about the wifis... [17:34:30] 3Wikipedia-App-iOS-App: Wikipedia App: [iOS] After removing a page from "Recents" section, loading that same article from Search or Saved Pages does not activate the page navigation at the bottom for that article - https://phabricator.wikimedia.org/T74987#982203 (10Deskana) p:5Normal>3Low If this is going... [17:42:40] (03PS1) 10BearND: Fix build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185464 [17:48:07] (03PS11) 10MaxSem: WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [17:48:44] (03CR) 10jenkins-bot: [V: 04-1] WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [17:49:09] (03PS1) 10Phuedx: Avoid SearchOverlay input drift [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185467 (https://phabricator.wikimedia.org/T1159) [17:50:12] (03PS2) 10Phuedx: Work around ForeignApi/mw.Api inconsistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185423 (https://phabricator.wikimedia.org/T87006) [17:57:10] 3Mobile-Web: No refresh icon on Special:Nearby in alpha - https://phabricator.wikimedia.org/T85578#982260 (10phuedx) Ping @MSyed. [17:57:55] phuedx: thanks for filing that [17:59:09] (03PS2) 10Phuedx: Avoid SearchOverlay input drift [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185467 (https://phabricator.wikimedia.org/T1159) [17:59:27] (03PS9) 10Paladox: Convert to globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 [18:11:15] phuedx: hey, following our brief haskell/fn'l programming chat.. i'm wondering if we should set aside some time to hack on fn'l stuff at dev summit (either an official hack session or just an activity after-hours) [18:14:20] 3Mobile-Web: Photo uploads broken locally - https://phabricator.wikimedia.org/T87006#982318 (10phuedx) @jdlrobson: [185423](https://gerrit.wikimedia.org/r/185423) is a workaround. We should chat about `ForeignApi`/`mw.Api` and tokens. [18:14:25] 3Mobile-Web, Analytics-EventLogging: Many of the mobile report cards are broken - https://phabricator.wikimedia.org/T86972#982320 (10bmansurov) https://phabricator.wikimedia.org/T86059 [18:14:39] bgertie: i'd quite like to get clojurescript working by default in mediawiki ;) [18:16:10] or purescript! [18:18:28] moizsyed: hey, could you upload the new design assets to https://trello.com/c/QNEGUHe5/103-design ? [18:18:56] dr0ptp4kt: will do [18:21:40] (03CR) 10Dbrant: [C: 032] Fix build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185464 (owner: 10BearND) [18:21:50] phuedx: you there? [18:21:55] yello [18:22:34] phuedx: so ForeignApi/Api stuff [18:22:41] yarrrp [18:22:43] I think ForeignApi#post was badly named [18:22:47] should have been postWithToken [18:22:50] i agree [18:23:03] so let's just do that. [18:23:20] cool, i missed the foreign api stuff landing [18:23:22] (ideally i'd want this stuff moved into core [18:23:32] phuedx: np it happened pretty fast. it's been bugging me for a while [18:23:35] so i wasn't sure what you'd want to do [18:23:43] and we were trying to get it ready for the dev summit [18:23:44] cool, i'm happy with that [18:23:51] +1 would have this chat again! [18:24:01] (03CR) 10Jdlrobson: [C: 04-1] "As discussed let's rename ForeignApi#post to postWithToken" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185423 (https://phabricator.wikimedia.org/T87006) (owner: 10Phuedx) [18:24:40] (03Abandoned) 10Phuedx: Work around ForeignApi/mw.Api inconsistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185423 (https://phabricator.wikimedia.org/T87006) (owner: 10Phuedx) [18:24:41] phuedx: do you think we are in a position we can move mw-ui-icon to beta? [18:25:05] phuedx: the only issue i can see is with the VisualEditorOverlay toggle editor - i was going to see if i could use oojs ui for that though [18:25:15] since it's what they call an icon with an indicator [18:25:26] i haven't noticed anything recently [18:25:36] and that last fix cleared some stuff up [18:25:41] i feel getting it into beta would give it more attention [18:25:48] it's weird how new features need to think about 2 types of icons [18:26:14] jdlrobson: you doing the foreignapi thing or am i? [18:26:20] (i don't mind) [18:26:23] phuedx: if you can do that that would be great [18:26:28] would be good to have someone else poke at that code [18:26:29] sure thing [18:26:40] i'm just reviewing your patches as we speak [18:27:15] jdlrobson: i forget, is server-side templating a thing yet? [18:27:28] phuedx: not yet. as i understand it we are getting close [18:27:37] i'd really like to share the searchoverlay template between the header chrome and the searchoverlay class [18:27:41] darn [18:27:59] i'm going to spend some time tidying up the class names for the search overlay [18:28:06] so i can pull them out and apply them to both [18:28:43] hrrm [18:30:19] (03CR) 10Jdlrobson: [C: 032] Avoid SearchOverlay input drift [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185467 (https://phabricator.wikimedia.org/T1159) (owner: 10Phuedx) [18:31:03] brion i'm guessing the answer is no, but are users' saved articles stored on a server anywhere? [18:31:14] Deskana: dbrant|brb mhurd are you guys up for doing a quick bug triage later? Maybe just Deskana? [18:31:14] 3Mobile-Web: Editor's onSaveComplete handler is broken (edit is saved but the user isn't redirected to it) - https://phabricator.wikimedia.org/T86941#982377 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [18:31:22] i.e. do we support syncing them across devices, platforms, etc.? [18:31:26] brb -- gonna get george to bed [18:31:41] goodnight george! [18:31:45] kristenlans: i'd be up for it [18:32:25] (03Merged) 10jenkins-bot: Avoid SearchOverlay input drift [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185467 (https://phabricator.wikimedia.org/T1159) (owner: 10Phuedx) [18:33:59] bgerstle: hangout? [18:34:11] 3Mobile-Web: Images are top-aligned in image viewer - https://phabricator.wikimedia.org/T86800#982396 (10Jdlrobson) I suspect this is due to Id8bc1873e87fd450582daa2253f23e574fb37ebc [18:34:24] mhurd :thumbsup: [18:34:28] 3Mobile-Web: Images are top-aligned in image viewer - https://phabricator.wikimedia.org/T86800#982397 (10Jdlrobson) [ specifically https://gerrit.wikimedia.org/r/#/c/183904/1/less/modules/mediaViewer.less ] [18:35:02] bgerstle: not yet no, it’s local only [18:35:10] are there plans to do this? [18:35:11] but we’ve been thinking it’d be wise to sync them if you’re logged in [18:35:17] yeah [18:35:25] don’t know if it’s on the todo list yet tho [18:35:46] we could make a new micro-service to do it :wink: :wink: [18:35:52] :D [18:36:09] there’s some functional overlap with the server-side watchlist, so we have to decide whether to try ot merge them or make them explicitly separate features [18:36:29] (confession: spotify was very SOA & micro-service, so which i kinda liked. especially how they started using middleware services for client-specific data aggregation) [18:36:33] i’ve got like thousands of watchlisted pages from my old editing days so i don’t want them all synced locally ;) [18:36:38] nice [18:36:48] that makes sense [18:36:52] a lot of mediawiki stuff still goes through the mediawiki monolith even when we have a backend service [18:36:55] We should be very intentional about what we prioritise with respect to this :-) [18:36:55] sometimes this is awkward :) [18:36:56] maybe an extra data field for "sync for offline reading"? [18:37:09] 3Mobile-Web: Another icon misaligned in search alpha - https://phabricator.wikimedia.org/T87047#982415 (10Jdlrobson) [18:37:21] anyway, that satisfied my curiosity [18:37:22] We don't have a lot of experience doing things like this, and the apps presently don't store *anything* on the server side per-user, so something like this could end up as a mammoth all-consuming task [18:37:29] heh [18:37:29] So, we need to balance things carefully! [18:37:34] yeah no rush :D [18:37:38] just saying, that would be the expected behavior IMHO [18:39:21] 3Mobile-Web, WMF-Design: Polish : Search placeholder text is shifted ~2 px when field gains focus. - https://phabricator.wikimedia.org/T1159#982439 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [18:39:26] 3Mobile-Web, WMF-Design: Polish : Mobile experimental mode search header height is inconsistent - https://phabricator.wikimedia.org/T1165#982441 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [18:42:05] 3Mobile-Web: No refresh icon on Special:Nearby in alpha - https://phabricator.wikimedia.org/T85578#982447 (10Jdlrobson) Or maybe @violetto knows where a canonical SVG for this is: {F29124} [18:42:52] 3Mobile-Web, Analytics-EventLogging: Many of the mobile report cards are broken - https://phabricator.wikimedia.org/T86972#982452 (10Jdlrobson) [18:43:04] 3Mobile-Web, Analytics-Engineering, Analytics-Visualization: generate.py produced broken CSV files - https://phabricator.wikimedia.org/T86059#982455 (10Jdlrobson) #Mobile-Web [18:43:46] (03PS8) 10Jdlrobson: Scrollable reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (owner: 10Robmoen) [18:44:27] rmoen: is there a bug for https://gerrit.wikimedia.org/r/#/c/178338/8 i'm completely lost with what this is supposed to be fixing [18:45:06] and i'm not sure how high priority it is now since i'm not sure what state the references drawer in beta is in (are we planning to push that to stable any time soon?) [18:46:01] mhurd, brion, dr0ptp4kt, bgerstle, coreyfloyd: Your big priority for the next few hours is to get Brian and Corey's patches merged. [18:46:04] jdlrobson: there is a card in wikigrok team board to make the ref drawer scrollable. https://trello.com/c/o0l0dKAd/23-3-alpha-beta-make-reference-dialog-scrollable [18:46:13] (03CR) 10jenkins-bot: [V: 04-1] Scrollable reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (owner: 10Robmoen) [18:46:15] *nod* [18:46:15] mhurd, brion, dr0ptp4kt, bgerstle, coreyfloyd: Remember the target of having patches merged in the first week! :-) [18:46:16] (03PS3) 10Jdlrobson: Fix errors in MobileWebUploads schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185408 (owner: 10Phuedx) [18:46:19] Deskana on it, thanks! [18:46:27] rmoen: probably better to create a phabricator card for it now there has been a team split [18:46:37] Deskana: yes! we’re looking good i think [18:46:59] brion: could you review corey’s patch with him? [18:47:07] yeah lemme pull it up [18:47:27] coreyfloyd: https://gerrit.wikimedia.org/r/#/c/184970/ right? [18:48:34] jdlrobson: this was just something I had in gerrit that need finishing and they were carrying it on their board. kristenlans asked if i would take it on yesterday to wrap it before the sprint ended. I didn't know it needed a phab card. [18:49:01] sure. it just completely fell off my radar so it would be good to have a bug around capturing the issue and how to test it. [18:49:06] (03CR) 10Brion VIBBER: Navigation and Caching behavior changes (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184970 (owner: 10Fjalapeno) [18:49:13] i can do that if you want but i figure you understand the bug better [18:49:15] jdlrobson: yeah it's a legacy card from back in the day [18:49:30] right now i'm just now sure how to test it :-) [18:49:39] (03CR) 10Jdlrobson: [C: 032] Fix errors in MobileWebUploads schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185408 (owner: 10Phuedx) [18:50:29] mhurd: "Your own personal github"? [18:50:34] (03CR) 10Jdlrobson: [C: 031] Infinite scrolling on Special:EditWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184352 (owner: 10Jhernandez) [18:50:35] mhurd: https://en.wikipedia.org/wiki/Series_of_tubes [18:50:42] IT'S A SERIES OF TUBES [18:50:54] Don't go sending me any internets now! [18:50:55] I'm busy! [18:51:01] Deskana: it’s not a dumptruck [18:52:33] (03CR) 10Jdlrobson: Sample MobileWebClickTracking events at 50% (to reduce load on EventLogging) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185246 (owner: 10Kaldari) [18:52:48] (03Merged) 10jenkins-bot: Fix errors in MobileWebUploads schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185408 (owner: 10Phuedx) [18:54:37] (03PS9) 10Robmoen: Scrollable reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 [18:54:54] (03PS10) 10Robmoen: Scrollable reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 [18:54:57] (03PS8) 10Fjalapeno: Navigation and Caching behavior changes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184970 [18:56:24] (03CR) 10Dbrant: [C: 032] Combine title and full text search [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184692 (owner: 10BearND) [18:56:46] (03CR) 10Fjalapeno: "Addressed comment about providing a string for the new navigation enum" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184970 (owner: 10Fjalapeno) [18:57:15] woot [18:57:36] brion: just for you [18:57:39] :D [18:58:00] reminder: data layer hangout in 3 minutes :D mhurd coreyfloyd bgerstle [18:58:06] (03CR) 10Dr0ptp4kt: [C: 031 V: 031] "This is working for me." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184970 (owner: 10Fjalapeno) [18:58:31] (03CR) 10Mhurd: [C: 032 V: 032] "I like it." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185190 (https://phabricator.wikimedia.org/T68944) (owner: 10Bgerstle) [18:58:33] brion thanks for the reminder. see you there [19:00:33] (03CR) 10Jdlrobson: [C: 04-1] "getting close." (038 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) (owner: 10Bmansurov) [19:01:23] 3Mobile-Web: MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases - https://phabricator.wikimedia.org/T56885#982591 (10Jdlrobson) 5Open>3Resolved I can only assume this problem has gone away due to the lack of discussion? [19:04:24] 3Mobile-Web: Scrolling issues in beta with new ReferencesDrawer - https://phabricator.wikimedia.org/T87050#982601 (10Jdlrobson) 3NEW [19:04:27] rmoen: https://phabricator.wikimedia.org/T87050 [19:04:43] 3Mobile-Web: Scrolling issues in beta with new ReferencesDrawer - https://phabricator.wikimedia.org/T87050#982609 (10Jdlrobson) On the example I can scroll on desktop so I assume this is only limited to touch devices? [19:05:04] (03PS11) 10Jdlrobson: Scrollable reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (https://phabricator.wikimedia.org/T87050) (owner: 10Robmoen) [19:08:47] (03PS1) 10Bmansurov: Vertically align the image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185483 (https://phabricator.wikimedia.org/T86800) [19:09:36] (03PS2) 10Dbrant: Use Wikidata description returned by MobileView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184987 [19:12:27] (03PS3) 10Dbrant: Use Wikidata description returned by MobileView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184987 [19:13:38] (03CR) 10BearND: [C: 032] "Nice!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184987 (owner: 10Dbrant) [19:13:58] (03Merged) 10jenkins-bot: Use Wikidata description returned by MobileView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184987 (owner: 10Dbrant) [19:15:35] yo [19:15:38] george is asleep [19:15:50] 3Mobile-Web: Unconfirmed issue with editor Android 4.4.2 default browser - https://phabricator.wikimedia.org/T76619#982629 (10kaldari) I think this is fixed now. Can anyone reproduce? [19:18:32] 3Mobile-Web: VisualEditorOverlay toggle between wikitext and visual editor should use OO.ui.PopupToolGroup - https://phabricator.wikimedia.org/T87051#982633 (10Jdlrobson) 3NEW [19:19:28] (03CR) 10Jdlrobson: "This is becoming a lot of code for a small thing... :-/ maybe this would be better handled in the API response from wikidata?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960) (owner: 10Bmansurov) [19:20:07] jdlrobson: Is this bug resolved now: https://phabricator.wikimedia.org/T66101 ? [19:20:50] (03CR) 10Bmansurov: Represent main menu as a View incorporated in Skin (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) (owner: 10Bmansurov) [19:21:22] jdlrobson: FYI, the reason many of those images weren't using embedding is because the embedding system didn't support RTL flipping. Do you know if that works now? [19:21:48] (03PS9) 10Bmansurov: Represent main menu as a View incorporated in Skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) [19:22:30] 3Mobile-Web: Lots of background images not using data URI embedding - https://phabricator.wikimedia.org/T66101#982648 (10kaldari) Is this bug resolved now? AFAIK, the reason many of those images weren't using embedding is because the embedding system didn't support RTL flipping. So we didn't want to use it for t... [19:27:30] (03CR) 10Bmansurov: "Their formatting of certain things are english only. For example, on https://www.wikidata.org/wiki/Q44387?uselang=ru search for '486 BCE'," [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960) (owner: 10Bmansurov) [19:29:43] 3Mobile-Web, Services, MediaWiki-API: Expose page properties as an API - https://phabricator.wikimedia.org/T78737#982666 (10Anomie) 5Open>3Resolved a:3Anomie There doesn't seem to be anything concrete left to do here. [19:31:28] 3Mobile-Web: Scrolling issues in beta with new ReferencesDrawer - https://phabricator.wikimedia.org/T87050#982669 (10kaldari) @Rmoen Could you test this situation against your current patchset in Gerrit and make sure it is addressed? [19:31:34] 3Mobile-Web: "Desktop" in page footer of Special:Uploads returns Page unavailable - https://phabricator.wikimedia.org/T66986#982671 (10Jdlrobson) a:3Jdlrobson [19:31:46] 3Mobile-Web: Special:History should work on desktop - https://phabricator.wikimedia.org/T66939#982673 (10Jdlrobson) a:3Jdlrobson [19:33:13] 3Mobile-Web: Scrolling issues in beta with new ReferencesDrawer - https://phabricator.wikimedia.org/T87050#982676 (10rmoen) This has been a primary thought of my patch. And I have tested it on IOS 8 simulator and chrome. I will test further. [19:34:25] 3Mobile-Web: Special:History should work on desktop - https://phabricator.wikimedia.org/T66939#982678 (10Jdlrobson) 5Open>3Resolved Looks like this redirects to action=history now. [19:35:12] (03PS1) 10Phuedx: Rename ForeignApi#post to #postWithToken [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185486 (https://phabricator.wikimedia.org/T87006) [19:36:00] alright folks [19:36:02] i'm heading off [19:36:09] as it's ice cream and stargate time! [19:36:20] (you're right, i am /that/ cool) [19:36:48] 3Mobile-Web: Scrolling issues in beta with new ReferencesDrawer - https://phabricator.wikimedia.org/T87050#982691 (10rmoen) @Jdlrobson Correct. In desktop, if you focus the main body you can scroll the page. In Mobile, touches outside the drawer and scrolling beyond the drawer prevents body from scrolling. [19:36:55] 3Mobile-Web: [GlobalTitleFail] RequestContext::getTitle called by MobileContext::isBlacklistedPageInternal/ContextSource::getTitle/RequestContext::getTitle with no title set. - https://phabricator.wikimedia.org/T78414#982693 (10KLans_WMF) Gonna spike this and put it in our next sprint: [19:41:53] 3Mobile-Web, MediaWiki-Search, MediaWiki-extensions-WikibaseRepository, Wikidata: search for WIkidata should use entity selector on mobile as well - https://phabricator.wikimedia.org/T85368#982711 (10kaldari) Any thoughts on which team would be more appropriate to tackle this (mobile or wikidata)? [19:44:27] 3Wikipedia-App-Android-App: Long-press context in History and Saved Pages persists after pressing Back button. - https://phabricator.wikimedia.org/T87052#982712 (10Dbrant) 3NEW [19:44:53] mhurd on second thought, i'm going to take a stretch/snack break [19:44:54] bbiab [19:45:08] (03PS12) 10Robmoen: Scrollable reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (https://phabricator.wikimedia.org/T87050) [19:45:10] 3Mobile-Web, MediaWiki-extensions-WikibaseRepository, Wikidata: Wikidata qualifiers are not shown on mobile - https://phabricator.wikimedia.org/T85366#982720 (10kaldari) Would it make more sense for the mobile team to fix this bug or the wikidata team? [19:45:48] 3Mobile-Web: VisualEditorOverlay toggle between wikitext and visual editor should use OO.ui.PopupToolGroup - https://phabricator.wikimedia.org/T87051#982721 (10Jdforrester-WMF) You could use DropdownWidget or PopupButtonWidget – see https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/index.html#widgets-mediawiki-vec... [19:49:01] whee [19:49:11] lunch sounds good [19:49:12] brb [19:50:22] (03PS1) 10Jdlrobson: Surface mobile special pages on desktop [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185489 (https://phabricator.wikimedia.org/T66986) [19:50:37] 3Mobile-Web, MediaWiki-extensions-WikibaseRepository, Wikidata: Wikidata qualifiers are not shown on mobile - https://phabricator.wikimedia.org/T85366#982746 (10Lydia_Pintscher) I think the next step is figuring out why they are not shown. And for that the mobile team is probably better. [19:50:44] bgerstle: sounds good. hangout in half hour or so? [19:52:59] 3Mobile-Web, MediaWiki-Search, MediaWiki-extensions-WikibaseRepository, Wikidata: search for WIkidata should use entity selector on mobile as well - https://phabricator.wikimedia.org/T85368#982758 (10Lydia_Pintscher) If you have spare cycles please do. I have no idea when we'll have them unfortunately. [19:54:09] 3Mobile-Web: In mobile sidebar, last item border styling is inconsistent - https://phabricator.wikimedia.org/T1160#982769 (10kaldari) @KHammerstein Ping. [19:54:19] 3Mobile-Web, MediaWiki-extensions-WikibaseRepository, Wikidata: Wikidata qualifiers are not shown on mobile - https://phabricator.wikimedia.org/T85366#982770 (10Jdlrobson) They are not shown because we hid them.... (not showing them is better than showing them broken) http://wikidata.org/wiki/MediaWiki:Mobile.cs... [19:54:27] kaity: Can you take a look at https://phabricator.wikimedia.org/T1160 ? [19:57:52] 3Mobile-Web, MediaWiki-extensions-WikibaseRepository, Wikidata: Wikidata qualifiers are not shown on mobile - https://phabricator.wikimedia.org/T85366#982792 (10Jdlrobson) (.wb-snaklistview is display:none;} FWIW personally I think this show be hidden by default on mobile and revealable - the interface can look... [19:58:19] mhurd lemme test your search change real quick so we can close that out [19:58:22] 3Mobile-Web, MediaWiki-extensions-WikibaseRepository, Wikidata: Wikidata qualifiers are not shown on mobile - https://phabricator.wikimedia.org/T85366#982799 (10Lydia_Pintscher) Aha! Ok. Makes sense. And yes. Still the case. It really depends how much work this is going to be for you to fix. I don't want to make... [19:58:32] bgerstle: ah cool! [19:58:40] 3Mobile-Web, MediaWiki-extensions-Thanks: Thanks given via mobile are not shown on desktop history page - https://phabricator.wikimedia.org/T61207#982801 (10KLans_WMF) Tracking investigation here: https://trello.com/c/lPevpVxS/200-bug-t61297-thanks-given-via-mobile-are-not-shown-on-desktop-history-page [20:00:18] kaldari|2: Sure [20:00:32] mhurd OTOH looks like dr0ptp4kt and coreyfloyd already +1'd it. not sure if it needs further review [20:00:48] bgerstle: your call [20:00:49] 3Wikipedia-App-iOS-App: Leading image rendered differently from Android. - https://phabricator.wikimedia.org/T87055#982810 (10Etonkovidova) 3NEW [20:00:57] i think 2 sets of eyes are enough [20:01:01] k [20:01:35] 3Mobile-Web: "center" does not center non-thumb image on tablets - https://phabricator.wikimedia.org/T76945#982818 (10kaldari) @jdlrobson Is there still an unresolved question here or can we go ahead and fix this? [20:02:46] 3Mobile-Web, MediaWiki-extensions-WikibaseRepository, Wikidata: Wikidata qualifiers are not shown on mobile - https://phabricator.wikimedia.org/T85366#982820 (10Lydia_Pintscher) >>! In T85366#982792, @Jdlrobson wrote: > (.wb-snaklistview is display:none;} > FWIW personally I think this show be hidden by default... [20:04:05] jdlrobso_: Any explanation why you moved this card from 'Submit a patch' to 'Open discussions'? Trying to groom all the bugs and want to move this back to 'Submit a patch' [20:04:08] https://phabricator.wikimedia.org/T77931 [20:04:26] There's no discussion in the bug [20:04:31] 3Mobile-Web: In mobile sidebar, last item border styling is inconsistent - https://phabricator.wikimedia.org/T1160#982822 (10KHammerstein) Add a light gray line, the same color and size and spacing as the other lines, below login/username. {F29139} [20:06:51] (03CR) 10Jdlrobson: [C: 031] "Just need to test!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185486 (https://phabricator.wikimedia.org/T87006) (owner: 10Phuedx) [20:06:51] 3Mobile-Web: No easy way to edit redirect pages - https://phabricator.wikimedia.org/T71124#982827 (10kaldari) 5Open>3declined a:3kaldari I think we're going to stick with the current behavior for now. [20:07:15] kaldari|2: an you move https://gerrit.wikimedia.org/r/181225 along? [20:07:31] kaldari|2: in terms of the bug not clear how to do this [20:08:17] 3Mobile-Web: Log common JavaScript exceptions - https://phabricator.wikimedia.org/T77931#982831 (10Jdlrobson) This needs discussion before someone can submit a patch for it. We should talk about 1) whether this is a good idea 2) if it is possible 3) What we log / how we do it [20:09:00] 3Mobile-Web: Log common JavaScript exceptions - https://phabricator.wikimedia.org/T77931#831953 (10Jdlrobson) (note if we logged every exception via eventlogging if the exception hit all our users that would be a lot of events) [20:12:29] (03CR) 10Jdlrobson: [C: 032] Rename ForeignApi#post to #postWithToken [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185486 (https://phabricator.wikimedia.org/T87006) (owner: 10Phuedx) [20:15:14] (03Merged) 10jenkins-bot: Rename ForeignApi#post to #postWithToken [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185486 (https://phabricator.wikimedia.org/T87006) (owner: 10Phuedx) [20:15:17] jdlrobson: Thanks for updating the bug. I created a spike for it. I'll try to take a look at the rest of the infobox stuff today. [20:15:30] (03CR) 10Jdlrobson: [C: 04-1] "Getting issues:" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) (owner: 10Bmansurov) [20:18:35] (03CR) 10Jdlrobson: [C: 032] Vertically align the image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185483 (https://phabricator.wikimedia.org/T86800) (owner: 10Bmansurov) [20:18:55] 3Mobile-Web: Photo uploads broken locally - https://phabricator.wikimedia.org/T87006#982865 (10Jdlrobson) 5Open>3Resolved [20:20:02] (03Merged) 10jenkins-bot: Vertically align the image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185483 (https://phabricator.wikimedia.org/T86800) (owner: 10Bmansurov) [20:21:46] (03PS18) 10Jdlrobson: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 [20:22:42] jdlrobson: hey, what kind of fixme are you referring to? [20:23:26] (03PS10) 10Bmansurov: Represent main menu as a View incorporated in Skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) [20:24:12] (03PS10) 10Paladox: Convert to globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 [20:24:53] (03PS19) 10Jdlrobson: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 [20:25:10] 3Mobile-Web: Images are top-aligned in image viewer - https://phabricator.wikimedia.org/T86800#982873 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [20:28:27] (03PS1) 10Dbrant: Properly handle back button in long-press contexts. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185537 (https://phabricator.wikimedia.org/T87052) [20:29:13] (03CR) 10Kaldari: Sample MobileWebClickTracking events at 50% (to reduce load on EventLogging) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185246 (owner: 10Kaldari) [20:29:50] (03CR) 10jenkins-bot: [V: 04-1] Properly handle back button in long-press contexts. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185537 (https://phabricator.wikimedia.org/T87052) (owner: 10Dbrant) [20:31:27] ok where was i, got lost on wikitech-l :D [20:32:30] (03CR) 10Brion VIBBER: [C: 032] "Looks good. :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184970 (owner: 10Fjalapeno) [20:32:36] (03PS2) 10Dbrant: Properly handle back button in long-press contexts. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185537 (https://phabricator.wikimedia.org/T87052) [20:33:16] (03PS2) 10Brion VIBBER: Seamlessly supplement prefix search results with full text results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185124 (owner: 10Mhurd) [20:33:21] rrrrrrebase [20:36:58] (03CR) 10Brion VIBBER: [C: 032] "do it!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185124 (owner: 10Mhurd) [20:41:36] (03CR) 10Jdlrobson: [C: 031] "I worry that for thinks like thanks clicktracking the data sampling would produce would be meaningless." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185246 (owner: 10Kaldari) [20:42:15] FlorianSW, https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8077734 [20:42:18] not sure how it's not clear, but... [20:44:09] Krenair: oha :P [20:45:35] Deskana coreyfloyd what do you guys think about chatting IRL next week instead of meeting at 4:30? [20:45:56] brion: have a minute for quick hangout? [20:46:01] sure [20:46:17] bgerstle i'm good with whenever [20:46:50] bgerstle: Sure, we can do that. [20:47:15] cool, Deskana would you mind canceling the cal event? [20:47:22] bgerstle: Done! [20:47:53] :thumbsup: [20:50:58] dbrant, kristenlans: It's looking like I can't make the 1pm time. [20:51:50] mhurd where's the lead image touch callback? [20:53:16] Deskana should dbrant and I take a stab at it? [20:53:55] 3Mobile-Web, Analytics-Engineering, Analytics-Visualization: generate.py produced broken CSV files - https://phabricator.wikimedia.org/T86059#982917 (10Milimetric) so weird! always 711, 84... hm... (debugging this guys, don't worry I'll fix it soon) also, fyi, we're getting the green light to make this better... [20:54:00] kristenlans, dbrant: Or we can tweak the time, I'm pretty free this afternoon. [20:54:08] bgerstle: isn’t one yet. lead image stuffs just completed a few days ago. [20:54:15] oh ok [20:54:17] i can add one [20:54:42] bgerstle: cool [20:54:42] (03CR) 10Jdlrobson: [C: 04-1] "I'd suggest we make this beta only to start with (move methods to ReferenceDrawerBeta) and play with it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (https://phabricator.wikimedia.org/T87050) (owner: 10Robmoen) [20:55:06] ^ rmoen if it's beta only i'm happy to merge it. I think it's gonna need a few more tweaks before pushing out to all our users [20:55:37] jdlrobson: ok i'm fine with that [20:55:54] rmoen: if you get that done today i'll merge it before end of day [20:56:16] 3MediaWiki-extensions-CommonsMetadata, Multimedia, Wikipedia-App-Android-App: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#982921 (10Tgr) p:5Triage>3High [20:56:23] 3MediaWiki-extensions-CommonsMetadata, Multimedia, Wikipedia-App-Android-App: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#982922 (10Tgr) a:3Tgr [20:56:31] jdlrobson: sounds good [20:57:39] Deskana I'm pretty flat out for the rest of the day [20:57:57] But you and dbrant coudl go ahead without me at another time later today? [20:58:52] brion: how do I notify the PullToRefreshViewController that the refresh is complete? [20:59:06] hmm lemme check [21:00:19] coreyfloyd: excellent question :D [21:00:22] wtf that should be clearer hehe [21:00:42] mhurd did you say you already wrote a collection view controller w/ full screen items? [21:00:46] handling rotating etc.? [21:01:07] yeah - I thought there would just a public method like "completeRefresh" [21:01:56] kristenlans: Deskana: we could just pospone til later... those aren't super critical, are they? [21:02:58] coreyfloyd: you know, i think it just resets when you scroll up…. code feels kinda janky there [21:03:14] ah [21:03:29] bgerstle: no. the nearby controller uses one but it’s tied into the storyboard silliness so i can reuse the common top nav bits. since this gallery stuff is fullscreen it shouldn’t need to tie into any of those bits, so your “view controllers/image gallery” should be able to be much more self contained [21:03:43] ok [21:03:44] coreyfloyd: ok i think you’re meant to run a separate progress indicator for the actual refresh stage [21:03:48] loves me some green grass :wink: [21:03:52] dbrant fine by me [21:04:30] coreyfloyd: i believe the workflow is ‘pull, release, it goes up, then refresh happens’ [21:04:57] brion: ok so its not like the standard control where it stays exposed until refresh is complete? [21:05:01] brion: was the search patch ( https://gerrit.wikimedia.org/r/#/c/185124/ ) looking merge-ready? [21:05:18] brion: oh and i’ll finish testing your data import patch after lunch if that’s ok [21:05:27] mhurd: yeah pushing the button now [21:05:31] i must have pushed it wrong again :D [21:05:32] :) [21:05:40] coreyfloyd: no. we might want to change that though! [21:05:49] no. or yes? yes to the no it’s not the same [21:07:01] brion: coreyfloyd because the refresh bits are used elsewhere and are due for some ux/design love soon maybe put off visual changes to it for the time being? [21:07:16] probably wise, leave that to next week ;) [21:07:31] scope all the things! [21:08:08] ok - got it - thanks guys [21:08:27] lunch and stuff back in an hr or so [21:08:36] mhurd: for MWKImageMetadata do you want just those specific fields, or a full dictionary interface for everything that gets returned? [21:09:06] i can easily expose both actually [21:09:08] that might be easiest [21:09:12] brion: hmm… not sure? [21:09:20] just store a dict and expose some as properties :D [21:09:26] brion: sure! [21:09:33] sweet [21:09:55] ok off to the foods [21:09:57] :) [21:14:05] (03CR) 10Robmoen: "If you're seeing the window scroll when scrolling to the end of the drawer, this is not intended. I tested very thoroughly in chrome and " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (https://phabricator.wikimedia.org/T87050) (owner: 10Robmoen) [21:25:06] brion: new one - what does "needsRefresh" on the MKWArticle do? I thought it would force the article to be redownloaded, but that doesn't seem to be true [21:25:21] coreyfloyd: i believe that’s what it’s meant to do but it may be kinda wonky [21:25:32] heh [21:31:01] 3Wikipedia-App-Android-App: Add explanation of app permissions used to Play Store listing - https://phabricator.wikimedia.org/T87064#983013 (10bearND) 3NEW [21:32:46] bearND|food: able to jump on the hangout? [21:33:03] dr0ptp4kt: which one? [21:33:14] with moizsyed [21:33:26] bearND: https://plus.google.com/hangouts/_/wikimedia.org/share-a-fact?authuser=0 [21:33:40] dr0ptp4kt: moizsyed: coming [21:37:44] 3Wikipedia-App-Android-App: Imagemap does not fit the screen - https://phabricator.wikimedia.org/T87066#983056 (10Etonkovidova) 3NEW [21:39:49] (03CR) 10Jdlrobson: [C: 032] "WFM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) (owner: 10Bmansurov) [21:43:02] (03Merged) 10jenkins-bot: Represent main menu as a View incorporated in Skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184832 (https://phabricator.wikimedia.org/T86238) (owner: 10Bmansurov) [21:43:49] (03PS1) 10Jdlrobson: Hygiene: Split up mobile.head module into submodules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185547 [21:44:11] 3Wikipedia-App-iOS-App: Image map is not clickable - https://phabricator.wikimedia.org/T87067#983073 (10Etonkovidova) 3NEW [21:45:39] (03PS1) 10Brion VIBBER: (Work in progress) MWKImageMetadata object interface [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185548 [21:47:07] (03PS1) 10Dbrant: Fix checkstyle (parameter count) in PageProperties. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185549 [21:51:30] (03CR) 10Jdlrobson: "I can replicate this on Android Chrome, so possible it's just a bug there." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (https://phabricator.wikimedia.org/T87050) (owner: 10Robmoen) [21:52:24] 3Mobile-Web: Main menu should be represented as a View incorporated in Skin - https://phabricator.wikimedia.org/T86238#983094 (10Jdlrobson) 5Open>3Resolved [21:54:51] 3Mobile-Web: Filename scraping for image viewer should support - https://phabricator.wikimedia.org/T86467#983097 (10Jdlrobson) I don't understand this bug could you reword it? [21:55:48] mhurd i need to step out for a bit, might not be back until later, and then maybe not very long [21:56:02] i got some scaffolding in place and was adding the native hook for lead image taps [21:56:13] i can push what i have to a branch for you to see (on my GH fork) [21:56:19] looks like monte fell off irc :) [21:56:26] d'oh [21:56:41] anyone seen kaldari? [21:56:49] i've been trying to get hold of him for last hour [21:56:52] is he off today? [21:57:21] i saw him around this morning i think online [21:58:14] (03CR) 10Jdlrobson: [C: 032] Infinite scrolling on Special:EditWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184352 (owner: 10Jhernandez) [22:00:34] brion: yeh same :/ wondered if he'd left for afternoon though. I sent him a mail [22:00:45] (03PS13) 10Robmoen: Scrollable reference drawer beta behavior [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (https://phabricator.wikimedia.org/T87050) [22:01:08] jdlrobson, he might be commuting to office atm [22:02:03] 3Mobile-Web, Analytics-Engineering, Analytics-Visualization: generate.py produced broken CSV files - https://phabricator.wikimedia.org/T86059#983110 (10Milimetric) 5Open>3Resolved The files had things like 711,84 in them because something (either generate.py or a person who had a editing hiccup while they w... [22:03:44] jdlrobson: i think he's working from home today [22:05:09] (03CR) 10Robmoen: [C: 04-1] "Ahhh, Android chrome. I've moved this to beta and will do some fiddling in android chrome to see If this can be remedied before the merg" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (https://phabricator.wikimedia.org/T87050) (owner: 10Robmoen) [22:08:03] brion: he just showed up :D [22:08:09] \o/ [22:10:36] bb in an hour [22:12:57] 3Mobile-Web: Lots of background images not using data URI embedding - https://phabricator.wikimedia.org/T66101#983141 (10Jdlrobson) a:3Jdlrobson Not quite. Let me wrap this bug up. Fix on way. [22:14:31] (03PS1) 10Jdlrobson: Use data uris everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185558 (https://phabricator.wikimedia.org/T66101) [22:16:39] 3Mobile-Web: Another icon misaligned in search alpha - https://phabricator.wikimedia.org/T87047#983156 (10Jdlrobson) a:3Jdlrobson [22:18:38] bearND, dr0ptp4kt: We'll put any Share a Fact follow-up in a new card and design, estimate, prioritise, etc. :-) [22:18:54] Deskana: thx [22:20:22] Deskana: dr0ptp4kt: I think we need at least two new cards: one for the preview thing, and another for the restyling of the image [22:20:49] bearND: Deskana agreed [22:22:10] (03PS1) 10Jdlrobson: Fix misaligned search clear icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185560 (https://phabricator.wikimedia.org/T87047) [22:22:12] (03PS1) 10Jdlrobson: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185561 [22:24:07] bgerstle: quick hangout? i just realized a couple issues... [22:24:47] 3Wikipedia-App-iOS-App: The state of "Next" button in iOS-app should be disabled unless any edit has been done - https://phabricator.wikimedia.org/T87070#983188 (10Ryasmeen) 3NEW [22:28:15] 3Wikipedia-App-Android-App: Network error when entering gallery while reading page in another language - https://phabricator.wikimedia.org/T87071#983202 (10bearND) 3NEW [22:29:59] mhurd: partly-done MWKImageMetadata interface in https://gerrit.wikimedia.org/r/#/c/185548/ — lemme know if that looks sane and i’ll poke a little more at it [22:30:32] brion: yay! will do after this meeting v vibha [22:32:12] ok [22:34:55] 3Wikipedia-App-Android-App: Crashes caused by android.content.res.Resources$NotFoundException - https://phabricator.wikimedia.org/T76952#983212 (10Krenair) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8077619 - res/drawable-hdpi/title_bar_shadow.9.png [22:35:33] (03PS1) 10Kaldari: Promoting new table styles from beta to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185564 [22:35:38] bearND, think we've seen these before, new version though: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8076862 [22:37:55] (03PS1) 10Jdlrobson: Alpha login form tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185565 [22:38:26] (03PS2) 10Kaldari: Promoting new table styles from beta to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185564 [22:40:55] (03CR) 10jenkins-bot: [V: 04-1] Alpha login form tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185565 (owner: 10Jdlrobson) [22:41:58] (03PS2) 10Jdlrobson: Alpha login form tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185565 [22:42:21] Krenair: looks familiar but I think it's a few lines after the ones we previously fixed. I just wish NPE's would tell us which variable is null. There are two possibilities on the reported line. [22:42:32] 3Wikipedia-App-Android-App: Out of space errors causing app to crash - https://phabricator.wikimedia.org/T87073#983227 (10Krenair) 3NEW [22:43:48] (03PS2) 10Brion VIBBER: (Work in progress) MWKImageMetadata object interface [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185548 [22:44:03] (03PS3) 10Jdlrobson: Alpha login form tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185565 [22:58:40] 3Mobile-Web: Unconfirmed issue with editor Android 4.4.2 default browser - https://phabricator.wikimedia.org/T76619#983260 (10kaldari) 5Open>3Resolved a:3kaldari Hopefully this was fixed when we resolved all the weird browser bugs with editing. [23:00:17] Deskana: wrappign up a health check be in meetign a few mins late [23:00:59] (03CR) 10Kaldari: "Maryana said she would be fine if we dropped all the non-WikiGrok clicktracking entirely for a temporary period, but obviously that would " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185246 (owner: 10Kaldari) [23:04:25] 3Wikipedia-App-Android-App, Mobile-Apps: Edit pencil showing up on top of infoboxes. - https://phabricator.wikimedia.org/T87068#983272 (10bearND) [23:05:50] tfinc: i think the session was killed. i rejoined [23:10:29] (03CR) 10BearND: [C: 032] "Love the idea of using tags. Slick!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185537 (https://phabricator.wikimedia.org/T87052) (owner: 10Dbrant) [23:12:25] (03Merged) 10jenkins-bot: Properly handle back button in long-press contexts. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185537 (https://phabricator.wikimedia.org/T87052) (owner: 10Dbrant) [23:22:02] (03CR) 10Kaldari: [C: 032] User friendly dates for wikidata infobox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960) (owner: 10Bmansurov) [23:23:26] (03Merged) 10jenkins-bot: User friendly dates for wikidata infobox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960) (owner: 10Bmansurov) [23:24:23] (03CR) 10Kaldari: [C: 032] Regression: Show more link again on watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185241 (owner: 10Jdlrobson) [23:25:34] (03CR) 10Kaldari: [C: 032] Fix misaligned search clear icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185560 (https://phabricator.wikimedia.org/T87047) (owner: 10Jdlrobson) [23:25:36] is kaldari in our dimension? he works, but is invisible? :P [23:25:51] (03Merged) 10jenkins-bot: Regression: Show more link again on watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185241 (owner: 10Jdlrobson) [23:25:55] (03CR) 10jenkins-bot: [V: 04-1] Infinite scrolling on Special:EditWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184352 (owner: 10Jhernandez) [23:27:55] 3Mobile-Web: Recruit volunteers via the JavaScript console - https://phabricator.wikimedia.org/T85815#983304 (10Jdlrobson) a:3Jdlrobson [23:36:29] IT'S MY SIX MONTH WMF ANNIVERSARY!!!! [23:36:35] 3Mobile-Web: Upload page-action button sometimes visible, sometimes not - https://phabricator.wikimedia.org/T87075#983311 (10kaldari) 3NEW [23:36:59] Deskana sorry to miss that last meeting, got caught up in another one [23:39:11] (03CR) 10Bmansurov: [C: 032] Hygiene: Split up mobile.head module into submodules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185547 (owner: 10Jdlrobson) [23:39:38] congratulations kristenlans how's it going after six months? [23:40:17] chrismcmahon: loving it. Never a dull day :D [23:40:33] (03Merged) 10jenkins-bot: Hygiene: Split up mobile.head module into submodules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185547 (owner: 10Jdlrobson) [23:40:59] kristenlans: in two weeks I'll be three years and I feel about the same :-) [23:41:17] chrismcmahon: haha, that's good to hear :-) [23:43:17] (03CR) 10Kaldari: [C: 032] Use data uris everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185558 (https://phabricator.wikimedia.org/T66101) (owner: 10Jdlrobson) [23:43:44] (03CR) 10Bmansurov: [C: 032] Hygiene: Retrieve pageApi instance using module loader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183648 (owner: 10Jdlrobson) [23:44:37] (03Merged) 10jenkins-bot: Use data uris everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185558 (https://phabricator.wikimedia.org/T66101) (owner: 10Jdlrobson) [23:45:54] (03Merged) 10jenkins-bot: Fix misaligned search clear icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185560 (https://phabricator.wikimedia.org/T87047) (owner: 10Jdlrobson) [23:45:56] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Retrieve pageApi instance using module loader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183648 (owner: 10Jdlrobson) [23:46:08] (03PS3) 10Brion VIBBER: (Work in progress) MWKImageMetadata object interface [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185548 [23:46:47] huh [23:46:48] rebased cleanly in the ui that time [23:46:49] mhurd: try that one see if it works :D [23:46:56] brion: k [23:47:53] brion: oh i meant the patch from the 15th - https://gerrit.wikimedia.org/r/#/c/184716/ [23:48:00] hah ok [23:48:03] lemme poke that one [23:48:15] yeah some path conflict [23:48:19] whee manual rebase time! [23:49:56] hah it’s the localizable files :D [23:50:39] (03PS6) 10Brion VIBBER: Activity indicator screen and background thread for conversion [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184716 [23:51:49] kristenlans: 'Tis fine. [23:53:00] (03CR) 10Brion VIBBER: "(some inline notes)" (034 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184716 (owner: 10Brion VIBBER) [23:53:11] mhurd: ok lemme make a couple tweaks in response to comments [23:54:57] (03CR) 10Fjalapeno: "left some comments" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184716 (owner: 10Brion VIBBER) [23:57:50] (03CR) 10Fjalapeno: "some were stuck in draft…" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184716 (owner: 10Brion VIBBER) [23:59:28] lemme rename that class too\