[00:12:52] (03PS1) 10Deskana: More aggressively disable autocorrect on username fields [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185934 (https://phabricator.wikimedia.org/T87208) [00:23:01] (03CR) 10BearND: [C: 04-1] "It works. Only minor thing is in create account: When "Display password" is on the the password EditText still shows the suggestions." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185934 (https://phabricator.wikimedia.org/T87208) (owner: 10Deskana) [00:30:16] (03PS2) 10Deskana: More aggressively disable autocorrect on username fields [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185934 (https://phabricator.wikimedia.org/T87208) [00:45:53] (03CR) 10Bmansurov: [C: 04-1] Alpha: Read in another project overlay button (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185920 (owner: 10Jdlrobson) [00:57:45] (03PS1) 10Jdlrobson: Hygiene: Make banner image configurable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185941 [00:57:47] (03PS1) 10Jdlrobson: WIP Alpha: Introduce commons gallery overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185942 [01:02:43] (03CR) 10BearND: [C: 032] More aggressively disable autocorrect on username fields [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185934 (https://phabricator.wikimedia.org/T87208) (owner: 10Deskana) [01:03:03] (03CR) 10Bmansurov: [C: 032] Hygiene: Make banner image configurable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185941 (owner: 10Jdlrobson) [01:03:05] (03Merged) 10jenkins-bot: More aggressively disable autocorrect on username fields [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185934 (https://phabricator.wikimedia.org/T87208) (owner: 10Deskana) [01:04:23] (03Merged) 10jenkins-bot: Hygiene: Make banner image configurable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185941 (owner: 10Jdlrobson) [01:05:44] (03PS4) 10BearND: Add documentation for undocumented messages, and remove unused messages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185789 (owner: 10Deskana) [01:05:52] (03CR) 10BearND: [C: 032] Add documentation for undocumented messages, and remove unused messages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185789 (owner: 10Deskana) [01:06:19] (03Merged) 10jenkins-bot: Add documentation for undocumented messages, and remove unused messages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185789 (owner: 10Deskana) [01:07:28] 3Wikipedia-App-Android-App: Disable autocorrect on the username entry field - https://phabricator.wikimedia.org/T87208#986185 (10Deskana) 5Open>3Resolved a:3Deskana The above patch should fix the problem on devices that ignored the solution we were using before. Maybe we can remove this hack once device m... [01:11:33] 3Wikipedia-App-Android-App: Disable autocorrect on the username entry field - https://phabricator.wikimedia.org/T87208#986202 (10bearND) @ori would you mind trying this with the next Alpha build, which should be ready in about 25 min. at http://android-builds.wmflabs.org/. Thanks! [01:47:49] (03PS2) 10Jdlrobson: Alpha: Introduce commons gallery overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185942 [02:08:50] 3Wikipedia-App-iOS-App: iOS App: make "Username", "Password" and "Confirm password" fields required in order to submit account creation request - https://phabricator.wikimedia.org/T68944#986291 (10Deskana) 5Open>3Resolved Fixed by the above patch, which was merged. [03:05:44] (03PS1) 10BearND: Make checkboxes visible in dark mode on 4.x [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185955 (https://phabricator.wikimedia.org/T85809) [03:09:24] 3Wikipedia-App-Android-App: Add an easier and faster way to change the search language - https://phabricator.wikimedia.org/T87154#986328 (10Deskana) [04:56:58] (03PS1) 10Deskana: Add 1:100 sampling rate for table of contents interaction. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185957 [06:19:14] 3MediaWiki-extensions-PageImages, Wikipedia-App-Android-App: an irrelevant image is shown as the header for Hebrew Wikipedia articles about cities in Israel - https://phabricator.wikimedia.org/T87153#986376 (10Deskana) >>! In T87153#985799, @eranroz wrote: > Added the file to https://he.wikipedia.org/wiki/MediaW... [06:44:59] (03PS12) 10MaxSem: WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [06:45:34] (03CR) 10jenkins-bot: [V: 04-1] WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [09:07:31] 3MediaWiki-extensions-PageImages, Wikipedia-App-Android-App: an irrelevant image is shown as the header for Hebrew Wikipedia articles about cities in Israel - https://phabricator.wikimedia.org/T87153#986503 (10eranroz) Yes, it works [09:37:41] 3Mobile-Web: Portal pages on mobile should be blacklisted - https://phabricator.wikimedia.org/T86495#986537 (10John_of_Reading) There are CSS classes available that improve the appearance, but most portals have not been edited to use them. See https://en.wikipedia.org/wiki/Wikipedia_talk:Portal#Portals_on_the_mo... [17:24:13] (03PS3) 10Jdlrobson: Alpha: Read in another project overlay button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185920 [17:31:36] jdlrobson: You in the office today? [17:31:43] Reedy: yup :D just sat down [17:32:51] I think the scones will need eating fairly quickly [17:33:01] Was hard to get any with a long ish best before date [17:34:35] (03CR) 10Jdlrobson: Alpha: Read in another project overlay button (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185920 (owner: 10Jdlrobson) [17:35:23] Reedy: (!!!!) [17:35:32] jdlrobson: But I did get jam and lemon curd too [17:35:38] So I'm sure that wn't be hard :P [17:35:39] wooo!! tea and scones for afternoon tea!!! [17:35:57] I'll upload a photo to officewiki later and mail it round [17:39:08] (03PS3) 10Jdlrobson: Alpha: Introduce commons gallery overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185942 [17:39:10] (03PS1) 10Jdlrobson: Hygiene: Generalize photo list / gallery code for use elsewhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/186000 [17:39:10] Reedy: :D [17:48:46] (03PS4) 10Jdlrobson: Alpha: Introduce commons gallery overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185942 [17:58:35] 3MediaWiki-extensions-PageImages, Wikipedia-App-Android-App: an irrelevant image is shown as the header for Hebrew Wikipedia articles about cities in Israel - https://phabricator.wikimedia.org/T87153#986846 (10Krenair) 5Open>3Invalid a:3Krenair Okay, setting this to invalid because it was resolved by an on... [18:02:26] 3MediaWiki-extensions-PageImages, Wikipedia-App-Android-App: an irrelevant image is shown as the header for Hebrew Wikipedia articles about cities in Israel - https://phabricator.wikimedia.org/T87153#986851 (10Deskana) >>! In T87153#986503, @eranroz wrote: > Yes, it works It's still showing the circle as a lead... [18:03:26] (03CR) 10Jdlrobson: [C: 04-1] Use events map in overlay files (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185929 (https://phabricator.wikimedia.org/T87193) (owner: 10Bmansurov) [18:04:08] (03CR) 10Jdlrobson: "(you also have mwext-MobileFrontend-npm issues)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185908 (https://phabricator.wikimedia.org/T86231) (owner: 10Bmansurov) [18:04:43] (03PS4) 10Jdlrobson: Allow other token types with foreign api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185581 [18:04:48] (03CR) 10Jdlrobson: [C: 032] Allow other token types with foreign api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185581 (owner: 10Jdlrobson) [18:05:15] (03PS4) 10Jdlrobson: Alpha login form tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185565 [18:08:38] Alright, heading to the office. See you soon! [18:10:53] (03Merged) 10jenkins-bot: Allow other token types with foreign api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185581 (owner: 10Jdlrobson) [18:31:14] 3Wikipedia-App-Android-App: Crashes caused by android.content.res.Resources$NotFoundException - https://phabricator.wikimedia.org/T76952#986912 (10Krenair) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8083454 - res/drawable-hdpi/title_bar_shadow.9.png [18:42:16] 3Project-Creators, Mobile-Web: Split off #Browser-Support-Opera-12 from #Browser-Support-Opera - https://phabricator.wikimedia.org/T76302#986955 (10Aklapper) p:5Low>3Volunteer? @matmarex: See my questions in T76302#796189 (first part before I unfortunately answered the braoder part). We talk about 15 open ti... [18:45:54] 3Wikipedia-App-Android-App: Consider background for images with transparency - https://phabricator.wikimedia.org/T87250#986966 (10Krenair) 3NEW [18:46:34] 3Wikipedia-App-Android-App: Consider background for images with transparency - https://phabricator.wikimedia.org/T87250#986982 (10Krenair) [18:48:26] 3MediaWiki-extensions-LdapAuthentication, Mobile-Web: MobileFrontend extension does not support LdapAuthentication - https://phabricator.wikimedia.org/T65328#986985 (10Jdlrobson) This should be working in alpha now. If it's not we will need to tweak the #MediaWiki-extensions-LdapAuthentication extension. Is anyo... [18:48:39] 3Mobile-Web, MediaWiki-extensions-OpenID: Mobile login not compatible with OpenID - https://phabricator.wikimedia.org/T54059#986986 (10Jdlrobson) This should be working in alpha now. If it's not we will need to tweak the #MediaWiki-extensions-OpenID; extension. Is anyone able to test this? I'm happy to help. [18:50:30] 3Mobile-Web: Portal pages on mobile should be blacklisted - https://phabricator.wikimedia.org/T86495#986992 (10Jdlrobson) Thanks @John_of_Reading I didn't realise someone was looking into this. How can we help speed this a long? Is it possible for all portals to use a generic template in the work you propose?... [19:00:50] 3Mobile-Web: Search results showing as red links - https://phabricator.wikimedia.org/T87252#987004 (10Jdlrobson) 3NEW [19:01:01] 3Mobile-Web: Search results showing as red links - https://phabricator.wikimedia.org/T87252#987011 (10Jdlrobson) new class shouldn't be on the elements [19:04:29] (03PS22) 10Jdlrobson: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 [19:05:23] 3Mobile-Web: Create Anchor abstraction - https://phabricator.wikimedia.org/T87253#987013 (10Jdlrobson) 3NEW [19:06:01] 3Mobile-Web: Create button abstraction - https://phabricator.wikimedia.org/T87254#987022 (10Jdlrobson) 3NEW [19:07:16] 3Mobile-Web: Create input abstraction - https://phabricator.wikimedia.org/T87255#987031 (10Jdlrobson) 3NEW [19:07:37] (03CR) 10Jdlrobson: Infobox item editing using oojs-ui (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [19:07:48] hey FlorianSW you around? [19:07:57] https://phabricator.wikimedia.org/T87252 < just noticed this nasty regression [19:09:13] jdlrobson: yeah, i'm here :) ??? How happened this :/ [19:09:17] only in alpha? [19:09:23] FlorianSW: stable too i think [19:09:28] it's related to the watchlist changes i think [19:10:39] * FlorianSW takes a look [19:11:51] (03CR) 10Kaldari: [C: 032] Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [19:12:04] Gosh. [19:13:38] (03Merged) 10jenkins-bot: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [19:16:11] James_F: gosh? [19:16:19] jdlrobson: Landing it! Yay. :-) [19:18:52] (03CR) 10Kaldari: Hygiene: Removing @inheritdoc, no parent function (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185590 (owner: 10Kaldari) [19:20:32] 3Mobile-Web: Search results showing as red links - https://phabricator.wikimedia.org/T87252#987073 (10Florian) a:3Florian [19:21:58] (03PS3) 10Kaldari: Promoting new table styles from beta to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185564 [19:22:05] (03CR) 10jenkins-bot: [V: 04-1] Promoting new table styles from beta to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185564 (owner: 10Kaldari) [19:22:43] 3Mobile-Web: Alpha captcha styling different from stable - https://phabricator.wikimedia.org/T87256#987075 (10Jdlrobson) 3NEW [19:23:14] 3MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), Mobile-Web: Alpha captcha styling different from stable - https://phabricator.wikimedia.org/T87256#987083 (10Jdlrobson) [19:24:16] 3Mobile-Web: Hide account benefits in Minerva version of login page - https://phabricator.wikimedia.org/T87257#987088 (10Jdlrobson) 3NEW [19:24:50] Hey, random question, does mobile do story-points, for estimating tasks? [19:24:51] (03PS1) 10Florianschmidtwelzow: Add css classes explicitly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/186013 (https://phabricator.wikimedia.org/T87252) [19:24:55] jdlrobson: ^^ [19:25:05] FlorianSW: \o/ [19:25:08] quiddity: yes we do [19:25:12] ty :) [19:25:26] FlorianSW: i also think the confirm edit changes might have broken captcha display on the login form in stable [19:25:32] have been unable to verify yes [19:25:36] jdlrobson, quiddity what are story points? [19:26:04] (03CR) 10Jdlrobson: [C: 032] Add css classes explicitly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/186013 (https://phabricator.wikimedia.org/T87252) (owner: 10Florianschmidtwelzow) [19:26:12] jdlrobson: there are no merged commits in confirmedit oO [19:26:28] or have i missed some e-mails :/ [19:27:26] jdlrobson: or what you mean? :) And why stable? *justtestingnow* [19:27:44] FlorianSW: story points are a way of estimating how big a chunk of new work is [19:27:58] so doing something like changing some copy text in a login form might be 1 point of work [19:28:13] whilst building the category overlay might be 8 or 13 points of work [19:28:34] (03PS5) 10Jdlrobson: Improve wikidata infobox style and template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185164 (owner: 10Jhernandez) [19:28:34] ah yeah, that sounds reasonable :) [19:28:47] (03CR) 10Jdlrobson: [C: 031] Improve wikidata infobox style and template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185164 (owner: 10Jhernandez) [19:28:52] (03CR) 10Jdlrobson: [C: 032] Improve wikidata infobox style and template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185164 (owner: 10Jhernandez) [19:29:33] (03CR) 10Jdlrobson: [C: 04-1] "rebase needed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185564 (owner: 10Kaldari) [19:31:44] lol, why i don't see change https://gerrit.wikimedia.org/r/#/c/184912/ in github? [19:31:59] 3Mobile-Web: Captcha not rendering on stable login form - https://phabricator.wikimedia.org/T87260#987133 (10Jdlrobson) 3NEW [19:32:29] (03Merged) 10jenkins-bot: Add css classes explicitly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/186013 (https://phabricator.wikimedia.org/T87252) (owner: 10Florianschmidtwelzow) [19:34:24] (03PS1) 10Jdlrobson: Regression: Restore captcha in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/186014 (https://phabricator.wikimedia.org/T87260) [19:34:40] jdlrobson: now i know, what you mean with ConfirmEdit, i forgot to update mediawiki core :( [19:34:48] ^ FlorianSW [19:34:51] fix already :-) [19:35:03] yeah, i see it \o/ [19:35:43] (03Merged) 10jenkins-bot: Improve wikidata infobox style and template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185164 (owner: 10Jhernandez) [19:37:22] (03CR) 10jenkins-bot: [V: 04-1] Regression: Restore captcha in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/186014 (https://phabricator.wikimedia.org/T87260) (owner: 10Jdlrobson) [19:38:16] 3Mobile-Web: Watermark and no default message not shown in alpha version of login form - https://phabricator.wikimedia.org/T87261#987151 (10Jdlrobson) 3NEW [19:38:33] (03CR) 10Florianschmidtwelzow: Regression: Restore captcha in stable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/186014 (https://phabricator.wikimedia.org/T87260) (owner: 10Jdlrobson) [19:41:19] 3Mobile-Web, MediaWiki-User-login-and-signup: Watermark and no default message not shown in alpha version of login form - https://phabricator.wikimedia.org/T87261#987176 (10Jdlrobson) [19:41:25] (03PS5) 10Jdlrobson: Alpha login form tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185565 (https://phabricator.wikimedia.org/T87257) [19:42:53] (03PS2) 10Jdlrobson: Regression: Restore captcha in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/186014 (https://phabricator.wikimedia.org/T87260) [19:44:37] 3Mobile-Web: Search results showing as red links - https://phabricator.wikimedia.org/T87252#987187 (10Jdlrobson) 5Open>3Resolved [19:46:38] 3Mobile-Web: Portal pages on mobile should be blacklisted - https://phabricator.wikimedia.org/T86495#987190 (10John_of_Reading) I've submitted a request for approval of the bot task at https://en.wikipedia.org/wiki/Wikipedia:Bots/Requests_for_approval/John_of_Reading_Bot_2 [19:49:44] 3MobileFrontend-Feature-requests: Add geolocation functionality to MobileFrontend to support Articles near me - https://phabricator.wikimedia.org/T21920#987201 (10brion) [19:51:37] (03CR) 10Florianschmidtwelzow: [C: 031] Regression: Restore captcha in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/186014 (https://phabricator.wikimedia.org/T87260) (owner: 10Jdlrobson) [19:53:08] 3Mobile-Web: Captcha not rendering on stable login form - https://phabricator.wikimedia.org/T87260#987212 (10Florian) > another reason we should be using core code +++++++++++++++++1! The header field shouldn't be omitted (or moved) :/ [19:54:42] (03PS1) 10BearND: Fix getting gallery image from non primary site. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186017 (https://phabricator.wikimedia.org/T87071) [19:58:28] (03CR) 10jenkins-bot: [V: 04-1] Fix getting gallery image from non primary site. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186017 (https://phabricator.wikimedia.org/T87071) (owner: 10BearND) [20:01:17] (03PS4) 10Kaldari: Promoting new table styles from beta to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185564 [21:23:53] (03CR) 10Jdlrobson: [C: 032] Promoting new table styles from beta to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185564 (owner: 10Kaldari) [21:25:56] (03Merged) 10jenkins-bot: Promoting new table styles from beta to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185564 (owner: 10Kaldari) [21:33:49] mhurd: API slide still needs session info [21:43:12] 3Mobile-Web: Portal pages on mobile should be blacklisted - https://phabricator.wikimedia.org/T86495#987499 (10Jdlrobson) Excellent! Thanks @John_of_Reading!! [21:46:53] 3Mobile-Web: Broken unicode character in mobile footer (ZERO WIDTH NON-JOINER) - https://phabricator.wikimedia.org/T86281#987517 (10Jdlrobson) 5Open>3Resolved Patch was merged [21:47:53] 3Mobile-Web, MediaWiki-API: commons images are always "Last updated 0 seconds ago" - https://phabricator.wikimedia.org/T84906#987520 (10Jdlrobson) [21:48:34] 3MobileFrontend-Feature-requests: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#987522 (10Jdlrobson) [21:49:27] 3Mobile-Web, MediaWiki-Categories: (3) 3 column responsive layout for categories so they render nicely on mobile - https://phabricator.wikimedia.org/T85496#987527 (10Jdlrobson) [21:50:51] 3Mobile-Web, MediaWiki-Parser: Display of images in categories on mobile web site present only one image per row starting at some resolution. - https://phabricator.wikimedia.org/T78174#987531 (10Jdlrobson) This is not actionable so moving back to in discussion. I'm not sure how we solve this one. [21:51:41] 3MobileFrontend-Feature-requests: Should be able to read/search categories inside overlay. - https://phabricator.wikimedia.org/T86497#987533 (10Jdlrobson) [21:53:51] 3Wikipedia-App-Android-App: Crash from RuntimeException: No such message type registered: imageClicked - https://phabricator.wikimedia.org/T87110#987535 (10Krenair) [22:13:05] 3Wikipedia-App-Android-App: Crash from RuntimeException: No such message type registered: imageClicked - https://phabricator.wikimedia.org/T87110#987587 (10Krenair) [22:13:23] MaxSem: help me with some vagrant issues? [22:23:35] 3Mobile-Web, MediaWiki-Parser: Display of images in categories on mobile web site present only one image per row starting at some resolution. - https://phabricator.wikimedia.org/T78174#987625 (10JeanFred) Something I do not get: the desktop site does wrap galleries in categories properly, doesn’t it? [22:38:55] 3Mobile-Web, MediaWiki-Parser: Display of images in categories on mobile web site present only one image per row starting at some resolution. - https://phabricator.wikimedia.org/T78174#987651 (10Jdlrobson) @JeanFred define properly.. if you look closely you will see inline styles setting widths on each of the ga... [22:42:51] 3Mobile-Web: ResourceLoader dependency issues on beta labs - https://phabricator.wikimedia.org/T87272#987657 (10Jdlrobson) 3NEW [22:47:34] MaxSem, dbrant: The app doesn't crash if it doesn't get a lastmodified from the API, so imo you'd be good to remove it. [22:48:05] ok, mhurd - is that fine with you? [22:56:20] (03PS2) 10Jdlrobson: WIP: Fix UploadTutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185850 [23:08:04] 3Mobile-Web: [Tracking] Getting rid of own login page - https://phabricator.wikimedia.org/T74910#987719 (10Jdlrobson) [23:08:05] 3MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), Mobile-Web, MediaWiki-User-login-and-signup: Captcha positioning is inconsistent between JavaScript and non-JavaScript users - https://phabricator.wikimedia.org/T85192#987717 (10Jdlrobson) 5Open>3Resolved [23:20:38] (03PS3) 10Jdlrobson: Fix UploadTutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185850 [23:20:40] (03PS4) 10Jdlrobson: Hygiene: UploadTutorial should use events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185849 [23:20:42] (03PS2) 10Jdlrobson: Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 [23:26:07] (03CR) 10jenkins-bot: [V: 04-1] Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 (owner: 10Jdlrobson) [23:27:39] (03PS3) 10Jdlrobson: Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 [23:29:04] (03CR) 10jenkins-bot: [V: 04-1] Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 (owner: 10Jdlrobson) [23:29:16] (03PS1) 10Dbrant: Fix crash when clicking images in Preview. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186101 (https://phabricator.wikimedia.org/T87110) [23:32:08] (03CR) 10jenkins-bot: [V: 04-1] Fix crash when clicking images in Preview. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186101 (https://phabricator.wikimedia.org/T87110) (owner: 10Dbrant) [23:36:03] (03CR) 10Dbrant: [C: 032] Fix tests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185851 (owner: 10BearND) [23:36:38] (03PS4) 10Jdlrobson: Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 [23:39:43] kaldari: around ? [23:40:16] yes [23:40:44] re: https://phabricator.wikimedia.org/T85525 [23:40:48] Yes, able. Are you deleting using the delete menu or the trash icon ? [23:41:22] 3Mobile-Web: Filename scraping for image viewer should support ugly URLs - https://phabricator.wikimedia.org/T86467#987823 (10MaxSem) [23:43:19] also kaldari , i think it has something to do with the fact the trash icon takes you to desktop view [23:45:15] matanya: Trash icon [23:46:20] matanya: Taking you to the desktop view should be fine. It just does that because there is no mobile interface for deleting. If you start on the desktop site, does it work for you? [23:49:34] kaldari: yes [23:51:28] better scope kaldari :it only happens if i didn't login to desktop view before [23:51:44] if i was, it will take me to the delete page [23:52:09] (03CR) 10Dbrant: [C: 032] "Might be a good idea to factor out the sampling code at some point." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185957 (owner: 10Deskana) [23:53:14] (03PS2) 10Dbrant: Fix getting gallery image from non primary site. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186017 (https://phabricator.wikimedia.org/T87071) (owner: 10BearND) [23:55:46] matanya: good to know. I’ll try reproducing it that way... [23:56:02] dbrant: Don't forget its companion patch: https://gerrit.wikimedia.org/r/#/c/185958/ [23:56:04] dbrant: Thank you :-) [23:56:09] i'll leave a comment on the bug, and head to bed. thanks kaldari ! [23:57:22] dbrant: <3 [23:58:39] dbrant: I was thinking maybe we have a "SampledFunnel" class that extends Funnel and has the sampling logic in an overridden log() method [23:58:51] dbrant: For a more generic sampling method, I mean [23:59:04] Then we change Search and ToC to extend SampledFunnel instead of Funnel [23:59:09] Does that sound like a sensible approach? [23:59:17] Deskana: that would be my thinking, as well [23:59:25] Cool. I'll put that on my refactor list. [23:59:26] dbrant: want to meet in say 30 min for screenshots? [23:59:36] mhurd: yep!