[00:00:05] 3Mobile-Web: Use strict mode in javascript files - https://phabricator.wikimedia.org/T86231#1000050 (10bmansurov) 5Open>3Resolved [00:04:53] 3RESTBase, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1000056 (10Deskana) 3NEW [00:05:13] 3RESTBase, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1000064 (10Deskana) [00:05:16] 3Wikipedia-App-General-or-Unknown, MediaWiki-API: Tracking: API/backend issues blocking Wikipedia app development - https://phabricator.wikimedia.org/T75616#1000063 (10Deskana) [00:05:53] 3RESTBase, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1000066 (10Deskana) [00:06:43] 3RESTBase, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1000056 (10Deskana) [00:11:42] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Removed some svg-to-png inkscape build commands. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187060 (owner: 10Mhurd) [00:13:20] 3RESTBase, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1000086 (10Deskana) AFAIK this should be made possible by the deployment of RESTBase. @gwicke can correct me if I'm wrong. :-) [00:17:05] 3Wikipedia-App-iOS-App: Leading images displayed blurry due to low resolution of the original file - https://phabricator.wikimedia.org/T87827#1000103 (10Etonkovidova) 3NEW [00:17:50] (03PS1) 10Krinkle: Hygiene: Clean up repeated copies and re-assignments in Resources.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187294 [00:22:56] 3Wikipedia-App-iOS-App: When the first image cannot be used as a leading img, select another another available from the page - https://phabricator.wikimedia.org/T87828#1000118 (10Etonkovidova) 3NEW [00:27:54] (03CR) 10Siebrand: [C: 031] WIP [DONOTMERGE]: Add Special:MobileCollections to alpha left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson) [00:28:36] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166089 (https://phabricator.wikimedia.org/T85587) (owner: 10Florianschmidtwelzow) [00:30:26] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [00:41:20] brion ping [00:41:25] yo [00:41:27] or maybe Deskana [00:41:39] brion i know you're a busy dude :-) i have some questions about links in articles [00:41:46] particularly those that point to images [00:41:49] sure [00:42:02] you don't appear to be at your desk [00:42:20] had to run some errands, i’m sitting in a hangout for another meetin gactually :D [00:42:28] oh ;-) [00:42:36] let me bother someone else then [00:42:39] brion: I'm here. What's up? [00:42:42] hehe ok [00:42:49] or schedule some time tomorrow [00:42:49] Deskana where are you? [00:43:01] bgerstle: At home, sick. [00:43:04] oh right ;-/ [00:43:10] my morning’s free tomorrow if you’re still in town [00:43:18] who can answer questions about article html? [00:43:19] max? [00:43:37] try max and see yeah :D [00:43:50] i don't see him.. [00:43:57] in here or at his desk [00:44:11] oh right — it’s wednesday i think he has a dr’s appt for his arm [00:44:14] k [00:44:15] bgerstle: Just ask your question in here and someone can probably answer. [00:44:20] yeah we’ll try :D [00:44:44] are all images in an article surrounded by tags, and how are the link paths constructed? [00:45:03] ah there’s a fun question [00:45:06] i need to be able to pull the image file name out of the URL and see if it's one of the currently-viewed article's images [00:45:15] so _most_ images are linked to the corresponding File: page [00:45:15] BUT [00:45:22] some are overridden to link to other pages [00:45:31] and … i think you can also disable the link, which’ll output with no [00:45:37] and there are probably redirects, etc... [00:45:44] yes things get nasty [00:45:54] ok, well, i guess assuming there _is_ a link [00:45:58] otherwise nothing would happen anyway [00:46:02] when we move to parsoid-based HTML output i think we’ll have cleaner data in the html markup [00:46:09] "when" [00:46:23] for now the safest thing is to scan all src values and extract the filename from the URL [00:46:24] anyway [00:46:29] but that’s akind of nasty to do too :( [00:46:40] If this is about the image viewer then you can probably ask Dmitry how he did whatever it is you're trying to do. [00:46:47] good point [00:46:51] yeah [00:47:03] and do feel free to write up some notes — we can probably improve the markup to make this easier [00:47:11] bearND have a sec? [00:47:24] or dmitry, don't see anything that looks like an IRC handle for him [00:47:57] bgerstle: sure. I'll drop by in a sec. [00:48:14] bearND probably better if i go to you so you can show me android code [00:48:18] ping me when you're available [00:51:30] 3MediaWiki-extensions-MultimediaViewer, Mobile-Web, Multimedia: Mobile Web and Multimedia viewer should use same hash fragment - https://phabricator.wikimedia.org/T87769#1000201 (10Gilles) p:5Triage>3Normal [00:54:39] (03PS1) 10Kaldari: Adding missing period to error message per Siebrand [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187303 [01:05:26] mhurd: dr0ptp4kt brion which of you guys worked on the JS stuff in the iOS app? [01:05:49] bgerstle: i think mhurd did the last major overhaul [01:05:52] ok [01:06:17] bgerstle: ya [01:06:18] (03CR) 10Yurik: "RECHECK" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/187241 (owner: 10Jhobs) [01:12:53] 3Mobile-Web: Move overlayManager and router as defined modules using M.define - https://phabricator.wikimedia.org/T86246#1000241 (10jhobs) Oh yeah we have very few tests and definitely need a bunch to avoid this kind of thing. I'm planning to spend a big portion of this quarter writing a lot of these, but I just... [01:35:47] 3RESTBase, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1000267 (10mobrovac) @Deskana does the workflow described in T87807 make sense? [02:13:17] 3RESTBase, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1000330 (10Deskana) @mobrovac Sounds good to me! One question, though: is the intention for this to provide all the metadata about articles that we use, such as W... [02:18:26] 3RESTBase, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1000335 (10mobrovac) >>! In T87824#1000330, @Deskana wrote: > Is the intention for this to provide all the metadata about articles that we use, such as Wikidata d... [05:18:40] 3Mobile-Web: Move overlayManager and router as defined modules using M.define - https://phabricator.wikimedia.org/T86246#1000429 (10Jdlrobson) I'm more than happy to get some tests written with you. Shouldn't take more than 2 hours to do this at most. Want to pair on this? [05:18:45] 3Mobile-Web: Move overlayManager and router as defined modules using M.define - https://phabricator.wikimedia.org/T86246#1000430 (10Jdlrobson) I'm more than happy to get some tests written with you. Shouldn't take more than 2 hours to do this at most. Want to pair on this? [06:21:08] (03CR) 10Florianschmidtwelzow: "> /srv/deployment/integration/slave-scripts/bin/mw-teardown.sh: No such file or directory" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187233 (https://phabricator.wikimedia.org/T87438) (owner: 10Bmansurov) [06:21:52] yo [06:22:46] 3Wikipedia-App-Android-App: "IndexOutOfBoundsException: Invalid index 0, size is 0" from gallery.GalleryActivity$GalleryItemAdapter.getItem - https://phabricator.wikimedia.org/T87149#1000476 (10Krenair) 5Open>3Resolved a:3Krenair Sounds like this is fixed. [06:23:38] jdlrobson: ping :P [06:24:52] (03CR) 10Florianschmidtwelzow: [C: 031] "Let's see, if it helps us to get more volunteers :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185578 (owner: 10Jdlrobson) [06:26:01] (03CR) 10Florianschmidtwelzow: Recruit volunteers via the JavaScript console (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185578 (owner: 10Jdlrobson) [06:30:27] (03CR) 10Florianschmidtwelzow: [C: 031] "minor :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187303 (owner: 10Kaldari) [06:33:01] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Clean up repeated copies and re-assignments in Resources.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187294 (owner: 10Krinkle) [06:37:29] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185929 (https://phabricator.wikimedia.org/T87193) (owner: 10Bmansurov) [06:42:13] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187233 (https://phabricator.wikimedia.org/T87438) (owner: 10Bmansurov) [06:44:32] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187240 (owner: 10Ricordisamoa) [06:46:43] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185565 (https://phabricator.wikimedia.org/T87257) (owner: 10Jdlrobson) [06:46:52] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 (owner: 10Jdlrobson) [06:47:26] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 (owner: 10Jdlrobson) [07:02:25] (03CR) 10Florianschmidtwelzow: Alpha: Introduce commons gallery overlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185942 (owner: 10Jdlrobson) [07:08:31] (03CR) 10Yurik: "RECHECK" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/187241 (owner: 10Jhobs) [07:12:51] (03PS1) 10BearND: Update Android plugin for Gradle to version 1.0.1 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187332 [07:12:53] (03PS1) 10BearND: Enable Checkstyle via Gradle [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187333 [08:12:24] (03PS1) 10BearND: NPE crash from onPrepareOptionsMenu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187335 (https://phabricator.wikimedia.org/T87109) [08:13:54] (03PS2) 10BearND: Avoid NPE crash from onPrepareOptionsMenu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187335 (https://phabricator.wikimedia.org/T87109) [12:04:41] (03PS1) 10Gerrit Patch Uploader: Implement ChangeTagsListActive hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187354 [12:04:43] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187354 (owner: 10Gerrit Patch Uploader) [16:46:27] (03PS1) 10Jhernandez: WIP: Introduce Mobile collection models [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187395 [16:46:29] (03PS1) 10Jhernandez: WIP: Add Special:Collections page to menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187396 [16:46:31] (03PS1) 10Jhernandez: WIP: Show in Special:Collections the user's Watchlist "collectionized" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187397 [17:40:31] (03CR) 10Bmansurov: [C: 032] Adding missing period to error message per Siebrand [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187303 (owner: 10Kaldari) [17:42:28] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187413 [17:42:36] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187414 [17:43:13] (03Merged) 10jenkins-bot: Adding missing period to error message per Siebrand [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187303 (owner: 10Kaldari) [17:47:20] (03CR) 10Bmansurov: [C: 032] Alpha login form tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185565 (https://phabricator.wikimedia.org/T87257) (owner: 10Jdlrobson) [17:56:29] (03Abandoned) 10BearND: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187414 (owner: 10BearND) [17:59:07] 3Mobile-Web, MediaWiki-extensions-CentralAuth: CentralAuth AutoLogin not working on mobile sites - https://phabricator.wikimedia.org/T87290#1001088 (10csteipp) During login for global accounts (which redirects to loginwiki, then back to the wiki where the user logged in, then usually to the page they were loggin... [17:59:29] (03Merged) 10jenkins-bot: Alpha login form tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185565 (https://phabricator.wikimedia.org/T87257) (owner: 10Jdlrobson) [18:19:52] (03CR) 10Yurik: "RECHECK" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/187241 (owner: 10Jhobs) [18:21:38] (03CR) 10Bmansurov: [C: 032] QA: Enforce requirement of cite extension for references test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187126 (owner: 10Jdlrobson) [18:25:48] Maryana: where do you want to add the asks slide ? [18:25:58] 3Mobile-Web: Move overlayManager and router as defined modules using M.define - https://phabricator.wikimedia.org/T86246#1001164 (10jhobs) I think the tests are fairly straightforward, it's more of a matter of finding the time to do them. I hope to get them out of the way later today, but if I don't then let's s... [18:26:11] tfinc: there's one at the end. did you want to add to it? [18:26:44] Maryana: that one is after the appendix. where do you want to put it within the presentation ? [18:27:06] hm? no, it's right before :) [18:27:09] slide 41 [18:27:22] 42 is appendix [18:28:47] k, i'l remove slide 57 then [18:29:30] slide 41 looks fine as is [18:31:13] (03CR) 10Jdlrobson: [C: 031] Autofill the search input in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187233 (https://phabricator.wikimedia.org/T87438) (owner: 10Bmansurov) [18:31:17] (03PS2) 10Jdlrobson: Autofill the search input in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187233 (https://phabricator.wikimedia.org/T87438) (owner: 10Bmansurov) [18:31:21] (03CR) 10Jdlrobson: [C: 032] Autofill the search input in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187233 (https://phabricator.wikimedia.org/T87438) (owner: 10Bmansurov) [18:33:48] (03Merged) 10jenkins-bot: QA: Enforce requirement of cite extension for references test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187126 (owner: 10Jdlrobson) [18:37:58] (03PS2) 10Jhernandez: Show in Special:Collections the user's Watchlist "collectionized" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187397 [18:38:01] (03PS2) 10Jhernandez: Add Special:Collections page to menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187396 [18:38:03] (03PS2) 10Jhernandez: Introduce Mobile collection models [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187395 [18:38:10] (03PS1) 10Cmcmahon: QA: distinguish history link for no-js users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187438 [18:38:22] 3Mobile-Web: VisualEditorOverlay toggle between wikitext and visual editor should use OO.ui.PopupToolGroup - https://phabricator.wikimedia.org/T87051#1001202 (10bmansurov) a:5bmansurov>3None [18:38:40] (03Merged) 10jenkins-bot: Autofill the search input in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187233 (https://phabricator.wikimedia.org/T87438) (owner: 10Bmansurov) [18:40:20] 3Mobile-Web: Hide account benefits in Minerva version of login page - https://phabricator.wikimedia.org/T87257#1001212 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [18:40:47] 3RESTBase, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1001219 (10Mhurd) I addition to the article data, the meta data for the article's images is needed. Presently we're having to do separate chained requests for thi... [18:40:51] (03CR) 10Jdlrobson: [C: 031] Add 'license-name' matching SPDX conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187240 (owner: 10Ricordisamoa) [18:40:56] (03CR) 10Jdlrobson: [C: 032] Add 'license-name' matching SPDX conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187240 (owner: 10Ricordisamoa) [18:41:50] (03CR) 10Jdlrobson: [C: 031] "I don't really know this hook. Can someone verify it works as expected?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187354 (owner: 10Gerrit Patch Uploader) [18:42:52] (03CR) 10Jdlrobson: [C: 032] Hygiene: Clean up repeated copies and re-assignments in Resources.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187294 (owner: 10Krinkle) [18:44:27] (03CR) 10Jdlrobson: [C: 04-1] "(Feel free to disagree I just worry this code will go neglected)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187438 (owner: 10Cmcmahon) [18:45:50] 3Mobile-Web: QA table of contents test failing for last 25 builds - https://phabricator.wikimedia.org/T87342#1001224 (10bmansurov) These tests pass locally. What am I doing differently? ``` Feature: Table of contents Background: # features/toc.feature:4 Given I am using the mobile s... [18:46:43] (03Merged) 10jenkins-bot: Add 'license-name' matching SPDX conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187240 (owner: 10Ricordisamoa) [18:48:23] (03Merged) 10jenkins-bot: Hygiene: Clean up repeated copies and re-assignments in Resources.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187294 (owner: 10Krinkle) [18:53:56] tfinc: Looks like our 1:1 conflicts with the Wikidata Query Service demo :( [18:57:01] 3Wikipedia-App-iOS-App: iOS app doesn't support {{DISPLAYTITLE:}} - https://phabricator.wikimedia.org/T65971#1001279 (10brion) The titles as returned in search etc never use the display title currently; that's a separate issue that'll require some server-side improvements I think. [18:58:04] kaldari: k, go ahead and reschedule with sarah [18:58:05] thanks [18:59:15] (03PS2) 10Cmcmahon: QA: update Special:History link for js and non-js tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187438 [19:02:19] (03PS1) 10BearND: More docs for make-templates script [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187448 [19:02:53] (03CR) 10Cmcmahon: "Works for me, if y'all don't mind." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187438 (owner: 10Cmcmahon) [19:05:00] bmansurov: we're in R31 for the wikidata query service demo :) [19:05:02] come join [20:03:22] I'm not sure if people watch the Mobile engineering talk page, so just in case: someone left some feedback about the mobile apps at https://www.mediawiki.org/wiki/Talk:Wikimedia_mobile_engineering#Various_hints.2Fcomplaints_on_app [20:12:42] rmoen_, joakino, jdlrobson: food before quarterly review? [20:13:09] we should go, yes [20:13:24] phuedx: yes [20:16:06] jdlrobson's just finishing up an email [20:16:18] you still on the sofa near the door? [20:16:39] phuedx: no, in the door by the elevator (the other one) [20:17:55] (03PS1) 10Dbrant: Switch to using PreferenceFragment for settings. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187464 (https://phabricator.wikimedia.org/T85809) [20:18:16] phuedx: i'm going restrooms and down, see you guys at the entrance [20:18:25] (03CR) 10Phuedx: [C: 032] Recruit volunteers via the JavaScript console [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185578 (owner: 10Jdlrobson) [20:19:56] (03Merged) 10jenkins-bot: Recruit volunteers via the JavaScript console [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185578 (owner: 10Jdlrobson) [20:21:38] (03CR) 10jenkins-bot: [V: 04-1] Switch to using PreferenceFragment for settings. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187464 (https://phabricator.wikimedia.org/T85809) (owner: 10Dbrant) [20:25:23] (03PS2) 10Dbrant: Switch to using PreferenceFragment for settings. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187464 (https://phabricator.wikimedia.org/T85809) [20:34:29] (03PS1) 10Fjalapeno: Setup Cocoapods workspace refine build/setup process [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187472 [20:52:23] (03CR) 10Dbrant: [C: 032] Update Android plugin for Gradle to version 1.0.1 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187332 (owner: 10BearND) [20:57:25] (03CR) 10jenkins-bot: [V: 04-1] Update Android plugin for Gradle to version 1.0.1 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187332 (owner: 10BearND) [21:00:04] (03CR) 10Jdlrobson: [C: 032] QA: update Special:History link for js and non-js tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187438 (owner: 10Cmcmahon) [21:00:05] (03CR) 10Jdlrobson: [C: 031] QA: update Special:History link for js and non-js tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187438 (owner: 10Cmcmahon) [21:00:07] (03PS3) 10Jdlrobson: QA: update Special:History link for js and non-js tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187438 (https://phabricator.wikimedia.org/T87456) (owner: 10Cmcmahon) [21:00:28] (03CR) 10Jdlrobson: [C: 032] QA: update Special:History link for js and non-js tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187438 (https://phabricator.wikimedia.org/T87456) (owner: 10Cmcmahon) [21:00:38] 3Mobile-Web: ResourceLoader dependency issues on beta labs - https://phabricator.wikimedia.org/T87272#1002329 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [21:01:17] 3Mobile-Web: Recruit volunteers via the JavaScript console - https://phabricator.wikimedia.org/T85815#1002331 (10Jdlrobson) Implemented in https://gerrit.wikimedia.org/r/185578 Someone needs to write a patch to enable it in config now. [21:01:40] 3Mobile-Web: Alpha: Impossible to edit a search query - https://phabricator.wikimedia.org/T87438#1002332 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [21:02:56] (03Merged) 10jenkins-bot: QA: update Special:History link for js and non-js tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187438 (https://phabricator.wikimedia.org/T87456) (owner: 10Cmcmahon) [21:04:25] 3Mobile-Web: QA: Problem with history page selector - differs with and without JS - https://phabricator.wikimedia.org/T87456#1002338 (10Jdlrobson) 5Open>3Resolved [21:05:32] (03PS5) 10Jdlrobson: Hygiene: Use events map in overlay files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185929 (https://phabricator.wikimedia.org/T87193) (owner: 10Bmansurov) [21:05:57] (03CR) 10Jdlrobson: [C: 032] Hygiene: Use events map in overlay files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185929 (https://phabricator.wikimedia.org/T87193) (owner: 10Bmansurov) [21:08:31] (03Merged) 10jenkins-bot: Hygiene: Use events map in overlay files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185929 (https://phabricator.wikimedia.org/T87193) (owner: 10Bmansurov) [21:11:46] (03CR) 10Phuedx: [C: 031] "This LGTM. Though the ChangeTagsListActive hook hasn't actually been introduced to core (i.e. merged), this change can still be merged." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187354 (owner: 10Gerrit Patch Uploader) [21:11:58] (03PS2) 10Dbrant: Update Android plugin for Gradle to version 1.0.1 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187332 (owner: 10BearND) [21:18:00] 3Mobile-Web: EditorOverlays should use events property for their event bindings - https://phabricator.wikimedia.org/T87193#1002358 (10Jdlrobson) 5Open>3Resolved [21:18:40] rmoen_: https://gerrit.wikimedia.org/r/#/c/178338/5 [21:19:13] ^ can you post the new version? this patch is getting old now and we should really get it wrapped up [21:26:19] (03PS2) 10Yurik: Update ApiResult handling for mediawiki/core change I7b37295e [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/183608 (owner: 10Anomie) [21:26:42] (03CR) 10jenkins-bot: [V: 04-1] Update ApiResult handling for mediawiki/core change I7b37295e [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/183608 (owner: 10Anomie) [21:27:57] (03PS2) 10Dbrant: More docs for make-templates script [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187448 (owner: 10BearND) [21:30:16] (03CR) 10Dbrant: [C: 032] More docs for make-templates script [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187448 (owner: 10BearND) [21:31:55] jdlrobson: I don't have the new version yet. Still need to fix the android /chrome issue. Otherwise it can be merged in beta ? [21:34:44] (03CR) 10Phuedx: "I've given the tyres a kick and this does indeed look like it /should/ handle the dependent patch in core (I7b37295e) not being merged." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie) [21:35:08] (03CR) 10Phuedx: "Note that I've yet to test it with the dependent patch." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie) [21:36:25] rmoen_: did composer install --dev sort out your issue? [21:36:42] phuedx: yes, i now have a working dev environment ;) [21:36:44] ty [21:36:46] \o/ [21:43:57] (03CR) 10Phuedx: "Is this a straight import of Jdlrobson's patch to core? It seems familiar." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187395 (owner: 10Jhernandez) [21:47:28] (03CR) 10Phuedx: "Edit: i.e. is this a port of WatchlistPageCollection et al?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187395 (owner: 10Jhernandez) [21:52:03] (03CR) 10Phuedx: "Ping Kaldari" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185590 (owner: 10Kaldari) [21:52:41] phuedx: ? I’m confused. [21:53:18] phuedx: hoping to get a reply from jdlrobson on the inline comments [21:53:47] (03CR) 10Yurik: [C: 032 V: 032] Fix routing capabilities [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/187241 (owner: 10Jhobs) [21:53:53] you could also copy the documentation from core [21:53:57] (03CR) 10Bmansurov: Add Special:Collections page to menu (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187396 (owner: 10Jhernandez) [21:54:02] which isn't blocked by a reply from jdlrobson [21:54:40] phuedx: agreed. I’ll go ahead and do it. [21:54:49] you're the man [21:55:47] (03CR) 10Jhobs: "For posterity: the jenkins failures were investigated and determined to have a cause unrelated to this patch. Due to urgency, this patch w" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/187241 (owner: 10Jhobs) [21:57:47] marxarelli: how do I use cucumber URLs in page files on the pre-release version again? I accidentally lost all the changes we made during the workshop on friday [21:58:30] jhobs______: oh crap [21:58:30] marxarelli: or if you already put the README you were working on during that workshop up, that would work as well [21:58:46] jhobs______: it's still a sketch of a readme [21:59:48] jhobs______: hang on, give me a minute and i'll add a section to the readme [21:59:49] marxarelli: if it has enough to get me going again could you throw it in a pastebin or something maybe? I already ran the init stuff I'm just trying to fix my tests now [22:02:23] (03PS1) 10Krinkle: Sample commit for Jenkins [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/187532 [22:02:45] (03CR) 10jenkins-bot: [V: 04-1] Sample commit for Jenkins [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/187532 (owner: 10Krinkle) [22:02:47] jhobs______: https://phabricator.wikimedia.org/P240 [22:03:47] jhobs: there are more possible breaking changes but AFAIR you didn't encounter any [22:04:24] marxarelli: thanks! [22:05:00] jhobs: np [22:05:46] marxarelli: i think i might still be confused on URL though. If I have "page_url URL.url("Special:ZeroPortal#/dashboard")", what do I need to change that to? [22:05:58] ah, right [22:06:01] just remove the reference to the URL class? [22:06:03] remove the URL.url( bit [22:06:19] ah the whole method, got it, thanks [22:06:32] i.e. just: page_url "some/relative/path" [22:07:03] jhobs: yeah, it's now qualified relative to the current wiki context [22:07:22] marxarelli: sweet, much nicer [22:07:36] jhobs: see `Environment#on_wiki` and `Environment#wiki_url` [22:08:01] jhobs: https://doc.wikimedia.org/rubygems/mediawiki-selenium/MediawikiSelenium/Environment.html#on_wiki-instance_method [22:09:06] (03CR) 10Robmoen: "It seems the Gateway pattern feedback which Phudex left on Jon's core patch needs to be done here." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187395 (owner: 10Jhernandez) [22:09:07] marxarelli: so that's for testing different wikis (i.e., betalabs vs. vagrant)? [22:09:47] jhobs: no, those would be different "environments" [22:09:58] jhobs: on_wiki is for testing inter-wiki behavior [22:10:17] marxarelli: oooooh ok I see, thanks [22:10:39] jhobs: e.g. "Given this page exists on Wiki B" "When I reference it on Wiki A" "Then it links correctly" [22:10:47] or whatever [22:10:57] right [22:11:13] the implementation would be (roughly) `on_wiki(:a) { api.create_page... }` [22:11:42] etc. [22:11:46] :) [22:12:33] jhobs: the equivalent method for testing inter-user behavior is `Environment#as_user` [22:12:57] (03PS3) 10Kaldari: Hygiene: Replacing @inheritdoc with local documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185590 [22:13:01] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Replacing @inheritdoc with local documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185590 (owner: 10Kaldari) [22:13:18] jhobs: and remember that the context of your cucumber steps is now an instance of Environment, so reference its documentation when you want to know what's available to you [22:13:33] marxarelli: right, right I remember now. Ok cool thanks, and I'll definitely be bookmarking this API page [22:14:15] jhobs: np. let me know if you want a review or want to pair [22:14:34] (03PS4) 10Kaldari: Hygiene: Replacing @inheritdoc with local documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185590 [22:14:46] phuedx: https://gerrit.wikimedia.org/r/#/c/185590/4 [22:14:48] marxarelli: will definitely take you up on review, and potentially on pair if I get too stuck ;) [22:21:11] phuedx: kaldari: how can i protect a page in php so that only user can edit it and admins? [22:23:05] (03CR) 10Krinkle: "recheck" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/187532 (owner: 10Krinkle) [22:23:13] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Replacing @inheritdoc with local documentation (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185590 (owner: 10Kaldari) [22:23:25] jdlrobson: protection is set in the database. I don’t know of anyway to override it within PHP. You would probably need to add a hook to the permissionChecking function in the Title class. [22:23:43] ergg how does User:foo/common.js do it? [22:23:58] (03Abandoned) 10Krinkle: Sample commit for Jenkins [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/187532 (owner: 10Krinkle) [22:24:24] dr0ptp4kt: I moved a lot of Tweet a Fact cards to Sprint 50. I think given their original scope they're actually done. [22:24:49] dr0ptp4kt: They're the ones at the bottom of the "Doing" column. [22:24:49] Deskana: thx [22:24:49] dr0ptp4kt: Or, in code review. [22:24:49] (03CR) 10Krinkle: "recheck" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/183608 (owner: 10Anomie) [22:24:51] (03CR) 10Krinkle: "recheck" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/184995 (owner: 10Yurik) [22:24:53] (03CR) 10Krinkle: "recheck" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/180800 (owner: 10Dr0ptp4kt) [22:25:20] jdlrobson: There are permission checks that are tied to namespace and extension, but not page-specific. [22:25:29] bahh [22:25:41] dr0ptp4kt: I'll go through them in the iteration review. [22:25:48] but how does User:Jdlrobson/common.js get protected [22:25:52] where is the code that does this? [22:26:09] jdlrobson: it’s all in /includes/Title.php [22:26:47] * jdlrobson looks [22:27:07] jdlrobson: common.js is checked specifically by Title::isCssJsSubpage() [22:29:29] marxarelli: hmm... I've set up my environments.yml and exported the right env var to select the right environment, yet when I try to use as_user with my login method I get no username. Have a minute to chat? I can come to you [22:34:10] marxarelli: nevermind, think I found my issue [22:41:04] (03PS1) 10Jhobs: Update to mediawiki-selenium pre-release version [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/187602 [22:42:20] ^ marxarelli: note that those are basically just some super simple tests just for switching to prerelease [22:42:31] I have some REAL tests in mind that I'm starting on now [22:42:39] for ZeroBanner (not ZeroPortal) [22:46:58] (03PS2) 10Jhobs: Update to mediawiki-selenium pre-release version [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/187602 [22:47:04] jhobs: your refactoring looks right [22:47:11] jhobs: do they pass? [22:48:39] (03CR) 10Dduvall: [C: 031] "Your refactoring looks right. Do your tests pass?" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/187602 (owner: 10Jhobs) [22:50:10] (03CR) 10Jhobs: "Yep! Assuming all is well here I'll be moving the ZeroBanner extension over to prerelease as well and writing some real tests where I'll b" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/187602 (owner: 10Jhobs) [22:51:48] (03CR) 10Yurik: [C: 032] Update to mediawiki-selenium pre-release version [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/187602 (owner: 10Jhobs) [22:52:27] (03Merged) 10jenkins-bot: Update to mediawiki-selenium pre-release version [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/187602 (owner: 10Jhobs) [22:54:15] (03CR) 10Bgerstle: [C: 031] "woohoo!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187472 (owner: 10Fjalapeno) [22:56:21] (03PS1) 10Bmansurov: Correctly render thumbnail images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187607 (https://phabricator.wikimedia.org/T87198) [23:27:38] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Setup Cocoapods workspace refine build/setup process [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187472 (owner: 10Fjalapeno) [23:30:17] kaldari: do you have half an hour today to chat about diversity in Wikipedia? :-) [23:32:32] less, later today [23:33:12] (03CR) 10Bmansurov: Introduce Mobile collection models (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187395 (owner: 10Jhernandez) [23:37:32] https://www.mediawiki.org/wiki/Flow/Architecture/API [23:37:46] https://www.mediawiki.org/wiki/Flow/Architecture/API [23:38:41] https://www.mediawiki.org/w/api.php?action=help&modules=flow [23:39:21] (03PS8) 10Mhurd: Activity indicator screen and background thread for conversion [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184716 (owner: 10Brion VIBBER) [23:40:09] (03CR) 10Mhurd: "Rebased!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184716 (owner: 10Brion VIBBER) [23:40:30] (03PS4) 10Mhurd: (Work in progress) MWKImageMetadata object interface [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185548 (owner: 10Brion VIBBER) [23:42:19] (03PS3) 10Jhernandez: Show in Special:Collections the user's Watchlist "collectionized" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187397 [23:42:21] (03CR) 10jenkins-bot: [V: 04-1] Show in Special:Collections the user's Watchlist "collectionized" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187397 (owner: 10Jhernandez) [23:43:17] https://www.mediawiki.org/wiki/Flow/Pages [23:43:35] A sandbox on Wikipedia is: https://en.wikipedia.org/wiki/Wikipedia_talk:Flow/Developer_test_page [23:43:58] (03CR) 10Bmansurov: Add Special:Collections page to menu (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187396 (owner: 10Jhernandez) [23:46:28] (03PS1) 10Jdlrobson: POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187616 [23:47:44] (03PS4) 10Jhernandez: Show in Special:Collections the user's Watchlist "collectionized" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187397 [23:47:46] (03PS3) 10Jhernandez: Add Special:Collections page to menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187396 [23:47:48] (03PS3) 10Jhernandez: Introduce Mobile collection models [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187395 [23:47:53] (03CR) 10jenkins-bot: [V: 04-1] POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187616 (owner: 10Jdlrobson) [23:49:10] 3Mobile-Web, MediaWiki-extensions-WikibaseRepository: Redirect loop on mobile diffs (wikidata) - https://phabricator.wikimedia.org/T88029#1002775 (10Jdlrobson) 3NEW [23:50:59] (03PS4) 10Jhernandez: Introduce Mobile collection models [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187395 [23:51:09] (03PS4) 10Jhernandez: Add Special:Collections page to menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187396 [23:53:21] (03CR) 10Jhernandez: Add Special:Collections page to menu (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187396 (owner: 10Jhernandez) [23:53:39] (03PS5) 10Jhernandez: Add Special:Collections page to menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187396 [23:53:59] (03PS5) 10Jhernandez: Show in Special:Collections the user's Watchlist "collectionized" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187397 [23:55:26] (03CR) 10Robmoen: "Incoming patch based on this to address some model feedback." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187397 (owner: 10Jhernandez) [23:57:39] 3Mobile-Web: Editor switcher icon should be hidden - https://phabricator.wikimedia.org/T88032#1002810 (10bmansurov) 3NEW [23:58:12] (03PS1) 10Fjalapeno: Setup crashlytics [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622