[00:05:25] <wikibugs>	 3Mobile-Web: Editor switcher icon should not be shown in anon editor cta - https://phabricator.wikimedia.org/T88032#1002823 (10Jdlrobson)
[00:05:50] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Correctly render thumbnail images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187607 (https://phabricator.wikimedia.org/T87198) (owner: 10Bmansurov)
[00:07:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Correctly render thumbnail images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187607 (https://phabricator.wikimedia.org/T87198) (owner: 10Bmansurov)
[00:08:28] <wikibugs>	 3Mobile-Web: Some galleries still not rendering correctly on mobile - https://phabricator.wikimedia.org/T87198#1002838 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson
[00:19:20] <bmansurov>	 jdlrobson: do you know how I can load oojs-ui styles in mobile?
[00:19:41] <bmansurov>	 jdlrobson: they don't seem to be loaded when I load the 'oojs-ui' module
[00:20:47] <grrrit-wm>	 (03PS1) 10Robmoen: Break storage out of collection model classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187627 
[00:22:00] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Break storage out of collection model classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187627 (owner: 10Robmoen)
[00:31:52] <grrrit-wm>	 (03PS2) 10Robmoen: Break storage out of collection model classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187627 
[00:41:11] <grrrit-wm>	 (03PS2) 10Jdlrobson: POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187616 
[00:42:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187616 (owner: 10Jdlrobson)
[00:48:48] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Let's wait till this is not an empty page before merging." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187396 (owner: 10Jhernandez)
[01:09:33] <grrrit-wm>	 (03PS2) 10Fjalapeno: Setup crashlytics [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 
[01:14:00] <grrrit-wm>	 (03CR) 10Mhurd: [C: 031 V: 031] "Looks good." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 (owner: 10Fjalapeno)
[01:14:21] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 031 V: 031] Activity indicator screen and background thread for conversion [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184716 (owner: 10Brion VIBBER)
[01:14:45] <jdlrobson>	 joakino: is it beer o clock yet? I'm exhausted
[01:19:29] <wikibugs>	 3RESTBase, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1003031 (10Dbrant) It would be great if we could totally generalize the kind of Wikidata data we receive in the mobileview response.  i.e. instead of just specify...
[01:20:18] <wikibugs>	 3Wikipedia-App-iOS-App: "The Internet connection appears to be offline" appears when attempting to access saved pages while in airplane mode - https://phabricator.wikimedia.org/T88042#1003035 (10dr0ptp4kt) 3NEW
[01:21:47] <joakino>	 jdlrobson: +1 bmansurov phuedx
[01:21:57] <joakino>	 beer o clock
[01:22:42] <grrrit-wm>	 (03PS3) 10Robmoen: WIP: Break storage out of collection model classes Currently broken, watchlist is duplicated [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187627 
[01:23:46] * rmoen is annoyed that limechat didn't reconnect ...
[01:23:48] <rmoen>	 jdlrobson: beerthirty = true
[01:25:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Break storage out of collection model classes Currently broken, watchlist is duplicated [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187627 (owner: 10Robmoen)
[01:27:17] <jhobs__>	 chrismcmahon: quick selenium question for you: how can I set request headers in my step definition file (or page file)?
[01:28:07] <jhobs>	 chrismcmahon: having a hard time finding this in the documentation
[01:30:03] <chrismcmahon>	 jhobs: Selenium doesn't normally allow that. 
[01:30:46] <chrismcmahon>	 jhobs: Selenium intentionally limits operations to only what users can do.
[01:31:01] <wikibugs>	 3Mobile-Web, MediaWiki-extensions-CentralAuth: CentralAuth AutoLogin not working on mobile sites - https://phabricator.wikimedia.org/T87290#1003091 (10Jdlrobson) I'm not sure what's going on here. I tried alpha which should run all hooks (doesn't override login form) and the problem is broken there too. https://...
[01:31:05] <jhobs>	 chrismcmahon: hmm... do we have a way to do it (or fake it)?
[01:31:29] <jhobs>	 chrismcmahon: via watir or phantomjs or something else?
[01:32:16] <chrismcmahon>	 jhobs: one moment... 
[01:33:01] <bmansurov>	 joakino: where are you guys?
[01:33:26] <grrrit-wm>	 (03CR) 10Anomie: "> Is that patch C-2 because you're waiting on us to merge the patch?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie)
[01:34:51] <chrismcmahon>	 jhobs: Firefox only, we can fake a useragent, see https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/tests/browser/features/step_definitions/common_steps.rb line 55 https://github.com/wikimedia/mediawiki-extensions-Flow/blob/master/tests/browser/features/step_definitions/flow_no_javascript_steps.rb line 10
[01:35:26] <chrismcmahon>	 jhobs: what exactly are you trying to do?
[01:35:49] <jhobs>	 chrismcmahon: trying to fake mobile (so user agent helps there), but also trying to set a custom X-CS header
[01:36:09] <grrrit-wm>	 (03CR) 10Robmoen: [C: 04-1] "Special:MobileEditWatchlist renders double, Special:Collections renders nothing." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187627 (owner: 10Robmoen)
[01:36:19] <jhobs>	 chrismcmahon: these two things in conjunction actually simulate our end-user experience, which is actually based on ip addresses
[01:36:34] <chrismcmahon>	 jhobs: best we have is faking useragent, again, Firefox only
[01:36:44] <jhobs>	 chrismcmahon: ok, good to know, thanks
[01:37:36] <chrismcmahon>	 jhobs: yeah, in general, if the user can't do it, Selenium can't do it, and any tests beyond that are probably not good candidates for browser tests but better as integration tests or unit tests
[01:39:00] <wikibugs>	 3Wikipedia-App-iOS-App, MediaWiki-Core-Team, MediaWiki-API, Wikipedia-App-Android-App: Support login with email address instead of username - https://phabricator.wikimedia.org/T88046#1003106 (10Deskana) 3NEW
[01:39:07] <wikibugs>	 3Wikipedia-App-iOS-App, MediaWiki-Core-Team, MediaWiki-API, Wikipedia-App-Android-App: Support login with email address instead of username - https://phabricator.wikimedia.org/T88046#1003117 (10Deskana)
[01:39:10] <wikibugs>	 3Wikipedia-App-General-or-Unknown, MediaWiki-API: Tracking: API/backend issues blocking Wikipedia app development - https://phabricator.wikimedia.org/T75616#1003116 (10Deskana)
[01:39:37] <wikibugs>	 3Wikipedia-App-iOS-App, MediaWiki-Core-Team, MediaWiki-API, Wikipedia-App-Android-App: Support login with email address as well as with username - https://phabricator.wikimedia.org/T88046#1003118 (10Deskana)
[01:41:53] <wikibugs>	 3Wikipedia-App-iOS-App, MediaWiki-Core-Team, MediaWiki-API, Wikipedia-App-Android-App: Support login with email address as well as with username - https://phabricator.wikimedia.org/T88046#1003121 (10Legoktm)
[01:43:22] <wikibugs>	 3Wikipedia-App-iOS-App, MediaWiki-Core-Team, MediaWiki-API, Wikipedia-App-Android-App: Support login with email address as well as with username - https://phabricator.wikimedia.org/T88046#1003126 (10Deskana)
[01:43:45] <jhobs>	 chrismcmahon: yeah, these are unfortunately great browser tests, it's just that the setup to get to the page requires all this extra shit. I'm looking into some alternatives though
[01:44:20] <jhobs>	 chrismcmahon: oh, one last thing: is there some better way to refresh a page that just re "visit()"ing it, or is that fine?
[01:45:37] <wikibugs>	 3Wikipedia-App-iOS-App, MediaWiki-Core-Team, MediaWiki-API, Wikipedia-App-Android-App: Support login with email address as well as with username - https://phabricator.wikimedia.org/T88046#1003128 (10Anomie) > (Side note: presently an email address can be associated with more than one account, and we'd have to ch...
[01:46:22] <wikibugs>	 3Wikipedia-App-iOS-App, MediaWiki-Core-Team, MediaWiki-API, Wikipedia-App-Android-App: Support login with email address as well as with username - https://phabricator.wikimedia.org/T88046#1003131 (10Krenair) I agree, if that's true this is wontfix.
[01:50:30] <wikibugs>	 3Wikipedia-App-iOS-App, MediaWiki-Core-Team, MediaWiki-API, Wikipedia-App-Android-App: Support login with email address as well as with username - https://phabricator.wikimedia.org/T88046#1003136 (10Deskana) >>! In T88046#1003131, @Krenair wrote: > I agree, if that's true this is wontfix.  Then I would welcome a...
[01:50:43] <chrismcmahon>	 jhobs: $browser.refresh I think is the command, but visit(FooPage) is just as good
[01:53:10] <wikibugs>	 3Wikipedia-App-iOS-App, MediaWiki-Core-Team, MediaWiki-API, Wikipedia-App-Android-App: Support login with email address as well as with username - https://phabricator.wikimedia.org/T88046#1003141 (10Legoktm) Can everyone keep the discussion on T30085 please?
[01:59:59] <grrrit-wm>	 (03CR) 10Bgerstle: [C: 04-1] "wrap the Fabric build script in check for Release configuration and update README to indicate release build dependency on Fabric app (w/ l" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 (owner: 10Fjalapeno)
[02:08:54] <wikibugs>	 3Wikipedia-App-MobileApp-extension: Convert MobileApp extension to use extension registration - https://phabricator.wikimedia.org/T88056#1003241 (10Legoktm) 3NEW
[02:09:12] <grrrit-wm>	 (03CR) 10Deskana: "Can someone confirm whether this patch sends any data to third parties? If it does, we'll need to check with legal before merging." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 (owner: 10Fjalapeno)
[02:11:10] <wikibugs>	 3Mobile-Web: Convert MobileFrontend extension to use extension registration - https://phabricator.wikimedia.org/T88057#1003253 (10Legoktm) 3NEW
[02:26:57] <wikibugs>	 3Wikipedia-App-MobileApp-extension: Convert MobileApp extension to use extension registration - https://phabricator.wikimedia.org/T88056#1003372 (10Legoktm)
[02:27:01] <wikibugs>	 3Mobile-Web: Convert MobileFrontend extension to use extension registration - https://phabricator.wikimedia.org/T88057#1003371 (10Legoktm)
[05:00:21] <grrrit-wm>	 (03CR) 10Deskana: "Also, what copyright licences are Crashlytics and Fabric under?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 (owner: 10Fjalapeno)
[05:13:22] <wikibugs>	 3MediaWiki-API, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Mobile apps users should not be shown captchas when creating accounts - https://phabricator.wikimedia.org/T88083#1003721 (10Deskana) 3NEW
[05:15:03] <wikibugs>	 3MediaWiki-API, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Mobile apps users should not be shown captchas when creating accounts - https://phabricator.wikimedia.org/T88083#1003728 (10Deskana) @dr0ptp4kt has some thoughts on this, which he may choose to document here.
[05:15:06] <wikibugs>	 3MediaWiki-API, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Mobile apps users should not be shown captchas when creating accounts - https://phabricator.wikimedia.org/T88083#1003731 (10Deskana)
[05:15:07] <wikibugs>	 3Wikipedia-App-General-or-Unknown, MediaWiki-API: Tracking: API/backend issues blocking Wikipedia app development - https://phabricator.wikimedia.org/T75616#1003730 (10Deskana)
[05:15:44] <wikibugs>	 3MediaWiki-API, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Mobile apps users should not be shown captchas when creating accounts - https://phabricator.wikimedia.org/T88083#1003721 (10Deskana) @csteipp may also have some ideas?
[05:35:57] <grrrit-wm>	 (03PS2) 10Yurik: TLS support [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/184995 
[05:36:29] <grrrit-wm>	 (03PS6) 10Yurik: Show noscript HTTPS to HTTP tap if HTTPS charged [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/180800 (owner: 10Dr0ptp4kt)
[05:38:32] <wikibugs>	 3Wikipedia-App-iOS-App, MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), MediaWiki-API, Wikipedia-App-Android-App: Mobile apps users should not be shown captchas when creating accounts - https://phabricator.wikimedia.org/T88083#1003740 (10TTO) Yet another problem with our notorious CAPTCHA.
[05:41:35] <grrrit-wm>	 (03PS3) 10Yurik: Update ApiResult handling for mediawiki/core change I7b37295e [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/183608 (owner: 10Anomie)
[06:06:08] <wikibugs>	 3Wikipedia-App-iOS-App, MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), MediaWiki-API, Wikipedia-App-Android-App: Mobile apps users should not be shown captchas when creating accounts - https://phabricator.wikimedia.org/T88083#1003750 (10Krenair) And... How do you plan to achieve this securely?
[06:06:29] <wikibugs>	 3Wikipedia-App-iOS-App, MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), MediaWiki-API, Wikipedia-App-Android-App: Mobile apps users should not be shown captchas when creating accounts - https://phabricator.wikimedia.org/T88083#1003751 (10Krenair)
[06:10:47] <grrrit-wm>	 (03CR) 10Fjalapeno: "Fabric (Twitter/Crashlytics) does not share your data with 3rd parties. You can read there terms here:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 (owner: 10Fjalapeno)
[06:31:50] <wikibugs>	 3RESTBase, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1003765 (10bearND) @mobrovac Maybe I've misread your comment. But I want to make sure you are aware that we're already getting Widata descriptions channeled throu...
[06:32:28] <grrrit-wm>	 (03CR) 10Deskana: [C: 04-2] "Needs discussion with Legal before this can be merged. Feel free to address any concerns raised in other code reviews while this happens." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 (owner: 10Fjalapeno)
[12:33:06] <grrrit-wm>	 (03PS1) 10Ricordisamoa: Add 'license-name' matching SPDX conventions [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/187672 
[12:36:46] <grrrit-wm>	 (03PS1) 10Ricordisamoa: Add 'license-name' matching SPDX conventions [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/187673 
[17:27:21] <wikibugs>	 3Wikipedia-App-iOS-App, MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), MediaWiki-API, Wikipedia-App-Android-App: Mobile apps users should not be shown captchas when creating accounts - https://phabricator.wikimedia.org/T88083#1004409 (10brion) For reference, the Google and Gmail apps on iOS do require a c...
[17:32:28] <joakino>	 good morning
[17:40:39] <joakino>	 phuedx: MaxSem: in phpstorm do you open the whole vagrant folder? mediawiki folder? or extensions folder?
[17:40:54] <MaxSem>	 vagrant
[17:41:51] <MaxSem>	 this way, you'll get stock settings already in version control
[17:45:52] <joakino>	 thx max
[17:47:27] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 031 V: 031] "Doing an [obj save] after using an artificial @"foo" name initialization and reading out [<the_image> metadata] with the corresponding MWK" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185548 (owner: 10Brion VIBBER)
[17:54:00] <joakino>	 phpstorm 380% cpu
[17:55:14] <wikibugs>	 3Wikipedia-App-iOS-App, MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), MediaWiki-API, Wikipedia-App-Android-App: Mobile apps users should not be shown captchas when creating accounts - https://phabricator.wikimedia.org/T88083#1004511 (10csteipp) >>! In T88083#1003731, @Deskana wrote: > @csteipp may also h...
[17:55:42] <prtksxna>	 joakino: 12 instances of emacs <5mb of memory :D
[17:56:55] <MaxSem>	 prtksxna, IDE that actually understands the language you're programming in === hours and hours and hours of time saved
[17:57:02] <bgerstle>	 joakino: so php upgrade your computer to a 3x faster CPU? ;-)
[17:57:43] <prtksxna>	 https://www.gnu.org/software/emacs/manual/html_node/emacs/Semantic.html
[17:58:11] <bgerstle>	 prtksxna or for the fans of vim: https://github.com/scrooloose/syntastic
[17:58:33] <prtksxna>	 bgerstle: mmmm look at the horse!
[17:58:46] <prtksxna>	 More beautiful curly braces I have never seen
[17:58:46] <bgerstle>	 heheh
[17:58:50] <bgerstle>	 ascii art ftw
[17:59:15] <bgerstle>	 clearly this means vim is superior...
[18:00:23] <prtksxna>	 :|
[18:02:50] <wikibugs>	 3Mobile-Web, MediaWiki-extensions-CentralAuth: CentralAuth AutoLogin not working on mobile sites - https://phabricator.wikimedia.org/T87290#1004525 (10Jdlrobson) @csteipp note this can be replicated on beta labs  Steps to demonstrate: Ensure logged out / clear cookies. Login @ http://en.m.wikipedia.beta.wmflabs....
[18:04:23] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "Sorry Max told me otherwise." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie)
[18:05:19] <grrrit-wm>	 (03CR) 10Jdlrobson: "(needs rebase though now) Can someone who understands this stuff commit to getting this merged once rebased - i'd hate to waste Anomie's t" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie)
[18:14:59] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Introduce Mobile collection models (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187395 (owner: 10Jhernandez)
[18:16:06] <grrrit-wm>	 (03CR) 10Jdlrobson: Add Special:Collections page to menu (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187396 (owner: 10Jhernandez)
[18:19:02] <wikibugs>	 3Mobile-Web, MediaWiki-extensions-CentralAuth: CentralAuth AutoLogin not working on mobile sites - https://phabricator.wikimedia.org/T87290#1004554 (10csteipp) >>! In T87290#1003091, @Jdlrobson wrote: > I'm not sure what's going on here. I tried alpha which should run all hooks (doesn't override login form) and...
[18:20:32] <grrrit-wm>	 (03CR) 10MaxSem: "This is kinda deadlock - I wouldn't feel confident about merging an extension change before the core change of this magnitude of complexit" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie)
[18:23:00] <grrrit-wm>	 (03PS3) 10Jdlrobson: POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187616 
[18:23:22] <wikibugs>	 3MediaWiki-Categories, Mobile-Web: (3) 3 column responsive layout for categories so they render nicely on mobile - https://phabricator.wikimedia.org/T85496#1004575 (10bmansurov) 5Open>3Resolved a:3bmansurov
[18:24:18] <grrrit-wm>	 (03CR) 10Phuedx: "I'll have plenty of time on the plane back to London. I'll make sure Anomie has a response when I hit terra firma." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie)
[18:24:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187616 (owner: 10Jdlrobson)
[18:26:45] <wikibugs>	 3Wikipedia-App-Android-App: Tweet a fact quotation marker needs to be localized - https://phabricator.wikimedia.org/T86394#1004580 (10Deskana) 5Open>3Resolved a:3Deskana Obsolete now.
[18:27:33] <wikibugs>	 3Wikipedia-App-Android-App: Share a Fact quote should be flipped in RTL context - https://phabricator.wikimedia.org/T86395#1004583 (10Deskana) p:5Triage>3Low
[18:29:17] <wikibugs>	 3Wikipedia-App-Android-App: android.database.sqlite.SQLiteDiskIOException: error code 10: disk I/O error - https://phabricator.wikimedia.org/T86438#1004588 (10Deskana) Not really sure what we can do about this. This crash isn't even coming from our code.
[18:30:29] <wikibugs>	 3Wikipedia-App-Android-App: SecurityException: Neither user <n> nor current process has android.permission.WAKE_LOCK - https://phabricator.wikimedia.org/T86440#1004591 (10Deskana) This isn't in our code so there may not be anything we can do about it.
[18:35:31] <grrrit-wm>	 (03PS1) 10Jhernandez: Introduce Special:Collections page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 
[18:35:33] <grrrit-wm>	 (03PS1) 10Jhernandez: WIP [DO NOT MERGE] Introduce Collections item on menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187717 
[18:36:21] <grrrit-wm>	 (03Abandoned) 10Jhernandez: Show in Special:Collections the user's Watchlist "collectionized" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187397 (owner: 10Jhernandez)
[18:36:32] <grrrit-wm>	 (03Abandoned) 10Jhernandez: Add Special:Collections page to menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187396 (owner: 10Jhernandez)
[18:36:52] <grrrit-wm>	 (03Abandoned) 10Jhernandez: Introduce Mobile collection models [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187395 (owner: 10Jhernandez)
[18:37:28] <wikibugs>	 3MediaWiki-Categories, Mobile-Web: (3) 3 column responsive layout for categories so they render nicely on mobile - https://phabricator.wikimedia.org/T85496#948174 (10Ricordisamoa)
[18:38:41] <grrrit-wm>	 (03CR) 10Jhernandez: "Rob by popular demand i've merged the patches and they will be fixed on this new one:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187627 (owner: 10Robmoen)
[18:38:58] <joakino>	 jdlrobson: Introduce Special:Collections page [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/187716
[18:39:16] <joakino>	 jdlrobson: review and critizise at will :D
[18:40:19] <codezee>	 jdlrobson: Sumit here, a small question-do I need to communicate and get involved on mediaiwiki trello, if I'm looking for working on improving the ui?
[18:48:06] <phuedx>	 jdlrobson, rmoen, joakino: is there anything you want me to review?
[18:56:02] <wikibugs>	 3RESTBase, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1004711 (10mobrovac) >>! In T87824#1003765, @bearND wrote: > @mobrovac Maybe I've misread your comment. But I want to make sure you are aware that we're already g...
[18:59:25] <bgerstle>	 tfinc: Deskana is the mobile-app mailing list still in use?
[18:59:43] <bgerstle>	 if i want to send an email to the app team
[19:00:10] <grrrit-wm>	 (03PS1) 10Phuedx: Remove unnecessary clarification [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187719 
[19:01:12] <phuedx>	 rmoen, jdlrobson, joakino: deployment training – can someone +2 that real quick? ^
[19:01:30] <rmoen>	 phuedx: looking
[19:01:32] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Remove unnecessary clarification [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187719 (owner: 10Phuedx)
[19:01:42] <phuedx>	 rmoen: ta
[19:01:43] <phuedx>	 wait
[19:01:45] <phuedx>	 no need
[19:02:01] <grrrit-wm>	 (03CR) 10Robmoen: [C: 032] Remove unnecessary clarification [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187719 (owner: 10Phuedx)
[19:02:13] <grrrit-wm>	 (03PS2) 10Phuedx: WIP: new extension registration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183906 (https://phabricator.wikimedia.org/T88057) (owner: 10MaxSem)
[19:02:14] <rmoen>	 lols
[19:02:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unnecessary clarification [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187719 (owner: 10Phuedx)
[19:02:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: new extension registration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183906 (https://phabricator.wikimedia.org/T88057) (owner: 10MaxSem)
[19:02:53] <grrrit-wm>	 (03PS1) 10Phuedx: Remove unnecessary clarification [extensions/MobileFrontend] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/187720 
[19:04:58] <grrrit-wm>	 (03Abandoned) 10Robmoen: WIP: Break storage out of collection model classes Currently broken, watchlist is duplicated [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187627 (owner: 10Robmoen)
[19:11:23] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Remove unnecessary clarification [extensions/MobileFrontend] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/187720 (owner: 10Phuedx)
[19:13:13] <grrrit-wm>	 (03PS2) 10BearND: Enable Checkstyle via Gradle [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187333 
[19:13:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unnecessary clarification [extensions/MobileFrontend] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/187720 (owner: 10Phuedx)
[19:15:03] <bearND>	 dbrant: would you check out https://gerrit.wikimedia.org/r/#/c/187333/ today so i can send a phab ticket to ci
[19:16:11] <dbrant>	 bearND: yep!
[19:19:30] <grrrit-wm>	 (03CR) 10Jhernandez: Add Special:Collections page to menu (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187396 (owner: 10Jhernandez)
[19:20:03] <wikibugs>	 3MediaWiki-Categories, Mobile-Web: (3) 3 column responsive layout for categories so they render nicely on mobile - https://phabricator.wikimedia.org/T85496#1004783 (10bmansurov) a:5bmansurov>3None
[19:24:28] <wikibugs>	 3MediaWiki-Categories, Mobile-Web: (3) 3 column responsive layout for categories so they render nicely on mobile - https://phabricator.wikimedia.org/T85496#1004803 (10Florian) a:3Sumit
[19:30:46] <jhobs_>	 marxarelli: do you potentially have some time (either before lunch or later today) to help me with some automated tests? I'm having to use phantomjs since I need to set headers and its causing me some problems
[19:31:43] <jhobs_>	 marxarelli: today's my last day in the office, but we can work on this remote next week if you're busy today
[19:33:05] <Deskana>	 http://hatjitsu.wmflabs.org/89035
[19:33:25] <marxarelli>	 jhobs_: i'm wfh today, so it's remote either way :)
[19:33:34] <marxarelli>	 jhobs_: but yeah, i'm around
[19:34:47] <grrrit-wm>	 (03CR) 10Brion VIBBER: (Work in progress) MWKImageMetadata object interface (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185548 (owner: 10Brion VIBBER)
[19:35:14] <jhobs_>	 marxarelli: ok. would you be available for a hangout at 1? Hopefully should only take a half-hour or so, but I could easily see us falling down the rabbit hole
[19:35:59] <jhobs_>	 marxarelli: I'm also available around 3 if that works better
[19:36:15] <marxarelli>	 jhobs_: yeah, send me an invite
[19:36:20] <jhobs_>	 marxarelli: will do
[19:38:43] <jhobs_>	 marxarelli: sent, and starting time is fairly loose, don't feel like you have to hurry back from lunch or anything :)
[19:46:59] <wikibugs>	 3Mobile-Web, MediaWiki-extensions-CentralAuth: CentralAuth AutoLogin not working on mobile sites - https://phabricator.wikimedia.org/T87290#1004911 (10Jdlrobson) a:3kaldari @csteipp helpfully helped me debug this IRL but sadly we couldn't find what was going on. Appears there are two issues.  1) Images not bei...
[19:47:40] <grrrit-wm>	 (03CR) 10Jdlrobson: Show in Special:Collections the user's Watchlist "collectionized" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187397 (owner: 10Jhernandez)
[19:53:12] <grrrit-wm>	 (03PS5) 10Phuedx: Hygiene: Replacing @inheritdoc with local documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185590 (owner: 10Kaldari)
[19:53:58] <grrrit-wm>	 (03CR) 10Phuedx: Hygiene: Replacing @inheritdoc with local documentation (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185590 (owner: 10Kaldari)
[19:54:18] <phuedx>	 jdlrobson: that should be mergeable now
[19:54:23] <phuedx>	 also, kaldari ain't on irc
[19:54:53] <wikibugs>	 3Mobile-Apps, Wikipedia-App-iOS-App, Flow, Wikipedia-App-Android-App: Flow is broken on the mobile app - https://phabricator.wikimedia.org/T73754#1004949 (10bearND)
[19:57:39] <wikibugs>	 3Mobile-Web, MediaWiki-extensions-CentralAuth: CentralAuth AutoLogin not working on mobile sites - https://phabricator.wikimedia.org/T87290#1004952 (10Jdlrobson) (so my theory/hope is that #2 is just bad configuration on betalabs - domains )
[19:57:46] <grrrit-wm>	 (03CR) 10Phuedx: "@Jdlrobson: the ChangeTagsListActive hook has the same signature as the ListDefinedTags hook. It also expects the same behaviour from its " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187354 (owner: 10Gerrit Patch Uploader)
[19:58:38] <jdlrobson>	 hey codezee sorry for late reply been debugging a nasty bug
[19:59:30] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Replacing @inheritdoc with local documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185590 (owner: 10Kaldari)
[19:59:44] <phuedx>	 you're the man jdlrobson 
[20:00:18] <jdlrobson>	 codezee: not sure where mediawiki trello board you are talking about but best way to get involved with anything ui standardisation related is to sync up with TrevorP|Away. Maybe introduce yourself on the design-l mailing list and ask how you can help?
[20:02:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Replacing @inheritdoc with local documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185590 (owner: 10Kaldari)
[20:02:51] <codezee>	 jdlrobson: alright! thanks, also I'd like to know if MobileFrontend is looking for any kind of new feature or development?
[20:03:21] <jdlrobson>	 codezee: let's take a look at the backlog :)
[20:03:45] <jdlrobson>	 codezee: for mobile web specific https://phabricator.wikimedia.org/project/board/67/
[20:04:06] <jdlrobson>	 feel free to grab anything out of the backlogs / submit a patch column
[20:04:20] <jdlrobson>	 for new features - https://phabricator.wikimedia.org/project/board/366/ 
[20:04:28] <jdlrobson>	 starting with must have / should have
[20:05:10] <codezee>	 jdlrobson: thanks! presently I was looking at - https://phabricator.wikimedia.org/T85495
[20:06:09] <jdlrobson>	 codezee: that would be great if you can help with that :-)
[20:06:32] <jdlrobson>	 Florian has been doing a bunch of stuff around categories so would be great for you to pair up with him and improve that feature for mobile
[20:06:44] <phuedx>	 ^ that
[20:06:54] <codezee>	 jdlrobson: alright, I'll shortly submit a patch :), and ok I'll talk to him
[20:08:05] <jdlrobson>	 i'm leaving very shortly
[20:08:17] <jdlrobson>	 ^ ignore - wrong window
[20:09:23] <jdlrobson>	 brb stepping out for lunch!
[20:09:43] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Introduce Special:Collections page (039 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez)
[21:07:24] <marxarelli>	 jhobs: hey, i canceled the meeting because of some crazy nonsense at home, but i probably still have 20 minutes or so if you have some questions
[21:08:48] <jhobs>	 marxarelli: I ended up scheduling some time with my PM after I noticed you cancelled it. Do you think you'll have some time around 3?
[21:19:44] <wikibugs>	 3RESTBase, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1005093 (10mobrovac) @bearND @Dbrant @Mhurd @Deskana @gwicke @jdouglas let's set up a meeting and discuss this further? Today? Monday?
[21:27:38] <joakino>	 phuedx: at what time are we leaving
[21:31:49] <jhobs>	 marxarelli: ^ (previous message) ?
[21:31:51] <phuedx>	 joakino: good question
[21:31:55] <phuedx>	 joakino: when's our flight?
[21:32:18] <rmoen>	 joakino, phuedx: would you guys like to share an uber ? I'm leaving at 2pmg 
[21:32:20] <rmoen>	 2pm
[21:32:32] <joakino>	 phuedx: 7:25pm i think
[21:32:42] <phuedx>	 joakino, rmoen: flight's at 7:25 pm
[21:33:00] <phuedx>	 joakino, rmoen: as long as the airport has wifi?
[21:33:29] <rmoen>	 phuedx, joakino: it does has the wifi
[21:34:59] <phuedx>	 joakino: what do you think? 3.5 hours of furious hacking in the airport?
[21:37:14] <wikibugs>	 3Mobile-Web: QA table of contents test failing for last 25 builds - https://phabricator.wikimedia.org/T87342#1005121 (10Jdlrobson) @cmcmahon - it seems that the browser window is not getting resized in chrome. Is this a known problem? Should we stop running the test on chrome?
[21:38:26] <wikibugs>	 3Mobile-Web: QA table of contents test failing for last 25 builds - https://phabricator.wikimedia.org/T87342#1005123 (10Jdlrobson) That said it seems to be applying in https://saucelabs.com/jobs/3cb4b0de8eb24f6cbc6cb53097e88697 https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-MobileFrontend-en.m...
[21:41:58] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] "Tested this with I77f476c8d0f32c80f720aa2c5e66869c81faa282." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187354 (owner: 10Gerrit Patch Uploader)
[21:43:15] <joakino>	 phuedx: good with me
[21:44:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Implement ChangeTagsListActive hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187354 (owner: 10Gerrit Patch Uploader)
[21:46:42] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Enable Checkstyle via Gradle [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187333 (owner: 10BearND)
[21:47:00] <phuedx>	 rmoen: let's uber!
[21:48:15] <wikibugs>	 3Mobile-Web: QA table of contents test failing for last 25 builds - https://phabricator.wikimedia.org/T87342#1005161 (10Cmcmahon) Works for me , resizes window, and passes locally in Chrome and Firefox. Looking at the Sauce builds...
[21:49:35] <rmoen>	 phuedx, joakino ok i'll book it in 5 mins ? 
[21:49:44] <phuedx>	 rmoen: sounds good
[21:49:49] <phuedx>	 tfinc: are you in the office/
[21:49:50] <phuedx>	 ?
[21:50:01] * phuedx doesn't know where you usually sit
[21:55:21] <grrrit-wm>	 (03PS3) 10Dbrant: Avoid NPE crash from onPrepareOptionsMenu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187335 (https://phabricator.wikimedia.org/T87109) (owner: 10BearND)
[21:55:49] <wikibugs>	 3Mobile-Web: Recruit volunteers via the JavaScript console - https://phabricator.wikimedia.org/T85815#1005170 (10phuedx) @Jdlrobson Take a look at them there settings and +1/-1 appropriately.
[21:59:29] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Avoid NPE crash from onPrepareOptionsMenu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187335 (https://phabricator.wikimedia.org/T87109) (owner: 10BearND)
[22:00:40] <grrrit-wm>	 (03PS2) 10Jhernandez: Introduce Special:Collections page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 
[22:00:51] <grrrit-wm>	 (03CR) 10Jhernandez: Introduce Mobile collection models (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187395 (owner: 10Jhernandez)
[22:00:55] <jhobs>	 dr0ptp4kt: omw
[22:01:25] <grrrit-wm>	 (03CR) 10Jhernandez: "jdlrobson i'll handle your comments soon" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez)
[22:01:47] <dr0ptp4kt>	 jhobs: c u up there in a few
[22:28:15] <mhurd>	 dr0ptp4kt: i think i may have a handle on the saved pages issue...
[22:28:45] <dr0ptp4kt>	 mhurd: sweet. heads up, i'm meeting with jhobs atm to wrap up the final zero things
[22:29:19] <mhurd>	 dr0ptp4kt: cool
[22:35:18] <jhobs>	 bearND & dbrant: when do you guys leave (assuming you're still here)?
[22:35:41] <bearND>	 jhobs: just arrived at the airport ;)
[22:35:52] <jhobs>	 bearND: ah, then have a safe flight!
[22:36:05] <dbrant>	 jhobs: i'm still here; leaving tomorrow
[22:36:43] <jhobs>	 dbrant: will you have a moment around 3 (or at least, before 4)? Trying to set up android app and have a gradle issue
[22:37:30] <dbrant>	 jhobs: sure thing
[22:37:40] <jhobs>	 dbrant: sweet, i'll swing by later
[22:47:21] <wikibugs>	 3Mobile-Web: QA table of contents test failing for last 25 builds - https://phabricator.wikimedia.org/T87342#1005316 (10Jdlrobson)
[22:47:36] <wikibugs>	 3Mobile-Web: QA table of contents test failing for last 25 builds - https://phabricator.wikimedia.org/T87342#989239 (10Jdlrobson) can't replicate locally... maybe @dduvall has some ideas?
[22:49:12] <wikibugs>	 3Mobile-Web: QA toggling sections test failing for last 25 builds - https://phabricator.wikimedia.org/T87343#1005327 (10Jdlrobson) a:3Jdlrobson This is happening because of the table of contents being visible. I think there is a nice way to fix this one separately.
[22:50:04] <Krenair>	 bgerstle, does the ios repo use github?
[22:50:14] <Krenair>	 I thought those repos were just mirrored to github
[22:50:30] <bgerstle>	 krenair they are
[22:50:43] <bgerstle>	 (mirrored)
[22:50:48] <bgerstle>	 is this because i opened a PR?
[22:50:55] <Krenair>	 yes
[22:51:10] <bgerstle>	 krenair: i'll close it
[22:51:16] <Krenair>	 ok...
[22:51:40] <bgerstle>	 krenair: out of curiosity, why do you ask?
[22:51:45] <bgerstle>	 i'm surprised you even noticed
[22:51:49] <bgerstle>	 i guess you're watching the repo
[22:51:55] <Krenair>	 I'm an owner of the wikimedia github organisation
[22:52:07] <Krenair>	 I watch everything
[22:52:09] <bgerstle>	 ah ha
[22:52:20] <grrrit-wm>	 (03PS1) 10Jdlrobson: QA: Use section-heading class to identify first section heading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187827 (https://phabricator.wikimedia.org/T87343) 
[22:52:22] <brion>	 :)
[22:52:28] <bgerstle>	 unrelated, i'm having trouble creating a review in gerrit
[22:52:33] <Krenair>	 and pull requests... typically these are supposed to go through gerrit instead
[22:52:41] <bgerstle>	 it says my commit depends on multiple "outstanding" commits
[22:52:46] <bgerstle>	 even though it's already rebased on master
[22:53:40] <wikibugs>	 3Mobile-Web: Convert MobileFrontend extension to use extension registration - https://phabricator.wikimedia.org/T88057#1005353 (10Jdlrobson) As you can see it's messy. I think for the sanity of developers we may want to do some cleanup before doing this to avoid having a huge json blob like this.
[22:53:48] <grrrit-wm>	 (03PS1) 10Bgerstle: add unit testing target [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187828 
[22:54:37] <brion>	 we found it, it was the stray ‘gerrit’ remote had to be updated too :)
[22:54:39] <brion>	 damn that thing
[22:54:46] <brion>	 i think there’s a way to make it use origin instead
[22:54:46] <bgerstle>	 Krenair: brion fixed it. apparently i had to fetch the gerrit remote
[22:54:49] <bgerstle>	 which i didn't even know i had
[22:54:52] <bgerstle>	 because git review created it for me
[22:55:08] * brion shakes head at gerrit sadly
[22:55:29] <bgerstle>	 щ(ಠ益ಠщ)
[22:55:38] <Krenair>	 'git fetch gerrit' fixes this
[22:55:50] <brion>	 best emoticon evar
[22:55:52] <bgerstle>	 Krenair see above
[22:55:56] <Krenair>	 yeah
[22:56:19] <bgerstle>	 also ಠ╭╮ಠ
[22:56:21] <Krenair>	 but sometimes you can just let it upload anyway, if you see origin/master is where you would expect it
[22:56:47] <bgerstle>	 i just want to use git :'(
[22:57:25] <bgerstle>	 maybe git-review is the problem
[22:57:33] <bgerstle>	 Krenair can i just git push -f to a branch?
[22:57:41] <bgerstle>	 something like /refs/publish/foo?
[22:58:03] <bgerstle>	 i guess it would be /refs/publish/merge_to_branch/merge_from_branch
[22:59:10] <grrrit-wm>	 (03CR) 10Jdlrobson: "Paladox you may want to check out https://phabricator.wikimedia.org/T88057" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 (owner: 10Paladox)
[22:59:38] <bgerstle>	 hrm, why isn't my gerrit CR request being sent here..
[22:59:53] <wikibugs>	 3Mobile-Web: QA table of contents test failing for last 25 builds - https://phabricator.wikimedia.org/T87342#1005367 (10Cmcmahon) this seems likely to be an issue with SauceLabs and/or ChromeDriver, the @browser.window.resize_to command seems to have just stopped working for Chrome on SauceLabs, even though it w...
[23:00:20] <wikibugs>	 3Mobile-Web: QA table of contents test failing for last 25 builds - https://phabricator.wikimedia.org/T87342#1005368 (10Cmcmahon) a:3Cmcmahon
[23:00:42] <grrrit-wm>	 (03PS3) 10Jdlrobson: Turn off universal box-sizing in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183987 (https://phabricator.wikimedia.org/T85068) 
[23:01:14] <bgerstle>	 FYI  mhurd dr0ptp4kt i added you to a gerrit code review
[23:01:37] <dr0ptp4kt>	 bgerstle: thx, which one. want review?
[23:01:40] <mhurd>	 bgerstle: cool will check it out shortly…
[23:03:23] <Krenair>	 bgerstle, I think https://lists.wikimedia.org/pipermail/wikitech-l/2013-May/069672.html was relevant
[23:03:35] <Krenair>	 push -f is a bad idea
[23:03:52] <mhurd>	 dr0ptp4kt: i can’t seem to find the trello card for that saved-pages-being-redownloaded bug… i think i have a fix :)
[23:04:35] <dbrant>	 jhobs: i'll be at my desk in a few...
[23:06:09] <grrrit-wm>	 (03CR) 10Esanders: [C: 031] "I'm happy with us committing crimes against CSS if it's just for testing alpha/beta. Let's just get this out so we can start fixing any is" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183987 (https://phabricator.wikimedia.org/T85068) (owner: 10Jdlrobson)
[23:06:23] <jhobs>	 dbrant: i'll be down in a bit, finishing up a meeting with adam atm
[23:10:58] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "MF is doing some weird stuff:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183906 (https://phabricator.wikimedia.org/T88057) (owner: 10MaxSem)
[23:11:01] <bgerstle>	 ahhh thanks Krenair
[23:16:38] <mhurd>	 bgerstle: hamcrest? lol
[23:17:04] <bgerstle>	 yep
[23:17:11] <bgerstle>	 ask dbrant & bernd, there's a java lib w/ the same name
[23:17:14] <mhurd>	 bgerstle: great name :)
[23:17:19] <bgerstle>	 bearnd*
[23:17:30] <bgerstle>	 i'm going to start calling him beorn
[23:17:43] <bgerstle>	 we need more mythical beings in here
[23:18:01] <bgerstle>	 already got the headmaster himself :-P *waves at dumbledore*
[23:20:20] <grrrit-wm>	 (03CR) 10Mhurd: "Added comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187828 (owner: 10Bgerstle)
[23:20:22] <grrrit-wm>	 (03PS2) 10Bgerstle: add unit testing target [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187828 
[23:20:51] <mhurd>	 bgerstle: we had “bronte”
[23:21:59] <grrrit-wm>	 (03CR) 10Mhurd: "Oops. Amended comment." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187828 (owner: 10Bgerstle)
[23:24:55] <grrrit-wm>	 (03PS1) 10Deskana: Capitalise first character of descriptions returned by action=mobileview [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187832 
[23:24:58] <Deskana>	 dbrant ^
[23:41:37] <dr0ptp4kt_>	 mhurd: https://phabricator.wikimedia.org/T88042
[23:41:59] <grrrit-wm>	 (03PS1) 10Phuedx: Register the PHPUnit test directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187833 
[23:42:20] <grrrit-wm>	 (03PS1) 10Mhurd: Fix for page loads deleting saved article data too aggressively. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187835 
[23:42:42] <wikibugs>	 3Wikipedia-App-iOS-App: "The Internet connection appears to be offline" appears when attempting to access saved pages while in airplane mode - https://phabricator.wikimedia.org/T88042#1005584 (10Mhurd) Patch with fix:  https://gerrit.wikimedia.org/r/187835
[23:44:42] <grrrit-wm>	 (03PS2) 10Mhurd: Fix for page loads deleting saved article data too aggressively. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187835 (https://phabricator.wikimedia.org/T88042) 
[23:45:49] <grrrit-wm>	 (03CR) 10Mhurd: [C: 031 V: 031] "Looks legit." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187828 (owner: 10Bgerstle)
[23:47:22] <mhurd>	 dr0ptp4kt_: bgerstle quick patch if you have some review cycles to spare: https://gerrit.wikimedia.org/r/#/c/187835/
[23:51:13] <grrrit-wm>	 (03PS3) 10Bgerstle: add unit testing target [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187828 
[23:51:29] <bgerstle>	 mhurd & dr0ptp4kt_ please re-review, just pushed a couple minor changes ^
[23:51:35] <mhurd>	 bgerstle: k
[23:52:17] <grrrit-wm>	 (03PS4) 10Bgerstle: add unit testing target [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187828 
[23:53:50] <bgerstle>	 mhurd quick chat?
[23:53:58] <bgerstle>	 i don't have context for this change
[23:54:01] <mhurd>	 bgerstle: ya!