[00:10:59] Maryana: https://bugzilla.mozilla.org/show_bug.cgi?id=1071620 [00:12:22] https://git.wikimedia.org/git/mediawiki/extensions/Thanks.git [00:12:27] ^ jhobs [00:20:39] (03PS1) 10Dbrant: Styling tweaks: toolbar/drawer shadows. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187839 [00:20:58] (03PS3) 10Mhurd: Fix for page loads deleting saved article data too aggressively. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187835 (https://phabricator.wikimedia.org/T88042) [00:22:20] bgerstle: amended [00:24:11] (03CR) 10Mhurd: [C: 031 V: 031] "Looks good." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187828 (owner: 10Bgerstle) [00:24:32] (03CR) 10Bgerstle: [C: 031] Fix for page loads deleting saved article data too aggressively. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187835 (https://phabricator.wikimedia.org/T88042) (owner: 10Mhurd) [00:24:46] (03CR) 10Jdlrobson: [C: 032] Register the PHPUnit test directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187833 (owner: 10Phuedx) [00:25:36] (03Merged) 10jenkins-bot: Register the PHPUnit test directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187833 (owner: 10Phuedx) [00:40:48] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Fix for page loads deleting saved article data too aggressively. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187835 (https://phabricator.wikimedia.org/T88042) (owner: 10Mhurd) [00:41:33] (03CR) 10Mhurd: [C: 031 V: 031] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184716 (owner: 10Brion VIBBER) [00:42:10] (03CR) 10Mhurd: [C: 032 V: 032] "Merge!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184716 (owner: 10Brion VIBBER) [00:42:26] (03PS5) 10Mhurd: (Work in progress) MWKImageMetadata object interface [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185548 (owner: 10Brion VIBBER) [00:42:39] (03CR) 10Mhurd: [C: 032 V: 032] "More merge!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/185548 (owner: 10Brion VIBBER) [00:42:59] (03PS4) 10Mhurd: Fix for page loads deleting saved article data too aggressively. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187835 (https://phabricator.wikimedia.org/T88042) [00:43:31] (03CR) 10Dr0ptp4kt: [V: 032] Fix for page loads deleting saved article data too aggressively. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187835 (https://phabricator.wikimedia.org/T88042) (owner: 10Mhurd) [00:45:31] (03CR) 10Mhurd: [C: 04-1] "Needs rebase / update." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [00:46:57] (03PS1) 10Dbrant: Styling tweaks: infobox color/shadow, disambig link padding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187843 [00:54:10] (03CR) 10Kaldari: [C: 032] Turn off universal box-sizing in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183987 (https://phabricator.wikimedia.org/T85068) (owner: 10Jdlrobson) [00:55:01] (03Merged) 10jenkins-bot: Turn off universal box-sizing in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183987 (https://phabricator.wikimedia.org/T85068) (owner: 10Jdlrobson) [01:08:56] (03PS1) 10Dbrant: Make nav drawer overlap over search bar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187849 [01:12:05] (03CR) 10Dr0ptp4kt: "Looks like this needs rebasing. @bgerstle, mind doing that?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187828 (owner: 10Bgerstle) [01:23:51] bgerstle: https://www.mediawiki.org/wiki/Mobile_web/Team/Onboarding [01:31:09] bgerstle: sorry to hit you from multiple angles. for the sake of not losing the message, though: mind rebasing https://gerrit.wikimedia.org/r/#/c/187828/ and resubmitting? [01:31:23] bgerstle: it otherwise looks good [01:31:24] yo [01:31:33] sittin' at the airport [01:31:35] drinkin' [01:31:37] reviewin' [01:31:43] Baller. [01:31:50] BEER REVIEW +2 [01:32:07] Jenkins says: JET LAG -1 [01:33:47] hahahaha [01:34:05] joakino is somehow eating [01:34:19] i don't understand how he can eat after the burgers that we had at lunch [01:38:58] emailin' [01:52:53] dr0ptp4kt: rebuilding now before pushing rebase [01:53:55] (03PS5) 10Bgerstle: add unit testing target [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187828 [01:54:41] dr0ptp4kt: mhurd rebased ^ [01:54:49] bgerstle: woohoo! [01:54:56] i'm a rebasing ninja [01:55:05] FYI there are some failing tests… should i disable them? [01:55:19] or leave them, and fix them ASAP [01:55:29] (since no CI builds are failing and bugging us, i say leave it) [01:55:33] bgerstle: we can maybe leave ‘em and fix soon [01:55:38] +1 [01:55:39] bgerstle: preference? [01:55:43] leave it [01:55:55] what's that saying? "if it's broken, don't fix it" [01:55:59] i'm pretty sure that's how it goes [01:56:22] if it’s broken, make the new guy fix it? ;) [01:56:39] har har [01:58:32] dr0ptp4kt: hey! [01:58:43] dr0ptp4kt: test [01:58:55] dr0ptp4kt: test 3 [01:59:52] mhurd: hova [02:25:05] (03PS6) 10Bgerstle: add unit testing target [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187828 [02:31:13] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] add unit testing target [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187828 (owner: 10Bgerstle) [03:33:34] (03PS1) 10Bgerstle: fix visual and web regressions [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187873 [03:42:15] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187873 (owner: 10Bgerstle) [03:48:33] hi [03:49:18] just test [04:46:56] (03PS1) 10Mhurd: Fix for blank article on startup regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187879 [05:44:16] does anyone this Could not GET 'https://tools.wmflabs.org/android-maven-repo/org/mediawiki/api/json/1.3.0/json-1.3.0.pom'. Received status code 503 from server: Service Temporarily Unavailable [05:52:23] 3Wikipedia-App-Android-App: NPE crash from DateFormat.getRelativeTimeSpanString calls - https://phabricator.wikimedia.org/T88202#1005999 (10Krenair) 3NEW [06:20:36] i'm novice to wikimedia-mobile and i got a problem ,see this http://stackoverflow.com/questions/28248801/build-problems-with-mediawikis-android-platform . hope someone can help me. [06:28:02] shine_, so, right now it's 22:28 SF time [06:28:27] so probably the mobile apps engineers are at home [06:33:00] ok, i from China,and my time is 14:30 pm . and i will come back some hours later. thanks [07:04:23] 3Editing, Mobile-Web, VisualEditor, Citoid: VE does not work in MobileFrontend - https://phabricator.wikimedia.org/T87869#1006020 (10Krenair) [07:18:19] 3Editing, Mobile-Web, VisualEditor: Editing breaks and edit button does nothing after switching from VE to wikitext editor - https://phabricator.wikimedia.org/T84898#1006028 (10Krenair) [10:42:32] 3MediaWiki-Categories, Mobile-Web: (3) 3 column responsive layout for categories so they render nicely on mobile - https://phabricator.wikimedia.org/T85496#1006074 (10Schnark) This causes a messed up display, see http://de.wikipedia.beta.wmflabs.org/wiki/Kategorie:Vorlage:f%C3%BCr_Vorlagen-Meister {F33481} The... [11:07:12] 3MediaWiki-Categories, Mobile-Web: (3) 3 column responsive layout for categories so they render nicely on mobile - https://phabricator.wikimedia.org/T85496#1006087 (10matmarex) 5Resolved>3Open Reopening, needs more work (and possibly a revert in the meantime). I posted a longer comment on the changeset. [11:24:17] 3MediaWiki-Categories, Mobile-Web: (3) 3 column responsive layout for categories so they render nicely on mobile - https://phabricator.wikimedia.org/T85496#1006137 (10matmarex) By the way, this is a duplicate of T55130. @jdlrobson, can you clean this up in a way that causes the least mess in the projects this is... [13:10:31] 3MediaWiki-Categories, Mobile-Web: (3) 3 column responsive layout for categories so they render nicely on mobile - https://phabricator.wikimedia.org/T85496#1006227 (10matmarex) [18:02:24] 3Wikipedia-App-Android-App: Images' metadata labels do not have spaces between words in 'More information' - https://phabricator.wikimedia.org/T86810#1006373 (10Krenair) [23:46:24] (03CR) 10Legoktm: [C: 032] Add 'license-name' matching SPDX conventions [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/187673 (owner: 10Ricordisamoa) [23:46:35] (03CR) 10Legoktm: [C: 032] Add 'license-name' matching SPDX conventions [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/187672 (owner: 10Ricordisamoa) [23:49:39] (03Merged) 10jenkins-bot: Add 'license-name' matching SPDX conventions [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/187673 (owner: 10Ricordisamoa) [23:49:41] (03Merged) 10jenkins-bot: Add 'license-name' matching SPDX conventions [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/187672 (owner: 10Ricordisamoa)