[00:33:42] Deskana, hey, is there a schedule for the next android app beta->stable release? [00:34:31] Krenair: We've not been sticking to it due to having to coordinate with comms. [00:34:40] Krenair: Is there something in particular in beta that you'd like to see make it to stable soon? [00:34:52] No, someone was asking me about a schedule [04:01:12] 3Editing, Mobile-Web, VisualEditor, Citoid: Citoid extension should target Mobile as well as desktop (otherwise it blocks VisualEditor loading in MobileFrontend) - https://phabricator.wikimedia.org/T87869#1007347 (10Jdforrester-WMF) [05:33:22] (03PS1) 10Mhurd: Merged the 2 glyph fonts into one. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188026 [05:36:09] (03PS2) 10Mhurd: Merged the 2 glyph fonts into one. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188026 [06:05:57] (03PS3) 10Mhurd: Merged the 2 glyph fonts into one. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188026 [08:36:37] 3Mobile-Web, Wikidata, MediaWiki-extensions-WikibaseRepository: Redirect loop on mobile diffs (wikidata) - https://phabricator.wikimedia.org/T88029#1007733 (10Lydia_Pintscher) [08:41:40] 3Mobile-Web: "Edit without login" button is hidden in editor cta - https://phabricator.wikimedia.org/T88264#1007744 (10Florian) 3NEW a:3Florian [08:42:01] (03CR) 10Florianschmidtwelzow: "caused: T88264" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185929 (https://phabricator.wikimedia.org/T87193) (owner: 10Bmansurov) [08:42:14] 3Mobile-Web: "Edit without login" button is hidden in editor cta - https://phabricator.wikimedia.org/T88264#1007752 (10Florian) Caused by: https://gerrit.wikimedia.org/r/#/c/185929/ [08:43:01] 3Mobile-Web: Editor switcher icon should not be shown in anon editor cta - https://phabricator.wikimedia.org/T88032#1007754 (10Florian) a:3Florian Will do this :) Thanks for pointing me to T88264, too :D [08:49:38] 3Mobile-Web: "Edit without login" button is hidden in editor cta - https://phabricator.wikimedia.org/T88264#1007766 (10Florian) [08:49:40] 3MobileFrontend-Feature-requests: [Tracking] Obstacles to enable anonymous editing for MobileFrontend users - https://phabricator.wikimedia.org/T55069#1007767 (10Florian) [08:50:16] 3Mobile-Web: "Edit without login" button is hidden in editor cta - https://phabricator.wikimedia.org/T88264#1007744 (10Florian) [08:50:17] 3MobileFrontend-Feature-requests: [Tracking] Obstacles to enable anonymous editing for MobileFrontend users - https://phabricator.wikimedia.org/T55069#569273 (10Florian) [08:50:35] 3Mobile-Web: "Edit without login" button is hidden in editor cta - https://phabricator.wikimedia.org/T88264#1007744 (10Florian) [09:27:30] 3MobileFrontend-Feature-requests: Don't override Special:Watchlist with Special:EditWatchlist - https://phabricator.wikimedia.org/T88270#1007848 (10Nemo_bis) 3NEW [12:01:01] 3Wikipedia-App-Android-App, Wikipedia-App-iOS-App, MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), MediaWiki-API: Mobile apps users should not be shown captchas when creating accounts - https://phabricator.wikimedia.org/T88083#1008076 (10Florian) >>! In T88083#1004511, @csteipp wrote: > For registration, w... [12:37:00] (03PS1) 10Florianschmidtwelzow: Don't hide "edit without login" button on editor cta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188043 (https://phabricator.wikimedia.org/T88264) [13:49:29] (03CR) 10Dbrant: [C: 032] Capitalise first character of descriptions returned by action=mobileview [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187832 (owner: 10Deskana) [14:53:49] (03PS1) 10Dbrant: Don't keep History, Saved Pages, or Nearby fragment in the backstack. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188050 [15:07:51] (03Abandoned) 10Dbrant: [WIP] Infobox/toolbar styling tweaks. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184793 (owner: 10Dbrant) [15:08:29] (03PS7) 10Dbrant: [WIP] Widgets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175225 [15:09:42] 3Quality-Assurance, Mobile-Web: Issue with Chrome driver with resizing window - https://phabricator.wikimedia.org/T88288#1008283 (10Jdlrobson) 3NEW [15:09:58] 3Mobile-Web: QA table of contents test failing for last 25 builds - https://phabricator.wikimedia.org/T87342#1008291 (10Jdlrobson) Hey @cmcmahon I will untag the tests for Chrome. Have setup T88288 to track this issue. [15:10:04] 3Mobile-Web: QA table of contents test failing for last 25 builds - https://phabricator.wikimedia.org/T87342#1008293 (10Jdlrobson) a:5Cmcmahon>3Jdlrobson [15:10:07] * jdlrobson2 waves [15:11:26] * dbrant waves [15:12:20] great to be back in 2 feet of snow! feelin' good about life! [15:12:53] (03CR) 10Jdlrobson: [C: 04-1] "Let's simplify this even more!" (037 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [15:13:06] dbrant: "_ [15:13:14] dbrant: i'm in even more sun :) [15:13:23] although just had a tropical rainstorm [15:13:34] *envy* [15:13:40] good to be on GMT-5 [15:15:14] 3Mobile-Web: Revisit box-sizing: border-box for everything in MobileFrontend - https://phabricator.wikimedia.org/T86366#1008295 (10Jdlrobson) Okay, code merged. Next step: Let's get this deployed and assess damage. I'm actually off on vacation, but does someone want to report back on improvement to VE in alpha @... [15:15:20] 3Mobile-Web: Revisit box-sizing: border-box for everything in MobileFrontend - https://phabricator.wikimedia.org/T86366#1008297 (10Jdlrobson) [15:15:49] 3Mobile-Web: Revisit box-sizing: border-box for everything in MobileFrontend - https://phabricator.wikimedia.org/T86366#967012 (10Jdlrobson) [15:16:47] 3Mobile-Web, Wikidata, MediaWiki-extensions-WikibaseRepository: Redirect loop on mobile diffs (wikidata) - https://phabricator.wikimedia.org/T88029#1008300 (10JanZerebecki) [15:19:21] (03PS1) 10Jdlrobson: Stop running certain tests on Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188051 (https://phabricator.wikimedia.org/T87342) [15:20:36] 3Mobile-Web: QA: Page actions menu when anonymous tests failing due to new selector - https://phabricator.wikimedia.org/T88289#1008305 (10Jdlrobson) 3NEW a:3Jdlrobson [15:23:58] (03PS1) 10Jdlrobson: Use more future proof selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188053 (https://phabricator.wikimedia.org/T88289) [15:28:44] (03CR) 10Cmcmahon: [C: 032] "Good call" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188053 (https://phabricator.wikimedia.org/T88289) (owner: 10Jdlrobson) [15:29:35] (03CR) 10Cmcmahon: "Good call" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188053 (https://phabricator.wikimedia.org/T88289) (owner: 10Jdlrobson) [15:30:50] hey codezee sorry about your patch getting reverted, I somehow missed the styling regression (still not sure how that happened). New patch will be even better i'm sure :-) [15:32:13] (03Merged) 10jenkins-bot: Use more future proof selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188053 (https://phabricator.wikimedia.org/T88289) (owner: 10Jdlrobson) [15:36:20] jdlrobson2, its ok, I was also at error to have overlooked the minute html error, I'm learning :) [15:36:32] hello everyone [15:36:45] codezee: yeh it can be a bit bumpy when you first start out :) [15:36:47] i'm getting emails from diffusion about code being committed. are we migrating already? [15:36:54] but don't be too disheartened :) [15:37:01] bgerstle: no you can turn those notifications off [15:37:04] i'd highly recommend it [15:37:05] they get noisy [15:37:19] jdlrobson2: thanks for the heads up [15:37:31] here's jdrlrobson1? WHAT DID YOU DO TO HIM? [15:37:37] s/here's/where's/ [15:37:46] jdlrobson2, to be honest, actually the start has so far been good, given the support I got at the captcha bug, and now, only a little problem [15:38:21] 3Mobile-Web: Overlay and Drawer should use events property for its event bindings - https://phabricator.wikimedia.org/T87192#1008336 (10Jdlrobson) [15:38:50] jdlrobson2, these things sometimes happen, so I'm still enjoying :) [15:38:56] codezee: https://phabricator.wikimedia.org/T87192 might be a good bug to poke at to understand the MobileFrontend client side code a little more if you are interested [15:39:08] it's not the most fun bug but will help you understand the internals and is relatively easy [15:39:23] bgerstle: 10:39 Error(437): jdlrobson Nick/channel is temporarily unavailable :( [15:39:31] it's closer i guess ;-) [15:40:02] 3Mobile-Web: QA: Page actions menu when anonymous tests failing due to new selector - https://phabricator.wikimedia.org/T88289#1008338 (10Jdlrobson) 5Open>3Resolved [15:40:13] (03PS2) 10Jdlrobson: QA: Use section-heading class to identify first section heading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187827 (https://phabricator.wikimedia.org/T87343) [15:40:25] jdlrobson1, alright, I'll look at it, thanks! [15:40:43] codezee: if you need any bugs let me know. I'm keen to get you more involved in MobileFrontend dev :) [15:40:49] jdlrobson1: i was getting that a lot last week, i suspected it had something to do w/ being sporadically kicked off wifi [15:41:10] sometimes restarting Adium helped [15:41:14] * bgerstle shrug [15:41:49] jdlrobson1: a small query, if I've changed OS, and there were incomplete patches, then will a simple "git review -d ", get them back in new mediawiki? [15:42:05] 3Editing, Mobile-Web, VisualEditor, Citoid: Citoid extension should target Mobile as well as desktop (otherwise it blocks VisualEditor loading in MobileFrontend) - https://phabricator.wikimedia.org/T87869#1008341 (10Jdlrobson) Please when adding the target ensure that the module is as lightweight as possible and... [15:42:46] jdlrobson1: alright, after I'm through with the catrgoryview bug, I'll let you know :) [15:42:56] codezee: sounds good :) [15:43:17] codezee: that should work yes [15:43:42] dbrant: if it's any consolation i'm being terrorised by mosquitos [15:44:15] jdlrobson1: you seem to be in tropics [15:44:22] jdlrobson1: still less depressing than a blizzard, imo! [15:44:23] codezee: Miami [15:54:43] jdlrobson: wait, what? [15:54:54] bgerstle: mm/ [15:54:56] you're in miami?? [15:55:03] bgerstle: yes [15:55:06] GTFO [15:55:09] I'M IN MIAMI [15:55:15] bgerstle: where? [15:55:23] and for how long [15:55:25] SoBe [15:55:27] i live here! [15:55:31] bgerstle: hah! [15:55:36] i'm in little havana [15:55:42] haha crazy [15:55:47] for how long? [15:55:52] bgerstle: until wednesday night [15:56:02] was thinking of going to see some live music tomorrow night in little havana if you want to join [15:56:03] when did you get in? [15:56:13] also desperately need to get a cubano sandwich this lunchtime [15:56:19] bgerstle: i arrived yesterday morning [15:56:27] Versailles is the place for cuban food [15:56:30] i needed a change of scenery :) [15:56:51] jdlrobson you just missed the nice cool weather, though i suppose you wanted something warmer than SF [15:57:11] bgerstle: yeh that place is not too far from mine. had the best roast pork ever yesterday at exquistito [15:57:19] nice [15:57:22] bgerstle: i'm off to brazil wednesday so i'm not too fussed about wather :) [15:57:27] haha nice [16:08:32] (03CR) 10Cmcmahon: [C: 032] QA: Use section-heading class to identify first section heading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187827 (https://phabricator.wikimedia.org/T87343) (owner: 10Jdlrobson) [16:09:36] (03Merged) 10jenkins-bot: QA: Use section-heading class to identify first section heading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187827 (https://phabricator.wikimedia.org/T87343) (owner: 10Jdlrobson) [16:10:01] jdlrobson: how long will you be in Brazil. I had a colleague once who spent 6 months working from Argentina because why not. we were all remote and the time zone is not too bad. [16:10:05] ? [16:10:32] (03CR) 10Jdlrobson: [C: 04-1] "nice catch!" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188043 (https://phabricator.wikimedia.org/T88264) (owner: 10Florianschmidtwelzow) [16:10:55] 3Mobile-Web: QA toggling sections test failing for last 25 builds - https://phabricator.wikimedia.org/T87343#1008379 (10Jdlrobson) 5Open>3Resolved [16:11:06] Deskana: ping [16:11:24] (03PS2) 10Jdlrobson: Stop running certain tests on Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188051 (https://phabricator.wikimedia.org/T87342) [16:11:33] FlorianSW: Hey! What's up? [16:12:05] (03PS3) 10Jdlrobson: QA: Stop running certain tests on Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188051 (https://phabricator.wikimedia.org/T87342) [16:12:14] Deskana: i remember a problem, that, if you're logged in in the android app, your edits still are saved with your ip adress, right? Was this fixed? [16:12:36] No, it's not been easy for us to fix [16:13:23] (03Abandoned) 10Jdlrobson: Remove border-box rule from reset.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (https://phabricator.wikimedia.org/T85068) (owner: 10Esanders) [16:13:39] phuedx: the coffee is outstanding and a welcome addition to my Monday morning :-) [16:13:53] (03PS4) 10Jdlrobson: Hygiene: Move wgResourceLoaderLESSVars out of extension function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187947 (owner: 10Florianschmidtwelzow) [16:13:59] (03CR) 10Florianschmidtwelzow: Don't hide "edit without login" button on editor cta (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188043 (https://phabricator.wikimedia.org/T88264) (owner: 10Florianschmidtwelzow) [16:14:05] jdlrobson1: ^ [16:14:13] hey FlorianSW :) [16:14:19] back in Deutschland? [16:14:31] hey :) Yeah, arrived at saturday evening :D [16:14:39] it's cold :P [16:14:48] chrismcmahon: i'm in Brazil for 20ish days [16:14:50] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move wgResourceLoaderLESSVars out of extension function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187947 (owner: 10Florianschmidtwelzow) [16:14:51] all vacation. [16:15:12] I have to say i'm enjoying the miami timezone. Nice to be closer to a bunch of people timewise :) [16:15:32] *yay* [16:15:34] :P [16:15:43] FlorianSW: i think you misunderstood my comment [16:15:54] ok? [16:16:22] so VisualEditorOverlay has a blue button in the top right corner too [16:16:43] Deskana: ok, hmm, so it's work-in-progress? Is there a task i can link to? [16:16:49] i'm saying it should be renamed to continue-edit if we are doing this [16:16:49] jdlrobson1: yep [16:16:58] basically we should have one selector [16:17:12] e.g. not 'click .continue,.continue-edit' but 'click .canonical-classname' [16:17:14] why? EditorOverlay still have a continue selector (the top right button) [16:17:30] it's confusing. [16:17:39] 3Editing, Mobile-Web, VisualEditor, Citoid: Citoid extension should target Mobile as well as desktop (otherwise it blocks VisualEditor loading in MobileFrontend) - https://phabricator.wikimedia.org/T87869#1008384 (10Jdforrester-WMF) >>! In T87869#1008341, @Jdlrobson wrote: > Please when adding the target ensure... [16:17:42] yes, that's why i said, that i split it up :D [16:17:45] let me explain: [16:18:56] The "Edit without logging in" is not semantically the same as the blue icon in the top right corner [16:19:04] if you're allowed to edit without login, the top right button will be hidden (using the .continue selector) and a new button (.continue-edit) allows you to go to the edit form. When you click the edit without login button, the top right button (.continue) will be visible. If you set for both the same class, both will be hidden :) [16:19:07] the latter means "stage edits" the former means "open editor" [16:19:30] jdlrobson1: ok, correct, let's find a better one, but it has to be a different name :) [16:19:47] .overlay-header .continue [16:19:53] would also be a better approach to distinguish them [16:20:01] only hide the one in the top right [16:20:15] hmm, ok, that's possible [16:20:26] either way multiple class names is what broke the bug so we should be careful to make this clearer so it doesn't break again [16:20:32] the continue class is weird though [16:20:38] as that is what mw-ui-progressive essentially means :) [16:20:56] maybe a todo/fixme :D [16:21:09] i'd rather fix this now whilst it has our attention [16:22:30] FlorianSW: https://www.mediawiki.org/wiki/Gerrit/Project_ownership#.2B2_for_Florian_Schmidt_on_mediawiki.2Fextensions.2FMobileFrontend pretty cool :-) [16:22:50] yeah :D Thanks @all [16:23:52] Thank YOU FlorianSW :-) [16:24:10] :) [16:24:35] (03PS2) 10Florianschmidtwelzow: Don't hide "edit without login" button on editor cta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188043 (https://phabricator.wikimedia.org/T88264) [16:25:28] 3Multimedia, MediaWiki-extensions-MultimediaViewer, Mobile-Web: Mobile Web and Multimedia viewer should use same hash fragment - https://phabricator.wikimedia.org/T87769#1008397 (10Jdlrobson) a:3Jdlrobson @Tgr I will submit a patch today to change it to media on our side. [16:26:36] (03PS1) 10Jdlrobson: Switch to canonical '/media' prefix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188059 [16:27:02] (03PS2) 10Jdlrobson: Switch to canonical '/media' prefix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188059 (https://phabricator.wikimedia.org/T87769) [16:27:24] jdlrobson1: about time zones, I like being east of CA, those early hours are productive [16:27:27] 3MediaWiki-extensions-CentralAuth, Mobile-Web: CentralAuth AutoLogin not working on mobile sites - https://phabricator.wikimedia.org/T87290#1008408 (10Jdlrobson) @kaldari ping me when this is deployed on enwiki [16:28:04] chrismcmahon: +1 [16:28:24] FlorianSW: how was rest of your day in sf? China beach looked great [16:28:27] did you get to ocean beach? [16:29:37] (03CR) 10jenkins-bot: [V: 04-1] Don't hide "edit without login" button on editor cta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188043 (https://phabricator.wikimedia.org/T88264) (owner: 10Florianschmidtwelzow) [16:30:03] jdlrobson1: it was a great day! Thanks for the tips. Yeah, i started at fort point (golden gate is amazing) and took the bus to china beach. [16:30:50] After i spent nearly 2 hours there i started to walk to ocean beach (i tought: "hey, how long can the way be" and it was really long :P) [16:31:13] (03CR) 10Cmcmahon: [C: 032] "I didn't look closely, but setting user-agent only works for Firefox" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188051 (https://phabricator.wikimedia.org/T87342) (owner: 10Jdlrobson) [16:32:12] (03Merged) 10jenkins-bot: QA: Stop running certain tests on Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188051 (https://phabricator.wikimedia.org/T87342) (owner: 10Jdlrobson) [16:33:31] and in the afternoon i started my backway using Golden Gate park (haven't crossed it entirely) and bus 38L, which took me into the city :) [16:37:10] (03CR) 10jenkins-bot: [V: 04-1] Switch to canonical '/media' prefix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188059 (https://phabricator.wikimedia.org/T87769) (owner: 10Jdlrobson) [16:38:24] * FlorianSW kicks Jenkins [16:44:41] (03CR) 10Florianschmidtwelzow: Register the PHPUnit test directory (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187833 (owner: 10Phuedx) [16:46:19] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188059 (https://phabricator.wikimedia.org/T87769) (owner: 10Jdlrobson) [16:46:37] 3Mobile-Web: QA table of contents test failing for last 25 builds - https://phabricator.wikimedia.org/T87342#1008465 (10Jdlrobson) 5Open>3Resolved [16:54:08] chrismcmahonbrb: is zeljko in today? [16:55:48] (03CR) 10Florianschmidtwelzow: "recehck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188043 (https://phabricator.wikimedia.org/T88264) (owner: 10Florianschmidtwelzow) [16:55:53] damn [16:56:01] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188043 (https://phabricator.wikimedia.org/T88264) (owner: 10Florianschmidtwelzow) [17:00:00] Deskana bearND https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8103902 maybe you can answer this? [17:00:30] and https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8103871 [17:00:31] dbrant, bearND: Yeah, that's one for one of you two to answer [17:01:05] (03CR) 10Jdlrobson: [C: 032] ":D" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188043 (https://phabricator.wikimedia.org/T88264) (owner: 10Florianschmidtwelzow) [17:01:53] 3Mobile-Web: "Edit without login" button is hidden in editor cta - https://phabricator.wikimedia.org/T88264#1008487 (10Florian) 5Open>3Resolved [17:01:55] 3MobileFrontend-Feature-requests: [Tracking] Obstacles to enable anonymous editing for MobileFrontend users - https://phabricator.wikimedia.org/T55069#1008488 (10Florian) [17:03:38] (03Merged) 10jenkins-bot: Don't hide "edit without login" button on editor cta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188043 (https://phabricator.wikimedia.org/T88264) (owner: 10Florianschmidtwelzow) [17:03:43] FlorianSW: thanks. The second one is sent to the iOS queue, but would probably good for Android as well. [17:04:22] 3Mobile-Web: Overlays not designed to be run from head - https://phabricator.wikimedia.org/T88295#1008494 (10Jdlrobson) 3NEW [17:04:34] (03CR) 10Jdlrobson: "@bmansurov this is https://phabricator.wikimedia.org/T88295" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185850 (owner: 10Jdlrobson) [17:04:48] bearND: did you see the issue with the build failing due to java-mwapi not downloading from our repo? [17:05:26] bgerstle: the sun came out :D [17:05:38] bearND: oops, you're right, sorry. Will you answer the android one? [17:05:40] jdlrobson1: zeljko was probably around earlier. he was at FOSDEM over the weekend. [17:05:52] chrismcmahon: okay. I need his help merging a config change [17:06:07] jdlrobson1: got a link? maybe I can help... [17:06:15] chrismcmahon: https://gerrit.wikimedia.org/r/#/c/186451/ [17:06:39] chrismcmahon: i'm keen to setup some smaller jobs for mobile based on features [17:08:19] FlorianSW: dbrant: Yes I can answer those [17:08:29] (03CR) 10Bgerstle: "Did some grepping on current master to figure out whether cache invalidation was consistent for each discovery method. Based on my findin" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187879 (owner: 10Mhurd) [17:09:57] bearND: thx [17:11:10] (03PS1) 10Florianschmidtwelzow: Hide all actions in editor cta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188061 (https://phabricator.wikimedia.org/T88032) [17:13:05] jdlrobson1: I agree. I have some other ideas for those also. [17:16:27] (03PS5) 10Jdlrobson: Fix UploadTutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185850 [17:18:23] (03CR) 10jenkins-bot: [V: 04-1] Fix UploadTutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185850 (owner: 10Jdlrobson) [17:19:11] 3Mobile-Web: Closing mobile media viewer always scrolls to top on FF, IE - https://phabricator.wikimedia.org/T87156#1008530 (10Jdlrobson) Strange. What is Chrome doing differently (as it's not an issue there)? [17:22:08] (03CR) 10Jdlrobson: Hide all actions in editor cta (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188061 (https://phabricator.wikimedia.org/T88032) (owner: 10Florianschmidtwelzow) [17:22:28] (03PS6) 10Jdlrobson: Fix UploadTutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185850 [17:22:45] (03CR) 10Florianschmidtwelzow: Hide all actions in editor cta (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188061 (https://phabricator.wikimedia.org/T88032) (owner: 10Florianschmidtwelzow) [17:24:16] (03PS2) 10Florianschmidtwelzow: Hide all actions in editor cta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188061 (https://phabricator.wikimedia.org/T88032) [17:25:45] (03CR) 10Bgerstle: [C: 04-1] "Please consider doing a global find/replace on the @"WikiFont-Glyphs" font creation for a UIFont category. It shouldn't be too tedious, h" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188026 (owner: 10Mhurd) [17:33:48] 3Mobile-Web: Overlay, Panel and Drawer should use events property for its event bindings - https://phabricator.wikimedia.org/T87192#1008541 (10Jdlrobson) [17:34:17] 3Mobile-Web: ErrorReportOverlay not using View##event - https://phabricator.wikimedia.org/T88296#1008542 (10Jdlrobson) 3NEW [17:34:26] bb in 30 [17:34:59] 3Mobile-Web: ErrorReportOverlay, Infobox, WikiGrokDialogs not using View##event - https://phabricator.wikimedia.org/T88296#1008551 (10Jdlrobson) [17:51:36] (03CR) 10Phuedx: Register the PHPUnit test directory (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187833 (owner: 10Phuedx) [17:51:44] hey all [17:51:50] * phuedx has had a /big/ sleep [17:52:22] yo [17:52:27] feeling better? [17:54:32] MaxSem: yeah, i think it may have just been jet lag [17:54:36] i may have been lucky [17:54:53] had a mighty headache which seems to have disappeared after sleeping [17:59:25] phuedx its ok to admit you stayed up late to watch the superbowl. [17:59:37] wait [17:59:42] what's "superbowl" [17:59:45] is that a food thing? [18:00:05] phuedx that recycled air sucks [18:00:16] or does it blow? *shrug* [18:00:18] lol - a large bread bowl of chili I believe [18:00:45] phuedx it's like the world cup, only we're the only country that plays and it's that "other" football [18:02:04] (03PS1) 10Florianschmidtwelzow: Hygiene: Use __DIR__ directly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188081 [18:02:06] (03PS8) 10Dbrant: [WIP] Widgets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175225 [18:03:34] phuedx: Ibb3f1ed09dcfcf4270185e5dc4ef38f7e0e1898d :) [18:03:42] (03PS2) 10Phuedx: Hygiene: Use __DIR__ directly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188081 (owner: 10Florianschmidtwelzow) [18:03:54] damn... ah, you found it :D [18:04:09] (03CR) 10Phuedx: [C: 032] Hygiene: Use __DIR__ directly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188081 (owner: 10Florianschmidtwelzow) [18:04:27] (03CR) 10Florianschmidtwelzow: Register the PHPUnit test directory (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187833 (owner: 10Phuedx) [18:06:11] phuedx: in the hous! [18:06:23] phuedx: it's about some kind of superb owl [18:06:29] lol [18:06:40] people get beer and watch it fly i think [18:06:52] and the head it lands on wins [18:07:01] it catches field mice really, really well? [18:07:10] phuedx: REALLY well [18:07:19] rmoen: 'sup [18:07:22] (03Merged) 10jenkins-bot: Hygiene: Use __DIR__ directly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188081 (owner: 10Florianschmidtwelzow) [18:07:37] jdlrobson1: looking at storage POC [18:07:39] rmoen: since i'm picky do you want me to have a pass on the Special:Collections page? [18:07:48] jdlrobson1: sure [18:07:49] rmoen: and hopefully we can bully phuedx into merging it [18:07:50] cool [18:07:54] right will do that right now [18:10:19] https://www.mediawiki.org/w/index.php?title=Gerrit/Project_ownership&curid=83703&diff=1389616&oldid=1389612 *yay* [18:11:04] (03PS3) 10Jdlrobson: Introduce Special:Collections page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [18:11:06] (03PS1) 10Jdlrobson: WIP: Abstract Watchlist storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188083 [18:11:27] (03CR) 10Jdlrobson: [C: 04-1] "i'm picking this up" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [18:13:07] (03CR) 10jenkins-bot: [V: 04-1] WIP: Abstract Watchlist storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188083 (owner: 10Jdlrobson) [18:13:41] (03CR) 10Florianschmidtwelzow: [C: 032] "yay :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188059 (https://phabricator.wikimedia.org/T87769) (owner: 10Jdlrobson) [18:14:43] (03CR) 10jenkins-bot: [V: 04-1] Switch to canonical '/media' prefix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188059 (https://phabricator.wikimedia.org/T87769) (owner: 10Jdlrobson) [18:16:18] * FlorianSW thanks jenkins for "let's fail his first merge in MobileFrontend"! [18:16:25] (03CR) 10Phuedx: "Sorry Anomie. Have been out with weird jet lag/cold-like thing for most of Sunday/Monday." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie) [18:16:39] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188059 (https://phabricator.wikimedia.org/T87769) (owner: 10Jdlrobson) [18:18:49] (03CR) 10Florianschmidtwelzow: [C: 032] Switch to canonical '/media' prefix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188059 (https://phabricator.wikimedia.org/T87769) (owner: 10Jdlrobson) [18:19:45] (03Merged) 10jenkins-bot: Switch to canonical '/media' prefix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188059 (https://phabricator.wikimedia.org/T87769) (owner: 10Jdlrobson) [18:25:57] (03PS1) 10MaxSem: Clarify license [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/188086 (https://phabricator.wikimedia.org/T88251) [18:27:32] (03CR) 10Bmansurov: [C: 032] Hide all actions in editor cta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188061 (https://phabricator.wikimedia.org/T88032) (owner: 10Florianschmidtwelzow) [18:28:24] can i spin up vagrant, test a patch, and spin it down in 2 minutes? [18:28:28] i think not [18:28:37] (03Merged) 10jenkins-bot: Hide all actions in editor cta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188061 (https://phabricator.wikimedia.org/T88032) (owner: 10Florianschmidtwelzow) [18:28:46] kaldari: yt? [18:30:06] kristenlans i'm moving the stuff over to board 50, FYI [18:30:22] for iOS, at least [18:31:27] kristenlans done! [18:32:17] (03CR) 10Fjalapeno: [C: 04-1] "Agreement with Brian on this took the words out of my mouth." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188026 (owner: 10Mhurd) [18:32:26] LIZARD DOING PUSH UPS [18:32:40] (03CR) 10Bmansurov: [C: 04-1] "needs rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 (owner: 10Jdlrobson) [18:33:27] dr0ptp4kt: sorry in advance for having to rebase on top of CocoaPods changes :-( [18:33:46] jdlrobson1: yeah, they do that… often while flaring their neck thingy [18:33:48] bgerstle: thanks, you're a champ [18:34:00] kristenlans: FYI there's a way to do it while preserving card ata [18:34:08] card data* [18:34:15] (03CR) 10Fjalapeno: "Also you may want to start grouping anything style related into its own group with common naming conventions." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188026 (owner: 10Mhurd) [18:35:19] 3Mobile-Web: Editor switcher icon should not be shown in anon editor cta - https://phabricator.wikimedia.org/T88032#1008770 (10bmansurov) 5Open>3Resolved [18:35:42] jdlrobson1: you joining retro [18:37:04] (03CR) 10Ricordisamoa: Clarify license (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/188086 (https://phabricator.wikimedia.org/T88251) (owner: 10MaxSem) [18:37:06] 3Multimedia, MediaWiki-extensions-MultimediaViewer, Mobile-Web: Mobile Web and Multimedia viewer should use same hash fragment - https://phabricator.wikimedia.org/T87769#1008774 (10Jdlrobson) @Tgr I'm removing #Mobile-Web tag as we are done on our end. [18:37:53] https://etherpad.wikimedia.org/p/MobileWeb-Retrospective [18:38:27] bgerstle: i deserve it for not rebasing along the way! [18:38:43] https://etherpad.wikimedia.org/p/MobileWeb-Retrospective [18:38:47] (03PS1) 10Dbrant: Ripple effect when highlighting Nav items. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188089 [18:38:50] (03PS2) 10MaxSem: Clarify license [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/188086 (https://phabricator.wikimedia.org/T88251) [18:39:01] dr0ptp4kt: FWIW enabling rerere in git will help you in the future [18:40:43] http://git-scm.com/blog/2010/03/08/rerere.html [18:41:00] TL;DR; it helps you "re" apply conflict resolutions while rebasing [18:41:05] (automatically) [18:41:19] so if you're on a long-lived branch and you continually rebase, this will save you lots of time [18:41:36] but yeah, long-lived branches are a pain no matter what [18:42:29] (03CR) 10Fjalapeno: "Do we know why we are invalidating the cache in each instance (or why that flag was created?)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187879 (owner: 10Mhurd) [18:43:18] coreyfloyd: regarding ^, did you see my gist? [18:43:30] yeah I did [18:43:35] but either way, the reason for the discovery reasons is unclear [18:43:41] the reason for the reason… [18:43:44] the meta-reason? [18:43:46] right - i see where - not why [18:44:21] IIRC, mhurd (who appears to be offline) was saying it's related to attempting to grab a newer revision [18:44:29] (03CR) 10BearND: [C: 04-1] "Works great on 4.x and 5.x. Needs improvement for GB: in dark mode I get white text on light gray background." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187464 (https://phabricator.wikimedia.org/T85809) (owner: 10Dbrant) [18:47:50] (03CR) 10BearND: [C: 032] Ripple effect when highlighting Nav items. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188089 (owner: 10Dbrant) [18:49:09] (03Merged) 10jenkins-bot: Ripple effect when highlighting Nav items. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188089 (owner: 10Dbrant) [18:49:37] (03CR) 10Ricordisamoa: [C: 031] "I've CC'ed every patch author I could find. All of them should probably +1 this." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/188086 (https://phabricator.wikimedia.org/T88251) (owner: 10MaxSem) [18:54:52] (03PS1) 10Bgerstle: remove cocoapods notes.txt [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188093 [18:55:54] mhurd: dr0ptp4kt: coreyfloyd & i forgot to remove that file when fixing cocoapods integration ^ [18:56:10] doh! [18:56:30] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188093 (owner: 10Bgerstle) [18:56:32] (03PS2) 10Bgerstle: remove cocoapods notes.txt [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188093 [18:56:36] merged [18:56:39] k [18:56:44] i just amended the commit message, nbd [18:57:02] bgerstle: oh sorry! [18:57:17] not a problem [18:57:51] gah, forgot to remove the file from the proj [18:58:17] (03CR) 10BearND: [C: 04-1] "Main issue see CIL." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187849 (owner: 10Dbrant) [19:01:34] (03PS3) 10Dbrant: Switch to using PreferenceFragment for settings. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187464 (https://phabricator.wikimedia.org/T85809) [19:02:38] (03PS4) 10Dbrant: Switch to using PreferenceFragment for settings. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187464 (https://phabricator.wikimedia.org/T85809) [19:03:03] (03CR) 10BearND: [C: 04-1] "Why not use elevation?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187839 (owner: 10Dbrant) [19:03:20] (03CR) 10Mhurd: "Good points. Amending..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188026 (owner: 10Mhurd) [19:03:27] (03PS4) 10Mhurd: Merged the 2 glyph fonts into one. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188026 [19:04:31] (03PS1) 10Bgerstle: remove cocoapods notes.txt & test.xcconfig from .xcodeproj [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188095 [19:05:30] mhurd just added you to another quick cleanup. just removed a couple files that don't exist from the xcodeproj ^ [19:05:38] if you'd be so kind [19:06:01] bgerstle: on it [19:06:21] thanks [19:07:04] especially since i broke master w/ that last change… if only we had something to auto-build & test the project to catch stupid mistakes like mine :-( [19:07:22] bgerstle: ;) [19:07:31] (03PS2) 10BearND: Don't keep History, Saved Pages, or Nearby fragment in the backstack. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188050 (owner: 10Dbrant) [19:07:39] (03CR) 10BearND: [C: 032] Don't keep History, Saved Pages, or Nearby fragment in the backstack. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188050 (owner: 10Dbrant) [19:08:03] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188095 (owner: 10Bgerstle) [19:08:07] (03Merged) 10jenkins-bot: Don't keep History, Saved Pages, or Nearby fragment in the backstack. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188050 (owner: 10Dbrant) [19:08:20] (03CR) 10Dbrant: "@BearND, should be fixed. The line that sets the theme for the PreferenceActivity somehow ended up in the wrong place." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187464 (https://phabricator.wikimedia.org/T85809) (owner: 10Dbrant) [19:10:17] (03CR) 10Phuedx: [C: 031] "I've tested the basic mobile features (incl. Discussion and editing) with the dependent change enabled and disabled and it works OK." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie) [19:11:04] (03PS5) 10Mhurd: Merged the 2 glyph fonts into one. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188026 [19:11:53] (03PS5) 10BearND: Switch to using PreferenceFragment for settings. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187464 (https://phabricator.wikimedia.org/T85809) (owner: 10Dbrant) [19:12:20] (03CR) 10BearND: [C: 032] "Perfect!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187464 (https://phabricator.wikimedia.org/T85809) (owner: 10Dbrant) [19:12:23] mhurd dr0ptp4kt coreyfloyd what are your thoughts on prefixing category methods? [19:12:41] (03Merged) 10jenkins-bot: Switch to using PreferenceFragment for settings. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187464 (https://phabricator.wikimedia.org/T85809) (owner: 10Dbrant) [19:12:59] bgerstle: dr0ptp4kt coreyfloyd no issue with doing so [19:13:18] e.g. any UIFont/UIColor categories would probably start w/ whatever our class prefix is, like wmf_glyphFont [19:13:26] bgerstle: mhurd coreyfloyd i'm okay with that. you thinking to avoid conflicts? [19:13:32] dr0ptp4kt: that's the idea [19:13:40] bgerstle you really are supposed to (especially with anything that extends a framework class) [19:13:59] right, that's what apple recommends [19:14:17] sounds good. prepend “mw_” ? [19:14:18] especially since i don't _think_ you'll get a compiler error in the event of a collision [19:14:23] just undefined behavior :-( [19:14:27] "wmf" is fine with me if you want to go 3 letters - I started with "wm" [19:14:33] +1 for 3 letters [19:14:34] 3Wikipedia-App-Android-App: Unchecked checkboxes aren't visible in dark theme - https://phabricator.wikimedia.org/T85809#1008955 (10Dbrant) 5Open>3Resolved a:3Dbrant [19:15:16] mhurd: "mw" seems reserved for mediawikikit currently - so we should pick something different for app specific code [19:15:43] coreyfloyd: bgerstle: dr0ptp4kt: so “wmf” with no underscore - ie “wmfFoo”? [19:15:52] coreyfloyd: MediaWikiKit uses MWK [19:16:06] mhurd: in this case i'd prefer prefix_cameCaseMethodName [19:16:13] camelCase* [19:16:29] coreyfloyd: dr0ptp4kt ^ sound good? [19:16:55] coreyfloyd: TBH i think MWK should be assimilated into the main project. i don't really see the benefit of keeping it external [19:16:58] sounds good to me…(prefixing methods is one of the few cases you use underscores in cocoa.) [19:17:02] but that's a discussion for another day [19:17:16] yah i think we shoulddiscus collapsing another day [19:17:43] I can definitely see why Brion made it a separate piece [19:18:10] mhurd: coreyfloyd bgerstle i'm cool with the underscore [19:18:15] mainly i wanted it separate from the UI for testing [19:18:21] feel free to rearrange it however you guys prefer :D [19:18:41] yeah, that's what i figured—but seeing as the main app has its own unit testing target now ;-) ;_) [19:20:20] bgerstle Sounds good I'll update my pull request with WMF [19:21:47] dr0ptp4kt mhurd bgerstle we should probably start renaming class names as we work. So anything new for sure. [19:21:54] +1 [19:22:18] coreyfloyd: yep [19:22:36] http://cdn.meme.am/instances/500x/58740635.jpg [19:22:56] but first, lunch [19:23:04] bbiab [19:24:03] actually, Deskana: we don't need legal review for libraries using the MIT license, right? [19:24:13] and if not, does that also apply to BSD? [19:24:29] on top of that, both libraries in question are unit-testing libraries, not app/widget frameworks [19:25:47] bgerstle: I'd say that if a library is under a pretty reasonable standard copyleft licence (MIT, GPL, BSD, etc) then you can assume that you can use it until told otherwise [19:25:57] w00t [19:26:16] Notwithstanding any data being sent to third parties blocking it (which you said isn't relevant in this case) [19:27:03] right [19:32:12] cleaned up our mobile app backlog a bit [19:32:22] iOS tech backlog, at least [19:33:04] k, seriously getting something to eat now o/ [19:33:17] (03PS6) 10Mhurd: Merged the 2 glyph fonts into one. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188026 [19:33:46] coreyfloyd: dr0ptp4kt ^ [19:34:03] amended with UIFont category [19:35:50] mhurd: will review in 10 mins or so [19:36:00] coreyfloyd: dr0ptp4kt oh crap i forgot to remove some comments... [19:37:38] mhurd also, you can check with Brian, but I typically only "_" the category method names - I don't think you need to do it to the category name itself. [19:38:05] coreyfloyd: oh sure. amending… [19:38:09] So WMFStyle… but wmf_font… [19:38:24] coreyfloyd: sounds good [19:39:05] mhurd I think that is matter pf preference though… [19:40:04] mhurd one last thing "glyph" should still be lower case [19:40:21] coreyfloyd: cool. fixing… [19:40:47] I guess the logic is that you underscore so you don't need to camel case the first letter [19:41:01] coreyfloyd: makes sense [19:42:36] dr0ptp4kt: Moved this into the current sprint: https://trello.com/c/GK7sLmp2/26-3-tweet-a-fact-eventlogging-for-tweet-a-fact [19:44:40] (03Restored) 10Krinkle: Sample commit for Jenkins [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/187532 (owner: 10Krinkle) [19:44:43] (03PS2) 10Krinkle: Sample commit for Jenkins [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/187532 [19:47:20] (03PS7) 10Mhurd: Merged the 2 glyph fonts into one. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188026 [19:49:07] mhurd - I forget what the process is for the localization - you have a minute to discus? [19:49:18] coreyfloyd: ya [19:49:26] lemme find my headphones... [19:49:30] k [19:50:36] https://trello.com/b/ORQY7kE7/wikigrok-unstructured-sprint-39-mad-max [19:51:09] Software gore in iOS itself: http://i.imgur.com/EYiiqCj.jpg [19:57:38] (03PS2) 10Dbrant: [WIP] Make nav drawer overlap over search bar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187849 [20:00:57] rmoen: just about to submit a new patch then run out for lunch [20:00:59] am starving [20:01:21] jdlrobson1: ok [20:01:52] jdlrobson1: I will review. I have 1:1 with tom until 1:30. Should we chat after that? [20:02:39] rmoen: sure [20:02:44] (03PS4) 10Jdlrobson: WIP: Introduce Special:Collections page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [20:03:03] (03Abandoned) 10Jdlrobson: WIP: Abstract Watchlist storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188083 (owner: 10Jdlrobson) [20:03:55] (03CR) 10jenkins-bot: [V: 04-1] WIP: Introduce Special:Collections page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [20:05:29] ok bbiab [20:05:34] 3Wikipedia-App-Android-App, RESTBase, Wikipedia-App-iOS-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1009272 (10Deskana) @mobrovac Sure, do you want to set it up since you know better than I what the agenda should be? [20:06:01] http://hatjitsu.wmflabs.org/86480 [20:10:29] Deskana: thx [20:17:31] kaldari: yt? [20:17:45] nuria: almost done with meeting [20:17:53] kaldari: ok, you let me know [20:19:03] (03CR) 10Fjalapeno: [C: 031] "Looks good to me." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188026 (owner: 10Mhurd) [20:23:16] dr0ptp4kt: mhurd coreyfloyd warning: you might want to configure your "global find" in xcode to only search the Wikipedia project (and skip all the pods) [20:23:51] there's a small ellipsis-sandwich-button-thing underneath the search bar that says "In workspace" by default (or something) [20:26:12] (03PS1) 10Dbrant: Nearby: secondary action instead of long-click to view on a map. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188110 [20:26:24] (03CR) 10Bgerstle: [C: 031] "I guess there's no "default" size, so we'll need to refactor font sizes (and colors) another time. Until then, +1!" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188026 (owner: 10Mhurd) [20:26:48] mhurd: +1 administered. do you want any of us to double-check any visual stuff? [20:26:53] or elena, maybe? [20:27:22] (03PS2) 10Dbrant: Styling tweaks: toolbar/drawer shadows. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187839 [20:27:41] mhurd when testing iOS 6 are you running the app from Xcode 5 or did you pimp Xcode 6 to run the iOS 6 simulator? [20:28:10] good call, i'm downloading the iOS 7 sim now [20:28:31] don't see an option for iOS 6 though [20:29:20] bgerstle you cant install it by normal means [20:29:35] i only see an option for iOS 7 [20:30:59] https://etherpad.wikimedia.org/p/N_sprint! [20:31:09] https://en.wikipedia.org/wiki/List_of_films:_N–O [20:32:49] bgerstle you can copy the SDK from xcode 5 to xcode 6 I believe - but thats about it. Otherwise you can run it on an iOS 6 device [20:33:07] or use xcode 5 [20:33:26] i dont like how xcode version numbers are n-1 iOS SDK numbers [20:33:51] https://etherpad.wikimedia.org/p/N_sprint [20:34:20] (03PS1) 10Hashar: Delay ZeroBanner die requirement after setup [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/188115 (https://phabricator.wikimedia.org/T88015) [20:34:53] right, that's what i figured [20:34:53] (03CR) 10Hashar: "Should let one include ZeroPortal first, then ZeroBanner." [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/188115 (https://phabricator.wikimedia.org/T88015) (owner: 10Hashar) [20:35:23] mhurd: cubano #1 :-) [20:40:40] (03PS5) 10Robmoen: WIP: Introduce Special:Collections page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [20:41:40] (03CR) 10jenkins-bot: [V: 04-1] WIP: Introduce Special:Collections page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [20:45:58] (03PS6) 10Jdlrobson: Introduce Special:Collections page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [20:46:54] (03CR) 10jenkins-bot: [V: 04-1] Introduce Special:Collections page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [20:47:02] jdlrobson1: thoughts on pagination ? [20:47:09] rmoen: resolve later :) [20:47:12] ok [20:47:29] I'm going to follow up with some fixes to some php notices on that patch [20:47:31] rmoen: i think we'll need it but i updated commit/code to reflect the current state [20:47:34] rmoen: i was just doing that [20:47:35] & warnings [20:47:36] ok [20:47:37] so hang on :) [20:47:41] go head ;) [20:48:12] (03PS7) 10Jdlrobson: Introduce Special:Collections page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [20:48:17] rmoen: done &^ [20:48:34] (03CR) 10Jdlrobson: [C: 031] "someone outside collections team should probably +2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [20:49:48] rmoen: so there are 2 checkboxes to finish up https://trello.com/c/3Ce95D3R/1-3-basic-presentation-of-a-list [20:49:57] not sure if you want to pick those up or for me to do them [20:50:14] jdlrobson1: I'll take them [20:50:27] jdlrobson1: also there are still some notices on that patch [20:50:31] (03CR) 10Jdlrobson: [C: 04-1] "2 of acceptance criteria not met" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [20:50:33] jdlrobson1: i can address them [20:50:34] rmoen: ok all yours [20:50:55] rmoen: i'm gonna rewrite the temporary backend solution based on this patch [20:51:01] (03CR) 10Legoktm: [C: 04-1] "This should use $wgExtensionFunctions instead." [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/188115 (https://phabricator.wikimedia.org/T88015) (owner: 10Hashar) [20:51:03] jdlrobson1: awesome [20:52:57] (03PS8) 10Robmoen: Introduce Special:Collections page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [20:53:12] ^ no more notices or warnings [20:53:35] (03CR) 10Robmoen: [C: 031] Introduce Special:Collections page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [20:54:52] rmoen: whaat bout acceptance criteria? [20:55:22] jdlrobson1: oops, did i trump your commit msg ? [20:55:32] no why? [20:56:03] (03CR) 10Jdlrobson: [C: 04-1] "Note acceptance criteria still need to be fulfilled:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [20:56:31] 3Mobile-Web: Location template disregarded in collapsed sections - https://phabricator.wikimedia.org/T88320#1009395 (10Thgoiter) 3NEW [20:56:35] jdlrobson1: working on that [20:57:09] jdlrobson1: now i understand what you mean, i'll put that in same patch [21:03:47] bgerstle: thx for hint! [21:05:37] np [21:07:33] marxarelli: still available to pair on those browser tests today? I'm in the hangout [21:09:53] jdlrobson: yay! :) [21:11:09] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Merged the 2 glyph fonts into one. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188026 (owner: 10Mhurd) [21:11:21] woohoo! [21:12:17] (03CR) 10Dbrant: "@BearND, elevation is only supported in 5.0+, so we need manual gradients to simulate elevation in earlier versions. We could theoreticall" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187839 (owner: 10Dbrant) [21:13:58] (03PS2) 10Mhurd: Fix for blank article on startup regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187879 [21:17:41] rmoen: jdlrobson: i just got back [21:18:21] how did the standup go? where are we at? what do I need to know for working tomorrow? [21:20:12] (03CR) 10MaxSem: [C: 04-2] "Please do it in a separate extension." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [21:23:33] (03CR) 10Mhurd: "Cache invalidation was added as a parameter before I knew exactly how each type of fetch would need to deal with cache invalidation - i.e." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187879 (owner: 10Mhurd) [21:23:45] coreyfloyd: bgerstle dr0ptp4kt ^ [21:24:18] joakino: jdlrobson and I have been working on your patch to try to get it merged today.. There are still acceptance criteria items I was going to work on today. Though MaxSem just left feedback saying we need to do this in a sep extension. [21:24:30] yes please [21:24:36] rmoen: i was just checking the patch [21:24:46] MaxSem: any particular reason why ? [21:25:06] MaxSem: please not yet [21:25:06] MaxSem: it's gonna give us huge headaches [21:25:06] mf is a god repository already [21:25:06] we don't know how all the pieces fit together yet [21:25:06] -2 with no explanation is kinda cruel :) [21:25:12] i don't want to have dependency hell [21:25:26] i'm already rewriting a bunch of stuff in that patch to support user page storage [21:25:40] jdlrobson, for the same reason as I -2'd your other patch [21:25:40] MaxSem: indeed, this will slow us up a bit [21:25:57] brb, cooking [21:26:07] mediawiki's extension system sucks. It doesn't help this sort of work especially in client side development [21:26:24] why on earth do you want to pile everything in one place? [21:26:44] MaxSem: to make everyones lives easier. At least for the first 2 iterations [21:27:17] over my dead body because later you will say it's not splittable just like you did with wikiigrok [21:27:20] otherwise we're gonna to have to construct a crappy hooks system for adding stuff to main menus, we're gonna have duplicate code for watchlist it's gonna be a nightmare [21:27:31] MaxSem: wikigrok isn't splittable! [21:27:48] precisely [21:27:48] sigh. [21:27:55] jdlrobson: rmoen please guys comment on the trello cards about their state at the end of the day so that I can get a picture when I start tomorrow (that or email would be nice) [21:28:13] joakino: well looks like current state is Max is blocking any dev ^ [21:29:10] xD jdlrobson i see [21:29:13] fight! http://blog.lhyeung.net/wp-content/uploads/2009/07/sfivpc02b.jpg [21:29:14] MaxSem: we don't know what we are building yet but setting up a new extension adds a whole deal of complexity we're not ready for. [21:29:18] I'm blocking only piling of code in one place [21:29:24] i already have a massive headache today from reshuffling around MobileFrontend code [21:29:35] bgerstle: quick hangout? [21:29:44] we need extensions subextensions on mediawiki [21:29:44] yep [21:30:00] joakino careful what you wish for.. [21:30:24] haha [21:30:30] Mantle is proof that extension dependencies do not work [21:33:47] (03CR) 10MaxSem: [C: 04-2] "Please do it in a separate extension." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187616 (owner: 10Jdlrobson) [21:34:03] bgerstle: https://github.com/montehurd/apps-ios-wikipedia/commit/e1f1d901e7565622fe562992e935429c42113a1b [21:34:24] 3Mobile-Web: Location template disregarded in collapsed sections - https://phabricator.wikimedia.org/T88320#1009563 (10dschwen) {{Location}} is a separate template that inserts a box below the {{Information}} template. We use a border-collapse trick to make it look like the location row is part of the informatio... [21:35:55] 3Mobile-Web: Closing mobile media viewer always scrolls to top on FF, IE - https://phabricator.wikimedia.org/T87156#1009580 (10Tgr) For the desktop product, we save/restore the scroll position from JS. [21:37:07] (03CR) 10Fjalapeno: [C: 031] "Yeah thats good for me!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187879 (owner: 10Mhurd) [21:39:00] 3Mobile-Web: Cannot open the same image twice in mobile media viewer - https://phabricator.wikimedia.org/T88336#1009607 (10Tgr) 3NEW [21:41:27] 3Wikipedia-App-Android-App, RESTBase, Wikipedia-App-iOS-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1009619 (10mobrovac) Ok, you should all have an invite for tomorrow morning (PST). [21:45:49] 3Mobile-Web, Wikidata, MediaWiki-extensions-WikibaseRepository: Redirect loop on mobile diffs (wikidata) - https://phabricator.wikimedia.org/T88029#1009625 (10MaxSem) a:3MaxSem [21:46:52] bb in 30 or so [21:49:38] (03PS3) 10Mhurd: Fix for blank article on startup regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187879 [21:49:54] kaity: hey, can you please upload the wikigrok icon to https://trello.com/c/uZ9geKCR/15-3-tell-people-about-what-contribute-is-when-they-click-on-it-in-left-nav ? Thanks [21:54:08] (03CR) 10Bgerstle: [C: 031] "LGTM, we can revisit caching/history logic & architecture at a later date. in the meantime, this should fix regressions related to caching" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187879 (owner: 10Mhurd) [21:54:13] dr0ptp4kt: brian and corey +1’ed this: https://gerrit.wikimedia.org/r/187879 [21:54:19] 3Mobile-Web: Closing mobile media viewer always scrolls to top on FF, IE - https://phabricator.wikimedia.org/T87156#1009641 (10Jdlrobson) We do on mobile too.. for some reason only applying in Chrome though. [21:57:35] bgerstle: #import "UIWebView+ElementLocation.h" [21:59:28] kristenlans: Headed upstairs for the meeting. [22:03:06] (03CR) 10Sn1per: [C: 031] "Fine by me :)" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/188086 (https://phabricator.wikimedia.org/T88251) (owner: 10MaxSem) [22:06:24] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Fix for blank article on startup regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187879 (owner: 10Mhurd) [22:06:59] tfinc: i dont think my dentist appt will take more than an hour, but just in case i moved our meeting to 5 - hope that’s not too late - if i’m back by 4 we could still do 4 to 4:30... [22:07:14] mhurd: ok [22:14:52] bgerstle: hey quick question - when i’m trying to push to my phone i’m now getting an error: “CodeSign error: code signing is required for product type 'Unit Test Bundle' in SDK 'iOS 8.1'” - i see folks on stackoverflow have ran into this… is there some config bit we need to fiddle? [22:15:41] .... [22:15:46] that's interesting [22:16:01] i haven't run on my device yet, but that's really weird it's asking you about that [22:16:21] you're selecting the Wikipedia target and doing Cmd+R? [22:16:40] bgerstle: ya [22:16:53] oh interesting [22:17:02] it's coming from MediaWikiKitTests [22:17:47] btw, why do we use "-com.apple.CoreData.SQLDebug 0" as an argument when running the app? [22:17:50] can we remove that? [22:18:28] bgerstle: i think only the import from the old to new data store should be using any core data bits… brion? ^ [22:18:55] bgerstle: that can probably be killed yeah, i suspect it was an old default or test [22:19:13] right, i'm guessing someone was white-box testing accidentally committed it [22:19:39] bgerstle: if i recall “com.apple.CoreData.SQLDebug 0” was just for convenience… easy to flip it to “1” to see core data sqlite debug msgs [22:20:21] i see [22:20:27] that's neat, haven't done that before [22:21:13] mhurd fwiw i'm getting the error just building for device, not even running [22:21:16] lemme see... [22:22:52] kaldari: hello? [22:23:14] nuria: oops! sorry I forgot to get back to you. I’m free now. [22:24:23] kaldari: ok, you can talk to leila about issues with data but they come from two sides: 1) the method getrandomsessionid in mw js is not so random or unqiue as you might think, and that becomes apparent when you have high volumnes of data [22:24:58] kaldari: that is nox exactly "fixable" but i have submitted a patch that should mitigate the problem: https://gerrit.wikimedia.org/r/#/c/187876/ [22:25:03] weiiird. mhurd: now i'm getting a warning that "UIWebVIew+LoadAssetsHtml.h can't be found [22:25:09] restarting xcode.. [22:25:16] ? that is weird! [22:25:39] nuria: honestly, I don’t like using getrandomsession ID anyway since it’s hard to use for bucketing, i.e. it’s not a number. [22:25:49] i was switching branches a lot while xcode was running.. kind of a recipe for disaster [22:26:00] ok, now it's able to find that file [22:26:01] kaldari: issue 2) are client issues as data is incosistant in some aspects (too many users on step #2 that did not go through step #1 for example) [22:26:01] buuut [22:26:15] yeah, that error's weird. mhurd mind linking me to the SO article? [22:26:41] (03PS1) 10MaxSem: Fix redirect loop in difs on wikidata [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188215 (https://phabricator.wikimedia.org/T88029) [22:26:52] kaldari: for 1) i am not sure there is a better alternative unless you use the crypto api directly (which is what i have done) [22:26:57] bgerstle: http://stackoverflow.com/questions/26109851/code-signing-is-required-for-product-type-unit-test-bundle-in-sdk-ios-8-0 [22:27:22] nuria: I’ll investigate issue #2. I imagine it’s either some bug in the workflow code or data getting dropped from eventlogging for some reason. Hopefully the first. [22:27:29] kaldari: for 2) I would spent some time with leila as i think there are issues client wise at the time of reporting [22:27:45] kaldari: i did check data getting dropped/not validating [22:27:50] kaldari: and that is not the case [22:27:52] bgerstle: i played with a couple of the suggestions, but could only get this one to work: http://stackoverflow.com/a/26135634 [22:27:59] not ideal of course... [22:28:03] kaldari: so you do not have to check raw logs or anything [22:28:08] mhurd i think i know why.. [22:28:20] un-check the test bundles from analyze/run in the xcode scheme config [22:28:21] nuria: thanks [22:28:57] kaldari: you can concentrate on the client and -if you do not want to wait for my merge- use crypto api when available, that can give you a number [22:29:38] nuria: Yay, that will be a huge help [22:29:40] kaldari: browser support is higher than you might think but of course it's not everywhere [22:30:37] bgerstle: want to submit patch for that and the “SQLDebug 0” business? [22:30:47] kaldari:check it out, it's pretty good: http://caniuse.com/#search=getrandomvalues [22:31:02] nuria: Oh, that’s browser-dependant? That will be a problem. [22:31:03] sure [22:31:22] kaldari: yes, the code on my patch: https://gerrit.wikimedia.org/r/#/c/187876/ [22:31:28] bgerstle: oh i’ll be afk from 3 to 4 PST for dentist [22:31:43] dr0ptp4kt: coreyfloyd ^ [22:32:07] k [22:32:23] nuria: it would be really nice if we could apply math to the sessionID consistantly for bucketing purposes. Could we also change the non-crypto version to be interger-based? [22:34:32] kaldari: I think it will be even less random that was is currently coded right? [22:34:32] nuria: Then we could have nice clean bucketing code like: if ( sessionID > (maxInt / bucketFraction) ) { put in the test bucket; } [22:35:23] kaldari: to truly do that you need a cryto-safe identifier for your set which math.random cannot give you [22:35:36] nuria: If the sessionID can be either a string or a number, the bucketing code will be even more complicated and unweildy that it already is. [22:35:55] nuria: hmm [22:36:19] kaldari: will be back in 30 mins [22:36:27] kaldari: we can talk then [22:36:33] mhurd fix incoming [22:36:39] hehe cool [22:37:16] FYI i just un-checked the SQLite debug arg, so we can re-check if you want [22:37:41] sounds good [22:38:34] (03PS1) 10Bgerstle: fix xcode scheme so it doesn't build test targets all the time [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188218 [22:38:37] mhurd ^ [22:42:15] bgerstle: checking [22:45:57] bgerstle: hmm still getting the error... [22:46:27] gotta run to dentist - back around 4 [22:46:34] mhurd try restarting xcode? [22:47:30] k [22:48:04] 3MediaWiki-API, Wikipedia-App-General-or-Unknown: Tracking: API/backend issues blocking Wikipedia app development - https://phabricator.wikimedia.org/T75616#1009915 (10Eloquence) Can we prioritize these? What's blocking near term releases/features? [22:50:18] bgerstle: compiling… gah… taking so long… gotta run [22:50:23] back at 4 [22:51:43] k [22:51:47] coreyfloyd mind having a look? [22:52:01] mhurd i won't be around [22:52:07] FYI [22:53:08] (03CR) 10Kaldari: [C: 031] Clarify license [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/188086 (https://phabricator.wikimedia.org/T88251) (owner: 10MaxSem) [22:53:58] bgerstle: give a min, rebasing [22:56:33] k [23:04:04] (03PS1) 10Jdlrobson: POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 [23:07:31] (03CR) 10jenkins-bot: [V: 04-1] POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 (owner: 10Jdlrobson) [23:07:36] coreyfloyd dr0ptp4kt sorry i gotta run. leave comments if it doesn't work and i'll have it ready tomorrow morning at the latest [23:08:00] bgerstle no problem - sorry significant changes in my rebase [23:08:05] yeah [23:08:20] coreyfloyd unfortunately there's no `git rebase —pause` [23:08:31] 3MediaWiki-API, Wikipedia-App-General-or-Unknown: Tracking: API/backend issues blocking Wikipedia app development - https://phabricator.wikimedia.org/T75616#1009987 (10Deskana) @Eloquence Nothing in this list is blocking feature development right now. Mostly these are either causing performance issues or are are... [23:10:10] bgerstle: ttyl [23:11:52] l8r bgerstle [23:12:19] o/ [23:12:56] bgerstle: Ta ta! [23:18:00] tfinc: my dentist apt only took 10 minutes - they need a pre-auth from insurance for crown for cracked tooth. i can move our meeting back to 4 if that’s ok? [23:18:10] mhurd: up to you [23:18:28] tfinc: sure lets move it so you can finish up sooner [23:19:29] mhurd: owch [23:19:47] mhurd - I need the x circle glyph that was removed on your icon fix up [23:22:04] coreyfloyd: cool i’ll add it [23:23:25] (03CR) 10Fjalapeno: [C: 031] fix xcode scheme so it doesn't build test targets all the time [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188218 (owner: 10Bgerstle) [23:26:31] (03CR) 10Mhurd: [C: 031 V: 031] "So I had to clean out derived data and restart Xcode, but it worked :)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188218 (owner: 10Bgerstle) [23:26:41] dr0ptp4kt: ^ this one looks good. [23:26:45] coreyfloyd: adding glyph [23:27:24] mhurd - thanks! If you want I can add it as part of my patch if you want to send me the new file [23:27:56] coreyfloyd: there’ll be 2 files. i can send you both [23:28:03] coolio [23:28:09] coreyfloyd: 10 min [23:28:20] no rush [23:33:47] (03PS9) 10Robmoen: Introduce Special:Collections page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [23:34:03] (03PS2) 10Robmoen: POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 (owner: 10Jdlrobson) [23:37:26] (03CR) 10jenkins-bot: [V: 04-1] POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 (owner: 10Jdlrobson) [23:42:31] coreyfloyd: https://github.com/montehurd/apps-ios-wikipedia/commits/circleXGlyph [23:42:57] coreyfloyd: i can submit through gerrit and adam can prob review it quickly if that works for you [23:43:46] coreyfloyd: otherwise just grab the 2 files [23:45:43] coreyfloyd: since we have +2 on this ( https://gerrit.wikimedia.org/r/#/c/188218/ ) i’m gonna merge... [23:46:05] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188218 (owner: 10Bgerstle) [23:49:12] (03PS1) 10Mhurd: Added WIKIGLYPH_X_CIRCLE to glyph font. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188242 [23:49:21] (03PS2) 10Mhurd: Added WIKIGLYPH_X_CIRCLE to glyph font. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188242 [23:49:53] (03CR) 10Mhurd: "Corey feel free to -1 this if you want to pick these files and just include them in your forthcoming patch." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188242 (owner: 10Mhurd) [23:56:38] (03CR) 10Yurik: [C: 04-1] "see comment" (031 comment) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/188115 (https://phabricator.wikimedia.org/T88015) (owner: 10Hashar)