[00:08:18] mhurd: sorry wasnt looking… I'm grabbing them now [00:09:40] (03CR) 10Legoktm: Delay ZeroBanner die requirement after setup (031 comment) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/188115 (https://phabricator.wikimedia.org/T88015) (owner: 10Hashar) [00:11:20] Goodnight mobile channel! [00:12:51] 3Wikipedia-App-Android-App: Expose search through intent - https://phabricator.wikimedia.org/T88364#1010158 (10bearND) 3NEW [00:24:47] (03PS1) 10Robmoen: Collections live at Special:Collections/user/id [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188258 [00:26:01] (03CR) 10jenkins-bot: [V: 04-1] Collections live at Special:Collections/user/id [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188258 (owner: 10Robmoen) [00:26:22] mhurd - hit me up after your meeting if you have a chance [00:28:26] coreyfloyd: will do! [00:28:32] (03PS1) 10Robmoen: Link to page in title of collection item [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188260 [00:30:45] bearND: would you mind looking/commenting on these: https://gerrit.wikimedia.org/r/187843 https://gerrit.wikimedia.org/r/187839 [00:38:29] dbrant|brb: i'm on it [00:42:13] mhurd nm - im good [00:45:19] (03CR) 10Legoktm: "And by separate extension you mean the Collection extension right? ;)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [00:46:03] legoktm[NE]: haha [00:46:25] :) [00:54:15] tfinc: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Onboarding#Apps_Software_Developer_Onboarding_.28Tech.29 [00:59:32] (03CR) 10BearND: [C: 032] Styling tweaks: toolbar/drawer shadows. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187839 (owner: 10Dbrant) [01:02:17] (03Merged) 10jenkins-bot: Styling tweaks: toolbar/drawer shadows. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187839 (owner: 10Dbrant) [01:18:15] (03CR) 10Kaldari: [C: 04-1] "This causes a wikigrok_question entry to be generated for every slow campaign, regardless of whether it should actually apply to the artic" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [01:20:27] MaxSem: looks like there’s a bug in the new WikiGrok code. It’s kind of complicated to explain in gerrit though. Let me know if you want to see it on my local machine. [01:22:41] (03PS2) 10Fjalapeno: Create a saved articles fetcher - internally using the articles fetcher to fetch each page. Use saved pages fetcher in the saved pages controller Add pods for autolayout and pull to refresh Add basic pull to refresh view with indeterminate animation progr [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 [01:22:51] (03CR) 10BearND: [C: 04-1] "See comment for PS1 in https://gerrit.wikimedia.org/r/#/c/187842/" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187843 (owner: 10Dbrant) [01:28:39] (03PS1) 10Bmansurov: Add WikiGrok Roulette tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 [01:29:38] (03CR) 10jenkins-bot: [V: 04-1] Add WikiGrok Roulette tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 (owner: 10Bmansurov) [01:30:18] (03PS2) 10Bmansurov: Add WikiGrok Roulette tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 [01:31:18] (03CR) 10jenkins-bot: [V: 04-1] Add WikiGrok Roulette tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 (owner: 10Bmansurov) [01:34:28] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 (owner: 10Bmansurov) [01:34:39] (03PS1) 10MaxSem: Add new thumbnailing parameters to mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 [01:35:25] (03CR) 10jenkins-bot: [V: 04-1] Add new thumbnailing parameters to mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 (owner: 10MaxSem) [01:40:54] (03PS3) 10Bmansurov: Add WikiGrok Roulette tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 [03:25:39] (03CR) 10Jdlrobson: "Shouldn't this be part of PageImages extension...?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 (owner: 10MaxSem) [03:44:14] (03Abandoned) 10Dr0ptp4kt: WIP: Enhanced sharing with cards [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/186168 (owner: 10Dr0ptp4kt) [03:57:34] (03PS1) 10Dr0ptp4kt: WIP: Enhanced sharing with cards [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293 [04:11:39] (03PS2) 10Dr0ptp4kt: WIP: Enhanced sharing with cards [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293 [04:17:58] (03CR) 10Bgerstle: ""+1379, -83" that's-a big diff, mario! i'll have a look tomorrow" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [04:53:55] (03CR) 10BearND: [C: 04-1] "I think the 2ndry action could use bigger touch targets." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188110 (owner: 10Dbrant) [05:17:05] (03PS3) 10Dr0ptp4kt: Enhanced sharing with cards [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293 [09:56:28] morning [10:47:32] just brewing coffee [10:52:47] hey joakino [10:52:48] hi phuedx [11:32:49] phuedx: sent email to mobile-l about the dev session we had [11:33:45] when you have 10 minutes, it would be great if you could have a look at it and proof read it [11:34:38] on my todo list [11:35:18] thx! 😁 [11:49:30] joakino: nice work :) [11:50:00] phuedx: thx! so much awesome in there [11:53:25] joakino: yeah! [12:12:37] (03PS1) 10Jhernandez: Improve lists styles for nested lists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188351 [12:24:04] (03CR) 10Jhernandez: [C: 04-1] "Some minor comments" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188258 (owner: 10Robmoen) [12:29:38] (03PS3) 10Jhernandez: POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 (owner: 10Jdlrobson) [12:30:34] (03CR) 10jenkins-bot: [V: 04-1] POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 (owner: 10Jdlrobson) [12:48:03] (03PS4) 10Jhernandez: POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 (owner: 10Jdlrobson) [12:48:28] bleh [12:48:36] gonna drop lisa and george of at the doctors for a check up [12:48:47] phuedx: 👍 [12:48:53] (03CR) 10jenkins-bot: [V: 04-1] POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 (owner: 10Jdlrobson) [13:05:49] (03PS5) 10Jhernandez: POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 (owner: 10Jdlrobson) [13:11:22] (03CR) 10Jhernandez: "Fixed linting errors and tests" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 (owner: 10Jdlrobson) [13:23:52] (03CR) 10Jhernandez: [C: 04-1] "Besides documentation, it looks good to me, but I don't have experience with hooks." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 (owner: 10Jdlrobson) [13:25:11] (03CR) 10Jhernandez: Collections live at Special:Collections/user/id (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188258 (owner: 10Robmoen) [13:25:20] (03PS2) 10Jhernandez: Collections live at Special:Collections/user/id [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188258 (owner: 10Robmoen) [13:26:54] (03CR) 10Nemo bis: [C: 04-1] "It's impossible to make sense out of such a commit message, please make it readable. https://www.mediawiki.org/wiki/Gerrit/Commit_message_" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [13:28:39] (03PS2) 10Jhernandez: Link to page in title of collection item [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188260 (owner: 10Robmoen) [13:40:19] (03PS3) 10Jhernandez: Link to page in title of collection item [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188260 (owner: 10Robmoen) [13:41:42] (03CR) 10Jhernandez: [C: 031] "Rob I've made it so that the link is inside the h2, seems more "semantic" to me, and I've added css so that the title still looks like a t" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188260 (owner: 10Robmoen) [13:53:08] i've been back for a while [13:53:13] silly irc client [14:05:58] hey joakino [14:12:24] hi jdlrobson phuedx [14:12:43] joakino: i'm just about to send that email want to give it a test run? [14:12:51] sure [14:13:01] sent over [14:13:14] jdlrobson: phuedx: what do you do when an svg icon that moiz sent is too big? :S [14:13:31] yo [14:13:43] i wait until rmoen resizes the art board ;) [14:13:45] (really) [14:13:52] there are tools [14:13:55] that's about all i know [14:14:19] grr [14:14:27] shouldn't svg be auto scaled? [14:14:39] (03PS1) 10Jhernandez: Add arrow icon to read more in the collections view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188368 [14:14:57] phuedx: jdlrobson: ^ icon too big, don't know what to do [14:15:09] * jdlrobson looks [14:15:32] might be because of use of :after [14:15:38] that's not been done anywhere [14:15:41] (03CR) 10jenkins-bot: [V: 04-1] Add arrow icon to read more in the collections view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188368 (owner: 10Jhernandez) [14:15:50] also hey jdlrobson [14:15:58] hey :) [14:21:08] jdlrobson: s/3 person team/3 developers team/ [14:30:28] (03CR) 10Jhernandez: "jdlrobson the missing AC criteria is fixed on followup patches." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [14:30:41] (03CR) 10Jhernandez: [C: 031] Introduce Special:Collections page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [14:31:00] (03CR) 10Jdlrobson: [C: 031] Introduce Special:Collections page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [14:31:23] phuedx: just sent a mail to the team. Bit blocked on collections work so keen to get your opinion. [14:33:09] (03PS6) 10Jdlrobson: POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 [14:34:33] jdlrobson: about this ^ [14:34:37] (03CR) 10jenkins-bot: [V: 04-1] POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 (owner: 10Jdlrobson) [14:34:40] i submitted patches there [14:35:20] i'm confused [14:36:08] jdlrobson: look at PS5 https://gerrit.wikimedia.org/r/188225 , i fixed linting and tests there [14:37:16] joakino: mmm? [14:37:25] joakino: i was rewriting it yesterday [14:37:52] mm i think i forgot to submit some additional minor changes [14:38:09] and maybe rebased it. [14:38:18] i'm still fiddling with it [14:38:23] jdlrobson: from what i can see it is just a rebase [14:38:43] but it brings back the linting errors, a "False" that should be false, and the broken test [14:39:20] i'm not expecting to get this patch merged this iteration [14:39:37] it's a card in next sprint but i wanted to work out all the moving parts [14:39:54] you guys may want to completely rewrite it. Passing the id when saving seems weird [14:39:57] haven't quite worked out how to do that [14:41:32] ^ joakino [14:42:01] jdlrobson: oki [14:43:13] (03CR) 10Jdlrobson: [C: 04-1] Add arrow icon to read more in the collections view (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188368 (owner: 10Jhernandez) [14:43:17] jdlrobson: before you go on vacation, write down on the comment or the trello card concerns or missing pieces we should fix, it kinda looks good for now to me [14:47:07] (03CR) 10Jdlrobson: [C: 04-1] "minor tweak suggested" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188260 (owner: 10Robmoen) [14:47:46] joakino: sure thing [14:48:32] (03CR) 10Jdlrobson: [C: 032] Improve lists styles for nested lists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188351 (owner: 10Jhernandez) [14:49:05] (03CR) 10Jdlrobson: [C: 031] "Untested but looks fine. Waiting for feedback from Wikidata folks." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188215 (https://phabricator.wikimedia.org/T88029) (owner: 10MaxSem) [14:49:33] (03Merged) 10jenkins-bot: Improve lists styles for nested lists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188351 (owner: 10Jhernandez) [14:53:58] (03PS3) 10Fjalapeno: Implement Pull to Refresh for saved pages. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 [14:55:36] (03CR) 10Jdlrobson: [C: 04-1] "Purely because the name is confusing. We already have a tutorials folder and ContentOverlay PageActionOverlay and uploads/UploadTutorial. " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 (owner: 10Bmansurov) [14:58:06] (03PS2) 10Jdlrobson: WIP [DO NOT MERGE] Introduce Collections item on menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187717 (owner: 10Jhernandez) [14:58:35] (03Abandoned) 10Jdlrobson: WIP [DONOTMERGE]: Add Special:MobileCollections to alpha left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson) [14:59:33] (03CR) 10Jdlrobson: [C: 04-1] "Please don't base off of the POC - that's throwaway." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188258 (owner: 10Robmoen) [14:59:41] (03PS7) 10Jdlrobson: POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 [15:00:25] (03CR) 10jenkins-bot: [V: 04-1] POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 (owner: 10Jdlrobson) [15:03:01] 3Mobile-Web: Nearby should be JS only - https://phabricator.wikimedia.org/T88432#1011511 (10Jdlrobson) 3NEW [15:03:34] (03Abandoned) 10Jdlrobson: Refactor Nearby feature as overlay in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 (owner: 10Jdlrobson) [15:04:13] (03PS7) 10Jdlrobson: Fix UploadTutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185850 [15:04:28] (03CR) 10Jdlrobson: "Anyone? 14 days old now!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185850 (owner: 10Jdlrobson) [15:06:30] (03CR) 10Jdlrobson: "Hey Florian, I think it's best to have conversation in bugs. Lack of activity on this patchset and bug reports suggests the team isn't int" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166089 (https://phabricator.wikimedia.org/T85587) (owner: 10Florianschmidtwelzow) [15:08:38] (03PS5) 10Jdlrobson: Hygiene: Move wgResourceLoaderLESSVars out of extension function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187947 (owner: 10Florianschmidtwelzow) [15:09:02] (03PS2) 10Jhernandez: Add arrow icon to read more in the collections view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188368 [15:10:01] 3Mobile-Web: Scrolling issues in beta with new ReferencesDrawer - https://phabricator.wikimedia.org/T87050#1011534 (10Jdlrobson) Ping @rmoen let's either get this bug fix wrapped up today or abandon the patch and free it for a volunteer. [15:10:07] out for lunch [15:10:15] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move wgResourceLoaderLESSVars out of extension function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187947 (owner: 10Florianschmidtwelzow) [15:13:06] (03CR) 10jenkins-bot: [V: 04-1] Add arrow icon to read more in the collections view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188368 (owner: 10Jhernandez) [15:28:26] jdlrobson: how about this weather today? [15:32:26] (03CR) 10Fjalapeno: "Cleaned up commit message and renamed classes/protocols using new WMF prefix convention" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [15:37:00] bgerstle: it seems to be brightening up :) [15:40:27] nice and cool too :-) [15:40:37] should be less mosquitoes [15:40:42] (03CR) 10Phuedx: [C: 04-1] "See inline for preliminary feedback." (0313 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [15:41:27] jdlrobson: phuedx joakino do you guys have any test rigs for running tests against an arbitrary number of articles? [15:41:32] JS tests, even [15:43:10] say "forAll articles suchThat $(".image") …" [15:43:56] (03CR) 10JanZerebecki: [C: 04-1] "Looks good for wikidata, no further review needed for that." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188215 (https://phabricator.wikimedia.org/T88029) (owner: 10MaxSem) [15:44:11] or at the very least, can you point me to the browser tests so i can take a look at how you're loading articles? [15:47:54] coreyfloyd: would now be a good time to look at your pull-to-refresh change? [15:48:59] bgerstle: i don't know of any such tool [15:49:30] bgerstle: and our browser tests are here: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/tree/master/tests/browser/features [15:49:39] jdlrobson: readin' yer email now [15:49:45] so many cukes [15:54:55] so uh… there's apparently no gemfile in that repo? :-/ [15:55:13] chrismcmahon: is that a mistake? (no GemFile in tests/browser) [15:55:16] Gemfile* [15:55:57] bgerstle: it's in the root directory [15:56:31] i just searched the whole repo for "Gemfile" and didn't find one [15:56:44] oh what [15:56:45] hrm [15:56:49] i guess GH search doesn't do filenames [15:56:51] * bgerstle shrug [15:56:54] sorry for the false alarm [15:57:11] we're using our own selenium..? [15:58:16] huh [15:59:26] oh, it's just the QA Framework [16:00:09] bgerstle - yeah you can take a look at the patch [16:01:51] ok [16:06:46] * jdlrobson grabbing lunch/brunch [16:15:55] we don't by any chance have a media wiki JS client npm package, do we? [16:21:48] bgerstle: we're using selenium-webdriver and watir-webdriver in Ruby (and some other stuff). Let me know if you have questions... [16:21:58] k, thanks! [16:24:04] bgerstle: basically my goal was to have the browser test framework support the most powerful Selenium API I could find while also being as standard and NIH as possible. All the components we're using are well-known and well-documented. [16:26:41] yeah, i see that now [16:27:06] was misled by "mediawiki_selenium" which at cursory glance seems like a MW abstraction/convenience on top of the libs you mentioned [16:27:08] which is nice [16:27:50] bgerstle: yes, mediawiki-selenium holds all the mw-specific stuff and know about e.g. the API, and users, and random pages, etc. [16:27:55] knows [16:29:21] bgerstle: in practice we find that (used well) the framework is such a high level of abstraction that it barely even looks like Ruby. and if you *do* find yourself doing, y'know, programming, you're probably misusing the framework. [16:29:23] chrismcmahon: i'd like eventually work on these kinds of tests for mobile features, but it's a ways off yet [16:30:34] bgerstle: great! Jon Robson knows the MobileFrontend tests really well, me and Dan Duvall and Zeljko Filipin are also always available for support. [16:30:38] not sure how many (if any) steps would translate over. certainly a fair amount of the steps would need to be rewritten and/or heavily refactored. i don't quite understand how and if page objects are being used here (i saw some gem by that name, but am not familiar with it) [16:30:46] cool [16:31:00] bgerstle: are you in SF? [16:31:17] i was for the past two weeks, but am back home in Miami now [16:31:35] i meant to snag you during the dev summit to chat about this stuff and my experience at Spotify (was a quality engineer there for a bit) [16:31:36] oh right, Miami, I remember from yesterday :-) [16:32:03] oh nice, I've read about Spotify's dev process, very neat [16:32:04] but maybe we can talk more when my team decides to look at these things in earnest [16:32:33] bgerstle: definitely. also, your time zone is convenient for pairing with Zeljko in Croatia [16:32:41] ok [16:36:48] chrismcmahon: in particular, i wanted to chat w/ you about my experience w/ model-based testing, which seemed really relevant to your dev summit talk [16:36:56] how you spoke of entry points and such [16:39:15] bgerstle: I know a bit about MBT. state machines and such [16:39:27] yep [16:39:36] "extended finite state machines" [16:40:09] IOW: ability to add edge guards and state to the graph [16:40:11] bgerstle: ever heard of someone named Harry Robinson? he's been quiet the last few years but was a pioneer of MBT [16:40:31] no, but i'm sure my colleague who introduced me to MBT has [16:40:44] you know or heard of Kristian Karl? [16:41:02] i'll look up robinson [16:43:00] bgerstle: my biggest issue with MBT is that most state transitions are just not very interesting :-) [16:44:42] i suppose, but it's a great way to test things more comprehensively, since it will often try things you didn't think of writing a scenario for [16:45:10] bgerstle: I glanced through http://www.slideshare.net/SmartBear_Software/how-spotify-does-test-management-kristian-karl, very neat [16:45:22] that's the guy [16:46:10] unfortunately spotify is often guilty of "NIH" syndrome [16:46:24] but, in this case at least, the MBT framework they use is developed by him and open soure [16:46:26] source* [16:46:33] bgerstle: It would be great to see some tests like that especially at an integration level. as UI tests that kind of coverage might be too expensive. [16:46:34] AFAIK there aren't any ruby bindings though :-P [16:47:20] chrismcmahon agreed, it can be expensive and also yield diminishing returns because it doesn't shrink test failures for you [16:47:33] unlike other testing approaches [16:47:56] anyway, gotta get back to working on other stuff. hope to chat more soon :-) [16:48:04] bgerstle: I know someone who created a simple MBT framework using Selenium in about an hour, but quickly realized that covering all possible states for even a simple web page would take hours and hours and hours. [16:48:44] right, that's what's nice about his framework: you can define stop conditions in terms of coverage, visited edges/nodes, and/or time [16:48:54] bgerstle: me too, but let's keep talking about this stuff, it's nice to know someone at WMF is thinking along these lines [16:49:35] last thing: you can also specify traversal algos like "shortest path," "purely random", etc [16:49:49] neato :-) [16:49:55] so yeah, lots of stuff to think/talk about :-) [17:10:47] jdlrobson: responded, took me a while to get my thoughts down [17:10:57] also, harry had a Bad Time at the doctors [17:13:35] phuedx: :-( [17:16:10] phuedx: "Code should be moving towards core not backwards into other extensions that depend on MobileFrontend." what i meant by this is we shouldn't have extensions that depend on MobileFrontend [17:16:30] Core should provide all the things needed for an extension imo [17:16:46] ah [17:16:52] phuedx poor harry :-( [17:17:00] shots? [17:17:05] yeah [17:17:11] he had a bad reaction to something [17:17:17] eek [17:17:28] so he had to stay at the doctors for another hour while they confirmed what was going on [17:17:50] he might be allergic to egg [17:17:53] (george is) [17:17:58] :-S [17:18:12] although, george isn't so allergic any more [17:18:12] of all the things to be allergic to :-(! [17:18:21] he can eat cake etc. [17:18:30] but we haven't tried him on, say, scrambled egg [17:18:53] that's a put-it-in-his-mouth-but-have-the-phone-in-yer-hand-to-call-the-ambulance kinda thing [17:19:08] there's lots of vomiting [17:19:10] lots [17:19:16] well, there was last time [17:19:33] tldr: you can train your body not to be allergic to egg by eating lots of cake [17:19:34] wow [17:20:01] phuedx the body is an amazing thing. but also, kind of evil [17:20:06] ^ that [17:24:53] jdlrobson: i reckon we both agree on the whole collectionsmabob [17:25:00] thing [17:25:11] but kaldari raises a good point about deployments [17:25:17] on the other hand, feature flags [17:28:35] back [17:29:25] (03CR) 10Phuedx: WIP: recording and applying user responses (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [17:29:47] responded to kaldari's comments about deployment. I think this is a fallacy phuedx [17:30:11] how was lunch joakino [17:30:20] i'm hitting the salad hard atm [17:30:31] soup and burguer [17:30:34] sf was /a lot/ of awesome food [17:30:40] yep [17:30:52] had the best dinner ever with bgerstle yesterday [17:30:54] even had salad! [17:31:24] and meatballs that were closer to mini burgers [17:31:53] jdlrobson: glad you enjoyed it :-) [17:32:21] phuedx "hitting the salad hard" lol [17:32:47] you'll find that i mix all of the expressions [17:33:06] i'm constantly a/b testing colloquialisms [17:33:35] lol [17:33:46] a voracious vernaculator [17:42:58] coreyfloyd sorry, got sidetracked. promise i'll look at your changes and provide some preliminary feedback soon [17:45:26] bgerstle np [17:46:03] joakino: standup [17:46:10] oops [17:46:12] jdlrobson: going [17:47:29] (03CR) 10Aude: [C: 031] "manually tested, works for me." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188215 (https://phabricator.wikimedia.org/T88029) (owner: 10MaxSem) [17:51:17] (03CR) 10Aude: Fix redirect loop in difs on wikidata (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188215 (https://phabricator.wikimedia.org/T88029) (owner: 10MaxSem) [17:53:04] i'm glad Gatherllections stuck [17:53:09] let's make it a thing [18:01:04] bath time! [18:01:08] i'll be back in 40 [18:01:19] phuedx glhf! o/ [18:04:56] (03PS4) 10Bmansurov: Add WikiGrok Roulette tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 [18:07:09] (03CR) 10Bmansurov: "There is a separate card for i18n. Although we can make this patch translatable, WikiGrok as a whole is not ready yet. I think it's best t" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 (owner: 10Bmansurov) [18:07:14] phuedx: a more natural but unfortunate word is gatherections [18:07:55] lol [18:09:00] hahaha [18:09:36] joakino: I have already typed that once and deleted it out of shame. [18:11:25] friendly spaces [18:12:18] ^ :) [18:15:48] Deskana: same [18:16:06] VERY friendly spaces [18:17:31] Deskana: Over-friendly? [18:17:39] James_F: ;-) [18:21:12] i'm really starting to dislike our image URLs [18:23:41] (03PS5) 10Bmansurov: Add WikiGrok Roulette tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 [18:24:31] (03CR) 10Jdlrobson: "I'm arguing the architecture is ready for this right now. There is nothing in this patch that screams difficult to translate." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 (owner: 10Bmansurov) [18:25:59] (03CR) 10Bmansurov: "Good points. What I meant was that the wikigrok campaigns are not translatable yet. Why translate this now if campaigns are in English now" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 (owner: 10Bmansurov) [18:27:50] is there a place where one could learn about the rhyme & reason behind image URLs? [18:28:09] e.g. what do the different components of: //upload.wikimedia.org/wikipedia/commons/thumb/4/4c/Fairport%2C_New_York_village_hall.jpg [18:28:10] mean [18:28:45] or what are all the components i might see? this one i already popped off the last "440px-….jpg" component [18:29:00] or 220px, whatever [18:29:04] this is the actual image http://upload.wikimedia.org/wikipedia/commons/thumb/4/4c/Fairport%2C_New_York_village_hall.jpg/220px-Fairport%2C_New_York_village_hall.jpg [18:34:32] 3Wikipedia-App-Android-App, MediaWiki-extensions-PageImages, Wikipedia-App-iOS-App: PageImages shouldn't return images that are way below the fold - https://phabricator.wikimedia.org/T87336#1012082 (10bd808) "Below the fold" is something that can really only be determined at page render time as it is based on th... [18:38:18] Maryana: Hey, this card: https://trello.com/c/7eClxCsB/14-2-tell-people-about-the-wikigrok-sidebar-game-after-finishing-one-grok requires that WikiGrok in Sidebar is always enabled. How should I handle the case where it's not enabled? [18:39:11] hm, so i suppose this card depends on wikigrok in sidebar graduating to beta [18:39:16] so that it can always be enabled there [18:39:26] (03PS3) 10Jhernandez: Add arrow icon to read more in the collections view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188368 [18:39:27] bmansurov: ^ [18:39:45] Maryana: ok, should I fall back to the previous about dialog if it's not enabled? [18:40:01] yes, sounds sensible [18:40:05] k [18:40:09] thanks :) [18:40:26] (03CR) 10jenkins-bot: [V: 04-1] Add arrow icon to read more in the collections view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188368 (owner: 10Jhernandez) [18:40:43] hallo bmansurov Maryana jdlrobson [18:40:56] hi aharoni [18:42:01] (03CR) 10Jhernandez: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [18:47:03] (03PS4) 10Jhernandez: Link to page in title of collection item [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188260 (owner: 10Robmoen) [18:47:47] dbrant|brb, bearND: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8107386 https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8111900 [18:48:32] hey aharoni / bmansurov i just worry we are becoming lazy about translation with wikigrok. I'd hate us to get to a point where we want to deploy in 2 weeks and are blocked on i18n. i18n is really not that hard. The infobox experiment I built for instance wasn't any trickier to do with i18n and it actually flagged some issues with wikidata. [18:48:47] Hear hear! \o/ [18:48:53] jdlrobson: so how can I help? [18:48:55] i think we gain more by building new stuff with i18n unless there is a good reason not to (for example wikigrok a was a tricky beast and an exception) [18:49:26] (03CR) 10Jhernandez: Link to page in title of collection item (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188260 (owner: 10Robmoen) [18:50:06] * jdlrobson shrugs. As i understand it there are plans to translate wikigrok b in the near future, i'm just a bit puzzled why we are continuing to ignore i18n for new things. [18:50:38] it just seems like a development anti-pattern [18:51:26] Krenair: ...chalk those up to more obscure WebView-related bugs and/or support library bugs :( [18:51:44] :( [18:51:45] (03PS4) 10Jhernandez: Add arrow icon to read more in the collections view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188368 [18:53:35] bgerstle: dbrant: would you guys have time for hangout together to talk about image urls? [18:54:13] yeah, was just about to grab some lunch and then review corey's change [18:54:18] what time are you free? [18:54:38] mhurd: I'll be free after 1:00 (pst) [18:55:44] i'm good then [18:56:16] bgerstle: dbrant cool i’ll leave you two to chat whenever works for you - i think dmitry can demystify / clarify what you’ll need to use to get the higher res image urls [18:56:35] *you three* [18:56:46] oh wait - i thought i was in there [18:57:11] i saw my name and was confused - I'm better now [18:59:00] mhurd i'm not even at getting higher res URLs [18:59:11] the whole MWKImagesList was throwing me for a loop [18:59:37] now that i've just about got the web hook functional, i might take a closer lookat it [19:00:03] (03CR) 10JanZerebecki: [C: 04-1] "You should never throw a plain Exception in your PHP code, only a class that extends it. Otherwise you will not be able to distinguish it " [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/184062 (owner: 10Ori.livneh) [19:01:40] 3Wikipedia-App-Android-App, RESTBase, Wikipedia-App-iOS-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1012236 (10mobrovac) Notes from today's meeting are available [here](https://www.mediawiki.org/wiki/Services/Meetings/2015-02-03-MA) [19:03:03] bearND: what times are ou available on thursday? [19:03:15] bearND: i'm gonna set another meeting with moiz, you, and me [19:04:05] dr0ptp4kt: Thursday morning would be great [19:04:40] dr0ptp4kt: before 11:00 PST [19:04:48] (03PS2) 10Dbrant: Styling tweaks: infobox color/shadow, disambig link padding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187843 [19:05:25] dr0ptp4kt: or between 1-2 PST. We have a meeting at 2 [19:07:44] (03CR) 10Mhurd: [C: 04-1 V: 04-1] "I'm seeing crashes on iOS 6 when loading "saved pages"." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [19:08:30] (03PS1) 10Bmansurov: Fix mainMenu selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188407 [19:09:39] (03PS4) 10Dr0ptp4kt: Enhanced sharing with cards [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293 [19:14:52] well [19:14:54] that was… [19:14:56] tough [19:17:18] mhurd - how are you testing iOS 6 - directly on a device or in the simulator? [19:17:34] device [19:17:36] (03CR) 10Aaron Schulz: "Using raw Exceptions seems fine for "unchecked" errors that just want to stop the program (e.g. "this should NEVER happen"). MWException i" [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/184062 (owner: 10Ori.livneh) [19:22:38] mhurd ar eyou building with Xcode 6 or 5? [19:23:22] i'm heading out [19:23:25] have a nice day guys [19:23:29] and girls [19:23:47] o/ [19:23:51] (03CR) 10Deskana: [C: 04-1] "This patch introduces jitter in pull to refresh in articles and makes pull to refresh in Nearby behave very strangely with it starting the" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [19:25:05] 3Wikipedia-App-Android-App: UnsupportedOperationException in MenuWrapperFactory.wrapSupportMenu - https://phabricator.wikimedia.org/T78738#1012310 (10bearND) Newer OTRS reports with version 2.0-r-2015-01-15: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8107386 3.2.1 acer A500 http... [19:26:56] (03CR) 10Krinkle: [C: 031] "Indeed. MWException being more specific than Exception is an illusion. MediaWiki core has various Exception subclasses for User, Title and" [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/184062 (owner: 10Ori.livneh) [19:33:51] Deskana: mobile product/analytics sync up - coming? [19:34:00] we need to talk about high priority data asks for the q :) [19:34:07] grab jon katz if you see him [19:36:58] kaldari: let's talk about the crypto stuff when you can later on today [19:37:49] (03CR) 10Fjalapeno: "The throw distance is configurable - I used the distance from the old code, but it looks like the old code is adjusting it by the scaling " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [19:38:42] (03PS3) 10Robmoen: Watchlist lives at Special:Collections/user/0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188258 [19:38:43] (03PS10) 10Robmoen: Introduce Special:Collections page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [19:40:27] nuria: On the Wikigrok items that are missing page-impression, are they also missing widget-impression, or only page-impression? [19:41:12] k, seriously lunch time, bbiab [19:43:03] kaldari: there are several flavours but several have "widget-impression" (step #2 right?) w/o "page-impression" [19:43:23] (03CR) 10JanZerebecki: Fix redirect loop in difs on wikidata (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188215 (https://phabricator.wikimedia.org/T88029) (owner: 10MaxSem) [19:43:35] kaldari: or wait, was it the reverse? need to look again but leila has the data too [19:43:42] (03PS2) 10JanZerebecki: Fix redirect loop in diffs on wikidata [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188215 (https://phabricator.wikimedia.org/T88029) (owner: 10MaxSem) [19:43:54] (03CR) 10JanZerebecki: [C: 031] Fix redirect loop in diffs on wikidata [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188215 (https://phabricator.wikimedia.org/T88029) (owner: 10MaxSem) [19:43:57] kaldari: bottom line: we show users on step#2 that had not gone through step#1 [19:44:36] (03CR) 10jenkins-bot: [V: 04-1] Fix redirect loop in diffs on wikidata [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188215 (https://phabricator.wikimedia.org/T88029) (owner: 10MaxSem) [19:45:56] nuria: so generally, the funnels that are missing page-impression do have widget-impression? Try to figure out if the problem is related to the show event (which would affect both) or just specific to the logPageImpression() function. [19:46:08] Try=I’m trying... [19:46:18] Maryana: Lila grabbed me. [19:46:30] nuria: I can ask leila if you’re busy too [19:46:35] (03PS3) 10Dbrant: Styling tweaks: infobox color/shadow, disambig link padding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187843 [19:46:42] Deskana: ok, np :) [19:46:45] Maryana: I'll come once she's stopped talking to me. [19:47:40] kaldari: if you can ask leila it will be best as she has looked at several problems [19:47:48] kaldari: not just this one [19:47:54] nuria: will do [19:48:37] kaldari: ok, let me know if you guys need more help [19:48:55] leila: You around? [19:50:35] kaldari: let's talk later also about the crypto patch, cause i do not understand your last comment super well [19:55:41] (03CR) 10MaxSem: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188215 (https://phabricator.wikimedia.org/T88029) (owner: 10MaxSem) [19:56:04] gonna head off for the night folks [19:56:37] sweet dreams phuedx [19:56:53] i will be dreaming of EntityStore [19:56:57] MaxSem ^ [19:57:01] kekeke [20:02:33] coreyfloyd: sorry was afk - using xcode 6 [20:04:29] lunch!!! [20:08:59] (03PS5) 10Dr0ptp4kt: Enhanced sharing with cards [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293 [20:10:01] (03PS5) 10Robmoen: Link to page in title of collection item [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188260 [20:18:31] 3Mobile-Web: Page with collapsible sections contains divs with non-unique id values - https://phabricator.wikimedia.org/T88473#1012553 (10Cmcmahon) 3NEW [20:18:50] 3Mobile-Web: Page with collapsible sections contains divs with non-unique id values - https://phabricator.wikimedia.org/T88473#1012560 (10Cmcmahon) [20:19:21] (03PS1) 10Jhobs: [WIP] Create browser tests [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/188418 [20:19:30] ^ marxarelli [20:20:57] nuria: Just talked to leila and she is going to investigate the data regarding page-impressions further. Sorry I was confusing about the crypto patch. Let me see if I can explain better. Right now the random session ID is essentially a random base 62 number (there are 62 possible values in each place [0-z]) and it can be converted into a base 10 integer for applying regular math functions against it. The problem is, Javascript (which is what [20:20:57] all my bucketing code is written in), can only handle bases up to base 36. It can’t easily convert a base 62 number into a base 10 number (although you can write functions to do this). From my point of view, then, it’s almost just as easy for me to work with a base 36 number (i.e. a series of random chars [0-Z]) as it is for me to work with a base 10 integer (i.e. a series of random chars [0-9]), but it’s a lot more hassle for me to [20:20:58] work with a base 62 number (what we currently have, [0-z]). The only advantage to working in higher bases is that the values are more space efficient, i.e. more variations in the same number of characters, but I’m not really sure anyone cares about that. Just to keep things simple, my top preference is still just a regular base 10 integer, like you are proposing. [20:27:15] kaldari: then let's go for base 10 identifiers then [20:27:26] :) [20:27:33] kaldari: i think it makes for easier to "grasp" code [20:27:59] kaldari: thus, easier to mainatain [20:28:02] (03CR) 10Kaldari: [C: 032] Fix redirect loop in diffs on wikidata [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188215 (https://phabricator.wikimedia.org/T88029) (owner: 10MaxSem) [20:28:16] nuria: very true [20:29:15] (03Merged) 10jenkins-bot: Fix redirect loop in diffs on wikidata [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188215 (https://phabricator.wikimedia.org/T88029) (owner: 10MaxSem) [20:33:29] kaldari: ok then 64 bits (in size) integers that can be truncated, represented in decimal form, ok [20:33:38] kaldari: did you talked to leila? [20:35:13] 3Mobile-Web: Overlay, Panel and Drawer should use events property for its event bindings - https://phabricator.wikimedia.org/T87192#1012582 (10Sumit) @Jdlrobson, if I get this right, we have to change the jquery event handlers to handlers defined by the native MobileFrontend OO library? [20:43:23] 3Mobile-Web: Overlay, Panel and Drawer should use events property for its event bindings - https://phabricator.wikimedia.org/T87192#1012611 (10Jdlrobson) @Sumit EditorOverlayBase is a good example. Take a look at events and onClickSubmit function. Basically we don't want to bind events in the postRender function... [20:48:57] (03PS8) 10Jdlrobson: POC: Collections API/storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 [20:49:16] (03PS2) 10Dduvall: [WIP] Create browser tests [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/188418 (owner: 10Jhobs) [20:50:32] (03CR) 10jenkins-bot: [V: 04-1] POC: Collections API/storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 (owner: 10Jdlrobson) [20:51:00] (03PS1) 10Bmansurov: WIP: Show the user how Contribute menu item [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188424 [20:51:19] (03PS2) 10Bmansurov: WIP: Show the user the Contribute menu item [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188424 [20:54:30] (03CR) 10jenkins-bot: [V: 04-1] WIP: Show the user the Contribute menu item [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188424 (owner: 10Bmansurov) [20:57:37] (03CR) 10Jdlrobson: [C: 04-1] WIP: Show the user the Contribute menu item (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188424 (owner: 10Bmansurov) [21:01:08] (03CR) 10Bmansurov: WIP: Show the user the Contribute menu item (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188424 (owner: 10Bmansurov) [21:16:20] (03CR) 10Jdlrobson: [C: 04-1] Add arrow icon to read more in the collections view (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188368 (owner: 10Jhernandez) [21:19:12] (03CR) 10Jdlrobson: [C: 031] Watchlist lives at Special:Collections/user/0 (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188258 (owner: 10Robmoen) [21:19:36] (03CR) 10Jdlrobson: [C: 032] Link to page in title of collection item [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188260 (owner: 10Robmoen) [21:27:08] (03CR) 10Jdlrobson: [C: 04-2] "Just a POC. Please rewrite piece by piece based on feature development." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 (owner: 10Jdlrobson) [21:30:20] ok me too [21:34:12] kaity: https://trello.com/c/7eClxCsB/14-blocked-2-tell-people-about-the-wikigrok-sidebar-game-after-finishing-one-grok thanks [21:40:01] bmansurov: just uploaded the new background to trello card [21:40:21] bearND: can haz merge? (when you get a moment) https://gerrit.wikimedia.org/r/187843 [21:40:21] moizsyed: thanks [21:40:40] dbrant: ok [21:46:17] bgerstle dr0ptp4kt searching for iOS 6… https://pbs.twimg.com/media/B882V3rIYAEJY2T.jpg [21:46:35] what are those, from the bronze age? [21:46:35] coreyfloyd: :) [21:46:47] is that an original iPhone?? [21:46:58] it's like an iPod classic [21:47:05] of course [21:47:34] still works - screen is about the size of an apple watch though [21:48:27] Even more archaic… I need to find a 30 pin connector - The packing crew just finished packing up all of my weird old wires [21:49:08] leila: Just want to check if missing page-impressions also have missing widget-impressions, as that will help me narrow down where the problem is. [21:49:52] yup. makes sense kaldari. will report shortly [21:53:21] (03PS4) 10Fjalapeno: Implement Pull to Refresh for saved pages. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 [21:54:40] kaldari: there are cases where page-impression is missing but widget-impression is not [21:56:02] if you look at staging.leizi_wikigrok_invalid_entries, you will see all event_userToken, event_taskToken for which page-impression is missing. The event_action_gp column in that table tells you what actions are present for these (user,task)s with no page-impression and you see widget-impression in there, kaldari [21:56:14] (03CR) 10Fjalapeno: "Visual glitch is fixed, should not jump anymore." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [21:58:33] leila: So for all the entries that are missing page_impression, what percentage are also missing widget-impression? 10%? 90%? [22:00:15] checking kaldari [22:03:17] coreyfloyd: omg how have i never heard of masonry before [22:03:40] bgerstle yeah - it is pretty awesome - one of those things i put in every project [22:03:49] 4k stars ಥ﹏ಥ [22:04:25] I prefer to use straw [22:05:42] kaldari: LULZ [22:07:16] bgerstle I actually am pretty horrible at reading VFL - because I have been using Masonry from the get go. As a bonus, it pretties up the debug print out of constraints to make them easy to debug. [22:08:07] (03PS4) 10BearND: Styling tweaks: infobox color/shadow, disambig link padding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187843 (owner: 10Dbrant) [22:08:14] (03CR) 10BearND: [C: 032] "Looks great!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187843 (owner: 10Dbrant) [22:09:19] bearND: thanks! lol i hope that's the last time i have to touch the infobox css... [22:10:00] dbrant: ;) [22:10:17] coreyfloyd: yeah i saw that in the GH README http://i292.photobucket.com/albums/mm31/leecothran/Borat-VeryNice.gif [22:10:35] kaldari: 0.6% of those (userToken, taskToken)s missing page-impression, missing widget-impression as well. [22:10:35] (03Merged) 10jenkins-bot: Styling tweaks: infobox color/shadow, disambig link padding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187843 (owner: 10Dbrant) [22:11:01] coreyfloyd: any reason why you used the C assert instead of NSParameterAssert? [22:15:00] bgerstle file/line#? [22:15:03] umm [22:15:24] -[SavedArticlesFetcher init...] [22:16:11] bgerstle, ahh… followed the convention of the other fetchers [22:16:56] bb in 30 - need to pick up the dog from day care [22:17:18] k [22:17:40] coreyfloyd: hrm, good thing i added that NDEBUG preprocessor setting... [22:17:44] otherwise we'd be getting crashes [22:19:00] bgerstle we can refactor all the fetchers to use better assert practices - or just change this one for now. [22:19:58] (03CR) 10QChris: [C: 031] "(I did not touch that file, I only created the repo, but still ... CR+1 :-) )" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/188086 (https://phabricator.wikimedia.org/T88251) (owner: 10MaxSem) [22:20:00] dbrant: why did you mark https://gerrit.wikimedia.org/r/#/c/187849/2 as WIP? Are you planning to add a header element? [22:22:08] bearND: yeah, i was going to talk to Vibha about what we could put up there (i agree that something should fill up that space). so, it's kind of on hold for the moment... [22:22:29] dbrant: great. Was just curious [22:22:31] bearND: we could also vertically center all the items... [22:24:57] dbrant: not so sure about centering nav drawer items. I haven't seen any apps do it. [22:27:14] 3Scrum-of-Scrums, Zero, MediaWiki-extensions-ZeroBanner, Mobile-Web: Language-aware redirects for mdot webroot in general - https://phabricator.wikimedia.org/T78172#1013047 (10DFoy) a:3dr0ptp4kt [22:27:58] 3Scrum-of-Scrums, Zero, MediaWiki-extensions-ZeroBanner, Mobile-Web: Language-aware redirects for mdot webroot in general - https://phabricator.wikimedia.org/T78172#837987 (10DFoy) Adam is this done? Can you close this? [22:32:56] 3Scrum-of-Scrums, Mobile-Web, MediaWiki-extensions-ZeroBanner: Language-aware redirects for mdot webroot in general - https://phabricator.wikimedia.org/T78172#1013074 (10Yurik) [22:54:11] mhurd any way to get you to send me the stack trace from the ios 6 crash? [22:54:25] it should be in your logs [22:54:31] coreyfloyd: lemme check... [22:54:51] same place a your build logs… not sure how much you have done since then… [23:02:16] coreyfloyd: qq, is the saved pages refresh control supposed to snap to the top bar while refreshing? [23:02:21] it seems to go away once loading starts [23:03:53] 3Scrum-of-Scrums, Mobile-Web, MediaWiki-extensions-ZeroBanner: Language-aware redirects for mdot webroot in general - https://phabricator.wikimedia.org/T78172#1013135 (10DFoy) p:5Triage>3Normal [23:04:37] (03CR) 10Bgerstle: "just a couple things about the refresh view API and some other minor stuff. otherwise, non-blockers that would be better addressed by a li" (0311 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [23:05:17] coreyfloyd: are you going to check out soon? i'm probably going to take a break and start prepping dinner [23:05:24] also, my eyes need a break [23:08:15] jdlrobs__: so that patch - https://gerrit.wikimedia.org/r/#/c/188271/ [23:08:36] is it supposed to be internationalized in any way? or are you asking me for suggestions on how to internationalize it? [23:09:06] oh, I'm reading the comments. [23:09:11] coreyfloyd: xcode makes me sad. got tired of trying to figure out where it’s storing those logs. from the console it looks like this is what you’re looking for “-[SavedPagesViewController setAutomaticallyAdjustsScrollViewInsets:]: unrecognized selector sent to instance 0x1db77af0” [23:09:31] jdlrobs__: I'll try to review it. [23:13:09] mhurd sure enough that's iOS 7+ [23:13:21] bgerstle: ya [23:13:38] mhurd i'm gonna step out for a bit. be back after dinner [23:13:45] bgerstle: sounds good! [23:14:16] o/ [23:16:12] (03PS1) 10Bmansurov: Define the 'skin' module outside DOM ready. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188483 [23:19:53] (03PS3) 10Bmansurov: Show the WikiGrokRoulette menu item to the user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188424 [23:19:55] (03PS2) 10Bmansurov: Fix mainMenu selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188407 [23:19:57] (03PS2) 10Bmansurov: Define the 'skin' module outside DOM ready. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188483 [23:36:54] mhurd did you find a log? [23:37:00] sorry - was on a hangout [23:38:23] coreyfloyd: no worry! xcode doesn’t make it easy to find those logs :) i ended up just copying this from the console ““-[SavedPagesViewController setAutomaticallyAdjustsScrollViewInsets:]: unrecognized selector sent to instance 0x1db77af0”” [23:38:47] that works… thanks [23:38:58] coreyfloyd: yw! [23:39:23] Deskana: have a minute? [23:39:46] mhurd: In a few minutes, sure. [23:39:52] mhurd yeah - my 30 pin connector was packed so i cant hook up an old device and i cant run the project in xcode 5 [23:39:55] Deskana: no rush [23:42:48] 3Mobile-Web: Cannot open the same image twice in mobile media viewer - https://phabricator.wikimedia.org/T88336#1013202 (10Jdlrobson) I believe this has since been fixed but enwiki is running super old code because of the all staff etc :/ [23:44:07] 3Mobile-Web: Cannot open the same image twice in mobile media viewer - https://phabricator.wikimedia.org/T88336#1013205 (10Jdlrobson) Specifically T85636 [23:44:57] kaldari: I am back, did you get the help you needed from leila? [23:52:49] nuria_: yes. it looks like lack of page-impression is not related to lack of widget-impression [23:53:25] kaldari: ok good, were you able to fix any problems on the client? [23:54:56] nuria_: not yet, I was hoping they were connected, becuase otherwise it’s pretty mysterious :P [23:55:35] kaldari: ok, did you look at browsers? to rule out it might be an error in a set of browsers? [23:55:54] nuria_: no, that’s a good idea though [23:56:38] kaldari: also the "dropped" events are the 1st ones right? so you have people on step #2 that are not on step #1 [23:56:41] Deskana: i added this: https://trello.com/c/3v3FbUeO/111-attach-the-actual-mocks-assets-to-the-card-rather-than-linking-to-dropbox-or-some-external-storage-service-otherwise-we-loose-th because of thiese: https://trello.com/c/TsM7DwLs/99-ios https://trello.com/c/ogYXOUcz/100-android https://trello.com/c/FieRD7Qq/101-kindle [23:56:46] *these* [23:57:40] kaldari: are you buffering events at all before logging?