[00:01:06] nuria_: the weird thing is that it’s pretty much impossible to get to step #2 without logging step #1. And no, the events are not getting buffered, they get fired in order of them happening. [00:01:45] does your step #1 include any async operation before firing the event? [00:01:49] kaldari [00:02:26] nope [00:03:15] it’s the simplest of all the logging code, so it’s extra weird that it’s the one missing. [00:04:26] mhurd: Good call. Make sure you point those new cards out in a mail to mobile-l otherwise nobody will ever know you added them! [00:06:44] Deskana: will do [00:13:16] (03CR) 10Fjalapeno: "Thanks Brian - addressing some changes in a few minutes" (036 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [00:15:01] (03PS5) 10Fjalapeno: Implement Pull to Refresh for saved pages. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 [00:15:47] (03CR) 10Fjalapeno: "Addressing some of Brian's feedback." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [00:16:18] (03PS6) 10Dr0ptp4kt: Enhanced sharing with cards [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293 [00:16:28] mhurd can you let me know about iOS 6 crashing when you look at my patch? [00:16:54] coreyfloyd: sure! just a minute... [00:17:02] dunka [00:18:59] mhurd: coreyfloyd when you have some time in the next day or two, would you please review https://gerrit.wikimedia.org/r/188293 ? Deskana if you want to install it onto an iOS device, lemme know. it seems like the event logging is basically working okay, but i can provide more details on how that actually works if you like [00:19:27] dr0ptp4kt will do [00:23:31] (03PS6) 10Bmansurov: Add WikiGrok Roulette info overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 [00:24:49] (03CR) 10jenkins-bot: [V: 04-1] Add WikiGrok Roulette info overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 (owner: 10Bmansurov) [00:26:15] (03PS7) 10Bmansurov: Add WikiGrok Roulette info overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 [00:26:35] (03PS8) 10Bmansurov: Add WikiGrok Roulette info overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 [00:31:27] coreyfloyd: no crash on ios 6! [00:31:46] mhurd long distance dubugging [00:31:55] coreyfloyd: hahah [00:34:42] coreyfloyd: tiny nit-pick, but the dots on the refresh used to all stay filled from time refresh triggers until the refresh disappears. now it flickers to only the center dot being filled once it triggers… would you mind taking a quick peek to see if it’s an easy fix? [00:35:03] mhurd: feature not a bug [00:35:17] they animate - blink 135 [00:35:27] coreyfloyd: regression not a feature [00:35:39] your just refreshing so fast that you only see the first blink [00:35:57] coreyfloyd: try ‘em side by side - you’ll see it [00:37:55] coreyfloyd: the padding between the dots and the “Pull to refresh article” has also significantly increased. easy fix i’m sure [00:38:17] mhurd i can fix spacing - how close do you want them [00:38:48] coreyfloyd: you can just use the old spacing for comparison [00:40:30] mhurd what about throw distance? closer or is that good? [00:44:11] (03PS1) 10BearND: Use Gradle BuildConfig to replace getPackageName calls [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188493 [00:47:25] leila: I’m really beating my head against the wall trying to figure out how only the page-impressions could be missing. It’s very mysterious. Of all the things we’re logging, that one is the most simple and fool-proof. Any chance you could look for any other patterns in those records, e.g. certain time period, certain browser, etc. or send me the table and I can look. [00:49:29] coreyfloyd: throw is spot on [00:49:51] good [00:50:17] (03PS6) 10Fjalapeno: Implement Pull to Refresh for saved pages. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 [00:50:30] mhurd that is the spacing adjustment [00:53:38] kaldari: can you check staging.leizi_wikigrok_invalid_entries to see if you see the table? [00:54:10] sure.... [00:54:20] leila: are you thinking of going to wikimania this year? [00:54:26] (03PS1) 10Robmoen: WIP: Showing collection list on Special:Collections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188495 [00:54:35] yes, Maryana. why? [00:54:42] https://etherpad.wikimedia.org/p/Mobile_at_Wikimania_2015 :) [00:54:44] 3Scrum-of-Scrums, Mobile-Web, MediaWiki-extensions-ZeroBanner: Language-aware redirects for mdot webroot in general - https://phabricator.wikimedia.org/T78172#1013399 (10dr0ptp4kt) 5Open>3declined [00:55:01] (03PS2) 10Robmoen: WIP: Showing collection list on Special:Collections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188495 [00:55:09] leila: we should give some awesome data-informed talks together [00:55:22] leila: I have access to it. Thanks! [00:55:24] totally, Maryana. [00:55:29] np, kaldari. [00:55:42] end of February is the deadline Maryana, right? [00:55:46] yep [00:56:00] (03CR) 10jenkins-bot: [V: 04-1] WIP: Showing collection list on Special:Collections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188495 (owner: 10Robmoen) [00:56:00] hookay, beginning of next week to talk about it, Maryana? [00:56:05] leila: it doesn’t have much data in it :P Any possibility of adding more fields to it or should I just join with the other tables; [00:56:06] i'm just trying to pull ideas together on etherpad so we don't all submit 5 wikigrok talks ;) [00:56:13] leila: sure thing [00:56:14] coreyfloyd: sweet! looking solid. still on the fence about the 1-3-5 animation ;) [00:56:54] mhurd: I hear ya - can we have Dan and VIbha take a look? [00:57:09] makes sense Maryana [00:57:20] mhurd if its good it would be a nice lead in to getting rid of the modal spinner - most pull to refreshes do some sort of nice animation [00:57:22] yeah, kaldari. I made that just to group event_action [00:58:07] (03CR) 10Robmoen: "Needs:" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188495 (owner: 10Robmoen) [00:58:12] mhurd lots of companies actually do some cool blue sky stuff with their pull to refresh animations. [00:58:17] coreyfloyd: oh may be a problem - i just did pull to refresh on the saved pages and the progress bar immediately scrolled away… [00:58:31] leila: no problem [00:58:44] mhurd probably refreshing really fast [01:00:05] coreyfloyd: yeah that’s what the pull to refresh stuff i had written was setting the stage for - a cool wikipedia-specifc core animation indicator - which is part of the reason why i’m hesitant about 3rd party pull to refresh [01:00:13] (03PS3) 10Robmoen: WIP: Showing collection list on Special:Collections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188495 [01:00:51] mhurd I wrote the animation - no 3rd Party code™ [01:01:11] (03CR) 10jenkins-bot: [V: 04-1] WIP: Showing collection list on Special:Collections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188495 (owner: 10Robmoen) [01:01:54] (03PS4) 10Robmoen: WIP: Showing collection list on Special:Collections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188495 [01:01:56] take that jenkins ^ [01:02:28] mhurd also - I removed the 3rd party lib and implemented it, used the library as a starting point and added all the tweaks we needed [01:03:19] coreyfloyd: ya, is good stuff [01:04:30] coreyfloyd: quick hangout? [01:04:38] 2 min [01:22:50] 3Mobile-Web: Alpha: Wrong position for the last edited bar when images are present on the page - https://phabricator.wikimedia.org/T88499#1013421 (10bmansurov) 3NEW [04:39:23] 3Wikipedia-App-Android-App, RESTBase, Wikipedia-App-iOS-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1013630 (10Eloquence) [04:43:35] (03CR) 10Fjalapeno: [C: 04-1] "Left some mostly minor comments. The primary thing holding me up is encapsulation of the share view code into a reusable component. Basica" (0321 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293 (owner: 10Dr0ptp4kt) [05:32:40] 3Wikipedia-App-Android-App: Page footer doesn't show on short articles where the footer should be displayed above the fold - https://phabricator.wikimedia.org/T88509#1013668 (10Deskana) 3NEW [05:35:50] (03Abandoned) 10Florianschmidtwelzow: POC: Add mobile preview button to EditPage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166089 (https://phabricator.wikimedia.org/T85587) (owner: 10Florianschmidtwelzow) [05:36:17] 3MobileFrontend-Feature-requests: Emulate mobile view on desktop preview page - https://phabricator.wikimedia.org/T85587#1013680 (10Florian) [10:15:54] yo [10:16:01] * YuviPanda waves at phuedx [10:16:34] hey YuviPanda! [11:34:22] (03CR) 10Phuedx: "See inline." (037 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 (owner: 10Jdlrobson) [11:49:34] (03CR) 10JanZerebecki: "Yes it is broken as is, but this patch is not improving it, it is making the problem worse, as before it was distinguishable from PHP noti" [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/184062 (owner: 10Ori.livneh) [14:07:43] hi phuedx! [14:07:48] just arrived from the vet again [14:09:37] hey joakino [14:17:06] (03CR) 10Jhernandez: Add arrow icon to read more in the collections view (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188368 (owner: 10Jhernandez) [14:17:21] (03PS5) 10Jhernandez: Add arrow icon to read more in the collections view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188368 [14:20:15] hey all! [14:21:34] Hi there, a deprecated-Commons-app-for-Android user asks when there will be an app to upload pictures to Commons, or what is the plan [14:21:56] Is the plan to add this functionality to the Wikipedia app? [14:22:21] qgil: i think the latter [14:22:26] there was a commons app [14:22:47] pulled from Google Play, es [14:22:49] yes [14:22:49] i'm pretty sure the plan is to fold its functionality into the wikipedia app [14:23:43] joakino: can you review "Fix UploadTutorial" [14:24:10] hi all [14:24:15] jdlrobson: im on it [14:25:32] (03CR) 10Jdlrobson: [C: 032] Fix mainMenu selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188407 (owner: 10Bmansurov) [14:26:50] (03CR) 10Jhernandez: [C: 04-1] Watchlist lives at Special:Collections/user/0 (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188258 (owner: 10Robmoen) [14:27:43] (03Merged) 10jenkins-bot: Fix mainMenu selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188407 (owner: 10Bmansurov) [14:28:06] https://commons.wikimedia.org/wiki/Commons:Mobile_app says "It was available for Android and iOS but has not been maintained in a while and will likely not see further development, thus it has been removed from Play Store and App Store..." [14:28:30] No trace of plans in the wiki page or Phabricator, I wonder if there is a Trello board smewhere with the answer [14:28:39] anyway, not urgent [14:29:14] hola joakino :) [14:29:22] hola qgil! [14:29:30] joakino: thanks, keen to get all my stuff merged today [14:29:38] joakino: thanks, keen to get all my stuff merged today [14:30:23] joakino, the user who asks the question above is from your lovely Valencian region... As you see, I'm nice with your neighbors [14:31:22] qgil: well done :) [14:31:47] :) [14:32:16] jdlrobson: when I click the yes it prompts me for an image (closes the modal), and when i select one it goes somewhere else and reloads the modal again [14:33:54] jdlrobson: i've been called to lunch, i'll review it in a bit first thing [14:34:03] OH NOOO [14:36:45] (03PS1) 10Florianschmidtwelzow: Regression: Fix upload overlay [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/188558 (https://bugzilla.wikimedia.org/71715) [14:37:09] jdlrobson: whoops [14:37:14] i dropped the ball on reviewing that [14:38:15] (03CR) 10Florianschmidtwelzow: "i know, that we normally don't support older branches, but this breaks the entire Upload function especially for third parties (which are " [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/188558 (https://bugzilla.wikimedia.org/71715) (owner: 10Florianschmidtwelzow) [14:38:27] also, hey jdlrobson [14:39:38] phuedx is in the houuussee [14:39:45] yeah sorry [14:39:47] phuedx: it's cos you've been working in Wikigrok extension [14:39:56] nah it ain't [14:39:58] yey silos etc (i'm still grumpy about this as you might be able to tell ;-)) [14:39:58] i just forgot ;) [14:40:07] (03PS1) 10Jdlrobson: Hygiene: Minor documentation changes - fix jsduck warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188559 [14:42:21] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Minor documentation changes - fix jsduck warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188559 (owner: 10Jdlrobson) [14:44:07] jdlrobson: i struggled with that email about collections storage [14:44:17] took me a while to get it out of my head [14:44:21] and i'm not sure it reads well [14:44:51] one of my personal goals this year is to write more prose than code [14:45:07] phuedx: what did you struggle with? [14:45:22] just writing it down [14:45:37] ;) [14:45:52] the act of laying out my thoughts [14:46:09] i find it much easier to riff on other people's emails than i do to start a new [14:50:06] i will forever be waiting for shared nfs folders to mount [14:51:14] :) [14:51:20] so was my email articulated well? [14:51:25] or could i have improved it? [14:51:51] (03CR) 10Jdlrobson: [C: 04-2] "Pending outcome of "Important: Collections work blocked - When is an extension not an extension?"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 (owner: 10Bmansurov) [14:52:25] (03CR) 10Jdlrobson: [C: 04-2] "Pending outcome of "Important: Collections work blocked - When is an extension not an extension?"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188424 (owner: 10Bmansurov) [14:54:29] jdlrobson: which email? [14:54:38] collections storage [14:54:53] the first one? yeah, it was fine [14:55:19] phuedx: cool and yeh i was aware why the race condition was occurring, i just hadn't thought about that possibility before implementing [14:55:23] but it makes total sense [14:55:58] jdlrobson: i figured, but i wanted to provide context for why collections-as-sub-pages might be a little cleaner [14:56:10] i know you guys are wicked smart [14:56:19] but context :) [14:56:25] yeh i thought about that, and i'm still open to that [14:56:35] although race conditions are still possible [14:56:45] take the Special:editwatchlist page for example [14:56:52] imagine unticking a bunch of articles on the page [14:57:01] yup [14:57:12] pointed that out at the bottom of the email [14:57:15] oh yeh [14:57:22] so yeh it has its problems as expected [14:57:35] i should've put "use a database" at the bottom of the email ;) [14:57:37] at least if it's in one page we don't pollute the namespace and it gets us off the ground [14:57:47] yarrrp [14:57:48] phuedx: for reals. you know i want a database [14:57:56] you'll race but not at the manifest-level [14:58:00] *manifest level [14:58:02] right now i just want to get something off the ground [14:58:10] stick with what you've got [14:58:13] with bugs and all [14:58:30] show it to people [14:58:35] then, db! [15:00:30] gonna get a jumper [15:00:36] it's cold down here [15:02:54] i'm back! [15:03:03] hey joakino [15:03:56] wtf irc [15:03:57] anyway [15:05:06] -2 war! [15:05:55] 3Mobile-Web: VisualEditorOverlay should be written as an OO.ui.Dialog - https://phabricator.wikimedia.org/T88559#1014685 (10Jdlrobson) 3NEW [15:06:09] 3Mobile-Web: VisualEditorOverlay should be written as an OO.ui.Dialog - https://phabricator.wikimedia.org/T88559#1014694 (10Jdlrobson) Related: T87051 [15:09:47] (03PS2) 10Phuedx: Hygiene: Minor documentation changes - fix jsduck warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188559 (owner: 10Jdlrobson) [15:10:53] * phuedx waits for jenkins [15:11:57] phuedx: http://knowyourmeme.com/memes/waiting-for-op [15:12:06] jdlrobson: in the upload tutorial when clicking the yes button, it should allow a file upload normally like from Special:Uploads, right? [15:12:21] lol [15:12:58] (03CR) 10Phuedx: [C: 032] Hygiene: Minor documentation changes - fix jsduck warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188559 (owner: 10Jdlrobson) [15:13:11] given that my change was uppercasing an 's' [15:14:39] joakino_: only if you have set a funnel parameter [15:15:10] (03Merged) 10jenkins-bot: Hygiene: Minor documentation changes - fix jsduck warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188559 (owner: 10Jdlrobson) [15:15:35] jdlrobson: that is the /foo [15:16:24] (03PS6) 10Jdlrobson: Hygiene: Move wgResourceLoaderLESSVars out of extension function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187947 (owner: 10Florianschmidtwelzow) [15:17:07] i am slightly worried about collections being broken by wikigroks rapid deploy cycle [15:17:25] this is a good example of something that could break us > https://gerrit.wikimedia.org/r/#/c/187947/ [15:17:32] jdlrobson: the file upload is not working with the funnel :( does it work for you? [15:17:39] joakino_: i'll take a look [15:17:43] i wrote the patch 2 weeks ago :) [15:18:03] just reviewing bahas aptch [15:18:30] jdlrobson: what in that patch relates to wikigrok rapid deploys? [15:18:38] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move wgResourceLoaderLESSVars out of extension function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187947 (owner: 10Florianschmidtwelzow) [15:22:08] joakino_: just forwarded to mobile-tech [15:23:51] (03PS1) 10Jdlrobson: Hygiene: Don't bind mainMenu to mw.mobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188561 [15:26:07] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Don't bind mainMenu to mw.mobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188561 (owner: 10Jdlrobson) [15:28:04] (03CR) 10Jdlrobson: [C: 032] "please review my follow up patches related to my comments." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188483 (owner: 10Bmansurov) [15:28:20] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188561 (owner: 10Jdlrobson) [15:28:39] jdlrobson: i'm fixing the uploading, let me have a stab at it [15:30:22] (03Merged) 10jenkins-bot: Define the 'skin' module outside DOM ready. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188483 (owner: 10Bmansurov) [15:31:16] 3Mobile-Web: ErrorReportOverlay should use View##events map - https://phabricator.wikimedia.org/T88562#1014863 (10Jdlrobson) 3NEW [15:31:42] 3Mobile-Web: LanguageOverlay should use View##events - https://phabricator.wikimedia.org/T88563#1014871 (10Jdlrobson) 3NEW [15:31:59] 3Mobile-Web: Overlay, Panel and Drawer should use View##events - https://phabricator.wikimedia.org/T87192#1014879 (10Jdlrobson) [15:33:17] 3Mobile-Web: Talk overlays should use View##events - https://phabricator.wikimedia.org/T88564#1014885 (10Jdlrobson) 3NEW [15:36:36] 3Mobile-Web: Infobox should use View##events - https://phabricator.wikimedia.org/T88565#1014899 (10Jdlrobson) 3NEW [15:36:50] 3Mobile-Web: ImageOverlay should use View##events - https://phabricator.wikimedia.org/T88566#1014907 (10Jdlrobson) 3NEW [15:37:45] 3Mobile-Web: PhotoUploadOverlay and PhotoUploadProgress should use View##events - https://phabricator.wikimedia.org/T88568#1014931 (10Jdlrobson) 3NEW [15:38:03] 3Mobile-Web: WikiGrokDialogs not using View##event - https://phabricator.wikimedia.org/T88296#1014939 (10Jdlrobson) [15:38:35] 3Mobile-Web: Wikigrok and infobox dialogs should use events property to define their events - https://phabricator.wikimedia.org/T87194#1014943 (10Jdlrobson) 5Open>3Invalid a:3Jdlrobson [15:39:01] 3Mobile-Web: Update Schema:MobileWebWikiGrokError now that WikiGrok has changed - https://phabricator.wikimedia.org/T86855#1014945 (10Jdlrobson) Did this get fixed @kaldari ? [15:41:28] 3Mobile-Web: Special:UserProfile should not use wfHttpError() for missing user parameters - https://phabricator.wikimedia.org/T86007#1014950 (10Jdlrobson) @Krinkle out of interest why is this the status quo? It seems like this would effect SEO and be cached on the local browser. Why do we show error pages with a... [15:43:57] (03PS1) 10Jdlrobson: Hygiene: Make Infobox use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188566 (https://phabricator.wikimedia.org/T88565) [15:44:57] joakino: okay looking at the code [15:45:15] jdlrobson: the problem is dismissing the tutorial on upload click [15:45:34] then the file selected event does not trigger when you select an image because that dom has been blown away [15:46:08] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make Infobox use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188566 (https://phabricator.wikimedia.org/T88565) (owner: 10Jdlrobson) [15:46:11] joakino: what url are you using? [15:46:20] (03PS2) 10Jdlrobson: Hygiene: Make Infobox use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188566 (https://phabricator.wikimedia.org/T88565) [15:46:40] i go to http://localhost:8080/wiki/Albert_Einstein and when it is loaded I add #/upload-tutorial/foo to the url [15:47:07] (03PS3) 10Jdlrobson: Hygiene: Make Infobox use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188566 (https://phabricator.wikimedia.org/T88565) [15:47:42] okay joakino i'm not sure whether that matters [15:47:45] but i'll check [15:48:51] (03PS8) 10Jhernandez: Fix UploadTutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185850 (owner: 10Jdlrobson) [15:49:25] jdlrobson: ^ check this one, if you do not hide the tutorial, the uploading works normal, but then reloads the page and the tutorial opens again [15:51:03] (03CR) 10jenkins-bot: [V: 04-1] Fix UploadTutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185850 (owner: 10Jdlrobson) [15:51:08] i've tried dismissing the tutorial on the M.on( _upload-preview ) event and also in the change event of the input, but havent managed to get it working because the tutorial catches the events too late [15:51:49] EVENT HELL [15:52:39] yeh that whole code is a nightmare [15:52:54] we only surface it to 3rd parties [15:53:44] ok so yeh i see.. it opens the upload interface but then reverts back [15:53:45] sigh [15:54:19] i've only been optimising for Special:Uploads [15:55:50] i dunno what to do. the problem is i wrote this 2 weeks ago and i've completely forgotten about it [15:55:57] i can't even remember what i was fixing [15:56:20] i think it was mostly visuals [15:59:35] joakino_: just fixing up now. I think i see what's happening [16:04:30] is there currently no way to see all the diffs & comments for a gerrit review in one tab? [16:05:31] bgerstle: git diff HEAD^ :D [16:05:53] bgerstle: or All Side-by-Side [16:05:55] at the end [16:06:28] oh... which appears to be broken? [16:09:01] jdlrobson: All Side-by-Side opens them all in tabs [16:09:11] which is usable, but brute force [16:09:11] [16:09:40] jdlrobson: and yes, i could use a nice diff viewer, but what i actually want to see is a diff between patch sets [16:09:57] if this weren't gerrit, i'd just view the individual commit diffs [16:09:58] but... [16:15:18] (03PS9) 10Jdlrobson: Fix UploadTutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185850 [16:15:23] ^ joakino_ just about does it [16:17:44] (03CR) 10jenkins-bot: [V: 04-1] Fix UploadTutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185850 (owner: 10Jdlrobson) [16:18:47] the strong winds are breaking internet and i keep disconnecting from irc... so annoying [16:18:53] jdlrobson: gonna have a look [16:19:22] bgerstle: if you find a way without opening 2 thousand tabs, please share, that would be so useful [16:19:46] (03PS7) 10Jdlrobson: Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 [16:20:06] joakino all i found was an issue on the googlecode repo saying they don't have an ETA for the feature :-( [16:20:15] grr [16:20:19] also, their gerrit looks much nicer than hours [16:20:21] ours* [16:20:32] https://code.google.com/p/gerrit/issues/detail?id=938 [16:20:52] joakino_: heading for lunch in a bit [16:21:11] 👍 [16:21:22] https://gerrit-review.googlesource.com/#/c/59320/ [16:22:10] (03CR) 10jenkins-bot: [V: 04-1] Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 (owner: 10Jdlrobson) [16:23:58] jdlrobson: so after an upload the tutorial is supposed to appear again? [16:24:16] joakino_: no.. does it? :-/ [16:24:25] jdlrobson: i think so [16:24:28] jdlrobson: let me retry [16:24:29] sighhh [16:25:57] yep, when the upload finishes, the router does a back() which goes to the tutorial url so when it refreshes it pops up again [16:30:01] sigh [16:30:18] i don't know what to do about it all then [16:30:38] i'm only making css changes really, so maybe we should just raise a bug for behaviour [16:30:57] we're not technically supporting it anyway - all the uploads browser tests got removed [16:31:08] and my vagrant just broke again [16:31:14] sigh one of these days! [16:31:46] jdlrobson: :( we never got around to pairing to see if we could fix your problems last week [16:32:07] bd808: yeh and i'm off on vacation after tomorrow :-/ [16:32:23] 17s to load a css file.. :-S [16:32:26] it makes no sense! [16:32:39] i don't know how i get any work done with this environment [16:32:39] jdlrobson: set a meeting with me when you get back. we can debug over a hangout I think [16:32:48] i know rmoen has the same issue [16:32:52] bgerstle: that gerrit interface is the new one, you can enable it from the settings [16:32:52] he's stopped using vagrant i believe [16:33:18] orly? [16:33:21] jdlrobson: he has a non vagrant installation for day to day work, and when needed (prod mirroring) uses the vagrant [16:33:38] jdlrobson: I have a sneaking hunch that your problems are related to the redis cache layer [16:34:04] job queue and content cache fighting for too little ram [16:34:27] ok grabbing lunch... maybe we can debu this later? [16:34:52] have you tried turning it off and on? https://www.youtube.com/watch?v=p85xwZ_OLX0 [16:35:13] first episode. a classic [16:35:19] haha [16:35:31] I have that RTFM shirt. It tool me weeks to track it down [16:35:36] *took [16:37:54] joakino ugh the new view is worse than the old one! [16:37:56] (03CR) 10Florianschmidtwelzow: [C: 032] Hygiene: Make Infobox use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188566 (https://phabricator.wikimedia.org/T88565) (owner: 10Jdlrobson) [16:38:03] bgerstle: yep :( [16:38:04] i didn't think that was possible [16:38:10] hahah [16:38:15] agreed [16:38:47] bgerstle: personally i wouldnt care if i could easily compare patchsets and have fucking notifications for comments or mentions on patches or code [16:39:35] joakino if only there was a service that had those features [16:40:06] (03Merged) 10jenkins-bot: Hygiene: Make Infobox use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188566 (https://phabricator.wikimedia.org/T88565) (owner: 10Jdlrobson) [16:40:07] it has to be open source :( [16:40:18] ^ that [16:41:19] (03CR) 10Bgerstle: "moar comments" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [16:42:38] bgerstle: phuedx: this is supposed to be pretty good https://about.gitlab.com/ [16:43:10] i've head good things about gitlab [16:43:16] and 've seen it in the wild [16:44:27] phuedx just saw that googling "open source github" [16:44:32] this thread seems interesting: http://programmers.stackexchange.com/questions/129152/are-there-open-source-alternatives-to-bitbucket-github-kiln-and-similar-dvcs [16:45:03] gitorious (http://www.gitorious.org/) ships in a docker image. sold [16:47:53] phuedx: bgerstle: we'll get phabricator code auditing at some point in the future [16:48:02] then we'll bitch about it xd [16:48:33] joakino i saw the YT demo of it… not sure what to think [16:48:47] anyway [16:48:49] bgerstle: link? [16:48:53] hmm [16:48:57] isn't it more like github? [16:49:21] joakino forwarded you an email w/ links [16:49:32] thx!! [16:53:11] bgerstle: it says it is similar to pull requests? [16:53:19] no video on the links though [16:53:57] i thought the first link is a YT video? [16:56:40] bgerstle: oh yeah [16:56:42] sorry [17:05:49] fingerless gloves [17:05:56] for the cold, stylish h4xx0r [17:09:02] +1 [17:12:16] phuedx dbrant: http://www.thinkgeek.com/product/ebcc/ [17:12:35] (03PS10) 10Jhernandez: Fix UploadTutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185850 (owner: 10Jdlrobson) [17:13:00] bgerstle: lol of course that exists! [17:15:36] coreyfloyd: FYI i found a sweet Xcode plugin that lets you change font size w/ Cmd +/- [17:16:11] lol [17:16:23] i found a sweet xcode plugin that warms up my damn hands [17:16:53] phuedx i thought that was a built-in feature [17:17:08] (03CR) 10Jhernandez: [C: 031] "The buttons are fixed, functionality works, there is a slight quirk where uploading an image will reload the page and that may reload the " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185850 (owner: 10Jdlrobson) [17:17:25] coincidentally it also happens streaming video and just browsing w/ multiple tabs :-/ [17:17:29] lol [17:17:32] stop using chrome [17:17:40] joakino how'd you know... [17:17:49] let me guess "use an open source browser!" [17:18:01] i don't really have anything tying me to chrome [17:18:07] xd [17:18:11] bgerstle: http://i.imgur.com/bhfYx6R.jpg [17:18:22] hehehhe [17:19:13] i use the firefox developer edition for browsing, chrome for dev & debugging mainly, each browser has its quirks [17:19:29] lol lol [17:19:37] that image is excellent [17:20:37] chrome debugger is so nice though [17:20:42] haven't used safari's too much [17:20:53] i love the MDN javascript reference though [17:20:59] chrome dev tools are awesome [17:21:04] s/safari/firefox/ [17:21:10] safari's is awful :( [17:21:17] gotten better recently [17:21:18] ff dev tools are catching up too [17:21:22] but still pales in comparison [17:22:16] well, maybe if i use firefox i'll be motivated to dust off my C++ chops and make a contribute (yeah right, who am i kidding) [17:22:24] contribution* [17:22:39] (03CR) 10Dbrant: [C: 04-1] Use Gradle BuildConfig to replace getPackageName calls (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188493 (owner: 10BearND) [17:24:55] bgerstle: don't you want to learn some good ol' php? [17:25:26] maybe. but i'd probably rather learn the new shiny: hack [17:26:29] all this SOA discussion and doing things in node scares me… i like type checking [17:26:50] http://learnxinyminutes.com/ [17:27:02] ohhh [17:27:04] bookmarked! [17:27:21] the moment you do micro services you lose any type checking, right? [17:27:29] why would you? [17:27:30] i mean, between service boundaries [17:27:48] sort of… you have a schema [17:27:50] http endpoints can't enforce types? [17:28:32] and if we follow the ideas from james douglas talk, we'd actually be able to strengthen those contracts [17:28:48] i.e. generate checkable types in your language of choice from the API & schema specifications [17:29:09] even if you do it manually, you can get type-checking for response schemas [17:29:12] aha [17:29:25] which talk? i'm guessing not this one https://www.youtube.com/watch?v=srstQVfVNEM [17:29:37] i meant our james douglas [17:29:40] from the dev summit [17:29:45] he did a talk on Swagger [17:29:54] oh i didn't attend that one [17:30:15] well, check out Swagger and JSONSchema [17:30:25] ^ that [17:30:26] i'd like to start using those more [17:30:36] swagger-core [17:30:44] swagger looks cool [17:30:44] netflix did a talk where they mentioned swagger [17:30:52] but there was no swagger codegen for php when i looked [17:30:54] now there is! [17:31:06] \o/ [17:31:17] never write client-side wrappers for server APIs again! [17:31:29] 3Mobile-Web: Infobox should use View##events - https://phabricator.wikimedia.org/T88565#1015261 (10Florian) 5Open>3Resolved a:3Florian [17:31:36] george is currently reading plato's republic [17:31:40] upside down [17:31:47] he's wicked smart [17:33:19] bgerstle: saw this yesterday and thought of our chats: http://rosetta-lang.org/ [17:33:37] phuedx: oh noes! he may turn into a hippie philosopher! [17:33:46] also, this: http://noflojs.org/ [17:33:54] phuedx is this along the lines of the domain driven stuff you were talking about? [17:33:54] rosetta-lang seems to have been abandoned [17:34:02] so i stopped after the front page [17:36:47] simple services, composition of services is where the complexity lies, need a language to describe it [17:37:01] http://i.imgur.com/wm9Srgj.gif [17:37:17] seriously though, i'll check it out [17:37:27] on the surface rosetta looks like it was an attempt to do the composition bit [17:37:56] it's drag and drop design for developers!!! [17:38:05] ! [17:38:07] * bgerstle has flashbacks fo supercollider and puredata [17:38:10] PROGRAMMING [17:38:32] screw writing code [17:38:34] seriously [17:38:39] wait what [17:38:45] it was funded ON KICKSTARTER?! [17:39:02] and there are ready-made components already? [17:39:09] http://noflojs.org/library/ [17:39:20] this is like every start-up CEO's wet dream [17:40:04] ain't it just [17:40:05] (03CR) 10Jhernandez: "agreed with phuedx. that's how it is going to be. i don't think it matters for the mvp that if a user is going to be editing a list at the" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188225 (owner: 10Jdlrobson) [17:43:02] bgerstle: as with most things awesome, this is 1970's solutioneering [17:43:23] hehe [17:43:45] * bgerstle changes title to "Full-stack Polyglot Solutioneer" [17:44:02] my theory is programmers united and stopped reading papers so that we could generate enough technical debt to keep the industry alive [17:44:19] "you mean you've solved this and all i have to do is implement your paper ONCE!?" [17:44:20] you know too much.. [17:44:46] btw i watched that glen vanderberg talk. top-notch [17:44:46] "step into this dark alley for a second…" [17:44:51] inorite [17:44:58] totes [17:46:07] also, bgerstle, everything will eventually be written in js [17:46:16] i read a paper on it not so long ago… [17:46:44] i'll just wait until ECMAScript adds optional static typing [17:46:54] typescript.org [17:47:01] wow [17:47:03] wrong site [17:47:07] haha [17:47:16] but yeah, that's a third-party compiler, right? [17:47:21] http://www.typescriptlang.org/ [17:47:31] but yeah, that's the idea [17:47:46] phuedx although, i might be persuaded to abandon types and write clojurescript [17:47:52] http://www.purescript.org/ [17:48:16] i'm fairly sure that joakino_ has a clojurescript highlight word [17:48:25] hahaha [17:48:33] omfg yes purescript [17:48:47] it looks like haskell! do want [17:48:57] phuedx also, http://elm-lang.org/ [17:49:06] and now i need to actually start working [17:49:11] w/e [17:49:13] work is for nerds [17:49:23] or people who want to get paid [17:50:20] lol [17:50:23] fun conversations [17:50:58] 3Mobile-Apps, Wikipedia-App-Android-App, RESTBase, Services, Wikipedia-App-iOS-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1015336 (10dr0ptp4kt) [17:51:08] so TodoMVC has implementations in typescript + backbone & angular [17:51:20] someone needs to write one in purescript, clojurescript, and ELM [17:51:23] you know, for comparison [17:51:24] and science [17:51:36] http://todomvc.com/ [17:51:42] 3Scrum-of-Scrums, Mobile-Apps, Wikipedia-App-Android-App, RESTBase, Services, Wikipedia-App-iOS-App: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1000056 (10dr0ptp4kt) [17:52:32] bgerstle: it has for clojurescript and elm that i know of [17:52:45] joakino really? it's not linked on their site [17:53:10] bgerstle: https://github.com/evancz/elm-todomvc [17:53:15] ohhh [17:53:35] and with om on clojurescript http://swannodette.github.io/todomvc/labs/architecture-examples/om/ (features benchmark against backbone and undo/redo courtesy of immutable data structures) [17:54:25] 3MediaWiki-API, Mobile-Apps, Wikipedia-App-Android-App, MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), Wikipedia-App-iOS-App: Mobile apps users should not be shown captchas when creating accounts - https://phabricator.wikimedia.org/T88083#1015356 (10dr0ptp4kt) [17:54:57] whoa [17:54:59] nice [17:55:07] i've heard of om [17:55:23] bgerstle: hmm can't find the undo/redo, seems like they removed it [17:56:08] 3Wikipedia-App-Android-App, MediaWiki-API, Mobile-Apps, Wikipedia-App-iOS-App: generator=search API should return information about search suggestions, like list=search does - https://phabricator.wikimedia.org/T86982#1015368 (10dr0ptp4kt) [17:56:54] phuedx, your +1 needed at https://gerrit.wikimedia.org/r/#/c/188086/ [17:57:19] 3MediaWiki-API, Scrum-of-Scrums, Mobile-Apps, Wikipedia-App-Android-App, Wikipedia-App-iOS-App: generator=search API should return information about search suggestions, like list=search does - https://phabricator.wikimedia.org/T86982#980930 (10dr0ptp4kt) [17:57:37] (03CR) 10Phuedx: [C: 031] Clarify license [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/188086 (https://phabricator.wikimedia.org/T88251) (owner: 10MaxSem) [17:57:43] MaxSem: ^ [17:57:47] thank [17:57:51] s:) [18:00:40] maxsem where does the commons image metadata API documentation live? [18:01:01] phuedx, stand and deliver [18:01:11] sorry, lisa's having a nosebleed [18:07:32] (03CR) 10Bmansurov: [C: 032] Hygiene: Don't bind mainMenu to mw.mobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188561 (owner: 10Jdlrobson) [18:08:18] (03CR) 10Dr0ptp4kt: "@Fjalapeno, thanks for comments. Will examine..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293 (owner: 10Dr0ptp4kt) [18:09:38] (03Merged) 10jenkins-bot: Hygiene: Don't bind mainMenu to mw.mobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188561 (owner: 10Jdlrobson) [18:12:45] 3Mobile-Web: Special:UserProfile should not use wfHttpError() for missing user parameters - https://phabricator.wikimedia.org/T86007#1015401 (10Krinkle) [18:12:55] 3Mobile-Web: Special:UserProfile should not use wfHttpError() for missing user parameters - https://phabricator.wikimedia.org/T86007#959444 (10Krinkle) [18:17:18] bearND stadn with us [18:19:27] (03PS8) 10Bmansurov: Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 (owner: 10Jdlrobson) [18:19:42] (03PS8) 10Dbrant: Video playback in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) [18:20:41] 3Mobile-Web: Special:UserProfile should not use wfHttpError() for missing user parameters - https://phabricator.wikimedia.org/T86007#1015422 (10Krinkle) [18:20:53] (03CR) 10MaxSem: "Jon, the only reason it's not in a separate extension is your objections." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 (owner: 10Bmansurov) [18:21:24] Maryana, leila: I have scrum of scrums until 11, would it be possible to reschedule the WikiGrok meeting? [18:21:46] works for me kaldari, Maryana [18:22:01] 11-11:30 would work [18:22:15] (03PS1) 10Florianschmidtwelzow: Hygiene: Convert SkinMinerva* files to use Config object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188589 (https://phabricator.wikimedia.org/T87614) [18:22:39] kaldari: leila i can do 11-11:30 [18:22:42] i'll move it [18:22:45] thanks! [18:22:58] my calender is updated kaldari. feel free to move the envet. [18:23:03] I can't do 11, another meeting [18:23:51] OK, moved it to 11:30 to 12 [18:24:28] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Convert SkinMinerva* files to use Config object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188589 (https://phabricator.wikimedia.org/T87614) (owner: 10Florianschmidtwelzow) [18:25:31] Maryana: is 11:30 to 12 good for you? [18:25:48] kaldari: sure thing [18:26:19] updated. sorry for the calendar spam! [18:27:43] (03CR) 10Legoktm: [C: 031] Clarify license [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/188086 (https://phabricator.wikimedia.org/T88251) (owner: 10MaxSem) [18:27:55] (03CR) 10Reedy: [C: 031] Clarify license [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/188086 (https://phabricator.wikimedia.org/T88251) (owner: 10MaxSem) [18:29:59] (03CR) 10Dbrant: "@BearND, issue #1 should be resolved; and issue #2 is actually approved by designers (start playing upon swipe), so it shouldn't be a bloc" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) (owner: 10Dbrant) [18:31:06] Maryana: :-) https://medium.com/backchannel/meet-the-ultimate-wikignome-10508842caad [18:31:24] hehe, yeah, giraffedata! [18:31:30] i love that guy [18:32:06] I am a fan of what he's doing :-) [18:34:48] bearND: I clarified this card: https://trello.com/c/3qXBHYOW/15-bring-back-suggestions-in-full-text-search [18:34:52] bearND: Does it look right to you? [18:36:14] Deskana: are we agreed regarding aligning lead images at 75% instead of 100% (i.e. all the way at the top)? [18:36:47] dbrant: Yes. Do you want to do that or shall I? I could probably slip that change in tonight [18:37:14] Deskana: looks great. Thank you! [18:38:07] mhurd: Got a few minutes? [18:38:13] Deskana: ya [18:38:20] Deskana: if you could slip it in, that'd be awesome [18:39:06] this is probably the coolest looking code i've written: find . -name '*.beta.less' -exec perl -pe "chomp if eof" -i {} + [18:39:20] (not the coolest, but the coolest looking) [18:39:28] i feel like it should go in a movie somewhere [18:39:54] perrrllll [18:40:29] (03PS9) 10Dbrant: [WIP] Widgets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175225 [18:41:25] phuedx: i saw a nice perl program on wikipedia http://upload.wikimedia.org/wikipedia/commons/9/9d/Papyrus_Ani_curs_hiero.jpg [18:41:46] joakino_: TROLL!!! [18:42:03] hehe [18:42:06] perl -pe "chomp if eof" -i /path/to/file is a lovely command [18:42:13] although [18:42:19] kristenlans: is he meeting in 20 minutes? [18:42:29] i could just configure vim to handle the existing line ending properly [18:42:32] I dunno, what do you think? [18:42:33] *file ending [18:42:42] joakino ^ [18:42:54] I'm about to send a claendar invite to hold it [18:43:11] oki [18:43:30] kristenlans: idk, jdlrobson has disappeared [18:43:44] joakino yeah would be kind of a fial without him ;-) [18:43:54] yep haha [18:44:07] phuedx: why do you want to remove my lovely c++ eof newlines [18:44:10] xd [18:47:02] kristenlans: love your event titles, very good use of ALLCAPS [18:47:21] joakino ty ;-) [18:48:13] 3Mobile-Web: Special:UserProfile should not use wfHttpError() for missing user parameters - https://phabricator.wikimedia.org/T86007#1015485 (10Krinkle) @Jdlrobson It is the status quo because outputting unstyled errors is not up to our standards. It lacks user experience (no navigation options, other than brows... [18:48:16] kristenlans: jon told me via watsapp that he can make it [18:48:30] cool, good back channeling ;-) [18:49:11] i'm gonna make sure i have my pitchforks ready [18:49:33] i'm here yeh [18:49:46] kristenlans: suggested title update: EXISTENTIAL EXTENSION QUESTIONS [18:49:58] joakino LOL, put down the pitchfork adn pick up the hot sauce [18:50:06] leila: kaldari i promise this is the last time i move that wikigrok meeting ;) [18:50:24] http://files.g4tv.com/ImageDb3/186569_S/Angry-Mob.jpg [18:50:31] feel free Maryana. as long as it doesn't have conflict with my other meetings. [18:50:34] phuedx: done [18:50:42] looks like i found an empty slot on your cal, leila [18:50:56] thanks and sorry for more calendar spam :) [18:51:54] i have to get george to bed tonight, but i'll try and make some of the meeting [18:52:15] having said that, it feels like i agree with rmoen and joakino_ [18:52:24] (03CR) 10Bgerstle: [C: 031] "code looks good to me. just needs to be tested across iOS versions in each view to check regressions. I only have iOS 8 devices on hand, b" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [18:52:26] phuedx: :( would be useful to have you there as you seem to be a good mediator [18:52:49] in fact i'd rather delay meeting if it means you are available [18:52:51] sorry guys I cannot make the meeting either. Though I would really like to be there [18:53:01] but i'm not as flexible as y'all at 7 pm [18:53:24] jdlrobso_: basically, i think this is a block of work that absolutely has to go through our process [18:53:26] proper [18:53:52] i actually think that good things will come out of splitting stuff up, but it'll take practice [18:53:57] BUT PROCESS PROCESS PROCESS PROCESS [18:54:20] 3Mobile-Web: Special:UserProfile should not use wfHttpError() for missing user parameters - https://phabricator.wikimedia.org/T86007#1015509 (10Jdlrobson) thanks for clarification @krinkle - is there any page documented how to do a 404 / 400 with correct styling. Special:UserProfile without parameters should nev... [18:54:23] which means delaying until we're past gatherllections mvp [18:54:27] phuedx: it's just a big headache [18:54:52] seems like we are making our lives more difficult at a crucial time. Making a mountain out of a molehill. I agree in principle but i wish this had happened over the xmas period [18:55:14] existensions [18:55:22] again "delaying until we're past gatherllections mvp" [18:55:25] right [18:55:25] brb [18:55:31] handover time [18:56:32] 3Mobile-Web: Mobile image viewer and back button behaviour - https://phabricator.wikimedia.org/T85636#1015518 (10Jdlrobson) [18:56:35] 3Mobile-Web: Cannot open the same image twice in mobile media viewer - https://phabricator.wikimedia.org/T88336#1015519 (10Jdlrobson) [18:56:51] side note: i wished componentized was recognized as word chrome and my chat client [18:56:59] 3Mobile-Web: Cannot open the same image twice in mobile media viewer - https://phabricator.wikimedia.org/T88336#1009607 (10Jdlrobson) [18:57:00] 3Mobile-Web: Mobile image viewer and back button behaviour - https://phabricator.wikimedia.org/T85636#951371 (10Jdlrobson) [18:57:15] kristenlans: i'm wary about having this meeting without the whole team there [18:57:45] jdlrobso_: well then it will have to wait until tomorrow if we want sam and joaquin around [18:58:03] jdlrobso_: does that work for your plans? [18:58:09] 3Mobile-Web: Special:UserProfile should not use wfHttpError() for missing user parameters - https://phabricator.wikimedia.org/T86007#1015535 (10Krinkle) @Jdlrobson I'm not sure what kind of documentation you're looking for. Output a page like any other and set the desired status code (if other than 200, which is... [18:58:33] your wifi situation tomorrow is unknown, correct jdlrobso_ ? [18:58:41] kristenlans: not reallly.. :-/ sigh. [18:59:15] tomorrow was going to be a wrap up day for me plus there is metrics meeting [18:59:50] jdlrobso_, rmoen, phuedx, bmansurov: meeting starting [19:00:08] kaldari: see conversation above. [19:00:10] kaldari: I can stay for about 10 mins [19:00:14] jdlrobso_: seems like this is the best we can do now [19:01:40] 3Mobile-Web: Special:UserProfile should not use wfHttpError() for missing user parameters - https://phabricator.wikimedia.org/T86007#1015554 (10Florian) a:3Florian [19:01:45] https://etherpad.wikimedia.org/p/existensions [19:03:46] (03PS1) 10Florianschmidtwelzow: SpecialUserProfile: Return Status code 404 when no user found [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188602 (https://phabricator.wikimedia.org/T86007) [19:04:43] (03PS2) 10Florianschmidtwelzow: SpecialUserProfile: Return Status code 404 when no user found [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188602 (https://phabricator.wikimedia.org/T86007) [19:09:03] (03PS2) 10Florianschmidtwelzow: Hygiene: Convert SkinMinerva* files to use Config object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188589 (https://phabricator.wikimedia.org/T87614) [19:10:13] dbrant bearND is GalleryCollectionFetchTask the class you're using to fetch image metadata? [19:10:16] (for the gallery) [19:11:13] bgerstle: that task is for fetching a list of all the images on the current page, and some minimal data about each image (e.g. mime type). [19:11:17] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Convert SkinMinerva* files to use Config object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188589 (https://phabricator.wikimedia.org/T87614) (owner: 10Florianschmidtwelzow) [19:11:29] bgerstle: GalleryItemFetchTask fetches all the other metadata. [19:11:34] ok [19:12:20] bgerstle: we could tecnhically fetch all of the metadata for all the items in GalleryCollectionFetchTask, but it would become a pretty huge payload. [19:14:39] right [19:18:01] bgerstle: quick hangout? [19:18:29] sure [19:21:09] (03PS3) 10Florianschmidtwelzow: Hygiene: Convert SkinMinerva* files to use Config object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188589 (https://phabricator.wikimedia.org/T87614) [19:22:07] bearND|brb: when you're rb, got a few minutes to discuss https://phabricator.wikimedia.org/T86982 ? trying to do some follow up on the scrum of scrums meeting [19:23:20] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Convert SkinMinerva* files to use Config object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188589 (https://phabricator.wikimedia.org/T87614) (owner: 10Florianschmidtwelzow) [19:25:51] lunch! [19:31:00] jdlrobso_: hi :) Shouldn't this be an "unbreak now"? *wondering* https://phabricator.wikimedia.org/T87290 [19:32:41] (03PS2) 10Deskana: Crop images to crop off more off the bottom of iamges, rather than centreing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186862 (https://phabricator.wikimedia.org/T87613) [19:33:10] (03CR) 10Jdlrobson: "After IRL discussion seems this can live here till next iteration." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 (owner: 10Bmansurov) [19:33:16] (03CR) 10Jdlrobson: "After IRL discussion seems this can live here till next iteration." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188424 (owner: 10Bmansurov) [19:33:23] dbrant: I think that does it, but honestly I'm a little fuzzy. [19:33:29] dbrant: I tested it and it seemed to be doing what I intended. [19:33:37] FlorianSW: supposedly it's not a big problem since it doesn't effect stable users - it's just an inconvenience [19:33:57] it wasn't very bad, no cursing, no pitchforks [19:34:03] dbrant: I rebased it while I was at it. [19:34:12] Deskana: looking [19:34:24] jdlrobso_: it doesn't effect stable users? I tested it just a minute before with commons and enwiki with both stable mode :/ [19:34:25] joakino: I was just thinkign the same thing [19:35:20] (03PS10) 10Dbrant: [WIP] Widgets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175225 [19:35:35] good conclusion [19:35:42] +1 would avoid the meeting again [19:35:46] i mean… [19:35:49] get george to bed [19:35:51] obvs [19:35:53] ;) [19:36:01] notes seem good [19:36:21] sorta felt like everyone was on the same page but needed a little pow wow [19:36:23] FlorianSW: but it doesn't break any workflows [19:36:33] only infobox editing makes save across sites [19:36:35] ok folks [19:36:38] g'night y'all [19:36:44] hmm, right :) [19:36:50] gn phuedx [19:36:54] gnight phuedx [19:38:28] night phuedx [19:40:08] (03CR) 10Jhernandez: [C: 032] Fix UploadTutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185850 (owner: 10Jdlrobson) [19:43:17] (03Merged) 10jenkins-bot: Fix UploadTutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185850 (owner: 10Jdlrobson) [19:43:58] FlorianSW: how was NY [19:44:21] joakino_: i will be in NY in June :) [19:44:33] oh, weren't you going after SF? [19:45:27] no :) a little break until the next journey :D [19:45:48] (03CR) 10MaxSem: [C: 04-1] "First, cursory, review pass inline. Please add a feature flag for this." (0327 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [19:46:29] FlorianSW: cool :), i saw your picture from china beach [19:47:29] MaxSem: eh? not putting it in a separate extension? [19:47:31] cool, it was great! :) You're back in Spain? [19:48:04] legoktm, try convincing that crowd yourself:P [19:48:25] (03CR) 10Legoktm: [C: 04-2] "This really needs to happen in a separate extension." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [19:49:04] FlorianSW: yep, still too cold, SF was better [19:49:09] legoktm: this is only temporary whilst we set up the extension [19:49:46] joakino_: we have snow and nearly -1°C :( [19:49:49] jdlrobso_: what do you mean by temporary? is the change going to be merged? or is it just up for review while a new repo is created? [19:49:53] * FlorianSW want's back to SD [19:49:55] *SF [19:50:01] i'd appreciate if you removed your -2 as we've just had 2 hours worth of discussion as a team around this and we just agreed to this. [19:50:32] legoktm: we don't know what we are building yet and how it fits into MobileFrontend and what infrastructure needs to change [19:50:47] already we've identified issues with existing code and hooking into the main menu on a stable/beta/alpha level [19:51:12] Is there a summary of that discussion publicly available for others to read? There's been numerous discussion on public lists about why this is a bad idea with very little response. [19:51:26] we've literally just had the meeting legoktm [19:51:32] there will be notes as soon as we can get them [19:51:45] we just need to get shit done. [19:51:59] the summary is right now we recognise that MobileFrontend has become too big and needs to be split up [19:52:15] and the solution is to stick more stuff into it? [19:52:19] but this is a mammoth task that we need to do incrementally [19:52:34] MaxSem: thanks for the review, helpful [19:52:46] MaxSem: what do you mean by "caps" on -> @return string Html [19:53:09] the standard is called "HTML" ;) [19:53:47] legoktm: What we just decided was to move WikiGrok out of MobileFrontend completely, and move Collections out of MobileFrontend as soon as it has moved from being purely an experiment to something we want to productize/move out of beta. [19:54:16] legoktm: etherpad notes are here: https://etherpad.wikimedia.org/p/existensions [19:54:44] MaxSem: noted! [19:55:17] legoktm: most folks agree with you that it doesn’t really belong in MobileFrontend, but the team working on it wants to move quickly with prototyping it as an experiment, and thus want to piggy-back on the MF extension for the time being. [19:56:32] legoktm: I’m not 100% happy with this solution, but it was the consensus of the mobile team meeting, FWIW. [19:56:50] ok, thanks for the context. I'm writing up a longer response on the patch right now. [19:57:36] legoktm: we'd rather do this properly for everything - skins/minerva, extension/NearbyPages extension/WikiGrok etc etc in one go [20:01:39] where did we decide on "in one go" part? :P [20:02:14] (03PS3) 10Dbrant: Crop images to crop off more off the bottom of images, rather than centreing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186862 (https://phabricator.wikimedia.org/T87613) (owner: 10Deskana) [20:02:33] Deskana: ^ ftfy :) feel free to merge yourself, if you like [20:02:36] gradle [20:02:37] (03CR) 10jenkins-bot: [V: 04-1] Crop images to crop off more off the bottom of images, rather than centreing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186862 (https://phabricator.wikimedia.org/T87613) (owner: 10Deskana) [20:02:42] bah, wrong window ;_) [20:02:42] ... or not [20:04:37] (03CR) 10MaxSem: [C: 04-1] POC: Collections storage (0317 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187616 (owner: 10Jdlrobson) [20:05:23] (03Abandoned) 10Jdlrobson: POC: Collections storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187616 (owner: 10Jdlrobson) [20:05:43] sorry i wasted your time with review MaxSem i hoped 'POC' was sufficient [20:06:23] (03CR) 10Legoktm: "Some more rationale for my -2:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [20:07:14] jdlrobso_: every time I see ‘POC’, I initially think it means ‘Piece of crap’ :) [20:07:24] that works too [20:07:25] :) [20:07:46] ideally i'd do this on github in my own fork [20:07:50] but we don't have that on gerrit :-. [20:08:27] gerrit supports sandbox branches, which are very similar [20:09:00] dbrant bearND|lunch where does the Api java class live? [20:09:08] i see the params you're sending, but i don't know where they're going [20:12:42] bgerstle: ah, that's actually a separate repo: https://gerrit.wikimedia.org/r/#/admin/projects/apps/android/java-mwapi [20:12:53] anyone willing to review https://gerrit.wikimedia.org/r/#/c/188424/ or https://gerrit.wikimedia.org/r/#/c/188271/ ? thanks [20:14:57] cool thanks :-) [20:16:32] darn what a crappy connection today [20:16:40] i'm heading out [20:18:44] (03CR) 10Bmansurov: [C: 031] SpecialUserProfile: Return Status code 404 when no user found [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188602 (https://phabricator.wikimedia.org/T86007) (owner: 10Florianschmidtwelzow) [20:24:56] gerrit is extremely slow at my end :( [20:25:00] why are the result indexes in this response negative? [20:25:03] https://en.wikipedia.org/wiki/Special:ApiSandbox#action=query&prop=imageinfo&format=json&iiprop=url%7Csize%7Cmime%7Cextmetadata&iiextmetadatalanguage=en&titles=Philip_Seymour_Hoffman&generator=images&gimlimit=15 [20:25:11] also… why aren't they just put into an array? [20:25:26] Maryana: thanks for setting priority on https://phabricator.wikimedia.org/T88473, I think it's more important than it looks at first sight. [20:25:34] lol bgerstle [20:25:52] i take it back [20:26:01] they're not indices.. i think [20:26:45] (03CR) 10Florianschmidtwelzow: [C: 04-1] Introduce Special:Collections page (0322 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [20:28:24] (03CR) 10Florianschmidtwelzow: "> Please add a feature flag for this. ++++++++!! :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [20:28:57] I read a line in EditorOverlayBase.js as 'click .back': 'onClickBack'(L 98), is this line responsible for attaching the handler onClickBack? [20:29:40] FlorianSW: thanks for the review, all help is really appreciated [20:29:53] joakino: np :) [20:30:52] (03CR) 10Krinkle: "MWException isn't specifically for checked or unchecked exceptions. It's just as generic as Exception." [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/184062 (owner: 10Ori.livneh) [20:30:57] (03PS1) 10Jdlrobson: Hygiene: Weaken special page selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188619 [20:31:04] FlorianSW: count in php arrays is not a constant operation? i would hope the length is internally cached on the array [20:32:36] mhurd got minute to hang out? [20:32:43] coreyfloyd: ya! [20:33:03] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Weaken special page selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188619 (owner: 10Jdlrobson) [20:33:20] joakino: ok, you got me, i'm not sure, i understand it, that count() really _counts_ the elements of an array: http://php.net/manual/de/function.count.php [20:33:45] (03CR) 10Krinkle: [C: 031] "You may wanna move setStatusCode() from showHtmlNoUser() to executeWhenAvailable(), next to the setPageTitle() for clarity – since setting" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188602 (https://phabricator.wikimedia.org/T86007) (owner: 10Florianschmidtwelzow) [20:34:27] MaxSem: ^^ (my message about count()), maybe you know more? :) [20:36:40] (03CR) 10Florianschmidtwelzow: "@Krinkle: I want to avoid code duplication, but you're right :/ Would you be more ok with a more meaningful function name? E.g. displayNot" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188602 (https://phabricator.wikimedia.org/T86007) (owner: 10Florianschmidtwelzow) [20:37:50] FlorianSW: http://stackoverflow.com/questions/4566314/php-what-is-the-complexity-i-e-o1-on-of-the-function-count [20:38:03] FlorianSW: it is an old question, but i would guess it still applies [20:38:39] MaxSem: dbrant is there a way to take the commons logo out of the image info response? [20:39:59] bgerstle: not at present. For the moment, I'm simply throwing away items that have a mimetype of "svg" or "png" [20:40:22] bgerstle: (unless the user explicitly clicks on an svg in the page) [20:40:36] (03CR) 10Krinkle: "@Florian: Sure. I'll defer to MobileFrontend maintainers further, though. Thanks :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188602 (https://phabricator.wikimedia.org/T86007) (owner: 10Florianschmidtwelzow) [20:41:12] joakino: ok, then i'm ok with it :) And, see: http://stackoverflow.com/questions/5835241/phps-count-o1-or-on-for-arrays So [20:42:19] FlorianSW: awesome, that answer is a lot more trustworthy [20:42:35] yeah, that i wanted to say before my disconnect :D [20:42:41] (03CR) 10Bmansurov: [C: 04-1] Alpha: Allow browsing of images in a page on mobile. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 (owner: 10Jdlrobson) [20:43:06] FlorianSW: i'll look into adding a method isEmpty for readability, because that if is used in a few places [20:43:16] to the model, that is [20:43:26] ok, great :) [20:44:41] (03PS3) 10Florianschmidtwelzow: SpecialUserProfile: Return Status code 404 when no user found [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188602 (https://phabricator.wikimedia.org/T86007) [20:46:04] mhurd: coreyfloyd dr0ptp4kt before I embark on this dangerous quest of fetching image metadata (now that I think i know how to get it) does anyone need code review? [20:46:32] bgerstle: nothing needed by me at the moment [20:49:38] bgerstle: the one thing i’d suggest when fetching image meta data is to hew as closely as you can to the way the other fetchers operate - not that the way they work is optimal, but so we can have a fairly consistent set of fetchers to deal with when we eventually refactor some of the fetching bits [20:53:56] chrismcmahon: sure thing :) i don't like breaking browser tests [20:54:20] alright i'm finally logging out [20:54:24] Maryana: I don't like breaking W3C web standards :-) [20:54:34] or that :) [20:54:59] mhurd gotchya [20:55:25] (03CR) 10Deskana: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186862 (https://phabricator.wikimedia.org/T87613) (owner: 10Deskana) [20:56:54] Deskana: ^ I was going to fix the checkstyle issues, but got sidetracked [20:57:02] 3Mobile-Web: Special:UserProfile should not use wfHttpError() for missing user parameters - https://phabricator.wikimedia.org/T86007#1015906 (10Jdlrobson) Hey @Krinkle I was merely hoping for some kind of php doc link to the relevant function. I don't like to assume volunteers know how to do this sort of thing s... [21:00:08] dbrant: It looked to me like actually it simply stalled. [21:01:04] kaldari: meetin' time [21:01:06] (03CR) 10MaxSem: Introduce Special:Collections page (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [21:02:02] dbrant: Oh, no, it didn't. I just didn't look properly. [21:02:11] dbrant: I'll fix the checkstyle, test and merge laster. [21:02:13] *later [21:02:26] Deskana: ok! [21:03:07] 3Mobile-Web: Page with collapsible sections contains divs with non-unique id values - https://phabricator.wikimedia.org/T88473#1015910 (10bmansurov) a:3bmansurov [21:03:07] maryana i see your icon but don't hear you [21:03:26] you just dropped off [21:04:39] 3Mobile-Web: Page with collapsible sections contains divs with non-unique id values - https://phabricator.wikimedia.org/T88473#1015912 (10Jdlrobson) 5Open>3Invalid I only see one... and the page validates. http://validator.w3.org/check?uri=http%3A%2F%2Fen.m.wikipedia.beta.wmflabs.org%2Fwiki%2FSelenium_sectio... [21:04:50] ^ bmansurov [21:04:56] chrismcmahon: ^ [21:05:50] oh wait i'm wrong [21:06:13] toc has one too [21:06:21] 3Mobile-Web: Page with collapsible sections contains divs with non-unique id values - https://phabricator.wikimedia.org/T88473#1015914 (10Jdlrobson) 5Invalid>3Open Oh wait, the validator won't run on stuff added via JS. Yes you are right it seems there are 2 versions of #collapsible-block-0 - table of conten... [21:07:32] (03CR) 10Jdlrobson: [C: 032] SpecialUserProfile: Return Status code 404 when no user found [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188602 (https://phabricator.wikimedia.org/T86007) (owner: 10Florianschmidtwelzow) [21:08:03] (03PS2) 10Jdlrobson: Hygiene: Weaken special page selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188619 [21:09:49] (03Merged) 10jenkins-bot: SpecialUserProfile: Return Status code 404 when no user found [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188602 (https://phabricator.wikimedia.org/T86007) (owner: 10Florianschmidtwelzow) [21:10:22] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Weaken special page selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188619 (owner: 10Jdlrobson) [21:12:11] 3Mobile-Web: Special:UserProfile should not use wfHttpError() for missing user parameters - https://phabricator.wikimedia.org/T86007#1015926 (10Jdlrobson) 5Open>3Resolved [21:14:43] (03PS9) 10Jdlrobson: Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 [21:17:15] (03PS1) 10Jdlrobson: Hygiene: ImageOverlay should use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188622 (https://phabricator.wikimedia.org/T88566) [21:17:42] (03PS2) 10Jdlrobson: Hygiene: ImageOverlay should use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188622 (https://phabricator.wikimedia.org/T88566) [21:18:17] jdlrobso_:I have a small question regarding T87192 [21:18:34] codezee: sure [21:18:38] A line in EditorOverlayBase.js as 'click .back': 'onClickBack'(L 98), is this line responsible for attaching the handler onClickBack? [21:18:46] exactly [21:18:56] also take a look at https://gerrit.wikimedia.org/r/188622 [21:19:07] essentially that says on the click event for anything matching the .back selector [21:19:10] run the callback onClickBack [21:19:14] alright then!, I've understood what I need to do [21:19:55] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: ImageOverlay should use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188622 (https://phabricator.wikimedia.org/T88566) (owner: 10Jdlrobson) [21:20:20] codezee: yeey :) [21:20:30] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188622 (https://phabricator.wikimedia.org/T88566) (owner: 10Jdlrobson) [21:21:20] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188619 (owner: 10Jdlrobson) [21:27:27] (03CR) 10Florianschmidtwelzow: [C: 032] Hygiene: ImageOverlay should use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188622 (https://phabricator.wikimedia.org/T88566) (owner: 10Jdlrobson) [21:29:00] jdlrobso_: also,we do not know the current object's(this) css-class, how should event be attached to that, using the above method? [21:30:02] css class? [21:30:37] codezee: "this" inside the callback will be the javascript class [21:30:45] if you need the element you can use ev.target [21:31:14] (03CR) 10MZMcBride: "What Lego said. This changeset is unacceptable." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [21:32:40] jdlrobso_: ok [21:33:37] (03CR) 10MaxSem: WIP: recording and applying user responses (0312 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [21:34:20] (03PS14) 10MaxSem: WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [21:36:36] (03CR) 10jenkins-bot: [V: 04-1] WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [21:38:22] FlorianSW: just a heads up i'm on vacation from friday am, and my code reviewing abilities might be somewhat restricted tomorrow (have non-developer duties) [21:38:38] so apologies in advance for not being able to review your stuff whilst gone :) [21:39:00] (03CR) 10MaxSem: "@jdlrobson: this is all bunched into mobileview to reduce the number of requests made per pageview." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 (owner: 10MaxSem) [21:39:13] jdlrobso_: no problem, enjoy your vacation! :) [21:43:19] (03CR) 10BearND: "There are some checkstyle issues, see https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/3513/checkstyleResu" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186862 (https://phabricator.wikimedia.org/T87613) (owner: 10Deskana) [21:44:15] bearND: Dan said he'll fix those later ;) [21:44:23] mhurd hangout part deux? [21:44:32] coreyfloyd: ya, just sec... [21:44:44] mhurd k ring me when ready [21:45:58] (03PS11) 10Dbrant: Widgets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175225 [21:46:03] (03CR) 10Brion VIBBER: [C: 04-2] "I have to agree this does not belong in MobileFrontend, especially since the project will presumably need a desktop UI as well. Make sure" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [21:48:53] (03PS1) 10Bmansurov: Make section IDs unique [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188672 (https://phabricator.wikimedia.org/T88473) [21:49:34] (03PS1) 10Sumit: Overlay,Panel,Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) [21:49:50] dbrant: yeah, just looked like he thought there was a Jenkins error dur to the "recheck" comment [21:49:51] (03CR) 10jenkins-bot: [V: 04-1] Overlay,Panel,Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [21:50:04] 3Mobile-Web, MobileFrontend-Feature-requests: Page with collapsible sections contains divs with non-unique id values - https://phabricator.wikimedia.org/T88473#1016027 (10Nemo_bis) [21:50:45] bearND: I did, but that was my fault for only briefly glancing at Jenkins' output. [21:50:50] Herp. [21:51:41] (03CR) 10jenkins-bot: [V: 04-1] Make section IDs unique [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188672 (https://phabricator.wikimedia.org/T88473) (owner: 10Bmansurov) [21:51:47] coreyfloyd: Regarding Crashlytics, Luis has asked me to speak to their privacy expert and let them check the terms of use of Crashlytics/Fabric. [21:51:58] coreyfloyd: Estimated timescale for their response is one or two weeks. [21:52:09] Deskana: that's cool. [21:52:53] (03CR) 10Alex Monk: [C: 04-2] "Does not belong in MobileFrontend." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [21:55:37] (03PS2) 10Sumit: Overlay,Panel,Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) [21:55:49] (03CR) 10jenkins-bot: [V: 04-1] Overlay,Panel,Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [21:55:55] Shall I give it a -2 as well? [21:56:04] I hear that's the cool thing to do now. [21:56:40] kicking it when it's down? :P [21:57:22] [[WP:STICK]] [21:57:40] Deskana: hehe [21:57:50] Also known as "Grab a stick and slowly approach the horse carcass so you can beat it" [21:57:59] (03PS3) 10Sumit: Overlay,Panel,Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) [21:58:11] (03CR) 10jenkins-bot: [V: 04-1] Overlay,Panel,Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [21:58:16] coreyfloyd: i’d recommend a quick hangout with brion if he comes online to chat about that issue [21:58:47] coreyfloyd: but let’s still sync up this afternoon [22:02:31] (03CR) 10Sumit: "will fix the jshint errors in next patch, do I also need to reposition the touchstart and touchmove events?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [22:03:22] (03PS2) 10Bmansurov: Make section IDs unique [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188672 (https://phabricator.wikimedia.org/T88473) [22:03:23] bearND: did you want to join the content-service meeting? [22:05:45] bearND: Ping! Coming to the service meeting? [22:06:00] mhurd, dbrant, dr0ptp4kt: http://etherpad.wikimedia.org/p/AppsContentService [22:06:11] Deskana: ouch. Thanks for the reminder [22:10:00] (03CR) 10Bartosz Dziewoński: [C: 04-2] "Dogpile!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [22:10:28] (03CR) 10Bartosz Dziewoński: "(Just kidding, just kidding. But Legoktm makes good points.)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [22:12:17] 3Mobile-Web: Closing mobile media viewer always scrolls to top on FF, IE - https://phabricator.wikimedia.org/T87156#1016080 (10bmansurov) a:3bmansurov [22:16:35] (03CR) 10Fjalapeno: "thanks for the feedback Brian - update coming." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [22:17:19] (03PS7) 10Fjalapeno: Implement Pull to Refresh for saved pages. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 [22:32:17] (03PS1) 10Bmansurov: Restore document scroll position after closing the overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188681 (https://phabricator.wikimedia.org/T87156) [22:33:58] oops dr0ptp4kt be right there... [22:34:36] Ah. [22:35:01] (03CR) 10Florianschmidtwelzow: [C: 04-1] Make section IDs unique (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188672 (https://phabricator.wikimedia.org/T88473) (owner: 10Bmansurov) [22:35:08] dr0ptp4kt: have you ever done that thing where you set up a meeting, and then don't invite the person you want to meet with? Well I just did that to you! [22:35:11] bgerstle: so um, you can configure a sane diff view in your gerrit preferences :) [22:35:45] bgerstle: Unified Diff instead of Side-by-side [22:36:46] (03CR) 10Bmansurov: Make section IDs unique (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188672 (https://phabricator.wikimedia.org/T88473) (owner: 10Bmansurov) [22:38:04] legoktm i tried it, and it looked awful [22:38:06] this looks much nicer [22:38:13] and doesn't involve 1 million tabs [22:38:19] heh [22:38:39] although, i still would like to see the comment threads [22:38:43] well, just be aware that we're planning on killing gitblit because it's terrible and goes down all the time [22:38:48] oh [22:39:00] * bgerstle continues waiting for diffusion [22:39:09] anyway, i'm out for a bit. bbl o/ [22:39:23] (03CR) 10Florianschmidtwelzow: "Hi Sumit! Nice to have you here! :D" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [22:40:39] (03CR) 10Florianschmidtwelzow: Make section IDs unique (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188672 (https://phabricator.wikimedia.org/T88473) (owner: 10Bmansurov) [22:41:30] I know, that we don't support older branches of MF, but this change would help third parties a lot and is really minor, can someone take a look? https://gerrit.wikimedia.org/r/#/c/188558/ [22:41:47] bmansurov, kaldari, rmoen, phuedx ^^ [22:42:01] (03CR) 10Bmansurov: [C: 04-1] "Also, I think you should show the loading icon while you're loading the next/prev image when a slider button is clicked." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 (owner: 10Jdlrobson) [22:43:50] (03CR) 10Bmansurov: Make section IDs unique (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188672 (https://phabricator.wikimedia.org/T88473) (owner: 10Bmansurov) [22:44:45] (03CR) 10Bmansurov: [C: 031] Regression: Fix upload overlay [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/188558 (https://bugzilla.wikimedia.org/71715) (owner: 10Florianschmidtwelzow) [22:46:16] (03CR) 10Florianschmidtwelzow: [C: 032] Make section IDs unique (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188672 (https://phabricator.wikimedia.org/T88473) (owner: 10Bmansurov) [22:46:40] 3Mobile-Web, MobileFrontend-Feature-requests: Page with collapsible sections contains divs with non-unique id values - https://phabricator.wikimedia.org/T88473#1016191 (10Florian) 5Open>3Resolved [22:47:39] Deskana: http://i.imgur.com/RSfhDpB.png [22:48:11] Deskana: ^ view it actual size… [22:48:18] this monitor is ridiculous [22:48:19] mhurd: That's... impressive. [22:48:24] mhurd: What size is it? [22:48:29] 30in [22:48:30] (03Merged) 10jenkins-bot: Make section IDs unique [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188672 (https://phabricator.wikimedia.org/T88473) (owner: 10Bmansurov) [22:49:27] Deskana: http://www.monoprice.com/Product?c_id=113&cp_id=11307&cs_id=1130703&p_id=10734&seq=1&format=2 [22:49:52] Whoa boy [22:50:11] Deskana: no need for multi-panel setup for sure :) [22:50:35] *feel so spoiled* [22:59:51] (03PS2) 10MaxSem: Add new thumbnailing parameters to mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 [23:00:41] (03CR) 10jenkins-bot: [V: 04-1] Add new thumbnailing parameters to mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 (owner: 10MaxSem) [23:01:42] Maryana, kristenlans: FYI: https://gerrit.wikimedia.org/r/#/c/187716/ [23:02:05] yeah. ugh. i saw. [23:02:16] (03CR) 10Mhurd: "Added comment." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 (owner: 10MaxSem) [23:02:45] kaldari maryana: was just staring at that page despairingly [23:02:51] (03CR) 10MaxSem: Add new thumbnailing parameters to mobileview (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 (owner: 10MaxSem) [23:03:11] Deskana reminder to beam me in to PM mtg if you guys have alrady started ;-) [23:03:20] (03PS3) 10MaxSem: Add new thumbnailing parameters to mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 [23:03:21] kristenlans: Yeah, we're working on it. [23:03:23] kristenlans: Sorry. [23:03:30] no worries :-) [23:03:52] dbrant|bbl: bearND: check it out: https://gerrit.wikimedia.org/r/#/c/188272/ :) [23:04:04] (03CR) 10jenkins-bot: [V: 04-1] Add new thumbnailing parameters to mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 (owner: 10MaxSem) [23:04:05] Maryana, kristenlans: oh well, maybe it’s for the best in the long run [23:04:45] MaxSem: very excited about the thumbsize patch! [23:07:56] mhurd: great! Do we need to change app code for that? Looks like not. But wanted to make sure. [23:08:31] bearND: when it goes live, we’ll need to change thumbsize to thumbwidth [23:09:00] mhurd: ah, i see. [23:09:04] (03PS4) 10MaxSem: Add new thumbnailing parameters to mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 [23:09:59] (03CR) 10jenkins-bot: [V: 04-1] Add new thumbnailing parameters to mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 (owner: 10MaxSem) [23:10:34] bearND|brb: when you do you’ll see the “obama” example from the trello card (https://trello.com/c/XaPEs6Jl/8-add-width-constrained-article-image-parameter-to-mobileview-api) will now result in 640 url instead of 512 url. This isn’t so dramatic, but on other images it is. [23:10:49] dbrant|bbl: ^ [23:13:05] Deskana: should we create a card for changing our lead image url “thumbsize” parameter to “thumbwidth” when https://gerrit.wikimedia.org/r/#/c/188272 goes live? [23:15:16] Maryana: So it looks like less than 1% are missing page-impression [23:15:24] phew. ok, good. [23:18:43] mhurd: Can you do that? You know the details better than I. Then we can review. [23:18:51] Deskana: ya [23:22:18] Deskana: https://trello.com/c/dEIhZm8D/873-change-our-article-fetcher-lead-image-url-thumbsize-parameter-to-thumbwidth-when-max-s-thumbsize-patch-goes-live at top of bug backlog [23:30:52] coreyfloyd: oh meeting’s over - ping me if you wanna chat [23:36:06] (03PS1) 10Bmansurov: Create the editor switcher buttons using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188695 (https://phabricator.wikimedia.org/T87051) [23:38:23] (03PS1) 10Kaldari: Turning off page-impression logging for now [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188699 [23:39:06] Deskana: quick hangout when you have 5-10 min to spare? [23:39:46] mhurd: Probably can't until 4:30pm. [23:40:14] Deskana: no worry - can wait, or chat tomorrow :) [23:41:01] (03PS5) 10MaxSem: Add new thumbnailing parameters to mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 [23:41:27] (03PS2) 10Kaldari: Turning off page-impression logging for now [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188699 [23:41:29] (03CR) 10BearND: Use Gradle BuildConfig to replace getPackageName calls (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188493 (owner: 10BearND) [23:41:40] (03CR) 10MaxSem: "Submitted https://gerrit.wikimedia.org/r/#/c/188694/ to address test failures." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 (owner: 10MaxSem) [23:42:41] (03CR) 10Bmansurov: [C: 032] Turning off page-impression logging for now [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188699 (owner: 10Kaldari) [23:43:15] (03CR) 10jenkins-bot: [V: 04-1] Add new thumbnailing parameters to mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 (owner: 10MaxSem) [23:44:31] (03PS2) 10BearND: Use Gradle BuildConfig to replace getPackageName calls [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188493 [23:47:14] (03CR) 10BearND: [C: 04-1] "Video playback doesn't work for me. Send you some logs via email." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) (owner: 10Dbrant) [23:47:32] kaldari: here is the code for creating the table that contains the unique (userToken,taskToken) pairs corresponding to sessions with no page-impression: http://www.codeshare.io/4V7V3 That table has 13,394 rows which means that many sessions don't have page-impression in test 3 [23:47:49] let me know if you spot a problem in the code or if you want to chat more about it [23:49:08] thanks. BTW, I wasn’t able to find any pattern in the entries that were missing page-impressions, but I rearranged the code a bit to make more unlikely that page-impression would not be recorded. [23:49:36] it’s still a mystery though :P [23:49:41] fire alarm in apartment… brb i hope... [23:55:42] back. by the time i got my shoes on and laptop packed the alarm stopped… in any case i have climing gear and could rappel down [23:56:34] (03Merged) 10jenkins-bot: Turning off page-impression logging for now [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188699 (owner: 10Kaldari)