[00:03:10] kaldari: not sure if it's related but there are events with more than one page-impression [00:05:11] bb in about an hour - dinner time [00:05:40] leila: yes, that might be related [00:06:13] yeah, kaldari. what worries me now is that some page-impressions move from one session to the other. :-\ [00:06:38] leila: Do they happen to have the same userToken as one of the events without a page-impression? [00:06:54] actually, we should count this. Is the number of sessions with more than one page-impression >= the number of sessions with no page-impression. [00:07:04] yes [00:07:05] (03PS6) 10MaxSem: Add new thumbnailing parameters to mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 [00:07:25] hokay. let me finish what I'm working on kaldari and look into this one. [00:07:30] be back in 15 min [00:07:51] (03CR) 10jenkins-bot: [V: 04-1] Add new thumbnailing parameters to mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 (owner: 10MaxSem) [00:15:16] Deskana: success on the search suggestions with prefix results :) [00:15:50] Deskana: they were getting blasted by the subsequent full text search [00:20:30] 3Wikipedia-App-Android-App: NPE crashes from android.webkit.WebViewDatabase.initDatabase - https://phabricator.wikimedia.org/T85653#1016546 (10bearND) ANDROID_VERSION=4.0.4 STACK_TRACE=java.lang.NullPointerException at android.webkit.WebViewDatabase.initDatabase(WebViewDatabase.java:231) at android.webkit.WebVie... [00:30:38] 3Wikipedia-App-Android-App: NPE crashes from android.webkit.WebViewDatabase.initDatabase - https://phabricator.wikimedia.org/T85653#1016590 (10bearND) Update upstream report at https://code.google.com/p/android/issues/detail?id=35204 Also see http://stackoverflow.com/questions/17478097/webview-crash-nullpointer... [00:30:56] 3Mobile-Web: 'Close' button does clear search criteria on the full-text Search Result page - https://phabricator.wikimedia.org/T88631#1016591 (10Etonkovidova) {F37385} [00:34:02] 3Services, Mobile-Web: Image-positioning service - https://phabricator.wikimedia.org/T88633#1016600 (10Maryana) 3NEW [00:38:21] dr0ptp4kt: btw did you see max’s thumbsize patch? https://gerrit.wikimedia.org/r/#/c/188272/ [00:38:28] (03CR) 10Jdlrobson: [C: 04-1] Overlay,Panel,Drawer made to use View##events (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [00:38:30] (03CR) 10Dr0ptp4kt: "Okay, readying to update the code. Thanks again for the feedback, @Fjalapeno!" (0321 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293 (owner: 10Dr0ptp4kt) [00:39:30] (03CR) 10Jdlrobson: Overlay,Panel,Drawer made to use View##events (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [00:40:03] mhurd_: no, but i do now. cool! MaxSem, thank you! [00:41:16] dr0ptp4kt: it looks pretty slick [00:41:28] kaldari: let me dig into it and get back to you [00:41:43] I need some time to write the queries and run them [00:41:55] (03PS15) 10MaxSem: WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [00:42:06] leila: sure [00:45:30] 3Wikipedia-App-Android-App: 'Similar pages' link produces 'This page does not exist' - https://phabricator.wikimedia.org/T88636#1016659 (10Etonkovidova) 3NEW [00:47:05] (03PS16) 10MaxSem: WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [00:47:55] mhurd_: Sweet! [00:49:12] 3Wikipedia-App-Android-App: 'Similar pages' link produces 'This page does not exist' - https://phabricator.wikimedia.org/T88636#1016677 (10Etonkovidova) {F37393} {F37395} [00:49:18] (03CR) 10Mhurd: "Added comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293 (owner: 10Dr0ptp4kt) [00:49:44] Deskana: readying patch [00:49:45] (03CR) 10Kaldari: [C: 04-1] "Still seeing bug. The problem seems to be that when it is looking at the ifAll options for a campaign in Campaign::isApplicableToPage(), i" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [00:50:38] 3Services, Mobile-Web: Image-positioning service - https://phabricator.wikimedia.org/T88633#1016679 (10Deskana) @gwicke @jdouglas @mobrovac Thoughts from you guys? Does this seem like a use case that a Node.js service and RESTBase could support? [00:53:55] Deskana: got a minute? [00:54:01] dr0ptp4kt: Sure do. [00:57:45] 3Services, Mobile-Web: Image-positioning service - https://phabricator.wikimedia.org/T88633#1016699 (10Jdouglas) Definitely! Let's put it in the hopper. Is there a way to designate this task as a backlog item for RESTBase, other than to just tag it as RESTBase? [00:59:42] 3Services, Mobile-Web: Image-positioning service - https://phabricator.wikimedia.org/T88633#1016713 (10Jdouglas) To answer my own question: yes. https://phabricator.wikimedia.org/project/board/833/ [01:02:04] bearND: dbrant|bbl do you guys know if it's possible to send a null-ish value (not the literal int 0) for a required int to event logging? our article fetching / response currently doesn't have that property, and adding that is backlogged [01:02:18] (i'm currently u sing the literal 0, but wondering if you have other recommendations) [01:03:35] dr0ptp4kt: which schema are you looking at? [01:04:40] dr0ptp4kt: i think it depends on how the int is interpreted [01:04:42] bearND: https://meta.wikimedia.org/w/index.php?title=Schema:MobileWikiAppShareAFact&oldid=10916168 [01:07:04] bearND: Deskana is okay with 0 if necessary, but if there's a better null-ish value to use, lemme know [01:08:51] dr0ptp4kt: i think 0 or -1 should be fine. I was just looking in our code to see what we're doing. [01:09:05] (03PS17) 10MaxSem: WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [01:09:12] kaldari, ^^ [01:09:41] dr0ptp4kt: we don't have a fallback value. we just get it from the page page response every time [01:11:40] (03PS4) 10Deskana: Crop images to crop off more off the bottom of images, rather than centreing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186862 (https://phabricator.wikimedia.org/T87613) [01:12:51] dr0ptp4kt: fyi, if you add "id|revision" to the prop paramater you get page id and rev ID inside the properties block [01:14:22] bearND: cool, thx [01:15:18] (03CR) 10Deskana: [C: 032] "Checkstyle errors fixed. Looks good! Thanks Dmitry." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186862 (https://phabricator.wikimedia.org/T87613) (owner: 10Deskana) [01:15:36] (03Merged) 10jenkins-bot: Crop images to crop off more off the bottom of images, rather than centreing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186862 (https://phabricator.wikimedia.org/T87613) (owner: 10Deskana) [01:15:43] bearND: the trick will be making it go to the storage layer nicely. but the api part should be pretty simple. [01:16:22] (03CR) 10Kaldari: [C: 04-1] "For some reason I'm not able to save articles now. The error I get is "Cls: Expected string or object"" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [01:16:54] 3Mobile-Web, Services: Image-positioning service - https://phabricator.wikimedia.org/T88633#1016791 (10Maryana) Additional use-case to consider: sometimes the lead image is really not appropriate as a banner image (think scary medical conditions you don't want to see close up). It would be great if this service... [01:18:47] (03PS18) 10MaxSem: WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [01:20:34] (03CR) 10Kaldari: [C: 04-1] WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [01:21:14] (03CR) 10Kaldari: "nevermind you found it first :)" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [01:27:47] MaxSem: What does ‘binary’ in the line “wgr_campaign varchar(60) binary NOT NULL,” do? [01:28:14] ensures a particular collation [01:28:40] i.e. "I know what I'm doing with encoding, don't do anything for me" [01:28:57] thanks [01:36:00] 3Mobile-Web, Services: Image-positioning service - https://phabricator.wikimedia.org/T88633#1016862 (10Mhurd) Ideas: As a thought exercise (regardless of where this data should/could live) assume images had a concept of a "focal area", comprised of a unit rectangle* and an optional article title (omitting lang... [01:42:39] (03PS12) 10Dbrant: Widgets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175225 [01:46:23] (03CR) 10Dbrant: [C: 032] Use Gradle BuildConfig to replace getPackageName calls [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188493 (owner: 10BearND) [01:51:16] (03CR) 10Kaldari: [C: 04-1] WIP: recording and applying user responses (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [01:51:54] Deskana: oh this screen is evil… the last couple hours just flew by… tempted to get one for my desk at the office ;) [01:54:50] (03PS1) 10Mhurd: Brought back search suggestions in efficent way. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188726 [01:56:38] (03Abandoned) 10Mhurd: Added WIKIGLYPH_X_CIRCLE to glyph font. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188242 (owner: 10Mhurd) [01:59:12] (03PS2) 10Mhurd: Brought back search suggestions in efficent way. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188726 [02:01:45] (03PS4) 10Yurik: Update ApiResult handling for mediawiki/core change I7b37295e [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/183608 (owner: 10Anomie) [02:03:08] (03CR) 10Mhurd: [C: 031] "This is way cool." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 (owner: 10MaxSem) [02:03:12] (03CR) 10MaxSem: [C: 032] Regression: Fix upload overlay [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/188558 (https://bugzilla.wikimedia.org/71715) (owner: 10Florianschmidtwelzow) [02:03:58] (03Merged) 10jenkins-bot: Regression: Fix upload overlay [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/188558 (https://bugzilla.wikimedia.org/71715) (owner: 10Florianschmidtwelzow) [02:05:12] (03CR) 10Yurik: [C: 032 V: 032] "@anomie, you missed a compile error - ApiResult was not declared in the namespace. PhpStorm is great for those. Fixed. Also, i removed bac" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/183608 (owner: 10Anomie) [02:07:17] (03CR) 10jenkins-bot: [V: 04-1] Update ApiResult handling for mediawiki/core change I7b37295e [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/183608 (owner: 10Anomie) [02:07:28] (03CR) 10Dbrant: "@BearND, hmm very curious... All of the videos you linked in your email are working correctly on my Galaxy S3 (4.4) and Galaxy S4 (4.3), a" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) (owner: 10Dbrant) [02:15:12] 3Wikipedia-App-Android-App: Crop images to focus the top, rather than the centre - https://phabricator.wikimedia.org/T87613#1016926 (10Deskana) 5Open>3Resolved a:3Deskana [02:29:47] 3Wikipedia-App-Android-App, Multimedia, MediaWiki-extensions-CommonsMetadata: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#1016961 (10Tgr) [02:46:07] (03CR) 10Yurik: "recheck" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/183608 (owner: 10Anomie) [02:58:51] (03CR) 10Mhurd: "Added a couple comments. Apologies in advance for taking so long." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [03:01:09] (03CR) 10Yurik: "recheck" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/183608 (owner: 10Anomie) [03:01:19] (03CR) 10Yurik: [C: 032] Update ApiResult handling for mediawiki/core change I7b37295e [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/183608 (owner: 10Anomie) [03:02:06] coreyfloyd: hey sorry for the late comments - just wanted to double-check there isn’t a simpler way to handle some of the refreshiness bits [03:04:05] (03CR) 10jenkins-bot: [V: 04-1] Update ApiResult handling for mediawiki/core change I7b37295e [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/183608 (owner: 10Anomie) [03:15:33] (03CR) 10Yurik: "recheck" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/183608 (owner: 10Anomie) [03:17:06] (03CR) 10Yurik: Update ApiResult handling for mediawiki/core change I7b37295e [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/183608 (owner: 10Anomie) [03:17:14] (03CR) 10Yurik: [C: 032] Update ApiResult handling for mediawiki/core change I7b37295e [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/183608 (owner: 10Anomie) [03:18:12] (03Merged) 10jenkins-bot: Update ApiResult handling for mediawiki/core change I7b37295e [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/183608 (owner: 10Anomie) [03:38:00] (03CR) 10Mhurd: "Clarified previous comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [04:10:49] (03Abandoned) 10Krinkle: Sample commit for Jenkins [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/187532 (owner: 10Krinkle) [04:33:54] 3Wikipedia-App-Android-App, MediaWiki-extensions-PageImages, Wikipedia-App-iOS-App: PageImages shouldn't return images that are way below the fold - https://phabricator.wikimedia.org/T87336#1017078 (10Deskana) >>! In T87336#1012082, @bd808 wrote: > "Below the fold" is something that can really only be determined... [04:54:45] 3Wikipedia-App-iOS-App, Continuous-Integration: phplint shouldn't run on apps/ios/wikipedia repository - https://phabricator.wikimedia.org/T88653#1017082 (10Deskana) 3NEW [04:55:32] 3Wikipedia-App-iOS-App, Continuous-Integration: phplint shouldn't run on apps/ios/wikipedia repository - https://phabricator.wikimedia.org/T88653#1017089 (10Deskana) p:5Triage>3Low Speculatively marking as low priority since it's not blocking anything. Feel free to reprioritise. [05:00:55] 3Wikipedia-App-iOS-App, Continuous-Integration: phplint shouldn't run on apps/ios/wikipedia repository - https://phabricator.wikimedia.org/T88653#1017092 (10Legoktm) I see php files? https://github.com/wikimedia/apps-ios-wikipedia/search?l=php&q=php&utf8=%E2%9C%93 [05:03:51] mhurd_: You here? [05:04:03] Deskana: ya! [05:04:21] mhurd_: Do you happen to know if these two scripts are still used? https://github.com/wikimedia/apps-ios-wikipedia/search?l=php&q=php&utf8=%E2%9C%93 [05:05:30] Deskana: i think so? i believe brion wrote those to wrangle incoming translations [05:06:47] mhurd_: Okie doke. [05:08:00] Deskana: i added a big ole comment here: https://phabricator.wikimedia.org/T88633#1016862 if you want to take a peek… i hope it’s not too rambling... [05:13:47] 3Services, Mobile-Web: Image-positioning service - https://phabricator.wikimedia.org/T88633#1017106 (10GWicke) I see several requirements here: - some service or library for face detection / other alignment inference - a place to store image positions, in a way that - is updated if images are re-uploaded - m... [05:14:23] mhurd_: Not at all. Looks pretty nice. [05:14:46] Deskana: cool! if you fresh it i just tightened it up a bit more [05:14:56] *re-fresh* [05:15:04] lol [05:15:38] mhurd_: I'll re-refresh. ;-) [05:15:58] mhurd_: This kind of stuff will come in handy whenever the person working on it (probably Max, I guess?) starts hacking. [05:16:06] ya! [05:16:29] 3Wikipedia-App-iOS-App, Continuous-Integration: phplint shouldn't run on apps/ios/wikipedia repository - https://phabricator.wikimedia.org/T88653#1017112 (10Deskana) >>! In T88653#1017092, @Legoktm wrote: > I see php files? https://github.com/wikimedia/apps-ios-wikipedia/search?l=php&q=php&utf8=%E2%9C%93 Fair p... [05:21:19] Deskana: signing off… this monitor is a total time vortex… highly recommended [05:21:25] mhurd_: Haha :-p [05:21:32] mhurd_: See you later! [05:21:36] see ya tomorrow! [06:40:38] (03CR) 10Florianschmidtwelzow: [C: 031] Restore document scroll position after closing the overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188681 (https://phabricator.wikimedia.org/T87156) (owner: 10Bmansurov) [06:41:56] (03CR) 10Florianschmidtwelzow: "any updates? :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (https://phabricator.wikimedia.org/T87050) (owner: 10Robmoen) [08:32:01] 3Wikipedia-App-iOS-App, Continuous-Integration: phplint shouldn't run on apps/ios/wikipedia repository - https://phabricator.wikimedia.org/T88653#1017339 (10hashar) One can configure Zuul to only trigger apps-ios-wikipedia-phplint when a php file has been changed. In integration/config.git zuul/layout.yaml: ```... [08:37:28] good morning [08:52:56] 3MobileFrontend-Feature-requests, MediaWiki-Special-pages, Mobile-Web: Special:UserProfile shouldn't live in MobileFrontend - https://phabricator.wikimedia.org/T85929#1017367 (10Nemo_bis) p:5Triage>3Normal [12:17:00] (03PS1) 10Jhernandez: Fix less specificity for content and headers in special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188792 [12:23:49] (03CR) 10Florianschmidtwelzow: "dup of I908bf7f7e7a2f0c0306bc6df0c9b765ead2430c1" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188792 (owner: 10Jhernandez) [12:25:28] (03Abandoned) 10Jhernandez: Fix less specificity for content and headers in special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188792 (owner: 10Jhernandez) [12:26:29] (03PS3) 10Jhernandez: Hygiene: Weaken special page selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188619 (owner: 10Jdlrobson) [12:27:44] (03CR) 10Jhernandez: [C: 031] "Just fixed the syntax error. It's +2, florian if you +1 it i'll merge it" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188619 (owner: 10Jdlrobson) [12:29:36] (03CR) 10Florianschmidtwelzow: [C: 032] "Why just +1 :D" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188619 (owner: 10Jdlrobson) [12:30:51] (03CR) 10Jhernandez: "WOHOOO :D, awesome!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188619 (owner: 10Jdlrobson) [12:37:37] (03Merged) 10jenkins-bot: Hygiene: Weaken special page selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188619 (owner: 10Jdlrobson) [12:40:02] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188589 (https://phabricator.wikimedia.org/T87614) (owner: 10Florianschmidtwelzow) [12:59:58] (03Abandoned) 10Jhernandez: Link to page in title of collection item [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188260 (owner: 10Robmoen) [13:11:33] (03Abandoned) 10Jhernandez: Introduce Special:Collections page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187716 (owner: 10Jhernandez) [13:12:39] (03Abandoned) 10Jhernandez: WIP [DO NOT MERGE] Introduce Collections item on menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187717 (owner: 10Jhernandez) [13:15:39] (03Abandoned) 10Jhernandez: Watchlist lives at Special:Collections/user/0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188258 (owner: 10Robmoen) [13:21:55] (03CR) 10JanZerebecki: "> As for error logging, why would you be less interested in PHP Exceptions than MWExceptions?" [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/184062 (owner: 10Ori.livneh) [13:35:56] (03Abandoned) 10Jhernandez: Add arrow icon to read more in the collections view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188368 (owner: 10Jhernandez) [13:45:45] yowza [13:45:51] hey phuedx [13:45:55] good afternoon [13:46:33] hey joakino [13:46:34] how're you? [13:46:52] pff not very well [13:47:34] between the collections drama and my cat slowly dying it's not been a good week [13:48:00] :( [13:57:25] phuedx: there was collections drama? [13:57:49] jein [13:57:56] YuviPanda: depends on who you ask [13:58:02] i feel bummed [13:58:26] YuviPanda: https://gerrit.wikimedia.org/r/#/c/187716/10 this started it [13:58:36] oh [13:58:41] * YuviPanda reads mobile-tech [13:59:19] the collections work re-invigorated chats about how we organise our code and as a team around our code [13:59:26] it got a little… interesting [14:01:46] sultanas soaked in lime juice [14:01:49] this is my jam [14:01:54] wow [14:01:59] that's a lot of drama, yeah [14:03:42] with a good outcome [14:03:48] we made a decision! [14:03:58] hashtagpositive [14:06:39] YuviPanda: phuedx: still bums me, 6 -2s, not a fucking positive thing, and the project is already getting a lot of shit in both email chains, talk page in mediawiki, and code stuff [14:06:56] 6 -2s? [14:07:17] wait… there are two email chains? [14:07:25] max lego brion alex mzmcbride(not-2butcommentis-2) bartosz [14:07:26] * phuedx looks at his email again [14:07:55] phuedx: not 2 email chains, sorry, i meant in all mediums: email, talk, and code [14:08:01] me no ingles [14:08:54] * YuviPanda hugs joakino and phuedx and other folks on the chain [14:09:20] fwiw, this seems to be mostly a "What broke the camel's back" than anything particularly against Collections/Gather [14:09:32] first project to start in wikimedia, get the real deal everywhere [14:09:53] YuviPanda: i can see that [14:10:07] anyway [14:10:18] we'll find a way to get shit done somehow [14:10:19] joakino: current situation *is* frustrating, yeah. [14:11:08] ah, i've just checked my labels in gmal [14:11:10] *gmail [14:11:11] ah [14:12:27] i'm going to have lunch [14:12:36] it is already 3pm, damn [14:25:55] 3MobileFrontend: [Tracking] Obstacles to enable anonymous editing for MobileFrontend users - https://phabricator.wikimedia.org/T55069#1017938 (10Nemo_bis) The two current open blockers, T87644 and T87508, are felt as very important for feature parity by users; but they don't cancel the benefits of unregistered e... [14:48:02] 3Mobile-Web, MobileFrontend: Remove mobile editing "call to registration" CTA - https://phabricator.wikimedia.org/T87508#1017952 (10Florian) > goes away by itself after some seconds I'm not really comfortable with this, because of 2 things: # it isn't the behavior on desktop (ok, that would be acceptable) # we... [14:53:40] (03PS1) 10Phuedx: Promote alpha page styles to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 [14:56:04] joakino: recommendation for the day: chillwave: https://soundcloud.com/stumbleineuk/sets/spiderwebbed-1 [15:09:26] 3Mobile-Web, MobileFrontend: Remove mobile editing "call to registration" CTA - https://phabricator.wikimedia.org/T87508#1017975 (10phuedx) > Thanks. Point (2) still is to be implemented. You're right. With your approval I'd like to break point 2 out into its own user story where we can discuss it without it be... [15:15:10] hey jdlrobson [15:15:19] hey hey [15:16:53] phuedx: my portuespanolcais came in useful already [15:17:06] i managed to get to the hotel! [15:17:11] ! [15:17:13] despite getting on the wrong bus! [15:17:16] success! [15:17:36] i need coffee now [15:18:41] and $$$ [15:22:08] i also need coffee [15:25:16] joakino: you around [15:30:50] he can't get you coffee [15:34:13] jdlrobson: i really like abandoning patches now [15:34:19] it makes my gerrit clean! [15:34:43] phuedx: EXACTLY! [15:34:49] i wish it wasn't called abandon [15:34:56] it seems to have this stigma associated with it [15:34:58] abandoning is a good thing [15:35:05] it basically means "put on ice" [15:36:16] yup [15:36:35] "throw caution to the wind" would be a bit long [15:36:40] "give up change" [15:36:43] "despair" [15:36:51] "release" [15:41:53] "relinquish" :P [15:43:06] codezee: nice [15:43:27] thanks :) [15:44:56] (03CR) 10Florianschmidtwelzow: Promote alpha page styles to beta (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 (owner: 10Phuedx) [15:46:57] (03CR) 10Phuedx: [C: 04-2] "This change needs to be reviewed by KHammerstein for merging." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 (owner: 10Phuedx) [15:47:15] when did -2s get so popular in MobileFrontend ;-) [15:47:49] phuedx: can we do banner image in beta? [15:47:57] the api requests it makes tell me know [15:47:59] *no [15:48:07] self -2s are fine [15:48:20] phuedx: yeh jokes about that but seriousness about the banner image [15:48:24] it could cripple our api [15:48:39] hrrmmph [15:49:51] i'll take a look, if not then i'll roll the promotion back [15:54:33] phuedx: roger. okay stepping out for a while. back in just under 2 hrs [15:54:43] hf [16:45:04] dang missed jdlrobson [16:49:56] joakino: my computer just crashed… HARD. and i just installed firefox [16:50:04] i'm laying all the blame on you [16:50:06] xD [16:50:16] i expect a formal, written apology for making me wait 5 minutes for my computer to reboot [16:50:18] bgerstle: yosemite is shit [16:50:30] oh sure, blame it on the OS [16:50:49] if your computer takes 5 minutes to boot [16:50:50] haha [16:50:56] i'm going to blame it on the os [16:51:09] seriously though, 5 minutes? [16:51:13] wait… [16:51:14] phuedx no [16:51:23] i've just rebooted [16:51:25] ;) [16:51:25] well, it reboots quickly enough, then tries to relaunch everything it thought was running [16:51:32] ah [16:51:56] i run 4 apps [16:52:03] one of them i really should stop running [16:52:05] (chrome) [16:52:11] (but now i don't want to) [16:52:32] phuedx: i'm going to give firefox another chance [16:52:42] you're too forgiving [16:52:54] if my mac drops another brick i'm switching back [16:53:03] it was painless enough moving over [16:53:14] auto-import history etc, install 1password extension, good to go [16:55:13] * phuedx takes a deep breath [16:57:38] * phuedx gets firefox developer edition [17:09:29] 3Mobile-Web: 'Close' button does clear search criteria on the full-text Search Result page - https://phabricator.wikimedia.org/T88631#1018284 (10Florian) Related: T73203 I think it should be a "back" button (arrow), this X isn't intended to clear the search string :) What says #Design ? [17:11:21] 3Mobile-Web: Talk overlays should use View##events - https://phabricator.wikimedia.org/T88564#1018304 (10Florian) a:3Florian [17:16:54] phuedx: do you know how adding icons works? [17:17:35] hm… wikipedia is taking WAY too long to load (on firefox) [17:17:44] hrm, unable to connect [17:17:44] weird [17:18:13] bgerstle: see #wikimedia-operations [17:18:37] something happening right now? [17:18:50] switch outage in a dc [17:18:54] \o/ [17:19:00] *power outage [17:19:14] joakino: ? [17:19:41] joakino: like adding them to resources.php? [17:19:53] time for lunch then [17:20:13] phuedx: wait, i'll come up with a concrete example [17:20:25] bgerstle: going to do the porridge + caramelised bananas for my fam on saturday [17:20:29] i am very excited [17:20:34] i shouldn't be nearly this excited [17:20:36] but i am [17:21:17] can events map be used on self like 'click':'showDrawer' in Drawer.js? [17:21:19] mediawiki.org is down? [17:21:30] codezee: yess [17:21:34] joakino: while you do, i'm going out to get some biscuits [17:21:38] codezee: yes :) [17:21:38] that binds click to the $el [17:21:49] joakino: see my comments from about 5 minutes ago ;) [17:21:53] joakino: thanks! I was stuck, because of this [17:23:50] holy shit [17:23:51] phuedx, joakino: new on MobileFrontend but enjoying :) [17:24:02] so, if i hit "api" right now w/ &format=json [17:24:09] i get the same HTML dump as the browser [17:24:29] codezee: welcome [17:24:33] i'm 70% sure this will break the app [17:24:34] brb [17:24:45] bgerstle: url or it didn't happen [17:25:03] curl https://en.m.wikipedia.org/w/api.php\?action\=query\&prop\=imageinfo\&format\=json\&generator\=images\&gimlimit\=30\&iiprop\=url%7Cextmetadata%7Csize\&titles\=wikipedia.org%3Aen%3APhilip%20Seymour%20Hoffman\&continue\=foo [17:25:27] codezee: have you contributed to wikimedia projects before? [17:26:23] ohai brion [17:26:57] joakino: I've contributed to wikimedia core a few patches, but not many [17:27:05] 3MobileFrontend, MediaWiki-Vagrant: MobileFrontend vagrant role forces EventLogging on, breaks VisualEditor - https://phabricator.wikimedia.org/T88698#1018337 (10brion) 3NEW [17:27:10] oh, well we handle it (somehow) gracefully [17:27:13] codezee: cool :D [17:27:30] phuedx at least the status is 503 [17:27:32] so it won't break the app [17:27:38] but still, there's NO reason to send all that HTML [17:27:56] 3MobileFrontend, MediaWiki-Vagrant: MobileFrontend vagrant role forces EventLogging on, breaks VisualEditor - https://phabricator.wikimedia.org/T88698#1018345 (10brion) [17:28:00] howdy [17:28:21] joakino: basically after getting along with core, I was looking for something specific to work on, jdlrobson helped me here, and now I'm finding this interesting [17:28:52] bgerstle, you can't really expect to get JSON back right now [17:28:56] codezee: awesome, we need more contributors! [17:29:05] codezee: where are you from [17:29:14] api clients must be able to handle this [17:29:27] joakino: I'm from India [17:29:55] Krenair: why? [17:30:00] just curious [17:30:05] bgerstle: ah are we getting html error pages from the api? [17:30:09] yes [17:30:09] codezee: cool, i'm from spain! [17:30:11] hopefully it’s at least coming with a proper http response code [17:30:11] (03PS1) 10Cmcmahon: QA: update gems for latest mediawiki_selenium [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188836 [17:30:14] because web servers and proxies etc. can return errors like this [17:30:20] Krenair: the Android app is handling it by saying "no network connection"... [17:30:25] indeed [17:30:28] krenair i would expect to get next to nothing w/ a 503 [17:30:31] it used to crash, however dbrant [17:30:40] dbrant: hm, interesting [17:30:49] i think when the actual php servers handle an error in api it gives you a json back, but this shut off communication from the frontend web caches [17:30:53] joakino: nice to get acquainted :) [17:30:56] which might not be smart enough to serve a json error page :D [17:31:09] or at least certain functions did crash [17:31:16] that can probably be overridden though somehow… [17:31:17] brion so everything is failing because our cache died? [17:31:23] we don't just… go around the cache if it fails? [17:31:46] bgerstle: oh god no, that would overload the application servers instantly :D [17:31:53] lol [17:32:13] (03CR) 10jenkins-bot: [V: 04-1] QA: update gems for latest mediawiki_selenium [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188836 (owner: 10Cmcmahon) [17:32:20] we can't even serve a subset of the requests and do something like a "server busy" response? [17:32:20] it’s a delicate ecosystem…. like the rainforest :D [17:32:31] that should be possible though yeah [17:32:44] ^ is this another "it works in practice" thing? [17:32:46] ;) [17:33:09] codezee: i'm based in the uk, so you, joakino, and i will have a good amount of overlap :) [17:33:49] * dbrant tests the app vigorously during this unique opportunity ;) [17:34:02] phuedx, codezee and i'm in the middle :D [17:35:08] dbrant, bgerstle: i'm a big fan of mitmproxy for doing that sort of thing [17:35:16] FlorianSW: \o/ [17:35:28] FlorianSW: hi! [17:36:16] hi :P [17:36:32] phuedx: nice to meet you too! [17:41:21] hey all \o [17:41:36] hey jdlrobson, you left MIA just in time. rained earlier today [17:41:39] been grey all day [17:41:52] i'm sweating buckets [17:42:07] hi jdlrobson :) [17:42:29] hey FlorianSW [17:42:37] last few hours of me for a while ;-) [17:42:54] codezee: likewise :) [17:43:26] codezee: if you've got any questions, then just shout out :) [17:43:38] jdlrobson: last few patch reviews? owner:bmansurov [17:43:55] * jdlrobson looks [17:43:56] jdlrobson: first thought: great, that you have vacation, enjoy it!; second thought: WE WILL MISS YOU! [17:44:46] phuedx: alright, I'll remember [17:44:55] you'll be fine... you won't miss my -1s :-P and i'm come back and be all grumpy again. Make me happy and get the bear grillz patch merged :D [17:45:15] (03CR) 10Jdlrobson: [C: 032] QA: update gems for latest mediawiki_selenium [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188836 (owner: 10Cmcmahon) [17:46:08] have a good time jdlrobson [17:46:11] can someone give me another IP address to hit for wikipedia/api that's up? [17:46:14] (03CR) 10jenkins-bot: [V: 04-1] QA: update gems for latest mediawiki_selenium [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188836 (owner: 10Cmcmahon) [17:46:17] 208.80.154.224 keeps 503-ing [17:46:28] jdlrobson: third thought: AREN'T YOU ON HOLIDAY ALREADY!? GET OFF OF IRC! [17:46:41] phuedx: have my foot in the sea [17:47:00] this has been in the back of my head for a while: [17:47:06] holiday-bot [17:47:24] it shouts "NO! HOLIDAY! NO! HOLIDAY!" [17:47:25] JonKatz: stando? [17:47:36] phuedx: do it :D [17:47:42] at users who are registered as being on holiday [17:47:59] scans gcals and maps emails to irc nicks mebs [17:48:14] i think it'd be useful [17:48:19] looks like we're back [17:48:33] dbrant indeed we are [17:48:34] thanks [17:48:42] \o/ [17:50:05] dr0ptp4kt: now it should be working. do you want to reinstate the meeting with moiz? [17:53:34] bearND: i setup a new meeting for 10. i just saw moiz in person and told him we'll still meet at 10 [17:54:13] dr0ptp4kt: great. looking forward to your deom [17:54:15] demo [18:01:02] 3Mobile-Web: VisualEditorOverlay toggle between wikitext and visual editor should use OO.ui.PopupToolGroup - https://phabricator.wikimedia.org/T87051#1018430 (10bmansurov) a:3bmansurov [18:09:05] kristenlans: we are going to the prioritization meeting [18:09:49] ? [18:10:40] joakino: which room do you want to be in [18:10:52] jdlrobson: whatever [18:10:53] standup room or the estimation/prioritisation one ? :) [18:10:57] i'm in both lolz [18:11:00] xD [18:11:17] (03CR) 10Kaldari: [C: 032] QA: update gems for latest mediawiki_selenium [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188836 (owner: 10Cmcmahon) [18:11:23] I think Im in prioritization room [18:12:14] (03Merged) 10jenkins-bot: QA: update gems for latest mediawiki_selenium [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188836 (owner: 10Cmcmahon) [18:12:38] jdlrobson rmoen: we are here https://plus.google.com/hangouts/_/wikimedia.org/hold?authuser=0 [18:13:23] (03CR) 10Kaldari: WIP: recording and applying user responses (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [18:18:02] (03CR) 10Fjalapeno: "Thanks mhurd - posted some responses - catch you when you get in." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [18:18:14] kaldari: i'm not in the wmf-deployment gerrit group yet [18:18:17] (which i've asked for) [18:18:28] so i can't +2 yer change [18:20:51] (03PS1) 10Florianschmidtwelzow: Hygiene: Use events map in talk feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) [18:23:49] phuedx: that’s OK, usually best to let the SWAT deployer +2 config changes, but the +1 is useful since it’s such a complicated config. We should get you in that gerrit group though... [18:24:26] kaldari: looking at the labels for P364, are we sure that it'll display as "Original language"? [18:24:28] https://www.wikidata.org/w/api.php?action=wbgetentities&ids=P364 [18:25:05] english label is 'original language of this work' [18:26:23] ack, you’re right [18:26:55] (03CR) 10Bmansurov: [C: 032] Hygiene: Convert SkinMinerva* files to use Config object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188589 (https://phabricator.wikimedia.org/T87614) (owner: 10Florianschmidtwelzow) [18:28:03] (03Merged) 10jenkins-bot: Hygiene: Convert SkinMinerva* files to use Config object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188589 (https://phabricator.wikimedia.org/T87614) (owner: 10Florianschmidtwelzow) [18:28:25] phuedx: so much for that idea :P [18:28:42] (03CR) 10Deskana: "This was intended to be a really quick onboarding task and it seems to be taking longer than we would've expected based on the estimate." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [18:29:10] i +1'd it thinking "sure. that's really nice" and then double checked while trying to set up a test [18:35:34] (03CR) 10Bmansurov: Hygiene: Use events map in talk feature (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [18:36:11] (03CR) 10Mhurd: "Added comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [18:42:36] (03CR) 10Fjalapeno: "Actually already working on my next task - this has just been in review for a while while going back and forth on UI tweaks." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [18:43:25] kaldari: phuedx can you guys review some of my patches? thanks [18:45:39] bmansurov: will do [18:47:04] bmansurov: now that that've been unblocked, yes we can [18:47:16] thanks guys [18:51:46] *they've [19:13:00] FlorianSW: touchstart and touchmove in Overlay.js are related events, should they be handled separately?(T87192) [19:18:28] codezee: you mean? they do different things, so they should be handeld seperately :) [19:18:34] or do you mean in a seperate change? [19:20:16] FlorianSW: currently touchstart and touchmove are defined in postRender, one after another, because touchmove uses value startX initialized by touchstart [19:21:02] FlorianSW: *startY [19:21:11] FlorianSW: moving them to separate handlers would require defining startY outside the two handlers [19:21:25] codezee: that order doesn't matter :) You can change the order and it would work, too. [19:21:55] the var is defined when the event is triggered, and touchstart is before touchmove :) [19:22:57] FlorianSW: the problem with separate events is that var startY would need to be defined outside any function, due to scope restrictions [19:24:18] codezee: just use this.startY :) [19:24:30] FlorianSW: ok, thanks! [19:24:49] so the var is set as a class variable :) [19:25:30] FlorianSW: exactly, that needs to be done, but I wasn't sure enough if that was a good practice [19:27:06] (03CR) 10Phuedx: [C: 032] "Tested in Chrome (40.0.2214.94), Firefox Developer Edition (37.0a2), IE9, and IE10." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188681 (https://phabricator.wikimedia.org/T87156) (owner: 10Bmansurov) [19:28:05] (03Merged) 10jenkins-bot: Restore document scroll position after closing the overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188681 (https://phabricator.wikimedia.org/T87156) (owner: 10Bmansurov) [19:28:25] codezee: that's ok and the easiest way here :) If we find a better solution sometimes, we can revisit it. [19:29:47] FlorianSW: alright :) [19:30:42] 3Mobile-Web: Closing mobile media viewer always scrolls to top on FF, IE - https://phabricator.wikimedia.org/T87156#1018836 (10bmansurov) 5Open>3Resolved [19:34:03] bmansurov: I’m reviewing the WikiGrok Roulette info screen patch, but I have some questions for Moiz about it. [19:34:19] ok [19:39:07] (03PS4) 10Sumit: Overlay,Panel,Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) [19:44:51] 3Mobile-Web, Services: Image-positioning service - https://phabricator.wikimedia.org/T88633#1018899 (10brion) If we don't get a commons-wikibase setup or something to store the data in, I recommend entering the data into the pages via a parser function, just as we do with coordinates in GeoData. This could stor... [19:48:11] 3Wikipedia-App-iOS-App: 'Share' button crashes app on iPad Mini running iOS 8 - https://phabricator.wikimedia.org/T73189#1018927 (10brion) 5Open>3Resolved a:3brion This should have landed some time ago. [20:17:41] brion2: do you want me to take you off of the app retrospective calendar invite [sadface]. [20:17:58] kristenlans: oh yeah go ahead and take me off the cal [20:18:07] i’ll still be on the mailing list to harrass^H^H^H^^H^H^Hhelp :D [20:18:58] (03PS8) 10Fjalapeno: Implement Pull to Refresh for saved pages. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 [20:19:13] brion2: :P [20:24:32] (03CR) 10Florianschmidtwelzow: [C: 04-1] "some inline things, not tested, but looks good :)" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [20:35:27] dr0ptp4kt: are we still having the 2nd meeting? [20:36:12] bearND: i canceled it. i scheduled another one for next week. apologies for the meeting on, meeting off, meeting on, off, on, off, on [20:37:15] dr0ptp4kt: that's cool. now i can leave the hangout, hehe. Yeah, I didn't think we really needed one right now. [20:38:03] bearND: yeah. i should have notified you on irc as well. [20:38:05] coreyfloyd: sorry was at metric meeting and am wrapping up lunch, back in a bit [20:38:36] mhurd np [20:39:20] dr0ptp4kt: duh, forgot to scroll up in my mail window, lol. I found the cancellation notice. Sorry [20:39:37] bearND: NO! looking at email all day is evil! :) [20:39:52] bearND: i therefore apologize [20:50:12] bearND: moiz said for now let's just use the standard english wordmark for "Wikipedia" (with the circle R registered mark to the top and the right of it - in both ltr and rtl). he mentioned that the wordmark's baseline should be same as the cc-by-sa baseline. he said transposing the those three cc-by-sa icons in rtl mode is okay. he said he recalls that all thre of those cc-by-sa icons should be present (image viewer he's not so sure abo [20:50:19] (he dropped by my desk) [20:52:21] dr0ptp4kt: ok, thanks [20:53:21] bearND, I noticed responses to feedback with "Disclaimer: all mail to this address is answered by volunteers" at the bottom [20:55:30] Krenair: yes [20:55:50] from mobile apps staff [20:56:16] Krenair: are you saying I should remove that line when I respond? [20:56:29] I'm not sure. [20:56:40] aren't we all volunteers when it comes to responding to otrs? [20:56:49] But it sounds like it should be changed to me... [20:57:18] I don't think that applies if you have a staff account for your work.. [20:57:34] maybe it does. maybe ask lca [20:57:58] Krenair: that's probably a good question for Deskana to answer. I'm fine either way. [20:58:25] yeah, lca would be better [20:58:42] IANAL [21:02:20] Agreed. [21:02:28] Do you want me to kick that discussion off with them? [21:02:51] I think you're the best person to ask them to look into it. [21:04:06] Deskana: Thanks! [21:05:00] (03CR) 10Kaldari: WIP: recording and applying user responses (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [21:16:05] (03CR) 10MaxSem: WIP: recording and applying user responses (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [21:16:59] coreyfloyd: mhurd dr0ptp4kt Deskana stepping out for a bit before our evening meetings [21:17:06] o/ [21:28:50] (03PS1) 10Dbrant: [WIP] Translucent toolbar on top of lead image, fading with scroll. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188888 [21:33:13] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Translucent toolbar on top of lead image, fading with scroll. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188888 (owner: 10Dbrant) [21:33:51] dbrant: http://etherpad.wikimedia.org/p/WikipediaLite [21:58:53] (03CR) 10BearND: "@Dbrant. OK, I got it working on another device I hadn't tried before. So, for me it's 1 out 3 that it works." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) (owner: 10Dbrant) [22:08:07] (03PS2) 10Dbrant: [WIP] Translucent toolbar on top of lead image, fading with scroll. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188888 [22:18:57] bmansurov: need to discuss the wikigrok roulette stuff with you. do you have some free time? [22:19:08] kaldari: yes, let's do it [22:22:17] bmansurov: So we had a design review meeting today and one of the upcoming projects that we have is this: https://trello.com/c/yv3DSeyf/182-8-new-page-header-in-beta [22:22:55] bmansurov: which would immediately make the work that you did on the WikiGrok Roulette tutorial interface obsolete :( [22:24:52] kaldari: i see [22:24:56] so after discussing it with the designers they are OK with the WikiGrok Roulette tutorial interface just being a regular page with a regular header, so that we don’t have even more fragmented code that is harder to maintain [22:25:28] or if you think it would work better, I can see if they would be OK with it being a regular overlay [22:26:02] Mainly, I just don’t want us to have 10 different header implementations that we have to maintain in different places [22:26:13] I tried to mimic the design ;) [22:26:17] and keep in sync [22:26:24] bmansurov: Yes, you did a great job on it [22:26:40] I still think it should be an overlay and maybe leave room for the header (not cover it) [22:26:45] bmansurov: and I’m sorry I didn’t see this upcoming conflict earlier [22:27:10] kaldari: np, so according to the new design, we won't have the left navigation menu anymore? [22:27:26] bmansurov: We do in stable, but not in beta :P [22:28:03] kaldari: i see [22:28:49] kaldari: I think we should wait until this new card is implemented and then come back to my patch [22:28:54] what do you think? [22:30:18] bmansurov: so you think we should just not merge it for now? [22:30:52] kaldari: it's ready to be merged now, and I think we should merge it ;) [22:30:59] but we'll have to revisit [22:31:49] bmansurov: yeah, I think that might be the best course of action [22:32:55] bmansurov: it’ll just have an inconsistant interface for a bit [22:33:20] kaldari: how so? the new cad hasn't been worked on yet [22:33:25] *card [22:33:33] bmansurov: I mean after the new card is done [22:34:05] kaldari: i think this should be one of the requirements of the new card [22:35:02] bmansurov: yeah, although I will probably put it in a separate card and make it a dependency [22:35:52] kaldari: that would cause an inconsistency until the card is implemented ;) they should be done in one patch imo [22:37:38] bmansurov: actually it wouldn’t have to be inconsistant… If we changed the WikiGrok roulette intro interface to just use the shared header code (or shared overlay code), it will get the new changes for free. [22:37:51] as long as we change it first [22:38:03] ok [22:38:39] so, I’ll create a new card for that… [22:40:12] cool [22:41:20] (03PS19) 10MaxSem: WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [22:42:27] kaldari & phuedx, added edit summary and CentralAuth integration ^^^ [22:49:23] (03CR) 10Kaldari: [C: 04-1] WIP: recording and applying user responses (032 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [23:17:26] MaxSem: Do you think we should add some throttling to ApiResponse.php (as suggested by Daniel)? [23:17:38] we already have [23:19:18] MaxSem: ? I don’t see any pingLimiter [23:19:37] in EventLogger [23:20:07] MaxSem: Ah, nevermind :) [23:23:20] (03PS1) 10Bmansurov: Hygiene: Use view events in LanguageOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188939 (https://phabricator.wikimedia.org/T88563) [23:23:59] 3Mobile-Web: LanguageOverlay should use View##events - https://phabricator.wikimedia.org/T88563#1019682 (10bmansurov) a:3bmansurov [23:26:42] bmansurov: talked with moiz some more about WGR intro. He wants the intro page to have the standard page header so that it will be consistant with the subsequent pages, so I think we’ll need to convert it from an overlay to a special page. [23:27:29] kaldari: what subsequent pages? [23:28:05] bmansurov: I mentioned that you thought it would work better as an overlay, but he disagreed :P [23:28:20] bmansurov: the actual article pages with WikiGrok C on them [23:29:06] kaldari: ok, but it's so inefficient, we should just share the header with the overlay [23:29:59] yes, that might be the best solution [23:30:28] bmansurov: in fact, now that lightncandy is in core we could actually share the same code betwen both [23:30:36] cool [23:31:37] (03PS1) 10Bmansurov: Hygiene: Use View events in ErrorReportOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188941 (https://phabricator.wikimedia.org/T88562) [23:32:00] 3Mobile-Web: ErrorReportOverlay should use View##events map - https://phabricator.wikimedia.org/T88562#1019708 (10bmansurov) a:3bmansurov [23:38:22] (03CR) 10Florianschmidtwelzow: Hygiene: Use View events in ErrorReportOverlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188941 (https://phabricator.wikimedia.org/T88562) (owner: 10Bmansurov) [23:39:08] (03CR) 10Bmansurov: Hygiene: Use View events in ErrorReportOverlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188941 (https://phabricator.wikimedia.org/T88562) (owner: 10Bmansurov) [23:44:59] (03PS2) 10Bmansurov: Hygiene: Use View events in ErrorReportOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188941 (https://phabricator.wikimedia.org/T88562) [23:53:20] Maryana: do you have few min? [23:53:29] i will in a sec [23:53:35] are you in the office? [23:53:43] i can come find you when i'm out of this meeting [23:53:44] no. can send you a hangout? [23:54:12] send me a hangout when you're out, or let me know and I'll do it [23:54:13] ok, no worries. lemme wrap up this meeting and i'll ping you in a few minutes [23:54:15] sure [23:56:07] nuria: let me know as soon as your new sessionID code goes live as we’ll need to update the code on our end at the same time [23:56:44] kaldari: will update patch as soon as i am done documenting EL outage , so likely will send patch tomorrow [23:57:22] nuria: thanks [23:59:55] (03Abandoned) 10Robmoen: WIP: Showing collection list on Special:Collections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188495 (owner: 10Robmoen)