[00:05:42] bb after dinner [00:09:47] leila: ok, done w/meeting! just sent you a hangout link via email :) [00:10:20] thanks, Maryana. in hangout now. [00:17:13] (03CR) 10Kaldari: [C: 032] Add WikiGrok Roulette info overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 (owner: 10Bmansurov) [00:17:58] 👍 [00:18:16] (03Merged) 10jenkins-bot: Add WikiGrok Roulette info overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188271 (owner: 10Bmansurov) [00:36:47] (03CR) 10Hashar: "TimedMediaHandler ends up suffering from a same issue and die() because it requires the MwEmbedSupport. That is T88729" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/188115 (https://phabricator.wikimedia.org/T88015) (owner: 10Hashar) [01:21:24] coreyfloyd: hey sorry i was so unavailable today! ok if i schedule a meeting tomorrow so we’re sure to sync up? [01:31:59] (03CR) 10Kaldari: [C: 04-1] Show the WikiGrokRoulette menu item to the user (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188424 (owner: 10Bmansurov) [01:34:15] (03PS4) 10Bmansurov: Show the WikiGrokRoulette menu item to the user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188424 [01:36:53] mhurd sure [01:36:59] (03CR) 10Kaldari: [C: 032] Show the WikiGrokRoulette menu item to the user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188424 (owner: 10Bmansurov) [01:38:01] (03Merged) 10jenkins-bot: Show the WikiGrokRoulette menu item to the user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188424 (owner: 10Bmansurov) [01:42:54] (03PS1) 10Kaldari: List default value for MainMenu::openNavigationDrawer() in docs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188961 [01:43:01] (03CR) 10jenkins-bot: [V: 04-1] List default value for MainMenu::openNavigationDrawer() in docs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188961 (owner: 10Kaldari) [01:45:27] (03PS2) 10Kaldari: List default value for MainMenu::openNavigationDrawer() in docs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188961 [01:48:54] 3Wikipedia-App-Android-App: Double-tap search text hides it behind buttons - https://phabricator.wikimedia.org/T88768#1019971 (10Yurik) 3NEW [01:52:34] (03PS1) 10Bmansurov: Promote WikiGrok Roulette to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188962 [01:54:11] (03PS3) 10Kaldari: List default value for MainMenu::openNavigationDrawer() in docs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188961 [02:01:16] (03CR) 10Bmansurov: [C: 032] List default value for MainMenu::openNavigationDrawer() in docs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188961 (owner: 10Kaldari) [02:02:16] (03Merged) 10jenkins-bot: List default value for MainMenu::openNavigationDrawer() in docs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188961 (owner: 10Kaldari) [02:05:21] (03PS1) 10Fjalapeno: Add library license links to about page. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188964 [02:28:47] (03CR) 10Fjalapeno: "Responded to a few of Adam's comments." (035 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293 (owner: 10Dr0ptp4kt) [08:17:46] morning [08:36:16] (03CR) 10Florianschmidtwelzow: [C: 04-1] Hygiene: Use events map in talk feature (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [09:48:15] (03CR) 10Jhernandez: [C: 04-1] Hygiene: Use events map in talk feature (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [09:57:47] (03CR) 10Florianschmidtwelzow: Hygiene: Use events map in talk feature (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [09:59:16] yo [09:59:27] joakino [10:00:06] sup phuedx [10:05:59] how're you doing joakino ? [10:06:14] phuedx: fine and you? [10:09:10] yeah [10:09:11] fine [10:09:17] a bit beat [10:55:11] (03PS2) 10Phuedx: Promote alpha page styles to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 [10:55:13] (03PS1) 10Phuedx: Promote the BannerImage module to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189000 [10:55:23] (03CR) 10jenkins-bot: [V: 04-1] Promote alpha page styles to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 (owner: 10Phuedx) [10:55:28] (03CR) 10jenkins-bot: [V: 04-1] Promote the BannerImage module to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189000 (owner: 10Phuedx) [11:02:11] (03PS2) 10Phuedx: Promote the BannerImage module to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189000 [11:02:13] (03PS3) 10Phuedx: Promote alpha page styles to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 [11:08:32] (03CR) 10Phuedx: [C: 04-2] "This is part of the work described in https://trello.com/c/26TidjN6/11-3-page-styling-to-beta. However, because of the way this module is " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189000 (owner: 10Phuedx) [13:51:14] (03CR) 10Phuedx: [C: 032] Hygiene: Use View events in ErrorReportOverlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188941 (https://phabricator.wikimedia.org/T88562) (owner: 10Bmansurov) [13:52:22] (03Merged) 10jenkins-bot: Hygiene: Use View events in ErrorReportOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188941 (https://phabricator.wikimedia.org/T88562) (owner: 10Bmansurov) [13:53:38] 3Mobile-Web: ErrorReportOverlay should use View##events map - https://phabricator.wikimedia.org/T88562#1020587 (10phuedx) 5Open>3Resolved [14:11:22] (03PS5) 10Sumit: Overlay,Panel,Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) [14:13:29] (03CR) 10Sumit: [C: 04-1] "@Florian, I've made the minor changes, but the back button on edit page seems not to work, please see, I'm unable to figure out why?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [14:37:43] (03CR) 10Phuedx: [C: 04-1] "See inline." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188939 (https://phabricator.wikimedia.org/T88563) (owner: 10Bmansurov) [15:10:35] (03CR) 10Bgerstle: [C: 04-1] "see my comment in the Podfile, the version specifier is wrong. also, why can't we simply bundle the Pods-acknowledgements.plist and inject" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188964 (owner: 10Fjalapeno) [15:17:01] (03PS2) 10Dbrant: Nearby: secondary action instead of long-click to view on a map. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188110 [16:02:39] hey phuedx [16:02:49] hey kaity [16:03:22] is the promote page styling to beta ready to look over? or still working? [16:03:44] i think we can take a look at it [16:03:56] but i've had to split out the banner image stuff [16:03:58] ok cool [16:04:09] because that needs some more investigation to speed it up [16:04:21] (i think) [16:05:08] can you screenshare? [16:05:17] i should be able to [16:05:30] one sec though – currently trying to get george to go upstairs! [16:06:04] ok! [16:09:42] (03PS3) 10Dbrant: Nearby: secondary action instead of long-click to view on a map. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188110 [16:14:41] dbrant dr0ptp4kt i have a question about images [16:14:57] (for the gallery) [16:15:04] yep? [16:15:14] i'm able to fetch image info (using code inspired by android) [16:15:26] but… i'm not trying to correlate that response w/ the images actually being show in the article [16:16:02] sorry, i AM trying to correlate [16:16:07] but, i don't know how [16:16:37] the image info response is a "dict" of seemingly arbitrary numbers and image info objects [16:17:16] and part of the problem is the iOS app's article data model.. which essentially greps the article HTML and pulls out img URLs..? [16:17:27] (03CR) 10Mhurd: [C: 04-1] "Added comments inline." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188964 (owner: 10Fjalapeno) [16:17:33] i guess this is somewhat iOS specific [16:17:47] i guess dbrant, what are you guys doing to correlate image info objects w/ images? [16:18:03] bgerstle: hmm, it sounds like you're not getting the actual "File:___" wiki links for the images from the article? [16:18:21] dbrant, so we have an "article" object [16:18:23] which has an "images [16:18:25] field* [16:18:29] of type ImagesList [16:18:44] which AFAICT is injected with URLs gleaned from img tags in the article html [16:20:25] bgerstle: yeah, you need to use the File: link for the image to correlate it with the items in the imageinfo response. You shouldn't use the actual image URL [16:20:41] yeah, that's what i thought to do [16:20:53] but i'm having trouble finding it [16:21:35] bgerstle: in the html, it should be the target of the tag that encloses the image [16:22:05] right. . . [16:22:12] so we're pulling the src, doing some workaround for the srcset attribute [16:22:21] but not grabbing wherever the File: info is stored [16:22:50] what i'd LOVE to do, is ditch this altogether and get structured data [16:22:57] but.. [16:23:25] not sure how to do it or if it's possible to add my image info params to the article query params [16:24:35] not sure how all of that would work, given how articles are structured currently [16:25:08] how does image info work? [16:25:15] do i want to know? [16:26:22] i haven't touched that code; that would probably be MaxSem [16:26:34] right, so the a href is a *link* to a file [16:26:49] which i could search to see if it contains the image info's "File:.." string [16:27:19] e.g. if (image.fileHref.contains(imageInfo.fileName)) … [16:28:16] side note: still wondering why we're using article titles as references [16:29:07] coreyfloyd: FYI i left a couple comments on your blockskit & lib acknowledgement patch [16:29:16] TL;DR; the Podfile is broken [16:29:26] thanks - just saw that from monte [16:29:29] hehe block - skit [16:41:51] dat main page... :( [16:48:58] (03PS3) 10Phuedx: Promote the BannerImage module to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189000 [16:49:00] (03PS4) 10Phuedx: Promote alpha page styles to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 [17:05:07] dbrant ok… it's not just the FIle: name i need [17:05:16] i've now extracted the href: /wiki/File:Heka_Nanai.jpg [17:05:35] but for the image info object i have _canonicalFileURL NSURL * @"https://upload.wikimedia.org/wikipedia/commons/4/4c/Heka_Nanai.jpg" 0x00007fc0051161c0 [17:05:46] and _canonicalFilename NSString * @"File:Heka Nanai.jpg" [17:06:03] the canonicalFilename has a SPACE where the href has an underscore >:( [17:06:18] ah yes... that. [17:07:11] i mean.. i can try comparing the last path components, ignoring any File: prefix [17:07:25] is there any better way? [17:09:09] bgerstle: (you won't like it) (and neither do i) but in Android we actually take the href name and convert underscores to spaces. [17:10:35] bgerstle: I'm kind of in agreement that the element should contain the actual, real File: name as an attribute. For some images, it looks like the "alt" attribute is the name, but it's not consistent. [17:10:48] (✖╭╮✖) [17:11:24] or how about some kind of unique identifier, like a pageid for the corresponding file? [17:11:47] alright, i'll hack it for now and at least compare URLs to URLs [17:11:58] and pray [17:13:12] oh wait! [17:13:20] there's a description URL which might "just work" [17:13:24] * bgerstle prays some more [17:15:29] last ditch effort, then i need to step out for a bit [17:15:50] woohoo! it seemed to work! (**: for this one article i tried) [17:15:57] will expand on this more, later [17:16:35] bgerstle: you'll need to elaborate :) [17:17:02] :-( [17:17:09] found an article w/ more than one image and it won't work [17:17:19] at least [17:17:28] the comparison still works, but i'm not picking up all the images [17:18:53] or.. it's really unclear what articles have which images [17:19:01] … will need to sync w/ people after standup [17:19:37] ok, gtg now o/ [17:41:42] Happy Friday [17:42:14] joakino: are you around to hangout, or is it beer thirty ? [17:42:26] (03CR) 10Jhernandez: [C: 031] Hygiene: Use events map in talk feature (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [17:42:57] (03CR) 10Jhernandez: "I'll test this soon" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [17:43:06] rmoen: i'm around! [17:43:19] 1 minute [17:45:01] Heck yeah! UPS man is here. [17:45:33] its like chrismas [17:50:42] joakino: Yes. Getting more machinist tools today :) I'm super excited about it [17:51:31] very cool [18:03:48] phuedx $1 [18:03:52] (USD) [18:04:57] kristenlans: 1 on 1 with tfinc [18:04:59] wrapping up now [18:12:33] 3Mobile-Web: 'Close' button does not clear search criteria on the full-text Search Result page - https://phabricator.wikimedia.org/T88631#1020885 (10KLans_WMF) [18:17:38] bearND: coreyfloyd [18:18:13] kristenlans: thanks. [18:20:06] thanks [18:20:11] on my way [18:31:46] (03PS2) 10Bmansurov: Hygiene: Use View events in LanguageOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188939 (https://phabricator.wikimedia.org/T88563) [19:01:39] (03PS2) 10BearND: Enable search suggestions in prefix search task [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186942 (https://phabricator.wikimedia.org/T86982) [19:04:00] (03CR) 10jenkins-bot: [V: 04-1] Enable search suggestions in prefix search task [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186942 (https://phabricator.wikimedia.org/T86982) (owner: 10BearND) [19:04:38] (03PS1) 10Kaldari: Add border between notices and header in mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189039 [19:05:27] (03PS2) 10Kaldari: Add border between notices and header in mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189039 [19:05:32] coreyfloyd: NAVBAR_MODE_PAGES_SAVED [19:05:43] NAVBAR_MODE_PAGES_SAVED_UPDATING [19:07:09] WHY_YOU_YELL [19:07:27] 3MediaWiki-ResourceLoader, Mobile-Web: Introduce MediaWiki:Mainpage.css - https://phabricator.wikimedia.org/T78418#1021016 (10Legoktm) [19:08:45] coreyfloyd: https://github.com/montehurd/apps-ios-wikipedia/tree/progressExample [19:10:50] (03CR) 10BearND: "@Dbrant could this new nearby marker pin icon replace nearby.png we use for the nav drawer?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188110 (owner: 10Dbrant) [19:25:52] bgerstle: there's now a phab task for including an html attribute that contains the actual title of images: https://phabricator.wikimedia.org/T88825 [19:26:30] bgerstle: fwiw, the MediaViewer on desktop also currently resorts to parsing the image URLs. [19:27:21] dbrant hacking's ok if everyone's doing it! \o/ [19:30:45] (03PS2) 10Bmansurov: Promote WikiGrok Roulette to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188962 [19:33:16] (03CR) 10Bmansurov: [C: 032] Add border between notices and header in mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189039 (owner: 10Kaldari) [19:34:21] (03Merged) 10jenkins-bot: Add border between notices and header in mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189039 (owner: 10Kaldari) [19:38:07] (03CR) 10Phuedx: [C: 032] Hygiene: Use View events in LanguageOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188939 (https://phabricator.wikimedia.org/T88563) (owner: 10Bmansurov) [19:39:15] (03Merged) 10jenkins-bot: Hygiene: Use View events in LanguageOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188939 (https://phabricator.wikimedia.org/T88563) (owner: 10Bmansurov) [19:39:18] mhurd: dr0ptp4kt when do you guys think you'll have a few spare minutes to talk about image gallery stuff? [19:40:13] i'm trying not to compromise too much here in terms of hackiness, but am worried i might be missing something [19:40:27] bgerstle: this afternoon would work for me. want me to setup a videoconference? that way we can discuss from a conference room [19:40:49] 3Mobile-Web: LanguageOverlay should use View##events - https://phabricator.wikimedia.org/T88563#1021189 (10phuedx) 5Open>3Resolved [19:41:08] bgerstle: i should say...i'll setup a meeting at 1:30 pm sf / 4:30 pm fl time. okay? [19:41:37] sure i'm free then [19:44:09] 3Wikipedia-App-iOS-App: iOS app: Little icons in articles should not be fuzzy (iOS 6 and 7) - https://phabricator.wikimedia.org/T72364#1021199 (10brion) a:5brion>3None (deassigning as this doesn't seem high prio) [19:44:23] 3Wikipedia-App-iOS-App: iOS app doesn't support {{DISPLAYTITLE:}} - https://phabricator.wikimedia.org/T65971#1021201 (10brion) a:5brion>3None [19:44:36] (03PS1) 10Kaldari: Hygiene: Cleaning up ui.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189048 [19:48:33] gonna head orf for the weekend [19:48:36] see y'all on monday [19:49:32] phuedx see ya! o/ [19:50:39] 3Mobile-Web, MediaWiki-extensions-CentralAuth: CentralAuth AutoLogin not working on mobile sites - https://phabricator.wikimedia.org/T87290#1021259 (10kaldari) It looks like the train deployment did not fix the CentralAuth bug on the group 0 wikis (testwiki, mediawiki). [20:29:16] bgerstle: just looking at calendar and scrollback. sorry, lost attention without my nick being in there. mind moving that meeting to 4:30 eastern instead of 4:00? monte's at lunch [20:29:59] sure [20:30:31] bgerstle: thx :) [20:31:04] np [20:34:53] * FlorianSW waves around [20:37:35] (03PS3) 10BearND: Enable search suggestions in prefix search task [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186942 (https://phabricator.wikimedia.org/T86982) [20:42:31] (03PS3) 10Dbrant: [WIP] Translucent toolbar on top of lead image, fading with scroll. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/188888 [20:57:54] (03CR) 10Bmansurov: [C: 032] Hygiene: Cleaning up ui.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189048 (owner: 10Kaldari) [21:02:03] (03CR) 10Dbrant: [C: 04-1] "When there are zero results, the suggestion is never shown (even when the api response contains a suggestion). For example, try searching " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186942 (https://phabricator.wikimedia.org/T86982) (owner: 10BearND) [21:06:42] (03Merged) 10jenkins-bot: Hygiene: Cleaning up ui.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189048 (owner: 10Kaldari) [21:08:26] dbrant how did you filter out images like the commons logo from the image info response? [21:09:31] is this about the lead image thing? [21:10:54] krenair yes [21:11:05] Don't those come from Extension:PageImages? [21:11:17] Krenair i have no idea [21:11:22] oh sorry [21:11:23] not lead images [21:11:30] article images & the image gallery [21:11:36] Krenair ^ [21:11:42] ah, not sure then, sorry [21:21:11] bgerstle: sorry was afk [21:21:29] bgerstle: hangout at 1:30? [21:25:29] mhurd you mean in 5? [21:25:32] (minute) [21:39:51] bgerstle: i look at the mime type of each image, and throw it away if it's svg or png [21:54:36] dr0ptp4kt: i just found this: https://www.mediawiki.org/wiki/API:Properties#images_.2F_im [21:54:40] dbrant: ^ [21:54:46] even says: [21:54:47] Example[https://www.mediawiki.org/w/index.php?title=API:Properties&veaction=edit&vesection=33 | https://www.mediawiki.org/w/index.php?title=API:Properties&action=edit§ion=33] [21:54:47] Get a list of images on https://en.wikipedia.org/wiki/Albert_Einstein's page [21:54:47] https://en.wikipedia.org/w/api.php?action=query&titles=Albert%20Einstein&prop=images [21:55:12] i guess that's the "generator" that i'm using though..? [21:55:34] right, that's what we're using [21:55:56] dbrant the generator, you mean? [21:56:03] yep [21:56:42] there's an "imimages" property [21:56:52] it says "Only list these images" [21:56:59] does it take files? w/ or w/o the File: prefix? [21:58:16] i think you always need the File: prefix [21:58:20] seems like it [21:58:26] mhurd, looks like i can use that to filter the imageinfo response [21:58:57] but why do you need to filter the imageinfo response? [21:59:33] bgerstle: i think if you just set “titles” to only the ones we’re looking for you won’t need to filter. i think? [22:00:35] ^ [22:00:52] "titles" lets you put multiple titles separated by | [22:01:19] i just tried the imimages prop, and it does the same thing [22:04:14] dbrant mhurd what's a generator? [22:09:28] bgerstle mhurd dr0ptp4kt going to hop off about 530 take a long dinner break and drive back to my other house - I'll be back on 730ish - do any of you need anything before I do? [22:10:24] coreyfloyd: nothing here. enjoy dinner! [22:12:26] thanks! Unfortunately most of the time will be spent driving on the turnpike - need some finger food. [22:12:40] coreyfloyd: i’m good drive safe! [22:13:05] nope o/ [22:13:10] drive safe [22:15:13] thnaks guys -still around for a bit if you change your minds [22:20:43] mhurd going to try your approach, though the way we're getting the File: title is less than ideal [22:21:03] dbrant i also found this property: "iiextmetadatafilter" [22:21:11] which lets you specify only the keys you want from the extmetadata obj [22:21:21] instead of getting a whole bloatload of stuff [22:21:25] boatload* [22:21:31] though similar to a bloatload [22:26:04] (03PS4) 10BearND: Enable search suggestions in prefix search task [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186942 (https://phabricator.wikimedia.org/T86982) [22:29:33] (03CR) 10BearND: "@Dbrant. Good point. That is fixed now." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186942 (https://phabricator.wikimedia.org/T86982) (owner: 10BearND) [22:30:16] bgerstle: i like bloatload :) [22:30:28] 3Mobile-Web, MediaWiki-extensions-CentralAuth: CentralAuth AutoLogin not working on mobile sites - https://phabricator.wikimedia.org/T87290#1021778 (10kaldari) I ran some testcases and got the following results consistently: Logging into mobile Wikipedia from the Main Page: Fails to load 1x1 images Fail... [22:31:18] dr0ptp4kt: tfinc thinking about WFH this afternoon… giant monitors and all… [22:31:45] mhurd: how are the new screens ? [22:32:00] mhurd: no probs here. gimme a monitor, though! ;) [22:32:06] tfinc: it’s good! it has all the finest pixels [22:40:25] mhurd seems to work w/ minimal changes [22:40:34] just need to pair the backing MWKImage w/ my new image object [22:40:47] breaking for chips, salsa & dog walk [22:40:53] might hammer on it a bit more later [22:41:07] 3Mobile-Web, MediaWiki-Authentication-and-authorization: Authentication sharing between desktop and mobile Commons is broken - https://phabricator.wikimedia.org/T88860#1021810 (10kaldari) 3NEW [22:41:24] unless, you know, i'm parting MIA style w/ dr0ptp4kt [22:41:27] ( •_•)>⌐■-■ [22:41:31] (⌐■_■) [22:41:34] YYYYEAHHHHHH [22:41:49] c ya [22:41:50] o/ [22:41:55] 3Mobile-Web, MediaWiki-extensions-CentralAuth: CentralAuth AutoLogin not working on mobile sites - https://phabricator.wikimedia.org/T87290#1021818 (10kaldari) I split off bug #1 in the previous comment into bug T88860. I will also retitle this bug. [22:42:11] bgerstle: awww yeah [22:42:38] 3Mobile-Web, MediaWiki-extensions-CentralAuth: CentralAuth AutoLogin not working from mobile site Main Pages - https://phabricator.wikimedia.org/T87290#1021821 (10kaldari) [22:46:15] 3Mobile-Web, MediaWiki-extensions-CentralAuth: CentralAuth AutoLogin not working from mobile site Main Pages - https://phabricator.wikimedia.org/T87290#1021827 (10kaldari) [22:51:13] tfinc: dr0ptp4kt back online [22:51:25] mhurd: thx [23:02:13] 3Wikipedia-App-Android-App: EGL-related crashes - https://phabricator.wikimedia.org/T74530#1021857 (10Krenair) [23:13:01] 3Mobile-Web, MediaWiki-extensions-CentralAuth: CentralAuth AutoLogin not working from mobile site Main Pages - https://phabricator.wikimedia.org/T87290#1021866 (10kaldari) So I think what's happening here is that CentralAuth is inserting the images into the bottom of the content of the Main Page, then MobileForm... [23:20:35] MaxSem: Do you have any opinion which of these two solutions is best: https://phabricator.wikimedia.org/T87290#1021866 [23:21:29] 3Mobile-Web, MediaWiki-extensions-CentralAuth: CentralAuth AutoLogin not working from mobile site Main Pages - https://phabricator.wikimedia.org/T87290#1021871 (10MaxSem) Make parseMainPage() not touch it? [23:21:36] kaldari, ^ [23:32:38] 3Mobile-Web, MediaWiki-extensions-CentralAuth: CentralAuth AutoLogin not working from mobile site Main Pages - https://phabricator.wikimedia.org/T87290#1021905 (10kaldari) @MaxSem: Actually my 2nd solution wouldn't work well anyway, since it would cause parseMainPage() to built a bunch of extra DOM elements arou... [23:39:33] Maryana: Did we ever find out if we can remove all the ® and TM symbols?