[06:37:57] (03PS1) 10Rahdev: Added feature to bring up W menu with a swipe gesture from the left side of the screen [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189432 [06:46:30] (03PS2) 10Rahdev: Add defaultremote = origin to .gitreview Directory (.config) and file (git-review.conf) do not exist in the MacOSX Yosimite installation. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189432 [09:03:52] morning y'all [09:17:27] woo [09:17:30] light email day! [09:57:41] (03CR) 10Jhernandez: [C: 04-1] "Some minor problems. Looking good" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [09:57:55] morning phuedx [09:58:04] hey joakino [10:01:28] phuedx: how's the morning goign [10:02:00] good thanks [10:02:24] kinda groggy [10:02:27] got a bit of a cold [10:02:31] how about yours? [10:02:44] i've signed up for the gym this morning [10:03:09] it was super packed and i didn't have a lock so i've come back to work, i'll go at lunch time [10:03:42] (03CR) 10Florianschmidtwelzow: Hygiene: Use events map in talk feature (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [10:03:48] i really hate masses [10:05:47] (03CR) 10Jhernandez: Hygiene: Use events map in talk feature (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [10:13:40] (03CR) 10Florianschmidtwelzow: [C: 04-1] Hygiene: Use events map in talk feature (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [10:14:56] joakino: masses? [10:15:06] crowds? [10:15:13] tons of people? [10:15:58] phuedx: this `==> default: Mounting NFS shared folders...` and `Loading localhost:8080` is what I spend most of my day on [10:16:40] (03CR) 10Florianschmidtwelzow: [C: 04-1] Overlay,Panel,Drawer made to use View##events (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [10:21:44] *sigh* [10:21:47] yeah [10:21:50] that [10:22:02] oic, yeah, packed gyms are the worst [11:11:05] hey phuedx [11:11:15] i've been looking at the logs on vagrant [11:11:28] and this things are taking a lot of time each reload: [11:11:31] [caches] LocalisationCache: using store LCStoreCDB [11:11:31] [caches] main: RedisBagOStuff, message: RedisBagOStuff, parser: RedisBagOStuff [11:11:38] multiple of them [11:11:49] any ideas on what to do to speed whatever that is? [11:14:01] turn off i18n? :/ [11:14:09] (i'm not sure that's a thing) [11:14:31] redisbagostuff being slow seems like memory pressure on the vm [11:14:40] but you're giving it 3gb right? [11:42:53] phuedx: yep 3gb [12:29:20] i'm out to the gym [12:56:49] (03PS7) 10Sumit: Overlay,Panel,Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) [12:57:53] (03CR) 10Sumit: "Yes, I should have seen the extend thing, I'll be careful next time :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [15:08:08] (03CR) 10Jhernandez: [C: 04-1] "I've made a through code review, this is a hard patch (lots of small things and corner cases) and I don't think our tests are extensive en" (0311 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [15:10:23] and now joakino saved his comment son the change ^ before me :D [15:10:35] FlorianSW: xD [15:10:47] FlorianSW: it took me about 50 minutes to do that code review [15:10:58] i'm scared we are going to break a bunch of things subtly [15:11:05] (03CR) 10Florianschmidtwelzow: [C: 04-1] "+1 to comments from Jhernandez :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [15:12:05] joakino: yeah, that are our base classes, on which we build our whole feature set, so if we make an error there we could have a big problem :/ I would suggest to split the change up into 3 ones (one for each class), too [15:12:41] 3Mobile-Web: Overlay, Panel and Drawer should use View##events - https://phabricator.wikimedia.org/T87192#1024859 (10Jhernandez) @Sumit thanks for the patch! :D, i've left a buncha comments, this are very basic views so we have to make sure they extend their parents events, and check child classes and if they us... [15:13:01] (03CR) 10Florianschmidtwelzow: "And: I would suggest to split this change into more then one (one change for each file/class), that would make it easier for us to review " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [15:13:07] FlorianSW: do you think sumit can handle that? [15:13:26] joakino: maybe we can ask himself :D codezee: ping [15:13:33] codezee: wohoo [15:13:34] xd [15:14:05] FlorianSW: codezee: gotta go for lunch, its 4pm already :/ i'll read you later, whatever you guys decide [15:14:09] i think it would be a good task to learn our code base. It will take more time (because he is new), but i see no problem there, it's a hygiene task :) [15:14:20] * phuedx hasn't looked at this change [15:14:31] fortunately y'all 've got it covered \o/ [15:14:33] joakino: bon appetit :D [15:17:44] (03PS3) 10Florianschmidtwelzow: Hygiene: Use events map in talk feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) [15:26:26] joakino,FLorianSW:hello, sorry, I was not here [15:26:44] now here [15:26:55] codezee: no problem, that's irc :D [15:30:24] joakino,FlorianSW:I'll have a look at it :), no problem, if any issue, I'll just ask [15:31:09] codezee: right :) But maybe you should wait until joakino wrote the e-mail to mobile-l to know, what he wants to say us :) Have you subscribed to mobile-l already? [15:31:33] FlorianSW: alright, and no, I'm not yet subscribed to that list [15:32:00] codezee: if you want: https://lists.wikimedia.org/mailman/listinfo/mobile-l :) [15:32:21] FlorianSW: yes, ok, I'll do it right away [15:32:28] maybe 6-7 e-mails a week (sometimes more, sometimes less) i suggest, but i can't count it really, my inbox is to full :D [15:35:04] FlorianSW: meanwhile, feel free to delegate any task that you think could be handled by me, I'd be happy to take it up and learn [15:35:36] codezee: ok, great :D I will see if i find a good task on phabricator and add you as a subscriber, ok? :) [15:35:57] FlorianSW: ok! :) [15:54:21] codezee: FlorianSW: i just want to write down about adding events map to a view, and checking the parent and children classes for extending where appropiate, it is all commented in that patch i reviewed, so you guys already know about that [15:54:46] joakino: fine :D [15:54:52] but i want the whole mobile devs to sync up on that, that's why i want to write the email [15:55:07] feel free to keep on working on the patch :D [15:55:11] joakino: yes, I did see that, I'll also look and see whatever I can figure out [15:55:44] awesome! :D [16:01:00] joakino: tbh, I did think that this would come, as the View, and Overlay are at the top of heirarchy, so a thorough scanning becomes inevitable [16:01:34] joakino: is there any documentation where we can see the class heirarchy? [16:01:50] codezee: i suggest make doc or something else [16:02:20] codezee: ah, "make docs" :D https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/Makefile#L44 [16:02:39] there is no onloine documentation at the moment (*crying*) [16:03:36] FlorianSW: hmm, ok, I guess that is also something that must be in line of 'to do' [16:04:03] i remember we have a task for it [16:04:25] * FlorianSW digging in phabricator data [16:04:47] ah, yes: https://phabricator.wikimedia.org/T74794 [16:05:51] brb [16:18:01] 3Continuous-Integration, Mobile-Web, Thanks, §Collaboration-Team-Sprint-P-2015-02-11: Thanks is broken again (Mobile Thanks needs qunit tests) - https://phabricator.wikimedia.org/T86687#1025067 (10hashar) [16:23:12] 3VisualEditor, Mobile-Web, Citoid: Citoid extension should target Mobile as well as desktop (otherwise it blocks VisualEditor loading in MobileFrontend) - https://phabricator.wikimedia.org/T87869#1025115 (10Jdforrester-WMF) 5Open>3Resolved a:3Mvolz [16:34:56] i'm back~! [16:36:24] FlorianSW: does make docs work for you? i'm getting make: *** [kss] Error 7 [16:36:28] grunt docs works fine [16:38:06] joakino: i never used it, i use github and grep, it's faster :D [16:38:08] let me try it [16:38:23] (03PS1) 10Florianschmidtwelzow: Show edit pencil on all headings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189506 (https://phabricator.wikimedia.org/T87644) [16:39:11] joakino: works for me :/ [16:39:14] FlorianSW: i use ag for that too, way better [16:39:18] FlorianSW: dang it... [16:39:20] anyway [16:39:33] maybe something in node_modules? [16:39:43] grr [16:40:23] MaxSem will hate me for this change ^^ :D [16:41:37] (03CR) 10jenkins-bot: [V: 04-1] Show edit pencil on all headings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189506 (https://phabricator.wikimedia.org/T87644) (owner: 10Florianschmidtwelzow) [16:43:57] haha [16:44:16] and jenkins hate me too, and they're right :P [16:44:21] FlorianSW: phuedx: codezee: i've published the docs on github pages as of today [16:44:24] http://chimeces.com/mobile-frontend-docs [16:45:12] joakino: i thought they were published on docs.mediawiki.org (or something like that)? [16:45:20] codezee: if you click by inheritance at the bottom left, then you can see the tree of classes http://chimeces.com/mobile-frontend-docs/#!/api/Overlay [16:45:29] phuedx: are they? that would be awesome [16:45:47] 3Mobile-Web: Alpha: Wrong position for the last edited bar when images are present on the page - https://phabricator.wikimedia.org/T88499#1025171 (10Florian) @Sumit maybe you want to work on this? [16:46:11] phuedx: hmm there is https://doc.wikimedia.org/ [16:46:15] joakino: i don't think they are [16:46:20] https://doc.wikimedia.org/ doesn't have 'em [16:46:29] phuedx: we are not there :( [16:46:40] hashar: ^ do you have an example of how to get our js docs onto doc.wikimedia.org [16:46:43] joakino: those will be very helpful..., thanks [16:46:45] joakino, phuedx it's planned to publish them [16:46:46] is it a zuul thing? [16:46:56] FlorianSW: cool.io, when? ;) [16:47:11] phuedx, joakino feel free to work on it :D https://phabricator.wikimedia.org/T74794 [16:47:26] i don't know, but it takes too long :/ [16:48:12] looks like jdlrobson is waiting on feedback from hashar maybe? [16:48:16] (maybe) [16:48:21] although he self -1'd [16:48:26] anyway joakino, thanks! [16:48:33] use them until we're all official like! [16:49:23] for doc updates ping me or pull request [16:49:46] lol [16:51:02] xd [16:54:04] phuedx: where what ? :-D [16:54:28] ah yeah the mobile doc [16:54:29] 3Mobile-Web: Alpha: Wrong position for the last edited bar when images are present on the page - https://phabricator.wikimedia.org/T88499#1025194 (10Sumit) @Florian,yes, ok, I'll look into it [16:54:35] https://gerrit.wikimedia.org/r/#/c/181693/ <- hashar [16:55:21] I had some discussions about docs last week. Seems we will need some kind of convention to generate them [17:00:29] hashar: how can we help with that? [17:00:30] hashar: we need good conventions for doc generation, testing infra and setup, linting, etc, and a good boilerplate so that it is supereasy to spin projects for both developers and CI [17:00:42] yeah, what can we do [17:00:53] joakino ^^ [17:01:09] but it's easy to get paralysed by the "we have so much we can do" mentality ;) [17:01:41] so, is there a better options for publishing docs that jdlrobson's patch should follow? [17:01:43] hashar ^ [17:09:58] 3Continuous-Integration, Mobile-Web: Publish our JS Documentation - https://phabricator.wikimedia.org/T74794#1025231 (10hashar) We have too many different ways to generate documentation. Each time we end up having to create yet another job and Jon patch is an illustration ( https://gerrit.wikimedia.org/r/#/c/18... [17:10:11] phuedx: yeah avoid copy pasting :D [17:10:21] good start ;) [17:10:21] phuedx: jon patch is fine [17:10:32] in the sense it will probably work [17:10:39] but it is bad because it s building up on top of a tech debt [17:10:40] :-D [17:10:56] I would like Jenkins to be very dump [17:10:59] and just "make doc" [17:11:09] or something similar, as long as it is a command shared by all repos [17:11:19] then it will be trivial for developers to invoke whatever they want. [17:11:54] wellp, does jenkins do that now? [17:12:04] (and i'm for that btw) [17:12:06] we are moving toward that goal for tests [17:12:14] https://www.mediawiki.org/wiki/Continuous_integration/Tests_entry_points [17:12:29] ie jenkins just: npm test, composer test or tox [17:12:32] what's wrong with make test? [17:12:34] for doc it could just: make doc [17:12:38] ;) [17:12:49] [17:12:53] yeah we could go with make test as well haha [17:13:05] I am pinging wikitech-l [17:13:08] some tools come with parallelisation etc [17:13:18] well [17:13:28] joakino has graciously published the mf docs on his site [17:13:57] so that might be an acceptable interim measure until we have an acceptably dumb jenkins [17:14:18] hashar: any rough estimates? [17:18:10] phuedx: I have posted to wikitech-l [17:18:21] with an "ultimatum" that next week I will use the convention "make docs" [17:18:30] i.e. I will get a jenkins job template that shell "make docs" [17:18:54] then write a wiki page explaining how to conform to the convention and setup CI [17:18:59] so ETA 1 week :-D [17:19:15] wikitech message https://lists.wikimedia.org/pipermail/wikitech-l/2015-February/080670.html [17:20:12] 3Continuous-Integration, Mobile-Web: Publish our JS Documentation - https://phabricator.wikimedia.org/T74794#1025278 (10hashar) [17:21:20] hashar: <3 [17:21:25] 3Continuous-Integration, Mobile-Web: Publish our JS Documentation - https://phabricator.wikimedia.org/T74794#761166 (10hashar) That is merely to avoid pilling more tech debt on top of the existing debt. I have mailed [[ https://lists.wikimedia.org/pipermail/wikitech-l/2015-February/080670.html | wikitech-l ]] ab... [17:21:32] phuedx: so moaaar delay [17:21:39] but I am idealist / perfectionist [17:22:39] oh of COURSE. because if a JSON response field is empty, it should be returned as an array instead of an object -_- [17:22:57] awesome hashar [17:24:00] what would be awesome would be to reuse the Travis workers :D [17:24:12] then our Jenkins would just reuse .travis.yaml \O/ [17:25:45] I am off :-D [17:27:27] MaxSem just found a nasty bug in JSON serialization [17:27:31] joakino phuedx [17:27:42] related to image info property [17:28:10] where would i file such a thing? [17:28:33] bgerstle: this is in mobileview api? [17:28:43] Mobile-Web? [17:28:55] joakino don't believe so [17:29:12] one sec and i can paste a gist to demonstrate [17:29:19] ta [17:31:43] FlorianSW|away: codezee: i've written about what i've posted on the CR from before here, http://mobile_web/Coding_conventions/JavaScript/Views#Implementing_events_map_on_a_View_in_an_inheritance_chain [17:31:51] also sent an email to mobile-l [17:32:48] sorry phuedx, i meant to mention you [17:32:50] here: https://gist.github.com/btgerst/6725a8d823f32f2bbd72 [17:32:58] note the difference between the extmetadata fields [17:34:49] bgerstle: i recall seeing that "pattern" in other responses; i don't think it's unique to imageinfo :( [17:35:06] are we using the force_object thing? ;/ [17:35:09] hrrrrm [17:35:16] dbrant: so what you're telling me is that JSON is broken on the back-end [17:35:38] bgerstle: i'm fairly sure there's a flag that varies this behaviour [17:35:48] i don't remember where else i've seen it, though. and yes, that would mean it's broken [17:35:48] this is a feature?? [17:36:10] well, it might be, i'm just checking the json_encode options [17:36:21] phuedx, would it be a request param? [17:36:25] joakino: fails to open, strange [17:37:01] bgerstle: no, sorry, this is a php constant that affects the behaviour of the json encoding function [17:37:09] oh [17:37:14] and i was misremembering [17:37:32] this is not the constant i was looking for [17:37:35] anyway [17:37:42] * bgerstle waves hand in jedi fashion [17:38:35] to answer your question: core [17:38:36] dbrant are there any other bear traps i should be wary of? [17:38:45] ApiQueryImageInfo.php is in core includes [17:40:44] bgerstle: ah, here's what I was thinking of: [17:40:55] compare these two responses: [17:40:58] http://en.wikipedia.org/w/api.php?action=query&prop=pageprops&rawcontinue=&generator=prefixsearch&gpssearch=test [17:41:02] http://en.wikipedia.org/w/api.php?action=query&prop=pageprops&rawcontinue=&generator=prefixsearch&gpssearch=testtt [17:41:14] haha yep [17:41:17] for a whole response, wow [17:41:34] i don't know, either, [17:43:25] codezee: shit i messed the url on the email https://www.mediawiki.org/w/index.php?title=Mobile_web/Coding_conventions/JavaScript/Views#Implementing_events_map_on_a_View_in_an_inheritance_chain [17:45:54] I'd better read the entire mobile web coding conventions page [17:53:34] joakino: i wonder if we can use extend always, for each event map? That would make it much easier and less error-prone? [17:59:42] FlorianSW: View doesn't have or won't have default events, so it is cleaner without the extend [17:59:58] FlorianSW: no need to overprotect/preemptively engineer [18:02:55] joakino: :D [18:13:31] (03CR) 10Bmansurov: [C: 04-1] "needs rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189212 (owner: 10Florianschmidtwelzow) [18:18:25] (03CR) 10BearND: [C: 04-1] "Missed the search widget at first since it doesn't start with the app name. More comments inline." (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175225 (owner: 10Dbrant) [18:25:13] (03CR) 10Bmansurov: Hygiene: Use events map in talk feature (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [18:26:04] dr0ptp4kt: coreyfloyd: what's our status on the license issue in https://gerrit.wikimedia.org/r/#/c/187251/ ? [18:27:18] gonna watch a movie with a bunch of friends and then come back to work [18:27:24] see y'all later [18:27:42] phuedx: have fun!! [18:28:16] kaldari: now I see two borders https://imgur.com/wHiCvv6 ;( [18:28:56] bye phuedx [18:28:57] :( [18:29:27] kaldari: is that on your local wiki? [18:29:35] oops, why am I talking to myself [18:29:43] bmansurov: which wiki is that on? [18:29:50] beta labs [18:30:22] @dr0ptp4kt no longer an issue - we are no longer using SSPullToRefresh [18:31:05] dr0ptp4kt the about page patch is ready to go for review - don'r bother with the pull to refresh for now - I am going to push up a new patch later today [18:31:08] bmansurov: ah, I see (it only has the double border in beta and alpha) [18:31:13] coreyfloyd: tfinc ^ . cool. as you probably know, for the future if we do copy-paste with a chunk like that, best to just link back to it, and then include the license (labeled as mit) [18:31:27] kaldari: ok [18:31:36] coreyfloyd: cool. thanks! [18:31:38] bmansurov: but that’s still bad [18:31:53] dr0ptp4kt: coreyfloyd why are we copy/pasting instead of using the lib as-is? [18:32:13] kaldari: yeah looks weird [18:32:34] dr0ptp4kt: yeah - used it as a starting point but made significant changes - so didn't worry about it - I can throw in an attribute in the about page if you want - let me know [18:33:02] bmansurov: actually, I lied it seems to happen in stable too (after clearing my cache). [18:33:18] not just our best effort. it's our obligation to do it per license and give them credit [18:33:21] kaldari: liar [18:33:25] P [18:33:25] :) [18:33:37] bgerstle: agreed, typically easier to use the full lib (if it doesn't bloat build). i think coreyfloyd was reducing the package size and customizing pretty extensively. but it's moot now [18:33:56] k [18:34:02] there's always subspecs [18:34:22] either way, we make it harder for ourselves to incorporate upstream fixes this way, but i assume that's a trade-off we're consciously making [18:35:07] bgerstle - yeah we needed significantly different functionality than the library provided. And yeah after I spoke to Monte about the dependency, he thought it better if we didn't have a dependency for pull to refresh and we could maintain a solution ourselves. [18:35:21] k [18:35:35] bgerstle - but yeah - typically I don't like doing this myself [18:35:46] i'm signing off for lunch now. just posting a couple minor comments on the library/about.html stuff [18:35:55] i've got some questions about blockskit, but that can wait til later [18:36:44] (03CR) 10Bgerstle: [C: 031] "just a couple minor comments. code looks good" (034 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188964 (owner: 10Fjalapeno) [18:36:53] bbl o/ [18:37:50] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189526 [18:37:57] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189527 [18:41:47] (03CR) 10BearND: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189527 (owner: 10BearND) [18:41:55] (03CR) 10Bmansurov: [C: 04-1] "This fixes half the problem. If the page contents is the following text, then the first level 1 section is not editable." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189239 (https://phabricator.wikimedia.org/T88885) (owner: 10Florianschmidtwelzow) [18:42:06] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189527 (owner: 10BearND) [18:44:03] (03CR) 10Bmansurov: "Has there been a discussion about it? I may have missed it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189213 (owner: 10Florianschmidtwelzow) [18:52:50] (03CR) 10Fjalapeno: "Responses to Brian - will be making a small change." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188964 (owner: 10Fjalapeno) [18:53:53] (03CR) 10Dbrant: [C: 04-1] "Found a weird issue:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186942 (https://phabricator.wikimedia.org/T86982) (owner: 10BearND) [19:03:40] (03PS3) 10Fjalapeno: Add library license links to about page. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188964 [19:15:59] (03PS3) 10Kaldari: Making MobileFormatter preserve the CentralAuth 1x1 images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189154 (https://phabricator.wikimedia.org/T87290) [19:17:31] (03CR) 10Dr0ptp4kt: "We're actually going to be examining new progressive swipe gestures, and it looks like swipe from left is probably not going to show the m" (034 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189432 (owner: 10Rahdev) [19:18:26] (03CR) 10jenkins-bot: [V: 04-1] Making MobileFormatter preserve the CentralAuth 1x1 images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189154 (https://phabricator.wikimedia.org/T87290) (owner: 10Kaldari) [19:20:13] (03PS4) 10Kaldari: Making MobileFormatter preserve the CentralAuth 1x1 images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189154 (https://phabricator.wikimedia.org/T87290) [19:21:44] (03CR) 10jenkins-bot: [V: 04-1] Making MobileFormatter preserve the CentralAuth 1x1 images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189154 (https://phabricator.wikimedia.org/T87290) (owner: 10Kaldari) [19:23:06] (03PS5) 10Kaldari: Making MobileFormatter preserve the CentralAuth 1x1 images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189154 (https://phabricator.wikimedia.org/T87290) [19:24:56] (03PS13) 10Dbrant: Widgets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175225 [19:25:09] Maryana: So we are promoting page images to beta according to this card? https://trello.com/c/sdP2EAbL/16-3-beta-restyle-image-title-on-tablet [19:25:15] (03CR) 10jenkins-bot: [V: 04-1] Widgets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175225 (owner: 10Dbrant) [19:27:56] (03PS14) 10Dbrant: Widgets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175225 [19:28:24] (03PS1) 10Kaldari: Removing duplicate border on dismissable sitenotices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189538 [19:28:48] bmansurov: https://gerrit.wikimedia.org/r/#/c/189538/ [19:29:14] (03CR) 10Bmansurov: [C: 032] Removing duplicate border on dismissable sitenotices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189538 (owner: 10Kaldari) [19:30:28] (03Merged) 10jenkins-bot: Removing duplicate border on dismissable sitenotices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189538 (owner: 10Kaldari) [19:31:31] (03CR) 10Dbrant: "@BearND, Yes, I'll agree that the name of the app should come first in the widget name (done). It's just unfortunate that our brand start" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175225 (owner: 10Dbrant) [19:47:38] legoktm: hey thanks for the feedback. When adding extension.json, should the php config be removed ? [19:50:35] (03CR) 10Bgerstle: [C: 031] Add library license links to about page. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188964 (owner: 10Fjalapeno) [19:51:00] me: i'd like to respond to my colleagues code review comments! [19:51:12] gerrit: http://www.rimmkaufman.com/content/url.jpeg [19:51:29] rmoen: for now you'll need to keep both and maintain them in parallel until we switch production over, at which point we can start removing PHP entry points. (https://www.mediawiki.org/wiki/Manual:Extension_registration#Migrating) [19:53:51] coreyfloyd: so, i'm not seeing blockskit in the about page still [19:53:52] legoktm: right, I was reading that. Since our extension doesn't need to support older versions I didn't see the point in duplicating the config. [19:54:09] but, i see mantle. are we even using that? [19:54:37] bgerstle oh - give me a sec… [19:54:45] rmoen: so production is still using PHP entry points, and we want to switch everything over at once, so we need to have both temporarily (I'm estimating about a month) [19:54:51] legoktm: though its np as the maintenance script will generate the extension.json for us. So i'm ok with both [19:54:58] bearND: do we have anything for showcase? [19:55:07] legoktm: i see. [19:56:46] coreyfloyd: just rebuilt & reinstalled the app, still no BK and still seeing mantle [19:57:26] legoktm: one more question, lets imagine for some reason the two config get out of sync.. Is there a way to test against this ? [19:57:50] legoktm: or do you recommend just generating the extension.json every time a config change is made ? [19:58:13] (03PS4) 10Fjalapeno: Add library license links to about page. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188964 [19:58:22] bgerstle: there you go [19:58:24] i guess that's two related questions [20:01:00] dbrant: hmm, don't think so [20:02:12] rmoen: you coming to mobile showcase? [20:05:36] rmoen: there's no automated way to test...I guess you could run the conversion script every time or something. I have a patch waiting on CI so that jenkins will start using extension.json when running tests if it's present [20:06:48] kaldari: 1 min [20:12:15] bmansurov: do you want to show off the new wikigrok roulette stuff or should I? [20:12:32] kaldari: please do [20:13:04] NP [20:31:40] (03PS1) 10Yurik: Warn on HTTPS - take 2 [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/189553 [20:31:57] MaxSem, could you skim through ^ to tell me if you see anything major? Need to commit asap [20:32:45] bmansurov: want to talk about your translate work? [20:33:02] kaldari: it's not worth mentioning [20:33:51] I will when it's in a better shape [20:40:27] dr0ptp4kt: bgerstle coreyfloyd if anyone has some review cycles to spare later today: https://gerrit.wikimedia.org/r/#/c/188726/ [20:40:57] will take a look [20:41:04] ditto [20:41:59] mhurd: about to test [20:42:34] dr0ptp4kt: bgerstle coreyfloyd the einstein misspelling that dmitry demo’ed was useful for testing [20:44:33] mhurd: ^ (bernd demoed) :) [20:44:51] dbrant: doh! sorry bearnd! [20:45:07] (03CR) 10MaxSem: [C: 04-1] Warn on HTTPS - take 2 (035 comments) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/189553 (owner: 10Yurik) [20:46:15] mhurd: was copied from Deskana|Away [20:47:18] bearND: hehe he gave me the query params too. made it so quick/simple to implement :) [20:49:04] mhurd: the params probably came from my initial patch to bring it back. Had it originally in full text search request but got moved to prefix search request sine it's the first request we do [20:49:33] bearND: oh cool! i should have known :) [20:49:52] thx MaxSem ! [20:49:54] kaity|away: hey, can you explain what you mean by 'large crop' in the 3rd criterion at https://trello.com/c/sdP2EAbL/16-3-beta-restyle-image-title-on-tablet ? [20:50:05] coreyfloyd: bgerstle lemme know once you're done with the review. seems to be working swell on my device. [20:50:24] dr0ptp4kt: search, you mean? [20:50:27] kaity|away: do you mean tablet-03.png or tablet-06.png? [20:50:47] bgerstle: yeah, that [20:51:46] (03CR) 10Jhobs: [C: 031] Warn on HTTPS - take 2 (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/189553 (owner: 10Yurik) [20:52:26] (03CR) 10Bgerstle: "can't weigh on this w/o sufficient context. nothing obvious seem amiss, though." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188726 (owner: 10Mhurd) [20:52:40] (03CR) 10BearND: "Hmm, the same happens in master." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186942 (https://phabricator.wikimedia.org/T86982) (owner: 10BearND) [20:53:12] mhurd: ^ there are come more test inputs ^ from dbrant [20:53:31] bgerstle: if you search for a term, but don’t spell the search term correctly, the search query can return a search suggestion, and the app shows a “did you mean” button atop the search results [20:53:45] very curious indeed... /: [20:56:38] dr0ptp4kt: if you're already looking at it, i trust your judgement at this point [20:57:48] MaxSem: woohoo, thanks for the 47 comments :) I'll be looking at those right now [20:59:18] bearND: alright then; i'll merge your patch, then follow it up with a fix for the bold-highlight code. I think I know what's going on. [20:59:54] MaxSem is the king of reviews today :) [21:00:01] MaxSem, what do you mean by dbl esc in https://gerrit.wikimedia.org/r/#/c/189553/1/includes/PageRendering.php ? [21:00:42] (03PS5) 10Dbrant: Enable search suggestions in prefix search task [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186942 (https://phabricator.wikimedia.org/T86982) (owner: 10BearND) [21:02:30] dbrant: sounds great. Thanks! [21:02:57] (03CR) 10Fjalapeno: [C: 031] "Looks good to me - tried the einstien search." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188726 (owner: 10Mhurd) [21:03:13] dr0ptp4kt ^ [21:05:04] dr0ptp4kt do we need to anything with my license patch - wasn't clear from the earlier conversation? [21:06:29] (03CR) 10Dbrant: [C: 032] Enable search suggestions in prefix search task [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186942 (https://phabricator.wikimedia.org/T86982) (owner: 10BearND) [21:07:56] coreyfloyd: for https://gerrit.wikimedia.org/r/#/c/188964/ nothing that i know of - i'll do a review on that once bgerstle and mhurd give me the word to take a look. for https://gerrit.wikimedia.org/r/#/c/187251/ you're not (re)using the sppulltorefresh stuff, so i don't think anything will be needed there regarding inclusion of a license (sounds like you'll be submitting a new patch for that later). [21:08:58] dr0ptp4kt: i've already reviewed that patch and +1'd it [21:09:02] * bgerstle goes to double check [21:09:14] dr0ptp4kt yeah pull to refresh is getting an update later - just wanted to know about the about page [21:09:34] bgerstle - I resubmitted with the string fix, so your plus 1 is probabaly gone [21:09:59] wait.. [21:10:21] coreyfloyd: why are you manually adding blockskit? i thought you were automatically incorporating pods-acknowledgements? [21:11:07] yurikR, 1) escaped(), 2) Html::element() escapes attribute values too. [21:11:37] bgerstle we can only automatically import the license - the html has content that isn't in the acknowledgements, so that is still being done manual [21:12:54] * bgerstle shrug [21:13:05] i guess as long as it's in the about page at this point [21:13:10] we can redo it natively… soon... [21:16:43] bgerstle yeah - I'd prefer to have it all done automatically / natively - really all we need to do is drop the link to the project page for each library and we can go totally automated [21:16:49] 3Wikipedia-App-Android-App: Incorrect search result highlighting makes some results look weird. - https://phabricator.wikimedia.org/T89037#1026017 (10Dbrant) 3NEW [21:17:04] IMO we should. AFAIK licenses don't dictate it [21:17:12] (03PS2) 10Yurik: Warn on HTTPS - take 2 [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/189553 [21:17:19] (03PS1) 10Dbrant: Fix bold-highlighting of search results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189586 (https://phabricator.wikimedia.org/T89037) [21:17:49] (03CR) 10Yurik: "fixed msg formating to text()" (032 comments) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/189553 (owner: 10Yurik) [21:18:03] MaxSem, yes, thx. fixed ^ [21:24:31] kaldari, Maryana: do you guys know what kaity|away means in the 3rd criterion at https://trello.com/c/sdP2EAbL/16-3-beta-restyle-image-title-on-tablet ? [21:24:49] * Maryana looks [21:25:16] bgerstle yeah - we should see if we get that done in an about page redesign [21:25:36] bmansurov: the "detect resolution of lead image.." one? [21:25:57] Maryana: "large crop at top" [21:26:06] ah, right. that's just the big banner image [21:26:15] Maryana: so don't show it at all? [21:26:21] right [21:26:30] if it's too small to take up the space [21:26:46] Maryana: ok thanks, also with this change we are promoting banner images to beta? [21:26:58] bgerstle dr0ptp4kt mhurd heading to late lunch/early dinner - will be back in about an hour. If there are no problems about/license patch please merge in - otherwise i can address issues when i get back. [21:27:14] yes. i believe phuedx is working to change where that image comes from (currently wikidata, but after his patch the pageimage API) [21:27:31] Maryana: cool [21:27:40] this is the card: https://trello.com/c/26TidjN6/11-3-page-styling-to-beta [21:27:59] thanks [21:28:10] np :) [21:28:13] coreyfloyd: thx. mhurd, you all done with review on https://gerrit.wikimedia.org/r/#/c/188964/ ? not saying rush, just wondering if anything further needed on it, or if it's something i should review later this afternoon [21:29:34] bgerstle: coreyfloyd +1 to native about page!!! hopefully soon after catching up we can tackle it [21:30:20] (03CR) 10Dr0ptp4kt: "One thing." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188726 (owner: 10Mhurd) [21:30:35] mhurd: ^ one small thing [21:30:46] dr0ptp4kt: ahh cool! [21:30:50] will amend [21:36:05] (03PS3) 10Mhurd: Brought back search suggestions in efficent way. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188726 [21:36:15] dr0ptp4kt: ^ [21:37:55] yurikR, I'm lost in cases. ask aharoni ? [21:38:45] aharoni, https://gerrit.wikimedia.org/r/#/c/189553/2/i18n/en.json ? [21:39:07] MaxSem, its fine, that message won't be used from the start. Any other objections? [21:39:33] (03CR) 10MaxSem: [C: 031] Warn on HTTPS - take 2 [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/189553 (owner: 10Yurik) [21:40:37] yurikR: looking [21:40:59] yurikR: you don't need GRAMMAR:genitive in English. [21:41:12] Translators to languages that need it are supposed to add it themselves. [21:41:12] MaxSem, ? [21:41:27] nowpe:) [21:41:38] no other objections [21:42:29] oki, thanks :))) [21:42:43] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Brought back search suggestions in efficent way. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188726 (owner: 10Mhurd) [21:42:59] dr0ptp4kt: cool! thanks! [21:43:20] mhurd: thank you for putting that in. much better [21:43:25] that is, having suggestions [21:43:39] although i guess preventing non-fatals is also good ;P [21:44:00] dr0ptp4kt: hehe that too [21:45:45] (03PS3) 10Yurik: Warn on HTTPS - take 2 [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/189553 [21:46:10] (03CR) 10Yurik: [C: 032] Warn on HTTPS - take 2 [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/189553 (owner: 10Yurik) [21:47:09] (03PS1) 10Yurik: Warn on HTTPS - take 2 [extensions/ZeroBanner] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/189591 [21:47:19] (03Merged) 10jenkins-bot: Warn on HTTPS - take 2 [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/189553 (owner: 10Yurik) [21:48:41] (03PS1) 10Yurik: Warn on HTTPS - take 2 [extensions/ZeroBanner] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/189592 [21:49:06] (03CR) 10Yurik: [C: 032] Warn on HTTPS - take 2 [extensions/ZeroBanner] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/189592 (owner: 10Yurik) [21:49:32] (03CR) 10Yurik: [C: 032] Warn on HTTPS - take 2 [extensions/ZeroBanner] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/189591 (owner: 10Yurik) [21:50:13] (03CR) 10jenkins-bot: [V: 04-1] Warn on HTTPS - take 2 [extensions/ZeroBanner] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/189592 (owner: 10Yurik) [21:50:58] (03Merged) 10jenkins-bot: Warn on HTTPS - take 2 [extensions/ZeroBanner] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/189591 (owner: 10Yurik) [21:52:34] (03CR) 10Yurik: Warn on HTTPS - take 2 [extensions/ZeroBanner] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/189592 (owner: 10Yurik) [21:52:47] (03CR) 10Yurik: [C: 032] "recheck" [extensions/ZeroBanner] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/189592 (owner: 10Yurik) [21:54:16] MaxSem: Are you Trolling me about the empty lines before @param? I'm assuming you mean empty line before @param and after description on docs? I don't even see MF doing this ... [21:54:58] MaxSem: I'm almost done addressing your FB, will you be able to review again after ? or possibly +2 :) [21:55:48] (03CR) 10Manybubbles: "Thanks!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186942 (https://phabricator.wikimedia.org/T86982) (owner: 10BearND) [21:56:06] eh, it's present in MF though inconsistent [21:56:17] FB = facebook? [21:56:41] yurikR1: intended as feedback [21:56:57] I realized that was confusing, sorry [21:57:21] rmoen, http://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP :P [21:57:31] rmoen, i liked facebook better [21:57:59] rmoen, you're the only person left to +1 https://gerrit.wikimedia.org/r/#/c/188086/ btw [21:58:19] MaxSem: not seeing returns before @return :P [21:58:32] (03CR) 10Robmoen: [C: 031] Clarify license [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/188086 (https://phabricator.wikimedia.org/T88251) (owner: 10MaxSem) [21:58:51] at least there should be a line between description and params [21:58:59] dr0ptp4kt: dbrant|brb may be just a minute or two late for "the party", want to grab a snack to munch [21:59:06] and return is after the params;) [21:59:18] kristenlans: cool [21:59:43] (03Abandoned) 10Rahdev: Add defaultremote = origin to .gitreview Directory (.config) and file (git-review.conf) do not exist in the MacOSX Yosimite installation. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189432 (owner: 10Rahdev) [21:59:49] MaxSem: yes, it is after. though the page you linked does not indicate a line return is required ;) [22:00:04] But i will adhere to your standards :) [22:00:12] (03CR) 10MaxSem: [C: 032] "Weeeeee!" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/188086 (https://phabricator.wikimedia.org/T88251) (owner: 10MaxSem) [22:01:56] bgerstle: have a few minutes for hangout? [22:02:09] (03CR) 10jenkins-bot: [V: 04-1] Clarify license [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/188086 (https://phabricator.wikimedia.org/T88251) (owner: 10MaxSem) [22:02:14] sure [22:03:21] (03CR) 10MaxSem: [V: 032] Clarify license [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/188086 (https://phabricator.wikimedia.org/T88251) (owner: 10MaxSem) [22:03:33] pfft Flow [22:11:12] (03CR) 10jenkins-bot: [V: 04-1] Warn on HTTPS - take 2 [extensions/ZeroBanner] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/189592 (owner: 10Yurik) [22:12:13] (03CR) 10Yurik: [V: 032] Warn on HTTPS - take 2 [extensions/ZeroBanner] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/189592 (owner: 10Yurik) [22:20:20] 3Wikipedia-App-iOS-App: iOS-regression: 4.0.6 - the pie chart 'Geographical distribution' in 'English language' article not displayed correctly - https://phabricator.wikimedia.org/T86572#1026222 (10KLans_WMF) p:5Triage>3Normal [22:22:56] 3Wikipedia-App-iOS-App: Pencil icon displayed on image file page - https://phabricator.wikimedia.org/T86594#1026234 (10KLans_WMF) p:5Triage>3Low [22:23:17] (03PS6) 10Kaldari: Making MobileFormatter preserve the CentralAuth 1x1 images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189154 (https://phabricator.wikimedia.org/T87290) [22:23:46] 3Wikipedia-App-iOS-App: Pencil icon displayed on image file page - https://phabricator.wikimedia.org/T86594#1026238 (10dr0ptp4kt) The editing mode says 'Unable to obtain latest revision' as a gray bar along the top. [22:24:21] (03CR) 10BearND: "Thanks to you, @Manybubbles, and to @Anomie for figuring out the necessary API calls." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/186942 (https://phabricator.wikimedia.org/T86982) (owner: 10BearND) [22:25:00] 3Wikipedia-App-iOS-App: Production release for iOS Wikipedia app in February (provisional) - https://phabricator.wikimedia.org/T86692#1026240 (10KLans_WMF) Dan, how should we triage this? :-) [22:25:27] (03CR) 10jenkins-bot: [V: 04-1] Making MobileFormatter preserve the CentralAuth 1x1 images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189154 (https://phabricator.wikimedia.org/T87290) (owner: 10Kaldari) [22:27:05] 3Wikipedia-App-Android-App, Wikipedia-App-iOS-App: Address requests for Share a Fact from Legal - https://phabricator.wikimedia.org/T86843#1026245 (10KLans_WMF) p:5Triage>3Normal a:3dr0ptp4kt [22:27:50] 3Wikipedia-App-Android-App: Expanding the references makes the "Read more" section invisible until you scroll - https://phabricator.wikimedia.org/T86861#1026250 (10KLans_WMF) p:5Triage>3Normal [22:27:56] (03CR) 10BearND: [C: 032] "Good catch and fix! Thank you!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189586 (https://phabricator.wikimedia.org/T89037) (owner: 10Dbrant) [22:28:49] 3Wikipedia-App-Android-App: 'Tap here to expand' - the label should change when the section is expanded? - https://phabricator.wikimedia.org/T86860#1026255 (10KLans_WMF) p:5Triage>3Low [22:30:49] (03Merged) 10jenkins-bot: Fix bold-highlighting of search results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189586 (https://phabricator.wikimedia.org/T89037) (owner: 10Dbrant) [22:32:04] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189154 (https://phabricator.wikimedia.org/T87290) (owner: 10Kaldari) [22:33:10] 3Wikipedia-App-Android-App: Images are out of order in gallery view - https://phabricator.wikimedia.org/T86954#1026270 (10KLans_WMF) @Deskana do you know who we should escalate this to? Looks like an API problem, not necessarily an app problem. [22:33:15] (03CR) 10jenkins-bot: [V: 04-1] Making MobileFormatter preserve the CentralAuth 1x1 images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189154 (https://phabricator.wikimedia.org/T87290) (owner: 10Kaldari) [22:34:31] (03CR) 10MaxSem: [C: 032 V: 032] Making MobileFormatter preserve the CentralAuth 1x1 images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189154 (https://phabricator.wikimedia.org/T87290) (owner: 10Kaldari) [22:35:44] 3Wikipedia-App-iOS-App: The state of "Next" button in iOS-app should be disabled unless any edit has been done - https://phabricator.wikimedia.org/T87070#1026282 (10KLans_WMF) p:5Triage>3Low [22:36:34] 3Wikipedia-App-Android-App, Mobile-Apps: Edit pencil showing up on top of infoboxes. - https://phabricator.wikimedia.org/T87068#1026287 (10KLans_WMF) p:5Triage>3Normal [22:38:09] 3Wikipedia-App-Android-App: In Android app,clicking on any co-ordinate of an image map , loads the hyperlinked article on the browser not in the app - https://phabricator.wikimedia.org/T87084#1026293 (10KLans_WMF) 5Open>3Invalid [22:38:32] 3Wikipedia-App-Android-App: In Android app,clicking on any co-ordinate of an image map , loads the hyperlinked article on the browser not in the app - https://phabricator.wikimedia.org/T87084#983516 (10KLans_WMF) Problem is with wikilcnks on page not a problem in the app [22:41:13] legoktm, are you in SF today? [22:41:23] MaxSem: I am [22:41:44] 3Wikipedia-App-Android-App: IllegalArgumentException: pointerIndex out of range crashes - https://phabricator.wikimedia.org/T86166#1026306 (10KLans_WMF) p:5Triage>3Low [22:44:12] 3Wikipedia-App-iOS-App: iOS App: Table of contents slow to appear - https://phabricator.wikimedia.org/T87122#1026327 (10KLans_WMF) p:5Triage>3Low [22:44:37] 3Wikipedia-App-Android-App: Rotating screen during saved pages refresh causes it to cancel refreshing - https://phabricator.wikimedia.org/T87123#1026329 (10KLans_WMF) p:5Triage>3Low [22:45:26] 3Wikipedia-App-iOS-App: iOS App: Table of contents slow to appear - https://phabricator.wikimedia.org/T87122#1026334 (10dr0ptp4kt) We're planning in the future to maybe use a progressively displayed table of contents for swipe from right. [22:45:38] 3Wikipedia-App-Android-App: Dragging (rather than just tapping) lead image up should scroll down - https://phabricator.wikimedia.org/T87128#1026335 (10KLans_WMF) p:5Triage>3Normal [22:46:19] legoktm: Do you have any ideas for how to fix https://phabricator.wikimedia.org/T88860 ? According to Max it is broken on purpose, as we don’t want to share login across all wikimedia.org sites. [22:46:40] we don't? [22:47:02] (03PS1) 10Bmansurov: Restyle banner image and page title on tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 [22:47:09] oh, I suppose we want to exclude private wikis... [22:47:25] mhurd dr0ptp4kt is there any code for mapping copyright strings to glyphs? [22:47:34] I don't think you can set *.wikimedia.org cookies [22:47:37] dbrant: bearND, or anything from android that might "inspire" me? [22:47:43] there are private wikis under other domains like wikipedia [22:48:02] there are (were?) untrusted servers under *.wikimedia.org [22:48:21] 3Wikipedia-App-Android-App: Add explanation of app permissions used to Play Store listing - https://phabricator.wikimedia.org/T87064#1026342 (10KLans_WMF) @Deskana is there anything actionable yet from this task? Doing some triaging [22:48:25] kaldari, legoktm ^ [22:48:53] 3Wikipedia-App-Android-App: Scroll position for image description is preserved while moving through images, hiding some of them - https://phabricator.wikimedia.org/T87191#1026347 (10KLans_WMF) p:5Triage>3Low [22:49:15] 3Wikipedia-App-Android-App: Image description, when hidden, sometimes is still visible right at the bottom of the page - https://phabricator.wikimedia.org/T86577#1026351 (10KLans_WMF) p:5Triage>3Low [22:49:21] legoktm, Krenair: So any idea how we could share login between commons.wikimedia.org and commons.m.wikimedia.org, or is it just a WONTFIX? [22:49:32] MaxSem: I've addressed all of your comments. https://gerrit.wikimedia.org/r/#/c/189157/ +2 needed so we can better iterate on this tomorrow ;) [22:50:00] kaldari: I'm not sure...chris would be a better person to ask since there are security concerns... [22:50:18] 3Wikipedia-App-Android-App: Consider background for images with transparency - https://phabricator.wikimedia.org/T87250#1026352 (10KLans_WMF) p:5Triage>3Normal [22:51:10] 3Wikipedia-App-Android-App: Network error when entering gallery while reading page in another language - https://phabricator.wikimedia.org/T87071#1026362 (10KLans_WMF) p:5Triage>3Normal [22:51:32] 3Wikipedia-App-Android-App: Network error when entering gallery while reading page in another language - https://phabricator.wikimedia.org/T87071#1026364 (10Dbrant) 5Open>3Resolved a:3Dbrant [22:51:36] bgerstle: doing bug triage. heads up, pre-empt on iOS if you can: https://phabricator.wikimedia.org/T87250 [22:51:49] bgerstle: will get back to you on your question when done [22:52:05] 3Wikipedia-App-Android-App: IndexOutOfBoundsException: setSpan (? ... ?) ends beyond length ? crash - https://phabricator.wikimedia.org/T87286#1026368 (10KLans_WMF) p:5Triage>3Low [22:52:15] csteipp: We’ve been discussing if it’s possible to fix https://phabricator.wikimedia.org/T88860 or not, and apparently there are security concerns potentially blocking it. [22:52:21] ok [22:52:48] 3Wikipedia-App-Android-App: Crash from RuntimeException: No such message type registered: imageClicked - https://phabricator.wikimedia.org/T87110#1026371 (10KLans_WMF) 5Open>3Resolved p:5Triage>3Normal [22:53:03] csteipp: as we don’t want to set a cookie for *.wikimedia.org since there are untrusted and/or private wikis on that domain [22:54:42] 3Wikipedia-App-Android-App: share via Google+ error - https://phabricator.wikimedia.org/T87319#1026387 (10KLans_WMF) @Shizhao could you please list the steps to reproduce this and attach a screenshot, if possible? [22:56:10] kaldari: btw, https://gerrit.wikimedia.org/r/#/c/188962/ fixes the hidden badge bug you encountered today [22:56:21] kaldari: a review would be nice ;) [22:57:43] 3Wikipedia-App-Android-App: OutOfMemoryError crashes from some IO/string building code - https://phabricator.wikimedia.org/T86442#1026415 (10KLans_WMF) Trying to solve soem of the bigger picture issue here: https://trello.com/c/lmqPNAwC [22:58:07] kaldari: Yeah, we don't want do that, so we would need an explicit auto-login to both [22:58:32] 3Wikipedia-App-Android-App: Nearby is wrapping descriptions strangely - https://phabricator.wikimedia.org/T87401#1026421 (10KLans_WMF) 5Open>3Resolved p:5Triage>3Normal [22:58:39] kaldari: But don't you typically just hit the api on commons? Or are you actually sending users to the mobile domain? [22:59:00] stupid friends taking up my time [22:59:02] 3Wikipedia-App-Android-App: Out of space errors causing app to crash - https://phabricator.wikimedia.org/T87073#1026427 (10KLans_WMF) trying to get more info here: https://trello.com/c/lmqPNAwC [22:59:12] am going to make up the hour that i owe tomo [22:59:28] as the fam is out early [22:59:32] g'night y'all [23:00:26] 3Wikipedia-App-Android-App: Some labels still ALLCAPS - https://phabricator.wikimedia.org/T87595#1026434 (10KLans_WMF) [23:00:39] 3Wikipedia-App-Android-App: Some labels still ALLCAPS - https://phabricator.wikimedia.org/T87595#1026443 (10KLans_WMF) p:5Triage>3Low [23:01:03] 3Wikipedia-App-Android-App: Some labels still ALLCAPS - https://phabricator.wikimedia.org/T87595#994800 (10KLans_WMF) CC'ED VIBHA TO GET DESIGN INPUT (<-see what I did there) [23:02:05] (03CR) 10Bmansurov: Hygiene: Use events map in overlay files (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185929 (https://phabricator.wikimedia.org/T87193) (owner: 10Bmansurov) [23:05:34] 3Wikipedia-App-Android-App: Page image gallery starts in the middle, difficult to see all images - https://phabricator.wikimedia.org/T87622#1026452 (10KLans_WMF) @deskana another one that sounds like an API fix required to make this work in the app. Suggestions fro who to raise this with? [23:06:19] 3Wikipedia-App-Android-App: NPE crash from android.view.SurfaceView.onAttachedToWindow - https://phabricator.wikimedia.org/T86441#1026454 (10KLans_WMF) p:5Triage>3Low [23:06:23] 3Mobile-Web: Inaccessible UI elements - https://phabricator.wikimedia.org/T87670#1026456 (10bmansurov) @Jdlrobson, why shouldn't hamburger have a title? I agree, maybe label is not needed. [23:08:41] 3Wikipedia-App-iOS-App: Special:Watchlist on iOS app produces page that makes no sense - https://phabricator.wikimedia.org/T87599#1026469 (10KLans_WMF) Sjoerddebruin sound like this is fixed, shall we close this bug report? :-) [23:11:36] bgerstle: sorry was afk - there’s a burrito to blame - leftovers appeared in the kitchen. but yes there is a copyright glyph being used on the edit comfirmation page [23:11:37] 3Wikipedia-App-Android-App, Wikipedia-App-iOS-App: Leading images displayed blurry due to low resolution of the original file - https://phabricator.wikimedia.org/T87827#1026484 (10KLans_WMF) p:5Triage>3Normal [23:12:18] 3Wikipedia-App-Android-App, Wikipedia-App-iOS-App: Leading images displayed blurry due to low resolution of the original file - https://phabricator.wikimedia.org/T87827#1000103 (10KLans_WMF) @vibhabamba cc:ing you for some design wisdom [23:12:25] bgerstle: oh i was thinking of the “cc” glyph - ping me if this isn’t what you meant [23:13:29] 3Wikipedia-App-iOS-App: When the first image cannot be used as a leading img, select another another available from the page - https://phabricator.wikimedia.org/T87828#1026500 (10KLans_WMF) @deskana sounds like a feature request. Thoughts? [23:15:40] 3Wikipedia-App-Android-App: android.database.sqlite.SQLiteDiskIOException: error code 10: disk I/O error - https://phabricator.wikimedia.org/T86438#1026519 (10KLans_WMF) 5Open>3declined [23:16:15] csteipp: We want to send people to the actual mobile domain [23:16:29] 3Wikipedia-App-Android-App: SecurityException: Neither user nor current process has android.permission.WAKE_LOCK - https://phabricator.wikimedia.org/T86440#1026523 (10KLans_WMF) p:5Triage>3Low [23:17:05] 3Wikipedia-App-Android-App: NPE crash from com.android.internal.policy.impl.PhoneWindow.onKeyUpPanel - https://phabricator.wikimedia.org/T87722#1026525 (10KLans_WMF) p:5Triage>3Low [23:17:05] kaldari: and do most of the users have javascript? [23:17:13] csteipp: yes [23:17:56] csteipp: I’m fine with explicitily adding the full mobile domains to the list if that’s the best solution. Maybe we should just add commons.m.wikimedia.org for now. I’m not sure how much demand there is for meta, species, incubator, etc. [23:18:05] kaldari: cool, so even if they're not being logged in at login time, they should get logged in when they hit the actual domain [23:18:28] 3Wikipedia-App-iOS-App: "The Internet connection appears to be offline" appears when attempting to access saved pages while in airplane mode - https://phabricator.wikimedia.org/T88042#1026532 (10KLans_WMF) 5Open>3Resolved [23:18:30] yeah [23:18:44] 3Wikipedia-App-iOS-App: "The Internet connection appears to be offline" appears when attempting to access saved pages while in airplane mode - https://phabricator.wikimedia.org/T88042#1003035 (10KLans_WMF) This has been fixed and will be in the next app store release [23:18:57] dbrant, can you remind me where the app saves its articles? [23:19:17] csteipp: If you could add a brief comment to the bug with your recommendation, that would be awesome. [23:19:32] 3Wikipedia-App-Android-App: NPE crash from DateFormat.getRelativeTimeSpanString calls - https://phabricator.wikimedia.org/T88202#1026537 (10KLans_WMF) p:5Triage>3Low [23:22:23] dr0ptp4kt mhurd bgerstle anyone have a few minutes coming up to review my change? [23:22:57] coreyfloyd: sorry for delay. i was reviewing it, and then it was time for bug triage meeting. i'm resuming on the licenses patch, and should be done pretty soon. [23:23:09] mhurd: you on point with bgerstle on the glyphs question? [23:23:30] coreyfloyd: i was just about to step out for dinner [23:23:39] dr0ptp4kt: he said there's a glyph char [23:23:49] but he didn't mention anything about license "codes" to glyphs [23:23:59] which we will need for image gallery [23:24:01] Krenair: the contents are stored at /data/data/org.wikipedia/files/savedpages [23:24:33] dr0ptp4kt: bgerstle hmm not clear on what the codes reference… [23:24:48] mhurd: bgerstle you're talking about cc-by-sa icons, right? [23:24:58] (question directed at bgerstle) [23:25:09] dr0ptp4kt: yeah [23:25:14] but there's also "Fair use" [23:25:23] "Public domain" (copyright sign w/ strikethrough, IIRC) [23:25:33] dr0ptp4kt: bgerstle coreyfloyd i have to spec out a potential laptop upgrade at the moment - any quick recommendations/advice 13” vs 15”? [23:26:11] mhurd: liking my 13" retina so far [23:26:29] worked really well on the plane, HUGE difference in weight [23:26:34] hugely noticeable, that is [23:26:37] bgerstle: i can show you how to pipeline any of these into the glyph font - prob tomorrow if that’s ok? it’s a pretty simple process [23:26:51] k [23:27:04] mhurd I dont know i was on the fence - you can either get double the cores or usability on a plane [23:27:18] dbrant, we have some other records relating to them right? db rows? [23:27:20] bgerstle: would you mind scheduling a hangout for tomorrow so i don’t forget? [23:27:21] mhurd: i have an air 13''. an mbp 13'' is really nice for the additional ports and the ability to hook up to two external monitors [23:27:39] mhurd i opted for power - i wanted to make sure i could work fast - and i wanted the bigger screen away from the desk [23:27:46] mhurd it's not urgent, i'll let you know [23:27:54] bgerstle: k [23:28:06] coreyfloyd: *trade-offs… gah!* [23:28:11] coreyfloyd: TBH compile time hasn't been what's slowing me down, and 16 GB of RAM has been plenty thus far [23:28:22] coreyfloyd: on the fence as well... [23:28:25] THE 13" RETINA IS SUPERIOR IN EVERY WAY [23:28:36] ALL HAIL 13" RETINA MBP [23:28:36] lol [23:28:49] anyway, yeah [23:29:08] i had a relatively new 15" MBP retina from my last gig, and i haven't noticed a speed difference—yet [23:29:12] Yeah - i'm going to just get a 12" personal when it comes out - so I will have the fastest and the smallest laptops [23:29:18] nice [23:29:25] Krenair: the saved pages are organized in directories in the filesystem. But they're not human-readable (the directory name is an md5 of the page title). [23:29:29] well, i'm gonna step out for now [23:29:30] its the only sane solution [23:29:38] coreyfloyd: buy all the apple things ;-) [23:29:47] Krenair: and then the directory contains a json dump of the page contents [23:30:04] might be on later. see ya o/ [23:30:10] alter [23:30:14] later that is [23:33:01] (03PS1) 10Yurik: Properly HTML-escape banner text [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/189617 [23:33:20] (03CR) 10Dr0ptp4kt: [C: 04-1 V: 04-1] "Something strange happening. After tapping "License" for one of the listed libraries, and then tapping the back arrow, the "repositories" " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188964 (owner: 10Fjalapeno) [23:33:52] coreyfloyd: ^ able to reproduce? [23:33:59] (03CR) 10Yurik: [C: 032] "minor sec bugfix" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/189617 (owner: 10Yurik) [23:35:03] (03Merged) 10jenkins-bot: Properly HTML-escape banner text [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/189617 (owner: 10Yurik) [23:35:48] (03PS1) 10Yurik: Properly HTML-escape banner text [extensions/ZeroBanner] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/189618 [23:35:59] dr0ptp4kt - looking [23:36:07] (03CR) 10Yurik: [C: 032] Properly HTML-escape banner text [extensions/ZeroBanner] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/189618 (owner: 10Yurik) [23:36:31] (03PS1) 10Yurik: Properly HTML-escape banner text [extensions/ZeroBanner] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/189619 [23:36:40] (03CR) 10Yurik: [C: 032] Properly HTML-escape banner text [extensions/ZeroBanner] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/189619 (owner: 10Yurik) [23:37:10] (03Merged) 10jenkins-bot: Properly HTML-escape banner text [extensions/ZeroBanner] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/189618 (owner: 10Yurik) [23:37:34] (03CR) 10jenkins-bot: [V: 04-1] Properly HTML-escape banner text [extensions/ZeroBanner] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/189619 (owner: 10Yurik) [23:37:44] (03CR) 10Yurik: Properly HTML-escape banner text [extensions/ZeroBanner] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/189619 (owner: 10Yurik) [23:37:55] (03CR) 10Yurik: [C: 032] "recheck" [extensions/ZeroBanner] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/189619 (owner: 10Yurik) [23:38:55] (03Merged) 10jenkins-bot: Properly HTML-escape banner text [extensions/ZeroBanner] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/189619 (owner: 10Yurik) [23:40:31] 3Mobile-Web, MediaWiki-Authentication-and-authorization: Authentication sharing between desktop and mobile Commons is broken - https://phabricator.wikimedia.org/T88860#1026622 (10csteipp) We can't set the cookie for *.wikimedia.org since there are private wikis on that domain. That's why we individually login to... [23:45:58] dbrant: btw, to do the line attribution thing in phpstorm, right-click in the gutter and choose 'annotate' [23:46:36] dbrant: i realize that is like an hour late :) [23:49:18] 3Wikipedia-App-iOS-App: When the first image cannot be used as a leading img, select another another available from the page - https://phabricator.wikimedia.org/T87828#1026649 (10Deskana) p:5Triage>3Low Really good idea. I'd love for us to work on this next quarter. But right now our quarterly goals are base... [23:54:48] MaxSem: ty [23:55:35] dr0ptp4kt: got it! thx [23:59:34] dr0ptp4kt - trying to fix this real quick - hadn't really played with the HTML code - however the page is being constructed before doesn't like being called multiple times…