[00:01:52] coreyfloyd: yeah. hopefully there's a quick hack in there somehwer [00:01:56] e [00:03:27] (03CR) 10Kaldari: [C: 04-1] Promote WikiGrok Roulette to beta (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188962 (owner: 10Bmansurov) [00:03:43] rmoen, justy noticed that gather is not yet in ci so won't get merged until you kick it - do you want me to do so right now or you want to fix extension.json fiirst? [00:04:07] MaxSem: I'll fixy [00:04:14] then you can kick it if you want [00:04:37] MaxSem: good call, i forgot about ci ;/ [00:07:39] (03CR) 10Bmansurov: Promote WikiGrok Roulette to beta (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188962 (owner: 10Bmansurov) [00:07:54] (03PS3) 10Bmansurov: Promote WikiGrok Roulette to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188962 [00:09:38] MaxSem, legoktm: qq, in regards to the removing the absolute fs paths generated from convertExtensionToRegistration.php, Would the path to the extension be local to mw install ? eg: extensions/Gather ? [00:11:07] I read someone else had this issue in the Convert extensions to use extensions.json phabricator task. Not sure if include paths would then be local to the extension or the mw directory [00:13:40] dr0ptp4kt got a fix - coming up in a few [00:13:52] coreyfloyd: cool [00:18:45] (03PS5) 10Fjalapeno: Add library license links to about page. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188964 [00:18:52] dr0ptp4kt there you go ^ [00:21:27] 3Mobile-Web: The mobile Web wikicode editor loses the user-entered text - https://phabricator.wikimedia.org/T88949#1026713 (10kaldari) @Nnemo: The mobile Web wikicode editor of Wikipedia is not really a page. It's actually just an overlay that is constructed via Javascript that sits on top of the regular article... [00:22:51] rmoen: so, oncvertExtensionToRegistration should not be generating absolute paths...but if it does, the paths should be relative to dirname('extension.json') [00:23:17] legoktm: ok ty [00:23:56] coreyfloyd: about to test. [00:23:57] I will file a bug against the conversion script if you want.. it's happening on extension configs that use __DIR__ as their paths [00:24:01] legoktm: ^^ [00:24:07] rmoen: yes please [00:24:14] rmoen: "MediaWiki-Configuration" project [00:24:19] legoktm: ok np [00:34:43] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] "When this goes native, probably a good idea to make the about screen retain its scroll position when the user taps the back arrow. But fir" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188964 (owner: 10Fjalapeno) [00:35:34] dr0ptp4kt - hey forgot to address that - yeah - I can do that but prefer it be in a bug ticket since it will be a little bit of work and I want to get this merged [00:36:57] coreyfloyd: agreed [00:38:28] 3Wikipedia-App-iOS-App: Retain scroll position of About screen when user taps on a license, then taps the back arrow - https://phabricator.wikimedia.org/T89064#1026738 (10dr0ptp4kt) 3NEW [00:38:56] mhurd: coreyfloyd i'm going to be wrapping up in about 20 minutes. you guys need anything additional? [00:39:21] dr0ptp4kt: quick hangout? android question... [00:40:06] dr0ptp4kt I'm ok - nothing more from me in the next 20 - thanks for looking at the patch [00:40:59] coreyfloyd: dr0ptp4kt heading out soon as well [00:41:24] mhurd: yeah, i'll call you on hangout shortly. coreyfloyd, sure thing - have a good night [00:41:55] mhurd cool - I'll catch you guys tomorrow then - I'll still be on for a bit [01:19:56] (03PS7) 10MaxSem: Add new thumbnailing parameters to mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 [01:20:55] bmansurov: In https://gerrit.wikimedia.org/r/#/c/188962, the spinner that is shown between pages is aligning to the left of the page instead of being centered. Can you confirm that? I’m looking at it in Firefox. [01:25:06] bmansurov: looks like it’s only that way in beta mode, not alpha mode [01:29:19] (03CR) 10Kaldari: [C: 04-1] "A couple issues with the spinner..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188962 (owner: 10Bmansurov) [01:49:43] kaldari: doesn't that happen on master too? [01:50:07] bmansurov: not for me [01:50:19] kaldari: I couldn't find where I was introducing it [01:50:42] bmansurov: let me double check. maybe I was looking at alph mode in master... [01:51:19] kaldari: I mean, click on any photo on a page and see where the spinner is [01:51:51] kaldari: since the picture is not related to wikigrok, and the spinner is on the left, I thought it was not related to this patch [01:52:29] bmansurov: it might not be related to your patch, but we should fix it regardless [01:52:43] bmansurov: I could file it as a separate bug if you like [01:53:00] kaldari: no, no need, I just wanted to confirm [01:54:10] bmansurov: yep, it looks like you’re right, that alignment is already in beta master [01:55:45] kaldari: and the related change is I792c1aacafc075e86a0b060e2318e7e129c14182 i think [01:56:27] bmansurov: I’m also wondering if it’s possible to avoid the blank screen spinner entirely. It would be nice to just have the in-button spinner until the next page was ready to load. [01:57:16] kaldari: I think the next page is already ready to be loaded, we could get rid of the loading overlay now [01:57:39] bmansurov: if it looks like the left-aligned spinner problem is hard to fix, just skip it and file a bug for that. [01:57:57] bmansurov: ah, in that case, let’s just do that. [01:58:18] kaldari: the problem is that there is no spinner on the 'Contribute' menu icon [01:58:35] if the user wanted to load the next page using that button [01:58:40] * menu ietm [01:58:43] hmmm [02:01:02] bmansurov: would it be possible to only show the page spinner when the user clicks the menu item and otherwise to just use the in-button spinner? [02:01:47] kaldari: yes, but there is another case, where the next page is loaded automatically (cases where the badge is not shown) [02:02:50] (03PS4) 10Bmansurov: Promote WikiGrok Roulette to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188962 [02:02:58] kaldari: ^ should fix the spinner [02:03:44] has anyone figured out why badges don't show? [02:03:53] or should i file that bug first? :) [02:03:58] Maryana: yes [02:04:03] yes file the bug? [02:04:06] Maryana: already fixed [02:04:14] perfect :) [02:06:05] bmansurov: I think in the ‘next page is loaded automatically’ case, it would be best if that just had a spinner in the ‘Next’ button rather than briefly showing a spinner in the middle of the dialog and then showing a spinner on a blank page. How hard do you think it would be to change that? [02:06:35] kaldari: piece of cake ;)) [02:06:50] give me a couple of mins [02:07:30] wait, i think more haha [02:08:25] bmansurov: If it’s a lot of work, we can move it to a separate card. [02:09:01] kaldari: it depends, if we want to change the version B behavior too, then it should be not too hard [02:12:18] bmansurov: As long as it doesn’t actually effect what the user sees in version B. Are you talking about just rearranging some code in verison B? [02:12:49] kaldari: yeah, I was going to add the spinner to the next button to the v B template, which is used by roulette too [02:12:58] but there is another spinner there already [02:13:16] bmansurov: I think that would be fine. They should be consistant anyway [02:13:43] kaldari: it looks like a follow up patch may be a better idea [02:14:00] bmansurov: I asked Moiz about using the spinners in buttons a few days ago and he wants to migrate towards do that more (not just in WikiGrok Roulette) [02:14:14] bmansurov: a follow-up patch would be fine [02:14:16] ok sounds good [02:15:22] bmansurov: I think all that’s still needed for this patch is replacing the button text with the spinner in the badge interface (rather than having both) [02:15:34] bmansurov: sorry there wasn’t a mock for that [02:15:46] kaldari: ok will do so [02:16:41] bmansurov: in the follow-up commit you may just want to create a more generate class+subtemplate for spinners in buttons [02:16:50] generate=general [02:17:01] yeah i agree [02:22:23] (03PS5) 10Bmansurov: Promote WikiGrok Roulette to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188962 [02:23:04] kaldari: ^ [02:23:32] bmansurov: checking [02:25:26] man, vagrant is sooo slow. MaxSem: What’s the magic trick for speeding up vagrant (clean the job queue or something) [02:25:27] ? [02:25:55] bmansurov: looks good… [02:26:16] (03CR) 10Kaldari: [C: 032] Promote WikiGrok Roulette to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188962 (owner: 10Bmansurov) [02:26:20] MaxSem: yeah, let us know [02:27:14] kaldari: If you update to the latest version via `git pull` you can do `vagrant config vagrant_ram auto; vagrant config vagrant_cores auto; vagrant reload` to give it lots more ram and cpu cores [02:27:19] (03Merged) 10jenkins-bot: Promote WikiGrok Roulette to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188962 (owner: 10Bmansurov) [02:27:22] that was just merged like today [02:27:30] 3Mobile-Web: Use buttons with spinners instead of loading overlays - https://phabricator.wikimedia.org/T89069#1026935 (10bmansurov) 3NEW a:3bmansurov [02:27:42] kaldari: ^ feel free to add details [02:28:01] bd808: ooh [02:28:20] bmansurov: OK, all set now. Go get some dinner or something :) [02:28:33] That will give 1/4 of your laptop ram to Vagrant and let it see all the cores you have [02:28:36] kaldari: alright, later guys [02:28:41] night bmansurov :) [02:29:03] bd808: snazzy! [02:31:12] bd808: erg, looks like it failed :( [02:31:20] "Stderr: VBoxManage: error: Invalid virtual CPU count: 0 (must be in range [1, 32])" [02:31:28] yikes [02:31:40] weird that my virtual CPU count is 0 :P [02:32:08] there should have been a guard against 0 too [02:32:21] bd808: should I file a bug? [02:33:27] yeah. but maybe we can debug it a bit too [02:34:03] what does `sysctl -n hw.ncpu` say for you (assuming you are on an OSX laptop) [02:34:50] oh man I didn't put a guard in there for <1 [02:35:04] that's a bug for sure [02:35:17] but still wondering why you ended up with 0 [02:35:36] bd808: https://phabricator.wikimedia.org/T89070 [02:35:50] bd808: 4 [02:36:01] hmmm [02:36:07] did you run setup.sh? [02:36:17] after the git pull [02:36:21] no [02:36:29] oh. please try that [02:37:53] bd808: did that, but same error [02:37:58] so 'auto' with an older plugin would end up with the 0 value [02:38:29] bd808: can I run ‘vagrant config vagrant_cores 4’ instead? [02:38:34] yes [02:38:48] that should work with the old or new plugin version [02:39:14] what does `vagrant plugin list|grep mediawiki-vagrant` tell you? [02:39:45] mediawiki-vagrant (0.2.1) [02:39:57] ‘vagrant config vagrant_cores 4’ worked :) [02:40:01] hmmm.. you didn't get the new plugin yet [02:40:12] mediawiki-vagrant (0.3.0) is latest [02:40:15] guess not [02:42:31] so what HEAD do you have in your mediawiki-vagrant clone? [02:42:44] weird. I just ran setup.sh again and now it’s at 0.3.0 [02:42:57] hmmm [02:43:02] ghosts [02:43:09] messing with you [02:43:15] apparently [02:43:15] stupid ghosts [02:43:25] you should try auto again [02:43:29] jsut to see [02:43:32] trying... [02:44:42] bd808: seems to have worked that time :) [02:44:50] sweet! [03:16:41] 3Wikipedia-App-Android-App: NPE crashes from android.webkit.AccessibilityInjector$TextToSpeechWrapper$1.onInit - https://phabricator.wikimedia.org/T89077#1027028 (10Krenair) 3NEW [03:18:20] 3Wikipedia-App-Android-App: NPE crashes from android.webkit.AccessibilityInjector$TextToSpeechWrapper$1.onInit - https://phabricator.wikimedia.org/T89077#1027036 (10Krenair) Issue occurs apparently while Talkback is enabled on pre-4.3 devices - https://code.google.com/p/android/issues/detail?id=40944 [07:16:24] (03CR) 10Phuedx: [C: 04-2] "The BannerImage module shouldn't be promoted to beta, because it makes /another/ call to the Wikidata API. I split out that change to If8e" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 (owner: 10Bmansurov) [07:21:42] (03CR) 10Phuedx: "Also, could you base this change off of I7cad9546ca9c932b071b920ba85e0f560f5d7eb2 as they're both closely related." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 (owner: 10Bmansurov) [07:22:54] (03CR) 10Phuedx: [C: 04-1] "Page action Icons need resizing to 24px square." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 (owner: 10Phuedx) [07:31:46] (03CR) 10Florianschmidtwelzow: [C: 04-1] Hygiene: Use events map in talk feature (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [07:32:12] (03CR) 10Florianschmidtwelzow: "there wasn't a discussion about it, yet :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189213 (owner: 10Florianschmidtwelzow) [07:34:33] (03CR) 10Phuedx: "Sorry Bmansurov, it was my fault for not messaging the changes around the BannerImage module clearly." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 (owner: 10Bmansurov) [07:59:54] 3Mobile-Web: Inaccessible UI elements - https://phabricator.wikimedia.org/T87670#1027214 (10TheDJ) @bmansurov There is something very wrong here at a much deeper level I suspect. Even the desktop version of Voiceover on the mobile website is totally unable to read and control the mobile website, and we are not e... [08:00:43] 3Mobile-Web: The mobile Web wikicode editor loses the user-entered text - https://phabricator.wikimedia.org/T88949#1027215 (10Florian) a:3Florian @kaldari: it seems, that we trigger this confirm message only, if you want to leave the Overlay (with the back key of the phone or of the ovleray): https://github.co... [08:13:46] (03PS4) 10Phuedx: Promote the BannerImage module to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189000 [08:13:48] (03PS5) 10Phuedx: Promote alpha page styles to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 [08:13:50] (03PS1) 10Phuedx: Refactor the BannerImage module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 [08:13:54] (03CR) 10jenkins-bot: [V: 04-1] Promote the BannerImage module to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189000 (owner: 10Phuedx) [08:14:03] (03CR) 10jenkins-bot: [V: 04-1] Refactor the BannerImage module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 (owner: 10Phuedx) [08:15:00] (03CR) 10jenkins-bot: [V: 04-1] Promote alpha page styles to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 (owner: 10Phuedx) [08:18:29] (03PS5) 10Phuedx: Promote the BannerImage module to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189000 [08:18:31] (03PS6) 10Phuedx: Promote alpha page styles to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 [08:18:33] (03PS2) 10Phuedx: Refactor the BannerImage module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 [08:19:44] morning! [08:20:11] (03CR) 10jenkins-bot: [V: 04-1] Refactor the BannerImage module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 (owner: 10Phuedx) [08:24:23] hey joakino [08:24:44] how are you doing phuedx [08:24:51] i'm good [08:25:05] having a little battle with the banner image module [08:25:08] how're you? [08:26:02] phuedx: i'm fine, checking out emails and what happened yesterday on gerrit [08:26:32] phuedx: i'm really tired this week [08:26:37] joakino: i hear you [08:26:47] i haven't been working well this week [08:27:02] i've been finding it hard to focus because i feel tired all the damn time [08:27:09] you the same same or different? [08:28:25] i'm kind of getting a certain amount of work done because it is pretty focused on collections, but yea [08:28:54] phuedx: since we came back ive been sleeping really bad because of the cat, and that destroys me during the day [08:29:04] :( [08:30:03] phuedx: how is the family? [08:30:08] good [08:30:13] busy [08:30:24] george is just eating his breakfast [08:30:29] then they're all going out for the day [08:31:03] harry has started waking up at 5 am, which is the worst [08:32:17] it means he goes to sleep at 5:40 [08:32:20] george wakes at 7 [08:32:40] so i don't really get a proper sleep after feeding harry [08:34:29] phuedx: omg when do you sleep then [08:34:55] i usually sleep from 10:30 pm to 5:30 am [08:34:55] 10 to 5? that'd be7 hours [08:35:01] ^ that [08:35:03] phuedx: makes sense [08:35:17] but 5:30 am to 10:30 am is a /long/ day [08:35:23] that's every day [08:35:27] without fail! [08:35:50] yep, very long [08:36:04] phuedx: does he wake up crying? [08:37:07] harry? [08:37:08] no [08:37:12] just making a few noises [08:37:56] so i don't wake up abruptly [08:38:05] it also means he doesn't wake other people up ;) [08:38:09] (especially george) [08:38:12] great [08:38:45] i'm gonna get a coffee [08:40:40] ttyl [09:05:09] 3Living-Style-Guide, Tool-Labs, MobileFrontend: npm version on tools-login.wmflabs.org is incompatible with MobileFrontend package.json used by the KSS styleguide - https://phabricator.wikimedia.org/T89093#1027309 (10Spage) 3NEW [09:28:09] 3Wikipedia-App-iOS-App: Special:Watchlist on iOS app produces page that makes no sense - https://phabricator.wikimedia.org/T87599#1027355 (10Sjoerddebruin) @KLans_WMF, I only have the beta version on my iPhone. It is fixed in that version, don't know if the live version is fixed yet. Also: I don't know when a ta... [09:57:46] 3Beta-Cluster, Mobile-Web: Beta labs (except enwiki): Exception "TypeError: config is null" - https://phabricator.wikimedia.org/T89095#1027373 (10Florian) 3NEW a:3Florian [10:04:21] 3Beta-Cluster, Mobile-Web: Beta labs (except enwiki): Exception "TypeError: config is null" - https://phabricator.wikimedia.org/T89095#1027398 (10Florian) [10:08:31] 3Release-Engineering, Beta-Cluster, Mobile-Web: Warnings when running `mwscript eval.php` on deployment-prep - https://phabricator.wikimedia.org/T88093#1027428 (10Florian) [10:10:54] 3Mobile-Web: Use buttons with spinners instead of loading overlays - https://phabricator.wikimedia.org/T89069#1027436 (10Florian) Is this already used somewhere (in MobileFrontend)? Maybe i missed some changes? [10:14:36] phuedx: i've had to fix a bunch of crap since max *suggested* rob to namespace stuff, and everything was broken. This is how I'm referencing globals, what do you think: https://gerrit.wikimedia.org/r/#/c/189696/ [10:15:39] ATM everything is on the Gather namespace, but since we are on it i'm thinking on sub namespacing views and models, and remove view/model from the name. eg: CollectionsListView --> Views\CollectionsList [10:21:12] sorry joakino, was travelling to a coffee shop [10:21:24] joakino: yes [10:21:47] np [10:21:59] the only time i write FooModel rather than Model Foo is when i don't have namespaces easily available [10:22:15] (javascript) [10:22:18] ok i'll subnamespace then [10:22:21] +1 [10:22:31] don't know if the gods of php will like that, but anyways [10:22:32] make sure the directory structure follows the namespacing pattern [10:22:39] yep, mirror it right? [10:22:39] it's your extension [10:22:46] yup [10:24:01] ok thanks phuedx [10:24:11] we should also get jenkins-bot catting changes to wikimedia-mobile [10:24:16] *catting collections changes [10:24:23] not sure where the hell to do that [10:24:33] phuedx: i've been a while here this morning http://php.net/manual/en/language.namespaces.php [10:24:40] heh [10:24:51] phuedx: yeah i miss the bot pinging me on irc xd, it is like confirmation that push worked [10:24:57] ^ that [10:25:00] also visibility [10:25:03] y [10:25:20] it's hard – well… not trivial – for me to find out what you guys are up to [10:25:23] which isn't bad [10:25:25] but… [10:25:32] it's sorta nice knowing that you guys are killing it [10:27:47] we'll kill it, going pretty slow for now [10:27:51] (slang for doing really well, not, y'know, killing wikipedia) [10:28:22] fuck resourceloader [10:28:41] phuedx: do you know if there is a log where i can see what the fak that magic box is doing? [10:28:49] it's not loading icons now... [10:28:57] hhvm error log? [10:29:02] other than that, i have no idea [10:29:04] none [10:29:17] phuedx: i'm watching mediawiki-wiki-debug.log [10:29:22] ah [10:29:28] yeah, i've got nothing [10:30:41] good morning :-D [10:30:47] don't be mean with ResourceLoader! [10:31:19] you can pass &debug=true if you want the non minimified version of the resources, that helps sometime [10:31:30] also should bypass caches entirely [10:33:39] hey hashar [10:34:52] sorry for the mobilefrontend docs publishing delay :( [10:35:08] it already waited for a couple months now, so I thought another week of delay is affordable hehe [10:35:52] holy jesus: "Errors thrown from ResourceLoader during module packaging in load.php requests are caught and output in a javascript comment on top of that request response (e.g. an error in a module definition such as missing files). You can inspect them through a panel for network requests in the developer tools for your browser." [10:36:15] gotta go inspect 30 requests on the network tab to see the errors? xD [10:36:52] morning hashar [10:37:33] aren't they loaded server side as well? [10:37:55] hashar: i've seen some when files not found for css in the normal log [10:38:09] but for images/icons is just not showing anything [10:39:38] joakino: bug report plz plz plz [10:39:43] or feature request w/e [10:39:55] phuedx: still not sure if that's the problem [10:39:59] all errors should be output to a log [10:40:02] i'm just venting on irc xd [10:40:08] joakino: yeah sure [10:40:19] but if you don't have logs then how can you find out wth the problem is? ;) [10:43:29] do you have an error on the production site ? [10:43:43] if so I can help, else fix your code/dev instance *grin* [10:46:24] hashar: that's the best advice i've ever been given ;) [10:46:37] hashar === sensei [10:46:45] :P still a long way from deploying [10:48:47] hehe [10:51:03] (03PS3) 10Phuedx: Refactor the BannerImage module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 [10:51:29] ugh [10:51:32] that's going to -1 [10:52:50] (03CR) 10jenkins-bot: [V: 04-1] Refactor the BannerImage module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 (owner: 10Phuedx) [10:53:47] hashar: do you know what we should do to have the gerrit-wm bot post here updates on the gather project? [10:53:58] yeah sure [10:54:46] get http://21st-amendment.com to deliver their material at home [10:55:38] joakino: the bot code and configuration is in the git repo labs/tools/grrrit.git there is a config.yaml there to route messages between channels [10:56:13] the bot is hosted in wmflabs tools project and maintainied/deployed by volunteers [10:56:23] ok thx hashar, i'll have a look [10:56:58] we have other bots as well such as labs/tools/wikibugs2 for Phabricator (I think) [10:59:05] hashar: yea phab connection would be good too [10:59:13] i'll have a look when i have some time [10:59:13] 3Release-Engineering, Beta-Cluster, Mobile-Web: Warnings when running `mwscript eval.php` on deployment-prep - https://phabricator.wikimedia.org/T88093#1027595 (10hoo) 5Open>3Resolved Patch approved and deployed. [10:59:19] there he goes xD [10:59:23] ^ [11:01:06] (03PS4) 10Phuedx: Refactor the BannerImage module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 [11:04:02] adopting a node-style index.js might be useful for M.require [11:04:04] joakino ^ [11:04:51] M.require needs to die and we need to use commonJS and autogenerate the dependency graph [11:04:56] phuedx: ^ [11:05:17] joakino: i agree [11:05:43] or transpiled es6 modules, whatever, but something standarized [11:05:53] M.require is standardised [11:06:02] it's standardised to whatever we're doing at the time ;) [11:10:08] joakino: there are two routes [11:10:35] 1: grand sweeping vision, despair at how much javascript we have in mf, cry, never get anywhere [11:11:05] 2: draw a line in the sand, have M.require and requirejs (w/e) running in parallel [11:11:13] slowly migrate existing modules away [11:11:28] maybe even move 'em out of mf [11:11:33] i'm in favour of 1 [11:11:40] which do you prefer? [11:13:45] oh and 2 requires that we all commit to the move as a team to [11:13:55] and given that consensus in distributed systems is hard [11:14:07] i'm definitely choosing 1 ;) [11:24:21] phuedx: internet hiccup [11:24:37] but yeah, 1 is what it looks like [11:24:54] but 2 is sane [11:25:22] unless we convince pms that it's a necessary chunk of work at 2 people go heads down for a couple of days [11:25:29] (03PS6) 10Phuedx: Promote the BannerImage module to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189000 [11:25:31] (03PS5) 10Phuedx: Refactor the BannerImage module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 [11:25:49] reorderin'! [11:26:01] phuedx: we can't use third party libraries, so i'm guessing a third party module system wouldn't be accepted [11:26:19] * phuedx sighs [11:26:32] haha [11:28:02] (03CR) 10Phuedx: "The BannerImage module now uses the pageimages API in beta so I'm removing the -2." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189000 (owner: 10Phuedx) [11:29:04] you can get 3rd party libraries via mediawiki/vendor repo though :D [11:29:05] (03CR) 10Phuedx: "If you base your changes off of If8ef848e43d941454881c13eb5ff30337f4e8a30, then that'd be fine too." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 (owner: 10Bmansurov) [11:35:44] true [11:36:31] phuedx: if i have a view in namespace Gather\views and i want to use a model from Gather\models will it resolve fine without a use? [11:36:49] no [11:36:52] i'm guessing not, but might as well just ask [11:37:26] so on the view I have to do use \Gather\models as models and then reference models\Collection for example [11:37:48] or you could write "use \Gather\models\Collection;" [11:37:55] new Collection [11:38:03] hmm [11:38:22] also, it's a little easier on the eye if you uppercase your namespace names ;) [11:38:23] phuedx: does that also work for global names? like "use \Title;" and then new Title? [11:38:28] (but you totally don't have to) [11:38:33] yes [11:38:41] ooh interesting [11:38:55] but then if i uppercase it does not follow the folder names? [11:39:08] it does, but not strictly [11:39:10] anyway [11:39:14] that's by the by [11:39:19] years of reading \Foo\Bar\Baz [11:39:56] joakino_: i tend to use aliases (the `as Y` part) only when there are class name collisions [11:40:23] but using an alias to group objects is also quite nice [11:40:37] like your `new models\Collection` example [11:40:42] although it's a bit more verbose [11:41:13] so you would just do: use \Gather\models\Collection; [11:41:20] yeah [11:41:42] if you're using multiple models in the same file then maybe that works [11:42:03] though i'd argue that if your using multiple models in the same file that's indicative of complexity [11:42:28] by multiple i mean 2/3+ [11:42:37] although 3 is a lotta models! [11:42:48] xd ok [11:43:58] gonna get another cup of coffee [11:44:01] brb [12:04:37] nom nom nom [12:11:09] the coupling between the source and visual editors in our code is weird [12:12:07] visual editor overlay knows how to switch to the source overlay and vice versa [12:35:36] phuedx: yep, the coupling between classes, and members on the inheritance chain is huge in lots of places [12:42:38] Im out to the gym [13:11:44] back from lunch [13:30:10] (03CR) 10Phuedx: [C: 031] "I've left a really minor question inline. Regardless, this LGTM." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188695 (https://phabricator.wikimedia.org/T87051) (owner: 10Bmansurov) [14:25:54] yurikR: hello!, I'm looking for project to work on and I'm interested in https://www.mediawiki.org/wiki/Outreach_programs/Possible_projects#Make_Wiktionary_definitions_available_via_the_dict_protocol, especially in bringing wikitionary feature to wikipedia-mobile [14:26:42] yurikR: is this open for taking up, for I'd like to contribute in bringing this feature to both wikipedia-mobile and desktop? [14:27:32] codezee, hmm, i'm not really sure why my name is on that proposal [14:28:06] yurikR: then,could you tell whom could I contact regarding this one? [14:28:12] i think qgil is the best person to coordinate that [14:28:25] yurikR: ok, thanks! [14:28:28] i could help a bit once the project is started [14:28:33] 3Mobile-Apps, Parsoid, Mobile-Web: Support for mobile's section use cases in Parsoid HTML - https://phabricator.wikimedia.org/T78734#1028017 (10marcoil) [14:29:31] qgil: could you tell me if https://www.mediawiki.org/wiki/Outreach_programs/Possible_projects#Make_Wiktionary_definitions_available_via_the_dict_protocol, is open for taking up? [14:29:36] (03CR) 10Phuedx: [C: 031] "This LGTM." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 (owner: 10MaxSem) [14:29:54] codezee, I was looking at it now. You should ask at https://phabricator.wikimedia.org/T31229 [14:30:28] qgil: ok! [14:31:51] codezee Today we are doing some cleaning at that Possible Project pages. We are moving the list of project ideas to https://phabricator.wikimedia.org/tag/possible-tech-projects/ [14:34:39] qgil: I guess all the projects which are not very raw are being moved? [14:36:15] codezee, Yes, all are being moved, but we are just starting to check which ones still are ready to go, with mentors backing them [14:37:34] 3MediaWiki-Interface, Mobile-Web, MediaWiki-Core-Team, Parsoid: Switch MobileFrontend over to using Parsoid for its read HTML - https://phabricator.wikimedia.org/T76970#1028024 (10marcoil) [15:01:10] (03CR) 10Phuedx: WIP: recording and applying user responses (032 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [15:01:22] (03CR) 10Phuedx: WIP: recording and applying user responses (034 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [15:32:01] brb [16:11:35] (03CR) 10Phuedx: [C: 04-1] WIP: recording and applying user responses (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [16:28:56] (03Abandoned) 10Fjalapeno: Implement Pull to Refresh for saved pages. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187251 (owner: 10Fjalapeno) [16:38:54] (03CR) 10Phuedx: [C: 031] Promote talk answer feature to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189213 (owner: 10Florianschmidtwelzow) [16:39:33] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189506 (https://phabricator.wikimedia.org/T87644) (owner: 10Florianschmidtwelzow) [16:44:05] 3Beta-Cluster, Mobile-Web: Beta Cluster (except enwiki): Exception "TypeError: config is null" - https://phabricator.wikimedia.org/T89095#1028309 (10greg) [17:11:15] http://bassistance.de/wp-content/problem-factory.jpeg [17:13:19] <3 [17:13:37] Preparing to edit /etc/exports. Administrator privileges will be required... [17:13:42] * phuedx goes to make a cup of coffee [17:24:28] dbrant anything in the android js folder that is android specific? [17:26:36] (03PS2) 10Phuedx: Show edit pencil on all headings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189506 (https://phabricator.wikimedia.org/T87644) (owner: 10Florianschmidtwelzow) [17:26:56] coreyfloyd: hmm, not much that I can think of, except the bridge.js code which does the actual message passing to/from Java. [17:27:06] coreyfloyd: I don't know how that part is done in iOS. [17:27:15] ok - gotcha - thanks [17:30:38] phuedx: thanks for uploading ps2 :) [17:30:48] FlorianSW_: just testing now [17:30:49] (03PS8) 10Sumit: Overlay,Panel,Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) [17:30:57] will clarify that ps2 was just to fix the tests [17:31:52] (03CR) 10Phuedx: "PS2 fixes the failing MobileFormatterTest#testHtmlTransform test case." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189506 (https://phabricator.wikimedia.org/T87644) (owner: 10Florianschmidtwelzow) [17:31:59] (03CR) 10Phuedx: Show edit pencil on all headings (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189506 (https://phabricator.wikimedia.org/T87644) (owner: 10Florianschmidtwelzow) [17:37:48] (03CR) 10Florianschmidtwelzow: Show edit pencil on all headings (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189506 (https://phabricator.wikimedia.org/T87644) (owner: 10Florianschmidtwelzow) [17:37:54] (03CR) 10Florianschmidtwelzow: [C: 04-1] Show edit pencil on all headings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189506 (https://phabricator.wikimedia.org/T87644) (owner: 10Florianschmidtwelzow) [17:38:32] FlorianSW_: just testing if i've found a bug [17:38:43] phuedx: ok :) [17:38:52] wasn't sure about c: -1 for the doc stuff, but yeah, go for it :) [17:43:18] FlorianSW_: not a bug, caching issues! [17:43:26] i.e. bug disappears with hard refresh ;) [17:43:36] yeah, update the docs and it's mergeable [17:43:45] phuedx: If there is something to do (no matter what), i like to give a -1, that's a sign (for me and maybe other devs, too), that there is some work needed, so if i miss the e-mail, i can look at gerrit and see, which changes needs some more work. Other changes i normally doesn't look into it :P [17:43:48] Good morning/evening ;) [17:43:54] hola rmoen [17:43:57] phuedx: great :D [17:43:57] mevening! [17:44:07] hi rmoen :) [17:44:14] morvening? [17:45:02] I was looking for the right word merger but just went verbose style [17:45:18] we need to ticket this [17:45:22] (03PS3) 10Florianschmidtwelzow: Show edit pencil on all headings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189506 (https://phabricator.wikimedia.org/T87644) [17:45:24] phuedx: ^ [17:45:28] "As a remote worker, I want…" [17:46:27] FlorianSW_: lovely stuff [17:47:03] FlorianSW_: do you python? specifically, do you know of doctest? [17:47:07] phuedx: yeah, let's see, what the users say, maybe it's tooooo much if there are a lot of sections with "one-sentence-content" [17:47:22] one day, i'd like phpunit to do doctest [17:47:26] wait… [17:47:38] https://packagist.org/search/?q=doctest [17:47:41] sonofa [17:47:47] phuedx: no :/ [17:48:00] https://docs.python.org/2/library/doctest.html [17:48:19] uses documentation examples as test cases for functions [17:48:49] results in more examples in docs (!!) [17:48:54] who does't love examples? [17:48:56] *doesn't [17:49:31] 3Wikipedia-App-iOS-App: iOS-regression: 4.0.6 - Cannot save editing changes - https://phabricator.wikimedia.org/T86569#1028464 (10dr0ptp4kt) @Etonkovidove, on the 4.0.6.1 beta this doesn't seem to be reproducible. On English, a section on "The Man and Men" was able to be edited, with changes showing up after sav... [17:50:04] phuedx: you mean for MobileFrontend? [17:50:16] for EVERYTHING [17:51:14] phuedx: that sounds like a nice idea, if you want to write tests, you already give good examples for your code, very interesting [17:51:27] and always up-to-date doc is NICE! [17:51:33] ^ that [17:53:33] time for george's bath/bed time [17:53:35] back in a bit [17:54:26] (03CR) 10Phuedx: [C: 032] Show edit pencil on all headings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189506 (https://phabricator.wikimedia.org/T87644) (owner: 10Florianschmidtwelzow) [17:54:54] ok [17:54:56] now i'm gone [17:55:26] (03Merged) 10jenkins-bot: Show edit pencil on all headings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189506 (https://phabricator.wikimedia.org/T87644) (owner: 10Florianschmidtwelzow) [17:57:07] 3MobileFrontend: [Tracking] Obstacles to enable anonymous editing for MobileFrontend users - https://phabricator.wikimedia.org/T55069#1028486 (10Florian) [17:57:09] 3MobileFrontend: Show edit section icons for all sections, not just h2 - https://phabricator.wikimedia.org/T87644#1028484 (10Florian) 5Open>3Resolved a:3Florian [17:59:59] rmoen: i'll be around for about an hour, ping me regarding those patches if you need so, they are fairly small [18:00:12] joakino_: sounds good [18:01:02] rmoen: or feel free to patch at will and ping me for review [18:01:59] (03CR) 10Bmansurov: "Phuedx, Maryana was fine with promoting banner images to beta. Now I'm confused." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 (owner: 10Bmansurov) [18:03:20] 3Mobile-Web: Use buttons with spinners instead of loading overlays - https://phabricator.wikimedia.org/T89069#1028509 (10bmansurov) @Florian, it's used in WikiGrok Roulette. [18:03:28] rmoen: I was thiking that our project is a one man working 18 hours a day non-stop xd [18:03:37] with the time change and all [18:04:17] joakino_: Yeah I was just thinking about how awesome that is. [18:04:31] joakino_: nearly said the same thing to Candace last night [18:04:37] haha [18:06:37] (03CR) 10Bmansurov: Create the editor switcher buttons using oojs-ui (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188695 (https://phabricator.wikimedia.org/T87051) (owner: 10Bmansurov) [18:08:03] mhurd have a js question for you when you get settled [18:08:34] mhurd actually it can just wait until after lunch… I'm about to head out to eat [18:08:35] (03PS2) 10Bmansurov: Create the editor switcher buttons using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188695 (https://phabricator.wikimedia.org/T87051) [18:08:59] coreyfloyd: oh cool - hit me up when you get back! [18:10:58] 3Continuous-Integration, Mobile-Web: Publish MobileFrontend JS Documentation - https://phabricator.wikimedia.org/T74794#1028538 (10hashar) [18:12:08] moizsyed: are you guys off-site today too? [18:20:31] (03CR) 10Florianschmidtwelzow: [C: 04-1] "apart from my inline comments looks good, bt needs testing :)" (0310 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [18:21:43] (03PS3) 10Florianschmidtwelzow: Create the editor switcher buttons using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188695 (https://phabricator.wikimedia.org/T87051) (owner: 10Bmansurov) [18:22:32] (03CR) 10Florianschmidtwelzow: [C: 031] "LGTM, too, i would merge it, but Phuedx did the main review work, so i want to wait, if he is ok with it :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188695 (https://phabricator.wikimedia.org/T87051) (owner: 10Bmansurov) [18:23:44] (03CR) 10Florianschmidtwelzow: Add new thumbnailing parameters to mobileview (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 (owner: 10MaxSem) [18:26:55] (03PS2) 10Florianschmidtwelzow: Fix toggling when level 0 sections are used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189239 (https://phabricator.wikimedia.org/T88885) [18:27:45] Maryana, kaldari, bmansurov_ https://trello.com/c/nXel0ldz/29-change-wikigrok-frontend-to-send-responses-to-wikidata-org-instead-of-local-wiki [18:28:27] and https://trello.com/c/InOkrliI/30-add-wiki-id-parameter-to-wikigrokresponse-api [18:28:47] (03CR) 10Florianschmidtwelzow: "Should be fixed with I8d8d47cd608d59fb1723758106547f1ab137daa2 :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189239 (https://phabricator.wikimedia.org/T88885) (owner: 10Florianschmidtwelzow) [18:29:42] rad. thanks, MaxSem! [18:30:09] 3Mobile-Web, MobileFrontend: Remove mobile editing "call to registration" CTA - https://phabricator.wikimedia.org/T87508#1028604 (10Nemo_bis) >>! In T87508#1017975, @phuedx wrote: > You're right. With your approval I'd like to break point 2 out into its own user story where we can discuss it without it being tie... [18:30:10] I'm baaaaaack! [18:31:19] MaxSem: So are you also thinking that the response table will only live in the wikidata db? [18:32:04] and will collect all the responses from all the wikis [18:33:06] Deskana: welcome back! [18:34:26] (03CR) 10Bmansurov: [C: 04-1] "Isn't this patch supposed to cover "promote alpha page restyling experiment to beta: page issues, lead image, disambiguation, page actions" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 (owner: 10Phuedx) [18:35:17] MaxSem: cool [18:36:12] kaldari, Maryana, bmansurov_: Maybe i misunderstand WikiGrokRoulette or something is wrong here. In beta labs (enwiki), if i click on the contribute button in the left sidebar i see the info overlay and click "Let's go". I will be redirected and should see wikigrok questions, right? [18:36:28] yes [18:36:44] ok, i see no wikigrok [18:36:55] FlorianSW_: can you share your URL? [18:37:12] sure: http://en.m.wikipedia.beta.wmflabs.org/wiki/Emma_Goldman#wikigrokversion=c [18:39:08] bgerstle: https://github.com/montehurd/FontToSvgsToFont [18:39:21] 3Wikipedia-App-Android-App: Crash when clicking a link with a percent sign - https://phabricator.wikimedia.org/T89156#1028625 (10Krenair) 3NEW [18:40:12] FlorianSW_: something is wrong because there are no campaigns on that page. mw.config.get( 'wgWikiGrokCampaigns' ) is returning null. Any ideas, kaldari? [18:40:55] bmansurov_: but it shouldn't be in roulette if there are no campaigns, right? That would be more confusing for users :P [18:40:57] hmm, that’s weird. It was working yesterday [18:41:13] FlorianSW_: yes [18:43:18] 3Mobile-Web, MobileFrontend: Remove mobile editing "call to registration" CTA - https://phabricator.wikimedia.org/T87508#1028639 (10Florian) I think it would be relatively easy to move the cta to the end of the workflow (before the sites gets reloaded, e.g. a text like "Did you know, that you can login/register... [18:44:37] (03CR) 10Bmansurov: [C: 032] Fix toggling when level 0 sections are used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189239 (https://phabricator.wikimedia.org/T88885) (owner: 10Florianschmidtwelzow) [18:45:37] (03Merged) 10jenkins-bot: Fix toggling when level 0 sections are used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189239 (https://phabricator.wikimedia.org/T88885) (owner: 10Florianschmidtwelzow) [18:48:33] kaldari, yeah - that's the outcome of our discussion with Chris [18:49:52] MaxSem: I seem to not have sudo on deployment-bastion, but I could have sworn you added me to some group for that [18:51:48] hmm, it looks like all project members are supposed to have sudo on there :P [18:52:19] if I’m reading the Sudo policy list correctly [18:52:54] or maybe not since they don’t have a host set [18:54:10] kaldari, I see you in https://wikitech.wikimedia.org/wiki/Special:NovaSudoer [18:54:12] hmm, I’m also listed under under_NDA [18:54:19] ask in #-labs? [18:55:18] 3Mobile-Web: Mobile toggling code doesn't use the first heading to toggle - https://phabricator.wikimedia.org/T88885#1028675 (10Florian) 5Open>3Resolved [18:58:27] bearND, Deskana|Away is it palanned to add a feature to create pages with the Wikipedia android app? [19:03:45] (03CR) 10MaxSem: "@Phuedx, I was trying to get the tests work in Jerkins, but that change didn't help. Can undo it if you think it's unhelpful. It worked fo" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 (owner: 10MaxSem) [19:03:49] MaxSem: I'm getting an error while saving a page locally. Do you know how I can fix it? https://gist.github.com/anonymous/e159eb9514e7ef299c9d thanks [19:04:28] bmansurov_, what's the exception message? [19:04:42] I'ts in the above url, I didn't want to paste it here [19:04:52] Welcome back Deskana, I liked your creepy re-entry greeting. ;-) [19:04:55] no, it has only the stacktrace [19:05:12] MaxSem: "[60a5be92] Exception Caught: Redis server error: Could not insert 1 ParsoidCacheUpdateJobOnDependencyChange job(s)." [19:05:21] MaxSem: code: "internal_api_error_JobQueueError" [19:05:56] grmbl - update vagrant/reprovision/restart redis? [19:06:50] MaxSem: ok [19:06:51] thanks [19:07:43] yo [19:07:56] (03PS8) 10MaxSem: Add new thumbnailing parameters to mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 [19:08:13] dbrant & bearND hey! i have a couple image gallery questions [19:08:46] (03CR) 10jenkins-bot: [V: 04-1] Add new thumbnailing parameters to mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 (owner: 10MaxSem) [19:08:57] coreyfloyd: hi corey, i saw you abandoned the pull to refresh patch. starting over on that? need any help syncing with design? i can track people down [19:08:57] fuck you jerkins [19:11:37] boo jerkins [19:11:48] dr0ptp4kt Thanks I'm ok for now - spoke to Vibha last night. She wants to sync up with Dan before we finish it. [19:12:01] FlorianSW_: IMHO we should add that, but I don't see it on the horizon. But Deskana|Away would have the authoritative answer. [19:12:07] coreyfloyd: cool [19:12:20] bgerstle: ? [19:12:28] bearND: ok, thanks :) [19:14:09] MaxSem: you know the jerkins setup better than i, if that's what jerkins wants, then i'll have to accept it [19:14:26] (03CR) 10MaxSem: WIP: recording and applying user responses (033 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [19:16:00] dbrant: where might i find your extmetadat[LicenseShortName] => copyright glyph code? [19:16:11] or, can you tell me the LIcenseShortName values you're looking for? [19:16:21] or better yet, some documentation for what they might be? [19:16:25] (03CR) 10Phuedx: WIP: recording and applying user responses (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [19:16:30] Deskana: done w hangout [19:16:39] mhurd you have some free time coming up to hangout ? [19:16:50] coreyfloyd: ya! now? [19:16:59] bgerstle: we haven't implemented that part yet; we're just displaying the license string as-is. [19:17:19] sure [19:17:26] (03CR) 10MaxSem: WIP: recording and applying user responses (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [19:17:27] ohhh [19:17:37] eeenterrresting [19:19:13] (03CR) 10MaxSem: WIP: recording and applying user responses (032 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [19:20:17] (03PS20) 10MaxSem: WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [19:21:17] (03CR) 10jenkins-bot: [V: 04-1] WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [19:23:22] (03PS7) 10Phuedx: Promote alpha page styles to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 [19:24:14] (03CR) 10jenkins-bot: [V: 04-1] Promote alpha page styles to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 (owner: 10Phuedx) [19:24:21] 3Mobile-Web: Mobile toggling code doesn't use the first heading to toggle - https://phabricator.wikimedia.org/T88885#1028731 (10Thnidu) Thanks. [19:25:04] (03CR) 10Bmansurov: [C: 04-1] Refactor the BannerImage module (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 (owner: 10Phuedx) [19:25:35] Maryana, we need to discuss EL schema changes with DarTar [19:26:00] MaxSem: I’m seeing Maryana in 5, adding this to the agenda [19:28:44] (03PS8) 10Phuedx: Promote alpha page styles to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 [19:29:24] (03CR) 10Phuedx: Refactor the BannerImage module (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 (owner: 10Phuedx) [19:29:39] (03CR) 10jenkins-bot: [V: 04-1] Promote alpha page styles to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 (owner: 10Phuedx) [19:31:51] (03PS9) 10Phuedx: Promote alpha page styles to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 [19:32:03] not sure what the phpunit-zend failure is all about [19:32:40] (03CR) 10jenkins-bot: [V: 04-1] Promote alpha page styles to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 (owner: 10Phuedx) [19:32:59] (03CR) 10Phuedx: "Not the lead image as that's covered in follow-on patches. However, I did forget the page issues and last modified changes." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 (owner: 10Phuedx) [19:34:18] MaxSem: I’m trying to work on a lightncandy implementation that uses eval() instead of a pre-compiled template (per Krinkle), but I’m not having any luck. Do you have any time to take a look at what I’m doing? [19:34:55] eh? NO EVAL IN WEB-ACCESSIBLE CODE! XD [19:35:38] MaxSem: that’s what Krinkle wants and csteip said was OK :P Personally, I think it’s a terrible idea. [19:36:16] (03CR) 10MaxSem: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188272 (owner: 10MaxSem) [19:36:44] kaldari, where's the patch? [19:36:54] * phuedx is curious about this patch too [19:37:11] whew [19:37:15] it ain't just me [19:37:22] jerkins is screwing you too MaxSem [19:37:23] \o/ [19:38:59] (03CR) 10Phuedx: [C: 032] "This LGTM. Nice work!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188695 (https://phabricator.wikimedia.org/T87051) (owner: 10Bmansurov) [19:40:03] (03Merged) 10jenkins-bot: Create the editor switcher buttons using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188695 (https://phabricator.wikimedia.org/T87051) (owner: 10Bmansurov) [19:40:17] 👍 [19:41:30] (03CR) 10Phuedx: "We'll be promoting banner images, but after it's had a little TLC so that it can use the pageimages API." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 (owner: 10Bmansurov) [19:42:27] well obviously jenkins likes bmansurov_ [19:42:44] 3Mobile-Web: VisualEditorOverlay toggle between wikitext and visual editor should use OO.ui.PopupToolGroup - https://phabricator.wikimedia.org/T87051#1028776 (10phuedx) 5Open>3Resolved [19:42:44] mhurd: Let's grab lunch together and talk about it. [19:42:57] phuedx: jenkins is a friend of mine, it's ok with my patches, but not yours ;) [19:43:09] bmansurov_: how did you find the integration? [19:43:13] yeah, obvs :/ [19:43:22] not sure [19:43:35] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 (owner: 10Phuedx) [19:43:43] * phuedx crosses fingers [19:43:48] Deskana: sounds good! [19:46:01] MaxSem, phuedx: discussing in #wikimedia-dev [19:46:35] bmansurov_: any notes that you could share with mobile folk? [19:47:01] (03PS6) 10Phuedx: Refactor the BannerImage module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 [19:47:37] mhurd: I think I'll be out of this in about 15 minutes or so [19:47:47] phuedx: about what? jenkins? [19:48:05] no the oojs-ui stuff! [19:48:09] :D [19:49:04] phuedx: I haven't documented what I learned from TrevorParscal yet, but I'll try to write something up [19:49:16] that'd be super-helpful [19:49:28] phuedx: I agree [19:53:45] kaldari: did you ever get to the bottom of the page impression data loss in WG? [19:54:16] no, but I revised that code a bit [19:54:28] kk [19:54:37] Maryana, bmansurov_, kaldari: did i miss something with those two new wikigrok cards? [19:54:51] which ones? [19:54:51] https://trello.com/c/nXel0ldz/29-change-wikigrok-frontend-to-send-responses-to-wikidata-org-instead-of-local-wiki [19:55:00] and https://trello.com/c/InOkrliI/30-add-wiki-id-parameter-to-wikigrokresponse-api [19:55:11] * phuedx isn't sure where they came from [19:55:14] MaxSem: ebernhardson solved my eval problem, BTW, so no worries [19:55:47] phuedx: ah. yes. should send out team note :) [19:56:05] from convos with wikidata & chris steipp. anyway, those cards should go to the backlog, not this sprint [19:56:08] * Maryana does [19:56:54] Maryana: would be good to have Max look at the email before it’s sent out to add any technical details and make sure you guys are on the same page. [19:57:04] MaxSem: ^ [19:57:17] actually, max, you should just write an update :) [19:57:23] & send to mobile-tech [19:57:38] Maryana, eh? they're needed sooner than later [19:57:52] will do once we have the schema discussion [19:57:54] MaxSem: let's talk when i'm out of this meeting [20:00:57] MaxSem: was there something you wanted to talk about with dartar & leila? i let them know about the new aggregation & pushing wikidata requirements [20:02:44] (03PS7) 10Phuedx: Refactor the BannerImage module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 [20:03:00] * phuedx glares at jerkins [20:04:40] (03CR) 10Phuedx: Refactor the BannerImage module (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 (owner: 10Phuedx) [20:04:46] gonna head off for the night [20:04:48] it's 8pm [20:04:50] time to sleep! [20:06:08] i'm leaving too [20:06:44] rmoen: send me an email or mention me on trello with anything you want me to check tomorrow! [20:07:30] joakino_: will do [20:07:45] gn o/ [20:07:50] gn :) [20:09:06] (03Abandoned) 10Yurik: TLS support [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/184995 (owner: 10Yurik) [20:09:32] (03Abandoned) 10Yurik: Show noscript HTTPS to HTTP tap if HTTPS charged [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/180800 (owner: 10Dr0ptp4kt) [20:09:44] (03Abandoned) 10Yurik: Enhance unsupported HTTPS options [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/181194 (owner: 10Dr0ptp4kt) [20:27:26] mhurd: yeah [20:27:33] mhurd: offsite today too [20:27:36] mhurd: and tomorrow [20:27:44] mhurd: design conference [20:27:50] (03PS1) 10Cmcmahon: QA: update ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189788 [20:28:35] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189788 (owner: 10Cmcmahon) [20:29:37] (03CR) 10jenkins-bot: [V: 04-1] QA: update ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189788 (owner: 10Cmcmahon) [20:29:44] (03Merged) 10jenkins-bot: QA: update ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189788 (owner: 10Cmcmahon) [20:44:07] coreyfloyd: do you happen to have an iOS 6 device? i'm wondering if you need an iPod Touch 4th generation or if you're already set with an iOS 6 device [20:44:38] coreyfloyd: the iPod Tough 4th generation will be fine, just don't want to send anything unnecessarily [20:45:43] dr0ptp4kt I THINK I do… but I have to unpack some boxes before I know for sure. I should know this weekend when I get back home [20:46:50] coreyfloyd: okay, i'll set a reminder to check back in on that next week [20:48:59] coreyfloyd: Hey Corey! [20:49:13] Deskana hey yo [20:49:19] bgerstle: i'm planning to get you an iPod Touch 4th generation so you don't have to fiddle with antennas and such [20:49:36] bgerstle: just getting the formal approval on the devices [20:50:00] bgerstle and coreyfloyd i'll be having some nexus s devices shipped your way. i'll follow up on the devices email thread [20:50:44] ok, thanks dr0ptp4kt [20:50:49] bgerstle: sure thing [20:51:14] (03PS1) 10Cmcmahon: QA: editor switcher controls became generic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189792 [20:53:20] coreyfloyd: I'm just looking at the cards for the pull to refresh. [20:53:36] coreyfloyd: I'm a bit unclear on its status, was looking for a bit of clarification. [20:55:02] Deskana put a message on there about Vibha wanting to talk with you (I think today?) before anything goes in - TL;DR - she didn't intend on this feature to be pulled forward so fast and wants to make sure it makes sense before finishing implementation [20:56:01] Deskana she asked me to table it until after you talk [20:56:29] coreyfloyd: The reason I'm confused is because I don't know what "it" is. [20:56:43] coreyfloyd: I've not seen any of the work that's gone on on this so far, so it's hard for me to know whether to tell you to carry on or not. [20:56:52] coreyfloyd: Do you have a link to the work you've done so far on it so I can evaluate that? [20:57:08] kaldari: I put you on the review for https://gerrit.wikimedia.org/r/#/c/189792 in case you wanted to chime in on losing the specific locator for "editor-switcher" to the generic locator for the same element "oo-ui-indicatorElement-indicator". I'm not super happy about it, but it seems to be the way things go. [20:57:26] Deskana "it" == "pull to refresh saved pages" [20:57:43] (03CR) 10Bmansurov: [C: 032] Promote alpha page styles to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 (owner: 10Phuedx) [20:57:59] coreyfloyd: She asked you to table working on it at all? [20:58:11] Deskana yes [20:58:29] chrismcmahon: hmm, that’s not good [20:58:41] Deskana I can send you a link to the current state [20:58:49] coreyfloyd: That would be good. Thanks! [20:59:26] phuedx, bmansurov_: This broke the browsers tests for the editor switcher: https://gerrit.wikimedia.org/r/#/c/188695/ [20:59:48] kaldari: ok, I'll debug it [21:00:16] (03Merged) 10jenkins-bot: Promote alpha page styles to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188813 (owner: 10Phuedx) [21:00:58] bmansurov_: chrismcmahon already debugged: https://gerrit.wikimedia.org/r/#/c/189792/. Would be good if we could just restore those css classes on the elements. [21:01:09] kaldari: k [21:01:21] coreyfloyd: In addition, I'll set something up for Vibha, myself, Adam and you to talk about this. It sounds like there's a bit of miscommunication. [21:01:37] bmansurov_: I assume there should be some way to add CSS classes in OOjs UI. If not, we can merge chris’s patch instead. [21:02:15] kaldari: i think it's better to merge the tests because the patch didn't need those classes and thus were removed [21:02:38] kaldari: bmansurov_ I'll let y'all call it. If you want the test to pass today, merge that change, otherwise leave a comment and I'll follow up with whatever happens. [21:02:44] kaldari: oh wait, actually, we should add classes [21:02:55] chrismcmahon: ok [21:03:29] otherwise otherwise merge the change, and I'll wait for the test to fail again later :-) [21:03:52] bmansurov_: I’m OK either way. I’ll leave it to your judgement. [21:03:52] Deskana sounds good [21:03:57] Deskana here you go: https://github.com/coreyfloyd/apps-ios-wikipedia/tree/feature/saveRefreshSquash [21:04:24] coreyfloyd: Is it in gerrit? I don't do github very well. [21:04:30] (03CR) 10Cmcmahon: "the change that broke the test was https://gerrit.wikimedia.org/r/#/c/188695/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189792 (owner: 10Cmcmahon) [21:04:40] Deskana - its abondaned in gerrit [21:04:46] Oh. [21:04:50] Well, yes, miscommunication indeed. [21:04:53] I can push up again [21:05:04] coreyfloyd: No, that sounds indicative of some other problem. [21:05:24] coreyfloyd: So, let's just chat over hangout. Carry on with your other stuff for now. [21:05:28] coreyfloyd: Thanks. :-) [21:05:37] Deskana sounds good [21:09:07] mhurd - quick question, want to grab some CSS from android and test it out real quick without converting to LESS - whats the easiest way to do that? [21:10:04] coreyfloyd: iirc you can put straight css in less file [21:10:22] ok cool [21:10:25] mhurd thanks [21:12:18] Deskana: have 10 min to chat about “other meanings/ page issues” [21:20:34] stepping out for eye doctor. bbl [21:21:40] SEE you later bgerstle [21:21:42] haha [21:21:44] hahahh [21:30:00] coreyfloyd: FYI, the Android CSS files are derived from the LESS files in the MobileApp extension. [21:30:16] bearND thanks! [21:31:25] bearND do you modify the LESS for app specific styles? [21:31:39] coreyfloyd: the main differences betwene Android and iOS are that in Android we bundle the css with the app (while iOS downloads it dynamically), and that we have a dark (aka night) mode [21:33:04] coreyfloyd: the app specific stuff is in MobileApp ext. while this gets the rest from MFE. [21:33:51] mhurd: Backed up in meetings! I'll try to chat as soon as I can. [21:37:33] coreyfloyd: ios bundles *and* downloads the css, but we’ve had problems with the downloads in that upstream changes enter the app basically untested. so anyway we were planning on removing the dynamic download of the css (commenting out a couple lines) and just using the bundled css as android does [21:37:51] Deskana: no rush! [21:37:57] mhurd thanks [21:38:04] arg. issues with IRC/wifi today. anybody desperately pinging me out there? [21:39:52] (03PS7) 10Florianschmidtwelzow: Hygiene: Move wgResourceLoaderLESSVars out of extension function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187947 [21:40:39] (03PS1) 10Chad: Remove obvious function-level profiling [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/189829 [21:40:40] i will take that as a no. [21:43:01] bearND did you see my PM? [21:46:47] coreyfloyd: not initially [21:47:16] bearND - i think i found it though - the text "Quick Facts" [21:47:33] coreyfloyd: ah, good [21:48:05] coreyfloyd: Yeah, that text gets injected from the Java code since it needs to be localized [21:48:37] bearND Ok thanks - need to see how we do that on our end [21:49:41] mhurd do we do any localization within html right now? can you point me to the code? [21:50:45] coreyfloyd: yes the last modified and article history stuff that gets injected at the bottom of articles [21:50:56] mhurd thanks [21:51:03] coreyfloyd: in Android you can find what we inject in PageViewFragmentInternal.displayLeadSection(). See lines starting with 'leadSectionPayload.put'. [21:51:30] bearND ok cool - will check that out. [21:51:46] coreyfloyd: sorry it’s the “Modified x days ago by …” and the “You can read this in x other languages” at the bottom of articles [21:52:17] tfinc: i emailed you with spec [21:55:22] FlorianSW_: does "{$config->get( 'MFDeviceWidthTablet' )}px" work? [21:55:41] http://3v4l.org/FLXHt :o apparently [21:56:17] legoktm: why not? It's php :D [21:56:27] >.> [21:56:43] (03CR) 10Legoktm: [C: 032] Hygiene: Move wgResourceLoaderLESSVars out of extension function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187947 (owner: 10Florianschmidtwelzow) [21:57:44] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move wgResourceLoaderLESSVars out of extension function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187947 (owner: 10Florianschmidtwelzow) [21:58:58] (03CR) 10Legoktm: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187947 (owner: 10Florianschmidtwelzow) [22:02:34] MaxSem: Why is it possible for me to set a PHP member var with: “var $myDir = __DIR__’;”, but not “var $myDir = __DIR__.'/test’;”? The 2nd throws a parse error. [22:03:13] (03CR) 10Legoktm: [C: 032] Hygiene: Move wgResourceLoaderLESSVars out of extension function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187947 (owner: 10Florianschmidtwelzow) [22:03:20] because first is a constant while the second contains a string operation [22:03:45] and yeh, this is stupid because the second can be evaluated statically too [22:03:51] ah [22:03:59] that sucks :P [22:04:14] (03Merged) 10jenkins-bot: Hygiene: Move wgResourceLoaderLESSVars out of extension function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187947 (owner: 10Florianschmidtwelzow) [22:04:55] hmm, or not... in any case reasonable languages permit such syntax [22:06:12] (03CR) 10Legoktm: [C: 04-1] "Needs rebase :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187948 (owner: 10Florianschmidtwelzow) [22:07:27] FlorianSW_: woot! [22:08:56] legoktm, how can I check if a wiki other than the curent one is in CentralAuth? [22:09:11] legoktm: will rebase this tomorrow, now i have no time :/ [22:09:51] MaxSem: CentralAuthUser::getWikiList() [22:10:02] FlorianSW_: sounds good :) [22:22:57] legoktm, danke:) [22:26:08] (03PS1) 10Chad: Remove obvious function-level profiling [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/189850 [22:26:17] (03CR) 10Legoktm: [C: 032] Remove obvious function-level profiling [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/189829 (owner: 10Chad) [22:27:26] (03Merged) 10jenkins-bot: Remove obvious function-level profiling [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/189829 (owner: 10Chad) [22:30:32] (03CR) 10Legoktm: [C: 032] Remove obvious function-level profiling [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/189850 (owner: 10Chad) [22:31:27] mhurd you available for a chat? [22:31:57] coreyfloyd: ya in 5 min? [22:32:07] sure [22:32:27] (03Merged) 10jenkins-bot: Remove obvious function-level profiling [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/189850 (owner: 10Chad) [22:55:07] (03PS1) 10Yurik: Fix URL domains (minor) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/189858 [22:57:47] (03PS2) 10Florianschmidtwelzow: Hygiene: Move SpecialNearby registration out of extension function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187948 [22:58:18] legoktm: ^ [22:59:56] FlorianSW_: is it already tomorrow for you? :P [23:00:09] now yes, it's 00:00 :D [23:02:06] (03CR) 10Legoktm: Hygiene: Move SpecialNearby registration out of extension function (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187948 (owner: 10Florianschmidtwelzow) [23:03:41] (03CR) 10Florianschmidtwelzow: [C: 04-1] Hygiene: Move SpecialNearby registration out of extension function (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187948 (owner: 10Florianschmidtwelzow) [23:03:58] ok, that i make "tomorrow", now i need to go to bed :D [23:04:02] good night all! [23:04:55] :) night FlorianSW_ [23:05:17] legoktm: what's the time in your zone? [23:05:26] 3pm [23:06:09] oh, then: have a nice day :P [23:36:17] 3Wikipedia-App-Android-App: Returning to the main home screen and back -the main page is displayed instead of recent search - https://phabricator.wikimedia.org/T89186#1029472 (10Etonkovidova) 3NEW [23:37:40] Krinkle: I reimplemented the server-side templating code as a class that provides cachable dynamically compiled templates: https://gerrit.wikimedia.org/r/#/c/187728/ [23:38:26] it has 2 layers of caching actually [23:49:58] kaldari: Sounds exciting! [23:54:10] 3Wikipedia-App-Android-App: Gallery: gif images are not animated - https://phabricator.wikimedia.org/T89189#1029512 (10Etonkovidova) 3NEW [23:56:40] 3Wikipedia-App-Android-App: Gallery: gif images are not animated - https://phabricator.wikimedia.org/T89189#1029531 (10Krenair) [23:56:42] 3Wikipedia-App-Android-App: GalleryActivity does not animate gifs - https://phabricator.wikimedia.org/T85766#1029532 (10Krenair)