[00:07:56] 3Mobile-Web: The mobile Web wikicode editor loses the user-entered text - https://phabricator.wikimedia.org/T88949#1033030 (10kaldari) @nnemo Actually it looks like the behavior I was describing only applies if you hit the back button while in the editor. If you leave the editor by entering a new URL or loading... [00:16:55] (03PS1) 10Mhurd: Fix for RTL lang bracket problem in About page license links. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190124 [00:17:28] 3Mobile-Web: Mobile-frontend-time-* messages need better documentation - https://phabricator.wikimedia.org/T87144#1033050 (10Amire80) 5Open>3Resolved p:5Triage>3Low a:3Amire80 [00:17:44] 3Mobile-Web: Mobile-frontend-time-* messages need better documentation - https://phabricator.wikimedia.org/T87144#984689 (10Amire80) I update the qqq documentation in translatewiki.net. [00:19:03] dr0ptp4kt: rather than amending your commit again i just did a separate branch for the bidirectional bracket fix [00:19:17] mhurd: cool [00:31:24] (03PS1) 10Mhurd: Prevent license text size from growing on rotate. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190129 [00:32:13] 3Mobile-Web, MobileFrontend: "Last modified .." flashes on screen, then replaced by "Last modified .." - https://phabricator.wikimedia.org/T89219#1030118 (10kaldari) The message differing significantly is on purpose, as this was dictated by product/design. Apparently the same message was tried on desktop, but pe... [00:37:59] 3Mobile-Web, MobileFrontend: "Last modified .." flashes on screen, then replaced by "Last modified .." - https://phabricator.wikimedia.org/T89219#1033144 (10kaldari) @Jaredzimmerman-WMF @MSyed On desktop the interface says: "This page was last modified on 10 January 2015, at 12:25". On mobile it says: "Last edit... [00:41:11] 3Mobile-Web, MobileFrontend: "Last modified..." text differs between desktop and mobile - https://phabricator.wikimedia.org/T89219#1033149 (10kaldari) [00:42:57] 3Mobile-Web: "Last modified .." flashes on screen, then replaced by "Last modified .." - https://phabricator.wikimedia.org/T89310#1033151 (10kaldari) 3NEW [00:43:36] 3Mobile-Web, MobileFrontend: "Last modified..." text differs between desktop and mobile - https://phabricator.wikimedia.org/T89219#1033161 (10kaldari) I split off a separate bug for the flash issue: T89310 [00:44:10] 3MediaWiki-Core-Team, MobileFrontend, Mobile-Web: "Last modified..." text differs between desktop and mobile - https://phabricator.wikimedia.org/T89219#1033164 (10kaldari) [00:53:45] bmansurov : when you have some time, can you please translate https://translatewiki.net/w/i.php?title=Special:Translate&group=ext-contenttranslation&language=uz&filter=!translated&action=translate ? [00:54:21] aharoni: ok [00:55:42] 3MediaWiki-extensions-CentralAuth, Mobile-Web: CentralAuth AutoLogin not working from mobile site Main Pages - https://phabricator.wikimedia.org/T87290#1033189 (10kaldari) Want to make sure this doesn't significantly affect the formatting of the Main Page. Here's a screenshot of the English Wikipedia Main Page b... [01:02:02] (03PS8) 10Bmansurov: Refactor the BannerImage module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 (owner: 10Phuedx) [01:06:36] (03PS7) 10Bmansurov: Promote the BannerImage module to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189000 (owner: 10Phuedx) [01:07:36] (03CR) 10jenkins-bot: [V: 04-1] Promote the BannerImage module to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189000 (owner: 10Phuedx) [01:08:03] (03PS2) 10Bmansurov: Restyle banner image and page title on tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 [01:09:03] (03CR) 10jenkins-bot: [V: 04-1] Restyle banner image and page title on tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 (owner: 10Bmansurov) [01:09:19] (03PS8) 10Bmansurov: Promote the BannerImage module to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189000 (owner: 10Phuedx) [01:09:55] (03PS3) 10Bmansurov: Restyle banner image and page title on tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 [01:11:27] (03CR) 10MaxSem: [C: 032] Always run the mobileview API image tranform tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189958 (owner: 10Phuedx) [01:11:44] (03CR) 10Bmansurov: [C: 032] Promote the BannerImage module to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189000 (owner: 10Phuedx) [01:12:42] (03CR) 10Bmansurov: "Phuedx, sorry, I had to rebase your patch. Also, please see my comments in Patchset 7." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 (owner: 10Phuedx) [01:12:49] (03Merged) 10jenkins-bot: Always run the mobileview API image tranform tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189958 (owner: 10Phuedx) [01:13:59] (03CR) 10Bmansurov: "Phuedx, please review again. I have rebased this patch on your patch." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 (owner: 10Bmansurov) [01:17:20] (03PS9) 10Dr0ptp4kt: Enhanced sharing with cards [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293 [01:33:05] 3Mobile-Web: 'Close' button does not clear search criteria on the full-text Search Result page - https://phabricator.wikimedia.org/T88631#1033340 (10Maryana) I think all that's needed for this is for the same clear button that we use for normal search to be added to search-within-pages search. [01:34:43] 3MediaWiki-extensions-CentralAuth, Mobile-Web: CentralAuth AutoLogin not working from mobile site Main Pages - https://phabricator.wikimedia.org/T87290#1033343 (10Maryana) 5Open>3Resolved [01:39:08] 3Mobile-Web: Alpha: Wrong position for the last edited bar when images are present on the page - https://phabricator.wikimedia.org/T88499#1033352 (10Maryana) Not seeing this in alpha anymore. Can you confirm, @Bmansurov? [01:39:29] * bmansurov looking [01:43:48] 3Mobile-Web: Alpha: Wrong position for the last edited bar when images are present on the page - https://phabricator.wikimedia.org/T88499#1033372 (10bmansurov) Looks like it's gone. [01:45:19] 3Mobile-Web: UI elements Inaccessible by screen reader - https://phabricator.wikimedia.org/T87670#1033374 (10kaldari) [01:45:31] 3Mobile-Web: UI elements inaccessible by screen reader - https://phabricator.wikimedia.org/T87670#996513 (10kaldari) [01:54:03] 3MediaWiki-API, Mobile-Web: commons images are always "Last updated 0 seconds ago" - https://phabricator.wikimedia.org/T84906#1033389 (10kaldari) [01:54:11] 3MediaWiki-API, Mobile-Web: commons images are always "Last updated 0 seconds ago" - https://phabricator.wikimedia.org/T84906#1033390 (10Maryana) [01:54:29] 3MediaWiki-API, Mobile-Web: commons images are always "Last updated 0 seconds ago" - https://phabricator.wikimedia.org/T84906#1033392 (10kaldari) [01:57:26] 3Mobile-Web: MobileFrontend and $wgUseFileCache - https://phabricator.wikimedia.org/T78021#1033394 (10kaldari) a:3MaxSem [02:02:49] 3Mobile-Web: Alpha: Wrong position for the last edited bar when images are present on the page - https://phabricator.wikimedia.org/T88499#1033401 (10Maryana) 5Open>3Resolved [05:23:59] (03PS1) 10Mhurd: Updated contributors list. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190155 [05:53:06] (03CR) 10Phuedx: "Bmansurov: that's fine. I rebase other people's patches all the time. I'm really not precious about my patches." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 (owner: 10Phuedx) [05:54:04] (03PS3) 10BearND: ShareAFact: add preview + redesign [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189872 (https://phabricator.wikimedia.org/T86843) [05:54:09] (03CR) 10jenkins-bot: [V: 04-1] ShareAFact: add preview + redesign [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189872 (https://phabricator.wikimedia.org/T86843) (owner: 10BearND) [06:00:07] (03PS4) 10BearND: ShareAFact: add preview + redesign [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189872 (https://phabricator.wikimedia.org/T86843) [06:02:58] (03CR) 10jenkins-bot: [V: 04-1] ShareAFact: add preview + redesign [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189872 (https://phabricator.wikimedia.org/T86843) (owner: 10BearND) [06:32:28] 3Mobile-Web: The mobile Web wikicode editor loses the user-entered text - https://phabricator.wikimedia.org/T88949#1033571 (10Florian) Can reproduce this in mobile chrome for android, same for chrome desktop. The page reloads instead of loaded from cache. In Firefox on desktop, i can see the bahaviour described... [07:03:03] 3MediaWiki-Core-Team, MobileFrontend, Mobile-Web: "Last modified..." text differs between desktop and mobile - https://phabricator.wikimedia.org/T89219#1033590 (10Jaredzimmerman-WMF) I'd propose that we merge on a consistant "Last edited 1 month ago by Hafspajen" but have a tooltip on the simplified time, with t... [07:40:09] (03CR) 10Aaron Schulz: "That doesn't matter to me. If PHPUnit wants warnings to fail tests with exceptions, it doesn't matter if we also use Exception. It's only " [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/184062 (owner: 10Ori.livneh) [07:41:17] (03PS1) 10Florianschmidtwelzow: Ask the user if he want to leave the editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) [07:53:15] (03PS5) 10BearND: ShareAFact: add preview + redesign [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189872 (https://phabricator.wikimedia.org/T86843) [07:58:56] (03CR) 10jenkins-bot: [V: 04-1] ShareAFact: add preview + redesign [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189872 (https://phabricator.wikimedia.org/T86843) (owner: 10BearND) [08:04:17] (03CR) 10BearND: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189872 (https://phabricator.wikimedia.org/T86843) (owner: 10BearND) [08:06:57] (03PS1) 10Robmoen: Add personal tools hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190164 [08:08:47] morning! [08:11:17] (03PS2) 10Robmoen: Add personal tools hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190164 [08:12:31] rmoen: u still there? [08:12:36] ya [08:12:51] you work late :p go to sleep! [08:13:01] just about to crash. I had a long day [08:13:07] rmoen: what time is it there? [08:13:08] got our labs thing running finally [08:13:16] awesome [08:13:28] i'll check it out in a bit, i'm making coffee [08:13:48] joakino: also just got the link in the menu via hook [08:14:18] rmoen: cool, we are going to be mostly set up for the sprint [08:14:44] rmoen: good job! yay for us! [08:14:59] Yeah i wanted to get something done besides fiddle with labs all day. Filed some bugs [08:15:36] rmoen: i was talking to phuedx about sub-namespacing our stuff mirroring the folder structure, so the views would be in Gather\views\CollectionItemCard (without the view) [08:15:46] same for models, etc [08:15:48] Nice [08:15:49] what do you think? [08:16:09] I like that for structure [08:16:26] Also I kegged some beer today.. been a long day [08:16:55] Moped rally this weekend. Work + prep is consuming all my time [08:17:09] Anyway, party on. I gotta get some sleep [08:17:14] so cool [08:17:24] see you at standup [08:17:27] share video or pics afterwards [08:17:31] good night rmoen [08:17:34] joakino: ahh ok ;) [08:17:36] gn [08:43:37] (03CR) 10Florianschmidtwelzow: [C: 032] Add personal tools hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190164 (owner: 10Robmoen) [08:45:58] (03Merged) 10jenkins-bot: Add personal tools hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190164 (owner: 10Robmoen) [09:34:01] (03CR) 10Phuedx: [C: 032] "I was finally able to get the browser tests running locally after provisioning a new VM. One of the steps in editor_ve.feature was failing" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189870 (owner: 10Bmansurov) [09:35:12] (03Merged) 10jenkins-bot: Unbreak browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189870 (owner: 10Bmansurov) [09:35:17] (03CR) 10Phuedx: Restyle banner image and page title on tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 (owner: 10Bmansurov) [11:19:57] (03CR) 10Phuedx: [C: 04-1] "Missing tests. All the PageImagers-powered banner image doesn't respond to device/window rotation." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 (owner: 10Phuedx) [11:22:15] (03CR) 10Phuedx: [C: 04-1] "This LGTM. However, could you add unit tests to exercise the" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190115 (owner: 10Bmansurov) [11:26:12] (03CR) 10Phuedx: Add support for logging responses from remote wikis (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/189880 (owner: 10MaxSem) [11:29:01] (03CR) 10Phuedx: Add support for logging responses from remote wikis (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/189880 (owner: 10MaxSem) [11:51:20] (03PS1) 10Phuedx: More sign off comments for I00ee00 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190188 [11:56:48] (03CR) 10Florianschmidtwelzow: [C: 04-1] Hygiene: Move SpecialNearby registration out of extension function (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187948 (owner: 10Florianschmidtwelzow) [12:00:30] (03CR) 10Gerardduenas: [C: 031] More sign off comments for I00ee00 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190188 (owner: 10Phuedx) [12:03:01] * phuedx sighs [12:09:44] i shall forever remain Mounting NFS shared folders... [12:10:28] don't [12:10:39] i had to spin up a new vm this morning [12:10:49] it took me an hour and a half to get ve saving a page edit [12:10:53] brb [12:11:52] lol that's horrible [12:12:20] provisioning, figuring out the correct extensions to enable [12:12:22] provisioning [12:12:25] testing [12:12:30] enabling another extension [12:12:36] working! [12:12:46] ok, brb again, nipping out to get some soup [12:13:24] ok bb [12:20:35] (03PS2) 10Florianschmidtwelzow: More sign off comments for I00ee00 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190188 (owner: 10Phuedx) [12:20:44] (03CR) 10Florianschmidtwelzow: [C: 032] More sign off comments for I00ee00 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190188 (owner: 10Phuedx) [12:22:44] (03Merged) 10jenkins-bot: More sign off comments for I00ee00 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190188 (owner: 10Phuedx) [12:48:40] and now i'm having lunch [13:43:09] and now i'm definitely not [13:43:19] although i haven't been for some time [13:50:28] out for lunch [14:04:55] (03PS1) 10Phuedx: Fix overlapping (sub-) section heading edit links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190205 [14:20:17] (03CR) 10Phuedx: "@Cmcmahon: this should have been fixed @Bmansurov's patch, which has been merged." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189792 (owner: 10Cmcmahon) [14:27:18] phuedx: hi, I need a little help [14:27:26] hey codezee [14:27:32] i'll try my best [14:27:37] what's yer issue? [14:28:07] how can I bind an event map which was originally bound using this.$el.on('click'..., using events map? [14:28:14] here : https://gerrit.wikimedia.org/r/#/c/188673/10/javascripts/Drawer.js [14:30:08] codezee: ok [14:30:20] in answer to your question: you can't [14:30:38] however, the handler receives the element that triggered the event as its first argument [14:31:20] sorry [14:31:25] no they won't [14:31:29] they'll receive the event [14:31:59] then is there any workaround for the comment at the patch? [14:32:03] onShowDrawer: function () { /* ... */ }; [14:32:06] use [14:32:22] onShowDrawer: function ( event ) { var $el = $( event.target ); /* ... */ } [14:33:05] it's not necessarily a workaround [14:33:22] it's the way we write event handlers for event-mapped views :) [14:34:26] alright, so basically, we attach the handler to 'this', but while triggering, the target is this.$el I guess? [14:35:14] yeah, ish [14:35:27] using this.$el inside the handler should work too [14:35:57] phuedx: alright, thanks! :) [14:36:37] in event mapped views, even handlers are bound to the view rather than to the element that triggered the event [14:36:38] codezee: the handlers are bound to the View class, like the rest of the class methods, so in that case, to Drawer [14:36:46] what phuedx said [14:37:07] *event handlers [14:37:47] joakino: do we have a preferred style for event handlers: $( event.target ) or this.$el? [14:38:01] codezee: in that example, this.on refers to the View's event emmiter `on`, not to jquery's dom events [14:38:18] codezee: events map is for dom events, not for event emmiter's (js objects) events [14:38:31] codezee: so you don't have to migrate the `this.on` [14:39:29] phuedx: this.$el and this.$('...') for stuff from the view, and just $( event.target ) for the element that triggered the event [14:39:49] cool [14:39:54] noted [14:41:10] joakino: ok, I get the idea :) [14:42:04] codezee: it gets messy since there are 2 event systems, the DOM and the synthetic js one (that comes from the classes extending from EventEmitter, more concretely View) [14:42:55] joakino: yes, I do see that, there are both of them [14:44:53] cool 👍 [14:48:27] i forgot about the synthetic event system… [15:03:38] (03CR) 10Bgerstle: "ofc +1. once we start scaling up authors, we can update this to use a script that maps all git commits and creates an alphanumerically-sor" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190155 (owner: 10Mhurd) [15:03:45] (03CR) 10Bgerstle: [C: 031] Updated contributors list. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190155 (owner: 10Mhurd) [15:05:53] (03PS1) 10Mikaelstaldal: Shortcuts to Wikipedia in different languages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190213 [15:06:42] (03CR) 10Fjalapeno: [C: 031] "Adam - Looks good to go." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293 (owner: 10Dr0ptp4kt) [16:25:54] (03PS3) 10Fjalapeno: WIP Info Box collapsing. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189897 [16:26:37] (03PS4) 10Fjalapeno: Info Box collapsing. (Ready for Review) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189897 [16:28:40] 3Mobile-Web: The mobile Web wikicode editor loses the user-entered text - https://phabricator.wikimedia.org/T88949#1034455 (10Nnemo) >>! In T88949#1033030, @kaldari wrote: > @nnemo Actually it looks like the behavior I was describing only applies if you hit the back button while in the editor. If you leave the e... [16:41:21] (03CR) 10Fjalapeno: [C: 031] Updated contributors list. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190155 (owner: 10Mhurd) [16:42:18] (03CR) 10Fjalapeno: [C: 031] Prevent license text size from growing on rotate. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190129 (owner: 10Mhurd) [16:49:55] (03CR) 10Fjalapeno: [C: 04-1] "Left a comment about using descriptive method names as a opposed to comments to explain the purpose of code." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190124 (owner: 10Mhurd) [16:51:36] (03CR) 10Fjalapeno: [C: 04-1] Prevent license text size from growing on rotate. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190129 (owner: 10Mhurd) [16:52:22] (03CR) 10Fjalapeno: "Similar message about wrapping non-obvious language in a descriptive method rather than using a comment to describe what is going on." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190129 (owner: 10Mhurd) [16:53:26] (03CR) 10Fjalapeno: [C: 031] Idiomatically update menu bar in About [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189869 (owner: 10Dr0ptp4kt) [16:54:18] (03CR) 10Fjalapeno: "Adam / Monte - what do we do with these? Do we check them or verify?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189526 (owner: 10BearND) [17:02:02] (03CR) 10BearND: "BTW, these either come in from me, and then it asks about a +2 from you or it comes in from L10n-bot which automatically +2s the patch by " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189526 (owner: 10BearND) [17:04:53] 3Wikipedia-App-Android-App: Image Save to device does not properly handle errors - https://phabricator.wikimedia.org/T89358#1034592 (10MikaelStaldal) 3NEW [17:08:19] (03CR) 10Dr0ptp4kt: "@Fjalapeno, thanks. Yeah, not full edge-to-edge, with a fixed size for different devices (although down the road maybe I can work on somet" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293 (owner: 10Dr0ptp4kt) [17:10:48] sheesh, i've been booted by IRC more times than i can count today [17:10:52] this happening to anyone else? [17:15:40] bgerstle - not me [17:16:20] bgerstle just left some comments on your patch - about to go through patch 5 - any part you want me to focus on since its kinda big? [17:17:15] coreyfloyd: probably start with ImageGalleryViewController and dive into the networking & persistence layers as needed. [17:17:47] i'm just refactoring some stuff now though [17:18:10] bgerstle sounds good - actually going to take a break and walk the dog - so maybe I'll wait until the next patch [17:18:33] i'll probably take a break in a bit as well [17:18:46] (03PS1) 10Mikaelstaldal: Make sure that saved images are successfully saved before telling the user so [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190236 (https://phabricator.wikimedia.org/T89358) [17:18:47] might be best for me to walk you & monte through the feature [17:25:58] smaller patcheeeeees [17:26:11] ^ this [17:26:18] although, easier said 'n done [17:26:35] (especially w/ gerrit, gerrit makes a series of small patches confusing) [17:26:44] phuedx: bgerstle: i'm watching Spotify engineering culture [17:27:09] agreed about gerrit and small patches, still reviewing big patches is horrible [17:28:23] joakino oh? link to the video? [17:28:30] joakino happy to answer any questios [17:28:33] questions* even [17:28:38] but i'll abide some questios as well [17:28:43] bgerstle: its on the http://sometalks.tumblr.com [17:29:10] i see [17:29:36] * bgerstle adds to RSS reader [17:29:52] bgerstle: http://sometalks.tumblr.com/post/109215940451/engineering-culture-at-spotify [17:31:22] (03CR) 10Mikaelstaldal: "This could solve this issue:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190213 (owner: 10Mikaelstaldal) [17:36:25] 3Wikipedia-App-Android-App: Option to start Wikipedia app without loading the Today page - https://phabricator.wikimedia.org/T89362#1034664 (10MikaelStaldal) 3NEW [17:45:43] (03CR) 10MaxSem: [C: 04-1] "Why not just use the SpecialPage_initList hook?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187948 (owner: 10Florianschmidtwelzow) [17:48:07] (03CR) 10MaxSem: [C: 04-1] Send WikiGrok responses to wikidata.org (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190115 (owner: 10Bmansurov) [17:59:51] joakino: rejoining [18:08:00] bearND: around? [18:09:21] (03PS2) 10Bmansurov: Send WikiGrok responses to wikidata.org [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190115 [18:13:18] yup [18:17:52] rmoen: i've realized the publish and submit button is everywhere, that's pretty dangerous xd [18:20:18] (03CR) 10Jhernandez: "I'll give this a review tomorrow, and i'll try to test stuff manually. Let's try to get a few +1s in this one so that we are sure that we " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [18:23:53] joakino: Yep [18:26:18] 3WikiGrok, Mobile-Web: DBQueryError: "Deadlock found when trying to get lock; try restarting transaction" - https://phabricator.wikimedia.org/T89359#1034739 (10MaxSem) [18:31:56] (03CR) 10Bmansurov: [C: 04-1] Ask the user if he want to leave the editor (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [18:36:46] bearND: working on reviewing your patch now; And I'll try to take care of the face alignment + gradient afterwards. [18:37:44] 3Mobile-Web: TOC should be horizontally scrollable - https://phabricator.wikimedia.org/T89367#1034749 (10bmansurov) 3NEW [18:40:01] 3Mobile-Web: TOC should be horizontally scrollable or items in it should wrap - https://phabricator.wikimedia.org/T89367#1034762 (10bmansurov) [18:43:45] dbrant: We had two patches come in by a volunteer, could you review them? [18:43:53] dbrant: https://gerrit.wikimedia.org/r/#/c/190236/ [18:43:57] dbrant: https://gerrit.wikimedia.org/r/#/c/190213/ [18:43:59] dbrant: great. Just meeting with dr0ptp4kt and moiz to adjust some of the sizing. The gradient would be first priority according to Moiz. [18:44:00] Deskana: yep! saw those [18:44:12] dbrant: Wait, let me rephrase that. "As Tech Lead, can you ensure they get reviewed?" [18:44:19] lol right! [18:44:54] dbrant: Thank you sir! [18:44:55] (03PS2) 10Mhurd: Fix for RTL lang bracket problem in About page license links. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190124 [18:44:56] dbrant Deskana: cool! (volunteer patches) [18:44:56] Deskana: "... so I can ..." (phrasing as a user story) [18:45:16] (03CR) 10Mhurd: "Updated based on comments." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190124 (owner: 10Mhurd) [18:45:36] As a product manager, I would like the Android tech lead to ensure patches from volunteers get reviewed so we get more volunteer devs. [18:45:47] :) [18:46:04] As a scrummaster, I would like to torment my product manager by making him write everything as user stories so that he goes insane [18:46:17] kristenlans: That one's just for you ;-) [18:46:37] kaldari: gracias [18:47:00] hahah Deskana I was just about to write that my heart is bursting with scrum master joy and pride [18:47:15] until that last user story :P [18:47:57] kristenlans: I'm just making sure you've always got something to improve, process wise. ;-) [18:49:11] (03PS2) 10Mhurd: Prevent license text size from growing on rotate. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190129 [18:49:46] (03CR) 10Mhurd: "Updated based on comments." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190129 (owner: 10Mhurd) [18:50:01] (03CR) 10Bmansurov: [C: 032] Fix overlapping (sub-) section heading edit links (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190205 (owner: 10Phuedx) [18:51:49] (03CR) 10Phuedx: [C: 032] Send WikiGrok responses to wikidata.org [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190115 (owner: 10Bmansurov) [18:52:02] (03Merged) 10jenkins-bot: Fix overlapping (sub-) section heading edit links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190205 (owner: 10Phuedx) [18:52:38] bmansurov: re: right margin on the edit button, i agree, but i wanted to make it consistent [18:52:50] phuedx: ok [18:53:21] bmansurov: mind if i reorder the beta styling changes? i want to merge yours and i don't want it to be blocked on the code review cycles of the page images stuff [18:53:25] (03CR) 10jenkins-bot: [V: 04-1] Send WikiGrok responses to wikidata.org [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190115 (owner: 10Bmansurov) [18:53:37] phuedx: np [18:53:53] (03CR) 10Florianschmidtwelzow: "> Why not just use the SpecialPage_initList hook?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187948 (owner: 10Florianschmidtwelzow) [18:53:55] gracias [18:54:41] nuria: Are you still working on this patch: https://gerrit.wikimedia.org/r/#/c/187876/ ? [18:55:19] kaldari: yes, submitted one change yesterday, will submit another one today [18:55:31] kaldari: sorry that is slow outages of EL have taken most of my time [18:55:49] kaldari: if you notice comments are cosmetic so methodology is done [18:56:14] kaldari; just need to correct formatting [18:56:51] (03PS4) 10Florianschmidtwelzow: Hygiene: Move SpecialNearby registration out of extension function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187948 [18:57:00] NP, I’m going to be out of town next week and am hoping to coordinate updating WikiGrok with your change, so I’m hoping it gets merged before the end of the week. [18:57:06] (03CR) 10Fjalapeno: [C: 031] Prevent license text size from growing on rotate. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190129 (owner: 10Mhurd) [18:57:11] kaldari: let me know if you have additional suggestions [18:57:35] (03CR) 10Mhurd: [C: 032 V: 032] "ENHANCE!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190155 (owner: 10Mhurd) [18:57:44] (03PS9) 10Phuedx: Refactor the BannerImage module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 [18:57:56] nuria: it looks pretty good to me at this point. Let me know if there’s anything I can do to help. [18:57:57] (03CR) 10Fjalapeno: [C: 031] Fix for RTL lang bracket problem in About page license links. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190124 (owner: 10Mhurd) [18:58:22] kaldari: I hope to commit one more patch today and that should be it [18:58:39] kaldari: like before lunch [18:58:45] :) [18:59:13] (03CR) 10jenkins-bot: [V: 04-1] Refactor the BannerImage module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 (owner: 10Phuedx) [18:59:44] (03CR) 10Fjalapeno: "Thanks BearnD" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189526 (owner: 10BearND) [19:00:03] coreyfloyd: hmm just noticed a couple license links don’t seem to work. the screen goes white. it seems to be happening on master and not just in my recent patches. ideas? [19:00:21] mhurd I'll look now [19:01:16] mhurd is this on device/simulator or both? [19:01:23] bearND: http://www.google.com/design/spec/components/bottom-sheets.html#bottom-sheets-content [19:01:23] coreyfloyd: both [19:01:31] mhurd thanks [19:01:59] Deskana: hi threre, access to the mobile otrs queues ? :) [19:03:58] bmansurov: basically, i'm going to resurrect your initial patch set and then drop the enable-banner-image-on-beta part [19:04:13] so it'll be available on alpha to test the styling, then i'll put mine on top of yours [19:04:17] matanya: Hey! I'm not an OTRS admin so I can't actually give you access. You'll need to speak to an OTRS admin. [19:04:19] phuedx: ok [19:04:21] feels like the right way round [19:04:28] sure [19:04:31] matanya: Or were you saying "I don't know what that email you sent me was even about"? :-) [19:04:35] (03CR) 10Florianschmidtwelzow: Ask the user if he want to leave the editor (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [19:05:11] Deskana: i actully had a clue, but wondered if you declared that i have access, or just telling me more about it in general [19:05:12] dbrant: feel free to +2 whenever. Looks like there would be a lot more changes for the layout needed that come later. [19:05:19] I think RD was waiting for Deskana to give the OK [19:05:22] I know the answer now :) [19:05:40] Deskana: mind jumping into #wikimedia-otrs ? [19:06:24] dbrant, bearND|lunch: Getting an error with the alpha builds. "Can't open file" [19:06:48] mhurd just tried simulator and device both iOS 8.1 and was not able to reproduce [19:07:05] mhurd what os were you on? [19:07:08] Deskana: sometimes it helps to do a clean or rebuild [19:07:13] coreyfloyd: it looks like it’s only the external links. i can double check... [19:07:19] gotta run [19:07:23] oh not the license ones [19:07:41] mhurd - the links to the project websites? [19:07:42] coreyfloyd: wait. i may be confused. double checking... [19:08:51] mhurd I'm on master by the by [19:09:21] 3MobileFrontend: Show edit section icons for all sections, not just h2 - https://phabricator.wikimedia.org/T87644#1034836 (10Florian) \o/ Thanks for the feedback @Mattflaschen! :) [19:09:25] coreyfloyd: ya. switching my phone from hebrew back to english… [19:09:31] (03PS10) 10Phuedx: Refactor the BannerImage module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 [19:10:09] (03CR) 10Mhurd: "Found one tiny issue." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189897 (owner: 10Fjalapeno) [19:10:50] coreyfloyd: did a clean build an now they’re working. also had to delete the app… weird!!! [19:11:56] yeah - do we test upgrades in regression? If not we should because this may actually be a real bug [19:12:01] mhurd^ [19:12:56] (03PS5) 10Fjalapeno: Info Box collapsing. (Ready for Review) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189897 [19:13:08] mhurd^ [19:13:34] coreyfloyd: now i’m thinking it may be a bug in the bidirectional bracket patch i submitted. can you confirm? the wikifont license link is not working for me... [19:14:01] from master? [19:14:24] i had switched to master and it still wasn’t working until i deleted the app, but it seems like my patch left something in a funky state? so confused [19:15:09] coreyfloyd: i’m suspecting my patch did it: https://gerrit.wikimedia.org/r/#/c/190124/ [19:15:21] could it be related to the typo fix? [19:16:18] mhurd not sure - will check out [19:17:15] (03CR) 10Mhurd: [C: 031] "Looks solid." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189897 (owner: 10Fjalapeno) [19:23:10] 3Mobile-Web: UI elements inaccessible by screen reader - https://phabricator.wikimedia.org/T87670#1034868 (10TheDJ) It seems that this is caused by the text-indent hack to hide the text from view. This trick also doesn't work well with rtl, so that's another reason to avoid it. I do admit, that this is DIFFICUL... [19:26:00] (03PS6) 10Mhurd: Info Box collapsing. (Ready for Review) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189897 (owner: 10Fjalapeno) [19:26:11] ^ rebased [19:27:59] 3Mobile-Web: When editing, seeing old version of page - https://phabricator.wikimedia.org/T75429#1034892 (10bmansurov) I'm not able to reproduce this using the API level 10 which covers 2.3.6. The editor doesn't even open. [19:28:14] (03CR) 10MaxSem: Add support for logging responses from remote wikis (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/189880 (owner: 10MaxSem) [19:29:23] (03CR) 10Dbrant: [C: 04-1] "Great idea! Please see inline comments, and another issue:" (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190236 (https://phabricator.wikimedia.org/T89358) (owner: 10Mikaelstaldal) [19:30:14] dr0ptp4kt: coreyfloyd bgerstle grabbing some early foods. brb [19:31:25] k [19:31:54] FYI mhurd dr0ptp4kt coreyfloyd i'm adding my iPad to our dev profile, so yours might become invalid [19:32:10] mhurd that patches fixes the spelling of the plist key without updating the plist [19:32:23] coreyfloyd: hehe [19:32:43] coreyfloyd: lemme fix that before grabbing foods... [19:33:43] 3Mobile-Web: Use buttons with spinners instead of loading overlays - https://phabricator.wikimedia.org/T89069#1034898 (10bmansurov) a:5bmansurov>3None [19:34:30] (03Abandoned) 10Cmcmahon: QA: editor switcher controls became generic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189792 (owner: 10Cmcmahon) [19:36:11] (03PS3) 10Mhurd: Fix for RTL lang bracket problem in About page license links. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190124 [19:36:17] coreyfloyd: ^ [19:36:31] coreyfloyd: thanks for tracking that down! [19:36:58] ok foods [19:38:22] (03CR) 10Bmansurov: Ask the user if he want to leave the editor (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [19:40:30] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190115 (owner: 10Bmansurov) [19:42:43] phuedx: i've just watched the spotify engineering talks from the tumblr [19:43:02] (03PS4) 10Phuedx: Restyle banner image and page title on tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 (owner: 10Bmansurov) [19:43:15] they sound awesome [19:43:21] joakino: had a good time did you? [19:43:27] x-fn'l teams can be nice [19:44:01] (03CR) 10MaxSem: [C: 04-2] "Blocked on I910cecd197883948cbdc2c07fa67a055035c2039" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190115 (owner: 10Bmansurov) [19:44:02] phuedx: i feel like that needs to go to wmfall and wikitech [19:44:58] bgerstle: if you get to watch them i'd love to hear about what is actually true and pains you remember about those approaches [19:45:05] MaxSem: which one goes first? [19:45:20] (03CR) 10Phuedx: "PS4 is a rebase atop master without enabling banner images on beta." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 (owner: 10Bmansurov) [19:45:21] at the same time? :PP [19:45:36] (03PS5) 10Phuedx: Restyle banner image and page title on tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 (owner: 10Bmansurov) [19:45:42] joakino i might have seen bits & pieces, but i'll check them out again and let you know [19:45:45] lololo [19:45:53] you turn one key i turn the other? ;) [19:46:11] joakino: have you read the spotify matrix org thing? [19:46:12] bgerstle: its about 25 minutes of cute drawings [19:46:21] phuedx: nope, what is that [19:46:26] right, about the matrix organization? [19:46:34] chapters, squads, etc.? [19:46:54] ^ that [19:47:04] phuedx kristenlans & arthur are very interested in these things as well [19:47:35] sec, just pulling the url [19:49:12] sounds too good to be true [19:49:33] it's still how the org is structured (squads, chapters, & tribes) [19:50:08] i haven't watched those talks in a while [19:50:18] i might be posting a rehash of the same thing [19:50:27] lagggggg [19:50:36] do the horizontal/vertical splits work well? (team split and skills (ops, etc) split) [19:50:43] define well ;-) [19:50:48] joakino: https://ucvox.files.wordpress.com/2012/11/113617905-scaling-agile-spotify-11.pdf [19:51:08] rmoen, phuedx: Just sent an email to greg about getting you guys leveled up on SWAT deployment [19:51:18] Kristen|BRB: ^ have that url too [19:51:27] kaldari: cool.io [19:51:34] bgerstle: so, no? xd [19:51:47] rmoen: If you want to do a simple config deployment this afternoon for practice, let me know. (I’m assuming phuedx will be asleep by then) [19:51:59] kaldari: yeah, i'll be asleep [19:51:59] i mean, it is people, and it is going to be different with each chapter/tribe/whatever, but experience is always interesting [19:52:28] kaldari: cool. I've talked to him about it too. Honestly i'd like to do a config change to beta cluster to get Gather on beta labs [19:52:30] bgerstle: i'd be super interested if you did a hangout describing your experiences [19:52:36] dr0ptp4kt: are you remote today? [19:52:50] kaldari: my patches need merged for mediawiki/extensions and my config change [19:52:51] mhurd: no, meeting central [19:52:52] phuedx: bgerstle +1 [19:53:02] a private one [19:53:05] phuedx: oh I HAVE that url [19:53:08] rmoen: if there’s anything I can do to help, let me know [19:53:22] dr0ptp4kt: ah cool - can you make the noon meeting in R69? [19:53:30] joakino phuedx bgerstle +1 [19:53:32] how are the guilds defined? mailing lists? [19:53:36] rmoen: unfortunately, I haven’t had much time to look at Gather yet :( [19:53:41] kaldari: yeah, plus 2 :) https://gerrit.wikimedia.org/r/#/c/189836/ and https://gerrit.wikimedia.org/r/#/c/189863/ [19:53:49] mhurd: yep [19:53:49] phuedx joakino kristenlans happy to oblige [19:53:57] joakino: roughly, yes [19:54:03] e.g. "java at spotify" [19:54:06] or "mobile at spotify" [19:54:15] kaldari: yeah max has done a lot of code review for us. [19:54:26] bgerstle: aha [19:54:26] the java one is the best example, but they weren't used heavily [19:54:41] they were a bit informal [19:54:47] we would like to get it on beta labs. So I've made a config change and added it to extensions repo in the above two commits [19:54:49] e.g. "Java 8 is out! When can we migrate?!" [19:55:11] bgerstle: so mostly low traffic/attention [19:55:12] we also IIRC had guilds about continuous deployment [19:55:15] yep [19:55:21] (03CR) 10Fjalapeno: [C: 031] Fix for RTL lang bracket problem in About page license links. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190124 (owner: 10Mhurd) [19:55:28] a good way to propagate best practices and narrowly scoped decisions [19:55:29] bgerstle: do they have remote workers? [19:55:36] joakino one fewer now ;-) [19:55:50] only a handful, IIRC [19:55:54] it's definitely the exception [19:55:58] although they have many offices [19:56:10] aha [19:56:14] cool [19:56:23] remote brings different challenges too [19:56:25] for all intents and purposes, they have 4 eng offices: Stockholm, Gothenberg, NY, and SF [19:56:43] they have a big office in London, but IIRC it's mostly customer support and related engineering [19:56:55] also have offices else, but AFAIK mostly for sales & licensing [19:57:01] elsewhere* [19:57:04] aha [19:57:10] anyway, we can jump into a separate room if you want to talk more [19:57:22] but i think i have a chat coming up w/ mhurd & dr0ptp4kt.. possibly coreyfloyd [19:57:28] you guys still down for image gallery code review? [19:58:22] 3Mobile-Web: Use buttons with spinners instead of loading overlays - https://phabricator.wikimedia.org/T89069#1034984 (10bmansurov) I think this should be done after https://phabricator.wikimedia.org/T87254 [20:00:30] bgerstle: phuedx: kristenlans: i've joined ##engineering-culture-talk to talk about this stuff [20:01:14] (03PS2) 10Mikaelstaldal: Make sure that saved images are successfully saved before telling the user so [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190236 (https://phabricator.wikimedia.org/T89358) [20:04:27] Deskana: is alpha build working for you now? [20:05:02] dbrant: No. "Can't open file" [20:05:08] dbrant: I just pulled from master and built one myself. [20:06:00] Deskana: wait, is it the app itself that's saying "can't open file"? [20:06:08] dbrant: No, it's Android. [20:06:30] dbrant: Has the APK been packaged incorrectly or something? [20:06:31] (03PS2) 10Mikaelstaldal: Shortcuts to Wikipedia in different languages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190213 [20:07:18] Deskana: very strange... not much has changed. [20:07:25] (and I can't reproduce) [20:12:26] (03CR) 10Dbrant: [C: 04-1] "Minor stuff inline. Not commenting on layout, since there will be more tweaks to come." (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189872 (https://phabricator.wikimedia.org/T86843) (owner: 10BearND) [20:12:38] (03PS2) 10Florianschmidtwelzow: Ask the user if he want to leave the editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) [20:15:47] (03PS6) 10Phuedx: Restyle banner image and page title on tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 (owner: 10Bmansurov) [20:15:48] (03PS11) 10Phuedx: Refactor the BannerImage module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 [20:16:30] bmansurov: could you +1 189605 (yours) if you think it's representative of your ps1 (which i think it is) [20:16:47] i'm happy to merge it later or tomo morning [20:20:40] (03PS4) 10Florianschmidtwelzow: Hygiene: Use events map in talk feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) [20:20:55] (03PS1) 10Chad: Remove obvious function-level profiling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190287 [20:21:45] 3Mobile-Web: Events map: Not possible to combine events - https://phabricator.wikimedia.org/T89382#1035033 (10Florian) 3NEW [20:22:30] (03CR) 10jenkins-bot: [V: 04-1] Remove obvious function-level profiling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190287 (owner: 10Chad) [20:22:39] (03CR) 10Florianschmidtwelzow: [C: 032] Remove obvious function-level profiling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190287 (owner: 10Chad) [20:22:58] kaldari: if you need a config change though I'll gladly do it [20:23:41] (03CR) 10Florianschmidtwelzow: "@see: I781f62be9747bb41af6faad6fbe265414fb77669" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190287 (owner: 10Chad) [20:24:15] (03PS1) 10Chad: Remove obvious function-level profiling [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/190288 [20:24:27] (03Merged) 10jenkins-bot: Remove obvious function-level profiling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190287 (owner: 10Chad) [20:26:08] 3Mobile-Web: Alpha: Wrong position for the last edited bar when images are present on the page - https://phabricator.wikimedia.org/T88499#1035047 (10Florian) 5Resolved>3Open {F40454} Can still be reproduced on actual master :) [20:27:24] g'night folks [20:27:27] i'm org [20:27:29] *orf [20:27:48] Don't orf :/ [20:28:00] gn phuedx [20:28:46] kaldari: pretty please at least drop a +1 on my extension change too ;)https://gerrit.wikimedia.org/r/#/c/189836/ [20:28:48] gn rmoen [20:31:43] (03PS3) 10Dbrant: Make sure that saved images are successfully saved before telling the user so [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190236 (https://phabricator.wikimedia.org/T89358) (owner: 10Mikaelstaldal) [20:32:34] (03CR) 10Bmansurov: [C: 031] Restyle banner image and page title on tablet (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 (owner: 10Bmansurov) [20:35:12] (03CR) 10Dbrant: [C: 032] Make sure that saved images are successfully saved before telling the user so [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190236 (https://phabricator.wikimedia.org/T89358) (owner: 10Mikaelstaldal) [20:35:14] 3Mobile-Web: Events map: Not possible to combine events - https://phabricator.wikimedia.org/T89382#1035067 (10Jhernandez) We could do something to avoid that case, but this are the problems I see with doing it: * Getting further and into a weirder place than Backbone * Losing the familiarity with how they do... [20:35:30] 3Mobile-Web: Events map: Not possible to combine events - https://phabricator.wikimedia.org/T89382#1035071 (10bmansurov) I think its easier to read than having multiple events and selectors in one line. [20:36:27] 3Mobile-Web: Alpha: Wrong position for the last edited bar when images are present on the page - https://phabricator.wikimedia.org/T88499#1035075 (10bmansurov) @Florian, can you also share the URL of the page? thanks [20:37:02] gn people [20:46:25] 3Mobile-Web: Events map: Not possible to combine events - https://phabricator.wikimedia.org/T89382#1035112 (10Florian) 5Open>3declined a:3Florian ok, reasonable points :) Thanks for the comments! [20:49:33] 3Mobile-Web: Alpha: Wrong position for the last edited bar when images are present on the page - https://phabricator.wikimedia.org/T88499#1035119 (10Florian) it's locally, but here is the wikitext code (make sure you set $wgUseInstantCommons = true;): ``` f __NOTITLE__d fedfebgffedäg Testcodergfr... [21:02:19] (03PS2) 10Mhurd: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189526 (owner: 10BearND) [21:04:08] (03CR) 10Mhurd: [C: 031] "Looks good." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189526 (owner: 10BearND) [21:11:13] bd808: Looks like the SecurePoll farm is fixed now? [21:12:37] Deskana: Partially. There is a bug in SecurePoll with the latest version of MediaWiki that we found and another bug with the mediawiki-vagrant/labs-vagrant db selection process [21:12:49] So yeah for testing! [21:13:00] but needs more work [21:13:20] bd808: Good stuff. I'll schedule that meeting with James A now. [21:13:32] bd808: I'll let you know how it goes afterwards. [21:13:40] and I've got to work on something else for a bit. Good thing you were pessimistic about me getting this done today [21:13:50] I'll get back to it later today [21:15:34] bd808: No worries. Thanks! [21:17:19] (03CR) 10Legoktm: [C: 032] Remove obvious function-level profiling [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/190288 (owner: 10Chad) [21:18:16] (03CR) 10Mikaelstaldal: "Fine by me." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190236 (https://phabricator.wikimedia.org/T89358) (owner: 10Mikaelstaldal) [21:18:22] (03Merged) 10jenkins-bot: Remove obvious function-level profiling [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/190288 (owner: 10Chad) [21:23:08] (03CR) 10Bmansurov: [C: 031] Hygiene: Use events map in talk feature (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [21:29:06] (03CR) 10Mhurd: "added comment" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293 (owner: 10Dr0ptp4kt) [21:32:09] bgerstle: hey libraries meeting now [21:32:35] rmoen, did you just +1 on email thread from last summer? :P [21:33:12] MaxSem: I think so :) [21:33:48] Lols so did Emily [21:34:09] I wonder how many people will do that. . For some reason it was on the top of my email [21:34:29] I must have had a search going on [21:34:39] yikes sorry [21:35:47] Hah [21:35:58] It was muted, so I missed out on the action [21:36:04] Thanks for pointing it out Max [21:36:12] * Deskana is tempted to also reply... again [21:36:26] rmoen LOL. I noticed that earlier, and I was like "wow, delayed reaction, but still nice of him to congrtulate Arthur" [21:37:13] Deskana do it! A thread revival troll. [21:37:44] (03CR) 10Bmansurov: [C: 031] "This applies to the source editor only. Not sure if VE should be handled in this patch too." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [21:37:53] kristenlans: Yeah.. thinking back I know I read that email back in the day. I need a food break [21:38:54] Deskana: i encourage you to do so :) [21:39:05] * rmoen blushes [21:39:41] I will say, I enjoyed re-reading the story of the genesis of the TPG! [21:39:58] MaxSem: I can always trust you to clown on me when I do something silly <3 [21:40:58] kristenlans: If you look back far enough you'll see all the sceptics arguing about how it's a bad idea and it's not needed. [21:41:27] kristenlans: I think the fact that people are clamouring to get your help now proved them wrong. :-) [21:44:14] kaldari: you got 15 min to talk w/me & leila? [21:44:17] :) [21:44:21] we're in r32 [21:45:41] sure [21:46:48] brb food [21:50:06] 3Mobile-Web: Users who click on a link shared from Tweet a Fact in the app should see a banner telling them about it - https://phabricator.wikimedia.org/T89403#1035364 (10Deskana) 3NEW [21:50:50] Maryana ^ [21:51:10] (03PS1) 10Bmansurov: Do not highlight editor switcher buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190355 [21:53:45] (03CR) 10Phuedx: Restyle banner image and page title on tablet (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 (owner: 10Bmansurov) [22:03:26] bgerstle - I am looking over your latest patch FYI [22:06:14] coreyfloyd: k [22:12:56] Deskana: https://trello.com/c/Kaqzlnw4/225-help-spread-the-word-about-share-a-fact [22:12:57] :) [22:13:03] i love mobile collaboration [22:13:52] MaxSem: can you review https://gerrit.wikimedia.org/r/#/c/189135/ ? thanks [22:14:10] nuria: Sorry for the last minute code comments, there were a couple things I didn’t think about when I looked at it before. [22:18:27] mhurd i forgot to mention i figured out the "Max preferred layout width" warning thing [22:18:38] i haven't fixed it in other nibs though [22:18:47] kaldari: responded to those already, take a look, we can talk more here if you want [22:18:48] dr0ptp4kt: ok if i merge https://gerrit.wikimedia.org/r/#/c/189869/ ? i had amended it so was not sure if it was proper [22:19:04] bgerstle: crufty key in the xml? [22:20:31] nope [22:20:37] mhurd it's an iOS 8 thing [22:21:06] in iOS 8 & Xcode 6, there's a new IB feature that lets UILabel's w/ numberOfLines = 0 automatically figured out preferredMaxLayoutWidth at runtime [22:21:20] if your deployment target is < 8, you need to set it "explicitly" [22:21:30] bgerstle: ya i’d read about it [22:21:34] ah cool! [22:21:49] it's a neat feature, too bad they couldn't back-port it [22:22:25] bgerstle: yeah right! [22:22:34] nuria: the cached library makes sense, replied about the array conversion. [22:24:26] bgerstle: i was excited to see the auto-preferredMaxLayoutWidth-stuff - especially since that was one of the major reasons i created the paddedlabel class [22:28:22] (03CR) 10BearND: "Good catches." (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189872 (https://phabricator.wikimedia.org/T86843) (owner: 10BearND) [22:32:40] (03CR) 10Dr0ptp4kt: [C: 031 V: 031] "Monte, your turn." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189869 (owner: 10Dr0ptp4kt) [22:32:55] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189869 (owner: 10Dr0ptp4kt) [22:33:25] (03PS4) 10Dr0ptp4kt: Fix for RTL lang bracket problem in About page license links. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190124 (owner: 10Mhurd) [22:33:27] (03PS6) 10BearND: ShareAFact: add preview + redesign [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189872 (https://phabricator.wikimedia.org/T86843) [22:33:53] (03PS7) 10BearND: ShareAFact: add preview + redesign [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189872 (https://phabricator.wikimedia.org/T86843) [22:34:23] dbrant|bbl: i think i've addressed the issues you've raised [22:34:49] bearND: will look [22:35:09] dbrant|bbl: also did some minor layout changes [22:35:16] but more will come later [22:35:38] bgerstle: what was that simulator folder app? [22:37:36] simpholders [22:37:41] mhurd dr0ptp4kt coreyfloyd ^ [22:38:26] bgerstle: did you say it was in the mac app store? [22:39:41] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Fix for RTL lang bracket problem in About page license links. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190124 (owner: 10Mhurd) [22:40:04] bgerstle: nm. found it. [22:40:32] (03PS3) 10Mhurd: Prevent license text size from growing on rotate. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190129 [22:41:05] mhurd: Do you have a CR policy that multiple people need to review before the +2? Was just wondering because of the translation changes just got a +1. [22:41:49] I hope you realize that when the L10n-bot pushes those it automatically +2 the changes. [22:42:30] bearND: ah [22:43:06] bearnd dbrant: guava is my fav java library, probably [22:43:15] makes Java SO much nicer to deal with [22:43:20] ImmutableCollections alone.. [22:43:37] i mean, all their collections stuff [22:43:44] ImmutableList, FluentIterable, etc.. [22:43:58] not to even mention Function and ListenableFuture [22:44:16] highly recommended [22:46:25] bearND: to be clear, l10n bot is going to come around eventually and +2 that translations patch, right? i don't think we need to have manual human work there if you're saying l10n bot will take care of +2 merging https://gerrit.wikimedia.org/r/#/c/189526/ and its like [22:46:40] cc mhurd [22:48:34] bearND: mhurd just clarified that there have been broken plurals and html snippets, so he's been doing them manually. [22:49:03] bearND: do you know if the apps/ios/wikipedia stuff is part of auto +2 and merge as part of l10n bot? we may actually want to disable l10n bot [22:49:06] for that purpose [22:49:13] bearND: ok if i quick call you? [22:49:20] dr0ptp4kt: no. There are two kinds of patches. The ones I make, and the ones from L10n-bot. If mine doesn't get merged by the time L10n-bot does it creates an overlapping commit, and mine becomes outdated (and should be abandoned) [22:49:37] dr0ptp4kt: ok [22:49:52] is there a way to prevent the API from sending the "normalized" titles back in a response? [22:53:04] (03CR) 10Bmansurov: [C: 04-1] Refactor the BannerImage module (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 (owner: 10Phuedx) [22:56:06] kaldari: is wikigrok broken? [22:56:11] on beta labs? [22:56:19] can't trigger it on wolf city [22:56:20] last time I checked [22:56:22] w/query string param [22:57:21] MaxSem: I haven’t been able to get access to the beta labs db lately. Can you check the wikigrok_questions table there (or help me figure out how to access it) [22:57:36] oh, labs might be down [22:57:40] it's not doing anything for me now [22:57:43] blank screen [22:57:55] bearND: connection went boom. thanks! [22:58:23] dr0ptp4kt: ok [22:58:34] bearND: thx in advance [23:06:01] bgerstle yeah - I like that simpholders app - I also have a alfred plugin that does something similar. [23:06:09] nice [23:06:18] Maryana: Is "Multi-language search" on the Platform dependencies spreadsheet yours of Deskana's? [23:06:28] *yours or [23:06:47] bgerstle I loaded up on a lot of alfred plugins - I always forget the less used ones though [23:11:32] i'm heading out for a dog walk and then prepping dinner [23:11:40] might be on later polishing up the image gallery a tad [23:13:07] bgerstle also left some comments for you [23:13:27] ah ha [23:14:23] bd808: ain't mine, and AFAIK not dan's [23:14:39] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Prevent license text size from growing on rotate. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190129 (owner: 10Mhurd) [23:14:44] heh. mystery ask! the easiest to deny :) [23:14:50] lulz [23:14:58] coreyfloyd: i'll probably get to these later. we can discuss tomorrow morning EST If necessary [23:14:58] bd808: I think that was Amir's. [23:14:58] probably amir's, no? [23:15:00] bd808: I mean, we'd like it, but it's not a Q3 thing at all. [23:15:02] bd808: For us, at least. [23:16:17] dr0ptp4kt: mhurd: ok, before i send of this email, can we come to an understanding that from now on your team will review L10n patches within a day? [23:16:59] later o/ [23:17:13] bgerstle: ttyl. i'll look at your patch tonight and tomorrow morning [23:17:41] bearND: is that day requirement something to ensure stuff doesn't slow down somewhere? [23:17:53] bearND: or would two business days work? [23:18:17] bearND: or does the amount of time even matter at all? [23:19:44] dr0ptp4kt: it's helpful to make sure the syncs don't overlap, and avoids me having to remember to abandon old patches [23:20:35] dr0ptp4kt: when i do it I usually test and merge the Android patch right away [23:21:02] bearND: okay, 1 business day on those it is, then. cc mhurd [23:21:57] dr0ptp4kt: mhurd: great! Do you guys want me to add you as reviewer manually, or do you see it automatically even if I don't add you in? [23:24:35] bearND: was it you who added us to https://gerrit.wikimedia.org/r/#/c/189526/ ? if not, then i guess we're getting auto-added. [23:25:09] bearND: if we're behind on accepting translations, do please ping on irc, though, of course [23:26:37] (03PS1) 10Bmansurov: Remove unused style file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190378 [23:27:18] dr0ptp4kt: I probably did that. I remember adding some of you the last couple of time. [23:27:50] bearND: okay, in that case, if you will please continue adding us, it would be most appreciated. [23:27:59] dr0ptp4kt: ok, next time I'll try without adding you manually to the Gerrit patch [23:28:08] bearND: thanks! [23:28:28] dr0ptp4kt: ooops, just read your message after i sent mine, lol [23:29:10] dr0ptp4kt: but maybe next i'll wait a bit longer before adding you to see if Gerrit does it. [23:29:16] dr0ptp4kt: mhurd: I usually do the regular syncs on Monday mornings. [23:29:19] bearND: cool [23:29:26] r0ptp4kt: mhurd: also whenever you've got big string changes merged from your side feel free to ping me, and I can do a sync so it gets to the translators earlier [23:30:41] bearND: cool thanks! [23:31:02] (03PS2) 10Bmansurov: Remove unused style file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190378 [23:33:52] dr0ptp4kt: does https://gerrit.wikimedia.org/r/#/c/188293/ include all of the changes moizsyed wanted? [23:34:40] bearND: not quite. i'm going to resubmit within the next 5-10 minutes [23:35:50] dr0ptp4kt: cewl [23:41:18] kaldari: made loops more concise on crypto patch please take a look [23:44:32] looking [23:45:11] 3Wikipedia-App-Android-App, MediaWiki-extensions-PageImages, Wikipedia-App-iOS-App: PageImages shouldn't return images that are way below the fold - https://phabricator.wikimedia.org/T87336#1035675 (10bd808) @MaxSem would it be difficult to make this API return some indication of where the image was found in the... [23:47:44] nuria: looks good, just needs rebasing and some formatting tweaks. [23:49:31] 3Wikipedia-App-Android-App, MediaWiki-extensions-PageImages, Wikipedia-App-iOS-App: PageImages shouldn't return images that are way below the fold - https://phabricator.wikimedia.org/T87336#1035684 (10MaxSem) Unfortunately, PI hooks into parsing the way that it can't know where is this image on page. Not sure of... [23:50:22] kaldari: what's the formater for mw? it's not prettyfy. [23:51:55] nuria: we us jscs in mobile: https://github.com/jscs-dev/node-jscs [23:56:34] (03PS10) 10Dr0ptp4kt: Enhanced sharing with cards [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293