[00:00:31] signing off for the drive home from pittsburg [00:01:13] 3Mobile-Apps, Wikipedia-App-Android-App, MediaWiki-API, MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), Wikipedia-App-iOS-App: Mobile apps users should not be shown captchas when creating accounts - https://phabricator.wikimedia.org/T88083#1035719 (10bd808) "client-side throttling" is not a viable solution... [00:08:00] kaldari: what i do not get is what is up with jenkins on teh crypto patch, do you know? [00:08:37] nuria: lemme take a look... [00:08:40] (03CR) 10JanZerebecki: "> It's only a problem if something is trying to catch bare Exception, which nothing should really be doing (except MWExceptionHandler)." [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/184062 (owner: 10Ori.livneh) [00:11:27] nuria: looks like a bunch of jshint errors: the missing semicolon, var id is never used, need to use strict !== in the test, etc. [00:12:03] kaldari: but where do you look at those errors? it's not that we use jshint plain, or jslint [00:12:54] nuria: They’re at the bottom of https://integration.wikimedia.org/ci/job/mediawiki-core-npm/3794/console [00:15:13] kaldari: the "^ Unexpected use of '&'" seems like a bogus error, those are not going to go away i do not think [00:17:52] kaldari: let me see if you can use jshint flags on our code [00:18:40] nuria: Frankly that line is Greek to me (rnds[i] = r >>> ( ( i & 0x03 ) << 3 ) & 0xff) :P [00:20:11] nuria: Yeah, you might need to add some jshint flags for the Greek part :) [00:20:46] kaldari: just did it, i just wasn't sure what was our formatting cause i normally use jshint+jspretyfy and that was not cuting it [00:25:46] it’s still choking on the Greek line [00:40:03] kaldari: added a jshint file per: https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript [00:40:21] fingers crossed [00:43:59] (03PS11) 10Dr0ptp4kt: Enhanced sharing with cards [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293 [01:02:20] nuria: hmm, now it’s running jshint against every file in the directory :( [01:02:51] kaldari: ya, i think i need to override the .jshint file completely, let me try that [01:11:39] (03CR) 10Mhurd: [C: 031] "It's alive!!!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293 (owner: 10Dr0ptp4kt) [01:12:55] (03CR) 10Mhurd: [C: 032 V: 032] "It's alive!!!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188293 (owner: 10Dr0ptp4kt) [01:17:43] kaldari: i give up trying to fix formatting will ask krinkle when he's back [01:18:00] nuria: good idea [01:18:17] kaldari: otherwise patch is fine right? [01:18:26] nuria: as far as I can tell [01:27:02] nuria: Heya, how can I help? [01:32:38] Krinkle: jelouuuu [01:32:59] Krinkle: i am at a loss about formatting on this patch: https://gerrit.wikimedia.org/r/#/c/187876/ [01:33:44] Krinkle: it includes bitwise operations that trigger jshint warnings, tried to add a .jshintrc to the dir but now it fails at scanning some files on directory [01:34:05] Krinkle: so... not sure what is the right approach to follow here [01:35:25] nuria: OK. I'll leave a few quick comments. I'll be brief. Friendly intention :) [01:37:12] (03CR) 10Kaldari: [C: 04-1] "Need to add wiki and user hash to response table. Also probably want to add indexes for user name (for logged in) and user hash (for anony" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [01:38:23] Krinkle: but is the idea that i have to add a .jshintrc or do we add falgs per file? [01:38:30] Krinkle: flags per file [01:39:01] Krinkle: like "/*jshint bitwise: false*/ [01:39:02] " [01:46:01] (03CR) 10Kaldari: [C: 04-1] Remove unused style file (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190378 (owner: 10Bmansurov) [01:46:38] (03CR) 10Bmansurov: Remove unused style file (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190378 (owner: 10Bmansurov) [01:48:58] nuria: https://gerrit.wikimedia.org/r/#/c/187876/15/resources/src/mediawiki/mediawiki.user.js https://gerrit.wikimedia.org/r/#/c/187876/15/tests/qunit/suites/resources/mediawiki/mediawiki.user.test.js [01:51:51] Krinkle: will change, I also use jshint +prettyfy but our setup is very custom [01:52:33] nuria: Which prettyfy? [01:53:00] Krinkle: jsprettyfy i think, easies one to setup with sublime [01:54:56] Those tools are mostly useful for interpreting minified javascript. For authored code like yours, it's best to write it manually in the correct style. They tend to not be very configurable or flexible to be used in real-world applications. JSCS is working on a good one, but still in the making. [01:55:10] nuria: If you're using sublime, note that there is a jscs plugin for Sublime in addition to jshint. [01:55:27] that will give exact style hints, using the configuration from MediaWiki automatically (it looks for the jscsrc file). [01:56:04] Ensure nodejs and npm is installed, run 'npm install -g jscs' from the command line, then install SublimeLInter and SublimeLinter-jscs in Sublime Text. An [01:56:11] (if you want that :) ) [01:57:59] Krinkle: I think you are thinking of a different prettyfy( Iam not talking about the kind to decompress js), but yes, I will get jscs [01:58:25] nuria: The prettyfy you refer to modifies the javacscript file to be formatted? [01:59:05] Krinkle: yes https://packagecontrol.io/packages/HTML-CSS-JS%20Prettify [01:59:10] While conceptually (to you and me) that is different than decompress. It is the same principle. It reads the code, ignores the existing (or absent) whitespace, and reformats it with whitespace it thinks should be there. [02:00:00] But I'd recommend against using that. It'll do more damage than good for you I think. [02:00:30] Krinkle: i use it on the other projects we have yes, on mediawiki you cannot [02:00:58] nuria: Wikimedia projects? [02:01:08] Krinkle: yes [02:01:15] nuria: Which one for example? [02:01:25] Krinkle: https://github.com/wikimedia/analytics-dashiki [02:01:48] Krinkle: i will make sure to use jscs for mediawiki [02:03:19] nuria: Does it document or verify what coding style to use in analytics? It seems it currently is done by individual contributors. [02:03:47] Krinkle: no, it doesn't. [02:04:30] Krinkle: the build will use hint (is alredy setup) but formatting is not documented i do not think [02:05:17] Krinkle: we should probably add teh formatter we use to teh README [02:05:18] *the [02:06:02] An annoyance typically observed in projects with individuals using a formatter without it being enforced by gulp or grunt, is that one tends to get commits that reformat existing code unintentionally. Thus making reviews harder. [02:06:33] And these libraries have different versions. So you get commits that every other week change it back and forth. [02:07:07] The sublime one has a different configuration for example when using HTML-CSS-JS Prettify. JSCS solves this by using a strict preset based system that is saved in the repository. [02:07:30] Anyhow, let me know if you want help there. Whatever works for your team :) it's not a big deal. [02:08:34] Krinkle: not a big deal now but that might change next quarter [02:13:33] (03CR) 10Kaldari: [C: 04-1] Ask the user if he want to leave the editor (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [02:57:32] 3Wikipedia-App-Android-App: Add explanation of app permissions used to Play Store listing - https://phabricator.wikimedia.org/T87064#1036000 (10Deskana) 5Open>3stalled Stalling this for now while I think about it. [02:58:23] Deskana: why not just add a FAQ wiki page? [02:58:40] bearND: And link it from the Play Store listing? [02:59:15] Deskana: well, at least OTRS responders could reference it when someone asks a common question [02:59:47] That's a possibility [03:00:02] Or simply adding something like "(requires Location)" after the Nearby entry in the Play Store listing [03:00:18] I was previously thinking a big explanation would be put in, which is too heavy [03:00:21] But something like that might be fine [03:00:32] http://random-ness.wikia.com/wiki/File:Why_not_both.jpg [03:02:04] 3Wikipedia-App-Android-App: Add explanation of app permissions used to Play Store listing - https://phabricator.wikimedia.org/T87064#1036002 (10Deskana) Two options: # Create an FAQ on mediawiki.org and tell the OTRS volunteers they can reference it if someone asks about permissions # Add a little "(requires Loc... [03:02:29] Deskana: Yeah. I think the "(requires Location)" is fine for the store listing; it's short enough. Note that it also has a website field which we could change to the FAQ page. [03:06:07] Home time! [03:19:33] 3Wikipedia-App-Android-App: Image Save to device does not properly handle errors - https://phabricator.wikimedia.org/T89358#1036005 (10Deskana) 5Open>3Resolved [03:31:48] (03CR) 10Dbrant: [C: 04-1] "Before I comment in greater depth on the code, I'd like a product-level assessment from @Deskana (our product manager)." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190213 (owner: 10Mikaelstaldal) [03:33:38] 3Wikipedia-App-Android-App: Incorrect search result highlighting makes some results look weird. - https://phabricator.wikimedia.org/T89037#1036009 (10Deskana) 5Open>3Resolved [03:40:29] 3Wikipedia-App-Android-App: IllegalStateException: Can not perform this action after onSaveInstanceState - https://phabricator.wikimedia.org/T75237#1036012 (10Krenair) [03:41:46] (03PS9) 10Alex Monk: Video playback in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) (owner: 10Dbrant) [03:41:50] (03CR) 10jenkins-bot: [V: 04-1] Video playback in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) (owner: 10Dbrant) [03:42:36] 3Wikipedia-App-Android-App: IllegalArgumentException: pointerIndex out of range crashes - https://phabricator.wikimedia.org/T86166#1036016 (10Krenair) [03:43:45] 3Wikipedia-App-Android-App: App unexpectedly closes on Samsung Galaxy Ace II X (S7560M) - https://phabricator.wikimedia.org/T76279#1036017 (10Krenair) [03:45:06] 3Wikipedia-App-Android-App: Long-press context in History and Saved Pages persists after pressing Back button. - https://phabricator.wikimedia.org/T87052#1036019 (10Krenair) Is this resolved now? [03:45:39] 3Wikipedia-App-Android-App: TOC does not update highlighted position until after it is opened - https://phabricator.wikimedia.org/T68612#1036021 (10Krenair) Is this resolved now? [03:46:53] 3Wikipedia-App-Android-App: Long-press context in History and Saved Pages persists after pressing Back button. - https://phabricator.wikimedia.org/T87052#1036026 (10Deskana) It should be! !close [03:47:32] 3Wikipedia-App-Android-App: Long-press context in History and Saved Pages persists after pressing Back button. - https://phabricator.wikimedia.org/T87052#1036027 (10Deskana) 5Open>3Resolved [03:48:02] 3Wikipedia-App-Android-App: TOC does not update highlighted position until after it is opened - https://phabricator.wikimedia.org/T68612#1036028 (10Deskana) Yes! [03:48:17] 3Wikipedia-App-Android-App: TOC does not update highlighted position until after it is opened - https://phabricator.wikimedia.org/T68612#1036029 (10Deskana) 5Open>3Resolved [03:53:54] (03CR) 10Aaron Schulz: "I'm not sure how often you need tests for severe misuse cases (where bare exception is used), though if you do you, it would make sense to" [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/184062 (owner: 10Ori.livneh) [07:43:30] (03CR) 10Florianschmidtwelzow: "> This applies to the source editor only." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [07:45:10] (03CR) 10Florianschmidtwelzow: [C: 04-1] Hygiene: Use events map in talk feature (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [08:42:48] (03PS5) 10Florianschmidtwelzow: Hygiene: Use events map in talk feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) [09:00:23] 3Mobile-Web: Left navigation bar icons misaligned in stable - https://phabricator.wikimedia.org/T89436#1036221 (10Florian) 3NEW [09:58:02] morrrning [10:01:54] morning [10:01:58] joakino: ^ [10:02:08] hi phuedx [10:02:20] what time did you get to bed last night joakino ;) [10:02:38] phuedx: around 2am :P [10:03:10] disconnected at 10pm, made dinner and watched a couple sons of anarchy for a while [10:04:06] is that any good? [10:05:08] phuedx: entertaining, still don't have an opinion [10:05:18] i'm 8 episodes into the first season [10:05:37] it has a 8.7 in imdb [10:06:11] it started in 2008, i just wanted to watch something where I wouldn't wait for the episodes [10:07:04] i get that [10:07:12] lisa and i are currently working our way through stargate [10:07:16] (she's never seen it before) [10:22:50] woah, weird router issues [10:28:54] phuedx: wow stargate, good times [10:34:31] phuedx: this is sad... https://lists.wikimedia.org/pipermail/wikitech-l/2015-February/080748.html [10:34:39] i agree with him [10:36:12] joakino: +1 [10:36:25] i haven't heard about extensions.json until you mentioned it the other day [10:36:37] so when i git pull, things are gonna break? [10:36:53] idk man, i'm just ignoring it and leaving it outdated on gather [10:36:59] i'm not sure what's going on [10:38:55] phuedx: where is the extensions.json email? i haven't read it and can't find it [10:39:22] neither can i [10:39:30] * phuedx was also trying to find it [10:40:52] joakino: honestly, wikitech goes straight out of my inbox into a label [10:40:59] i've got 50+ emails in the wikitech label [10:41:11] xD yeah [10:41:34] i did a cleanup after SF, and have been mostly keeping up to date [10:44:07] * phuedx sighs [10:44:59] * phuedx is currently eating a few black olives and drinking a cup of coffee [10:45:08] i'm also listening to the american dollar [10:45:20] what is that [10:45:23] joakino: if you like ambient, cinematic music, then tad is for you [10:45:45] tad? [10:45:53] * joakino search grooveshark [10:46:32] the american dollar [10:46:36] phuedx: only one song, crap http://grooveshark.com/#!/theamericandollar [10:46:48] and it is an intermission xD [10:47:09] joakino: http://theamericandollar.bandcamp.com/ [10:47:28] you can buy their entire disography for $20 [10:47:36] (!!!) [10:47:55] i'd like to listen to some of it before that [10:48:01] yeah, obvs [10:48:09] but their catalogue is like 10 albums strong [10:48:40] sounds cool, gonna search youtube for a bit [10:48:48] when you said tad i ended up here http://grooveshark.com/#!/tad [10:48:58] not ambient at all haha [10:52:48] lol [11:50:02] (03CR) 10Phuedx: [C: 032] Add support for logging responses from remote wikis [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/189880 (owner: 10MaxSem) [11:50:04] (03CR) 10jenkins-bot: [V: 04-1] Add support for logging responses from remote wikis [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/189880 (owner: 10MaxSem) [11:50:47] (03CR) 10Phuedx: [C: 032] "I've just tested I910cecd197883948cbdc2c07fa67a055035c2039 and this patch together and +2'd the former." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190115 (owner: 10Bmansurov) [11:51:49] (03Merged) 10jenkins-bot: Send WikiGrok responses to wikidata.org [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190115 (owner: 10Bmansurov) [12:03:59] (03PS7) 10Phuedx: Add support for logging responses from remote wikis [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/189880 (owner: 10MaxSem) [12:05:41] (03CR) 10Phuedx: "PS7 is a rebase." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/189880 (owner: 10MaxSem) [12:05:49] (03CR) 10Phuedx: [C: 032] Add support for logging responses from remote wikis [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/189880 (owner: 10MaxSem) [12:06:46] (03Merged) 10jenkins-bot: Add support for logging responses from remote wikis [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/189880 (owner: 10MaxSem) [12:11:06] 3MobileFrontend: Put link to desktop version in mobile front end at the top rather than st the bottom - https://phabricator.wikimedia.org/T89448#1036417 (10Matanya) 3NEW [12:17:11] 3: java.lang.IllegalStateException: Fragment PageViewFragment{42c490f8} not attached to Activity - https://phabricator.wikimedia.org/T66493#1036426 (10Matanya) This is a crash report from three days ago: USER_COMMENT= ANDROID_VERSION=2.3.5 APP_VERSION_NAME=2.0-r-2015-01-15 BRAND=htc_asia_india PHONE_MODEL=HTC E... [12:25:17] 3Mobile-Web: Put link to desktop version in mobile front end at the top rather than at the bottom - https://phabricator.wikimedia.org/T89448#1036436 (10Jhernandez) [12:34:58] out for lunch with an old friend [12:41:46] bb [13:21:46] 3Wikipedia-App-Android-App: Add explanation of app permissions used to Play Store listing - https://phabricator.wikimedia.org/T87064#1036573 (10Florian) @Deskana: > Create an FAQ on mediawiki.org and tell the OTRS volunteers they can reference it if someone asks about permissions Sounds good, but i hope we find... [14:07:57] out for lunch [14:47:19] (03PS10) 10Dbrant: Video playback in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) [14:50:41] back, finally [14:51:05] i now have a script that restarts my router as i can no longer be bothered to walk upstairs to do it myself [14:54:31] nice! [15:09:29] (03PS7) 10Phuedx: Restyle banner image and page title on tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 (owner: 10Bmansurov) [15:09:44] (03PS11) 10Sumit: Overlay,Panel,Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) [15:10:54] (03CR) 10Phuedx: [C: 032] Restyle banner image and page title on tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 (owner: 10Bmansurov) [15:12:00] (03CR) 10Dbrant: [C: 032] ShareAFact: add preview + redesign [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189872 (https://phabricator.wikimedia.org/T86843) (owner: 10BearND) [15:12:04] (03Merged) 10jenkins-bot: Restyle banner image and page title on tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189605 (owner: 10Bmansurov) [15:12:21] (03Merged) 10jenkins-bot: ShareAFact: add preview + redesign [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/189872 (https://phabricator.wikimedia.org/T86843) (owner: 10BearND) [16:16:34] good morning phuedx [16:18:46] yo [16:18:55] phuedx I have an interview this morning that is going to conflict with standup. I was wondering if I coudl prevail upon you to stand in for me. It will just be you, Baha, and Max, since Kaldari and Maryana are out. [16:19:10] kristenlans: sure [16:19:13] 'course [16:19:30] Thanks phuedx :D [16:19:40] kristenlans: i am drinking some of the tastiest coffee i have drunk in a while: http://www.workshopcoffee.com/collections/coffee/products/kasigwa [16:20:11] phuedx holy crap that description is amazing [16:20:29] That coffe you brought me was SO GOOD. I stil think about it. [16:22:13] next time we're in sf, remind me and i'll make sure i get you some good beans [16:22:42] phuedx you da man. I'll have to brign you some...clams? lobster? :/ [16:23:25] kristenlans: you must have a local roastery (obviously, doesn't everyone?) [16:23:57] phuedx the local roastery is crap [16:24:10] boo [16:24:32] dr0ptp4kt: I'm going to ask you the same thing I just asked phuedx. I have an interview this morning that is going to conflict with standup. I was wondering if I coudl prevail upon you to stand in for me. [16:25:28] phuedx I like MLP (Minimum Loveable Product) [16:26:47] kristenlans i like that too :-) [16:26:56] also a fan of NFR's (non-functional requirements) [16:27:42] phuedx rwandan eh? might need to grab some next time i get the groceries [16:49:31] dr0ptp4kt i don't think it's in scope for my current patch, but i'd like to take a long look at URLCache, since it seems to be getting in the way of my feature [16:49:55] e.g. it turns out high-res images are not being cached [16:50:16] also, it seems like we're persisting JSON to memory AND disk, even though we're parsing JSON into model objects and saving as plists? [16:52:18] kristenlans: will do. [16:52:57] bgerstle: i think that's a good idea [16:54:37] bgerstle: is https://gerrit.wikimedia.org/r/#/c/188583/ stable, or are there any small commits you'll be adding this morning (excepting the need to rebase) ? [16:55:03] bgerstle: i'm hoping to dive into the code review once you give me the word, with the intention to have a "stable" first cut in for the end of the iteration today if all is well [16:55:26] dr0ptp4kt yeah, i'm doing some cursory QA now and cleaning up some visual stuff [16:55:41] the caching is kind of a big problem, since it means i can't cache big images in memory or disk [16:55:47] which prevents both offline use and smooth scrolling [16:56:13] so i'd rather take a deeper look at caching in general to make sure i understand what URLCache is supposed to do, and whether i should just do my own thing [16:57:33] bgerstle: is smooth scrolling affected for online (non-offline) ? [16:57:57] probably, since i constantly need to fetch the image [16:58:08] i can hack something together to have an in-memory cache [16:58:31] TBH, we should be using something like FastImageCache [16:58:35] bgerstle: oh my. ok, can you create a small facade for the online use case so that you at least maintain a recently used cache of your own? [16:59:01] bgerstle: that is, to get you through for the time being until big corrections are achievable... [16:59:13] dr0ptp4kt right, i'll figure something out [16:59:20] bgerstle: oh i see, like you just said :) [17:01:19] also dr0ptp4kt, a potentially major issue (i'm surprised it's not wreaking more havoc) is that we're accessing the data store (and model objects) from multiple threads via URLCache [17:01:43] any time we update an article w/ image data, etc. w/in URLCache, it's being accessed from a background URLConnection thread [17:01:53] AFAICT [17:03:19] bgerstle: it's been a while since i read that code more than cursorily (i needed to understand it somewhat when i was integrating wikipedia zero [from here on w0 is what i will use]), but that sounds about right. might be good to get a walkthrough from monte on the historical basis for doing that, and what sort of things we would want to do in order for your follow on-patch to reduce hacked together caching [17:03:41] bgerstle: i hear the general concern around atomicity and other types of potential thrashing [17:03:42] thx dr0ptp4kt let me know if you have any questions. [17:04:43] kristenlans: will do if need be [17:05:13] dr0ptp4kt k, should i file "cache auditing" as a tech debt item for us to tackle in the near term? [17:05:16] in trello..? [17:05:19] bgerstle: so....i should wait until a little later today to do the review...right? [17:05:27] bgerstle: yes, please do add it to tech debt in the backlog [17:05:32] dr0ptp4kt let me rig up a simple cache w/ facade, then i'll ping you [17:05:39] bgerstle: cool [17:11:05] dr0ptp4kt cataloged here: https://trello.com/c/sxZu6Xpu [17:11:56] bgerstle: thx [17:32:46] dr0ptp4kt hmmm [17:32:58] found an interesting thing [17:33:24] NSURLProtocol will not try to cache something if it will go beyond NSURLCache's memory capacity [17:33:45] or rather, it doesn't seem to follow LRU eviction [17:38:01] so even if we would have ended up storing something in our own folder, it won't even get the call to store it, since NSURLProtocol won't call the method [17:40:29] bgerstle: yeah. hmmm indeed [17:51:52] dr0ptp4kt bgerstle do you guys mind looking at my patch when you have time so we can get it merged if it is all good? [17:52:03] https://gerrit.wikimedia.org/r/#/c/189897/ [17:52:44] bgerstle: you first, then ping me and i'll look at coreyfloyd's patch for the +2 [17:53:03] ok [17:53:09] coreyfloyd dr0ptp4kt sounds good [17:53:13] bgerstle: thx [18:01:46] MaxSem: standup? [18:05:48] tfinc can we bump our 1:1 to 3/3:30? conflicts w/ our iteration review [18:09:27] oh, he's not here [18:11:00] bmansurov, we were at the standup, but haven't seen you :P [18:11:15] interesting, we couldn't see you [18:11:16] MaxSem: we just finished with Sam and Nick ;) [18:11:23] pfft. [18:12:24] We must have been in an older hangout [18:12:47] kaldari: we saw your avatar but no cam/voice [18:12:55] was like the olde internet days [18:12:56] ?? weird [18:13:04] so i guess we all owe a few dollaz? [18:13:05] phuedx: We didn’t see you guys at all [18:13:06] ;) [18:13:32] kaldari: I commented on https://gerrit.wikimedia.org/r/#/c/190378/ can review it? thanks [18:16:00] bmansurov: ah, you’re right, my bad [18:16:06] np [18:23:33] FlorianSW: I commented on https://gerrit.wikimedia.org/r/#/c/190355/ can you take a look at it again? thanks [18:23:46] bmansurov: sure :) [18:24:33] bmansurov: that's exactly what i did (in chrome and firefox) and can't reproduce :( [18:24:46] bmansurov: I believe that these changes were supposed to be beta only (per the title of the card) even though it didn’t list that in the acceptance criteria: https://trello.com/c/sdP2EAbL/16-3-beta-restyle-image-title-on-tablet [18:25:19] kaldari: yes, there is another patch that phuedx is working on, which will promote that stuff to beta. [18:25:33] kaldari: his card had the same requirement [18:26:18] FlorianSW: is not https://phabricator.wikimedia.org/T89462 related? [18:27:06] FlorianSW: although different scenarios, the problem is the same [18:28:36] bmansurov: It looks like the title changes need to be restricted to beta though. Currently they show up in stable as well. [18:29:07] kaldari: i'll submit a follow up patch [18:29:13] thanks [18:29:44] bmansurov: yes, same problem, but i can't reproduce it, but it's reasonable and should work, so i'm keen to merge it, but it's annoying that i can't see if the problem get's solved with it :( [18:29:58] kaldari: I also noticed other css should be beta only ;( [18:30:26] FlorianSW: wait, I'll do a quick screen record of it [18:30:40] *thumbsup* [18:31:29] hrrm, i must've misread the change [18:31:48] bearND: i'm rescheduling the restbae meeting. just verified with gwicke we should indeed postpone [18:31:49] i only looked at beta/alpha for it too :/ [18:32:01] easily remedied though [18:33:15] dr0ptp4kt: ok, sounds good [18:33:29] coreyfloyd: saw vibha’s mock - quick note: for example in the code of interleaving glyph with text the very first time you tap the heart icon to save a page you’ll see a message at the bottom of the screen which interleaves the wikipedia “w” glyph (and one other iirc) with message text [18:35:25] bgerstle: quick hangout? [18:35:36] mhurd yeah [18:38:14] phuedx, bmansurov: I’m working on redoing cards https://trello.com/c/lcrGQKKZ/12-3-only-show-article-text-in-wikigrok-roulette and https://trello.com/c/CRNhpYOL/210-i-can-get-out-of-wikigrok-roulette-and-go-to-the-article-i-was-on-before-i-entered-the-game since they are confusing (and probably in the wrong order) [18:38:34] kaldari: awesome, thanks [18:38:59] FlorianSW: https://www.youtube.com/watch?v=w9JoNWZyfcw [18:39:39] bmansurov: that [18:39:45] damn... [18:40:19] bmansurov: that's a problem of your damn Mac :P But ok, i see what you mean and i'm sure, that the change fixes it :) Thanks for the video :P [18:40:33] ;) np [18:41:44] mhurd - thanks [18:49:54] (03PS1) 10Bmansurov: Revert some style changes from I7cad9546ca9c932b071b920ba85e0f560f5d7eb2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190494 [18:53:14] (03CR) 10Phuedx: [C: 032] "When wgMFNearby set to false, it's not listed on Special:SpecialPages and Special:Nearby 404's and when wgMFNearby is set to true it is an" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187948 (owner: 10Florianschmidtwelzow) [18:55:03] (03Merged) 10jenkins-bot: Hygiene: Move SpecialNearby registration out of extension function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187948 (owner: 10Florianschmidtwelzow) [18:55:12] woot! [18:55:34] the extension function is dead! [18:55:39] * legoktm hugs FlorianSW [18:55:50] legoktm: Yeah :D [18:56:07] (03CR) 10Bmansurov: Refactor the BannerImage module (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 (owner: 10Phuedx) [18:56:16] (03CR) 10Bmansurov: [C: 032] Refactor the BannerImage module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 (owner: 10Phuedx) [18:56:30] legoktm: let's see, how long :P [18:56:50] gonna head off for the night [18:57:05] (i'll check in at 5 am – or whenever harry wakes up, obvs) [18:57:11] have a good weekend y'all [18:57:20] phuedx: u2 [18:57:41] (03Merged) 10jenkins-bot: Refactor the BannerImage module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189687 (owner: 10Phuedx) [18:59:56] (03CR) 10Bmansurov: "@jhernandez, browser test may catch some of the bugs, but not all." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [19:02:03] 3Mobile-Web: When editing, seeing old version of page - https://phabricator.wikimedia.org/T75429#1037289 (10rmoen) @bmansurov: Not surprised the status of this changed, as this was in November when I was in the office. I think I was testing on the Nexus 1 from the device drawer. [19:02:05] (03CR) 10Bmansurov: "I wonder why jenkins is not running jscs here." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [19:06:55] mhurd dr0ptp4kt http://hatjitsu.wmflabs.org/58477 [19:07:10] coreyfloyd: bgerstle ^ [19:09:37] bmansurov: could you tell where I can find the .jscsrc file for mediawiki, I'll run the rest manually? [19:09:56] codezee: you mean mobile front end? [19:10:00] bmansurov: yes [19:10:06] codezee: make jscs [19:10:18] bmansurov: alright [19:10:26] codezee: the file is in the root dir [19:18:04] 3Mobile-Web: Search from non-existent pages is broken - https://phabricator.wikimedia.org/T89483#1037378 (10kaldari) 3NEW [19:19:23] (03CR) 10Bmansurov: Hygiene: Use events map in talk feature (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [19:20:33] (03PS22) 10MaxSem: WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [19:21:39] (03CR) 10jenkins-bot: [V: 04-1] WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [19:28:18] 3Mobile-Web, WMF-Design: Inconsistency: Editor uses back icon for closing overlay, talk uses X - https://phabricator.wikimedia.org/T73203#1037407 (10kaldari) The description leads me to believe that Kaity favors using the back arrow when content creation/editing is involved. Currently that is the case for the ed... [19:29:54] can anyone else confirm this bug: https://phabricator.wikimedia.org/T89483 ? [19:32:18] phuedx: ^ [19:33:50] FlorianSW: ^ [19:35:02] good night everyone! [19:35:09] joakino: good night [19:35:13] kaldari: alpha, beta, stable? [19:35:17] joakino: night! [19:35:20] stable [19:35:39] FlorianSW: But I can only reproduce locally [19:35:46] kaldari: works for me :/ [19:35:51] hm [19:36:04] seems to be a local problem on your site, have you mw and mf master branch? [19:36:14] yeah [19:36:28] lemme try in my other install [19:39:31] FlorianSW: This is really weird. It only throws that error for certain search strings… [19:39:43] which one? :o [19:41:27] If is search for ‘A’, ‘D’, or ‘E’ it works fine, but if I search for ‘B’, ‘C’, or ‘F’ it fails. All of those should find articles on my wiki. [19:42:44] and actually it looks like it’s not related to searching from a non-existant page, that was just cooincidence. [19:42:57] ? wtf, i tried "B" on my wiki and i found "Berlin" (a test page) for the others i don't have test pages, but i got no exception :/ [19:43:45] FlorianSW: it’s very mysterious [19:44:35] have you changed something the last time? New php version, another browser or something else (do you use chrome?) [19:46:19] 3Mobile-Web: Searches for certain strings throw JS error - https://phabricator.wikimedia.org/T89483#1037438 (10kaldari) [19:50:26] FlorianSW: works fine in my Vagrant install :P [19:51:04] ? lol :D [19:53:47] FlorianSW: time to jump down a rabbit hole :P [19:53:59] hope I make it back up before lunchtime [19:54:06] : [19:54:07] :) [19:58:07] (03PS1) 10Yurik: Changed https warning banner [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/190502 [20:02:28] 3Mobile-Web, WikiGrok: DBQueryError: "Deadlock found when trying to get lock; try restarting transaction" - https://phabricator.wikimedia.org/T89359#1037472 (10MaxSem) a:3MaxSem [20:07:14] (03CR) 10Yurik: [C: 032] Changed https warning banner [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/190502 (owner: 10Yurik) [20:08:14] (03Merged) 10jenkins-bot: Changed https warning banner [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/190502 (owner: 10Yurik) [20:14:33] 3Mobile-Web: Searches for certain strings throw JS error - https://phabricator.wikimedia.org/T89483#1037523 (10kaldari) Seems to be caused by some of the search results being redirects to non-existent pages. [20:22:24] msg bgerstle_ ready to ahng if you are! [20:22:33] oops forgot / [20:22:56] this is why I always use /query [20:25:32] (03PS1) 10Kaldari: Prevent search from throwing error for redirects to non-existant articles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190505 (https://phabricator.wikimedia.org/T89483) [20:26:13] 3Mobile-Web: Search throws error if any matches are redirects to non-existent articles - https://phabricator.wikimedia.org/T89483#1037571 (10kaldari) [20:26:34] (03CR) 10jenkins-bot: [V: 04-1] Prevent search from throwing error for redirects to non-existant articles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190505 (https://phabricator.wikimedia.org/T89483) (owner: 10Kaldari) [20:27:19] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190505 (https://phabricator.wikimedia.org/T89483) (owner: 10Kaldari) [20:31:31] kaldari: ^ why is mw.Title not defined? How i can reproduce it? [20:35:21] FlorianSW, does your module declare a dependency on it? [20:35:33] you may be running other modules which make it available [20:35:45] Krenair: i think it has, let me check :) [20:36:34] oops ;) i should check and not assume it :) It has no dependency. Do you know, if mediawiki.Title is loaded on non-existent pages? [20:36:58] wouldn't expect it to be by default [20:39:34] (03CR) 10Florianschmidtwelzow: [C: 04-1] Prevent search from throwing error for redirects to non-existant articles (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190505 (https://phabricator.wikimedia.org/T89483) (owner: 10Kaldari) [20:53:00] mhurd: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/iOS [21:01:11] moushira: Hey! Just grabbing some water, I'll be on the hangout in a sec. [21:01:40] no worries, Deskana! [21:03:47] mhurd: https://etherpad.wikimedia.org/p/styleguide [21:32:18] (03PS2) 10Kaldari: Prevent search from throwing error for redirects to non-existant articles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190505 (https://phabricator.wikimedia.org/T89483) [21:32:54] moushira: Which one of these is your staff acount? [21:32:55] moushira: https://trello.com/moushira [21:33:01] moushira: https://trello.com/moushiraelamrawy [21:33:57] Deskana, the second one [21:40:38] (03CR) 10Kaldari: [C: 04-1] "This surfaces another bug: Watchstars break for redirects to non-existent pages." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190505 (https://phabricator.wikimedia.org/T89483) (owner: 10Kaldari) [21:40:46] (03PS1) 10MaxSem: Reduce database locking [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/190562 (https://phabricator.wikimedia.org/T89359) [21:55:48] (03PS3) 10Kaldari: Prevent search from throwing error for redirects to non-existant articles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190505 (https://phabricator.wikimedia.org/T89483) [21:56:54] (03CR) 10jenkins-bot: [V: 04-1] Prevent search from throwing error for redirects to non-existant articles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190505 (https://phabricator.wikimedia.org/T89483) (owner: 10Kaldari) [21:57:58] (03PS4) 10Kaldari: Prevent search from throwing error for redirects to non-existant articles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190505 (https://phabricator.wikimedia.org/T89483) [21:59:09] FlorianSW: I think I have it totally fixed now (and it’s more efficient) [21:59:20] (03CR) 10jenkins-bot: [V: 04-1] Prevent search from throwing error for redirects to non-existant articles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190505 (https://phabricator.wikimedia.org/T89483) (owner: 10Kaldari) [21:59:27] grr [21:59:56] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190505 (https://phabricator.wikimedia.org/T89483) (owner: 10Kaldari) [22:00:59] (03CR) 10jenkins-bot: [V: 04-1] Prevent search from throwing error for redirects to non-existant articles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190505 (https://phabricator.wikimedia.org/T89483) (owner: 10Kaldari) [22:02:44] kaldari: i'll take a look [22:04:30] (03PS5) 10Kaldari: Prevent search from throwing error for redirects to non-existant articles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190505 (https://phabricator.wikimedia.org/T89483) [22:10:55] (03CR) 10Florianschmidtwelzow: [C: 04-1] "This breaks the Category add feature :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190505 (https://phabricator.wikimedia.org/T89483) (owner: 10Kaldari) [22:13:51] FlorianSW: How do I get to the category add feature? [22:14:22] kaldari: go to a page in alpha mode (you need to be logged in) and click the "categories" button at the end of the page. [22:14:37] There you have an "Add" button at the top right [22:14:39] :) [22:21:46] bgerstle: got time to look at https://gerrit.wikimedia.org/r/#/c/189897/ ? you'll proabably want to hit the Rebase Change button in Gerrit before you pull it down [22:22:20] dr0ptp4kt it's not giving me an option to rebase [22:22:30] bgerstle: one moment... [22:22:48] (03PS7) 10Dr0ptp4kt: Info Box collapsing. (Ready for Review) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189897 (owner: 10Fjalapeno) [22:22:59] bgerstle: ^ thar [22:23:13] k [22:23:33] dr0ptp4kt let me stash what i was working on real quick [22:23:42] is there anything in particular you wanted me to look at? [22:23:55] am i the 2nd or 3rd person to review it? [22:24:07] because if you and monte have seen it, i'm sure it's fine [22:24:32] bgerstle: mainly, just check the diffs since last time you looked [22:25:32] bgerstle: i see you did some review on it earlier. just wanted to make sure all of your feedback is in place now before i do final review [22:25:49] yeah, seems like all the javascript NSStrings are gone [22:26:10] (03CR) 10Bgerstle: [C: 031] Info Box collapsing. (Ready for Review) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189897 (owner: 10Fjalapeno) [22:26:46] bgerstle: thx [22:26:50] bgerstle: i'll look now [22:32:29] dr0ptp4kt: brian +1’ed it [22:34:30] 3Mobile-Web, WikiGrok: DBQueryError: "Deadlock found when trying to get lock; try restarting transaction" - https://phabricator.wikimedia.org/T89359#1037966 (10greg) p:5Triage>3High [22:35:55] MaxSem: https://www.mediawiki.org/wiki/Wikimedia_Engineering/2014-15_Goals#Maps_.26_Geo [22:38:53] (03PS6) 10Kaldari: Prevent search from throwing error for redirects to non-existant articles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190505 (https://phabricator.wikimedia.org/T89483) [22:40:18] bgerstle: you're thinking it will be tuesday before mergeable code for the image viewer stuff, right? if so, we'll still cut a testflight build this afternoon, and we can cut an additional testflight build next week. [22:40:29] dr0ptp4kt sgtm [22:40:38] bgerstle: cool [22:40:52] (03PS7) 10Kaldari: Prevent search from throwing error for redirects to non-existant articles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190505 (https://phabricator.wikimedia.org/T89483) [22:40:52] it's getting near "friday night" here, so i don't think i can do any more [22:49:21] 3Mobile-Web: Watchstar icons in alpha and beta not aligned - https://phabricator.wikimedia.org/T89506#1038005 (10kaldari) 3NEW [22:53:35] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Info Box collapsing. (Ready for Review) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189897 (owner: 10Fjalapeno) [22:56:00] (03CR) 10Aaron Schulz: [C: 031] Reduce database locking [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/190562 (https://phabricator.wikimedia.org/T89359) (owner: 10MaxSem) [23:00:03] bgerstle: the outcome of our scheduling for next iteration is: [23:00:05] mhurd: (5) Make a native component underneath the webview to put the front-end UI for suggestions in [23:00:18] coreyfloyd: (5) Front-end UI for displaying article suggestions [23:00:28] bgerstle: (3) Back-end for displaying article suggestions: fetch three suggestions from full-text search, and their wikidata descriptions [23:00:37] dr0ptp4kt: (2) Add EventLogging for article suggestions. [23:01:15] the following really depends on those, so we'll figure that out at that time: (3) As a reader, I'd like suggestions for what I can read next to be presented to me. [23:02:38] hm, ok [23:02:51] not even really sure what that last one means [23:03:00] oh wait [23:03:05] it's "read more" at the end [23:03:12] and the others are at the top of the article..? [23:06:00] (03CR) 10Florianschmidtwelzow: [C: 032] Prevent search from throwing error for redirects to non-existant articles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190505 (https://phabricator.wikimedia.org/T89483) (owner: 10Kaldari) [23:06:12] FlorianSW: Thanks! [23:06:25] kaldari: thanks to you :) [23:06:56] 3Mobile-Web: Search throws error if any matches are redirects to non-existent articles - https://phabricator.wikimedia.org/T89483#1038040 (10Florian) 5Open>3Resolved a:3Florian [23:07:03] (03Merged) 10jenkins-bot: Prevent search from throwing error for redirects to non-existant articles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190505 (https://phabricator.wikimedia.org/T89483) (owner: 10Kaldari) [23:12:04] dr0ptp4kt: sry i was distracted… did you say it’s ok to merge the localization update? ( https://gerrit.wikimedia.org/r/#/c/189526/ ) [23:12:24] mhurd: go for it [23:12:32] (03PS3) 10Mhurd: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189526 (owner: 10BearND) [23:12:49] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/189526 (owner: 10BearND) [23:13:01] dr0ptp4kt: done [23:15:18] 3Mobile-Web: Put link to desktop version in mobile front end at the top rather than at the bottom - https://phabricator.wikimedia.org/T89448#1038072 (10Florian) I'm not sure, where a link to the desktop version should be, if we want to put it at the top of the article :/ Just a "look-around" to other mobile web... [23:20:37] alright folks, getting late here [23:20:41] i'm heading out. see you on monday! [23:22:05] (03PS1) 10Kaldari: Update WikiGrok user token handling for change I71b5ccc588 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190593 [23:22:51] dr0ptp4kt: Deskana will cut build w adam after my chat w vibha [23:24:45] (03CR) 10Florianschmidtwelzow: [C: 031] Update WikiGrok user token handling for change I71b5ccc588 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190593 (owner: 10Kaldari) [23:24:48] bmansurov: I have a MF change that needs to be merged within the same deployment cycle as a core change. Could you review and +1 it if it looks good and then I will +2 when the core change is merged? https://gerrit.wikimedia.org/r/#/c/190593/ [23:25:04] ok [23:32:59] (03CR) 10Bmansurov: [C: 031] Update WikiGrok user token handling for change I71b5ccc588 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190593 (owner: 10Kaldari) [23:36:08] I'm gonna head out a little early (had a late one last night). Have a gret weekend, see you on Tuesday! [23:40:51] 3Mobile-Web: Icon buttons broken in desktop Minerva skin - https://phabricator.wikimedia.org/T89510#1038126 (10kaldari) 3NEW [23:44:24] bearND: do i owe you anything programmer wise? [23:44:42] bearND: i realize i've said i was going to catch up with you on something, but i don't remember what that was [23:44:45] kaldari: OMG, the merge of the crypto patch MIGHT happen [23:45:22] nuria: If no one complains in the next 30 minutes, I’m merging it myself :) [23:45:26] dr0ptp4kt: have you added a card for Share-A-Fact design adjustments? If so, please let me know so I can duplicate it for Android [23:45:43] bearND: oh right :) thx [23:46:43] bearND: which board you want this in? [23:46:53] kaldari: good, i FULLY support that, figured out our formatting for mw thanks to Krinkle so i have that one under control for next time [23:52:38] 3Mobile-Web: Icon buttons broken in desktop Minerva skin - https://phabricator.wikimedia.org/T89510#1038160 (10kaldari) 5Open>3Resolved a:3kaldari This is already fixed in 1.25wmf17.