[00:05:23] dr0ptp4kt: where the card for iOS goes is up to you. Just let me know where you put it and I can duplicate it for Android. I would probably put it into sprint 51. [00:18:38] 3MediaWiki-API, Mobile-Apps, Wikipedia-App-iOS-App, MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), Wikipedia-App-Android-App: Mobile apps users should not be shown captchas when creating accounts - https://phabricator.wikimedia.org/T88083#1038209 (10csteipp) @Deskana, is there anything else you need from... [00:18:55] 3MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), Wikipedia-App-Android-App, MediaWiki-API, Mobile-Apps, Wikipedia-App-iOS-App: Mobile apps users should not be shown captchas when creating accounts - https://phabricator.wikimedia.org/T88083#1038211 (10csteipp) [00:20:06] 3MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), Wikipedia-App-Android-App, MediaWiki-API, Mobile-Apps, Wikipedia-App-iOS-App: Mobile apps users should not be shown captchas when creating accounts - https://phabricator.wikimedia.org/T88083#1038212 (10Deskana) >>! In T88083#1037165, @brion wrote: > Other mo... [00:41:16] 3MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), Wikipedia-App-Android-App, MediaWiki-API, Mobile-Apps, Wikipedia-App-iOS-App: Mobile apps users should not be shown captchas when creating accounts - https://phabricator.wikimedia.org/T88083#1038265 (10Krenair) If you can come up with a better solution that... [00:54:22] 3MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), Wikipedia-App-Android-App, MediaWiki-API, Mobile-Apps, Wikipedia-App-iOS-App: Mobile apps users should not be shown captchas when creating accounts - https://phabricator.wikimedia.org/T88083#1038287 (10Deskana) >>! In T88083#1038265, @Krenair wrote: > If you... [01:01:14] 3Wikipedia-App-iOS-App: Left side of search icon is cut off on top when tapping search - https://phabricator.wikimedia.org/T89515#1038301 (10Tfinc) 3NEW [01:02:47] 3Wikipedia-App-iOS-App: Average load time of an article is over 5 seconds - https://phabricator.wikimedia.org/T89517#1038318 (10Tfinc) 3NEW [01:04:57] 3Wikipedia-App-iOS-App: In article scrolling performance around images is jerky and inconsistent - https://phabricator.wikimedia.org/T89518#1038325 (10Tfinc) 3NEW [01:06:26] 3Wikipedia-App-iOS-App: Collapsible tables have a 1 second delay when expanding/collapsing - https://phabricator.wikimedia.org/T89519#1038337 (10Tfinc) 3NEW [01:06:48] 3Wikipedia-App-iOS-App: Production release for iOS Wikipedia app in February (provisional) - https://phabricator.wikimedia.org/T86692#1038344 (10Deskana) [01:06:49] 3Wikipedia-App-iOS-App: Average load time of an article is over 5 seconds - https://phabricator.wikimedia.org/T89517#1038345 (10Deskana) [01:07:11] 3Wikipedia-App-iOS-App: Production release for iOS Wikipedia app in March (provisional) - https://phabricator.wikimedia.org/T86692#1038346 (10Deskana) p:5Triage>3Normal [01:07:37] 3Wikipedia-App-iOS-App: Average load time of an article is over 5 seconds - https://phabricator.wikimedia.org/T89517#1038352 (10Deskana) p:5Triage>3High Not quite "Unbreak now!" yet, but it will be soon... [01:08:28] 3Wikipedia-App-iOS-App: In article page images are low quality - https://phabricator.wikimedia.org/T89521#1038366 (10Tfinc) 3NEW [01:10:01] 3Wikipedia-App-iOS-App: In article chrome pops out when you unfold a collapsable table - https://phabricator.wikimedia.org/T89522#1038373 (10Tfinc) 3NEW [01:12:10] 3Wikipedia-App-iOS-App: Tweet a fact UI pop over post share selection is misaligned above save - https://phabricator.wikimedia.org/T89524#1038395 (10Tfinc) 3NEW [01:47:15] 3Wikipedia-App-iOS-App: Footnote overlap on tablets includes significant blank space - https://phabricator.wikimedia.org/T89529#1038478 (10Tfinc) 3NEW [01:48:19] (03CR) 10Kaldari: [C: 032] Update WikiGrok user token handling for change I71b5ccc588 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190593 (owner: 10Kaldari) [01:49:08] tfinc: http://tflig.ht/1dhqz8j [01:51:02] 3Wikipedia-App-iOS-App: Correct capitalisation of "Quick facts" - https://phabricator.wikimedia.org/T89530#1038488 (10Deskana) 3NEW [01:51:24] (03PS1) 10Deskana: Correct capitalisation of "Quick Facts" to "Quick facts" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190626 (https://phabricator.wikimedia.org/T89530) [01:53:15] (03Merged) 10jenkins-bot: Update WikiGrok user token handling for change I71b5ccc588 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190593 (owner: 10Kaldari) [02:17:51] 3Wikipedia-App-iOS-App: App occasionally flashes where lead paragraph is overlapping lead image - https://phabricator.wikimedia.org/T89535#1038571 (10Deskana) 3NEW [04:12:36] (03CR) 10Yuvipanda: [C: 032] Correct capitalisation of "Quick Facts" to "Quick facts" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190626 (https://phabricator.wikimedia.org/T89530) (owner: 10Deskana) [04:14:58] 3Wikipedia-App-iOS-App: Correct capitalisation of "Quick facts" - https://phabricator.wikimedia.org/T89530#1038770 (10yuvipanda) 5Open>3Resolved a:3yuvipanda [04:57:03] 3Mobile-Web: "Read in another language" gives desktop site's links - https://phabricator.wikimedia.org/T67047#1038807 (10C933103) Some other links in wikipedia in general also act in this way, like links generated via Template:link on English Wikipedia. [06:24:48] 3Wikipedia-App-iOS-App: Left side of search icon is cut off on top when tapping search - https://phabricator.wikimedia.org/T89515#1038838 (10Deskana) [06:24:49] 3Wikipedia-App-iOS-App: Production release for iOS Wikipedia app in March (provisional) - https://phabricator.wikimedia.org/T86692#1038837 (10Deskana) [07:50:17] mhurd: Hey! [07:50:24] yo! [07:50:45] mhurd: So what I'm trying to do is test a patch I just wrote on my iPhone. [07:50:53] k [07:51:01] mhurd: Is it possible for me to do that without having to pay Apple $100? :-p [07:51:14] no :( [07:51:31] mhurd: I'd just test what I've done on the simulator but it tweaks the sharing functionality and that sucks to test on the simulator due to it not having sharing apps [07:52:08] true. iirc you only have the email option on sim [07:52:45] Yeah, and that doesn't seem to work properly [07:52:48] I think it fakes it [07:53:25] if you push it to github or gerrit i can run it on my phone and send u screenshot :) [07:53:31] Well, I'll just submit it and see [07:54:06] One sec [07:57:02] 3Wikipedia-App-iOS-App: "Share as text" when you've not highlighted text is generating snippets so long that they can't even be shared on Twitter - https://phabricator.wikimedia.org/T89541#1038878 (10Deskana) [07:58:08] mhurd: Almost ready... [07:58:23] no rush! [07:59:24] (03PS1) 10Deskana: Don't include article snippet in "Share as text" option [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190637 (https://phabricator.wikimedia.org/T89541) [07:59:29] mhurd: ^ [07:59:43] cool just a sec... [08:00:09] mhurd: It's a quick pass at fixing that bug that Jared just sent about the snippet being too long [08:01:28] hehe it’s funny i think the last 2 things adam and i talked about before i left were the text snippet issue and the icon issue, both of which jared noticed right away :) [08:01:36] ^_^ [08:02:06] is there a particular article you want screenshot of? [08:02:33] mhurd: No, not really [08:02:44] mhurd: Why not try it on the article that Jared was on? [08:02:49] mhurd: And see if it fixes the issue? [08:03:00] mhurd: https://en.wikipedia.org/wiki/Salvador_Dal%C3%AD [08:03:04] oh yeah, just a sec… compiling [08:03:14] So go to it, and tap "Share as text" without highlighting anything and try to share to Twitter [08:03:20] k [08:05:39] Superfreak: i don’t have twitter acct - i sent to your email instead [08:05:49] So I think that fixes it [08:05:53] Cool! [08:06:56] Thanks! [08:08:40] Superfreak: i had suggested to adam maybe using the wikidata description, if available, in the case that no text was selected and “share as text” was chosen. maybe could add that later if it makes sense? [08:09:47] Hmm, that's interesting! [08:09:53] Sounds good [08:10:06] SHIP IT! [08:11:22] Hah [08:14:17] Superfreak: oh just noticed your patch breaks share as text if a snippet had been selected... [08:20:41] * Superfreak looks [08:20:43] Superfreak: specifically, the selected snippet is gone [08:24:04] Ahh so I see where the real problem is [08:24:27] The snippet method that's being called returns something if nothing is selected [08:24:35] I should change that instead [08:27:13] I'll think about it tomorrow [08:27:42] (03CR) 10Deskana: [C: 04-1] "Breaks things in the case where a user highlights some text and chooses to share as text. That needs to be fixed." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190637 (https://phabricator.wikimedia.org/T89541) (owner: 10Deskana) [08:29:01] Superfreak: coolness! i’m fixin that search glyph issue jared mentioned... [08:42:08] (03PS2) 10Deskana: Don't include article snippet in "Share as text" option [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190637 (https://phabricator.wikimedia.org/T89541) [08:42:39] (03CR) 10Deskana: [C: 04-1] "Fixed this so it doesn't randomly remove EventLogging stuff. Previous concerns still need to be addressed." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190637 (https://phabricator.wikimedia.org/T89541) (owner: 10Deskana) [08:42:44] mhurd: Alright, sleepy time. [08:42:48] mhurd: Night. :-) [08:42:51] Superfreak: see ya! [08:43:05] Superfreak: good hacking [08:43:14] :) [10:51:15] 3Wikipedia-App-Android-App: add the option to have favorite languages in the app - https://phabricator.wikimedia.org/T36100#1038981 (10MikaelStaldal) Please do not limit this to two languages only. I would like three. [10:58:57] (03CR) 10Mikaelstaldal: "My change would make the app consistent with how the wikipedia.org web site currently works. There you have to select language first, and " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190213 (owner: 10Mikaelstaldal) [11:01:37] (03CR) 10Mikaelstaldal: "I do not want to search for articles in *any* language. I do not want the app to show me articles in a language I cannot read, that would " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190213 (owner: 10Mikaelstaldal) [12:22:31] (03PS1) 10Mhurd: Fix for layout regressions from glyph font consolidation. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190647 [12:23:41] (03PS2) 10Mhurd: Fix for layout regressions from glyph font consolidation. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190647 [12:31:45] 3Wikipedia-App-iOS-App: Left side of search icon is cut off on top when tapping search - https://phabricator.wikimedia.org/T89515#1039045 (10Mhurd) Confirmed that this was a regression introduced when glyph fonts were consolidated. All of the main article buttons were badly misplaced as well. Fixed in this pa... [12:36:00] (03CR) 10Mhurd: "Brian, note that I used the font from your gallery patch, so the 2 glyphs I added for you should be present in this font file too." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190647 (owner: 10Mhurd) [13:20:21] 3MediaWiki-Categories, Mobile-Web: (3) 3 column responsive layout for categories so they render nicely on mobile - https://phabricator.wikimedia.org/T85496#1039061 (10Krinkle) [13:20:50] 3MediaWiki-Categories, Mobile-Web: (3) 3 column responsive layout for categories so they render nicely on mobile - https://phabricator.wikimedia.org/T85496#948174 (10Krinkle) [14:17:56] 3MediaWiki-Categories, Mobile-Web: (3) 3 column responsive layout for categories so they render nicely on mobile - https://phabricator.wikimedia.org/T85496#1039100 (10matmarex) [14:18:49] 3MediaWiki-Categories, Mobile-Web: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1039104 (10matmarex) a:3Sumit [14:19:29] 3MediaWiki-Categories, Mobile-Web: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#577156 (10matmarex) #patch-for-review: https://gerrit.wikimedia.org/r/187952 [14:33:10] 3MobileFrontend: mobile beta: warning icon ⚠, truncated, is triplicated at the top of a page where it appears - https://phabricator.wikimedia.org/T89525#1039113 (10Aklapper) [18:56:01] 3Mobile-Web, MobileFrontend: mobile beta: warning icon ⚠, truncated, is triplicated at the top of a page where it appears - https://phabricator.wikimedia.org/T89525#1039311 (10Florian) [18:56:09] 3Mobile-Web, MobileFrontend: mobile beta: warning icon ⚠, truncated, is triplicated at the top of a page where it appears - https://phabricator.wikimedia.org/T89525#1038404 (10Florian) [18:56:49] 3Mobile-Web, MobileFrontend: mobile beta: warning icon ⚠, truncated, is triplicated at the top of a page where it appears - https://phabricator.wikimedia.org/T89525#1039316 (10Florian) 5Open>3Invalid a:3Florian The problem was already resolved with this change: https://gerrit.wikimedia.org/r/#/c/190188/2... [18:57:54] 3Mobile-Web: Main Page has 100% high edit button - https://phabricator.wikimedia.org/T89559#1039319 (10kaldari) 3NEW [18:59:39] (03PS1) 10Kaldari: Revert "Show edit pencil on all headings" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190662 [19:00:31] (03PS2) 10Kaldari: Revert "Show edit pencil on all headings" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190662 (https://phabricator.wikimedia.org/T89559) [19:02:40] kaldari: ^ have you an example page i can copy to my local environment? [19:02:55] Hey FlorianSW :) [19:03:03] kaldari: Hi :) [19:03:17] FlorianSW: The bug has some sample main page code you can use [19:03:39] ah, ok, i should click "edit task" :D [19:04:12] FlorianSW: Our Main Page rewriting is kind of a pain. I would like to kill it one day. [19:04:31] kaldari: me too, and Jon, and other people :D [19:04:56] FlorianSW: oops, damn parsable HTML [19:05:26] oh weird, it’s actually parsing the WIkitext, not the HTML! [19:05:40] exact ;) [19:05:46] *exactly [19:05:58] 3Mobile-Web: Main Page has 100% high edit button - https://phabricator.wikimedia.org/T89559#1039337 (10Florian) [19:06:02] ^ changed kaldari [19:06:14] thanks! [19:06:55] FlorianSW: Does that reproduce the bug for you? [19:07:00] fuck, that looks terrible :/ [19:07:06] yes, unfortunately, yes :( [19:07:34] FlorianSW: Plus, if you try to click your notifications button, you will probably go to the editor instead :P [19:08:01] yes, i tested it :P It's the whole right side (and the width of the button) [19:08:33] FlorianSW: Sorry I don’t have time to troubleshoot further today, about to leave to run some errands [19:09:07] kaldari: wouldn't it be better to disable this function just for the mainpage? Background: There was another change which changed the toggling of a page, which result in the problem, that the first section probably isn't editable (which doesn't matter, if all sections have an edit pencil) :/ [19:10:25] FlorianSW: I’m OK with just disabling it on the Main Page if you want to do that. Although I would like to run it by product and design at some point (but that doesn’t have to block it). [19:11:02] kaldari: ok, i upload a change :) Is easier as to revert both changes (and probably run into merge conflicts and other funny things :P) [19:12:52] FlorianSW: Any UI changes that potentially affect editing usually have to be approved by Product (Maryana), but hopefully this will be fine. [19:13:36] ok :/ [19:14:01] FlorianSW: Personally, I think it is a nice improvement :) [19:15:03] (03Abandoned) 10Kaldari: Revert "Show edit pencil on all headings" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190662 (https://phabricator.wikimedia.org/T89559) (owner: 10Kaldari) [19:15:51] FlorianSW: OK, well I have to run, but please submit a new patch for disabling on the main page and we can discuss further later. [19:16:26] Adios! [19:16:50] kaldari: ok :) [19:18:57] 3Mobile-Web: Main Page has 100% high edit button - https://phabricator.wikimedia.org/T89559#1039346 (10Florian) a:3Florian [19:22:13] (03PS1) 10Florianschmidtwelzow: Don't show edit pencils on main page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190663 (https://phabricator.wikimedia.org/T89559) [19:22:48] (03CR) 10Florianschmidtwelzow: "Follow up: I8688ddda81d292b80e280f758d6d434f7c748aa7" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189506 (https://phabricator.wikimedia.org/T87644) (owner: 10Florianschmidtwelzow) [19:47:48] (03PS1) 10Florianschmidtwelzow: Don't add height to watchstar button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190665 (https://phabricator.wikimedia.org/T89506) [19:47:57] 3Mobile-Web: Watchstar icons in alpha and beta not aligned - https://phabricator.wikimedia.org/T89506#1039373 (10Florian) a:3Florian [19:49:55] 3Mobile-Web: Left navigation bar icons misaligned in stable - https://phabricator.wikimedia.org/T89436#1039380 (10Florian) 5Open>3Invalid a:3Florian Hmm, can't reproduce anymore (not on mediawiki.org, nor locally :) [19:51:02] 3Mobile-Web, MobileFrontend: Don't override Special:Watchlist with Special:EditWatchlist - https://phabricator.wikimedia.org/T88270#1039388 (10Florian) [19:56:01] 3Mobile-Web, MobileFrontend: Don't override Special:Watchlist with Special:EditWatchlist - https://phabricator.wikimedia.org/T88270#1039393 (10Florian) a:3Florian [20:13:08] (03PS1) 10Florianschmidtwelzow: Change default watchlist from a-z to feed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190670 (https://phabricator.wikimedia.org/T88270) [20:14:19] 3Mobile-Web, MobileFrontend: Don't override Special:Watchlist with Special:EditWatchlist - https://phabricator.wikimedia.org/T88270#1039428 (10Florian) The watchlist saved the last view in the user's options, but i'm agree, that the user (if he clicks on "watchlist" the first time) he assumes to see changes to h... [20:24:20] (03PS1) 10Florianschmidtwelzow: Add the footer really after the content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190673 (https://phabricator.wikimedia.org/T88499) [20:24:51] 3Mobile-Web: Alpha: Wrong position for the last edited bar when images are present on the page - https://phabricator.wikimedia.org/T88499#1039436 (10Florian) a:3Florian [20:35:50] (03PS1) 10Florianschmidtwelzow: useFileCache hook must be prefixed with the correct class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190675 (https://phabricator.wikimedia.org/T78021) [20:35:56] (03CR) 10jenkins-bot: [V: 04-1] useFileCache hook must be prefixed with the correct class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190675 (https://phabricator.wikimedia.org/T78021) (owner: 10Florianschmidtwelzow) [20:36:15] (03Abandoned) 10Florianschmidtwelzow: useFileCache hook must be prefixed with the correct class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190675 (https://phabricator.wikimedia.org/T78021) (owner: 10Florianschmidtwelzow) [20:47:35] (03CR) 10Florianschmidtwelzow: "@bmansurov: That doesn't matter, this is build on top of the function hasChanged() which is handeld in EditorOverlay and VisualEditorOverl" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [20:50:59] (03PS3) 10Florianschmidtwelzow: Ask the user if he want to leave the editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) [20:53:32] (03PS4) 10Florianschmidtwelzow: Ask the user if he want to leave the editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) [20:54:32] (03CR) 10jenkins-bot: [V: 04-1] Ask the user if he want to leave the editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [21:04:34] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow)