[04:17:44] <wikibugs>	 2Wikipedia-App-Android-App: Make it easier to access talk pages - https://phabricator.wikimedia.org/T89606#1040738 (10Deskana) p:5Triage>3Volunteer? Talk pages serve mobile users really poorly right now. In order to resolve that problem we'd need to invest a lot in to this, and we're not capable of doing t...
[08:43:30] <joakino>	 morning!
[08:45:58] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] "D'oh!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190729 (owner: 10Florianschmidtwelzow)
[08:46:25] <MaxSem>	 yo joakino, do you work today?
[08:46:35] <joakino>	 yes!
[08:46:44] <joakino>	 MaxSem: how are you awake still :p
[08:47:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Fix false composer phpunit dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190729 (owner: 10Florianschmidtwelzow)
[08:47:04] <MaxSem>	 it's just past midnight
[08:47:27] <MaxSem>	 and imma big kid
[08:47:29] <joakino>	 haha
[08:47:36] <joakino>	 MaxSem: how was the weekend
[08:47:49] <MaxSem>	 reasonable:P
[08:48:19] <MaxSem>	 note that tomorrow is also a weekend
[08:48:41] <joakino>	 amerikaa haha
[08:49:00] <joakino>	 i'm taking friday instead, going to london this next weekend
[08:49:30] <MaxSem>	 https://www.youtube.com/watch?v=NteVmdoo1yI
[08:50:36] <joakino>	 great song
[08:51:01] <joakino>	 wunderbaarrr
[09:47:36] <Yuvi|Vacation>	 joakino: I responded!
[09:47:45] <Yuvi|Vacation>	 oh, you hadn't
[09:47:48] <joakino>	 hey Yuvi|Vacation!
[09:47:48] <Yuvi|Vacation>	 nevermind
[09:47:52] <joakino>	 what?
[09:47:52] <Yuvi|Vacation>	 hi joakino 
[09:49:51] <Yuvi|Vacation>	 joakino: there was an email from phuedx to me, you and a bunch of others.
[09:50:05] <Yuvi|Vacation>	 brian had replied but for some reason I thought it was you
[09:50:16] <joakino>	 haha ok :)
[09:50:19] <joakino>	 i'll read it soon
[09:50:28] <joakino>	 Yuvi|Vacation: are you on SF already?
[09:50:43] <Yuvi|Vacation>	 joakino: no! am in Goa, near a beach
[09:51:20] <joakino>	 oh cool
[09:51:30] <joakino>	 hows the weather there
[11:21:47] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "@bmansurov: npm and extension integration (hhvm and zend) are in the test pipeline i think, not in the check-only." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit)
[11:21:48] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit)
[11:23:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Overlay,Panel,Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit)
[13:11:29] <grrrit-wm>	 (03PS12) 10Sumit: Overlay,Panel,Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) 
[14:42:41] <wikibugs>	 3Wikipedia-App-Android-App, Wikipedia-App-General-or-Unknown: Handle edit conflicts on the mobile app in some way - https://phabricator.wikimedia.org/T66281#1041544 (10FriedhelmW) p:5Triage>3Unbreak!
[15:03:18] <Krenair>	 hi dbrant 
[15:03:26] <dbrant>	 hello!
[15:03:35] <Krenair>	 isn't it a holiday over there? :p
[15:03:58] <dbrant>	 just catching up on a few things ;)
[15:05:41] <Krenair>	 Was I correct at https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8125046 ?
[15:07:12] <dbrant>	 Krenair: that's absolutely right
[15:07:27] <Krenair>	 what about the reply? :/
[15:09:40] <dbrant>	 Hard to say... it's possible that the user missed the "/data/data/..." (two of them) path
[15:15:23] <Krenair>	 dbrant, does it need root?
[15:17:11] <dbrant>	 Krenair: actually... I think it might! :(  All of my devices are rooted, so I didn't think twice about it.  Totally missed that.
[15:18:00] <Krenair>	 :(
[15:20:36] <grrrit-wm>	 (03PS3) 10Dbrant: Make nav drawer overlap over search bar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187849 
[15:23:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make nav drawer overlap over search bar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187849 (owner: 10Dbrant)
[15:27:41] <Krenair>	 dbrant, there is https://stackoverflow.com/questions/13006315/how-to-access-data-data-folder-in-android-device
[15:32:29] <dbrant>	 Krenair: yeah, it can be done via adb.  But ultimately the user probably just wants to copy the saved pages to another device, which we simply don't support yet :(
[15:37:28] <grrrit-wm>	 (03CR) 10Dbrant: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187849 (owner: 10Dbrant)
[15:41:20] <grrrit-wm>	 (03PS4) 10Dbrant: Make nav drawer overlap over search bar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187849 
[15:41:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make nav drawer overlap over search bar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187849 (owner: 10Dbrant)
[15:45:11] <grrrit-wm>	 (03PS5) 10Dbrant: Make nav drawer overlap over search bar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187849 
[15:45:31] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make nav drawer overlap over search bar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187849 (owner: 10Dbrant)
[15:47:02] <grrrit-wm>	 (03PS6) 10Dbrant: Make nav drawer overlap over search bar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187849 
[15:47:15] <wikibugs>	 3Wikipedia-App-Android-App, Wikipedia-App-General-or-Unknown: Handle edit conflicts on the mobile app in some way - https://phabricator.wikimedia.org/T66281#1041625 (10Deskana) p:5Unbreak!>3Normal Don't panic! This is a normal priority issue. :-)
[15:47:31] <codezee>	 help needed!, I've added a jquery parameter to InfoOverlay.js, which I believe is causing qunit tests to fail
[15:47:35] <codezee>	 https://gerrit.wikimedia.org/r/#/c/188673/12/javascripts/modules/wikiGrokRoulette/InfoOverlay.js
[15:47:46] <codezee>	 test result:https://dpaste.de/rM95
[15:48:12] <codezee>	 what can I possibly do to restore the functionality?
[15:55:13] <joakino>	 codezee: it is holiday on the US so i don't think anybody is going to connect
[15:55:17] <joakino>	 i gotta leave for a while
[15:55:22] <joakino>	 sorry :(
[15:55:38] <codezee>	 joakino: alright, I'll ask sometime later :)
[15:55:53] <joakino>	 codezee: i'll be around in about 3 hours
[15:56:07] <joakino>	 bb!
[15:56:16] <codezee>	 joakino: ok!, if I'll see you, I'll jus tping
[15:56:23] <codezee>	 *just
[16:04:31] <grrrit-wm>	 (03CR) 10Sumit: [V: 04-1] "the qunit tests still fail, possibly due to adding a jquery parameter in InfoOverlay.js and UploadTutorial.js, but I'm unable to figure ou" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit)
[16:05:42] <grrrit-wm>	 (03CR) 10Sumit: [C: 04-1] Overlay,Panel,Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit)
[16:34:49] <grrrit-wm>	 (03PS1) 10Dbrant: Fix scrolling when tapping and dragging over lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190820 (https://phabricator.wikimedia.org/T87128) 
[17:02:39] <wikibugs>	 3Wikidata, Mobile-Web: Mobile version of Dutch Wikisource doesn't list other language version. - https://phabricator.wikimedia.org/T89566#1041759 (10Lydia_Pintscher)
[17:14:17] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 04-1] TOC: horizontal scrolling added for long words (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190734 (https://phabricator.wikimedia.org/T89367) (owner: 10Sumit)
[17:29:04] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] "bring jenkins back to life" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190663 (https://phabricator.wikimedia.org/T89559) (owner: 10Florianschmidtwelzow)
[17:30:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't show edit pencils on main page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190663 (https://phabricator.wikimedia.org/T89559) (owner: 10Florianschmidtwelzow)
[17:34:53] <grrrit-wm>	 (03PS1) 10Bmansurov: Add border to local notice [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190826 
[17:38:48] <FlorianSW>	 hi codezee :) How are you?
[17:39:11] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 031] "Not sure what you mean by 'breaks rotate', but it works fine for me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190665 (https://phabricator.wikimedia.org/T89506) (owner: 10Florianschmidtwelzow)
[17:39:41] <codezee>	 FlorianSW: hi, I'm doing fine :), though in a little fix
[17:40:48] <codezee>	 FlorianSW: I've posted the comments at https://gerrit.wikimedia.org/r/#/c/188673/
[17:41:36] <FlorianSW>	 codezee: i took the task https://phabricator.wikimedia.org/T88499 and haven't seen, that you wanted to work on it, sorry :( Yeah, i'll take a look :)
[17:42:26] <FlorianSW>	 bmansurov: about the change ^ :D I mean, that the rotate css rule breaks, if the height is set, iirc (i haven't found words to describe this :/)
[17:42:40] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: TWN: Use own message for terms of use link in license warning (editor and talk) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190831 
[17:42:49] <bmansurov>	 FlorianSW: ohh, i thought your fix breaks it ;))
[17:43:02] <bmansurov>	 You could add 'Otherwise' to the beginning of the sentence ;)
[17:43:12] <FlorianSW>	 bmansurov: no, ok, i see, it's really bad english :D
[17:43:23] <codezee>	 FlorianSW: its ok, no problem, I didn't give time to it, I'll look around :)
[17:44:00] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Don't add height to watchstar button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190665 (https://phabricator.wikimedia.org/T89506) 
[17:44:18] <codezee>	 FlorianSW: also, test fail results - https://dpaste.de/rM95
[17:44:31] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Don't add height to watchstar button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190665 (https://phabricator.wikimedia.org/T89506) (owner: 10Florianschmidtwelzow)
[17:44:34] <FlorianSW>	 codezee: 404 Not found
[17:44:37] <FlorianSW>	 :D
[17:45:02] <codezee>	 FlorianSW: sorry, expired, I'll upload another :P
[17:45:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't add height to watchstar button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190665 (https://phabricator.wikimedia.org/T89506) (owner: 10Florianschmidtwelzow)
[17:45:47] <grrrit-wm>	 (03PS13) 10Florianschmidtwelzow: Use View##events in Overlay, Panel and Drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit)
[17:46:07] <codezee>	 FlorianSW: here - https://dpaste.de/k2fp
[17:46:17] <wikibugs>	 3Mobile-Web: Watchstar icons in alpha and beta not aligned - https://phabricator.wikimedia.org/T89506#1041892 (10Florian) 5Open>3Resolved
[17:46:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use View##events in Overlay, Panel and Drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit)
[17:47:33] <codezee>	 FlorianSW: the only reason I see for test fail is that I had added a jquery parameter to InfoOverlay.js
[17:48:18] <codezee>	 FlorianSW: and also to UploadTutorial.js
[17:48:54] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Reset clicked state of VE editor switcher when loading fails [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190474 (https://phabricator.wikimedia.org/T89462) (owner: 10Florianschmidtwelzow)
[17:49:16] <FlorianSW>	 codezee: i'll take a look :)
[17:49:26] <wikibugs>	 3Mobile-Web: EditorOverlay: If VE can't be loaded, reset the clicked state of the switcher - https://phabricator.wikimedia.org/T89462#1041899 (10bmansurov) 5Open>3Resolved
[17:49:32] <codezee>	 FlorianSW: thanks...
[17:50:10] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Reset clicked state of VE editor switcher when loading fails [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190474 (https://phabricator.wikimedia.org/T89462) (owner: 10Florianschmidtwelzow)
[17:50:39] <grrrit-wm>	 (03PS1) 10Dbrant: Update launcher icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190835 
[17:55:03] <grrrit-wm>	 (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190474 (https://phabricator.wikimedia.org/T89462) (owner: 10Florianschmidtwelzow)
[17:57:10] <mhurd>	 Deskana: yo!
[17:57:18] <Deskana>	 mhurd: Good morning!
[18:01:03] <mhurd>	 Deskana: we’re still doing standup? should be quick :)
[18:02:15] <Deskana>	 mhurd: I think so, yeah
[18:02:34] <mhurd>	 Deskana: sounds good!
[18:04:49] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 04-1] "I think the bug is talking about the Watchlist in the main menu. It should take the user to http://127.0.0.1:8080/w/index.php?title=Specia" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190670 (https://phabricator.wikimedia.org/T88270) (owner: 10Florianschmidtwelzow)
[18:08:08] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "correct. If you never clicked on the watchlist (so you're a new user e.g.), you will be redirected to the default watchlist. For all futur" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190670 (https://phabricator.wikimedia.org/T88270) (owner: 10Florianschmidtwelzow)
[18:09:50] <grrrit-wm>	 (03CR) 10BearND: [C: 032] "Still feel there is missing something on the top of the nav drawer. So I hope there will be some design improvements following." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187849 (owner: 10Dbrant)
[18:12:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make nav drawer overlap over search bar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/187849 (owner: 10Dbrant)
[18:13:51] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Update launcher icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190835 (owner: 10Dbrant)
[18:14:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update launcher icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190835 (owner: 10Dbrant)
[18:15:02] <codezee>	 FlorianSW: how can jenkins be made to run all tests instead of just two, which it was doing in that patch?
[18:15:19] <FlorianSW>	 codezee: one second, ok :)
[18:15:43] <FlorianSW>	 bmansurov: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/javascripts/modules/wikigrok/WikiGrokDialogC.js#L96 why do you call Drawer's prototype postRender? wikiGrok uses panel and :/
[18:16:24] <grrrit-wm>	 (03CR) 10Bmansurov: "Why not do it in css? Something like this:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190673 (https://phabricator.wikimedia.org/T88499) (owner: 10Florianschmidtwelzow)
[18:17:01] <bmansurov>	 FlorianSW: because wikigrok version C is supposed to be fixed at the bottom of the page
[18:17:06] <bmansurov>	 i.e. drawer
[18:17:24] <bmansurov>	 FlorianSW: also lines 15 and 16
[18:17:51] <FlorianSW>	 codezee: All "new" users are in a test pipeline called "check-only" which runs "Only" basic tests like lint's. For other tests (which takes much more resources), e.g. npm, qunit and so on, you need to be a wmf staff or a so called "trusted user". So for you it's actually not possible to trigger the test pipeline (which includes npm, qunit and so on) :/ You should run the tests locally and submit them if there isn't an error
[18:18:21] <FlorianSW>	 ...rebase the change, or use the "recheck" key, zuul wil trigger all jobs connected with our accounts, which will normally be all tests :)
[18:18:45] <codezee>	 FlorianSW: ok :)
[18:19:36] <FlorianSW>	 bmansurov: hmm, ok :/ because it breaks the change from codezee (https://gerrit.wikimedia.org/r/#/c/188673/13/javascripts/Drawer.js) because postRender references a function that does exist in Drawer class, but not in WikiGrokDialogC :/
[18:20:34] <bmansurov>	 FlorianSW: which function?
[18:20:58] <FlorianSW>	 bmansurov: new functions, onShowDrawer and onHideDrawer
[18:21:09] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] Use View##events in Overlay, Panel and Drawer (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit)
[18:21:53] <bmansurov>	 FlorianSW: ok then we should initialize Drawer in WikigrokC then 
[18:22:40] <FlorianSW>	 yap, or you extend WikiGrokDialogB and Drawer, that should work, too
[18:22:44] <FlorianSW>	 bmansurov: ^
[18:23:02] <bmansurov>	 yes
[18:23:29] <FlorianSW>	 codezee: do you read it? ^
[18:23:42] <codezee>	 FlorianSW: yes, I'm reading it, I see the problem now
[18:23:58] <FlorianSW>	 great :)
[18:24:45] <grrrit-wm>	 (03CR) 10BearND: [C: 04-1] "does not compile" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190820 (https://phabricator.wikimedia.org/T87128) (owner: 10Dbrant)
[18:25:44] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] "hmm, haven't thought about it :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190673 (https://phabricator.wikimedia.org/T88499) (owner: 10Florianschmidtwelzow)
[18:28:58] <grrrit-wm>	 (03PS2) 10Dbrant: Fix scrolling when tapping and dragging over lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190820 (https://phabricator.wikimedia.org/T87128) 
[18:29:08] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Add clear:both before the page-secondary-actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190673 (https://phabricator.wikimedia.org/T88499) 
[18:29:51] <wikibugs>	 3Mobile-Web: Main Page has 100% high edit button - https://phabricator.wikimedia.org/T89559#1041976 (10Florian) 5Open>3Resolved
[18:31:19] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 04-1] Ask the user if he want to leave the editor (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow)
[18:33:11] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 04-1] Add clear:both before the page-secondary-actions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190673 (https://phabricator.wikimedia.org/T88499) (owner: 10Florianschmidtwelzow)
[18:35:10] <bgerstle>	 mhurd Deskana is the lead image supposed to be shown in landscape?
[18:35:22] <mhurd>	 Deskana: no
[18:35:25] <bgerstle>	 mhurd since you're looking at the native "header" component
[18:35:25] <mhurd>	 Deskana: by design
[18:35:29] <bgerstle>	 why?
[18:36:00] <mhurd>	 bgerstle: mvp was spec’ed to be portrait only for now. 
[18:36:08] <Deskana>	 For the MVP, it was agreed that we wouldn't think about it in landscape mode because the aspect ratio makes it harder than in portrait.
[18:36:27] <bgerstle>	 hm
[18:36:28] <bgerstle>	 ok
[18:36:44] <Deskana>	 Rather than do something which might kind of work then open a can of design worms, we just decided to not deal with that.
[18:37:24] <mhurd>	 bgerstle: especially on tablets - stretching images out etc. we expected to revisit at some point in future
[18:37:29] <bgerstle>	 Deskana mhurd in either case, should the lead image show when you rotate back to portrait?
[18:37:37] <mhurd>	 bgerstle: it does
[18:37:41] <Deskana>	 bgerstle: Yep
[18:37:43] <bgerstle>	 mhurd not in my experience
[18:37:44] <bgerstle>	 not always
[18:37:58] <mhurd>	 bgerstle: did the artifcle have a lead image?
[18:38:14] <bgerstle>	 yeah, i'll have to try it some more to get exact reproduction steps
[18:38:18] <mhurd>	 bgerstle: def record any instances you find though :)
[18:38:21] <bgerstle>	 yeah
[18:38:37] <bgerstle>	 mhurd for the scaling, though, it should only be a matter of scale aspect fill
[18:38:44] <bgerstle>	 whether it looks good is another question
[18:39:03] <bgerstle>	 but, whether any of our lead images look good is kind of a toss-up
[18:39:07] <mhurd>	 bgerstle: it was more an issue of stretching lower res image out making it look pixelated
[18:39:17] <bgerstle>	 right
[18:39:27] <bgerstle>	 makes sense
[18:39:34] <Deskana>	 And also, how much of the screen you want it to take up
[18:39:38] <grrrit-wm>	 (03CR) 10BearND: [C: 04-1] "If starting to drag up from the bottom of the lead image (roughly where the description is) and continuing up to the edge of the screen I " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190820 (https://phabricator.wikimedia.org/T87128) (owner: 10Dbrant)
[18:39:40] <Deskana>	 We wanted to keep the text above the fold
[18:39:40] <mhurd>	 bgerstle: we had/have other lead image layout challenges as it is, so scoped it narrowly
[18:40:12] <Deskana>	 So then you need an image that takes up around half of the height of the screen, and since the screen is much wider than it is tall in landscape mode, you'd end up with a very wide image
[18:40:20] <bgerstle>	 mhurd so you'll hide the lead image when in landscape, but show the other components of your header?
[18:40:28] <mhurd>	 bgerstle: yes
[18:40:36] <bgerstle>	 Deskana right
[18:40:38] <mhurd>	 bgerstle: that’s how it presently works
[18:41:16] <Deskana>	 These aren't problems that we can't figure out, but we didn't want to have to figure them out to move forwards on this
[18:41:23] <Deskana>	 Portrait is much easier due to the aspect ratios in that mode
[18:42:06] <bgerstle>	 sure
[18:42:42] <bgerstle>	 and other things are probably more important than supporting landscape. just wondering if we're making more work for ourselves by special-casing our orientation support
[18:43:10] <bgerstle>	 but if it's simple as a "hide lead image when landscape" piece of logic, should be fine
[18:43:38] <bgerstle>	 wanted to make sure it was a feature, not a bug
[18:43:51] <bgerstle>	 i'll let you know if i can narrow down a scenario when it doesn't reappear
[18:44:35] <mhurd>	 bgerstle: yeah, making it do so was a bit more work, but it’s done such that the change takes place as part of the rotation animation, so it looks smooth - you’ll notice the lead title text color changes as part of this animation as well
[18:44:44] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Hygiene: Use Config object in SpecialPages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190841 (https://phabricator.wikimedia.org/T87614) 
[18:45:59] <FlorianSW>	 bmansurov: can you re-+2 this: https://gerrit.wikimedia.org/r/#/c/190474/ ? :)
[18:46:08] <bgerstle>	 mhurd also, i set the thumb width/height constraints to the max screen dimension (so landscape or portrait will at most fill the screen)
[18:46:12] <bgerstle>	 but now you can't zoom
[18:46:20] <grrrit-wm>	 (03CR) 10Bmansurov: [V: 032] Reset clicked state of VE editor switcher when loading fails [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190474 (https://phabricator.wikimedia.org/T89462) (owner: 10Florianschmidtwelzow)
[18:46:25] <bgerstle>	 unless you want to zoom farther than 1:1
[18:47:15] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] Add clear:both before the page-secondary-actions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190673 (https://phabricator.wikimedia.org/T88499) (owner: 10Florianschmidtwelzow)
[18:48:12] <Deskana>	 bgerstle: And about the merging, generally getting stuff merged in small chunks will let me see it sooner without you having to set up a meeting to show it to me.
[18:48:20] <FlorianSW>	 bmansurov: you need to remove your +2 on review column and add it again :/
[18:48:29] <Deskana>	 bgerstle: That's good for both of us, because the earlier you get the feedback the less you might have to change after the fact. :-)
[18:48:38] <grrrit-wm>	 (03CR) 10Bmansurov: Reset clicked state of VE editor switcher when loading fails [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190474 (https://phabricator.wikimedia.org/T89462) (owner: 10Florianschmidtwelzow)
[18:48:40] <mhurd>	 bgerstle: for the higher res version i think this should be a fixed resolution consistent with what android uses so we don’t cause unknown number of new resolutions of image to be created/cached.
[18:48:46] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Reset clicked state of VE editor switcher when loading fails [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190474 (https://phabricator.wikimedia.org/T89462) (owner: 10Florianschmidtwelzow)
[18:48:51] <bgerstle>	 Deskana trust me, i would have if i knew i could merge it w/o it going out prematurely
[18:48:58] <grrrit-wm>	 (03PS3) 10Florianschmidtwelzow: Add clear:both before the page-secondary-actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190673 (https://phabricator.wikimedia.org/T88499) 
[18:49:00] <bgerstle>	 AFAIK we don't have feature flags
[18:49:46] <Deskana>	 We need a proper alpha for the iOS app.
[18:49:46] <bgerstle>	 mhurd if it's any smaller, it will look blurry
[18:49:56] <Deskana>	 TestFlight is kind of both alpha and beta right now and it's annoying.
[18:49:59] <bgerstle>	 it's not a matter of alpha/beta
[18:50:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Reset clicked state of VE editor switcher when loading fails [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190474 (https://phabricator.wikimedia.org/T89462) (owner: 10Florianschmidtwelzow)
[18:50:04] <bgerstle>	 it's a matter of having control over what users see
[18:50:15] <bgerstle>	 and being able to merge code w/o potentially blocking release
[18:50:33] <mhurd>	 bgerstle: the image info query will return you the closest resolution it has to the one you requested, it will not scale up
[18:50:43] <Deskana>	 And whether we're happy with users seeing it depends on whether it's relatively stable but still untested (beta) or unstable but kind of working (alpha)... so, actually, it is about alpha and beta.
[18:50:47] <mhurd>	 *will return url*
[18:50:51] <bgerstle>	 mhurd that's not what i'm seeing. it's scaling up to 2048
[18:50:56] <Deskana>	 It's about both
[18:51:25] <mhurd>	 bgerstle: hmm what query parameters are you using? 
[18:51:28] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Add clear:both before the page-secondary-actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190673 (https://phabricator.wikimedia.org/T88499) (owner: 10Florianschmidtwelzow)
[18:51:38] <wikibugs>	 3Mobile-Web: Alpha: Wrong position for the last edited bar when images are present on the page - https://phabricator.wikimedia.org/T88499#1042072 (10bmansurov) 5Open>3Resolved
[18:52:17] <mhurd>	 bgerstle: i think i found ‘em… testing...
[18:52:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add clear:both before the page-secondary-actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190673 (https://phabricator.wikimedia.org/T88499) (owner: 10Florianschmidtwelzow)
[18:53:16] <bgerstle>	 Deskana right, but if i were to just merge the image gallery in the state it's in now, wouldn't you get a flood of noise about a feature you know isn't ready to be seen?
[18:53:30] <Deskana>	 Noise from where?
[18:53:36] <bgerstle>	 whoever's using the app? testers?
[18:53:51] <bgerstle>	 people in alpha/beta?
[18:54:20] <Deskana>	 We've never really had that problem in our experience.
[18:54:31] <Deskana>	 The feedback tends to be very manageable.
[18:54:59] <Deskana>	 And also, it's kind of a chicken and egg problem, because I don't know whether it's ready to be shown to users because I don't know how it looks :P
[18:55:39] <bgerstle>	 right
[18:55:43] <bgerstle>	 that's exactly the problem
[18:55:48] <bgerstle>	 if i merge the image gallery
[18:55:53] <bgerstle>	 and it's not ready
[18:55:55] <bgerstle>	 but we want to release..?
[18:56:08] <bgerstle>	 this is where feature flags come in handy
[18:57:08] <bgerstle>	 i _want_ to show you
[18:57:16] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Ask the user if he want to leave the editor (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow)
[18:57:20] <bgerstle>	 but my concern was that putting it in would have blocked the TF build
[18:57:57] <mhurd>	 bgerstle: quick hangout? i think i see the problem
[18:58:10] <bgerstle>	 mhurd i have a 1:1 w/ tomasz in a minute. maybe after?
[18:58:16] <mhurd>	 bgerstle: ya sure
[18:58:32] <grrrit-wm>	 (03PS5) 10Florianschmidtwelzow: Ask the user if he want to leave the editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) 
[19:00:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Ask the user if he want to leave the editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow)
[19:03:16] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow)
[19:06:11] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Ask the user if he want to leave the editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow)
[19:06:45] <bgerstle>	 mhurd it appears tfinc isn't working today, call me whenever
[19:07:09] <mhurd>	 bgerstle: good to know - i had 1:1 schedules today as well...
[19:07:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Ask the user if he want to leave the editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow)
[19:08:04] <wikibugs>	 3Mobile-Web: The mobile Web wikicode editor loses the user-entered text - https://phabricator.wikimedia.org/T88949#1042110 (10bmansurov) 5Open>3Resolved @Nnemo, since the editor is constructed on the fly without extra work to save the user's changes, the default browser behavior doesn't apply here.
[19:09:27] <bmansurov>	 FlorianSW: what does TWN stand for?
[19:09:38] <FlorianSW>	 translatewiki.net :D
[19:09:40] <FlorianSW>	 sorry :P
[19:09:47] <bmansurov>	 np, thanks
[19:09:59] <FlorianSW>	 [[TWN]]
[19:10:10] <FlorianSW>	 @link
[19:10:11] <wm-bot2>	 http://enwp.org/TWN
[19:10:33] <FlorianSW>	 fu**, false, it should be mediawiki.org, not enwiki :)
[19:10:39] <FlorianSW>	 [[mediawiki:TWN]]
[19:10:40] <FlorianSW>	 @link
[19:10:40] <wm-bot2>	 http://enwp.org/mediawiki:TWN
[19:10:51] <FlorianSW>	 *grrr*
[19:11:01] <FlorianSW>	 [[mediawikiwiki:TWN]]
[19:11:02] <FlorianSW>	 @link
[19:11:02] <wm-bot2>	 http://enwp.org/mediawikiwiki:TWN
[19:11:13] <FlorianSW>	 aha :D bmansurov ^
[19:11:30] <bmansurov>	 :)
[19:13:30] <grrrit-wm>	 (03CR) 10Bmansurov: "Please change these in the commit message:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190831 (owner: 10Florianschmidtwelzow)
[19:13:50] <wikibugs>	 3Wikipedia-App-Android-App: Storing current scroll location for each article? - https://phabricator.wikimedia.org/T89607#1042116 (10Deskana) p:5Triage>3Low This is a nice idea to support the "I'm not finished reading, and want to read it later" use case. We'd need to think about how to do this in a way that...
[19:16:39] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: TWN: Use own message for terms of use link in license warning (editor and talk) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190831 
[19:17:07] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-2] "I want to wait for a response of the user on TWN, if this would solve the problem :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190831 (owner: 10Florianschmidtwelzow)
[19:18:41] <Deskana>	 mhurd: Aha, Adam was using the epic card to track the final set of design changes.
[19:18:54] <Deskana>	 mhurd: So I copied that checklist onto a separate card and put the epic in "Done
[19:29:27] <wikibugs>	 3Wikipedia-App-Android-App, Mobile-Apps, Wikipedia-App-iOS-App: Upload photos on Wikipedia mobile app's edit screen - https://phabricator.wikimedia.org/T88746#1042136 (10Deskana)
[19:31:01] <joakino_>	 sup
[19:33:50] <wikibugs>	 3Wikipedia-App-Android-App, Mobile-Apps, Wikipedia-App-iOS-App: Upload photos on Wikipedia mobile app's edit screen - https://phabricator.wikimedia.org/T88746#1042143 (10Deskana) >>! In T88746#1019516, @Tobias1984 wrote: > I think it should be more a discussion about the needs of the community. If the community...
[20:23:37] <mhurd>	 Deskana: running to lunch
[20:24:04] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: TWN: mf-profile-last-thanked should really say "last thanked by" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190854 
[20:26:19] <grrrit-wm>	 (03CR) 10Nemo bis: [C: 031] "Thanks. I guess the original author of this message thought the "last" was an unnecessary detail, but it's actually something which got me" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190854 (owner: 10Florianschmidtwelzow)
[21:22:34] <bearND>	 Deskana: should https://meta.wikimedia.org/wiki/Schema:MobileWikiAppShareAFact be updated for the case where no text is selected and the share menu item from the overflow menu is used? Also do we want to track "share as text" results?
[21:24:25] <Deskana>	 Hmm.
[21:24:50] <bearND>	 In the case where no text gets selected there would not be a highlight event.
[21:25:41] <Deskana>	 Yeah, that's interesting.
[21:25:45] <Deskana>	 I'll need to think about this.
[21:25:57] <Deskana>	 The new UX might change exactly what we want to measure.
[21:25:57] <bearND>	 sure
[21:26:32] <Deskana>	 bearND: I'll try to give you an answer by tomorrow. Any changes we need to make will be minor but we should make them quite fast so we can get it out soon.
[21:27:44] <bearND>	 Deskana: I just came across it as I was refactoring the code, and I felt I needed to pass the funnel into the new common ShareHandler class
[21:28:59] <Deskana>	 bearND: Is my lack of an answer right now blocking you from proceeding?
[21:29:06] <bearND>	 No. I'll just add a null check for the funnel for now
[21:29:07] <Deskana>	 bearND: If it is I can drop what I'm doing.
[21:29:20] <Deskana>	 Alright. Thanks!
[21:46:32] <wikibugs>	 3Wikipedia-App-iOS-App: Wikipedia-ios-share-article-name-on-wikipedia/ja - https://phabricator.wikimedia.org/T89604#1042340 (10Nemo_bis)
[21:47:12] <wikibugs>	 3Wikipedia-App-iOS-App: Wikipedia-ios-share-article-name-on-wikipedia/ja - https://phabricator.wikimedia.org/T89604#1040181 (10Nemo_bis)
[22:13:45] <wikibugs>	 3Wikipedia-App-iOS-App: Wikipedia-ios-share-article-name-on-wikipedia/ja - https://phabricator.wikimedia.org/T89604#1042379 (10Deskana) @Takot Thanks for the report. We've had issues with the same string on Android, mainly because the purpose of the string is complicated and we're not adequately explaining what...
[22:14:24] <grrrit-wm>	 (03PS1) 10Deskana: Improve descriptions for some strings in Share a Fact feature. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190941 (https://phabricator.wikimedia.org/T89604) 
[22:14:44] <Deskana>	 mhurd: ^ Can you give this a quick review?
[22:14:55] <Deskana>	 mhurd: Pretty minor string change, should only take a minute.
[22:15:17] <Deskana>	 Wait, I found a typo.
[22:15:35] <mhurd>	 Deskana: k
[22:15:35] <grrrit-wm>	 (03PS2) 10Deskana: Improve descriptions for some strings in Share a Fact feature. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190941 (https://phabricator.wikimedia.org/T89604) 
[22:15:41] <Deskana>	 mhurd: Okay, now it's good ^
[22:15:51] <bgerstle>	 Deskana mhurd was addressing some code-review comments from corey, nearing completion but need to break for a bit
[22:15:57] <bgerstle>	 will be on again later
[22:16:07] <Deskana>	 bgerstle: Good stuff. Thanks!
[22:16:12] <mhurd>	 bgerstle: k
[22:16:18] <bgerstle>	 o/
[22:16:32] <Deskana>	 mhurd: No, wait, sorry
[22:16:39] <Deskana>	 mhurd: I wrote something stupid
[22:16:47] <mhurd>	 Deskana: no worry
[22:16:51] <Deskana>	 mhurd: What do I use to escape quotes in this? A backslash?
[22:17:26] <mhurd>	 Deskana: are there other quotes being escaped somewhere in that file? i’d have to check
[22:17:42] <Deskana>	 Good thinking. Yep, it's a backslash.
[22:17:59] <mhurd>	 cool!
[22:18:14] <grrrit-wm>	 (03PS3) 10Deskana: Improve descriptions for some strings in Share a Fact feature. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190941 (https://phabricator.wikimedia.org/T89604) 
[22:18:16] <Deskana>	 mhurd: Alright, I'm done.
[22:18:23] <Deskana>	 patchfinalfinalfinalfinal.pdf
[22:18:27] <mhurd>	 hehe
[22:19:20] <mhurd>	 Deskana: looks good. do you want that merged now so twn gets what they need asap?
[22:19:26] <Deskana>	 mhurd: Yes please
[22:19:30] <mhurd>	 Deskana: k
[22:21:04] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Per Dan merged this now so TWN gets clarification a.s.a.p." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190941 (https://phabricator.wikimedia.org/T89604) (owner: 10Deskana)
[22:21:11] <Deskana>	 mhurd: Thank you sir!
[22:21:16] <mhurd>	 Deskana: np!
[22:21:21] <mhurd>	 Deskana: good catch
[22:22:23] <wikibugs>	 3Wikipedia-App-iOS-App: Wikipedia-ios-share-article-name-on-wikipedia/ja - https://phabricator.wikimedia.org/T89604#1042406 (10Deskana) 5Open>3Resolved a:3Deskana I'm closing this as resolved as, hopefully, the improved description which was just merged (and will be synced with translatewiki soon) will hel...
[22:22:49] <wikibugs>	 3Wikipedia-App-iOS-App: Wikipedia-ios-share-article-name-on-wikipedia/ja - https://phabricator.wikimedia.org/T89604#1042410 (10Deskana) p:5Triage>3High
[22:23:41] <Deskana>	 mhurd: It's just nice to get these minor little that you can knock out and merge in 5 minutes done the second you see them, otherwise they have a tendency to just sit there.
[22:23:47] <Deskana>	 mhurd: So, thanks again. :-)
[22:45:00] <matanya>	 Deskana: a small feature request ?
[22:46:41] <matanya>	 on alpha add some sort of release notes, in the more menu or somewhere, it can even be a list of gerrit patches. doable ?
[22:48:55] <Deskana>	 matanya: Hmm, that would only really serve a very, very small portion of our user base.
[22:49:27] <Deskana>	 matanya: So if we expended effort on something like that, I'd rather do it a more generic version of it that's useful to everyone.
[22:50:05] <matanya>	 Deskana: i personally find it useful, but it might be only me
[22:50:38] <Deskana>	 matanya: I would too. But you and I are not the typical mobile app user. :-)
[22:51:10] <Deskana>	 I think the root of the request, namely "Let me see everything that's changed in this version of the app" is sound.
[22:51:23] <Deskana>	 But we'd have to think about how to serve it better than a big list of patches.
[22:52:02] <matanya>	 even a link to a gerrit tag/branch/sprint
[22:52:30] <Deskana>	 Even those are very technical things. Your average user doesn't know what a repository branch or sprint board are.
[22:53:01] <matanya>	 yeah, i fail to remember that from time to time :)
[22:53:25] <Deskana>	 It depends who the audience is.
[22:53:37] <matanya>	 ok, i requested, you will find the right way to make it happen, or not :)
[22:53:50] <Deskana>	 I think a page on mediawiki.org with a list of every commit new to a particular release would be good
[22:53:59] <Deskana>	 Note the difference there; on mediawiki.org. The audience is not the user. :-)
[22:54:26] <matanya>	 but it needs to be maintained in some way
[22:54:35] <Deskana>	 We could probably write a script to look for commits that are indicative of a release that then builds it automatically
[22:54:44] <Deskana>	 Indeed, yes
[22:54:48] <Deskana>	 That is the reason we've not done it yet
[22:54:51] <Deskana>	 Overhead!
[22:55:17] <matanya>	 would you be interested in help here, if i can ?
[22:55:26] <mhurd>	 isn’t that what the commit messages in git already do?
[22:55:37] <Deskana>	 Also, bear in mind that the app store the user got the app from displays a "recently changed" bit for each app version
[22:56:01] <Deskana>	 "What's New" on this, for example: https://play.google.com/store/apps/details?id=org.wikipedia
[22:56:04] <matanya>	 mhurd: how would you know what patch made it to what release?
[22:56:18] <matanya>	 i don't use play
[22:56:33] <mhurd>	 matanya: oh, from the release date of the last patch. just look at commits since then
[22:56:33] <Deskana>	 matanya: Right, there are people that get their apps from other sources on Android.
[22:57:03] <mhurd>	 ah hadn’t considered the “other sources” angle
[22:58:23] <matanya>	 + the alpha is not on play iirc. so that wouldn't help even if i used play
[23:00:26] <Deskana>	 Correct, it's not.
[23:00:35] <Deskana>	 So would you say this is more for people that are testing?
[23:00:54] <matanya>	 that is way i asked for the alpha in the first place
[23:01:00] <Deskana>	 "As a volunteer tester, I would like a list of changes that are present in the version of the app that I am using, so I can test them thoroughly"?
[23:01:09] <matanya>	 yes
[23:01:10] <mhurd>	 Deskana: matanya not ideal, but i suppose you could bundle a release notes file (linked to in the “about the wikipedia app” menu item) which would be appended with respective notes for each release
[23:02:11] <mhurd>	 Deskana: matanya like this one: https://www.dropbox.com/release_notes
[23:02:41] <Deskana>	 Right
[23:02:47] <matanya>	 that is nice.
[23:03:03] <Deskana>	 But of course there are complications
[23:03:22] <Deskana>	 Beta and production may overlap a lot or not at all
[23:03:27] <Deskana>	 In terms of patches, I mean
[23:03:37] <Deskana>	 That two patches were in the same beta doesn't mean they were in the same production release
[23:03:46] <Deskana>	 So provided you choose one version to do it for, it's simpler
[23:03:48] <Deskana>	 Like production
[23:03:56] <Deskana>	 We could host that on mediawiki.org easily enough
[23:04:00] <matanya>	 https://git.wikimedia.org/blob/mediawiki%2Fcore.git/REL1_24/RELEASE-NOTES-1.24
[23:04:28] <Deskana>	 I'd rather we put it on mediawiki.org personally :-)
[23:04:33] <matanya>	 https://www.mediawiki.org/wiki/MediaWiki_1.24
[23:06:05] <mhurd>	 Deskana: there could be 15 patches enabling a feature. this seems a better fit for higher level update descriptions. it seems like some git-fu would better suit this use-case. maybe post a couple git commands for seeing the patches that went into a given release?
[23:06:56] <Deskana>	 mhurd: One could massage that into a higher-level thing anyway
[23:07:12] <Deskana>	 I wouldn't mind taking the big list of commits and massaging that into high-level bullet points every release
[23:08:35] <matanya>	 Deskana: taking something like https://www.mediawiki.org/wiki/MediaWiki_1.25/wmf1 and converting to https://www.mediawiki.org/wiki/MediaWiki_1.24 
[23:17:11] <grrrit-wm>	 (03CR) 10Bmansurov: Change default watchlist from a-z to feed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190670 (https://phabricator.wikimedia.org/T88270) (owner: 10Florianschmidtwelzow)
[23:17:24] <Deskana>	 matanya: Yes, but I'd say one page for the *entire app*
[23:17:26] <Deskana>	 matanya: Not per release
[23:17:45] <Deskana>	 matanya: Like that Dropbox list.
[23:20:02] <matanya>	 that more than works for me
[23:21:44] <matanya>	 Deskana: need a ticket for this request, or it is on the task list already ?
[23:22:08] <Deskana>	 matanya: I'll make one then you can check it to make sure we're on the same page. :-)
[23:22:19] <matanya>	 thanks!
[23:25:49] <wikibugs>	 3Wikipedia-App-Android-App, Mobile-Apps, Wikipedia-App-iOS-App: Create a page on mediawiki.org listing all major changes to the app - https://phabricator.wikimedia.org/T89683#1042534 (10Deskana)
[23:25:52] <Deskana>	 matanya: ^
[23:28:49] <matanya>	 yes, that thanks a lot
[23:35:50] <Deskana>	 matanya: So is the intended audience meant to be an average app user or an engineer?
[23:36:02] <Deskana>	 matanya: I said it was an average app user, in which case I don't think we really need a script.
[23:36:16] <Deskana>	 matanya: We just need me (the product owner) to write a high level summary by looking at the commit logs in git
[23:37:13] <matanya>	 i see two use cases: 1. me looking at each commit and testing the feature. 2. me sending the app to friend and telling them "test item #4 on whats new"
[23:37:33] <Deskana>	 1) is already served by looking at gerrit :-)
[23:37:43] <Deskana>	 2) Could be served by a mediawiki.org page linked from the app, yeah
[23:38:08] <matanya>	 so yes, i do use case 1 by looking at gerrit
[23:38:50] <matanya>	 i do use case 2 by a how to test in my mails, that is not working very well
[23:39:04] <Deskana>	 Yeah, that's true
[23:39:31] <Deskana>	 matanya: We do have this: https://www.mediawiki.org/wiki/Mobile/Release_history#Android
[23:40:30] <matanya>	 i tried that once, the guy responded: "do you even know me?, I would never read such a page. what do you want me to test"
[23:40:31] <Deskana>	 If we exposed it to users we want it to look a lot nicer than that
[23:40:53] <Deskana>	 Well if you want to make a page that a guy who doesn't want to read pages will read, then that's pretty impossible :P
[23:41:52] <matanya>	 "we do the hard things right away, impossible takes us sme time"
[23:42:00] <matanya>	 *some time
[23:44:52] <matanya>	 The Difficult We Do Immediately. The Impossible Takes a Little Longer. <-- correct quote
[23:46:43] <Deskana>	 There's truth to that.
[23:47:13] <Deskana>	 But, this is a problem we don't have the time to devote that level of thinking too.
[23:47:16] <Deskana>	 *to
[23:47:18] <Deskana>	 We're still a small team
[23:47:22] <Deskana>	 That's why we're not actively tackling it
[23:51:45] <wikibugs>	 3Mobile-Web: Users who click on a link shared from Tweet a Fact in the app should see a banner telling them about it - https://phabricator.wikimedia.org/T89403#1042622 (10bmansurov) @KHammerstein @Msyed: can you guys upload a design? Thanks!
[23:52:39] <wikibugs>	 3Mobile-Web: Put link to desktop version in mobile front end at the top rather than at the bottom - https://phabricator.wikimedia.org/T89448#1042625 (10bmansurov) @KHammerstein @Msyed what do you guys think?