[00:05:38] (03PS1) 10Bmansurov: Add padding left to menu items in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190956 (https://phabricator.wikimedia.org/T89436) [00:05:52] 3Mobile-Web: Left navigation bar icons misaligned in stable - https://phabricator.wikimedia.org/T89436#1042650 (10bmansurov) a:3bmansurov [00:18:29] 3Mobile-Web: Put link to desktop version in mobile front end at the top rather than at the bottom - https://phabricator.wikimedia.org/T89448#1042672 (10Deskana) I really don't like this idea. The vast majority of the people that use Wikipedia on mobile phones are not well served by having the link to the deskto... [00:20:01] (03PS1) 10Bmansurov: Hygiene: Render the reference drawer only when needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190957 [00:27:44] (03PS1) 10Bmansurov: Don't warn about losing input after save [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190959 [00:34:56] (03PS1) 10Rahdev: Automatically dismiss keyboard on fast scroll when in edit mode. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190960 [00:38:43] (03PS2) 10Bmansurov: Hygiene: Render drawers only when needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190957 [00:39:51] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Render drawers only when needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190957 (owner: 10Bmansurov) [00:41:00] (03PS3) 10Bmansurov: Hygiene: Render drawers only when needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190957 [00:42:07] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Render drawers only when needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190957 (owner: 10Bmansurov) [00:42:31] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190957 (owner: 10Bmansurov) [05:14:49] (03CR) 10Deskana: [C: 04-1] "No flashing on my Nexus 5 running Lollipop. That said, the scrolling doesn't track with my finger in the same way as scrolling the web vie" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190820 (https://phabricator.wikimedia.org/T87128) (owner: 10Dbrant) [05:25:17] (03CR) 10Florianschmidtwelzow: [C: 032] Don't warn about losing input after save [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190959 (owner: 10Bmansurov) [05:26:35] (03Merged) 10jenkins-bot: Don't warn about losing input after save [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190959 (owner: 10Bmansurov) [05:28:01] (03PS1) 10BearND: ShareAFact refactoring [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190979 [05:28:03] (03PS1) 10BearND: Share first paragraph when no text is selected [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190980 [05:33:45] (03CR) 10Florianschmidtwelzow: [C: 031] "Looks goid, but needs testing first :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190956 (https://phabricator.wikimedia.org/T89436) (owner: 10Bmansurov) [05:40:35] 3Wikipedia-App-Android-App: Can't go back from anchors in Android Beta Wikipedia App - https://phabricator.wikimedia.org/T89693#1042883 (10Deskana) [05:40:37] 3Wikipedia-App-Android-App: Can't go back from anchors in Android Beta Wikipedia App - https://phabricator.wikimedia.org/T89693#1042885 (10Jidanni) The app! [05:42:11] 3Wikipedia-App-Android-App: Put current page name in box at top, instead of just "Search", on Android Beta Wikipedia App - https://phabricator.wikimedia.org/T89694#1042888 (10Jidanni) [06:06:22] 3Wikipedia-App-Android-App: The "other" edit summary text box should have standard dictionary suggestions as well as persisted edit summaries - https://phabricator.wikimedia.org/T89696#1042904 (10Deskana) 3NEW [06:10:23] (03PS1) 10Deskana: Force enable autocompletion in the edit summary AutoCompleteTextView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190981 (https://phabricator.wikimedia.org/T89696) [06:30:54] (03PS1) 10Deskana: Hygiene: Remove unused visitSettings method from EditSectionActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190982 [06:38:25] (03PS1) 10Deskana: Hygiene: Convert some fields to local variables [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190983 [06:39:08] 3Wikipedia-App-Android-App: The "other" edit summary text box should have standard dictionary suggestions as well as persisted edit summaries - https://phabricator.wikimedia.org/T89696#1042944 (10Deskana) p:5Triage>3Normal [06:45:51] 3MobileFrontend, Mobile-Web: Remove mobile editing "call to registration" CTA - https://phabricator.wikimedia.org/T87508#1042950 (10Florian) > the interstitial can be kept for the browsers we don't manage to support. No need, non JS browsers can't edit in mobile :) > Does jquery.tipsy work in mobile browsers w... [07:05:53] (03PS1) 10Florianschmidtwelzow: Don't show edit pencils on main page [extensions/MobileFrontend] (wmf/1.25wmf17) - 10https://gerrit.wikimedia.org/r/190984 (https://phabricator.wikimedia.org/T89559) [07:53:50] morning [08:13:51] joakino: morning! [08:14:01] hi :) [09:15:04] Yuvi|Vacation: hey, we've added a repo to grrrit, who can I ping to deploy+restart so that it picks the changes up? [09:15:19] i shouldn't even ask you since you are on vacation [09:32:11] joakino: haha. I dont think you need a restart. [09:32:27] Qchria or ^D are the gerrit people [09:32:51] joakino: oh grrrit [09:32:54] Not gerrit [09:33:01] joakino: valhallasw or legokt [09:33:44] Yuvi|Vacation: i've pinged valhallasw, do you know with tz they are in [09:34:33] * which timezone [09:48:05] (03PS1) 10Mhurd: W.I.P. Native component beneath webView. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 [09:48:43] (03PS2) 10Mhurd: WIP: Native component beneath webView. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 [09:51:16] (03PS3) 10Mhurd: WIP: Native component beneath webView. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 [10:00:38] yo [10:02:58] joakino: do you have a kindle? [10:03:12] hey phuedx, yes, the paperwhite [10:03:21] would you recommend it? [10:03:28] (i was going to ask if it was the paperwhite) [10:04:16] phuedx: yes, it is very good. but it is also my first and only ebook reader [10:04:23] ah [10:04:25] noted [10:05:34] so idk if there are better options, IMO it is light, works well, i can put my own books there via usb or kindle email, the battery lasts a lot, touch screen, and backlight for no-light or too much light situations [10:05:42] phuedx: it's worked very well for me ^ [10:06:07] yeah, the backlight is what's tempting me over the normal kindle [10:06:22] i couldn't read in the car yesterday, for example [10:06:44] phuedx: we recently bought the normal kindle for my cousin, and it is a bit bigger than ours [10:06:54] it is also cheaper [10:07:26] ^ that [10:07:38] like £49 here [10:08:56] yep [10:09:32] phuedx: it may be a good buy for a SF trip, since they have the ads supported version which is even cheaper and you don't get ads if you don't connect it to the internet (which i do xD) [10:09:47] lol [10:10:14] anyways, it is a good buy, genuinely a great type of electronic device [10:10:35] great purpose, and works very well [10:14:22] saves us the trouble of buying books and brings every literary work within our reach :) [10:24:23] +10 [10:29:07] ads supported hardware… [10:48:32] haha [10:49:00] hey phuedx do you know where hashar hangs out? [10:49:22] joakino: #wikimedia-qa [10:49:31] he's usually in here too… [10:50:28] phuedx: that channel doesn't exist? [10:50:52] wtf [10:51:02] joakino: wikimedia-releng [10:51:05] sorry, they moved [10:51:33] oh yea haha [10:51:39] thanks phuedx [10:51:53] not online [10:53:39] lol tools.lolr [10:53:49] cmon grrrit bottt [10:54:19] (03PS2) 10Jhernandez: Add unit tests support [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191005 [10:54:21] (03PS9) 10Phuedx: Promote the BannerImage module to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189000 [10:54:28] hell yeah [10:55:34] phuedx: ^ grrrit posts gather crap now! :D [10:55:43] \o/ [10:55:56] haha [11:13:34] (03CR) 10Phuedx: [C: 04-1] Test invalid request parameters (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/190490 (owner: 10MaxSem) [11:39:00] (03CR) 10Phuedx: [C: 04-1] "This bug is Firefox-only because Firefox (yet) doesn't support background-position-x/-y. Change:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190956 (https://phabricator.wikimedia.org/T89436) (owner: 10Bmansurov) [11:45:28] 3Wikidata, Mobile-Web: Mobile version of Dutch Wikisource doesn't list other language version. - https://phabricator.wikimedia.org/T89566#1043326 (10Florian) Hmm, the api request [1] doesn't return the en version, so we can't show it :( [1] https://nl.m.wikisource.org/w/api.php?action=query&format=json&meta=sit... [11:45:37] 3MediaWiki-API, Wikidata, Mobile-Web: Mobile version of Dutch Wikisource doesn't list other language version. - https://phabricator.wikimedia.org/T89566#1043327 (10Florian) [12:16:05] out to the gym and lunch [12:22:58] (03CR) 10Phuedx: [C: 032] Hygiene: Render drawers only when needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190957 (owner: 10Bmansurov) [12:24:08] (03Merged) 10jenkins-bot: Hygiene: Render drawers only when needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190957 (owner: 10Bmansurov) [12:24:16] (03CR) 10Phuedx: "Tested the edit and watchstar button behaviour while logged out as well as testing the reference drawer behaviour. They all work as before" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190957 (owner: 10Bmansurov) [12:28:30] 3Mobile-Web: Recruit volunteers via the JavaScript console - https://phabricator.wikimedia.org/T85815#1043380 (10phuedx) Perhaps [187823](https://gerrit.wikimedia.org/r/187823) could be my first confploy (!) [12:29:26] 3Continuous-Integration, Mobile-Web: Publish MobileFrontend JS Documentation - https://phabricator.wikimedia.org/T74794#1043382 (10phuedx) @hashar Did you settle on `make docs`? [12:30:45] 3Mobile-Web: Left navigation bar icons misaligned in stable in Firefox - https://phabricator.wikimedia.org/T89436#1043383 (10phuedx) [12:36:06] (03CR) 10Phuedx: [C: 04-1] Hygiene: Use Config object in SpecialPages (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190841 (https://phabricator.wikimedia.org/T87614) (owner: 10Florianschmidtwelzow) [13:52:03] Hello,I often use the wikipedia app,Am intending to participate in GSOC 2015, can you point me to bugs I can fix? [13:59:22] 3Continuous-Integration, Mobile-Web: Publish MobileFrontend JS Documentation - https://phabricator.wikimedia.org/T74794#1043483 (10hashar) [14:00:02] phuedx: hola! [14:00:20] phuedx: I have been relocating for the last few days so the 'make docs' idea/project is a bit lagged out [14:00:23] hola hashar! [14:00:27] no worries [14:01:30] currently laughing at my wife attempting to mount some Ikea furnitures [14:02:43] hashar: is that in the instructions" [14:02:45] *? [14:02:48] 3Continuous-Integration, Mobile-Web: Publish MobileFrontend JS Documentation - https://phabricator.wikimedia.org/T74794#1043490 (10hashar) After a week on wikitech-l and barely any comment, `make docs` is adopted as an entry point to generate documentation. Could you provide a `/makefile` with a `docs` target p... [14:03:06] she loose patience quite fast :D [14:03:15] but learns from her mistakes eventually [14:03:42] anyway [14:03:48] make docs is approved :D [14:03:58] so /makefile with a docs (plural) target and we are all set [14:05:03] hashar: and this happens automatically, or is there config we have to write? [14:05:07] (also, awesome!) [14:05:16] still have to do some config [14:05:33] 1) to create the jenkins job 2) to get Zuul to trigger such jobs [14:05:37] I am working on a job template that will make it trivial [14:06:23] hashar: awesome [14:06:24] one sec [14:07:27] (03CR) 10Phuedx: [C: 032] Revert some style changes from I7cad9546ca9c932b071b920ba85e0f560f5d7eb2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190494 (owner: 10Bmansurov) [14:08:03] hashar: mobilefrontend has a makefile with a docs target [14:08:09] docs will be built in docs/ [14:08:26] great [14:08:38] (03Merged) 10jenkins-bot: Revert some style changes from I7cad9546ca9c932b071b920ba85e0f560f5d7eb2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190494 (owner: 10Bmansurov) [14:20:53] Hello, Am a frequent user of the Wikipedia android app and I would love to contribute to it for gsoc 2015. Can someone point me to bugs I can start on. [14:29:47] culey_: you probably want to subscribe to the mobile mailing list [14:29:59] culey_: https://lists.wikimedia.org/mailman/listinfo/mobile-l [14:30:17] phuedx: I have created some jobs. trying them :] [14:30:40] culey_: hey, you left before, welcome back :) [14:30:42] though I have an "unbreak now!" Ikea priority [14:31:08] culey_: there's also the mobile apps phabricator project which you'll want to subscribe to: https://phabricator.wikimedia.org/tag/mobile-apps/ [14:31:13] and its workboard [14:31:47] Thank you! hashar and phuedx [14:35:29] 3Continuous-Integration, Mobile-Web: Publish MobileFrontend JS Documentation - https://phabricator.wikimedia.org/T74794#1043550 (10Florian) @hashar: We already have a Makefile with a "docs" target :) https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/Makefile#L44 [14:35:44] pffffff [14:36:01] phuedx: the poor Makefile needs a working MediaWiki install :( https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-docs/1/console [14:36:40] hashar: *sigh* i was just looking at that [14:38:47] pfff [14:40:08] hashar: well, actually, it kinda makes sense [14:40:25] because a lot of our js code (for example) references types defined/documented in core [14:41:48] * hashar shoots self [14:41:57] I should apply to Ikea [14:42:00] (03Draft9) 10Bgerstle: image gallery [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188583 [14:43:15] phuedx: apparently I "just" have to clone mediawiki/core as well [14:43:22] gotta rework the job template a bit [14:51:35] hashar: it's annoying i know, but i think most extensions will need core present [14:52:18] phuedx: I guess [14:52:27] ideally we will have a single job generating doc for core + extensions [14:52:35] the unicorn of unified documentation [14:52:42] * hashar hires a team [14:52:44] i was about to say… ;) [15:01:30] (03PS10) 10Bgerstle: image gallery [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188583 [15:07:39] 3Wikidata, MediaWiki-API, Mobile-Web: Mobile version of Dutch Wikisource doesn't list other language version. - https://phabricator.wikimedia.org/T89566#1043611 (10Anomie) The API is working fine, in that it's returning all the entries from the langlinks table for that title. The question becomes why the langlin... [15:07:51] 3Wikidata, Mobile-Web: Mobile version of Dutch Wikisource doesn't list other language version. - https://phabricator.wikimedia.org/T89566#1043612 (10Anomie) [15:08:24] phuedx: so I will get core cloned under /src/ [15:08:43] and MobileFrontend under /src/extensions/MobileFrontend [15:08:56] then the job will cd src/ && make docs [15:09:06] so we could have MW_INSTALL_PATH to /src/ [15:09:15] sorry merely speaking to myself hehe [15:13:53] hashar: i'll let you hashar out the details ;) [15:14:12] refactored my draft to add mw/core [15:14:20] and export MW_INSTALL_PATH before invoking make docs [15:14:24] seems it will be useful for others [15:14:37] mw_install_path is the most flexible solution for this [15:14:54] i'd be interested to see other people's doc setups [15:15:03] if it ain't necessary, kill it! [15:15:08] hehe [15:16:15] 3Wikidata, Mobile-Web: Mobile version of Dutch Wikisource doesn't list other language version. - https://phabricator.wikimedia.org/T89566#1043619 (10Anomie) A purge with forcelinkupdate fixed it, FYI. A null edit would have too, most likely. [15:22:54] 3Continuous-Integration, Mobile-Web: Publish MobileFrontend JS Documentation - https://phabricator.wikimedia.org/T74794#1043629 (10hashar) I made a first pass job that clones mediawiki/core and MobileFrontend under /src/ then do: ``` export MW_INSTALL_PATH=/src cd /src/extensions/MobileFrontend make docs ```... [15:26:32] off again :( [16:02:35] time to make a cup of coffee [16:19:12] bgerstle - saw your message - let me know what you need me to do [16:19:35] coreyfloyd i posted a bunch of comments in response to yours. i recommend looking at the patch in the "new" gerrit UI [16:19:41] it's slightly better for following comment threads [16:19:50] new? [16:19:51] but, i can also get on a hang out and talk about the patch [16:20:05] coreyfloyd if you go to your gerrit setting (top right) and click "preferences" there's a UI option [16:20:16] ahh cool - will take a look [16:20:28] coreyfloyd i've actually got a cleaner coming today, supposed to be at 11:30, so would probably be better for me to just get on a call now and chat about it real quick [16:20:34] if you've got a moment. up to you [16:20:48] 3Wikidata, Mobile-Web: Mobile version of Dutch Wikisource doesn't list other language version. - https://phabricator.wikimedia.org/T89566#1043711 (10Florian) 5Open>3Invalid a:3Florian Ok, i only tried the purge action, haven't thought about a null edit, thanks @Anomie, i'll close this task, because there i... [16:21:09] (03PS11) 10Bgerstle: image gallery [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188583 [16:22:57] 3Wikidata, Mobile-Web: Mobile version of Dutch Wikisource doesn't list other language version. - https://phabricator.wikimedia.org/T89566#1043721 (10Anomie) >>! In T89566#1043711, @Florian wrote: > @Lydia_Pintscher: Wasn't there an announcement of wikidata to not rely on the parserOutput for language links anymo... [16:24:03] 3Wikidata, Mobile-Web: Mobile version of Dutch Wikisource doesn't list other language version. - https://phabricator.wikimedia.org/T89566#1043724 (10Lydia_Pintscher) Adding @hoo and @daniel for clarification. [16:34:59] (03CR) 10Fjalapeno: "Left some quick initial comments" (038 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 (owner: 10Mhurd) [16:36:02] bgerstle - sorry missed your last - will just look through while you are indisposed… [16:37:18] coreyfloyd nah i'm all setup now [16:37:29] gave the dogs some fresh bones so they're nice and distracted [16:39:39] (03CR) 10Dbrant: [C: 032] Force enable autocompletion in the edit summary AutoCompleteTextView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190981 (https://phabricator.wikimedia.org/T89696) (owner: 10Deskana) [16:40:03] bgerstle - you saying you want to hangout? [16:40:26] (03CR) 10Dbrant: [C: 032] Hygiene: Remove unused visitSettings method from EditSectionActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190982 (owner: 10Deskana) [16:41:02] 3Wikipedia-App-Android-App: The "other" edit summary text box should have standard dictionary suggestions as well as persisted edit summaries - https://phabricator.wikimedia.org/T89696#1043784 (10Dbrant) 5Open>3Resolved a:3Dbrant [16:41:16] coreyfloyd if you want to do some code review now (i.e. aren't working on anything else) [16:42:34] Ok cool - I'm already walking through the code - I'll hit you up if I have any questions… [16:42:50] ok [16:43:20] coreyfloyd there were only a couple things that i disagreed with you on [16:46:05] (03CR) 10Dbrant: [C: 032] Hygiene: Convert some fields to local variables [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190983 (owner: 10Deskana) [16:51:57] so...much...snow... [16:54:26] kristenlans: where? oO [16:54:29] Mhoar! [16:54:52] FlorianSW: about any where in the US except Florida [16:55:16] T13|mobile: wow, ok :D [16:55:31] It's all relative per location of course. [16:56:28] Like Texas for example gets snow once every few years, a couple inches is a lot. [16:56:48] FlorianSW: Massachusetts. [16:57:19] FlorianSW: specifically, here: https://en.wikipedia.org/wiki/Cape_Cod [16:58:13] and i thought, italia looks like a shoe :D [16:58:33] FlorianSW: :P [16:58:45] lol [17:06:55] (03PS1) 10Dbrant: Fix "other" edit summary in 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191073 [17:08:49] (03PS1) 10Dr0ptp4kt: Make popover arrow point at share button [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191074 [17:13:22] (03PS1) 10Dbrant: Once and for all, spell "persistence" correctly. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191075 [17:13:30] 3Wikipedia-App-iOS-App: Tweet a fact UI pop over post share selection is misaligned above save - https://phabricator.wikimedia.org/T89524#1043920 (10dr0ptp4kt) https://gerrit.wikimedia.org/r/#/c/191074/ submitted for review. [17:18:05] morning bgerstle and coreyfloyd. FYI today is the "sprint changeover" where we move from sprint 50->51. [17:18:33] kristenlans yeah, sproke briefly w/ deskana yesterday. hoping to merge image gallery stuff (from sprint 50) today [17:18:46] will need to do review w/ deskana and vibha after that, so will probably be working on it a bit more [17:19:59] bearND: is your share-a-fact refactor ready for merge? [17:20:23] dbrant: yes, it is [17:20:52] bgerstle: Cool. Yeah, as you've noticed, there's a little wiggle room on the morning of the sprint start day around getting stuff wrapped up and calling it "done", since we don't have a formal "kickoff" to draw a hard stop/start line. [17:21:08] right [17:21:31] bgerstle: though it might be time to get a little less formal about that :-) [17:21:39] I mean more formal! [17:21:49] Monday brain [17:22:12] joakino: hi, do you still need help with something gerrit related? [17:22:16] kristenlans but.. it's tuesday.. [17:22:33] bgerstle lol, true [17:22:56] kristenlans unless it IS monday and i've come back from the future [17:26:09] coreyfloyd i'm about to push some refinements to the collection view controller. i've done some tweaks to vastly improve scroll performance [17:26:56] (03CR) 10Dbrant: [C: 032] Share first paragraph when no text is selected [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190980 (owner: 10BearND) [17:27:27] bgerstle, kristenlans: Well, ordinarily this would be done on Monday, but Monday was a quasi-holiday. :) [17:27:43] bgerstle coreyfloyd anyhoo, anything that's not done in the next few hours or so in sprint 50 we'll want to bump in to the next sprint or backlog, dependign on priority. I am hoping to sync up with Deskana in a bit to jiggulate all of that. I don't anticipate anything to change radically from what we discussed at the iteration review on Friday. [17:27:59] also what deskana said :-) [17:28:18] TIL: jiggulate [17:28:25] (03CR) 10Dbrant: [C: 032] ShareAFact refactoring [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190979 (owner: 10BearND) [17:28:46] Let's flop on over to the jiggulation [17:29:51] "Baggy" is another one I'm trying to get in to rotation, as in "This is kind of a baggy sprint." [17:30:00] (03PS3) 10Dbrant: Fix scrolling when tapping and dragging over lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190820 (https://phabricator.wikimedia.org/T87128) [17:35:09] kristenlans: I've put a meeting together for us to unblock all the things. [17:35:18] (03PS3) 10Robmoen: Hygiene: Fix phpdoc on models\Collection constructor [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190800 (owner: 10Jhernandez) [17:35:26] Deskana hooray! [17:35:29] kristenlans: It seems Vibha is unavailable until Friday which is unfortunate, but this can't wait until Friday. [17:35:54] (03CR) 10Robmoen: [C: 032 V: 032] Hygiene: Fix phpdoc on models\Collection constructor [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190800 (owner: 10Jhernandez) [17:36:34] The Unblockening [17:37:23] Unblockageddon [17:38:24] The Unblockularity [17:40:54] dbrant: I don't see the issues that https://gerrit.wikimedia.org/r/#/c/191073 was to solve on my 5.0 device [17:41:34] bearND: it's only for 2.3 [17:41:42] dbrant: ah [17:41:58] hi rmoen [17:41:58] I can test on 2.3 once I get into the office [17:41:59] dbrant: missed the headline, duh [17:42:04] (03CR) 10Robmoen: "Haven't tested fully yet. Looks good so far but needs rebase and small 1 area where whitespace is present." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190801 (owner: 10Jhernandez) [17:42:11] joakino!!! [17:42:49] Good evening [17:43:04] two person team killing it [17:43:09] legoktm: thanks! it was about the grrrit bot, but valla helped me from ops [17:43:19] dbrant: Deskana: charging my 2.3 device [17:43:25] rmoen: doing pretty good for the moment :D [17:43:41] phuedx, can you take a look t https://gerrit.wikimedia.org/r/#/c/190562/ please? [17:44:10] MaxSem: suresies [17:44:56] To the office! [17:45:07] ok :) [17:56:10] 3Wikipedia-App-Android-App: "This page does not exist" on clickthrough from Google search results. - https://phabricator.wikimedia.org/T89734#1044055 (10dahamsta) 3NEW [17:56:57] (03PS12) 10Bgerstle: image gallery [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188583 [17:57:33] (03PS2) 10Bmansurov: Fix padding left of the menu items in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190956 (https://phabricator.wikimedia.org/T89436) [17:58:14] (03PS3) 10Anomie: Update ApiResult handling for mediawiki/core change I7b37295e [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 [17:58:20] (03CR) 10jenkins-bot: [V: 04-1] Update ApiResult handling for mediawiki/core change I7b37295e [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie) [17:59:19] (03PS1) 10Jhernandez: WIP: Setup browser tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191083 [17:59:51] (03CR) 10Jhernandez: [C: 04-2] "I don't know what i'm doing" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191083 (owner: 10Jhernandez) [18:00:35] coreyfloyd dr0ptp4kt there are some more refactors & refinements i'd like to do, but i think at this point it's good enough to merge [18:00:38] scrolling seems to work pretty well [18:01:11] you can spam flick through all the images as fast as you want, then scroll back and see the high-res bitmaps as they're loaded from the cache [18:03:06] JonKatz: are you guys firing up the SF room? [18:03:17] dbrant: now i tried it on the Droidx, and still see no difference in before and after. In light mode it's all fine, and in dark mode it doesn't show the edit hint. [18:03:42] dr0ptp4kt also, i tried testing the app w/ the language set to Hebrew, but the labels didn't switch to RTL mode [18:04:39] bearND: on my 2.3 device (in light mode) the edittext and the persisted suggestions are both white on white :( [18:05:34] dbrant: I'd be fine with that but I think I would also like to see some improvement for dark mode [18:06:04] bearND: can you send a screenshot of how it looks for you in dark mode? [18:06:15] dbrant: sure [18:06:26] MaxSem: you coming to the spretro? [18:07:54] bgerstle: if that sort of alignement is a requirement, i think autolayout in ib or programmatically, for the leading and trailing properties between the subview labels and the container view would do it. there's a rtlSafeAlignment method in the project in case you need to determine this programmatically [18:08:15] dr0ptp4kt i thought it was a standard thing, you guys asked me to test it [18:08:32] they're all aligned via auto layout [18:08:38] i didn't see the article title flip either [18:08:43] so i figured i wasn't doing something correctly [18:09:01] dbrant: http://imgur.com/hZlzZtf [18:09:15] bearND: thx [18:09:17] bgerstle: yeah, it's a standard practice. when i do the code review i'll see if i can figure it out [18:09:20] (will fix) [18:09:31] dr0ptp4kt: ok [18:10:54] 3Wikipedia-App-Android-App: "This page does not exist" on clickthrough from Google search results. - https://phabricator.wikimedia.org/T89734#1044076 (10Deskana) Thanks for the report! Can you share both the search query you typed into Google and the title of the page that you clicked on, so we can attempt to r... [18:11:45] (03PS2) 10BearND: Once and for all, spell "persistence" correctly. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191075 (owner: 10Dbrant) [18:13:20] 3Wikipedia-App-Android-App, Multimedia, MediaWiki-extensions-CommonsMetadata: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#1044078 (10Deskana) Thanks for the fix! How can this be tested? [18:14:12] (03CR) 10Fjalapeno: "Responded to a few comments" (035 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188583 (owner: 10Bgerstle) [18:14:29] bgerstle ^ [18:14:34] thanks [18:14:37] moizsyed: kaity|away Max is in R36 for retrospective whenever you guys are done withyour other mtg :-) [18:14:41] bgerstle sorry was caught up on something else… [18:15:25] np [18:15:27] kristenlans are we standing up today? [18:16:08] mhurd left an email for you - need a glyph to finish up last weeks work if you can help me out [18:16:32] coreyfloyd: awesome! on hangout w adam atm - quick hangout w you after? [18:16:46] mhurd sure - just hit me up [18:16:59] coreyfloyd: adam’s gonna invite you guys [18:17:02] bgerstle: ^ [18:17:17] k [18:17:18] ok [18:17:43] coreyfloyd: not today [18:17:56] (03CR) 10jenkins-bot: [V: 04-1] Once and for all, spell "persistence" correctly. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191075 (owner: 10Dbrant) [18:18:08] coreyfloyd: are you in the hangout alone ;-( [18:19:02] kristenlans no - I have an imaginry friend [18:19:53] (03CR) 10BearND: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191075 (owner: 10Dbrant) [18:28:56] (03PS1) 10Yurik: Backported i18n messages from master [extensions/ZeroBanner] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/191092 [18:29:14] (03CR) 10Yurik: [C: 032 V: 032] Backported i18n messages from master [extensions/ZeroBanner] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/191092 (owner: 10Yurik) [18:31:53] dr0ptp4kt: scroll-speed-dismiss-keyboard https://gerrit.wikimedia.org/r/#/c/190960/ submitted for review. Let me know if you would like me to make any changes. [18:32:13] 3Wikipedia-App-Android-App, Multimedia, MediaWiki-extensions-CommonsMetadata: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#1044129 (10Tgr) Upload a file on beta commons with `License: (03CR) 10jenkins-bot: [V: 04-1] Fix scrolling when tapping and dragging over lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190820 (https://phabricator.wikimedia.org/T87128) (owner: 10Dbrant) [18:45:40] (03Merged) 10jenkins-bot: Once and for all, spell "persistence" correctly. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191075 (owner: 10Dbrant) [18:45:59] (03PS5) 10Dbrant: Fix scrolling when tapping and dragging over lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190820 (https://phabricator.wikimedia.org/T87128) [18:49:30] MaxSem: totally forgot that {page, version, campaign} form the primary key in wikigrok_questions [18:49:39] just testing the locking patch now [18:52:06] (03CR) 10Bmansurov: [C: 032] Promote the BannerImage module to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189000 (owner: 10Phuedx) [18:52:16] dbrant: Huh. I'm testing your patch to fix the issue with the "Other" box in the edit summary fragment but I can't reproduce the problem on my 2.3 device. [18:53:11] (03Merged) 10jenkins-bot: Promote the BannerImage module to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189000 (owner: 10Phuedx) [18:53:46] dbrant: It's an HTC Wildfire S running 2.3.3. [18:54:02] Deskana: yeah, there seem to be some vendor-specific inconsistencies... but regardless, this patch should also enable persisted suggestions in 2.3, which were disabled previously. [18:54:15] * Deskana tests that [18:55:25] (03CR) 10Bgerstle: "responded to comments" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188583 (owner: 10Bgerstle) [18:55:38] hmm where are my comments [18:55:45] dbrant: Whoa. This edit summary box is totally broken though. [18:55:52] dbrant: My text is flickering in and out of existence. [18:56:25] mhurd: about to merge https://gerrit.wikimedia.org/r/#/c/190647 [18:56:50] Deskana: lol that's not something I've seen [18:56:51] dr0ptp4kt: cool! [18:56:56] dbrant: Broken on master, that is. I'm testing your patch. [18:57:33] * bgerstle sigh [18:57:34] Deskana: what exactly is broken? [18:57:34] oh gerrit [18:58:41] dbrant, bearND: On this 2.3 device (HTC Wildfire S, 2.3.3) the AutoCompleteTextView that's used when you tap "Other" in the editing workflow has text flickering in and out as you type [18:58:52] coreyfloyd responded to your comments in PS 6 [18:58:54] dbrant, bearND: It flickers on when you type a character, then all disappears afterwards [18:59:04] dbrant, bearND: Dmitry's patch actually fixes that problem. [18:59:39] I'll take what I can get. [19:00:12] (03CR) 10Phuedx: [C: 032] Fix padding left of the menu items in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190956 (https://phabricator.wikimedia.org/T89436) (owner: 10Bmansurov) [19:00:16] Deskana: interesting. On my DroidX I did not experience that issue. But yeah, 2.3 is like the wild west of devices, anything goes. Glad it's fixed. [19:00:39] JonKatz, joakino: Splanning [19:01:00] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] "Looks okay on" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190647 (owner: 10Mhurd) [19:01:09] (03CR) 10Deskana: [C: 031] "Test device: HTC Wildfire S, Android 2.3.3" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191073 (owner: 10Dbrant) [19:01:19] (03Merged) 10jenkins-bot: Fix padding left of the menu items in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190956 (https://phabricator.wikimedia.org/T89436) (owner: 10Bmansurov) [19:01:46] There's an issue in that the dropdown for the persisted edit summaries overlaps the autocompletion that I enabled in my patch [19:02:02] I guess this is why AutoCompleteTextViews are hardcoded to disable suggestions... [19:02:16] ^^^ mhurd (indeterminate number of carets, as i lost connection), merged [19:02:32] That said, I don't think it's a big issue. Although they overlap, you can actually use both. [19:02:56] 3Mobile-Web: Left navigation bar icons misaligned in stable in Firefox - https://phabricator.wikimedia.org/T89436#1044301 (10phuedx) 5Open>3Resolved [19:03:27] ^^^ bgerstle, https://gerrit.wikimedia.org/r/#/c/190647 now needs rebase (if it didn't already) [19:03:37] bgerstle: i mean https://gerrit.wikimedia.org/r/#/c/188583/ [19:04:07] dr0ptp4kt_ k, on it [19:04:40] dr0ptp4kt_: yay! [19:05:16] brion: of course that gigantour monitor went on sale just after i bought it [19:05:26] 3Wikipedia-App-Android-App: Voice search? - https://phabricator.wikimedia.org/T89609#1044305 (10brion) >>! In T89609#1040380, @Deskana wrote: > On a lot of Google apps nowadays, the voice input is a button in the field itself rather than on the keyboard. I guess this is why people are requesting this in spite of... [19:05:30] heh [19:06:57] (03PS2) 10Dbrant: Fix "other" edit summary in 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191073 [19:09:11] (03PS6) 10BearND: Fix scrolling when tapping and dragging over lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190820 (https://phabricator.wikimedia.org/T87128) (owner: 10Dbrant) [19:09:24] (03CR) 10BearND: [C: 032] Fix scrolling when tapping and dragging over lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190820 (https://phabricator.wikimedia.org/T87128) (owner: 10Dbrant) [19:09:44] (03Merged) 10jenkins-bot: Fix scrolling when tapping and dragging over lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/190820 (https://phabricator.wikimedia.org/T87128) (owner: 10Dbrant) [19:11:51] 3Wikipedia-App-Android-App: Dragging (rather than just tapping) lead image up should scroll down - https://phabricator.wikimedia.org/T87128#1044341 (10Dbrant) 5Open>3Resolved a:3Dbrant [19:13:59] (03PS3) 10BearND: Fix "other" edit summary in 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191073 (owner: 10Dbrant) [19:14:09] (03CR) 10BearND: [C: 032] Fix "other" edit summary in 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191073 (owner: 10Dbrant) [19:14:27] (03Merged) 10jenkins-bot: Fix "other" edit summary in 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191073 (owner: 10Dbrant) [19:33:22] (03PS13) 10Bgerstle: image gallery [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188583 [19:33:44] mhurd coreyfloyd rebased and addressed review comments [19:34:06] bgerstle: checking... [19:34:24] mhurd it should be using master's font file [19:34:55] bgerstle: cool! [19:35:35] hm.. project seems to be broken though :-( [19:35:41] (03CR) 10Fjalapeno: "Last 2 comments… :)" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188583 (owner: 10Bgerstle) [19:35:47] (03PS2) 10Mhurd: Make popover arrow point at share button [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191074 (owner: 10Dr0ptp4kt) [19:35:59] mhurd coreyfloyd i somehow broke the xcodeproj, stand by [19:36:12] lol -ok [19:36:32] taking a brunch break [19:36:50] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191074 (owner: 10Dr0ptp4kt) [19:36:57] https://etherpad.wikimedia.org/p/o [19:37:09] 3Wikipedia-App-iOS-App: Tweet a fact UI pop over post share selection is misaligned above save - https://phabricator.wikimedia.org/T89524#1044474 (10Mhurd) 5Open>3Resolved [19:37:19] (03PS14) 10Mhurd: image gallery [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188583 (owner: 10Bgerstle) [19:37:37] damit this is why i hate squashing/amending [19:38:11] bgerstle: i merged a tiny patch adam submitted, then i tapped rebase on your change and it did so cleanly. issue? [19:38:27] mhurd please let me rebase it next time.. i don't trust gerrit [19:38:47] (03PS4) 10Anomie: Update ApiResult handling for mediawiki/core change I7b37295e [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 [19:38:52] bgerstle: k sorry1 [19:38:55] unless gerrit will only go through w/ it when there are 0 conflicts [19:39:14] bgerstle: yes it only works if 0 conflicts [19:39:42] bgerstle: my bad i should have given you a heads up [19:41:02] it's ok, i probably broke it [19:41:22] bgerstle: how so? [19:42:10] missed the project when rebasing [19:42:26] ok seems back now [19:42:47] hm.. [19:42:50] it's missing some changes [19:43:01] or not [19:43:03] anyone want to break our spritn namign tie? [19:43:22] Oldboy vs O Brother Where Art Though [19:43:42] (03PS15) 10Bgerstle: image gallery [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/188583 [19:43:45] coreyfloyd mhurd branch is fixed [19:43:51]