[00:24:22] (03PS1) 10Bmansurov: Allow other extensions to add or override discovery tools [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191219 [00:28:37] (03CR) 10MaxSem: [C: 032] Don't show edit pencils on main page [extensions/MobileFrontend] (wmf/1.25wmf17) - 10https://gerrit.wikimedia.org/r/190984 (https://phabricator.wikimedia.org/T89559) (owner: 10Florianschmidtwelzow) [00:40:51] (03PS1) 10Bmansurov: Remove WikiGrok related stuff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191224 [00:41:43] (03PS1) 10Bmansurov: WIP: Move over WikiGrok front end code from Mobile Frontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 [00:42:57] (03Merged) 10jenkins-bot: Don't show edit pencils on main page [extensions/MobileFrontend] (wmf/1.25wmf17) - 10https://gerrit.wikimedia.org/r/190984 (https://phabricator.wikimedia.org/T89559) (owner: 10Florianschmidtwelzow) [00:45:41] rmoen, JonKatz: Gather should be live, please test [00:45:55] MaxSem: Thanks [00:50:12] rmoen are you able to see any gather features? [00:50:17] MaxSem: Not seeing it. http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather Is the extension on the cluster ? [00:50:21] i can't but maybe not going to correct place [00:50:24] JonKatz: ^ [00:50:35] got it [00:51:34] eh it's not at http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Version [00:52:04] or maybe new extensions get pulled by a cronjob [00:52:18] don't remeber for sure what was said about it [00:52:23] MaxSem: Which is why i think it needs to be mediawiki/extensions.git [00:52:38] oh you merged it :) [00:52:53] Yeah i bet the 10 min sync needs to happen [00:53:02] JonKatz, MaxSem ^ [00:57:42] 3Mobile-Web, WikiGrok: DBQueryError: "Deadlock found when trying to get lock; try restarting transaction" - https://phabricator.wikimedia.org/T89359#1045361 (10MaxSem) 5Open>3Resolved *poof* [01:03:17] "Nothing in this collection yet... I don't know how you got here but this is a sad place." :) [01:08:38] MaxSem: everything is there. Thanks [01:10:21] MaxSem Thanks!!! [01:13:55] (03PS1) 10Bmansurov: Add javascript dev and test tools [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191232 [01:15:18] (03PS2) 10Bmansurov: Move over WikiGrok front end code from Mobile Frontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 [01:16:28] I see my watchlist. [01:16:29] (03CR) 10Bmansurov: "In the WikiGrok extension: https://gerrit.wikimedia.org/r/#/c/191225/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191224 (owner: 10Bmansurov) [01:16:54] (which has nothing in it) [01:24:27] (03PS3) 10Bmansurov: Move over WikiGrok front end code from Mobile Frontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 [01:32:40] Deskana: is it "a sad place"? [01:32:50] No, it's "private" [01:32:56] Which one could argue is also sad [01:48:09] hey mhurd still there? [01:48:58] bgerstle: ya! [01:49:09] i guess my patch was merged? [01:49:15] bgerstle: ya! [01:49:19] woohoo [01:49:28] yay! [01:49:40] so, i can't repro the rotation issue on iPhone 6 / iOS 8 [01:49:56] bgerstle: only seeing it on ios 6 now [01:50:08] ok.. [01:50:47] bgerstle: lemme know if you want me to test anything on my device. adam said he’s sending you a ios 6 ipod iirc [01:51:09] would you mind taking at look at some point? dr0ptp4kt ordered me an iPod touch 4 [01:51:09] but might not be here for a bit [01:51:26] ya any time [01:52:34] bgerstle: what i see now on 6 is the image, but if i rorate the screen goes black and that warning is back: “the behavior of the UICollectionViewFlowLayout is not defined because: the item height must be less that the height of the UICollectionView minus the section insets top and bottom values.” [01:52:49] hm. . . [01:53:38] bgerstle: when you took out the rotate stuff that went away iirc and the only issue, on 6,7&8 was after rotate part of 2 images were visible [01:53:52] *that went away* = the black screen issue [01:54:35] sorry, so the issue now is that on iOS 6 (only), rotating will show two images AND the collection view will log that error? [01:55:10] bgerstle: quick hangout? [01:56:28] as of last patch, on ios 6 only, rotate caues black screen with log error from above [01:56:41] ok [01:57:07] previous patch (where you did something rotate code) worked on 6,7, and 8, but had the 2 images onscreen issue after rotate [01:57:19] hm. . . [01:57:26] and now only 6 is broken [01:57:31] bgerstle: ya [01:57:35] so, drop 6! problem solved ;-) [01:57:42] bgerstle: done! ;) [02:03:48] Deskana: getting ready to wrap up. i was thinking tomorrow morning i will finish the event logging subclassing for the article suggestions / read more thing on iOS, and then after that i could update https://gerrit.wikimedia.org/r/#/c/190637/ if you like [02:03:53] Deskana: make sense? [02:04:12] dr0ptp4kt: Please do! I bit off more than I could chew with that I think. [02:04:17] mhurd: bgerstle coreyfloyd before i go anything you guys need from me or tomorrow morning? [02:04:29] dr0ptp4kt: I thought it'd be simple but actually it's more complex than planned. Take it away. :-) [02:04:47] nope [02:04:49] Deskana: it's all those square brackets [02:04:56] dr0ptp4kt nope [02:05:00] dr0ptp4kt: have a good night! [02:05:23] 'night all [02:34:15] mhurd i think i'm gonna sign off for the night. should we plan on pairing on iOS 6 issues sometime tomorrow? [02:34:32] bgerstle_: ya sure! [02:34:42] also, should i file a bug for the lead image rotation stuff i found? [02:35:18] bgerstle_: maybe tomorrow show me on hangout? [02:35:24] sure [02:35:58] bgerstle_: cool. send me an invite if you want to do ios 6 stuff at specific time [02:36:13] already creating a cal even t;-) [02:36:15] bgerstle_: have a good night! [02:36:23] thanks, you too! [03:22:01] 3Wikipedia-App-Android-App, Wikipedia-App-iOS-App: As a User I should be able to swipe image preview to choose alternate background images for image based tweet - https://phabricator.wikimedia.org/T89790#1045565 (10Jaredzimmerman-WMF) 3NEW [03:27:43] bearND, what do you think about https://ticket.wikimedia.org/otrs/index.pl?Action=AgentZoom&TicketID=8077900 ? [03:28:08] (saving pages doesn't get everything you need to open an image page without a connection) [03:40:54] Krenair: yeah, the gallery info is not included in saved pages (yet). I hope we can get that in the future. I would probably like to see us use the RESTBase microservice we're going to develop first. Then including at least the gallery info in there should be possible. [03:41:31] (03PS1) 10Deskana: Fix incorrectly closed in qq/strings.xml [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191247 [03:42:46] Krenair: Not 100% guaranteed since we'll have to see how it pans out; e.g if size of payload is neg. affected we'd have to revisit, I guess we'd probably just include the smaller version of the images and not full size as in online. [03:53:11] (03PS2) 10BearND: Fix incorrectly closed in qq/strings.xml [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191247 (owner: 10Deskana) [03:53:30] (03CR) 10BearND: [C: 032] "Nice catch!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191247 (owner: 10Deskana) [03:53:49] (03Merged) 10jenkins-bot: Fix incorrectly closed in qq/strings.xml [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191247 (owner: 10Deskana) [04:01:47] bearND, ok, thanks. [04:02:03] bearND, what about https://ticket.wikimedia.org/otrs/index.pl?Action=AgentZoom&TicketID=7932491 ? [04:02:20] I thought we had the ability to distinguish between title and fulltext searches at some point [04:03:54] Krenair: we had that in the beta app but it has been replaced by a combination of the two in a single list. [04:04:07] ah [04:04:17] Krenair: Those search changes haven't made it to the prod app yet [04:04:42] so on the next update search will be much better? [04:05:01] Krenair: Yes. Also the beta app will get search suggestions back next time we release the beta app. [04:05:46] Krenair: I think we should be able to publish a new beta soon [04:06:00] yay :) [04:09:58] 3Wikipedia-App-Android-App, Wikipedia-App-iOS-App: As a User I should be able to swipe image preview to choose alternate background images for image based tweet - https://phabricator.wikimedia.org/T89790#1045599 (10Deskana) p:5Triage>3Normal We could probably incorporate this into the action sheet that's sho... [04:10:58] Deskana: How did you find the tag mismatch in the qq? [04:11:05] Great find [04:11:31] bearND: On a whim I ran that script I wrote to find missing string documentation [04:11:44] bearND: It said the descriptions were missing for the widgets [04:11:53] bearND: I went to add them in and Android Studio said they were already in there [04:11:57] Deskana: ah, nice! [04:12:09] bearND: Then I looked at them and saw the weird tag [04:14:23] there's also https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8137417 [04:14:47] putting a "Copy URL" button somewhere prominent [04:19:40] (03PS1) 10Mhurd: Added WIKIGLYPH_RELOAD. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191252 [04:21:17] (03CR) 10Mhurd: "Got tired of waiting for reload svg. Made one." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191252 (owner: 10Mhurd) [04:21:56] Deskana: ^ [04:22:21] mhurd: That's my boy! [04:22:22] ;-) [04:22:26] hehe :) [04:24:16] I'm writing a Wikimania talk submission [04:24:20] It's asking me for my country of origin [04:24:28] Which one of the three countries I have ties to should I enter? ^_^ [04:24:32] Stupid question [04:25:05] Deskana: Britmerica [04:25:21] Britamericaland [04:25:23] Don't forget Ireland ;-) [04:25:29] oh yeah! [04:25:44] Iremeritain? [04:34:35] (03PS2) 10Mhurd: Added WIKIGLYPH_RELOAD. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191252 [05:06:57] 3Wikipedia-App-Android-App, Wikipedia-App-iOS-App: As a User I should be able to swipe image preview to choose alternate background images for image based tweet - https://phabricator.wikimedia.org/T89790#1045693 (10Jaredzimmerman-WMF) >>! In T89790#1045599, @Deskana wrote: > We could probably incorporate this in... [05:20:06] 3Wikipedia-App-Android-App, Wikipedia-App-iOS-App: Page image should animate in rather than appearing suddenly - https://phabricator.wikimedia.org/T89797#1045707 (10Jaredzimmerman-WMF) 3NEW [05:25:36] 3Wikipedia-App-Android-App, Wikipedia-App-iOS-App: as a user I should be able to swipe on non-horizontal scrolling content to navigate back through browsing history - https://phabricator.wikimedia.org/T89798#1045714 (10Jaredzimmerman-WMF) 3NEW [05:27:00] (03PS5) 10Mhurd: WIP: Native component beneath webView. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 [05:30:17] (03CR) 10Mhurd: "Updated based on Corey's comments." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 (owner: 10Mhurd) [05:33:21] (03CR) 10Florianschmidtwelzow: [C: 04-1] Allow other extensions to add or override discovery tools (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191219 (owner: 10Bmansurov) [06:25:25] 3Mobile-Web: Users who click on a link shared from Tweet a Fact in the app should see a banner telling them about it - https://phabricator.wikimedia.org/T89403#1045801 (10MaxSem) @Deskana: can the link be changed to a standard routed hash, e.g. https://en.wikipedia.org/wiki/Barack_Obama#/source/app ? [06:35:03] 3Mobile-Web: Users who click on a link shared from Tweet a Fact in the app should see a banner telling them about it - https://phabricator.wikimedia.org/T89403#1045816 (10Deskana) @maxsem: @dartar was the one who requested the current URL format, so we should check with him. Is it okay to change this Dario? [06:48:35] 3Mobile-Web: Recruit volunteers via the JavaScript console - https://phabricator.wikimedia.org/T85815#1045827 (10phuedx) 5Open>3Resolved [06:56:52] 3Mobile-Web: Users who click on a link shared from Tweet a Fact in the app should see a banner telling them about it - https://phabricator.wikimedia.org/T89403#1045837 (10MaxSem) My main worry is cache purging: while currently non-canonical URLs are not cached, my paranoia suggests that in corner cases, such URL... [07:19:59] (03PS6) 10Mhurd: WIP: Native component beneath webView. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 [07:21:24] (03CR) 10Mhurd: "Mostly hooked up the "last modified by" and "other languages" native footer. Still need to hook up tap events and remove old non-native fo" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 (owner: 10Mhurd) [09:34:48] morning [09:36:05] 3Mobile-Web: Mobile sites are causing a lot of 404s in production - https://phabricator.wikimedia.org/T73571#1045988 (10Florian) 5Open>3Invalid If there aren't any 404's in prod anymore, i'm closing this task for now :) [09:47:38] hey hashar, i submitted yesterday https://gerrit.wikimedia.org/r/#/c/191009/ to add jenkins integration on gerrit for the Gather extension. For the moment i'm just interested in basic phpunit and phpcs support, can you have a look when you have a moment and give me feedback? I don't know if I have to do something else [10:02:07] 3Mobile-Web, MobileFrontend: Remove mobile editing "call to registration" CTA - https://phabricator.wikimedia.org/T87508#1046013 (10Florian) jQuery.tipsy isn't loaded on mobile actually, and i'm feeling bad to load the whole library just for one notification. Therefore i tested mediawiki.notify, because it's alr... [10:06:01] joakino: morning. I am in a conf call, will be available in a few [10:06:11] minutes [10:06:16] hashar: oki :) [10:06:55] conf is done. Nature's call , I have one liter of tea to evacuate [10:06:57] and need a coffee [10:08:29] (03PS1) 10Florianschmidtwelzow: Editor: Don't ask for confirm leave, if nothing changed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191283 [10:10:33] 3MobileFrontend, Mobile-Web: Remove mobile editing "call to registration" CTA - https://phabricator.wikimedia.org/T87508#1046022 (10Florian) [10:10:39] morning joakino [10:10:43] hey hash [10:10:45] *hashar [10:10:50] helps if i open my irc client [10:12:24] hi phuedx! [10:12:56] exclamation mark [10:13:00] someone's in a good mood [10:13:28] 3MobileFrontend, Mobile-Web: Remove mobile editing "call to registration" CTA - https://phabricator.wikimedia.org/T87508#1046032 (10Nemo_bis) The screenshot looks rather good as a result. I'd still consider some conservative auto-hiding, like 10 seconds. [10:15:11] (03CR) 10Phuedx: Allow other extensions to add or override discovery tools (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191219 (owner: 10Bmansurov) [10:21:24] joakino: back sorry [10:21:29] np [10:21:38] looking at https://gerrit.wikimedia.org/r/#/c/191009/ [10:21:53] thx [10:22:05] dependencies: 'PageImages,TextExtracts,MobileFrontend' [10:22:19] the trick is that the dependencies are not iterated [10:22:27] so you have to add all the ones from MobileFrontend [10:22:50] maybe we can add Gather to the shared job which already has all mobile extensions [10:26:28] (03CR) 10Phuedx: [C: 04-1] "See inline for a few minors." (034 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [10:29:15] (03CR) 10Phuedx: [C: 032] Test invalid request parameters [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/190490 (owner: 10MaxSem) [10:30:21] (03Merged) 10jenkins-bot: Test invalid request parameters [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/190490 (owner: 10MaxSem) [10:30:28] hashar: oki, i'm going to update it with the mobile frontend ones [10:30:51] hashar: it would be good to have it on the shared one too, since we are running mobile-only and mobile frontend dependent for a quarter at least [10:31:45] joakino: the shared job does not run qunit jobs yet though :(- [10:32:26] hashar: oo [10:32:55] hashar: let's go for the simple setup now, we'll add more stuff as we need it then [10:33:05] hashar: can jenkins run browser tests? [10:33:58] joakino: twice per days using SauceLabs VMs [10:34:07] we don't have support to run the browser tests on patchset submission yet [10:34:11] well we do [10:34:16] but it is not really used and flappy :-( [10:35:01] hashar: i was thiking since we are only going to have a couple of features with 2 or 3 scenarios that maybe we could try to run them on patches, is it worth it? [10:35:15] joakino: yeah we want to achieve that eventually [10:35:45] oki [10:36:17] I am generating the jobs for Gather [10:36:24] exec jenkins-jobs --conf jenkins_jobs.ini update config/jjb '*Gather*' [10:36:36] i've pushed ps2 with the updated deps [10:36:47] btw, you could generate them using your labs account :-] The process is described at http://www.mediawiki.org/wiki/CI/JJB [10:37:10] * joakino goes on to read [10:38:19] and I have manually triggered a run of the job at https://integration.wikimedia.org/ci/job/mwext-Gather-testextension-hhvm/1/console [10:39:28] hashar: so that is for testing that the patch does what it has to, right? [10:40:26] joakino: exactly [10:40:31] and I have amended the Zuul conf [10:40:41] some scary setting / filter was missing. I am commenting on the Gerrit change [10:40:48] waiting for job to complete [10:40:54] tis cloning the whole world [10:41:10] haha ok [10:43:02] so master fails https://integration.wikimedia.org/ci/job/mwext-Gather-testextension-hhvm/1/console [10:43:08] The module 'ext.collections.styles' must not have target 'desktop' because its dependency 'skins.minerva.special.styles' does not have it [10:43:09] :-( [10:43:19] that is test ResourcesTest::testUnsatisfiableDependencies [10:43:24] it is a test in core [10:43:34] which checks whether the ResourceLoader registrations are properly set [10:44:24] hashar: hmm [10:44:39] so i should probably remove that target then [10:45:50] I know MobileFrontend had a similar issue [10:45:53] which got fixed eventually [10:47:49] (03PS1) 10Jhernandez: Remove desktop group from special page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191304 [10:47:59] hashar: how do we test if ^ fixes it? [10:48:32] hmm [10:48:41] we can trigger the job manually and have it fetch that patch [10:48:52] wanna do a google hangouts? [10:50:28] hashar: yep, 1 min [10:52:00] (03CR) 10Florianschmidtwelzow: [C: 04-1] Move over WikiGrok front end code from Mobile Frontend (035 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [10:52:53] hashar: my girlfriend is by the router sleeping after a 24h work shift :( i can't get into hangouts now without waking her up (and if i move far from the router it doesn't cut it) [10:52:54] grr [10:53:30] let her sleep so :-] [10:53:42] 24 hours shift are awful [10:53:59] doctors... [10:54:01] agreed [10:54:05] so I have already triggered the job manually once against the master branch [10:54:10] the job parameters are shown at https://integration.wikimedia.org/ci/job/mwext-Gather-testextension-hhvm/1/parameters/ [10:54:18] ZUUL_URL = https://gerrit.wikimedia.org/r/p [10:54:24] is the prefix to git clone / git fetch from [10:54:32] ZUUL_PROJECT = mediawiki/extensions/Gather [10:54:34] is the repository [10:54:39] and so once [10:54:59] ZUUL_REF , ZUUL_COMMIT and ZUUL_BRANCH are used to fetch the patch [10:55:20] if you login on https://integration.wikimedia.org/ci/ using your wmflabs account [10:55:39] then going to the job main page https://integration.wikimedia.org/ci/job/mwext-Gather-testextension-hhvm/ , you should have a link on the left that says: [ Build with Parameters ] [10:55:51] that would show a form asking to fill the ZUUL_* parameters [10:56:21] so we can reuse mostly the same parameters [10:56:45] but use the info from your Gerrit change, i.e.: ZUUL_COMMIT= 496a64273ea89a8c8fea63ce191e435a4c76d6ce and ZUUL_REF=refs/changes/04/191304/1 [10:57:01] (03CR) 10Florianschmidtwelzow: "will this break the desktop style? I think Gather shouldn't be focused on mobile web, it should be useable from desktop and mobile from th" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191304 (owner: 10Jhernandez) [10:57:03] the script will git fetch $ZUUL_URL/$ZUUL_PROJECT $ZUUL_REF [10:57:09] and then git checkout $ZUUL_COMMIT [10:57:24] (03CR) 10MaxSem: [C: 04-1] "In general: please use the standard extension layout, with all resources being in resources directiry, in subdirectories named after modul" (0315 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [10:57:33] aha, thanks hashar, going to try that [10:58:56] (03CR) 10MaxSem: Move over WikiGrok front end code from Mobile Frontend (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [11:02:42] (03CR) 10Jhernandez: "Agreed florian but i want to get jenkins working. We explicitly depend on special.minerva styles which do not target desktop, so I'm just " [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191304 (owner: 10Jhernandez) [11:07:17] hashar: what do i use for the ZUUL_UUID? [11:08:07] joakino: I don't think it is used [11:08:12] just use 'foobar' :-] [11:08:20] UUID can be skipped [11:08:32] ZUUL_PIPELINE can probably as well. I use 'manual' [11:08:51] you are fast :] [11:09:12] bah [11:09:20] you need ZUUL_CHANGE and ZUUL_PATCHSET [11:09:23] just enter some random numbers [11:09:41] ZUUL_BRANCH should be: master [11:09:47] that is the actual git branch [11:10:12] hashar: so branch is not the topic branch on gerrit [11:10:38] (03CR) 10Florianschmidtwelzow: "In fact: no styles module in MF depends on another styles module, there is normally no reason to do that. All special pages, which get's l" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191304 (owner: 10Jhernandez) [11:10:39] hashar: i can't edit the build parameters? [11:11:12] maxsem is still awake [11:11:19] phuedx: yea xd [11:11:43] joakino: ah you have to rebuild last [11:11:51] (03CR) 10Jhernandez: "I'll try this out soon. As soon as I learn how to properly launch jenkins xd" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191304 (owner: 10Jhernandez) [11:11:53] joakino: on the job main page https://integration.wikimedia.org/ci/job/mwext-Gather-testextension-hhvm/ [11:11:59] hit [Rebuild Last] [11:12:12] hashar: cool thx [11:12:28] it will show the form populated with parameters from previous build [11:12:40] hashar: so ZUUL_CHANGE and ZUUL_PATCHSET are not used/ [11:13:11] or do i use the gerrit patch changeid [11:13:35] you can use the gerrit chnage / patch id [11:13:36] ok doing stuff now https://integration.wikimedia.org/ci/job/mwext-Gather-testextension-hhvm/3/console [11:14:25] holy hell my disk is full :/ [11:17:17] haha [11:18:10] (03PS2) 10Phuedx: Add javascript dev and test tools [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191232 (owner: 10Bmansurov) [11:18:12] (03PS4) 10Phuedx: Move over WikiGrok front end code from Mobile Frontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [11:18:14] (03PS1) 10Phuedx: Instrument the widget-click-none WikiGrok action [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191319 [11:19:19] (03CR) 10Phuedx: "PS2 is a rebase." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191232 (owner: 10Bmansurov) [11:19:31] seems https://integration.wikimedia.org/ci/job/mwext-Gather-testextension-hhvm/3/console is happy [11:19:37] (03CR) 10Phuedx: "PS4 is a rebase." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [11:20:01] hashar: yep [11:20:10] i'm trying another fix for that problem [11:20:45] awesome, thanks hashar, so when i get the patch that makes the build happy on gather, do i ping you for merging the integration/config patch? [11:20:46] I need to clear out my disk :/ [11:21:05] so yeah you can test it yourself [11:21:09] amend patch until happy [11:21:20] then need a final review by one from integration to get the Zuul config deployed [11:22:00] ok [11:23:12] gotta quit sorry :-( [11:23:23] (03PS2) 10Jhernandez: Remove dependency from special.minerva styles [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191304 [11:23:30] bb hashar [11:24:30] (03CR) 10Jhernandez: [C: 031] "Ok, Florian I've removed that dependency, it doesn't do anything as you thought (when on minerva)." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191304 (owner: 10Jhernandez) [11:26:58] (03PS3) 10Jhernandez: Remove dependency from special.minerva styles [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191304 [11:27:23] (03CR) 10Jhernandez: "Updated the freaking extension.json" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191304 (owner: 10Jhernandez) [11:28:51] (03CR) 10Jhernandez: [C: 031] "Ok, this patchset makes jenkins happy with the mwext-Gather-testextension-hhvm job. Look at https://integration.wikimedia.org/ci/job/mwext" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191304 (owner: 10Jhernandez) [11:36:50] (03CR) 10Florianschmidtwelzow: [C: 031] "i can not merge here, but if i could, i would do it :D" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191304 (owner: 10Jhernandez) [11:37:27] (03CR) 10Jhernandez: [C: 032 V: 032] "Good enough to me :P" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191304 (owner: 10Jhernandez) [11:38:39] gonna make a cup of coffee [11:39:03] joakino: getting your self-merge on i see ;) [11:39:28] phuedx: i'm merging for florian :p haha [11:39:53] not only self-merge, but self-jenkinsify submit too [11:39:59] its a really manual repo xD [11:56:00] (03CR) 10Jhernandez: "This is giving me this errors:" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191083 (owner: 10Jhernandez) [12:33:42] (03CR) 10Jhernandez: [C: 031 V: 032] "Verify it and merge it when you can" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190801 (owner: 10Jhernandez) [12:34:46] (03CR) 10Phuedx: "Couple of minor comments inline." (034 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [12:40:17] i'm out to the gym and lunch [12:41:12] bbl [14:51:52] (03CR) 10Bmansurov: Allow other extensions to add or override discovery tools (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191219 (owner: 10Bmansurov) [14:57:55] (03CR) 10Bmansurov: "phuedx, wikigrok folder should have been removed ;(" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [14:58:15] (03CR) 10Bmansurov: Move over WikiGrok front end code from Mobile Frontend (033 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [15:05:24] (03CR) 10Florianschmidtwelzow: Allow other extensions to add or override discovery tools (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191219 (owner: 10Bmansurov) [15:17:03] joakino: my comp has some disk space now :] [15:17:10] i am merging the CI configuration change https://gerrit.wikimedia.org/r/#/c/191009/ [15:17:16] congrat on testing all the jobs [15:25:52] (03CR) 10Hashar: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190801 (owner: 10Jhernandez) [15:25:54] (03CR) 10jenkins-bot: [V: 04-1] Collections list collections show image [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190801 (owner: 10Jhernandez) [15:26:32] (03CR) 10Hashar: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190791 (owner: 10Jhernandez) [15:27:04] lets see https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/3653/console [15:27:06] should be fine [15:27:31] joakino: Gather is configured now :-] [15:29:20] (03CR) 10Hashar: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191005 (owner: 10Jhernandez) [15:29:35] (03CR) 10Hashar: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190802 (owner: 10Jhernandez) [15:29:36] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Rename views\ItemImage to views\Image [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190802 (owner: 10Jhernandez) [15:32:06] I am off again [15:32:09] but Gather should be fine [15:34:52] (03CR) 10Bmansurov: Move over WikiGrok front end code from Mobile Frontend (032 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [15:37:11] 3Wikipedia-App-Android-App: Cache visited pages in filesystem instead of ram. - https://phabricator.wikimedia.org/T89826#1046440 (10Dbrant) 3NEW [15:38:31] 3Wikipedia-App-Android-App: Reuse the same WebView for visiting subsequent pages. - https://phabricator.wikimedia.org/T89828#1046456 (10Dbrant) 3NEW [15:40:07] 3Wikipedia-App-Android-App: Don't perform arbitrary-length transactions over the Javascript bridge. - https://phabricator.wikimedia.org/T89831#1046487 (10Dbrant) 3NEW [15:41:00] 3Wikipedia-App-Android-App: Limit the filesystem cache size of Picasso library. - https://phabricator.wikimedia.org/T89834#1046511 (10Dbrant) 3NEW [15:57:17] (03PS5) 10Bmansurov: Move over WikiGrok front end code from Mobile Frontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 [15:58:10] (03PS6) 10Bmansurov: Move over WikiGrok front end code from Mobile Frontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 [16:02:45] (03CR) 10Bgerstle: [C: 04-1] "lgtm, public domain glyph still works" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191252 (owner: 10Mhurd) [16:02:55] (03CR) 10Bgerstle: [C: 031] "whoops, meant to +1" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191252 (owner: 10Mhurd) [16:06:45] (03CR) 10Bmansurov: Allow other extensions to add or override discovery tools (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191219 (owner: 10Bmansurov) [16:07:09] (03PS2) 10Bmansurov: Allow other extensions to add or override discovery tools [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191219 [16:07:56] (03PS2) 10Bmansurov: Remove WikiGrok related stuff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191224 [16:09:07] (03PS7) 10Bmansurov: Move over WikiGrok front end code from Mobile Frontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 [16:09:29] (03CR) 10Florianschmidtwelzow: [C: 032] Allow other extensions to add or override discovery tools [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191219 (owner: 10Bmansurov) [16:09:57] (03PS8) 10Bmansurov: Move over WikiGrok front end code from Mobile Frontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 [16:10:36] (03Merged) 10jenkins-bot: Allow other extensions to add or override discovery tools [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191219 (owner: 10Bmansurov) [16:10:58] (03CR) 10jenkins-bot: [V: 04-1] Move over WikiGrok front end code from Mobile Frontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [16:12:51] (03PS3) 10Jhernandez: Collections list collections show image [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190801 [16:14:35] (03CR) 10jenkins-bot: [V: 04-1] Collections list collections show image [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190801 (owner: 10Jhernandez) [16:19:26] (03CR) 10Bgerstle: [C: 04-1] "see comments about UIScrollView's panRecognizer and leveraging keyboard notifications to prevent unnecessary calculation when keyboard isn" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190960 (owner: 10Rahdev) [16:20:31] (03PS4) 10Jhernandez: Collections list collections show image [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190801 [16:21:06] 3Wikipedia-App-Android-App: Cache visited pages in filesystem instead of ram. - https://phabricator.wikimedia.org/T89826#1046666 (10Dbrant) [16:21:07] 3Wikipedia-App-Android-App: OutOfMemoryError crashes from some IO/string building code - https://phabricator.wikimedia.org/T86442#1046665 (10Dbrant) [16:21:34] (03CR) 10jenkins-bot: [V: 04-1] Collections list collections show image [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190801 (owner: 10Jhernandez) [16:21:58] 3Wikipedia-App-Android-App: Limit the filesystem cache size of Picasso library. - https://phabricator.wikimedia.org/T89834#1046671 (10Dbrant) [16:21:58] 3Wikipedia-App-Android-App: Out of space errors causing app to crash - https://phabricator.wikimedia.org/T87073#1046670 (10Dbrant) [16:22:47] wtf jenkins [16:25:16] (03CR) 10Jhernandez: "I don't know what the hell is going on. I can't even see an error message in the jenkins jobs output..." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190801 (owner: 10Jhernandez) [16:26:43] jhernandez: jerkins [16:27:16] kristenlans: so long we waited to have it, and when it came... [16:28:37] 3Wikipedia-App-Android-App: android.os.TransactionTooLargeException (when editing a large page?) - https://phabricator.wikimedia.org/T68872#1046722 (10Dbrant) [16:28:38] 3Wikipedia-App-Android-App: Reuse the same WebView for visiting subsequent pages. - https://phabricator.wikimedia.org/T89828#1046724 (10Dbrant) [16:28:39] 3Wikipedia-App-Android-App: Cache visited pages in filesystem instead of ram. - https://phabricator.wikimedia.org/T89826#1046723 (10Dbrant) [16:30:40] 3Wikipedia-App-Android-App: Cache visited pages in filesystem instead of ram. - https://phabricator.wikimedia.org/T89826#1046741 (10Dbrant) [16:30:43] 3Wikipedia-App-Android-App: App unexpectedly closes on Samsung Galaxy Ace II X (S7560M) - https://phabricator.wikimedia.org/T76279#1046740 (10Dbrant) [16:30:43] 3Wikipedia-App-Android-App: Reuse the same WebView for visiting subsequent pages. - https://phabricator.wikimedia.org/T89828#1046742 (10Dbrant) [16:32:49] 3Wikipedia-App-Android-App: Search results missing some prefix results - https://phabricator.wikimedia.org/T86243#1046750 (10Dbrant) 5Open>3Resolved a:3Dbrant [16:36:11] 3Wikipedia-App-Android-App: Material Design: The app could be more material - https://phabricator.wikimedia.org/T87141#1046814 (10Dbrant) We are indeed ♫ living in a material world ♫ [16:44:29] (03CR) 10Bgerstle: "looks good so far, just left some style comments and questions" (036 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 (owner: 10Mhurd) [16:46:07] (03CR) 10Fjalapeno: [C: 031] Added WIKIGLYPH_RELOAD. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191252 (owner: 10Mhurd) [16:57:35] (03PS1) 10Phuedx: Remove WikiGrok version A [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191358 [17:02:17] dbrant: Good sir, I had a thought. I'm guessing there's no way we can measure how often people are putting the widgets you made on their home screen? [17:03:05] Did we have a bug for the launcher icon somewhere? [17:03:52] dbrant: Regardless, can we log that the app was started as a result of someone tapping on one of the widgets? [17:04:06] started/resumed/brought to the foreground/whatever [17:04:38] Krenair: You mean the fact that the alpha icon changed recently? [17:05:07] no [17:05:12] Deskana: that's a great question... we'd have to investigate to be sure. I know for certain that we can tell when the widget is *updated*, but this can be when the wedget is first placed, OR when the device is restarted, or if the widget is picked up and dropped down again, etc.... [17:05:18] (it changed? I should install alpha...) [17:05:39] Deskana: we can definitely track when the app is launched from the widget. [17:05:40] (03PS1) 10Fjalapeno: Implement new refresh saved pages logic and UI. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 [17:05:52] dbrant: I went looking and found out where we can put that. [17:06:01] * Deskana looks at his calendar for today and sees if he has time to do this himself [17:06:10] I have been too long away from the fold of the code! [17:06:44] (03PS2) 10Fjalapeno: Implement new refresh saved pages logic and UI. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 [17:07:22] Deskana: would you put it into an existing schema? [17:07:41] dbrant: I doubt it, probably a separate one. I'm concerned about sampling the widget searches because I suspect they'll be low throughput. [17:08:01] dbrant: Probably something like MobileWikiAppWidgets [17:08:16] dbrant: Then log, e.g. action = "search", action = "featuredarticle", etc [17:08:37] sure, that's good [17:09:24] Then you can compare search starts (from MobileWikiAppSearch) to widget search starts (from MobileWikiAppWidgets, divided by 100 to make the data comparable) to see what percentage of searches were started from the widget [17:10:01] Krenair: It did. We're trying to make it more material design-y. I don't think we did a good job of it, really. [17:10:08] ok [17:10:20] ^ sort of agree [17:10:39] Did you guys put up an alpha build somewhere with that in? [17:10:39] Or would I have to compile it from the repo to see that? [17:10:59] It'll be in the normal alphas from android-builds.wmflabs.org [17:12:38] Deskana: I would expect the percentage of searches from the widget to be quite small. The discoverability of the widgets is abysmal :( [17:12:43] and it doesn't help that our widget starts with the letter "W", which puts it at the very end of the list. [17:12:53] I was thinking about that too [17:13:00] But I don't know that we should cheat ^_^ [17:13:14] I wonder how invisible spaces are sorted :D [17:14:43] Deskana: I was going to bug vibha to make some further refinements to the icons. [17:16:11] (03PS9) 10Bmansurov: Move over WikiGrok front end code from Mobile Frontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 [17:16:18] dbrant: Yeah, I think that'd be good. They stand out rather a lot from other more material-y icons. [17:16:32] (03PS10) 10Bmansurov: Move over WikiGrok front end code from Mobile Frontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 [17:17:43] (03CR) 10jenkins-bot: [V: 04-1] Move over WikiGrok front end code from Mobile Frontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [17:19:34] oh i found an interesting bug [17:19:49] or, unexpected behavior (on my part) [17:19:54] while debugging lead image issues [17:19:56] Deskana, https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8011866 appears to propose integration with Opera Mini, and a couple of design things [17:20:13] but in spanish [17:20:29] coreyfloyd it seems our shrinking the UIWebView via the TOC causes different images to be selected from the 's srcset attribute [17:20:56] i'm not sure how srcset even behaves, but i'm now wondering if the TOC causes a bunch of network requests to fire for smaller images [17:21:12] bgerstle - thats weird [17:21:25] bgerstle do you have charles - you can inspect network while you are doing things [17:21:26] Krenair: I think they just want us to use image compression like Opera Mini does. [17:21:28] coreyfloyd need to verify in the inspector [17:21:42] coreyfloyd no, but i can probably monitor this via safari inspector [17:21:59] let me verify how behvaves w/ resizing [17:22:21] Krenair: We're aware of that request, so I'd just thank them for the suggestion. :-) [17:23:14] bgerstle: The ToC used to have images in it for each section, but that was taken out because we felt it was too distracting/unreliable from a design standpoint. [17:23:20] coreyfloyd (or everyone for that matter) i found out today that changing my OSX DNS settings to use google's public DNS servers (8.8.8.8 and 8.8.4.4) cut my IRC latency by 70% [17:23:33] bgerstle: Do you think it's related to that? [17:23:41] Deskana this isn't related to the TOC itself, but how the UIWebView shrinks to make room for it [17:23:48] Deskana, "Gracias por tus sugerencias. El equipo es consciente de estos problemas." is a google translate [17:24:04] it's effectively shrinking the window size, which i'm guessing causes the browser to pick smaller images [17:24:15] I don't know if there's someone here who speaks spanish that can check [17:24:17] Krenair: Perhaps you could ask joakino whether that actually makes sense or not. [17:24:51] hey Krenair [17:24:54] hi [17:25:14] bgerstle: Ahhhh, I see what you mean. [17:25:27] Krenair: it sounds good to me, more context would be good too [17:25:47] bgerstle: What's the actual user-facing symptom of this? Are the new images that were loaded pixelated once you close the ToC? [17:26:00] Deskana right now it's causing a failed assertion in the image gallery [17:26:01] joakino, someone is requesting image compression, and a couple of design changes, to the android wikipedia app [17:26:09] since it's not able to find the selected image but the "src" URL [17:26:30] which has changed to a URL which we didn't know about (i.e. didn't parse from the image's "src" attribute) [17:26:46] s/but/by/ [17:27:13] bgerstle so this causes a problem even after the TOC is closed? [17:27:15] Krenair: sounds good [17:27:20] or only while it is open [17:27:25] that's what i'm trying to figure out [17:33:41] of course now i can't produce the issue anymore [17:34:05] 3Mobile-Web: Users who click on a link shared from Tweet a Fact in the app should see a banner telling them about it - https://phabricator.wikimedia.org/T89403#1047074 (10DarTar) @MaxSem the proposed change works for me, how would you recommend representing multiple parameters, in case we need them? Also, note t... [18:01:25] bmansurov: ping [18:01:27] pong [18:01:32] coming [18:01:37] (03CR) 10Florianschmidtwelzow: Move over WikiGrok front end code from Mobile Frontend (032 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [18:03:08] (03PS3) 10Florianschmidtwelzow: Remove WikiGrok related stuff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191224 (owner: 10Bmansurov) [18:06:13] (03CR) 10Dbrant: [C: 032] ShareAFact design changes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191194 (owner: 10BearND) [18:06:42] (03PS1) 10Dr0ptp4kt: Event logging for suggested pages [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191367 [18:08:43] 3Mobile-Web: Users who click on a link shared from Tweet a Fact in the app should see a banner telling them about it - https://phabricator.wikimedia.org/T89403#1047183 (10Florian) >>! In T89403#1047074, @DarTar wrote: > how would you recommend representing multiple parameters, in case we need them? Just add a "/... [18:10:28] MaxSem: just added myself to the card [18:12:16] (03CR) 10Florianschmidtwelzow: Hygiene: Use Config object in SpecialPages (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190841 (https://phabricator.wikimedia.org/T87614) (owner: 10Florianschmidtwelzow) [18:12:34] (03PS2) 10Florianschmidtwelzow: Hygiene: Use Config object in SpecialPages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190841 (https://phabricator.wikimedia.org/T87614) [18:12:43] (03CR) 10Bmansurov: Move over WikiGrok front end code from Mobile Frontend (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [18:13:41] (03PS11) 10Bmansurov: Move over WikiGrok front end code from Mobile Frontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 [18:15:00] (03PS2) 10Bmansurov: Instrument the widget-click-none WikiGrok action [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191319 (owner: 10Phuedx) [18:15:20] f/away [18:15:22] ksadjh [18:15:27] i'm a professional [18:16:19] interestingly, i actually have that in textexpander [18:16:36] ;pro -> I'm a professional. [18:18:28] who doesn't love dbrant's gif responses? [18:19:40] (03CR) 10Bmansurov: [C: 04-1] "Wouldn't it be better to listen to the '.none' button click and log this event?" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191319 (owner: 10Phuedx) [18:27:30] phuedx: I'm pretty sure I can think of Tim&Eric scenes that apply to any situation in life. [18:29:08] bmansurov: y'know what, it would – now i know how that little group of buttons works [18:29:46] cool [18:32:53] mhurd i'll be in the hangout, ready to start when you are [18:33:23] mhurd: bgerstle coreyfloyd when you have a moment would you please review https://gerrit.wikimedia.org/r/#/c/191367/ ? this is the one i mentioned during standup [18:33:48] dr0ptp4kt sure once i'm done w/ monte [18:33:52] (03PS3) 10Phuedx: Instrument the widget-click-none WikiGrok action [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191319 [18:34:01] bgerstle: thx [18:34:09] (03CR) 10Phuedx: "Yes. Yes it would." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191319 (owner: 10Phuedx) [18:34:14] kristenlans: you guys should decide what works best for you but experience has showed me that under committing on the sprint todo column and keeping a prioritized backlog works better for the PM as it sets a clear expectation of what will actually get done rather then what is aspirational [18:34:58] but you guys should pick what works best for the team and we'll support it [18:35:24] (03CR) 10Fjalapeno: [C: 031] "Seems straight forward." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191367 (owner: 10Dr0ptp4kt) [18:35:32] coreyfloyd: thx [18:36:37] tfinc: +1 [18:36:48] (to both bits) [18:37:10] phuedx, bmansurov, joakino: can one of you look over change https://gerrit.wikimedia.org/r/#/c/191283/ and merge it, if it's ok? So we save a swat :) [18:37:39] tfinc: yep, I agree with you. As I mentioned we don't _really_ have a great sense of our velocity yet, but we can make an educated guess. I can work with dan to prune a few things out. [18:38:15] FlorianSW: in the middle of another review /cc bmansurov joakino [18:38:23] kristenlans: thats fine and if the worst of it is picking up stories that are estimated from the backlog then your doing pretty well [18:38:36] i'm sure you'll lead the team well through this [18:38:37] FlorianSW: will take a look in a bit [18:39:04] bmansurov, phuedx +1, thanks :) [18:39:37] (03PS1) 10Florianschmidtwelzow: Hygiene: Don't set robots policy for a skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191374 [18:40:36] dr0ptp4kt mhurd bgerstle check this out when you get a chance - I did a dry run and works good (read: project builds) - but does move quite a few files in order to sync the file structure (read: large diff). If you are all good with it, I'd like to get this in while we have a small amount of outstanding branches… https://github.com/venmo/synx [18:41:36] MaxSem: the patch lgtm, just performing a test update now [18:44:07] (03CR) 10Bmansurov: [C: 04-1] Remove WikiGrok version A (035 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191358 (owner: 10Phuedx) [18:46:14] (03PS1) 10Deskana: Add warning to translators that this feature is experimental. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191377 [18:48:23] (03CR) 10Florianschmidtwelzow: "Maybe we should ask Siebrand (or any other twn admin) to not include Gather for translations in this stadium on twn? I don't know the exac" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191377 (owner: 10Deskana) [18:48:33] (03CR) 10Bmansurov: [C: 032] Editor: Don't ask for confirm leave, if nothing changed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191283 (owner: 10Florianschmidtwelzow) [18:49:02] thx bmansurov :) [18:49:20] FlorianSW: np, also, when you add some text and undo your changes, the editor still thinks that you edited it. [18:49:38] (03Merged) 10jenkins-bot: Editor: Don't ask for confirm leave, if nothing changed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191283 (owner: 10Florianschmidtwelzow) [18:50:40] bmansurov: that's the problem, that we don't check the original text against the entered, we just recognize, if the user entered some text or not :/ But that's not different from desktop iirc, so shouldn't be a big problem. [18:50:53] k [18:51:32] bmansurov: no, desktop doesn't ask, if you want to leave if you restore the old version of the page :/ [18:52:16] (03CR) 10Bmansurov: [C: 032] "We should do [1] in a follow up patch." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191319 (owner: 10Phuedx) [18:52:37] FlorianSW: ok, we should do the same then [18:52:51] already working on it [18:54:22] (03CR) 10Jhernandez: [C: 032 V: 032] "Let's get the warnings in, and discuss about Florian comments." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191377 (owner: 10Deskana) [18:55:57] FlorianSW: 👍 [18:57:06] (03CR) 10Jkatz: "Hi Florian--there might be a more elegant way to handle this, but given it is a small issue and for the sake of everyones time, I think a " [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191377 (owner: 10Deskana) [18:59:31] (03CR) 10Jhernandez: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190801 (owner: 10Jhernandez) [19:00:13] Coming upstairs! [19:04:22] (03PS5) 10Jhernandez: Collections list collections show image [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190801 [19:07:11] (03PS2) 10Jhernandez: Hygiene: Rename views\ItemImage to views\Image [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190802 [19:13:52] This error starts appearing from 2 days. The edit source icon in mobile version of wikipedia(A Pencil Logo), get merged to the notification icon on the top right corner of the page . [19:14:06] lol dbrant MaxSem http://i.imgur.com/hODVmh2.png [19:14:08] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#I_am_not_able_to_edit_my_user_page [19:14:14] can't stop laughing [19:15:00] thedj: in wikipedias? oO [19:15:34] thedj: let me check that out [19:16:27] thedj: yes, you're right, wait, we had a swat yesterday i think: https://gerrit.wikimedia.org/r/#/c/190984/ [19:16:31] joakino: ^ [19:16:42] this should fix the user page, too [19:16:53] (i can't reproduce it actually on enwiki?) [19:17:01] FlorianSW: mainpage? [19:17:20] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191252 (owner: 10Mhurd) [19:17:21] userpage only perhaps ? [19:17:34] damn [19:17:46] or caching issue if it was indeed already fixed. always a possibility [19:17:49] coreyfloyd: bgerstle dr0ptp4kt ^ merged the reload glyph update [19:18:42] hmm, i can't reproduce it on https://en.m.wikipedia.org/wiki/User:Saurabh_Chatterjee_2 :/ [19:19:22] (03CR) 10Bmansurov: Move over WikiGrok front end code from Mobile Frontend (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [19:19:44] thedj: FlorianSW: i can't reproduce on enwiki on my user page [19:19:57] the icon is below the title User: username [19:19:58] joakino: me too, see above message :/ [19:20:21] anyway i'm leaving for today! [19:20:27] have a nice day people [19:22:38] hehe: https://pbs.twimg.com/media/B-EItNsIMAAEuxb.jpg [19:25:47] coreyfloyd seriously? [19:26:24] yep - http://www.theverge.com/2015/2/17/8052603/comcast-ripped-off-apples-brand-to-make-a-tv-remote-look-special [19:26:57] coreyfloyd does it make you swell with local pride? [19:27:13] local humiliation [19:27:27] lol [19:27:48] (03PS1) 10Florianschmidtwelzow: Don't ask for leave, if the content hasn't changed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191384 [19:27:58] bmansurov: ^ [19:30:06] mhurd would you mind sending me the TF instructions? i should probably cut a build for Deskana et. al before i do anymore work on it [19:31:55] (03CR) 10Mhurd: [C: 04-1] "On the simulator, if I open up "Data/sites/wikipedia.org/en/articles/" and watch the folder as I refresh, the saved folders disappear inst" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [19:32:07] bgerstle: quick hangout? [19:32:14] sure [19:33:39] (03CR) 10Bmansurov: Don't ask for leave, if the content hasn't changed (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191384 (owner: 10Florianschmidtwelzow) [19:36:19] (03CR) 10Mhurd: "Looks like the title isn't switching to "Updating" per the mock." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [19:37:48] (03CR) 10Mhurd: "Also the cancel message is missing the refresh glyph." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [19:38:18] (03CR) 10Florianschmidtwelzow: Don't ask for leave, if the content hasn't changed (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191384 (owner: 10Florianschmidtwelzow) [19:38:40] (03PS2) 10Florianschmidtwelzow: Don't ask for leave, if the content hasn't changed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191384 [19:40:11] (03CR) 10MaxSem: [C: 04-1] "Please move the resources to resources/." (035 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [19:40:12] mhurd ? [19:41:18] bgerstle: hangout stuck... [19:41:26] same here :-/ [19:48:16] MaxSem: Do you mean I should move javascript, less, and templates folders into the resources folder? [19:49:28] yep. and group by module, not resource type [19:49:47] (03CR) 10MaxSem: [C: 032] "Let's move ahead wth this. We won't be able to test these until we have new jobs anyway." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191232 (owner: 10Bmansurov) [19:50:08] MaxSem: ok thanks [19:51:52] (03PS3) 10Fjalapeno: Implement new refresh saved pages logic and UI. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 [19:52:09] mhurd: ^ [19:53:17] mhurd: didnt get the glyph in the cancel message - didnt see your comment until now - if thats the only thing left, can we merge this and address that later? [19:53:31] (03Merged) 10jenkins-bot: Add javascript dev and test tools [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191232 (owner: 10Bmansurov) [19:54:19] bb in 30 [19:57:05] coreyfloyd: on hangout - will test right after [19:58:11] bearND: Looking at this card in "To do": https://trello.com/b/zCd2vxM8/mobile-apps-sprint-51-android-16th-feb-2nd-mar [19:58:15] bearND: Is this an old carD? [19:58:40] (03CR) 10MaxSem: [C: 032] TWN: mf-profile-last-thanked should really say "last thanked by" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190854 (owner: 10Florianschmidtwelzow) [19:59:04] Deskana: which card? You linked to the board [19:59:09] bearND: Phail. [19:59:34] bearND: I originally linked you to my calendar, and replaced it with a slightly less irrelevant link. :-p [19:59:36] bearND: https://trello.com/c/r24EJ6EV/17-epic-as-a-twitter-user-i-d-like-to-tweet-an-interesting-fact-so-my-friends-can-read-about-it [19:59:38] bearND: This card! [20:00:01] Deskana: ah, that's the epic card for this [20:00:14] probably should be moved along as well [20:00:52] Deskana: the design there is def. old [20:00:58] (03Merged) 10jenkins-bot: TWN: mf-profile-last-thanked should really say "last thanked by" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190854 (owner: 10Florianschmidtwelzow) [20:03:37] Deskana: I've moved it to "ready for signoff" [20:03:48] bearND: Cool. Thanks! [20:05:14] Deskana: is https://trello.com/c/l3i1DMc3/9-3-as-a-reader-i-d-like-suggestions-for-what-i-can-read-next-to-be-presented-to-me blocked? Just wondering why it has you on it [20:05:43] bearND: I'll check that stuff in an hour or so, we just had The Unblockening [20:05:51] bearND: Doing a thing about iOS sprint now [20:06:01] bearND: But yeah, that one's good to go AFAIK [20:06:13] Deskana: ah, cool. The plumber is gone ;) [20:08:58] Deskana: already getting food? [20:09:24] mhurd: I've brought lunch. Wrapping up a meeting, so why don't you go get something then I can reheat my food once you're back? [20:09:35] Deskana: cool will do [20:13:44] (03CR) 10Bgerstle: "code looks OK, will need to test it later" (037 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [20:14:23] (03CR) 10Mhurd: "Looks like it's still blasting saved data instead of refreshing it. Also getting occasional exception." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [20:15:31] lunch! [20:19:27] Deskana coreyfloyd dr0ptp4kt while looking through TF stuff w/ mhurd i found crash reports! [20:19:32] from the app store [20:19:54] they're not symbolicated, so i'd need the original dSYM from the build that was uploaded [20:24:17] brion ping [20:24:38] bgerstle: in a meeting but can look stuff up :) [20:24:56] i was wondering if you could export the developer identity for iOS App distribution [20:25:13] specifically, i need the private key for the iOS app distribution certificate [20:25:34] ah fun [20:26:08] bgerstle: adam should have it, if that’s not working i’ll give it another try [20:26:39] ok [20:28:13] brion he's not online now, could you quickly export it from your machine? [20:28:19] if you're too busy that's fine [20:28:24] i'll wait until adam gets bcak [20:28:25] back* [20:28:39] after the mtg i’ll check back :) [20:29:02] k, thanks! [20:29:11] ermagerd so much BRIOAN [20:29:59] bgerstle: FYI just got out of a mtg w/adam, pretty sure he's at lunch [20:30:15] figured as much, thanks kristenlans [20:31:03] kristenlans also: http://resources2.news.com.au/images/2012/12/13/1226535/447686-best-memes-of-2012.jpg [20:35:28] (03CR) 10Bgerstle: [C: 031] "looks good, just some minor comments" (034 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191367 (owner: 10Dr0ptp4kt) [20:40:56] bgerstle: lulz [20:48:42] bgerstle_: you there? [20:48:46] hey [20:49:13] bgerstle_: the crash reports you were referring to were the ones for the app store release, via itunes connect, not testflight, right? [20:49:18] right [20:49:21] the ones mainly around stalled start? [20:49:35] there seem to be others [20:49:48] hard to tell what's going on w/o symbols [20:50:21] actually, something related to core data? [20:50:28] so maybe data migration is broken? [20:50:49] anyway [20:51:14] just trying to figure out new TF stuff, and i wanted to see if i could make a build to upload to TF in iTunes Connect [20:54:06] dr0ptp4kt ^ [20:56:31] (03PS4) 10Bmansurov: Remove WikiGrok related stuff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191224 [20:59:55] coreyfloyd: you around? [21:00:05] bgerstle_: i'm about to call you guys from my computer so we can all talk testflight [21:00:07] dr0ptp4kt: yep [21:00:19] dr0ptp4kt: whats up? [21:00:23] sure [21:02:04] coreyfloyd: you getting the google hangout invitation in gmail? [21:03:55] (03PS1) 10Dbrant: [WIP] Final tweaks/fixes for share-a-fact. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191430 (https://phabricator.wikimedia.org/T86242) [21:04:46] dr0ptp4kt bgerstle_ coreyfloyd FYI another ad hoc meeting thing you can use if it's easier is "the batcave" (persistent hangout link, just bookmark it) [21:04:51] https://plus.google.com/hangouts/_/event/c5p2pudvb8s6ckluqf56v791em4 [21:19:25] Deskana: https://trello.com/c/vLmz1Vyr [21:19:59] Deskana: so we are only doing the multiple suggestion version to satisfy the trello story? [21:20:24] coreyfloyd: That's correct [21:20:42] coreyfloyd: This one: https://trello-attachments.s3.amazonaws.com/545d0274e501c2777ccceaf4/1015x2707/16845cc5065900da208da0588e301f79/DESIGN1.png [21:21:08] Deskana: got it - and are we putting the "reason for inclusion" (the third line) in as well? [21:21:19] (03PS27) 10MaxSem: WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [21:21:21] Deskana: we dont really have that info right? Arent we just doing a search? [21:21:33] (03CR) 10MaxSem: WIP: recording and applying user responses (033 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [21:21:37] coreyfloyd: Yeah, this design is a little out of date [21:21:52] ok - so just title and wikigrok description? [21:21:56] Deskana: ^ [21:22:24] Deskana: maybe can you update the card with the current IA for the feature even if the images are out of sync? [21:22:43] coreyfloyd: http://i.imgur.com/jH4c7pB.png [21:22:48] coreyfloyd: That's what it looks like on Android [21:23:35] coreyfloyd: What do you mean by "current IA"? [21:23:36] Deskana: ok thanks - yeah can we have design update the card to get it up to date? [21:23:44] coreyfloyd: Yes, I'll pass that on to them. [21:23:47] coreyfloyd: Thanks! [21:23:48] Deskana: Information Architecture [21:24:16] Deskana: or Information contained on the screen… [21:26:05] Deskana patriotic testing material, eh? [21:36:31] (03CR) 10BearND: "Looks very good already. The gradient makes a big difference." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191430 (https://phabricator.wikimedia.org/T86242) (owner: 10Dbrant) [21:46:00] 3Wikipedia-App-Android-App: Limit the filesystem cache size of Picasso library. - https://phabricator.wikimedia.org/T89834#1048173 (10bearND) Looks like this should be easy: http://stackoverflow.com/questions/20090265/android-picasso-configure-lrucache-size [21:47:33] (03CR) 10MaxSem: "Note that this does not change the default for sidebar links - is it worth changing too?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190670 (https://phabricator.wikimedia.org/T88270) (owner: 10Florianschmidtwelzow) [21:52:17] bgerstle_: Partially, yes. ;-) [21:54:05] coreyfloyd: have a sec for quick hangout? [21:54:18] yeah [21:58:56] brion: you around? [21:59:13] dr0ptp4kt: about to pop into another brief meeting :D [21:59:15] what can i do for ya [21:59:35] brion: was hoping to talk code signing with you and bgerstle_ [21:59:49] ah fun times [21:59:56] i should be free in 20 mins [22:00:19] brion: how's tomorrow looking? [22:00:42] tomorrow’s good too [22:00:54] anytime morning would be fine [22:01:20] dr0ptp4kt: send me a calendar invite :) [22:01:36] brion: will do, thx [22:01:41] coreyfloyd: room conflict. need a minute to figure it out [22:01:51] brion: you gonna be here or remote? [22:01:57] flyingclimber: ok [22:01:58] dr0ptp4kt: in the office [22:02:03] brion: sweet, thx [22:02:08] so i can transfer stuff to you on thumb drive if needed [22:06:06] 3Wikipedia-App-Android-App: Limit the filesystem cache size of Picasso library. - https://phabricator.wikimedia.org/T89834#1048228 (10bearND) Oh wait. The above link is just for RAM cache. To limit disk usage: https://github.com/square/picasso/issues/278 http://stackoverflow.com/questions/18944773/how-to-imple... [22:08:38] (03CR) 10Florianschmidtwelzow: "@MaxSem: If i understand the code correctly, the link in the sidebar (for new users) will be SpecialPage::getTitleFor( 'Watchlist' ) -> "/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190670 (https://phabricator.wikimedia.org/T88270) (owner: 10Florianschmidtwelzow) [22:12:28] (03CR) 10MaxSem: [C: 04-1] "Just checked: with all user_preferences nuked, it defaults to a-z due to SkinMinerva::getPersonalTools()." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190670 (https://phabricator.wikimedia.org/T88270) (owner: 10Florianschmidtwelzow) [22:32:42] (03PS12) 10Bmansurov: Move over WikiGrok front end code from Mobile Frontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 [22:44:21] (03PS13) 10Bmansurov: Move over WikiGrok front end code from Mobile Frontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 [22:46:41] (03CR) 10Bmansurov: [C: 032] Don't ask for leave, if the content hasn't changed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191384 (owner: 10Florianschmidtwelzow) [22:47:58] (03Merged) 10jenkins-bot: Don't ask for leave, if the content hasn't changed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191384 (owner: 10Florianschmidtwelzow) [22:49:24] (03CR) 10Dr0ptp4kt: "About to resubmit. See question." (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191367 (owner: 10Dr0ptp4kt) [22:50:11] (03PS2) 10Dr0ptp4kt: Event logging for suggested pages [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191367 [23:30:25] bearND: around? [23:30:37] dr0ptp4kt: yes, sir [23:30:49] bearND: able to get on video for 10-15 minutes? [23:30:58] yes [23:31:09] bearND: to the batcave [23:31:21] ok, cya [23:46:38] (03CR) 10MaxSem: Collections list collections show image (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190801 (owner: 10Jhernandez) [23:49:10] Deskana: testflight build cut [23:52:35] mhurd: \o/