[00:02:16] bearND: connection locked up, but anyhow...we'll see what the feedback is :) [00:03:37] dr0ptp4kt: cool. [00:13:20] yurikR: check your inbox [00:24:03] (03CR) 10Mhurd: "Replied to comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 (owner: 10Mhurd) [00:24:10] 3Wikipedia-App-iOS-App: Sometimes images don't show in image viewer - https://phabricator.wikimedia.org/T89914#1048618 (10dr0ptp4kt) 3NEW a:3BGerstle-WMF [00:24:40] goodnight all! [00:25:57] 3Wikipedia-App-iOS-App: Allow pinch zooming even when image in image viewer is smallish - https://phabricator.wikimedia.org/T89915#1048634 (10dr0ptp4kt) 3NEW a:3BGerstle-WMF [00:36:01] (03CR) 10Mhurd: "One more inline comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 (owner: 10Mhurd) [01:12:43] (03PS2) 10Dbrant: Additional tweaks/fixes for share-a-fact. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191430 (https://phabricator.wikimedia.org/T86242) [01:24:53] Hi MaxSem bmansurov... we just deployed (finally) a change to wmf-config that eliminates extra round background trips on mobile when CentralNotice serves banners.... Everything looks great, but just thought I'd let u know... [01:25:16] weeeee [01:25:18] AndyRussG: cool, thanks [01:25:42] \o/ [01:26:19] (See https://en.m.wikipedia.org/wiki/Main_Page?country=IL with network tab and a mobile UA) [01:49:52] 3Wikipedia-App-iOS-App: Gifs binaries are not being routed to the data store properly (causes temporary blank screens in gallery) - https://phabricator.wikimedia.org/T89921#1048801 (10Mhurd) [02:09:42] (03PS1) 10Fjalapeno: (WIP) Add Search Suggestions to web view [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191527 [03:13:56] (03CR) 10Bgerstle: "responding to dictionary copy comment" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191367 (owner: 10Dr0ptp4kt) [03:22:03] (03PS1) 10Bgerstle: fixes unit testing target [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191534 [03:22:49] (03PS2) 10Bgerstle: fixes unit testing target [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191534 [03:23:25] (03PS3) 10Bgerstle: fixes unit testing target [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191534 [04:02:05] (03PS4) 10Fjalapeno: Implement new refresh saved pages logic and UI. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 [04:51:03] (03PS1) 10Deskana: Add EventLogging for widget taps. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191536 [04:51:48] (03CR) 10BearND: [C: 04-1] "see comments inline" (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191430 (https://phabricator.wikimedia.org/T86242) (owner: 10Dbrant) [04:59:45] (03PS1) 10Deskana: Correct misleading comment in handleIntent method in PageActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191537 [05:01:02] (03PS2) 10Deskana: Add EventLogging for widget taps. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191536 [06:10:51] (03PS1) 10Yurik: Show XFF header to the user in case of missig zero domain [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/191541 [06:38:01] (03CR) 10Florianschmidtwelzow: "It shouldn't :/ I tested it and it worked for me (maybe a caching issue?), if you delete all user options, the link should be "Special:Wat" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190670 (https://phabricator.wikimedia.org/T88270) (owner: 10Florianschmidtwelzow) [06:38:09] (03PS2) 10Florianschmidtwelzow: Change default watchlist from a-z to feed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190670 (https://phabricator.wikimedia.org/T88270) [08:25:11] morning [08:25:19] morning [08:29:43] 3Mobile-Web: Provide open in app link in sidebar on mobile site - https://phabricator.wikimedia.org/T89942#1049183 (10Jaredzimmerman-WMF) 3NEW [08:32:35] 3Mobile-Apps, Mobile-Web: Provide open in app link in sidebar on mobile site - https://phabricator.wikimedia.org/T89942#1049196 (10Jaredzimmerman-WMF) [08:33:40] 3Mobile-Apps, Mobile-Web: Provide open in app link on mobile site - https://phabricator.wikimedia.org/T89942#1049202 (10Jaredzimmerman-WMF) [08:41:37] 3Wikidata, Mobile-Web: Mobile version of Dutch Wikisource doesn't list other language version. - https://phabricator.wikimedia.org/T89566#1049212 (10Lydia_Pintscher) [09:38:57] drowning on email [09:41:09] * prtksxna knows [10:02:44] 3Wikidata, Mobile-Web: Wikidata changes do not propagate to siteinfo api call - https://phabricator.wikimedia.org/T89903#1049309 (10Florian) [10:12:29] yo [10:13:15] omg so many emails [10:29:13] yep [10:29:23] phuedx: i'm flying to london tonight [10:29:43] i'll be there till sunday with my woman, visiting the queen's precious monuments [10:30:05] taking tomo off? [10:42:03] phuedx: yep, exchanged from monday's president day [10:44:49] 3Wikidata, Mobile-Web: Wikidata changes do not propagate to siteinfo api call - https://phabricator.wikimedia.org/T89903#1049369 (10Lydia_Pintscher) p:5High>3Unbreak! [10:47:41] 3Wikidata, Mobile-Web: Wikidata changes do not propagate to siteinfo api call - https://phabricator.wikimedia.org/T89903#1049378 (10hoo) a:5Wikidata-bugs>3hoo Investigating [11:32:53] (03CR) 10Jhernandez: Collections list collections show image (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190801 (owner: 10Jhernandez) [11:54:32] (03PS1) 10Florianschmidtwelzow: Hygiene: Don't assume, that all pages has text extracts [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191578 [12:28:44] (03PS1) 10Florianschmidtwelzow: Hygiene: Use one query to get all page images [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191584 (https://phabricator.wikimedia.org/T89754) [12:38:43] (03CR) 10Florianschmidtwelzow: "I unblock it now, there was no response, but the change makes sense nonetheless :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190831 (owner: 10Florianschmidtwelzow) [12:38:48] (03PS3) 10Florianschmidtwelzow: TWN: Use own message for terms of use link in license warning (editor and talk) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190831 [12:44:16] (03PS4) 10Phuedx: Instrument the widget-click-none WikiGrok action [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191319 [12:54:29] (03CR) 10Jhernandez: "Have a look at https://phabricator.wikimedia.org/T89754 before merging this." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191584 (https://phabricator.wikimedia.org/T89754) (owner: 10Florianschmidtwelzow) [12:58:21] joakino: i've just had my first cup of coffee for the day [12:58:32] brewed it at 12:30 [12:58:40] i'm trying to drop to one cup per day [13:02:15] (03CR) 10Jhernandez: [C: 04-2] "Thanks for the patch Florian but the constructor on CollectionItem relies on the $extract being null for setting the default value to fals" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191578 (owner: 10Florianschmidtwelzow) [13:02:29] phuedx: uuu [13:02:42] ? [13:02:45] drug addict [13:02:47] hehe [13:02:53] i've had 2 already [13:05:56] phuedx: there was a guy i know praising the barn's coffee from berlin as a god gift [13:08:12] massive +1 [13:08:23] joakino: i haven't found a roaster that comes close [13:08:25] i really havent [13:08:33] joakino: re the drug addict thing [13:08:37] this year [13:08:38] that is [13:09:34] january an half of february [13:09:45] i've already brewed my way through 8 bags of coffee [13:10:55] woo [13:11:08] phuedx: that is a lot [13:11:21] 2 of those are 350g [13:11:25] 6 of 'em are 250g [13:11:56] so 2.2 kgs of coffee… [13:13:15] (03CR) 10Florianschmidtwelzow: "> I don't think we particularly need to handle all this, by having value or null, and leveraging constructor defaults we get values and de" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191578 (owner: 10Florianschmidtwelzow) [13:26:02] (03PS2) 10Phuedx: Remove WikiGrok version A [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191358 [13:27:01] (03CR) 10jenkins-bot: [V: 04-1] Remove WikiGrok version A [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191358 (owner: 10Phuedx) [13:28:29] joakino: seeing this in the logs for the extension tests: PHP Warning: call_user_func() expects parameter 1 to be a valid callback, function 'efGatherExtensionSetup' not found or invalid function name in /srv/ssd/jenkins-slave/workspace/mediawiki-extensions-zend/src/includes/Setup.php on line 671 [13:29:08] phuedx: wtf is that xd [13:31:31] phuedx: can you open a phab bug? [13:33:50] sure thank [13:33:52] *thang [13:55:25] joakino: https://phabricator.wikimedia.org/T89954#1049667 [13:57:12] the joys of running two different mwv boxes [13:57:14] … [14:17:53] (03CR) 10Dbrant: Additional tweaks/fixes for share-a-fact. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191430 (https://phabricator.wikimedia.org/T86242) (owner: 10Dbrant) [14:18:04] (03PS3) 10Dbrant: Additional tweaks/fixes for share-a-fact. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191430 (https://phabricator.wikimedia.org/T86242) [14:21:12] (03CR) 10jenkins-bot: [V: 04-1] Additional tweaks/fixes for share-a-fact. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191430 (https://phabricator.wikimedia.org/T86242) (owner: 10Dbrant) [14:21:45] (03PS1) 10Jhernandez: Style: Adjust margin for collections list items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191597 [14:21:47] (03PS1) 10Jhernandez: Hygiene: Collection doesn't need to use stores [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191598 [14:21:50] (03PS1) 10Jhernandez: Split the Collection model and add JSON serialization [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191599 [14:21:51] (03PS1) 10Jhernandez: Protect storage json pages for collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191600 [14:21:53] (03PS1) 10Jhernandez: Retrieve collections list from json store [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191601 [14:28:33] 3§ Wikidata-Sprint-2015-02-03, Wikidata, Mobile-Web: Wikidata changes do not propagate to siteinfo api call - https://phabricator.wikimedia.org/T89903#1049716 (10JanZerebecki) [14:41:49] (03PS4) 10Dbrant: Additional tweaks/fixes for share-a-fact. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191430 (https://phabricator.wikimedia.org/T86242) [14:45:28] (03CR) 10Phuedx: [C: 04-1] Move over WikiGrok front end code from Mobile Frontend (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [15:00:36] (03CR) 10Dbrant: [C: 032] Correct misleading comment in handleIntent method in PageActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191537 (owner: 10Deskana) [15:05:43] (03CR) 10Dbrant: [C: 032] "wfm!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191536 (owner: 10Deskana) [15:08:26] (03CR) 10Phuedx: "Derp. I forgot about the programmatic creation of the ext.wikigrok.loggingSchema module." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [15:24:36] (03PS3) 10Phuedx: Remove WikiGrok version A [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191358 [15:29:20] 3MediaWiki-extensions-WikibaseRepository, Wikidata, Mobile-Web: Image thumbnail urls should be included where applicable in wikidata API response for commonsMedia - https://phabricator.wikimedia.org/T76827#1049829 (10Lydia_Pintscher) I am going to close this assuming previous comments address the usecase. [15:29:29] 3MediaWiki-extensions-WikibaseRepository, Wikidata, Mobile-Web: Image thumbnail urls should be included where applicable in wikidata API response for commonsMedia - https://phabricator.wikimedia.org/T76827#1049831 (10Lydia_Pintscher) 5Open>3declined a:3Lydia_Pintscher [15:30:01] (03CR) 10Phuedx: Remove WikiGrok version A (035 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191358 (owner: 10Phuedx) [15:37:24] 3Wikipedia-App-Android-App: Text sometimes hard to read in images created by new Android sharing feature - https://phabricator.wikimedia.org/T86240#1049873 (10Dbrant) https://gerrit.wikimedia.org/r/191430 [15:52:08] (03PS11) 10Dbrant: Video playback in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) [15:54:45] (03PS5) 10Dbrant: Additional tweaks/fixes for share-a-fact. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191430 (https://phabricator.wikimedia.org/T86242) [15:57:30] (03CR) 10Legoktm: [C: 032] Update ApiResult handling for mediawiki/core change I7b37295e [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie) [16:00:09] (03Merged) 10jenkins-bot: Update ApiResult handling for mediawiki/core change I7b37295e [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie) [16:14:15] (03PS12) 10Dbrant: Video playback in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) [16:17:55] (03PS4) 10Bgerstle: fixes unit testing target [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191534 [16:25:49] (03PS1) 10Dbrant: In Gallery, provide a white background for images with transparency. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191628 (https://phabricator.wikimedia.org/T87250) [16:37:47] 3§ Wikidata-Sprint-2015-02-03, Wikidata, Mobile-Web: Wikidata changes do not propagate to siteinfo api call - https://phabricator.wikimedia.org/T89903#1050010 (10daniel) 5Open>3Resolved fixed in head [16:42:17] 3§ Wikidata-Sprint-2015-02-03, Wikidata, Mobile-Web: Wikidata changes do not propagate to the local langlinks table, according to props=langlinks in the API - https://phabricator.wikimedia.org/T89903#1050029 (10daniel) [16:44:26] (03CR) 10Bgerstle: "I also found this while looking through UIScrollView documentation: UIScrollView.keyboardDismissMode, but it's iOS 7 only :-/. we should p" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190960 (owner: 10Rahdev) [16:52:50] (03CR) 10BearND: [C: 032] Additional tweaks/fixes for share-a-fact. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191430 (https://phabricator.wikimedia.org/T86242) (owner: 10Dbrant) [16:56:50] 3Wikipedia-App-Android-App: Faces not aligned properly in shared images. - https://phabricator.wikimedia.org/T86242#1050091 (10Dbrant) 5Open>3Resolved a:3Dbrant [16:57:10] 3Wikipedia-App-Android-App: Text sometimes hard to read in images created by new Android sharing feature - https://phabricator.wikimedia.org/T86240#1050093 (10Dbrant) 5Open>3Resolved a:3Dbrant [17:05:51] bearND: did you mean to add "Deskana" and not "Deshank"? [17:06:06] dbrant: yes, oops [17:06:38] dbrant: updated [17:07:07] bearND: cool; the API patch is still not deployed yet, but this patch should be ready to go regardless. [17:07:08] I wanted to see if Deskana could play some videos. I still can't on my 5.0 device [17:07:15] sure [17:07:33] dbrant: what api patch? [17:07:36] Maybe Deshank could also help us :-p [17:08:06] bearND: the one that I submitted to fix fetching the thumbnail URL for videos. [17:08:06] I've got to go for 15 minutes but I can test when I get back, if you point me to what you want me to test :-) [17:08:26] Deskana: https://gerrit.wikimedia.org/r/184416 [17:09:28] dbrant: Deskana: probably should hold off merging this until the api patch is deployed. I'd hate to announce that we have video playback but when it doesn't work for most [17:10:15] technically the API patch wouldn't block the actual playback of videos; just the fetching of the thumbnail that's overlaid on top of the video while it loads. [17:10:58] dbrant: so, you'd still get the error "video could not be played"? [17:11:51] bearND: right; this wouldn't fix the apparent issues that you're seeing. [17:12:13] (03CR) 10Dr0ptp4kt: "Will update to [dict copy]" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191367 (owner: 10Dr0ptp4kt) [17:13:30] bearND: actually, can you send me a logcat dump (unfiltered) when trying to play a video? [17:13:42] dbrant: sure [17:22:22] phuedx is it time for a cup of coffee? [17:22:34] ? [17:23:14] I'm gonna say "yes". [17:23:42] i've had one today [17:23:47] i'm sticking to it [17:24:16] I'm goign to have my first right now. [17:25:13] kristenlans how's weather in beantown today? [17:25:29] if it's cold here i can only imagine [17:25:29] (03CR) 10Robmoen: [C: 032] Style: Adjust margin for collections list items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191597 (owner: 10Jhernandez) [17:26:21] bgerstle: Warm! It actaully broke out of the teens! [17:26:27] haha [17:26:33] Smowed again this morning, but it's sunny. [17:26:42] i was looking at chicago where some of my friends live, and it's single digits [17:26:53] days like this i'm glad to be this far south [17:27:01] every other day of the year.. not as much [17:27:20] yeah chicago gets so bitterly cold. I'm super jelly of the south right now. [17:27:30] but i can empathize with the "20-30 is warm" feeling [17:27:45] i always forget that you folks are talking in fahrenheit [17:27:48] i only lived in NY for one mild winter, but there were some nights that were cold [17:28:14] phuedx anyone who doesn't is a communist and needs to have their freedom recalibrated [17:28:20] reinfused? [17:28:27] re-something [17:28:32] bgerstle: lol [17:29:40] hahaha [17:32:56] phuedx: Yeah, me too. [17:33:03] dbrant: Is there an article you know of with a video that I can try? [17:33:11] dbrant: I'm building an APK with that patch now. [17:33:54] Deskana: [[Jellyfish]], at the bottom of the lead section [17:35:01] dbrant, bearND: Yep, it works. The video autoplayed when I tapped on it. [17:35:30] Deskana: and your device is 5.0? [17:35:47] 5.0.1 [17:36:17] Deskana: try [[12 Angry Men]], click on the trailer [17:36:18] dbrant: Deskana: hmm, [[Jellyfish]] doesn't work for me either (also got 5.0.1) [17:36:48] (03PS3) 10Dr0ptp4kt: Event logging for suggested pages [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191367 [17:37:00] bgerstle: good morning, and ^ [17:37:12] dbrant, bearND: Also works for me. [17:37:31] bgerstle: that is, would you please verify that's what you had in mind? [17:37:47] dr0ptp4kt looks like it +1 [17:37:53] bgerstle: thx [17:38:10] the only question i have is if we return nil from init, will that fail silently as we expect? and do we want logging for this to fail silently? [17:38:33] i.e. the rest of the logging machinery won't blow up if it gets nil [17:38:39] (03CR) 10Deskana: [C: 031] "It works on my Nexus 5, Android 5.0.1." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) (owner: 10Dbrant) [17:39:03] dbrant: One note though, it's not always obvious that what the user is tapping on is a video. I was kind of taken aback by the sound and volume. [17:39:11] (03CR) 10Robmoen: [C: 032] Collections list collections show image [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190801 (owner: 10Jhernandez) [17:39:23] dbrant: We may want to consider muting the sound, and indicating that to the user somehow [17:39:53] Deskana: yeah, I recall someone suggesting to mute the sound by default. Should be simple to do [17:40:18] The alternative is to superimpose a play icon over videos in the web view [17:40:29] That also would indicate to the user that it's a video with sound [17:40:33] bgerstle: okay if i go ahead and implement init and initWithScheme:(NSString*)schema version:(int)revision in this subclass to both return nil? [17:40:43] I'm actually unsure which I prefer [17:40:44] bgerstle: i can add NSLogs to all three [17:40:51] (03CR) 10Robmoen: [C: 032] Hygiene: Collection doesn't need to use stores [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191598 (owner: 10Jhernandez) [17:41:37] bgerstle: i'd rather have it fail silently than make the app go boom in this case. can you live with that? [17:41:45] dr0ptp4kt i'm not familiar enough w/ our client-side logging impl to say yay or nay w/ confidence. i'm just raising general concerns [17:42:02] dr0ptp4kt actually, what do you think of doing both? [17:42:14] i.e. assert (so build breaks immediately in debug mode, alerting devs) [17:42:32] then return nil [17:42:46] bgerstle: oh right, you made it so the asserts don't crash prod, right? [17:42:49] and the main logging mechanism can still handle nil gracefully [17:42:53] dr0ptp4kt correct [17:43:00] bgerstle: okay, easy enough in that case [17:46:40] dr0ptp4kt: just a heads-up that there was another translation patched merged this morning. If you have any automated tests in the iOS project that tests translations you may want to run them. [17:47:09] (03CR) 10Jhernandez: [C: 04-1] "Oh! Didn't know about that. Can you handle non existence then and push a null into the array?" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191578 (owner: 10Florianschmidtwelzow) [17:47:30] bearND: thx, we probably need to write some tests like you've done [17:48:18] dr0ptp4kt: also, feel free to chime in to the email thread about stopping automatic L10n-bot +2 [17:49:38] JonKatz: ping pong [17:49:50] Will you be joining standup? [17:49:53] bearND: yeah, been meaning to do that [17:50:00] (03PS2) 10Jhernandez: Protect storage json pages for collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191600 [17:50:12] rmoen shit, have been sitting in meeting room for 5 minutes now [17:50:20] (03PS2) 10Jhernandez: Retrieve collections list from json store [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191601 [17:50:37] JonKatz: haha [17:50:39] JonKatz: are you in the wrong hangout ? [17:50:48] Should we start? [17:50:48] JonKatz: https://plus.google.com/hangouts/_/wikimedia.org/collections?authuser=1 [17:57:24] dr0ptp4kt, around? [17:58:47] MaxSem, dr0ptp4kt, could either one of you +1 or +2 https://gerrit.wikimedia.org/r/#/c/191541/ -- would like to depl it asap [17:59:21] ehhhhhhh [17:59:39] versial [17:59:46] *contro [18:00:08] also, there was a function for xff [18:00:10] 1 sec [18:01:39] (03CR) 10Dr0ptp4kt: "Unsubscribing from this, Max is on it." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/191541 (owner: 10Yurik) [18:02:05] MaxSem, i don't want to parse xff - just dump it as is [18:02:28] this is a rare debug msg [18:03:42] joakino: https://gerrit.wikimedia.org/r/#/c/191578/ do you have error reporting activated in your php.ini? maybe you should activate _all_ errors (including notices and other stuff) :) [18:04:04] FlorianSW: i should [18:04:08] i'm in a meeting [18:04:15] :) [18:04:26] FlorianSW: can you send me an email please? @ jhernandez@wikimedia.org [18:04:45] bath time [18:05:44] (03CR) 10BearND: [C: 032] In Gallery, provide a white background for images with transparency. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191628 (https://phabricator.wikimedia.org/T87250) (owner: 10Dbrant) [18:06:19] joakino: sure [18:08:42] jenkins is so dead [18:11:01] (03CR) 10Bmansurov: [C: 032] Instrument the widget-click-none WikiGrok action [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191319 (owner: 10Phuedx) [18:13:00] (03PS2) 10Florianschmidtwelzow: Hygiene: Don't assume, that all pages has text extracts [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191578 [18:14:00] bgerstle: did you see https://phabricator.wikimedia.org/T89921 [18:14:07] no [18:14:39] mhurd hrm [18:14:42] bgerstle: i think it’s the reason some gallery images appear black for a second (unrelated to the ios 6 rotate issue) [18:14:59] they would only appear "black" if the images aren't "cached" [18:15:00] bgerstle: go to the fish article and tap on the animated gif image from the screenshot [18:15:13] k, i'll have a look in a sec [18:15:14] (03CR) 10MaxSem: [C: 031] "Never mind, I don't have any questions anymore." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/191541 (owner: 10Yurik) [18:15:23] made some good progress on the custom collection view layout [18:15:29] MaxSem, lol :)) [18:15:39] MaxSem, you had before? [18:15:45] (03CR) 10Yurik: [C: 032] Show XFF header to the user in case of missig zero domain [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/191541 (owner: 10Yurik) [18:15:49] bgerstle: true, but the web view retrieves the gif so it should have been cached, but isn’t as u can see from the screenshot [18:16:01] bgerstle: that’s great! [18:16:14] yeah, I thought there was some function to remove internal ips from xff [18:16:29] (03PS1) 10Yurik: Show XFF header to the user in case of missig zero domain [extensions/ZeroBanner] (wmf/1.25wmf17) - 10https://gerrit.wikimedia.org/r/191656 [18:16:43] brion: do you happen to have dbrant's project tango device ? [18:16:43] (03PS1) 10Yurik: Show XFF header to the user in case of missig zero domain [extensions/ZeroBanner] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/191657 [18:16:53] bgerstle: URLCache.m appears to be set to intercept gifs though, and it used to, so not sure what happened [18:17:09] tfinc: i have the one you lent me [18:17:11] MaxSem, there is some code in getIp() afaik [18:17:16] * bgerstle shrug [18:17:29] then dbrant i'm not sure where the one your brought back is [18:17:34] bgerstle: ya it’s weird [18:18:06] :( [18:18:16] tfinc dbrant: i’m not actively working with this one so let me know if you need it [18:18:20] i’ve got it right here :) [18:18:34] brion: i will but i also want to know where the other device went [18:18:42] yeah that’d be nice to not lose :( [18:21:50] dbrant: the question then come back you as to where it is [18:24:34] tfinc: brion: i'm quite certain that the last time i handled it was when I put it in the drawer with the rest of the devices. [18:24:42] tfinc: (i didn't bring it in the original box, since i would have had to check an extra bag. i just brought the device + charger, and put it in the drawer) [18:25:46] (03PS4) 10Dr0ptp4kt: Event logging for suggested pages [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191367 [18:25:54] ^ bgerstle mhurd pls review [18:26:02] dr0ptp4kt: k [18:28:56] dbrant: found it, it was sitting under a bunch of phones [18:29:29] :D [18:29:29] tfinc: alright! do you, in fact, need the box though? [18:30:12] (03CR) 10Mhurd: [C: 031] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191367 (owner: 10Dr0ptp4kt) [18:31:13] (03CR) 10Bmansurov: [C: 04-1] Remove WikiGrok version A (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191358 (owner: 10Phuedx) [18:31:21] dbrant: no [18:31:34] bearND: hey adam said there were incoming translations but i don’t see any... [18:32:35] mhurd: they were already merged this morning [18:32:56] bearND: oh they’re still being auto-merged? [18:33:03] mhurd: yes [18:33:11] bearND: gotcha [18:34:43] (03CR) 10Bmansurov: "Also, wikigrok version c drawer is inserted to the page twice, one on top of the other." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191358 (owner: 10Phuedx) [18:34:51] (03CR) 10Kaldari: [C: 04-1] Move over WikiGrok front end code from Mobile Frontend (033 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [18:37:34] (03CR) 10jenkins-bot: [V: 04-1] Additional tweaks/fixes for share-a-fact. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191430 (https://phabricator.wikimedia.org/T86242) (owner: 10Dbrant) [18:39:36] (03Merged) 10jenkins-bot: In Gallery, provide a white background for images with transparency. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191628 (https://phabricator.wikimedia.org/T87250) (owner: 10Dbrant) [18:40:31] 3Wikipedia-App-Android-App: Consider background for images with transparency - https://phabricator.wikimedia.org/T87250#1050460 (10Dbrant) 5Open>3Resolved a:3Dbrant [18:41:14] (03CR) 10Dbrant: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191430 (https://phabricator.wikimedia.org/T86242) (owner: 10Dbrant) [18:41:21] mhurd: not sure if you saw my fix to the directory erasing issue… https://gerrit.wikimedia.org/r/#/c/191359/ [18:41:21] (03CR) 10Bmansurov: Move over WikiGrok front end code from Mobile Frontend (033 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [18:41:23] (03PS14) 10Bmansurov: Move over WikiGrok front end code from Mobile Frontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 [18:42:04] 3Wikipedia-App-Android-App: Consider background for images with transparency - https://phabricator.wikimedia.org/T87250#1050467 (10bearND) 5Resolved>3Open The above patch only addresses the gallery image but not the lead image. [18:43:09] coreyfloyd: oh awesome! will CR all the things [18:43:19] dunka [18:44:59] mhurd: also when you get done with that, I have the first UI up for the read more. I am using your code to display the suggestions. After you get a look, want to sync up so we can begin to figure out how to finish it up? [18:46:44] coreyfloyd: sounds good! [18:54:42] 3Wikipedia-App-iOS-App: Gifs binaries are not being routed to the data store properly (causes temporary blank screens in gallery) - https://phabricator.wikimedia.org/T89921#1050540 (10Mhurd) On the "Fish" article, it looks like "storeCachedResponse:forRequest:" is for some reason not getting called when the web... [18:55:56] bgerstle: ^ i added a comment to the phab task for the gif issue… [18:56:21] (03Merged) 10jenkins-bot: Style: Adjust margin for collections list items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191597 (owner: 10Jhernandez) [18:56:30] woo jerkins!! [18:58:49] (03CR) 10Dbrant: [C: 032] Additional tweaks/fixes for share-a-fact. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191430 (https://phabricator.wikimedia.org/T86242) (owner: 10Dbrant) [19:00:56] kaldari: you might be interested in https://gerrit.wikimedia.org/r/#/c/190826/ [19:03:37] (03CR) 10jenkins-bot: [V: 04-1] Collections list collections show image [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190801 (owner: 10Jhernandez) [19:04:44] (03Merged) 10jenkins-bot: Hygiene: Collection doesn't need to use stores [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191598 (owner: 10Jhernandez) [19:09:58] (03CR) 10Kaldari: "This works, but I would favor a more comprehensive and less fragile solution. I think we should put all of the notice divs (#centralNotice" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190826 (owner: 10Bmansurov) [19:10:18] (03PS1) 10Dbrant: Give lead image a white background, in case the image has transparency. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191667 (https://phabricator.wikimedia.org/T87250) [19:10:19] bmansurov: Let me know what you think about my comments. I didn’t -1. [19:10:57] (03CR) 10Bmansurov: [C: 04-2] "I agree. That makes more sense." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190826 (owner: 10Bmansurov) [19:11:22] kaldari: Yes, let's do what you suggested [19:11:49] (03Abandoned) 10Bmansurov: Add border to local notice [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190826 (owner: 10Bmansurov) [19:16:15] (03Merged) 10jenkins-bot: Show XFF header to the user in case of missig zero domain [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/191541 (owner: 10Yurik) [19:17:21] (03CR) 10Bgerstle: "just one small comment about NSAssert usage. up to you if you'd rather fix now or merge as-is" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191367 (owner: 10Dr0ptp4kt) [19:19:01] mhurd: would you have a minute to try some image gallery changes on iOS 6? [19:19:44] i have a meeting in a couple minutes. i can right after though [19:19:49] bgerstle: ^ [19:20:06] dr0ptp4kt: mhurd FYI i put up a small patch yesterday to fix unit tests: https://gerrit.wikimedia.org/r/#/c/191534/ [19:20:07] (03CR) 10Dr0ptp4kt: "Will resubmit shortly." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191367 (owner: 10Dr0ptp4kt) [19:20:18] (03CR) 10Phuedx: [C: 031] "The change looks good but I haven't tested all of the special pages yet." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190841 (https://phabricator.wikimedia.org/T87614) (owner: 10Florianschmidtwelzow) [19:21:52] 3Wikipedia-App-Android-App: ShareAFact not usable again after rotating device - https://phabricator.wikimedia.org/T89979#1050716 (10bearND) 3NEW [19:21:55] (03PS5) 10Dr0ptp4kt: Event logging for suggested pages [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191367 [19:22:06] ^ bgerstle, you then mhurd [19:22:12] bgerstle: will look at the unit test patch [19:23:38] ok [19:25:34] MaxSem: can you help me with a vagrant question? [19:26:16] coreyfloyd: hey i found a data layer issue when reviewing your latest at https://gerrit.wikimedia.org/r/#/c/191359 [19:26:36] coreyfloyd: i have a meeting, then a hangout w brian, can you and i chat after that? [19:27:38] coreyfloyd: *it’s not caused by your patch* [19:34:09] kristenlans: http://etherpad.wikimedia.org/p/AppsPhabelloMigration [19:36:57] kristenlans: fyi i've arranged a meeting with kaity to review the beta styles cards in sprint 40 [19:37:04] tomo at 4 pm gmt [19:37:30] mhurd: sure [19:39:38] nice, thx phuedx! [19:42:42] (03PS6) 10Robmoen: Collections list collections show image [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190801 (owner: 10Jhernandez) [19:43:01] (03CR) 10Robmoen: [C: 032] Collections list collections show image [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190801 (owner: 10Jhernandez) [19:44:57] (03Merged) 10jenkins-bot: Collections list collections show image [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190801 (owner: 10Jhernandez) [19:47:03] 3Wikipedia-App-Android-App: Epic: Onboarding, both generally and for Tweet A Fact - https://phabricator.wikimedia.org/T89985#1050863 (10Deskana) 3NEW [19:48:42] 3Wikipedia-App-Android-App: [Spike ?hr] Investigate onboarding libraries to find one that's suitable for our purposes - https://phabricator.wikimedia.org/T89987#1050887 (10Deskana) 3NEW [19:49:23] 3Wikipedia-App-Android-App: As an engaged reader, I'd like to know that I can share cards with interesting facts on. - https://phabricator.wikimedia.org/T89988#1050896 (10Deskana) 3NEW [19:49:53] 3Wikipedia-App-Android-App: As a product owner, I'd like to know how well the Tweet A Fact onboarding did at exposing users to the feature - https://phabricator.wikimedia.org/T89989#1050905 (10Deskana) 3NEW [19:51:59] 3Wikipedia-App-Android-App: [Spike ?hr] Investigate onboarding libraries to find one that's suitable for our purposes - https://phabricator.wikimedia.org/T89987#1050942 (10Deskana) [19:52:26] 3Wikipedia-App-Android-App: [Spike ?hr] Investigate onboarding libraries to find one that's suitable for our purposes - https://phabricator.wikimedia.org/T89987#1050887 (10Deskana) [19:52:45] 3Wikipedia-App-Android-App: [Spike ?hr] Investigate onboarding libraries to find one that's suitable for our purposes - https://phabricator.wikimedia.org/T89987#1050887 (10Deskana) [19:54:37] dr0ptp4kt, mhurd: You guys going for lunch soon? [19:54:47] dr0ptp4kt, mhurd: I have an interview at 1pm but would love to grab lunch. [19:54:48] ya 10 min? [19:56:14] mhurd: Yeah! [20:00:04] Deskana: https://phabricator.wikimedia.org/T821 [20:01:38] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] "Some of the other data store things are broken, but this takes care of the majority of stuff." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191534 (owner: 10Bgerstle) [20:02:06] 3Wikipedia-App-iOS-App: Gifs binaries are not being routed to the data store properly (causes temporary blank screens in gallery) - https://phabricator.wikimedia.org/T89921#1050972 (10BGerstle-WMF) @Mhurd that method is usually not called because either the response isn't meant to be cached (due to NSURLCachePol... [20:03:43] 3Wikipedia-App-iOS-App: Gifs binaries are not being routed to the data store properly (causes temporary blank screens in gallery) - https://phabricator.wikimedia.org/T89921#1050974 (10BGerstle-WMF) This is the same problem I ran into w/ trying to cache higher-res png & jpeg images. [20:08:39] (03PS4) 10Phuedx: Remove WikiGrok version A [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191358 [20:09:38] (03CR) 10jenkins-bot: [V: 04-1] Remove WikiGrok version A [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191358 (owner: 10Phuedx) [20:16:23] (03CR) 10Bmansurov: Remove WikiGrok version A (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191358 (owner: 10Phuedx) [20:16:47] (03PS5) 10Phuedx: Remove WikiGrok version A [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191358 [20:16:54] bmansurov: on it – can't seem to lint locally [20:17:09] also, will look into the double insert thing tomo [20:17:11] mhurd still in a meeting? [20:17:18] phuedx: sounds good [20:17:36] g'night folks [20:17:42] see ya [20:20:15] night phuedx [20:25:29] (03PS1) 10Bartosz Dziewoński: Hide MediaWiki's clickable link for section headers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191682 [20:25:36] (03CR) 10jenkins-bot: [V: 04-1] Hide MediaWiki's clickable link for section headers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191682 (owner: 10Bartosz Dziewoński) [20:26:12] bah [20:26:43] can anyone merge that now-ish, after i fix it? the MF test is blocking the merge in core [20:29:42] (03PS2) 10Bartosz Dziewoński: Hide MediaWiki's clickable link for section headers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191682 [20:30:15] MaxSem: can you? ^ [20:34:10] mhurd dr0ptp4kt coreyfloyd stepping out for a bit [20:51:04] coreyfloyd: quick hangout? [20:51:20] sure [20:52:05] mhurd: ^ [20:58:47] (03PS3) 10Dr0ptp4kt: Don't include article snippet in "Share as text" option [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190637 (https://phabricator.wikimedia.org/T89541) (owner: 10Deskana) [20:59:58] 3Wikipedia-App-Android-App: ShareAFact not usable again after rotating device - https://phabricator.wikimedia.org/T89979#1051179 (10Dbrant) We're leaking something somewhere.... I'm investigating. [21:00:39] (03CR) 10Polybuildr: [C: 031] Hide MediaWiki's clickable link for section headers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191682 (owner: 10Bartosz Dziewoński) [21:05:11] aaaanyone? i don't want to self-merge (especially in your repos), i don't want to break your tests by merging the core change, either [21:05:30] (03CR) 10MaxSem: [C: 032] Hide MediaWiki's clickable link for section headers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191682 (owner: 10Bartosz Dziewoński) [21:05:40] <3 MaxSem [21:06:05] MatmaRex, also du]h on that fixme:P [21:06:17] (03CR) 10BearND: [C: 032] Give lead image a white background, in case the image has transparency. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191667 (https://phabricator.wikimedia.org/T87250) (owner: 10Dbrant) [21:06:31] 3Wikipedia-App-Android-App: Consider background for images with transparency - https://phabricator.wikimedia.org/T87250#1051203 (10bearND) 5Open>3Resolved [21:06:33] MaxSem: i'd have fixed it, but who knows if MF doesn't depend on it not being removed now [21:07:23] (03Merged) 10jenkins-bot: Hide MediaWiki's clickable link for section headers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191682 (owner: 10Bartosz Dziewoński) [21:07:28] wait. MatmaRex, why are oyu creating another resource just for it? [21:08:28] MaxSem: i have this quiet hope that y'all will realize that this is an awesome feature, and fill that file with real pretty CSS rather than just display:none; ;) [21:08:45] pfft [21:08:57] (also, i didn't know where to put it :P) [21:09:26] yeh, we can reshuffle it latyer [21:09:57] (03Merged) 10jenkins-bot: Give lead image a white background, in case the image has transparency. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191667 (https://phabricator.wikimedia.org/T87250) (owner: 10Dbrant) [21:12:35] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191758 [21:13:31] (03PS1) 10Bgerstle: fix Xcodeproj code signing [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191763 [21:18:56] dbrant: ok for me to make a beta? [21:20:00] bearND: I might have a fix for the share / screen rotate bug, if you have time to review [21:22:15] Deskana have you had a chance to look at the iOS image gallery in TF yet? [21:23:19] mhurd: are you and adam using instruments to explore the performance bottle necks? [21:24:09] coreyfloyd: we were just doing manual method level benchmarking. quick hangout to show me what you use? [21:24:34] mhurd: sure… [21:25:14] dbrant: if it doesn't affect anything else then i don't really care too much about that since it's alpha only right now [21:25:33] unless it's quick of course [21:25:42] bearND: ah, that's true, it's only alpha. in that case, go for it! [21:26:07] dbrant: ok, getting ready for beta /cc Deskana [21:26:19] (03CR) 10BearND: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191758 (owner: 10BearND) [21:28:19] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191758 (owner: 10BearND) [21:28:53] (03PS1) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191768 [21:29:12] (03CR) 10BearND: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191768 (owner: 10BearND) [21:29:39] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191768 (owner: 10BearND) [21:31:17] bearND: see my PMs? [21:31:36] dbrant: ah, thanks for the head's up [21:37:19] bgerstle: I'm a bit backed up with meetings/interviews atm, so I'll get back to you soon [21:37:28] k [21:39:15] dr0ptp4kt mhurd brion so i can build archives, but when i try submit or validate them i get a warning; "No eligible software found, make sure it is owned by the developer organization." [21:39:21] or something like that [21:39:40] i've tried exporting it and using Application Loader to no avail [21:39:59] interesting :D [21:40:19] bgerstle: are you submitting as bgerstle@wikimedia or as brion@wikimedia? [21:40:27] you might have to be logged in as the team agent etc [21:40:34] perhaps [21:40:44] but i would've thought admin would be enough [21:40:58] let me try something really quick [21:41:44] also i think you have to do the ‘add new version’ dance first still [21:41:53] hrm [21:43:47] (03CR) 10Kaldari: [C: 032] Move over WikiGrok front end code from Mobile Frontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [21:44:04] (03CR) 10Kaldari: [C: 032] Remove WikiGrok related stuff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191224 (owner: 10Bmansurov) [21:44:06] brion it's not even validating successfully though [21:44:17] and the online instructions don't mention creating a new version prior to upload for TF [21:44:22] yay\ [21:44:30] hmmm [21:44:37] validation should give you a warning about the qqq.lproj but otherwise be ok [21:44:45] :( [21:44:56] (03Merged) 10jenkins-bot: Move over WikiGrok front end code from Mobile Frontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191225 (owner: 10Bmansurov) [21:46:41] (03CR) 10Robmoen: [C: 032] Hygiene: Don't assume, that all pages has text extracts [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191578 (owner: 10Florianschmidtwelzow) [21:46:46] (03PS3) 10Robmoen: Hygiene: Don't assume, that all pages has text extracts [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191578 (owner: 10Florianschmidtwelzow) [21:47:53] bmansurov: shit, I just realized there should be one more condition for loading WikiGrokUI module: whether or not CentralAuth is installed. [21:48:11] since now it depends on CentralAuth [21:48:15] kaldari: ok let's add it, what should I do? [21:48:21] guess I should file a bug for that :) [21:48:27] ok [21:49:23] bmansurov: we’ll need to make sure the ApiCentralAuthToken class is defined [21:49:57] ok, I don't think you need to file a bug for that, I'll just implement it [21:50:50] (03Merged) 10jenkins-bot: Remove WikiGrok related stuff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191224 (owner: 10Bmansurov) [21:50:57] (03PS1) 10Dbrant: Fix ability to share text selection after screen rotation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191775 (https://phabricator.wikimedia.org/T89979) [21:52:42] bmansurov: created a card for it: https://trello.com/c/vT1HSV1O/25-bug-t90010-wikigrok-ui-should-not-load-if-centralauth-is-not-installed [21:53:27] BTW, welcome back Kaldari :-) [21:53:39] thanks! did I miss anything? [21:54:16] nope ;-) [21:55:01] kaldari sounds like you're up to speed on the wg extension stuff... [21:55:19] 3Wikipedia-App-iOS-App: Gifs binaries are not being routed to the data store properly (causes temporary blank screens in gallery) - https://phabricator.wikimedia.org/T89921#1051463 (10Mhurd) I tried bumping the value from 8MB to 32MB and still no luck. Is there a NSURLCachePolicy change we can make for these lar... [21:55:26] bgerstle: any luck? [21:55:35] I think so. Looks like bmansurov has been hard at work. [21:55:49] kaldari let me know if you have any questiosn about the sprint plan, since you weren't at the kickoff. Hopefully it'spretty strightforward [21:57:00] (03PS28) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [21:57:03] (03CR) 10jenkins-bot: [V: 04-1] Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [21:58:04] (03PS1) 10Bmansurov: Don't enable the UI if CentralAuth is not installed [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191779 (https://phabricator.wikimedia.org/T90010) [21:58:46] bgerstle: ok if i merge https://gerrit.wikimedia.org/r/#/c/191367/ ? [21:59:12] (03PS29) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [21:59:17] bgerstle: i’m free for a bit for ios 6 testing as well [21:59:26] note the lack of WIP [21:59:28] :P [22:00:20] dbrant: Deskana: beta is published \o/ [22:01:02] bearND: awesome [22:01:58] (03PS5) 10Fjalapeno: Implement new refresh saved pages logic and UI. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 [22:02:37] bgerstle: if you’re still having trouble with the login i’ve got to run do some bank stuff so i’ll be offline for a bit, but i’ll check my mail :) [22:04:35] (03PS6) 10Mhurd: Event logging for suggested pages [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191367 (owner: 10Dr0ptp4kt) [22:04:46] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191367 (owner: 10Dr0ptp4kt) [22:09:30] mhurd: ^ patch up… I think I just had the one line removal - I forgot by the time I did it :( [22:12:35] coreyfloyd: hmm still getting an exception when i tap reload button... [22:13:34] coreyfloyd: in “requiredDate:dict:” in MWKDataObject.m line 109 [22:14:05] mhurd: seen that before too… [22:14:20] mhurd: normally deleting the app gets rid of that [22:14:39] mhurd: do you know whay we are purposefully throwing an exception in that method? [22:14:55] coreyfloyd mhurd there's also something that happens on app launch occasionally where we update local app data or something on a background thread [22:15:09] and we start accessing MWKDataStore from the background (even though it's not thread safe) [22:15:17] coreyfloyd: can i send you the SavedPages.plist that cause it? [22:16:26] bgerstle: i think that may be a separate issue [22:16:35] mhurd:sure [22:16:37] probably, but w/ threads, who knows? ;-) [22:16:42] hehe true [22:17:02] mhurd: also - can you just hit "continue" - there is a try block around that exception [22:17:14] coreyfloyd: sent. let me know if saving the same pages causes the same exception when you tap reload... [22:17:25] coreyfloyd: k. just sec... [22:17:26] MaxSem: What is the good place to put helper functions that I need in the hooks file? Any convention on that? [22:17:47] mhurd: can you do the continue thing first - I want to know if it is actually a cratch, or if you just need to continue to move past the exception [22:17:50] in the Hooks class itself? [22:18:03] (03PS2) 10Robmoen: Split the Collection model and add JSON serialization [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191599 (owner: 10Jhernandez) [22:18:04] coreyfloyd: hehe cratch [22:18:21] i like that [22:19:21] MaxSem: ok thanks [22:19:34] coreyfloyd: looks like if i hit continue it eventually works - it hit the exception, like, 8 more times, but then it worked [22:20:05] mhurd: yeah - so I don't know why the package does not include the "lastModifiedDate" [22:20:10] but thats what you are seeing [22:21:07] mhurd: we can file a bug for that, but it is separate from my patch - we need to know why we are throwing an exception and why are we catching it if its not a problem [22:21:28] coreyfloyd: *facepalm* i had break on exception enabled [22:21:42] mhurd: dont worry, i never turn that off [22:21:57] mhurd: i always want to know when i hit an exception [22:22:39] coreyfloyd: for sure [22:23:33] (03PS2) 10Bmansurov: Don't enable the UI if CentralAuth is not installed [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191779 (https://phabricator.wikimedia.org/T90010) [22:24:23] ok - I'll be back in like an hour [22:24:29] coreyfloyd: on ios 6 i’m getting a compile time error on #import [22:24:52] coreyfloyd: cool don’t worry about ^ now. take a break [22:27:41] mhurd: ok - I'll look - that header was renamed in ios 7 [22:27:46] afer i get back [22:29:03] (03PS4) 10Dr0ptp4kt: Don't include article snippet in "Share as text" option [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190637 (https://phabricator.wikimedia.org/T89541) (owner: 10Deskana) [22:29:05] mhurd: wait - how are you getting it to compuile for ios 6? [22:29:07] dr0ptp4kt you might have just gotten an interesting email ;-) [22:29:15] that shoudlnt be possible from xcode 6 [22:29:24] bgerstle_: i fear for me [22:29:37] bgerstle_: yay, i see it...hold tight [22:29:43] coreyfloyd i think you mean: http://www.spacetimestudios.com/attachment.php?attachmentid=26488&d=1363808996 [22:29:54] lol [22:30:05] GIFS people, COME ON [22:30:11] we're supposed to be engineers, damnit [22:30:20] were bad engineers [22:30:25] apparently [22:31:28] mhurd: ok - ill catch you when i get back [22:31:39] coreyfloyd: k [22:31:56] coreyfloyd: oh sorry didn’t see your last msg [22:32:45] hmmmm [22:33:02] mhurd coreyfloyd dr0ptp4kt apparently the Apple TestFlight app is iOS 8 only? WTF [22:33:18] bgerstle: yeah i’d heard that… *sigh* [22:33:25] iPhone 5 and above [22:34:03] bgerstle: because FUCKYOUWE’REAPPLEHAHAH! [22:34:03] also, i can't accept invites :-/ [22:34:13] ;) [22:34:34] Apple goes above and beyond to show they're insanely great and screwing up services [22:35:01] s/and/at [22:36:31] Deskana: mhurd coreyfloyd would you please take a look at https://gerrit.wikimedia.org/r/#/c/190637/ ? this is iterating on Deskana's patch. smarter text extracts for the case where the user hasn't selected anything will come in a separate patch. [22:37:06] oh, apparently you can't open TF invites in Gmail. [22:37:16] bgerstle: blargh [22:37:17] has to be Apple Mail app (according to reviews) [22:37:21] this is looking worse by the minute [22:37:53] iOS 8 only, can't really be automated (aside from people brave enough to do weird hacks), and yeah, the on-boarding sucks [22:38:16] bgerstle: just choose 'open in safari' after double pressing the home button to get back to the post-click from the gmail app [22:38:46] bgerstle: not that it's fun. [22:38:59] hm [22:39:11] more fun than setting up an account in apple mail [22:39:37] that worked, thanks dr0ptp4kt [22:39:38] bgerstle: here's what i did: (1) open email in gmail app. (2) tap on invitation link. (3) after that spawns another window double tap home button. (4) go back to gmail. (5) tap on on the diagonal share looking icon [22:39:41] bgerstle: good [22:39:59] also, we need to come up w/ a better build versioning scheme [22:40:17] i wonder if we can ignore apple's guidelines for this [22:40:24] bgerstle: in other news, don't try to launch the appp while you have a zombie debug session connected to your phone [22:40:36] on standalone TF you could put whatever you want in the CFBundleVersion [22:40:41] haha [22:41:31] bgerstle: well, one thing that's nice with tf is it has a dot by the icon, so maybe we don't need the beta icons. [22:41:46] bgerstle: then in theory we could just release to prod with the identical build if no badness [22:41:53] bgerstle: stepping away for a moment [22:42:30] (03PS2) 10Bgerstle: fix Xcodeproj code signing [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191763 [22:42:46] dr0ptp4kt yeah, that's one thing that's nice [22:42:51] you can just flip a switch and deploy to prod! [22:43:06] * bgerstle steps slowly away from the big red button [22:43:42] dr0ptp4kt mhurd coreyfloyd i was required to sign in as brion to upload the build, though [22:44:08] we might want to change that account to point to some email alias that we all share instead of to brion [22:44:42] oh and apparently these builds only live for 30 days [22:44:45] shouldn't be a big deal, though [22:44:52] ideally we're releasing to prod more often than that [22:46:33] (03PS3) 10Robmoen: Split the Collection model and add JSON serialization [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191599 (owner: 10Jhernandez) [22:54:39] (03CR) 10Kaldari: [C: 04-1] Recording user responses (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [22:55:39] (03PS30) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [22:58:50] bgerstle: looks like the app store version of the app "overwrites" the testflight beta. [22:59:35] was just showing Deskana and mhurd the dot icon...they were saying in the past people got confused with idential icons, so i think we need to still use a different icon...and from the looks of it a different bundle id or something so there isn't overwriting of the app [23:02:22] bgerstle: anyway, i know you were just working to get the thing doing the basic thing :) [23:02:28] dr0ptp4kt then we can't deploy a beta to prod [23:02:30] we have to do a separate build [23:02:35] bgerstle: coreyfloyd gonna change connections, will be back online after a while. [23:02:48] although, part of me wants to actually do some things differently in beta [23:02:54] e.g. crash on asserts [23:02:54] MaxSem: that makes me think of http://xkcd.com/303/ [23:02:56] bgerstle: yeah, i think we'll have to rely on being able to create identical builds sans icons and some other things. bleh [23:03:00] bgerstle: yeah, that too [23:03:02] ttyl bgerstle [23:03:05] later [23:03:59] coreyfloyd mhurd do you guys need any code review? [23:04:03] or mhurd are you able to look at some image gallery stuff? [23:05:08] bgerstle: gah! have another meeting for next hour - i can right after though [23:05:38] mhurd i'll probably call it a day before then [23:06:25] bgerstle: sounds good. sry i wasn’t able to help today. can you send me an invite for tomorrow so we for sure sync up? [23:06:40] np [23:06:41] sure [23:06:48] bgerstle: thanks! [23:07:59] (03CR) 10Kaldari: [C: 032] Don't enable the UI if CentralAuth is not installed [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191779 (https://phabricator.wikimedia.org/T90010) (owner: 10Bmansurov) [23:08:58] (03Merged) 10jenkins-bot: Don't enable the UI if CentralAuth is not installed [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191779 (https://phabricator.wikimedia.org/T90010) (owner: 10Bmansurov) [23:09:30] (03PS5) 10Kaldari: Instrument the widget-click-none WikiGrok action [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191319 (owner: 10Phuedx) [23:16:34] (03CR) 10Bmansurov: [C: 031] Hygiene: Use Config object in SpecialPages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190841 (https://phabricator.wikimedia.org/T87614) (owner: 10Florianschmidtwelzow) [23:16:56] (03PS4) 10Robmoen: Split the Collection model and add JSON serialization [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191599 (owner: 10Jhernandez) [23:18:03] (03CR) 10Robmoen: [C: 032] Split the Collection model and add JSON serialization [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191599 (owner: 10Jhernandez) [23:18:27] (03PS3) 10Robmoen: Protect storage json pages for collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191600 (owner: 10Jhernandez) [23:19:02] (03Merged) 10jenkins-bot: Split the Collection model and add JSON serialization [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191599 (owner: 10Jhernandez) [23:23:01] 3VisualEditor, Mobile-Web, Citoid: Citoid extension should target Mobile as well as desktop (otherwise it blocks VisualEditor loading in MobileFrontend) - https://phabricator.wikimedia.org/T87869#1051728 (10Etonkovidova) Tested & verified on iOS - in beta/test2. [23:23:21] 3VisualEditor, Mobile-Web, Citoid: Citoid extension should target Mobile as well as desktop (otherwise it blocks VisualEditor loading in MobileFrontend) - https://phabricator.wikimedia.org/T87869#1051729 (10Etonkovidova) [23:34:24] MaxSem: https://phabricator.wikimedia.org/T88860