[00:00:05] dr0ptp4kt, bearND: I modified the ShareAFact schema to answer the questions you guys asked me about it [00:00:12] dr0ptp4kt, bearND: These were the changes I made: https://meta.wikimedia.org/w/index.php?title=Schema:MobileWikiAppShareAFact&diff=11322925&oldid=10916168 [00:00:24] dr0ptp4kt, bearND: Do those answer your questions, solve your concerns, etc? [00:00:27] 3Wikipedia-App-iOS-App: Some articles about cities are broken in iOS app beta 4.0.6.3 - https://phabricator.wikimedia.org/T90032#1051850 (10Amire80) 3NEW [00:02:48] Deskana: thank you. Does that mean that you also want EL when no text is selected? That part is still unclear to me. [00:03:20] bearND: So if they tap share without having highlighted text? Yes, that should be logged just the same. [00:03:30] bearND: Perhaps we should really retitle the schema, but... hassle. [00:03:47] Deskana: ok, thanks [00:04:06] gotta head out for an appointment [00:04:06] (Although obviously the funnel will begin with a sharetap event rather than a highlight event in that case) [00:04:34] bearND|bbl: Great, chat to you later! [00:06:33] (03CR) 10Catrope: [C: 032] Show XFF header to the user in case of missig zero domain [extensions/ZeroBanner] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/191657 (owner: 10Yurik) [00:06:37] (03CR) 10Catrope: [C: 032] Show XFF header to the user in case of missig zero domain [extensions/ZeroBanner] (wmf/1.25wmf17) - 10https://gerrit.wikimedia.org/r/191656 (owner: 10Yurik) [00:09:21] (03Merged) 10jenkins-bot: Show XFF header to the user in case of missig zero domain [extensions/ZeroBanner] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/191657 (owner: 10Yurik) [00:09:23] (03Merged) 10jenkins-bot: Show XFF header to the user in case of missig zero domain [extensions/ZeroBanner] (wmf/1.25wmf17) - 10https://gerrit.wikimedia.org/r/191656 (owner: 10Yurik) [00:17:19] 3Wikipedia-App-iOS-App: Support 1password for login - https://phabricator.wikimedia.org/T90033#1051868 (10Jaredzimmerman-WMF) 3NEW [00:18:49] 3Wikipedia-App-iOS-App: Support 1password for login - https://phabricator.wikimedia.org/T90033#1051875 (10Krenair) [00:19:27] 3Wikipedia-App-iOS-App: Support 1password for login - https://phabricator.wikimedia.org/T90033#1051868 (10Krenair) [00:23:51] 3MediaWiki-extensions-Extensions-requests, Wikipedia-App-iOS-App, MediaWiki-Authentication-and-authorization: Support 1password for login - https://phabricator.wikimedia.org/T90033#1051888 (10Legoktm) [00:27:01] (03PS6) 10Bmansurov: Remove WikiGrok version A [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191358 (owner: 10Phuedx) [00:27:50] 3Wikipedia-App-iOS-App: Support 1password for login - https://phabricator.wikimedia.org/T90033#1051890 (10Legoktm) [00:28:16] 3Wikipedia-App-iOS-App: Support 1password for login - https://phabricator.wikimedia.org/T90033#1051892 (10Krenair) [00:53:16] (03CR) 10BearND: [C: 04-1] "Works. Just some minor nits." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191775 (https://phabricator.wikimedia.org/T89979) (owner: 10Dbrant) [01:03:09] Deskana: dr0ptp4kt: fyi, I've added a card to this sprint for EL changes. Should be simple: https://trello.com/c/gXlyRzRw/36-update-el-for-share-a-fact [01:03:22] bearND: thx [01:03:38] dr0ptp4kt: feel free to duplicate once Deskana approves [01:14:01] (03CR) 10Bmansurov: Instrument the widget-click-none WikiGrok action [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191319 (owner: 10Phuedx) [01:14:07] (03CR) 10Bmansurov: [C: 032] Instrument the widget-click-none WikiGrok action [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191319 (owner: 10Phuedx) [01:15:10] (03Merged) 10jenkins-bot: Instrument the widget-click-none WikiGrok action [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191319 (owner: 10Phuedx) [02:00:07] des [02:00:18] Deskana: haha. back online [02:00:28] mhu [02:00:30] mhurd: Yay! [02:00:33] lol [04:27:56] 3Wikipedia-App-iOS-App: Some articles about cities are broken in iOS app beta 4.0.6.3 - https://phabricator.wikimedia.org/T90032#1052291 (10Deskana) p:5Triage>3High Verified. Needs fixing. [04:32:30] coreyfloyd: hey you still up? [04:57:56] mhurd: You might want to know about this: https://phabricator.wikimedia.org/T90032 [04:58:50] Deskana: ah. good catch! [05:09:39] mhurd: Strangely seems to be fine in other RTL languages. [05:09:52] mhurd: Probably some random CSS rule in the Hebrew Wikipedia that just isn't playing nice with something. [05:10:30] Deskana: would you mind attaching a screenshot or 2 to the phab task? [05:10:35] mhurd: Sure, give me 5. [05:10:49] Deskana: thx! no rush! [05:23:27] Uploading them now... [05:25:01] 3Wikipedia-App-iOS-App: Some articles about cities are broken in iOS app beta 4.0.6.3 - https://phabricator.wikimedia.org/T90032#1052319 (10Deskana) How to reproduce this for people that can't type in Hebrew: 1) Go to [[Tel Aviv]] on the English Wikipedia 2) Use the ToC to go to the last section 3) Tap "Read in... [05:25:04] mhurd: ^ [05:26:01] Deskana: great! thanks for the repro-steps [05:28:38] Deskana: heading offline… may watch a movie :) [05:28:40] mhurd: Sure! Now, step away from the computer and relax. [05:28:44] mhurd: Aha, great minds. ;-) [05:28:49] lol [05:29:03] Deskana: see ya tomorrow! [05:29:24] mhurd: Have fun! [05:29:42] Deskana: take a break yourself ;) [05:29:47] Hah. [07:57:51] (03PS31) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [10:05:41] 3MobileFrontend: Gallery tags do not honour their 'spec' - https://phabricator.wikimedia.org/T56796#1052579 (10Florian) [10:40:49] morning all [10:40:55] * phuedx forgot to sign into irc again :/ [12:29:25] 3Wikipedia-App-Android-App: ShareAFact not usable again after rotating device - https://phabricator.wikimedia.org/T89979#1052986 (10Aklapper) [13:41:49] breaking for lunch [14:11:00] Please fix "Mobile App Sprint 52 - Android" [14:11:08] it creates an error on https://phabricator.wikimedia.org/project/sprint/ [14:11:45] same for the iOS one [14:11:49] https://phabricator.wikimedia.org/project/details/1065/ [14:11:50] https://phabricator.wikimedia.org/project/details/1066/ [14:11:53] Thank you. [14:12:12] * andre__ sets a random sprint date for the time being [14:13:07] (03PS6) 10Fjalapeno: Implement new refresh saved pages logic and UI. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 [14:17:06] back [14:36:14] if the unit tests are failing, is there a way we can debug what caused the error from test results? [14:36:17] eg : https://dpaste.de/PxLm [14:39:47] (03CR) 10Phuedx: "Mostly questions about TODOs inline." (035 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [14:40:36] codezee: that looks like a module dependency error [14:40:41] * phuedx isn't sure though [14:45:42] phuedx: has the wikigrok js files been removed? [14:45:50] codezee: yes [14:45:59] they've been moved over to the WikiGrok extension [14:46:09] codezee: are you using mediawiki-vagrant? [14:46:33] phuedx: I'm using a local instance of mediawiki, not vagrant [14:46:45] I'll pull the latest changes [14:47:12] I guess now this will require new changes: https://gerrit.wikimedia.org/r/#/c/188673/ [14:49:07] phuedx: should I just remove the wikigrok related files from the patch? or the extension will also need to be updated? [14:50:01] codezee: it looks like you'll have to split the patch into two – one for MF and one for WG [14:51:47] phuedx: yes, ok, for the time being I'll remove wikigrok from here, and then update it in separate patch [14:52:23] codezee: sorry, i didn't quite answer your question – yes, remove the wikigrok-related changes [14:53:13] phuedx: also, could you tell the difference b/w voting and non-voting tests, I guess voting tests are the one's that need to be necessarily passed? [14:53:42] (03CR) 10Phuedx: Hygiene: Don't set robots policy for a skin (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191374 (owner: 10Florianschmidtwelzow) [14:54:00] codezee: exactly right [14:54:25] a non-voting test can fail and it won't effect the vote [14:54:29] *affect [14:55:02] phuedx: alright, thanks :) [15:08:17] (03CR) 10Phuedx: [C: 032] Hygiene: Don't set robots policy for a skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191374 (owner: 10Florianschmidtwelzow) [15:09:58] (03CR) 10Phuedx: "Tested this locally by using useskin=minerva and proving that the robot policy wasn't set and proving the opposite when viewing the site o" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191374 (owner: 10Florianschmidtwelzow) [15:10:59] (03CR) 10Phuedx: "Ping @Florianschmidtwelzow." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [15:16:12] (03PS2) 10Dbrant: Fix ability to share text selection after screen rotation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191775 (https://phabricator.wikimedia.org/T89979) [15:18:03] (03PS2) 10Bgerstle: use UICollectionViewDelegate to set itemSize dynamically [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191805 [15:18:33] (03PS3) 10Bgerstle: fix Xcodeproj code signing [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191763 [15:37:02] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Sorry i read the comment, but forgot to do anything :/" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [16:01:51] (03PS14) 10Sumit: Overlay,Panel,Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) [16:02:32] (03CR) 10Sumit: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [16:04:29] (03CR) 10Sumit: "wikigrok has been moved out, but the unit tests still fail...." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [16:05:15] 3Wikipedia-App-iOS-App: Gifs binaries are not being routed to the data store properly (causes temporary blank screens in gallery) - https://phabricator.wikimedia.org/T89921#1053699 (10BGerstle-WMF) @Mhurd you need to bump both the memory & disk capacity to a larger value to get it to work. Try this: 1. Uninsta... [16:07:38] phuedx: you around? [16:07:47] gah [16:10:24] 3Wikipedia-App-iOS-App: Gifs binaries are not being routed to the data store properly (causes temporary blank screens in gallery) - https://phabricator.wikimedia.org/T89921#1053715 (10BGerstle-WMF) @Mhurd I posted a draft patch set here: https://gerrit.wikimedia.org/r/191894 [16:39:30] (03CR) 10Umherirrender: [C: 032] "Resubmit to give jenkins a second try (rebasing after Code-Review+2 stopps jenkins)" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191578 (owner: 10Florianschmidtwelzow) [16:40:31] (03Merged) 10jenkins-bot: Hygiene: Don't assume, that all pages has text extracts [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191578 (owner: 10Florianschmidtwelzow) [16:44:47] (03CR) 10Sumit: "when I switched to master branch, the same tests fail, not sure whether my instance has problem, or it it global" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [17:03:10] hey coreyfloyd anything i can do to help you out? [17:03:19] code review, pairing.. [17:04:22] bgerstle: if you want to look at the save to refresh patch you can… I know monte was looking it too [17:04:58] bgerstle: otherwise nothing much - I am just doing the uncrustify stuff now - going to push it up soon so you can look at that and modify the config if you like. [17:05:04] sweet! [17:05:11] i've been looking at fastlane this morning [17:05:24] it's our best shot at automating iTC stuff, afaict [17:05:40] it's all a bunch of ruby utils that do website scraping, etc. [17:05:50] some of the non-iTC stuff is cool too [17:05:57] like generating and publishing new screenshots of your app [17:06:02] in different langs [17:06:51] (03PS1) 10Fjalapeno: Uncrustify (WIP). [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 [17:07:29] bgerstle: yeah - i was going to say between that and cupertino, we should be able to automate deployments still [17:07:45] cupertino is mattt's thing? [17:07:59] yeah - not sure if it was updated for the new testflgiht stuff or not [17:08:00] part of the nomad CLI suite [17:08:08] no idea [17:08:14] i'm pretty sure fastlane though [17:08:16] is though* [17:08:20] cool [17:10:16] 3Wikipedia-App-Android-App: [Spike ?hr] Investigate building a Node.js service for mobile apps content - https://phabricator.wikimedia.org/T90228#1054114 (10Deskana) [17:10:38] 3Wikipedia-App-Android-App, Wikipedia-App-iOS-App: [Spike ?hr] Investigate building a Node.js service for mobile apps content - https://phabricator.wikimedia.org/T90228#1054105 (10Deskana) [17:10:43] bgerstle: uncrustify has a lot of settings we didn't cover (and i don't care to cover) in the style doc. I picked some good objective-c starting points and made sure to get our preferences in there. So if you or anyone else wants to change something it should be easy - I just wanted to make sure we had good sensible default for most things. [17:11:18] +1 [17:11:36] i'm trying to do some research now on how it differs from other tools like oclint and clang-format [17:11:46] i also found this nifty looking commit hook https://github.com/githubbrowser/Pre-commit-hooks/blob/master/pre-commit-uncrustify [17:11:49] bgerstle: i went through clang-format first [17:12:05] bgerstle: yeah i have a commit hook - i can include it [17:12:13] nice [17:13:03] 3: Article talk page should be accessible from inside the app - https://phabricator.wikimedia.org/T64776#1054126 (10Deskana) [17:13:04] 3Wikipedia-App-Android-App: Make it easier to access talk pages - https://phabricator.wikimedia.org/T89606#1054127 (10Deskana) [17:13:32] coreyfloyd based on the diff you haven't actually run it yet? [17:13:46] 3Wikipedia-App-Android-App, MediaWiki-API, Wikipedia-App-iOS-App, MediaWiki-Core-Team: Allow triggering of user password reset email via the API - https://phabricator.wikimedia.org/T32788#1054137 (10Deskana) [17:13:47] 3Wikipedia-App-Android-App: Password changes? - https://phabricator.wikimedia.org/T69539#1054136 (10Deskana) [17:13:47] bgerstle: clangformat is missing a couple things… the big one is that it can't enforce brackets on single ifs [17:13:59] hrm [17:14:40] bgerstle_: yeah - its a bit annoying - i knew that from before, but was hoping they had added it in the past year. [17:15:10] 3Wikipedia-App-Android-App: Enable save of pictures for "saved pages" - https://phabricator.wikimedia.org/T70288#1054141 (10Deskana) 5Open>3Resolved a:3Deskana It's now possible to save images to your device using the image viewer. [17:15:11] bgerstle_: no - I didn't ru it [17:15:27] k [17:15:34] bgerstle_: on purpose so you can evaluate it - its easier for you to see if you run it on a file and see what changes [17:15:44] right [17:15:50] 3Wikipedia-App-General-or-Unknown: Apps need FAQ pages - https://phabricator.wikimedia.org/T71329#1054145 (10Deskana) [17:15:51] 3: There doesn't seem to be a help page, user help manual, or link to the Wikipedia app - https://phabricator.wikimedia.org/T54795#1054144 (10Deskana) [17:16:09] 3Wikipedia-App-General-or-Unknown: Apps need FAQ pages - https://phabricator.wikimedia.org/T71329#728186 (10Deskana) This might be a good task for our community liaison, @moushira. [17:16:55] bgerstle_ dr0ptp4kt bb for standup [17:17:00] k [17:17:21] coreyfloyd: thx [17:18:29] 3Wikipedia-App-General-or-Unknown: Category view shows no articles in the mobile app - https://phabricator.wikimedia.org/T71984#1054152 (10Deskana) [17:18:29] 3Wikipedia-App-Android-App: Show categories of a page - https://phabricator.wikimedia.org/T73966#1054151 (10Deskana) [17:19:00] 3Wikipedia-App-General-or-Unknown: Category view shows no articles in the mobile app - https://phabricator.wikimedia.org/T71984#740572 (10Deskana) Merged in another task about categories; the tasks were subtly different, but can both be tracked here. [17:19:55] (03CR) 10Bmansurov: "Tests are passing on my local machine." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [17:23:13] 3Wikipedia-App-General-or-Unknown: Apps need FAQ pages - https://phabricator.wikimedia.org/T71329#1054171 (10Moushira) Right, we need FAQ for all mobile projects. It has been on my to-do. Will share a draft soon :) [17:32:26] (03PS1) 10Dbrant: [WIP] Use icons in Gallery license information. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191910 [17:34:47] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use icons in Gallery license information. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191910 (owner: 10Dbrant) [17:34:50] Hi folks! Question for the MFE team: why is the Talk link is still only Beta? [17:35:34] (03PS2) 10Dbrant: [WIP] Use icons in Gallery license information. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191910 [17:36:25] (03CR) 10Sumit: "@bmansurov, could you run recheck, so that jenkins runs the tests" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [17:36:54] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [17:40:05] (03CR) 10Sumit: "all the tests finally pass, I guess it can be given a manual try now" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [17:43:09] (03CR) 10Florianschmidtwelzow: [C: 032] "bring Jenkins back to life! :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191374 (owner: 10Florianschmidtwelzow) [17:44:21] hmm, it seems, that +2 get's not triggered? [17:44:28] * in jenkins [17:46:22] (03CR) 10Kaldari: "Currently the PHP coding conventions for Mediawiki just say to use MWException or a subclass. As the commit summary for this change doesn'" [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/184062 (owner: 10Ori.livneh) [17:46:56] 3Wikipedia-App-Android-App, Wikipedia-App-iOS-App: [Spike ?hr] Investigate building a Node.js service for mobile apps content - https://phabricator.wikimedia.org/T90228#1054263 (10Joe) This sounds to me like awkwardly similar to what mediawiki does now... it could just be a new api endpoint, right? After all we... [17:55:41] coreyfloyd: heya! [17:56:54] 3Wikipedia-App-Android-App, Wikipedia-App-iOS-App: [Spike ?hr] Investigate building a Node.js service for mobile apps content - https://phabricator.wikimedia.org/T90228#1054286 (10Deskana) This spike is for an experimental service for us to get to grips with how to build services. The goal is not intended to use... [17:57:18] (03CR) 10BearND: [C: 04-1] "That's better. Another minor nit." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191775 (https://phabricator.wikimedia.org/T89979) (owner: 10Dbrant) [17:58:02] coreyfloyd: time for quick pre-standup hangout? [17:58:21] (03PS1) 10BearND: Fix several Lint issues [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191915 [17:58:50] yeah [17:59:35] (03PS6) 10Florianschmidtwelzow: Hygiene: Use events map in talk feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) [18:04:09] (03PS3) 10Dbrant: Fix ability to share text selection after screen rotation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191775 (https://phabricator.wikimedia.org/T89979) [18:08:37] (03PS7) 10Mhurd: WIP: Native component beneath webView. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 [18:09:20] (03PS8) 10Mhurd: WIP: Native component beneath webView. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 [18:14:07] (03PS4) 10BearND: Fix ability to share text selection after screen rotation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191775 (https://phabricator.wikimedia.org/T89979) (owner: 10Dbrant) [18:14:22] (03CR) 10BearND: [C: 032] "Perfect!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191775 (https://phabricator.wikimedia.org/T89979) (owner: 10Dbrant) [18:14:41] (03Merged) 10jenkins-bot: Fix ability to share text selection after screen rotation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191775 (https://phabricator.wikimedia.org/T89979) (owner: 10Dbrant) [18:16:18] bgers [18:16:31] bgerstle: standing! [18:16:36] kristenlans sitting! [18:18:01] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Breaks main drawer functionality :/ (see inline comments :))." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [18:18:29] kristenlans: do you made Spaghettieis? :) [18:19:33] FlorianSW: not yet! I'm goign to wait until summer I think :-) [18:19:43] great idea :) [18:20:30] FlorianSW: kristenlans: yummmm [18:21:14] bearND: you already had it? kristenlans asked me, if i know about it and i had to say "never heard" :D [18:23:19] FlorianSW: yep. Vanilla ice cream is my favorite [18:24:40] cool, my favourite is chocolate, i never want any other :D [18:24:57] bearND, any thoughts on https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8145442 ? plotting nearby articles with (presumably) OSM? [18:26:23] Krenair: probably more a question for Deskana|Away (should be back shortly, we're having our standup right now) [18:26:46] 3Mobile-Web: Sub-section edit icon floats over images - https://phabricator.wikimedia.org/T90245#1054402 (10Krenair) [18:26:51] ok [18:26:59] 3MobileFrontend: Sub-section edit icon floats over images - https://phabricator.wikimedia.org/T90245#1054407 (10Krenair) [18:27:29] 3MobileFrontend, Mobile-Web: Sub-section edit icon floats over images - https://phabricator.wikimedia.org/T90245#1054412 (10phuedx) [18:27:43] stupid phabricator (lack of) conflict detection -_- [18:28:39] helps if you're not editing a task underneath the person trying to create it ;) [18:28:47] :P [18:34:26] wow bearND i can't believe you've really had Spaghettieis! [18:35:11] (03PS32) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [18:42:46] 3Wikipedia-App-iOS-App: As a new user, I'd like article issues and disambiguation wrapped up into a button so that I can see what problems an article might have. - https://phabricator.wikimedia.org/T90250#1054479 (10Deskana) 3NEW [18:42:52] phuedx, kaldari: not sure if wgr_status should be an enum, now I want to add 'no consensus' to it... [18:43:37] 3Wikipedia-App-iOS-App: As a reader, I'd like to not be shown the IPA in an article so that it doesn't take up space. - https://phabricator.wikimedia.org/T90251#1054505 (10Deskana) p:5Triage>3Normal [18:43:38] varchar(20) would be more flexible... [18:43:49] 3Wikipedia-App-iOS-App: As a reader, I'd like to not be shown the IPA in an article so that it doesn't take up space. - https://phabricator.wikimedia.org/T90251#1054492 (10Deskana) [18:44:03] (03CR) 10Florianschmidtwelzow: [C: 04-1] Hygiene: Don't set robots policy for a skin (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191374 (owner: 10Florianschmidtwelzow) [18:44:10] 3Wikipedia-App-iOS-App: As a new user, I'd like article issues and disambiguation wrapped up into a button so that I can see what problems an article might have. - https://phabricator.wikimedia.org/T90250#1054509 (10Deskana) [18:44:34] FlorianSW: lol [18:44:47] we tend to use the if { } else { } style anyway [18:44:51] it was just a though [18:44:53] *thought [18:45:10] MaxSem: I think the existing enum options will work, but I’m also fine with varchar(20) [18:45:31] (03PS3) 10Florianschmidtwelzow: Hygiene: Use Config object in SpecialPages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190841 (https://phabricator.wikimedia.org/T87614) [18:45:33] (03PS2) 10Florianschmidtwelzow: Hygiene: Don't set robots policy for a skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191374 [18:45:41] brb getting george to bed [18:48:43] kristenlans: it's been a long time ago, in Germany, of course [18:49:29] bearND: Lint isn't supposed to pass completely (yet), right? [18:49:39] dbrant: right [18:49:45] ok [18:50:07] dbrant: this patch is just making a dent in the long list of Lint issues [18:50:12] yep [18:53:07] (03PS33) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [18:53:08] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Hone in on, and eradicate, article load time performance issues - https://phabricator.wikimedia.org/T90255#1054590 (10Deskana) 3NEW [18:53:38] 6Mobile-Web, 10MobileFrontend: Sub-section edit icon floats over images - https://phabricator.wikimedia.org/T90245#1054598 (10Florian) a:3Florian [18:54:20] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: As a reader, I'd like suggestions for what I can read next to be presented to me. [Main page read more] - https://phabricator.wikimedia.org/T90256#1054612 (10Deskana) 3NEW [18:54:30] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: As a reader, I'd like suggestions for what I can read next to be presented to me. [Main page read more] - https://phabricator.wikimedia.org/T90256#1054621 (10Deskana) [18:55:09] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Implement Schema:Search - https://phabricator.wikimedia.org/T90257#1054629 (10Deskana) 3NEW [18:55:20] folks familiar with the MobileFrontEnd code, you should check this out: [18:55:20] https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/javascripts/loggingSchemas/SchemaMobileWebClickTracking.js#L73 [18:55:51] that line in combination with this one: [18:55:51] https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/javascripts/Schema.js#L58 [18:56:19] means that schema (MobileWebClickTracking) is sampling at 50% rate client side. Sampling is usually handled server side [18:56:30] I didn't see any code accounting for this when analyzing that schema's data [18:56:40] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Implement Schema:Search - https://phabricator.wikimedia.org/T90257#1054647 (10Deskana) [18:56:45] I'll ping you on the mailing list but was wondering if there's a simple explanation [18:57:33] (03PS4) 10Robmoen: Protect storage json pages for collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191600 (owner: 10Jhernandez) [18:58:44] So Phabricator lets you enter point values that aren't a number [18:58:46] So I did that [18:58:53] Now the total points for the sprint is shown as "NaN" [18:59:00] I took a screenshot to paste in here and tried to upload it to imgur [18:59:10] But when I went to their website to upload it, it spewed a load of JSON at me: http://imgur.com/upload [18:59:16] {"data":{"error":{"code":0,"message":"No files to upload.","type":"ImgurException","exception":{}},"request":"\/upload","method":"GET"},"success":false,"status":500} [18:59:27] Is everything broken, everywhere? [18:59:43] bgerstle: coreyfloyd mhurd let's all update https://trello.com/b/RAyj54YQ/mobile-apps-sprint-51-ios-16th-feb-2nd-mar with patch URLs. kristenlans, sorry for me not being good about this personally and also not taskmastering on it; i will be better [18:59:53] i'm about to disconnect and reconnect [19:00:32] Deskana: you can upload images to phabricator, too? :) [19:01:00] milimetric: it was added in this change: https://gerrit.wikimedia.org/r/#/c/185246/ to reduce the load to EventLogging, maybe kaldari can explain a little bit more :) [19:01:59] (03PS1) 10Florianschmidtwelzow: Hygeiene: Edit pencil images shouldn't overlap floated images. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191924 (https://phabricator.wikimedia.org/T90245) [19:02:43] FlorianSW: the motivation makes sense, but the sampling mechanisms that everyone else uses are on the server side, and it would probably be best if all schemas did it the same way [19:02:44] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: [Spike ?hr] Investigate onboarding libraries to find one that's suitable for our purposes - https://phabricator.wikimedia.org/T89987#1054704 (10Deskana) [19:02:50] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: As an engaged reader, I'd like to know that I can share cards with interesting facts on. - https://phabricator.wikimedia.org/T89988#1054705 (10Deskana) [19:02:55] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: As a product owner, I'd like to know how well the Tweet A Fact onboarding did at exposing users to the feature - https://phabricator.wikimedia.org/T89989#1054707 (10Deskana) [19:03:02] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - Android: [Spike ?hr] Investigate building a Node.js service for mobile apps content - https://phabricator.wikimedia.org/T90228#1054709 (10Deskana) [19:03:37] https://phabricator.wikimedia.org/project/view/1065/ [19:03:39] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - Android: [Spike ?hr] Investigate building a Node.js service for mobile apps content - https://phabricator.wikimedia.org/T90228#1054105 (10Deskana) [19:03:52] https://phabricator.wikimedia.org/project/view/1066/ [19:05:47] https://phabricator.wikimedia.org/tag/mobile_app_sprint_52_-_android/ [19:06:06] milimetric: +1 :) i'm totally new at eventlogging, have you a doc for sampling (or any example)? Or is there nothing to do at the client side? Can you open a task in phabricator, so we can track this and maybe discuss it? Maybe we really new the client sampling, i'm not sure :/ :) [19:06:53] dr0ptp4kt: no worries, learning curve! We're ALL going to have to get even better at being on the ball with tools and communication (esp asynch. stuff) with a bigger team and mroe remote team members. [19:06:56] (03PS2) 10Florianschmidtwelzow: Hygiene: Edit pencil images shouldn't overlap floated images. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191924 (https://phabricator.wikimedia.org/T90245) [19:12:23] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: As an engaged reader, I'd like to know that I can share cards with interesting facts on. - https://phabricator.wikimedia.org/T89988#1054774 (10KLans_WMF) [19:18:22] (03PS1) 10Phuedx: Implement design review for beta styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191930 [19:20:15] (03PS1) 10Chad: Always define $talkButton in SkinMinvervaBeta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191932 [19:22:53] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: [Spike ?hr] Investigate onboarding libraries to find one that's suitable for our purposes - https://phabricator.wikimedia.org/T89987#1054853 (10Deskana) [19:23:42] (03CR) 10MaxSem: [C: 032] Always define $talkButton in SkinMinvervaBeta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191932 (owner: 10Chad) [19:23:47] (03CR) 10Florianschmidtwelzow: Always define $talkButton in SkinMinvervaBeta (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191932 (owner: 10Chad) [19:24:29] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: [Spike ?hr] Investigate onboarding libraries to find one that's suitable for our purposes - https://phabricator.wikimedia.org/T89987#1050887 (10Deskana) [19:24:53] (03CR) 10Chad: [C: 04-2] Always define $talkButton in SkinMinvervaBeta (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191932 (owner: 10Chad) [19:26:00] (03PS2) 10Chad: Always define $talkButton in SkinMinvervaBeta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191932 [19:26:42] (03CR) 10Florianschmidtwelzow: [C: 04-1] Always define $talkButton in SkinMinvervaBeta (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191932 (owner: 10Chad) [19:26:44] (03PS3) 10Chad: Always define $talkButton in SkinMinvervaBeta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191932 [19:27:55] (03CR) 10Florianschmidtwelzow: [C: 032] "thanks :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191932 (owner: 10Chad) [19:29:16] (03Merged) 10jenkins-bot: Always define $talkButton in SkinMinvervaBeta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191932 (owner: 10Chad) [19:34:00] (03PS2) 10Dbrant: Fix several Lint issues [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191915 (owner: 10BearND) [19:36:38] Deskana, any thoughts on https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8145442 ? plotting nearby articles with (presumably) OSM? [19:36:53] (03CR) 10Dbrant: [C: 032] Fix several Lint issues [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191915 (owner: 10BearND) [19:48:11] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Implement Schema:MobileWikiAppSearch - https://phabricator.wikimedia.org/T90257#1055001 (10Deskana) [19:49:27] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Implement Schema:MobileWikiAppSearch - https://phabricator.wikimedia.org/T90257#1054629 (10Deskana) [20:00:13] (03PS3) 10Dbrant: Use icons in Gallery license information. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191910 [20:03:44]   [20:03:44]  FlorianSW: sorry I was in a meeting. Yes, there's nothing you need to do client side to sample, the sampling can be decided when you deploy the extension. Basically when you deploy, you should tell us how many events per second you expect to get and we'll help you pick a good rate to sample at. [20:04:00] (03PS3) 10Robmoen: Retrieve collections list from json store [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191601 (owner: 10Jhernandez) [20:05:55] (03CR) 10Robmoen: [C: 032] "Rebased, and untied this patch to the protection patch. Also cleaned up the usage of loadCollections." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191601 (owner: 10Jhernandez) [20:06:25] milimetric: np :) Can you open a task for it and put your explanation in it? :) [20:06:40] sure [20:06:46] thanks! :D [20:06:48] FlorianSW: what project should i tag? [20:06:55] Mobile-web [20:07:01] that should be enough [20:07:02] :) [20:08:16] (03Merged) 10jenkins-bot: Retrieve collections list from json store [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191601 (owner: 10Jhernandez) [20:08:33] bgerstle: it was this patch: https://gerrit.wikimedia.org/r/#/c/191805/ [20:09:12] bgerstle: confirmed that adam has an ios 6 device on it’s way to you. said it was due to ship on/around today [20:10:11] 6Mobile-Web, 10Analytics-EventLogging, 6Analytics-Kanban: Follow up with mobile team on instrumentation sampling rate (%50) - https://phabricator.wikimedia.org/T88363#1055105 (10Milimetric) [20:10:14] https://phabricator.wikimedia.org/T88363 [20:10:22] ah :) bot beat me to it [20:13:16] mhurd great [20:13:36] bgerstle: running to lunch [20:13:42] ok [20:13:48] i'll put this fix on hold until i get a device [20:14:04] or i find another creative way to test it ;-) [20:14:26] stepping out to run a quick errand, bbiab [20:55:53] MaxSem: Just sent email about aggregation idea. Also came up with a way for it to be performant (I think) [21:00:07] coreyfloyd: we’ll be upstairs in a minute… [21:06:43] (03CR) 10BearND: [C: 04-1] Use icons in Gallery license information. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191910 (owner: 10Dbrant) [21:10:40] (03PS34) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [21:11:01] (03PS1) 10MaxSem: WIP: aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191957 [21:11:45] (03PS2) 10MaxSem: WIP: aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191957 [21:13:43] (03CR) 10jenkins-bot: [V: 04-1] WIP: aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191957 (owner: 10MaxSem) [21:18:43] 10Wikipedia-App-Android-App, 5Patch-For-Review: ShareAFact not usable again after rotating device - https://phabricator.wikimedia.org/T89979#1055301 (10bearND) 5Open>3Resolved a:3bearND [21:26:43] (03CR) 10TheDJ: Delay ZeroBanner die requirement after setup (031 comment) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/188115 (https://phabricator.wikimedia.org/T88015) (owner: 10Hashar) [21:32:57] bd808: Is vote-securepoll.wmflabs.org job queue working? [21:33:12] bd808: Our voter eligibility list is stuck at 0%. [21:33:22] Deskana: :( I can look in a bit [21:33:23] hi kaldari: can you add me to mobile-tech list? I don't see it in lists.wikimedia.org and am not sure how to subscribe. thanks! [21:33:32] it may be broken [21:33:47] leila: I think tfinc has to do that [21:34:24] I'll email him, thanks, kaldari. (I didn't get your earlier email about what we decided to do with aggregation yesterday, for example.) [21:40:44] leila, is that @wikimedia.org or @lists.wikimedia.org? [21:41:28] looks like @wm.o [21:41:52] Krenair: it's wikimedia.org but shouldn't it show up in https://lists.wikimedia.org/mailman/listinfo regardless? [21:42:03] so won't appear on lists.wikimedia.org [21:42:07] no [21:42:29] if it's not a mailman list it can't show up on mailman [21:42:55] even many mailman lists are hidden from there :( [21:43:49] leila, https://www.mediawiki.org/wiki/Mobile_web/Team/Onboarding says it's mobile team only, sorry. [21:44:28] Krenair: that's fine. thanks for checking. the problem is that there are conversations that I'm involved in and it becomes a hassle for kaldari to cc me in every one of them [21:44:39] kaldari: are you fine with making sure I'm cc-ed in everything I need to know [21:45:11] for example, the email that you sent about aggregation: I'd like to be in that conversation. [21:47:01] leila: oops, should have cced you [21:47:22] np. as long as cc it's not a big hassle for you, I'm happy with not being on that list [21:47:29] thanks, kaldari [21:48:22] leila: you should be sub'ed on all lists, just set them all to 'don't sent mail'. then you can always reply or post, but don't get all the overhead of each mail :) [21:48:30] People should probably be used to CCing in others, if you're going to have random private staff-only lists lying around everywhere [21:50:23] thedj: where should I set the "don't send mail"? [21:53:31] if this is a google group it can be managed through that interface [22:00:32] leila: https://lists.wikimedia.org/mailman/options/wikimedia-l (you can set it globally or for each individual list) [22:00:48] not sure where the gmail group option is. [22:01:40] thedj: thanks! wikimedia-l is a list on its own, right? [22:01:54] yes [22:02:09] leila, https://groups.google.com/a/wikimedia.org/forum/#!myforums [22:02:49] Click the edit button next to your name in the row for the right group [22:02:55] then you get some options for this stuff [22:03:37] thanks Krenair. this is helpful. [22:08:46] it's one of my key ways to limit myself from going crazy on some of the more 'combative' lists.... [22:23:08] (03PS3) 10Robmoen: Hygiene: Rename views\ItemImage to views\Image [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190802 (owner: 10Jhernandez) [22:23:30] (03CR) 10Robmoen: [C: 032] Hygiene: Rename views\ItemImage to views\Image [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190802 (owner: 10Jhernandez) [22:24:39] (03Merged) 10jenkins-bot: Hygiene: Rename views\ItemImage to views\Image [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190802 (owner: 10Jhernandez) [22:24:54] (03CR) 10Robmoen: [C: 032] Add unit tests support [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191005 (owner: 10Jhernandez) [22:25:17] (03PS2) 10Robmoen: Add collection-owner icon [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190791 (owner: 10Jhernandez) [22:26:00] (03Merged) 10jenkins-bot: Add unit tests support [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191005 (owner: 10Jhernandez) [22:32:32] (03CR) 10Robmoen: [C: 032] Add collection-owner icon [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190791 (owner: 10Jhernandez) [22:33:34] (03Merged) 10jenkins-bot: Add collection-owner icon [extensions/Gather] - 10https://gerrit.wikimedia.org/r/190791 (owner: 10Jhernandez) [22:34:49] 10Wikipedia-App-iOS-App: Image Gallery: cannot open a random image - https://phabricator.wikimedia.org/T90293#1055549 (10Etonkovidova) 3NEW [22:44:23] 10Wikipedia-App-iOS-App: Image map is not displayed correctly in Image Gallery view - https://phabricator.wikimedia.org/T90294#1055567 (10Etonkovidova) 3NEW [22:54:56] 10Wikipedia-App-iOS-App: Image Gallery img comparison with Android - https://phabricator.wikimedia.org/T90296#1055594 (10Etonkovidova) 3NEW [22:55:54] 10Wikipedia-App-iOS-App: Image Gallery img comparison with Android - https://phabricator.wikimedia.org/T90296#1055601 (10Etonkovidova) [23:03:30] coreyfloyd: ok if i tag everyone on the uncrustify patch? [23:07:06] mhurd: sure [23:07:32] coreyfloyd: cool - testing pull to refresh update on ios 6 device atm [23:08:29] coreyfloyd: added [23:08:44] mhurd: cool thanks [23:08:50] np! [23:12:00] coreyfloyd: quick hangout? [23:13:57] sure [23:17:54] 10Wikipedia-App-iOS-App: svg images do not display information in Image Gallery view - https://phabricator.wikimedia.org/T90298#1055656 (10Etonkovidova) 3NEW [23:33:20] i'm off for the day. 'night folks! [23:33:20] o/ [23:33:27] bgerstle: have a good weekend! [23:33:39] thanks! [23:35:31] (03CR) 10Mhurd: "There remain some iOS 6 issues, so Brian is putting this on hold until he receives the iOS 6 ipod - hopefully early next week." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191805 (owner: 10Bgerstle) [23:42:23] mhurd dr0ptp4kt ok - cocoapods decided to break, so I am going to take a break to… hit me up if you need something, will be back post din din [23:42:41] coreyfloyd: sounds good! [23:42:53] coreyfloyd: peace [23:43:35] (03CR) 10Mhurd: [C: 031] "Seems to work." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191763 (owner: 10Bgerstle) [23:43:54] dr0ptp4kt: ^ this looks like it’s working [23:49:02] (03CR) 10Mhurd: "Re: the iOS 6 issue where after rotate you see 2 images partially onscreen - could it be related to this? http://stackoverflow.com/a/13389" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191805 (owner: 10Bgerstle) [23:59:27] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] fix Xcodeproj code signing [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191763 (owner: 10Bgerstle)