[03:20:25] (03PS1) 10Deskana: Update app store description for translation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192261 [03:25:19] 10Wikipedia-App-General-or-Unknown: Apps need FAQ pages - https://phabricator.wikimedia.org/T71329#1058112 (10Deskana) p:5Triage>3Normal a:3Moushira [03:25:38] 10Wikipedia-App-General-or-Unknown: Apps need FAQ pages - https://phabricator.wikimedia.org/T71329#728186 (10Deskana) >>! In T71329#1054171, @Moushira wrote: > Right, we need FAQ for all mobile projects. It has been on my to-do. Will share a draft soon :) Excellent! Thanks. [04:38:13] (03CR) 10BearND: [C: 04-1] Update app store description for translation. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192261 (owner: 10Deskana) [04:39:14] 6Mobile-Web, 10MobileFrontend: ResourceLoader definition hash for mobile.usermodule changes suspiciously frequently - https://phabricator.wikimedia.org/T90411#1058132 (10ori) 3NEW [05:08:20] (03CR) 10Deskana: Update app store description for translation. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192261 (owner: 10Deskana) [05:11:48] (03PS2) 10Deskana: Update app store description for translation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192261 [05:17:59] 10Wikipedia-App-iOS-App: Average load time of an article is over 5 seconds - https://phabricator.wikimedia.org/T89517#1058153 (10Deskana) [05:18:06] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Hone in on, and eradicate, article load time performance issues - https://phabricator.wikimedia.org/T90255#1058156 (10Deskana) p:5Normal>3High [05:25:58] 10Wikipedia-App-Android-App: Returning to the main home screen and back -the main page is displayed instead of recent search - https://phabricator.wikimedia.org/T89186#1058158 (10Deskana) p:5Triage>3Normal [06:04:41] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Leading images displayed blurry due to low resolution of the original file - https://phabricator.wikimedia.org/T87827#1058165 (10Deskana) This sounds more like a bug than a design issue. [06:24:13] (03PS1) 10Deskana: Fix button text incorrectly appearing in ALLCAPS. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192274 (https://phabricator.wikimedia.org/T87595) [06:33:12] 10Wikipedia-App-Android-App, 10MediaWiki-API, 10MediaWiki-User-login-and-signup: Logging in using a temporary password is reported as "incorrect password" - https://phabricator.wikimedia.org/T67857#1058181 (10Deskana) [06:34:35] 10Wikipedia-App-Android-App: Add feature to highlight text - https://phabricator.wikimedia.org/T70272#1058183 (10Deskana) p:5Triage>3Low [06:35:04] 10Wikipedia-App-Android-App: Some characters not displayed - https://phabricator.wikimedia.org/T71409#1058184 (10Deskana) 5Open>3stalled [06:36:05] 10Wikipedia-App-Android-App: When trying to create an account, Android mobile app doesn't show error messages from AntiSpoof extension, blocking registration with no explanation - https://phabricator.wikimedia.org/T74331#1058185 (10Deskana) [06:37:03] 10Wikipedia-App-Android-App: Article rotations pull and stretch lead images in very bizarre ways - https://phabricator.wikimedia.org/T75345#1058188 (10Deskana) p:5Triage>3Lowest [06:43:54] (03PS1) 10Deskana: Don't display last modified message on main page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192276 (https://phabricator.wikimedia.org/T78005) [06:51:53] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 5Patch-For-Review: Address requests for Share a Fact from Legal - https://phabricator.wikimedia.org/T86843#1058219 (10Deskana) 5Open>3Resolved Pretty sure this is on both apps right now. [06:52:00] Deskana: nice patches! :) [06:52:57] YuviPanda: Heh, I'm intentionally picking easy ones. [06:53:03] YuviPanda: I was proud of this one though: https://gerrit.wikimedia.org/r/#/c/191536/ [06:53:12] did your patch to mw core go somewhere? [06:53:23] Deskana: nice! [06:53:33] Wrote the schema, implemented the schema, validated that the data was being sent. Only took like 10 minutes. [06:53:48] niiice :) [06:54:01] YuviPanda: Nope, it's in review hell: https://gerrit.wikimedia.org/r/#/c/182886/ [06:54:13] 14 patchesets later I gave up. [06:54:39] ah [06:54:44] well, account creation / login is hairy as fuck [06:54:54] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10MediaWiki-extensions-PageImages: PageImages shouldn't return images that are not in the lead section - https://phabricator.wikimedia.org/T87336#1058228 (10Deskana) [06:54:54] and I'm commending you on even going that far... [06:55:12] I learned first hand how fucked MediaWiki core is [06:55:16] So I got that out of it at least [06:55:34] The fact that I could write a function to validate a username that a user put in and do it without the function having any parameters... [06:55:44] Because globals. [06:55:52] :D [06:56:09] I actually had to expend effort to make it static [06:56:40] * Deskana shrugs [06:56:57] I'm glad the apps necessitate a different technology stack [06:56:59] I'll put it that way [06:57:02] Deskana: I have only 4 patches to mwcore ever :) [06:58:25] Deskana: you should try writing tools at some point. Clean slate start every time [07:00:42] Tempting! [07:01:10] I was thinking about a simple service, actually. [07:01:20] Nothing other than a table as the backend [07:10:19] * Deskana goes to sleep [07:11:46] Deskana|Away: :) indeed, and you can do it in whatever language you want. [07:11:58] Deskana|Away: I recently added 'first class' support for python and nodejs as well, to go with our support for php [07:12:18] YuviPanda: whoa awesome!!! [07:12:50] mhurd: :D [07:13:06] mhurd: I might add ruby support at some point as well. unsure. [07:14:19] YuviPanda: very cool [07:28:09] morning [07:28:24] hi joakino [07:28:26] morning [07:28:38] back from holidays YuviPanda [07:28:44] joakino: did you and phuedx read the email link I sent you guys? [07:28:45] yeah :) [07:28:56] YuviPanda: not yet, i was on a trip to london the last few days [07:29:00] aaaah [07:29:01] nice [07:29:06] i'll do it in a bit [08:13:36] (03PS13) 10Mhurd: WIP: Native component beneath webView. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 [08:17:11] joakino: cool [08:52:09] YuviPanda: awesome link [08:52:13] i'll have a look soon [08:52:45] joakino: :) tools.wmflabs.org has a list of tools people run on it [08:53:47] cool, there is a ton of stuff [08:54:07] joakino: yeah, the tools developer community is, I think, bigger than the MW core/ext dev community [08:54:10] with lots of overlap [08:55:19] YuviPanda: that seems normal to me. it is a bit cumbersome to get into the mw/core/ext development processes compared to just making some toos [08:55:21] tools [08:55:26] joakino: yeah. [08:56:14] joakino: in fact, if you give me your usernames on wikitech/gerrit I can grant you shell acces right away, and after that it is 100% self serve [08:56:54] YuviPanda: i think i already have it, user is jhernandez [08:57:12] i ssh'd into somewhere some time ago but haven't had time to dive into it [08:57:24] joakino: right [08:57:27] YuviPanda: i'll make good use of that link you sent, seems really complete and useful [08:57:36] joakino: yeah, although could be organized better. [08:57:39] is on my todo [08:57:45] haha [08:58:07] huge todo lists ftw :p [08:59:18] joakino: :D [09:09:34] (03PS14) 10Mhurd: WIP: Native component beneath webView. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 [09:13:25] morning [09:13:57] YuviPanda: that link is awesome [09:14:00] ^ joakino [09:14:03] phuedx: :D [09:14:19] that's basically everything that i think we'd need to do super-experimental stuff [09:14:36] i have no problem having a 10 minute meeting to pat you on the back ;) [09:14:45] phuedx: :) [09:14:58] phuedx: there are caveats! [09:15:02] 'course [09:15:07] phuedx: basically, 'failure is an option'. Don't expect production level uptimes. [09:15:07] decisions must be made! [09:15:09] that's basically it [09:15:28] phuedx: although our uptimes have been fairly good recently. just not as good as prod [09:15:31] YuviPanda: but the more we use it, the more it becomes part of the process, the less that's a problem [09:15:35] phuedx: right. [09:15:38] because it'll be a /product/ [09:15:49] right now, "product" is my buzzword [09:16:01] phuedx: also, you can't hit labs from production. so you can't have an AJAX call from en.m.wikipedia.org to tools.wmflabs.org/supercoolthing/something [09:16:08] (you can hit production from labs) [09:16:27] that's basically the caveats from the infrastructure side :) [09:16:34] YuviPanda: in my head that's not a big deal [09:16:47] however, that requires better APIs to support experiments on labs [09:16:56] or, at least, better api clients [09:17:08] phuedx: you also have readonly access to live replicas of the databases. [09:17:25] YuviPanda: but we have access to storage, right? [09:17:28] phuedx: so the same databases that quarry has access to, any tool running on this also has access to. [09:17:42] phuedx: yes, you have NFS access. about 15T of storage atm, we're expanding later this week. [09:17:48] :o [09:17:51] that'll do ;) [09:18:00] phuedx: and a mysql database where you can do whatever. [09:18:12] phuedx: also a postgres database, but access to that is on a per-request basis [09:18:28] phuedx: *and* a redis instance where you can do a lot of things [09:18:33] YuviPanda: my thing is, i think we should build lightweight standalone apps that hit mw apis until we've proven that what we're building is a core product [09:18:43] phuedx: I agree, yeah. [09:18:53] right now, i think labs is the answer [09:19:02] reading that page, i still think labs is the answer [09:19:18] phuedx: problem is going to be how you are going to expose it to people. if you build it in mobile frontend, you can basically say 'show this to 1% of all people' or something like that, and you have a large audience at the ready [09:19:23] how will you do that with tools? [09:19:43] well that's a toughy [09:19:52] i don't think mf is quite the right thing to build as a standalone app [09:20:04] however, gather, imo, would be a good candidate [09:20:07] as would wikigrok [09:20:27] as would a few other microcontrib ideas [09:20:31] ^ joakino: thoughts? [09:22:59] surfacing experiments on mw.org/wikis would be… interesting… but not impossible [09:23:14] but i think a good first step would be standalone things that we can publicise [09:23:31] phuedx: right. [09:23:56] phuedx: also, if you build them as php + js, you can easily just re-use the code when you move it into MW [09:24:01] ^ that [09:24:13] bbiab [09:24:14] I'm not sure of the current state of MW code and how easy / hard it makes it, though [09:24:18] i have a meeting with a neighbour [09:24:22] :/ [09:24:24] phuedx: makes sense if we have a good bucketing/ab testing infrastructure from core/mf [09:24:25] over hangouts? :) [09:24:27] sounds more ominous than it is [09:25:16] joakino: phuedx you can *link* to tools from prod, of course. so you can run experiments where you show 1% of people a link / button to an experiment and have them click it [09:27:13] YuviPanda: given that bucketing infrastructure, same could go for ajaxing with cors, right? [09:27:35] joakino: so, there are a couple of things to consider there. [09:27:51] joakino: one is, you can't make a serverside call from prod to labs - it is prevented via a firewall. [09:28:20] joakino: cors *should* be ok if you bucket it small enough (lots of gadgets do this already) [09:28:42] joakino: I'll check with other labs admins, etc as well, but my understanding is that it's ok to do that. [09:29:00] YuviPanda: aha [09:29:23] didnt know about the firewall in prod [09:29:31] 6Mobile-Web, 10Phabricator.org, 7Mobile: Ability to designate sub-workboards in Phabricator - https://phabricator.wikimedia.org/T78225#1058377 (10Qgil) [09:29:41] so no use of those apis from the backend then [09:29:53] joakino: yeah. [09:30:06] joakino: in general, you should consider toollabs to be a 'separate' thing. [09:30:20] build / prototype on toollabs, then 'productize' into something else [09:30:36] joakino: https://tools.wmflabs.org/wikidata-game for example. [09:31:52] 6Mobile-Web, 10Phabricator.org, 7Mobile: Ability to designate sub-workboards in Phabricator - https://phabricator.wikimedia.org/T78225#1058378 (10Qgil) I still think that the principle of one workboard for one project is the right approach here. Projects are cheap. Subprojects are somewhere in Phabricator's... [09:32:21] YuviPanda: the thing is for wmf they want the experiments to be mixed into prod wikis for better traffic/exposure so that they can get better metrics [09:32:31] so it usually means the experiments are quite coupled with wikipedia [09:32:40] joakino: yup. so that's the thing you gotta solve :) [09:32:50] so that should be an extension for the integration with hooks, and the rest could be on tool labs [09:33:07] joakino: or you can enable gadgets on mobile :) [09:33:15] but that's js only too... [09:33:30] but we need basic infrastructure for bucketing features [09:33:55] right [09:34:57] YuviPanda: i don't know anything about gadgets, don't look at me :P http://m.memegen.com/1eyqgm.jpg [09:38:09] joakino: https://www.mediawiki.org/wiki/Extension:Gadgets [09:38:22] joakino: I personally think Gadgets for frontend + toollabs backend would solve problems [09:38:36] but there are several others who don't want to let gadgets touch Mobile at all :) [09:38:44] bundle exec mediawiki-selenium-init [09:38:47] oops shit [09:40:51] YuviPanda: well having the code live in mw and be editable by admins doesn't seem very sensible for wmf and dev team supported products [09:41:00] i can understand the pain of some [09:42:02] well, what this means is that atm if someone from the 'community' wanted to test something like wikigrok they would have a much easier time since they will just use gadgets on desktop, a backend on toollabs and be done with it. [09:42:14] YuviPanda: new extension + hooks wouldn't be a bad solution if it wasn't for the tediousness of getting it set up, how brittle mw extension dependency management is, and how jenkins still can't crosstest extensions in anything other than phpunit [09:42:31] plus security / arch review [09:42:36] true [09:42:40] and we basically have one person who does security review [09:43:35] YuviPanda: so can you version and publish gadgets from a git repo? [09:43:42] or make them read only? [09:44:09] joakino: you can't make them readonly, but yeah, you can publish them from a git repo (post push hook that just writes to the appropriate wiki page) [09:44:34] and as for readonly, I do trust wiki admins to not do very stupid things :) [09:46:03] joakino: but that's a decision for you guys as a team to make. I'm just poingint out the alternatives. [09:48:30] YuviPanda: ok thanks, its nice to know. i figure there is fear to having to mantain code that can be pushed in production by editing a wiki page, seems like it could be a nightmare if admins miss behave, but you have a point on trusting admins to not do stupid things [09:49:26] joakino: yes, that's why they are admins... [09:51:32] YuviPanda: aha :) [09:55:02] (03PS2) 10Jhernandez: WIP: Setup browser tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191083 [10:00:08] (03CR) 10Jhernandez: "Still getting the same error" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191083 (owner: 10Jhernandez) [10:03:36] (03CR) 10Jhernandez: [C: 032] Protect storage json pages for collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191600 (owner: 10Jhernandez) [10:03:38] (03CR) 10jenkins-bot: [V: 04-1] Protect storage json pages for collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191600 (owner: 10Jhernandez) [10:05:57] (03PS5) 10Jhernandez: Protect storage json pages for collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191600 [10:07:14] joakino: phuedx can you guys respond on the thread? [10:07:56] YuviPanda: y [10:08:51] cool [10:11:00] (03CR) 10Florianschmidtwelzow: Protect storage json pages for collections (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191600 (owner: 10Jhernandez) [10:18:37] (03PS6) 10Jhernandez: Protect storage json pages for collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191600 [10:19:35] (03CR) 10jenkins-bot: [V: 04-1] Protect storage json pages for collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191600 (owner: 10Jhernandez) [10:20:56] oh cmon [10:22:39] (03CR) 10Jhernandez: "flow failed tests ... wtf" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191600 (owner: 10Jhernandez) [10:51:27] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191600 (owner: 10Jhernandez) [10:53:45] (03CR) 10Jhernandez: [C: 032] "wtf non deterministic tests..." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191600 (owner: 10Jhernandez) [10:54:44] (03Merged) 10jenkins-bot: Protect storage json pages for collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191600 (owner: 10Jhernandez) [11:09:31] back [11:09:32] finally [11:10:36] i have enjoyed reading the scrollback [11:11:30] although the phrase "bucketing infrastructure" makes me giggle [11:11:37] you mean the mod operator, right? ;) [11:11:51] joakino, YuviPanda|brb: https://github.com/phuedx/mwext-PlanOut [11:11:56] ^ experiment infrastructure [11:11:59] SCIENCE! [11:18:02] 10Wikipedia-App-Android-App: Wikipedia Android is contributed anonymous if username is in Korean - https://phabricator.wikimedia.org/T90428#1058556 (10Ara) 3NEW [11:26:40] phuedx: :D [11:32:55] (03CR) 10Phuedx: [C: 032] Hygiene: Don't set robots policy for a skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191374 (owner: 10Florianschmidtwelzow) [11:43:29] phuedx: glad you found it useful [11:44:00] YuviPanda|brb: ? [11:48:26] phuedx: the help page [11:48:34] I often despair of its state [11:48:51] it confirmed a lot of what i already suspected [11:49:11] maybe needs a few recipes and to be a little less verbose but well [11:49:15] v1? ;) [11:54:37] (03CR) 10Phuedx: "@Bmansurov: I don't see version C being inserted into the page twice. Could you provide more detail?" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191358 (owner: 10Phuedx) [11:58:23] phuedx: it has been around for 2y now :) [11:58:35] I need to sit and redo it [11:59:24] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191374 (owner: 10Florianschmidtwelzow) [12:01:39] (03CR) 10Phuedx: [C: 032] Hygiene: Don't set robots policy for a skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191374 (owner: 10Florianschmidtwelzow) [12:34:00] (03PS1) 10Jhernandez: UserPageCollectionsList shows collection images [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192302 [14:01:13] (03PS1) 10Jhernandez: Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 [14:02:19] (03CR) 10jenkins-bot: [V: 04-1] Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [14:17:15] (03CR) 10Dbrant: [C: 04-1] "Build fails." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192261 (owner: 10Deskana) [14:23:25] (03CR) 10Dbrant: [C: 04-1] "It's better to add the "textAllCaps" property to the actual Style that these buttons are using (styles.xml -> text_heading_gray) instead o" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192274 (https://phabricator.wikimedia.org/T87595) (owner: 10Deskana) [14:35:51] i have cookies and milk [14:35:56] my day has gotten a lot better [14:37:37] (03CR) 10Dbrant: [C: 032] Promote widgets from alpha to production [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192098 (owner: 10BearND) [14:53:09] (03CR) 10Dbrant: [C: 04-1] "Might as well also check if it's a File page (pageTitle.isFilePage()), since those dates are broken, as well. Also, there's a little too " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192276 (https://phabricator.wikimedia.org/T78005) (owner: 10Deskana) [14:59:46] (03CR) 10Phuedx: [C: 04-1] Hygiene: Follow up "Show edit pencils on all headings" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192187 (owner: 10Florianschmidtwelzow) [15:05:57] 10Wikipedia-App-iOS-App: GIFs don't animate when displayed in the image gallery - https://phabricator.wikimedia.org/T90444#1058939 (10BGerstle-WMF) 3NEW a:3BGerstle-WMF [15:07:07] cookies always work [15:07:36] (03PS7) 10Fjalapeno: Implement new refresh saved pages logic and UI. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 [15:08:39] (03CR) 10Phuedx: [C: 032] Hygiene: Edit pencil images shouldn't overlap floated images. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191924 (https://phabricator.wikimedia.org/T90245) (owner: 10Florianschmidtwelzow) [15:11:03] (03CR) 10Fjalapeno: "@mhurd - found the problem - it was a regression of the queue using the wrong serializer - I needed to update the QueueSingleton after Bri" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [15:13:11] (03Merged) 10jenkins-bot: Hygiene: Edit pencil images shouldn't overlap floated images. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191924 (https://phabricator.wikimedia.org/T90245) (owner: 10Florianschmidtwelzow) [15:17:08] coreyfloyd hey [15:17:16] bgerstle: sup? [15:17:23] i'm making a "codingstyle" .h/.m pair to have a better "canvas" for uncrustify twaeks [15:17:24] tweaks* [15:17:33] ok cool [15:17:36] i can post a gist for you in a bit and we can discuss if you want [15:17:50] sure [15:17:59] 10Wikipedia-App-Android-App, 10MediaWiki-API, 10MediaWiki-User-login-and-signup: Logging in using a temporary password is reported as "incorrect password" - https://phabricator.wikimedia.org/T67857#1058984 (10Anomie) This is somewhat intentional, see T22233. I wouldn't be opposed to returning a distinct erro... [15:21:31] (03PS4) 10Dbrant: Use icons in Gallery license information. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191910 [15:24:20] coreyfloyd https://gist.github.com/btgerst/fdfbed21c6db7a838880 [15:27:10] (03PS2) 10Fjalapeno: (WIP) Add Search Suggestions to web view [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191527 [15:30:09] bgerstle_: mybe we put that file in a project on github with our config so we can just clone the project and play with the config. Also we can share our style config with the world™. [15:30:29] coreyfloyd yeah i just had a better idea: including it as a file that actually compiles in the test target [15:30:43] oh you're saying to make it a separate project entirely? [15:30:50] i suppose we could do that too [15:31:07] i think it would be sufficient to keep it in our project and telling people to copy/modify as needed [15:31:40] sounds good [15:31:55] are you just going to update my patch then? [15:32:03] coreyfloyd i could.. [15:32:06] if gerrit would let me [15:32:21] i thin you can - i saw monte do it before [15:32:34] alright i'll give it a shot [15:34:32] (03PS2) 10Bgerstle: Uncrustify (WIP). [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [15:34:37] w00t [15:34:57] coreyfloyd now you can run uncrustify -c uncrustify.cfg WikipediaUnitTests/WMFCodingStyle.m and see the diff [15:35:04] you'll see the case statement i was talking about [15:35:15] i also can't get it to leave my one-line else if ... alone [15:35:27] boom goes the dynamite http://media3.giphy.com/media/H6jVFw6KGRNmM/200.gif [15:35:27] (03PS3) 10Deskana: Update app store description for translation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192261 [15:35:52] wtf haha [15:36:17] bgerstle: it was getting rid of one liners on purpose [15:38:08] (03PS2) 10Deskana: Fix button text incorrectly appearing in ALLCAPS. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192274 (https://phabricator.wikimedia.org/T87595) [15:39:43] also, do we really want to align all the = on mulitple assignments? [15:41:02] bgerstle: i dont think we need to [15:41:14] i can remove that [15:41:52] coreyfloyd i've got a local patch for it [15:41:58] there were some other things i tried to tweak too [15:42:13] like pointer spacing [15:42:20] to conform to our style (no space) [15:42:28] err NSString* over NSString * [15:43:37] you want to push those 2 changes? And I can work on the enum? [15:44:06] k [15:45:34] bgerstle_: what in particular is it doing to your enum that you want to change? [15:45:50] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: Sub-section edit icon floats over images - https://phabricator.wikimedia.org/T90245#1059030 (10phuedx) 5Open>3Resolved [15:47:54] coreyfloyd it's the switch statement [15:48:02] it bumps the cases back to the left [15:48:04] oh - sorry [15:48:12] ok looking [15:49:14] (03PS3) 10Bgerstle: Uncrustify (WIP). [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [15:49:19] coreyfloyd ^ [16:07:28] (03PS2) 10Deskana: Don't display last modified message on main page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192276 (https://phabricator.wikimedia.org/T78005) [16:07:39] dbrant: Does this work for the spacing? ^ [16:11:33] (03CR) 10Zfilipin: "Are you free tomorrow (Tuesday) to pair on this? Ping zeljkof on #wikimedia-releng or create a hangout." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191083 (owner: 10Jhernandez) [16:16:27] bgerstle_: fixed the case statement [16:16:48] cool [16:17:18] Deskana: yeah, that could work. The padding is now smaller than before, but i kind of like it that way. [16:17:44] dbrant: btw, I was thinking about adding convenience methods to the Page class to check if a page is a file page or main page [16:17:58] dbrant: It's kind of clunky how you have to know to getPageProperties() for main page and getTitle() for file pages [16:18:06] dbrant: You should be able to run those methods on the page itself, imo [16:18:13] dbrant: Does that sound sane to you? [16:18:26] Deskana: yep, sure! [16:19:26] coreyfloyd i fixed the if/else/elseif stuff [16:19:31] i have a fix for the enum too [16:19:36] should i push my changes? [16:20:01] two things left are: identation on and a space between NS_ENUM (NSInteger... [16:20:16] bgerstle_: yeah go ahead [16:21:29] (03PS4) 10Bgerstle: Uncrustify (WIP). [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [16:21:46] bgerstle_: one thing i want to change… if we are putting the opening curlys on the same line as the method signature, then I would like to not "eat blank lines after brace" - i think it is easier to read with breathing room between the method signature and the method content. [16:24:36] dbrant: I'll just add those to that patch and use them there. We can change everywhere else to use them later. [16:24:52] bgerstle_: git review -d is so scary… it just overwrites your directory without warning [16:25:05] Deskana: very good [16:25:12] yeah [16:26:05] (03CR) 10Dbrant: [C: 032] Fix button text incorrectly appearing in ALLCAPS. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192274 (https://phabricator.wikimedia.org/T87595) (owner: 10Deskana) [16:26:46] coreyfloyd yay fixed NS_ENUM [16:26:55] sweet [16:27:00] and somehow indentation...? [16:28:13] ah nope, still there [16:29:03] bgerstle_: you added for 4 values that already exist (nl_brace…, nl_else, and friends… can you combine them?) [16:29:11] yeah sorry [16:29:17] np [16:29:55] just don't want to make sure you set them how you want them - and I don't know what it does with duplicate values exist - so you shoudl probabaly test [16:30:12] probably overrides [16:30:16] yeah it should warn on dupe decls [16:30:17] that's weird [16:30:18] (03PS3) 10Deskana: Don't display last modified message on main page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192276 (https://phabricator.wikimedia.org/T78005) [16:30:58] bgerstle_: be back in a bit - dog walk and brunch [16:32:08] k [16:32:38] (03PS5) 10Bgerstle: Uncrustify (WIP). [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [16:33:02] 10Wikipedia-App-Android-App: Some labels still ALLCAPS - https://phabricator.wikimedia.org/T87595#1059145 (10Deskana) 5Open>3Resolved [16:38:51] (03PS6) 10Bgerstle: Uncrustify (WIP). [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [16:52:03] (03PS7) 10Bgerstle: Uncrustify (WIP). [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [16:52:30] Hey, ignoring capitalization and forcing the English style of it in the Wikidata infobox (alpha mobile website) is highly annoying. [16:53:26] (03CR) 10Bgerstle: [C: 031] "See WMFCodingStyle.m and run uncrustify -c uncrustify.cfg --check -l OC -f WikipediaUnitTests/WMFCodingStyle.m to verify that the current " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [16:55:49] (03PS8) 10Bgerstle: Adds code linting via uncrustify. Run the wrapper script (scripts/uncrustifyw.sh) to lint all project files. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [16:56:03] (03PS9) 10Bgerstle: Adds code linting via uncrustify. Run the wrapper script (scripts/uncrustifyw.sh) to lint all project files. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [17:10:41] 6Mobile-Web, 10MediaWiki-Categories, 5Patch-For-Review: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1059329 (10matmarex) Screenshots: Before: {F45702} # Full support Hilariously, these four browsers provide three different renderi... [17:13:20] 10Wikipedia-App-Android-App: Wikipedia Android is contributed anonymous if username is in Korean - https://phabricator.wikimedia.org/T90428#1059343 (10Deskana) @Ara Can you provide some more information, and steps that we can take to reproduce this problem? We will not be able to investigate this otherwise. Thanks. [17:16:07] 6Mobile-Web, 10MobileFrontend, 7Design, 5Patch-For-Review: Remove mobile editing "call to registration" CTA - https://phabricator.wikimedia.org/T87508#1059352 (10Aklapper) [17:18:44] 10Wikipedia-App-Android-App, 5Patch-For-Review: main page last modified time confusing - https://phabricator.wikimedia.org/T78005#1059372 (10Aklapper) [17:20:49] (03PS2) 10Florianschmidtwelzow: Hygiene: Follow up "Show edit pencils on all headings" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192187 [17:22:45] 6Mobile-Web, 10MediaWiki-Categories: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1059392 (10matmarex) 5Open>3Resolved [17:57:14] (03CR) 10Phuedx: [C: 032] Hygiene: Follow up "Show edit pencils on all headings" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192187 (owner: 10Florianschmidtwelzow) [17:58:18] (03Merged) 10jenkins-bot: Hygiene: Follow up "Show edit pencils on all headings" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192187 (owner: 10Florianschmidtwelzow) [18:05:58] (03PS1) 10BearND: Read more suggestions for main page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192353 [18:06:54] (03PS10) 10Fjalapeno: WIP Adds code linting via uncrustify. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 [18:08:22] (03CR) 10jenkins-bot: [V: 04-1] Read more suggestions for main page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192353 (owner: 10BearND) [18:09:35] (03CR) 10Bmansurov: "Sorry about the false alert. You're right, I don't see it twice either." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191358 (owner: 10Phuedx) [18:09:44] (03PS2) 10BearND: Read more suggestions for main page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192353 [18:14:18] (03PS5) 10BearND: Use icons in Gallery license information. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191910 (owner: 10Dbrant) [18:14:30] (03CR) 10BearND: [C: 032] Use icons in Gallery license information. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191910 (owner: 10Dbrant) [18:14:52] (03Merged) 10jenkins-bot: Use icons in Gallery license information. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/191910 (owner: 10Dbrant) [18:16:30] coreyfloyd did you want me to try rebasing the crashlytics patch? [18:16:46] bgerstle_: if you want to go ahead [18:16:49] k [18:17:38] bgerstle_: standup [18:18:39] bah [18:18:57] mph chrome issues [18:18:58] 1 sec [18:25:18] 10Wikipedia-App-iOS-App: GIFs don't animate when displayed in the image gallery - https://phabricator.wikimedia.org/T90444#1059680 (10brion) It may be necessary to run GIFs in an embedded UIWebView or some such malarkey to get them to animate. :P [18:25:44] (03CR) 10Bmansurov: [C: 032] Remove WikiGrok version A [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191358 (owner: 10Phuedx) [18:26:10] \o/ [18:26:24] yay [18:26:46] (03Merged) 10jenkins-bot: Remove WikiGrok version A [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191358 (owner: 10Phuedx) [18:34:14] dbrant, bearND: Okay, I'm in the hangout for our next meeting! [18:38:45] dbrant: have a minute for quick hangout? [18:38:57] mhurd: in 1/2 hour? [18:39:04] dbrant: ya! [18:39:08] bgerstle: hey! saw my link? [18:39:16] dbrant: i need coffee anyway :) [18:39:16] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Cache visited pages in filesystem instead of ram. - https://phabricator.wikimedia.org/T89826#1059720 (10Deskana) p:5Triage>3Normal [18:39:40] YuviPanda|zzz to the tools wiki page? [18:39:49] YuviPanda|zzz i meant to read it sometime today [18:39:52] sorry i haven't gotten to it yet [18:39:55] bgerstle: yeah. [18:40:09] bgerstle: cool. phuedx and joakino read it and were very, very happy. just wanted to see your reaction :) [18:40:28] YuviPanda|zzz i'm sure i'll be pleased ;-) and if not, majority rules anyway :-P [18:40:34] heh [18:40:43] i'll make a point to read it today [18:40:54] MaxSem: It would be great if you could add your thoughts on WikiGrok aggregation to the WikiGrok aggregation email thread. BTW, Erik has scheduled a meeting for tomorrow morning to discuss WikiGrok user value, etc. so we should have a better idea of what direction we need to go in tomorrow. [18:41:11] (03PS3) 10Bgerstle: Setup crashlytics [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 (owner: 10Fjalapeno) [18:41:31] coreyfloyd dr0ptp4kt Deskana rebased ^ will send build w/ "CRASH ALL THE THINGS" button soon [18:41:56] Deskana can the button be a Wreck It Ralph GIF? please? [18:42:06] bgerstle: thx [18:42:14] bgerstle: thx [18:42:28] dr0ptp4kt: thx [18:42:47] dr0ptp4kt i like surround sound too [18:42:48] bgerstle: i meant to say ha! [18:42:52] bgerstle: thx thx ok ha thx [18:43:13] * bgerstle plays THX synth sound [18:47:24] leila: I was going to work on hand-coding for album data, but I couldn’t find it in Google Docs. I only have the actor data. [18:47:50] kaldari: I can look into it in 30 min would it work? [18:47:59] sure [18:48:06] mhurd dr0ptp4kt do we have anything in the way of a "debug" menu? [18:48:11] bgerstle: Is the gif open source? ;-) [18:48:12] or do i get to add one? [18:48:28] Deskana hrm... i guess it would technically be property of Pixar/Disney [18:48:48] so i'll have to choose another "community" meme [18:49:26] (03CR) 10Yuvipanda: "Is Crashylitics client library open source?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 (owner: 10Fjalapeno) [18:49:33] bgerstle: not at present. are you thinking about adding a “debugging” section to the “More…” menu? [18:50:12] bgerstle: or is this a hidden type menu for us? [18:50:29] mhurd either [18:50:38] it would only show on debug or beta builds [18:50:43] initially i'll do debug only [18:51:34] bgerstle: since it’s only showing on debug/beta builds i’d lean toward just adding a section to the bottom of the more menu [18:51:42] sgtm [18:51:43] hmm kristenlans, we don't have an in dev column in phabricator? [18:51:44] Deskana thoughts? ^ [18:51:50] (on debug menu) [18:52:27] Maxsem: hmm good point :-) [18:52:32] (03CR) 10Yuvipanda: "I think 'third party' in this case would count Twitter itself, no?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 (owner: 10Fjalapeno) [18:52:44] mhurd Deskana w/o getting into scope creep territory.. long term i'd like this "Debug" menu to also house things like feature flags or other app params that are used by team members and external testers only [18:53:21] bgerstle: Sounds fine to me for the long term. Can you make a card for the backlog to document what you'd like in it? [18:53:31] but anyway, for now I'll just but a "debug" option in the "W" menu [18:53:58] bgerstle: in the “W” menu? not the “More…” menu? [18:54:08] Deskana well, the things i'd go in it should be backlog items of their own. the fact that they end up in "Debug" is only relevant to the discussion of what a "Debug" menu can be used for [18:54:20] mhurd yeah "More" works [18:54:26] bgerstle: Well, then make a series of cards. :-) [18:54:29] in Spotify it was in our "app settings" dialog [18:54:35] IT'S... IT'S A SERIES OF CARDS [18:54:43] lol [18:54:47] Deskana quit reminding me that house of cards isn't out yet [18:55:09] ok so, Debug in the "More..." view. done [18:55:21] bgerstle: netflix lies too! it showed up in “new releases” even though it’s not out yet [18:55:29] mhurd i heard about that ;-) [18:55:34] cruel bastards [18:55:54] brb before android/ios split meeting [18:56:08] 6Mobile-Web, 10MobileFrontend: ResourceLoader definition hash for mobile.usermodule changes suspiciously frequently - https://phabricator.wikimedia.org/T90411#1059802 (10MaxSem) a:3MaxSem [18:57:44] (03CR) 10Deskana: "It's not open source, but it's free to use for any purpose." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 (owner: 10Fjalapeno) [18:59:37] Deskana: would you mind forwarding the split meeting invite or hangout link to me? [19:00:37] bearND: Invite sent [19:00:45] https://plus.google.com/hangouts/_/wikimedia.org/app-team-split?authuser=1 [19:00:45] Deskana: ty [19:01:35] (03CR) 10Yuvipanda: [C: 04-1] "fwiw, if you include a closed source blob in your code you are going to implicitly trust them to only do what they say they do, and not an" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 (owner: 10Fjalapeno) [19:02:15] kaldari: ok, i've actually processed your aggregation proposal now :) do you have a sec to chat about it so i can ask you a few dumb questions? [19:02:18] (03CR) 10Legoktm: "Err, so what exactly are the restrictions that the library has? I'm a little confused here." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 (owner: 10Fjalapeno) [19:03:02] Maryana: sure [19:11:23] (03CR) 10Brion VIBBER: [C: 04-1] "Must include the license information for the library and a readme file saying where the library came from and what version it is, so it ca" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 (owner: 10Fjalapeno) [19:14:54] (03CR) 10Brion VIBBER: [C: 04-2] "Hmm, the only legal info I can find is the terms of use page here http://try.crashlytics.com/terms/ which specifically says you can't try " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 (owner: 10Fjalapeno) [19:20:22] (03PS1) 10Bmansurov: Fix close button fix [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192374 [19:20:38] (03PS2) 10Bmansurov: Fix close button click [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192374 [19:21:31] (03PS3) 10Bmansurov: Fix close button click [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192374 [19:28:12] (03CR) 10Jhernandez: "I'll try to find you on irc tomorrow, thanks Zeljko" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191083 (owner: 10Jhernandez) [19:35:11] george gets more excited that later it gets [19:35:15] he doesn't get more tired [19:35:19] i do not understand [19:35:29] a true nightowl [19:35:37] having said that, i'm tired all the time [19:37:46] YuviPanda|zzz: which one? ;) [19:37:59] george of course [19:42:53] lolol https://www.youtube.com/watch?v=FEokEOezF7o#t=266 [19:43:04] great movie haha [19:51:40] kaldari: added album for version b [19:51:47] thanks! [19:51:58] there are very few entries for this campaign with more than 2 responses for question. [19:55:46] (03CR) 10Phuedx: [C: 032] "I've tested the pages locally and it all seems okay to me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190841 (https://phabricator.wikimedia.org/T87614) (owner: 10Florianschmidtwelzow) [19:57:25] (03Merged) 10jenkins-bot: Hygiene: Use Config object in SpecialPages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190841 (https://phabricator.wikimedia.org/T87614) (owner: 10Florianschmidtwelzow) [19:59:12] (03Merged) 10jenkins-bot: Hygiene: Don't set robots policy for a skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191374 (owner: 10Florianschmidtwelzow) [20:18:47] kaldari: are you doing the prioritisation/grooming? [20:41:07] (03Abandoned) 10Robmoen: Json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192043 (owner: 10Robmoen) [20:41:07] phuedx: it’s been rescheduled for weds [20:41:26] kaldari: Just saw your announcement email on templates landing in core. Congratulations! [20:41:30] phuedx: or maybe not [20:41:46] bd808: Thanks! [20:43:39] Maryana, kristenlans: Are we still doing the Mobile Web Story prioritization/Backlog grooming today? [20:44:32] kaldari I have that on my calendar fro 2 PM PT [20:46:15] kaldari do you have concerns about doign it today? [20:47:43] does anyone have the actual copyright license text for the crashlytics libraries? i’m curious where the idea that it’s “free to use for any purpose” came from [20:48:14] kristenlans: let's use that time to look a the bugs/work for the rest of this sprint [20:48:27] cool [20:48:54] we'll have a much better idea of next sprint/rest of quarter by tomorrow morning & can cycle back on wednesday [20:49:17] maryana kaldari 10-4 [20:50:07] the lack of a direct download link and the terms of use i can find are super evil [20:50:58] (03CR) 10Kaldari: Json user page storage for a collection (036 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192043 (owner: 10Robmoen) [20:51:29] oops, reviewed the wrong patch [20:58:15] bgerstle_afk: coreyfloyd brion MaxSem i'm going to schedule a meeting to go over crash reporting in beta [20:58:38] awesome [20:59:13] to summarize my position: if we can confirm the license on the *sdk binary* is ok to redistribute then i’ll whinge but won’t stop ya :) [20:59:29] but i wuv open source moar in theory :) [21:01:05] (03CR) 10Kaldari: [C: 04-1] Add json user page storage for a collection (036 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [21:03:46] (03CR) 10Legoktm: [C: 04-1] "Once again, if you are going to store JSON in wiki pages, please use ContentHandler." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [21:06:56] bgerstle_afk: coreyfloyd i'm setting up a separate meeting to discuss "non-functional" backlog things in order that we can plan out our approach for the next quarter or two [21:07:12] (03PS1) 10Dbrant: Improve moving of infoboxes to end of first paragraph. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192452 (https://phabricator.wikimedia.org/T77802) [21:10:26] (03PS1) 10BearND: Avoid NPE when upserting page thumbnails [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192453 [21:11:33] (03CR) 10Alex Monk: [C: 04-2] "No." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 (owner: 10Fjalapeno) [21:12:09] (03PS2) 10Dbrant: Improve moving of infoboxes to end of first paragraph. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192452 (https://phabricator.wikimedia.org/T77802) [21:12:23] brb [21:19:03] 6Mobile-Web, 10WikiGrok: WikiGrokDialogs not using View##event - https://phabricator.wikimedia.org/T88296#1060388 (10bmansurov) [21:26:08] 6Mobile-Web: MobileFrontend should use new Config features instead of global variables - https://phabricator.wikimedia.org/T87614#1060433 (10Florian) [21:27:25] bearND: good call with the try-catch around upsert(), but let me run this by you: [21:28:24] bearND: what if we make our SaneAsyncTask even more sane by allowing exceptions to be thrown in onFinish, and passing them on to onCatch? That way you won't need a separate try-catch block inside onFinish... [21:29:01] dr0ptp4kt: BTW, if you guys want I can help with getting the back end for the OSS crash reporter set up on labs [21:29:11] I should do that for android too I guess [21:29:25] (Am in a bus, just can't sleep) [21:29:37] YuviPanda|zzz: thx [21:32:43] 6Mobile-Web: Create button abstraction - https://phabricator.wikimedia.org/T87254#1060479 (10bmansurov) Why not directly transition OOJS UI instead of this intermediate step? [21:39:57] (03CR) 10Legoktm: [C: 032] Update ApiResult handling for mediawiki/core change I7b37295e [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/183609 (owner: 10Anomie) [21:42:36] dr0ptp4kt sounds good [21:42:41] (regarding NFR planning) [21:42:43] (03Merged) 10jenkins-bot: Update ApiResult handling for mediawiki/core change I7b37295e [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/183609 (owner: 10Anomie) [21:43:04] YuviPanda|zzz that's a generous offer, but let's hope it doesn't come to that ;-) [21:45:52] dbrant: I like that idea. I'll amend that patch to do so [21:50:56] 6Mobile-Web, 10MobileFrontend: ResourceLoader definition hash for mobile.usermodule changes suspiciously frequently - https://phabricator.wikimedia.org/T90411#1060553 (10MaxSem) Mmm... ``` $ grep -oP 'New definition hash for module mobile\.usermodule.*$' resourceloader.log | grep -oP '2015\d+T\d+' | sort | un... [21:53:29] (03PS2) 10BearND: Avoid NPE when upserting page thumbnails [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192453 [21:54:59] (03PS3) 10BearND: Catch exceptions in SaneAsyncTask.onFinish [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192453 [21:55:17] dbrant: ^ changed the commit msg [22:00:32] mhurd dr0ptp4kt where's the "more" view controller? [22:01:43] bgerstle_: i think you want to peruse SecondaryMenuViewController cc mhurd [22:02:23] looks like i want ModalMenuAndontentViewController? [22:02:56] the more button callback is creating a "modal_segue_show_secondary_menu [22:03:04] hrmm [22:04:40] all of this is just asking to be on the refactoring chopping block [22:05:24] leila: I’m not sure exactly how to translate the hand-coding in the spreadsheet into useful data. Instead of having a freq column, could we have ‘total responses’ and ‘% positive responses’ columns? That would make it easy to analyze for optimizing thresholds. [22:05:28] i see dr0ptp4kt, you were right [22:05:35] had to point & click about 10 times in the storyboard to confirm [22:05:49] bgerstle_: every now and then i get one thing right :) [22:06:11] bgerstle_: wait, your comp didn't freeze when you opened the storyboard? ;) [22:06:16] i should've just been able to "Open Quickly" -> "MoreViewController" [22:06:21] dr0ptp4kt i saw the beachball for a bit ;-) [22:11:14] phuedx: can you help us estimate something for a sec? [22:11:16] :) [22:11:33] the thing you suggested we do before new page header in alpha & beta [22:12:11] (03CR) 10BearND: "Just a small question -- inline." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192452 (https://phabricator.wikimedia.org/T77802) (owner: 10Dbrant) [22:13:20] phuedx: hey, did you get a chance to write up your experience of setting up wikidata locally? [22:16:46] \\ [22:16:58] oops, trying to clean my keyboard :) [22:20:09] Maryana: sorry, was afk – i was feeding harry [22:20:11] are y'all good? [22:20:19] (it's 10:20 pm here) [22:20:32] bmansurov: nopers, but i can do it tomo morning [22:20:48] phuedx: ok thanks [22:20:56] * phuedx opens up his notes for the morning [22:25:26] dbrant|brb: ping me if you have time for quick hangout this afternoon [22:26:53] mhurd: hey! ready when you are [22:29:28] dr0ptp4kt: bgerstle: the logic behind the primary/secondary naming convention for the menu view controllers (vs naming them “WMenuViewController” and “MoreMenuViewController”) is that early on we recognized that the primary menu items may not always be tied the the “W” button - there was discussion about potentially surfacing it in different ways in the future. For the secondary (more) menu it is named as it is primarily beca [22:29:29] that exposes it has not always said “More…” [22:30:10] dr0ptp4kt: bgerstle initially the “More…” menu button just said “…” [22:30:36] given the flux i thougth it wise not to tie the name of the file to the changing button caption [22:31:21] Maryana: also, i'm buying tickets for two gigs: jajob and nordic giants [22:31:30] the latter of which you should check out [22:31:33] also, jakob [22:31:38] because i can spell proper good [22:31:43] jajob sounds way cooler [22:32:59] … [22:33:06] dr0ptp4kt: bgerstle more background - design/ux went through various mocks and tried really hard to condense/reduce menu to keep it to an absolute minimum, hence the very few items on the primary menu, and a single secondary menu. [22:33:50] so that also informed the naming to some extent - to remind us primary was for things which are truly primary [22:34:31] mhurd: all good here [22:34:32] phuedx: i will investigate. they're coming stateside? [22:34:44] jakob maybe [22:34:48] nordic giants [22:34:53] probably not [22:35:09] i think they're moving to sweden [22:35:35] you can't have all of the nice things over there y'know [22:36:37] Maryana: https://www.youtube.com/watch?v=TxeBiUnKOEM [22:36:52] featuring a speech from chaplin's the great dictator [22:36:55] lovely stuff [22:36:55] kaldari https://trello.com/c/ZXMvPeN2/13-expose-the-sidebar-to-other-extensions [22:37:22] phuedx: so you're saying i should go to sweden to see a band with you? sounds legit :D [22:37:32] * Maryana goes to buy plane tix [22:38:38] mhurd: got some time now [22:38:59] (03PS5) 10Dr0ptp4kt: Don't include article snippet in "Share as text" option [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190637 (https://phabricator.wikimedia.org/T89541) (owner: 10Deskana) [22:39:05] i think this year will be the first year i've travelled to another country to see a band [22:39:38] okie folks, i'm gonna head orf to bed [22:39:48] i'm being told that is no longer computer time [22:39:54] mhurd: coreyfloyd would you please review https://gerrit.wikimedia.org/r/190637 ? that's the update based on eventlogging stuff. it's not uncrustified. [22:40:14] dr0ptp4kt: sure [22:40:47] mhurd: can you check out my saved pages patch [22:40:52] if you havent already [22:41:01] mhurd: want to get it merged [22:41:15] coreyfloyd: will do! [22:44:45] coreyfloyd: okay if i quick add a couple additional nsasserts? [22:44:54] coreyfloyd: ...and resubmit? [22:45:46] dr0ptp4kt: suere [22:45:50] mhurd: thanks [22:45:52] coreyfloyd: thx, and sorry... [22:55:00] dr0ptp4kt: np [22:55:22] dr0ptp4kt: mhurd bgerstle walking the dog before dark back in a few [22:55:48] coreyfloyd: cool, i'll resubmit that thing shortly [22:57:42] (03PS6) 10Dr0ptp4kt: Don't include article snippet in "Share as text" option [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190637 (https://phabricator.wikimedia.org/T89541) (owner: 10Deskana) [22:57:47] mhurd: ^ updated [23:14:57] bgerstle_: you there? [23:15:01] yeah [23:15:09] durnit IRC lemme keep my name [23:15:15] bgerstle_: got 5-8 mins to talk on video? [23:15:22] yeah [23:15:27] bgerstle: i'll call you [23:20:52] (03PS4) 10BearND: Update app store description for translation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192261 (owner: 10Deskana) [23:21:02] (03CR) 10BearND: [C: 032] Update app store description for translation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192261 (owner: 10Deskana) [23:23:29] (03Merged) 10jenkins-bot: Update app store description for translation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192261 (owner: 10Deskana) [23:28:48] coreyfloyd: okay, i updated https://gerrit.wikimedia.org/r/190637 ...gotta run to a meeting now [23:29:16] i'm heading out for a bit as well. might be on later. otherwise, night all o/ [23:29:33] later bgerstle_ [23:31:39] coreyfloyd: k, back online. if it looks okay when you're done with it, mind pinging mhurd so he can do the final code review on it? [23:35:01] (03CR) 10Fjalapeno: [C: 04-1] "Adam only 1 real thing i noticed (the funnel method) , eveything else is just little stuff. Otherwise looks good." (035 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190637 (https://phabricator.wikimedia.org/T89541) (owner: 10Deskana) [23:45:48] (03CR) 10Mhurd: [C: 04-1] "Hey Corey! I made some notes and a quick example to summarize what we chatted about last week. It looks like this patch just rebased w/o t" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191527 (owner: 10Fjalapeno) [23:47:17] (03CR) 10Mhurd: "Gah! apologies for the line wrapping on that last comments..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191527 (owner: 10Fjalapeno) [23:48:19] (03PS1) 10Bmansurov: Add ButtonWithSpinner and re-create 'Report an error' button using it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192473 [23:48:47] coreyfloyd: reposting those comments - i made a typo anyway saying “search suggestions” when i meant “read more” [23:51:08] (03CR) 10jenkins-bot: [V: 04-1] Add ButtonWithSpinner and re-create 'Report an error' button using it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192473 (owner: 10Bmansurov) [23:52:01] (03CR) 10Mhurd: "(Updated for better work wrapping and change "search suggestion" to "read more")" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191527 (owner: 10Fjalapeno) [23:52:25] (03CR) 10Fjalapeno: "@mhurd - yeah it is just the rebase - nothing internal yet - just want to make sure everything is good with the rebase first." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191527 (owner: 10Fjalapeno) [23:52:37] coreyfloyd: sounds good [23:53:02] coreyfloyd: reviewing pull to refresh... [23:53:56] mhurd: dunka [23:54:03] fingers crossed [23:54:52] (03PS2) 10Bmansurov: Add ButtonWithSpinner and re-create 'Report an error' button using it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192473