[00:11:11] coreyfloyd: so close!!! [00:11:26] coreyfloyd: it’s updating articles now [00:11:49] coreyfloyd: it’s not blasting saved entries if you refresh w/o interwebs connection [00:11:54] coreyfloyd: but... [00:12:22] coreyfloyd: article pull to refresh is blasting cache if no interwebs [00:12:23] :( [00:12:50] coreyfloyd: quick hangout? [00:24:54] mhurd: sorry off working in the corner [00:24:57] mhurd: just a sec [00:26:03] 6Mobile-Web: Put link to desktop version in mobile front end at the top rather than at the bottom - https://phabricator.wikimedia.org/T89448#1061030 (10MaxSem) 5Open>3declined a:3MaxSem I also don't think it's a good idea. No matter where you place this link, some people will still fail to notice it. This... [00:39:01] (03PS4) 10BearND: Don't display last modified message on main page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192276 (https://phabricator.wikimedia.org/T78005) (owner: 10Deskana) [00:39:14] (03CR) 10BearND: [C: 032] "wfm" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192276 (https://phabricator.wikimedia.org/T78005) (owner: 10Deskana) [00:45:16] (03Merged) 10jenkins-bot: Don't display last modified message on main page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192276 (https://phabricator.wikimedia.org/T78005) (owner: 10Deskana) [00:45:45] (03PS3) 10BearND: Read more suggestions for main page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192353 [00:58:42] (03CR) 10BearND: [C: 04-1] "I'd rather have something like Monte's patch for moving a

tag up instead of infoboxes down. See transform "moveFirstGoodParagraphUp" i" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192452 (https://phabricator.wikimedia.org/T77802) (owner: 10Dbrant) [01:31:41] (03CR) 10Mhurd: "One tiny tweak! Damn you iOS 6!!!! :)" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [01:31:46] 10Wikipedia-App-Android-App, 5Patch-For-Review: main page last modified time confusing - https://phabricator.wikimedia.org/T78005#1061151 (10bearND) 5Open>3Resolved a:3bearND [01:37:52] (03CR) 10Mhurd: [C: 031] "+1 for now as these last 2 comments can come as a follow-on patch if you'd like." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [01:43:02] (03PS1) 10Bmansurov: WIP: Localize english texts [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192491 [03:47:14] 10Wikipedia-App-iOS-App: Article caches are being removed unnecessarily when network connection in lost - https://phabricator.wikimedia.org/T90525#1061244 (10Fjalapeno) 3NEW [03:47:57] 10Wikipedia-App-iOS-App: Article caches are being removed unnecessarily when network connection in lost - https://phabricator.wikimedia.org/T90525#1061252 (10Fjalapeno) [04:21:19] (03PS11) 10Fjalapeno: Adds code linting via uncrustify. Install the pre-commit git hook by running ./scripts/setup_git_hooks.sh Uncrustify all files manually by running ./scripts/uncrustify_all.h Update README for dependencies, install instructions, etc… [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 [05:01:35] (03CR) 10Yuvipanda: "I've setup an instance of Quincy on toollabs (https://tools.wmflabs.org/ios-crashes/quincy/test_setup.php). You can use it with https://gi" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 (owner: 10Fjalapeno) [06:20:14] YuviPanda: I found a stupid bug in the app but my JS isn't good enough to fix it. [06:22:10] Deskana: wooo, link? [06:22:24] YuviPanda: https://phabricator.wikimedia.org/T88636 [06:22:40] Basically, the JS that's scraping the disambiguation is looking at the *displayed* HTML to get the page title [06:22:44] Not the actual link [06:23:31] I'm basically trying random things in JS to get it to work [06:27:14] Wait, I think I know what to do... [06:28:07] Deskana: ugh, sorry, there's a labs outage, helping there atm [06:39:03] YuviPanda: Well I fixed it but my solution is ridiculous. [06:41:26] * Deskana shrugs [06:41:56] Deskana: JS is ridiculous, so by that meter everything using JS is as well [06:42:02] var pageTitle = links[i].toString(); [06:42:02] pageTitle = pageTitle.substring(pageTitle.indexOf("/wiki/") + 6); [06:42:02] pageTitle = pageTitle.split("_").join(" "); [06:42:04] res.push( pageTitle ); [06:42:59] Deskana: I wonder if the problem is with the : in the title? [06:43:14] perhaps our page parsing code is trying to count everything before that as a namespace? [06:43:29] YuviPanda: If you look at this, you see the issue: https://en.wikipedia.org/w/api.php?action=mobileview&page=Jellyfish&prop=text§ions=0 [06:43:30] I remember running into this problem in the initial PageTitle parsing code, don't remember if I fixed it or not... [06:43:41] Erm, no you don't. [06:43:48] If you look at this [06:43:49] https://en.wikipedia.org/w/api.php?action=mobileview&page=Star%20Trek%20III&prop=text§ions=0 [06:44:12]

\"Star Trek 3\" redirects here. For the proposed 2016 sequel to the 2013 film of the same franchise, see Star Trek Into Darkness \u00a7 Sequel.
[06:44:29] So what is happening is the current JS is taking the displayed HTML to be the page title [06:44:41] aaaaaahhhhh [06:44:44] I see [06:44:46] In most cases that works, but in this case the displayed HTML (Star Trek Into Darkness \u00a7 Sequel) is different from the link (Star_Trek_Into_Darkness#Sequel) [06:44:54] that's in general a bad idea in wikitext generated HTML [06:45:20] we had a method in Java that parsed internal links like /wiki/Star_Trek_Into_Darkness#Sequel into appropriate ones [06:45:30] so why not just pass the entire internal link up and parse the PageTitle out of that? [06:45:37] rather than muck around in JS and re-create the logic? [06:46:20] Oooh [06:46:34] Deskana: that’s what we do for link clicks also [06:46:41] NICE [06:47:42] Deskana: and it even has unit tests and stuff [06:51:16] * Deskana tries that, when Android Studio decides it wants to unfreeze [06:52:19] Deskana: :D [06:55:35] Gradle is stuck. Eurgh. [07:00:07] I think Gradle is messed up. [07:00:15] I even did a full restart and it's still not working. [07:19:15] 10Wikipedia-App-Android-App, 10Wikimedia-Hackathon-2015: Add an easier and faster way to change the search language - https://phabricator.wikimedia.org/T87154#1061509 (10Qgil) [07:22:49] YuviPanda: Oh shit, I bet what's wrong with Gradle is that it's timing out trying to connect to labs for something [07:22:57] hahaha [07:22:58] yeah [07:23:00] the maven repos [07:23:01] It's stuck trying to resolve dependencies [07:23:01] are on labs [07:23:09] :-( [07:23:22] we're working on it [07:23:34] also funny labs goes down just after I write an email to mobile-tech about using it for crash reporting [07:23:47] ^_^ [07:23:51] I guess I'll go to sleep [07:24:10] And try again in the morning [07:24:12] Night! [07:24:32] Deskana: :) good night [07:27:35] 10Wikipedia-App-Android-App, 10Wikimedia-Hackathon-2015: Add an easier and faster way to change the search language - https://phabricator.wikimedia.org/T87154#1061511 (10Qgil) @bearND is proposing to work on this task at the #Wikimedia-Hackathon-2015. Just checking, is this task proposed as the main activity f... [07:52:51] YuviPanda: https://gerrit.wikimedia.org/r/#/c/192508/ [07:53:31] 10Wikipedia-App-Android-App: 'Similar pages' link produces 'This page does not exist' - https://phabricator.wikimedia.org/T88636#1061577 (10Deskana) https://gerrit.wikimedia.org/r/#/c/192508/ [07:53:40] 10Wikipedia-App-Android-App, 5Patch-For-Review: 'Similar pages' link produces 'This page does not exist' - https://phabricator.wikimedia.org/T88636#1061578 (10Deskana) [07:54:13] YuviPanda: Really nice! Thanks for the advice. [07:54:31] YuviPanda: And this is a milestone... it's my first patch that touches the app JS. [08:30:39] (03PS1) 10BearND: ShareAFact: EL update [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192505 [08:30:41] (03CR) 10jenkins-bot: [V: 04-1] ShareAFact: EL update [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192505 (owner: 10BearND) [08:30:59] (03CR) 10Legoktm: "Yuvi, you are awesome." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 (owner: 10Fjalapeno) [08:31:01] (03CR) 10Florianschmidtwelzow: "looks good. One problem: The button looks different from the other ones in page-secondary-actions, that looks strange :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192473 (owner: 10Bmansurov) [08:31:07] (03CR) 10Florianschmidtwelzow: [C: 032] Implement design review for beta styles (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191930 (owner: 10Phuedx) [08:31:17] (03Merged) 10jenkins-bot: Implement design review for beta styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/191930 (owner: 10Phuedx) [08:31:37] (03PS1) 10Deskana: Fix disambiguation links that point to specific sections to work properly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192508 [08:31:43] (03PS2) 10Deskana: Fix disambiguation links that point to specific sections to work properly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192508 [08:37:26] morning [09:08:38] phuedx: hey have you registered for the hackathon? [09:16:19] * YuviPanda waves [09:16:39] joakino: phuedx see the crashlytics thread for a use case when toollabs was an almost instant solution [09:16:55] hi YuviPanda [09:17:00] hi [09:17:10] i read it, i don't remember, was tool labs mentioned? [09:17:42] joakino: yeah, I emailed about it about 4-5h ago [09:18:30] YuviPanda: oh ok, i'll find it again [09:18:38] still diving through email :p [09:57:56] hey joakino, YuviPanda [09:58:41] joakino: i haven't registered for the hackathon [09:58:44] hey YuviPanda props on the crashlytics thing, we need more of that [09:58:44] i probably should… [09:59:11] phuedx: just fill the form as you can, next week it closes for new entries, you can edit the form later [09:59:41] YuviPanda: more constructive and helpful behavior, really, thanks [10:02:57] YuviPanda: that's an awesome reply [10:03:03] i second what joakino has already said [10:03:06] :D [10:03:15] (i dislike sending +1 emails) [10:04:50] scaffolding is going up around our house \o/ [10:04:56] we are, however, blocked on a third party [10:05:09] who i paid before coming to sf [10:05:12] and has failed to deliver [10:31:58] joakino: have you submitted for wikimania? [10:32:31] phuedx: joakino I must say that the Gather drama made me think a fair bit about this [10:32:51] tool labs? [10:55:33] (03PS3) 10Jhernandez: Setup browser tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191083 [11:02:29] phuedx: about responding with options along with a -2 [12:11:23] gonna have some lunch [12:21:14] (03CR) 10Yuvipanda: [C: 04-1] Fix disambiguation links that point to specific sections to work properly (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192508 (owner: 10Deskana) [12:25:53] at least something good came out of it YuviPanda :D [12:26:03] phuedx: i said both with preference for wikimania [12:26:30] when is the last date for that thing? [12:26:38] * YuviPanda would like to go to both too [12:26:45] next wednesday for new entrys on the form [12:26:47] I’ve so far managed to get approved for both in the 3 years at the WMF... [12:26:56] cool YuviPanda [12:27:17] i'm hoping to go to wikimania because it is my first time, and to the hackathon because it is so close and cheap from spain [12:27:30] right [12:41:48] (03PS1) 10Jhernandez: Add browser test for acessing private collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192540 [12:41:50] (03PS1) 10Jhernandez: Use mobile site for the browser tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192541 [12:41:52] (03PS1) 10Jhernandez: POC: Load i18n messages to browser tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192542 [12:43:25] (03CR) 10jenkins-bot: [V: 04-1] POC: Load i18n messages to browser tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192542 (owner: 10Jhernandez) [12:43:45] mmm beetroot soup [12:48:16] (03CR) 10Dbrant: [C: 032] Catch exceptions in SaneAsyncTask.onFinish [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192453 (owner: 10BearND) [12:57:37] phuedx: joakino can you do me a favor and see if https://phabricator.wikimedia.org/T90568 is visible to you? [12:57:53] YuviPanda: nope [12:58:34] (03PS2) 10Jhernandez: POC: Load i18n messages to browser tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192542 [12:58:49] phuedx: whee, sweet [12:58:51] YuviPanda: on it [12:58:58] restricted [12:59:03] wheeee [12:59:04] ty [12:59:09] (03PS4) 10Dbrant: Read more suggestions for main page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192353 (owner: 10BearND) [12:59:52] dude flow breaks everythinggg [13:18:48] (03PS15) 10Sumit: Overlay,Panel,Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) [13:20:39] (03CR) 10Zfilipin: [C: 04-1] "Looks good to me in general, there is just one minor problem, see inline." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191083 (owner: 10Jhernandez) [13:33:18] 6Mobile-Web, 5Patch-For-Review: TOC should be horizontally scrollable or items in it should wrap - https://phabricator.wikimedia.org/T89367#1062322 (10Sumit) Here's a screenshot, the text within
  • is small enough yet each
  • 's actual width is exceeding the container, which seems to be the problem. Because... [13:34:44] (03CR) 10Dbrant: [C: 04-1] "minor stuff" (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192353 (owner: 10BearND) [13:56:22] (03PS2) 10Sumit: TOC: horizontal scrolling added for long words [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190734 (https://phabricator.wikimedia.org/T89367) [13:56:24] 6Mobile-Web, 5Patch-For-Review: TOC should be horizontally scrollable or items in it should wrap - https://phabricator.wikimedia.org/T89367#1062352 (10Sumit) setting the width of containing toc-collapsible block(say to 90%), to accound seems to work. Uploaded with that for now [13:57:50] (03PS3) 10Sumit: TOC: horizontal scrolling added for long words [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190734 (https://phabricator.wikimedia.org/T89367) [14:23:50] Deskana: wb! [15:01:25] (03PS3) 10Dbrant: Improve moving of infoboxes to end of first paragraph. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192452 (https://phabricator.wikimedia.org/T77802) [15:03:26] (03CR) 10jenkins-bot: [V: 04-1] Improve moving of infoboxes to end of first paragraph. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192452 (https://phabricator.wikimedia.org/T77802) (owner: 10Dbrant) [15:05:03] (03PS4) 10Dbrant: Improve moving of infoboxes to end of first paragraph. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192452 (https://phabricator.wikimedia.org/T77802) [15:15:01] (03CR) 10Phuedx: [C: 04-1] "-1 for the issue that @Florianschmidtwelzow raised." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192473 (owner: 10Bmansurov) [15:17:16] (03CR) 10Dbrant: "@BearND, Done!!! I've been wanting to implement Monte's approach for a while, but the roadblock has been that the .offsetHeight property w" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192452 (https://phabricator.wikimedia.org/T77802) (owner: 10Dbrant) [15:21:25] (03PS3) 10Deskana: Fix disambiguation links that point to specific sections to work properly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192508 [17:56:19] We're still getting some feedback in languages we can't respond in properly [18:01:03] (03PS4) 10Deskana: Fix disambiguation links that point to specific sections to work properly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192508 [18:01:25] (03CR) 10jenkins-bot: [V: 04-1] Fix disambiguation links that point to specific sections to work properly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192508 (owner: 10Deskana) [18:01:35] (03CR) 10Deskana: "recheck jerkins" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192508 (owner: 10Deskana) [18:02:41] (03CR) 10BearND: Read more suggestions for main page (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192353 (owner: 10BearND) [18:02:53] (03PS5) 10BearND: Read more suggestions for main page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192353 [18:02:55] (03CR) 10Deskana: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192508 (owner: 10Deskana) [18:02:57] (03CR) 10jenkins-bot: [V: 04-1] Read more suggestions for main page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192353 (owner: 10BearND) [18:07:58] (03PS1) 10MaxSem: Don't modify an array while iterating over it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192580 [18:10:21] coreyfloyd: hey! [18:10:31] mhurd: hey man [18:10:43] (03CR) 10Florianschmidtwelzow: [C: 031] "Even if it doesn't solve the bug, it should be merged, because it makes sense :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192580 (owner: 10MaxSem) [18:11:00] mhurd: to your question last night - yeah lets address any minor issues in a bug ticket [18:11:28] mhurd: I'd like to close out this patch - its been open for a long time [18:11:34] coreyfloyd: agreed [18:26:49] phuedx: hey, did you get a chance to publish instructions on how to get wikidata working locally? [18:37:34] (03PS2) 10Bmansurov: Internationalize English texts [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192491 [18:39:32] dbrant, user asked about text-to-speech for the app... sounds like something that would be provided by another app? [18:41:09] bmansurov: no i didn't, i haven't been productive at all today [18:41:09] Krenair: yeah, something like TalkBack (built into Android) would read the contents of the screen automatically. [18:41:25] i was actually about to start because it's a small task that i can do before i sign off [18:41:42] phuedx: ok, let me know when you're done. thanks [18:42:06] Krenair: but there may be some value in providing functionality to TTS just the contents of the page (since TalkBack would read all the controls on the screen, not just the page contents. But it wouldn't be a priority at the moment. [18:42:10] shall do [18:45:10] (03CR) 10Jdlrobson: [C: 032] Don't modify an array while iterating over it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192580 (owner: 10MaxSem) [18:46:10] (03CR) 10Bmansurov: "> I think it would be better, if we change all visible buttons (at least for stable mode) in one change, to hold this widely used mode con" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192473 (owner: 10Bmansurov) [18:46:18] (03Merged) 10jenkins-bot: Don't modify an array while iterating over it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192580 (owner: 10MaxSem) [18:46:36] jdlrobson: welcome back [18:47:00] dbrant, thanks, responded to them [18:47:07] thanks! [19:06:36] mhurd: I got your lead paragraph transform working! [19:07:00] dbrant: that’s great! how’d you do it? [19:08:15] mhurd: it's kind of silly -- we were performing our transforms on an object that contained the html, before actually assigning it to the DOM. That's why the offsetHeight was always 0. [19:09:27] mhurd: so now I'm putting the content into the document first, then doing the transforms. And there's still no flicker. [19:14:04] dbrant: for this particular transform, yes, you have assign to the DOM so it knows how wide/tall a

    tag is going to be for the screen it’s being shown on, but for other transforms i’d consider doing them the way you were, to unattached object to avoid “thrashing” the browser component (http://wilsonpage.co.uk/preventing-layout-thrashing/) [19:17:30] dbrant: the linked article’s “Chrome Timeline” example is nice for seeing if a change is causing extra layout passes. sorry if this already known :) [19:19:23] mhurd: thank you for the link. That's useful info. [19:19:39] bearND: yw! [19:20:56] mhurd: hmm, something else to profile! [19:21:08] dbrant: i know right ;) [19:22:12] dbrant: well, hopefully the transforms will be made obsolete by the node service. So, I wouldn't worry about it too much at this point. [19:22:22] yay! [19:23:57] I mean don't worry about the performance of it. Our main focus right now should be that it's correctly transforming the page contents. [19:24:32] bearND: dbrant i’d recommend a quick double-check on old device - dom thrashing can be *really* slow [19:24:33] But who knows. Maybe that could be useful learning for the performance of the RESTBase service, too. [19:24:55] mhurd: good point [19:25:44] it shouldn't be too bad; this only applies to the lead section. I'll try it on my 2.3 device [19:28:10] yep, no appreciable speed degradation :) [19:28:23] (03PS3) 10Bmansurov: WIP: Add ButtonWithSpinner and re-create 'Report an error' button using it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192473 [19:31:45] kristenlans: extremely stupid question: to "move" (or that is, at least make visiable) a card to a sprint should one just add the corresponding project to the "Projects" field? For example, I see "Mobile App Sprint 52 - iOS" as one of the projects for https://phabricator.wikimedia.org/T90255, and I also see it on the actual sprint 52 board, so i was wondering if there's a direct link or if that's all there is to it. [19:35:18] dr0ptp4kt: Adding the Sprint 52 project would add it to the top of the "To do" column [19:35:20] dr0ptp4kt: So then you move it [19:36:47] (03CR) 10Deskana: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192508 (owner: 10Deskana) [19:36:50] Deskana: thx [19:37:10] running to lunch - back in hr [19:37:15] dr0ptp4kt: does that answer your question? PS ther are no stupid questions when it comes to Phab ;-) [19:37:18] Deskana: so then from there one moves it into the different columns on the workboard, which is workboard specific, right? [19:37:30] kristenlans: yeah, i think that answers it [19:38:13] dr0ptp4kt: lemme knwo if you want to do a quick screenshare sometimes that's easier [19:41:45] coreyfloyd: any update on the proposal for team structure for mobile-tech? [19:41:57] dr0ptp4kt: just finishing it up with brian [19:42:14] bmansurov: sanitised notes from my notepad: https://gist.github.com/phuedx/5fe813967b2265003757 [19:42:18] coreyfloyd: thx [19:42:23] i'll prettify 'em [19:42:26] phuedx: thanks! [19:44:40] bmansurov: the hardest part about that was deciphering messages i'd left to my future self [19:44:45] coreyfloyd: sorry to send a deluge of questions, but ahead of the crash reporting meeting, would it be feasible for you to examine the quincy stuff and see if that can serve as a stand in replacement with adequate desymoblication and, to the extent that it's important, a good reporting console? cc bgerstle. i don't want us to get off track on finishing the work allocated for this sprint, but it might help to know ahead of time if the ope [19:44:46] source solution is "good enough" or "better" [19:45:01] big boxes with "FOREACHWIKI!!!" inside 'em [19:45:31] phuedx: i see [19:45:41] * phuedx didn't know about foreachwiki [19:45:48] coreyfloyd: more specifically, i was wondering if you could wire it up and see if it works if there's time, but failing that, just reviewing the documentation and code and the url yuvi posted [19:46:56] dr0ptp4kt: I have to go over what Yuvi did and check it out. I'll let you know how far I get. [19:47:06] coreyfloyd: k [19:48:18] dbrant: Okay, I think that patch is finally ready now [19:49:09] dbrant: Funny, it ends up touching pretty much every aspect of the disambig from the web view to the front-end [19:49:14] dbrant: Lots of little tweaks to it all [19:49:58] dr0ptp4kt coreyfloyd i'm still hooking up the insta-crash button [19:50:07] once i've done that i can integrate quincy and see how it looks [19:50:11] i could even do both [19:50:22] coreyfloyd might as well let me do it so we don't duplicate efforts [19:50:52] bgerstle: yeah if you want to look, go ahead [19:51:04] (03CR) 10Dbrant: [C: 032] Fix disambiguation links that point to specific sections to work properly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192508 (owner: 10Deskana) [19:51:30] (03CR) 10Dbrant: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192353 (owner: 10BearND) [19:52:04] dbrant: \o/ [19:52:10] dbrant: Thanks :-) [19:52:14] bgerstle: i'm with coreyfloyd - if you can verify this ahead of the meeting that will be best. but will this derail anything on the critical path for the current iteration? [19:52:26] Deskana: yw! [19:53:13] dr0ptp4kt nope [19:53:23] should just be an extra hook for the debug menu [19:53:32] bgerstle: great. [19:59:25] (03CR) 10Dbrant: [C: 032] Read more suggestions for main page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192353 (owner: 10BearND) [19:59:55] (03CR) 10Dbrant: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192505 (owner: 10BearND) [20:00:33] phuedx: good job, got it working locally [20:00:48] pew pew pew [20:01:44] Maryana: https://trello.com/c/Isf8stWH/26-5-new-mobile-menu-page [20:02:28] (03PS5) 10Dbrant: Improve moving of infoboxes to end of first paragraph. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192452 (https://phabricator.wikimedia.org/T77802) [20:09:10] (03PS1) 10Dbrant: Correctly release ContentProviderClient. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192618 [20:51:45] (03PS1) 10Kaldari: Declaring Hooks::isUIEnabled() as a static function [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192632 [20:51:48] hey coreyfloyd, i've got the crash button wired up, but it just pauses in Xcode w/o letting the app crash [20:52:04] i need to send a SIG_KILL to stop the app, but then it doesn't report the crash [20:52:04] do i need to run it on a device? [20:52:05] bgerstle: turn off breakpoints? [20:52:08] tried taht [20:52:10] that* [20:52:19] lemme try on a device [20:53:42] bgerstle: i think i remember there is some feature that always breaks on crash even if breakpoints are off - or something like that [20:53:53] bgerstle: you can just relaunch from the simulator [20:54:03] dont launch from xcode [20:54:10] ok i'll try that first [20:54:38] hrm [20:54:41] not showing up in the dashboard [20:58:11] hmm… [20:58:26] can you verify the crash report is sent? You have to relaunch and not crash [20:58:58] bgerstle_: ^ [20:59:08] ah [20:59:25] so i relaunched.. [20:59:28] still nothing [21:01:40] oh hey, there it is! [21:01:46] https://fabric.io/wikimedia/ios/apps/org.wikimedia.wikipedia/issues?build=all&status=open&event_type=all&time=all [21:01:53] here: https://fabric.io/wikimedia/ios/apps/org.wikimedia.wikipedia/issues/54ece6a67d7854d7c98bc92a [21:02:07] yay [21:03:12] Deskana: did he talk about the 8938 [21:03:34] jdlrobson: Nope [21:03:42] ok hope there is time for questions [21:04:07] jdlrobson: afaik there is [21:04:27] i guess not.. [21:18:02] bgerstle_: yeah i think it isnt instantaneous -a few minutes to process [21:22:18] bgerstle_: hey i was able to modify the web view tracking stuff to use intrinsic content size properly so no need for a height constraint - per your feedback [21:22:32] ok, cool [21:22:41] bgerstle_: amending the patch, but it seems solid so far :) [21:23:18] mhurd: anything else needed for the save patch to be merged? [21:26:16] (03CR) 10MaxSem: [C: 032] Declaring Hooks::isUIEnabled() as a static function [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192632 (owner: 10Kaldari) [21:27:21] (03CR) 10jenkins-bot: [V: 04-1] Declaring Hooks::isUIEnabled() as a static function [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192632 (owner: 10Kaldari) [21:29:50] (03CR) 10MaxSem: Declaring Hooks::isUIEnabled() as a static function [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192632 (owner: 10Kaldari) [21:30:00] (03CR) 10MaxSem: [C: 032] "recheck" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192632 (owner: 10Kaldari) [21:30:41] (03CR) 10Robmoen: [C: 032] UserPageCollectionsList shows collection images [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192302 (owner: 10Jhernandez) [21:30:59] (03Merged) 10jenkins-bot: Declaring Hooks::isUIEnabled() as a static function [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192632 (owner: 10Kaldari) [21:31:47] (03Merged) 10jenkins-bot: UserPageCollectionsList shows collection images [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192302 (owner: 10Jhernandez) [21:36:56] bgerstle_ mhurd dr0ptp4kt bb in an hour - late lunch - you can get me on IRC if needed. [21:37:26] coreyfloyd: k [21:38:08] mhurd: also did you see my last message ? [21:38:20] coreyfloyd: sorry just got back [21:38:31] coreyfloyd: merge time [21:38:43] Cool thanks. Catch up in a few [21:39:38] (03CR) 10Florianschmidtwelzow: [C: 031] "code looks good, but haven't tested :)" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192374 (owner: 10Bmansurov) [21:42:18] (03CR) 10Florianschmidtwelzow: "> This is going to be a big task. We should maybe split up the codebase and do it in multiple patches and merge them at once." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192473 (owner: 10Bmansurov) [21:52:35] (03CR) 10Bmansurov: [C: 04-1] TOC: horizontal scrolling added for long words (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190734 (https://phabricator.wikimedia.org/T89367) (owner: 10Sumit) [22:00:22] (03PS8) 10Mhurd: Implement new refresh saved pages logic and UI. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [22:03:49] bgerstle_: ok if i merge https://gerrit.wikimedia.org/r/#/c/191359 ? [22:04:11] mhurd do you want me to review it? [22:04:43] i seem to have left some comments, but i don't see that they've been addressed [22:04:52] i'd need to look at the most recent patch set to see if they're still relevant [22:04:59] bgerstle_: i think there’s frustration it’s been open so long. ya could you check? [22:05:00] that being said, if dr0ptp4kt was already looking i don't feel the need to [22:05:12] mhurd sure, just responding to some stuff on the platform split doc [22:05:13] bgerstle_: no he’s on other stuffs atm [22:05:22] k, i'll review in a abit [22:05:27] bgerstle_: thx1 [22:43:54] (03PS2) 10BearND: ShareAFact: EL update [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192505 [22:45:51] (03PS1) 10Robmoen: WIP: Read CollectionLists and Collections from DB [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192711 [22:51:45] (03CR) 10BearND: [C: 032] "Good catch" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192618 (owner: 10Dbrant) [22:52:06] (03Merged) 10jenkins-bot: Correctly release ContentProviderClient. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192618 (owner: 10Dbrant) [22:56:24] (03PS15) 10Mhurd: WIP: Native component beneath webView. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 [22:57:22] (03PS16) 10Mhurd: WIP: Native component beneath webView. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 [23:14:54] (03CR) 10BearND: [C: 04-1] "minor comment stuff" (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192452 (https://phabricator.wikimedia.org/T77802) (owner: 10Dbrant) [23:20:06] (03CR) 10MaxSem: [C: 04-2] Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [23:24:18] stepping out for a walk and dinner, bbl [23:24:48] sorry coreyfloyd mhurd didn't get to review that patch [23:24:52] i can do it later tonight [23:30:07] (03PS17) 10Mhurd: WIP: Native component beneath webView. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 [23:35:40] mhurd: i should rebase on that? [23:36:09] coreyfloyd: oh yeah! sorry! [23:36:21] mhurd: np - just wanted to check [23:36:33] mhurd: are you close to finished then? [23:36:44] coreyfloyd: i’d finally addressed brian’s instrinsic content size comments [23:37:07] coreyfloyd: lemme see if there were any other must-haves…. [23:37:52] coreyfloyd: i think that’s all the big stuff… checking the trello card... [23:40:45] coreyfloyd: crap i forgot to update a couple copyright comments... [23:40:54] mhurd: np [23:41:01] coreyfloyd: will amend in a minute… changing them now... [23:42:19] 10Wikipedia-App-iOS-App: HockeyApp Spike (4) - https://phabricator.wikimedia.org/T90659#1064262 (10dr0ptp4kt) 3NEW a:3BGerstle-WMF [23:42:53] (03PS18) 10Mhurd: WIP: Native component beneath webView. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 [23:42:59] coreyfloyd: ^ [23:43:05] 10Wikipedia-App-iOS-App: Self-hosted Quincy Spike (4) - https://phabricator.wikimedia.org/T90660#1064272 (10dr0ptp4kt) 3NEW a:3BGerstle-WMF [23:43:06] thanks [23:43:21] (03PS19) 10Mhurd: Native component beneath webView. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 [23:43:31] jdlrobson: So you want all the local user pages for this account deleted? https://meta.wikimedia.org/wiki/User:Jdlrobson [23:43:31] coreyfloyd: just removed “WIP” ^ [23:43:35] Deskana: dr0ptp4kt: mhurd http://hockeyapp.net/promise/ [23:43:39] jdlrobson: Just to confirm? [23:45:38] 10Wikipedia-App-iOS-App: Self-hosted Quincy Spike (4) - https://phabricator.wikimedia.org/T90660#1064301 (10dr0ptp4kt) Any server taking the data would need to be further isolated and security audited. [23:47:30] Deskana: you there? [23:47:44] dr0ptp4kt: Yeah, what's up! [23:50:15] Deskana: okay if i drag https://trello.com/c/wwdrzd1y/900-spike-4-hours-self-hosted-quincy and https://trello.com/c/X4uxiVM5/901-spike-4-hours-hockeyapp over to the current sprint? the assumption is that the image viewer stuff is temporarily on hold until the ios 6 device shows up for brian, so these cards are actually workable [23:50:42] 10Wikipedia-App-iOS-App: [Spike 4 hours] Self-hosted Quincy - https://phabricator.wikimedia.org/T90660#1064356 (10dr0ptp4kt) [23:51:27] 10Wikipedia-App-iOS-App: [Spike 4 hours] HockeyApp - https://phabricator.wikimedia.org/T90659#1064358 (10dr0ptp4kt) [23:53:32] ^^^ kristenlans fyi, based on meeting we just had about crash reporting on ios [23:54:07] coreyfloyd: realized i was the only +1 on the pull to refresh patch so i asked brian to give it another quick review - sorry i thought he’d already +1’ed. ( i’m trying avoid +2’ing ) i think he said he’ll do it in the morning [23:55:20] mhurd: cool - I'll be sure i address anything quickly so you can merge before standup [23:56:06] coreyfloyd: awesome! maybe you can sneak in the 2 line fix i mentioned in the comments as part of that? [23:56:36] *it’s just removing a no-longer used header and one ios 7+ method which won’t work on 6* [23:56:45] coreyfloyd: ^ [23:57:05] *header include statement*