[00:03:27] 6Mobile-Web, 10Continuous-Integration, 10VisualEditor, 10Wikimedia-Hackathon-2015: Create Jenkins builds for Editing across repositories (MobileFrontend, VisualEditor etc) - https://phabricator.wikimedia.org/T90647#1064441 (10greg) [00:04:19] (03PS35) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [00:04:29] kaldari, ^^ [00:04:48] (03CR) 10jenkins-bot: [V: 04-1] Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [00:08:01] any volunteers here need a wmf buddy for the mediawiki hackathon? [00:18:10] (03CR) 10Dr0ptp4kt: "Request for clarification, then will resubmit based on answers." (035 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190637 (https://phabricator.wikimedia.org/T89541) (owner: 10Deskana) [00:18:29] coreyfloyd: ^ would you please respond to the questions? [00:20:14] 6Mobile-Web, 10Continuous-Integration, 10Flow, 10VisualEditor, 10Wikimedia-Hackathon-2015: Create Jenkins builds for Editing across repositories (MobileFrontend, VisualEditor etc) - https://phabricator.wikimedia.org/T90647#1064461 (10Jdforrester-WMF) [00:27:44] dr0ptp4kt: ok [00:27:58] coreyfloyd: thx [00:30:32] 10Wikipedia-App-Android-App: Split Chinese into Traditional/Simplified in menus? - https://phabricator.wikimedia.org/T85615#1064498 (10bearND) [00:30:33] 10Wikipedia-App-Localization-or-Translation-or-Language, 7I18n: Special case Traditional and Simplified Chinese in all language handling - https://phabricator.wikimedia.org/T62743#1064499 (10bearND) [00:31:05] 10Wikipedia-App-Android-App, 10Wikipedia-App-Localization-or-Translation-or-Language, 7I18n: Special case Traditional and Simplified Chinese in all language handling - https://phabricator.wikimedia.org/T62743#673611 (10bearND) [00:34:51] 10Wikipedia-App-Android-App, 10Wikimedia-Hackathon-2015, 7Design: Add an easier and faster way to change the search language - https://phabricator.wikimedia.org/T87154#1064516 (10bearND) This was not meant to be the main task for the whole team, just for myself and whoever would like to be my Hackathon buddy... [00:36:22] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Mobile-Apps, 6operations: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1064522 (10dr0ptp4kt) p:5Triage>3Normal [00:40:44] (03CR) 10Fjalapeno: "adam left some responses - let me know if everything makes sense." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190637 (https://phabricator.wikimedia.org/T89541) (owner: 10Deskana) [00:47:23] 10Wikipedia-App-Android-App, 7I18n: add the option to have favorite languages in the app - https://phabricator.wikimedia.org/T36100#1064537 (10bearND) For the case where you want to quickly switch between two languages: The languages list is sorted so that the most recently used languages appear at the beginni... [00:48:01] (03PS1) 10Mhurd: Updated reload glyph in font from a cleaned up svg from Vibha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192734 [00:49:01] (03PS2) 10Mhurd: Updated reload glyph in font from a cleaned up svg from Vibha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192734 [00:55:17] (03CR) 10Bgerstle: [C: 04-1] "So, I posted a lot of comments, some of which are nit-picky. The important ones are:" (0316 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [01:01:32] coreyfloyd: sorry for dropping a ton of comments. happy to hop on hangout tomorrow and discuss [01:01:51] bgerstle: np - im answering now [01:01:55] k [01:02:08] coreyfloyd: side note, are you using IRCCloud in the browser? [01:02:15] bgerstle: yeah [01:02:22] i liked textual's native UI [01:02:36] yay skins! https://userstyles.org/styles/browse/irccloud [01:03:39] ah lame it requires a browser extension :-/ [01:04:00] the white is too bright! my eyes are burrnniiinnggg [01:04:16] * bgerstle dims screen drastically [01:04:30] bgerstle: coreyfloyd i'm heading out. have a good night. talk to you later [01:04:36] later dr0ptp4kt [01:10:49] kaldari: can we have a signoff party at some point today/tomorrow? [01:11:01] there's a bunch of lingering stuff in last sprint & this sprint, some of which i need your help on [01:11:05] sure. probably today [01:11:18] cool, lmk when you're free [01:11:26] i'll bring the punch [01:14:05] (03CR) 10Mhurd: "https://trello.com/c/RHV2XJu3" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192734 (owner: 10Mhurd) [01:21:38] (03CR) 10Fjalapeno: "@bgerstle thanks - send some responses will be making a patch tonight to address some of the issues. Thanks!" (0314 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [01:22:23] bgerstle: yeah - not the dark theme I usually like [01:22:56] bgerstle: yeah i like textual - but like the always on here better. some day they will have support for native clients. [01:23:16] yeah, i saw a tweet about it [01:23:30] apparently IRCCloud's API isn't "official" or very similar to the generic IRC spec [01:23:42] coreyfloyd: will look at your comments now [01:24:17] bgerstle: yeah i gotta upload a patch in a bit - but im taking my time for the rest of the night [01:24:31] dont wait on me - just check it in the morning [01:24:39] yeah, just wanted to see your responses [01:24:51] doing some other administrivia too [01:29:43] (03CR) 10Fjalapeno: [C: 031] Updated reload glyph in font from a cleaned up svg from Vibha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192734 (owner: 10Mhurd) [01:35:37] 6Mobile-Web, 5Patch-For-Review: Watchstar icons in alpha and beta not aligned - https://phabricator.wikimedia.org/T89506#1064582 (10Maryana) 5Resolved>3Open Just checked on beta labs and the stars are now misaligned in a different way :) The non-watched and watched ones line up now, which is good, but they... [01:55:29] 6Mobile-Web, 10WikiGrok: Create an override for WikiGrok CentralAuth dependency on beta labs - https://phabricator.wikimedia.org/T90671#1064613 (10Maryana) 3NEW [02:04:19] (03CR) 10Bgerstle: "responding to corey's responses." (038 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [02:04:43] coreyfloyd: in case you're working on it right now, i'd check out the category i wrote: NSDictionary+WMFMaybeSet [02:04:50] does one thing you need to do already [02:05:35] going to eat some dinner now, bbl [02:06:02] 6Mobile-Web, 10WikiGrok: Create an override for WikiGrok CentralAuth dependency on beta labs - https://phabricator.wikimedia.org/T90671#1064638 (10Legoktm) CentralAuth is installed in beta labs...or am I misunderstanding? [03:52:29] (03CR) 10Fjalapeno: "patch coming with fixes… comments attached here to explain some changes" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [03:53:13] (03PS9) 10Fjalapeno: Implement new refresh saved pages logic and UI. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 [04:55:38] (03PS4) 10Sumit: TOC: horizontal scrolling added for long words [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190734 (https://phabricator.wikimedia.org/T89367) [05:59:10] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Mobile-Apps, 5Patch-For-Review: Add watchlist to app - https://phabricator.wikimedia.org/T76953#1064887 (10Deskana) The above patch got this to the state where it could fetch the most recent changes from a user's watchlist and display it as a list of p... [07:47:59] morning! [08:30:21] (03PS2) 10Jhernandez: Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 [08:31:25] (03CR) 10jenkins-bot: [V: 04-1] Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [08:35:57] (03CR) 10Jhernandez: "I've addressed your comments Kaldari. Thanks for the review." (036 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [08:37:18] (03PS3) 10Jhernandez: Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 [08:42:41] (03CR) 10Legoktm: "See https://www.mediawiki.org/wiki/Manual:ContentHandler." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [08:44:04] (03CR) 10Jhernandez: "I've been looking at that. I'll try to get it set up this morning, thanks" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [09:05:15] (03CR) 10Legoktm: "If1e8eab864ec2726afd36ac4565a9c30193a32f0 is the CI change." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [09:05:28] (03CR) 10Legoktm: "Aaand wrong patch. Sorry!" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [09:28:38] morning joakino [09:29:00] sup phuedx [09:33:51] nothing much [09:34:01] catching up on email, typical morning ;) [09:34:09] how's everything going on your side joakino [09:35:51] phuedx: i'm fighting content handler a bit [09:35:55] boring shit [09:40:44] var_dump('HOOOOOOOOOOOOOOOOOOOOOOOOK'); die; [09:40:56] doesnt fucking call my hook, bullshat [09:45:56] gonna bike to a coffee shop in a bit [09:47:25] enjoy :D [09:47:30] to work, obvs [09:48:07] oh awesome [10:31:01] here with coffee [10:49:37] joakino: not sure if it's yer thing but: https://soundcloud.com/minnesota/astral-projection [10:50:08] bass-heavy glitch/danceable dubstep type thing [10:50:14] i find it pretty good to work to [10:51:57] phuedx: very cool, i like it [11:07:50] joakino: my favourite track of his is "Bloom": https://soundcloud.com/minnesota/sets/eternal-frequencies-equinox [11:07:55] first track off of that ^ [11:16:54] where's phab-bot? [11:16:57] (or whatever) [11:33:32] phuedx: i think it died yesterday with the outage [11:33:40] bleh [11:33:43] this is me with the -2 war http://giphy.com/gifs/sad-dumb-and-dumber-bjfv14wZU7PiM [11:33:46] haha [11:33:52] i've answered [14:09:08] that was a hard ride home :/ [14:34:16] (03CR) 10Phuedx: Add the MobileViewBannerImageRepository (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [14:47:59] 10Wikipedia-App-Android-App: Wikipedia Android is contributed anonymous if username is in Korean - https://phabricator.wikimedia.org/T90428#1065752 (10Ara) @Revi This is true. When I edit page KBS 3TV at Korean Wikipedia, I could see contrubution with IP address in history page. [14:51:01] (03PS1) 10Phuedx: Remove the PageImagesBannerImageRepository class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192805 [15:15:12] 10Wikipedia-App-Android-App, 7I18n: Wikipedia app description in the Google Play market is outdated in some languages - https://phabricator.wikimedia.org/T90703#1065848 (10Deskana) Within the past few days I've updated the store description in the repo for translation. Once it's gone through some translation,... [15:15:30] 10Wikipedia-App-Android-App, 7I18n: Wikipedia app description in the Google Play market is outdated in some languages - https://phabricator.wikimedia.org/T90703#1065849 (10Deskana) This was the commit, btw: https://gerrit.wikimedia.org/r/#/c/192261/ [15:16:00] 10Wikipedia-App-Android-App, 7I18n: Wikipedia app description in the Google Play market is outdated in some languages - https://phabricator.wikimedia.org/T90703#1065854 (10Deskana) p:5Triage>3Normal [15:17:56] (03CR) 10Florianschmidtwelzow: Add the MobileViewBannerImageRepository (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [15:19:58] 10Wikipedia-App-Android-App, 10MediaWiki-extensions-GeoData, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, and 3 others: GeoData should pull coordinates from Wikidata on sites with the Wikibase Client - https://phabricator.wikimedia.org/T35704#1065864 (10Tobi_WMDE_SW) [16:30:46] (03PS1) 10Cmcmahon: QA: id values are now random(ish) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192816 [16:58:29] (03CR) 10Jhernandez: [C: 031] "Woops forgot! Looks good to me too" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191083 (owner: 10Jhernandez) [17:05:03] * jdlrobson waves [17:05:32] welcome back jdlrobson, did you have a good time? [17:06:05] yes :) [17:06:11] catching up with my backlog [17:07:21] I'm a little jealous. :-) I think i want to do a Serious Vacation this summer maybe. [17:07:38] i do one every february to mark my birthday [17:07:42] it's good to have a routine ;-) [17:07:55] i also like thanksgiving since it is two days off in a row :) [17:08:10] (and i dont celebrate it :)) [17:08:34] hey jdlrobson [17:08:38] this year my idea is to get out of Tucson for a significant part of the summer, when the weather is appalling [17:08:38] hey phuedx!!! [17:08:56] still wired on coffee? [17:09:03] not so much now, no [17:09:17] i hadn't had any in two days, then i had two cups with a friend [17:09:29] head felt very funny [17:12:55] jdlrobson: if you're looking for an easy review to ease back in, this should turn at least one build green: https://gerrit.wikimedia.org/r/#/c/192816/ [17:18:25] chrismcmahon, jdlrobson: is there a dashboard/thing for those browser tests? [17:19:21] phuedx: https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/ [17:19:33] * chrismcmahon should make a mobile-only view, lemme do that now [17:20:50] <3 [17:20:54] i was just about to ask ;) [17:21:03] chrismcmahon: clearing the email backlog first :) [17:21:41] why is my MobileFrontend bust. Do I need to update core or something? [17:22:11] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Mobile-Apps, 10RESTBase, and 2 others: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1066172 (10dr0ptp4kt) [17:22:14] phuedx: jdlrobson https://integration.wikimedia.org/ci/view/BrowserTests/view/MobileFrontend/ voila [17:23:16] would be nice to turn that one build green again [17:23:23] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Scrum-of-Scrums, 3Mobile App Sprint 52 - Android: [Spike ?hr] Investigate building a Node.js service for mobile apps content - https://phabricator.wikimedia.org/T90228#1066174 (10dr0ptp4kt) [17:23:26] To the office! [17:25:18] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Scrum-of-Scrums, 3Mobile App Sprint 52 - Android: [Spike ?hr] Investigate building a Node.js service for mobile apps content - https://phabricator.wikimedia.org/T90228#1054105 (10dr0ptp4kt) [17:25:20] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Mobile-Apps, 10RESTBase, and 2 others: Create specialised content API for mobile apps - https://phabricator.wikimedia.org/T87824#1066176 (10dr0ptp4kt) [17:26:10] chrismcmahon: wait.. when did these become random? [17:26:11] this is terible [17:27:24] (since ids can be used as fragment identifiers) [17:27:33] jdlrobson: that was a long conversation. there was a change that made every id for every section identical, which is a violation of W3C rules https://phabricator.wikimedia.org/T88473 [17:28:06] new task please [17:28:07] jdlrobson: I would certainly like to see that done better, but it's at least legal HTML now [17:28:08] * jdlrobson catches up [17:28:17] "less horrible section element ids" [17:28:20] and the UI test is good [17:28:22] * jdlrobson creates task [17:28:45] wheeee, thanks, I'll sleep better [17:29:21] (03CR) 10Bgerstle: "I found two bugs, one w/ an iOS 7 API crashing the app on iOS 6 and another where the saved pages UI is in a corrupt state when loaded dur" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [17:30:59] 6Mobile-Web: Don't create random ids for sections - https://phabricator.wikimedia.org/T90737#1066198 (10Jdlrobson) 3NEW [17:30:59] hi people [17:31:59] (03CR) 10Bgerstle: "replying to myself..." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [17:32:34] (03CR) 10Jdlrobson: "This should be revisited." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188672 (https://phabricator.wikimedia.org/T88473) (owner: 10Bmansurov) [17:33:01] (03PS6) 10Dbrant: Improve moving of infoboxes to end of first paragraph. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192452 (https://phabricator.wikimedia.org/T77802) [17:33:20] hey joakino [17:33:21] 6Mobile-Web: Don't create random ids for sections - https://phabricator.wikimedia.org/T90737#1066212 (10Cmcmahon) [17:33:22] (03PS10) 10Bgerstle: Implement new refresh saved pages logic and UI. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [17:33:43] jdlrobson: i'm reading https://medium.com/medium-eng/the-code-review-mindset-3280a4af0a89 [17:33:47] its good [17:33:49] (03CR) 10Jdlrobson: [C: 04-1] "Mm.. i'm not sure about this as this makes it only applicable to certain pages... I'd rather get https://phabricator.wikimedia.org/T90737 " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192816 (owner: 10Cmcmahon) [17:34:11] joakino: yeh it resonated a lot with me [17:34:56] jdlrobson: it resonates with the answer i posted, but i hadn't read the article [17:35:03] good stuff [17:35:03] :) [17:35:17] (03CR) 10Bgerstle: [C: 031] "aside from outstanding issue i mentioned before w/ saved pages UI during previous update, i think this is ok to merge." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [17:35:52] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Updated reload glyph in font from a cleaned up svg from Vibha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192734 (owner: 10Mhurd) [17:36:51] 6Mobile-Web: Don't create random ids for sections - https://phabricator.wikimedia.org/T90737#1066221 (10Cmcmahon) I think index isn't helpful here because of the risk of a false positive when the test should fail [17:36:55] mm gerrit command line seems broken [17:39:13] jdlrobson: hi! [17:39:22] codezee: hey! [17:39:28] awesome work getting that categories patch merged :) [17:39:38] thanks... [17:41:03] codezee: where are you based? i was wondering if you were planning to go to the lyon hackathon? https://www.mediawiki.org/wiki/Lyon_Hackathon_2015 [17:41:29] jdlrobson: no, I'm from India :P [17:41:35] far away [17:42:13] codezee: well if you're interested i know there is sponsorship :) [17:43:32] jdlrobson: I'd could try, is it from May 23-25? [17:44:09] correct :) [17:44:15] just something to think about :) [17:44:30] jdlrobson: alright, I'll see, and let you know [17:44:34] jdlrobson: getting along with mobile frontend, though presently I'm looking forward to take part in GSOC in mediawiki... [17:45:47] codezee: interesting. Any ideas on what you'd want to work on? [17:45:59] phuedx: joakino anything in particular you wanted to pow wow on today? [17:46:54] jdlrobson: actually https://phabricator.wikimedia.org/T89287 interested me, but it is nowhere near developed, so I'm looking around presently [17:47:05] jdlrobson: i wanted somebody to show me how the frak do you learn to use certain extensions, because i dont know if i'm not doing it right [17:47:21] jdlrobson: was wondering if mobile frontend had any feature request on which I could work... [17:47:53] codezee: let me think about that. Quite possibly can work something out :) [17:48:33] jdlrobson, joakino: nothing in particular [17:48:43] i've started trying to keep a devlog again [17:48:46] that's about it [17:48:47] jdlrobson: if something in mobile frontend comes up, let me know, I'd be more than happy to work on that :) [17:49:00] (03CR) 10Bmansurov: [C: 032] TOC: horizontal scrolling added for long words [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190734 (https://phabricator.wikimedia.org/T89367) (owner: 10Sumit) [17:49:11] phuedx: i've stopped xd [17:49:12] codezee: added to my todo list! [17:49:40] 6Mobile-Web, 5Patch-For-Review: TOC should be horizontally scrollable or items in it should wrap - https://phabricator.wikimedia.org/T89367#1066369 (10bmansurov) 5Open>3Resolved a:3bmansurov [17:49:57] jdlrobson: thanks for that, seems one of my patches gets merged :) [17:50:07] (03Merged) 10jenkins-bot: TOC: horizontal scrolling added for long words [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190734 (https://phabricator.wikimedia.org/T89367) (owner: 10Sumit) [17:50:13] codezee: shoot, the commit message is wrong [17:50:24] i just noticed [17:50:44] bmansurov: yes, I see that, is it late? [17:51:03] codezee: not sure, probably yes [17:52:15] bmansurov: yes, seems it is, need to be reverted and submitted again? [17:52:39] too late. don't worry. happens :) [17:53:21] jdlrobson: rmoen: do we have standup? a magic meeting just appeared [17:53:24] ok :) [17:53:26] phuedx: did wikidataid=Q937 stop working? [17:53:39] ? [17:53:49] mw.config.get( 'wgWikibaseItemId' ) gives me null [17:54:11] jdlrobson: locally, beta, prod? [17:54:11] where is it added? [17:54:13] locally [17:54:13] all three? [17:54:25] assuming it's related to moving out of MobileFrontend [17:54:37] jdlrobson: master in mf and wg extensions? [17:54:39] same on betalabs [17:54:48] yup [17:55:26] what's the value of wgWikiGrokRepoMode? [17:55:40] null on beta labs [17:55:49] in teh config [17:55:49] null on local [17:55:51] locally [17:55:59] sorry, not js config, php config [17:56:09] how do i find out? [17:56:18] joakino: no standup today. I think its the magic tool sharing meeting that we had a month ago in the office [17:56:19] sorry really disorientated now its not in MobileFrotnend [17:56:30] look at yer wikigrok config ;) [17:56:38] which is... where? [17:57:14] ok, i'm going to hazard a guess there isn't one [17:57:20] so you should be seeing the override behaviour [17:57:47] somethings broken on beta labs/local for me - would be good if someone who knows this better could confirm :) [17:58:04] jdlrobson: you using vagrant? [17:58:05] mhurd dr0ptp4kt i +1'd coreyfloyd's saved pages patch [17:58:15] hm, monte's not around [17:58:22] nope [17:58:24] dr0ptp4kt: were you on reviewing duty for that as well? [17:58:34] or do we want monte to have another look and he can +2 it [17:58:40] (when he gets in) [17:58:54] jdlrobson: should probably do this via a hangout ;) [18:00:16] dr0ptp4kt: if you can merge that in it would be cool - if not we'll wait for monte to mosie in. [18:00:23] bgerstle: coreyfloyd i'm looking at the diff from ps7 right now [18:01:30] dr0ptp4kt: k [18:01:40] jdlrobson: phuedx powpow? [18:01:48] joakino: standup [18:01:54] will be with you in 15 minutes [18:04:37] coreyfloyd: is the header referenced in the comment at https://gerrit.wikimedia.org/r/#/c/191359/7..10/wikipedia/View+Controllers/SavedPages/SavedPagesViewController.h necessary? [18:05:46] (03PS11) 10Fjalapeno: Implement new refresh saved pages logic and UI. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 [18:06:01] dr0ptp4kt: removed ^ [18:06:23] dr0ptp4kt: 8 minutes! [18:06:28] dr0ptp4kt: coreyfloyd brb [18:06:34] we can do it [18:08:08] 6Mobile-Web: Don't create random ids for sections - https://phabricator.wikimedia.org/T90737#1066423 (10bmansurov) a:3bmansurov [18:08:45] coreyfloyd: were the other changes in that latest patchset intentional? mhurd, would you please review the diffs from the latest ps you've seen with the latest ps in https://gerrit.wikimedia.org/r/191359 and then +2 if appropriate? [18:09:11] jdlrobso_: https://phabricator.wikimedia.org/T90671 <- related [18:09:27] dr0ptp4kt: coreyfloyd will do [18:09:27] enable central auth and wikigrok is currently disabled on beta [18:12:13] jdlrobso_: http://etherpad.wikimedia.org/p/devpowpow-2015-02-25 [18:13:04] 6Mobile-Web, 10Analytics-EventLogging, 6Analytics-Kanban: Follow up with mobile team on instrumentation sampling rate (%50) - https://phabricator.wikimedia.org/T88363#1066439 (10KLans_WMF) a:5Milimetric>3kaldari [18:15:00] (03PS12) 10Mhurd: Implement new refresh saved pages logic and UI. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [18:15:12] (03CR) 10Mhurd: [C: 032 V: 032] "Ship it!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191359 (owner: 10Fjalapeno) [18:15:43] 6Mobile-Web, 10WikiGrok: Create an override for WikiGrok CentralAuth dependency on beta labs - https://phabricator.wikimedia.org/T90671#1066452 (10Maryana) It's not, AFAIK. [18:15:53] bmansurov: ping. pow wow! [18:16:18] 6Mobile-Web, 10WikiGrok: Create an override for WikiGrok CentralAuth dependency on beta labs - https://phabricator.wikimedia.org/T90671#1066453 (10MaxSem) a:3MaxSem [18:17:38] 6Mobile-Web: Don't create random ids for sections - https://phabricator.wikimedia.org/T90737#1066459 (10bmansurov) Where are 'toc' and 'page' prefixes coming from? IDs of the container? If so, there is no guarantee that the container has an ID. Any other suggestions how to change this? [18:18:43] 10Wikipedia-App-iOS-App: Saved pages UI corrupt when displayed during refresh. - https://phabricator.wikimedia.org/T90746#1066462 (10BGerstle-WMF) 3NEW [18:19:20] 6Mobile-Web, 10MobileFrontend: What's the use of Special:UserProfile - https://phabricator.wikimedia.org/T90632#1066472 (10Maryana) 5Open>3declined a:3Maryana Please engage constructively on Phabricator or don't engage at all. Asking for an opt out for a feature = constructive. Calling that feature "ugly... [18:19:31] 10Wikipedia-App-iOS-App: Saved pages UI corrupt when displayed during refresh. - https://phabricator.wikimedia.org/T90746#1066475 (10BGerstle-WMF) [18:19:44] 10Wikipedia-App-iOS-App: Saved pages UI corrupt when displayed during refresh. - https://phabricator.wikimedia.org/T90746#1066462 (10BGerstle-WMF) [18:20:07] 10Wikipedia-App-iOS-App: Saved pages UI corrupt when displayed during refresh. - https://phabricator.wikimedia.org/T90746#1066462 (10BGerstle-WMF) [18:20:28] (03PS1) 10BearND: Remove unused resources [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192836 [18:20:55] (03PS1) 10BearND: Update to Android Gradle build plugin to 1.1.0 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192837 [18:24:09] (03PS1) 10MaxSem: Allow functioning without CentralAuth in debug mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192839 (https://phabricator.wikimedia.org/T90671) [18:25:55] 6Mobile-Web, 10WikiGrok, 5Patch-For-Review: Create an override for WikiGrok CentralAuth dependency on beta labs - https://phabricator.wikimedia.org/T90671#1066520 (10Legoktm) >>! In T90671#1066452, @Maryana wrote: > It's not, AFAIK. Um, yes it is... http://meta.wikimedia.beta.wmflabs.org/wiki/Special:Version [18:32:11] mhurd: https://trello.com/c/XaPEs6Jl/30-add-width-constrained-article-image-parameter-to-mobileview-api [18:33:09] 10Wikipedia-App-iOS-App: [iOS 6] Image gallery is blank after device is rotated - https://phabricator.wikimedia.org/T90752#1066557 (10BGerstle-WMF) [18:33:36] 6Mobile-Web, 10MobileFrontend: What's the use of Special:UserProfile - https://phabricator.wikimedia.org/T90632#1066559 (10Saenger) But that's exactly what it looks like, and it serves absolutely no purpose. It has nothing whatsoever to do with a profile. I wonder what stupid idiot came up with this rubbish. [18:34:02] haha wow seriously? ^ [18:34:05] 10Wikipedia-App-iOS-App: [iOS 6] Image gallery is blank after device is rotated - https://phabricator.wikimedia.org/T90752#1066546 (10BGerstle-WMF) [18:34:44] 10Wikipedia-App-iOS-App: [iOS 6] Image gallery is blank after device is rotated - https://phabricator.wikimedia.org/T90752#1066546 (10BGerstle-WMF) [18:35:04] kristenlans: Deskana|Away i had a question about our upcoming phab experiment [18:35:13] i noticed we have a separate project for our sprint [18:35:22] is that because we can't use our App-iOS project workboard? [18:36:18] also, what have you guys been putting as your buddy & hack idea for the hackathon? [18:36:26] mhurd: https://docs.google.com/a/wikimedia.org/forms/d/1ZS3Zi9RYVSD504MCeNtNbA-7Y49DFcImXqbnaVZxNEU/alreadyresponded?c=0&w=1&usp=send_form [18:36:55] 6Mobile-Web, 10MobileFrontend: What's the use of Special:UserProfile ? - https://phabricator.wikimedia.org/T90753#1066570 (10Saenger) 3NEW [18:37:53] does anyone want to share a room for the hackathon? [18:38:27] y'know, save some $$$$ [18:39:03] 6Mobile-Web, 10MobileFrontend: What's the use of Special:UserProfile ? - https://phabricator.wikimedia.org/T90753#1066570 (10Saenger) [18:39:22] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Mobile-Apps, and 2 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1066600 (10dr0ptp4kt) [18:40:37] Deskana: filled out the form! i left the hack projects! brion i listed video playback on iOS as my project ;-) ;-) [18:40:52] woot :) [18:40:58] ignore the "i left the hack projects!" part of that last msg [18:41:08] brion: will give me a good excuse to bone up on C++ [18:41:18] awesome :D [18:41:27] and dust off my AV chops [18:42:16] bgerstle: i’m actually in progress on the side of converting some of my video player logic from JavaScript to C++ so I can share the code with the iOS app :D [18:42:25] once that’s done it should add ability to seek etc over the last demo i made [18:42:52] brion this sounds like a good side project for me :-) [18:42:57] i'll try to find some time [18:42:59] do feel free to poke at it anytime — https://github.com/brion/OGVCore for the new C++ code, https://github.com/brion/ogv.js for the older JS side [18:43:24] i’m kinda relearning C++, since i first learned it in the 90s before STL and stuff [18:43:28] 6Mobile-Web, 10MobileFrontend: Create an opt out for Special:Userprofile - https://phabricator.wikimedia.org/T90753#1066632 (10Maryana) p:5Triage>3Low [18:43:30] C++11 adds a bunch of nice stuff like lambdas [18:43:31] brion: oh boy [18:43:33] yeah [18:43:46] i bought this: http://shop.oreilly.com/product/0636920033707.do [18:44:00] can't wait to use me some autos & lambdas ;-) [18:44:09] i’ve heard that’s a good book, i’ll have to grab it too :D [18:44:23] brion got it on sale, but haven't touched it yet [18:44:33] apparently obj-c blocks and C++ lambdas are partially compatible in obj-c++ mode… but only partially ;) it’s weird [18:44:44] bgerstle: a phab project only has one workboard (not many). If we used the workboard view for the App-iOS project for our sprints, we would be looking at all possible tasks in the App-iOS project (rather than the subset we select for our sprint). We were told that projects are cheap in Phab, and making new ones every couple weeks is fine. [shrug] [18:45:18] kristenlans: hrm you can't control which tasks show up in a board? [18:45:28] kristenlans: i'm thinking about how JIRA works w/ agile [18:45:45] kristenlans: which i guess is similar (creating new sprints and adding/removing tasks from them) [18:45:49] but they all stay in the same project [18:45:56] makes it easier to move stuff around [18:46:23] plus, we have to "join" each project every week or two [18:46:30] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Mobile-Apps, and 3 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1066658 (10dr0ptp4kt) [18:46:44] 6Mobile-Web, 10MobileFrontend: Get rid of Special:Userprofile - https://phabricator.wikimedia.org/T90753#1066659 (10Saenger) [18:47:42] kristenlans: if there were a way to add another status to phab [18:48:09] we could only show items in the board that are "open" or something [18:48:12] bgerstle: Good job! [18:48:52] brion yeah i haven't done much Objc++ lately. i would probably stick to one or the other [18:49:12] i.e. if you're in a .mm file, use blocks when using ObjC API and lambda for C++ [18:49:14] yeah, mainly i’d expect to use it to bridge a C++ class to an obj-c api [18:49:37] which can then expose to swift :D [18:49:39] although w/ C++ you could *probably* write a block-wrapper class that allows you to wrap blocks as lambdas [18:49:57] you might, or might not, be able to wrap them in a std::function<> [18:50:00] i’m not quite sure :D [18:50:04] yeah [18:50:11] fn'l C++ is another topic i'd like to get into [18:50:38] but yeah, i was also under the impression that it wasn't worth trying to map C++ to swift [18:50:48] you need to wrap C++ in a C API [18:50:51] AFAIK [18:50:51] 10Wikipedia-App-Android-App, 6Mobile-Apps: Create Wikipedia Lite app. - https://phabricator.wikimedia.org/T90758#1066678 (10Dbrant) 3NEW [18:51:09] aaanyway [18:51:15] we can talk more later ;-) [18:51:24] :D [18:51:27] mhurd: sent you a profiling invite [18:51:56] bgerstle: cool! [18:53:00] Deskana: dr0ptp4kt do you want me to schedule a quick hangout regarding crash reporting? i don't have much else to work on and that should fill my time for the rest of the week (in addition to image gallery tweaks, code review, etc.) [18:53:07] 10Wikipedia-App-Android-App, 6Mobile-Apps: Create Wikipedia Lite app. - https://phabricator.wikimedia.org/T90758#1066693 (10Dbrant) nb: I'm specifying this as my Hackathon task. [18:53:24] i don't think i can tack on to any other work that's happening in anything other than a reviewing capacity [18:54:01] bgerstle: i'm in the scrum of scrums meeting . lemme get back to you in a bit [18:54:09] bgerstle: I agree it's definitely not ideal. Though in trello we also have to add members to the board every time it's created. Let's see how it goes using Phab in the next sprint and get a little more familiar with it and see what we think are the most important areas to improve on. [18:54:25] mhurd: https://wikimediafoundation.org/wiki/User:MHurd_(WMF) [18:55:46] kristenlans: gotchya, just trying to think of ways we might be able to avoid this sort of thing [18:56:28] kristenlans: if phab can work for us, i want to make sure we're giving it an adequate chance [18:56:50] it will really help my process metrics initiative ;-) [18:59:04] mhurd: Your central user page is here now: https://meta.wikimedia.org/wiki/User:MHurd_(WMF) [19:00:03] bgerstle: I appreciate the proactive thinking about Phab :-) I'm gonna try to carve out some time today to give it more thought. [19:01:10] phuedx: so how would you imagine using twitch? [19:01:46] 6Mobile-Web, 10MobileFrontend: Get rid of Special:Userprofile - https://phabricator.wikimedia.org/T90753#1066742 (10Saenger) [19:01:50] kristenlans: feel free to call if you want to bounce some ideas off me. i went ahead and created a board for the iOS project http://shop.oreilly.com/product/0636920033707.do [19:02:05] the only problem is that we can't hide the backlog where all tasks are kept by default [19:02:10] 6Mobile-Web, 10MobileFrontend: Get rid of Special:Userprofile - https://phabricator.wikimedia.org/T90753#1066570 (10Saenger) [19:02:28] 6Mobile-Web: Don't create random ids for sections - https://phabricator.wikimedia.org/T90737#1066744 (10Jdlrobson) Well toggle.enable currently takes a container. It could also take a prefix. [19:02:57] jdlrobso_: phuedx: just start streaming, game programming. announce it in reddit.com/r/watchpeoplecode and relevant mailing lists [19:03:12] kristenlans: a base project board could at least be nice for grooming the backlog [19:03:23] kaldari: meetin' time [19:03:27] i'll leave it alone now :-) [19:03:29] (game programming means when asked about which game choose "programming") [19:03:43] (03CR) 10Dbrant: [C: 04-1] "Building the APK fails because the strings you removed from the default locale are still present in other locales. We should either remov" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192836 (owner: 10BearND) [19:03:51] i've been thinking on doing it [19:03:54] 6Mobile-Web: Don't create random ids for sections - https://phabricator.wikimedia.org/T90737#1066745 (10bmansurov) How do you guarantee that prefixes are unique? Who keeps track of them? I don't think it's a good solution. [19:04:01] joakino: meetins [19:04:02] brb [19:04:41] bgerstle: did you make a board at the o'reilly shop? ;-) [19:05:02] oh whoops lol [19:05:04] wrong link [19:05:19] you can see it if you go to the main iOS project and click on the workboard button [19:06:44] 6Mobile-Web: Don't create random ids for sections - https://phabricator.wikimedia.org/T90737#1066763 (10Jdlrobson) I really don't understand your question - the prefixes are unique because they are fixed in our code. Math.random() 'foo' the second is static, the first isn't. [19:06:58] http://hatjitsu.wmflabs.org/71693 [19:07:01] (03PS1) 10Jdlrobson: Remove the md5 library [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192855 [19:08:19] bgerstle: Deskana and i just chatted. do things in this order: (1) image viewer bug fixes. i'm about to assign a number of bugs from phabricator to you. if we can leave the sprint with those fixed, we're going to be in great shape. (2) new testflight system with an apps that can't overwrite each other and have the correct icons etc., (3) crash reporting spikes, (4) speed spike. on this (4) speed spike Deskana is going to arrange a meetin [19:08:20] we can plan out more discrete tasks for the iteration starting next week, with the understanding that if there is somehow time left tomorrow/friday after (1), (2), and (3) are done and mhurd has time, (4) can be worked tomorrow friday. [19:08:45] We should make that those Phab tasks are also reflected in Trello :) [19:08:50] (since we're using Trello atm) [19:09:05] ok [19:09:18] sgtm [19:09:37] dr0ptp4kt: is the goal to do another beta after 1-3? potentially after 4? [19:10:37] mhurd: https://www.mediawiki.org/wiki/Lyon_Hackathon_2015/Buddies [19:10:41] 6Mobile-Web: Don't create random ids for sections - https://phabricator.wikimedia.org/T90737#1066789 (10Jdlrobson) a:5bmansurov>3Jdlrobson [19:12:07] (03CR) 10BearND: "@Dbrant Only the release build fails. The debug build should be fine. Once this is merged then I plan to do a TWN sync which should remove" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192836 (owner: 10BearND) [19:12:58] (03PS7) 10BearND: Improve moving of infoboxes to end of first paragraph. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192452 (https://phabricator.wikimedia.org/T77802) (owner: 10Dbrant) [19:13:12] (03CR) 10BearND: [C: 032] "Awesome! :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192452 (https://phabricator.wikimedia.org/T77802) (owner: 10Dbrant) [19:13:28] Deskana: yes, will update trello. ok if i do a consolidated card in trello for the imageviewer fixes for bgerstle that calls out to each task? or would you rather see multiple cards for each image viewer bug? i think we should do an external testflight by no later than wednesday, march 4, provided at least 1 & 2 are done. [19:13:53] i'd prefer separate cards for each [19:13:58] i'll be doing separate code review for each [19:15:19] (03Merged) 10jenkins-bot: Improve moving of infoboxes to end of first paragraph. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192452 (https://phabricator.wikimedia.org/T77802) (owner: 10Dbrant) [19:15:30] "OK" is a sideways person. wooooahhh [19:15:41] http://hatjitsu.wmflabs.org/71693 [19:15:49] maxsem ^ [19:15:55] 10Wikipedia-App-iOS-App: [iOS 6] Image gallery is blank after device is rotated - https://phabricator.wikimedia.org/T90752#1066857 (10dr0ptp4kt) p:5Triage>3High a:3BGerstle-WMF [19:16:14] (03PS1) 10Jdlrobson: Don't use random ids for toggleable sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192858 (https://phabricator.wikimedia.org/T90737) [19:16:25] kaldari moiz kaity maryana http://hatjitsu.wmflabs.org/71693 [19:16:40] 10Wikipedia-App-iOS-App: GIFs don't animate when displayed in the image gallery - https://phabricator.wikimedia.org/T90444#1066869 (10dr0ptp4kt) p:5Triage>3High [19:16:56] dr0ptp4kt: mine assigning me to those while you're at it? [19:16:59] 10Wikipedia-App-iOS-App: Gifs binaries are not being routed to the data store properly (causes temporary blank screens in gallery) - https://phabricator.wikimedia.org/T89921#1066875 (10dr0ptp4kt) p:5Triage>3High a:3BGerstle-WMF [19:17:01] s/mine/mind/ [19:17:28] bgerstle: okay cc Deskana i'll make you separate trello cards [19:17:44] (03CR) 10jenkins-bot: [V: 04-1] Don't use random ids for toggleable sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192858 (https://phabricator.wikimedia.org/T90737) (owner: 10Jdlrobson) [19:18:05] 10Wikipedia-App-iOS-App: svg images do not display information in Image Gallery view - https://phabricator.wikimedia.org/T90298#1066883 (10dr0ptp4kt) p:5Triage>3High a:3BGerstle-WMF [19:18:25] (03CR) 10Dbrant: [C: 032] "in that case, lgtm!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192836 (owner: 10BearND) [19:18:52] (03CR) 10Dbrant: [C: 032] Update to Android Gradle build plugin to 1.1.0 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192837 (owner: 10BearND) [19:20:10] 10Wikipedia-App-iOS-App: Image Gallery img comparison with Android - https://phabricator.wikimedia.org/T90296#1066893 (10dr0ptp4kt) p:5Triage>3High a:3BGerstle-WMF [19:21:12] 10Wikipedia-App-iOS-App: Image map is not displayed correctly in Image Gallery view - https://phabricator.wikimedia.org/T90294#1066900 (10dr0ptp4kt) p:5Triage>3High a:3BGerstle-WMF [19:22:00] 10Wikipedia-App-iOS-App: Image Gallery: cannot open a random image - https://phabricator.wikimedia.org/T90293#1066903 (10dr0ptp4kt) p:5Triage>3High a:3BGerstle-WMF [19:22:51] hi. is there some designs, documentation, or a way to test / look at these infoboxes generated from wikidata by mobile frontend? [19:23:48] jzerebecki: you mean the alpha infoboxes? [19:24:07] joakino: probably [19:24:25] jzerebecki: what do you need? [19:24:45] it is an experimental feature [19:25:36] (03CR) 10Jdlrobson: "Also I think this will require a cache flush or a JS workaround to inject the button on pages where it is not present." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [19:26:11] joakino: a) stuff that was written up about it during development/design b) a way to look at it if that is already possible [19:28:10] 10Wikipedia-App-iOS-App: Make iOS app Wikidata description editable - https://phabricator.wikimedia.org/T90765#1066924 (10Mhurd) 3NEW [19:28:20] jzerebecki: about a) it is an experimental feature done by a developer experimenting, not much written about it yet, b) i'm not sure of the state of it, let me have a quick look [19:29:41] mhurd: https://phabricator.wikimedia.org/T90590 [19:34:12] 6Mobile-Web, 10MobileFrontend: What's the use of Special:UserProfile - https://phabricator.wikimedia.org/T90632#1066966 (10Aklapper) Please see [[ https://www.mediawiki.org/wiki/Bug_management/Phabricator_etiquette | mw:Bug management/Phabricator etiquette]]. I'm happy to respond to good-faith and engaged comm... [19:35:30] jzerebecki: you need to enable experimental mode on the mobile version of wikipedia, and then in articles you will see a gray button saying More information..., clicking that should load the infobox [19:35:41] for example: https://en.m.wikipedia.org/wiki/Barack_Obama?mobileaction=alpha [19:35:52] hope that helps :) [19:36:19] joakino: yes exactly what i was looking for, thx [19:39:35] (03CR) 10Jdlrobson: [C: 031] "My vagrant seems to be broken at moment so I haven't been able to verify save click" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [19:43:45] bgerstle: https://trello.com/b/RAyj54YQ/mobile-apps-sprint-51-ios-16th-feb-2nd-mar has been updated, and the image viewer cards are in roughly highest to next highest priority order [19:43:56] i saw, thanks a bunch! [19:44:11] hey jzerebecki [19:44:28] i can answer questions around that feature too if necessary :) [19:44:41] how did you find out about them? [19:45:09] dr0ptp4kt: Deskana i only have 1 comment, what do you guys think of me doing crash reporting before image gallery fixes [19:45:17] that way, we can ensure the next beta goes out w/ crash reporting [19:45:24] the sooner we get feedback on crashes the better [19:45:29] phuedx: i still can't get the override working :( [19:45:31] should i raise a bug? [19:46:17] bgerstle: Sorry, I disagree with that. Image gallery fixes are higher priority. [19:46:43] 10Wikipedia-App-iOS-App: Enable background sync of saved page data on iOS app. - https://phabricator.wikimedia.org/T90769#1067022 (10Mhurd) 3NEW [19:46:56] jdlrobso_: hey. water cooler talk ;) . you know how to get https://gerrit.wikimedia.org/r/#/c/192709/ deployed? if not i can answer questions regarding that. [19:47:05] Deskana: but, if there were crashes, fixing them would be higher priority than fixing image gallery bugs, right? [19:47:38] bgerstle: Not necessarily. [19:47:50] 10Wikipedia-App-iOS-App: Enable background sync of saved page data on iOS app. - https://phabricator.wikimedia.org/T90769#1067034 (10Mhurd) [19:48:02] bgerstle: It depends on frequency, what the user was doing, and so on. [19:48:28] Deskana: completely agree w/ that. if a crash is only effecting one user it's less important. however, my perspective is we don't really know what crashes there might be until we do more testing [19:48:33] therefore we should assume the worst [19:48:52] bgerstle: I understand. However, I disagree. Please work on the image gallery fixes first. [19:49:17] jzerebecki: looking [19:49:36] jzerebecki: i think we need to ping kaldari or MaxSem - there's a deployment window today [19:49:40] we just need to find someone to do it [19:49:41] Deskana: i don't understand why you disagree. also, i was under the impression that at least coreyfloyd also agrees with my assessment. [19:49:47] mhurd: & dr0ptp4kt what about you guys? [19:50:10] Well, if you want me to be frank, I'm the product owner and prioritisation is my job. You don't need to agree with it. [19:50:36] jdlrobson: yes or just edit yourself onto https://wikitech.wikimedia.org/wiki/Deployments for a SWAT [19:50:36] if you want me to be frank, i'm an engineer and i'm telling you that i we don't know how often the app is crashing then everything else we're doing is pointless [19:50:37] bgerstle: with a little bit of luck my guess is you'll be able to get the new testflight system working on tuesday, and the crash reporting on wednesday. my guess is that regardless we'll push a testflirght build on wednesday that doesn't have the crash reporter. i think on friday the 6th we should be able to release with the established crash reporter. [19:50:48] mhurd: bgerstle coreyfloyd Deskana ^^ [19:50:57] jzerebecki on it [19:51:05] Deskana: i'm trying to collaborate, here [19:51:08] jzerebecki interested in your thoughts on the experiment.. [19:51:24] mhurd: bgerstle coreyfloyd Deskana - and my recommendation is on the wed the 4th we use a smaller audience for the external test - friends & family [19:51:41] at the end of the day, we're talking about what order i do a few (should be easy) cards [19:51:43] mhurd: bgerstle coreyfloyd Deskana & wikimedia.org email holders - and we ask them to please crash report [19:52:47] dr0ptp4kt: so you're saying TF -> crash reporting -> ship, possibly w/ image gallery fixes? [19:53:41] bgerstle: lemme hop on video with you really quickly :D [19:53:45] k [19:54:30] Deskana: dr0ptp4kt hackathon and wikimania travel forms completed! :) [19:54:35] jzerebecki: getting lost in the wikitext :-( [19:55:16] yea no visual editor :( [19:55:42] ok think i did it :) [19:56:48] Editing the deployment calendar? [19:57:23] Krenair: yeh i found it in the page but then had to hunt for it in the wikitext :) [19:57:38] i always find the requesting a deployment window clunky [19:57:49] why don't we use phabricator for this now? [19:57:50] yeah :( [19:58:02] jdlrobson: looks good, then be in the operations channel at that time [19:58:09] requesting a window? Someone would still need to put it on the calendar [19:58:16] SWAT [19:58:33] oh, for adding patches to swat? [19:58:34] jzerebecki: am hoping this will make the wikidata infobox work on beta labs, keen to start tweaking it [19:58:38] Krenair: yeh [19:59:12] Hm. Suggest it to Greg? [19:59:28] 10Wikipedia-App-Android-App: Barack Obama article has the infobox collapsed inside another collapsed table (yo dawg) - https://phabricator.wikimedia.org/T77802#1067092 (10bearND) 5Open>3Resolved a:3bearND [20:00:01] Krenair: yeh will do next time he's in office he's not in today [20:00:09] i need a catch up with him anyway [20:00:17] He was on IRC earlier [20:00:39] Krenair: yeh i need to chat with him in person anyway so might as well do it in one go [20:00:48] greg-g? [20:00:53] alright [20:03:39] (03CR) 10Legoktm: Add json user page storage for a collection (034 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [20:03:45] bmansurov: if a card is way way off of its estimate, then send an email to mobile-tech and we should take a look, mebbe? [20:03:58] jdlrobson: quick hangout? [20:04:04] phuedx: yep [20:04:19] phuedx: sure my whole vagrant instance is a bit screwed right now though [20:04:55] jdlrobson: :/ [20:05:10] jdlrobson: i've got about 15 minutes before i sign off for the day [20:05:21] i can devote those 15 minutes entirely to you, if you so wish [20:05:49] phuedx: so you don't have the same problem? [20:05:54] nope [20:05:54] (with the override?) [20:06:04] ok you want to sort out a hangout link? [20:06:06] hrrm, lemme check [20:06:17] i'll try and get myself into a good spot [20:06:28] jdlrobson: is wikigrok working for you? [20:06:28] getting exceptions Wikibase\Client\Hooks\DataUpdateHookHandlers::onParserAfterParse(Parser, string, StripState) [20:06:40] phuedx: i can't remember how to get wikigrok working [20:06:46] all i'm trying to test is the infobox [20:07:01] ah [20:07:47] Krenair: contentless ping :) [20:08:01] what's the question, I have to run (I have a migraine) and don't want to read all the backscrol [20:08:16] [19:57:38] i always find the requesting a deployment window clunky [20:08:16] [19:57:49] why don't we use phabricator for this now? [20:08:28] (03PS20) 10Mhurd: Native component beneath webView. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 [20:08:50] jdlrobson: figure out a way and I'll do it, really, like yesterday, I hate the wiki page [20:09:00] * greg-g leaves [20:12:59] dbrant: xzibit is unhappy that there is no longer a collapsed table inside a collapsed table. [20:13:05] dbrant: I, however, am happy. :-) [20:13:50] Deskana: lol I, as well [20:20:11] 6Mobile-Web, 10MobileFrontend: What's the use of Special:UserProfile - https://phabricator.wikimedia.org/T90632#1067288 (10AFBorchert) One of the major problems of this feature is that pictures are taken out of context and associated with this "profile". Imagine a moslem editing https://de.wikipedia.org/wiki/M... [20:20:14] 6Mobile-Web, 10WikiGrok: Wikibase id should be retrieveable from M.require( 'util' ) - https://phabricator.wikimedia.org/T90777#1067289 (10Jdlrobson) 3NEW [20:22:17] * jdlrobson grabbing lunch [20:26:27] 6Mobile-Web, 10MobileFrontend: What's the use of Special:UserProfile - https://phabricator.wikimedia.org/T90632#1067329 (10AFBorchert) And the addition of the latest "thanks you" enables a new kind of vandalism. Check the log of new users and you will notice that offending user names are not uncommon. In combi... [20:31:05] Deskana|Away: bgerstle and i chatted. summary: imageviewer things first. if there are serious, serious things that come up in the image viewer bugfixes, bgerstle will alert us stat. our gut feeling is the image viewer fixes will be done within a couple/few days, meaning that getting a properly icon'd testflight build with a crash reporting for wed the 4th is achievable. we'll plan on releasing that testflight build to [20:31:05] family/friends/wikimedia.org holders on the 4th to get an early glimpse on crashes. then on the 6th, provided no obvious crashy pattern from the limited testflight release from the 4th, we'll push the testflight build with crash reporting to the wider audience. that will give a whole weekend for people to report crashes (incidentally, any last minute performance gains for perceived load time can probably be done before the 6th - win.)... [20:31:06] can re-assess on the 9th where our crash painpoints are and raise up the possibility of deferring an appstore release (or doing a release, but then doing a follow on release maybe a couple weeks later). [20:31:38] dr0ptp4kt: will read in a bit, just got on hangout w/ mhurd [20:31:46] Deskana: bgerstle mhurd coreyfloyd we're of course agreement that we need to get to *at least* weekly testflight builds with *at least* monthly appstore releases [20:33:38] Deskana: bgerstle mhurd coreyfloyd: i feel confident that after this next "big bang" appstore release we'll be able to do that no problem. re: the testflight part, starting next week we'll be regularly producing testflight builds [20:33:51] dr0ptp4kt: Yes. Thanks. [20:35:32] Deskana: i'm gonna submit something for the hackathon in my next email/bugs pass, hopefully this afternoon. [20:40:16] Deskana: kristenlans : dbrant - i recall discussion around having a regular bug triaging meeting. are we thinking to still keep doing that? i'd prefer that we do it as one group for one hour per week or something like that (unless anyone has strong objections and would prefer a different configuration) [20:50:51] (03CR) 10Dr0ptp4kt: "Looks like it's causing strangeness on iOS 6. Is this known, with an action plan? I'm wondering if to unblock Fjalapeno we can get this me" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 (owner: 10Mhurd) [21:10:57] (03CR) 10Amire80: [C: 04-1] "Generally OK, but see the comments." (033 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192491 (owner: 10Bmansurov) [21:15:21] 6Mobile-Web: Formatting of TOC messed up - https://phabricator.wikimedia.org/T90791#1067540 (10kaldari) 3NEW [21:16:10] 6Mobile-Web: Formatting of TOC header messed up - https://phabricator.wikimedia.org/T90791#1067550 (10kaldari) [21:16:46] 6Mobile-Web: Formatting of TOC header messed up - https://phabricator.wikimedia.org/T90791#1067540 (10kaldari) [21:19:51] dr0ptp4kt: dbrant Deskana I'm up for it. Just made a meeting invite with weekly recur. [21:21:53] (03CR) 10Florianschmidtwelzow: [C: 04-1] "if you fix this, i will merge it :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192858 (https://phabricator.wikimedia.org/T90737) (owner: 10Jdlrobson) [21:23:09] (03CR) 10Kaldari: Internationalize English texts (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192491 (owner: 10Bmansurov) [21:24:23] 10Wikipedia-App-Android-App, 10Wikimedia-Hackathon-2015, 7Design: Add an easier and faster way to change the search language - https://phabricator.wikimedia.org/T87154#1067630 (10Amire80) [21:24:51] (03Abandoned) 10Jdlrobson: Scrollable reference drawer beta behavior [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (https://phabricator.wikimedia.org/T87050) (owner: 10Robmoen) [21:25:59] (03Abandoned) 10Jdlrobson: Convert to globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185209 (owner: 10Paladox) [21:26:15] (03CR) 10Florianschmidtwelzow: "> Also I think this will require a cache flush or a JS workaround to inject the button on pages where it is not present." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [21:26:18] (03Abandoned) 10Jdlrobson: Small style tweaks to reference drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178355 (owner: 10Robmoen) [21:26:43] 10Wikipedia-App-Android-App, 10Wikimedia-Hackathon-2015, 7Design: Add an easier and faster way to change the search language - https://phabricator.wikimedia.org/T87154#1067638 (10Amire80) As @Qgil wrote, most of the Language team people probably won't be at Lyon, although some might be. But why wait for Lyon... [21:28:57] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: Don't override Special:Watchlist with Special:EditWatchlist - https://phabricator.wikimedia.org/T88270#1067643 (10Jdlrobson) I don't see why this is problematic, when you switch you stick on the view. We have data supporting users using both modes and no data... [21:29:11] (03CR) 10Jdlrobson: [C: 04-1] "See comments on bug, this shouldn't be necessary." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190670 (https://phabricator.wikimedia.org/T88270) (owner: 10Florianschmidtwelzow) [21:29:57] 10Wikipedia-App-Android-App, 7I18n: add the option to have favorite languages in the app - https://phabricator.wikimedia.org/T36100#1067647 (10Amire80) >>! In T36100#1064537, @bearND wrote: > For the case where you want to quickly switch between two languages: > The languages list is sorted so that the most re... [21:30:10] (03PS2) 10Jdlrobson: Don't use random ids for toggleable sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192858 (https://phabricator.wikimedia.org/T90737) [21:30:43] kristenlans: dbrant Deskana i _think_ i may have missed a message. did i? i swear i'm not passively aggressively asking for a response! [21:31:12] kristenlans: oh, i see a buggin' out meeting scheduled [21:31:41] kristenlans: thanks [21:34:56] 6Mobile-Web, 10Continuous-Integration, 5Patch-For-Review, 7Technical-Debt: Publish MobileFrontend JS Documentation - https://phabricator.wikimedia.org/T74794#1067677 (10Jdlrobson) In terms of the css I'm not sure what to do about that... apart from removing this from the `make docs` command. We can't easil... [21:35:54] 6Mobile-Web, 10Continuous-Integration, 5Patch-For-Review, 7Technical-Debt: Publish MobileFrontend JS Documentation - https://phabricator.wikimedia.org/T74794#1067685 (10Jdlrobson) (If we set MEDIAWIKI_LOAD_URL = http://en.m.wikipedia.beta.wmflabs.org/w/load.php this will work - is that an option or does th... [21:37:23] (03CR) 10Florianschmidtwelzow: [C: 032] Don't use random ids for toggleable sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192858 (https://phabricator.wikimedia.org/T90737) (owner: 10Jdlrobson) [21:37:31] (03PS3) 10Bmansurov: Internationalize English texts [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192491 [21:37:33] has florian got a new irc handle? [21:38:30] -NickServ- Last seen : Feb 25 12:14:15 2015 (9h 23m 52s ago) [21:38:39] according to /ns info FlorianSW [21:38:54] (03Merged) 10jenkins-bot: Don't use random ids for toggleable sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192858 (https://phabricator.wikimedia.org/T90737) (owner: 10Jdlrobson) [21:39:14] Krenair: he's on gerrit but not on irc it seems :) [21:39:17] MaxSem: any idea why {"error":{"code":"internal_api_error_MWException","info":"[a1bd3ff9] Exception Caught: ParserOutput::addSecondaryDataUpdate() is no longer supported. Override Content::getSecondaryDataUpdates() or use the SecondaryDataUpdates hook instead.","*":"#0 /vagrant/mediawiki/extensions/WikidataBuildResources/extensions/Wikibase/client/includes/hooks/DataUpdateHookHandlers.php(120): ParserOutput->addSecondar [21:39:17] yDataUpdate(Wikibase\\Updates\\DataUpdateAdapter)\n#1 /vagrant/mediawiki/extensions/WikidataBuildResources/extensions/Wikibase/client/includes/hooks/DataUpdateHookHandlers.php(106): Wikibase\\Client\\Hooks\\DataUpdateHookHandlers->registerDataUpdates(Title, ParserOutput)\n#2 /vagrant/mediawiki/extensions/WikidataBuildResources/extensions/Wikibase/client/includes/hooks/DataUpdateHookHandlers.php(76): Wikibase\\Client\\Ho [21:39:17] oks\\DataUpdateHookHandlers->doParserAfterParse(Parser, string, StripState)\n#3 [internal function]: Wikibase\\Client\\Hooks\\DataUpdateHookHandlers::onParserAfterParse(Parser, string, StripState)\n#4 /vagrant/mediawiki/includes/Hooks.php(209): call_user_func_array(string, array)\n#5 /vagrant/mediawiki/includes/parser/Parser.php(432): Hooks::run(string, array)\n#6 /vagrant/mediawiki/includes/content/WikitextContent.php( [21:39:18] 333): Parser->parse(string, Title, ParserOptions, boolean, boolean, NULL)\n#7 /vagrant/mediawiki/includes/content/AbstractContent.php(497): WikitextContent->fillParserOutput(Title, NULL, ParserOptions, boolean, ParserOutput)\n#8 /vagrant/mediawiki/includes/page/WikiPage.php(2129): AbstractContent->getParserOutput(Title, NULL, ParserOptions)\n#9 /vagrant/mediawiki/extensions/ConfirmEdit/Captcha.php(364): WikiPage->prepar [21:39:21] eContentForEdit(WikitextContent)\n#10 /vagrant/mediawiki/extensions/ConfirmEdit/Captcha.php(563): SimpleCaptcha->shouldCheck(WikiPage, WikitextContent, boolean, boolean)\n#11 /vagrant/mediawiki/extensions/ConfirmEdit/Captcha.php(589): SimpleCaptcha->doConfirmEdit(WikiPage, WikitextContent, boolean, boolean)\n#12 /vagrant/mediawiki/extensions/ConfirmEdit/ConfirmEditHooks.php(24): SimpleCaptcha->confirmEditMerged(RequestC [21:39:23] ontext, WikitextContent, Status, string, User, boolean)\n#13 [internal function]: ConfirmEditHooks::confirmEditMerged(RequestContext, WikitextContent, Status, string, User, boolean)\n#14 /vagrant/mediawiki/includes/Hooks.php(209): call_user_func_array(string, array)\n#15 /vagrant/mediawiki/includes/EditPage.php(1439): Hooks::run(string, array)\n#16 /vagrant/mediawiki/includes/EditPage.php(1808): EditPage->runPostMergeFi [21:39:24] ugh [21:39:24] lters(WikitextContent, Status, User)\n#17 /vagrant/mediawiki/includes/api/ApiEditPage.php(404): EditPage->internalAttemptSave(NULL, boolean)\n#18 /vagrant/mediawiki/includes/api/ApiMain.php(1028): ApiEditPage->execute()\n#19 /vagrant/mediawiki/includes/api/ApiMain.php(397): ApiMain->executeAction()\n#20 /vagrant/mediawiki/includes/api/ApiMain.php(368): ApiMain->executeActionWithErrorHandling()\n#21 /vagrant/mediawiki/ap [21:39:27] i.php(84): ApiMain->execute()\n#22 /var/www/w/api.php(5): require(string)\n#23 {main}"}} [21:39:29] ahh [21:39:31] sorryyyyy [21:39:34] :-| [21:39:36] copy paste fail [21:39:38] lulz [21:39:40] MaxSem: {"error":{"code":"internal_api_error_MWException","info":"[a1bd3ff9] Exception Caught: ParserOutput::addSecondaryDataUpdate() is no longer supported. Override Content::getSecondaryDataUpdates() or use the SecondaryDataUpdates hook instead.","*":"#0 /vagrant/mediawiki/extensions/WikidataBuildResources/extensions/Wikibase/client/includes/hooks/DataUpdateHookHandlers.php(120): [21:39:50] I'm geting this when I try and save pages on my vagrant [21:40:02] update wd? [21:40:06] it is apparently [21:40:15] it's even a disabled role :-S [21:40:20] as always, update first, ask if doesn't help:P [21:41:35] coreyfloyd: around? [21:41:44] dr0ptp4kt: yeah [21:41:57] coreyfloyd: ok if i call you on video in a minute? [21:42:20] dr0ptp4kt: yeah - warning I'm at a coffee shop [21:42:43] coreyfloyd: it'll be fun. there better be indie or punk music playing [21:42:50] 6Mobile-Web, 5Patch-For-Review: Don't create random ids for sections - https://phabricator.wikimedia.org/T90737#1067709 (10Florian) 5Open>3Resolved [21:43:50] coreyfloyd: i'm calling via hangouts [21:44:08] kristenlans, any ideas why does https://trello.com/c/nXel0ldz/29-change-wikigrok-frontend-to-send-responses-to-wikidata-org-instead-of-local-wiki require ppl to be logged in to see it? [21:46:20] kaldari: jdlrobson http://www.urbandictionary.com/define.php?term=MustacheCore [21:46:33] you are officially mustachecore! yay! [21:46:35] :) [21:47:05] "1. Used when something is too hardcore to be called hardcore and must move up to an even better word." [21:47:14] lol [21:47:25] MaxSem hmmm, maybe because it is in a closed sprint? I just reopened the sprint and logged out and I can see it. [21:47:37] grrrr [21:47:46] we should just migrate to phab [21:48:08] MaxSem: not sure what i did wrong.. i updated it just doesn't like me :/ [21:48:12] MaxSem: :-) [21:48:49] chrismcmahon: https://phabricator.wikimedia.org/T90737 [21:49:10] * jdlrobson tries provisioning again [21:50:38] (03CR) 10Amire80: [C: 031] "i18n seems OK for a start." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192491 (owner: 10Bmansurov) [21:50:42] jdlrobson: saw that. thanks for doing it the Right Way [21:50:54] aharoni: thanks for the review [21:51:35] thanks for not waiting for too long to internationalize wikigrok :) [21:52:08] now if we can get it merged ... [21:52:11] we have too many furriners on the team not to! [21:52:13] ;) [21:52:25] localize wikigrok, that is [21:52:55] english-only speakers are a minority on mobile, i believe [21:53:56] mhurd: hey - i need to rebase on master… do you need to do that first? [21:53:59] i want wikigrok in british english [21:54:34] colour and flavour and theatre and centre? [21:54:34] (03PS1) 10Dbrant: [WIP] Dark toolbar with white icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 [21:55:04] jdlrobson: Do you fink deez tags are ‘bout right? [21:55:18] that's cockney english [21:55:22] or something [21:56:21] 'twould be but a wee change [21:57:00] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dark toolbar with white icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 (owner: 10Dbrant) [21:57:47] jdlrobson: make it smashing! https://translatewiki.net/wiki/Special:Translate?filter=!translated&action=translate&group=ext-wikigrok&language=en-gb [22:04:53] dbrant: I just found out the API can tell you if something is a disambiguation page or a redirect. [22:04:58] I did not know this. [22:05:00] coreyfloyd: https://gerrit.wikimedia.org/r/#/c/191000/ should be on master [22:05:03] dbrant: Did you? [22:06:25] Deskana: I did not! this would certainly be of use. [22:06:36] dbrant: Check this out: https://en.wikipedia.org/w/api.php?action=query&titles=4%20(disambiguation)|Tony%20Blair%27s%20Cabinet|Lorem%20ipsum%7CBarack%20Obama&prop=info|pageprops&ppprop=disambiguation [22:06:40] mhurd: cool thanks [22:06:50] coreyfloyd: quick hangout? [22:06:56] sure [22:07:36] dbrant: James_F, TrevorParscal and I were just sharing queries. ;-) [22:07:47] dbrant: I gave them our pageterms and pageimages stuff, they gave me this. [22:08:01] API swop shop [22:08:20] terrific! [22:08:33] nice! [22:09:20] Deskana, the API can tell you if something is a disambiguation page if the wiki has the Disambiguation extension installed, IIRC [22:09:23] and the page is actually marked as such [22:09:33] Deskana: If '"redirect": ""' instead was '"redirect": ""' it'd be so much better. [22:09:44] James_F: Yeah! [22:09:56] Deskana: so, this would be useful for our idea of presenting "second-order" disambiguation results by scraping the disambiguation page... right? [22:10:16] dbrant: Well... I'm not sure it can tell you anything about the information contained in the page. [22:10:23] (03CR) 10Bmansurov: Add the MobileViewBannerImageRepository (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [22:10:37] dbrant: But you could at least know which ones of those were disambig pages and query for the page text and scrape it, I guess. [22:10:47] Deskana: right, that what i meant [22:11:10] dbrant: Hmm, I may give this a whirl at the weekend or during the Hackathon. [22:11:31] dbrant, bearND: Unless one of you gets there first ;-) [22:11:36] Race you! [22:11:43] :) [22:11:52] lol be my guest! [22:12:06] whereas redirects are MW core [22:13:19] James_F, Krenair: Do you know if there's a task for making the value for the "redirect" key be the title of the page it redirects to? [22:13:59] (03CR) 10Bmansurov: [C: 031] Tweak banner image aspect ratio [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192789 (owner: 10Phuedx) [22:14:06] I don't know [22:14:43] I'll file one and see what happens. [22:14:46] Deskana: File one! Make it something you want bd808 to fix in Platform. ;-) [22:14:50] ^_^ [22:15:18] (03CR) 10Jdlrobson: [C: 032] Hygiene: Use events map in talk feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [22:15:27] mhurd: where'd the card go for the optimization spike? [22:15:53] (03CR) 10Jdlrobson: [C: 032] Tweak banner image aspect ratio [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192789 (owner: 10Phuedx) [22:16:21] Deskana, I seem to recall from my VE work that handling redirects for things like this is... [22:16:28] Fun. [22:16:31] (03Merged) 10jenkins-bot: Hygiene: Use events map in talk feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188841 (https://phabricator.wikimedia.org/T88564) (owner: 10Florianschmidtwelzow) [22:17:30] 6Mobile-Web, 5Patch-For-Review: Talk overlays should use View##events - https://phabricator.wikimedia.org/T88564#1067831 (10Jdlrobson) 5Open>3Resolved [22:17:55] (03CR) 10Phuedx: [C: 04-1] Add the MobileViewBannerImageRepository [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [22:18:16] (03PS1) 10Jdlrobson: Hygiene: Use server side templating for checkbox generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192961 [22:18:43] bgerstle: Do you mean this? https://phabricator.wikimedia.org/T90255 [22:18:58] Deskana i remembered a trello card for it as well [22:20:02] Deskana let me know what you think of that email i sent. mhurd and i think we have a lot to go on from that trace, but i think other devs should try to reproduce—and potentially corroborate—my results [22:20:07] bgerstle: I'm not sure, then. I didn't think we have one. [22:20:17] maybe someone archived it [22:20:25] * bgerstle shrug [22:20:50] bgerstle: sounds good [22:20:57] anyway, if all goes well, we should have a nice series of cards related to optimizations ordered by their severity (i.e. CPU usage) [22:21:39] mhurd and i found a few key suspects already in our initial read, a quick profiling from other devs will add to and/or confirm them [22:22:42] 6Mobile-Web: Remove last edited pageimage from Special:Userprofile - https://phabricator.wikimedia.org/T90801#1067832 (10Maryana) 3NEW [22:22:43] chrismcmahon: are you updating the browser test patch? [22:22:46] (03CR) 10Bmansurov: [C: 032] Remove the PageImagesBannerImageRepository class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192805 (owner: 10Phuedx) [22:25:49] (03PS10) 10Jdlrobson: Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 [22:25:58] (03PS3) 10Jdlrobson: Hygiene: ImageOverlay should use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188622 (https://phabricator.wikimedia.org/T88566) [22:28:03] dr0ptp4kt: bgerstle mhurd bb in 30 [22:28:13] coreyfloyd: k [22:28:15] coreyfloyd: i'll be gone by then [22:28:30] FYI coreyfloyd dr0ptp4kt Deskana ill be missing tonight's design review due to dr's appt [22:28:39] also taking off in about 15 [22:28:46] bgerstle: thx for reminder. have a good night [22:29:29] jdlrobson: I haven't yet. [22:29:55] jdlrobson: if we're back to the good ol' days then my WIP patch should just be abandoned. [22:30:56] (03PS11) 10Jdlrobson: Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 [22:31:09] (03PS4) 10Jdlrobson: Hygiene: ImageOverlay should use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188622 (https://phabricator.wikimedia.org/T88566) [22:32:13] (03PS12) 10Jdlrobson: Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 [22:32:30] bgerstle: No worries. Thanks. [22:35:17] (03PS1) 10MaxSem: Conditionally enable stuff depending on repo mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192966 [22:35:23] kaldari, ^^ [22:42:23] (03CR) 10Jdlrobson: [C: 04-1] "So I talked to Maryana about this. The reason we never promoted this was because we were not clear how Flow fitted into mobile and the tal" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [22:42:56] (03CR) 10Kaldari: [C: 04-1] Internationalize English texts (032 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192491 (owner: 10Bmansurov) [22:45:43] (03CR) 10Bmansurov: Internationalize English texts (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192491 (owner: 10Bmansurov) [22:46:52] (03CR) 10Kaldari: [C: 04-1] "Seems to work OK, just 1 style comment." (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192966 (owner: 10MaxSem) [22:47:29] (03PS2) 10MaxSem: Conditionally enable stuff depending on repo mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192966 [22:47:46] bah, more than 30 seconds [22:50:21] mhurd: coreyfloyd dr0ptp4kt i gotta run. etherpad w/ instruments observations updated. gotta run! [22:50:30] bgerstle: see ya! [22:50:35] bgerstle: ttfn [22:51:03] dr0ptp4kt: toodles! [22:51:20] bgerstle: :) [22:54:10] (03PS1) 10Saltymule: Fix image map on article view [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192971 [22:58:10] (03CR) 10Kaldari: [C: 032] Conditionally enable stuff depending on repo mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192966 (owner: 10MaxSem) [22:58:46] (03CR) 10Kaldari: Conditionally enable stuff depending on repo mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192966 (owner: 10MaxSem) [22:59:16] (03CR) 10jenkins-bot: [V: 04-1] Conditionally enable stuff depending on repo mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192966 (owner: 10MaxSem) [22:59:22] (03CR) 10Kaldari: [C: 04-1] Conditionally enable stuff depending on repo mode (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192966 (owner: 10MaxSem) [22:59:25] uhoh [22:59:36] MaxSem: last one :) [22:59:47] * MaxSem bites... PhpStorm [23:00:36] MaxSem: I have no idea why hhvm didn’t like it [23:00:54] (03PS1) 10Mhurd: Fix for entries in TOC doubling up after pull to refresh. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192973 [23:01:02] zuul race condition? [23:01:08] * MaxSem bites jerkins [23:01:22] (03PS2) 10Mhurd: Fix for entries in TOC doubling up after pull to refresh regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192973 [23:02:02] coreyfloyd: ^ [23:03:09] (03PS3) 10MaxSem: Conditionally enable stuff depending on repo mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192966 [23:04:01] (03PS3) 10Mhurd: Fix for "entries in TOC doubling up after pull to refresh" regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192973 [23:04:14] (03CR) 10jenkins-bot: [V: 04-1] Conditionally enable stuff depending on repo mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192966 (owner: 10MaxSem) [23:04:24] FUCK YOU JERKINS [23:05:28] (03PS4) 10Bmansurov: Internationalize English texts [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192491 [23:06:17] (03CR) 10Kaldari: [C: 032] Conditionally enable stuff depending on repo mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192966 (owner: 10MaxSem) [23:06:56] (03CR) 10jenkins-bot: [V: 04-1] Internationalize English texts [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192491 (owner: 10Bmansurov) [23:07:34] Maryana: is "Multi-language search" on the platform dependencies spreadsheet your ask? (have I asked you this before?) [23:07:49] (03CR) 10jenkins-bot: [V: 04-1] Conditionally enable stuff depending on repo mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192966 (owner: 10MaxSem) [23:07:53] you have :) i believe it was amir's ask [23:07:57] bd808: ^ [23:08:14] thx. I'll write it down this time :) [23:08:21] np [23:09:08] (03CR) 10Jdlrobson: [C: 04-1] TWN: Use own message for terms of use link in license warning (editor and talk) (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190831 (owner: 10Florianschmidtwelzow) [23:19:13] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Improve app icon to make it more material designesque - https://phabricator.wikimedia.org/T90809#1068077 (10Deskana) 3NEW [23:26:19] (03CR) 10Kaldari: Internationalize English texts (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192491 (owner: 10Bmansurov) [23:27:08] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [Blocked on design] Improve loading indicator to make it less feel less heavy to the user - https://phabricator.wikimedia.org/T90812#1068113 (10Deskana) 3NEW [23:27:38] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [Blocked on design] Improve loading indicator to make it less feel less heavy to the user - https://phabricator.wikimedia.org/T90812#1068124 (10Deskana) a:3Vibhabamba [23:28:15] (03PS5) 10Bmansurov: Internationalize English texts [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192491 [23:29:29] (03CR) 10jenkins-bot: [V: 04-1] Internationalize English texts [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192491 (owner: 10Bmansurov) [23:32:08] MaxSem, bmansurov: You guys are both getting -1ed by jenkins for hhvm problems. Wonder what’s going on with that. Maybe we should poke Krinkle. [23:32:17] already [23:32:22] fix coming [23:32:46] (03CR) 10MaxSem: [C: 032] "recheck" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192966 (owner: 10MaxSem) [23:33:49] (03CR) 10jenkins-bot: [V: 04-1] Conditionally enable stuff depending on repo mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192966 (owner: 10MaxSem) [23:34:03] (03CR) 10Krinkle: "recheck" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192966 (owner: 10MaxSem) [23:34:18] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: As a reader, I'd like suggestions for what I can read next to be presented to me. [Main page read more] - https://phabricator.wikimedia.org/T90256#1068199 (10Deskana) [23:34:51] MaxSem: Fixed [23:34:58] thanks! :) [23:38:51] (03CR) 10Jdlrobson: [C: 031] "This looks good to me but can someone else verify and +2 ?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [23:39:49] (03CR) 10MaxSem: [C: 032] "recheck" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192966 (owner: 10MaxSem) [23:40:11] (03PS1) 10MaxSem: Conditionally enable stuff depending on repo mode [extensions/WikiGrok] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/192992 [23:40:16] (03PS1) 10Mhurd: Cache regressions fixes related to pull to refresh and offline mode. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192993 [23:40:53] (03CR) 10jenkins-bot: [V: 04-1] Conditionally enable stuff depending on repo mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192966 (owner: 10MaxSem) [23:41:13] (03CR) 10jenkins-bot: [V: 04-1] Conditionally enable stuff depending on repo mode [extensions/WikiGrok] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/192992 (owner: 10MaxSem) [23:41:30] Krinkle, not fixed, apparently [23:41:52] (03CR) 10MaxSem: [C: 032 V: 032] Conditionally enable stuff depending on repo mode [extensions/WikiGrok] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/192992 (owner: 10MaxSem) [23:42:40] (03CR) 10Mhurd: "Added comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192993 (owner: 10Mhurd) [23:46:20] (03PS1) 10MaxSem: Conditionally enable stuff depending on repo mode [extensions/WikiGrok] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/192996 [23:48:23] (03CR) 10jenkins-bot: [V: 04-1] Conditionally enable stuff depending on repo mode [extensions/WikiGrok] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/192996 (owner: 10MaxSem) [23:48:25] (03CR) 10MaxSem: [C: 032 V: 032] Conditionally enable stuff depending on repo mode [extensions/WikiGrok] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/192996 (owner: 10MaxSem) [23:51:05] (03CR) 10Krinkle: "recheck" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192966 (owner: 10MaxSem) [23:58:56] 6Mobile-Web: Special:EditWatchlist in mobile should use server side templating - https://phabricator.wikimedia.org/T90818#1068277 (10Jdlrobson) 3NEW [23:59:37] (03CR) 10Fjalapeno: "monte quick question on possible fix strategy…" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192993 (owner: 10Mhurd) [23:59:41] MaxSem: IT' fixed now. Though it seems the wikigrok failure is genuine [23:59:42] 23:56:24 [efef8b68] [no req] MWException from line 185 of /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm@2/src/includes/Hooks.php: Invalid callback WikiGrok\Hooks::onEventLoggingRegisterSchemas in hooks for EventLoggingRegisterSchemas [23:59:46] Can you look into that or file a bug