[00:00:20] rawr [00:00:23] looking [00:03:05] jdlrobson, swat time [00:03:15] yay [00:03:27] (03CR) 10Mhurd: "Added comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192993 (owner: 10Mhurd) [00:03:30] coreyfloyd: ^ [00:03:35] thanks Krenair for the poke [00:03:49] 14:44 Disconnected apparently from operations :) [00:04:04] (03CR) 10Fjalapeno: "possible simplification" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192973 (owner: 10Mhurd) [00:05:29] (03CR) 10Fjalapeno: [C: 031] Cache regressions fixes related to pull to refresh and offline mode. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192993 (owner: 10Mhurd) [00:05:31] (03CR) 10Mhurd: "Added comment. Will amend." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192973 (owner: 10Mhurd) [00:06:11] 6Mobile-Web: SpecialMobileWatchlist, SpecialMobileContributions, SpecialMobileHistory should not use MobileSpecialPageFeed - https://phabricator.wikimedia.org/T90819#1068286 (10Jdlrobson) 3NEW [00:06:30] Krenair: any idea who's managing swats today? [00:06:48] coreyfloyd: amending for the setsections stuff... [00:06:56] I guess I'll deploy the config changes, ebernhardson is doing the flow change [00:07:06] mhurd: cool [00:07:17] thanks Krenair let me know when it's up and i can verify [00:07:34] you should be pinged before and after your patch goes out [00:09:28] * jdlrobson nods [00:10:38] (03PS1) 10MaxSem: Conditionally enable stuff depending on repo mode [extensions/WikiGrok] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/193000 [00:10:40] (03CR) 10jenkins-bot: [V: 04-1] Conditionally enable stuff depending on repo mode [extensions/WikiGrok] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/193000 (owner: 10MaxSem) [00:14:54] (03PS1) 10MaxSem: Conditionally enable stuff depending on repo mode [extensions/WikiGrok] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/193001 [00:15:25] (03PS1) 10Jdlrobson: Remove absent ExtensionFunctions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193002 [00:15:29] (03CR) 10MaxSem: [C: 032] Conditionally enable stuff depending on repo mode [extensions/WikiGrok] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/193001 (owner: 10MaxSem) [00:16:13] (03CR) 10MaxSem: [C: 032] Remove absent ExtensionFunctions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193002 (owner: 10Jdlrobson) [00:16:15] (03CR) 10EBernhardson: [C: 032] Remove absent ExtensionFunctions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193002 (owner: 10Jdlrobson) [00:18:36] (03Merged) 10jenkins-bot: Conditionally enable stuff depending on repo mode [extensions/WikiGrok] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/193001 (owner: 10MaxSem) [00:18:38] (03Merged) 10jenkins-bot: Remove absent ExtensionFunctions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193002 (owner: 10Jdlrobson) [00:25:44] (03PS1) 10Jdlrobson: Hygiene: Correctly enable watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193005 [00:26:25] (03PS2) 10MaxSem: Conditionally enable stuff depending on repo mode [extensions/WikiGrok] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/193000 [00:26:27] (03CR) 10Bmansurov: [C: 032] Remove the md5 library [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192855 (owner: 10Jdlrobson) [00:26:32] (03CR) 10MaxSem: [C: 032] Conditionally enable stuff depending on repo mode [extensions/WikiGrok] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/193000 (owner: 10MaxSem) [00:27:09] (03PS3) 10Fjalapeno: Add Search Suggestions to web view [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191527 [00:27:13] mhurd: ^ [00:27:21] coreyfloyd: cool! [00:27:31] (03CR) 10MaxSem: [C: 04-1] "Eh, using thumb.php might fry the cluster." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192855 (owner: 10Jdlrobson) [00:27:58] bmansurov, sorry - had to pull your +2 to prevent merging :P ^^^ [00:28:04] coreyfloyd: quick hangout about the addSections? [00:28:37] MaxSem: ok, I didn't know that [00:28:40] good to know [00:28:57] (03Merged) 10jenkins-bot: Conditionally enable stuff depending on repo mode [extensions/WikiGrok] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/193000 (owner: 10MaxSem) [00:33:41] (03CR) 10Dr0ptp4kt: "About to resubmit" (034 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190637 (https://phabricator.wikimedia.org/T89541) (owner: 10Deskana) [00:33:57] dr0ptp4kt: You should amend that patch so that it says you're the owner now. :-) [00:34:06] (03PS4) 10Mhurd: Fix for "entries in TOC doubling up after pull to refresh" regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192973 [00:35:13] (03CR) 10Bmansurov: [C: 04-1] "I don't see checkbox labels in the UI." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192961 (owner: 10Jdlrobson) [00:35:24] bmansurov: have you got latest core? [00:35:25] (03PS7) 10Dr0ptp4kt: Don't include article snippet in "Share as text" option [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190637 (https://phabricator.wikimedia.org/T89541) (owner: 10Deskana) [00:35:36] jdlrobson: lemme check [00:35:47] coreyfloyd: ^^ okay, i think that does it. would you please re-review? [00:35:56] dr0ptp4kt: sure thing [00:36:17] kaldari: wikigrok preso for wikimania for your consideration: http://etherpad.wikimedia.org/p/wikigrokcollections [00:36:39] cool [00:37:00] take a look & lemme know what you think. leila & i just put this together [00:38:25] Maryana: I’ll have to take a look at it tomorrow. Working on Wikidata Query Service requirements [00:38:52] ok, no worries. anytime by end of the week. [00:39:12] jdlrobson: even after pulling the latest core & provisioning I don't see them [00:39:24] coreyfloyd: blargh, hang on, gonna rename some things [00:40:00] bmansurov: you don't see the checkboxes at all? [00:40:15] jdlrobson: I see the checkboxes but not texts next to them [00:40:22] ooh mmm [00:40:25] let me take another look [00:42:14] (03PS8) 10Dr0ptp4kt: Don't include article snippet in "Share as text" option [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190637 (https://phabricator.wikimedia.org/T89541) (owner: 10Deskana) [00:42:24] coreyfloyd: ^ okay, there [00:42:27] coreyfloyd: sorry [00:42:30] np [00:47:23] (03PS2) 10Jdlrobson: Hygiene: Correctly enable watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193005 [00:49:51] (03CR) 10Jdlrobson: [C: 04-1] "more tweaks needed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193005 (owner: 10Jdlrobson) [00:50:18] mhurd: hangout? [00:50:25] coreyfloyd: ya [00:52:46] 6Mobile-Web, 5Patch-For-Review: Watchstar icons in alpha and beta not aligned - https://phabricator.wikimedia.org/T89506#1068556 (10Jdlrobson) Yup still broken! [00:53:14] (03PS5) 10Fjalapeno: Fix for "entries in TOC doubling up after pull to refresh" regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192973 (owner: 10Mhurd) [00:58:25] (03PS16) 10Bmansurov: Overlay, Panel, Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [00:58:27] (03PS3) 10Jdlrobson: Hygiene: Correctly enable watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193005 [00:59:43] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Correctly enable watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193005 (owner: 10Jdlrobson) [01:03:24] (03PS2) 10Jdlrobson: Hygiene: Use server side templating for checkbox generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192961 [01:03:34] (03PS6) 10Fjalapeno: Fix for "entries in TOC doubling up after pull to refresh" regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192973 (owner: 10Mhurd) [01:03:59] (03PS1) 10Jdlrobson: Hygiene: Rename/reorganise modules [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193014 [01:04:01] (03PS1) 10Jdlrobson: Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 [01:05:08] (03CR) 10jenkins-bot: [V: 04-1] Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (owner: 10Jdlrobson) [01:05:27] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Rename/reorganise modules [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193014 (owner: 10Jdlrobson) [01:06:04] jdlrobson, fyi I fixed the issue with automatic deployments to beta (I think), problem is it's difficult to confirm properly because it's still trying to redirect me to HTTPS, which can't work in beta [01:07:25] (03PS1) 10Deskana: Remove all images and recent uploads from UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193017 (https://phabricator.wikimedia.org/T90801) [01:07:30] Maryana: ^ [01:08:04] everybody, meet the newest member of mobile web :) [01:08:25] so going to http://wikidata.beta.wmflabs.org/ does not try to redirect you to HTTPS, jdlrobson? [01:09:31] (03CR) 10Bmansurov: "recheck" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192491 (owner: 10Bmansurov) [01:11:51] (03CR) 10Bmansurov: [C: 032] Hygiene: Use server side templating for checkbox generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192961 (owner: 10Jdlrobson) [01:12:53] (03PS7) 10Mhurd: Fix for "entries in TOC doubling up after pull to refresh" regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192973 [01:12:56] (03Merged) 10jenkins-bot: Hygiene: Use server side templating for checkbox generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192961 (owner: 10Jdlrobson) [01:15:28] bmansurov: I think https://gerrit.wikimedia.org/r/#/c/192961/ might need to be reverted [01:15:39] bmansurov: Now all checkboxes are always unchecked for me [01:15:48] bmansurov: can you verify? [01:15:55] Maryana: And his first act is to rip things out. [01:15:58] kaldari: looking into it [01:16:29] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193020 [01:17:46] kaldari: you're right, i'll submit a follow up, sounds good? [01:17:54] sure [01:18:15] (03PS8) 10Mhurd: Fix for "entries in TOC doubling up after pull to refresh" regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192973 [01:18:37] bmansurov: The old template seemed to be using some hogan-specific magic with “{$imagesChecked}” [01:18:47] kaldari: looks like so [01:18:56] bmansurov: which Jon changed to {{imagesChecked}} [01:20:56] (03CR) 10Fjalapeno: [C: 031] "looks good" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190637 (https://phabricator.wikimedia.org/T89541) (owner: 10Deskana) [01:21:01] (03PS1) 10Bmansurov: Mark checkboxes checked [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193022 [01:21:05] kaldari: ^ [01:21:24] 6Mobile-Web, 10MobileFrontend: Get rid of Special:Userprofile - https://phabricator.wikimedia.org/T90753#1068780 (10MZMcBride) This is somewhat related to {T85929}. [01:21:26] (The issue I was having with beta is gone, had to delete a stupid forcessl cookie that got set in my browser by evading the redirect by using a 404 page) [01:22:05] kaldari: sorry, it's not sticking after save [01:23:35] 6Mobile-Web, 10MobileFrontend: Get rid of Special:Userprofile - https://phabricator.wikimedia.org/T90753#1068794 (10Deskana) And to T90801. [01:26:00] coreyfloyd: i amended https://gerrit.wikimedia.org/r/#/c/192973/ [01:26:30] (03CR) 10Fjalapeno: [C: 031] Fix for "entries in TOC doubling up after pull to refresh" regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192973 (owner: 10Mhurd) [01:26:39] yay [01:26:52] 6Mobile-Web, 10MobileFrontend: What's the use of Special:UserProfile - https://phabricator.wikimedia.org/T90632#1068796 (10MZMcBride) >>! In T90632#1066472, @Maryana wrote: > Please engage constructively on Phabricator or don't engage at all. Asking for an opt out for a feature = constructive. Calling that fea... [01:36:52] (03PS2) 10Bmansurov: Mark checkboxes checked [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193022 [01:37:06] (03CR) 10MZMcBride: "I'm not sure this change is a good idea. I'll leave a note on ." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193017 (https://phabricator.wikimedia.org/T90801) (owner: 10Deskana) [01:38:10] 6Mobile-Web, 5Patch-For-Review: Remove last edited pageimage from Special:Userprofile - https://phabricator.wikimedia.org/T90801#1068810 (10MZMcBride) >>! In T90801#1068757, @gerritbot wrote: > Change 193017 had a related patch set uploaded (by Deskana): > Remove all images and recent uploads from UserProfile... [01:39:29] (03CR) 10jenkins-bot: [V: 04-1] Mark checkboxes checked [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193022 (owner: 10Bmansurov) [01:42:22] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193022 (owner: 10Bmansurov) [01:49:59] (03CR) 10Mhurd: "Quick comments." (038 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191527 (owner: 10Fjalapeno) [01:50:01] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193022 (owner: 10Bmansurov) [01:50:32] coreyfloyd: ping me if you want a quick hangout about the comments i left. [01:53:03] mhurd: i'm out [01:53:08] will look tomorrow [01:53:33] coreyfloyd: cool thanks! they’re tiny points [01:56:20] 6Mobile-Web, 10MobileFrontend, 7Easy: Get rid of Special:Userprofile - https://phabricator.wikimedia.org/T90753#1068845 (10MZMcBride) [01:57:49] (03PS1) 10Kaldari: Identifying which extension is complaining about dependency [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/193028 [02:04:02] MobileFrontend is an abomination. [02:04:06] Just, y'know, for the record. [02:04:49] 10MobileFrontend: Special:UserProfile has unclosed div which destroy the page view - https://phabricator.wikimedia.org/T90611#1068848 (10kaldari) I haven't been able to reproduce this bug. The HTML looks valid and the page seems to display fine. (Testing desktop version.) Can anyone else verify? If so, a screens... [02:06:53] Fiona: Hi Max. Good to see you too :) [02:07:43] kaldari: I would be nicer if I didn't believe that the mobile team acted in completely bad faith. [02:07:54] Hiding unrelated features in its extension fiefdom. [02:08:01] Creating a huge fucking mess for everyone else to deal with. [02:10:38] I hope the Germans destroy you all. :-) [02:10:43] Fingers crossed, anyway. [03:18:51] (03PS2) 10Dbrant: [WIP] Dark toolbar with white icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 [03:29:40] (03PS1) 10Dbrant: Tweak the size of gallery license icon. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193037 [03:43:17] (03PS1) 10Dbrant: Unregister clipboard listener in onDestroy instead of onStop. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193039 [03:47:10] 10Wikipedia-App-iOS-App: Image gallery slow to load after merging saved pages patch - https://phabricator.wikimedia.org/T90838#1068939 (10BGerstle-WMF) 3NEW a:3Fjalapeno [03:47:35] (03PS2) 10BearND: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193020 [03:48:54] (03CR) 10BearND: [C: 032] "Had to quote % sign in app store description." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193020 (owner: 10BearND) [03:49:14] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193020 (owner: 10BearND) [04:13:40] (03PS1) 10BearND: Remove obsolete language folders [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193041 [04:13:42] (03PS1) 10BearND: Remove translations below the completion threshold [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193042 [04:32:47] (03PS2) 10BearND: Tweak the size of gallery license icon. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193037 (owner: 10Dbrant) [04:32:52] (03CR) 10BearND: [C: 032] Tweak the size of gallery license icon. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193037 (owner: 10Dbrant) [04:33:24] (03Merged) 10jenkins-bot: Tweak the size of gallery license icon. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193037 (owner: 10Dbrant) [04:36:04] (03PS1) 10Mhurd: Regression fix for TOC root level sections titles not being bold. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193045 [04:36:10] (03PS2) 10BearND: Unregister clipboard listener in onDestroy instead of onStop. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193039 (owner: 10Dbrant) [04:36:17] (03CR) 10BearND: [C: 032] Unregister clipboard listener in onDestroy instead of onStop. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193039 (owner: 10Dbrant) [04:36:37] (03Merged) 10jenkins-bot: Unregister clipboard listener in onDestroy instead of onStop. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193039 (owner: 10Dbrant) [05:14:15] 10Wikipedia-App-Android-App, 7Easy: Take advantage of the new isMainPage() and isFilePage() methods added to the Page class - https://phabricator.wikimedia.org/T90843#1069047 (10Deskana) 3NEW [05:14:40] 10Wikipedia-App-Android-App, 7Easy: Take advantage of the new isMainPage() and isFilePage() methods added to the Page class - https://phabricator.wikimedia.org/T90843#1069054 (10Deskana) p:5Triage>3Lowest [05:28:00] 10MobileFrontend: Special:UserProfile has unclosed div which destroy the page view - https://phabricator.wikimedia.org/T90611#1069055 (10Saenger) Here's what my "profile" looks like: {F47325} [06:26:18] (03CR) 10Florianschmidtwelzow: Hygiene: Use server side templating for checkbox generation (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192961 (owner: 10Jdlrobson) [06:30:04] (03CR) 10Florianschmidtwelzow: [C: 032] Mark checkboxes checked [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193022 (owner: 10Bmansurov) [06:31:19] (03Merged) 10jenkins-bot: Mark checkboxes checked [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193022 (owner: 10Bmansurov) [06:33:38] (03PS1) 10Florianschmidtwelzow: Hygiene: Follow coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 [06:49:18] 10MobileFrontend: Special:UserProfile has unclosed div which destroy the page view - https://phabricator.wikimedia.org/T90611#1069118 (10wctaiwan) This seems to happen on dewiki, but not on enwiki, meta or zhwiki. [06:49:21] 10MobileFrontend: Special:UserProfile has unclosed div which destroy the page view - https://phabricator.wikimedia.org/T90611#1069119 (10MZMcBride) https://de.wikipedia.org/w/index.php?title=Spezial:Benutzerprofil/S%C3%A4nger_S.G&useskin=vector certainly looks broken to me currently. [06:52:05] (03PS2) 10Florianschmidtwelzow: Improvements for answer feature in TalkSectionOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189212 [06:55:14] 10Wikipedia-App-Android-App, 6Mobile-Apps, 10Wikimedia-Hackathon-2015: Create Wikipedia Lite app. - https://phabricator.wikimedia.org/T90758#1069123 (10Qgil) [06:56:18] 10Wikipedia-App-Android-App, 10Wikimania-Hackathon-2015, 10Wikimedia-Hackathon-2015, 7Design: Add an easier and faster way to change the search language - https://phabricator.wikimedia.org/T87154#1069125 (10Qgil) [07:01:38] 10Wikipedia-App-iOS-App, 10Wikimedia-Hackathon-2015: Make iOS app Wikidata description editable - https://phabricator.wikimedia.org/T90765#1069129 (10Qgil) [07:01:58] 10Wikipedia-App-iOS-App, 10Wikimania-Hackathon-2015: Enable background sync of saved page data on iOS app. - https://phabricator.wikimedia.org/T90769#1069131 (10Qgil) [07:28:17] 6Mobile-Web: Formatting of TOC header messed up - https://phabricator.wikimedia.org/T90791#1069168 (10eplawless) I came here to report this bug :) It's very noticeable, running Chrome 40 on Windows 7. Otherwise, the redesign looks great! [07:29:06] 10MobileFrontend: Special:UserProfile has unclosed div which destroy the page view - https://phabricator.wikimedia.org/T90611#1069169 (10MZMcBride) Perhaps , but I'm quite tired. [07:39:13] (03CR) 10Florianschmidtwelzow: [C: 04-1] "You need to rename the modules in the files, where they are used, too :)" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193014 (owner: 10Jdlrobson) [07:58:38] morning all [08:04:16] (03CR) 10Florianschmidtwelzow: [C: 032] Overlay, Panel, Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [08:05:20] (03Merged) 10jenkins-bot: Overlay, Panel, Drawer made to use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188673 (https://phabricator.wikimedia.org/T87192) (owner: 10Sumit) [09:15:18] 6Mobile-Web, 5Patch-For-Review: Remove last edited pageimage from Special:Userprofile - https://phabricator.wikimedia.org/T90801#1069318 (10Troubled.asset) The same problem applies to the last uploaded picture. What if I upload a "problematic" picture? This will be displayed accordingly in my mobile profile, u... [10:04:24] good morning [10:09:32] hey joakino [10:26:26] hello phuedx [10:48:29] 6Mobile-Web, 5Patch-For-Review: Overlay, Panel and Drawer should use View##events - https://phabricator.wikimedia.org/T87192#1069436 (10Sumit) a:3Sumit [10:48:39] 6Mobile-Web, 5Patch-For-Review: Overlay, Panel and Drawer should use View##events - https://phabricator.wikimedia.org/T87192#1069437 (10Sumit) 5Open>3Resolved [11:09:45] (03Abandoned) 10Saltymule: Fix image map on article view [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192971 (owner: 10Saltymule) [11:18:30] (03PS1) 10Saltymule: Fix image map on article view [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193079 (https://phabricator.wikimedia.org/T87080) [12:07:14] (03PS1) 10Phuedx: Four minute abs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193083 [12:07:29] (03CR) 10Phuedx: [C: 04-2] Four minute abs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193083 (owner: 10Phuedx) [12:07:38] brb snack [12:10:04] (03CR) 10Yuvipanda: "Just wanted to say awesome commit subject." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193083 (owner: 10Phuedx) [12:11:08] YuviPanda: i'm hoping we agree to merge it because of the commit subject [12:11:17] :D [12:11:21] if you're not having fun, then yer doing it wrong [12:11:27] :D [12:15:48] phuedx: joakino will you guys hate me if I move the meeting by one hour? it ended up smack in dinner time, and I had not done the math properly [12:16:08] hmm, I see it conflicts for other people [12:16:12] 10MobileFrontend: Special:UserProfile has unclosed div which destroy the page view - https://phabricator.wikimedia.org/T90611#1069569 (10Saenger) >>! In T90611#1069118, @wctaiwan wrote: > This seems to happen on dewiki, but not on enwiki, meta or zhwiki. Strange, but you seem to be right: https://meta.wikimedi... [12:16:33] phuedx: joakino can I move it by 30min? [12:16:46] doesn’t seem to conflict... [12:16:47] * YuviPanda moves it [12:16:54] YuviPanda: be bold [12:16:58] yup [12:18:00] phuedx: done [12:18:12] phuedx: joakino bgerstle I’m still confused about what the agenda of this meeting is, tbh. [12:18:18] unless the etherpad has been updated since [12:18:28] i haven't updated the meeting [12:18:40] i think it's now a bit more of an informal chat [12:18:43] right [12:19:00] because the difficulties i perceived when i sent that email aren't really there any more [12:19:10] it'd still be good to talk about it [12:19:15] right, right. [12:20:19] phuedx: hmm, now I’m wondering if we can chat over some other medium (the IRC channel, perhaps). I’m wary of meetings with no set agendas. [12:20:50] but if you guys feel like a meeting would be useful, ’tis fine [12:21:55] YuviPanda: to discuss issues that might arise moving something from labs to production [12:22:09] that’s better! [12:22:22] i'll update the pad [12:22:26] ty [12:25:33] updated [12:25:37] ty [12:36:56] going for lunch [13:20:58] (03CR) 10Zfilipin: [C: 032] Setup browser tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191083 (owner: 10Jhernandez) [13:22:07] (03Merged) 10jenkins-bot: Setup browser tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191083 (owner: 10Jhernandez) [13:33:31] yo [13:51:26] 6Mobile-Web, 10MobileFrontend: What's the use of Special:UserProfile - https://phabricator.wikimedia.org/T90632#1069712 (10Aklapper) @MZMcBride: Sure, but language used to describe a potentially valid problem and actual workflows/technical aspects seem orthogonal... [14:01:43] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: Don't override Special:Watchlist with Special:EditWatchlist - https://phabricator.wikimedia.org/T88270#1069763 (10Nemo_bis) The user said she was confused; don't shoot the messenger. Could you explain what data is available? By "use", do you mean actually cl... [14:04:03] 6Mobile-Web, 5Patch-For-Review: Remove last edited pageimage from Special:Userprofile - https://phabricator.wikimedia.org/T90801#1069765 (10Saenger) >>! In T90801#1068810, @MZMcBride wrote: >>>! In T90801#1068757, @gerritbot wrote: >> Change 193017 had a related patch set uploaded (by Deskana): >> Remove all i... [14:07:40] 6Mobile-Web, 10MobileFrontend: What's the use of Special:UserProfile - https://phabricator.wikimedia.org/T90632#1069773 (10Saenger) Why was this invented? Who asked for it? Where was it discussed? Why is it named User**Profile**? What's the official purpose of this? [14:16:25] 6Mobile-Web, 10MobileFrontend: What's the use of Special:UserProfile - https://phabricator.wikimedia.org/T90632#1069778 (10Raymond) The main problem, besides NSFW images, is that the user does not have control over the content of Special:UserProfile. And every link to the normal user page in MobileFrontend is... [14:25:34] Deskana|Away can do php [14:25:41] can we steal him for the mobile web team!? [14:29:19] (03CR) 10Dbrant: "@BearND needs manual rebase." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193041 (owner: 10BearND) [14:40:06] (03PS1) 10Dbrant: Fix shadow for ToC and nav drawer in RTL. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193104 [14:55:16] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: Remove last edited pageimage from Special:Userprofile - https://phabricator.wikimedia.org/T90801#1069812 (10Se4598) [14:56:01] 6Mobile-Web, 10MobileFrontend: What's the use of Special:UserProfile - https://phabricator.wikimedia.org/T90632#1069815 (10Se4598) for the others as info: as far as I have followed this we have now (open) * {T90753} * {T90801} if you have other constructive improvement requests/bug reports, please open a new t... [15:26:31] (03CR) 10Dbrant: [C: 04-1] "A couple things:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192505 (owner: 10BearND) [15:27:50] (03PS2) 10Phuedx: Add the MobileViewBannerImageRepository [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 [15:28:38] (03CR) 10Phuedx: "You're absolutely right @Bmansurov. Thanks!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [15:29:26] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: Remove last edited pageimage from Special:Userprofile - https://phabricator.wikimedia.org/T90801#1069935 (10MZMcBride) >>! In T90801#1069765, @Saenger wrote: > Can you please enlighten me on this "little value" of this "feature"? > I fail to see any value at... [15:29:38] (03CR) 10jenkins-bot: [V: 04-1] Add the MobileViewBannerImageRepository [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [15:34:44] YuviPanda: you mean you actually stop coding to eat? ;-) [15:35:19] brb [15:35:20] (03PS3) 10Phuedx: Add the MobileViewBannerImageRepository [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 [15:39:05] (03CR) 10jenkins-bot: [V: 04-1] Add the MobileViewBannerImageRepository [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [15:40:55] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: Don't override Special:Watchlist with Special:EditWatchlist - https://phabricator.wikimedia.org/T88270#1069965 (10MZMcBride) >>! In T88270#1067643, @Jdlrobson wrote: > Note, this feature is likely to be revisited/rewritten as part of the collections work anyh... [15:41:39] phuedx: "can do php" is a strong term [15:41:42] phuedx: :-p [15:44:38] 10MobileFrontend: Special:UserProfile has unclosed div which destroy the page view - https://phabricator.wikimedia.org/T90611#1069981 (10MZMcBride) For what it's worth, looks broken to me. [15:45:06] (03CR) 10Jhernandez: Add json user page storage for a collection (034 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [15:46:04] (03PS5) 10Jhernandez: Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 [15:48:51] 10MobileFrontend: Special:UserProfile has unclosed div which destroy the page view - https://phabricator.wikimedia.org/T90611#1069991 (10Se4598) Due a missing closing div-tag, the header and sidebar (div#mw-navigation) are now within div#content dewiki has in its MediaWiki:Vector.css, which causes the wrong alig... [15:53:33] 10MobileFrontend: Special:UserProfile has unclosed div which destroy the page view - https://phabricator.wikimedia.org/T90611#1070017 (10Se4598) >>! In T90611#1069169, @MZMcBride wrote: > Perhaps this is so funny http://www.sansbullshitsans.com/ [15:59:49] joakino: omg [16:00:04] :D [16:23:13] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: Remove last edited pageimage from Special:Userprofile - https://phabricator.wikimedia.org/T90801#1070133 (10Peteforsyth) >>! In T90801#1069935, @MZMcBride wrote: > I don't think we want to break existing links to Special:UserProfile/. One option might b... [16:27:20] bgerstle: indeed. delicious, delicious food! :D [16:32:43] YuviPanda: you look blocked to everybody [16:33:31] joakino: I think my connection just died. [16:33:39] hoho [16:35:20] (03CR) 10Jhernandez: "Where are the icons less? :S" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193014 (owner: 10Jdlrobson) [16:45:23] 6Mobile-Web, 10MobileFrontend: What's the use of Special:UserProfile - https://phabricator.wikimedia.org/T90632#1070240 (10Begoon) From the comments and examples linked, this is evidently a very poorly thought out "feature", adding little, and leaving open many avenues of abuse. I trust it will be removed, no... [16:46:48] (03CR) 10Fjalapeno: [C: 031] Regression fix for TOC root level sections titles not being bold. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193045 (owner: 10Mhurd) [16:58:42] (03CR) 10Legoktm: Add json user page storage for a collection (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [16:59:19] (03PS2) 10BearND: Remove obsolete language folders [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193041 [16:59:21] (03PS2) 10BearND: Remove translations below the completion threshold [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193042 [17:05:06] (03PS4) 10Fjalapeno: Add Search Suggestions to web view [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191527 [17:05:52] bgerstle: you mind giving my search suggestions patch a pass when/if you have time? [17:11:28] (03CR) 10Jhernandez: Add json user page storage for a collection (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [17:18:55] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Hone in on, and eradicate, article load time performance issues - https://phabricator.wikimedia.org/T90255#1070363 (10dr0ptp4kt) A number of things have been identified at https://etherpad.wikimedia.org/p/instruments_observations. [17:21:35] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Implement Schema:MobileWikiAppSearch - https://phabricator.wikimedia.org/T90257#1070366 (10dr0ptp4kt) Meeting scheduled with Nik Everett and Jon Robson to discuss what a spike might look like. [17:24:50] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [Blocked on design] Improve loading indicator to make it less feel less heavy to the user - https://phabricator.wikimedia.org/T90812#1070384 (10dr0ptp4kt) To follow up on discussion with Monte yesterday: * The existing spinner was a stopgap mostly related... [17:33:51] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [17:34:57] coreyfloyd: sure [17:50:04] 10Wikipedia-App-iOS-App: Image gallery slow to load after merging saved pages patch - https://phabricator.wikimedia.org/T90838#1070469 (10Fjalapeno) @bgerstle - do you have some more info? OS, Device, an article to test? I didn't see any difference on my device through casual browsing. everything was pretty ins... [17:50:27] coreyfloyd: nothing concrete, just something i noticed. i can look into it more [17:50:57] bgerstle: yeah - Im not seeing anything at all - like everything just loads [17:51:07] ok, could be a false alarm. thanks for checking anyway [17:51:13] np [17:51:25] (03CR) 10Phuedx: [C: 032] Hygiene: Follow coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 (owner: 10Florianschmidtwelzow) [17:51:26] bgerstle: i also need to pull out an older device too [17:51:31] and see what i see [17:51:40] but nothing noticible on modern hardware [17:52:29] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Follow coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 (owner: 10Florianschmidtwelzow) [17:54:03] (03CR) 10Bgerstle: [C: 031] "code looks good to me, haven't tested though" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191527 (owner: 10Fjalapeno) [17:57:29] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 (owner: 10Florianschmidtwelzow) [17:58:25] (03PS1) 10Jdlrobson: Remove capitalization. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193145 [18:03:42] hey joakino so how do i get gather up and running? [18:04:00] jdlrobso_: 1 sec, i'm removing old jsons xd [18:04:14] content handler works for new json pages [18:04:23] old ones are horribly broken [18:04:49] jdlrobso_: i don't remember what is in master [18:05:10] gonna get george to bed [18:05:44] jdlrobso_: have you cloned the repo and put the require on localsettings? [18:09:16] bgerstle: out to lunch - back in an hour [18:09:34] the require? [18:09:41] i've got gather running but Special:Gather [18:09:43] gives me an empty page [18:09:46] 10Wikipedia-App-iOS-App, 10Wikimedia-Hackathon-2015: Make iOS app Wikidata description editable - https://phabricator.wikimedia.org/T90765#1070526 (10KLans_WMF) p:5Triage>3Low [18:10:44] 10Wikipedia-App-iOS-App, 10Wikimania-Hackathon-2015: Enable background sync of saved page data on iOS app. - https://phabricator.wikimedia.org/T90769#1070529 (10KLans_WMF) p:5Triage>3Low [18:12:20] jdlrobso_: oki, have a look at https://trello.com/c/H6lExls3/18-5-add-collection-to-index , the 4th comment more or less there are a few steps [18:12:56] jdlrobso_: basically create User:Youruser/GatherCollections.json and fill it with http://en.m.wikipedia.beta.wmflabs.org/wiki/User:Jhernandez/GatherCollections.json#/editor/0 for example [18:13:12] ok got it [18:13:24] jdlrobso_: that gives you the data for Special:Gather . The patch for the details collection json is still in flux :S [18:13:43] (03CR) 10Jhernandez: [C: 04-2] "This is broken ATM. Fixing it now." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [18:14:04] ok working now :) [18:14:17] well.. kind of [18:14:32] Error - Page not found [18:15:24] (03CR) 10Jdlrobson: [C: 032] Hygiene: Follow coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 (owner: 10Florianschmidtwelzow) [18:16:34] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Follow coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 (owner: 10Florianschmidtwelzow) [18:16:48] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Image thumbnail urls should be included where applicable in wikidata API response for commonsMedia - https://phabricator.wikimedia.org/T76827#1070552 (10Jdlrobson) 5declined>3Open According to @MaxSem use of thumb.php will fry the cluster. [18:17:00] (03CR) 10Jdlrobson: "Might or will? See https://phabricator.wikimedia.org/T76827" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192855 (owner: 10Jdlrobson) [18:17:07] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Saved pages UI corrupt when displayed during refresh. - https://phabricator.wikimedia.org/T90746#1070556 (10KLans_WMF) p:5Triage>3High [18:17:53] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [Spike 4 hours] HockeyApp - https://phabricator.wikimedia.org/T90659#1070559 (10KLans_WMF) p:5Triage>3Normal [18:19:44] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Mobile-Apps, and 4 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1063059 (10KLans_WMF) [18:21:13] 10Wikipedia-App-iOS-App: Article caches are being removed unnecessarily when network connection in lost - https://phabricator.wikimedia.org/T90525#1070564 (10KLans_WMF) p:5Triage>3Low [18:21:21] (03CR) 10Jdlrobson: [C: 04-1] Improvements for answer feature in TalkSectionOverlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189212 (owner: 10Florianschmidtwelzow) [18:21:22] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Article caches are being removed unnecessarily when network connection in lost - https://phabricator.wikimedia.org/T90525#1061244 (10KLans_WMF) [18:22:28] 10Wikipedia-App-iOS-App: GIFs don't animate when displayed in the image gallery - https://phabricator.wikimedia.org/T90444#1070577 (10Deskana) Not a blocker for the release of image gallery. [18:22:44] 10Wikipedia-App-iOS-App: GIFs don't animate when displayed in the image gallery - https://phabricator.wikimedia.org/T90444#1070578 (10dr0ptp4kt) p:5High>3Normal [18:22:52] (03CR) 10Jdlrobson: [C: 04-1] "bit confused - is the idea to swap out for one of them or have them both available?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [18:23:24] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Image thumbnail urls should be included where applicable in wikidata API response for commonsMedia - https://phabricator.wikimedia.org/T76827#1070585 (10brion) Note that the thumbnail size will need to be selectable through some input variab... [18:23:31] (03CR) 10Jdlrobson: Add the MobileViewBannerImageRepository (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [18:23:42] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: svg images do not display information in Image Gallery view - https://phabricator.wikimedia.org/T90298#1070587 (10KLans_WMF) [18:25:24] (03PS6) 10Jhernandez: Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 [18:26:12] (03CR) 10Jhernandez: [C: 031] "Seems to work now. Old pages are screwed though." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [18:26:58] 10Wikipedia-App-iOS-App: Image map is not displayed correctly in Image Gallery view - https://phabricator.wikimedia.org/T90294#1070609 (10KLans_WMF) p:5High>3Normal [18:27:22] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: svg images do not display information in Image Gallery view - https://phabricator.wikimedia.org/T90298#1070611 (10KLans_WMF) [18:27:23] 10Wikipedia-App-iOS-App: Image Gallery img comparison with Android - https://phabricator.wikimedia.org/T90296#1070610 (10KLans_WMF) [18:29:50] bmansurov, jdlrobso_ : Did you guys figure out any solution to the checkboxes being broken? [18:30:25] kaldari: yes, https://gerrit.wikimedia.org/r/#/c/193022/ [18:30:41] cool :) [18:32:32] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: Remove last edited pageimage from Special:Userprofile - https://phabricator.wikimedia.org/T90801#1070654 (10kaldari) I agree the last edited page image is problematic, and also the last uploaded image doesn't necessarily provide a good representation of the u... [18:33:17] kaldari: friendly reminder to take a look at this sometime today when you get a chance: http://etherpad.wikimedia.org/p/wikigrokcollections :) the sooner we submit, the higher the likelihood we'll get on the wikimania approval list [18:33:40] kristenlans, dr0ptp4kt: Room procured. [18:33:44] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Image thumbnail urls should be included where applicable in wikidata API response for commonsMedia - https://phabricator.wikimedia.org/T76827#1070664 (10Jdlrobson) I'm trying to avoid any roundtrips. It's too expensive in this use case :( [18:33:52] Maryana: it’s on my list, along with figuring out the deal with beta labs [18:34:03] roger [18:35:15] 10Wikipedia-App-iOS-App: Image Gallery: cannot open a random image - https://phabricator.wikimedia.org/T90293#1070669 (10Deskana) @Etonkovidova I am unable to reproduce this issue. [18:36:01] 10Wikipedia-App-iOS-App: Image Gallery: cannot open a random image - https://phabricator.wikimedia.org/T90293#1070673 (10Deskana) @BGerstle-WMF FYI I am unable to reproduce this issue. Can you? [18:37:03] 10Wikipedia-App-iOS-App, 6Security: Support 1password for login - https://phabricator.wikimedia.org/T90033#1070675 (10KLans_WMF) p:5Triage>3Low [18:37:27] 10Wikipedia-App-iOS-App: Image Gallery: cannot open a random image - https://phabricator.wikimedia.org/T90293#1070677 (10BGerstle-WMF) @Deskana haven't tried yet. Will report back here when I get around to debugging this issue. [18:37:45] 10Wikipedia-App-iOS-App: Image Gallery: cannot open a random image - https://phabricator.wikimedia.org/T90293#1070687 (10Deskana) Great. Thanks. [18:38:15] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Some articles about cities are broken in iOS app beta 4.0.6.3 - https://phabricator.wikimedia.org/T90032#1051850 (10KLans_WMF) [18:38:16] (03PS2) 10Jdlrobson: Hygiene: Rename/reorganise modules [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193014 [18:38:17] ^ joakino [18:38:21] 10Wikipedia-App-iOS-App, 6Security: Support 1password for login - https://phabricator.wikimedia.org/T90033#1070692 (10BGerstle-WMF) As a 1Password user, I support this feature :-) [18:38:35] kaldari: MaxSem: bmansurov: phuedx: do any of you guys know what is the name of the maintenance script that generates extension.json? [18:38:55] 10Wikipedia-App-iOS-App: Allow pinch zooming even when image in image viewer is smallish - https://phabricator.wikimedia.org/T89915#1070694 (10Deskana) Doesn't need to block release. [18:39:00] joakino: php maintenance/convertExtensionToRegistration.php [18:39:03] 10Wikipedia-App-iOS-App: Allow pinch zooming even when image in image viewer is smallish - https://phabricator.wikimedia.org/T89915#1070695 (10KLans_WMF) p:5High>3Low [18:39:16] ok thanks James_F :D [18:39:22] jdlrobso_: ^ [18:39:55] joakino: i've started a mail thread having 2 sources of truth is not sustainable [18:39:59] joakino: It's not perfect yet (I have to manually tweak the output when run for VisualEditor), but it's close. [18:40:04] when we did LESS it was a huge mess [18:40:15] (compiling less files manually) [18:40:22] jdlrobso_, there will be no 2 sources soon, it's just a transitional period [18:40:28] jdlrobso_: extension.json will be the only source in a few weeks time, once most extensions have been converted. [18:40:35] MaxSem: sure but Resources is messy in extensions.json [18:40:52] jdlrobso_: It's just really slow to load extension.json and Extension.php side-by-side. [18:40:55] lack of comments and lack of ability to provide defaults in modules is nasty [18:41:19] e.g. 'ext.gather.styles' => $wgGatherResourceFileModuleBoilerplate + array( [18:41:51] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: as a user I should be able to swipe on non-horizontal scrolling content to navigate back through browsing history - https://phabricator.wikimedia.org/T89798#1070722 (10KLans_WMF) p:5Triage>3Low [18:42:32] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Page image should animate in rather than appearing suddenly - https://phabricator.wikimedia.org/T89797#1070730 (10KLans_WMF) p:5Triage>3Low [18:42:47] jdlrobso_: regarding https://gerrit.wikimedia.org/r/#/c/193014/ , we need the first span.mw-ui-icon display:inline-block otherwise the user icon goes to shit [18:43:04] jdlrobso_: you are right the icons css is generated automatically, cool [18:43:16] let's put that in core then [18:43:38] joakino: wait.. it looks fine for me [18:43:43] firefox only? [18:43:54] MaxSem: I'm getting the following error: https://gist.github.com/anonymous/ab92010ec921caab1240 Do you know how I can fix it? [18:44:01] (03PS3) 10BearND: ShareAFact: EL update [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192505 [18:44:11] 10Wikipedia-App-iOS-App, 7Easy: When I tap on a licence, read it, and tap back, I should be taken back to the same scroll position I was at previously rather than the top - https://phabricator.wikimedia.org/T89759#1070756 (10Deskana) p:5Low>3Lowest [18:44:21] joakino: that rule is in MobileFrontend no? [18:44:24] (03PS4) 10BearND: ShareAFact: EL update [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192505 [18:44:34] jdlrobso_: in gather icons.less too [18:44:42] joakino: but it's not needed there [18:44:51] it's already present in the page [18:44:57] take a look http://localhost:8080/wiki/Special:Gather/Jdlrobson/0 [18:45:14] jdlrobso_: this is what i'm seeing http://i.imgur.com/ezgkHNC.png [18:45:28] joakino: in alpha? [18:45:38] latest core / mfe ? [18:45:38] jdlrobso_: in all modes [18:45:47] i'm booting up firefox now [18:45:51] jdlrobso_: yep, updated them 10 minutes ago [18:45:53] that was chrome [18:45:55] but inspect the dom that rule is present for me.. [18:45:57] 10Wikipedia-App-iOS-App: App occasionally flashes where lead paragraph is overlapping lead image - https://phabricator.wikimedia.org/T89535#1070780 (10KLans_WMF) p:5Triage>3Normal [18:46:10] jdlrobso_: wait [18:46:20] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Article caches are being removed unnecessarily when network connection in lost - https://phabricator.wikimedia.org/T90525#1070785 (10Mhurd) I believe we fixed these with https://gerrit.wikimedia.org/r/#/c/192993/ [18:46:26] 10Wikipedia-App-iOS-App: Footnote overlap on tablets includes significant blank space - https://phabricator.wikimedia.org/T89529#1070786 (10KLans_WMF) p:5Triage>3Low [18:46:45] jdlrobso_: yea devtools open, no cache, that's what i see with patch 193014 checked out [18:46:52] in chrome [18:46:57] 10Wikipedia-App-iOS-App: In article chrome pops out when you unfold a collapsable table - https://phabricator.wikimedia.org/T89522#1070789 (10KLans_WMF) p:5Triage>3Normal [18:47:00] oh wait now i can get it [18:47:03] caching issue maybe [18:47:07] but yeh this should be in MobileFrontend [18:47:08] i thought it was.. [18:47:25] (03CR) 10BearND: "@Dbrant: Thank you for the comments. PS3 should address those concerns." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192505 (owner: 10BearND) [18:48:20] Deskana: ^ [18:48:25] (03PS2) 10Jdlrobson: Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 [18:48:27] (03PS3) 10Jdlrobson: Hygiene: Rename/reorganise modules [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193014 [18:48:34] ^ joakino there we go [18:48:45] dr0ptp4kt: ^^ [18:48:51] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: Remove last edited pageimage from Special:Userprofile - https://phabricator.wikimedia.org/T90801#1070813 (10Saenger) Special:UserProfile/ suggests a user profile page, which it is not currently. If the linking to this (imho completely futile) page shoul... [18:49:09] 10Wikipedia-App-iOS-App: Footnote overlap on tablets includes significant blank space - https://phabricator.wikimedia.org/T89529#1070817 (10Mhurd) I think I disagree. The reason is if you tap a footnote that has adjacent footnotes, you are able to swipe left and right between them, and I'm not sure we want the f... [18:49:26] (03CR) 10jenkins-bot: [V: 04-1] Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (owner: 10Jdlrobson) [18:49:43] jdlrobso_: it is on mf in iconsNew.less line 98, i don't know why we are not getting it [18:52:12] (03CR) 10Jhernandez: [C: 032] "Much better" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193014 (owner: 10Jdlrobson) [18:52:24] jdlrobso_: anyway, done! [18:53:15] (03Merged) 10jenkins-bot: Hygiene: Rename/reorganise modules [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193014 (owner: 10Jdlrobson) [18:53:20] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193005 (owner: 10Jdlrobson) [18:53:24] (03PS4) 10Jdlrobson: Hygiene: Correctly enable watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193005 [18:56:12] (03CR) 10Phuedx: "I could get rid of the pageimages version to make the patch simpler. I wanted to make the transition in a few steps but it's not communica" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [18:57:29] jdlrobso_: lolz https://gerrit.wikimedia.org/r/#/c/193015/2/resources/ext.gather.watchstar/init.js [18:57:39] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Mobile-Apps, 10Wikimedia-Hackathon-2015: Create Wikipedia Lite app. - https://phabricator.wikimedia.org/T90758#1070866 (10dr0ptp4kt) [18:57:43] joakino: lol! [18:57:46] coreyfloyd: hey! have a sec for hangout? [18:57:55] haha xD [18:59:49] mhurd: My new standing desk allows me to watch you like a hawk. [19:00:22] jdlrobso_: in https://gerrit.wikimedia.org/r/#/c/193015/2/includes/Gather.hooks.php how is mobile['watch'] overriding ? or is that not what is going onmobile.watchstar.init [19:00:47] crap, again: how is mobile['watch'] overriding mobile.watchstar.init? or is that not what is going on [19:03:53] 10Wikipedia-App-iOS-App, 7Epic, 3Mobile App Sprint 52 - iOS: [Blocked on design] Improve loading indicator to make it less feel less heavy to the user - https://phabricator.wikimedia.org/T90812#1070897 (10KLans_WMF) [19:04:13] gonna go for a bouldererererer [19:04:38] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [Blocked on design] Improve loading indicator to make it less feel less heavy to the user - https://phabricator.wikimedia.org/T90812#1068113 (10KLans_WMF) [19:04:57] phuedx: MaxSem: is WikidataBuildResources broken with master core & mf? i'm getting this in all articles https://gist.github.com/joakin/d2f56268b86c91f48a99 [19:05:31] ask aude or hoo? [19:05:37] yowza [19:05:40] i've yet to see that [19:05:47] bmansurov just reported the same thing, right [19:05:49] ? [19:06:02] lol : bmansurov has left IRC [19:06:14] just before your message phuedx hah [19:06:22] joakino: i had that yesterday [19:06:26] i disabled the role [19:06:35] jdlrobso_: the wikigrok role? [19:07:02] joakino: in terms of overriding SkinMinervaDefaultModules is run before returning default modules [19:07:13] modules are grouped by feature to allow you to swap them out [19:07:18] joakino: wikigrok role yeh [19:07:24] my instance is faster now too [19:07:35] on down side i can't review wikigrok [19:07:53] but i warned people about that during the project split :) [19:08:58] haha [19:10:06] Deskana: i submitted my hackathon request in google forms [19:10:16] dr0ptp4kt: Good man! Thanks. :) [19:13:59] disabled, and i get the same fucking stacktrace [19:14:12] (03PS1) 10Jdlrobson: Hygiene: Refactor Watchstar for Extension:Gather [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193156 [19:14:43] (03CR) 10Mhurd: [C: 04-1] "Added comments. Seeing crash on simulator." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190637 (https://phabricator.wikimedia.org/T89541) (owner: 10Deskana) [19:15:04] dr0ptp4kt: ^ seeing crash [19:15:19] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Refactor Watchstar for Extension:Gather [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193156 (owner: 10Jdlrobson) [19:15:22] mhurd: thanks [19:15:39] (03CR) 10Bmansurov: [C: 032] Remove capitalization. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193145 (owner: 10Jdlrobson) [19:16:48] (03PS2) 10Jdlrobson: Hygiene: Refactor Watchstar for Extension:Gather [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193156 [19:16:52] (03Merged) 10jenkins-bot: Remove capitalization. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193145 (owner: 10Jdlrobson) [19:16:58] mhurd: so that i can reproduce, which simulator version? [19:17:03] dr0ptp4kt: could maybe scope the regex to run on the first x character of the section html - maybe first 500 chars or 1000 chars? [19:17:13] dr0ptp4kt: 8.1 [19:17:17] mhurd: yeah, that's what i was thinking, glad you had the same idea [19:17:23] :) [19:17:33] joakino: did you get an email with subject "browsertests-MobileFrontend-SmokeTests-linux-chrome-sauce - Build # 25 - Failure!" [19:18:06] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Refactor Watchstar for Extension:Gather [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193156 (owner: 10Jdlrobson) [19:18:57] (03CR) 10BearND: [C: 032] Fix shadow for ToC and nav drawer in RTL. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193104 (owner: 10Dbrant) [19:19:30] (03Merged) 10jenkins-bot: Fix shadow for ToC and nav drawer in RTL. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193104 (owner: 10Dbrant) [19:19:48] mhurd: which device type? [19:19:53] jdlrobso_: i think i ddi [19:19:54] did* [19:19:58] bgerstle: awesome thanks [19:19:59] dr0ptp4kt: whoa interesting! by limiting to 1000 chars the obama article now finds a good snippet instead of “First term” or whatever it had been showing. [19:20:11] mhurd: that's hilarious [19:20:12] dr0ptp4kt: still crashes when i select “Email” though [19:20:14] lemme go confirm [19:20:21] iphone 5 [19:20:24] dr0ptp4kt: ^ [19:20:31] mhurd: thx [19:20:48] mhurd: does it crash when choosing mail on your phone? [19:20:54] mhurd: that is, your physical phone [19:21:06] dr0ptp4kt: lemme check - maybe be weird simulator cruft [19:21:26] mhurd: yeah, i dunno, we shall see [19:21:28] jdlrobso_: just forwarded to you to confirm [19:21:58] bgerstle: perfect :D [19:22:06] good :-) [19:23:40] dr0ptp4kt: also, the regex @"

(.+)

” isn’t greedy enough i think? will capture nested p tags? [19:23:41] phuedx: is your WIP patch for https://trello.com/c/Isf8stWH/26-5-new-mobile-menu-page on gerrit? [19:24:08] mhurd: dr0ptp4kt sounds like a good candidate for a unit test ;-) [19:24:12] eh, you're parsing html with regexps? [19:24:18] oh wait [19:24:21] yeah that's probably a bad idea [19:24:25] good call MaxSem [19:24:30] mhurd: you're correct, that's a suboptimal regex. i'm planning to write a follow on patch to be more like text extracts or at least android [19:24:31] (03PS3) 10Jdlrobson: WIP: Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 [19:24:33] dr0ptp4kt: no crash on device [19:24:34] ^ joakino making progress :) [19:24:38] bgerstle: yes! [19:24:43] mhurd: /me throws hands in air [19:24:50] see this SO article: http://stackoverflow.com/questions/1732348/regex-match-open-tags-except-xhtml-self-contained-tags [19:25:11] my vote for best SO thread of all time [19:25:33] (03CR) 10jenkins-bot: [V: 04-1] WIP: Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (owner: 10Jdlrobson) [19:26:58] mhurd: dr0ptp4kt ^^ [19:29:07] (03CR) 10Dr0ptp4kt: "The crash doesn't surface on the iPhone 5, iOS 8.1 simulator from my machine. @mhurd confirmed on physical device no crash." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190637 (https://phabricator.wikimedia.org/T89541) (owner: 10Deskana) [19:29:15] jdlrobso_: i had to disable wikidata for getting rid of that error [19:29:16] bgerstle: thx [19:29:39] mhurd: the plan is to rewrite the heuristic in a separate patch. are we good to go on this? [19:30:19] mhurd: or do you want me to resubmit the current patch with a 1000 character constant just in case? [19:30:26] (followed by a separate heuristic patch) [19:31:31] dr0ptp4kt: sounds good [19:32:00] joakino: yeh same [19:32:28] jdlrobso_: i'm leaving for today, i'll have a look at those patches tomorrow, will work on the api for listing collections (for choosing where to add), adding item to collection, and such [19:32:37] np [19:32:48] joakino: i'll hopefully have a patch i can hand off to you at the end of the day [19:33:00] ad we can have the ability to add/ remove items to list by the end of the week [19:33:15] oki, post updates on the card if it is ready/not like yesterday [19:33:41] ye let's see how far we can get [19:34:26] jdlrobso_: i also have monday morning till sprint retro/kickoff :p hopefully we'll get close to sprint completion [19:34:34] have a nice day everybody [19:34:38] see ya joakino! [19:35:52] (03CR) 10Jdlrobson: [C: 04-1] "rebase needed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189213 (owner: 10Florianschmidtwelzow) [19:36:03] (03PS3) 10Jdlrobson: Improvements for answer feature in TalkSectionOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189212 (owner: 10Florianschmidtwelzow) [19:36:13] mhurd: the former or the latter? ;) [19:36:42] (03PS2) 10Jdlrobson: Hygiene: Follow coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 (owner: 10Florianschmidtwelzow) [19:36:49] (03CR) 10Jdlrobson: [C: 031] Hygiene: Follow coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 (owner: 10Florianschmidtwelzow) [19:36:55] (03CR) 10Jdlrobson: [C: 032] "try again" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 (owner: 10Florianschmidtwelzow) [19:37:11] (03PS5) 10Jdlrobson: Hygiene: ImageOverlay should use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188622 (https://phabricator.wikimedia.org/T88566) [19:38:00] (03CR) 10Jdlrobson: "cmcmahon any updates to this? Keen to get this green again." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192816 (owner: 10Cmcmahon) [19:38:17] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Follow coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 (owner: 10Florianschmidtwelzow) [19:38:56] (03PS3) 10Jdlrobson: Hygiene: Refactor Watchstar for Extension:Gather [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193156 [19:38:58] (03PS5) 10Jdlrobson: Hygiene: Correctly enable watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193005 [19:39:29] (03CR) 10Jdlrobson: [C: 031] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 (owner: 10Florianschmidtwelzow) [19:39:32] 6Mobile-Web, 10MobileFrontend: What's the use of Special:UserProfile - https://phabricator.wikimedia.org/T90632#1070998 (10Alsee) The entire page is unhelpful at best, and the dick-pics demonstrate just how bad it is at worst. The dick-pics aren't the problem, the entire page is the problem. We have user pages... [19:39:38] (03CR) 10Jdlrobson: [C: 032] "merge again" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 (owner: 10Florianschmidtwelzow) [19:40:45] dr0ptp4kt: your call - the heuristic definitely needs work [19:41:21] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Follow coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 (owner: 10Florianschmidtwelzow) [19:41:22] mhurd: i'll resubmit with a 1000 character limit, you merge, i get to the heuristic on a separate patch. okay? [19:42:36] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Refactor Watchstar for Extension:Gather [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193156 (owner: 10Jdlrobson) [19:43:03] dr0ptp4kt: quick hangout? [19:43:46] oh iOS 6, how you frustrate me. let me count the ways... [19:44:39] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: Remove last edited pageimage from Special:Userprofile - https://phabricator.wikimedia.org/T90801#1071005 (10Alsee) Close this and reopen T90632. [19:44:53] hmm kaldari, can a user supply 2 answers to the same campaign? [19:45:11] sure [19:45:43] for example, an actor can be both a TV actor and a film actor [19:46:00] or a disease could have multiple symptoms [19:46:13] hmm, then when they reply again on the same page, how do we decide if they're replacing their answers or adding more details? [19:48:59] fuck, the more I bash my head at this data model, the more I want a document store [19:49:20] ALSO, MONGODB IS WEBSCALE [19:50:19] kaldari, ^^^ [19:50:28] also, you're wfh today? [19:52:47] MaxSem: They shouldn’t be able to reply again on the same page, but if they do, each item+property+value combination that they submit should replace any previous item+property+value submission they have made. [19:54:36] well kaldari, we consider all anons from the same IP as the same person. and imagine first they responded tv actor, the other time movie actor. should their tv actor response be kept? [19:55:29] didn't we just talk about this last week? :) we should really start documenting our convos. probably my bad. [19:56:38] MaxSem: That’s why we probably need to store userToken as well [19:57:37] mhurd, dr0ptp4kt: Lunch? [19:57:44] MaxSem: Also, we should be sure to only store one item+property+value in each wikigrok_aggregation record (which I assume is your plan) [19:58:00] yep to the latter [19:58:15] to the former: didn't we decide to ditch it? [19:58:49] MaxSem: Hmm, I think you’re right [20:02:17] MaxSem: So to answer you’re example, if an IP submits (tv actor:true, film actor:null) and then (tv actor:null, film actor:true), we should record (tv actor:null, film actor:true) as their final responses. Although if they submit (tv actor:true, film actor:null) and then (film actor:true), we would record (tv actor:true, film actor:true). [20:03:02] Maryana: Does that sound right? ^ [20:03:44] MaxSem: yes, working from home to avoid all the bombs :) [20:03:49] (03CR) 10Mhurd: [C: 032 V: 032] "Merge! With follow-on patch from Adam to fix text heuristic." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190637 (https://phabricator.wikimedia.org/T89541) (owner: 10Deskana) [20:03:52] BOOM [20:03:56] plus I have no meetings today! :) [20:06:56] sorry, my wifi dropped [20:07:15] kaldari: yes, i think that's right [20:11:04] 6Mobile-Web: User icon misplaced on User:Contributions page in beta - https://phabricator.wikimedia.org/T90920#1071136 (10kaldari) 3NEW [20:17:43] Maryana: I figured out why WikiGrok isn’t loading on beta labs. Should have it fixed this afternoon. [20:18:06] Maryana: It’s related to moving it to a separate extension (with new config vars) [20:51:26] (03PS1) 10Cmcmahon: QA: slight change to id value for section content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193257 [20:51:56] bearND: needs another rebase?: https://gerrit.wikimedia.org/r/193041 [20:52:28] dbrant: k [20:52:39] (03Abandoned) 10Cmcmahon: QA: id values are now random(ish) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192816 (owner: 10Cmcmahon) [20:53:04] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10MediaWiki-API, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), and 2 others: Mobile apps users should not be shown captchas when creating accounts - https://phabricator.wikimedia.org/T88083#1071296 (10bd808) [20:53:09] (03PS3) 10BearND: Remove obsolete language folders [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193041 [20:53:11] (03PS3) 10BearND: Remove translations below the completion threshold [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193042 [20:53:24] dbrant: try now [20:54:11] dbrant: maybe it had to do with replacing the sym link with a real folder [20:54:49] that the patch cannot be automatically merged [20:56:14] (03CR) 10Dbrant: [C: 032] Remove obsolete language folders [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193041 (owner: 10BearND) [20:56:55] (03CR) 10Dbrant: [C: 032] Remove translations below the completion threshold [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193042 (owner: 10BearND) [21:05:30] dr0ptp4kt: hey, do you want to chat about the iOS trace stuff, or do you think you have everything you need to go into profiling meeting? [21:05:42] the etherpad w/ my trace notes should pretty much speak for itself [21:05:43] bgerstle: let's talk [21:05:46] ok [21:05:53] bgerstle: it does, although, i will call you [21:05:53] gimme a call whenever [21:05:57] on video [21:06:15] dr0ptp4kt: aw man, i guess i'll put my rotary phone away :( [21:06:55] bgerstle: i know, such a disappointment [21:13:46] Deskana: hey do you have a minute? [21:15:34] (03CR) 10Deskana: [C: 04-1] "Fixes the performance issue and looks good overall." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 (owner: 10Dbrant) [21:23:13] 6Mobile-Web, 10MobileFrontend: What's the use of Special:UserProfile - https://phabricator.wikimedia.org/T90632#1071468 (10Nemo_bis) [21:28:09] 10MobileFrontend: Use standard diff style in MobileFrontend - https://phabricator.wikimedia.org/T90948#1071492 (10Nemo_bis) 3NEW [21:28:20] 10MobileFrontend, 7Accessibility: Use standard diff style in MobileFrontend - https://phabricator.wikimedia.org/T90948#1071499 (10Nemo_bis) [21:32:53] mhurd: http://etherpad.wikimedia.org/p/instruments_observations [21:38:03] (03CR) 10BearND: [C: 04-1] "Agree with what Deskana said. Still need some time getting used to the new icon. It seems like the stroke is too thick to fit with the Mat" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 (owner: 10Dbrant) [21:41:57] 6Mobile-Web, 10MobileFrontend, 10MediaWiki-Special-pages, 7Technical-Debt: Special:UserProfile shouldn't live in MobileFrontend - https://phabricator.wikimedia.org/T85929#1071546 (10Nemo_bis) > a profile is auto-generated/displayed for (non-existent) user pages A solution consistent with how unregistered... [21:43:11] kaldari: ah ha. ok, thanks for the investigation/update! [22:03:41] (03CR) 10MaxSem: [C: 04-1] Remove all images and recent uploads from UserProfile (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193017 (https://phabricator.wikimedia.org/T90801) (owner: 10Deskana) [22:06:53] MaxSem: When removing messages from MediaWiki repos, do you just remove the entry from en.json and qq.json, or from all translations too? [22:07:04] MaxSem: In the apps we just remove the en and qq and the sync takes care of the rest. [22:07:06] just en is enough [22:07:11] kk, thanks [22:08:07] Deskana: we do the what MaxSem for the apps as well [22:08:13] -the [22:08:24] bearND: Yeah, I wanted to make sure that it was the same in MediaWiki extensions as in the apps. [22:08:31] bearND: Weren't sure if there were any differences or not. [22:12:56] https://www.mediawiki.org/wiki/Localisation#Removing_existing_messages [22:13:11] I don't know why it suggests qqq removal as well [22:16:27] (03PS2) 10Deskana: Remove all images and recent uploads from UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193017 (https://phabricator.wikimedia.org/T90801) [22:16:42] MaxSem: Thanks for the review. This patch should fix all your concerns. ^ [22:28:52] (03CR) 10Jdlrobson: [C: 032] QA: slight change to id value for section content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193257 (owner: 10Cmcmahon) [22:29:19] 6Mobile-Web, 5Patch-For-Review: ImageOverlay should use View##events - https://phabricator.wikimedia.org/T88566#1071830 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [22:29:27] 6Mobile-Web, 5Patch-For-Review: ImageOverlay should use View##events - https://phabricator.wikimedia.org/T88566#1071832 (10Jdlrobson) 5Resolved>3Open whoops. [22:30:05] (03Merged) 10jenkins-bot: QA: slight change to id value for section content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193257 (owner: 10Cmcmahon) [22:31:14] 6Mobile-Web: Watchstar icons in alpha and beta not aligned - https://phabricator.wikimedia.org/T89506#1071842 (10Jdlrobson) [22:33:37] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193156 (owner: 10Jdlrobson) [22:34:59] (03PS3) 10Jdlrobson: Hygiene: Follow coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 (owner: 10Florianschmidtwelzow) [22:36:04] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Follow coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 (owner: 10Florianschmidtwelzow) [22:36:06] (03CR) 10Jdlrobson: [C: 031] Hygiene: Follow coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 (owner: 10Florianschmidtwelzow) [22:36:12] (03CR) 10Jdlrobson: [C: 032] "3rd time lucky?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 (owner: 10Florianschmidtwelzow) [22:37:25] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Follow coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 (owner: 10Florianschmidtwelzow) [22:39:52] (03CR) 10Jdlrobson: [C: 04-1] "Minor tweak needed" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193017 (https://phabricator.wikimedia.org/T90801) (owner: 10Deskana) [22:41:17] (03CR) 10Jdlrobson: [V: 032] "tested locally works fine." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193059 (owner: 10Florianschmidtwelzow) [22:44:57] jdlrobson: I did what you suggested, removing MEDIUM_IMAGE_WIDTH and wgMFThumbnailMedium, but it broke stuff [22:45:09] (03PS4) 10Jdlrobson: Hygiene: Refactor Watchstar for Extension:Gather [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193156 [22:45:11] (03PS6) 10Jdlrobson: Hygiene: Correctly enable watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193005 [22:45:12] Wait. That may be because I'm an idiot. [22:45:14] Deskana: what did it break? [22:45:17] haha :) [22:45:23] Yes, it's because I'm an idiot [22:45:26] I left a comma in a bad place [22:45:48] Who'd've thought a misplaced comma would break the search box? [22:46:07] (03PS3) 10Deskana: Remove all images and recent uploads from UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193017 (https://phabricator.wikimedia.org/T90801) [22:46:12] jdlrobson: k, fixed ^ [22:46:22] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Refactor Watchstar for Extension:Gather [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193156 (owner: 10Jdlrobson) [22:47:11] Deskana: there's some issues with jenkins today so not sure ill be able to +2 "/ [22:47:21] (03CR) 10jenkins-bot: [V: 04-1] Remove all images and recent uploads from UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193017 (https://phabricator.wikimedia.org/T90801) (owner: 10Deskana) [22:48:01] (03CR) 10Deskana: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193017 (https://phabricator.wikimedia.org/T90801) (owner: 10Deskana) [22:48:18] jdlrobson: I guess it's that. It said that PhantonJS timed out. [22:48:38] Deskana: yeh i don't know what's going on. sadly antoine / Krinkle are probably not around [22:48:41] i cant' replicate locally [22:49:21] jdlrobson: recheck and hope for the best, I guess. [22:49:28] Deskana: been rechecking all day :/ [22:49:46] (03CR) 10Deskana: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193017 (https://phabricator.wikimedia.org/T90801) (owner: 10Deskana) [22:50:25] Deskana: Fatal error: Undefined class constant 'MEDIUM_IMAGE_WIDTH' in /mnt/jenkins-workspace/workspace/mwext-MobileFrontend-qunit/src/extensions/MobileFrontend/includes/MobileFrontend.hooks.php on line 363 [22:50:31] i guess this one is legit [22:50:38] jdlrobson: Oh, I guess I just don't know how to read those things then. [22:51:08] jdlrobson: How do I run these tests locally before submitting to gerrit? [22:51:39] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193156 (owner: 10Jdlrobson) [22:52:04] Deskana grunt tests [22:52:15] you'll need to run npm install first [22:52:26] jdlrobson: I've got all of that already for the iOS and Android apps. [22:52:40] you'll need to test it up locally for this repository though [22:53:33] jdlrobson: I am around [22:53:59] jdlrobson: PhantomJS does not time out. Check the build log [22:54:05] There's a php error on every page [22:54:23] Krinkle: on https://gerrit.wikimedia.org/r/#/c/193156/ ? [22:54:39] `A database query error has occurred.` [22:54:46] https://gerrit.wikimedia.org/r/#/c/193017/ [22:55:02] Krinkle: i know about that one see above [22:55:03] '14:50 jdlrobson: Deskana: Fatal error: Undefined class constant 'MEDIUM_IMAGE_WIDTH' in /mnt/jenkins-workspace/workspace/mwext-MobileFrontend-qunit/src/extensions/MobileFrontend/includes/MobileFrontend.hooks.php on line 363" [22:55:18] Krinkle: i'm curious about all the other ones that haven't merged today. I thought this was another example. [22:55:39] jdlrobson: mwext-MobileFrontend-qunit-mobile is failing because it is the only qunit job not running in labs. Running those in prod was removed. [22:55:46] Is there a reason that one runs on gallium? [22:55:59] i have no idea... antoine usually handles setting up these. [22:56:03] OK [22:56:10] let me re-enable support for that [22:56:17] Krinkle: thanks a bunch that would be most appreciated [22:56:21] * jdlrobson hugs krinkle [22:56:40] I removed it yesterday after migrating remaining -qunit jobs, but this one escaped the regex [23:00:26] (03PS4) 10Deskana: Remove all images and recent uploads from UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193017 (https://phabricator.wikimedia.org/T90801) [23:02:33] jdlrobson: Fixed ^ [23:02:47] thanks Deskana will take a look in a bit [23:03:03] (03CR) 10Krinkle: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193156 (owner: 10Jdlrobson) [23:03:48] jdlrobson: Thanks! [23:07:42] kaldari: What's an easy way of sharing a mustache template between two extensions? [23:08:45] hmm [23:09:09] create a module and require that in the other extension? [23:11:23] bmansurov: I assume you mean for client-side use? [23:11:41] if so, yes, put it in a module and make it a dependency [23:11:42] kaldari: yes [23:11:47] ok [23:12:00] thanks [23:15:21] jdlrobson: Any idea if rmoen is around today? [23:15:32] he was having connection issues haven't heard from him all day... [23:15:38] apart from on email [23:15:43] I’ll shoot him an email then, Thanks [23:19:23] (03CR) 10Kaldari: [C: 032] Allow functioning without CentralAuth in debug mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192839 (https://phabricator.wikimedia.org/T90671) (owner: 10MaxSem) [23:20:31] (03Merged) 10jenkins-bot: Allow functioning without CentralAuth in debug mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192839 (https://phabricator.wikimedia.org/T90671) (owner: 10MaxSem) [23:21:49] (03CR) 10Kaldari: [C: 032] Internationalize English texts [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192491 (owner: 10Bmansurov) [23:23:08] (03Merged) 10jenkins-bot: Internationalize English texts [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192491 (owner: 10Bmansurov) [23:26:40] coreyfloyd: can you hang on for 1 min on hangout once we wrap? [23:26:51] mhurd: yup [23:26:54] coreyfloyd: thx [23:37:53] (03PS36) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [23:37:55] (03CR) 10jenkins-bot: [V: 04-1] Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [23:40:17] coreyfloyd: bgerstle dr0ptp4kt corey’s patch on top of the bottom tracking view branch of mine looks good. any opposition to me addressing the ios6 issue adam found as a follow on patch so we can merge both of these? [23:41:02] mhurd: if you think you can have it done well ahead of wednesday, this is okay with me [23:41:14] dr0ptp4kt: yes i think i can [23:41:20] mhurd: i will need to merge yours, followed by you merging corey's. [23:41:28] mhurd: sounds ok, but not 100% sure i know what you're talking about [23:41:28] bgerstle: coreyfloyd how do you feel about this. cc mhurd [23:41:44] the question is whether you can amend his patch w/ an iOS 6 fix? [23:41:45] bgerstle: the read more thing is wonky on ios 6 [23:41:52] k [23:41:57] coreyfloyd: has an iOS 6 device, fwiw [23:42:08] doesn't make a difference to me [23:42:11] bgerstle: that is to say the container and the 'read in other languages', lead image, etc. [23:42:13] bgerstle: dr0ptp4kt not the read more the bottom tracking stuff i did [23:42:19] is wonky ios 6 [23:42:28] mhurd: url? [23:42:34] https://gerrit.wikimedia.org/r/#/c/191000/ [23:42:34] im good with how monte wants to solve it [23:42:57] are you talking about the same ios 6 bug or different ones? [23:43:03] mhurd: yeah that. i'll +2 it. last chance bgerstle mhurd coreyfloyd [23:43:35] coreyfloyd: it’s a bug on my tracking view stuff - that i mentioned during hangout [23:43:41] i think i was out of the loop on this one, you guys go ahead [23:44:05] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] "Per IRC discusson, @mhurd will be doing a follow on patch for iOS 6 support" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191000 (owner: 10Mhurd) [23:44:11] mhurd i reviewed it... 14 patches ago [23:44:17] to give you a sense for how much i remember about the code ;-) [23:44:20] mhurd: ^^^ your turn on coreyfloyd's. cc bgerstle [23:44:32] bgerstle: dr0ptp4kt also corey +1’ed 3 other patches i wrote. they are super tiny patches if you can take a quick peek [23:44:48] https://gerrit.wikimedia.org/r/#/c/192973/ [23:44:49] mhurd: sorry, i was caught up w/ other stuff today. didn't take any time for code review [23:44:54] i see we have a lot of stuff in flight, though [23:44:54] https://gerrit.wikimedia.org/r/#/c/192993/ [23:44:59] https://gerrit.wikimedia.org/r/#/c/193045/ [23:45:08] bgerstle: no worry! [23:45:23] mhurd: if you still need a +1 tomorrow morning EST i'd be happy to oblige [23:45:36] (03PS37) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [23:45:38] bgerstle: cool no worries! [23:45:50] k, i'm out for the evening [23:45:55] night everyone o/ [23:46:00] bgerstle: have a good night! [23:46:14] (03PS2) 10Dr0ptp4kt: Regression fix for TOC root level sections titles not being bold. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193045 (owner: 10Mhurd) [23:46:18] yay! [23:46:56] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Regression fix for TOC root level sections titles not being bold. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193045 (owner: 10Mhurd) [23:47:09] (03PS38) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [23:47:22] (03PS9) 10Dr0ptp4kt: Fix for "entries in TOC doubling up after pull to refresh" regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192973 (owner: 10Mhurd) [23:48:02] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Fix for "entries in TOC doubling up after pull to refresh" regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192973 (owner: 10Mhurd) [23:48:36] (03PS1) 10Bmansurov: Change header in Beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193289 [23:49:36] (03PS1) 10BearND: Hygiene: Various Lint stuff [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193290 [23:49:38] (03PS1) 10BearND: Hygiene: Replace Ellipsis strings with Ellipsis character [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193291 [23:50:13] mhurd: i'm going to manually test that last one, but gotta disconnect for 5-10 mins [23:53:36] (03CR) 10Mhurd: [C: 032 V: 032] "SHIP IT!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191527 (owner: 10Fjalapeno) [23:53:38] (03PS1) 10Bgerstle: Fix iOS 6 image gallery rotation [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193292 (https://phabricator.wikimedia.org/T90752) [23:53:40] (03CR) 10jenkins-bot: [V: 04-1] Fix iOS 6 image gallery rotation [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193292 (https://phabricator.wikimedia.org/T90752) (owner: 10Bgerstle) [23:53:51] wtf jenkins [23:53:59] bgerstle: hehe [23:54:25] jenkins, never letting language barriers get in the way of a -1 [23:54:37] mhurd: i'll just leave that there ;-) [23:54:43] lol [23:54:46] no need to review since i haven't reviewed your stuff [23:54:53] off for real this time [23:54:54] o/ [23:54:58] bgerstle: see ya! [23:55:01] 10MobileFrontend: Special:UserProfile has unclosed div which destroy the page view - https://phabricator.wikimedia.org/T90611#1072141 (10MZMcBride) If that's the spot, this unclosed div seems to have been introduced in / (03PS1) 10Bmansurov: Match the Roulette header with the new header in MF Beta [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/193294 [23:56:07] (03CR) 10jenkins-bot: [V: 04-1] Match the Roulette header with the new header in MF Beta [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/193294 (owner: 10Bmansurov) [23:57:15] (03PS4) 10Jdlrobson: Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 [23:57:17] (03PS1) 10Jdlrobson: Enable Gruntfile [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193296 [23:57:19] (03PS1) 10Jdlrobson: Do not load css via JavaScript [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193297 [23:58:20] (03CR) 10jenkins-bot: [V: 04-1] Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (owner: 10Jdlrobson)