[00:00:12] (03CR) 10Bmansurov: "recheck" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/193294 (owner: 10Bmansurov) [00:01:10] kaldari: could you review https://gerrit.wikimedia.org/r/#/c/192374/ please? thanks [00:01:21] (03PS5) 10Jdlrobson: Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 [00:01:50] (03PS5) 10Jdlrobson: Hygiene: Refactor Watchstar for Extension:Gather [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193156 [00:01:52] (03PS1) 10Jdlrobson: Hygiene: ContentOverlay shouldn't have header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193298 [00:02:04] (03PS1) 10MZMcBride: Fix unclosed div in MobileFrontend's Special:UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193299 [00:03:25] bmansurov: sure, one minute…. [00:03:41] (03PS2) 10MZMcBride: Fix unclosed div in MobileFrontend's Special:UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193299 [00:04:31] (03PS3) 10MZMcBride: Fix unclosed div in MobileFrontend's Special:UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193299 (https://phabricator.wikimedia.org/T90611) [00:07:49] (03CR) 10MZMcBride: "Okay, so if you install git-review after making a commit, it puts the Change-Id above the "Task:" line; tweaking that was PS2." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193299 (https://phabricator.wikimedia.org/T90611) (owner: 10MZMcBride) [00:13:40] (03CR) 10Jdlrobson: [C: 04-1] "Please do not use Special:MobileMenu" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193289 (owner: 10Bmansurov) [00:14:45] 6Mobile-Web: Crashing with new mobile Mozilla Firefox - https://phabricator.wikimedia.org/T89608#1072170 (10Jdlrobson) [00:16:48] (03CR) 10Bmansurov: "Yes, you're right. It depends on [1]. I forgot to add a WIP. I felt the same about the delay, but since it's in beta, we decided to go wit" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193289 (owner: 10Bmansurov) [00:20:02] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Cache regressions fixes related to pull to refresh and offline mode. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192993 (owner: 10Mhurd) [00:20:13] dr0ptp4kt: yay! thanks! [00:22:42] coreyfloyd: hey are you done for the night? [00:25:25] 10MobileFrontend, 10Flow, 10UI-Standardization, 7Accessibility, 7Design: Identify the standard diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1072182 (10Jdlrobson) [00:25:31] (03PS2) 10Bmansurov: WIP: Change header in Beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193289 [00:27:21] 10MobileFrontend, 10Flow, 10UI-Standardization, 7Accessibility, 7Design: Identify the standard diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1071492 (10Jdlrobson) I've updated the wording. This has come up numerous times and it's not clear what is the standard one. https://l... [00:27:56] 10MobileFrontend, 10Flow, 10UI-Standardization, 7Accessibility, 7Design: Identify the standard diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1072200 (10EBernhardson) The html for diffs in Flow are generated with the code as core (DifferenceEngine), the differences will be in... [00:29:18] (03PS2) 10Bmansurov: Match the Roulette header with the new header in MF Beta [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/193294 [00:30:26] (03CR) 10jenkins-bot: [V: 04-1] Match the Roulette header with the new header in MF Beta [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/193294 (owner: 10Bmansurov) [00:30:48] (03CR) 10Jdlrobson: [C: 032] Fix unclosed div in MobileFrontend's Special:UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193299 (https://phabricator.wikimedia.org/T90611) (owner: 10MZMcBride) [00:31:54] (03Merged) 10jenkins-bot: Fix unclosed div in MobileFrontend's Special:UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193299 (https://phabricator.wikimedia.org/T90611) (owner: 10MZMcBride) [00:33:09] dr0ptp4kt: is https://gerrit.wikimedia.org/r/#/c/192993/ ok to merge? [00:33:46] (03PS2) 10Dr0ptp4kt: Cache regressions fixes related to pull to refresh and offline mode. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192993 (owner: 10Mhurd) [00:34:03] mhurd: yeah, was testing. about to push the button [00:34:11] (03PS1) 10Mhurd: Fix for search results not showing. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193309 [00:34:15] (03CR) 10Dr0ptp4kt: [V: 032] Cache regressions fixes related to pull to refresh and offline mode. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/192993 (owner: 10Mhurd) [00:34:24] dr0ptp4kt: quick hotfix ^ search stopped working! [00:34:35] dr0ptp4kt: 193309 [00:34:38] mh lol [00:34:41] mh hang on [00:34:43] hehe [00:35:38] mhurd: gonna check against current master before i test that. several minutes. git pull & restart ide shuffle [00:35:47] dr0ptp4kt: k thanks! [00:37:38] (03CR) 10Jdlrobson: Remove all images and recent uploads from UserProfile (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193017 (https://phabricator.wikimedia.org/T90801) (owner: 10Deskana) [00:39:56] (03PS2) 10Mhurd: Fix for search results not showing. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193309 [00:40:02] dr0ptp4kt: ^ quick amendment [00:40:21] mhurd: thx [00:41:25] dr0ptp4kt: should i have removed the cruft files as a separate patch? [00:41:36] mhurd: it's fine [00:41:40] k [00:45:34] 10Wikipedia-App-iOS-App: Setup Xcode Server - https://phabricator.wikimedia.org/T90981#1072231 (10dr0ptp4kt) 3NEW a:3dr0ptp4kt [00:47:14] 10MobileFrontend, 10Flow, 10UI-Standardization, 7Accessibility, 7Design: Identify the standard diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1072240 (10Jdlrobson) @EBernhardson is the styling from Flow the same too these days? See also https://lists.wikimedia.org/pipermail/m... [00:48:40] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Fix for search results not showing. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193309 (owner: 10Mhurd) [00:48:49] dr0ptp4kt: thanks! [00:49:17] mhurd: no, thank you. gotta have search :) [00:49:22] hehe [00:51:24] (03CR) 10Bmansurov: "recheck" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/193294 (owner: 10Bmansurov) [00:53:51] 10Wikipedia-App-iOS-App: Don't duplicate current article in Read More - https://phabricator.wikimedia.org/T90982#1072246 (10dr0ptp4kt) 3NEW a:3Fjalapeno [01:03:57] (03PS1) 10Mhurd: Fix for status bar tap not causing scroll-to-top. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193312 [01:04:25] mhurd: wrapping up. have a good night [01:04:37] dr0ptp4kt: sounds good! you too! [01:05:17] (03CR) 10Mhurd: "Added comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193312 (owner: 10Mhurd) [01:08:06] Deskana: see you tomorrow [01:08:14] dr0ptp4kt: See you! Thanks. [01:09:28] 10MobileFrontend, 10Flow, 10UI-Standardization, 7Accessibility, 7Design: Identify the standard diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1072379 (10Quiddity) @Jdlrobson Flow uses the desktop colors: * https://www.mediawiki.org/w/index.php?title=Topic:Sck8j4swxazvcrtt&ac... [01:12:53] gather trello subscribers--sorry if you're getting spammed by phab as we migrate the backlog [01:13:05] that's all that's happening [01:20:28] (03PS2) 10Bgerstle: Fix iOS 6 image gallery rotation [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193292 (https://phabricator.wikimedia.org/T90752) [01:20:55] (03CR) 10Bgerstle: [C: 04-1] "don't merge, need to fix an issue w/ white lines during rotation (need to change a view's background color, most likely)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193292 (https://phabricator.wikimedia.org/T90752) (owner: 10Bgerstle) [01:29:55] (03PS1) 10Robmoen: Add gather db tables and schema update hook [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193315 [01:31:36] (03CR) 10Deskana: [C: 032] "SHIP IT!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193291 (owner: 10BearND) [01:32:42] (03PS2) 10Robmoen: Create db store for collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192711 [01:42:34] (03PS3) 10Robmoen: Create db store for collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192711 [02:00:20] (03PS1) 10Mhurd: Entry in TOC for "Read more". [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193321 [02:02:10] (03CR) 10Mhurd: "Quick hack to see how tough this would be. Turns out not very. Magic number "100000" probably could be handled better..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193321 (owner: 10Mhurd) [02:05:08] (03CR) 10Mhurd: "Corey, feel free to amend as needed." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193321 (owner: 10Mhurd) [02:08:25] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: Remove last edited pageimage from Special:Userprofile - https://phabricator.wikimedia.org/T90801#1072730 (10Aklapper) This task is about removing the last edited pageimage from Special:Userprofile. This task is not about Special:Userprofile in general. I ask... [02:08:29] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: Remove last edited pageimage from Special:Userprofile - https://phabricator.wikimedia.org/T90801#1072732 (10Aklapper) >>! In T90801#1068810, @MZMcBride wrote: > Why not just kill Special:UserProfile altogether? That's now covered by T90753. [02:28:09] (03PS1) 10Mhurd: Fix for iOS 6 native web tracking view. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193322 [02:30:45] (03PS2) 10Mhurd: Fix for iOS 6 native web tracking view. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193322 [02:55:39] (03PS1) 10Mhurd: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [03:39:11] (03PS1) 10Mhurd: Update article fetcher to use new "thumbwidth" param for lead image. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193324 [05:25:19] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: Remove last edited pageimage from Special:Userprofile - https://phabricator.wikimedia.org/T90801#1072860 (10Saenger) >>! In T90801#1072730, @Aklapper wrote: > This task is about removing the last edited pageimage from Special:Userprofile. This task is not abo... [06:47:38] (03CR) 10Florianschmidtwelzow: [C: 032] Hygiene: Refactor Watchstar for Extension:Gather [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193156 (owner: 10Jdlrobson) [06:52:29] (03CR) 10Florianschmidtwelzow: [C: 031] "Just one little question :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193005 (owner: 10Jdlrobson) [06:59:26] 6Mobile-Web: EditorTutorial false arrow position - https://phabricator.wikimedia.org/T91047#1072893 (10Florian) 3NEW [07:00:51] 6Mobile-Web: EditorTutorial "No thanks" doesn't work - https://phabricator.wikimedia.org/T91048#1072900 (10Florian) 3NEW [07:01:13] (03CR) 10Florianschmidtwelzow: [C: 032] Hygiene: ContentOverlay shouldn't have header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193298 (owner: 10Jdlrobson) [07:23:30] 10MobileFrontend, 10Wikimedia-Hackathon-2015: Shrinkify MobileFrontend responses - https://phabricator.wikimedia.org/T90867#1072913 (10Qgil) [07:38:54] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Mobile-Apps, 10Wikimedia-Hackathon-2015: Create Wikipedia Lite app. - https://phabricator.wikimedia.org/T90758#1072916 (10Qgil) Curious about the intersection between "low-end devices" and "iOS"... [07:40:15] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Mobile-Apps, 10Wikimedia-Hackathon-2015, 5Patch-For-Review: Add watchlist to app - https://phabricator.wikimedia.org/T76953#1072917 (10Qgil) [08:34:34] (03PS1) 10Mhurd: TOC setup on background thread to free main thread for article render. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 [08:43:26] (03PS2) 10Mhurd: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [09:08:01] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: Remove last edited pageimage from Special:Userprofile - https://phabricator.wikimedia.org/T90801#1072989 (10Aklapper) @Saenger: Please see https://www.mediawiki.org/wiki/Bug_management/Phabricator_etiquette. It has been brought up before in T90632. If you con... [09:11:30] 6Mobile-Web, 10MobileFrontend, 10MediaWiki-Special-pages, 7Technical-Debt: Special:UserProfile shouldn't live in MobileFrontend - https://phabricator.wikimedia.org/T85929#1072993 (10Bugreporter) I think we should make this page more useful if we want to put this in MediaWiki core. This may succeed the idea... [09:35:57] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: Remove last edited pageimage from Special:Userprofile - https://phabricator.wikimedia.org/T90801#1073001 (10Saenger) >>! In T90801#1072989, @Aklapper wrote: > @Saenger: Please see https://www.mediawiki.org/wiki/Bug_management/Phabricator_etiquette. It has bee... [10:06:22] morning [10:11:13] omg emailz [10:17:19] hey joakino [10:17:26] hi phuedx! [10:21:43] phuedx: what do you use for managing personal todos? (besides notebook, any apps?) [10:21:54] currently wunderlist [10:22:23] * YuviPanda|brb uses Google keep [10:22:30] And then I keep forgetting to check it [10:28:51] i'll be at the lyon hackathon [10:28:56] hackathlyon? [10:28:58] hackathlyon! [10:29:43] lol [10:45:37] I have to apply [11:32:02] (03CR) 10Zfilipin: [C: 04-1] "Voting -1 because it is not ready to be merged, and I need an indicator in my gerrit dashboard that I have reviewed this. :)" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192542 (owner: 10Jhernandez) [11:38:06] phuedx: do you know if I have to do anything special for an Api class to show up on the api sandbox? [11:40:23] joakino_: does your api work locally? [11:40:26] it's registered etc? [11:40:41] phuedx: i don't think so, how do i register it? [11:41:04] e.g. $wgAPIModules['mobileview'] = 'ApiMobileView'; [11:41:30] oo [11:41:49] phuedx: does the name have any rules? can i do gather? [11:45:59] yeah sure [11:46:11] ugh [11:46:25] failure to synchronise across cards… [11:46:46] * phuedx runs vagrant git-update [11:47:20] nooo don't do it [12:17:42] (03PS1) 10Jhernandez: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 [12:20:18] breaking for lunch [13:16:35] (03CR) 10Florianschmidtwelzow: [C: 04-1] Add api action for listing collections of a user (035 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (owner: 10Jhernandez) [13:37:14] back [13:53:10] 10MobileFrontend, 5Patch-For-Review: Special:UserProfile has unclosed div which destroy the page view - https://phabricator.wikimedia.org/T90611#1073338 (10Umherirrender) a:3MZMcBride [13:53:45] 10MobileFrontend, 5Patch-For-Review: Special:UserProfile has unclosed div which destroy the page view - https://phabricator.wikimedia.org/T90611#1073346 (10Umherirrender) 5Open>3Resolved Fix will be part of Version 1.25wmf20 - see https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap for the timeline [14:41:57] (03PS2) 10Jhernandez: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 [14:41:59] (03PS1) 10Jhernandez: Hygiene: remove unused store [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193362 [14:42:01] (03PS1) 10Jhernandez: Hygiene: Collection stores as functions & fix docs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 [14:42:03] (03PS1) 10Jhernandez: Fix bad parsing of url parameters [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193364 [14:42:05] (03PS1) 10Jhernandez: Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 [14:43:04] (03CR) 10jenkins-bot: [V: 04-1] Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (owner: 10Jhernandez) [14:43:09] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: remove unused store [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193362 (owner: 10Jhernandez) [14:43:15] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Collection stores as functions & fix docs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 (owner: 10Jhernandez) [14:43:17] (03CR) 10jenkins-bot: [V: 04-1] Fix bad parsing of url parameters [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193364 (owner: 10Jhernandez) [14:43:19] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 (owner: 10Jhernandez) [14:48:13] (03PS2) 10Jhernandez: Fix bad parsing of url parameters [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193364 [14:48:15] (03PS3) 10Jhernandez: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 [14:48:17] (03PS2) 10Jhernandez: Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 [14:48:19] (03PS2) 10Jhernandez: Hygiene: remove unused store [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193362 [14:48:21] (03PS2) 10Jhernandez: Hygiene: Collection stores as functions & fix docs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 [14:49:23] (03CR) 10jenkins-bot: [V: 04-1] Fix bad parsing of url parameters [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193364 (owner: 10Jhernandez) [14:49:25] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 (owner: 10Jhernandez) [14:53:51] (03PS1) 10Phuedx: [WIP] New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 [14:54:38] yowza [14:56:44] (03CR) 10Phuedx: "Actually, it was quite easy to base my patch on yours @Bmansurov, so I did!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193289 (owner: 10Bmansurov) [14:57:20] (03PS3) 10Jhernandez: Fix bad parsing of url parameters [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193364 [14:57:22] (03PS4) 10Jhernandez: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 [14:57:24] (03PS3) 10Jhernandez: Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 [14:57:26] (03PS3) 10Jhernandez: Hygiene: remove unused store [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193362 [14:57:28] (03PS3) 10Jhernandez: Hygiene: Collection stores as functions & fix docs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 [14:58:17] (03CR) 10Jhernandez: "Thanks for the comments florian, I've addressed them." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (owner: 10Jhernandez) [14:58:28] (03CR) 10jenkins-bot: [V: 04-1] Fix bad parsing of url parameters [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193364 (owner: 10Jhernandez) [14:58:31] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 (owner: 10Jhernandez) [15:26:22] (03CR) 10Fjalapeno: [C: 031] "Oh thanks - I totally missed the TOC part of this." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193321 (owner: 10Mhurd) [15:34:06] gonna go buy some fruit and nuts [15:34:09] back in a sec [15:34:34] i'm also running vagrant git-update on my alternative mwv box [15:34:36] so y'know [15:34:38] i've got time [16:08:53] coreyfloyd: need code review before standup? [16:11:20] bgerstle: would like to get uncrustify ready to go today [16:11:39] coreyfloyd: hear hear, what can i do to help? [16:11:40] bgerstle: but i think it needs more from monte and adam [16:12:22] (03Abandoned) 10Fjalapeno: Setup crashlytics [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187622 (owner: 10Fjalapeno) [16:12:48] bgerstle: yeah - probabaly not a lot you can do there [16:13:28] k [16:18:56] Wooot [16:19:06] Thank you bgerstle and coreyfloyd and other people [16:19:10] (03CR) 10Fjalapeno: [C: 04-1] "see comments (coupling the web VC to the implementation of the search VC)" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193312 (owner: 10Mhurd) [16:19:13] (Re: end of crashlytics) [16:20:04] YuviPanda|food: we should be thanking you! we'll probably propose another sol'n soon that should address the feedback we got [16:21:31] :) cool [16:21:50] Feel free to poke me for any server side type work [16:22:34] YuviPanda|food: we will, but we're hoping that won't be necessary at first [16:22:51] (03CR) 10Phuedx: "Can't seem to test this right now. But as Florianschidtwelzow says, the code looks good." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192374 (owner: 10Bmansurov) [16:22:55] don't want to get into details atm though [16:23:01] Fair enough. [16:24:08] (03CR) 10Fjalapeno: [C: 04-1] Move lead image inflation/face detection to background thread. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [16:26:27] coreyfloyd: hm, i'm trying to see the patch you commented on but i can't even get on gerrit right now [16:27:02] nm wifi issues [16:27:10] (03CR) 10Florianschmidtwelzow: Add api action for listing collections of a user (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (owner: 10Jhernandez) [16:30:18] (03CR) 10Fjalapeno: [C: 04-1] TOC setup on background thread to free main thread for article render. (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 (owner: 10Mhurd) [16:31:03] bgerstle: apparently the -1 button is working for me [16:31:13] yeah it was my wifi [16:31:57] (03CR) 10Fjalapeno: [C: 031] "Yea, its a +1!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193324 (owner: 10Mhurd) [16:43:28] (03PS4) 10Phuedx: Add the MobileViewBannerImageRepository [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 [16:44:59] (03CR) 10Phuedx: Add the MobileViewBannerImageRepository (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [16:45:56] (03Abandoned) 10Phuedx: Remove the PageImagesBannerImageRepository class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192805 (owner: 10Phuedx) [16:48:43] (03CR) 10Bgerstle: [C: 04-1] "see inline comments" (034 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 (owner: 10Mhurd) [16:53:38] bgerstle: meant to ask you yesterday - but based on your comment: "2. based on what I saw in the trace, we're already near maxing out CPU. therefore, IMO we should be *removing extra CPU usage* instead of moving it to another thread unless we data that suggests parallelizing is preferable over optimization" [16:54:27] bgerstle: can you confirm that you were looking at activity per cpu core? You mentioned you saw "over 100%" which leads me to believe you were examining the combined load [16:55:13] coreyfloyd: if you grab the trace you should be able to see [16:55:56] time profiler just says "CPU usage" [16:58:19] coreyfloyd: i can run the test again w/ a more CPU-usage-specific instrument e.g. activity monitor [16:58:25] that will give us a clearer picture [16:58:47] but >100% usage is probably just an artifact of the thread being blocked [17:02:12] s/thread/app/ [17:02:35] (03CR) 10Fjalapeno: "Monte - I'm working on the fix for my comment - will push soon" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193312 (owner: 10Mhurd) [17:03:18] bgerstle: you can seperate by cpu in the upper right corner [17:03:57] bgerstle: I will check out in a few and see if you can do it on the saved run [17:06:00] coreyfloyd: i looked at that [17:06:09] just tells you time [17:06:43] i was trying to say before, if the "usage" is >100%, it means the sampling period was longer than the clock cycle period [17:06:57] fwiw the core usage looks identical [17:07:34] but i agree, we probably double check our actual CPU usage using another instrument [17:07:36] i can do that in a bit [17:16:16] 10Wikipedia-App-Android-App: Crashes caused by android.content.res.Resources$NotFoundException - https://phabricator.wikimedia.org/T76952#1073765 (10Krenair) And https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8160377 - res/drawable-hdpi/title_bar_shadow.9.png again [17:21:52] Deskana: do you have a few minutes to talk about search schema? [17:22:03] Deskana: this one: https://meta.wikimedia.org/wiki/Schema:Search [17:22:32] nuria: Sure. [17:23:05] Deskana: Please take a look at my comments on https://phabricator.wikimedia.org/T89019 and see if they make some sense [17:23:23] Deskana: I might be totally off not knowing much about search [17:23:31] nuria: And so might I. :-) [17:23:53] nuria: So, I wrote the schema I wanted. When the relevant engineers start implementing it we might find some bits are feasible and might have to change. [17:24:01] (03PS3) 10Bgerstle: Fix iOS 6 image gallery rotation [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193292 (https://phabricator.wikimedia.org/T90752) [17:24:07] *some bits are *not* feasible [17:24:53] Deskana: Ok, how you have it right now I do not think is feasible with search functionality as it is today [17:25:15] Deskana: Note that your schema assumes search is a stateful app client side (like VE) [17:25:19] Deskana: but it is not [17:25:40] Deskana: it's an autocomplete plus server side page requests [17:25:45] nuria: Well, then it will change when we start implementing it. :) [17:25:58] (03PS2) 10Florianschmidtwelzow: Promote talk answer feature to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189213 [17:26:41] Deskana: Ok, as long as you are OK with it changing quite a bit is fine. If you tell me the number of search requests you get per day in teh wikis you are planning to instrument I will suggest a sampling ratio. [17:27:01] nuria: We don't know that. That's why we want the schema! [17:27:28] Deskana: to count pageviews? or to analyze funnels? those are two different things [17:27:42] (03CR) 10jenkins-bot: [V: 04-1] Promote talk answer feature to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189213 (owner: 10Florianschmidtwelzow) [17:27:53] nuria: We have no idea how many search requests we get per day, is what I mean. [17:27:53] Deskana: you can count search queries now without the schema, right? [17:28:05] nuria: Can we? I wouldn't know. [17:30:08] nuria: How would we do that? [17:30:09] Deskana: I think so, cause we have search logs, EL is not the best method to count pageviews, it will work great to analyze the funnel but note that deploying this to js-enabled desktop users you are already missing out abunch of users thus getting a non accurate number for pageviews. [17:30:41] Deskana: Did you asked about serach logs? [17:30:49] *search logs [17:30:58] (03PS2) 10Fjalapeno: Fix for status bar tap not causing scroll-to-top. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193312 (owner: 10Mhurd) [17:31:23] argh , *Search [17:31:37] nuria: I'm not sure what you mean. What are the search logs? [17:31:43] 10Wikipedia-App-iOS-App: Don't duplicate current article in Read More - https://phabricator.wikimedia.org/T90982#1073799 (10Fjalapeno) 5Open>3Resolved [17:32:56] (03PS1) 10Bgerstle: refactor subview searching categories [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193389 [17:33:00] Deskana: just like pageview requests get logged (we would never count those using EL) so do search requests [17:33:58] nuria: I'll enquire about that then. Who should I speak to? [17:34:17] Deskana: so elastic search must be logging search requests already and from there you can get pageview numbers w/o any new instrumentation. You would need to instrument to understand How people use search [17:34:18] (03PS2) 10Bgerstle: refactor subview searching categories [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193389 [17:34:51] Deskana: I am afraid I do not know, let me search in wikitech. [17:35:16] (03CR) 10Bgerstle: [C: 031] "good fix! i've submitted another patch w/ some refactors for you to review: https://gerrit.wikimedia.org/r/#/c/193389/2" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193322 (owner: 10Mhurd) [17:35:40] (03PS4) 10Bgerstle: Fix iOS 6 image gallery rotation [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193292 (https://phabricator.wikimedia.org/T90752) [17:36:15] Deskana: This is the search wiki in wikitech: https://wikitech.wikimedia.org/w/index.php?title=Search&action=history [17:36:25] (03CR) 10Bgerstle: "rebased on top of monte's iOS 6 fix patch, since this is impossible to test w/o it. there's still a white line during rotation, but i'm co" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193292 (https://phabricator.wikimedia.org/T90752) (owner: 10Bgerstle) [17:36:33] Deskana: looks like ops should know. [17:36:36] (03CR) 10Fjalapeno: [C: 031] Fix for iOS 6 native web tracking view. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193322 (owner: 10Mhurd) [17:37:05] Alright. Thanks. [17:37:38] Deskana: you should be able to get pageviews (just like we do for regular requests) from the search requests logs (just like regular pageviews are logged to hadoop and before they were logged to sampled logs and such) [17:37:40] coreyfloyd: thanks for reviewing that patch. would you mind reviewing the one i did on top of it? [17:37:43] you can see it in "related changes" [17:38:00] bgerstle: yeah heading down the review list now [17:38:03] the iOS 6 gallery rotation fix and/or the tweaks to the search subview categories [17:38:06] k [17:38:15] gonna grab a quick bite before standup [17:38:29] bgerstle: i have a new fix in for montes patch if you want to look at that when you get back [17:38:33] enjoy [17:39:27] hey joakino [17:39:32] hey FlorianSW!! :D [17:39:34] hey phuedx [17:39:36] hellos [17:39:42] hey jdlrobson [17:39:49] we need to use a highlight word ;) [17:39:53] mobileweb [17:39:55] didn't realise how much vagrant kills your battery [17:40:00] hoh yeah! [17:40:01] how the frak do i 'fuck|shit'.split('|') in php phuedx jdlrobson [17:40:04] explode is not working [17:40:19] oh nooos [17:40:19] explode( "|", "fuck|shit" ); [17:40:25] ... [17:40:39] phuedx: i execute that on php -a and it does nothing [17:40:41] damn you php [17:40:48] returns null [17:41:16] php -r "var_dump( explode( '|', 'foo|bar' ) );" [17:41:23] array(2) { [17:41:23] [0]=> [17:41:23] string(3) "foo" [17:41:23] [1]=> [17:41:23] string(3) "bar" [17:41:24] } [17:42:10] crap [17:42:19] then what does php -a do? [17:43:18] swallows the return value [17:43:31] or, better put, doesn't assign the return value to anything ;) [17:46:00] bearND: manual rebase :( https://gerrit.wikimedia.org/r/192505 [17:47:25] (03CR) 10Florianschmidtwelzow: Improvements for answer feature in TalkSectionOverlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189212 (owner: 10Florianschmidtwelzow) [17:50:33] (03PS4) 10Florianschmidtwelzow: Improvements for answer feature in TalkSectionOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189212 [17:52:09] (03PS5) 10BearND: ShareAFact: EL update [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192505 [17:52:18] dbrant: ^ manual rebase [17:55:41] (03CR) 10Dbrant: [C: 032] ShareAFact: EL update [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192505 (owner: 10BearND) [17:55:55] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189213 (owner: 10Florianschmidtwelzow) [17:56:13] jdlrobson: if you need any help with the browser tests for Gather, let us know. [17:56:31] 6Mobile-Web: Upgrade jscs version, stop using custom version - https://phabricator.wikimedia.org/T91083#1073925 (10Jdlrobson) 3NEW [17:59:49] jdlrobson, i rescheduled our meeting to monday. i need to talk to a couple people before i can be a productive member of the meeting [17:59:59] YES! [18:00:02] perfect [18:00:10] i was justwondering how i was going to attend as my battery is super low [18:00:56] kristenlans: ping pong [18:01:14] 6Mobile-Web, 7Technical-Debt: Use real (logic-less) templates to generate HTML - https://phabricator.wikimedia.org/T46130#1073952 (10Jdlrobson) 5Open>3Resolved This is done now! Thanks @Kaldari [18:02:36] (03CR) 10Fjalapeno: [C: 031] "Was about to comment on the parameter assert - but that is actually a larger discussion we should have at the next code review meeting. Li" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193389 (owner: 10Bgerstle) [18:02:58] jdlrobson: super fast question ........if you have time [18:03:06] hey nuria sure! [18:03:12] chrismcmahon: https://gerrit.wikimedia.org/r/193393 [18:03:33] jdlrobson: do desktop & mobile search client side search code? [18:04:18] on mediawiki? [18:04:20] jdlrobson: like the autocomplete that you see for example... [18:04:22] not sure i follow [18:04:23] jdlrobson: yes [18:05:06] i'm confused.. they only search pages.. [18:05:08] jdlrobson: on mediawiki, if you use the search box ... is that the same search box for mobile and desktop... [18:05:15] no it's different [18:05:27] jdlrobson: ah ok [18:05:32] the post hits the same Special:Search page though [18:05:37] if you do it without JavaScript [18:05:50] (03CR) 10Bgerstle: "agreed. just to be clear, assertions are a no-op in *all release builds*. this includes beta releases. i think the assert in this patch i" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193389 (owner: 10Bgerstle) [18:06:19] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: Make TOC only render when visible - https://phabricator.wikimedia.org/T91087#1073975 (10dr0ptp4kt) 3NEW a:3Mhurd [18:06:38] jdlrobson: Ok, does mobile use javascript for search? [18:07:00] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Convert assets JSON to NSDictionary literal - https://phabricator.wikimedia.org/T91088#1073984 (10dr0ptp4kt) 3NEW a:3BGerstle-WMF [18:07:08] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: Make TOC only render when visible - https://phabricator.wikimedia.org/T91087#1073993 (10dr0ptp4kt) [18:07:22] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance; Convert assets JSON to NSDictionary literal - https://phabricator.wikimedia.org/T91088#1073995 (10dr0ptp4kt) [18:08:08] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: LeadImage drawRect call frequency and CPU cost - https://phabricator.wikimedia.org/T91089#1073998 (10dr0ptp4kt) 3NEW [18:08:45] nuria: both desktop and mobile use javascript for search [18:08:48] with a form post fallback [18:08:52] jdlrobson: k [18:08:55] but the desktop code wasn't really reusable [18:08:57] and structured [18:09:00] coreyfloyd: hey quick hangout? [18:09:04] so we wrote it (it's pretty simple anyhow) [18:09:08] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: Make all NSDateFormatters archived and static - https://phabricator.wikimedia.org/T91090#1074007 (10dr0ptp4kt) 3NEW [18:09:27] joakino_: i'm gonna work on the add to collection workflow today [18:09:40] and then we just need to get the API stuff nailed down [18:09:46] mhurd: yeah [18:10:06] jdlrobson: i've posted a patch that lists the collections on the api, and a bunch more preparing for adding, and i have a WIP that mostly works [18:10:12] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [SPIKE ? hrs] Facial detection speed-ups - https://phabricator.wikimedia.org/T91091#1074016 (10dr0ptp4kt) 3NEW a:3Mhurd [18:11:48] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [SPIKE ? hrs] Performance: Facial detection speed-ups - https://phabricator.wikimedia.org/T91091#1074037 (10dr0ptp4kt) p:5Triage>3High [18:11:56] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: Make all NSDateFormatters archived and static - https://phabricator.wikimedia.org/T91090#1074040 (10dr0ptp4kt) p:5Triage>3High [18:12:05] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: LeadImage drawRect call frequency and CPU cost - https://phabricator.wikimedia.org/T91089#1074043 (10dr0ptp4kt) p:5Triage>3High [18:12:14] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance; Convert assets JSON to NSDictionary literal - https://phabricator.wikimedia.org/T91088#1074045 (10dr0ptp4kt) p:5Triage>3High [18:12:21] (03CR) 10Fjalapeno: [C: 04-1] "Brian - I'm still seeing the issue." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193292 (https://phabricator.wikimedia.org/T90752) (owner: 10Bgerstle) [18:12:23] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: Make TOC only render when visible - https://phabricator.wikimedia.org/T91087#1074048 (10dr0ptp4kt) p:5Triage>3High [18:12:38] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [SPIKE ? hrs] Performance: Facial detection speed-ups - https://phabricator.wikimedia.org/T91091#1074016 (10dr0ptp4kt) [18:12:59] 6Mobile-Web, 7Upstream: Crashing with new mobile Mozilla Firefox - https://phabricator.wikimedia.org/T89608#1074052 (10MaxSem) [18:13:07] coreyfloyd: IMPOSSIBLE [18:13:13] * bgerstle sigh [18:13:15] i'll check again [18:13:43] (03PS1) 10Jhernandez: WIP: Api: Adding a new collection with items. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 [18:13:58] bgerstle: yeah i'm going to delete the app and reinstall too [18:14:03] thanks [18:14:34] bgerstle: FYI - I am testing the article titled: "Operation Hardboiled" [18:14:57] (03CR) 10jenkins-bot: [V: 04-1] WIP: Api: Adding a new collection with items. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 (owner: 10Jhernandez) [18:15:44] jdlrobson: crappy internet [18:15:53] jdlrobson: here is the last patch i've been working on [18:16:12] coreyfloyd: ok [18:16:18] there are about 6/7 patches before, i'd need help reviewing fixing, i'm really tired today [18:16:28] where's a bmansurov when you need him [18:16:36] jdlrobson: https://gerrit.wikimedia.org/r/#/c/193401/ [18:16:50] (03CR) 10Jdlrobson: [C: 04-1] Promote talk answer feature to beta (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189213 (owner: 10Florianschmidtwelzow) [18:16:56] bgerstle: verified after clean install [18:17:45] (03PS6) 10Jdlrobson: Hygiene: Refactor Watchstar for Extension:Gather [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193156 [18:17:57] (03CR) 10Jdlrobson: [C: 032] "cherry picked" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193156 (owner: 10Jdlrobson) [18:18:06] (03PS2) 10Jdlrobson: Hygiene: ContentOverlay shouldn't have header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193298 [18:19:11] phuedx: in the work you are doing with the main menu with baha would be great to remove the left menu from ever page html load [18:19:13] (03Merged) 10jenkins-bot: Hygiene: Refactor Watchstar for Extension:Gather [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193156 (owner: 10Jdlrobson) [18:19:22] BEAR GRILLZ [18:19:33] jdlrobson: working on it ;) [18:19:37] joakino: go drink cerveja [18:19:49] you'll be more useful monday :) [18:19:56] jdlrobson: can't wait to get this stuff templated [18:20:03] NO MORE MINERVATEMPLATE [18:20:03] so who put the mustache on mediawiki.org? [18:20:05] (03CR) 10Deskana: "Let's use the material design ToC icon. We can't keep changing this over and over." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 (owner: 10Dbrant) [18:20:29] phuedx: blast from the past [18:20:29] https://github.com/jdlrobson/minerva [18:20:53] jdlrobson: haha, is the mustache still there? [18:21:07] https://github.com/jdlrobson/Minerva/blob/master/Minerva.php#L67 [18:21:07] aww [18:21:13] it's gone :( [18:21:16] Maryana_: oh nos! [18:21:40] She was born from the godhead of Jupiter with weapons! [18:21:55] jdlrobson: i'm out, i've written my comment down on trellow [18:22:02] gonna go drink [18:22:12] have a nice weekend everyone [18:22:23] ciao! [18:22:24] 👋😁 [18:22:46] bye joakino! [18:28:34] new sylosis album is lovely: https://en.wikipedia.org/wiki/Dormant_Heart [18:28:54] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Fix for iOS 6 native web tracking view. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193322 (owner: 10Mhurd) [18:30:52] coreyfloyd: gotta sec for a quick hangout? [18:31:06] mhurd: once you and coreyfloyd done with review on bgerstle's https://gerrit.wikimedia.org/r/#/c/193292/, don't of course wait for me...no iOS 6 device with me at the moment [18:31:18] mhurd: plus two of you is plenty [18:31:20] (03CR) 10Bgerstle: "just some questions so far, but i'm also curious about the parallelizing approach. (which is also being applied in other patches)" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [18:33:20] dr0ptp4kt: have a sec to review the other two +1’ed patches i submitted last night? [18:34:28] mhurd: urls? [18:34:43] dr0ptp4kt: https://gerrit.wikimedia.org/r/#/c/193324/ [18:34:50] dr0ptp4kt: https://gerrit.wikimedia.org/r/#/c/193321/ [18:35:50] (03PS2) 10Dr0ptp4kt: Entry in TOC for "Read more". [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193321 (owner: 10Mhurd) [18:36:33] (03PS2) 10Phuedx: Four minute abs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193083 [18:36:40] (03Abandoned) 10Bgerstle: use UICollectionViewDelegate to set itemSize dynamically [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191805 (owner: 10Bgerstle) [18:37:23] (03CR) 10jenkins-bot: [V: 04-1] Four minute abs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193083 (owner: 10Phuedx) [18:39:29] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Entry in TOC for "Read more". [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193321 (owner: 10Mhurd) [18:39:44] (03PS2) 10Dr0ptp4kt: Update article fetcher to use new "thumbwidth" param for lead image. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193324 (owner: 10Mhurd) [18:40:03] phuedx, so what account do you actually use for prod access? [18:43:41] mhurd: can you review https://gerrit.wikimedia.org/r/#/c/193292/? [18:43:51] corey and I tested on iOS 6 and it works [18:43:58] bgerstle: ya [18:44:00] so you can either look at the code or test it yourself if youw ant [18:44:19] bgerstle: testing... [18:44:22] thanks [18:44:31] (03CR) 10Fjalapeno: [C: 031] "Woot! Good to go. I was running the old code." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193292 (https://phabricator.wikimedia.org/T90752) (owner: 10Bgerstle) [18:45:09] mhurd: also, i don't know if you saw, but i added a patch on top of your iOS 6 patch which refactors some things. should be a quick review when you have a chance: https://gerrit.wikimedia.org/r/#/c/193389/ [18:45:45] bgerstle: cool thanks! maybe quick hangout after my dentist appt to chat? [18:46:27] (03CR) 10Bgerstle: [C: 031] Adds code linting via uncrustify. Install the pre-commit git hook by running ./scripts/setup_git_hooks.sh Uncrustify all files manually by r (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [18:46:59] (03PS1) 10Jdlrobson: WIP: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 [18:47:13] (03CR) 10Bgerstle: Adds code linting via uncrustify. Install the pre-commit git hook by running ./scripts/setup_git_hooks.sh Uncrustify all files manually by r (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [18:47:15] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Update article fetcher to use new "thumbwidth" param for lead image. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193324 (owner: 10Mhurd) [18:47:22] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (owner: 10Jdlrobson) [18:47:24] mhurd: sure, after the iter. review [18:47:25] dr0ptp4kt: yay thanks! [18:47:29] bgerstle: cool! [18:47:32] mhurd: sure thing [18:47:42] (03PS3) 10Jdlrobson: QA: Add browser test for acessing private collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192540 (owner: 10Jhernandez) [18:48:04] (03CR) 10jenkins-bot: [V: 04-1] QA: Add browser test for acessing private collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192540 (owner: 10Jhernandez) [18:49:03] (03PS3) 10Jdlrobson: QA:Use mobile site for the browser tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192541 (owner: 10Jhernandez) [18:49:31] (03CR) 10Jdlrobson: [C: 032] "First fails as it runs on desktop site for me but I see you are aware of this." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192540 (owner: 10Jhernandez) [18:49:51] (03CR) 10jenkins-bot: [V: 04-1] QA: Add browser test for acessing private collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192540 (owner: 10Jhernandez) [18:50:03] (03CR) 10Jdlrobson: [C: 04-1] "We should use an explicit "I am using the mobile site" step just like mobile." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192541 (owner: 10Jhernandez) [18:50:22] (03CR) 10Jdlrobson: [C: 032] Hygiene: ContentOverlay shouldn't have header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193298 (owner: 10Jdlrobson) [18:50:37] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Cut store release with only the addition of HockeyApp - https://phabricator.wikimedia.org/T91094#1074203 (10dr0ptp4kt) [18:51:49] dr0ptp4kt: ok to merge https://gerrit.wikimedia.org/r/#/c/193292 ? seems to work [18:52:19] mhurd: go for it [18:52:28] (03CR) 10Mhurd: [C: 032 V: 032] "SHIP IT!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193292 (https://phabricator.wikimedia.org/T90752) (owner: 10Bgerstle) [18:53:19] mhurd: bgerstle coreyfloyd, if you have a moment, now is a good time to update the cards at https://trello.com/b/RAyj54YQ/mobile-apps-sprint-51-ios-16th-feb-2nd-mar [18:53:51] dr0ptp4kt: i just dragged brian’s ios 6 card to “ready for signoff” [18:53:53] bgerstle: ^ [18:54:15] (03CR) 10jenkins-bot: [V: 04-1] QA:Use mobile site for the browser tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192541 (owner: 10Jhernandez) [18:56:24] (03PS1) 10Jdlrobson: QA: Apply anonymous test to mobile site only [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193409 [18:56:47] (03CR) 10jenkins-bot: [V: 04-1] QA: Apply anonymous test to mobile site only [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193409 (owner: 10Jdlrobson) [18:56:52] 10Wikipedia-App-iOS-App: Document app build and release process - https://phabricator.wikimedia.org/T91096#1074229 (10dr0ptp4kt) 3NEW [18:57:33] (03CR) 10Jdlrobson: "See https://gerrit.wikimedia.org/r/193409" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192541 (owner: 10Jhernandez) [18:58:03] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Implement Schema:MobileWikiAppSearch - https://phabricator.wikimedia.org/T90257#1074246 (10KLans_WMF) [18:58:11] FlorianSW: i'm bummed you can't make it to Lyon. I just got approved today. [18:58:33] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193409 (owner: 10Jdlrobson) [18:58:54] (03CR) 10Mhurd: [C: 031 V: 031] "Let's do it." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [18:59:35] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: ContentOverlay shouldn't have header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193298 (owner: 10Jdlrobson) [18:59:37] bgerstle: dr0ptp4kt coreyfloyd ^ should i merge uncrusify bits? [18:59:57] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Cut TestFlight release with Crash Reporting - https://phabricator.wikimedia.org/T91097#1074248 (10dr0ptp4kt) 3NEW a:3BGerstle-WMF [19:00:11] MaxSem: phuedx [19:00:14] always phuedx [19:00:15] mhurd if that is good to go we should do it near end of day after the patches are all in [19:00:20] mhurd: your call [19:00:33] coreyfloyd: dr0ptp4kt bgerstle ya end of day seems the way to go [19:00:48] phuedx, then just reply on this bug that you already have access as phuedx and all traces of ssmith should be removed [19:01:09] coreyfloyd: we can merge it now and do a separate patch that applies it, right? [19:01:23] bgerstle: good point, cc mhurd [19:01:28] coreyfloyd: oh were you going to amend https://gerrit.wikimedia.org/r/#/c/193312/ for the search result highlighting or separate patch? [19:01:39] mhurd: SHIP IT (uncrustify) [19:01:45] bgerstle: coreyfloyd lol ok [19:01:45] mhurd: its almost done now [19:01:49] about to push [19:01:54] mhurd: to the same patch [19:01:59] coreyfloyd: perfect! [19:02:13] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193083 (owner: 10Phuedx) [19:02:46] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Cut TestFlight release with Crash Reporting to friends & family & WMF - https://phabricator.wikimedia.org/T91097#1074261 (10dr0ptp4kt) [19:02:47] coreyfloyd: i’ll review right after dentist appt [19:02:58] (03PS3) 10Fjalapeno: Fix for status bar tap not causing scroll-to-top. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193312 (owner: 10Mhurd) [19:03:05] mhurd: there it is [19:03:19] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Cut TestFlight release with Crash Reporting to full TestFlight audience - https://phabricator.wikimedia.org/T91099#1074276 (10dr0ptp4kt) 3NEW [19:03:32] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Cut TestFlight release with Crash Reporting to full TestFlight audience - https://phabricator.wikimedia.org/T91099#1074284 (10dr0ptp4kt) p:5Triage>3Normal [19:03:43] coreyfloyd: bgerstle gotta run. will merge when i get back [19:05:25] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [Blocked] Cut TestFlight release with Crash Reporting to full TestFlight audience - https://phabricator.wikimedia.org/T91099#1074290 (10KLans_WMF) [19:09:03] 10Wikipedia-App-iOS-App: 4.0.6..3 - deleting a selected Saved page takes >20 sec - https://phabricator.wikimedia.org/T91100#1074300 (10Etonkovidova) 3NEW [19:09:15] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [SPIKE 2 hrs] Performance: Facial detection speed-ups - https://phabricator.wikimedia.org/T91091#1074309 (10KLans_WMF) [19:09:45] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [SPIKE 2 hrs] Performance: Facial detection speed-ups - https://phabricator.wikimedia.org/T91091#1074310 (10Deskana) [19:13:15] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: Make TOC only render when visible - https://phabricator.wikimedia.org/T91087#1074316 (10KLans_WMF) [19:14:41] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: Convert assets JSON to NSDictionary literal - https://phabricator.wikimedia.org/T91088#1074337 (10KLans_WMF) [19:16:47] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: LeadImage drawRect call frequency and CPU cost - https://phabricator.wikimedia.org/T91089#1074340 (10KLans_WMF) [19:16:53] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: LeadImage drawRect call frequency and CPU cost - https://phabricator.wikimedia.org/T91089#1074342 (10Deskana) [19:17:06] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: LeadImage drawRect call frequency and CPU cost - https://phabricator.wikimedia.org/T91089#1073998 (10Deskana) This may be rejiggulated in priority. [19:17:30] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: Make all NSDateFormatters archived and static - https://phabricator.wikimedia.org/T91090#1074350 (10KLans_WMF) [19:18:40] Maryana, Maryana_: Which one is real? [19:19:16] i think underscore is real [19:19:26] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: LeadImage drawRect call frequency and CPU cost - https://phabricator.wikimedia.org/T91089#1074369 (10KLans_WMF) [19:19:26] and no underscore is a wicked imposeter [19:19:29] *imposter [19:19:35] kaldari: ^ [19:20:19] Maryana_: but you also could be an imposter. hmmm. [19:20:32] you can try the turing test [19:20:33] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [Blocked] Cut TestFlight release with Crash Reporting to full TestFlight audience - https://phabricator.wikimedia.org/T91099#1074371 (10Deskana) [19:20:39] i can tell you how i feel about my mother [19:20:45] ;) [19:20:53] Maryana_: lol [19:22:34] Maryana_: Who’s your favorite Tourette’s cast member? (Test for imposter) [19:22:42] wonder dave!!!! [19:22:47] ok, you pass [19:22:51] :) [19:23:22] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: svg images do not display information in Image Gallery view - https://phabricator.wikimedia.org/T90298#1074373 (10Etonkovidova) More samples in Water article. The description for File:Access to drinking water in third world.svg will be correctly displayed... [19:24:18] Maryana_: I was bold and shortened the title of the presentation. ‘Here Comes Everybody’ is kind of a dated catchphrase IMO, but you can revert :) [19:24:26] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [Blocked] Cut TestFlight release with Crash Reporting to friends & family & WMF - https://phabricator.wikimedia.org/T91097#1074374 (10KLans_WMF) [19:24:40] kaldari: aww, but then it's not catchy/funny [19:24:56] hmm.. [19:24:59] (03CR) 10Jforrester: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192540 (owner: 10Jhernandez) [19:25:10] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Implement HockeyApp - https://phabricator.wikimedia.org/T90659#1074375 (10Deskana) [19:25:19] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Implement HockeyApp - https://phabricator.wikimedia.org/T90659#1074376 (10KLans_WMF) [19:26:26] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [Blocked] Cut store release with only the addition of HockeyApp - https://phabricator.wikimedia.org/T91094#1074377 (10KLans_WMF) [19:26:45] Maryana_: How about ‘Welcoming our new mobile overlords’ ;) [19:27:40] heh. how about "beyond editing: sharing in the sum of ALL human knowledge on mobile"? [19:28:45] I, for one, welcome our new mobile overlords! [19:28:59] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [Blocked] Cut store release with only the addition of HockeyApp - https://phabricator.wikimedia.org/T91094#1074378 (10KLans_WMF) [19:29:14] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Mobile-Apps, 10Wikimedia-Hackathon-2015: Create Wikipedia Lite app. - https://phabricator.wikimedia.org/T90758#1074382 (10cscott) Using Parsoid-format output (see https://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec and http://nell-wikipedia.githu... [19:36:46] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: EPIC: Hone in on, and eradicate, article load time performance issues - https://phabricator.wikimedia.org/T90255#1074427 (10KLans_WMF) [19:37:56] 10Wikipedia-App-iOS-App: 4.0.6.3 Image Gallery- switching from a vertical view to horizontal loads a different picture - https://phabricator.wikimedia.org/T91106#1074430 (10Etonkovidova) 3NEW [19:38:06] (03PS7) 10Jdlrobson: Hygiene: Correctly enable watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193005 [19:38:19] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: [Spike ?hr] Investigate onboarding libraries to find one that's suitable for our purposes - https://phabricator.wikimedia.org/T89987#1074437 (10KLans_WMF) [19:38:24] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: As an engaged reader, I'd like to know that I can share cards with interesting facts on. - https://phabricator.wikimedia.org/T89988#1074438 (10KLans_WMF) [19:38:47] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: As a product owner, I'd like to know how well the Tweet A Fact onboarding did at exposing users to the feature - https://phabricator.wikimedia.org/T89989#1074439 (10KLans_WMF) [19:38:49] 10Wikipedia-App-iOS-App: 4.0.6.3 Image Gallery- switching from a vertical view to horizontal loads a different picture - https://phabricator.wikimedia.org/T91106#1074440 (10Etonkovidova) [19:39:22] bmansurov: yt? [19:39:28] yes [19:39:40] ah, cool [19:40:42] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: [Blocked] Improve app icon to make it more material designesque - https://phabricator.wikimedia.org/T90809#1074460 (10KLans_WMF) a:3Vibhabamba [19:41:23] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Epic: Onboarding, both generally and for Tweet A Fact - https://phabricator.wikimedia.org/T89985#1074466 (10KLans_WMF) [19:41:37] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: [Spike 3 hrs] Investigate onboarding libraries to find one that's suitable for our purposes - https://phabricator.wikimedia.org/T89987#1074468 (10KLans_WMF) [19:41:44] i found the special:mobilemenu stuff a little fiddly [19:41:55] (03PS1) 10Bgerstle: image gallery design updates [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193419 [19:42:03] also, i'm still fiddling with the search overlay stuff [19:42:07] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Epic: Onboarding, both generally and for Tweet A Fact - https://phabricator.wikimedia.org/T89985#1050863 (10KLans_WMF) [19:42:28] on the other hand, because of the way the mobile menu is delivered, we might not have to make a full request to show the user the menu [19:42:41] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Epic: Onboarding, both generally and for Tweet A Fact - https://phabricator.wikimedia.org/T89985#1050863 (10KLans_WMF) [19:42:42] phuedx: ok, let me know when you're done, i'll need to change some stuff on my end too [19:43:25] bmansurov: if nothing else, i'd like to use this as an example for tidying up "templating" [19:43:28] i.e. use templates [19:43:40] sounds good [19:44:18] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: As a product owner, I'd like to know how well the Tweet A Fact onboarding did at exposing users to the feature - https://phabricator.wikimedia.org/T89989#1074479 (10KLans_WMF) [19:46:11] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Scrum-of-Scrums, 3Mobile App Sprint 52 - Android: [Spike 1 hr] Investigate building a Node.js service for mobile apps content - https://phabricator.wikimedia.org/T90228#1074480 (10KLans_WMF) [19:46:42] Maryana_: I like ‘Beyond editing’ [19:46:59] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Cache visited pages in filesystem instead of ram. - https://phabricator.wikimedia.org/T89826#1074481 (10KLans_WMF) [19:48:10] ok [19:48:13] submitting [19:48:37] alright folks [19:48:45] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: (2) EventLogging modifications to support A/B testing for "read more" vs "read next" - https://phabricator.wikimedia.org/T91110#1074482 (10Deskana) 3NEW [19:48:50] i'm going to wind down with a darling little 4 month old boy [19:48:58] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: (2) EventLogging modifications to support A/B testing for "read more" vs "read next" - https://phabricator.wikimedia.org/T91110#1074489 (10Deskana) This was previously tracked here: https://trello.com/c/vQCxiXe0/34-eventlogging-modifications-to-supp... [19:49:02] who'll no doubt vomit all over me [19:49:06] but that's ok [19:49:34] (03CR) 10Jdlrobson: [C: 031] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193298 (owner: 10Jdlrobson) [19:49:38] if i eat enough cake, then i might just get him back tonight [19:49:42] (03CR) 10Jdlrobson: [C: 032] Hygiene: ContentOverlay shouldn't have header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193298 (owner: 10Jdlrobson) [19:49:43] <3 [19:49:49] have a lovely weekend y'all [19:49:52] coreyfloyd: you should really look into changing your gerrit username :-P [19:49:52] 10Wikipedia-App-iOS-App: Update heuristic for Share a Fact - https://phabricator.wikimedia.org/T91111#1074493 (10dr0ptp4kt) 3NEW a:3dr0ptp4kt [19:49:54] 10Wikipedia-App-iOS-App: 4.0.6.3 Cladogram template - connecting lines displayed white: hard to see - https://phabricator.wikimedia.org/T91112#1074502 (10Etonkovidova) 3NEW [19:50:01] phuedx: cya! [19:50:18] kaldari: vagrant git-update fixed the issue i was seeing bee-tee-dubs [19:50:34] AWAY! [19:50:36] bgerstle: is that giving you some trouble? [19:50:50] a couple times i go to type "coreyfloyd" [19:50:53] (03Merged) 10jenkins-bot: Hygiene: ContentOverlay shouldn't have header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193298 (owner: 10Jdlrobson) [19:50:57] then realize "oh yeah, he's fjalapeno here [19:51:01] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: (3) As an engaged reader, I'd like a single more visually appealing "read more" result to be shown to me. (Experiment) - https://phabricator.wikimedia.org/T91113#1074517 (10Deskana) p:5Triage>3Normal [19:51:34] (03PS8) 10Jdlrobson: Hygiene: Correctly enable watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193005 [19:52:44] (03PS2) 10Bgerstle: image gallery design updates [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193419 [19:53:29] kaldari: leila - submitted! https://wikimania2015.wikimedia.org/wiki/Submissions/Beyond_editing:_Sharing_in_the_sum_of_ALL_human_knowledge_on_mobile [19:53:38] leila i don't know your username - add it plz :) [19:53:42] (03Draft2) 10Bgerstle: fix issue causing large images to not be rerouted to WMF cache [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191894 [19:54:02] (03PS3) 10Bgerstle: fix issue causing large images to not be rerouted to WMF cache [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191894 (https://phabricator.wikimedia.org/T89921) [19:54:06] sure Maryana. thanks! [20:04:04] 10Wikipedia-App-iOS-App: Add slow connection handling to image gallery - https://phabricator.wikimedia.org/T91115#1074534 (10BGerstle-WMF) [20:04:05] 10Wikipedia-App-iOS-App: 4.0.6.3 Image is not presented in the Image Gallery - https://phabricator.wikimedia.org/T91116#1074545 (10Etonkovidova) 3NEW [20:05:02] Deskana: kristenlans one more thing: our sprint-specific phab projects aren't being routed to this channel [20:05:09] also, kristenlans what's your phab username? [20:07:07] 10Wikipedia-App-iOS-App: Add slow connection handling to image gallery - https://phabricator.wikimedia.org/T91115#1074564 (10BGerstle-WMF) This task was spawned from a discussion in [[https://trello.com/c/XSW8DHdw | this trello card]]. @Deskana Kristen & vibha, can you verify the requirements, priority, and spr... [20:09:17] bgerstle: I am KLans (WMF) [20:09:27] kristenlans: so i see.. [20:10:35] bgerstle I am "Also Known As" Kristen Lans [20:10:39] whatever that means [20:12:04] Deskana kristenlans: also i was thinkin' (dangerous, i know): what if we converted the "milestone/marker" tasks into projects? [20:12:08] we could set due dates as well [20:12:15] The scrummaster formerly known as Kristen Lans [20:12:27] (see Edit Details ) on proj menu [20:12:37] or wait i might be wrong [20:12:46] so there's just a sprint end date field [20:12:49] and the ICON can be a "deadline" [20:13:08] so projects are not really "projects" in phab, i'm slowly coming to understand [20:13:26] they're essentially labels [20:13:42] anyway, just a thought, i'll leave it w/ you [20:15:31] 10Wikipedia-App-iOS-App: Implement Schema:MobileWikiAppSearch - https://phabricator.wikimedia.org/T90257#1074572 (10KLans_WMF) [20:15:35] 10Wikipedia-App-iOS-App: 4.0.6.3 Expanding Quick facts box and flipping to horizontal position - the empty space for leading image is preserved. - https://phabricator.wikimedia.org/T91118#1074573 (10Etonkovidova) 3NEW [20:15:45] bgerstle: Can you send me an email with what you just said here? I'm kind of messed up atm and can't focus. [20:15:47] 10Wikipedia-App-iOS-App: Some articles about cities are broken in iOS app beta 4.0.6.3 - https://phabricator.wikimedia.org/T90032#1074581 (10KLans_WMF) [20:15:49] (03CR) 10Bgerstle: "i'll review as-is, but just pointing out there are 3 "fixes" in this patch (according to the message). i'm as guilty of this as anyone, bu" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193312 (owner: 10Mhurd) [20:15:59] (03CR) 10Fjalapeno: "Quick questions" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191894 (https://phabricator.wikimedia.org/T89921) (owner: 10Bgerstle) [20:16:11] Deskana: you mean you can't follow a train of thought across 10 message in IRC which are sporadically separated by other messages? [20:16:11] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Some articles about cities are broken in iOS app beta 4.0.6.3 - https://phabricator.wikimedia.org/T90032#1051850 (10KLans_WMF) [20:16:24] when the thought itself isn't even fully formed? [20:16:26] ;-) [20:16:35] sure, i'll send an email [20:16:53] bgerstle: Well, you can take the time to form it too, if you like. [20:17:04] 10Wikipedia-App-iOS-App: As a reader, I'd like to not be shown the IPA in an article so that it doesn't take up space. - https://phabricator.wikimedia.org/T90251#1074584 (10KLans_WMF) [20:17:07] bgerstle: I just know I'll forget about it unless I get an email. I doubt I'll even remember I had this conversation. [20:17:08] we likes ideas raw.. and wwwwwriggling [20:17:12] 10Wikipedia-App-iOS-App: As a reader, I'd like suggestions for what I can read next to be presented to me. [Main page read more] - https://phabricator.wikimedia.org/T90256#1074585 (10KLans_WMF) [20:17:18] I'm really dazed atm [20:17:50] are you confused as well? has it been going on for so long that it's not true? [20:18:00] 10Wikipedia-App-iOS-App: As a new user, I'd like article issues and disambiguation wrapped up into a button so that I can see what problems an article might have. - https://phabricator.wikimedia.org/T90250#1074589 (10KLans_WMF) [20:18:04] 10Wikipedia-App-iOS-App: Update text heuristic for Share a Fact image when no text selected - https://phabricator.wikimedia.org/T91119#1074590 (10dr0ptp4kt) 3NEW [20:18:11] (led zeppelin.. ref) [20:19:38] 10Wikipedia-App-iOS-App: [Blocked on design] Improve loading indicator to make it less feel less heavy to the user - https://phabricator.wikimedia.org/T90812#1074609 (10KLans_WMF) [20:20:58] (03PS2) 10Jdlrobson: WIP: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 [20:21:00] (03PS2) 10Jdlrobson: QA: Apply anonymous test to mobile site only [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193409 [20:21:03] (03PS6) 10Jdlrobson: Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 [20:24:21] bgerstle: I knew that sounded familiar... [20:24:29] hahaha thank you [20:27:25] rmoen: can you help with some code review today? [20:27:40] jdlrobso_: aye [20:27:46] gather has a bit of a backlog :) [20:27:48] (03PS13) 10Dbrant: Video playback in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) [20:29:19] coreyfloyd: bgerstle dr0ptp4kt i’m back [20:29:23] k [20:29:38] mhurd: coreyfloyd bgerstle i'm heading out. happy h4x0ring [20:29:45] dr0ptp4kt: see ya! [20:29:49] see ya dr0ptp4kt [20:30:03] have fun storming the castle—i mean facebooK! [20:30:05] damn, he left [20:30:09] hehe [20:30:29] mhurd up for a quick review to get warmed up? :-) [20:30:36] bgerstle: yaQ [20:30:38] https://gerrit.wikimedia.org/r/#/c/193389/ [20:30:43] hehe ya! [20:30:59] coreyfloyd: already +1'd so, barring any issues, you can +2 it [20:31:34] (03PS3) 10Bgerstle: refactor subview searching categories [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193389 [20:31:39] just modified commit msg ^ [20:33:43] mhurd also can you merge https://gerrit.wikimedia.org/r/#/c/191894/ ? seems you and i both +1'd it. unless you want adam to weigh in, but he's gone for the day [20:33:53] bgerstle: will do [20:33:54] coreyfloyd: did you see my comment on ^ about 1-line if statements? [20:35:10] (03CR) 10Fjalapeno: [C: 04-1] "One real question, one code organization comment, one naming comment" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193419 (owner: 10Bgerstle) [20:35:18] (03CR) 10Mhurd: "Added comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193389 (owner: 10Bgerstle) [20:36:14] bgerstle: ^ [20:36:21] bgerstle: where? [20:40:43] bgerstle: oh - see it [20:43:32] (03CR) 10Bgerstle: [C: 04-1] "replying to coreyfloyd" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193419 (owner: 10Bgerstle) [20:45:55] (03CR) 10Mhurd: "Can you edit the commit message so it's not all on one line?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [20:46:52] coreyfloyd: something funky about the commit msg… ^ [20:47:31] mhurd: i saw that too. coreyfloyd there needs to be another line between the commit subject (first line) and body (rest of msg) [20:51:11] (03PS3) 10Jdlrobson: WIP: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 [20:51:13] (03PS7) 10Jdlrobson: Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 [20:51:30] (03CR) 10Mhurd: "Readme partial sentence?" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [20:52:12] (03CR) 10Fjalapeno: "reply" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193419 (owner: 10Bgerstle) [20:55:43] i'm having eye issues again so i need to go for a walk :( [20:56:38] (03CR) 10Fjalapeno: "@bgerstle - sorry, thought I sent you something about the change i made on the last patch, but it looks like I forgot:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [20:58:54] (03PS12) 10Fjalapeno: Adds code linting via uncrustify. Install the pre-commit git hook by running ./scripts/setup_git_hooks.sh Uncrustify all files manually by running ./scripts/uncrustify_all.h Update README for dependencies, install instructions, etc… [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 [20:59:13] coreyfloyd: ^ ok [20:59:48] mhurd: bgerstle I'm not sure about the commit message thing. Are you saying the whole commit message is on a single line? [21:00:30] coreyfloyd: kinda looks that way... [21:00:41] mhurd: can you screen shot me? [21:00:45] coreyfloyd: ya [21:00:48] coreyfloyd: in gerrit [21:00:50] you can see [21:01:03] speak like yoda, i do apparently [21:01:04] this is what i see: https://www.dropbox.com/s/9ant5n27zxhbrkf/Screenshot%202015-02-27%2016.00.49.png?dl=0 [21:01:27] coreyfloyd: in the "my changes" section [21:01:41] coreyfloyd: emailed one to you [21:02:07] coreyfloyd: try from command line [21:02:09] coreyfloyd: here [21:02:22] damnit.. [21:02:25] k looking… [21:02:32] https://www.dropbox.com/s/xdws5mf9wrj088s/truncated%20commit%20body.png?dl=0 [21:02:54] ahh - gotcha… hmm, weird [21:03:06] coreyfloyd: cr / lf issue? [21:03:12] (03PS13) 10Fjalapeno: Adds code linting via uncrustify. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 [21:03:18] (03CR) 10BearND: [C: 04-1] "When I can't play the video could you make it so that the video poster shows again. With this PS I only see black rectangle where the vide" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) (owner: 10Dbrant) [21:07:30] coreyfloyd: hmm i thought i had uncrustify all setup - it’s showing in my Xcode edit menu properly now, but when i try to commit a change i get this msg, even though the script is present “.git/hooks/pre-commit: line 6: ./scripts/uncrustify/uncrustify_all.sh: No such file or directory” [21:08:08] hmm… weird… i had fixed that previously [21:08:17] maybe i never commited it [21:08:21] mhurd: ^ [21:08:23] let me look [21:08:36] coreyfloyd: cool thanks! [21:09:41] coreyfloyd: oh i also ran setup_git_hooks.sh [21:12:21] 10Wikipedia-App-iOS-App: 4.0.6.3 Image Gallery - some images displayed in low resolution - https://phabricator.wikimedia.org/T91124#1074704 (10Etonkovidova) 3NEW [21:17:07] (03PS14) 10Dbrant: Video playback in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) [21:17:32] bearND: i can't reproduce the behavior you're seeing on my devices, but can you try this ^ [21:17:41] coreyfloyd: here's the reason why i need to use that UIButton "sizeToFitLabelContents" method: [21:17:53] the two approaches are: [21:18:17] https://www.irccloud.com/pastebin/GtYfBwxq/UIButton+sizetoFit+vs.+sizeToFitLabelContents [21:18:27] and the image diff looks like this: [21:18:28] https://www.dropbox.com/s/pj1m223yq47g8ku/sizeToFit%20-%20sizeToFitLabelContents%20diff.png?dl=0 [21:18:45] where the one closer to the top left (desired position) is the category method [21:19:52] bgerstle: why not use WikiGlyphButton, getting all that for free? [21:20:14] i need the hit area padding as well [21:20:22] bgerstle: it does that [21:20:56] mhurd: can you interact w/ WikiGlyphButton? [21:21:03] i don't see a touch callback API [21:21:06] bgerstle: it’s WikiGlyphLabel is a padded label [21:21:45] bgerstle: i used tap gesture recognizer - uibutton was huge pain for 6,7&8 [21:21:57] mhurd: i guess the short answer is: I know how to use UIButton to get what i want, and it works, and it took < 40 LOC [21:22:19] mhurd: seems to work fine in the image gallery [21:23:50] bgerstle: fair enough. just a bit strange that you didn’t notice all of the other buttons in the app and what they use ;) [21:24:40] mhurd: perhaps, but i consider what i ended up doing what any dev would do who came to the project [21:25:56] we can look at UI stuff another time. for now, i don't see what changing my approach to WikiGlyphButton will add [21:26:00] bgerstle: no worries at all. just keep in mind now we have 2 button classes. [21:28:48] coreyfloyd: i have other screens where i colored in the frames so you can see the extra padding UIButton puts on UILabel—even though titleEdgeInsets is 0 [21:30:04] normally it wouldn't be a problem as buttons are positioned by their regular frames, but since i'm positioning this button based on where the text starts, i need to be sure of where the frame is. [21:30:36] (03PS3) 10Bgerstle: image gallery design updates [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193419 [21:30:50] coreyfloyd: addressed your feedback here ^ [21:33:06] (03PS14) 10Fjalapeno: Adds code linting via uncrustify. Install the pre-commit git hook by running ./scripts/setup_git_hooks.sh Uncrustify all files manually by running ./scripts/uncrustify_all.h Update README for dependencies, install instructions, etc… [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 [21:33:24] mhurd: ^ let me know - and make sure to reinstall the hook [21:33:30] (03PS15) 10Bgerstle: Adds code linting via uncrustify. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [21:33:40] coreyfloyd: ^ added the extra line to commit msg [21:33:54] see how the title doesn't contain the 2nd+ lines [21:34:25] bgerstle: yeah forgot on the updated patch [21:34:31] np [21:34:37] figured i might as well [21:35:06] coreyfloyd sorry for bombarding this channel w/our code review, but did you get my points about your button comment? [21:35:10] bgerstle: catching up on your stuff above [21:35:12] ok [21:35:13] hehe [21:35:23] happy to demo on hangout if that's easier [21:38:47] 10Wikipedia-App-iOS-App: 4.0.6.3 Image gallery - not all image info is displayed - https://phabricator.wikimedia.org/T91125#1074734 (10Etonkovidova) 3NEW [21:39:59] eh... [21:40:00] Show hatnotes on tablet devices and not on mobile devices, i.e. reverse the current media query [21:40:03] wut ?? [21:40:15] why are we hiding them at all ? [21:40:26] see also: https://en.wikipedia.org/wiki/Template_talk:Main#Appearance_.28or_lack_thereof.29_on_mobile_browsers [21:40:48] 10Wikipedia-App-iOS-App: 4.0.6.3 Image gallery - not all image info is displayed - https://phabricator.wikimedia.org/T91125#1074741 (10Etonkovidova) File:Europe blank laea location map.svg file will display the red mark for Budapest:
(03CR) 10Fjalapeno: "FYI - I fixed up a few problems i saw in the styling and added a missing config parameter whilst I was fixing for Monte" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [21:51:29] bgerstle: yeah - saw your points - seems like a lot of wonkyness to deal with - got the gist [21:57:15] oh, i think jon was trying to get rid of the disambig hatnotes... [21:57:26] dbrant: still seeing the black background. Sent you a video [21:57:42] that's with PS 14 [21:57:46] forgetting that it's a style class, not limited to dab hatnotes. [21:58:03] bearND: that's really weird :( [21:58:30] hmm, even then i wouldn't hide them. [21:59:26] (03CR) 10Robmoen: [C: 032] Hygiene: Correctly enable watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193005 (owner: 10Jdlrobson) [22:01:11] (03Merged) 10jenkins-bot: Hygiene: Correctly enable watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193005 (owner: 10Jdlrobson) [22:04:09] 6Mobile-Web, 10MobileFrontend - Feature Requests, 7Easy: Get rid of Special:Userprofile - https://phabricator.wikimedia.org/T90753#1074783 (10GOIII) Where can I vote to either kill this dumb-ass idea or -- at the very least -- vote for the ability to opt out of it? [22:04:27] bearND: based on the logcat trace you sent earlier, your mediaserver actually crashes with SIGABRT, so I suppose the subsequent behavior would be pretty unpredictable... [22:05:44] dbrant: When you bring up the crouton toast "video could not be played" then you could show the image though [22:06:04] bearND: I do! it's working on my devices :( [22:07:33] bearND: by which I mean: I have one device on which video playback doesn't work, and it's showing the thumbnail correctly when it fails. [22:08:11] coreyfloyd: have a sec to help with uncrustify? [22:08:11] coreyfloyd: hey, so i thought about adding some more examples to WMFCodingStyle.m so we could verify a couple other examples [22:08:39] i.e. mulit-line arrays & dictionaries, and block alignment stuff [22:08:47] the multi-line arrays and dictionaries are a bit funky [22:09:33] bgerstle: did you want to rename UIView+SearchSubviews as part of https://gerrit.wikimedia.org/r/#/c/193389/ ? ( to UIView_WMFSearchSubviews ) [22:09:50] sorry “UIView+WMFSearchSubviews” [22:10:05] mhurd: TBH if don't know if we need to name the _files_ w/ that prefix. i'm inconsistent about it myself [22:10:13] sorry, category name, not file name [22:10:21] i'm not sure how that effects the objc runtime or name mangling [22:10:29] probably better to be safe and do it anyway [22:10:31] so yeah, i should [22:11:48] dbrant: I've got it to work now. Had to add a call to loadMedia(); in the error callback [22:12:06] mhurd: yeah [22:12:20] coreyfloyd: mind if i amend your patch w/ the extra examples? [22:12:32] bgerstle: yeah go ahead [22:13:38] (03PS16) 10Bgerstle: Adds code linting via uncrustify. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [22:13:44] 10Wikipedia-App-iOS-App: 4.0.6.3 Image gallery - images(svg) blurred on the black background - https://phabricator.wikimedia.org/T91128#1074812 (10Etonkovidova) 3NEW [22:14:18] (03CR) 10Bgerstle: [C: 04-1] Adds code linting via uncrustify. (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [22:15:05] bearND: hmm, very interesting... in that case, can you just try explicitly setting videoThumbnail.setVisibility(View.VISIBLE); (instead of loadMedia) [22:15:43] (03PS4) 10Bgerstle: image gallery design updates [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193419 [22:17:32] dbrant: just tried it. Then it doesn't show the nice play button on top of it. [22:17:45] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: [Blocked] Improve app icon to make it more material designesque - https://phabricator.wikimedia.org/T90809#1074821 (10Vibhabamba) {F49150} {F49151} {F49152} [22:17:56] bearND: sorry, also set videoPlayButton.setVisibility(View.VISIBLE); [22:18:08] dbrant: yep, just found it [22:18:12] bearND: I think I understand the hoops through which your device is jumping [22:18:29] (03PS4) 10Bgerstle: refactor subview searching categories [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193389 [22:18:34] mhurd: renamed category ^ [22:19:44] dbrant: that works for me [22:19:59] got the play button back [22:20:39] bearND: I'll update the patch [22:21:11] (03PS1) 10Bmansurov: Fix "No thanks" in EditorTutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193501 (https://phabricator.wikimedia.org/T91048) [22:25:19] (03PS15) 10Dbrant: Video playback in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) [22:29:44] (03PS4) 10Mhurd: Fix for status bar tap not causing scroll-to-top. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193312 [22:30:07] coreyfloyd: only way i can get the dictionary to stick w/ uncrustify is to change nl_after_brace_open [22:30:19] which means 1-line ifs are back [22:30:40] which is fine, we can prefer if { \n, but at least one-liners will always have wrapping { } [22:31:16] or wait sorry [22:31:22] the ifs are still mulit-line [22:31:54] the array is still off, though [22:32:40] bgerstle: sorry was on with monte - i have to do an array fix for him, which may be related - I'll check out the dictionary stuff [22:32:51] i've got a fix for teh dictionary stuff [22:33:03] bgerstle: monte is going to merge in end of day as long as that works for you [22:33:05] which doesn't effect our "if" rules, supposedly [22:33:08] +1 [22:33:10] lol [22:33:35] bgerstle: did you already send the patch with the fix [22:33:40] bgerstle: quick double-check before merging that you didn’t want to rename UIView+SearchSubviews.h and UIView+SearchSubviews.m to UIView+WMFSearchSubviews.h and UIView+WMFSearchSubviews.m [22:34:05] mhurd: i did rename it [22:34:12] i think i pushed it [22:34:24] bgerstle: the file names look the same... [22:34:28] hm, maybe i forgot to push [22:34:29] 1sec [22:35:26] coreyfloyd: pushing dictionary fix now.. [22:35:31] (03PS17) 10Bgerstle: Adds code linting via uncrustify. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [22:35:41] might want to stash save->pop [22:35:48] (thanks gerrit! collaboration's awesome!!!!!) [22:36:01] lol [22:36:38] coreyfloyd: thanks for helping me wrangle the uncrustify stuff! [22:36:45] ah mhurd the category name is different [22:36:47] filename is not [22:36:48] renaming... [22:36:59] THANKS XCODE UR REFACTOR FEATURES ARE AWESOME [22:37:11] THANKS OBAMA! [22:37:16] rofl [22:37:25] thanks FCC! (no seriously, thanks) [22:37:38] bgerstle: my thoughts exactly :) [22:38:41] (03CR) 10BearND: "See some follow-up opportunity in the inline comment." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) (owner: 10Dbrant) [22:38:46] (03PS5) 10Bgerstle: refactor subview searching categories [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193389 [22:38:49] mhurd: ^ [22:38:59] (03CR) 10BearND: [C: 032] Video playback in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) (owner: 10Dbrant) [22:39:03] novocain finally starting to subside… [22:39:16] bgerstle: on it [22:39:18] (03Merged) 10jenkins-bot: Video playback in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) (owner: 10Dbrant) [22:39:38] sweet sassy molassy. [22:39:40] mhurd... you should be getting some advil, not reviewing my code if your novacaine's wearing off! [22:40:18] hehe [22:41:35] (03PS2) 10BearND: Hygiene: Various Lint stuff [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193290 [22:41:45] (03PS2) 10BearND: Hygiene: Replace Ellipsis strings with Ellipsis character [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193291 [22:41:52] (03PS6) 10Mhurd: refactor subview searching categories [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193389 (owner: 10Bgerstle) [22:41:59] bgerstle: merging... [22:42:01] dbrant: mind looking at the patches ^^? [22:42:12] bearND: yep! [22:42:21] (03CR) 10Mhurd: [C: 032 V: 032] "Corey had +1'ed so merge time." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193389 (owner: 10Bgerstle) [22:43:46] (03PS5) 10Mhurd: Fix for status bar tap not causing scroll-to-top. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193312 [22:45:45] (03CR) 10Mhurd: "One quick comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193312 (owner: 10Mhurd) [22:47:22] forgot that was my branch ^ :) [22:48:50] (03CR) 10Dbrant: [C: 032] Hygiene: Various Lint stuff [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193290 (owner: 10BearND) [22:49:32] dbrant: btw, the animated GIF portion (https://phabricator.wikimedia.org/T85766) is not fixed by the video playback fix [22:49:34] (03Merged) 10jenkins-bot: Hygiene: Replace Ellipsis strings with Ellipsis character [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193291 (owner: 10BearND) [22:49:46] bgerstle: is the coding style file formatted the way we want, or does it contain an error? [22:50:03] as far as the array [22:50:38] dbrant: also in the spirit of getting ready for another release: would you like to strip out the toolbar icon change from https://gerrit.wikimedia.org/r/#/c/192916/? [22:51:01] coreyfloyd: hey your amendment to https://gerrit.wikimedia.org/r/#/c/193312 made some changes to “Wikipedia.xcodeproj/project.pbxproj” that i’m not sure were intentional… could you check? [22:51:14] mhurd: it was [22:51:19] i made a note in the commit message [22:51:46] coreyfloyd: ah the CODE_SIGN_IDENTITY stuff was? [22:51:56] yeah [22:51:57] mhurd: coreyfloyd i don't even know what to make of that patch anymore [22:51:59] coreyfloyd: oh cool sorry didn’t see it [22:52:02] bearND: sure! but that's not totally ready for merging yet, anyway [22:52:17] it got a bit non atomic ;) [22:52:21] coreyfloyd: the array's not ideal, but it's OK [22:52:43] bgerstle: xcode formats it like this: [22:52:52] bearND: as for animated gifs; yes, it will have to be its own story card, since it won't be trivial. That phab task can remain open for now. [22:52:55] https://www.irccloud.com/pastebin/yE39GktV [22:53:07] (03PS5) 10Jdlrobson: Remove all images and recent uploads from UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193017 (https://phabricator.wikimedia.org/T90801) (owner: 10Deskana) [22:53:27] coreyfloyd: but how does uncrustify format it? [22:53:28] bgerstle: or this: [22:53:34] (03CR) 10Jdlrobson: [C: 04-1] "I removed some css and the thanks image but see earlier comment - we need to link to the last upload to." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193017 (https://phabricator.wikimedia.org/T90801) (owner: 10Deskana) [22:53:38] https://www.irccloud.com/pastebin/JkC1g5ju [22:53:47] that's what i'd prefer ^^^ [22:54:06] but uncrustify indents 1-3 one space to the left *shrug* [22:54:33] bgerstle: ok - I dont know if we have control of whether the first element is on the same line as the bracket - but will work on the spacing [22:55:20] coreyfloyd: it *should* behave the same way as multi-line function call or C/C++ array [22:55:43] (03PS5) 10Jdlrobson: Improvements for answer feature in TalkSectionOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189212 (owner: 10Florianschmidtwelzow) [22:56:02] mhurd: coreyfloyd i'm just going to flag this moment of the 3 of us working collaboratively on about 5 patches [22:56:10] lol [22:56:11] and how much easier it would be if we were using github [22:56:30] (03CR) 10Jdlrobson: [C: 032] "Something's not quite right with this - when I click the save new topic button I see a flash of the overlay and the button is enabled agai" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189212 (owner: 10Florianschmidtwelzow) [22:56:54] specifically: pushing commits to each other's branches instead of amending the same commit [22:57:12] something we can maybe talk about soon ;-)) [22:57:16] bgerstle: lol [22:57:20] bgerstle: getting close… indent_square_nl [22:57:24] don't need to start using github, but at least pushing gerrit farther back in the process [22:57:30] coreyfloyd: niiice [22:57:40] https://www.irccloud.com/pastebin/XiVGRAd5 [22:57:41] (03Merged) 10jenkins-bot: Improvements for answer feature in TalkSectionOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189212 (owner: 10Florianschmidtwelzow) [22:57:43] bgerstle: ^ [22:57:49] mehhh [22:57:52] one… more… space [22:58:03] coreyfloyd: you can't have @0 on the same line as return? [22:58:21] 6Mobile-Web: Glitchy talk overlay behaviour - https://phabricator.wikimedia.org/T91139#1074936 (10Jdlrobson) 3NEW [22:58:27] bgerstle: you can [22:58:32] bgerstle: coreyfloyd can you guys +1 https://gerrit.wikimedia.org/r/#/c/193312/ if it’s not too jam packed :) [22:59:20] (03CR) 10Mhurd: [C: 031 V: 031] "Corey's amendments work nicely." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193312 (owner: 10Mhurd) [22:59:48] mhurd: I'll abstain since I wrote part of it [23:00:19] bgerstle: i just had it preformatted like that [23:00:34] bgerstle: i dont think i'll be able to enforce it one way or the other [23:00:54] coreyfloyd: as long as uncrustify doesn't mess up having @[@0,\n@1 i'm ok [23:00:55] dbrant: ok, sounds good [23:01:13] i.e. looks like how you just pasted, just w/ @0 on the return line [23:01:25] coreyfloyd: feel free to push and i'll have a look [23:01:35] dbrant: Deskana|Away: gonna start a new beta release if you don't mind [23:01:36] oh shite [23:01:49] coreyfloyd: are you getting uncrustify errors? [23:01:53] coreyfloyd: cool. if brian +1’s i’ll make a note on merge that about it being a collaborative patch thus not a true self-merge ;) [23:02:10] https://www.irccloud.com/pastebin/TZP4kzk9/uncrustify+error [23:02:22] i think the NSDictionary literal is breaking uncrustify :-((( [23:02:29] i saw errors for other files [23:02:34] (when run on the whole project) [23:02:39] bgerstle: RECRUSTIFY! [23:02:52] mhurd: more like no-crustify :-( [23:03:57] bearND: cool! [23:04:23] phuedx: you still here? [23:05:10] doing a TWN sync [23:05:27] hm, it still seems to process teh file... [23:05:31] just throws tha error [23:09:10] (03CR) 10Jdlrobson: [C: 031] "I wonder if we should just retrieve it all in one go and make getBannerImage a method on a Page rather than have this repository thing?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [23:09:13] coreyfloyd: it's messing up C functions too :-( [23:09:41] coreyfloyd: i'm going to push a C function example, k? [23:10:56] sorry mhurd getting side tracked w/ uncrustify [23:13:00] bgerstle: no worry i’m going to run to the store for 10 min or so to grab something to drink - can’t eat for another couple hours. could you set aside a few to review 193312 when i get back? [23:13:01] looked like a typ [23:13:38] mhurd: if i'm still online by the time you get back, sure [23:13:40] looking at it now [23:13:56] bgerstle: oh cool - i can wait a bit [23:15:00] coreyfloyd: would you mind +1’ing 193312 as well so it looks less like i’m doing a self merge if brian gives it a thumbs up? [23:15:02] 6Mobile-Web, 7Design: Styling regression in new editor tutorial - https://phabricator.wikimedia.org/T91141#1074959 (10Jdlrobson) 3NEW [23:15:12] (03CR) 10Jdlrobson: [C: 032] "There has also been some kind of styling regression here. Have cut a new bug for that." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193501 (https://phabricator.wikimedia.org/T91048) (owner: 10Bmansurov) [23:15:44] mhurd: we all know what you're up to [23:15:49] lol [23:15:49] merging your own patches.. [23:16:24] (03Merged) 10jenkins-bot: Fix "No thanks" in EditorTutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193501 (https://phabricator.wikimedia.org/T91048) (owner: 10Bmansurov) [23:16:53] coreyfloyd: i'm going to stash my changes and checkout 193312. i suggest you add another example w/ multi-line CGRect call to see how uncrustify deals w/ it [23:17:39] (03PS13) 10Jdlrobson: Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 [23:17:48] (03PS6) 10Jdlrobson: Hygiene: ImageOverlay should use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188622 (https://phabricator.wikimedia.org/T88566) [23:18:12] D: ERMAGERD [23:18:17] 6Mobile-Web, 5Patch-For-Review: EditorTutorial "No thanks" doesn't work - https://phabricator.wikimedia.org/T91048#1074972 (10Florian) 5Open>3Resolved a:3Florian [23:18:18] https://www.irccloud.com/pastebin/eItfpHJ6/ternary+madness [23:18:19] 6Mobile-Web, 10WikiGrok: wikigrokresponse API should cap the number of claims accepted - https://phabricator.wikimedia.org/T91142#1074974 (10MaxSem) 3NEW [23:19:11] (03PS4) 10Jdlrobson: WIP: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 [23:19:34] rmoen: around? [23:19:41] yes [23:19:43] bgerstle: these irccloud links never show anything... [23:19:51] please review https://gerrit.wikimedia.org/r/193297 ? it's bugging me like crazy :) [23:19:54] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193509 [23:19:58] mhurd: coreyfloyd FYI for part of my interview, i implemented a throttling, query-canceling search controller ;-) [23:20:03] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193510 [23:20:07] mhurd: really? should be a pastebin [23:20:20] (03CR) 10Fjalapeno: [C: 031] Fix for status bar tap not causing scroll-to-top. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193312 (owner: 10Mhurd) [23:20:23] mhurd: what about https://www.irccloud.com/pastebin/raw/eItfpHJ6? [23:20:25] 6Mobile-Web: Glitchy talk overlay behaviour - https://phabricator.wikimedia.org/T91139#1074983 (10Florian) a:3Florian That is the "correct" behavior, it indicates, that the new topic is beeing saved (e.g. try throttling the connections speed). But it should be a loading spinner like for EditorOverlay, instead... [23:20:30] bgerstle: trying... [23:20:39] jdlrobson: haha yeah its been bugging me a while too [23:20:39] bgerstle: yep i see that one! [23:20:50] weird the other doesn't work [23:20:58] (03CR) 10Robmoen: [C: 032] Do not load css via JavaScript [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193297 (owner: 10Jdlrobson) [23:21:03] mhurd: got a new translation patch ^^ [23:21:09] mhurd: sorry but i think i ran out of time for today [23:21:10] bgerstle: the other one has a loading indicator always stuck at ~25% [23:21:13] dogs can't wait any longer [23:21:17] bearND: hey thanks! [23:21:17] weird [23:21:31] mhurd i can review first thing on monday [23:22:21] (03CR) 10Jdlrobson: [C: 04-1] "When I visit http://localhost:8080/wiki/Special:Gather/Jdlrobson/0" (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 (owner: 10Jhernandez) [23:22:27] bgerstle: no worry! [23:22:37] (03CR) 10Bgerstle: [C: 031] "pure code comments only, haven't tested." (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193312 (owner: 10Mhurd) [23:22:45] mhurd ^ [23:22:47] that's all i got for now [23:22:50] bgerstle: wait on merge? [23:22:57] mhurd *shrug* not necessary IMO [23:23:06] if you test it, and it works, everything else can be patched later [23:23:13] (03PS4) 10Jdlrobson: Fix bad parsing of url parameters [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193364 (owner: 10Jhernandez) [23:23:23] coreyfloyd: ^thoughts? [23:23:44] gotta go now, i leave it in your capable hands [23:23:54] bgerstle: thanks! have a good weekend! [23:24:12] (03CR) 10Jdlrobson: "Also" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 (owner: 10Jhernandez) [23:24:18] (03CR) 10jenkins-bot: [V: 04-1] Fix bad parsing of url parameters [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193364 (owner: 10Jhernandez) [23:24:21] coreyfloyd mhurd i'm not 100% sure we should merge uncrustify... but i also hate to delay it any further [23:24:22] (03CR) 10Florianschmidtwelzow: [C: 04-1] "> Ideally the banner image should be available by default without this API request" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [23:24:30] so, i'll let you guys decide that too [23:24:35] have a great weekend! [23:24:36] o/ [23:24:36] bgerstle: oh is your image viewer patch ready to review? [23:24:42] mhurd: rrrm [23:24:58] both are (large images and design updates) [23:25:07] bgerstle: cool thanks! [23:25:20] mhurd: that is, if you're OK w/ me addressing the RTL close button flip via auto layout in another patch [23:25:30] bgerstle: ya for sure [23:25:33] (given that we file another bug for it which is triaged accordingly) [23:25:48] mhurd: bgerstle looks like a lot of things are cropping up on uncrustify - will work on it but maybe it will be easier to merge on monday morning [23:25:48] otherwise the meat of the matters should be solved in both patches [23:26:00] (03CR) 10Jdlrobson: [C: 04-1] Fix bad parsing of url parameters (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193364 (owner: 10Jhernandez) [23:26:02] coreyfloyd: i think that's wise [23:26:06] maybe i can tinker w/ it a bit over the weekend [23:26:07] mhurd: bgerstle i dont think that will affect me too much [23:26:14] ok, my dogs are gonna eat me alive. later! [23:26:19] bgerstle: ok - thinkning the same thing [23:26:22] bgerstle: go! [23:26:24] :) [23:26:40] mhurd: i also have to hop off for a bit - do you need something from me before i do? [23:27:32] coreyfloyd: if i can merge 193312 we can put that card in “ready for signoff”… think it’s ok? [23:28:37] coreyfloyd: i may be pushing too hard. it could wait until monday too [23:29:09] (03CR) 10Jdlrobson: Hygiene: Clean up stores\UserPageCollectionsList (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 (owner: 10Jhernandez) [23:30:13] mhurd: that one is good to go… i think i +1'd it didnt i? [23:30:37] coreyfloyd: you did, but brian didn’t have a chance to finish reviewing it. [23:31:00] 6Mobile-Web: Glitchy talk overlay behaviour - https://phabricator.wikimedia.org/T91139#1074995 (10Jdlrobson) I would expect the new topic overlay to display completely or to be replaced with a spinner in the body and destroyed when the topic is added.. not flash after clicking then disappear. [23:31:00] ahh - i mean - i code reviewed you and you reviewed me - so it should be fine [23:31:54] coreyfloyd: ok i’ll merge then. i need a brainless task for the afternoon - i was thinking about taking a styling pass at the 3 bottom trackingview sections and the “Read more” label. sound ok? [23:33:06] (03CR) 10BearND: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193510 (owner: 10BearND) [23:33:28] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193510 (owner: 10BearND) [23:34:09] 6Mobile-Web: Formatting of TOC header messed up - https://phabricator.wikimedia.org/T90791#1075006 (10kaldari) @phuedx @Jdlrobson It looks like the issues in the beta version are related to the rules for mw-ui-icon-element. Frankly, I'm not sure what to make of the rules for mw-ui-icon-element as they are surpri... [23:34:41] (03PS1) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193515 [23:35:09] (03CR) 10BearND: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193515 (owner: 10BearND) [23:35:29] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193515 (owner: 10BearND) [23:39:20] 6Mobile-Web: Formatting of TOC header messed up - https://phabricator.wikimedia.org/T90791#1075008 (10Jdlrobson) mw-ui-icon is part of MediaWiki UI which is now deprecated apparently. Our best bet is probably trying to port them over to OOJS UI now but I have no idea where to start with that, as I don't think t... [23:44:43] dbrant: did you see that “thumbwidth” can now be set in mobileview query? [23:45:33] ah, yes! it's on the to-do list to take advantage of [23:45:57] (03CR) 10Mhurd: [C: 032 V: 032] "This was a collaborative patch. Corey amendments came last (excluding rebase.)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193312 (owner: 10Mhurd) [23:46:27] (03PS2) 10Jdlrobson: Hygiene: Use one query to get all page images [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191584 (https://phabricator.wikimedia.org/T89754) (owner: 10Florianschmidtwelzow) [23:47:10] (03CR) 10Jdlrobson: [C: 032] "Yeh should be in PageImages but let's get this done here until then. @MaxSem would appreciate your help." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191584 (https://phabricator.wikimedia.org/T89754) (owner: 10Florianschmidtwelzow) [23:47:22] dbrant: Deskana|Away: do we have a Phab task for that? [23:47:45] (03PS4) 10Jdlrobson: QA: Add browser test for acessing private collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192540 (owner: 10Jhernandez) [23:47:50] (03CR) 10Jdlrobson: [C: 031] QA: Add browser test for acessing private collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192540 (owner: 10Jhernandez) [23:47:55] (03CR) 10Jdlrobson: [C: 032] QA: Add browser test for acessing private collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192540 (owner: 10Jhernandez) [23:48:36] bearND: we do not! feel free to add [23:48:44] (03Merged) 10jenkins-bot: Hygiene: Use one query to get all page images [extensions/Gather] - 10https://gerrit.wikimedia.org/r/191584 (https://phabricator.wikimedia.org/T89754) (owner: 10Florianschmidtwelzow) [23:48:56] (03Merged) 10jenkins-bot: QA: Add browser test for acessing private collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192540 (owner: 10Jhernandez) [23:49:25] (03CR) 10Jdlrobson: [C: 04-1] "also rebase" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 (owner: 10Jhernandez) [23:49:52] (03PS2) 10Jdlrobson: Do not load css via JavaScript [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193297 [23:49:57] (03CR) 10Jdlrobson: [C: 032] Do not load css via JavaScript [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193297 (owner: 10Jdlrobson) [23:50:02] rmoen: can you take a look at the gruntfile patch too? [23:50:15] https://gerrit.wikimedia.org/r/193296 [23:50:22] jdlrobson: yeah you see my pm ? [23:50:29] i do now [23:50:58] (03Merged) 10jenkins-bot: Do not load css via JavaScript [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193297 (owner: 10Jdlrobson) [23:51:09] dbrant: I think you know the details better [23:52:22] (03PS4) 10Jdlrobson: Hygiene: remove unused store [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193362 (owner: 10Jhernandez) [23:53:40] (03CR) 10Robmoen: [C: 032] "yay, jshint now works when running grunt. Thanks Jon." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193296 (owner: 10Jdlrobson) [23:54:47] (03Merged) 10jenkins-bot: Enable Gruntfile [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193296 (owner: 10Jdlrobson) [23:55:12] (03CR) 10Jdlrobson: [C: 032] Hygiene: remove unused store [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193362 (owner: 10Jhernandez) [23:56:17] (03Merged) 10jenkins-bot: Hygiene: remove unused store [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193362 (owner: 10Jhernandez) [23:56:23] mhurd: sounds good to me [23:56:40] coreyfloyd: yay! [23:58:19] coreyfloyd: i merged that mega-patch ( https://gerrit.wikimedia.org/r/#/c/193312/ ) so i dragged https://trello.com/c/QlENFzug/6-5-front-end-ui-for-displaying-article-suggestions to “ready for signoff" [23:58:19] dbrant: Deskana|Away: hmm, not sure what to do with ShareAFact. It's still in alpha only. Did we want to promote it or wait until next time? [23:59:58] coreyfloyd: i added this https://trello.com/c/Bd57wTMG/51-style-tweaks-to-bottom-tracking-view-sub-containers-read-more-last-edited-by-other-languages-and-legal-info to “Doing” column to track my style tweaks