[01:40:58] (03PS1) 10Bgerstle: remove MediaWikiKit tests from xcscheme [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193764 [03:21:26] 6Mobile-Web: Menu has fewer items in certain browsers despite plenty of room still left - https://phabricator.wikimedia.org/T91181#1076970 (10Jidanni) Yes I am studying how to http://www.quora.com/Phabricator/Comment-Editor-Only-support-drag-and-drop-for-upload-file-why [03:22:31] 6Mobile-Web: Menu has fewer items in certain browsers despite plenty of room still left - https://phabricator.wikimedia.org/T91181#1076976 (10Jidanni) https://secure.phabricator.com/T5187 still reading. [03:24:46] 6Mobile-Web: Menu has fewer items in certain browsers despite plenty of room still left - https://phabricator.wikimedia.org/T91181#1076981 (10Jidanni) Giving up. Tell me how to upload the images the old fashioned way. [03:50:07] 6Mobile-Web: MobileFrontend fails to enable Edit buttons when incorrectly mixing section levels - https://phabricator.wikimedia.org/T91186#1077012 (10Manfred.schlager) Thanks for your prompt answer Florian! Strange, I was able to reproduce it with the exact same markup. (See screenshots 1 [Desktop in mobile... [06:03:43] 6Mobile-Web: Menu has fewer items in certain browsers despite plenty of room still left - https://phabricator.wikimedia.org/T91181#1077166 (10Jidanni) OK I emailed the pictures to this bugs email address, but they still haven't showed up. [07:16:52] 6Mobile-Web: Menu has fewer items in certain browsers despite plenty of room still left - https://phabricator.wikimedia.org/T91181#1077205 (10Aklapper) >>! In T91181#1076981, @Jidanni wrote: > Tell me how to upload the images the old fashioned way. https://www.mediawiki.org/wiki/Phabricator/Help#Uploading_file_... [07:32:48] 6Mobile-Web: Menu has fewer items in certain browsers despite plenty of room still left - https://phabricator.wikimedia.org/T91181#1077223 (10MaxSem) 5Open>3Invalid a:3MaxSem You're not seing some items in Opera Mini because we've disabled all JS in it - reason being its JS engine being too weird to work w... [08:33:27] morning! [08:54:17] hey joakino [09:05:39] hi phuedx! [09:21:33] 6Mobile-Web, 5Patch-For-Review: Formatting of TOC header messed up - https://phabricator.wikimedia.org/T90791#1077451 (10phuedx) > Right now top priority should be fixing stable - all those rules are in our codebase, some change must have broken them. I think we can live with broken TOC in beta/alpha for a lit... [09:34:57] (03Abandoned) 10Jhernandez: POC: Load i18n messages to browser tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192542 (owner: 10Jhernandez) [09:37:59] (03PS4) 10Jhernandez: QA:Use mobile site for the browser tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192541 [09:39:46] (03CR) 10Phuedx: "Thanks Jdlrobson, Florianschmidtwelzow." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [09:41:35] (03CR) 10Jhernandez: "@Jdlrobson I know about that, but in the pairing session Zeljko suggested to do it explicitly for now." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192541 (owner: 10Jhernandez) [09:53:02] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193083 (owner: 10Phuedx) [10:06:11] (03PS5) 10Jhernandez: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 [10:06:16] (03CR) 10jenkins-bot: [V: 04-1] Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (owner: 10Jhernandez) [10:06:53] (03CR) 10Jhernandez: "Addressed comments" (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (owner: 10Jhernandez) [10:10:50] (03PS7) 10Jhernandez: Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 [10:10:52] (03PS6) 10Jhernandez: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 [10:29:18] (03CR) 10Jhernandez: [C: 04-2] Fix bad parsing of url parameters (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193364 (owner: 10Jhernandez) [10:29:50] (03Abandoned) 10Jhernandez: Fix bad parsing of url parameters [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193364 (owner: 10Jhernandez) [10:38:43] (03PS4) 10Jhernandez: Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 [10:46:13] (03PS5) 10Jhernandez: Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 [11:08:33] (03PS4) 10Jhernandez: Hygiene: Collection stores as functions & fix docs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 [11:09:38] (03CR) 10Jhernandez: [C: 031] "@Jdlrobson Fixed the public static abstract warnings and fixed the problem with the watchlist (id was passed as string, not int)" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 (owner: 10Jhernandez) [11:18:15] (03CR) 10Zfilipin: "I find the way MobileFronted has implemented going to the mobile site suboptimal." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192541 (owner: 10Jhernandez) [11:19:54] (03PS6) 10Jhernandez: Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 [11:26:51] (03CR) 10Phuedx: [C: 032] Hygiene: Correctly show relationship between desktop and mobile page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193756 (https://phabricator.wikimedia.org/T91183) (owner: 10Florianschmidtwelzow) [11:29:43] (03Merged) 10jenkins-bot: Hygiene: Correctly show relationship between desktop and mobile page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193756 (https://phabricator.wikimedia.org/T91183) (owner: 10Florianschmidtwelzow) [11:44:41] (03CR) 10Phuedx: "Tested by setting a bogus value for $wgMFMobileUrlTemplate and proving that the alternate links were added in desktop and mobile mode." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193756 (https://phabricator.wikimedia.org/T91183) (owner: 10Florianschmidtwelzow) [12:10:38] taking george to a fathers group [12:10:38] bbl [12:58:58] (03PS2) 10Jhernandez: WIP: Api: Adding a new collection with items. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 [14:05:48] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Image thumbnail urls should be included where applicable in wikidata API response for commonsMedia - https://phabricator.wikimedia.org/T76827#1077974 (10Lydia_Pintscher) p:5Triage>3Normal [14:06:36] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Image thumbnail urls should be included where applicable in wikidata API response for commonsMedia - https://phabricator.wikimedia.org/T76827#1077980 (10Lydia_Pintscher) a:5Lydia_Pintscher>3None [14:07:39] 6Mobile-Web, 10Continuous-Integration, 7Documentation, 7Technical-Debt: [jsduck] Various custom tags should be easily shareable between projects - https://phabricator.wikimedia.org/T86587#1077982 (10Krinkle) p:5Triage>3Low [14:39:31] back [14:39:41] * phuedx forgot to update his status [14:43:27] 6Mobile-Web: Menu has fewer items in certain browsers despite plenty of room still left - https://phabricator.wikimedia.org/T91181#1078012 (10Jidanni) File upload: OK. Who would have ever guessed. Hope I remember next time. Never mind this time. Opera Mini: well without a warning ("your browser..." linked from... [15:26:59] coreyfloyd: hey, were you involved w/ the xcodeproj code signing change? [15:27:08] just wondering why we set "developer" code signing for release config [15:27:09] bgerstle: yeah [15:28:24] bgerstle: no reason - that was a mistake - was letting xcode "fix code signing issues" to run on my device - didnt notice it did that. [15:28:37] bgerstle: feel free to modify [15:28:49] hm, is that what it does... interesting [15:28:56] were you profiling on your device? [15:29:23] i locally changed the "Profile" scheme setting to use the Debug config (to prevent it from needing the distribution profile) [15:29:49] i can commit that change so you shouldn't run into issues w/ the distribution profile unless you're releasing [15:30:24] coreyfloyd: anything i can do to help w/ uncrustify stuff? [15:35:26] (03CR) 10Phuedx: [C: 031] "This LGTM. These numbers are very magical though. It feels like the search list item HTML needs to be reworked to support vertically align" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193657 (https://phabricator.wikimedia.org/T91178) (owner: 10Florianschmidtwelzow) [15:37:13] bgerstle: I'm just looking for a way to control the array indentation [15:37:18] k [15:37:34] coreyfloyd: there are issues w/ func argument indentation too [15:37:39] bgerstle: I'm not sure if you had other things besides that that we needed to fix, but that is the oly thing i am really focusing on [15:38:04] coreyfloyd: i can push to my fork so you can see [15:38:11] and we can work off of that (instead of amending the same commit) [15:39:03] bgerstle: do you have "finished" changes? or is that just experimentation? [15:39:14] i have changes to the WMFCodingStyle file [15:39:24] adding more examples [15:39:38] C function call across multiple lines, macro across multiple lines, etc [15:42:52] coreyfloyd: changes are on my fork in the "uncrustify" branch [15:48:51] coreyfloyd: indent_brace_parent seems to fix the array & multi-line func examples [15:48:55] but.. breaks just about everything else :-( [15:50:06] bgerstle: ok thanks - are you just playing with this or are you on image gallery stuff today? [15:50:21] both i guess [15:50:28] i wanted to see if we could finally kill this task [15:50:55] and, afaict, since this is kind of a "trial and error" sorta thing, i thought we could kill it twice as fast [15:53:32] (03CR) 10Jhernandez: "@Jdlrobson I've renamed the methods as you suggested for API consistency" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 (owner: 10Jhernandez) [16:04:14] (03CR) 10Jhernandez: "Left a comment, I understand what you are saying Jdlrobson, let's figure out a better name but do the refactor on views/models/stores at t" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 (owner: 10Jhernandez) [16:06:51] (03CR) 10Jhernandez: [C: 031] "@Jdlrobson Also I've changed the name of the methods to match the newFromUser kind of name from the previous patch." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 (owner: 10Jhernandez) [16:08:36] (03PS3) 10Jhernandez: WIP: Api: Adding a new collection with items. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 [16:08:38] (03PS7) 10Jhernandez: Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 [16:08:40] (03PS5) 10Jhernandez: Hygiene: Collection stores as functions & fix docs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 [16:21:36] coreyfloyd: pushed more examples... also found a stray ":" in the uncrustify.cfg [16:21:45] bgerstle: hmm - can get it to allign the function variable names, but not the types [16:22:26] coreyfloyd: that's what i was seeing [16:22:35] the only thing i could get to work was "indent_brace_parent" [16:22:40] but like i said, it broke just about everything else [16:26:16] coreyfloyd: there's another fun edge case: [16:26:38] https://www.irccloud.com/pastebin/vkO7YOjj/oc+method+decl+w%2F+long+2nd+param [16:27:27] coreyfloyd: the short-term sol'n for array & fn indentation is to put all elements & params on the second line [16:27:45] but it's not ideal [16:28:35] bgerstle: this may help that: "align_oc_msg_colon_first" [16:28:40] (03PS3) 10Dbrant: Dark toolbar with white icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 [16:28:54] coreyfloyd: yeah, tbh uncrustify has TONS of somewhat-conflicting options [16:28:57] it's a rats' nest [16:29:09] i wish you could just say "here's what i want my code to look like" [16:29:24] i.e. what we have in WMFCodingStyle.{h,m} [16:30:00] bgerstle: yeah - i dont normally get this in the weeds on it - I just take one of the popular obj-c configs and maybe make a modification or 2 [16:30:28] yeah, i am being nit-picky w/ all these examples [16:30:47] also this may help you for getting some clarity on the options: https://github.com/Glavin001/atom-beautify/issues/57 [16:30:49] i didn't realize that enforcing some things like ptr-star spacing would come at the cost of method/fn arg indentation [16:30:55] (03PS4) 10Jhernandez: WIP: Api: Adding a new collection with items. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 [16:31:11] coreyfloyd: yeah i've been doing uncrustify --show-config [16:31:23] there are some intersting oc_ options [16:31:25] bgerstle: coreyfloyd heya! [16:31:30] hey mhurd [16:31:54] mhurd: sup dude [16:32:24] bgerstle: coreyfloyd woke up early… for me :) [16:32:38] yeah, no kidding! [16:32:39] mhurd: i'll say! [16:33:10] bgerstle: I would suggest time boxing it. Personally I don't care very deeply about too many things. [16:33:45] why can't ObjC devs have nice things :-( [16:33:48] bgerstle: at this point it may be easier to just grab another standard config and re-edit it [16:33:56] bgerstle: coreyfloyd did this friday before i left - https://gerrit.wikimedia.org/r/#/c/193557 i think it’s ready for cr :) [16:33:58] bgerstle: we dont deserve them [16:34:01] lol [16:34:07] mhurd: looking now [16:35:04] coreyfloyd: actually, that's a brilliant idea [16:35:18] copying that diijkst config *somehow* fixes the issues we're having [16:35:20] (03CR) 10jenkins-bot: [V: 04-1] Dark toolbar with white icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 (owner: 10Dbrant) [16:35:26] ill see if i can tweak it back to things like our ptr star preference [16:35:27] bgerstle: lol [16:35:34] or at least do a diff and figure out what's different [16:36:10] bgerstle: ok - well make the changes you want - try to be minimal - and then push it to gerrit - I'll do the same, and then lets ship it [16:36:28] coreyfloyd: can i work on it for like 6 more hours? :-P (ofc let's kill this thing) [16:36:33] lol [16:36:45] mhurd: you did some serious work friday night [16:37:36] coreyfloyd: was nice to have some head-down time :) also was able to snag vibha for a half hour or so before she left to tweak layout bits [16:38:10] *did someone say “ship it”?* [16:54:21] mhurd: cool - though sad when you need quite weekend time to get your head down… [16:54:33] mhurd: not quite shipping it yet, but soon [16:58:21] (03CR) 10Dbrant: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 (owner: 10Dbrant) [17:04:23] (03PS5) 10Jhernandez: WIP: Api: Adding a new collection with items. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 [17:04:42] i think this readme is up to date if i want to setup browser tests? https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/tree/master/tests/browser [17:10:32] phuedx: ^ do you know anything about it? :) [17:10:50] (03CR) 10Fjalapeno: "Minor comments" (039 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 (owner: 10Mhurd) [17:10:54] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: (3) As an engaged reader, I'd like a single more visually appealing "read more" result to be shown to me. (Experiment) - https://phabricator.wikimedia.org/T91113#1078571 (10KLans_WMF) [17:11:05] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: As an engaged reader, I'd like a single more visually appealing "read more" result to be shown to me. (Experiment) - https://phabricator.wikimedia.org/T91113#1078572 (10KLans_WMF) [17:11:21] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: EventLogging modifications to support A/B testing for "read more" vs "read next" - https://phabricator.wikimedia.org/T91110#1078573 (10KLans_WMF) [17:11:34] FlorianSW: i only modified the nearby endpoint [17:11:53] phuedx: ok, then i will try it, thanks :) [17:12:11] bgerstle: how are you coming along? [17:12:20] getting there [17:12:31] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: As an engaged reader, I'd like a single more visually appealing "read more" result to be shown to me. (Experiment) - https://phabricator.wikimedia.org/T91113#1078580 (10Dbrant) a:3Dbrant [17:12:41] hi all! I'd like to get some opinions on this from the mobile team - https://phabricator.wikimedia.org/T77925, and I'd like to know that does this feature stand a chance of being taken up as a project? [17:13:29] i think i'm happy enough w/ it at this point [17:14:28] coreyfloyd: do you want to have a look on my branch? [17:14:31] or should i amend the patch? [17:14:47] bgerstle: just patch it [17:15:56] (03CR) 10Florianschmidtwelzow: "> Can you rewrite the patch to also promote the talk overlay and take into account cache issues?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [17:16:03] (03PS18) 10Bgerstle: Adds code linting via uncrustify. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [17:16:13] tis done [17:16:17] bgerstle: dunka [17:16:53] bgerstle: I'll try and get this finished up quick then - need a lunch time break first though [17:17:08] k [17:18:00] mhurd: most comments i left were minor - the only real issue was encapsulation stuff. [17:18:34] coreyfloyd: cool thanks! amending now... [17:18:48] joakino: do you have a minute? [17:19:00] 10Wikipedia-App-Android-App: "This page does not exist" on clickthrough from Google search results. - https://phabricator.wikimedia.org/T89734#1078597 (10dahamsta) Apologetics for the delay. As an example, if I type "wikipedia" into Google on Chrome, the second result is Main_Page, and that throws the error, att... [17:19:03] codezee: what's up codezee [17:19:58] joakino: doing good, wanted some views on this - https://phabricator.wikimedia.org/T77925, if it can be taken up to develope as a project [17:22:17] codezee: seems like a good idea, jdlrobson seems pretty into it [17:22:33] ask him about it, he'll be around in an hour more or less for sure [17:23:07] joakino: yes,ok, I will :) [17:23:21] codezee: not sure about the complexity of the project though, that is something you need to ask so that it is clear that it is achievable [17:23:59] joakino: yes, that will come after its certain that it is up for taking up... [17:25:06] codezee: awesome, move it along [17:25:09] :D [17:25:33] yes, I'll try my best :) [17:26:33] (03PS5) 10Bgerstle: image gallery design updates [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193419 [17:30:02] mhurd: coreyfloyd are double infoboxes a known issue? [17:30:12] https://www.dropbox.com/s/6cbibgaxs9j5rfo/Double%20infobox%20on%20BO%20article.png?dl=0 [17:30:41] bgerstle: not a bug iirc. just 2 tables [17:30:46] i see [17:30:58] more of a design edge case [17:31:06] having "Quick facts:" for both makes them look like dupes [17:31:45] bgerstle: just the nature of wiki, people can add infoboxes or tables wherever. see the “mini” article on enwiki [17:32:16] (03PS4) 10Dbrant: Dark toolbar with white icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 [17:32:54] mhurd: right. would be nice if we could have a specific "title" for each one [17:33:43] bgerstle: for sure [17:36:14] (03PS6) 10Jhernandez: Api: Adding a new collection with items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 [17:36:23] (03PS2) 10Mhurd: Visual tweaks to "Read more" (w/Vibha) and other bottom native bits. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 [17:36:31] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 5Patch-For-Review: [iOS 6] Image gallery is blank after device is rotated - https://phabricator.wikimedia.org/T90752#1078687 (10KLans_WMF) [17:36:49] coreyfloyd: ^ i think i addressed all your comments except the containment one… checking that now... [17:37:30] coreyfloyd: by “addressed" i mean “did what you recommended” [17:37:52] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 5Patch-For-Review: Gifs binaries are not being routed to the data store properly (causes temporary blank screens in gallery) - https://phabricator.wikimedia.org/T89921#1078689 (10KLans_WMF) [17:37:53] dr0ptp4kt: ^ updated the patch [17:38:13] dr0ptp4kt: this patch: https://gerrit.wikimedia.org/r/#/c/193557 [17:39:12] mhurd: will retest [17:39:19] (03CR) 10Mhurd: "Added comments." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 (owner: 10Mhurd) [17:41:48] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Image map is not displayed correctly in Image Gallery view - https://phabricator.wikimedia.org/T90294#1078702 (10KLans_WMF) [17:42:18] coreyfloyd: quick hangout? [17:42:50] (03PS2) 10Phuedx: [WIP] New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 [17:43:09] mhurd: out for lunch. Post stand up is probably better. [17:43:23] coreyfloyd: no worry! [17:44:12] (03CR) 10jenkins-bot: [V: 04-1] [WIP] New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [17:45:01] 'course [17:45:30] ok, that's extremly uncool :( if i try to clone a repository from wikimedia git, it uses 20 kBit/s to transfer all data, if i clone it from github i have full-speed (1,7 MB/s here) :( Any ideas? [17:45:45] ssh or https clone? [17:45:50] both [17:46:31] tracert shows a route over telia.net, and iirc my provider (yeah it's the one i'm working for :D) has other customers with slow connections through telia's network, too :( [17:46:32] damn [17:46:46] 10Wikipedia-App-iOS-App: Sometimes images don't show in image viewer - https://phabricator.wikimedia.org/T89914#1078719 (10BGerstle-WMF) @MSyed @Deskana tried viewing Obama article on iPhone 6 simulator in English and Arabic, saw all the images. It could be that network issues are causing the images to not load... [17:46:56] Reedy ^^ [17:48:01] FlorianSW: If you go mention it in #wikimedia-operations opsen might be able to help a bit if you point out it's seemingly a telia issue etc [17:48:20] Reedy: ok, thanks :) [17:48:24] (03PS3) 10Phuedx: [WIP] New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 [17:48:28] brb rew00t [17:50:23] 10Wikipedia-App-iOS-App: Sometimes images don't show in image viewer - https://phabricator.wikimedia.org/T89914#1078722 (10BGerstle-WMF) Just re-read the description, how do I set the "Read in other languages" setting? I just set the device region & language to Saudi Arabia & Arabic respectively. [17:51:27] 10Wikipedia-App-iOS-App: Image Gallery: cannot open a random image - https://phabricator.wikimedia.org/T90293#1078728 (10BGerstle-WMF) @Deskana what do you mean by "multiple galleries"? I thought an article had one gallery of all its images? [17:52:35] (03CR) 10Mhurd: "Added one more comment." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 (owner: 10Mhurd) [17:52:45] 10Wikipedia-App-iOS-App: Sometimes images don't show in image viewer - https://phabricator.wikimedia.org/T89914#1078730 (10BGerstle-WMF) Ah-ha, found the setting and I see the problem: third image is blank when reading in arabic (via setting on the bottom of the page). [17:56:17] (03PS5) 10Dbrant: Dark toolbar with white icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 [17:56:30] (03PS4) 10Bmansurov: Fix close button click [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192374 [17:56:59] (03CR) 10Dr0ptp4kt: "Works okay on iPad 2 7.0.3 simulator, iPhone 4S 6.1.3, and iPhone 5c 8.1.3." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 (owner: 10Mhurd) [17:57:01] joakino: rmoen i'm getting up to speed with joakino patches [17:57:23] jdlrobson: whatever you need tell me [17:57:24] jdlrobson, joakino: aye, reading through https://gerrit.wikimedia.org/r/#/c/192309/ again [17:57:35] https://gerrit.wikimedia.org/r/193409 < joakino want to merg this? [17:57:51] joakino: and then add the @chrome and @en.m.wikipedia.beta.wmflabs.org tags [17:57:58] so we can get jenkins up and running [17:58:33] and hijack watchstar behaviour should be ready to go [17:58:35] 1 [17:59:35] jdlrobson: ok i'm having a look [17:59:49] (03CR) 10Jhernandez: [C: 032] QA: Apply anonymous test to mobile site only [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193409 (owner: 10Jdlrobson) [18:00:22] (03CR) 10Robmoen: [C: 031] "LG2M. This is very similar to my first attempt at this only better :)" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [18:00:55] (03Merged) 10jenkins-bot: QA: Apply anonymous test to mobile site only [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193409 (owner: 10Jdlrobson) [18:03:12] (03PS1) 10Jhernandez: Tag anon browser test with chrome and beta.wmflabs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193851 [18:04:55] (03PS8) 10Jhernandez: Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (owner: 10Jdlrobson) [18:05:08] (03CR) 10Jdlrobson: [C: 04-1] "( ! ) Fatal error: Call to undefined method WikitextContent::getJsonData() in /vagrant/mediawiki/extensions/Gather/includes/stores/JSONPag" (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [18:05:23] (03CR) 10Jdlrobson: [C: 032] Tag anon browser test with chrome and beta.wmflabs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193851 (owner: 10Jhernandez) [18:06:12] ^ joakino issue with your patch [18:06:14] can't get it working [18:06:24] (03Merged) 10jenkins-bot: Tag anon browser test with chrome and beta.wmflabs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193851 (owner: 10Jhernandez) [18:06:28] (without argumnets) [18:06:52] (03CR) 10Jdlrobson: "Also also http://localhost:8080/wiki/Special:Gather/Jdlrobson/13452 ( ! ) Notice: Undefined index: id in /vagrant/mediawiki/extensions/Gat" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [18:07:22] jdlrobson: that's because the wiki json page was created before, so content model is wikitext, next patch has the "back compatibility" if https://gerrit.wikimedia.org/r/#/c/193349/6/includes/stores/JSONPage.php [18:07:40] content model json is prf [18:07:49] joakino: we can't merge something with fatals [18:08:08] jdlrobson: let me fix it [18:08:12] joakino: sweet [18:08:20] otherwise ops will be moaning at us :) [18:08:30] not only ops :D [18:08:33] jdlrobson: but lego wanted me to remove all references to wikitext there ... [18:08:50] add FIXMEs if that's the case [18:08:53] we can clean it up later [18:08:53] k [18:08:58] and since we are not looking to use this long term.. [18:09:06] let's not waste energy / effort [18:09:36] joakino: why you try to call getJSONData() on a content model that isn't json? [18:09:38] (03PS9) 10Jdlrobson: Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 [18:10:03] FlorianSW: old pages florian, i just followed previeous reviews comments [18:10:07] 6Mobile-Web, 6Mobile-Apps, 10Wikimedia-Site-requests: Wikipedia app alt link shows on mediawiki.org and various other non-wikipedia misc. sites - https://phabricator.wikimedia.org/T91174#1078815 (10KLans_WMF) a:3MaxSem [18:10:21] mhurd - im back - you want to talk before standup [18:10:22] ? [18:10:38] joakino: hmm, but why jdlrobson get's this fatal, too? [18:11:42] what i mean: You schould check, if the content model match the expected and handle errors :) [18:11:45] not? [18:11:48] FlorianSW: again, he has a subpage ending in json that was created before the content model json rules were there [18:12:02] ah, ok :) [18:12:50] (03PS8) 10Jhernandez: Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 [18:14:26] 6Mobile-Web, 5Patch-For-Review: All en.wp hatnotes missing in content - https://phabricator.wikimedia.org/T91160#1078834 (10Jdlrobson) Background - https://trello.com/c/Ql6wlIAF/12-1-alpha-page-styling-experiment-disambiguation-is-not-shown I think the main purpose was to hide them in alpha where we are doing... [18:15:05] jdlrobson: can you revisit https://gerrit.wikimedia.org/r/#/c/189213/ in a free minute? :) [18:15:34] (03CR) 10Bmansurov: "Looks good, but stable and other modes look a little different. How about implementing it using an oojs-ui button with an indicator and an" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193540 (https://phabricator.wikimedia.org/T90791) (owner: 10Kaldari) [18:15:55] 6Mobile-Web, 5Patch-For-Review: All en.wp hatnotes missing in content - https://phabricator.wikimedia.org/T91160#1078840 (10Jdlrobson) Also cc @MHurd as the app uses our styling. [18:17:01] (03PS7) 10Florianschmidtwelzow: TWN: Use own message for terms of use link in license warning (editor and talk) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190831 [18:17:56] 6Mobile-Web, 7Design: Styling regression in new editor tutorial - https://phabricator.wikimedia.org/T91141#1078846 (10KLans_WMF) @msyed @vibhabamba do you guys have any leads on this? It may have been from before your time :-) [18:19:21] (03CR) 10jenkins-bot: [V: 04-1] TWN: Use own message for terms of use link in license warning (editor and talk) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190831 (owner: 10Florianschmidtwelzow) [18:19:35] (03PS9) 10Jhernandez: Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 [18:19:43] jdlrobson: ^ [18:20:06] (03PS7) 10Jhernandez: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 [18:20:46] 6Mobile-Web, 5Patch-For-Review: All en.wp hatnotes missing in content - https://phabricator.wikimedia.org/T91160#1078856 (10kaldari) I'm going to merge TheDJ's patch for now. We can revisit in alpha. [18:21:11] https://gerrit.wikimedia.org/r/#/c/192309/9/includes/stores/Collection.php < Gender cache not needed joakino [18:21:29] jdlrobson: 1 sec, rebasing followup patch [18:24:31] (03PS6) 10Jhernandez: Hygiene: Collection stores as functions & fix docs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 [18:25:16] (03PS10) 10Jhernandez: Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 [18:25:20] jdlrobson: ^ [18:25:32] (03PS8) 10Jhernandez: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 [18:27:51] (03PS7) 10Jhernandez: Hygiene: Collection stores as functions & fix docs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 [18:28:08] (03PS8) 10Jhernandez: Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 [18:28:18] (03PS7) 10Jhernandez: Api: Adding a new collection with items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 [18:29:24] (03CR) 10jenkins-bot: [V: 04-1] Api: Adding a new collection with items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 (owner: 10Jhernandez) [18:30:07] (03CR) 10Jhernandez: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 (owner: 10Jhernandez) [18:30:07] joakino: is that your last patch? [18:30:42] coreyfloyd: hangout about the main page bug adam found? [18:30:47] jdlrobson: jenkins hhvm job going crazy, but yea 'Api: Adding a new collection with items' is the last one [18:30:48] yup [18:30:56] https://gerrit.wikimedia.org/r/193401 [18:31:02] joakino: am looking at Add json user page storage for a collection [18:31:22] 👍 [18:32:40] (03CR) 10Kaldari: [C: 032] Bring back hatnotes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193560 (https://phabricator.wikimedia.org/T91160) (owner: 10TheDJ) [18:33:49] (03Merged) 10jenkins-bot: Bring back hatnotes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193560 (https://phabricator.wikimedia.org/T91160) (owner: 10TheDJ) [18:34:38] 6Mobile-Web: Page actions overlaps long titles - https://phabricator.wikimedia.org/T91281#1078904 (10Jdlrobson) 3NEW [18:35:16] kaldari are you guys having tech difficulties? [18:37:10] https://etherpad.wikimedia.org/p/MobileWeb-Retrospective [18:37:28] 6Mobile-Web, 10VisualEditor: Editor switcher styling regression - https://phabricator.wikimedia.org/T91283#1078925 (10Jdlrobson) 3NEW [18:37:43] (03PS2) 10Mhurd: TOC setup on background thread to free main thread for article render. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 [18:38:03] MaxSem: https://etherpad.wikimedia.org/p/MobileWeb-Retrospective [18:38:24] (03CR) 10Fjalapeno: "@monte also nice job filing a bug on masonry!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 (owner: 10Mhurd) [18:38:51] 6Mobile-Web, 10VisualEditor: Editor switcher styling regression - https://phabricator.wikimedia.org/T91283#1078943 (10Jdforrester-WMF) What should it look like? That's pretty much on-spec. for the MediaWiki theme that Design have asked for, but I might be missing something? [18:44:34] (03CR) 10Kaldari: [C: 032] Fix close button click [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192374 (owner: 10Bmansurov) [18:45:41] (03Merged) 10jenkins-bot: Fix close button click [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/192374 (owner: 10Bmansurov) [18:48:08] coreyfloyd: thanks! [18:48:27] coreyfloyd: still tweaking uncrustify? [18:49:19] mhurd: yeah about done - just grabbed brians changes and checking them out [18:49:43] coreyfloyd: exciting :) [18:52:40] 6Mobile-Web, 10VisualEditor: Editor switcher styling regression - https://phabricator.wikimedia.org/T91283#1079012 (10Jdlrobson) Icons are misaligned, tap areas are tiny, font is inconsistent with rest of the mobile experience Previously the highlight was a light blue - not sure if that is a regression or a pu... [18:59:03] (03PS1) 10Bgerstle: associate images using URLs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193863 (https://phabricator.wikimedia.org/T89914) [18:59:49] mhurd: dr0ptp4kt before i move onto squashing the next bug... is there anything i can do to help w/ teh CR backlog? [18:59:59] although, i might take a break for lunch now [19:00:07] (03CR) 10Jdlrobson: [C: 031] Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [19:00:10] maybe when i get back we can exchange some [19:00:22] bgerstle: i’m good. grab lunch :) [19:00:30] bgerstle: for sure [19:01:45] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 5Patch-For-Review: Sometimes images don't show in image viewer - https://phabricator.wikimedia.org/T89914#1079073 (10BGerstle-WMF) [19:03:26] (03PS6) 10Bgerstle: image gallery design updates [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193419 [19:03:40] (03PS4) 10Bgerstle: fix issue causing large images to not be rerouted to WMF cache [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191894 (https://phabricator.wikimedia.org/T89921) [19:06:17] (03CR) 10Fjalapeno: [C: 031] "bgerstle's latest change looks good to me. Can I get a second?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [19:06:53] mhurd: upvoted brian's change to uncrustify - you want checkout as well? [19:07:07] coreyfloyd: ya! [19:07:23] mhurd: if looks good to you, I will uncrustify the whole codebase [19:07:28] and add to the patch [19:07:44] coreyfloyd: k. i’ll checking in ~10min [19:07:50] *check it* [19:07:51] mhurd: np [19:09:17] (03PS1) 10Deskana: Promote Share a Fact to all build flavours except production release. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193866 [19:09:22] dbrant, bearND: ^ :-) [19:10:36] Deskana: great! when do we want to release a Beta with this included? [19:11:02] dbrant: We should wait a few days. I've got a meeting with Comms about it tomorrow. [19:11:09] dbrant: Seems sensible to hold off a few days at least to see. [19:11:36] Deskana: when are we going to be able to publish a prod release? [19:12:40] bearND: I think the only real blockers are the launcher icons and the toolbar. [19:13:08] bgerstle: i think we're currently ok on the cr. best i think to stay focused on image viewer. [19:13:12] bearND: Deskana: that's correct; I would want all of the "featuring" patches merged; and all that's left is the dark toolbar and launcher icons. [19:13:48] dbrant: Deskana: cool. I think I saw new launcher icons from Vibha [19:14:38] dbrant: Deskana: once we've go those things then we could publish a beta release and then a few days later production [19:20:44] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: [Blocked] Improve app icon to make it more material designesque - https://phabricator.wikimedia.org/T90809#1079118 (10Vibhabamba) {F52565} {F52566} {F52567} [19:24:15] dbrant, bearND: Yeah! Sounds nice. [19:24:32] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: LeadImage drawRect call frequency and CPU cost - https://phabricator.wikimedia.org/T91089#1079130 (10Fjalapeno) a:3Fjalapeno [19:25:04] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: Make all NSDateFormatters archived and static - https://phabricator.wikimedia.org/T91090#1079132 (10Fjalapeno) a:3Fjalapeno [19:25:52] dr0ptp4kt mhurd just grabbing the next 2 tickets of the stack ^ - hit me up if you want to discus [19:26:11] coreyfloyd: quick hangout? [19:30:57] (03CR) 10Phuedx: "Is this now record & aggregate user responses?" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [19:31:30] (03CR) 10MaxSem: "No, aggregation will be in a separate patch." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [19:32:05] MaxSem: wikigrok_aggregation.sql? [19:32:35] yep, the table is going to be part of this patch, but not actual agregayion:) [19:32:50] ooooook [19:33:01] so you can get both tables reviewed and ployed? [19:33:05] (just so i know) [19:34:38] yup [19:34:56] 6Mobile-Web: MobileFrontend fails to enable Edit buttons when incorrectly mixing section levels - https://phabricator.wikimedia.org/T91186#1079159 (10Manfred.schlager) Thanks KLans and Florian. To make it easier to test and verify, I have setup public access to the wiki exhibiting this issue. You can access sa... [19:37:50] 10Wikipedia-App-iOS-App, 10Analytics-EventLogging, 3Mobile App Sprint 52 - iOS: Some events not validating for MobileWikiAppSavedPages schema - https://phabricator.wikimedia.org/T91290#1079182 (10Deskana) [19:38:19] (03CR) 10Legoktm: [C: 04-1] Add json user page storage for a collection (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [19:40:22] dr0ptp4kt mhurd do you guys want offsite access to the builder server over VPN? (Brain and I are getting that setup for us because we need it) [19:40:55] coreyfloyd: did we get a build server? [19:41:20] 6Mobile-Web: MobileFrontend fails to enable Edit buttons when incorrectly mixing section levels - https://phabricator.wikimedia.org/T91186#1079211 (10Florian) a:3Florian @Manfred.schlager: Big thanks for your work in support us to solve this problem. For a little bit background: Earlier this day i want to try... [19:43:54] bmansurov: we chanegd hangouts [19:47:58] (03PS39) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [19:48:00] (03PS3) 10Mhurd: Visual tweaks to "Read more" (w/Vibha) and other bottom native bits. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 [19:49:06] (03CR) 10jenkins-bot: [V: 04-1] Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [19:49:15] coreyfloyd: ^ could you check the footer containment bits? i haven’t added the logic for hiding from main page yet [19:49:34] mhurd: yeah - its in [19:49:47] mhurd: yeah will check now [19:50:02] coreyfloyd: cool thanks! adding the main page hiding now... [19:50:07] (03CR) 10Fjalapeno: [C: 031] "minor comment - looks good." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193863 (https://phabricator.wikimedia.org/T89914) (owner: 10Bgerstle) [19:52:09] coreyfloyd: gah! i left in an extra property... [19:53:15] (03PS4) 10Mhurd: Visual tweaks to "Read more" (w/Vibha) and other bottom native bits. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 [19:53:21] coreyfloyd: ^ sry about that [19:53:32] coreyfloyd: removed the extra prop [19:53:49] mhurd: k [19:55:10] joered: https://phabricator.wikimedia.org/tag/gather/ [19:55:12] joakino: https://phabricator.wikimedia.org/tag/gather/ [19:56:25] (03PS3) 10Bmansurov: Change header in Beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193289 [19:56:38] http://hatjitsu.wmflabs.org/27095 < joakino rmoen [19:57:32] (03CR) 10Bmansurov: "@Phuedx Since your patch is based on my patch, could you address @Jdlrobson's comment in your patch? Thanks." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193289 (owner: 10Bmansurov) [19:58:23] coreyfloyd: oh god, i forget to set up “WMFWebViewFooterViewController.xib” … amending again. [19:58:37] mhurd: lol - take your time [19:58:45] coreyfloyd: sorry!!! [19:59:00] mhurd: i'm doing stuff for joel to get the server racked and accessable [19:59:25] coreyfloyd: oh cool thanks! [20:01:37] (03CR) 10Bmansurov: "recheck" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/193294 (owner: 10Bmansurov) [20:06:20] 6Mobile-Web: MobileFrontend fails to enable Edit buttons when incorrectly mixing section levels - https://phabricator.wikimedia.org/T91186#1079361 (10Manfred.schlager) @Florian: No worries, I'm absolutely delighted to see the level of interest, hard work, and great support you guys put into this AMAZING MW exte... [20:06:24] 6Mobile-Web, 10WikiGrok: Don't ever show WikiGrok on disambig pages - https://phabricator.wikimedia.org/T91300#1079362 (10MaxSem) 3NEW [20:06:53] joakino: rmoen https://trello.com/c/xZf1afge/36-add-existing-page-card-and-watchstar-to-add-to-collection-overlay [20:07:42] joakino: https://trello.com/c/4LrE1FYm/13-3-adding-to-new-collection-workflow [20:09:59] https://phabricator.wikimedia.org/T91302 < joakino rmoen [20:12:24] (03CR) 10Bgerstle: "replying to coreyfloyd's comment" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193863 (https://phabricator.wikimedia.org/T89914) (owner: 10Bgerstle) [20:13:47] (03PS11) 10Jhernandez: Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 [20:16:41] (03CR) 10Jhernandez: "I've reverted it to manually parsing since the code in several places assumes an "assoc" true, but getData on JsonContent doesn't allow pa" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [20:17:16] jdlrobson: when you can ^ [20:18:32] MaxSem: kaldari http://hatjitsu.wmflabs.org/68832 [20:18:42] (03CR) 10Bgerstle: [C: 031] Adds code linting via uncrustify. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [20:19:02] mhurd dr0ptp4kt let's uncrustify this thing! [20:19:03] ^^ [20:20:05] bgerstle: I'm all setup with the build server [20:20:20] coreyfloyd: joel told me \o/ [20:20:37] i think once uncrustify's merged, i'll put my up makefile patch that i hacked last weekend [20:20:53] then we can start automating build stuff [20:20:58] slowly but surely [20:23:18] jdlrobson: http://hatjitsu.wmflabs.org/27095 [20:25:04] bgerstle: almost ready to test uncrustify... [20:25:20] nice [20:25:26] (03PS1) 10Florianschmidtwelzow: Cherry pick "Fix transforming sections" to REL1_24 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193889 (https://phabricator.wikimedia.org/T91186) [20:25:28] bgerstle: grabbed quick lunch [20:25:30] k [20:25:34] (03CR) 10jenkins-bot: [V: 04-1] Cherry pick "Fix transforming sections" to REL1_24 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193889 (https://phabricator.wikimedia.org/T91186) (owner: 10Florianschmidtwelzow) [20:25:41] (03CR) 10Legoktm: [C: 04-1] "So we're basically back where we started in PS1? sigh..." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [20:26:03] (03Abandoned) 10Florianschmidtwelzow: Cherry pick "Fix transforming sections" to REL1_24 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193889 (https://phabricator.wikimedia.org/T91186) (owner: 10Florianschmidtwelzow) [20:27:21] legoktm: hey! it's not the same, the content model is set up and working properly, the problem is with the deprecation of getJsonData, how getData handles parsing, having not enough time, and this being a temporary solution [20:27:41] (03PS1) 10Florianschmidtwelzow: Cherry pick "Fix transforming sections" to REL1_24 [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/193891 (https://phabricator.wikimedia.org/T91186) [20:27:56] i understand your POV, i've tried hard to get it as good as I could, but i've spent too much time on this temporary hack [20:28:01] legoktm: ^ [20:28:31] joakino: did you read my inline comment? [20:29:13] legoktm: seems like i didn't :( sorry, and thanks, gonna try that! [20:29:20] (03CR) 10jenkins-bot: [V: 04-1] Cherry pick "Fix transforming sections" to REL1_24 [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/193891 (https://phabricator.wikimedia.org/T91186) (owner: 10Florianschmidtwelzow) [20:30:01] (03PS1) 10Dr0ptp4kt: Send app install ID with saved pages events [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193893 [20:30:08] ^ mhurd that [20:30:41] JsonContent has been developed after using it in 3+ extensions, and the whole parsing + getData() system is based on our experiences with the different types of JSON storage, so throwing it all away seems like you're just asking for a bad time or really want to re-invent the wheel. [20:33:51] hey legoktm the json storage is only temporary [20:33:57] we're trying to move to a database schema [20:34:02] so this is only a temporary solution [20:34:07] define temporary [20:34:07] (03PS12) 10Jhernandez: Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 [20:34:18] legoktm: as in we do not want to deploy it to production cluster [20:34:25] and one month tops [20:34:42] legoktm: thanks for the help, new patch there ^ [20:34:54] using json storage for managing lists will result in lots of race conditions [20:35:03] as soon as we hit list management [20:36:01] (03CR) 10Jhernandez: "Doing now:" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [20:36:11] rmoen: i can chat 1pm-1.30pm and 3pm onwards [20:36:17] what would you prefer? [20:36:22] got a crazy meeting day :( [20:36:37] https://etherpad.wikimedia.org/p/P [20:36:59] (03PS9) 10Jhernandez: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 [20:37:20] * jdlrobson grabbing lunch [20:37:21] (03PS8) 10Jhernandez: Hygiene: Collection stores as functions & fix docs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 [20:37:28] night joakino ! [20:37:33] (03PS9) 10Jhernandez: Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 [20:38:10] jdlrobson: gonna rebase the last patch and i'm out [20:39:04] (03CR) 10Legoktm: [C: 04-1] Add json user page storage for a collection (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (owner: 10Jhernandez) [20:39:21] (03PS8) 10Jhernandez: Api: Adding a new collection with items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 [20:39:23] (03PS1) 10Florianschmidtwelzow: Cherry pick "Fix transforming sections" to REL1_24 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193894 (https://phabricator.wikimedia.org/T91186) [20:39:30] (03CR) 10jenkins-bot: [V: 04-1] Cherry pick "Fix transforming sections" to REL1_24 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193894 (https://phabricator.wikimedia.org/T91186) (owner: 10Florianschmidtwelzow) [20:39:52] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 (owner: 10Jhernandez) [20:39:56] jdlrobson: dunno, I just get a bad feeling when people say temporary, I've just seen too much code that says "temporary hack" that was added years ago and never fixed [20:40:16] (03CR) 10Fjalapeno: "tag" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193863 (https://phabricator.wikimedia.org/T89914) (owner: 10Bgerstle) [20:40:29] (03Abandoned) 10Florianschmidtwelzow: Cherry pick "Fix transforming sections" to REL1_24 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193894 (https://phabricator.wikimedia.org/T91186) (owner: 10Florianschmidtwelzow) [20:40:45] anyways, I don't think this is too hard to do properly. [20:41:20] mhurd: just double cecking - you still need to do another update to your patch, right? [20:41:40] i got distracted - making sure i didnt miss anything [20:41:41] coreyfloyd: ya almost finished…. [20:41:42] baha [20:41:44] k [20:41:48] hangout quick [20:41:51] bmansurov: ^ [20:41:52] ok [20:41:59] legoktm: i guess it depends on how familiar you are with the codebase, it's costing me quite a bit [20:42:05] coreyfloyd: re: my patch, you're saying i should change it to @synthesize? [20:42:17] jdlrobso_: i'm out, too tired to continue, feel free to pick up https://gerrit.wikimedia.org/r/#/c/192309/ [20:42:27] gn all [20:42:31] (03PS2) 10Florianschmidtwelzow: Cherry pick "Fix transforming sections" to REL1_24 [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/193891 (https://phabricator.wikimedia.org/T91186) [20:42:41] 👋💩 [20:42:50] bgerstle: if that was the reason you needed the ivar, then yeah you can still declare it as a property and then provide a name for the storage variabe [20:43:07] just so you dont have to specify the ivar correctly [20:43:09] directly [20:43:20] (03CR) 10jenkins-bot: [V: 04-1] Cherry pick "Fix transforming sections" to REL1_24 [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/193891 (https://phabricator.wikimedia.org/T91186) (owner: 10Florianschmidtwelzow) [20:43:44] bgerstle: or rather - you can use the property syntax to take care of the implementation for you [20:43:54] coreyfloyd: not if it's lazy [20:44:02] i need to implement the getter [20:44:11] yeah - that still works [20:44:43] you need the matching property declaration @property(nonatomic, strong)… [20:44:43] hm, i'm confused by what you mean by "take care of the implementation" [20:44:49] do you mean that it'll create the ivar [20:44:54] right [20:45:47] right, so all we're talking about is explicit ivar or @synthesize [20:46:02] the getter & ivar reference in the impl don't change [20:46:02] yeah - thats why i didnt down vote it [20:46:55] right [20:47:04] bgerstle: yeah [20:47:04] am org [20:47:07] g'night folks [20:47:20] k [20:47:32] just wondered if we liked one over the other [20:48:00] bgerstle: i view it as a higher level abstraction thing - properties are above ivars… [20:48:28] bgerstle: i think the outline of that thinking is in the best practices… [20:48:31] right, it's an ugly facet of ObjC's leaky runtime abstraction [20:48:37] yeah it is, i'll change it [20:48:37] yeah [20:49:15] bgerstle: that is not the cleanest layer over ivars… c sucks [20:49:26] long live swift! [20:52:43] (03PS2) 10Bgerstle: associate images using URLs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193863 (https://phabricator.wikimedia.org/T89914) [20:53:57] coreyfloyd: http://weknowmemes.com/wp-content/uploads/2012/03/shoon.jpg [20:55:33] bgerstle: huh? I'm lost on this one [20:55:45] sean connery saying "soon" [20:55:52] say it in your head [20:56:00] LOL stop [20:56:03] hahaha [20:56:07] SHOON we'll have swift, my laddy [20:56:22] i mean "shwift" [20:56:33] bgerstle: its my fault for not being able recognize sean connery from the nose up [20:56:50] how do you sleep at night? [20:58:41] 10Wikipedia-App-iOS-App: image gallery UI doesn't flip to suit RTL languages - https://phabricator.wikimedia.org/T91313#1079644 (10BGerstle-WMF) 3NEW [20:59:16] 10Wikipedia-App-iOS-App: image gallery UI doesn't flip to suit RTL languages - https://phabricator.wikimedia.org/T91313#1079651 (10BGerstle-WMF) @Deskana @KLans_WMF please triage as needed for image gallery release [20:59:17] bgerstle: able to hop on a hangout for 5-10 mins? [20:59:36] dr0ptp4kt: i can join a hangout, probably not advisable for me to hop on my laptop [20:59:52] bgerstle: no problem there...i think [20:59:58] i'll try calling you on hangout shortly [21:00:05] k [21:01:25] (03PS4) 10Bmansurov: [WIP] New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [21:01:54] bgerstle: calling.. anything coming through? [21:06:57] 10Wikipedia-App-Android-App: EGL-related crashes - https://phabricator.wikimedia.org/T74530#1079692 (10Krenair) [21:08:04] (03PS5) 10Mhurd: Visual tweaks to "Read more" (w/Vibha) and other bottom native bits. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 [21:09:30] coreyfloyd: quick hangout? [21:10:49] dr0ptp4kt: i can pair w/ you on the parsing stuff if you'll repay me w/ a few code reviews :-) [21:10:50] mhurd: yep [21:13:12] bgerstle: reviewing uncrustify, then yours :) [21:13:20] k [21:14:33] bgerstle: coreyfloyd whoa! loving the column alignment on const strings [21:14:47] down with crust! [21:15:06] lol - nice [21:15:11] woohoo [21:16:01] (03CR) 10Fjalapeno: [C: 031] "still +1!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193863 (https://phabricator.wikimedia.org/T89914) (owner: 10Bgerstle) [21:16:21] thanks coreyfloyd [21:16:36] bgerstle: coreyfloyd oh neat it’s not just const strings! it seems to be on any grouping of assignments on consecutive lines [21:17:39] mhurd: yep [21:17:52] bgerstle: i sense a +1… [21:18:20] mhurd: have you seen WMFCodingStyle.{h,m}? [21:18:25] that's the style in a nutshell [21:18:44] but yeah, play around w/ it and re-run uncrustify on that file to see how it behaves [21:19:13] the one-liner is uncrustify -c uncrustify.cfg --replace --no-backup -l OC WikipediaUnitTests/WMFCodingStyle.* [21:19:22] that will "uncrustify" the coding style files [21:19:38] and then to revert to the patch state: git checkout WikipediaUnitTests/WMFCodingStyle.* [21:19:40] (03CR) 10Mhurd: [C: 032 V: 032] "Double checked with Adam too. MERGE!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191908 (owner: 10Fjalapeno) [21:19:47] YES! [21:20:44] * bgerstle pulls and sets up hooks & uncrustify plugin [21:21:02] (03PS13) 10Jdlrobson: Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (https://phabricator.wikimedia.org/T91293) (owner: 10Jhernandez) [21:21:32] coreyfloyd: mhurd dr0ptp4kt what happens now? merge outstanding patches and then uncrustify en masse? [21:21:47] bgerstle: coreyfloyd sounds good to me [21:22:14] bgerstle: coreyfloyd dr0ptp4kt so no new patches until uncrustify ? [21:22:51] mhurd: depends, how close are your perf patches from being final? [21:22:54] or, stable? [21:23:02] (03CR) 10MaxSem: [C: 04-1] "More generally, please see https://www.mediawiki.org/wiki/Manual:Database_access#Database_schema" (036 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193315 (owner: 10Robmoen) [21:23:18] bgerstle: the perf patches are tiny and i can rebase. [21:23:23] ok [21:23:40] most of my patches are small [21:24:02] bgerstle: coreyfloyd “bottomTrackingStyleTweaks” should probably be merged before uncrusting [21:24:03] so i'd almost rather get them reviewed [21:24:14] bgerstle: sounds good. reviewing now [21:24:30] mhurd: i'll look at that one [21:24:52] (03PS10) 10Jdlrobson: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (owner: 10Jhernandez) [21:25:02] bgerstle: ping me if you want a quick hangout tour of the overall bits [21:28:11] (03PS5) 10Bmansurov: [WIP] New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [21:28:16] (03PS6) 10Fjalapeno: Visual tweaks to "Read more" (w/Vibha) and other bottom native bits. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 (owner: 10Mhurd) [21:28:27] mhurd: wrapped up a couple lines… let me know what you think… ^ [21:28:43] coreyfloyd: checking… [21:29:57] coreyfloyd: perfect! [21:30:23] mhurd: cool - going over the rest now [21:35:10] (03CR) 10Mhurd: "Needs rebase." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193863 (https://phabricator.wikimedia.org/T89914) (owner: 10Bgerstle) [21:35:25] bgerstle: ^ if you can rebase and amend, i’ll merge it [21:35:36] jdlrobson: just got back, how about 3pm ? [21:37:03] bgerstle: can you rebase all your patches? [21:37:46] mhurd: sure [21:38:23] (03CR) 10BearND: [C: 04-1] Dark toolbar with white icons. (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 (owner: 10Dbrant) [21:39:12] (03CR) 10Mhurd: "Added comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191894 (https://phabricator.wikimedia.org/T89921) (owner: 10Bgerstle) [21:40:35] (03PS6) 10Bmansurov: [WIP] New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [21:40:59] JonKatz: https://phabricator.wikimedia.org/settings/panel/emailpreferences/ [21:42:03] (03CR) 10jenkins-bot: [V: 04-1] [WIP] New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [21:42:16] (03CR) 10MaxSem: [C: 04-1] Add api action for listing collections of a user (038 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (owner: 10Jhernandez) [21:43:55] (03CR) 10Fjalapeno: [C: 031] "Looks good!" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 (owner: 10Mhurd) [21:45:18] (03PS10) 10Jdlrobson: Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) [21:45:22] (03PS7) 10Bmansurov: [WIP] New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [21:45:54] (03CR) 10Fjalapeno: fix issue causing large images to not be rerouted to WMF cache (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191894 (https://phabricator.wikimedia.org/T89921) (owner: 10Bgerstle) [21:47:25] (03CR) 10Mhurd: "Much better. Follow-on patch ideas:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193419 (owner: 10Bgerstle) [21:47:46] (03CR) 10Mhurd: [C: 031 V: 031] "Looks good." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193419 (owner: 10Bgerstle) [21:47:48] (03CR) 10BearND: [C: 032] Promote Share a Fact to all build flavours except production release. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193866 (owner: 10Deskana) [21:48:34] (03CR) 10jenkins-bot: [V: 04-1] Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [21:48:59] (03CR) 10Fjalapeno: [C: 031] image gallery design updates (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193419 (owner: 10Bgerstle) [21:50:45] (03Merged) 10jenkins-bot: Promote Share a Fact to all build flavours except production release. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193866 (owner: 10Deskana) [21:51:21] (03PS4) 10Bmansurov: Expose the header template as a module for other extensions to use [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193289 [21:51:23] (03PS8) 10Bmansurov: [WIP] New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [21:51:33] (03CR) 10Fjalapeno: "Hey Brian - is there a reason we don't want to run these tests?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193764 (owner: 10Bgerstle) [21:51:40] bgerstle: stretching my legs for a couple minutes. can merge your patches when i get back if you’ll rebase them [21:51:49] brb [21:51:56] k [21:52:00] (03PS7) 10Bgerstle: image gallery design updates [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193419 [21:52:08] (03CR) 10Bmansurov: "I've transferred most of the contents of my earlier patch to @Phuedx's patch and made my patch depend on it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193289 (owner: 10Bmansurov) [21:52:20] mhurd: k, rebasing now. i have some questions about the IntrinsicContentSizeAware tableview when you get back [21:52:29] (03PS5) 10Bgerstle: fix issue causing large images to not be rerouted to WMF cache [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191894 (https://phabricator.wikimedia.org/T89921) [21:52:33] (03CR) 10jenkins-bot: [V: 04-1] Expose the header template as a module for other extensions to use [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193289 (owner: 10Bmansurov) [21:52:38] (03CR) 10jenkins-bot: [V: 04-1] [WIP] New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [21:52:59] mhurd also, seems like gerrit's able to rebase these on its own. i know i was squeamish about it last time, but feel free to try that if one of my patches needs it before merge [21:53:11] (03PS2) 10Bgerstle: remove MediaWikiKit tests from xcscheme [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193764 [21:56:26] (03PS3) 10Bmansurov: Match the Roulette header with the new header in MF Beta [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/193294 [21:56:55] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193289 (owner: 10Bmansurov) [22:01:10] bgerstle: gerrit won’t rebase this one https://gerrit.wikimedia.org/r/#/c/193863/ [22:01:37] dbrant, kristenlans: We're on our way! [22:01:55] 10-4 [22:02:01] Deskana ^ [22:02:57] mhurd: got it here [22:03:39] (03PS3) 10Bgerstle: associate images using URLs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193863 (https://phabricator.wikimedia.org/T89914) [22:03:41] mhurd ^ [22:05:08] (03CR) 10jenkins-bot: [V: 04-1] Match the Roulette header with the new header in MF Beta [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/193294 (owner: 10Bmansurov) [22:06:25] (03CR) 10Bgerstle: "first round of comments" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 (owner: 10Mhurd) [22:08:28] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Improve app icon to make it more material designesque - https://phabricator.wikimedia.org/T90809#1080025 (10bearND) a:5Vibhabamba>3bearND [22:09:02] bearND: note -- those launches icons are still not correct; Vibha is still working on them. [22:09:07] *launcher [22:09:18] dbrant: oh, ok. Thanks [22:10:15] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: [Blocked] Improve app icon to make it more material designesque - https://phabricator.wikimedia.org/T90809#1080040 (10bearND) a:5bearND>3Vibhabamba [22:10:39] dbrant: moved it back [22:11:17] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: [Spike 3 hrs] Investigate onboarding libraries to find one that's suitable for our purposes - https://phabricator.wikimedia.org/T89987#1080047 (10bearND) a:3bearND [22:13:37] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: image gallery UI doesn't flip to suit RTL languages - https://phabricator.wikimedia.org/T91313#1080052 (10KLans_WMF) [22:13:50] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: image gallery UI doesn't flip to suit RTL languages - https://phabricator.wikimedia.org/T91313#1080063 (10Deskana) This is a blocker for release, yes. [22:14:39] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: 4.0.6.3 Image gallery - images(svg) blurred on the black background - https://phabricator.wikimedia.org/T91128#1080064 (10KLans_WMF) p:5Triage>3Normal [22:14:41] (03PS1) 10Dr0ptp4kt: Share a fact heuristic text enhancements [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193973 [22:14:43] (03CR) 10jenkins-bot: [V: 04-1] Share a fact heuristic text enhancements [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193973 (owner: 10Dr0ptp4kt) [22:15:16] (03CR) 10Fjalapeno: Visual tweaks to "Read more" (w/Vibha) and other bottom native bits. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 (owner: 10Mhurd) [22:15:55] 10Wikipedia-App-iOS-App: 4.0.6.3 Image gallery - not all image info is displayed - https://phabricator.wikimedia.org/T91125#1080077 (10Deskana) 5Open>3stalled I don't know what we can do about this... :-( [22:17:19] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: image gallery UI doesn't flip to suit RTL languages - https://phabricator.wikimedia.org/T91313#1080083 (10KLans_WMF) p:5Triage>3Normal [22:17:46] (03CR) 10Mhurd: "Added comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 (owner: 10Mhurd) [22:18:04] (03PS7) 10Mhurd: Visual tweaks to "Read more" (w/Vibha) and other bottom native bits. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 [22:18:09] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: 4.0.6.3 Image Gallery - some images displayed in low resolution - https://phabricator.wikimedia.org/T91124#1080085 (10KLans_WMF) p:5Triage>3Low [22:18:18] (03CR) 10Fjalapeno: Visual tweaks to "Read more" (w/Vibha) and other bottom native bits. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 (owner: 10Mhurd) [22:19:03] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Update text heuristic for Share a Fact image when no text selected - https://phabricator.wikimedia.org/T91119#1080090 (10KLans_WMF) p:5Triage>3Normal [22:19:44] coreyfloyd: what was your last comment? [22:19:49] coreyfloyd: i can't read your comment after "Similarly..." [22:19:53] coreyfloyd: having trouble tracking it down in gerrit [22:20:05] mhurd: it was to brian… [22:20:29] mhurd: bgerstle didnt see brians comment that he referenced [22:21:07] coreyfloyd: s'alright [22:21:08] dbrant: https://phabricator.wikimedia.org/T91118 [22:21:10] just re-read the docs, and you're right [22:21:29] you only need to call willMoveToParentVC when remove it [22:21:32] before removing it* [22:22:45] 10Wikipedia-App-iOS-App: 4.0.6.3 Expanding Quick facts box and flipping to horizontal position - the empty space for leading image is preserved. - https://phabricator.wikimedia.org/T91118#1080108 (10KLans_WMF) p:5Triage>3Normal [22:23:32] 10Wikipedia-App-iOS-App: Add slow connection handling to image gallery - https://phabricator.wikimedia.org/T91115#1080112 (10KLans_WMF) p:5Triage>3Normal [22:25:06] 10Wikipedia-App-iOS-App: 4.0.6.3 Image is not presented in the Image Gallery - https://phabricator.wikimedia.org/T91116#1080117 (10KLans_WMF) p:5Triage>3Normal [22:25:33] (03PS8) 10Mhurd: Visual tweaks to "Read more" (w/Vibha) and other bottom native bits. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 [22:26:26] 10Wikipedia-App-iOS-App: 4.0.6.3 Cladogram template - connecting lines displayed white: hard to see - https://phabricator.wikimedia.org/T91112#1080121 (10KLans_WMF) p:5Triage>3Normal [22:28:01] (03PS1) 10Dbrant: [WIP] Single "read next" item at the bottom of articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193974 [22:28:21] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Update text heuristic for Share a Fact image when no text selected - https://phabricator.wikimedia.org/T91119#1080130 (10dr0ptp4kt) [22:28:22] 10Wikipedia-App-iOS-App: Update heuristic for Share a Fact - https://phabricator.wikimedia.org/T91111#1080129 (10dr0ptp4kt) [22:28:38] (03CR) 10Bgerstle: [C: 031] "lgtm!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 (owner: 10Mhurd) [22:28:45] (03CR) 10Fjalapeno: [C: 031] Visual tweaks to "Read more" (w/Vibha) and other bottom native bits. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 (owner: 10Mhurd) [22:29:02] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: 4.0.6.3 Image Gallery- switching from a vertical view to horizontal loads a different picture - https://phabricator.wikimedia.org/T91106#1080132 (10KLans_WMF) p:5Triage>3High [22:29:19] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Single "read next" item at the bottom of articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193974 (owner: 10Dbrant) [22:30:15] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: 4.0.6..3 - deleting a selected Saved page takes >20 sec - https://phabricator.wikimedia.org/T91100#1080140 (10KLans_WMF) p:5Triage>3Normal [22:30:18] (03PS2) 10Dbrant: [WIP] Single "read next" item at the bottom of articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193974 [22:30:34] dr0ptp4kt: got +1s on the “bottomTrackingStyleTweaks” patch. gonna merge if that’s ok [22:33:54] (03CR) 10Mhurd: [C: 032 V: 032] "+1's from Brian and Corey. Merging." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193557 (owner: 10Mhurd) [22:34:57] (03PS3) 10Mhurd: remove MediaWikiKit tests from xcscheme [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193764 (owner: 10Bgerstle) [22:35:48] (03CR) 10Mhurd: [C: 032 V: 032] "Brian removed some cruft." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193764 (owner: 10Bgerstle) [22:36:17] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Wikipedia Android is contributed anonymous if username is in Korean - https://phabricator.wikimedia.org/T90428#1080183 (10KLans_WMF) p:5Triage>3High [22:37:36] 10Wikipedia-App-Android-App: Limit the filesystem cache size of Picasso library. - https://phabricator.wikimedia.org/T89834#1080196 (10KLans_WMF) p:5Triage>3Normal [22:38:05] 10Wikipedia-App-Android-App: Don't perform arbitrary-length transactions over the Javascript bridge. - https://phabricator.wikimedia.org/T89831#1080200 (10KLans_WMF) p:5Triage>3Normal [22:38:43] 10Wikipedia-App-Android-App: Reuse the same WebView for visiting subsequent pages. - https://phabricator.wikimedia.org/T89828#1080206 (10KLans_WMF) p:5Triage>3Normal [22:39:08] (03PS6) 10Bgerstle: fix issue causing large images to not be rerouted to WMF cache [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191894 (https://phabricator.wikimedia.org/T89921) [22:41:36] 10Wikipedia-App-Android-App: Voice search? - https://phabricator.wikimedia.org/T89609#1080218 (10KLans_WMF) p:5Triage>3Normal [22:43:53] (03PS2) 10Jdlrobson: Add gather db tables and schema update hook [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193315 (https://phabricator.wikimedia.org/T91308) (owner: 10Robmoen) [22:43:59] 10Wikipedia-App-Android-App: "This page does not exist" on clickthrough from Google search results. - https://phabricator.wikimedia.org/T89734#1080227 (10KLans_WMF) a:3Etonkovidova [22:46:49] (03PS4) 10Bgerstle: associate images using URLs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193863 (https://phabricator.wikimedia.org/T89914) [22:47:27] (03CR) 10Mhurd: [C: 032 V: 032] "Corey +1'ed this earlier. Merge!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193863 (https://phabricator.wikimedia.org/T89914) (owner: 10Bgerstle) [22:49:40] (03CR) 10MaxSem: "New comments + everything from my previous comments." (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193315 (https://phabricator.wikimedia.org/T91308) (owner: 10Robmoen) [22:50:08] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Mobile-Apps: Upload photos on Wikipedia mobile app's edit screen - https://phabricator.wikimedia.org/T88746#1080251 (10KLans_WMF) p:5Triage>3Low [22:50:46] (03PS2) 10Dr0ptp4kt: Share a fact heuristic text enhancements [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193973 [22:52:46] (03PS8) 10Bgerstle: image gallery design updates [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193419 [22:53:13] 10Wikipedia-App-Android-App: Inconsistent image file info/display on 'Go to file page' - https://phabricator.wikimedia.org/T89191#1080274 (10KLans_WMF) @etonkovidova will recheck this [22:56:29] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Returning to the main home screen and back -the main page is displayed instead of recent search - https://phabricator.wikimedia.org/T89186#1080278 (10KLans_WMF) [22:57:28] 10Wikipedia-App-Android-App: Crash when clicking a link with a percent sign - https://phabricator.wikimedia.org/T89156#1080280 (10KLans_WMF) p:5Triage>3Normal [22:57:48] mhurd: coreyfloyd: would you please review https://gerrit.wikimedia.org/r/#/c/193973/ ? bgerstle, cc for visibility (but don't spend more than a few minutes on it should you tap through...image viewer!) [22:58:30] 10Wikipedia-App-Android-App: NPE crashes from android.webkit.AccessibilityInjector$TextToSpeechWrapper$1.onInit - https://phabricator.wikimedia.org/T89077#1080286 (10KLans_WMF) [22:59:08] 10Wikipedia-App-Android-App: NPE crashes from android.webkit.AccessibilityInjector$TextToSpeechWrapper$1.onInit - https://phabricator.wikimedia.org/T89077#1027028 (10KLans_WMF) Needs repro. [22:59:16] 10Wikipedia-App-Android-App: NPE crashes from android.webkit.AccessibilityInjector$TextToSpeechWrapper$1.onInit - https://phabricator.wikimedia.org/T89077#1080290 (10KLans_WMF) p:5Triage>3Low [23:00:42] (03CR) 10Mhurd: [C: 032 V: 032] "Merge!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193419 (owner: 10Bgerstle) [23:01:07] (03PS7) 10Mhurd: fix issue causing large images to not be rerouted to WMF cache [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191894 (https://phabricator.wikimedia.org/T89921) (owner: 10Bgerstle) [23:01:33] dr0ptp4kt: can you review https://gerrit.wikimedia.org/r/#/c/191894/ ? [23:02:16] (03CR) 10Mhurd: "Based on chat with Brian I think I'm game to try increasing the url cache memory allocation." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191894 (https://phabricator.wikimedia.org/T89921) (owner: 10Bgerstle) [23:02:41] (03CR) 10Mhurd: [C: 031 V: 031] "Let's do it." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191894 (https://phabricator.wikimedia.org/T89921) (owner: 10Bgerstle) [23:07:55] (03PS1) 10TheDJ: VE: Apply overflow fix on header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193984 [23:07:59] (03PS3) 10Mhurd: Share a fact heuristic text enhancements [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193973 (owner: 10Dr0ptp4kt) [23:13:41] (03CR) 10MaxSem: Add api action for listing collections of a user (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (owner: 10Jhernandez) [23:14:37] ApiQueryBase < MaxSem ? [23:14:54] ApiQueryGeneratorBase [23:15:39] dr0ptp4kt: will check out in about 15 [23:15:49] coreyfloyd: thx [23:16:15] (03CR) 10Jdlrobson: [C: 04-1] Expose the header template as a module for other extensions to use (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193289 (owner: 10Bmansurov) [23:16:22] Hey mhurd bgerstle dr0ptp4kt coreyfloyd Deskana: Just finally had a moment to sync phab/trello boards. Everything in fligth is in Phab now, so please use that board: https://phabricator.wikimedia.org/tag/mobile_app_sprint_52_-_ios/ [23:16:37] thanks kristenlans ! [23:16:38] kristenlans: cool thanks! [23:16:42] kristenlans: thx [23:17:01] (03CR) 10Jdlrobson: Hygiene: Align watchstars correctly in SearchOverlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193657 (https://phabricator.wikimedia.org/T91178) (owner: 10Florianschmidtwelzow) [23:17:09] thanks MaxSem [23:18:06] mhurd bgerstle dr0ptp4kt coreyfloyd Deskana: also note that we just wrapped up bug triage and popped a few release blockers into the sprint [23:18:30] kristenlans: TOTAL FAILURE!!!! [23:18:34] ;) [23:18:48] * Deskana checks that everything is prioritised correctly [23:19:02] Deskana: I CAN’T HEAR YOU!!! [23:19:03] * kristenlans hovers over cmd + R [23:20:39] Deskana can you please make the pic of you holding the facilitation kitten your phab avatar? [23:20:51] kristenlans: Deskana IT’S SHOUT TIME! [23:21:05] mhurd Deskana HELLYEAH!!!! [23:21:11] mhurd: Are you feeling alright? ;-) [23:21:24] He's at max coffee, I suspect ;-) [23:21:27] Deskana: COULDN’T BE BETTER!!! [23:22:15] mhurd, where the m stands for MAXIMUM CAFFEINE [23:22:34] Deskana: MMMMMMMMMEEEEERRRRGGGEEESHIPIT. [23:23:17] mhurd bgerstle dr0ptp4kt coreyfloyd: are you guys feeling solid about sprint plan/what to do next? It seems like there was some uncertainty about that at standup. [23:23:21] Who gave Monte's patch to drink so much coffee a +2? [23:23:36] Deskana: SELF MERGE!@!!@ [23:23:44] BAD MONTE [23:23:45] mhurd: LOLOL [23:23:53] "Trivial caffeination change, self-merging" [23:24:00] NO [23:24:10] you guys aren't even listening to how much he's chuckling to himself [23:24:19] (03CR) 10Jdlrobson: Add api action for listing collections of a user (038 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (owner: 10Jhernandez) [23:24:24] (03PS4) 10Dr0ptp4kt: Share a fact heuristic text enhancements [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193973 [23:24:30] ^ mhurd thar [23:28:53] Does anyone in the office have a Android 4.x testing device? [23:31:25] (03PS11) 10Jdlrobson: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (owner: 10Jhernandez) [23:33:11] bmansurov: Where is that OOjs patch for MF? I can’t seem to find it now. [23:33:25] mhurd bgerstle dr0ptp4kt coreyfloyd Deskana: one thing I suggest for our Phab trial is uploading a photo. END GROUP IRC MESSAGE SPAMMING [23:33:34] kaldari: button with spinner patch? [23:34:22] bmansurov: nevermind, I found it :) [23:37:30] 6Mobile-Web, 6Mobile-Apps, 10Wikimedia-Site-requests, 5Patch-For-Review: Wikipedia app alt link shows on mediawiki.org and various other non-wikipedia misc. sites - https://phabricator.wikimedia.org/T91174#1080443 (10Dzahn) makes me wonder if we advertise the Commons app on Commons instead? https://commo... [23:38:15] 6Mobile-Web, 6Mobile-Apps, 10Wikimedia-Site-requests, 5Patch-For-Review: Wikipedia app alt link shows on mediawiki.org and various other non-wikipedia misc. sites - https://phabricator.wikimedia.org/T91174#1080444 (10MaxSem) @Dzahn, the Commons app is not really maintained. [23:41:53] bgerstle: i think we should change line 45 of defines.h to “(50, 50)" [23:47:27] 6Mobile-Web, 6Mobile-Apps, 10Wikimedia-Site-requests, 5Patch-For-Review: Wikipedia app alt link shows on mediawiki.org and various other non-wikipedia misc. sites - https://phabricator.wikimedia.org/T91174#1080468 (10MaxSem) 5Open>3Resolved [23:47:53] 6Mobile-Web, 6Mobile-Apps, 10Wikimedia-Site-requests: Wikipedia app alt link shows on mediawiki.org and various other non-wikipedia misc. sites - https://phabricator.wikimedia.org/T91174#1075922 (10MaxSem) [23:54:37] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] fix issue causing large images to not be rerouted to WMF cache [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/191894 (https://phabricator.wikimedia.org/T89921) (owner: 10Bgerstle) [23:55:52] (03CR) 10Fjalapeno: [C: 031] "left some comments, but no show stoppers." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193973 (owner: 10Dr0ptp4kt) [23:58:09] kaldari: is there a page to test this on beta labs yet? https://trello.com/c/xGwY2peL/10-3-new-wikigrok-campaign-if-country-of-origin-is-uk-or-us-suggest-english-as-language-of-work [23:59:06] Maryana: No, but I can work on that after I finish unblocking all this OOjs stuff :P