[00:00:43] 10Wikipedia-App-Android-App: Inconsistent image file info/display on 'Go to file page' - https://phabricator.wikimedia.org/T89191#1080500 (10Etonkovidova) It turns out that the issue is present in - Mobile Web display the same problems as in the screenshot - http://commons.wikimedia.org/wiki/File:Mona_Lisa,_... [00:06:12] (03CR) 10Bmansurov: Expose the header template as a module for other extensions to use (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193289 (owner: 10Bmansurov) [00:11:11] 10Wikipedia-App-Android-App: Can't go back from anchors in Android Beta Wikipedia App - https://phabricator.wikimedia.org/T89693#1080537 (10Etonkovidova) iOS behaves the same: pressing Back button will return to the previously viewed article. However, **the browser back button** will bring to the top of the a... [00:21:46] (03PS40) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [00:22:52] (03CR) 10jenkins-bot: [V: 04-1] Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [00:23:31] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Returning to the main home screen and back -the main page is displayed instead of recent search - https://phabricator.wikimedia.org/T89186#1080559 (10Etonkovidova) Re-checked on Nexus 5 Android version 4.4.4. The issue does not happen anymore. [00:25:50] dbrant|bbl: http://www.androidpit.com/android-5-0-lollipop-bug-apps-frequently-restart-in-background [00:26:40] (03PS14) 10Jdlrobson: Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (https://phabricator.wikimedia.org/T91293) (owner: 10Jhernandez) [00:27:03] (03CR) 10Jdlrobson: Add json user page storage for a collection (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (https://phabricator.wikimedia.org/T91293) (owner: 10Jhernandez) [00:27:16] (03PS12) 10Jdlrobson: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (owner: 10Jhernandez) [00:28:04] (03Abandoned) 10Jdlrobson: QA:Use mobile site for the browser tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192541 (owner: 10Jhernandez) [00:31:59] (03CR) 10Jdlrobson: [C: 04-1] Fixing Table of Contents formatting on mobile (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193540 (https://phabricator.wikimedia.org/T90791) (owner: 10Kaldari) [00:32:02] 10Wikipedia-App-Android-App: "This page does not exist" on clickthrough from Google search results. - https://phabricator.wikimedia.org/T89734#1080572 (10Etonkovidova) I could not reproduce it on Nexus 5 Android version 4.4.4. Might it be a temporary issue? [00:33:01] (03CR) 10Legoktm: [C: 031] Add json user page storage for a collection (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (https://phabricator.wikimedia.org/T91293) (owner: 10Jhernandez) [00:33:18] (03PS5) 10Dr0ptp4kt: Share a fact heuristic text enhancements [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193973 [00:33:48] 10Wikipedia-App-Android-App: "This page does not exist" on clickthrough from Google search results. - https://phabricator.wikimedia.org/T89734#1080582 (10Deskana) 5Open>3Resolved We've tested several times and never been able to reproduce it, so we have to assume it's been fixed... [00:34:51] (03CR) 10Dr0ptp4kt: "Resubmitted." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193973 (owner: 10Dr0ptp4kt) [00:35:04] 6Mobile-Web, 3Gather: iconClass code duplicated - https://phabricator.wikimedia.org/T91346#1080584 (10Jdlrobson) 3NEW [00:37:55] (03CR) 10Dr0ptp4kt: "Addressed items in PS 5." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193973 (owner: 10Dr0ptp4kt) [00:40:35] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Update text heuristic for Share a Fact image when no text selected - https://phabricator.wikimedia.org/T91119#1080594 (10dr0ptp4kt) https://gerrit.wikimedia.org/r/#/c/193973/ submitted for review [00:53:28] mhurd: https://gerrit.wikimedia.org/r/193893 [00:53:35] mhurd: ding [00:53:38] mhurd: ding [00:53:49] (03PS2) 10Mhurd: Send app install ID with saved pages events [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193893 (owner: 10Dr0ptp4kt) [00:54:47] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: image gallery UI doesn't flip to suit RTL languages - https://phabricator.wikimedia.org/T91313#1080651 (10Etonkovidova) Looking at the 'Intellectual Disability' article in Hebrew(iOS) - verified with Moriel - The article title should be placed on the righ... [01:02:50] (03CR) 10Mhurd: [C: 032 V: 032] Send app install ID with saved pages events [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193893 (owner: 10Dr0ptp4kt) [01:02:55] dr0ptp4kt: ^ [01:03:36] (03PS6) 10Mhurd: Share a fact heuristic text enhancements [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193973 (owner: 10Dr0ptp4kt) [01:03:43] (03PS1) 10Fjalapeno: Uncrustify entire source [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194011 [01:03:45] (03CR) 10jenkins-bot: [V: 04-1] Uncrustify entire source [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194011 (owner: 10Fjalapeno) [01:07:21] (03PS15) 10Robmoen: Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (https://phabricator.wikimedia.org/T91293) (owner: 10Jhernandez) [01:07:29] (03CR) 10Robmoen: [C: 032] Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (https://phabricator.wikimedia.org/T91293) (owner: 10Jhernandez) [01:08:31] (03Merged) 10jenkins-bot: Add json user page storage for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192309 (https://phabricator.wikimedia.org/T91293) (owner: 10Jhernandez) [01:14:28] coreyfloyd: hey you still around? [01:17:16] (03CR) 10Mhurd: [C: 032 V: 032] Share a fact heuristic text enhancements [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193973 (owner: 10Dr0ptp4kt) [01:19:21] mhurd: yeah [01:19:24] whats up? [01:19:58] coreyfloyd: hey i just merged adam’s share a fact patch. could you re-do that uncrustify-all patch? [01:20:06] mhurd: yep [01:20:52] coreyfloyd: thanks! i’ll start testing the uncrust patch then. aim for maybe merging it in the morning if no big explosions? [01:22:00] kaldari: o/ [01:22:20] coreyfloyd: brb - grabbing a snack [01:22:44] mhurd: ok - will be pushing the update soon [01:23:56] (03PS2) 10Fjalapeno: Uncrustify entire source [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194011 [01:24:38] coreyfloyd: yay! [01:24:43] coreyfloyd: fetching... [01:24:46] coolio [01:30:57] prtksxna: howdy [01:32:43] coreyfloyd: seems to work... [01:34:38] mhurd: cool [01:35:15] mhurd: you all good with the plugin/commit hook? [01:35:31] coreyfloyd: lemme try it out again... [01:38:46] coreyfloyd: seems to work… tad slow, but not painfully so [01:39:27] ok - yeah that is optional - feel free to run it manually [01:39:42] coreyfloyd: cool [01:41:32] coreyfloyd: ok if i tag the rest of the team on that commit? [01:41:52] mhurd: oh yeah have at it - forgot [01:42:35] (03CR) 10Mhurd: [C: 031 V: 031] "It works! :)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194011 (owner: 10Fjalapeno) [01:54:52] (03PS1) 10Mhurd: Fix for tap on small images not causing gallery view to appear. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194021 [01:55:36] coreyfloyd: ^ [01:56:55] kaldari: Just discussed your issue with nzr [01:57:14] kaldari: Mobile sets the font size to 1em? [01:57:19] prtksxna: yes [01:57:27] kaldari: Doesn't that trickle down to making the OOjs ui controls larger? [01:57:36] yes [01:57:47] but they are still smaller than mediawiki ui [01:57:55] mhurd: i dont understand why that size change fixes the tap issue [01:58:05] kaldari: Maybe we can fix that [01:58:12] (03PS2) 10Mhurd: Fix for tap on small images not causing gallery view to appear. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194021 [01:58:33] kaldari: Maybe adjust mw.ui a little to make them both the same size [01:58:53] kaldari: Even though this sounds dirty it might be a better idea than you writing a separate override for oojsui [01:59:11] prtksxna: yeah, I think we might have to do that for now [02:00:06] kaldari: I'll submit a patch then :) [02:00:12] coreyfloyd: quick hangout? [02:00:17] sure [02:02:55] prtksxna: I told nirzar that I’m cool with that if he is [02:03:12] prtksxna: and I know trevor prefers that solution [02:24:39] (03CR) 10Mhurd: "Hey Daniel," [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193079 (https://phabricator.wikimedia.org/T87080) (owner: 10Saltymule) [02:27:34] (03CR) 10Mhurd: Automatically dismiss keyboard on fast scroll when in edit mode. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190960 (owner: 10Rahdev) [02:40:30] (03CR) 10Kaldari: Fixing Table of Contents formatting on mobile (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193540 (https://phabricator.wikimedia.org/T90791) (owner: 10Kaldari) [02:42:30] Deskana|Away: hey sorry i didn’t get the update on the 6+ - i can first thing in the morning [02:43:14] (03CR) 10Fjalapeno: [C: 031] "Spoke to Monte - currently we are conflating the idea of which images to cache and which images should be displayed in the image browser." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194021 (owner: 10Mhurd) [02:44:49] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Image map is not displayed correctly in Image Gallery view - https://phabricator.wikimedia.org/T90294#1080869 (10Mhurd) [02:45:44] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Image map is not displayed correctly in Image Gallery view - https://phabricator.wikimedia.org/T90294#1055567 (10Mhurd) [02:46:20] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Image map is not displayed correctly in Image Gallery view - https://phabricator.wikimedia.org/T90294#1055567 (10Mhurd) [02:50:49] 6Mobile-Web: Revisit box-sizing: border-box for everything in MobileFrontend - https://phabricator.wikimedia.org/T86366#1080872 (10kaldari) a:3kaldari [03:04:57] (03PS1) 10Mhurd: Top of options footer can now scroll to top of screen. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194034 [03:08:11] (03PS2) 10Kaldari: Fixing Table of Contents formatting on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193540 (https://phabricator.wikimedia.org/T90791) [03:12:17] 10Wikipedia-App-Android-App: "This page does not exist" on clickthrough from Google search results. - https://phabricator.wikimedia.org/T89734#1080918 (10dahamsta) Not temporary and not fixed. Also happening on my Huawei Mediapad X1, latest Chrome on 4.4.2. [03:12:53] 10Wikipedia-App-Android-App: "This page does not exist" on clickthrough from Google search results. - https://phabricator.wikimedia.org/T89734#1080919 (10dahamsta) 5Resolved>3Open [04:04:54] (03PS3) 10Bgerstle: uncrustify tweaks [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193992 [04:35:14] 10Wikipedia-App-Android-App: "This page does not exist" on clickthrough from Google search results. - https://phabricator.wikimedia.org/T89734#1081022 (10bearND) @dahamsta What version of the app are you using? Which language did you set the Wikipedia app to? [05:27:28] (03CR) 10Kaldari: [C: 031] "@Bmansurov: I did some work to synchronize the two button styles:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192473 (owner: 10Bmansurov) [05:38:55] kaldari: Around? [05:40:23] 6Mobile-Web, 10TextExtracts: No extract on airports articles - https://phabricator.wikimedia.org/T91367#1081122 (10MaxSem) a:3MaxSem [06:25:34] (03PS1) 10Mhurd: Fix to hide footer on main page. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194055 [06:32:54] (03Abandoned) 10Mhurd: Top of options footer can now scroll to top of screen. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194034 (owner: 10Mhurd) [07:55:59] Hi. Any plans for responsive design for Wikimedia? If so, where can I follow a bug/anything? [08:05:35] dror: The Minerva theme that is used for mobile is technically responsive. I am working on a skin that is forked off vector to be responsive. [08:12:36] (03CR) 10Nemo bis: "Does this require cache purging? See https://phabricator.wikimedia.org/T91372" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/186591 (https://phabricator.wikimedia.org/T87508) (owner: 10Florianschmidtwelzow) [08:16:59] 6Mobile-Web, 6Phabricator, 6Project-Creators: MobileFrontend needs a generic component - https://phabricator.wikimedia.org/T91373#1081272 (10Nemo_bis) 3NEW [08:30:09] prtksxna: Thanks. Where can I follow the progress? [08:30:55] dror: I think https://phabricator.wikimedia.org/project/view/1044/ might be the best place. [08:31:31] Thanks, prtksxna :-) [08:32:11] (03CR) 10MaxSem: "Nope, our cache doesn't live for that long." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/186591 (https://phabricator.wikimedia.org/T87508) (owner: 10Florianschmidtwelzow) [08:40:08] 10MobileFrontend-Feature-requests, 7Varnish: $wgMFAnonymousEditing = true is sometimes not respected: cache? - https://phabricator.wikimedia.org/T91372#1081303 (10Florian) iirc (please correct me @MaxSem if i'm false), our templates are cached (30 days?), so if there are big changes, it would require to purge... [09:11:44] 10MobileFrontend-Feature-requests, 7Varnish: $wgMFAnonymousEditing = true is sometimes not respected: cache? - https://phabricator.wikimedia.org/T91372#1081364 (10MaxSem) No, everything delivered via ResourceLoader will be refreshed in 15 minutes. [09:27:31] 10MobileFrontend-Feature-requests, 7Varnish: $wgMFAnonymousEditing = true is sometimes not respected: cache? - https://phabricator.wikimedia.org/T91372#1081401 (10Florian) Ah, ok, thanks @MaxSem, so i think we can close this task? [10:13:24] yo [10:20:21] * OuKB grumbles at phuedx welcomingly [10:20:45] heh :) [10:20:51] also, sleeeep! [10:22:21] it's 10:22 am here in london :) [10:27:48] 10Wikipedia-App-Android-App: "This page does not exist" on clickthrough from Google search results. - https://phabricator.wikimedia.org/T89734#1081554 (10dahamsta) 2.0-r-2015-01-15 on both devices. The app defaulted to English. I did some further testing this morning. Clearing data for the app didn't help, and... [10:29:47] no, me sleep [11:09:59] 6Mobile-Web, 5Patch-For-Review: The mobile Web wikicode editor loses the user-entered text - https://phabricator.wikimedia.org/T88949#1081587 (10Nnemo) 5Resolved>3Open [11:12:23] 6Mobile-Web, 5Patch-For-Review: The mobile Web wikicode editor loses the user-entered text - https://phabricator.wikimedia.org/T88949#1081590 (10Nnemo) >>! In T88949#1042110, @bmansurov wrote: > @Nnemo, since the editor is constructed on the fly without extra work to save the user's changes, the default browse... [11:13:49] 6Mobile-Web, 5Patch-For-Review: The mobile Web wikicode editor loses the user-entered text - https://phabricator.wikimedia.org/T88949#1081596 (10Aklapper) Should that be handled in a new separate task instead? Just wondering... [11:18:12] 6Mobile-Web, 10MobileFrontend-Feature-requests, 7Design, 5Patch-For-Review: Remove mobile editing "call to registration" CTA - https://phabricator.wikimedia.org/T87508#1081597 (10phuedx) > Sure, it doesn't matter that much. However that would already be the third task created to address the finding that dr... [12:24:03] (03PS3) 10Florianschmidtwelzow: Move Editor Cta to the end of the editing process [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192095 (https://phabricator.wikimedia.org/T87508) [12:26:48] (03CR) 10jenkins-bot: [V: 04-1] Move Editor Cta to the end of the editing process [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192095 (https://phabricator.wikimedia.org/T87508) (owner: 10Florianschmidtwelzow) [12:32:08] (03PS4) 10Florianschmidtwelzow: Move Editor Cta to the end of the editing process [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192095 (https://phabricator.wikimedia.org/T87508) [12:34:46] (03CR) 10Florianschmidtwelzow: Move Editor Cta to the end of the editing process (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192095 (https://phabricator.wikimedia.org/T87508) (owner: 10Florianschmidtwelzow) [12:36:09] (03CR) 10jenkins-bot: [V: 04-1] Move Editor Cta to the end of the editing process [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192095 (https://phabricator.wikimedia.org/T87508) (owner: 10Florianschmidtwelzow) [12:41:24] (03CR) 10Florianschmidtwelzow: "hmm, tests works for me locally and the result in jenkins doesn't look related to this change :(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192095 (https://phabricator.wikimedia.org/T87508) (owner: 10Florianschmidtwelzow) [13:02:08] coffee time! [13:08:09] Deskana|Away: just had this intensely nice experience getting these people at the beach-town I’m staying at on to facebook. [13:08:23] they got a cheap android phone just to get on to facebook and whatsapp so they can be in touch with family members from afar [13:08:26] but they couldn’t actually get on [13:08:45] so I spent the last 2 hours getting several of them online, and they were *so* happy to be able to chat and see pics of their family / friends [13:08:53] that was more fulfilling than figuring out the redis issue [13:33:00] YuviPanda: <3 [13:33:18] it’s also interesting. none of them have an email address [13:35:35] and the only reason they were able to sign up is because facebook supported using phone numbers [13:39:27] (03CR) 10Phuedx: "Minor comments inline." (0311 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [13:39:50] that's super interesting [13:41:25] phuedx: yup, very. [14:01:46] (03CR) 10Phuedx: "Also, if aggregation is in a separate patch then the modifications to ResponseStoreDB and the addition of wikigrok_aggregation.sql shouldn" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [14:54:25] sup1 [14:54:28] back [14:57:47] hey joakino [14:57:50] how was the gym? [15:15:41] hey phuedx, good, getting better at cardio step by step [15:16:42] hah [15:16:44] phuedx: this helps me a lot to keep focused http://tiesto.com/podcasts/#filter (scroll down), otherwise i don't last too much (cardio is boring) [15:16:53] yeah i need to do more cardio stuff [15:23:02] more cycling! [15:24:31] (03CR) 10Jhernandez: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [15:27:56] (03PS11) 10Jhernandez: Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [16:15:36] (03CR) 10Jhernandez: Hijack watchstar behaviour in alpha (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [16:15:50] (03CR) 10Jhernandez: Hijack watchstar behaviour in alpha (035 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [16:16:05] (03CR) 10Jhernandez: Hijack watchstar behaviour in alpha (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [16:16:39] (03CR) 10Jhernandez: Hijack watchstar behaviour in alpha (035 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [16:17:37] (03PS12) 10Jhernandez: Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [16:19:44] (03CR) 10Jhernandez: "I've addresed my own comments (formatting, comments, and browser tests stuff)." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [16:36:06] Deskana: yt? [16:37:35] (03PS13) 10Jhernandez: Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [16:38:36] (03CR) 10Jhernandez: "Fixed resource loader paths (needs the full path for the scripts for some reason)." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [16:45:36] (03CR) 10Bgerstle: [C: 031] "tested yesterday" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194021 (owner: 10Mhurd) [16:48:56] (03CR) 10Fjalapeno: "comments attached - looks good, one logic suggestion and a naming one." (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194055 (owner: 10Mhurd) [16:50:50] (03CR) 10Bgerstle: "just some preliminary comments. please rebase while i find time to review more thoroughly." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193079 (https://phabricator.wikimedia.org/T87080) (owner: 10Saltymule) [16:59:26] (03PS4) 10Bgerstle: uncrustify tweaks [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193992 [17:01:26] (03CR) 10Bgerstle: [C: 031] "all for it, but would suggest we review my uncrustify-related patch before applying the config. not the end of the world if we need to rea" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194011 (owner: 10Fjalapeno) [17:05:04] (03CR) 10Fjalapeno: "I see what you were trying to fix but this is still a bit wonky fighting with Xcode's indenting of blocks." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193992 (owner: 10Bgerstle) [17:06:53] (03CR) 10Bgerstle: "i can try fiddling a bit more, as there's supposedly an "xcode style" block indentation option. that being said, i think this is visually " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193992 (owner: 10Bgerstle) [17:12:52] bgerstle: coreyfloyd would you guys be able to get on a hangout in about an hour? i was hoping that we could review the sprint 52 board and make sure everyone knows what everyone's working on [17:12:53] dbrant: Started https://www.mediawiki.org/w/index.php?title=Wikimedia_Apps/Team/Android/Third_Party_Libraries. Feel free to edit. [17:13:07] dr0ptp4kt: yeah [17:13:19] dr0ptp4kt: yep [17:13:22] bearND: very nice! [17:14:38] (03PS14) 10Jhernandez: Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [17:15:40] (03CR) 10Jhernandez: "Scoped events on the overlay to the .overlay-content" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [17:17:37] dbrant: just did a minor update. Once you're done let me know and I'll send email to mobile-l [17:17:47] (03PS5) 10Fjalapeno: uncrustify tweaks [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193992 (owner: 10Bgerstle) [17:18:15] bgerstle: ^ trying to use those references to fix the block issues - still have one problem i cant fix yet [17:19:10] coreyfloyd: i got close, but like the issue mentioned, there's a problem if there's an "if" in there [17:19:18] let me pull your changes [17:19:36] bgerstle: yeah - but it also said it was fixed as of 0.61 [17:19:43] right :-/ [17:20:04] bgerstle: yeah - maybe there is a conflicting setting somewhere… [17:20:17] coreyfloyd: i initially discovered my first fix when i tried using UncrustifyX, and found it was using 0.60 [17:20:24] and everything seemed to work [17:20:30] so there were some changes to block indentation in 0.61 [17:21:10] coreyfloyd: you can see it in your patch [17:21:26] look at WMFCodingStyle.m:L98 [17:21:34] the NSLog should be indented [17:22:21] fwiw output_tab_size doesn't seem to have any effect [17:22:49] nor does "indent_from_keyword" [17:23:29] the only thing that "works" is indent_oc_block_msg = 0, but that puts it back to the way it was before your patch [17:23:42] by works i mean that the "if" body is properly indented [17:30:44] (03PS15) 10Jhernandez: Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [17:32:56] (03CR) 10Jhernandez: [C: 031] "Adding/removing to the watchlist in the modal will now update the status of the watchstar on the page." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [17:35:20] bgerstle: coreyfloyd : i'm planning to +2 https://gerrit.wikimedia.org/r/#/c/194021/ . any problem with that? i see your +1s, just don't want to cause any further headaches with any code linting that may be running [17:37:21] bearND: added a bit more detail about putting the license in the About activity. Everything else looks good [17:37:51] dbrant: great. Thanks! [17:38:24] (03PS6) 10Dbrant: Dark toolbar with white icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 [17:38:43] coreyfloyd: i think the patch mentioned in that issue doesn't fix the "if" problem [17:39:20] i'm thinking we should go back to my previous patch set (before your amendment) and settle for that [17:41:36] i recognize it's not the "xcode" indentation style, but there are a few things we're doing that aren't exactly xcode's indentation style [17:41:43] (03CR) 10Jhernandez: "Hrmm the browser tests are failing because the watchstar doesn't appear. Maybe timeout issue?" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [17:46:06] bgerstle: I'll take a look again in a bit - just working on some other stuff currently - from what i gathered the issue should be fixed. The last comment in issue 109 says so much: https://github.com/bengardner/uncrustify/issues/109#issuecomment-56281146 And there has been a release since that comment. [17:47:16] coreyfloyd: if you look at the tests (input & output files) they don't have an "if" statement, so it might have slipped through the cracks. i'll leave a comment asking as much [17:55:07] bgerstle: coreyfloyd i rescheduled the meeting to 1345 eastern / 1045 pacific. monte's gonna be in a bit later [17:55:28] dr0ptp4kt: ok - np [17:55:44] dr0ptp4kt: ok [17:56:06] morning joakino :) [17:56:36] hi jdlrobson [17:56:45] i'm having a tea rest [17:57:38] also it is more like good evening here :p [17:59:31] joakino: good :) [17:59:54] joakino: how has your day been? [18:00:38] jdlrobson: ive been catching up on email and been working on https://gerrit.wikimedia.org/r/#/c/193015/ [18:00:58] it seems mergeable to me at this point, unless i've missed something [18:01:34] i don't know why the watchstar browser test does not work :S i've been trying to run the browser tests with firefox and KEEP_OPEN but it just ignores me [18:03:12] seems like: browser_tests + firefox 36 = 💩 [18:04:55] (03PS13) 10Jhernandez: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 [18:05:15] (03PS9) 10Jhernandez: Hygiene: Collection stores as functions & fix docs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 [18:06:43] (03PS10) 10Jhernandez: Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 [18:06:59] (03PS9) 10Phuedx: [WIP] New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 [18:07:01] (03PS1) 10Phuedx: Hygiene: Make the main menu styles less specific [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194150 [18:07:56] i feel like i should have another cup of coffee [18:08:06] but i don't want to run out before the next batch arrives [18:08:09] this is hard [18:08:18] probably the hardest problem i've ever had to solve [18:08:48] (03PS1) 10Fjalapeno: Cache NSDateFormatters Addresses Bug:T91090 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194151 [18:08:50] (03PS7) 10Dbrant: Dark toolbar with white icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 [18:15:48] mm phabricator/gerrit are realy slow for me today - just me? [18:20:33] (03PS9) 10Jhernandez: Api: Adding a new collection with items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 [18:21:10] jdlrobso_: works as usual from here [18:22:45] (03CR) 10Bgerstle: [C: 04-1] "I would prefer PS4, as it didn't expose any indentation bugs. IIRC the only problem was that the resulting indentation of blocks in a mul" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193992 (owner: 10Bgerstle) [18:25:23] (03PS8) 10Dbrant: Dark toolbar with white icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 [18:26:14] Deskana|Away: kristenlans [18:26:16] bah [18:26:51] Deskana|Away: kristenlans it looks like our phab tickets aren't being auto-removed from the "In Review" project. i.e. somebody moves to "ready for signoff" but the patch still shows up as needing review [18:27:19] kristenlans: i manually fixed a couple, but i'll leave https://phabricator.wikimedia.org/T90752 as an example [18:31:24] (03PS2) 10Bgerstle: Fix image map on article view [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193079 (https://phabricator.wikimedia.org/T87080) (owner: 10Saltymule) [18:31:39] (03CR) 10Bgerstle: "rebased, reviewing now" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193079 (https://phabricator.wikimedia.org/T87080) (owner: 10Saltymule) [18:37:42] (03CR) 10jenkins-bot: [V: 04-1] [WIP] New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [18:42:35] hey joakino sorry my wifi is flakey at the moment [18:42:37] not sure why [18:42:53] jdlrobson: did you get any of what i said? [18:42:59] i just got your mail [18:43:06] no irc messages [18:43:10] not sure what's happening :-/ [18:43:33] but yeh last sprint was kinda weird [18:43:51] ebb and flow etc [18:43:52] (03CR) 10Dbrant: "@BearND, comments addressed!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 (owner: 10Dbrant) [18:44:09] joakino: once we've pinned down storage things should speed up [18:44:37] rmoen: you around? [18:44:40] yep [18:44:44] jdlrobson: yep [18:44:55] Dying but I'm around [18:47:35] joakino: sorry.. i don't know what is going on with my home wifi [18:47:45] i just switched to a hotspot that's not mine [18:47:47] hopefully it's bettr [18:48:05] haha [18:48:06] i got no irc messages from you. yeh last sprint was weird - ebb and flow etc [18:48:13] (03PS1) 10Chad: Use SpecialPage's msg() function for proper context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194161 [18:48:42] is rmoen around? [18:48:47] jdlrobson: ive been catching up on email and been working on https://gerrit.wikimedia.org/r/#/c/193015/ [18:48:48] 19:00 joakino [18:48:48] it seems mergeable to me at this point, unless i've missed something [18:48:50] (03CR) 10MaxSem: "@Phuedx," (0311 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [18:49:16] (03PS2) 10Jdlrobson: Hygiene: Use SpecialPage's msg() function for proper context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194161 (owner: 10Chad) [18:49:32] (03CR) 10Jdlrobson: [C: 032] Hygiene: Use SpecialPage's msg() function for proper context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194161 (owner: 10Chad) [18:49:39] jdlrobso_: also the browser tests don't work for me, not sure why (timeout when trying to find #ca_watch) and can't debug because ff36 and the tests don't get along [18:49:41] is jdlrobson around? [18:49:50] joakino: browser tests don't work? [18:49:56] jdlrobso_: on that patch [18:49:58] rmoen: jdlrobso_ is ;-) [18:50:02] jdlrobso_: i can't get them to work [18:50:09] joakino: mm. might be timeout related [18:50:11] what error do you get? [18:50:36] jdlrobso_: timeout 5 seconds on the watchstar when_present [18:50:39] so weird [18:50:46] joakino: are you running in phantom/ [18:50:57] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use SpecialPage's msg() function for proper context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194161 (owner: 10Chad) [18:51:05] jdlrobso_: yes, because firefox doesn't do anything since I updated it to v36 [18:51:15] joakino: mm so we can't debug grumble [18:51:28] * joakino nods [18:51:39] * jdlrobso_ runs in firefox [18:51:39] very anoying [18:51:55] jdlrobso_: which version do you have? [18:52:14] 35.0.1 [18:52:39] jdlrobso_: don't update then [18:53:12] if it works [18:53:29] joakino: i'm getting same issue [18:53:33] but it's because my instance is super slow [18:53:43] try upping the timeout [18:53:44] (03Merged) 10jenkins-bot: Hygiene: Use SpecialPage's msg() function for proper context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194161 (owner: 10Chad) [18:53:51] jdlrobso_: where do we do that? [18:54:24] * jdlrobso_ tries to remind himself [18:55:51] joakino: https://gerrit.wikimedia.org/r/#/c/193015/14..15/resources/ext.gather.watchstar/CollectionsWatchstar.js < not sure about this [18:55:54] dbrant: why was the bounding box around the search view removed? It still could be useful when the toolbar is opaque. [18:56:04] have talked to moiz about how icon makes no sense in the collections world [18:56:30] i think we are gonna change it to something else [18:57:23] jdlrobso_: what's wrong with that? i just paralleled what Watchstar.js does on onToggleStatus (handle the response of the action and update itself) [18:57:28] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] "Doing the honors..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194011 (owner: 10Fjalapeno) [18:57:40] bearND: vibha hates it; and admittedly it's not consistent with other "search" fields in Google apps. (and it was contributing to degrading performance when scrolling with opacity) [18:57:42] nothing wrong. i just think we'll end up killing that code very soon. [18:58:01] dbrant: ah, ok [18:58:50] (03PS9) 10BearND: Dark toolbar with white icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 (owner: 10Dbrant) [18:58:58] (03CR) 10BearND: [C: 032] Dark toolbar with white icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 (owner: 10Dbrant) [18:59:10] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] "Doing the honors..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194021 (owner: 10Mhurd) [18:59:28] jdlrobso_: that's fine :D [18:59:34] joakino: okay increasing timeout [19:00:18] phuedx: can we get "Add the MobileViewBannerImageRepository" merged today? I see it's blocking a bunch of patches which makes me sad :-/ [19:01:02] same with "Alpha: Allow browsing of images in a page on mobile." [19:01:12] 61 days old makes me sad :( [19:03:18] jdlrobso_: rmoen: i'm gonna be heading out soon, its 8pm already [19:03:30] sure. [19:03:31] joakino: understandably [19:03:53] i've rebased the chain of patches and fixed some stuff on those [19:03:53] joakino: anything we should pick up from you today [19:04:04] (03Merged) 10jenkins-bot: Dark toolbar with white icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/192916 (owner: 10Dbrant) [19:04:05] okay hopefully today will be a more productive one [19:04:07] jdlrobso_: let's keep trying to get that chain of patches for the api close to mergeability [19:04:20] cool! [19:04:43] (03PS3) 10Dbrant: [WIP] Single "read next" item at the bottom of articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193974 [19:05:31] jdlrobso_: i'd like to, i don't really see what's stopping it from being merged [19:05:43] it's swapping out one thing for another [19:05:56] i think that changing the way bannerimage works (which i'm in favour of) is way way out of scope for that patch [19:07:10] phuedx: my main issue is that is should probably be on the Page object [19:07:21] since that's essentially api mobile view [19:07:31] but i guess that can be done later [19:07:36] (the whole banner code depresses me) [19:07:37] jdlrobso_: follow on patch if at all [19:07:58] i can't test it right now though - i'm having huge vagrant issues [19:08:05] hopefully bd808 will help me fix them later today [19:08:45] I normally "fix" vagrant issues by obliterating the folder then reinstalling it [19:08:46] ^ that [19:09:52] (03CR) 10Jdlrobson: [C: 031] "Browser tests work fine in chrome with latest MobileFrontend" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [19:09:55] ^ rmoen [19:10:04] Deskana: yeh i've done that too many times [19:10:07] its unsustainable [19:10:14] i end up wasting too much time rebuilding stock content [19:10:20] jdlrobso_: Well, I'm not disagreeing with that ;-) [19:10:23] and it doesn't always work for me [19:10:32] jdlrobso_: i'll look here in a second [19:12:01] jdlrobso_: the banner image shouldn't be a js feature: https://phabricator.wikimedia.org/T90698 [19:12:34] re the where it lives thing [19:12:34] (03CR) 10Jdlrobson: [C: 031] "API is likely to be unstable until the UI becomes more stable, this helps us move things slightly forward. rmoen take a look?" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (owner: 10Jhernandez) [19:12:34] phuedx: clap clap [19:15:22] (03PS14) 10Jdlrobson: Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 [19:16:06] (03PS15) 10Jdlrobson: Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 (https://phabricator.wikimedia.org/T85643) [19:17:30] (03CR) 10jenkins-bot: [V: 04-1] Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 (https://phabricator.wikimedia.org/T85643) (owner: 10Jdlrobson) [19:17:54] (03CR) 10Phuedx: "Is there any way that this could be rebased against master? Or maybe flipping the dependencies round? It might get merged faster." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188622 (https://phabricator.wikimedia.org/T88566) (owner: 10Jdlrobson) [19:19:39] (03PS41) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [19:20:19] (03CR) 10Jdlrobson: [C: 04-1] "See my comment. We need to explain where these numbers come from." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193657 (https://phabricator.wikimedia.org/T91178) (owner: 10Florianschmidtwelzow) [19:24:59] (03CR) 10Jdlrobson: "In theory yes, but I'd rather not and wait it out - the preceding patch should be pretty much ready to go (it's alpha only and so far the " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188622 (https://phabricator.wikimedia.org/T88566) (owner: 10Jdlrobson) [19:25:03] (03PS7) 10Jdlrobson: Hygiene: ImageOverlay should use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188622 (https://phabricator.wikimedia.org/T88566) [19:25:31] mm for some reason i'm being forced into desktop site all the time now on local instance :-/ [19:26:24] (03CR) 10Jdlrobson: [C: 032] Fixing Table of Contents formatting on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193540 (https://phabricator.wikimedia.org/T90791) (owner: 10Kaldari) [19:27:31] (03Merged) 10jenkins-bot: Fixing Table of Contents formatting on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193540 (https://phabricator.wikimedia.org/T90791) (owner: 10Kaldari) [19:28:15] (03CR) 10Jdlrobson: [C: 032] VE: Apply overflow fix on header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193984 (owner: 10TheDJ) [19:29:23] (03Merged) 10jenkins-bot: VE: Apply overflow fix on header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193984 (owner: 10TheDJ) [19:29:43] (03CR) 10Jdlrobson: [C: 04-1] "You'll need to add some css with a FIXME to deal with pages in cache as HTML is cached for 30 days and the mainmenu class will not be pres" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194150 (owner: 10Phuedx) [19:30:35] (03PS8) 10Jdlrobson: TWN: Use own message for terms of use link in license warning (editor and talk) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190831 (owner: 10Florianschmidtwelzow) [19:30:45] (03CR) 10Phuedx: "Thanks for the pro tip @Jdlrobson!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194150 (owner: 10Phuedx) [19:31:48] (03CR) 10Jdlrobson: [C: 031] "Code looks fine haven't tested." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190831 (owner: 10Florianschmidtwelzow) [19:37:46] (03CR) 10Jdlrobson: Hygiene: Collection stores as functions & fix docs (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 (owner: 10Jhernandez) [19:39:18] (03CR) 10Saltymule: "I am trying to find a reference of "clickable elements" in html." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193079 (https://phabricator.wikimedia.org/T87080) (owner: 10Saltymule) [19:39:53] (03CR) 10Robmoen: Add gather db tables and schema update hook (039 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193315 (https://phabricator.wikimedia.org/T91308) (owner: 10Robmoen) [19:40:01] (03CR) 10Robmoen: Add gather db tables and schema update hook (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193315 (https://phabricator.wikimedia.org/T91308) (owner: 10Robmoen) [19:40:13] (03PS3) 10Robmoen: Add gather db tables and schema update hook [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193315 (https://phabricator.wikimedia.org/T91308) [19:40:48] (03CR) 10Phuedx: [C: 04-1] "A few teeny tiny points inline and one potential fatal error." (034 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (owner: 10Jhernandez) [19:40:49] MaxSem: ^ recommendations on table options ? [19:42:19] I pointed ya at the docs:) /*$wgDBTableOptions*/ or something [19:43:29] MaxSem: funny, i also pointed you at the docs in some of my responses ;) [19:43:44] WARWARWAR [19:43:52] haha [19:44:31] also, it currently lacks indices for some stuff you want to do with it [19:45:23] to decide what else is needed, I would recommend you to gather all the current and palusible future queries [19:45:38] pretty sure, some of them will need indexing [19:46:37] (03CR) 10Jdlrobson: "fixing up!" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (owner: 10Jhernandez) [19:46:58] (03CR) 10Robmoen: [C: 032] Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [19:47:25] dr0ptp4kt bgerstle walking the dog back in 30 or so [19:47:58] (03Merged) 10jenkins-bot: Hijack watchstar behaviour in alpha [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193015 (https://phabricator.wikimedia.org/T91294) (owner: 10Jdlrobson) [19:52:12] going for the night folks [19:52:31] sweet dreams phuedx [19:52:51] (03CR) 10MaxSem: [C: 04-1] Add gather db tables and schema update hook (036 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193315 (https://phabricator.wikimedia.org/T91308) (owner: 10Robmoen) [19:52:54] of indexes and class names [19:53:15] and fun! [19:57:38] (03CR) 10Bgerstle: "technically i think you can click on anything if an onclick handler is registered. for example, we're collapsing info boxes into e" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193079 (https://phabricator.wikimedia.org/T87080) (owner: 10Saltymule) [19:58:53] (03CR) 10Bgerstle: "also, feel free to hop onto #wikimedia-mobile on freenode IRC to chat" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193079 (https://phabricator.wikimedia.org/T87080) (owner: 10Saltymule) [20:04:17] FYI dr0ptp4kt mhurd coreyfloyd i'm able to profile the webview in Safari when using the iOS simulator. [20:04:25] so we can use that to measure webview load times [20:05:03] i.e. we can see layout & rendering, JS events, etc. [20:09:47] (03PS4) 10Robmoen: Add gather db tables and schema update hook [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193315 (https://phabricator.wikimedia.org/T91308) [20:09:49] (03CR) 10jenkins-bot: [V: 04-1] Add gather db tables and schema update hook [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193315 (https://phabricator.wikimedia.org/T91308) (owner: 10Robmoen) [20:11:11] (03CR) 10Robmoen: "MaxSem, in regards to predicting the future of queries needed by the gather team, I have no crystal ball. I currently have indexes for g" (036 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193315 (https://phabricator.wikimedia.org/T91308) (owner: 10Robmoen) [20:14:38] (03PS5) 10Robmoen: Add gather db tables and schema update hook [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193315 (https://phabricator.wikimedia.org/T91308) [20:16:00] (03PS4) 10Dbrant: [WIP] Single "read next" item at the bottom of articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193974 [20:16:44] MaxSem: Point me at docs again? I don't see a link [20:17:00] (03PS14) 10Jdlrobson: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [20:17:02] (03CR) 10jenkins-bot: [V: 04-1] Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [20:20:29] (03CR) 10Jdlrobson: Add api action for listing collections of a user (034 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [20:21:16] (03PS15) 10Jdlrobson: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [20:21:28] (03CR) 10Jdlrobson: [C: 031] Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [20:24:15] (03CR) 10Bgerstle: "mw-language-title JS handlers obviated by recent patch" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193079 (https://phabricator.wikimedia.org/T87080) (owner: 10Saltymule) [20:29:16] (03CR) 10Fjalapeno: [C: 031] "My comment was related to pre-existing code" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [20:30:12] bgerstle: you around? [20:30:21] dr0ptp4kt: yeah [20:30:34] bgerstle: able to do a hangout? i'll call if so [20:32:09] sure [20:33:12] bgerstle: calling [20:34:43] (03CR) 10Robmoen: "One small gripe" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [20:37:52] rmoen, https://www.mediawiki.org/wiki/Manual:Database_access#Database_schema [20:38:48] MaxSem: oh so on create table you just want /*$wgDBTableOptions*/; ? [20:38:56] yep [20:39:00] i see [20:40:39] (03PS6) 10Robmoen: Add gather db tables and schema update hook [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193315 (https://phabricator.wikimedia.org/T91308) [20:49:54] (03CR) 10Kaldari: [C: 032] Identifying which extension is complaining about dependency [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/193028 (owner: 10Kaldari) [20:56:06] (03Merged) 10jenkins-bot: Identifying which extension is complaining about dependency [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/193028 (owner: 10Kaldari) [20:56:57] (03PS6) 10Fjalapeno: uncrustify tweaks [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193992 (owner: 10Bgerstle) [20:58:47] (03CR) 10Bgerstle: [C: 031] "q's & comments, but lgtm" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193992 (owner: 10Bgerstle) [21:00:27] (03CR) 10Bgerstle: "block closing brace is off, but meh" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193992 (owner: 10Bgerstle) [21:00:50] (03PS7) 10Fjalapeno: uncrustify tweaks [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193992 (owner: 10Bgerstle) [21:01:08] bgerstle: updated commit message with 2 additional references… [21:02:24] (03CR) 10Anomie: [C: 04-1] "@MaxSem: Thanks for asking me to review this! Too many extensions wind up with rather poor APIs because they don't get good reviews." (0318 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [21:04:15] (03CR) 10Bgerstle: uncrustify tweaks (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193992 (owner: 10Bgerstle) [21:04:57] dr0ptp4kt: hey Adam! [21:05:14] got a mo for a PM? [21:05:19] (03CR) 10Fjalapeno: "comments" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193992 (owner: 10Bgerstle) [21:09:14] coreyfloyd: so you're saying the source code shows more than one oc_block_msg flag can be on at once? [21:10:05] also, have another look at PS4, i'm pretty sure the indenting's ok there (w/ the caveat that it's not xcode style) https://gerrit.wikimedia.org/r/#/c/193992/4/WikipediaUnitTests/WMFCodingStyle.m,cm [21:10:37] are we still trying to get it to xcode style? [21:10:49] AFAICT it's broken due to the "if" thing, which we need to file an issue or PR for [21:11:03] this whole ordeal has me wondering what clang format is like :-( [21:11:19] uncrustify certainly has lots of nice ObjC options, AFAICT clang-format is better suited to CPP [21:12:02] kristenlans: i'm not here [21:12:09] kristenlans: hangout? [21:17:02] hey Saltymule! [21:17:12] Hello brgestle [21:17:40] I won't get to updating that patch until tonight [21:18:04] ok [21:19:04] would you mind if i made some changes? [21:19:11] i'm thinking that instead of manually specifying arbitrary tag names to handle, we should just detect if it has an href attribute. if it does, we can use that instead [21:19:17] s/that/the event.target/ [21:19:18] (03PS5) 10Dbrant: Single "read next" item at the bottom of articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193974 [21:21:01] or rather, fall through to the "handleHref" function you wrote, and if that doesn't recognize anything, fall back on the bridge message [21:21:20] (03PS10) 10Robmoen: Hygiene: Collection stores as functions & fix docs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 (owner: 10Jhernandez) [21:23:18] mhurd: whats the difference between HistoryViewController and PageHistoryViewController [21:23:57] coreyfloyd: history is “Recent” from W menu, page history is from bottom of web view option for “last edited by" [21:24:14] mhurd: [21:24:15] thanks [21:25:32] That sounds pretty good. So that button handler is no longer used at all? [21:30:32] Saltymule: no, we recently merged a patch which filters out the corresponding HTML elements, and we augment the UIWebView w/ native controls to provide the same functionality—along w/ some new features ;-) [21:32:26] mhurd: coreyfloyd right? we're filtering out the mw-language and mw-last-modified button elements w/ your latest changes? [21:32:48] bgerstle: those buttons are gone iirc [21:32:52] bgerstle: now native [21:53:08] (03PS1) 10Dbrant: Update event logging for Read Next. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194201 [22:00:20] (03PS2) 10Fjalapeno: Cache NSDateFormatters Addresses Bug:T91090 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194151 [22:05:45] bgerstle: question - what do you mean by "assets JSON" for this ticket https://phabricator.wikimedia.org/T91088 ? [22:06:10] coreyfloyd: ^ is that date formatter patch ready for review? [22:06:15] mhurd: yeah [22:06:31] coreyfloyd: cool. fetching… [22:06:43] bgerstle: i dont see any JSON in MWKSection - is it in another file? [22:06:52] coreyfloyd: mhurd would know [22:06:57] it's a separate JSON file [22:06:58] thanks [22:07:04] there's a define for it that should point to the path [22:07:12] ASSETS_JSON i believe [22:07:38] not that one… mhurd do you know where this JSON is located? [22:08:12] coreyfloyd: checking... [22:09:04] coreyfloyd: hangout in a couple minutes? [22:09:14] mhurd: sure [22:09:37] Deskana: or someone, can you try loading the image gallery from one of the images on the "india" article? [22:09:41] seems to be slow [22:18:18] (03PS3) 10Bgerstle: Fix image map on article view [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193079 (https://phabricator.wikimedia.org/T87080) (owner: 10Saltymule) [22:18:45] Saltymule: see ^, this seems to maintain the same functionality w/o relying on arbitrary element tags [22:19:08] the drawback is you need to be fairly defense, since almost any event.target can be passed to that method [22:20:08] mhurd: dr0ptp4kt would appreciate a review: https://gerrit.wikimedia.org/r/#/c/193079/ [22:23:00] (03CR) 10Bgerstle: [C: 031] "made some adjustments, need review from others to merge" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193079 (https://phabricator.wikimedia.org/T87080) (owner: 10Saltymule) [22:23:19] (03CR) 10Bgerstle: "Saltymule, please verify that this fixes the original issue and is in line with what you had in mind." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193079 (https://phabricator.wikimedia.org/T87080) (owner: 10Saltymule) [22:25:41] bgerstle: i'm looking [22:25:59] dr0ptp4kt: k, let me know if anything's unclear [22:29:56] Deskana: dbrant ping [22:30:03] i have two problems w/ https://phabricator.wikimedia.org/T90298 [22:30:16] 1) the axes on the graph a black, and so aren't visible in the image gallery [22:30:33] Deskana: can you check w/ vibha on what we should do? should the gallery background be white or black? [22:30:51] bgerstle: i found an image gallery bug - have a sec for quick demo? [22:31:02] mhurd: can you file an issue? in the middle of some other ones [22:31:09] bgerstle: ya sure! [22:31:15] unless it's a show-stopper [22:31:22] bgerstle: not show stopper [22:31:25] k [22:31:26] thanks [22:31:30] bgerstle: np [22:31:37] 2) dbrant what imageinfo fields are you getting license & author data from? [22:31:51] elena's screenshot in the linked issue above shows data, but when i look at the JSON response, i don't see anything: [22:32:11] https://www.irccloud.com/pastebin/oZZ9PZi3/svg+imageinfo+extmetadata [22:32:22] or wait [22:32:25] sorry [22:32:45] that's the wrong metadata blob [22:33:49] in fact, there's no extmetadata for the svg in question [22:33:52] (for the query i'm using) [22:35:34] bgerstle: i checked with dan and the bug i found already has a task [22:35:46] cool [22:35:48] no nevermind :) [22:35:58] dbrant: Deskana here's the query for the svg i'm trying to display: https://en.wikipedia.org/wiki/Special:ApiSandbox#action=query&prop=imageinfo&format=json&iiprop=comment%7Cparsedcomment%7Ccanonicaltitle%7Curl%7Csize%7Cextmetadata&titles=File%3AAccess%20to%20drinking%20water%20in%20third%20world.svg.png [22:37:03] mhurd your phab user icon keeps makign me laugh for some reason [22:37:25] kristenlans: hehe makes me laugh too :) [22:38:01] bgerstle: it's "License" for the license name, and "Artist" for the author. [22:38:20] dbrant: right, but it's ExtMetadata -> License [22:38:21] right? [22:38:27] bgerstle: yep [22:38:53] kristenlans: https://www.youtube.com/watch?v=Dp0Bt2cbcc8 [22:39:08] dbrant: here's another API example [22:39:12] https://en.wikipedia.org/wiki/Special:ApiSandbox#action=query&prop=imageinfo&format=json&iiprop=url%7Cextmetadata&rawcontinue=&titles=File%3AAccess_to_drinking_water_in_third_world.svg.png%7C%20File%3ABay_of_Fundy_High_Tide.jpg [22:39:54] ah ha [22:40:02] if i remove the ".png" from ".svg.png" it works [22:40:10] dbrant: ring any bells? ^ [22:40:17] mhurd hahahOH!OHO!H I feel like I've had conversations like that before! :P [22:40:35] bgerstle: where did you get the title ending with .png? [22:40:44] frooom somewhere [22:40:51] probably some hacky parsing [22:42:04] (03PS2) 10Mhurd: Fix to hide footer on main page. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194055 [22:43:26] coreyfloyd: amended ^ to name the “containerContainer” better :) [22:44:10] dbrant: where do you get your image titles? [22:46:19] bgerstle: checking... [22:46:36] "Fundy High Tide" eh? [22:46:54] fundies on the rise:P [22:47:13] bgerstle: it's straight from the href of the tag that surrounds the image. [22:48:05] dbrant: same here... i think [22:48:09] or wait [22:48:13] j/k [22:48:21] it's parsed from teh img's src [22:48:35] aha, you don't want that [22:50:35] coreyfloyd: did you check https://gerrit.wikimedia.org/r/#/c/194151 on ios 6? …dan’s got my non-lightning cable. [22:51:10] dbrant: indeed i don't, but it's what i've got [22:51:16] unless.. [22:52:02] i do have it! \o/ [22:52:19] i forgot i added it a while ago [22:52:25] oh wow this will actually solve a lot of problems [22:52:40] you're genius dbrant! ;-) [22:52:46] a genius, even [22:53:08] bgerstle: SHIP IT! [22:53:32] bgerstle: find some good stuff? [22:53:48] all in a day's work. [22:53:50] mhurd: yeah [22:53:57] mhurd: i remembered that i added a property to MWKImage for the filePageURL [22:54:13] since we now have access to the enclosing in the createImageRecords... method in ArticleFetcher [22:54:32] (i pre-emptively added it, thinking i would need it for the "link to file page" functionality) [22:54:40] (03CR) 10Mhurd: [C: 031 V: 031] "It works and stuff!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194151 (owner: 10Fjalapeno) [22:55:38] bgerstle feel free to ping Vibha directly on the Phab ticket: https://phabricator.wikimedia.org/T90298 [22:55:53] kristenlans: k [22:55:58] bgerstle: I don't know keenly design are listenign to Phab, but this will be a good test :-) [22:56:06] (03CR) 10Saltymule: [C: 031] "Looks good. However why does _findParent need to be separated out? Is this for testing? Or is it a style choice?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193079 (https://phabricator.wikimedia.org/T87080) (owner: 10Saltymule) [22:56:21] kristenlans: one problem, i don't know her phab name [22:57:23] bgerstle: vibhabamba [22:57:27] say it ten times fast [22:57:52] (03CR) 10Bgerstle: "Saltymule: in theory, yes it could be for testing. but, since we don't have any unit tests (yet!...) it was mostly for style to separate t" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193079 (https://phabricator.wikimedia.org/T87080) (owner: 10Saltymule) [22:58:05] kristenlans: i can't even do it in my head [22:58:41] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: svg images do not display information in Image Gallery view - https://phabricator.wikimedia.org/T90298#1084852 (10BGerstle-WMF) @vibhabamba, what do you think about the black-on-black issue? see how the above graph's axes are visible on android but not iOS. [22:58:51] kristenlans: message sent, now we wait.. [23:00:58] * kristenlans tents fingers [23:01:03] Excellent. [23:01:39] bgerstle: i may be doing something wrong, but your uncrustify tweaks branch doesn’t seem to cause any changes to the codebase when i do a commit… [23:02:52] mhurd i would expect it to at least change WMFImageGalleryViewController.m [23:04:18] bgerstle: do i have to do anything for the config updates to “take” beyond checking out the branch? [23:05:08] mhurd: you'll probably need to run the "uncrustify everything" script [23:05:25] oh, you mean for the new config to apply [23:05:29] bgerstle: i’ve got the git commit hook, which does that i believe.. [23:05:32] no, the new config should be read automatically [23:06:43] hmmm [23:07:44] (03CR) 10Kaldari: [C: 04-1] [WIP] New-ish Special:MobileMenu page (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [23:09:03] (03CR) 10Jdlrobson: "I was disappointed when I locally installed this extension to see that it requires MobileFrontend." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [23:10:14] mhurd: what you're seeing is accurate then, based on the latest patch from coreyfloyd [23:10:56] bgerstle: ah cool. is your patch still needed then? [23:13:18] coreyfloyd: what's the state of the uncrustify tweaks patch? [23:13:25] (03CR) 10Jdlrobson: "* good enough to build the UI on top of and be revisited before productionising." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [23:13:40] it looks like it still has some issues (i.e. the dispatch_async block throws a wrench into all the subsequent indentation) [23:13:50] did you see my previous comments about how it looked in PS4? [23:15:23] bgerstle: mhurd the commit message gives the current state of the patch [23:15:39] coreyfloyd: bgerstle oops my bad [23:15:43] coreyfloyd: which is that what we really want to do (i.e. xcode-style indentation) doesn't seem to work? [23:15:45] it addresses indentation issues, but cannot fix the nested block indentation issue [23:16:51] coreyfloyd: so, here's what i remember [23:16:59] i thought i had it working in PS4: https://gerrit.wikimedia.org/r/#/c/193992/4 [23:17:20] bgerstle: mhurd I was ok with the output… the nested block formatting wasn't ideal, but seemed functional. Basically if you have a nested block, it outdents the block to the left [23:18:13] coreyfloyd: bgerstle sounds ok for now [23:18:19] in essence we're talking about this: [23:18:25] https://www.irccloud.com/pastebin/XSZENub6/v1 [23:18:37] versus this: [23:18:40] https://www.irccloud.com/pastebin/aiieCsga/v2 [23:19:00] v2 has the "outdenting" that coreyfloyd is talking about [23:19:06] v1 doesn't seem to [23:19:53] i see [23:20:01] bgerstle: yeah they both actually outdent - just that the first one only outdents the "dispatch_async" line, while in the second, the body is also outdented [23:20:02] mhurd: these pastebins are working for you, then? [23:20:23] bgerstle: first time. i restarted safari recently… maybe that did it [23:20:23] err rather the the body is outdented, but the async call is not [23:20:36] coreyfloyd: i don't see v1 as outdenting. the dispatch_async and it's block are indented from the enclosing block brace [23:20:54] v2 outdents everything inside the dispatch_async block arg outside the enclosing block [23:21:01] dispatch_async should be 4 spaces in from the previous line [23:21:15] instead it is 4 spaces out from uiview [23:21:19] in v1? [23:21:22] yeah [23:21:37] coreyfloyd: right, so that's the compromise [23:21:56] it's consistent w/ the the block examples (that the block body is indented relative to the body of its enclosing scope) [23:21:58] yeah -my thought was that v2 works in any case where blocks arent nested [23:22:01] bgerstle: coreyfloyd so it won’t quite format like control-i does in xcode… [23:22:14] mhurd: neither of these will [23:22:29] at least i can always control-i pre-commit if i need clarity [23:22:43] mhurd: i actually have ctrl-I re-mapped to the uncrustify plugin [23:22:54] bgerstle: ooh interesting.... [23:23:14] but regarding xcode-style, we could get the blocks to work, but stuff _inside_ the block (e.g. an "if" inside the block) would be messed up [23:23:37] (03CR) 10Dr0ptp4kt: [C: 031 V: 031] "This seems to be working." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193079 (https://phabricator.wikimedia.org/T87080) (owner: 10Saltymule) [23:23:59] dr0ptp4kt: unless you want someone else to look, you can merge it [23:24:28] bgerstle mhurd yeah i thought it was better to not compromise the indenting of the 90% case - a block without nested blocks, to have a slightly better, but still not right indenting in the 10% case, a nested block [23:25:03] mhurd: mind doing the fnal code review on https://gerrit.wikimedia.org/r/193079 ? [23:25:03] right, i guess i don't dislike the way v1 looks [23:25:07] cc bgerstle ^^ [23:25:26] dr0ptp4kt: i already +1'd [23:26:05] dr0ptp4kt: ya [23:26:16] coreyfloyd: IMO i'd rather have consistent indenting across all cases. but if we don't like the way that indenting looks, then we can accept the 90/10 trade-off and try for a fix later [23:26:37] dr0ptp4kt: i’ve been testing it for the last little bit here… almost done [23:26:46] mhurd: dr0ptp4kt you guys weigh in on v1 vs. v2 ^^ and decide [23:26:53] i think coreyfloyd and i have made the case for either [23:27:40] dr0ptp4kt: defer to your judgement on the v1 vs v2 issue so i can finish review on the 193079 [23:27:48] in other news, i don't have enough steam left to do this filePageURL stuff. maybe later tonight or tomorrow [23:28:02] mhurd: blasted, you pre-deferred to me. [23:28:07] haha [23:28:07] dr0ptp4kt: lol [23:28:18] bgerstle: have a good night! relax :) [23:28:36] mhurd: thanks, you too [23:30:02] (03PS1) 10Robmoen: WIP: API: Add items to collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91295) [23:30:38] mhurd: the assetsfile class has both an "array" property and a "dictionary" property… how do you know whether it is safe to use one or the other? [23:35:52] (03PS2) 10Robmoen: WIP: API: Add items to collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91295) [23:36:51] (03CR) 10jenkins-bot: [V: 04-1] WIP: API: Add items to collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91295) (owner: 10Robmoen) [23:41:31] coreyfloyd: bgerstle mhurd v1 will do [23:42:05] dr0ptp4kt: sounds good [23:42:15] (03PS1) 10Jdlrobson: Make watch star work. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194229 [23:42:26] coreyfloyd checking… [23:45:39] mhurd: also - why does the sessionsingleton allow you to set the title seperately. In other words, why doesnt it just infer the article title from the current article? [23:46:22] coreyfloyd: iirc prior knowlege of what was being dealt with was needed. for the dict vs array. [23:48:09] k [23:48:29] coreyfloyd: not sure about the sessionsingleton title… brion may have an answer. it could be cruft? [23:49:08] coreyfloyd: the article is readonly, whereas the title is readwrite… hmmm [23:50:51] coreyfloyd: may have to do with persisting last article across restarts. i know pre-new-data-layer the title and lang (“en”) was persisted [23:50:52] mhurd: thanks - i think i got it [23:51:02] (03PS2) 10Jdlrobson: Make watch star work. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194229 [23:51:54] coreyfloyd: oh yeah, in the title getter and setter in the singleton it’s using NSUserDefaults. [23:51:58] coreyfloyd: ah ok [23:52:43] cool - thanks - needed to make sure i understood what was going on there [23:53:17] (03CR) 10Robmoen: [C: 032] Make watch star work. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194229 (owner: 10Jdlrobson) [23:54:07] coreyfloyd: i see there’s a bit comment in “isCurrentArticleMain” implementation in sessionsingleton… probably worth double checking it. [23:54:14] *big comment* [23:54:16] (03Merged) 10jenkins-bot: Make watch star work. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194229 (owner: 10Jdlrobson) [23:56:00] kristenlans: can't have the Friday meetings right after standup? [23:57:44] bearnd Elena and our room have a conflict, but otherwise it look sliek we could. [23:58:14] kristenlans: bummer [23:58:17] bearnd which meeting are you talkign about actually? :-) [23:58:41] bearnd I can ask Elena if that is a solid meeting, and see what otehr rooms are open [23:59:14] kristenlans: app prioritization and iteration review