[00:05:51] (03PS16) 10Jdlrobson: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [00:06:05] (03PS11) 10Jdlrobson: Hygiene: Collection stores as functions & fix docs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 (owner: 10Jhernandez) [00:06:40] (03CR) 10Jdlrobson: "gonna need a rebase." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 (owner: 10Jhernandez) [00:06:46] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 (owner: 10Jhernandez) [00:07:00] bearnd I emailed elena to ask if she's felxible with the meeting time conflict, and I *think* there's a room available. So could be feasibel :-) [00:08:25] (03CR) 10Jdlrobson: [C: 04-1] "Can you separate out documentation changes? They seem uncontroversial and easy to get merged." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 (owner: 10Jhernandez) [00:09:13] Good night mobiles. [00:09:59] kristenlans: Awesome. Thank you! [00:14:46] (03CR) 10Jdlrobson: [C: 04-1] Api: Adding a new collection with items (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 (owner: 10Jhernandez) [00:38:33] (03PS10) 10Jdlrobson: Api: Adding a new collection with items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 (owner: 10Jhernandez) [00:38:35] (03PS11) 10Jdlrobson: Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 (owner: 10Jhernandez) [00:44:10] (03PS3) 10Jdlrobson: WIP: API: Add items to collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91295) (owner: 10Robmoen) [00:45:13] (03CR) 10jenkins-bot: [V: 04-1] WIP: API: Add items to collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91295) (owner: 10Robmoen) [00:47:59] (03PS4) 10Jdlrobson: WIP: API: Add items to collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [00:49:05] (03CR) 10jenkins-bot: [V: 04-1] WIP: API: Add items to collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [00:49:49] (03CR) 10Jdlrobson: [C: 04-1] "See last comment I think this part of the API should only create the list." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 (owner: 10Jhernandez) [00:51:00] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Design tweaks to page footer - https://phabricator.wikimedia.org/T91472#1085188 (10Deskana) 3NEW a:3Mhurd [00:51:04] mhurd: ^ [00:51:07] (03PS4) 10Mhurd: Fix image map on article view [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193079 (https://phabricator.wikimedia.org/T87080) (owner: 10Saltymule) [00:51:18] (03CR) 10Mhurd: [C: 032 V: 032] Fix image map on article view [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193079 (https://phabricator.wikimedia.org/T87080) (owner: 10Saltymule) [00:52:39] (03PS3) 10Mhurd: Fix to hide footer on main page. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194055 [00:52:58] coreyfloyd: did the changes i made to https://gerrit.wikimedia.org/r/#/c/194055/ look ok for now? [00:53:03] dr0ptp4kt: ^ [00:53:12] (03PS11) 10Jdlrobson: Api: Adding a new collection with items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 (https://phabricator.wikimedia.org/T91298) (owner: 10Jhernandez) [00:53:26] mhurd: looking [00:55:27] dr0ptp4kt: was brian’s uncrustify patch what we were going with (re. that v1 vs v2 business) https://gerrit.wikimedia.org/r/#/c/193992/ [00:55:39] coreyfloyd: ^ [00:56:02] (03CR) 10Fjalapeno: [C: 031] Fix to hide footer on main page. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194055 (owner: 10Mhurd) [00:56:55] dr0ptp4kt: ok to merge corey’s date formatter patch? ( https://gerrit.wikimedia.org/r/#/c/194151/ ) [01:02:22] coreyfloyd: i preferred version 1 from the pastes bgerstle provided. which patchset in https://gerrit.wikimedia.org/r/#/c/193992/ accomplishes that? [01:03:08] mhurd: i'm doing a quick spot check on https://gerrit.wikimedia.org/r/#/c/194055/ [01:03:52] dr0ptp4kt: PS4 does, I don't know if you can merge that specific commit [01:04:54] Finishing dinner be on [01:05:00] In a bit* [01:05:06] (03PS42) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [01:05:45] (03PS43) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [01:05:58] (03PS5) 10Jdlrobson: WIP: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 [01:07:03] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (owner: 10Jdlrobson) [01:07:39] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] "On the iPad simulator, there seems to be a gray line at the bottom of the main page. This doesn't seem to show up on shorter devices. Mind" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194055 (owner: 10Mhurd) [01:07:55] dr0ptp4kt: noted. will fix [01:07:59] ^ mhurd thx [01:09:12] (03PS6) 10Jdlrobson: WIP: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 [01:09:27] dr0ptp4kt: time to review corey’s date formatter? https://gerrit.wikimedia.org/r/#/c/194151/ [01:09:37] mhurd: i'm doing that right now [01:09:41] dr0ptp4kt: :) [01:09:52] dr0ptp4kt: end of day merge push [01:10:14] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (owner: 10Jdlrobson) [01:10:49] (03PS7) 10Jdlrobson: WIP: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 [01:11:47] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (owner: 10Jdlrobson) [01:15:10] (03PS3) 10Dr0ptp4kt: Cache NSDateFormatters Addresses Bug:T91090 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194151 (owner: 10Fjalapeno) [01:16:20] ^ mhurd, i namespaced the category method name. would you please go ahead and +2 if it looks okay? it looked fine to me. like you say, it works n stuff [01:17:31] (03PS4) 10Mhurd: Cache NSDateFormatters Addresses Bug:T91090 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194151 (owner: 10Fjalapeno) [01:19:59] coreyfloyd: mhurd back. i guess adam's gone for the day? [01:22:59] ohai dr0ptp4kt [01:24:09] (03CR) 10Mhurd: [C: 032 V: 032] Cache NSDateFormatters Addresses Bug:T91090 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194151 (owner: 10Fjalapeno) [01:24:17] bgerstle: is the stuff that followed ps4 ok to discard? [01:24:33] dr0ptp4kt: let me double check [01:24:59] bgerstle: if so, could you resubmit ps4 so that it's mergeable by gerrit? you suspected correctly: gerrit doesn't provide an option to merge ps4 as an earlier ps, apparently. [01:25:13] dr0ptp4kt: i'll just amend the patch after rebasing [01:25:22] bgerstle: ok, then have mhurd rebase. i gotta run [01:25:30] bgerstle: coreyfloyd mhurd peace out [01:25:36] later o/ [01:25:46] bgerstle: i mean ask mhurd to +2 at that point, not rebase. you're rebasing! [01:25:49] bgerstle: later [01:30:37] (03PS12) 10Robmoen: Api: Adding a new collection with items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 (owner: 10Jhernandez) [01:30:39] (03PS5) 10Robmoen: API: Add items to collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) [01:30:41] (03PS17) 10Robmoen: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (owner: 10Jhernandez) [01:30:43] (03PS12) 10Robmoen: Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 (owner: 10Jhernandez) [01:30:45] (03PS12) 10Robmoen: Hygiene: Collection stores as functions & fix docs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 (owner: 10Jhernandez) [01:31:29] (03PS8) 10Bgerstle: uncrustify tweaks [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193992 [01:31:41] mhurd: coreyfloyd rebased w/ "v1" style indentation ^ [01:31:54] (03CR) 10jenkins-bot: [V: 04-1] API: Add items to collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [01:31:55] bgerstle: yay! [01:32:09] brb, gotta get some pork outta the oven (slow-cooking for tomorrow) [01:32:22] bgerstle: so patch 8 is good to go? [01:34:22] (03PS6) 10Robmoen: API: Add items to collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) [01:36:42] mhurd i think so [01:36:49] bgerstle: lets merge [01:37:07] mhurd: if you're up for a 1-2 punch, i can submit another patch that re-uncrustifies the app [01:37:14] bgerstle: do it [01:37:17] k [01:37:30] mhurd: do it w/ this one or once you merge? [01:37:41] (03CR) 10Mhurd: [C: 032 V: 032] uncrustify tweaks [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193992 (owner: 10Bgerstle) [01:37:46] gotchya [01:39:44] (03CR) 10Mhurd: "This was merge after consulting with Adam and Brian." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193992 (owner: 10Bgerstle) [01:40:22] bgerstle: ^ ignore that - i just added a note for the record [01:40:28] (03PS1) 10Bgerstle: Uncrustify strikes back—with a vengeance [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194250 [01:40:33] lol [01:40:33] mhurd: ^ [01:40:54] bgerstle: reviewing... [01:42:08] bgerstle: this looks right? https://github.com/montehurd/apps-ios-wikipedia/commit/b99a9558ed0b87fce92159f1f0759e27560b5e4b [01:42:24] yessir [01:42:30] i looked through the diff, looked good to me [01:42:32] bgerstle: gotcha [01:42:33] what i expected [01:43:22] (03CR) 10Mhurd: [C: 032 V: 032] "Follow-up to the uncrustify config change which was just merged." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194250 (owner: 10Bgerstle) [01:43:33] \o/ [01:43:41] woohoo! [01:44:00] mhurd i can send an email for how to re-map your Ctrl-I shortcut to uncrustify (using the xcode plugin) [01:44:03] bgerstle: thanks for the late help!!! [01:44:05] np [01:44:08] just glad to get this done [01:44:10] bgerstle: cool thanks [01:44:13] me too [01:51:44] 10Wikipedia-App-Android-App: IllegalArgumentException: View not attached to window manager causing crashes - https://phabricator.wikimedia.org/T69947#1085309 (10Krenair) 5Resolved>3Open https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8170424 [02:27:54] (03CR) 10Bmansurov: "@kaldari, yes, let's get this merged then. I'll need to remove some test code and we're good to go." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192473 (owner: 10Bmansurov) [02:46:34] (03PS1) 10Bgerstle: add Makefile [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194257 [02:53:10] (03PS1) 10Mhurd: More footer style tweaks from Dan/Vibha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194258 [02:56:21] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Design tweaks to page footer - https://phabricator.wikimedia.org/T91472#1085360 (10Mhurd) [03:10:55] (03CR) 10Kaldari: "@bmansurov: You may want to subscribe to https://phabricator.wikimedia.org/T91473 to follow the one significant issue still remaining." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192473 (owner: 10Bmansurov) [04:02:49] (03CR) 10Mhurd: "Cool! Will test tomorrow." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194257 (owner: 10Bgerstle) [04:13:21] (03PS1) 10BearND: Use designtime layout attributes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194263 [06:03:46] (03PS1) 10Fjalapeno: WIP - performance improvements - lazy loading and caching assets [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194273 [06:03:48] (03CR) 10jenkins-bot: [V: 04-1] WIP - performance improvements - lazy loading and caching assets [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194273 (owner: 10Fjalapeno) [06:08:13] (03PS2) 10Fjalapeno: WIP - performance improvements - lazy loading and caching assets [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194273 [06:09:38] (03CR) 10Fjalapeno: [C: 031] More footer style tweaks from Dan/Vibha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194258 (owner: 10Mhurd) [07:47:05] 6Mobile-Web: Display coordinates in mobile version - https://phabricator.wikimedia.org/T91481#1085486 (10Thgoiter) 3NEW [09:42:35] morning! [09:42:38] hi phuedx [09:46:22] morning joakino [09:46:25] just got here [09:48:54] 43 emails [09:48:56] minimum [09:50:26] phuedx: yep i'm on it [09:50:36] it is horrible [10:33:15] (03CR) 10Jhernandez: "rmoen i don't know what happened in PS17 but you reverted Jon's changes from PS15 and before. I'm ignoring PS17 and fixing stuff from PS15" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (owner: 10Jhernandez) [10:37:04] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] More footer style tweaks from Dan/Vibha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194258 (owner: 10Mhurd) [10:52:50] gonna make a cup of coffee [11:40:12] (03PS18) 10Jhernandez: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) [11:44:17] (03CR) 10Jhernandez: [C: 031] "I've addressed Anomie comments, rebased and fixed it (it wasn't working as PS15)." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [11:44:43] (03CR) 10Jhernandez: Add api action for listing collections of a user (0319 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [11:51:17] (03CR) 10Jhernandez: Hygiene: Collection stores as functions & fix docs (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 (owner: 10Jhernandez) [11:57:48] (03CR) 10Jhernandez: Hygiene: Collection stores as functions & fix docs (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 (owner: 10Jhernandez) [11:58:32] (03PS13) 10Jhernandez: Hygiene: Collection stores as functions & fix docs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 [11:59:33] (03PS14) 10Jhernandez: Hygiene: Collection stores as functions & fix docs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 [12:02:05] (03PS13) 10Jhernandez: Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 [12:12:37] (03CR) 10Jhernandez: "Comments on api design" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 (owner: 10Jhernandez) [12:22:30] (03PS2) 10Phuedx: Hygiene: Make the main menu styles less specific [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194150 [12:22:32] (03PS10) 10Phuedx: [WIP] New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 [12:37:07] (03PS13) 10Jhernandez: Api: Adding a new collection with items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 [12:37:09] (03PS14) 10Jhernandez: Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 [13:07:52] out to gymlunch [13:13:50] have a lovely time [13:30:31] (03PS1) 10Dr0ptp4kt: Add debug menu for crashing app, wire up HockeyApp [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194321 [13:49:24] (03PS2) 10Dr0ptp4kt: Add debug menu for crashing app, wire up HockeyApp [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194321 [14:04:12] (03PS3) 10Dr0ptp4kt: Add debug menu for crashing app, wire up HockeyApp [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194321 [14:28:32] (03CR) 10Dbrant: [C: 032] "very nice!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194263 (owner: 10BearND) [14:31:22] (03Merged) 10jenkins-bot: Use designtime layout attributes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194263 (owner: 10BearND) [14:42:37] (03PS6) 10Dbrant: Single "read next" item at the bottom of articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193974 [14:44:49] (03CR) 10Dr0ptp4kt: "Note: A version that intentionally crashes on use of the Random feature and uses the org.wikimedia.wikipedia.alphahockey bundle ID has bee" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194321 (owner: 10Dr0ptp4kt) [14:45:02] (03PS2) 10Dbrant: Update event logging for Read Next. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194201 [14:50:05] (03PS1) 10Dbrant: Add wordmark to top of left nav menu. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194334 [14:52:38] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Implement HockeyApp - https://phabricator.wikimedia.org/T90659#1088402 (10dr0ptp4kt) a:5BGerstle-WMF>3dr0ptp4kt [14:55:06] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Implement HockeyApp - https://phabricator.wikimedia.org/T90659#1088417 (10dr0ptp4kt) We're currently trialing HockeyApp. I've created an account for my email address plus the organization account with the username+hockeyapp@wikimedia.org version of my email... [14:56:00] (03PS1) 10Phuedx: Highlight matching parts of search results [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194335 [15:10:30] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Adjust mobile.css to Wikibase dom changes - https://phabricator.wikimedia.org/T91398#1088479 (10Lydia_Pintscher) [15:10:44] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Adjust mobile.css to Wikibase dom changes - https://phabricator.wikimedia.org/T91398#1088482 (10Lydia_Pintscher) p:5Triage>3Normal [15:11:59] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: "other languages" layout does not adjust nicely to mobile - https://phabricator.wikimedia.org/T91397#1088493 (10Lydia_Pintscher) [15:12:18] (03PS2) 10Bgerstle: add Makefile [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194257 [15:12:43] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: "other languages" layout does not adjust nicely to mobile - https://phabricator.wikimedia.org/T91397#1081929 (10Lydia_Pintscher) [15:13:17] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: "other languages" layout does not adjust nicely to mobile - https://phabricator.wikimedia.org/T91397#1088503 (10Lydia_Pintscher) p:5Triage>3Normal [15:14:47] coreyfloyd: loving how everything's uncrustified now [15:15:09] the aligned "=" will take a bit getting used to, but everything looks so clean! [15:15:14] one less broken window ;-) [15:25:58] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Mobile-Apps, 7Tracking: Hackathon-able / volunteer-worthy tasks for Mobile Apps - https://phabricator.wikimedia.org/T91510#1088581 (10Dbrant) 3NEW [15:26:35] bgerstle: ha yeah. I'm not sold on the aligned = though. [15:26:53] really? i didn't want it either [15:27:25] coreyfloyd: maybe we should ask the other guys when they come on and we can quickly tweak that [15:27:33] at least THIS tweak will 100% be straightforward [15:27:36] (of course now that i said it...) [15:32:03] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Mobile-Apps, 10Wikimedia-Hackathon-2015: Create Wikipedia Lite app. - https://phabricator.wikimedia.org/T90758#1088612 (10Dbrant) [15:32:05] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Mobile-Apps, 10Wikimedia-Hackathon-2015, 5Patch-For-Review: Add watchlist to app - https://phabricator.wikimedia.org/T76953#1088614 (10Dbrant) [15:32:06] 10Wikipedia-App-iOS-App, 10Wikimedia-Hackathon-2015: Make iOS app Wikidata description editable - https://phabricator.wikimedia.org/T90765#1088613 (10Dbrant) [15:32:07] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Mobile-Apps, 7Tracking: Hackathon-able / volunteer-worthy tasks for Mobile Apps - https://phabricator.wikimedia.org/T91510#1088611 (10Dbrant) [15:33:00] bgerstle: lol [15:38:03] (03CR) 10Bgerstle: "looks good, but confused by the gerrit tag comment and why we're not using HockeyApp's test crash functionality." (034 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194321 (owner: 10Dr0ptp4kt) [15:49:46] 10Wikipedia-App-Android-App: Integrate with Google Now - https://phabricator.wikimedia.org/T91512#1088745 (10Dbrant) 3NEW [15:56:19] 10Wikipedia-App-Android-App: Share a Fact quote should be flipped in RTL context - https://phabricator.wikimedia.org/T86395#1088769 (10Dbrant) 5Open>3Invalid a:3Dbrant No longer using the quote glyph in share-a-fact. [16:00:27] 10Wikipedia-App-Android-App: Tabbed browsing - https://phabricator.wikimedia.org/T69251#1088784 (10Dbrant) [16:02:27] 10Wikipedia-App-Android-App: Integrate with Google Now - https://phabricator.wikimedia.org/T91512#1088792 (10Dbrant) [16:02:28] 10Wikipedia-App-Android-App, 10Wikimania-Hackathon-2015, 10Wikimedia-Hackathon-2015, 7Design: Add an easier and faster way to change the search language - https://phabricator.wikimedia.org/T87154#1088793 (10Dbrant) [16:02:29] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Mobile-Apps, 7Tracking: Hackathon-able / volunteer-worthy tasks for Mobile Apps - https://phabricator.wikimedia.org/T91510#1088791 (10Dbrant) [16:02:30] 10Wikipedia-App-Android-App: GalleryActivity does not animate gifs - https://phabricator.wikimedia.org/T85766#1088794 (10Dbrant) [16:02:31] 10Wikipedia-App-Android-App: Expose search through intent - https://phabricator.wikimedia.org/T88364#1088795 (10Dbrant) [16:24:24] 10Wikipedia-App-iOS-App, 10Wikidata, 10Wikimedia-Hackathon-2015: Make iOS app Wikidata description editable - https://phabricator.wikimedia.org/T90765#1088921 (10Krenair) Since you'd be editing wikidata rather than the local wiki, could there be policy concerns here? [16:27:30] (03CR) 10Anomie: Add api action for listing collections of a user (036 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [16:27:32] (03CR) 10Anomie: "> Since the extension is not deployed on production right now we do not care about rewriting the API/backend - we are just keen to get som" (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [16:27:46] 10Wikipedia-App-iOS-App, 10Wikidata, 10Wikimedia-Hackathon-2015: Make iOS app Wikidata description editable - https://phabricator.wikimedia.org/T90765#1088939 (10hoo) >>! In T90765#1088921, @Krenair wrote: > Since you'd be editing wikidata rather than the local wiki, could there be policy concerns here? The... [16:33:56] (03CR) 10Phuedx: [C: 04-1] Hygiene: Use same saving indication in TalkSectionAdd like in EditorOverlay (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193522 (https://phabricator.wikimedia.org/T91139) (owner: 10Florianschmidtwelzow) [16:37:59] (03Abandoned) 10Phuedx: [WIP] Bear grillz [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/187062 (owner: 10Phuedx) [16:45:43] (03CR) 10BearND: [C: 04-1] "Great idea! It would be better if the wordmark was a bit lighter. Right now it's so dark that it's barely noticeable." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194334 (owner: 10Dbrant) [16:52:28] hallo [16:52:33] i'm back [17:04:14] hi joakino [17:04:20] hi kristenlans [17:04:44] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Mobile-Apps, and 4 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1089065 (10dr0ptp4kt) @BBlack, okay if we model after https://gerrit.wikimedia.org/r/#/c/120617/ ? [17:06:13] prtksxna: A question for you at https://gerrit.wikimedia.org/r/#/c/194155/3//COMMIT_MSG [17:09:36] (03CR) 10Florianschmidtwelzow: [C: 04-1] Hygiene: Use same saving indication in TalkSectionAdd like in EditorOverlay (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193522 (https://phabricator.wikimedia.org/T91139) (owner: 10Florianschmidtwelzow) [17:14:46] coreyfloyd: is your JSON to NSDictionary literal stuff done? [17:14:50] the card is still in "doing" [17:15:12] also, i noticed none of the static date formatters are wrapped in dispatch_once, do you know if we're ever accessing them off the main thread? [17:16:20] (03PS2) 10Florianschmidtwelzow: Hygiene: Use same saving indication in TalkSectionAdd like in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193522 (https://phabricator.wikimedia.org/T91139) [17:20:16] (03PS1) 10Bgerstle: fix for missing image info when URLs have extra path extension [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194355 (https://phabricator.wikimedia.org/T90298) [17:25:37] bgerstle: yeah the json stuff is pretty much done. Oh I guess I need to tag everyone on the review [17:26:28] 10Wikipedia-App-iOS-App: Investigate to what extent app indexing and deep linking are available on iOS - https://phabricator.wikimedia.org/T91520#1089121 (10Deskana) 3NEW a:3Deskana [17:27:25] 10Wikipedia-App-Android-App: Find out why app indexing doesn't seem to be working fully - https://phabricator.wikimedia.org/T91521#1089130 (10Deskana) 3NEW a:3Deskana [17:29:11] coreyfloyd: k [17:29:12] Deskana: ping [17:29:14] bgerstle: thanks for the heads up on nsdateformatter. Forgot that iOS 6 is still not safe for that class. Most of the are UI only, but the one is possibly accessed in the background. I'll check it out. [17:29:35] coreyfloyd: we can either dispatch_once it pre-emptively, or at the very least assert it's on the main thread [17:29:53] what do you mean about iOS 6? [17:30:36] dr0ptp4kt: hey, dropped some comments on your patch [17:30:44] bgerstle: thx [17:30:45] didn't +/- 1 because i was a tad confused [17:30:58] see comments, let me know if you want to hangout real quick [17:31:05] dr0ptp4kt bgerstle here is my patch from yesterday - forgot to tag you: https://gerrit.wikimedia.org/r/#/c/194273/ [17:32:50] (03CR) 10Fjalapeno: "Still working on measuring before an after affects of the change" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194273 (owner: 10Fjalapeno) [17:35:53] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: Cache Assets JSON instead of recreating on each access. - https://phabricator.wikimedia.org/T91088#1089198 (10Fjalapeno) [17:37:54] https://www.youtube.com/watch?v=v9JQsXPd41U :D [17:44:47] 10Wikipedia-App-iOS-App: Audit Image hyperlinks - https://phabricator.wikimedia.org/T91527#1089296 (10Fjalapeno) 3NEW [17:58:36] (03CR) 10Bgerstle: [C: 031] "looks good, but i have some comments/questions about the different asset files" (035 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194273 (owner: 10Fjalapeno) [17:58:43] (03PS2) 10Florianschmidtwelzow: Promote TalkOverlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) [17:58:51] coreyfloyd: hey [17:58:58] bgerstle: yo [17:59:03] (btw do you have FJalapeno setup as a highlight word in IRCCloud?) [17:59:20] probably should, otherwise gerrit updates won't ping you [17:59:21] anyway [17:59:29] bgerstle: yeah [17:59:30] i do [17:59:33] cool [17:59:33] thanks thought [17:59:34] (03CR) 10Florianschmidtwelzow: [C: 04-1] Promote TalkOverlay to stable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [17:59:35] though [17:59:40] so, i think i have an observation about the assets file stuff [17:59:46] i alluded to it in the comments [17:59:55] but, some of the "assets" don't really need the extra abstraction layer [18:00:13] i.e. anything that's not "fetched", i think [18:00:26] (03PS19) 10Jhernandez: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) [18:00:31] i.e. main pages & languages [18:00:35] (03PS3) 10Florianschmidtwelzow: Promote TalkOverlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) [18:01:07] (03CR) 10Jhernandez: Add api action for listing collections of a user (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [18:01:07] what i had thought of when originally discussing this card was that we'd factor those into NSDictionary literals. did you run into something that indicated it wasn't feasible? [18:01:49] (03CR) 10Jhernandez: "Gonna have a look at the xml thingy and see if I can get that out of the way." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [18:01:50] bgerstle: yeah - something we can probably discus as a tech debt cleanup task. [18:02:01] (03CR) 10jenkins-bot: [V: 04-1] Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [18:02:23] bgerstle: oh - i didnt quite get what you meant… but now I do [18:02:45] i.e. get rid of the "MainPages" enum, and create a singleton for that data instead [18:03:14] bgerstle: I thought you meant just make the dictionaries cached in memory - i was confused about the literal part. [18:03:42] (03PS4) 10Dr0ptp4kt: Add debug menu for crashing app, wire up HockeyApp [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194321 [18:03:52] right, i think having it wrapped in the WMFAssetsFile abstraction made it a little unclear [18:03:54] (03CR) 10Anomie: Add api action for listing collections of a user (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [18:04:03] bgerstle: i think the result is the same - but i will look to see if any additional optimizations can be done to make that better [18:04:50] bgerstle: ^^^ updated. are you saying you want me to review https://gerrit.wikimedia.org/r/#/c/194273/ ? [18:04:56] bgerstle: it was funny i just saw "dictionary literal" and thought, "oh they just mean dictionary" [18:05:02] coreyfloyd: for the most part, yes since we're only paying the cost once. but we can skip the both the disk I/O & JSON parsing steps w/o too much effort, i think [18:05:07] coreyfloyd: that question was meant for you on ps 194273, not bgerstle [18:05:18] bgerstle: was hoping you could take another look at https://gerrit.wikimedia.org/r/194321 [18:05:26] (03PS20) 10Jhernandez: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) [18:05:36] (03CR) 10Florianschmidtwelzow: "At the moment i have no running environment for browser tests and can't setup one easily :( Can someone test it locally if browser tests w" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [18:05:44] (03CR) 10Jhernandez: "And fixed a misplaced space on a coment." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [18:05:55] dr0ptp4kt: can we hangout after standup? I have some ideas for other approaches we can use to toggle crash reporting besides bundle ID [18:06:44] bgerstle: yeah, main thing is i think to get this in front of legal and then get stuff out to testflight asap pending their approval [18:07:10] right, i think we can simplify things a bit though [18:07:23] it's not blocking at all, just curious what you think [18:07:41] bgerstle: yeah, let us chat after the standup. word [18:08:18] anyway coreyfloyd there are other things that concern me about the assets file stuff now that i'm looking a bit closer at it, but i think your patch does address the main issue, which is to prevent us from paying that I/O & JSON cost every time we look up a main page [18:09:01] although, it seems like the languages are also fetched... [18:09:28] main pages is the only one that isn't [18:09:41] afaict [18:09:43] maybe it was at some point [18:10:08] bgerstle: hmmm yeah I'll peek around and ask Monte for some background [18:10:47] yeah, just trying to think of easy ways we can simplify this stuff some more [18:11:15] (03CR) 10jenkins-bot: [V: 04-1] Promote TalkOverlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [18:11:46] coreyfloyd: all the assets stuff is OK for now, as you said.. the only other thing i wanted to ask about was the stuff you moved from application:didFinishLaunchingWithOptions: into SessionSingleton [18:11:55] after standup, perhaps [18:13:24] watching https://www.youtube.com/watch?v=jqXqdqUhxy8 [18:14:04] is anyone available to cover for me at the scrum of scrums meeting (10:30)? [18:16:03] is anyone available to cover for me at the scrum of scrums meeting (10:30)? [18:17:23] coreyfloyd: standup? [18:17:29] doh thanks [18:19:10] (03PS16) 10Jdlrobson: Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 (https://phabricator.wikimedia.org/T85643) [18:19:23] (03CR) 10Jdlrobson: "pleassseee someone get this merged. pleassseeeee" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 (https://phabricator.wikimedia.org/T85643) (owner: 10Jdlrobson) [18:21:24] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [18:21:44] (03CR) 10Jdlrobson: "kaldari can you test this?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190831 (owner: 10Florianschmidtwelzow) [18:22:42] jdlrobson: looking at your "image-browsing" feature now :) [18:22:50] thanks FlorianSW|away [18:22:57] how are you? i haven't spoken much since i got back [18:23:01] stuff has been crazy in Gather [18:23:22] (03CR) 10Bmansurov: Hygiene: Make the main menu styles less specific (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194150 (owner: 10Phuedx) [18:23:25] am just reviewing reply to beta [18:23:44] my vagrant is a bit faster now thanks to bd808 [18:24:04] jdlrobson: It will bite you soon :( [18:24:19] I figured out last night that the cache is never invalidated [18:24:45] hhvm wants inotify events to tell it when files change [18:25:00] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Design tweaks to page footer - https://phabricator.wikimedia.org/T91472#1089426 (10KLans_WMF) p:5Triage>3Normal [18:25:04] and nfs mounts don't support inotify [18:26:49] (03CR) 10Bmansurov: [C: 031] "Not sure if underlining is the right way of doing it. Maybe we should change the enclosing h3 font-weight to normal?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194335 (owner: 10Phuedx) [18:26:58] (03CR) 10Jdlrobson: [C: 032] Promote talk answer feature to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189213 (owner: 10Florianschmidtwelzow) [18:27:26] 6Mobile-Web: Issues with replying to talk page topics with ajax spinner - https://phabricator.wikimedia.org/T91531#1089430 (10Jdlrobson) 3NEW [18:27:56] hey joakino so what do we need to sort out before you finish for day [18:27:59] same question to phuedx [18:28:05] bd808: owch [18:28:20] bd808: that would explain the lag. really glad you are making progress with this. Will make rmoen and joakino happy too :) [18:28:27] jdlrobson: i'm trying to get the xml crap working [18:28:32] joakino: why?!!? [18:28:34] seriously [18:28:45] jdlrobson: I haven't given up yet but it's not fun at this point [18:28:47] jdlrobson: i just want merge [18:28:51] we're trying to get something out the door, the fact our api even supports xml is crazy [18:29:43] jdlrobson: crazy but true [18:29:54] (03Merged) 10jenkins-bot: Promote talk answer feature to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/189213 (owner: 10Florianschmidtwelzow) [18:29:56] bd808: i miss my django development days [18:30:00] and bypassing xml support is not nice [18:30:22] I .... do not miss django [18:30:31] especially its ORM [18:30:40] bd808: we're trying to rapidly prototype a new feature for mediawiki but it's proving very tiresome [18:30:44] I can think of other APIs that are more heavily consumed that do not support XML [18:30:49] rapid prototyping doesn't exist in mediawiki :) [18:31:02] no, it doesn't [18:31:13] this is a multi-consumer open source project [18:31:25] coreyfloyd: to be clear: my threading concern wasn't about NSDateFormatter itself (though that's a good point, we should definitely only have one per thread on iOS 6). i was thinking about multiple threads trying to create and set the static date formatter at once [18:31:55] (i also checked, and NSRegularExpression appears to be thread safe too. i made it a static singleton in one of my patches) [18:32:25] jdlrobson: rmoen: kind of got it working [18:32:30] one sec i'll submit soon [18:32:36] bd808: should be easier to rapidly prototype an extension that isn't on production though surely.. [18:32:47] jdlrobson: https://gerrit.wikimedia.org/r/#/c/193083/ [18:32:55] jdlrobson: https://gerrit.wikimedia.org/r/#/c/194150/ [18:33:01] jdlrobson: https://gerrit.wikimedia.org/r/#/c/194335/ [18:33:07] i'm looking for review on those [18:33:09] already on the 2nd one [18:33:16] just checking the caching issue [18:33:22] other than that, i'm synced with bmansurov on new wikigrok campaigns [18:33:26] phuedx: if you can help me get the image viewer off my plate i'd be super happy too [18:33:37] it's making me lose focus every day it stays on gerrit [18:33:39] the alpha image viewer schtuff? [18:33:48] jdlrobson: sure, just don't put reviews on who are concerned with production scale and full user support. Of course that will come home again when you get to a pre-deploy review and may cost you even more time then [18:33:58] *reviewers [18:35:12] bd808: maybe. Right now we're making no progress no :-/ i'd rather go through a pre-deploy review and fix up then [18:35:14] seems cheaper [18:35:22] since backend requirements are pretty simple [18:35:44] coreyfloyd: do you have a link to iOS 6 docs? [18:35:48] phuedx: erroneous new line in main menu patch [18:36:26] jdlrobson: if you don't like the new line then that's fine, you or i can drop it [18:36:33] bgerstle: you looking for thread safety info? [18:36:38] (03CR) 10Florianschmidtwelzow: [C: 04-1] "apart from this it looks good :)" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 (https://phabricator.wikimedia.org/T85643) (owner: 10Jdlrobson) [18:36:44] phuedx: sure thang but apart from that looks good [18:36:48] on NSRegularExpression in iOS 6 [18:36:58] jdlrobson: sec [18:37:02] phuedx: i can fix [18:37:07] sure? [18:37:08] sure! [18:37:32] phuedx: im in the cde already [18:37:33] so i use this: https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/Multithreading/ThreadSafetySummary/ThreadSafetySummary.html [18:37:33] of course [18:37:36] (03PS3) 10Jdlrobson: Hygiene: Make the main menu styles less specific [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194150 (owner: 10Phuedx) [18:37:46] (03CR) 10Jdlrobson: [C: 032] Hygiene: Make the main menu styles less specific [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194150 (owner: 10Phuedx) [18:37:49] id just be wasting your time [18:38:21] (03CR) 10Florianschmidtwelzow: Hygiene: Make the main menu styles less specific (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194150 (owner: 10Phuedx) [18:38:32] phuedx: ok looking at abs [18:39:01] coreyfloyd: found it [18:39:14] bmansurov, FlorianSW|away: please please please raise questions with -1s [18:39:15] you can find old docsets here: https://developer.apple.com/downloads/index.action# [18:39:40] bmansurov, FlorianSW|away: you're both right, minerva-main-menu is far less generic [18:39:43] (03CR) 10Florianschmidtwelzow: [C: 04-2] Hygiene: Make the main menu styles less specific [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194150 (owner: 10Phuedx) [18:39:48] phuedx: some people are sensitive to -'s so ;) [18:39:53] bgerstle: you generally dont need to look at the old docs, they note version differences in the current docs. For example NSDateFormatter calls out the iOS 6 difference: https://developer.apple.com/library/mac/documentation/Cocoa/Reference/Foundation/Classes/NSDateFormatter_Class/ [18:39:57] not -1's [18:40:01] phuedx: yeah, forgot, because on an older ps you can't vote, sorry ::( [18:40:24] phuedx: a -1 doesn't block from merging, or? [18:40:34] coreyfloyd: regardless of iOS version, i'm thinking about calls to +[NSDateFormatter wmf_someDateFormatter] on multiple threads [18:40:34] bgerstle: if you dont see a note about version differences in the current docs you are safe [18:40:41] ah ok [18:40:42] FlorianSW: not sure anything can block from merging [18:40:46] but we all see -1, right? [18:41:03] coreyfloyd: or any static singleton getter [18:41:08] phuedx: yeah, i would change it to -1 after jenkins tests are finished, ok? Just to be sure :) (that was my plan :P) [18:41:10] (ref to my comment above ^) [18:41:13] * phuedx wonders if the submit job will succeed [18:41:40] coreyfloyd: reviewing your patch - wow “displayHTML” was calling isCurrentArticleMain… that means it was opening that lang list file once for *each* section… !?!?!?! [18:41:52] bgerstle: coreyfloyd Deskana dr0ptp4kt dbrant bearND mhurd check email re: meetign in 20 mins :-) [18:41:54] (03CR) 10Bmansurov: [C: 04-1] Four minute abs (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193083 (owner: 10Phuedx) [18:42:45] (03CR) 10Florianschmidtwelzow: [C: 04-1] "See comments on ps2 :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194150 (owner: 10Phuedx) [18:43:19] kristenlans: fyi, I never got an invite for that meeting [18:43:26] (03PS21) 10Jhernandez: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) [18:43:55] thanks both [18:43:55] (03PS4) 10Phuedx: Hygiene: Make the main menu styles less specific [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194150 [18:44:07] jdlrobson: ^ xml support WOHOO lol [18:44:40] (03CR) 10Jhernandez: "Added the xml support with the tag names." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [18:44:42] (03CR) 10Bmansurov: [C: 031] Hygiene: Make the main menu styles less specific [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194150 (owner: 10Phuedx) [18:44:54] phuedx: i always get confused which hook to make use of [18:45:24] https://www.mediawiki.org/wiki/Manual:Hooks/MakeGlobalVariablesScript or onResourceLoaderGetConfigVars [18:45:38] (03CR) 10Jdlrobson: Four minute abs (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193083 (owner: 10Phuedx) [18:46:16] (03CR) 10Jdlrobson: Four minute abs (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193083 (owner: 10Phuedx) [18:46:17] bearnd: awesome! [18:46:20] jdlrobson: if you ever find out, then lmk! [18:46:24] kristenlans: Replied. [18:46:30] phuedx: basically it depends on who you need to load the code for [18:46:37] do we care about anons? [18:46:48] (03CR) 10Florianschmidtwelzow: "i'm sure, that there is a new line at the end of this file, but it hasn't 23 lines :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [18:46:54] bearND: added [18:47:11] phuedx: if you need anons you are probably doing it right. If you don't you should use Skin::getConfigVariables [18:47:39] actually scrap tht [18:47:56] actually don't scrap i'm right :) [18:48:08] getSkinConfigVariables is for things that don't ever change and things that change only for logged in users [18:48:41] kristenlans: sorry about missing standup - i decided just to head into the office. i'm in scrum of scrums now subbing for kaldari, but lemme know if there's anything of note for me from the meeting! [18:48:50] iirc ResourceLoaderGetConfigVars variables are added to the html output, too, so they will be cached for anons, too :) [18:49:45] Maryana: thanks for checking in there are a couple phab tix that I'll ping you on with questions, otherwise nothing urgent :-) [18:50:03] jdlrobson: i guess we should only serve things to anonymous users when we actually need to [18:50:07] so… which hook?! [18:50:31] kristenlans: word. are they in "needs triage" in phab? [18:50:35] i can take a look now.. [18:51:23] phuedx: what do you want to add? [18:51:35] FlorianSW: https://gerrit.wikimedia.org/r/#/c/193083/2/includes/MobileFrontend.hooks.php [18:52:35] jdlrobson, FlorianSW: i think you're right, it's a mobile-specific thing atm, so getSkinConfigVariables for now [18:52:58] Maryana: we moved https://phabricator.wikimedia.org/T91398 and https://phabricator.wikimedia.org/T91300 to backlog. Just wanted to make sure that seems right to you [18:53:31] kristenlans: lgtm. thank you! [18:53:42] phuedx: i wondering, if this is needed for anons? If not, you should check, if the user is logged in before adding it in SkinMinerva::getSkinConfigVariables() [18:54:18] Maryana: cool, that is all then! [18:54:41] phuedx: cool. happy to +2 if you get that in before you leave [18:55:01] FlorianSW: how do i test your TWN patch? [18:55:38] phuedx: on subject of underlining matched search terms [18:55:51] why are we adding an underline to a strong tag? any background to that? [18:55:57] we used to make it bold compared to rest of string [18:56:27] jdlrobson: puh, that was a long way to find out, let my try to remind: You need to set wgRightsPage, wgRightsUrl and wgRightsText in your LocalSettings.php (just text or something). The you need to add a message key, let me look which one... [18:56:41] was that a regression? or has it always been this broken? :) [18:56:52] (have headings always been bold?) [18:57:26] kristenlans: So are we doing it or not? It's your meeting, so it's your final call. [18:57:26] kristenlans: did the meeting get postponed? [18:57:49] (03PS2) 10Jdlrobson: Highlight matching parts of search results [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194335 (owner: 10Phuedx) [18:58:00] jdlrobson: add text to the following message key: mobile-frontend-terms-url [18:58:18] now you should see a Terms of use link in the footer and in editorOverlay/TalkSectionAddOverlay [18:58:18] (03CR) 10Jdlrobson: [C: 032] Highlight matching parts of search results [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194335 (owner: 10Phuedx) [18:58:21] jdlrobson: it may well have been a regression [18:59:01] jdlrobson: maybe should have been replaced with to make it clear what i was trying to say [18:59:43] i don't like the minerva-main-menu class FlorianSW phuedx [19:00:04] (03CR) 10Jdlrobson: Hygiene: Make the main menu styles less specific (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194150 (owner: 10Phuedx) [19:00:07] can we please return to patch set 2 [19:00:25] bgerstle: coreyfloyd Deskana dr0ptp4kt dbrant bearND mhurd: sounds like we shoudl postpone, I guess. Sorry if this is confsuing/disruptive. [19:00:26] (03Merged) 10jenkins-bot: Highlight matching parts of search results [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194335 (owner: 10Phuedx) [19:00:38] Special:MobileMenu is actually available on Vector - although this is not well advertised [19:00:55] http://en.wikipedia.beta.wmflabs.org/wiki/Special:MobileMenu?useskin=vector [19:01:14] kristenlans: no problem! thanks for letting us know [19:01:45] although that said it doesn't actually use the minerva-main-menu class [19:01:48] mmm [19:01:52] kristenlans: Can you also release the room from the invite? [19:02:15] i really hate prefixing stuff. vector doesn't have to do it so why should minerva [19:02:36] vector uses the portal class [19:02:44] not sure if that makes sense here though [19:03:18] jdlrobson: because we're better :D No, joke. I prefer a prefix there, because main-menu seems (in my view) too short and generic :/ [19:03:22] (03CR) 10Jdlrobson: [C: 04-1] "Switch back to main-menu." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194150 (owner: 10Phuedx) [19:03:30] FlorianSW: it's a skin though [19:03:42] Skins are allowed to be generic [19:03:47] i'm gonna leave [19:03:47] you could say same about 'portal' class in vector [19:03:56] joakino: it's not thaaaaat bad ;-) [19:04:02] jdlrobson: see you tomorrow, send me email if you want me to pick something up [19:04:51] joakino: will do [19:04:53] thanks for all your work today! [19:05:05] have a good day everybody! [19:05:19] joakino: bb :) you too [19:05:38] * FlorianSW is wondering, it's dark here, too, so nothing "day" [19:05:42] phuedx: FlorianSW other thing we could do is use the menu tag [19:05:46] and not bother with class [19:05:53] nav rather [19:06:00] (03PS3) 10Phuedx: Four minute abs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193083 [19:06:09] (03CR) 10Phuedx: Four minute abs (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193083 (owner: 10Phuedx) [19:06:17] HTML5 ftw! [19:06:19] jdlrobson: vector portal is the same, yes :/ I would be ok with nav tag :) [19:06:23] :D [19:06:33] wait wait wait [19:06:37] html… 5!? [19:06:40] !! [19:06:43] does opera mini supports html5? [19:06:47] phuedx: we already use HTML5 doctype [19:06:59] http://caniuse.com/#feat=html5semantic [19:07:10] opera mini is fine [19:07:16] just doesn't have main element [19:07:23] ie8 - screw it- there's a javascript shim you can use [19:07:51] ie… 8!? [19:08:06] phuedx: so switch to nav tag? [19:08:10] i guess i'm doing travel requests and not leaving... [19:08:12] i think we shouldn't waste too much time for ie8, minerva is a mobile skin (for now) [19:08:14] joakino: aww [19:09:31] jdlrobson: can you take a look on https://phabricator.wikimedia.org/T66275 in a free minute? phuedx, too :) [19:11:55] (03PS7) 10Dbrant: Single "read next" item at the bottom of articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193974 [19:12:20] FlorianSW: +1 [19:12:26] ie8 is already pretty broken in ie8 anyway [19:15:09] kristenlans: thx. no problem here (i'd be fine either way) [19:15:13] (03PS3) 10Dbrant: Update event logging for Read Next. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194201 [19:15:22] 6Mobile-Web, 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, and 4 others: there should be a comparison of clicks count on interlanguage on different platforms - https://phabricator.wikimedia.org/T78351#1089563 (10DarTar) If this doesn't require new instrumentation I think we can help. I... [19:16:55] (03CR) 10Robmoen: [C: 031] Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [19:17:44] mhurd: question why do we maintain a separate search site from the article site? [19:17:57] 10MobileFrontend-Feature-requests: configuration variable to turn on or off particular footer links (both on desktop and mobile) - https://phabricator.wikimedia.org/T66275#1089578 (10Jdlrobson) The reason for the mobile privacy key is that privacy message on desktop may wish to be more verbose but yes it should... [19:19:36] bgerstle: there? [19:19:51] dr0ptp4kt_: yeah looking at flights to/from lyon :-/ [19:20:08] we can talk now if you want [19:20:26] bgerstle: thx, will hangout call you shortly [19:21:46] 10MobileFrontend-Feature-requests, 7Varnish: $wgMFAnonymousEditing = true is sometimes not respected: cache? - https://phabricator.wikimedia.org/T91372#1089586 (10Jdlrobson) Config variables for anonymous users are baked into the HTML of a page when you use getSkinConfigVariables which will stay cached for 30... [19:22:59] jdlrobson: which ResourceLoader hook? https://phabricator.wikimedia.org/T91372#1089586 [19:23:07] 10MobileFrontend-Feature-requests, 7Varnish: $wgMFAnonymousEditing = true is sometimes not respected: cache? - https://phabricator.wikimedia.org/T91372#1089588 (10Jdlrobson) 22e06675dbd1d2630b0e602c782be35145e8b94d would have been deployed instantly so if you are seeing a decrease it's possible this had a nega... [19:27:20] (03PS5) 10Phuedx: Hygiene: Put the main menu in a nav element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194150 [19:27:30] 10Wikipedia-App-Android-App: Find out why app indexing doesn't seem to be working fully - https://phabricator.wikimedia.org/T91521#1089595 (10Deskana) [19:27:52] 10Wikipedia-App-iOS-App: Investigate to what extent app indexing and deep linking are available on iOS - https://phabricator.wikimedia.org/T91520#1089601 (10Deskana) [19:28:37] (03CR) 10Phuedx: [WIP] New-ish Special:MobileMenu page (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [19:33:02] (03CR) 10Bgerstle: [C: 031] "+1 looks good now that we're using HockeyApp to crash the app manually" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194321 (owner: 10Dr0ptp4kt) [19:33:35] seems we broke mobile switcher on localhost again so i'm being forced to use 127.0.0.1 for dev? [19:35:03] 6Mobile-Web: Section message boxes are hidden - https://phabricator.wikimedia.org/T91536#1089629 (10TheDJ) 3NEW [19:35:51] (03CR) 10Jdlrobson: [C: 032] "Hurray for the future." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194150 (owner: 10Phuedx) [19:37:50] (03Merged) 10jenkins-bot: Hygiene: Put the main menu in a nav element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194150 (owner: 10Phuedx) [19:40:03] 6Mobile-Web, 6WMF-Design-Research: Usability of "This page has some issues" - https://phabricator.wikimedia.org/T91539#1089672 (10TheDJ) 3NEW [19:40:09] (03PS11) 10Phuedx: [WIP] New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 [19:40:13] (03CR) 10Jdlrobson: [C: 04-1] Four minute abs (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193083 (owner: 10Phuedx) [19:40:18] ^ phuedx i can merge after that change [19:40:24] good day/evening/night @all :) [19:42:44] (03PS4) 10Bmansurov: Add ButtonWithSpinner and re-create 'Report an error' button using it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192473 [19:43:00] 10MobileFrontend-Feature-requests, 7Varnish: $wgMFAnonymousEditing = true is sometimes not respected: cache? - https://phabricator.wikimedia.org/T91372#1089698 (10Jdlrobson) https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderGetConfigVars (I think :-)) [19:43:09] night FlorianSW [19:44:19] jdlrobson: an empty array is falsy [19:44:25] sorry, i should be explicit [19:44:28] hahaha [19:44:31] php lolz [19:44:56] js lolz [19:45:04] (03CR) 10Jdlrobson: Alpha: Allow browsing of images in a page on mobile. (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 (https://phabricator.wikimedia.org/T85643) (owner: 10Jdlrobson) [19:45:41] (03PS17) 10Jdlrobson: Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 (https://phabricator.wikimedia.org/T85643) [19:47:01] jdlrobson: does attending the Lyon hackathon, require that we suggest a feature to work on? [19:48:05] (03PS5) 10Dr0ptp4kt: Add debug menu for crashing app, wire up HockeyApp [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194321 [19:48:33] codezee: yeh ideally you need to find someone in the wikimedia staff and pledge to work on something together [19:48:35] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1089713 (10Sumit) Many pages on the wikivoyage project use a banner image of their own using the pagebanner template, I guess here's where the passing of custom pa... [19:48:48] i'm not sure of the exact process for getting travel sponsorship [19:49:12] codezee: https://phabricator.wikimedia.org/T90867 would be a good thing to get involved with [19:49:13] ohh, I did look at that, it says if you find a buddy, chances of a sponsorship are high :) [19:49:41] bgerstle: ^^^^^, updated [19:49:48] (03PS4) 10Phuedx: Four minute abs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193083 [19:50:16] jdlrobson: sure, I'll look into that, presently exploring the wikivoyage banner template to work on... [19:53:08] brb food [19:54:12] gtg [19:54:43] (03CR) 10Bmansurov: [C: 031] Four minute abs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193083 (owner: 10Phuedx) [19:56:00] gonna watch a load of stargate with harry [20:16:14] (03CR) 10Jdlrobson: [C: 032] Four minute abs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193083 (owner: 10Phuedx) [20:17:20] (03Merged) 10jenkins-bot: Four minute abs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193083 (owner: 10Phuedx) [20:24:11] rmoen: yo can you rewrite https://gerrit.wikimedia.org/r/#/c/194225/6 without api changes and error handling [20:24:25] i'm keen to get some smoke and mirrors in whilst we finalise the api server side stuff [20:24:38] we may need to change api parameters but we should describe the service we need [20:24:54] (03PS15) 10Jdlrobson: Hygiene: Collection stores as functions & fix docs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 (owner: 10Jhernandez) [20:25:36] jdlrobson: For sure [20:26:15] rmoen: cool [20:30:50] jdlrobson: i'm going to add error handling, polish it up a bit then rebase it w/o the backend [20:31:05] (03CR) 10Jdlrobson: [C: 032] "On basis it will need to be rewritten anyway. Thanks!" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [20:36:39] dr0ptp4kt: Deskana FYI picking up the next image gallery bug, skipping https://phabricator.wikimedia.org/T90032 (not image gallery related) [20:36:58] mhurd: dr0ptp4kt either of you want to pick that as your next task? ^ [20:36:59] (03Merged) 10jenkins-bot: Add api action for listing collections of a user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193349 (https://phabricator.wikimedia.org/T91440) (owner: 10Jhernandez) [20:39:32] dbrant|food: Deskana ping [20:39:52] i'm looking at https://phabricator.wikimedia.org/T91128 (handling images w/ transparent backgrounds) [20:39:56] bgerstle: Sounds good. [20:39:58] what's the expected behavior here? [20:40:19] if an image has an alpha channel, show a tiled gray background similar to image viewer on desktop? [20:40:53] bgerstle: on Android, we actually force it to be a white background. [20:41:10] so the background of the image gallery in general is white? [20:41:10] bgerstle: more likely than not, it's a mathematical diagram that's intended to be viewed against a white background. [20:41:40] right, but then you're just exchanging the "black on black" problem for the (probably less common) "white on white" problem [20:42:20] bgerstle: yes; but white-on-white is a *lot* less common. [20:42:38] right, i figured that was the easiest workaround, just wanted to make sure you weren't doing something more involved [20:42:54] i noticed desktop has a white/grey checkered background [20:43:27] bgerstle: the default background in the Gallery is actually black, but we force it to white if it's a PNG or SVG. [20:43:41] why the distinction? [20:43:47] not if it's a JPEG? [20:44:40] (as many images seem to be) [20:46:03] bgerstle: when flipping through images, we do a slight 3D transform where the activity background shows through, and a dark background looks better. In the case of JPEGs, we don't explicitly set their background, since they can't have transparency. [20:46:22] oh, i didn't know JPEGs couldn't have an alpha channel [20:46:45] bgerstle: lemme get through the code reviews, and then i'll discuss with mhurd on who's taking that. it may or may not be more efficient for me to work it [20:47:00] ok [20:48:09] bgerstle: I think the JPEG specification technically allows for an alpha channel, but there aren't any encoders that actually use it. [20:49:10] mhurd: would you please do the honors on https://gerrit.wikimedia.org/r/#/c/194321/ ? i updated it based on patch feedback in gerrit plus hangout with bgerstle. i can step you through it if need be. cc coreyfloyd (n.b., it updates the bundle id to have .developer by default to compel the programmer to change it for prod stable builds) [20:49:29] (03PS3) 10Fjalapeno: WIP - performance improvements - lazy loading and caching assets [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194273 [20:49:36] 6Mobile-Web: Search bar suggestions not working on Windows Phone 8.1 - https://phabricator.wikimedia.org/T91421#1090045 (10bmansurov) @AdiPetrescu, thanks for reporting this. Could you please tell us what browser besides Maxthon you're using? Also, information about the browser version would be useful too. Thanks. [20:49:59] dbrant: apparently not, it seems JPEGs can either have a "Y" color space (greyscale) or "YCbCr" http://en.wikipedia.org/wiki/YCbCr [20:50:05] neither of which has an alpha [20:50:08] but still [20:50:33] is the logic `if (image.isJpeg()) { // show black background } else { // show white background }`? [20:51:15] let me see if i can actually download the android app and check this out.. [20:52:18] 6Mobile-Web, 5Patch-For-Review: Formatting of TOC header messed up - https://phabricator.wikimedia.org/T90791#1090055 (10bmansurov) 5Open>3Resolved a:3bmansurov [20:54:17] bgerstle: actually it's `if (isPng() || isSvg()) { // set white background }`. The background is transparent by default (activity background shows through), so no need to do anything for the other case. [20:55:31] do we have a list of the formats we can possibly encounter? [20:55:57] what about GIFs? [20:56:15] they can be transparent too, right? [20:56:33] yep, there are those. And they can be animated, too. [20:56:43] right, i'm not even thinking about the animated part yet :-P [20:56:50] that's something we're working on, as well [20:56:53] but the background would be black [20:57:01] or "transparent" which ends up being black [20:57:51] the chrome looks really weird over a white background, though: https://www.dropbox.com/s/aqpfflkvz54ccg9/svg%20on%20white%20background.png?dl=0 [20:58:10] my android device is still trying to join my wifi [20:58:20] dbrant: would you mind sending me a screen of what it looks like on android? [20:58:27] bgerstle: on Android we have a dark gradient over the top chrome, as well as the bottom. [20:58:54] bgerstle: sure, 1 sec [21:00:21] (03CR) 10Mhurd: "I'd prefer if we use standard secondary menu section/rows rather than separate popup for debug items." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194321 (owner: 10Dr0ptp4kt) [21:00:21] bgerstle: btw, most of the GIFs that I've seen so far on Commons are, in fact, animations. All of the mathematical/engineering diagrams are svg. [21:01:07] k [21:01:34] (03CR) 10Fjalapeno: [C: 031] fix for missing image info when URLs have extra path extension (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194355 (https://phabricator.wikimedia.org/T90298) (owner: 10Bgerstle) [21:01:40] bgerstle: what article is your screenshot from? [21:01:47] Water, sorry [21:01:58] it's in the "politics, law, and crisis" section [21:02:20] (03CR) 10Fjalapeno: "Comments" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194273 (owner: 10Fjalapeno) [21:04:26] bgerstle: http://imgur.com/R9RghQ8 [21:05:14] (03CR) 10Bgerstle: "reply" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194355 (https://phabricator.wikimedia.org/T90298) (owner: 10Bgerstle) [21:05:43] kristenlans: are we still doing backlog grooming? kaldari & moiz are both out :-/ [21:06:11] Ah sorry. Got in a mediawiki editing hole [21:06:19] Maryana ^ [21:06:53] Maryana: erm...I've got some time tomorrow. Want me to try and reschedule? [21:07:36] yeah, hopefully our fearless tech lead will be feeling better by then [21:07:50] moiz is out for the rest of the week for a conference [21:08:11] Maryana: yikes (re: moiz) [21:09:07] (03CR) 10Bmansurov: [C: 032] Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 (https://phabricator.wikimedia.org/T85643) (owner: 10Jdlrobson) [21:09:23] there's just one piece of designy stuff we might need for next sprint, so i think it's ok. we def need kaldari to help estimate the remaining backend stuff, tho [21:10:21] (03Merged) 10jenkins-bot: Alpha: Allow browsing of images in a page on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 (https://phabricator.wikimedia.org/T85643) (owner: 10Jdlrobson) [21:10:35] 6Mobile-Web, 10MobileFrontend-Feature-requests, 5Patch-For-Review: Should be possible to navigate between images on page - https://phabricator.wikimedia.org/T85643#1090143 (10bmansurov) 5Open>3Resolved a:3bmansurov [21:15:11] dbrant: your gradient looks way different from mine [21:15:30] and better on white backgrounds [21:15:52] dbrant do you adjust the size of the bottom bar based on the image description, etc.? [21:16:02] or is the gradient always the same height? [21:16:18] bgerstle: yep, it grows based on the text height [21:16:38] dbrant: is there a minimum height? [21:17:05] 10Wikipedia-App-Android-App: "This page does not exist" on clickthrough from Google search results. - https://phabricator.wikimedia.org/T89734#1090168 (10bearND) Another report of this is in OTRS https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8168412#9690676. [21:17:11] oh well, i'll wait on this one until i talk to vibha [21:17:18] (03CR) 10Jdlrobson: [C: 032] Hygiene: Collection stores as functions & fix docs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 (owner: 10Jhernandez) [21:17:23] there seem to be some design specs i'm missing [21:17:27] (03PS15) 10Jdlrobson: Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 (owner: 10Jhernandez) [21:18:30] (03Merged) 10jenkins-bot: Hygiene: Collection stores as functions & fix docs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193363 (owner: 10Jhernandez) [21:19:06] 6Mobile-Web: Search bar suggestions not working on Windows Phone 8.1 - https://phabricator.wikimedia.org/T91421#1090188 (10AdiPetrescu) Thank you for your quick reaction and sorry for not specifying this important information in the first place... On my Nokia, I use the default Windows Phone browser, which is In... [21:19:29] bgerstle: I have a padding of 32px below the text, and 64px above the text. The color starts from black with 0xB8 opacity (and ends with zero opacity). [21:19:49] k [21:20:10] dbrant: iOS actually has an API to see if an image has an alpha channel. i'm going to try that. maybe android has something similar? [21:20:12] (03CR) 10Mhurd: [C: 031] fix for missing image info when URLs have extra path extension [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194355 (https://phabricator.wikimedia.org/T90298) (owner: 10Bgerstle) [21:20:27] dr0ptp4kt: https://gerrit.wikimedia.org/r/#/c/194355/ looks good [21:21:48] mhurd: okay, i'll do the honors [21:22:32] bgerstle: interesting; worth investigating [21:23:20] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] fix for missing image info when URLs have extra path extension [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194355 (https://phabricator.wikimedia.org/T90298) (owner: 10Bgerstle) [21:24:47] coreyfloyd: how goes it? need me to test any bits? [21:25:10] mhurd: oh yeah - if you want to run through again and see how it works for the home page stuff [21:25:18] and search [21:25:20] coreyfloyd: cool will do [21:25:23] thanks [21:25:38] mhurd: its still wip until i deliver the metrics [21:25:46] mhurd: but the code itself is "done" [21:26:30] coreyfloyd: great! [21:28:50] 10Wikipedia-App-Android-App: Find out why app indexing doesn't seem to be working fully - https://phabricator.wikimedia.org/T91521#1090240 (10bearND) @Deskana Maybe they have turned it off? See some issues reported in T89734. see also my comment from yesterday about Webmaster tools. [21:33:55] Maryana I wonder if we can appropriate the design review slot for story priortization :-/ Since Moiz is out, I suppose it would depend it there's stuff we need to talk abotu with kaity [21:34:29] 10Wikipedia-App-Android-App: Find out why app indexing doesn't seem to be working fully - https://phabricator.wikimedia.org/T91521#1090256 (10Deskana) @bearND According to the Webmaster Tools it's still turned on. So I don't get what's happening at all. Hopefully our contact can shed some light on it. [21:34:58] kristenlans: yeah, i think that would be fine. kaity had one thing to demo/talk about, but it's more future thinking & i don't think it'll take too long [21:35:00] dbrant: hahaha of course, we get the SVG as a rendered PNG [21:35:06] which HAS an alpha channel *facepalm* [21:35:13] right! [21:35:27] Maryana: kristenlans thats fine with me, I could use awhile to prepare prototypes and such too [21:35:40] we can talk about that after a few weeks [21:35:50] sweet, thanks kaity [21:36:15] (03PS8) 10Jdlrobson: Hygiene: ImageOverlay should use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188622 (https://phabricator.wikimedia.org/T88566) [21:36:21] (03CR) 10Jdlrobson: [C: 032] Hygiene: ImageOverlay should use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188622 (https://phabricator.wikimedia.org/T88566) (owner: 10Jdlrobson) [21:36:29] 6Mobile-Web, 5Patch-For-Review: ImageOverlay should use View##events - https://phabricator.wikimedia.org/T88566#1090258 (10Jdlrobson) 5Open>3Resolved [21:36:32] Excellent, thanks kaity. Maryana, I'll send an email to let everyone invovled knwo [21:37:08] awesome sauce [21:37:20] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Use same saving indication in TalkSectionAdd like in EditorOverlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193522 (https://phabricator.wikimedia.org/T91139) (owner: 10Florianschmidtwelzow) [21:37:26] (03Merged) 10jenkins-bot: Hygiene: ImageOverlay should use View##events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/188622 (https://phabricator.wikimedia.org/T88566) (owner: 10Jdlrobson) [21:38:15] coreyfloyd: quick hangout? [21:38:18] (03CR) 10Jdlrobson: [C: 032] Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 (owner: 10Jhernandez) [21:39:18] (03Merged) 10jenkins-bot: Hygiene: Clean up stores\UserPageCollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193365 (owner: 10Jhernandez) [21:46:14] (03CR) 10Mhurd: WIP - performance improvements - lazy loading and caching assets (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194273 (owner: 10Fjalapeno) [21:47:44] bgerstle: coreyfloyd what are your usual workday end times (ET). Trying to figure out when to reschedule our app retro tomorrow (clashes with monthly metrics meeting) [21:48:16] usually try to end between 6-7 [21:52:06] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: 4.0.6.3 Image gallery - images(svg) blurred on the black background - https://phabricator.wikimedia.org/T91128#1090316 (10BGerstle-WMF) Blurriness should be fixed by the patch for T90298, since its caused by us using a lower-resolution image (120x120) from... [21:52:51] bgerstle kewl thx. Looks like 5 ET is gonna make the most sense. coreyfloyd feel free to protest :-) [21:56:34] kristenlans: that is fine for me [21:56:46] mhurd: sorry was on another hangout - back now [21:56:54] mhurd: i can talk now [21:56:57] coreyfloyd: no worry [22:03:01] Maryana: if that h4x0r3d devices doesn't work, lemme know...i can relinquish this nexus one [22:03:45] coreyfloyd: oh did you rebase that patch? [22:03:46] i'm going to spend a few more minutes googling for how to take a screenshot on this bad boy & then give up [22:03:50] dr0ptp4kt: ^ [22:04:08] maxsem kaldari deskana maryana do any of you have any protips for easy ways to move columns around in wiki tables 0_o [22:04:25] AWK? :P [22:04:40] err.. in wikitext or ve? [22:04:47] wait, easy? oh shi.. [22:05:01] Maryana: either [22:05:03] Maryana: yeah, i guess there's always just snap a pic with your iphone [22:05:07] i don't think you can do it in ve yet, but you can just copy-paste into another place, i suppose [22:05:13] dr0ptp4kt: oh! [22:05:15] genius [22:05:40] Maryana: looks like this may be something based on a lifehacker page: https://play.google.com/store/apps/details?id=com.liveov.shotux [22:05:52] or it would be if the camera on my own phone wasn't borked [22:05:53] sigh [22:06:53] Maryana: yeh, cut/paste is great for rows, not so much for columns. Guess I just need to muddle through ;-( [22:07:15] ...and add a VE feature request :D [22:10:47] (03PS4) 10Fjalapeno: WIP - performance improvements - lazy loading and caching assets [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194273 [22:10:51] (03CR) 10jenkins-bot: [V: 04-1] WIP - performance improvements - lazy loading and caching assets [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194273 (owner: 10Fjalapeno) [22:11:37] mhurd: i have to step out for 30 minutes or so - will do the performance stuff and rebase when I return [22:11:46] coreyfloyd: sounds good! [22:14:02] (03PS44) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [22:16:24] (03PS45) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [22:17:13] okay, ^^^ actually seems to work:P [22:19:39] kristenlans: VisualEditor. ;-) [22:21:24] phuedx, still not sleeping? [22:21:28] Deskana: unfortunately the feature I need is in the backlog! https://phabricator.wikimedia.org/T88694 [22:22:43] dr0ptp4kt: https://support.apple.com/en-us/HT201472 [22:25:45] (03CR) 10Jdlrobson: [C: 04-1] "Can you turn this into just an API patch? I've broken out the client side code bits." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [22:28:30] (03PS1) 10Jdlrobson: WIP: Describe API requests for adding/removing items for collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194404 [22:29:34] (03CR) 10jenkins-bot: [V: 04-1] WIP: Describe API requests for adding/removing items for collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194404 (owner: 10Jdlrobson) [22:34:30] (03PS46) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [22:37:50] (03CR) 10Jdlrobson: [C: 04-1] "don't merge - going to be folded into Rob's patch and abandoned." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194404 (owner: 10Jdlrobson) [22:40:47] (03PS6) 10Dr0ptp4kt: Add debug menu for crashing app, wire up HockeyApp [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194321 [22:42:25] ^ mhurd [22:45:14] Deskana: device has wikipedia app on it. what you'll want to do is go to W > More, then scroll down, then tap "Crash". then open the app back up and you'll see the prompt. i'm leaving it charging here on my desk [22:45:25] dr0ptp4kt: Thanks! [22:45:31] dr0ptp4kt: Now get out of here :-p [22:45:36] bgerstle: coreyfloyd i gotta head home. will be back online later. [22:45:53] k [22:46:02] Deskana: thx again [22:50:16] heading out for a walk, bbl [22:53:54] (03PS7) 10Robmoen: Add frontend api for adding items to collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) [22:54:55] (03CR) 10jenkins-bot: [V: 04-1] Add frontend api for adding items to collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [22:55:38] (03PS8) 10Jdlrobson: Add frontend api for adding items to collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [22:56:36] (03PS9) 10Jdlrobson: Add frontend api for adding items to collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [22:59:35] (03CR) 10jenkins-bot: [V: 04-1] Add frontend api for adding items to collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [23:00:47] (03CR) 10Jdlrobson: [C: 04-1] "Rewriting" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 (owner: 10Jhernandez) [23:01:15] tfinc and co.: gettign netwrok errors, will keep trying [23:01:55] kristenlans: can see you but can't hear you [23:04:59] bgerstle: hey would you have a minute to hangout and chat about testing stuffs? [23:05:25] I can hangout but at the dog park [23:05:30] So audio only [23:05:43] bgerstle: hehe may work… [23:05:54] mhurd: k, call if you want [23:06:01] Or call my cell [23:29:24] jdlrobson: Wouldn't https://gerrit.wikimedia.org/r/#/c/194383/ change the radio buttons everywhere? [23:29:40] prtksxna: no only where the mediawiki.ui.radio module is loaded [23:29:51] which only happens when explicitly added or boolean on [23:32:12] (03PS14) 10Jdlrobson: Api: Adding a new collection with items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 (owner: 10Jhernandez) [23:32:13] (03PS1) 10Jdlrobson: Hygiene: Generalise API query in preparation for future work. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194415 [23:32:26] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: 4.0.6.3 Image gallery - images(svg) blurred on the black background - https://phabricator.wikimedia.org/T91128#1090649 (10Mhurd) Also see "Cat" article's "Anatomy" section for the black on black issue. {F55272} {F55270} [23:33:08] (03CR) 10Jdlrobson: [C: 04-1] "I've also split out a hygiene patch to make these changes easier to follow. Hope that's okay." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 (owner: 10Jhernandez) [23:40:44] jdlrobson, ping [23:40:52] hey yurik [23:41:10] hi, want to talk today? [23:41:21] yurik: sure thing. I can grab a room now if you want [23:41:26] sure [23:41:32] ok give me a few minutes to scout out a room [23:41:37] bbiab