[00:00:14] (03PS7) 10Mhurd: Add debug menu for crashing app, wire up HockeyApp [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194321 (owner: 10Dr0ptp4kt) [00:01:38] (03CR) 10Mhurd: [C: 031 V: 031] "Amended to uncrustify and fix a layout issue in the menu (needed to conditionally add the "blank" row)." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194321 (owner: 10Dr0ptp4kt) [00:03:10] mhurd: i'll take a look, and then +2 that if that's okay with you [00:03:18] dr0ptp4kt: ya! [00:22:50] (03PS15) 10Jdlrobson: Api: Adding a new collection with items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 (owner: 10Jhernandez) [00:23:14] (03CR) 10Jdlrobson: [C: 04-1] "See early comment - also Yurik is going to pick this up and take ownership." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 (owner: 10Jhernandez) [00:23:53] (03CR) 10jenkins-bot: [V: 04-1] Api: Adding a new collection with items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193401 (owner: 10Jhernandez) [00:24:12] dr0ptp4kt: Quick question for you. I'm looking at the HockeyApp thing you left for me on the BriPod. Looks good! What exactly is it that we can customise in the dialogue? [00:24:14] dr0ptp4kt: All of the text? [00:24:16] dr0ptp4kt: Could we, for example, put a link to the privacy policy in the text above the buttons? [00:24:41] Deskana: yes, these sorts of things can be done [00:24:58] dr0ptp4kt: Cool. I'll let you know the outcome of the discussion. Thanks! [00:25:47] Deskana: thx [00:27:04] dr0ptp4kt: did it work? [00:28:30] mhurd: yep. about to merge [00:28:36] dr0ptp4kt: cool [00:28:46] Deskana: dr0ptp4kt: BriPod! [00:28:54] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Add debug menu for crashing app, wire up HockeyApp [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194321 (owner: 10Dr0ptp4kt) [00:29:21] dr0ptp4kt: Is this the privacy policy I should show Michelle? http://hockeyapp.net/privacy/ [00:29:33] dr0ptp4kt: MERGE IT! [00:29:36] :) [00:29:50] MERGE SHIPS [00:29:51] wait [00:30:07] Deskana: SHMERGEIT! [00:30:48] aaa [00:30:55] oops [00:32:20] git checkout monte [00:33:05] Deskana: http://hockeyapp.net/terms/ and http://hockeyapp.net/privacy/. the actual code is mit license [00:33:15] dr0ptp4kt: Thank you, sir! [00:34:06] (03PS10) 10Robmoen: Add items to collection frontend api [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) [00:34:08] git remote add monte https://127.0.0.1/internet.git [00:35:08] (03CR) 10jenkins-bot: [V: 04-1] Add items to collection frontend api [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [00:35:31] (03PS8) 10Jdlrobson: WIP: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 [00:35:33] (03PS1) 10Jdlrobson: Add collections interface smoke and mirrors [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194428 [00:36:33] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (owner: 10Jdlrobson) [00:36:38] (03CR) 10jenkins-bot: [V: 04-1] Add collections interface smoke and mirrors [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194428 (owner: 10Jdlrobson) [00:37:41] jdlrobson, what's that first image thing i keep seeing? [00:37:42] mhurd: any patches needing review? i'm thinking to start wrapping up soonish [00:37:58] yurik: so each collection has an PageImage associated with it [00:38:07] at moment it's just the page image of the first item in the collection [00:38:33] in future it could be any of the page images in the list or even any image on wikipedia (but trying to keep things small and focussed right now :-)) [00:39:10] jdlrobson, so this is really just an image that you can get via usual api if you know the first page of the collection? [00:39:17] (yes, slower, but we are doing a prototype here) [00:40:00] correct [00:40:06] it seems there is substantial code dealing with that image, but i don't think its needed for MVP [00:40:29] true dat. We might have jumped the gun there in making things look pretty [00:40:38] feel free to descope for time being if it gets us closer to the bullseye [00:40:48] ok [00:41:14] i will put together a small api doc so that we are on the same page, and will go from there. I don't think it is time to dive into the code just yet [00:42:19] (03PS2) 10Jdlrobson: Add collections interface smoke and mirrors [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194428 [00:42:21] (03PS11) 10Jdlrobson: Add items to collection frontend api [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [00:42:28] yurik: i wrote https://gerrit.wikimedia.org/r/194428 for you [00:42:31] that's all we need right now [00:42:45] ^ rmoen consider fixed up [00:43:19] (03CR) 10jenkins-bot: [V: 04-1] Add collections interface smoke and mirrors [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194428 (owner: 10Jdlrobson) [00:44:34] dr0ptp4kt: No big issues from Michelle. I'll sit down with you briefly tomorrow and we can do the tweaks she wanted and ask for her final signoff. [00:44:41] jdlrobson, you clearly need more - like "get list of pages in the collection" [00:44:53] Deskana: thanks [00:44:54] and - enumerate collections for user [00:45:01] yurik: not right now [00:45:03] that's all done on backend [00:45:11] we will need them soon but not right now [00:45:22] jdlrobson, how would you use it? not sure i understand [00:45:25] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194428 (owner: 10Jdlrobson) [00:45:41] via the special page/ [00:45:41] ? [00:45:46] Well when rendering the lists we are currently backend only so we just tap into the models directly [00:45:47] yeh [00:45:54] got it [00:45:57] bleh [00:46:02] not liking it ) [00:46:07] sure :-) [00:46:09] but agile etc [00:46:10] we will definitely need them but right now the bits that are blocked are those 3 api requests [00:46:17] got it [00:46:20] once we have those the teams going to be a lot happier [00:46:26] we can clean up the shitty backend after [00:46:36] just a bit time constrained right now [00:46:52] true, but if it doesn't fit into the overall model, we will spend tons of time later on fixing both back and frontend [00:47:01] won't take long [00:47:08] just need to wrap my head around the whole thing [00:47:57] yurik: got it :-) [00:48:09] (03CR) 10Robmoen: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194428 (owner: 10Jdlrobson) [00:48:30] Hey yurik: is it Spring yet? 0_o [00:48:55] kristenlans, define "spring" :D [00:49:13] yurik: when I look outside and it isn't snowing [00:49:18] (03PS9) 10Jdlrobson: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) [00:49:52] (03PS10) 10Jdlrobson: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) [00:49:57] (03PS11) 10Jdlrobson: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) [00:50:42] yurik, kristenlans means are you still using Struts? [00:51:18] funny [00:51:38] maxsem you're a real comedian :-| [00:51:52] (03CR) 10jenkins-bot: [V: 04-1] Add items to collection frontend api [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [00:52:28] HAAAR HAAAR [00:52:58] (03PS12) 10Jdlrobson: Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [00:53:27] kristenlans, its not too bad here - st.petersburg is rather nice, a bit rainy [00:53:28] (03CR) 10jenkins-bot: [V: 04-1] Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) (owner: 10Jdlrobson) [00:53:32] (03CR) 10jenkins-bot: [V: 04-1] Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [00:54:17] 10Wikipedia-App-iOS-App: Performance: Excessive calls to hide keyboard when webview scrolls - https://phabricator.wikimedia.org/T91601#1090880 (10MaxSem) [00:55:49] yurik: ah! I was commiserating with you as a felllow snow-bound East (US) coaster, I didn't know you were in St. Petersburg. [00:56:18] kristenlans, hehe, i decided to visit RU for a bit :) [00:56:40] hope you did'nt get snowed in complettelly [00:57:12] eww, SPb in march [00:57:47] 10Wikipedia-App-iOS-App: Performance: Excessive calls to hide keyboard when webview scrolls - https://phabricator.wikimedia.org/T91601#1090884 (10Fjalapeno) Attaching the trace for the fix. All time spent on this work is completely gone. {F55303} [00:59:04] (03PS1) 10Fjalapeno: Improve performance while scrolling by optimizing keyboard hiding. Bug:T91601 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194434 [00:59:48] 10MobileFrontend-Feature-requests: configuration variable to turn on or off particular footer links (both on desktop and mobile) - https://phabricator.wikimedia.org/T66275#1090895 (10Jidanni) Thank you but someone else please make the patch. [01:00:45] (03CR) 10Fjalapeno: "found this while checking performance for another" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194434 (owner: 10Fjalapeno) [01:01:08] 10Wikipedia-App-iOS-App: App menu should be showing if you minimise the app when the menu is collapsed - https://phabricator.wikimedia.org/T91603#1090901 (10Deskana) 3NEW [01:03:56] 10Wikipedia-App-iOS-App: Highlighting text when the menu is collapsed sometimes causes the menu to uncollapse and cancel the text selection - https://phabricator.wikimedia.org/T91605#1090924 (10Deskana) 3NEW [01:04:21] 10Wikipedia-App-iOS-App: Highlighting text when the menu is collapsed sometimes causes the menu to uncollapse and cancel the text selection - https://phabricator.wikimedia.org/T91605#1090932 (10Deskana) @dr0ptp4kt Might be good for you to take a look at this since you've touched this code most recently with your... [01:05:41] (03PS1) 10Bmansurov: Update jscs version [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/194439 [01:05:45] (03PS1) 10Bmansurov: Update jscs version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194440 (https://phabricator.wikimedia.org/T91083) [01:06:25] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194428 (owner: 10Jdlrobson) [01:07:25] (03PS1) 10Robmoen: Add hasMember method to check for title in a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194441 [01:08:04] (03PS2) 10Robmoen: Add hasMember method to check for title in a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194441 [01:08:06] (03PS3) 10Robmoen: Add collections interface smoke and mirrors [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194428 (owner: 10Jdlrobson) [01:08:08] (03PS13) 10Robmoen: Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) [01:09:14] (03CR) 10jenkins-bot: [V: 04-1] Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [01:13:18] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: Cache Assets JSON instead of recreating on each access. - https://phabricator.wikimedia.org/T91088#1090942 (10Fjalapeno) Changes in the patch had the following improvements: Reduced assetsfile dictionary/array access time by 516ms (from 549ms... [01:13:49] mhurd: got the traces up on phab ^ [01:14:02] (03PS3) 10Robmoen: Add hasMember method and collection tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194441 [01:14:12] (03PS4) 10Robmoen: Add collections interface smoke and mirrors [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194428 (owner: 10Jdlrobson) [01:14:18] (03PS14) 10Robmoen: Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) [01:14:19] mhurd: if there are no more issues, that is a clear win. Also filed and fixed another issue - you can see the patch in gerrit [01:14:31] coreyfloyd: for what article? [01:14:31] (03PS12) 10Robmoen: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) (owner: 10Jdlrobson) [01:14:43] uh… [01:15:00] coreyfloyd: oh nevermind. misread it [01:15:13] coreyfloyd: sweet!!!! [01:15:15] mhurd: it was the HMS Bellerophon [01:15:19] lol [01:15:19] if you care [01:15:26] (03CR) 10jenkins-bot: [V: 04-1] Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [01:15:28] (03CR) 10Robmoen: [C: 032] Add collections interface smoke and mirrors [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194428 (owner: 10Jdlrobson) [01:15:31] (03CR) 10jenkins-bot: [V: 04-1] Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) (owner: 10Jdlrobson) [01:15:37] coreyfloyd: so cool! [01:18:25] 10Wikipedia-App-iOS-App, 5Patch-For-Review: Performance: Excessive calls to hide keyboard when webview scrolls - https://phabricator.wikimedia.org/T91601#1090947 (10Fjalapeno) To quantify: previous trace showed over 2600ms spent in hiding the keyboard. The new trace shows 1ms [01:19:00] mhurd ^ that is probabaly a bigger win than the ticket i was working on [01:20:36] coreyfloyd: whoa! no way! double check it on ios 6 :) [01:21:00] mhurd: actually that is what i was running the test on [01:21:12] coreyfloyd: perfect! [01:21:43] coreyfloyd: will test in a minute... [01:21:46] (03PS4) 10Robmoen: Add hasMember method and collection tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194441 [01:22:44] mhurd: also let me know what i should do with that new ticket - since it is fixed, should I just move into the sprint? [01:23:43] coreyfloyd: ya sure [01:24:26] (03PS5) 10Robmoen: Add hasMember method and collection tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194441 [01:25:47] (03PS5) 10Jdlrobson: Add collections interface smoke and mirrors [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194428 [01:25:55] (03CR) 10Jdlrobson: [C: 032] Add collections interface smoke and mirrors [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194428 (owner: 10Jdlrobson) [01:26:11] (03PS15) 10Robmoen: Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) [01:26:41] (03PS6) 10Jdlrobson: Add hasMember method and collection tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194441 (owner: 10Robmoen) [01:26:49] (03CR) 10Jdlrobson: [C: 032] Add hasMember method and collection tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194441 (owner: 10Robmoen) [01:27:03] (03Merged) 10jenkins-bot: Add collections interface smoke and mirrors [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194428 (owner: 10Jdlrobson) [01:27:05] (03PS13) 10Robmoen: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) (owner: 10Jdlrobson) [01:27:17] (03CR) 10jenkins-bot: [V: 04-1] Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [01:27:51] (03Merged) 10jenkins-bot: Add hasMember method and collection tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194441 (owner: 10Robmoen) [01:28:07] (03CR) 10jenkins-bot: [V: 04-1] Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) (owner: 10Jdlrobson) [01:28:08] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Some articles about cities are broken in iOS app beta 4.0.6.3 - https://phabricator.wikimedia.org/T90032#1090972 (10Fjalapeno) a:3Fjalapeno [01:28:51] (03PS14) 10Robmoen: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) (owner: 10Jdlrobson) [01:29:00] (03CR) 10Jdlrobson: [C: 04-1] Add items to collection frontend changes (034 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [01:29:32] jshint on new collections patch rmoen [01:29:48] jdlrobson: just did it ^ [01:29:56] sweet thanks [01:30:02] ya :) [01:30:47] i think you should call it a day now rmoen. You can get https://gerrit.wikimedia.org/r/194225 completed tomorrow [01:30:55] looking at your review [01:31:11] yurik is on the api changes so hopefully we'll have some patches to work off tomorrow to start wiring things up [01:31:15] ok [01:31:33] we're assess during standup tomorrow about what we can do :) [01:31:50] jdlrobson, i was planning to sleep soonish, but hopefully will have something for you soon. Don't expect miracles the very first moment :) [01:32:01] yurik: but you're the messiah! [01:32:20] yes, but that involves bringing food, not working code [01:32:37] (03CR) 10Jdlrobson: [C: 032] "yay." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194440 (https://phabricator.wikimedia.org/T91083) (owner: 10Bmansurov) [01:32:54] yurik: :D [01:32:57] okay i'm calling it a day [01:33:02] LOL [01:33:43] (03Merged) 10jenkins-bot: Update jscs version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194440 (https://phabricator.wikimedia.org/T91083) (owner: 10Bmansurov) [01:34:12] 6Mobile-Web, 5Patch-For-Review: Upgrade jscs version, stop using custom version - https://phabricator.wikimedia.org/T91083#1090977 (10bmansurov) 5Open>3Resolved a:3bmansurov [01:35:22] 6Mobile-Web, 5Patch-For-Review: Upgrade jscs version, stop using custom version - https://phabricator.wikimedia.org/T91083#1090979 (10Jdlrobson) Thanks BMan! :D [02:03:56] 10MobileFrontend-Feature-requests: configuration variable to turn on or off particular footer links (both on desktop and mobile) - https://phabricator.wikimedia.org/T66275#1091035 (10Jdlrobson) @jidanni if you need this urgently I urge you to find someone willing to that would be great otherwise your at the merc... [02:08:47] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1091036 (10Jdlrobson) @wrh2 any ideas from an editors perspective how you would like this to work without templates? Ideally I would imagine an edit button on the... [02:13:01] (03PS5) 10Fjalapeno: Performance improvements - lazy loading and caching assets [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194273 [02:13:03] (03CR) 10jenkins-bot: [V: 04-1] Performance improvements - lazy loading and caching assets [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194273 (owner: 10Fjalapeno) [02:20:21] (03PS6) 10Fjalapeno: WIP - performance improvements - lazy loading and caching assets [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194273 [02:20:43] (03PS7) 10Fjalapeno: Performance improvements - lazy loading and caching assets [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194273 [04:04:52] (03PS1) 10Mhurd: Fix for stretched native header-footer issue. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194450 [04:07:25] (03PS2) 10Mhurd: Fix for stretched native header-footer issue. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194450 [04:09:46] 6Mobile-Web, 10WikiGrok: Don't ever show WikiGrok on disambig pages - https://phabricator.wikimedia.org/T91300#1091163 (10kaldari) You can test for this by checking for the 'disambiguation' page property. [04:10:16] (03PS1) 10Legoktm: Remove Special:UserProfile functionality [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194451 (https://phabricator.wikimedia.org/T85929) [04:14:18] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Wikidata description running off screen, images look 200% wide - https://phabricator.wikimedia.org/T91588#1091187 (10Deskana) p:5Triage>3Normal [04:14:21] mhurd: Nice. :-) [04:14:58] Deskana: thanks! :) note the commit message here: https://gerrit.wikimedia.org/r/#/c/194450/ - it ended up fixing a few other issues for which there may be backlogged cards [04:15:32] mhurd: I don't think there were cards for those but I did have a lot of those in the back of my head. :-) [04:16:09] Deskana: me too! i was so happy to wrangle so many small annoyances with one patch! [04:17:10] (03PS2) 10Alex Monk: Remove Special:UserProfile functionality [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194451 (https://phabricator.wikimedia.org/T85929) (owner: 10Legoktm) [04:39:03] (03CR) 10Mhurd: [C: 031 V: 031] "Great stuff!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194273 (owner: 10Fjalapeno) [04:39:12] coreyfloyd: ^ [04:42:24] (03CR) 10Mhurd: "Testing some more... wow does this seem to speed things up!!!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194273 (owner: 10Fjalapeno) [04:51:19] (03CR) 10Mhurd: [C: 031 V: 031] Improve performance while scrolling by optimizing keyboard hiding. Bug:T91601 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194434 (owner: 10Fjalapeno) [04:53:44] (03CR) 10Mhurd: [C: 031] "This looks fine, but I'll leave it to you guys." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194257 (owner: 10Bgerstle) [04:53:46] (03PS1) 10Legoktm: Avoid array_merge during initialization [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194454 [04:55:25] (03CR) 10Legoktm: "array_merge worked in the other order, so MF would have overridden any already registered special page. Is the code wrong or the comment w" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194454 (owner: 10Legoktm) [04:55:48] (03CR) 10jenkins-bot: [V: 04-1] Avoid array_merge during initialization [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194454 (owner: 10Legoktm) [04:56:57] (03CR) 10Legoktm: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194454 (owner: 10Legoktm) [05:33:51] kaldari: Are there any outstanding tasks that you want me to take a look at? [05:34:27] no, I think I figured out why the darken function in LESS is giving different results than expected though [05:35:03] kaldari: Oh, why? [05:35:10] prtksxna: In Photoshop when you reduce the brightness X% is an absolute reduction, while in LESS it is a relative reduction. [05:35:30] kaldari: Is there a patch that fixes the size of the buttons, or should I add that? [05:35:43] kaldari: Oh ok. That function isn't editable, right? [05:36:07] prtksxna: I don’t think it’s editable, no. [05:36:41] kaldari: I guess we'll go with values then? [05:36:43] prtksxna: I abandoned the patch that fixes the size for MediaWiki UI per Jared… [05:36:52] Its not //that// bad… [05:37:15] prtksxna: He wants OOjs UI to match the design spec [05:37:17] kaldari: Oh? What did he say? Can I read the conversation somewhere? [05:37:38] prtksxna: i.e. 44px tall buttons (at 1em font-size) [05:37:54] kaldari: Oh. Right, ok. Is there a patch for that? [07:33:17] (03CR) 10Florianschmidtwelzow: [C: 04-1] "apart from this: +1 :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194451 (https://phabricator.wikimedia.org/T85929) (owner: 10Legoktm) [07:35:36] 10Wikipedia-App-iOS-App, 15Roadmap, 10Mobile App Sprint 52 - iOS: Production release for iOS Wikipedia app in March (provisional) - https://phabricator.wikimedia.org/T86692#1091326 (10Eloquence) [07:37:50] for some reason, MF/Minerva is really really slow in vagrant [07:41:07] (03PS1) 10Florianschmidtwelzow: Hygiene: Revision::getRawUserText() was depreacted [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194463 [07:42:58] (03PS3) 10Legoktm: Remove Special:UserProfile functionality [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194451 (https://phabricator.wikimedia.org/T85929) [07:43:45] (03CR) 10Legoktm: Remove Special:UserProfile functionality (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194451 (https://phabricator.wikimedia.org/T85929) (owner: 10Legoktm) [07:44:26] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1091344 (10Florian) > as a page property In page_props?? If yes, you need to save it elsewhere, too, page_props are purged with any re-parse :) [07:55:02] (03CR) 10Florianschmidtwelzow: [C: 031] "I would +2 it, but i'm not sure, what mobile-team thinks about it :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194451 (https://phabricator.wikimedia.org/T85929) (owner: 10Legoktm) [08:20:37] 10MobileFrontend-Feature-requests, 7Varnish: $wgMFAnonymousEditing = true is sometimes not respected: cache? - https://phabricator.wikimedia.org/T91372#1091383 (10Nemo_bis) >>! In T91372#1089588, @Jdlrobson wrote: > 22e06675dbd1d2630b0e602c782be35145e8b94d would have been deployed instantly so if you are seein... [08:31:18] 6Mobile-Web: {{Main}} template not appearing in mobile web - https://phabricator.wikimedia.org/T91621#1091499 (10Pine) 3NEW [08:59:52] 6Mobile-Web, 5Patch-For-Review: "Edit without login" button is hidden in editor cta - https://phabricator.wikimedia.org/T88264#1091566 (10Nemo_bis) Between 2015-01-29 and 2015-02-11 the only MobileFrontend SAL item I see is [[https://wikitech.wikimedia.org/wiki/Server_Admin_Log#January_30| 19:27 logmsgbot: phu... [09:09:58] 6Mobile-Web, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), 5Patch-For-Review: Captcha positioning is inconsistent between JavaScript and non-JavaScript users - https://phabricator.wikimedia.org/T85192#1091593 (10Nemo_bis) I noticed 66f62346ae30470412f45c99ece51e... [09:12:08] 6Mobile-Web, 5Patch-For-Review: Hide account benefits in Minerva version of login page - https://phabricator.wikimedia.org/T87257#1091595 (10Nemo_bis) >>! In T87257#1001090, @gerritbot wrote: > Change 185565 merged by jenkins-bot: > Alpha login form tweaks > > [[https://gerrit.wikimedia.org/r/185565]] Did th... [09:17:52] 6Mobile-Web, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), 5Patch-For-Review: Captcha positioning is inconsistent between JavaScript and non-JavaScript users - https://phabricator.wikimedia.org/T85192#1091599 (10Florian) @Nemo_bis: The captcha was added as a hea... [09:22:44] 6Mobile-Web, 10MediaWiki-Categories: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1091611 (10Edokter) 5Resolved>3Open Reopening, because I am not quite happy with its implementation. # There is no `-o-column-count` property; it sho... [09:31:26] morning! [10:06:00] yo [10:06:07] today has already been poop [10:06:30] i don't see how it could get a whole bunch better [10:07:03] *worse [10:07:04] i meant wors [10:07:33] phuedx: You don't want to say that… [10:09:55] prtksxna: 32 "high priority" emails [10:09:58] i spoke way too soon [10:10:07] /o\ [10:10:26] phuedx: You mean Phabricator tasks? [10:10:32] no no [10:10:42] phab skips inbox ;) [10:11:32] hi phuedx prtksxna [10:11:38] joakino: o/ [10:11:38] hi priority emails? [10:11:46] phuedx: So, like, real email? [10:11:49] not hi, but high :S [10:11:59] prtksxna: not a chance ;) [10:12:11] not sure what the criteria are for high priority [10:12:54] phuedx: Gmail "Important"? [10:13:05] sorry "important" [10:13:07] yeah [10:13:32] If google says its important it must be. Mark is all as spam I say! [10:14:43] This would not be accepted in [teampractices] :P [10:17:22] wow phuedx have you seen the Mobile Web Q4 Planning invitation? [10:17:31] is it really 5 hours? lol [10:27:19] joakino: phuedx I’ve had those before. they used to start at 11:30 PM and end at 5am... [10:27:53] YuviPanda: what's that? what do you do in 5 hours [10:28:46] joakino: I forgot. it’s been a while :) [10:28:57] joakino: lots of talking [10:28:58] ok haha [10:29:11] i think its the longest meeting i've ever been invited to [10:29:27] there’s a break in the middle [10:29:33] oh good ;) [10:30:40] haha [10:30:43] thankfully [10:33:42] 6Mobile-Web, 5Patch-For-Review: "Edit without login" button is hidden in editor cta - https://phabricator.wikimedia.org/T88264#1091741 (10phuedx) I've just very quickly verified the behaviour on http://en.wikipedia.org/wiki/Samurai?mobileaction=alpha – including checking that the change is present in the sourc... [10:34:01] 5pm to 10pm for me [10:35:49] phuedx: that’s probably worse because it eats into your dinner [10:36:47] i always have my dinner at work :/ [10:37:10] YuviPanda: i'm pretty happy this landed with that commit message: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/commit/ad45b78aacc6551ac525578c14a31a586d1c24da [10:37:22] phuedx: well done [10:38:38] the goal is to have facebook's planout running across the cluster [10:39:05] i'd like to get together with a front ender and write a flask app to design and run experiments [10:39:17] that'd be a dream project for me [10:40:09] phuedx: wanna do that on a hackathon? [10:40:20] you do the backend and I do the frontend? [10:40:48] we can use tool labs for that :D hah [10:40:51] joakino: sure! that'd be cool! [10:40:56] joakino: +1 exactly what i was thinking [10:42:45] phuedx: wikimedia or wikimania hackathon [11:08:31] joakino: wikimedia [11:11:30] phuedx: i'm going to create a task [11:11:41] you monster [11:12:05] phuedx: where would you host the flask app? :) [11:14:51] phuedx: https://phabricator.wikimedia.org/T91632 feel free to edit whatever [11:16:39] YuviPanda: labby labs? [11:18:31] :D <3 [11:27:01] YuviPanda: phuedx: but is it agile isomorphic webscale? otherwise we won't be able to find any synergies [11:27:29] it's agile as fuck [11:27:59] joakino: that's a very neatly written proposal [11:28:35] sounds like a plan [11:30:07] YuviPanda: this is gonna be my hackathon thingy for wikimania https://phabricator.wikimedia.org/T91633 [11:30:13] (if they actually accept me) [11:32:23] 6Mobile-Web, 10MediaWiki-Categories: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1091834 (10TheDJ) wow, this totally backfired. probably not tested break inside with large categories. https://en.wikipedia.org/w/index.php?title=Categor... [11:33:20] joakino: niiice [11:43:26] joakino: that's awesome! [11:43:32] let's not wait for the hackathon!? [11:47:04] phuedx: needed a link for the google docs, but we can do it when we want [11:47:18] phuedx: I'm a bit tight this days with the gather mvp stuff though [11:48:41] bbiab -- early lunch [11:48:50] george really doesn't like the drilling that's going on right now [12:20:47] (03PS1) 10Jhernandez: WIP: Collection item cards are responsive (tablet) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194498 (https://phabricator.wikimedia.org/T91384) [12:35:07] out gymlunch [12:56:58] backsies [13:32:43] 10MobileFrontend-Feature-requests: Weird first pass picks up function out of what should be unreached code - https://phabricator.wikimedia.org/T91636#1091967 (10Jidanni) 3NEW [13:41:57] (03CR) 10Phuedx: "I think the comment is wrong. After reading I3be80e9d638f9eefb9c84458f788046a8083597f it looks as if we want to replace any registered spe" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194454 (owner: 10Legoktm) [13:56:35] 6Mobile-Web, 10MediaWiki-Categories: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1092019 (10Sumit) Removing "-webkit-column-break-inside:avoid", would cause continuing subcategories to go over to next column, but doing that in the foll... [13:58:13] (03CR) 10Phuedx: [C: 032] Hygiene: Revision::getRawUserText() was depreacted [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194463 (owner: 10Florianschmidtwelzow) [13:59:35] (03Merged) 10jenkins-bot: Hygiene: Revision::getRawUserText() was depreacted [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194463 (owner: 10Florianschmidtwelzow) [14:32:02] (03CR) 10Phuedx: "Some – beautiful – prior art: http://lab.hakim.se/ladda/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192473 (owner: 10Bmansurov) [14:33:17] (03CR) 10Phuedx: [C: 031] "I think that this is mergeable." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192473 (owner: 10Bmansurov) [15:12:36] 6Mobile-Web, 10MediaWiki-Categories, 5Patch-For-Review: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1092169 (10Edokter) @Sumit, What determined the break between columns when tables were used? That same algorith can be used to allow/... [15:16:48] (03PS1) 10Florianschmidtwelzow: Hygiene: Backport fix for useFileCache hook [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/194527 [15:22:02] 6Mobile-Web, 10MediaWiki-Categories, 5Patch-For-Review: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1092192 (10matmarex) It was a pretty lame algorithm that had several bugs filed against it – it just tried to fit the same number of... [15:27:18] 6Mobile-Web, 10MediaWiki-Categories, 5Patch-For-Review: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1092205 (10Sumit) @Edokter, the previous table implementation simply divided the categories into 3 parts, one for each column, and in... [15:31:15] 6Mobile-Web, 5Patch-For-Review: "Edit without login" button is hidden in editor cta - https://phabricator.wikimedia.org/T88264#1092208 (10Nemo_bis) > The change will have gone out on the train since the last date you mentioned, right? I think so, unless I missed something. [15:32:05] 6Mobile-Web: "Edit without login" button is hidden in editor cta - https://phabricator.wikimedia.org/T88264#1092209 (10phuedx) [15:36:08] (03CR) 10Phuedx: "@Jdlrobson: I'd really appreciate your feedback on this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [15:38:56] 6Mobile-Web, 10MediaWiki-Categories, 5Patch-For-Review: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1092243 (10Edokter) In that case, the avoid-break code should be aplied to the individual list items, and not the entire block. [15:40:38] 6Mobile-Web, 10MediaWiki-Categories, 5Patch-For-Review: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1092247 (10Edokter) @MatmaRex, the break-before/inside/after properties enjoy a wider support then columns, so I foresee no problems... [15:41:02] 6Mobile-Web, 10MediaWiki-Categories, 5Patch-For-Review: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1092248 (10matmarex) I'll believe it when I see it. :) [15:41:50] (03CR) 10Fjalapeno: [C: 04-1] "Can we update the read me?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194257 (owner: 10Bgerstle) [15:44:42] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS, 5Patch-For-Review: Performance: Excessive calls to hide keyboard when webview scrolls - https://phabricator.wikimedia.org/T91601#1092254 (10Fjalapeno) [15:45:50] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS, 5Patch-For-Review: Performance: Excessive calls to hide keyboard when webview scrolls - https://phabricator.wikimedia.org/T91601#1092258 (10Fjalapeno) a:3Fjalapeno [15:50:11] 6Mobile-Web, 10MediaWiki-Categories, 5Patch-For-Review: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1092267 (10Edokter) That hurts... :) https://developer.mozilla.org/en-US/docs/Web/CSS/page-break-before https://developer.mozilla.or... [15:52:17] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Cache visited pages in filesystem instead of ram. - https://phabricator.wikimedia.org/T89826#1092271 (10Dbrant) a:3Dbrant [16:10:42] coreyfloyd: I can update the README in a bit, good call [16:28:02] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Article caches are being removed unnecessarily when network connection in lost - https://phabricator.wikimedia.org/T90525#1092374 (10Fjalapeno) a:3Fjalapeno [16:32:09] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Article caches are being removed unnecessarily when network connection in lost - https://phabricator.wikimedia.org/T90525#1092411 (10Fjalapeno) @Monte - yeah we also implemented some of these fixes in later revisions of the original patch: https://gerrit.w... [16:35:40] (03CR) 10Jhernandez: "Some comments. I'll see if I can address them." (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) (owner: 10Jdlrobson) [16:48:40] (03CR) 10Legoktm: "Well, that doesn't really make sense either because core special pages aren't in $wgSpecialPages :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194454 (owner: 10Legoktm) [16:49:07] (03PS2) 10Legoktm: Avoid array_merge during initialization [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194454 [16:57:14] (03PS15) 10Jhernandez: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) (owner: 10Jdlrobson) [17:03:16] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Mobile-Apps, 10Wikimedia-Hackathon-2015: Create Wikipedia Lite app. - https://phabricator.wikimedia.org/T90758#1092563 (10dr0ptp4kt) It has been advised that Wikipedia Lite not be worked on for iOS. I'll remove the tag. For the hackathon, I'm planning... [17:08:58] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Mobile-Apps, 10Wikimedia-Hackathon-2015: Create Wikipedia Lite app. - https://phabricator.wikimedia.org/T90758#1092586 (10dr0ptp4kt) >>! In T90758#1092563, @dr0ptp4kt wrote: > It has been advised that Wikipedia Lite not be worked on for iOS. I'll remov... [17:09:17] 6Mobile-Web, 7Performance: MobileFrontendHooks::onResourceLoaderTestModules is really slow - https://phabricator.wikimedia.org/T91659#1092587 (10Legoktm) 3NEW [17:09:35] (03CR) 10MZMcBride: [C: 031] "I added Jdlrobson, Kaldari, and MaxSem as reviewers. I'd pushed for a separate extension, but I'm equally fine with this option. I'm not s" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194451 (https://phabricator.wikimedia.org/T85929) (owner: 10Legoktm) [17:09:40] 10Wikipedia-App-iOS-App, 10Wikimedia-Hackathon-2015: [Wikimedia Hackathon 2015] Wikipedia Radio (or "Wiki Radio" if not part of the official brand umbrella) for iOS - https://phabricator.wikimedia.org/T91658#1092594 (10Aklapper) [17:21:01] (03PS16) 10Jhernandez: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) (owner: 10Jdlrobson) [17:21:20] (03CR) 10Jhernandez: Add new collection (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) (owner: 10Jdlrobson) [17:21:40] (03CR) 10Phuedx: [C: 032] Avoid array_merge during initialization [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194454 (owner: 10Legoktm) [17:22:47] (03CR) 10Jhernandez: [C: 04-1] "I've fixed what I could in the browser tests but I'm getting timeout errors :( (even changing the when_present to when_present(30)). Not s" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) (owner: 10Jdlrobson) [17:23:32] (03CR) 10Phuedx: [C: 032] Hygiene: Backport fix for useFileCache hook [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/194527 (owner: 10Florianschmidtwelzow) [17:27:17] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: TOC setup on background thread to free main thread for article render. - https://phabricator.wikimedia.org/T91330#1092661 (10Fjalapeno) Monte - how you looking on this ticket? Asking because the dependent tasks in the Todo column are bubbling to the top. [17:27:17] coreyfloyd: any hints on what you think should be in the README regarding the Makefile? [17:27:22] i.e. which tasks there are? [17:27:52] I think the stuff you have in the commit message is a good start [17:27:56] bgerstle: ^ [17:28:25] like how to run it and what each task does [17:28:59] coreyfloyd: ok, i'm actually going to go a step further and make the Makefile self-documenting (similar to how rake tasks work) [17:29:11] so i can just add one line to the README: "run make help for more info" [17:29:27] (in addition to a quick blurb about comment make targets, as you suggest) [17:30:03] (03Merged) 10jenkins-bot: Avoid array_merge during initialization [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194454 (owner: 10Legoktm) [17:30:05] (03Merged) 10jenkins-bot: Hygiene: Backport fix for useFileCache hook [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/194527 (owner: 10Florianschmidtwelzow) [17:31:09] if i can, easily [17:31:11] 10Wikipedia-App-iOS-App, 10Wikimedia-Hackathon-2015: [Wikimedia Hackathon 2015] Wikipedia Radio (or "Wiki Radio" if not part of the official brand umbrella) for iOS - https://phabricator.wikimedia.org/T91658#1092677 (10dr0ptp4kt) [17:31:12] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Mobile-Apps, 7Tracking: Hackathon-able / volunteer-worthy tasks for Mobile Apps - https://phabricator.wikimedia.org/T91510#1092676 (10dr0ptp4kt) [17:31:18] ah, i'll just add readme docs for now [17:33:31] this is the shortest i've seen the mf open patches list [17:33:45] joakino: anything in gather need reviewing while i've got time? [17:34:46] 6Mobile-Web, 10MediaWiki-Categories, 5Patch-For-Review: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1092690 (10Jdlrobson) Thanks for that example @thedj - i wish we had better test pages for this sort of thing. I'm agnostic to what w... [17:36:09] phuedx: have a look, not much there right now [17:36:16] doesn't look like it [17:48:30] coreyfloyd: see new README here: https://github.com/btgerst/apps-ios-wikipedia/tree/makefile [17:53:37] (03PS17) 10Jhernandez: Add new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) (owner: 10Jdlrobson) [17:59:25] coreyfloyd: is there a way to skip uncrustify? [17:59:33] bgerstle: -n [17:59:41] where's that defined? [18:00:19] (03PS3) 10Bgerstle: add Makefile [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194257 [18:00:30] bgerstle: git commit --help [18:00:50] bgerstle: --no-verify [18:00:54] (03CR) 10Bgerstle: "FYI to see rendered README changes, check out https://github.com/btgerst/apps-ios-wikipedia/tree/makefile" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194257 (owner: 10Bgerstle) [18:01:11] coreyfloyd: please review ^. also, check out "make help" [18:01:23] coreyfloyd: ahh, --no-verify, awesome [18:01:24] thanks [18:05:09] (03PS4) 10Bgerstle: add Makefile [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194257 [18:05:13] (03PS18) 10Jdlrobson: Add new collection workflow [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) [18:06:29] i'm gonna fix browser tests now joakino [18:06:39] 👍 [18:07:58] (03PS19) 10Jdlrobson: Add new collection workflow [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) [18:08:27] * jdlrobson works on https://phabricator.wikimedia.org/T91665 [18:10:32] be back in 5 [18:10:57] (03PS1) 10Jdlrobson: Hygiene: Name scenarios [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194555 [18:11:37] ^ joakino can you mergethat or have you gone already [18:12:03] bgerstle: left comments: https://github.com/btgerst/apps-ios-wikipedia/commit/ca6e5355086d24e02b9300f7e2be8171394ae66d#diff-04c6e90faac2675aa89e2176d2eec7d8R16 [18:12:05] (03PS2) 10Jdlrobson: Hygiene: Name scenarios [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194555 [18:12:15] (03CR) 10Jdlrobson: [C: 032] "needed for debugging" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194555 (owner: 10Jdlrobson) [18:12:23] coreyfloyd: quick hangout? [18:12:35] mhurd: sho enuf [18:13:20] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Name scenarios [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194555 (owner: 10Jdlrobson) [18:14:02] (03CR) 10Jdlrobson: [C: 031] "grr flow" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194555 (owner: 10Jdlrobson) [18:14:08] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194555 (owner: 10Jdlrobson) [18:14:13] (03CR) 10Jdlrobson: [C: 032] Hygiene: Name scenarios [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194555 (owner: 10Jdlrobson) [18:15:19] (03Merged) 10jenkins-bot: Hygiene: Name scenarios [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194555 (owner: 10Jdlrobson) [18:16:37] jdlrobson: a browser test fails consistently to me https://gist.github.com/anonymous/989786dc728038b95773 [18:17:11] the toast one on add_to_collection.feature [18:17:19] does it work for you? (btw so slow [18:18:53] 6Mobile-Web, 5Patch-For-Review: The mobile Web wikicode editor loses the user-entered text - https://phabricator.wikimedia.org/T88949#1092825 (10bmansurov) @Aklapper, I agree it should be a separate task with new designs from the design team. Pinging @MSyed. [18:19:38] 6Mobile-Web, 5Patch-For-Review: Hide account benefits in Minerva version of login page - https://phabricator.wikimedia.org/T87257#1092829 (10Jdlrobson) No as commit message says it is alpha only. [18:19:59] coreyfloyd: responded, surprised i didn't get comment notifs [18:21:19] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Performance improvements - lazy loading and caching assets [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194273 (owner: 10Fjalapeno) [18:21:32] woohoo!!! [18:21:42] coreyfloyd: please rebase https://gerrit.wikimedia.org/r/#/c/194434/ [18:22:05] (03PS3) 10Mhurd: Fix for stretched native header-footer issue. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194450 [18:22:26] coreyfloyd: ^ mine rebased cleanly… yay! [18:22:52] 6Mobile-Web: EditorTutorial false arrow position - https://phabricator.wikimedia.org/T91047#1092855 (10bmansurov) a:3bmansurov [18:23:16] (03PS20) 10Jdlrobson: Add new collection workflow [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) [18:24:08] jdlrobson: testing ^ [18:24:23] (03PS1) 10Jdlrobson: QA: Log into mobile site [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194558 (https://phabricator.wikimedia.org/T91665) [18:24:39] ^ joakino worked out the browser test issue [18:25:00] (03PS2) 10Fjalapeno: Improve performance while scrolling by optimizing keyboard hiding. Bug:T91601 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194434 [18:25:05] dr0ptp4kt: ^ [18:25:40] (03CR) 10Jhernandez: [C: 032] QA: Log into mobile site [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194558 (https://phabricator.wikimedia.org/T91665) (owner: 10Jdlrobson) [18:26:46] (03Merged) 10jenkins-bot: QA: Log into mobile site [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194558 (https://phabricator.wikimedia.org/T91665) (owner: 10Jdlrobson) [18:26:50] jdlrobson: here https://gerrit.wikimedia.org/r/#/c/194558/ this is not implemented: Given(/^I am logged into the mobile website$/) do [18:27:12] whaaaa? [18:27:25] shoot [18:27:29] and i've merged the other one -_-' [18:27:41] mhurd: once you've put the +1 on https://gerrit.wikimedia.org/r/#/c/194450, give me a shout and i'll do some hands on testing. i looked through the code, but wanted to defer my hands on testing as it's a sort of time intensive task [18:28:11] coreyfloyd: ^ that was for you [18:28:17] coreyfloyd: oy [18:28:30] (03PS1) 10Jdlrobson: QA: Provide step for logging into mobile site [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194560 [18:28:32] ^ joakino will fix it [18:29:24] dr0ptp4kt: "oy veh"? [18:29:34] coreyfloyd: yeah, that, not oi punk stylee [18:29:47] joakino: i thought it was in the gem but apparently not [18:30:04] dr0ptp4kt: coreyfloyd bgerstle my masonry patch got merged :) https://github.com/Masonry/Masonry/commit/4ce6a4b3675a37e4c654982cc34dcb7891f3cf41 [18:30:14] mhurd: attaboy [18:30:16] mhurd: nice! [18:30:17] jdlrobson: btw the 1.0.0 of the gem is out and has breaking changes, i saw that on github the other day [18:30:28] ah they're using expecta? [18:30:33] mhurd: how'd you like it? [18:30:52] (03CR) 10Jhernandez: [C: 032] QA: Provide step for logging into mobile site [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194560 (owner: 10Jdlrobson) [18:31:24] bgerstle: expecta? is that a testing mock library? [18:31:37] mhurd: the "expect(foo).to.equal(bar)" [18:31:51] i'm pretty sure that's Expecta, it's what's called an expectation/matching framework [18:31:56] we're using one called Hamcrest which is a bit different [18:31:59] (03Merged) 10jenkins-bot: QA: Provide step for logging into mobile site [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194560 (owner: 10Jdlrobson) [18:32:04] (OCHamcrest, actually) [18:32:12] (03CR) 10Fjalapeno: [C: 031] "Code wise this seems fine. The part I will defer to Monte and Adam on is:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194450 (owner: 10Mhurd) [18:32:17] bgerstle: ah i see. i just based my tests on the pre-existing ones… seemed straighforward :) [18:32:23] yep [18:33:00] mhurd: bgerstle coreyfloyd - Deskana|Away is going to tell me the changes to the crash alert dialog that need to happen, and once that's done, i want to do the friends & family (internal, limited to 25) part of the testflight build. Deskana|Away is probably fairly occupied until after the metrics meeting starting in 27 minutes [18:33:43] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Improve performance while scrolling by optimizing keyboard hiding. Bug:T91601 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194434 (owner: 10Fjalapeno) [18:33:46] dr0ptp4kt: k. curious what needs to be changed but i'm glad things are moving along [18:33:47] (03CR) 10Mhurd: "It's always been that way - both the min and max was set to 1.0, so I just explicitly set scales to no." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194450 (owner: 10Mhurd) [18:33:56] bgerstle: i think it's just wording [18:34:00] k [18:36:03] coreyfloyd: ^ mind responding to the latest comment on https://gerrit.wikimedia.org/r/#/c/194450/ ? i'm eager to get to testing, if you're cool with that [18:37:48] (03PS21) 10Jhernandez: Add new collection workflow [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) (owner: 10Jdlrobson) [18:37:54] (03PS5) 10Mhurd: add Makefile [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194257 (owner: 10Bgerstle) [18:37:56] (03CR) 10Florianschmidtwelzow: Hygiene: Use same saving indication in TalkSectionAdd like in EditorOverlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193522 (https://phabricator.wikimedia.org/T91139) (owner: 10Florianschmidtwelzow) [18:38:08] (03CR) 10Jhernandez: [C: 032] Add new collection workflow [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) (owner: 10Jdlrobson) [18:39:12] (03Merged) 10jenkins-bot: Add new collection workflow [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193406 (https://phabricator.wikimedia.org/T91296) (owner: 10Jdlrobson) [18:39:12] thanks mhurd [18:39:27] (03PS3) 10Florianschmidtwelzow: Hygiene: Use same saving indication in TalkSectionAdd like in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193522 (https://phabricator.wikimedia.org/T91139) [18:41:36] (03CR) 10Mhurd: [C: 031 V: 031] add Makefile [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194257 (owner: 10Bgerstle) [18:43:13] mhurd don't merge yet, making a couple more tweaks [18:43:14] sorry [18:43:30] coreyfloyd: did you see my comment on https://gerrit.wikimedia.org/r/#/c/194450/ ? pages were already non-user scalable cause the max scale was 1 and the min scale was 1. realized after looking at android code a more concise way of doing this was setting scalable to no :) [18:43:55] bgerstle: k [18:45:28] mhurd: got it thanks [18:46:48] (03PS6) 10Bgerstle: add Makefile [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194257 [18:46:58] coreyfloyd: one more time, with feeling [18:47:06] (03CR) 10Fjalapeno: "left additional comments on gihub:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194257 (owner: 10Bgerstle) [18:47:19] (03CR) 10Florianschmidtwelzow: [C: 032] "that looks good enough, especially because the "report an error" button is only loaded in alpha :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192473 (owner: 10Bmansurov) [18:47:50] yay [18:48:03] coreyfloyd: sorry, i've been amending and force pushing because of gerrit [18:48:06] i might have lost your commits [18:48:10] i mean, comments [18:48:24] would you mind having another look at the README? [18:48:26] bgerstle: coreyfloyd GEEEEEERRRRRIIIIIITTTTTT!!!! [18:48:27] (03Merged) 10jenkins-bot: Add ButtonWithSpinner and re-create 'Report an error' button using it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192473 (owner: 10Bmansurov) [18:48:37] mhurd: don't get me started :-P [18:48:44] bgerstle: lol [18:48:58] bgerstle: you can just amend and rerun “git review” [18:49:12] mhurd: that's what i'm doing, and why i lost the other commits [18:49:16] :) [18:49:27] i amend, force push to my branch, and as a result obliterate the previous commit along w/ any comments attached to it [18:49:39] bgerstle: mhurd "Gerrrrrrrrrrrrit!" http://static.comicvine.com/uploads/original/6/69852/3474892-tumblr_lty7zyqval1r0gftro1_500.gif [18:49:46] (03PS5) 10Florianschmidtwelzow: Move Editor Cta to the end of the editing process [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192095 (https://phabricator.wikimedia.org/T87508) [18:49:51] coreyfloyd: read my mind [18:49:57] (03PS4) 10Florianschmidtwelzow: Promote TalkOverlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) [18:49:59] coreyfloyd: lol [18:50:26] coreyfloyd: bgerstle what i want to do to gerrit: http://i.imgur.com/oxEvxwL.gif [18:51:05] mhurd bgerstle The good news is that in Star Trek 3, Github is resurrected from the dead. [18:51:06] (03CR) 10jenkins-bot: [V: 04-1] Promote TalkOverlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [18:51:13] hahahah [18:51:17] hahaha [18:51:25] lol [18:52:04] mhurd: this is how i feel using gerrit: http://i.imgur.com/Y1UPO.png [18:52:22] bgerstle: HAHAHAHH!! [18:52:26] or how i picture gerrit while i use it: http://i.imgur.com/tkyJ8.jpg [18:52:37] ok i told you not to get me started [18:52:39] now i'm stopping [18:52:46] :) [18:54:31] bgerstle: mhurd is there a way to see the resulting file in gerrit? [18:54:41] the resulting file? [18:54:51] what do you mean? [18:55:29] JonKatz: http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings?article_action=signup-edit [18:56:27] (03CR) 10Fjalapeno: [C: 031] "looks good" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194257 (owner: 10Bgerstle) [18:56:45] coreyfloyd: i just realized the "option vs. requirement" for bundler vs. cocoapods [18:56:51] i can make that last tweak if you want [18:56:59] jdlrobso_, working hard on getting your api done ) [18:57:02] e.g. "uncrustify" is a requirement for linting, not homebrew [18:57:14] (03CR) 10Fjalapeno: "brian - forgot to ask: did you try this makefile from a clean machine?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194257 (owner: 10Bgerstle) [18:57:27] jdlrobso_, let me know if you want to make any changes to the spec before its too hard ) [18:57:56] bgerstle: i'm ok with how it is now - but am not against you amending [18:58:10] coreyfloyd: but which would you prefer? ;-) [18:58:13] (03CR) 10Florianschmidtwelzow: "one little question :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [18:58:19] phuedx: ^ :) [18:58:30] (03CR) 10Florianschmidtwelzow: [C: 031] Add the MobileViewBannerImageRepository [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [18:58:54] bgerstle: lol - dealers choice - its good enough for me [19:00:57] coreyfloyd: it's tricky because IMO the Makefile is the "higher level of abstraction", which does require bundler [19:01:20] if you're going around that, e.g. by installing the pod gem globally and running pod install manually, that's up to you [19:01:36] the Makefile is supposed to be the "source of truth" for how we build the project in dev & CI [19:01:56] bgerstle: i dont think you have to make the distinction… really that was just to point out the reason to have cocoapods in that section [19:02:11] ok [19:03:25] yurik: just in a meeting will chat in a second [19:03:28] dr0ptp4kt: that wasn't the link either - I dont actually know if it was on an etherpad - you might have been editing locally and screen sharing [19:03:43] jdlrobso_, dito [19:03:54] dr0ptp4kt: this was when we were having the whose on first meeting [19:04:14] dr0ptp4kt: ad we were trying to make sense of some overlapping tickets [19:05:15] coreyfloyd: oh, i think i was using textedit. and it looks like i don't have any windows open with that content, if that was the case. that said, i think the cards have comments in them where actionable [19:07:39] (03PS3) 10Mhurd: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [19:08:12] (03CR) 10Mhurd: "Rebased." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [19:10:10] (03PS7) 10Bgerstle: add Makefile [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194257 [19:10:22] coreyfloyd: ok, hopefully the last time [19:11:57] coreyfloyd: see https://github.com/btgerst/apps-ios-wikipedia/tree/makefile#dependencies [19:12:59] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] "Discussion resolved on IRC." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194450 (owner: 10Mhurd) [19:13:16] dr0ptp4kt: yay! [19:14:30] bgerstle: coreyfloyd: I push amended patches using "git review -R" (skips the automatic “git rebase -i” step) [19:14:47] (03PS4) 10Mhurd: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [19:15:14] bearND: hm, i usually rebase manually [19:19:25] (03CR) 10Phuedx: Add the MobileViewBannerImageRepository (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [19:20:27] coreyfloyd: you good with https://gerrit.wikimedia.org/r/#/c/194257/7 ? [19:22:48] \o yurik [19:22:56] jdlrobson, [19:25:59] yurik: hey [19:26:02] hi [19:26:37] i'm free now if you want to chat [19:26:47] the wiki page / bug reports looked great. [19:27:08] are you able to give a rough timeline of when / what we can get done over the next week? [19:27:30] coreyfloyd: running make on aclean project now, almost forgot [19:27:34] then i need to get some lunch [19:28:08] yurik: ^ [19:28:15] (03CR) 10Fjalapeno: [C: 031] add Makefile [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194257 (owner: 10Bgerstle) [19:28:23] dr0ptp4kt: ^ [19:28:37] coreyfloyd: thx [19:28:49] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] add Makefile [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194257 (owner: 10Bgerstle) [19:29:25] jdlrobson, if you are happy with the proposed api, i could try to get most of it within a week, possibly with the db support. In the mean time, you don't have to wait - go ahead and code against it. [19:29:35] coreyfloyd: just nuked the build folder, and ran make build-sim w/ successful results \o/ (still compiling but i'm confident) [19:29:46] yurik: so so far we've been using smoke and mirrors [19:29:59] but since we are currently using JSON storage we could use the wikitext editing api [19:30:06] jdlrobson, i could have some basic stuff functioning even earlier. The question is if you want to maintain the current storage model or it should be wiped clean [19:30:10] dr0ptp4kt: mhurd coreyfloyd our project is now one-line bootstrappable! (assuming you have system deps installed) [19:30:18] nope don't worry about backwards compatibility [19:30:28] coreyfloyd: for posterity: ** BUILD SUCCEEDED ** [19:30:30] we're not deployed anywhere so you can feel free to completely break existing data :) [19:30:44] bgerstle: coolio [19:31:03] jdlrobson, i'm thinking about how to store data within user profile or in the db from the start. I might hack around things a bit. Will see. I will try to get some of the api earlier [19:31:15] dr0ptp4kt: now you can patch the makefile for cutting release ;-) [19:31:31] just make sure commit messages are verbose and ideally separated into separate commits e.g. commit that adds new collection api, commit that adds add member api etc rather than one big patch with the commit message "API: all the things" [19:31:42] will help us frontend devs work out what we need to change on frontend [19:31:53] dr0ptp4kt: i.e. `xcodebuild archive` might work (w/ scheme & workspace args) [19:32:05] ideally we need the apis in place by Thursday next week latest (week today) [19:32:08] (and adding any preprocessor or build setting overrides as necessary [19:32:21] time to get some lunch though, bbl o/ [19:32:25] yurik: we have a sprint board https://phabricator.wikimedia.org/tag/gather_sprint_c/board/ in case you didn't see it [19:32:49] entire team is remote from one another so just stick any updates on the relevant cards in phabricator [19:33:06] yep, will do ) [19:33:29] im going to catch end of metrics meeting now. will temporarily drop off the wifi but ping me any time if you have any blockers/questions/code review - this is our top priority right now [19:33:54] enjoy ) [19:33:59] (03PS5) 10Mhurd: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [19:34:32] (03PS6) 10Mhurd: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [19:35:20] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10MediaWiki-extensions-PageImages: PageImages shouldn't return images that are not in the lead section - https://phabricator.wikimedia.org/T87336#1093224 (10Mattflaschen) [19:37:13] (03CR) 10Fjalapeno: "Monte - is this ready to go? Also did you determine a benchmark for this - is this an instruments thing, or a user experience one?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [19:38:32] (03PS1) 10Bmansurov: Correct the arrow position of the editor tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194574 (https://phabricator.wikimedia.org/T91047) [19:38:57] coreyfloyd: i was just cleaning it up/rebasing. i’m pretty confident it’s good to go, but presently at metrics meeting so haven’t had a chance to establish numbers. if you have a bit of time to benchmark it that’s fine with me too [19:39:37] 6Mobile-Web, 7Design: Styling regression in new editor tutorial - https://phabricator.wikimedia.org/T91141#1093241 (10bmansurov) Ping, @MSyed and @Vibhabamba. [19:49:49] 6Mobile-Web, 7Design: Styling regression in new editor tutorial - https://phabricator.wikimedia.org/T91141#1093299 (10Jdlrobson) This is also likely to block #Gather - we may want to reuse this for drawing attention to the feature. [19:50:05] haven't seen this list this small in quite some time: https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MobileFrontend,n,z [19:50:10] (03CR) 10Florianschmidtwelzow: [C: 032] Add the MobileViewBannerImageRepository (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [19:53:45] (03PS2) 10Bmansurov: Tweak banner image aspect ratio [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192789 (owner: 10Phuedx) [19:53:52] (03CR) 10Bmansurov: [C: 032] Tweak banner image aspect ratio [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192789 (owner: 10Phuedx) [19:53:57] ta bmansurov [19:54:04] np [19:54:05] yeesh, that list is getting pretty dern small now [19:54:29] alright folks – i'm heading off for the day [19:54:43] au revoir phuedx [19:55:03] going to take a look at the leaky pipes in the house :( [19:55:06] cya [19:55:22] 6Mobile-Web, 5Patch-For-Review: EditorTutorial false arrow position - https://phabricator.wikimedia.org/T91047#1093305 (10Florian) {F56164} That's how it looks on pages with bannerImages :/ They normally get loaded after the page is rendered and most of Javascripts are eecuted. This should be fixed, too. [19:55:23] (03PS1) 10Jhernandez: Add edit button to a collection page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194578 (https://phabricator.wikimedia.org/T90990) [19:55:25] (03CR) 10Florianschmidtwelzow: [C: 04-1] "see my comment in the bugreport, that seems to be too hacky :(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194574 (https://phabricator.wikimedia.org/T91047) (owner: 10Bmansurov) [19:56:30] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Some articles about cities are broken in iOS app beta 4.0.6.3 - https://phabricator.wikimedia.org/T90032#1093311 (10Fjalapeno) Hmm looks like the internal webview width is getting set to 616. Something in the js or the html is making that happen. {F56167} [19:56:41] 6Mobile-Web, 5Patch-For-Review: EditorTutorial false arrow position - https://phabricator.wikimedia.org/T91047#1093313 (10bmansurov) Good catch, then we should listen to the editor icon location changes. Simply listening to window.resize won't do it. [19:58:36] good night all :) [19:58:37] 10Wikipedia-App-iOS-App, 10Mobile App Sprint 52 - iOS: Some articles about cities are broken in iOS app beta 4.0.6.3 - https://phabricator.wikimedia.org/T90032#1093321 (10Fjalapeno) Ah ha! looks like these graphs are not getting resized: {F56169} [20:03:24] dr0ptp4kt: do you remember a conversation about map images recently? [20:03:42] coreyfloyd: several [20:03:46] coreyfloyd: what's up? [20:04:30] dr0ptp4kt: so the bug i am working on - related it seems. these map images are not being resized to the webview width [20:04:34] (03PS1) 10Jdlrobson: Hygiene: Correct hook in extension.json [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194580 [20:04:48] dr0ptp4kt: was there anything about the size of those images? [20:06:12] dr0ptp4kt: just wondering if those conversations yielded anything that I can use here [20:06:12] coreyfloyd: what's the phabricator card url? [20:06:24] dr0ptp4kt: https://phabricator.wikimedia.org/T90032 [20:06:48] dr0ptp4kt: basically I need to force these images to resize… [20:08:09] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Some articles about cities are broken in iOS app beta 4.0.6.3 - https://phabricator.wikimedia.org/T90032#1093334 (10Fjalapeno) Adding one of the actual image files for inspection. You can see it is 500px wide {F56174} [20:08:13] coreyfloyd: image size wasn't discussed for that sort of thing. the main things were image maps (often used on actual geographic maps), and the html red dots overlaid on maps to pinpoint the location of something like a city. glad you figured out the source of the bug [20:09:00] coreyfloyd: i know that i'm glad....is little consolation :) [20:09:14] dr0ptp4kt: lol - ok - good to know. I'll break for now and come back to it in a bit. [20:09:24] coreyfloyd: cool. ttyl [20:25:34] (03CR) 10Kaldari: [C: 04-1] TWN: Use own message for terms of use link in license warning (editor and talk) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190831 (owner: 10Florianschmidtwelzow) [20:29:15] 10Wikipedia-App-iOS-App, 6Multimedia: Package OGVKit for CocoaPods (iOS Ogg Vorbis/Theora playback library) - https://phabricator.wikimedia.org/T91689#1093387 (10brion) 3NEW a:3brion [20:29:42] 10Wikipedia-App-iOS-App: [iOS app] Media files do not work - https://phabricator.wikimedia.org/T68722#1093397 (10brion) [20:29:43] 10Wikipedia-App-iOS-App, 6Multimedia: Package OGVKit for CocoaPods (iOS Ogg Vorbis/Theora playback library) - https://phabricator.wikimedia.org/T91689#1093398 (10brion) [20:29:52] 10Wikipedia-App-iOS-App, 10Wikimedia-Hackathon-2015: [Wikimedia Hackathon 2015] Wikipedia Radio (or "Wiki Radio" if not part of the official brand umbrella) for iOS - https://phabricator.wikimedia.org/T91658#1093399 (10brion) [20:29:53] 10Wikipedia-App-iOS-App, 6Multimedia: Package OGVKit for CocoaPods (iOS Ogg Vorbis/Theora playback library) - https://phabricator.wikimedia.org/T91689#1093387 (10brion) [20:31:10] 10Wikipedia-App-iOS-App, 10Wikimedia-Hackathon-2015: [Wikimedia Hackathon 2015] Wikipedia Radio (or "Wiki Radio" if not part of the official brand umbrella) for iOS - https://phabricator.wikimedia.org/T91658#1092579 (10brion) Note that I haven't tried OGVKit with a Swift host app yet, but it should work. I may... [20:33:27] (03CR) 10Maryana: [C: 04-2] "Not quite ready for this yet." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194451 (https://phabricator.wikimedia.org/T85929) (owner: 10Legoktm) [20:37:51] 10Wikipedia-App-iOS-App: Investigate to what extent app indexing and deep linking are available on iOS - https://phabricator.wikimedia.org/T91520#1093418 (10brion) Deep linking is similar to Android in that you can register custom URL type handlers (say, 'wikipedia://*') but dissimilar in that you cannot match a... [20:46:02] Deskana, do we have a date for the android release? if so can we add the relevant task to https://phabricator.wikimedia.org/tag/roadmap/ ? [20:46:56] Eloquence: Provisional date for the next production release for both apps is 30th March. I think we're on target to hit it, but as always we'll be at the mercy of Apple's review process. [20:47:05] do we have a T# for it yet? [20:47:14] No, let me make one. [20:47:19] thanks! [20:48:15] 6Mobile-Web, 7Performance: MobileFrontendHooks::onResourceLoaderTestModules is really slow - https://phabricator.wikimedia.org/T91659#1093465 (10Krenair) Run only if you set $wgEnableJavaScriptTest = true; - so in WMF production this is test2wiki only [20:48:31] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap: Production release for iOS Wikipedia app in March (provisional) - https://phabricator.wikimedia.org/T86692#1093466 (10Deskana) [20:50:21] 10Wikipedia-App-Android-App, 3Roadmap: Production release for Android Wikipedia app in March (provisional) - https://phabricator.wikimedia.org/T91693#1093468 (10Deskana) 3NEW [20:50:32] Eloquence ^ [20:50:52] Eloquence: That's likely not the final feature set so that needs to be fleshed out, but that stuff should be included [20:50:59] <3 [20:53:41] jdlrobson, per MaxSem comment, i will rename collection to pageset [20:53:59] (03PS2) 10Bmansurov: Correct the arrow position of the editor tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194574 (https://phabricator.wikimedia.org/T91047) [20:54:03] apparently someone else is using collection for something [20:54:40] (03PS5) 10Krinkle: Add the MobileViewBannerImageRepository [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [20:54:42] (03CR) 10jenkins-bot: [V: 04-1] Tweak banner image aspect ratio [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192789 (owner: 10Phuedx) [20:54:51] (03PS3) 10Krinkle: Tweak banner image aspect ratio [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192789 (owner: 10Phuedx) [20:55:21] (03CR) 10Bmansurov: [C: 032] Add the MobileViewBannerImageRepository [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [20:57:12] (03PS2) 10Krinkle: Add edit button to a collection page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194578 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [20:57:19] (03CR) 10Krinkle: "(Zuul unstuck)" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194578 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [21:00:14] Deskana, is "Share a Fact" currently in beta? [21:00:32] Krenair: No, it'll be going out soon. [21:00:45] I can see "Did you mean" is [21:01:04] dbrant, bearND: Speaking of which, how do you feel about a beta release today to get it out there? :-) [21:02:49] Deskana: sure! let's get it out [21:03:06] Deskana, do we have a user-readable (i.e. not git-log) list of changes in the beta but not yet stable? [21:03:48] Krenair: I put the notable changes off the top of my head into that task I just filed [21:03:54] Otherwise, no [21:04:07] ok [21:04:27] "app featuring"? [21:04:41] (03CR) 10Bmansurov: [C: 04-1] "The spinner has an unnecessary margin and is not vertically aligned in the middle." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193522 (https://phabricator.wikimedia.org/T91139) (owner: 10Florianschmidtwelzow) [21:05:22] (03CR) 10Bmansurov: Tweak banner image aspect ratio [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192789 (owner: 10Phuedx) [21:05:29] (03CR) 10Bmansurov: [C: 032] Tweak banner image aspect ratio [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192789 (owner: 10Phuedx) [21:08:26] (03CR) 10MaxSem: [C: 032] Hygiene: Correct hook in extension.json [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194580 (owner: 10Jdlrobson) [21:13:48] mhurd: you got a minute to hangout? [21:14:19] coreyfloyd: 5 min? [21:14:27] mhurd: sure [21:14:48] hey, bmansurov, you should get +2! [21:14:55] it's silly that you don't have it yet [21:15:10] Maryana: that'd be nice [21:15:54] MaxSem: how does one get hooked up with +2? [21:16:33] mmm, ping ^d? [21:16:46] <^d> +2 to? [21:16:59] bmansurov :) [21:17:08] for operations/mediawiki-config [21:17:11] coreyfloyd: ok [21:18:02] <^d> Do you already have shell access? [21:18:40] ^d: yes [21:18:43] <^d> I don't see deployment access. [21:18:55] <^d> I see a shell account [21:19:11] yes, I haven't deployed yet, I just can ssh [21:19:28] 6Mobile-Web, 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1093567 (10KLans_WMF) [21:20:02] <^d> If you can't deploy then why do you need wmf-config merge rights? [21:20:20] ^d: for code review [21:20:54] <^d> You can +1 if you just want to review. Nobody should be able to merge wmf-config unless they can also deploy it [21:21:05] <^d> Otherwise you can cause icinga warnings about undeployed changes :) [21:21:13] ^d: sounds about right [21:21:15] thanks [21:21:36] mhurd: https://phabricator.wikimedia.org/T90032 [21:23:03] Deskana: dbrant: sure. beta sounds good. I'm reviewing dbrant's patches and then do a TWN sync. [21:23:55] (03CR) 10jenkins-bot: [V: 04-1] Add edit button to a collection page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194578 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [21:24:20] (03Merged) 10jenkins-bot: Add the MobileViewBannerImageRepository [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192788 (owner: 10Phuedx) [21:24:43] Deskana Maryana great job today at metrics...as usual :-) [21:24:54] thanks! [21:26:41] (03PS1) 10Bmansurov: Make WikiBase ID easily retrievable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194658 (https://phabricator.wikimedia.org/T90777) [21:27:37] (03Merged) 10jenkins-bot: Tweak banner image aspect ratio [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192789 (owner: 10Phuedx) [21:27:39] (03Merged) 10jenkins-bot: Hygiene: Correct hook in extension.json [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194580 (owner: 10Jdlrobson) [21:28:24] (03PS1) 10Bmansurov: Retrieve WikiBase ID using M.util [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/194671 [21:29:23] (03CR) 10BearND: [C: 04-1] "See comments inline." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193974 (owner: 10Dbrant) [21:30:33] 6Mobile-Web, 10WikiGrok, 5Patch-For-Review: Wikibase id should be retrieveable from M.require( 'util' ) - https://phabricator.wikimedia.org/T90777#1067289 (10bmansurov) Also, please review the related patch [1]. [1] https://gerrit.wikimedia.org/r/#/c/194671/ [21:32:45] (03PS8) 10Dbrant: Single "read next" item at the bottom of articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193974 [21:32:53] bearND: ^ [21:35:18] bearND: oh wait, didn't notice the rest of your comment... [21:36:32] ok [21:37:04] bearND: it's ok if this doesn't go in today's beta [21:37:19] dbrant: sure [21:38:27] dbrant: ok, i'll do a TWN sync then [21:42:02] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194699 [21:42:05] (03CR) 10Jdlrobson: [C: 04-1] "This is a good start but we should bake the override code into this as well, as this is where the code duplication is happening, otherwise" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194658 (https://phabricator.wikimedia.org/T90777) (owner: 10Bmansurov) [21:42:12] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194700 [21:45:17] kristenlans: Thank you! [21:45:26] mhurd: dr0ptp4kt: https://gerrit.wikimedia.org/r/194699 [21:45:46] bearND: yay! thanks! [21:46:23] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Some articles about cities are broken in iOS app beta 4.0.6.3 - https://phabricator.wikimedia.org/T90032#1093682 (10Fjalapeno) Woohoo - this was fixed in this patch: https://gerrit.wikimedia.org/r/#/c/194450/ [21:46:53] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: Make TOC only render when visible - https://phabricator.wikimedia.org/T91087#1093686 (10Fjalapeno) a:3Fjalapeno [21:46:57] (03CR) 10BearND: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194700 (owner: 10BearND) [21:47:26] dbrant: all ready for beta then [21:47:32] Deskana, "app featuring"? [21:47:38] bearND: yep! [21:47:41] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194700 (owner: 10BearND) [21:47:47] Krenair: Google wants to feature the app in Google Play, but they wanted us to make some tweaks. [21:47:51] nice [21:48:01] I saw https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8173682 [21:48:10] dbrant: any sign of a new launcher icon? [21:48:24] I started replying, then noticed the domain and unlocked it again :p [21:49:22] Krenair: lol, I read that one, too, but had not noticed the domain. [21:51:02] bearND: lol vibha is still working on it. Apparently there are incompatibilities between the SVG format that Adobe Illustrator outputs, and our rsvg library (it looks all weird). So, she will have to generate the PNGs for us herself. [21:52:37] 10Wikipedia-App-iOS-App: Some map images cause the entire webview to be scrollable left to right - https://phabricator.wikimedia.org/T91702#1093698 (10Fjalapeno) 3NEW [21:52:39] dbrant: I ran into similar problems witht he MAterial Design icons. To fix it I just ran them through Inkscape, rotated left, then right, save. Now the generated png looked fine [21:53:21] bearND: but the SVGs that she designed in Illustrator don't even look right in Inkscape :( [21:54:02] dbrant: ouch [21:59:11] (03PS2) 10Bmansurov: Make WikiBase ID easily retrievable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194658 (https://phabricator.wikimedia.org/T90777) [21:59:15] (03PS2) 10Bmansurov: Retrieve WikiBase ID using M.util [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/194671 [22:01:24] (03PS16) 10Jdlrobson: Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [22:01:26] (03PS1) 10Jdlrobson: Avoid API requests to page images / extracts when no titles [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194705 [22:01:28] (03CR) 10jenkins-bot: [V: 04-1] Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [22:04:05] dbrant [22:04:19] retro [22:04:19] kristenlans: [22:04:25] damn it!! [22:04:26] spective [22:06:17] https://etherpad.wikimedia.org/p/MobileAppRetrospective [22:06:39] (03PS2) 10Jdlrobson: Avoid API requests to page images / extracts when no titles [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194705 [22:06:41] (03PS17) 10Jdlrobson: Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [22:09:05] (03CR) 10jenkins-bot: [V: 04-1] Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [22:38:47] (03PS1) 10Bmansurov: Beta: Don't close ReferencesDrawer on scroll [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194716 (https://phabricator.wikimedia.org/T87050) [22:48:37] (03PS18) 10Jdlrobson: Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [22:49:29] (03CR) 10jenkins-bot: [V: 04-1] Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [22:51:25] (03CR) 10Kaldari: [C: 04-1] [WIP] New-ish Special:MobileMenu page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [22:52:46] Maryana: Is Jon around? [22:52:48] (03PS19) 10Jdlrobson: Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [22:53:02] kaldari: i don't see him, no.. [22:53:08] last i saw him, he was outside on the phone [22:53:18] thanks [22:54:03] (03CR) 10jenkins-bot: [V: 04-1] Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [22:54:12] (03PS1) 10Bmansurov: Correctly align user icon on Special:Contributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194730 (https://phabricator.wikimedia.org/T90920) [22:54:37] jdlrobson: What do you think about adding tests for https://gerrit.wikimedia.org/r/#/c/180647/ ? [22:54:48] (03PS1) 10Jdlrobson: QA: Update browser test step to use mobile site for logging in [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194731 [22:55:12] kaldari: i don't really see the value [22:55:19] it's an external library [22:55:24] mw.template has tests [22:56:05] jdlrobson: Cool, if you can add that as a comment on the patch, I’ll +1 (and then +2 next week if there are no other comments) [22:56:06] (03CR) 10Jdlrobson: [C: 032] "Need to get browser tests passing to stop failure email spam." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194731 (owner: 10Jdlrobson) [22:57:03] done [22:59:23] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [23:02:24] (03PS20) 10Jdlrobson: Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [23:03:39] (03CR) 10jenkins-bot: [V: 04-1] Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [23:04:00] (03Merged) 10jenkins-bot: QA: Update browser test step to use mobile site for logging in [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194731 (owner: 10Jdlrobson) [23:05:44] dr0ptp4kt: Deskana just noticed a meeting that starts in 25 mins (6:30 my time). Any chance we could move that to another time? I usually work until 7 or so local time but I'm not feeling so hot and was gonna bug out a little early. [23:07:09] kristenlans: Deskana i'm okay with whatever time works for you two that's also available on my calendar [23:07:37] kristenlans: Actually if you could just set up the boards for me that'd be fantastic. Then I can remove you from the meeting. [23:08:05] Deskana: ah I see how it is....;-) only wanted for my board creatorship! [23:08:16] I HAVE THE POWER! [23:08:30] kristenlans: Your powers are weak, old man. [23:08:52] Deskana I assume you want SPrint 53s, yeah? [23:09:04] kristenlans: You can't win, Product Owner. If you strike me down, your boards shall become less powerful than you could possibly imagine. [23:09:26] * bgerstle just realized his nick had _lunch for the past 4 hours [23:09:56] kristenlans: Yep. [23:15:00] kristenlans started to add those points from the retrospective here: https://etherpad.wikimedia.org/p/app_process_improvements [23:15:10] kristenlans: and clean them up a bit [23:18:09] Deskana: https://phabricator.wikimedia.org/project/sprint/board/1111/ [23:18:10] https://phabricator.wikimedia.org/project/sprint/board/1112/ [23:18:20] coreyfloyd: fantastic [23:25:20] Maryana: it seems we missed moving the infobox below lead section for article styling [23:25:41] oh yeah, i noticed that.. [23:25:45] should I make a bug on phab? [23:25:50] sure :) [23:25:56] ok! [23:26:00] thanks [23:26:06] also, oakland metro tonight? ;) [23:26:17] kristenlans: Thank you! [23:26:20] hmm hmm maybe :) [23:26:27] heh, ok [23:28:55] Maryana: is this the right board to file bugs? https://phabricator.wikimedia.org/tag/mobile-web/ [23:29:10] on styling stuff? yes [23:29:17] we moved wikigrok stuff to its own thing [23:30:47] Deskana: dbrant|bbl: kicking off the beta build process... [23:31:17] bearND: Sweet. And yeah, I hear you on the Android prod releases. I'm worried I'm the problem there. Let's chat about this tomorrow perhaps? [23:31:39] Deskana: Cool. [23:31:52] (03PS1) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194745 [23:34:18] 6Mobile-Web: Move infobox below lead section in article - https://phabricator.wikimedia.org/T91712#1094185 (10KHammerstein) 3NEW [23:36:19] (03CR) 10BearND: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194745 (owner: 10BearND) [23:36:54] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194745 (owner: 10BearND) [23:36:59] Maryana: BTW, when did that happen (wikigrok phab board) [23:38:17] Seems like a goo didea :-) [23:39:32] oh, i thought we already did it? [23:39:35] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Returning to the main home screen and back -the main page is displayed instead of recent search - https://phabricator.wikimedia.org/T89186#1094216 (10bearND) a:3bearND [23:39:38] i could be completely lying [23:39:58] 6Mobile-Web: Move infobox below lead section in article - https://phabricator.wikimedia.org/T91712#1094218 (10Mhurd) On apps we started moving infoboxes down, but found it's much better (fewer edge case etc) to move the first "good" paragraph up. See: https://gerrit.wikimedia.org/r/#/c/192452/ [23:40:14] 6Mobile-Web: Initial banner image should be delivered as part of the initial response - https://phabricator.wikimedia.org/T90698#1094219 (10bmansurov) a:3bmansurov [23:42:16] 6Mobile-Web: Move infobox below lead section in article - https://phabricator.wikimedia.org/T91712#1094222 (10Mhurd) The specific javascript transform we use for doing this: https://gerrit.wikimedia.org/r/#/c/192452/7/www/js/transforms.js [23:51:05] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Verify data migrations work from old store release - https://phabricator.wikimedia.org/T91713#1094240 (10dr0ptp4kt) 3NEW [23:52:33] Deskana: Hmm, the only real changes for beta are the dark toolbar and ShareAFact. I guess we could wait with the beta release a few more days. [23:52:56] bearND: I think it's okay to push out betas really, really regularly. [23:52:59] bearND: It's only beta. :-) [23:53:07] Deskana: ok [23:59:42] Deskana: What do you think about this text? "New feature: Share a quick fact from a Wikipedia page as an image card on Twitter or other social networks. Either use the share menu from the overflow to share some text from the lead section or select some text from the article and tap the share button to use the selected text."