[00:00:56] bearND: Excellent. [00:02:06] (03PS21) 10Jdlrobson: Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [00:02:08] (03PS3) 10Jdlrobson: Add edit button to a collection page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194578 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [00:03:22] (03PS22) 10Jdlrobson: Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [00:03:24] (03PS4) 10Jdlrobson: Add edit button to a collection page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194578 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [00:03:26] (03PS1) 10Jdlrobson: More API smoke and mirrors - editing collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194761 [00:04:41] (03CR) 10jenkins-bot: [V: 04-1] Add edit button to a collection page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194578 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [00:04:47] (03CR) 10jenkins-bot: [V: 04-1] Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [00:05:06] coreyfloyd: quick hangout? [00:08:37] MaxSem: hey where can I find the list of standard thumbnail sizes? [00:09:41] Deskana: beta is published [00:09:51] bmansurov, $wgThumbLimits [00:10:15] MaxSem: thanks [00:11:18] bearND: \o/ [00:12:24] Eloquence: So, Share a Fact is now live in beta on Android. :-) [00:13:21] Yay! [00:32:41] coreyfloyd: ping [00:35:35] 6Mobile-Web, 10MobileFrontend-Feature-requests, 7Design, 5Patch-For-Review: Remove mobile editing "call to registration" CTA - https://phabricator.wikimedia.org/T87508#1094382 (10Jaredzimmerman-WMF) A few questions and a comment. Can we technically attribute an edit post-save to a user who then logs in or... [00:45:32] MaxSem: When I’m on deployment-bastion on labs, what is the path to the MediaWiki install? Do you know or should I ask on labs channel? [00:46:09] somewhere in /srv [00:46:19] MaxSem: It looks like the config changes we made for WikiGrok have never taken effect on Beta Labs, so I was going to check the files there. [00:46:32] kaldari, are you feeling better? [00:46:39] no [00:46:46] :( [00:47:05] gh [00:47:08] *ugh [00:47:55] then go back to bed! [00:47:59] nah [00:52:55] MaxSem: Hmm, the files on beta labs look up to date. The configs are setting wmgWikiGrokUIEnable to true for enwiki, but mw.config.get( 'wgWikiGrokUIEnable' ) returns false. I don’t get it :P [00:53:44] maybe after I take nap it will make sense :) [00:54:56] kaldari, maxsem@tin:~$ echo "var_dump(\$wgWikiGrokUIEnable);" | mwscript eval.php enwiki [00:54:56] bool(false) [00:55:23] MaxSem: but why? [00:55:32] looking [00:55:49] it should be true [00:56:34] it’s set to true in InitialiseSettings-labs.php [00:56:59] try it in labs [00:57:35] try what? [00:57:56] that dump [00:58:07] I did and it returns false [00:58:48] arg [00:59:00] brb [01:15:11] 10Wikipedia-App-Android-App: Standardise share card layout on Android for very short text snippets - https://phabricator.wikimedia.org/T91721#1094497 (10Deskana) 3NEW [01:15:17] bearND ^ [01:15:21] bearND: Little tweak I'm suggesting. [01:15:38] bearND: If it's easy it might be good to knock it out so it gets into our next beta. [01:16:05] 10Wikipedia-App-Android-App: Standardise share card layout on Android for very short text snippets - https://phabricator.wikimedia.org/T91721#1094504 (10Deskana) [01:30:26] (03PS1) 10Bmansurov: Preload banner images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) [01:32:16] (03CR) 10jenkins-bot: [V: 04-1] Preload banner images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [01:33:35] (03CR) 10Bmansurov: "whaaat?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [01:35:23] Deskana: Are you talking about the way the preview is presented or the layout of the resulting image card? [01:36:11] bearND: About the card itself. [01:36:59] 10Wikipedia-App-Android-App: Standardise share card layout on Android for very short text snippets - https://phabricator.wikimedia.org/T91721#1094589 (10Deskana) [01:37:01] bearND: I clarified. [01:38:26] Deskana: ok, I'll look at the iOS code to see what the layout constraints are [01:39:02] Deskana: looks like the gradient is also darker on iOS [01:39:42] bearND: These aren't release blockers imo [01:39:52] bearND: But it's something you can pull into the current sprint if you're looking for work :-) [01:40:14] Deskana: the font is also different but there is not much we can do on the Android size (without bloating up the apk size) [01:40:25] bearND: Font is totally fine to leave as-is. [01:42:12] Deskana: OK. Hmmm, there's also a big difference in terms of where the image is cropped. On iOS I see the boat at the bottom fully, on Android it's on the edge. [01:46:33] (03PS5) 10Jdlrobson: Add edit button to a collection page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194578 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [01:46:35] (03PS1) 10Jdlrobson: Introduce crazy temporary JSON API [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194782 [01:46:40] bearND: Shall we scope this card to just be about the text? [01:47:16] 10Wikipedia-App-Android-App: Standardise the way the text is layed out in share cards on Android - https://phabricator.wikimedia.org/T91721#1094645 (10Deskana) [01:47:24] bearND: Eh, I changed the title. Feel free to revert if it doesn't suit. :-) [01:47:31] Deskana: sounds like a good step forward. Thank you [01:47:47] (03CR) 10jenkins-bot: [V: 04-1] Add edit button to a collection page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194578 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [01:47:57] (03CR) 10jenkins-bot: [V: 04-1] Introduce crazy temporary JSON API [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194782 (owner: 10Jdlrobson) [01:48:58] Deskana: btw, have you seen Moiz today. Just wondering if he has some comments re: onboarding lib [01:49:05] bearND: He's at a conference I think. [01:49:12] ah [01:49:28] Should be back on Monday, I think. [01:49:37] i c [01:54:37] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Returning to the main home screen and back -the main page is displayed instead of recent search - https://phabricator.wikimedia.org/T89186#1094671 (10bearND) 5Open>3declined Cannot repro right now. [01:58:14] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: [Spike 3 hrs] Investigate onboarding libraries to find one that's suitable for our purposes - https://phabricator.wikimedia.org/T89987#1094676 (10bearND) [02:00:37] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Scrum-of-Scrums, 3Mobile App Sprint 52 - Android: [Spike 1 hr] Investigate building a Node.js service for mobile apps content - https://phabricator.wikimedia.org/T90228#1094682 (10bearND) a:3bearND [02:02:04] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Standardise the way the text is layed out in share cards on Android - https://phabricator.wikimedia.org/T91721#1094683 (10bearND) a:3bearND [02:11:40] 10Wikipedia-App-iOS-App: Replace "Content is available under CC BY-SA 3.0" text at bottom of article with CC icon. (per Tomasz) - https://phabricator.wikimedia.org/T91729#1094692 (10Mhurd) 3NEW [02:11:53] tfinc: ^ [02:12:01] thanks mhurd [02:12:35] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Replace "Content is available under CC BY-SA 3.0" text at bottom of article with CC icon. (per Tomasz) - https://phabricator.wikimedia.org/T91729#1094699 (10Mhurd) [02:43:11] 10Wikipedia-App-iOS-App, 10Wikimedia-Hackathon-2015: [Wikimedia Hackathon 2015] Wikipedia Radio (or "Wiki Radio" if not part of the official brand umbrella) for iOS - https://phabricator.wikimedia.org/T91658#1094716 (10Jaredzimmerman-WMF) @dr0ptp4kt you know I love this idea, but I'm not currently slated to go... [02:48:00] (03PS1) 10Legoktm: Add composer test entry point for phplint and phpcs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194798 [02:55:18] (03PS2) 10Legoktm: Add composer test entry point for phplint and phpcs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194798 (https://phabricator.wikimedia.org/T90943) [02:57:20] (03CR) 10jenkins-bot: [V: 04-1] Add composer test entry point for phplint and phpcs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194798 (https://phabricator.wikimedia.org/T90943) (owner: 10Legoktm) [02:57:45] (03CR) 10Legoktm: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194798 (https://phabricator.wikimedia.org/T90943) (owner: 10Legoktm) [03:09:30] (03CR) 10Legoktm: "check experimental" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194798 (https://phabricator.wikimedia.org/T90943) (owner: 10Legoktm) [03:26:18] mhurd: hey sorry. Wasn't around earlier. What's up? [03:26:44] coreyfloyd: ran into some weird NSURLCache issues [03:27:03] coreyfloyd: quick hangout? [03:33:33] mhurd: give me a minute. [03:33:43] coreyfloyd: no rush [03:37:06] coreyfloyd: gmail is having issues... [03:37:11] mhurd: avon calling [03:37:14] ha ok [03:37:31] coreyfloyd: restarting safari [03:43:55] mhurd: https://github.com/AliSoftware/OHHTTPStubs [03:55:23] coreyfloyd: http://eng.kifi.com/customizing-uiwebview-requests-with-nsurlprotocol/ [04:37:43] coreyfloyd: ok i’m out. i basically proved the concept with help of this example: http://stackoverflow.com/a/5573155 will flesh it out tomorrow [05:53:51] (03PS1) 10Dr0ptp4kt: Customize HockeyApp alert dialog [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194821 [05:55:26] (03PS2) 10Dr0ptp4kt: Customize HockeyApp alert dialog [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194821 [06:05:27] (03PS3) 10Dr0ptp4kt: Customize HockeyApp alert dialog [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194821 [06:07:28] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Implement HockeyApp - https://phabricator.wikimedia.org/T90659#1064262 (10dr0ptp4kt) https://gerrit.wikimedia.org/r/#/c/194821 submitted for review. I'll ask Brian to review. [06:12:59] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Replace "Content is available under CC BY-SA 3.0" text at bottom of article with CC icon. (per Tomasz) - https://phabricator.wikimedia.org/T91729#1094899 (10Deskana) This needs to be run by Legal, and I'd rather get the crash reporting stuff out of the way... [06:38:33] (03CR) 10Florianschmidtwelzow: [C: 031] Make WikiBase ID easily retrievable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194658 (https://phabricator.wikimedia.org/T90777) (owner: 10Bmansurov) [06:41:51] (03CR) 10Florianschmidtwelzow: [C: 032] "LGTM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194574 (https://phabricator.wikimedia.org/T91047) (owner: 10Bmansurov) [06:43:18] (03Merged) 10jenkins-bot: Correct the arrow position of the editor tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194574 (https://phabricator.wikimedia.org/T91047) (owner: 10Bmansurov) [09:33:13] `good morning! [09:33:35] joakino: o/ [09:34:01] hi prtksxna [09:34:05] how is it going [09:38:22] morning [09:38:59] hi phuedx [09:39:09] hey MaxSem [09:39:11] you're up late [09:39:15] hey joakino [09:39:20] how're y'all? [09:39:26] * phuedx is making a cup of coffee [09:39:33] yep, insomnia [09:40:20] bleh [09:44:10] (03CR) 10Phuedx: [C: 032] Add composer test entry point for phplint and phpcs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194798 (https://phabricator.wikimedia.org/T90943) (owner: 10Legoktm) [09:44:38] joakino: d3 chart stuff for the new transparency report [09:44:58] prtksxna: ? [09:45:20] (03Merged) 10jenkins-bot: Add composer test entry point for phplint and phpcs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194798 (https://phabricator.wikimedia.org/T90943) (owner: 10Legoktm) [09:47:04] (03CR) 10Phuedx: [C: 04-1] "This isn't quite an override. If it were, then the query string parameter would take precedence." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194658 (https://phabricator.wikimedia.org/T90777) (owner: 10Bmansurov) [09:51:16] (03PS12) 10Phuedx: [WIP] New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 [09:51:35] (03CR) 10Phuedx: [WIP] New-ish Special:MobileMenu page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [10:20:43] (03CR) 10Jhernandez: [C: 031] "Gonna fix a couple of things and merge" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194578 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [10:25:16] (03PS6) 10Jhernandez: Add edit button to a collection page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194578 (https://phabricator.wikimedia.org/T90990) [10:26:05] (03CR) 10Jhernandez: "In last PS" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194578 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [10:26:16] (03CR) 10jenkins-bot: [V: 04-1] Add edit button to a collection page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194578 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [10:35:04] (03CR) 10Jhernandez: [C: 032] Add edit button to a collection page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194578 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [10:38:01] (03CR) 10Jhernandez: [C: 032] Avoid API requests to page images / extracts when no titles [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194705 (owner: 10Jdlrobson) [10:38:45] (03CR) 10Jhernandez: [C: 032] More API smoke and mirrors - editing collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194761 (owner: 10Jdlrobson) [10:39:02] (03Merged) 10jenkins-bot: Avoid API requests to page images / extracts when no titles [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194705 (owner: 10Jdlrobson) [10:39:45] joakino: you should be particularly proud of the "more api smoke and mirrors" commit message [10:39:52] (03Merged) 10jenkins-bot: More API smoke and mirrors - editing collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194761 (owner: 10Jdlrobson) [10:39:59] phuedx: that's jons xD [10:40:30] that's how we roll now, until yurik completes the api, given we aren't anywhere and we are super late [10:43:13] (03PS23) 10Jhernandez: Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [10:43:36] (03CR) 10jenkins-bot: [V: 04-1] Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [10:46:59] (03PS24) 10Jhernandez: Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [10:47:36] (03CR) 10jenkins-bot: [V: 04-1] Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [10:48:39] (03PS25) 10Jhernandez: Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [10:49:38] (03PS1) 10Jhernandez: Register qunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 [10:50:37] (03CR) 10jenkins-bot: [V: 04-1] Register qunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (owner: 10Jhernandez) [10:55:21] should i have another cup of coffee? [11:01:13] (03PS26) 10Jhernandez: Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [11:01:22] phuedx: yes [11:02:43] (03CR) 10Jhernandez: [C: 032] Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [11:02:58] (03PS7) 10Jhernandez: Add edit button to a collection page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194578 (https://phabricator.wikimedia.org/T90990) [11:03:44] (03Merged) 10jenkins-bot: Add items to collection frontend changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194225 (https://phabricator.wikimedia.org/T91294) (owner: 10Robmoen) [11:05:07] (03PS2) 10Jhernandez: Register qunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 [11:06:07] (03CR) 10jenkins-bot: [V: 04-1] Register qunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (owner: 10Jhernandez) [11:06:52] (03PS3) 10Jhernandez: Register qunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (https://phabricator.wikimedia.org/T91745) [11:07:51] (03CR) 10jenkins-bot: [V: 04-1] Register qunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (https://phabricator.wikimedia.org/T91745) (owner: 10Jhernandez) [11:10:30] (03CR) 10Jhernandez: Add edit button to a collection page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194578 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [11:10:37] (03CR) 10Jhernandez: [C: 032] Add edit button to a collection page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194578 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [11:10:42] (03CR) 10Phuedx: [C: 032] Correctly align user icon on Special:Contributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194730 (https://phabricator.wikimedia.org/T90920) (owner: 10Bmansurov) [11:11:41] (03Merged) 10jenkins-bot: Add edit button to a collection page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194578 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [11:11:51] (03CR) 10jenkins-bot: [V: 04-1] Correctly align user icon on Special:Contributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194730 (https://phabricator.wikimedia.org/T90920) (owner: 10Bmansurov) [11:17:55] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194730 (https://phabricator.wikimedia.org/T90920) (owner: 10Bmansurov) [11:18:06] i have another cup of coffee [11:18:11] and it is delish [11:20:38] (03PS2) 10Jhernandez: Introduce crazy temporary JSON API [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194782 (owner: 10Jdlrobson) [11:25:50] (03CR) 10Phuedx: [C: 032] Correctly align user icon on Special:Contributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194730 (https://phabricator.wikimedia.org/T90920) (owner: 10Bmansurov) [11:26:58] (03Merged) 10jenkins-bot: Correctly align user icon on Special:Contributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194730 (https://phabricator.wikimedia.org/T90920) (owner: 10Bmansurov) [12:17:57] (03PS3) 10Jhernandez: Introduce crazy temporary JSON API [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194782 (owner: 10Jdlrobson) [12:27:19] 10Wikipedia-App-Android-App: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1095386 (10jhsoby) >>! In T75086#764869, @bearND wrote: > The translations are edited in translatewiki.net (TWN). Here is a link to one language.[1] You can change the language with the lin... [12:30:06] 10Wikipedia-App-Android-App: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1095387 (10jhsoby) Correction: I hadn't tried the number one solution, which is logging out and logging back in (The IT Crowd is never wrong!), so here it worked as normal: https://no.wikip... [12:41:25] (03PS4) 10Jhernandez: Introduce crazy temporary JSON API [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194782 (owner: 10Jdlrobson) [12:43:16] (03CR) 10Jhernandez: [C: 032] "Made it a bit more robust, tested the (editing, adding new, adding to existing and removing from) collection." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194782 (owner: 10Jdlrobson) [12:44:16] (03Merged) 10jenkins-bot: Introduce crazy temporary JSON API [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194782 (owner: 10Jdlrobson) [12:45:24] (03PS4) 10Jhernandez: Register qunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (https://phabricator.wikimedia.org/T91745) [12:46:25] (03CR) 10jenkins-bot: [V: 04-1] Register qunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (https://phabricator.wikimedia.org/T91745) (owner: 10Jhernandez) [13:01:53] out for lun h [13:02:22] what's lun h? [13:45:47] 6Mobile-Web: Mobile editor needs basic formatting tools - https://phabricator.wikimedia.org/T91752#1095463 (10Florian) 3NEW a:3Florian [14:39:50] (03CR) 10Bmansurov: Beta: Don't close ReferencesDrawer on scroll (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194716 (https://phabricator.wikimedia.org/T87050) (owner: 10Bmansurov) [14:41:35] (03CR) 10Bmansurov: "Maybe the word 'override' doesn't fit here well, but our purpose is not to override the config variable but enable developers to use wikib" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194658 (https://phabricator.wikimedia.org/T90777) (owner: 10Bmansurov) [14:43:59] 6Mobile-Web, 5Patch-For-Review: User icon misplaced on User:Contributions page in beta - https://phabricator.wikimedia.org/T90920#1095561 (10bmansurov) 5Open>3Resolved a:3bmansurov [14:58:28] responding to code review but not in irc! [14:59:09] (03CR) 10Phuedx: "What did we do previously?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194658 (https://phabricator.wikimedia.org/T90777) (owner: 10Bmansurov) [15:00:48] (03PS1) 10Cmcmahon: QA: update ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194864 [15:02:36] (03PS2) 10Cmcmahon: QA: update ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194864 [15:20:34] (03CR) 10Zfilipin: [C: 032] QA: update ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194864 (owner: 10Cmcmahon) [15:21:39] (03Merged) 10jenkins-bot: QA: update ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194864 (owner: 10Cmcmahon) [15:57:36] for some reason my git hooks aren't generating change-ids anymore. [15:57:58] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: [Spike 3 hrs] Investigate onboarding libraries to find one that's suitable for our purposes - https://phabricator.wikimedia.org/T89987#1095648 (10KLans_WMF) [15:57:59] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: As an engaged reader, I'd like to know that I can share cards with interesting facts on. - https://phabricator.wikimedia.org/T89988#1095647 (10KLans_WMF) [15:58:49] 'coreyfloyd have you noticed this? [15:59:18] bearND: halp! my git hooks aren't generating change ids anymore :-( [15:59:49] bgerstle are you commuting with the no verify command? [16:00:02] yes :-/ [16:00:19] oh damnit [16:00:24] that bypasses ALL hooks [16:00:28] Lol. Yep [16:01:08] It sounds like you don't want the uncrustify commit hook. You can just uninstall it. [16:01:17] And run it by hand [16:01:32] yeah [16:02:11] (03PS1) 10Bgerstle: fix testing target [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194873 [16:02:13] yay it works [16:02:18] coreyfloyd: quick review plz ^ [16:02:35] bgerstle: it's actually strange that hit review has now command to apply the change Id. It relies solely on the commit hook. [16:02:49] Also I can't type [16:03:21] coreyfloyd: there's a '-i' command to regen a change id, but i guess it assumes that there is one to update [16:03:23] * bgerstle shrug [16:04:11] (03PS1) 10Yurik: Implemented api action=editcollection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194874 [16:04:14] (03PS1) 10Bgerstle: uncrustify pass to fix linting errors [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194875 [16:04:26] Bgerstle Yeah but it uses the commit hook to do it. [16:05:38] bgerstle: I haven't looked at the source but I have the feeling that -i just executes git commit --amend [16:06:06] coreyfloyd: so i had a commit w/o a change id [16:06:10] and i tried `git review -i` [16:06:16] hoping it would just add one and submit for review [16:06:20] that's not what happened :-( [16:06:43] (03PS2) 10Yurik: Implemented api action=editcollection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194874 [16:08:01] bgerstle: weird that a command line tool relies on a commit hook to do its task [16:08:10] Should be the other way around [16:08:54] * bgerstle shrugs again [16:08:56] * bgerstle longs for GH [16:09:07] bearND: ^^ let's join forces and push for github! [16:33:56] dr0ptp4kt: [16:33:57] hey [16:34:05] bgerstle: yo [16:34:11] making some tweaks to the patch, how do i check that a crash report was sent? [16:34:27] i'm using the dev bundle & app ID [16:34:50] bgerstle: one moment, i'll add you to hockeyapp [16:35:35] dr0ptp4kt: also i fixed the project stuff in https://gerrit.wikimedia.org/r/#/c/194873/] [16:35:43] if you could review, i can rebase your patch on top to get rid of the project changes [16:35:48] (and a bunch of pod install warnings) [16:36:30] bgerstle: check your email for a hockeyapp invitation, lemme know once you're in [16:36:37] bgerstle: will look at that patch right away [16:36:49] thanks [16:36:52] bgerstle: be sure to download the hockeyapp applicaton for mac os x [16:36:56] coreyfloyd: dr0ptp4kt there's another small uncrustify-related one [16:36:58] ok [16:37:02] bgerstle: they have a web console, but it's kinda nice to have a local tool [16:37:33] <3 zamboni icon [16:37:34] genius [16:37:48] dr0ptp4kt: did you invite bgerstle@wikimedia.org? [16:37:55] bgerstle: yes [16:38:22] bgerstle: you may need to check spam folder [16:38:40] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] fix testing target [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194873 (owner: 10Bgerstle) [16:38:51] nada [16:39:43] ^^ bgerstle ok, please rebase [16:40:19] any chance i could get a quick +2 on the uncrustify patch as well? [16:40:28] bgerstle: yeah, one moment [16:40:30] thanks [16:40:44] (03PS2) 10Dr0ptp4kt: uncrustify pass to fix linting errors [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194875 (owner: 10Bgerstle) [16:41:10] coreyfloyd: bgerstle: I would like to be able to use both Gerrit and Github. Can we sync both ways? [16:41:12] guessing that was a rebase [16:41:19] bearND: only manually AFAIK [16:41:23] and using both will probably be tricky [16:41:24] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] uncrustify pass to fix linting errors [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194875 (owner: 10Bgerstle) [16:41:29] ^ bgerstle thar [16:41:33] \o/ [16:41:36] bgerstle: invitation come through yet? [16:41:49] bgerstle: i resubmitted in hopes it will succeed [16:41:56] bgerstle: resubmitted invitation, that is [16:42:10] nothing yet... [16:42:12] i'll give it a minute [16:42:37] bgerstle: hangout time? [16:42:45] sure [16:42:57] bgerstle: actually, ok if i grab a coffee and then call you on hangout? [16:43:06] phuedx: thanks! [16:43:23] (03CR) 10Jdlrobson: [C: 04-1] "I think this is a bit of yet another overreaction (i mean this feature has been live for 2 years why the hoo ha now? Also we can't just re" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194451 (https://phabricator.wikimedia.org/T85929) (owner: 10Legoktm) [16:45:14] bearND: Yeah I don't think the automatic sync either way will let us do that - I think that basically to make it work we need to push to both remotes [16:45:36] bearND: thats what I hear some other teams do [16:47:09] bearND: it would be nice to use both, have gerrit mirror to GH and have GH pull-requests merges "just work" [16:47:14] i.e. no extra hoops to jump through [16:47:39] i guess that's what two-way mirroring would look like.. [16:47:52] IMHO, we should just use GH and avoid all this hassle [16:48:10] but, if we did, we wouldn't have gotten feedback on crash reporting [16:48:43] there's another thing.. [16:49:01] coreyfloyd: bearND i *think* GH will "just work" if you submit a "patch set" for the merge commit of your pull request [16:49:09] legoktm: ? [16:49:20] phuedx: the phpcs merge :) [16:49:25] if you need to make changes, you abandon that PS and submit a new one w/ add'l commits, etc. [16:49:26] oh yeah! [16:49:32] sure [16:49:38] and when gerrit eventually merges it, GH should update automatically and make the PR as closed [16:49:38] thank you for doing the work :) [16:49:47] s/make/mark [16:49:51] I'll flip the switch in jenkins in a minute [16:50:03] coreyfloyd: bearND up for an experiment to see if it works? ;-) [16:56:04] 10Wikipedia-App-iOS-App: Some map images cause the entire webview to be scrollable left to right - https://phabricator.wikimedia.org/T91702#1095797 (10Fjalapeno) Discovered while working on this bug: https://phabricator.wikimedia.org/T90032 [16:56:10] bgerstle: still unsure about it. Right now I'm more used to Gerrit and probably others in the team as well. The node.js prototype work hopefully will get me more comfortable with GH. [16:56:24] (03PS4) 10Bgerstle: Customize HockeyApp alert dialog [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194821 (owner: 10Dr0ptp4kt) [16:57:12] jdlrobson, around? [16:57:42] (03PS1) 10Legoktm: jenkins job validation, do not submit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194894 [16:59:19] (03Abandoned) 10Legoktm: jenkins job validation, do not submit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194894 (owner: 10Legoktm) [16:59:21] (03PS1) 10Cmcmahon: QA: add a sleep to make Chrome happy. I don't like it. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194896 [16:59:50] bgerstle: e.g. I was surprised that when I pushed to my GH repo with a pending PR it automatically amended that. Also not sure how to best deal with working on different topics. In Gerrit you can just create a local branch and have that as a topic, then you switch the branch/topic if you want to work on something else in the meantime while the code is under review [17:00:38] bearND: i'm not sure what you mean. what you're describing sounds possible in GH [17:00:42] GH is just git [17:00:49] GH only cares about remote branches [17:01:14] so you can do whatever you want :-) [17:02:36] bgerstle: That's cool. What I'm saying is that I still have some learning to do wrt GH, while I personally feel more comfortable with Gerrit atm, since I've been using it for so long. [17:03:05] sure [17:08:22] (03CR) 10Jdlrobson: Implemented api action=editcollection (035 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194874 (owner: 10Yurik) [17:08:41] 10Wikipedia-App-Android-App: NPE in TextSelectedShareAdapter.onTextSelected - https://phabricator.wikimedia.org/T91767#1095855 (10bearND) 3NEW [17:09:51] (03CR) 10Jdlrobson: "It's also worth noting that currently we store one json as a manifest of all the existing collections and one json for each collection. We" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194874 (owner: 10Yurik) [17:12:16] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Customize HockeyApp alert dialog [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194821 (owner: 10Dr0ptp4kt) [17:12:42] jdlrobson, ping [17:12:47] hey yurik [17:13:28] (03CR) 10Jdlrobson: [C: 032] ":(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194896 (owner: 10Cmcmahon) [17:13:34] 10Wikipedia-App-Android-App: NPE in TextSelectedShareAdapter.onTextSelected - https://phabricator.wikimedia.org/T91767#1095881 (10bearND) OTRS: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentZoom&TicketID=8178785 https://ticket.wikimedia.org/otrs/index.pl?Action=AgentZoom&TicketID=8177391 https://ticket.... [17:13:51] jdlrobson, i tried implementing it at first via the model/store classes, but that would have required substantial rewrites, so at the end I gave up and wrote a simple store myself. I feel model/store will need a lot of changes before being useful [17:14:31] jdlrobson, at the end of the day both the special page and the frontend JS should use API only to get all the relevant data [17:14:36] (03Merged) 10jenkins-bot: QA: add a sleep to make Chrome happy. I don't like it. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194896 (owner: 10Cmcmahon) [17:14:55] yurik: okay that makes sense - so the model would be the database and the controller the api basically? [17:15:06] jdlrobson, correct [17:15:14] more or less [17:15:40] morning jdlrobson yurik [17:15:44] the idea here is that you don't want to have multiple logic locations, plus the storage is not defined at the morning [17:15:45] i'm fine with that although i think we need a little abstraction to deal with the fact that a watchlist is a special kind of collection that is stored differently [17:15:46] hi joakino [17:16:05] (different database, some implied values) [17:16:07] jdlrobson, true, but that should all be hidden beneeth the api [17:16:22] hence i actually kept the "watchlist" names ;) [17:16:40] joakino: what do you think? it sounds okay to me. [17:17:13] also would it make sense in this interim to store everything in MobileWebGatherCollections.json ? [17:17:30] 6Mobile-Web: Mobile search in Firefox repeats first letters - https://phabricator.wikimedia.org/T91771#1095899 (10Darkdadaah) 3NEW [17:17:38] or do we think we can database storage sometime next week? [17:17:44] jdlrobson: yurik: it is a matter of design of the code, i designed what is there thinking special page, and api would consume stores, stores implement an interface so that they can be easily exchanged. a different design can be fine too [17:18:50] joakino, my concern mostly lies in the fact that you are trying to replicate the whole database with the model. Databases are much better at this - for example if you ask for partial items, etc [17:19:13] hence, wrapping everything as a model introduces way more problems than solving them [17:19:42] yurik: yep, it's tradeoffs, for storing jsons it's actually pretty useful if you implement serialization and hydration of the models [17:19:44] it would be fine for the api to have subclasses/models/whatever to abstract the actual storage, but it should not be exposed beyond that [17:20:01] 👍 [17:20:23] right, but it would be unrealistic to have the collections stored as json - people could have tens of thousands of pages [17:20:35] (03PS3) 10Jdlrobson: Implemented api action=editcollection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194874 (https://phabricator.wikimedia.org/T91304) (owner: 10Yurik) [17:20:38] plus we would want to be able to subscribe [17:20:43] yurik: yep, and race conditions are a serious problem [17:21:04] and subscribtions mean cross-joining multiple tables [17:21:05] and there is a lot of things you can't do now (or are difficult) like asking in an article which collections include it [17:21:13] exacly [17:21:16] yurik: yep, we definitely need dbs [17:21:26] yep, hence bye bye model :) [17:21:38] i'm sure i will keep parts of it [17:21:52] but just i feel that it shouldn't be exposed to data consumers [17:22:27] yurik: 👍, I trust you with the design, just expose a consistent api for the special page and the js frontend :D [17:22:54] obviously, now i need to figure out what you actually use on the special page - it might need some reworking [17:23:23] i just stared on the apiQueryCollections, should be another few hours for that and for apiQueryCollectionPages [17:23:33] afterwards can deal with other stuff [17:23:33] awesome [17:25:17] 10Wikipedia-App-Android-App: NPE in TextSelectedShareAdapter.onTextSelected - https://phabricator.wikimedia.org/T91767#1095928 (10Deskana) Well I guess we know people really are selecting things then! ^_^ [17:26:00] 10Wikipedia-App-Android-App: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1095929 (10bearND) Yes, I suspect the edit token expired after a while. I agree that this definitely should be looked at. Regarding translations: I'm attaching a screenshot {F57066} of the... [17:27:51] sounds good yurik! [17:28:23] joakino: quick check in - what are you working on/ [17:28:58] https://phabricator.wikimedia.org/T90990 < joakino on that subject i'm pretty sure jon katz said to ignore deletion [17:28:59] jdlrobson: Nothing concrete atm, just came back. This morning i've cleared the frontend patches, all patched up and merged [17:29:04] jdlrobson: went cowboy [17:29:10] and to not wire it up to new creation [17:29:21] so i think that's done from his perspective [17:29:31] but there's no harm in having a patch [17:29:54] jdlrobson: awesome, is there anything more important before that? [17:29:55] i didnt really understand why he was saying it didnt matter [17:30:10] https://phabricator.wikimedia.org/T91302 is probably important as is this bug i just noticed -https://phabricator.wikimedia.org/T91765 [17:30:18] (03PS1) 10Phuedx: [Tablet] Give all content the same gutter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194899 [17:30:19] i can take a look at the qunit stuff [17:30:24] jdlrobson: i feel we can have a delete button at the bottom of that same overlay and accomplish everything with the actual overlay with the sortable items and the edit/delete button [17:30:32] (for the moment [17:31:13] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (https://phabricator.wikimedia.org/T91745) (owner: 10Jhernandez) [17:31:25] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Standardise the way the text is layed out in share cards on Android - https://phabricator.wikimedia.org/T91721#1095940 (10Deskana) [17:31:43] jdlrobson: yeah, check the qunit crap, it's not finding the ext.gather.watchstar, so weird [17:32:03] joakino: where are you seeing that issue? [17:32:07] jdlrobson: about the other two, i'll grab the blank overlay T91765 [17:32:15] joakino: sweet just assign you [17:32:23] 👍 [17:33:43] ok brb just need to get myself coffee and other morning stuff. back in a bit [17:36:40] (03PS3) 10Fjalapeno: TOC performance [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 (owner: 10Mhurd) [17:37:51] (03PS4) 10Fjalapeno: TOC performance Bug:T91087 Bug:T91330 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 (owner: 10Mhurd) [17:44:52] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [SPIKE 2 hrs] Performance: Facial detection speed-ups - https://phabricator.wikimedia.org/T91091#1095983 (10Fjalapeno) a:3Fjalapeno [17:47:30] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [SPIKE 2 hrs] Performance: Facial detection speed-ups - https://phabricator.wikimedia.org/T91091#1095995 (10Fjalapeno) If you just do this in the background, then the image "jumps" when the face is detected. To make this work without jumping, we would have... [17:48:21] jdlrobson, joakino, it seems it would be a bit easier to enforce each collection to have a unique label (per user) [17:48:37] do we have to support multiple identical collection names? [17:48:55] robson ran away [17:49:03] yurik: not sure, SF is waking up, lets ask jon katz when he shows up [17:49:21] (03PS2) 10Phuedx: [WIP] Give all content the same gutter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194899 [17:49:52] yurik: it doesn't make much sense IMO, but lets ask PM [17:50:27] 10Wikipedia-App-Android-App: NPE in TextSelectedShareAdapter.onTextSelected - https://phabricator.wikimedia.org/T91767#1096005 (10bearND) Yeah. I'm glad we did push out the beta release yesterday, so we can find this issue before we publish to production. [17:51:53] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: LeadImage drawRect call frequency and CPU cost - https://phabricator.wikimedia.org/T91089#1096006 (10Fjalapeno) Hmmm… I'm not actually seeing draw rect called that much - just on article load. Lets move this to the back of the line since it i... [17:52:27] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: 4.0.6..3 - deleting a selected Saved page takes >20 sec - https://phabricator.wikimedia.org/T91100#1096008 (10Fjalapeno) a:3Fjalapeno [17:56:38] 10Wikipedia-App-iOS-App: Performance: UI locks while typing a search Term - https://phabricator.wikimedia.org/T91775#1096012 (10Fjalapeno) 3NEW [17:56:43] bgerstle: you still talking with vibha? [17:56:46] jdlrobson: hi :) [17:56:51] dr0ptp4kt: whoops sorry [17:56:53] working on image gallery stuff [17:57:02] did you still need something? i saw you merged the patch [18:00:47] yurik why would it be easier? from my perspective the only thing unique needs to be the list id [18:00:58] the name is only ever used for display purposes [18:01:21] my only issue is then i have to worry about doing client side validation for that :) [18:01:26] and suitable error handling [18:01:31] so that makes my life trickier :) [18:02:03] hi [18:03:24] kaldaryana [18:03:38] kaldari maryana satndup? [18:04:23] yurik: joakino ^ [18:04:34] not sure if i missed cnversation during coffee gathering [18:04:38] not sure why it disconnected [18:05:19] jdlrobson2: nah, i just said lets ask jonkatz just in case he had something in mind about that [18:05:41] joakino: he doesn't care - he said what ever keeps things simpler [18:05:49] im just curious why it makes things easier from yurik pov [18:06:30] easier when enumerating, looking up, etc [18:06:41] lots of minor issues are solved with uniqueness [18:07:03] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 5Patch-For-Review: Performance: Make TOC only render when visible - https://phabricator.wikimedia.org/T91087#1096056 (10Fjalapeno) For a test, I scrolled Barack Obama top to bottom while the TOC was closed. You can see the improvement in the instruments b... [18:07:14] for example, you query collections by label, and if there are multiple, your iteration code has to take that into account [18:07:42] (03PS1) 10Jdlrobson: Improve styling of Special:Gather on Vector skin [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194907 [18:07:49] yurik: we query by id.. [18:08:00] id is actually better as names could be long [18:08:14] e.g. "My very long list of all the people i'd like to thank in my graduation speech" [18:08:16] yurik: yep for title, description and owner you can get multiple results, for id just one or none [18:08:29] the label is only presentation [18:08:32] it's not meant for querying [18:08:50] (03CR) 10Phuedx: [C: 031] Retrieve WikiBase ID using M.util [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/194671 (owner: 10Bmansurov) [18:09:04] the id should be a database key [18:09:27] so my watchlist might be associated when id 40284818 for instance [18:09:44] joakino: made some minor fixes to presentation on vector > https://gerrit.wikimedia.org/r/194907 [18:10:13] jdlrobson2: cool! lets see [18:10:28] bgerstle: sorry, stepped away [18:10:46] bgerstle: i think we're okay. [18:10:57] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: 4.0.6..3 - deleting a selected Saved page takes >20 sec - https://phabricator.wikimedia.org/T91100#1096070 (10Fjalapeno) Just tested on iOS 6 / iPhone 4 - no significant delay - maybe 1 s Moving on to testing iPhone 6 / iOS 8… [18:11:12] i was going to ask you something about the #if, but i just realized it's okay....with my BRAIN [18:12:26] joakino: only minor tweaks [18:13:06] jdlrobson2: xDD borderbox haha [18:13:09] quick! merge [18:13:12] 6Mobile-Web: Section message boxes are hidden - https://phabricator.wikimedia.org/T91536#1096091 (10KLans_WMF) a:3Maryana [18:13:26] (03CR) 10Jhernandez: [C: 032] Improve styling of Special:Gather on Vector skin [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194907 (owner: 10Jdlrobson) [18:14:35] jdlrobson2: my gather page is in a weird state now http://i.imgur.com/KwfAgWW.png [18:14:44] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: 4.0.6..3 - deleting a selected Saved page takes >20 sec - https://phabricator.wikimedia.org/T91100#1096095 (10Fjalapeno) Also unable to repro on iOS 8. Need more info on how to reproduce [18:14:56] 6Mobile-Web, 10VisualEditor: Editor switcher styling regression - https://phabricator.wikimedia.org/T91283#1096096 (10KLans_WMF) [18:15:12] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: 4.0.6..3 - deleting a selected Saved page takes >20 sec - https://phabricator.wikimedia.org/T91100#1096098 (10Fjalapeno) 5Open>3Invalid a:5Fjalapeno>3Etonkovidova [18:15:15] joakino: lolz [18:15:20] 6Mobile-Web, 10VisualEditor: Editor switcher styling regression - https://phabricator.wikimedia.org/T91283#1078925 (10KLans_WMF) @khammerstein can you take a look at this? [18:15:28] pixel art! [18:15:43] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: 4.0.6..3 - deleting a selected Saved page takes >20 sec - https://phabricator.wikimedia.org/T91100#1074300 (10Fjalapeno) Elena - can you provide more info - I was unable to repro? [18:16:23] phuedx: Can you review this one too? https://gerrit.wikimedia.org/r/#/c/194439/ [18:16:30] bmansurov: sure [18:16:32] sec [18:17:49] (03CR) 10Jdlrobson: [C: 032] Update jscs version [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/194439 (owner: 10Bmansurov) [18:18:04] oh thanks [18:18:19] FlorianSW: hey, replied to https://gerrit.wikimedia.org/r/#/c/194716/ [18:18:28] bmansurov: probably want to update grunt-jscs too [18:19:02] bmansurov: ah, ok :D [18:19:12] (03CR) 10Florianschmidtwelzow: [C: 032] Beta: Don't close ReferencesDrawer on scroll (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194716 (https://phabricator.wikimedia.org/T87050) (owner: 10Bmansurov) [18:19:30] jdlrobson2: yeah we should [18:19:45] jdlrobson2: hi :) one question: if i want to reuse icons from VE, how i attribute them? [18:19:56] (03Merged) 10jenkins-bot: Improve styling of Special:Gather on Vector skin [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194907 (owner: 10Jdlrobson) [18:19:58] (03Merged) 10jenkins-bot: Update jscs version [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/194439 (owner: 10Bmansurov) [18:20:11] 6Mobile-Web, 5Patch-For-Review: Scrolling issues in beta with new ReferencesDrawer - https://phabricator.wikimedia.org/T87050#1096117 (10bmansurov) 5Open>3Resolved a:3bmansurov [18:20:35] kristenlans: i'm already assigned to the ticket, anything else i need to do? [18:22:02] bgerstle: this is the one I noticed: https://phabricator.wikimedia.org/T91128 [18:22:10] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [18:22:19] FlorianSW: no idea..:/ [18:22:39] hmm, damn :D bmansurov ? kaldari ? :) [18:22:57] jdlrobson2: did we never re-used images? [18:23:00] FlorianSW: you want to know the class of icons? [18:23:06] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: 4.0.6.3 Image gallery - images(svg) blurred on the black background - https://phabricator.wikimedia.org/T91128#1096138 (10BGerstle-WMF) a:3BGerstle-WMF [18:23:09] (03Merged) 10jenkins-bot: Beta: Don't close ReferencesDrawer on scroll [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194716 (https://phabricator.wikimedia.org/T87050) (owner: 10Bmansurov) [18:23:11] (03PS1) 10Jdlrobson: Hygiene: Update Gruntfile for jscs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194914 [18:23:13] kristenlans: updated ^, but that's already "ready for signoff" [18:23:16] i'm working on another one [18:23:24] FlorianSW: you want to copy an icon from oojs ui into mobile? [18:23:27] bmansurov: no :) We're open source, so normally you need to attribute the author of every third party work, e.g. images of VE [18:23:33] (03CR) 10Bmansurov: "Same as I did: https://gerrit.wikimedia.org/r/#/c/194671/2/resources/startup/init.js" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194658 (https://phabricator.wikimedia.org/T90777) (owner: 10Bmansurov) [18:23:40] technically all icons should be coming from our design team [18:23:48] bgerstle: ah OK. THat one's in doing. So I wonder who is working on it? :-) [18:23:49] jdlrobson2: it's in VE repo iirc [18:23:58] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: NPE in TextSelectedShareAdapter.onTextSelected - https://phabricator.wikimedia.org/T91767#1096151 (10bearND) [18:24:04] i've moaned numerous times about needing an icon repository for this reason :) [18:24:12] :P [18:24:25] jdlrobson2, bmansurov, FlorianSW: WikiLove uses a 3rd party icon. I credited them in the licensing statement for the extension. [18:25:03] although the icon actually isn’t copyrightable in the US :P [18:25:05] FlorianSW: well in theory icon should be built by design team so just copy across [18:25:25] if it's not we probably shouldn't be using it in mobile anyway [18:26:57] jdlrobson2: can you reply to https://gerrit.wikimedia.org/r/#/c/193289/4/includes/Resources.php ? [18:27:02] jdlrobson2: it's the italic, bold and reference image from VE (it's already used in mobile VE, but all things lives in VE repo atm). I will copy it and ask the VE team after i uploaded the images to gerrit. Thanks kaldari, jdlrobson2, bmansurov :) [18:27:17] FlorianSW: why do we need to copy those across... [18:27:27] these /should/ live in VE [18:27:33] 6Mobile-Web: Section message boxes are hidden - https://phabricator.wikimedia.org/T91536#1096164 (10Maryana) 5Open>3Resolved This is by design to avoid cluttering the reader experience and loading more elements on the page than absolutely necessary (have to think about lower-end device users and slow connect... [18:27:42] mobile shouldn't have its own versions of VisualEditorOverlay (if that's what you are thinking of doing ?) [18:27:46] (03PS5) 10Bmansurov: Expose the header template as a module for other extensions to use [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193289 [18:27:58] bmansurov: seems i didnt hit submit [18:28:03] jdlrobson2: https://phabricator.wikimedia.org/T91752 [18:28:05] (03CR) 10Jdlrobson: Expose the header template as a module for other extensions to use (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193289 (owner: 10Bmansurov) [18:28:15] FlorianSW: looking [18:28:33] florian please no.. [18:29:01] i don't think we should be cluttering up the editor. [18:29:21] from what I understand the VisualEditor team long term plan to replace the wikitext editing experience anyway. [18:29:31] i don't think it's a good use of time right now [18:30:08] unless you can point me at evidence that building that bar is going to drastically improve edit quality or number of edits :-) [18:31:08] (03CR) 10Phuedx: "Yeah. You're right. This is what wikigrok/init.js used to do to." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194658 (https://phabricator.wikimedia.org/T90777) (owner: 10Bmansurov) [18:31:28] i'd much rather we got to a point where the VE editing experience was awesome on tablet and we could think of enabling on mobile [18:31:39] (03CR) 10Phuedx: [C: 032] Make WikiBase ID easily retrievable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194658 (https://phabricator.wikimedia.org/T90777) (owner: 10Bmansurov) [18:31:56] Deskana: do you wanna chat in the batcave about the services stuff? [18:32:04] bearND: Sure. [18:32:36] Deskana: alright. see you there [18:32:51] (03Merged) 10jenkins-bot: Make WikiBase ID easily retrievable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194658 (https://phabricator.wikimedia.org/T90777) (owner: 10Bmansurov) [18:33:06] bearND: Deskana can you invite me to that hangout? [18:33:23] mhurd: https://plus.google.com/hangouts/_/event/c5p2pudvb8s6ckluqf56v791em4 [18:33:25] mhurd: Join that [18:34:23] jdlrobson2: the mobile editor delivers less functions as the standard editor on desktop (without WikiEditor or any other extensions), i think a minimalistic (really really basic) editor is a must have to improve editing on mobile. Nobody (no matter if registered or not) knows wikitext by heart (except some "professional" long-time community members), remember, that the wikitext editor is the standard one and what people m [18:35:09] jdlrobson2: i can not point you to some metrics or something else (because we don't have some) ;) But it's logical :) [18:35:20] i disagree. Wikitext was meant to be a quick language to learn/use (hence the use of the name wiki). We bastardised it and made it complicated :-) [18:35:38] we should be optimising for spelling mistakes / corrections / unformatted text. [18:35:51] and i don't talk about a new or reimplemented VisualEditor for mobile, i talk about some basic features like add ''' Text ''' for bold text and so on into the textarea [18:36:20] bgerstle: i think what you should do if you haven't seen an invitation come through, is sign up yourself for a hockeyapp account using your @wikimedia.org email address, but don't create any apps or teams or anything (i have the primary individual and organizatonal account, and let's not create more accounts). then i bet i can do the invitation and have it come through [18:36:20] I know, but I think those are nice to haves, and right now i'd rather we kept the existing editing experience as stable as possible [18:36:30] any tinkering with it could break stuff and impact editing negatively [18:36:32] dr0ptp4kt: k, let me finish the image gallery stuff first if that's ok [18:36:48] i just don't want you wasting time on effort- would be good to sync up with Maryana and see what she thinks [18:36:52] unless you need my help testing, since crash reporting's probably more important [18:36:54] bgerstle: sure. we can screenshare and get by just fine :) [18:36:57] dr0ptp4kt: FYI I'm at home, so you may want to send me that message on IRC :) [18:37:04] we can't just build things because 1 community member says we should. [18:37:05] bgerstle: ...without you having an account [18:37:15] Deskana: message, hwhat? [18:37:26] jdlrobson2: we have at least 2 community members ;) [18:37:27] Deskana: oh... [18:37:27] and it kinda frustrates me that's usually our approach to development :-) i'd much rather we made use of data to lead these decisions [18:37:30] FlorianSW: lol [18:37:37] Deskana: yeah, for the next sprint: [18:37:39] sad but true hehe [18:37:47] :P [18:37:49] Deskana: audit of existing fetchers and their callers. [18:37:50] just saying [18:38:27] i'm gonna be leaving, getting late here and it's friday! [18:38:55] i wondering, how we want to get data about the difference bewteen the "blank" wikitext editor and an editor with basic features, that we don't have? [18:38:58] phuedx, FlorianSW: any suggestion how I can share a template from MF to WikiGrok? https://gerrit.wikimedia.org/r/#/c/193289/4/includes/Resources.php see jon's comments [18:39:11] (03PS5) 10Jdlrobson: Register qunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (https://phabricator.wikimedia.org/T91745) (owner: 10Jhernandez) [18:39:42] joakino: fixed this if you want one last merge ^ [18:39:46] (i think) [18:39:52] regardless have a great weekend [18:39:59] Deskana: this way we get that work out of the way ahead of time. the first week of april and maybe beyond could include a number of appstore bugfixes, and we could be distracted in a way where we wouldn't do that auditing. that auditing in my view is appropriate due diligence for dropping ios 6 support. my thinking is in the next sprint we do the audit(and if necessary fixes) on the fetcher and callers, then in the sprint after that when [18:39:59] we're done closing all the bugs for the maintenance release, at the end of that sprint (around april 10), we cut the final release supporting ios 6.... [18:40:01] jdlrobson2: i didn't actually start the blank page thing so i've unnassigned myself, will pick what i find there on monday [18:40:01] lots of cerveja and thanks for all your work this stressful week :) [18:40:02] Deskana: that is all [18:40:06] jdlrobson2: yep i'll have a look [18:40:08] joakino: okay i'll take a look [18:40:16] (03CR) 10jenkins-bot: [V: 04-1] Register qunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (https://phabricator.wikimedia.org/T91745) (owner: 10Jhernandez) [18:40:30] jdlrobson2: jenkins doesn't love you ^ xD [18:40:36] FlorianSW: well if you really felt strongly this would make a difference, an a/b test would make sense. Show the bar 50% of the time and then look at whether more edits are made with it / analyse quality of edits made with it [18:40:39] boooo [18:41:09] is this flow? [18:41:23] nope [18:41:26] jdlrobson2: same problem [18:41:35] The module 'ext.gather.watchstar' required by 'ext.gather.watchstar.tests' must exist [18:41:38] jdlrobson2: that sounds like a plan :) [18:42:29] FlorianSW: that, and testing the editor in our supported browsers, text js apis are a bitch (selection range and all that crap) and more in mobile with virtual keyboards [18:42:35] 6Mobile-Web, 10WikiGrok, 5Patch-For-Review: Wikibase id should be retrieveable from M.require( 'util' ) - https://phabricator.wikimedia.org/T90777#1096292 (10bmansurov) 5Open>3Resolved a:3bmansurov [18:43:10] FlorianSW: but sounds like an interesting task! go for it, we'll help as we can [18:43:51] joakino: yes, testing, testing, testing :) thanks! [18:44:55] dr0ptp4kt: So by "fetchers" you mean all the methods that touch the API to get info from them? [18:45:01] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Verify data migrations work from old store release - https://phabricator.wikimedia.org/T91713#1096305 (10Fjalapeno) This isn't really a "task". This is really meant as a methodology for performing QA regression testing of the app. The thrust of this was th... [18:45:15] joakino: im on it [18:45:21] joakino: go have a weekend [18:45:35] mhurd dr0ptp4kt I updated Phab with the instruments results for the patch: https://phabricator.wikimedia.org/T91087 [18:45:44] jdlrobson2: yea its so weird, the tests register properly on/Special:JavaScriptTest/qunit [18:45:46] coreyfloyd: great! [18:45:46] anyway [18:45:51] FlorianSW: you should explore the reverse syntax highlighting again [18:46:02] bb all! [18:46:05] i think this would be more effective than a toolbar [18:46:14] do we still have a task open for that? [18:46:31] i never got my patch working because of the pain of text parsing :-) [18:46:43] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 5Patch-For-Review: Performance: Make TOC only render when visible - https://phabricator.wikimedia.org/T91087#1096311 (10Mhurd) Nice!!! [18:47:20] jdlrobson2: the biggest problem, iirc, was how all the browsers interpret and translate line breaks in content editable fields, right? [18:47:33] i don't know, if we still have an open task for it :/ [18:47:54] maybe but i think that is a super interesting untried experiment [18:47:56] but if i remember the first hours with content-editable i think that this bar should be relativley easy :D [18:48:06] and would be super cool to explore some more [18:48:14] i think the bar is small fish in comparsion :) [18:48:34] interesting, yes, sounds like a hackathon task :( [18:48:37] i can imagine lots of people tweeting about syntax highlighting on wikipedia for example but not at all for the bar :) [18:49:45] :P Why we not already have it in desktop editor? :D [18:50:31] Deskana: yeah. essentially, the first two or three bullets of https://phabricator.wikimedia.org/T91413 [18:50:45] coreyfloyd: thx [18:50:48] bearnd why did you reply maybe to the iOS iteration review mtg? That's the one I moved per your request :P [18:51:20] dr0ptp4kt: so, this upcoming meeting is for prioritizing stories that were already planned? [18:51:27] i.e. you won't be proposing any tech-debt tasks? [18:51:28] 6Mobile-Web: Mobile editor needs basic formatting tools - https://phabricator.wikimedia.org/T91752#1096333 (10Florian) I talked to @jdlrobson in irc and we've agreed to make an A/B test, one editor without any features (like the actual one), and one with some very basic features (like the basic mediawiki editor)... [18:51:30] e.g. setting up build server [18:51:37] coreyfloyd: hangout? [18:51:41] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: LeadImage drawRect call frequency and CPU cost - https://phabricator.wikimedia.org/T91089#1096335 (10Fjalapeno) to be clear - its possible this has been fixed by other performance improvements… [18:51:42] hey the rmoen how was your day off? [18:51:48] mhurd: sure [18:52:07] jdlrobson2: my birthday was pretty nice. [18:52:23] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Get iOS build server set up and serving alpha builds internally - https://phabricator.wikimedia.org/T91786#1096336 (10Deskana) 3NEW [18:52:32] kristenlans: because I'm not an iOS engineer I'm optional. If I say No then it'll probably get deleted from my calendar. [18:52:40] bgerstle: we're going to be starting the filling of https://phabricator.wikimedia.org/tag/mobile-app-sprint-53-android/. some tech debt things are likely to go in there, particularly around build instrumentation [18:52:44] rmoen: cool. we made some good progress yesterday. Gather it starting to get functional but loads of polishing needing. Not sure if you heard but we have yurik helping us with backend and building on your work there so far [18:52:50] so pretty confident that will be unblocked soon [18:53:08] bgerstle: it's a given we'll have bugfixes from the tf external stuff as well, as we march to the submission to aapl [18:53:10] bearnd ah ok sorry i'm gettign confused. TMM (too many meetings) [18:53:13] https://phabricator.wikimedia.org/tag/gather_sprint_c/board/ < keen to get the ready for dev column cleared out today [18:53:34] if you can claim and help with the top 3 cards that would be frigging awesome. [18:53:38] dr0ptp4kt: right. just wondering what the iOS tech backlog looks like and whether we were going to be pulling anything from it for the upcoming sprint [18:53:49] jdlrobson2: i can do that [18:53:49] they should be pretty rewarding and relatively troublefree compared to the other tasks we have been working on :) [18:53:54] sweet thanks rmoen [18:54:18] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Set up XCode dashboard to run unit tests on master branch - https://phabricator.wikimedia.org/T91788#1096355 (10Deskana) 3NEW [18:54:19] bgerstle: new plan on cutting internal tf. after i grab lunch after the prioritization meeting, i'll call you so we can step through creating the record, compiling the app with the right bundle id, uploading, etc. [18:54:43] > php maintenance/convertExtensionToRegistration.php /vagrant/mediawiki/extensions/Gather/Gather.php Seems to be omitting ResourceModules and ResourceFileModulePaths [18:54:46] ^ rmoen [18:54:58] having more extension.json issues [18:55:02] ok sure [18:55:05] they are out of sync again :/ [18:55:07] bgerstle: i think dan has been doing preliminary rounds (indeed, he wants to focus on some tech debt things) [18:55:08] jdlrobson2: i sent this out last week on the list but I have to disappear around noon to goto a doctors visit with Candace. I'll try to get as much possible done before then but I may have to continue when I return [18:55:19] rmoen: i didnt get a reply to that message.. [18:55:25] dr0ptp4kt: but don't we groom the tech backlog? [18:55:34] to a certain extent, i guess [18:56:48] i dunno, i guess i was what you had planned to bring up during the meeting [18:56:53] bgerstle: yeah. we've been week by week grooming it. we're not actually done with the leftmost column, but after a couple more weeks we will have groomed all of the tasks. [18:57:11] dr0ptp4kt: is it a separate phab project? do you have a link? [18:57:24] oh missed the dropping from localsettings comment rmoen [18:57:29] that's weird. Is there a bug for that? [18:57:29] bgerstle: the main board https://phabricator.wikimedia.org/project/sprint/board/782/query/bE24QjugTPbC/ [18:57:44] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-Android: As a user, I'd like lead sentences to be consistent so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1096410 (10Deskana) 3NEW [18:57:52] oh, so the "tech debt backlog" is it? [18:58:06] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Audit fetchers to enable us to sunset iOS 6 support - https://phabricator.wikimedia.org/T91789#1096425 (10Deskana) [18:58:08] and we need to triage stuff from the left column into it? [18:58:19] i guess that's what the plan is for this meeting? [18:59:00] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Services, 3Mobile-App-Sprint-53-Android: Deploy experimental version of mobile apps content service - https://phabricator.wikimedia.org/T91794#1096429 (10Deskana) 3NEW [18:59:20] bgerstle: yeah. bgerstle gotta disconnect and go to the other room on wifi [18:59:25] k [18:59:39] bgerstle: I hear your confusion, I think I can help explain...after I get out of meetings ;-) [18:59:44] ok [18:59:55] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android: Reuse the same WebView for visiting subsequent pages. - https://phabricator.wikimedia.org/T89828#1096438 (10Deskana) [18:59:55] (03CR) 10Dr0ptp4kt: "Optimizations notwithstanding, on iOS 6 the TOC position seems to be accurate after rapid scrolling up and down and swiping or tapping but" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 (owner: 10Mhurd) [19:00:29] 6Mobile-Web, 10VisualEditor: Editor switcher styling regression - https://phabricator.wikimedia.org/T91283#1096454 (10KHammerstein) Thanks @Jdlrobson Lots of things in mobile VE are visually broken or failing user tests. I would love to work on them, but not sure which team has the capacity to fix these bugs.... [19:02:43] jdlrobson2: i don't think there is a bug for that [19:02:47] akaik [19:03:30] rmoen: https://phabricator.wikimedia.org/T91795 [19:03:43] hah ^ :) [19:08:03] 6Mobile-Web: Deemphasise wikitext markup in editor - https://phabricator.wikimedia.org/T91796#1096462 (10Jdlrobson) 3NEW [19:08:18] 6Mobile-Web: Mobile editor needs basic formatting tools - https://phabricator.wikimedia.org/T91752#1096470 (10Jdlrobson) I also questioned whether right now this is a good use of our time. See T91796 for something I think is definitely a good use of time :) [19:08:50] (03PS6) 10Jdlrobson: Register qunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (https://phabricator.wikimedia.org/T91745) (owner: 10Jhernandez) [19:09:16] (03CR) 10jenkins-bot: [V: 04-1] Register qunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (https://phabricator.wikimedia.org/T91745) (owner: 10Jhernandez) [19:09:58] kristenlans: bearND do you have ios devices? [19:10:09] dr0ptp4kt: nope [19:10:14] dr0ptp4kt: yes [19:10:53] kristenlans: i'll add you to the internal testflight list if that's okay with you. you'll get an itunes connect invitation prior to the testflight invitation if you're interested. [19:11:04] dr0ptp4kt: awesome [19:11:33] kristenlans: thx [19:11:38] kristenlans: is it cold? [19:11:46] dr0ptp4kt: I already have tesfligth installled on my phone does that matter? [19:11:48] this is fun, screensharing while i type in irc [19:11:49] jdlrobson2, do we expect to support older mediawikis ? [19:11:49] dr0ptp4kt: yes [19:11:55] kristenlans: it's a new system [19:12:07] jdlrobson2, if not, would rather get rid of all the settings in gather.php and move to extension.json [19:12:48] yurik: that would be nice [19:12:58] dr0ptp4kt: 10-4 [19:13:03] so no need for <1.25 support, rigth? [19:13:15] yurik: let me fix the status quo in https://gerrit.wikimedia.org/r/#/c/194850/ and then i'm more than happy to drop < 1.25 support :) [19:14:21] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-Android: As a user, I'd like lead sentences to be consistent so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1096491 (10Vibhabamba) https://trello.com/c/jMlYFadF/112-improve-the-rea... [19:14:38] coreyfloyd: haha how did i get on “assault weapon” page on the simulator? [19:14:49] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-Android: As a user, I'd like lead sentences to be consistent so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1096492 (10Vibhabamba) [[ https://trello.com/c/jMlYFadF/112-improve-the-... [19:15:09] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android: Hook app up to experimental content service to test the service's viability [NEEDS MORE DEFINITION] - https://phabricator.wikimedia.org/T91798#1096495 (10Deskana) 3NEW [19:15:28] mhurd: is that a path from the main page - think i saw that one while i was testing too [19:15:40] (03PS7) 10Jdlrobson: Register qunit tests and phpunit tests on Jenkins [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (https://phabricator.wikimedia.org/T91745) (owner: 10Jhernandez) [19:15:54] ^ yurik hopefully that will make jenkins happy [19:16:06] (03CR) 10jenkins-bot: [V: 04-1] Register qunit tests and phpunit tests on Jenkins [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (https://phabricator.wikimedia.org/T91745) (owner: 10Jhernandez) [19:17:32] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-Android: As a user, I'd like lead sentences to be consistent so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1096525 (10Mhurd) I don't understand this design. Are we no longer havin... [19:24:44] (03PS8) 10Jdlrobson: Register qunit tests and phpunit tests on Jenkins [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (https://phabricator.wikimedia.org/T91745) (owner: 10Jhernandez) [19:26:01] ^ yurik that should work now. We can then switch over to using extension.json exclusively - I'll raise a bug! \o/ [19:26:17] cool [19:28:21] \o/ green > rmoenhttps://gerrit.wikimedia.org/r/#/c/194850/ [19:29:15] 1 sec [19:33:26] (03CR) 10Phuedx: [C: 032] Retrieve WikiBase ID using M.util [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/194671 (owner: 10Bmansurov) [19:34:02] 6Mobile-Web, 10WikiGrok: Wikibase id should be retrieveable from M.require( 'util' ) - https://phabricator.wikimedia.org/T90777#1096555 (10phuedx) [19:34:04] (03PS1) 10Legoktm: Remove unused $wgGatherMobileSpecialPageResourceBoilerplate [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194926 [19:34:06] (03PS1) 10Legoktm: unset RL boilerplates after usage to avoid polluting the global namespace [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194927 [19:34:06] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-Android: As a user, I'd like lead sentences to be consistent so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1096557 (10Deskana) @mhurd We're going to be meeting at 11am next Monday... [19:34:34] (03Merged) 10jenkins-bot: Retrieve WikiBase ID using M.util [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/194671 (owner: 10Bmansurov) [19:35:28] is rmoenhttps a new scheme? [19:35:30] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-Android: As a user, I'd like lead sentences to be consistent so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1096574 (10Mhurd) @deskana Vibha already set me straight - I thought the... [19:35:51] (03PS1) 10Yurik: action=query & list=collections implementation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 [19:35:53] 10Wikipedia-App-Android-App: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1096577 (10jhsoby) >>! In T75086#1095929, @bearND wrote: > Which translation are you talking about? So, if there is something missing please let me know which language/ which string is miss... [19:36:50] jdlrobson2, ^^ [19:39:19] mhurd: FWIW we just agreed that I'll write emails to mobile-l summarising the planning meetings [19:39:32] mhurd: Since it's tech lead only now [19:39:34] Deskana: cool [19:39:39] mhurd: That'll serve as a nice place to air questions like the one you had on Phab [19:41:28] yurik: \o/ [19:41:29] Deskana: i think i was just confused because usually the design board is where we post designs that are ready to be implemented - and this was really just a screenshot of the problem. vibha updated the image to clarify [19:42:55] (03PS4) 10Yurik: Implemented api action=editcollection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194874 (https://phabricator.wikimedia.org/T91304) [19:43:49] kristenlans: Can you write and send an email to mobile-l documenting that apps team will now send sprint planning summary emails to mobile-l? [19:44:05] kristenlans: I'm writing the emails now, but I figured that some explanation from the scrummaster might help [19:44:46] Deskana: sure [19:44:59] kristenlans: Thanks! [19:45:21] Deskana abou to go into a 2 hour meeting and I need to wrap some other stuff up first, so can't get to it until later. Does that block you? [19:45:36] kristenlans: Nope, I'll send them out anyway. The explanation can come later. [19:45:57] (03PS2) 10Yurik: action=query & list=collections implementation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 [19:45:58] kristenlans: Thanks again! [19:46:11] Deskana np [19:46:47] (03CR) 10Jdlrobson: [C: 032] Remove unused $wgGatherMobileSpecialPageResourceBoilerplate (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194926 (owner: 10Legoktm) [19:46:52] (03PS2) 10Jdlrobson: Hygiene: Remove unused $wgGatherMobileSpecialPageResourceBoilerplate [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194926 (owner: 10Legoktm) [19:47:06] (03PS2) 10Jdlrobson: Hygiene: unset RL boilerplates after usage [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194927 (owner: 10Legoktm) [19:47:23] (03PS3) 10Jdlrobson: Hygiene: unset RL boilerplates after usage [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194927 (owner: 10Legoktm) [19:47:27] (03CR) 10Jdlrobson: [C: 032] Hygiene: unset RL boilerplates after usage [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194927 (owner: 10Legoktm) [19:47:38] (03CR) 10Jdlrobson: [C: 031] Hygiene: Remove unused $wgGatherMobileSpecialPageResourceBoilerplate [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194926 (owner: 10Legoktm) [19:47:43] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove unused $wgGatherMobileSpecialPageResourceBoilerplate [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194926 (owner: 10Legoktm) [19:48:29] (03Merged) 10jenkins-bot: Hygiene: Remove unused $wgGatherMobileSpecialPageResourceBoilerplate [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194926 (owner: 10Legoktm) [19:52:15] (03PS1) 10Robmoen: Add watchlist to user collections list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194936 (https://phabricator.wikimedia.org/T91777) [19:52:35] (03PS9) 10Dbrant: Single "read next" item at the bottom of articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193974 [19:53:26] (03PS1) 10Jdlrobson: Hygiene: Make special pages group 'other' [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194938 [19:53:57] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make special pages group 'other' [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194938 (owner: 10Jdlrobson) [19:54:18] (03CR) 10Robmoen: "Not sure why yet but this works for Special:Gather. Title is [object Object] on add to collection workflow" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194936 (https://phabricator.wikimedia.org/T91777) (owner: 10Robmoen) [19:54:27] yeah could you take a quick look at ^ [19:54:34] strange issue with the title [19:55:33] (03PS2) 10Jdlrobson: Hygiene: Make special pages group 'other' [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194938 [19:55:57] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make special pages group 'other' [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194938 (owner: 10Jdlrobson) [19:57:03] rmoen: one second. i dont think we can merge anything right now [19:57:17] jdlrobson2: is there a reason 'ext.gather.styles' has group => other ? [19:57:26] legoktm: it is only loaded on Special:Gather [19:57:39] group stops it from breaking cache [19:57:42] jdlrobson2: tis not really in a state to merge as there is an issue. I just pushed it to get your opinion [19:58:02] rmoen: no just a general issue [19:58:15] there is an issue due to extension.json not being correct [19:58:21] right [19:58:43] will take a look after ive done that - gimme a few mins [19:58:52] np [20:00:51] (03PS9) 10Jdlrobson: Register qunit tests and phpunit tests on Jenkins [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (https://phabricator.wikimedia.org/T91745) (owner: 10Jhernandez) [20:01:32] (03PS2) 10Robmoen: Add watchlist to user collections list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194936 (https://phabricator.wikimedia.org/T91777) [20:02:43] (03PS10) 10Dbrant: Single "read next" item at the bottom of articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193974 [20:02:59] (03PS3) 10Jdlrobson: Hygiene: Make special pages group 'other' [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194938 [20:03:01] (03PS10) 10Jdlrobson: Register qunit tests and phpunit tests on Jenkins [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (https://phabricator.wikimedia.org/T91745) (owner: 10Jhernandez) [20:03:19] ^ rmoen okay those should get our phpunit tests up and running [20:03:27] and get extension.json back to a sane state [20:04:13] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make special pages group 'other' [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194938 (owner: 10Jdlrobson) [20:05:52] (03CR) 10Robmoen: [C: 032] Register qunit tests and phpunit tests on Jenkins [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (https://phabricator.wikimedia.org/T91745) (owner: 10Jhernandez) [20:06:34] ok folks [20:06:38] gonna call it a night [20:06:55] (03Merged) 10jenkins-bot: Register qunit tests and phpunit tests on Jenkins [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (https://phabricator.wikimedia.org/T91745) (owner: 10Jhernandez) [20:07:17] MaxSem: you said https://gerrit.wikimedia.org/r/#/c/177448 was working, right? [20:07:27] (03PS4) 10Dbrant: Update event logging for Read Next. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194201 [20:07:28] if so, then i'll do a functional review too :) [20:07:37] (03PS4) 10Jdlrobson: Hygiene: unset RL boilerplates after usage [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194927 (owner: 10Legoktm) [20:07:37] yep [20:07:54] (03CR) 10Jdlrobson: [C: 031] "attempt" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194927 (owner: 10Legoktm) [20:07:59] (03CR) 10Jdlrobson: [C: 032] "2" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194927 (owner: 10Legoktm) [20:08:36] cool.io [20:08:46] bgerstle, coreyfloyd, mhurd, bearND|lunch: High-level summaries of the sprint planning have been sent to mobile-l. :-) [20:09:00] Deskana: yay! [20:09:04] (03Merged) 10jenkins-bot: Hygiene: unset RL boilerplates after usage [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194927 (owner: 10Legoktm) [20:09:05] woot [20:09:17] thanks [20:09:55] (03CR) 10Robmoen: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194938 (owner: 10Jdlrobson) [20:10:24] gn folks [20:10:32] gn phuedx [20:10:32] have a <3ly weekend y'all [20:11:19] phuedx: Farewell! [20:11:38] Hello. As someone who occasionally wants to contribute, what bucket should I be looking at on phabricator? [20:13:38] Saltymule: Which project do you want to contribute to? [20:13:43] rmoen: not sure what the question is [20:13:50] iOS [20:14:20] Is bug backlog fair game? [20:14:25] Saltymule: Absolutely! [20:14:31] Ok [20:15:00] Saltymule: And, actually, the top two issues are ones I filed a few days ago that are particularly annoying. [20:15:12] Saltymule: You'd make me a very happy product manager if you fixed them. :-) [20:15:18] jdlrobson2: In regards to my patch? Wondering where the CollectionInfo for watchlist has gone wrong. [20:15:23] Saltymule: Thanks for helping out! :-D [20:15:33] Ok, maybe I'll look at them this weekend. [20:15:52] rmoen: i'll take a look after lunch but i imagine the object you are seeing is because the Title is getting stored not getTitleText [20:16:37] jdlrobson2: my thoughts too, though its working correctly on Special:Gather. . I'm going to poke more at it just wanted a second opinion [20:16:52] also the entry point seems wrong on that patch [20:17:11] or at least in newFromUser there should be if page doesn't exist set it up [20:17:34] jdlrobson2: have we any standard way to get a 50% bucket of users (e.g. for an a/b test :P)? [20:18:02] youll need to setup a schema [20:18:07] but bucketing is done in wikigrok [20:18:44] if this is still toolbar related i do predict that you will not see any significant data in an A/B test. I'm pretty confident it will have no effect on editing [20:19:24] (but if you are really interestingyou should continue - i just don't want you to come out disappointed :-)) [20:20:37] thanks for your care :) I think it should have a chance :-) [20:22:30] Deskana: I note that the 'share a fact' feature works for fair use images as well as free ones, and adds CC icons to them. [20:23:36] Is image licensing handled at all, or is the CC icon intended to just cover the text? [20:25:34] coreyfloyd: any news on the scroll bits? [20:31:44] bgerstle: there? ready to get this party started? [20:33:09] what party? [20:33:15] in 30min? [20:33:19] oh wait [20:33:22] the hockeyapp party [20:33:47] sorry, i'm heads-down in image gallery [20:33:47] can talk now if you want [20:34:19] dro [20:34:21] dr0 [20:34:22] bahh [20:34:24] dr0ptp4kt: ^^^ [20:34:48] bgerstle: let's talk. we gotta get this done [20:34:50] bgerstle: sometime i type git commands into chat [20:34:59] mhurd: git stash save [20:35:00] i mean what? [20:35:01] :-P [20:35:04] lol [20:35:12] been doing a lot of stashing & popping [20:35:20] dr0ptp4kt: k, i'll register for TF now [20:35:27] i mean hockeyapp [20:39:53] 10Wikipedia-App-Android-App: Share A Fact images do not include license or attribution info about the image - https://phabricator.wikimedia.org/T91811#1096747 (10Ragesoss) 3NEW [20:42:02] mhurd: took a food break first [20:42:13] mhurd: back on it in a sec [20:42:18] coreyfloyd: no rush! [20:50:55] (03PS3) 10Robmoen: Add watchlist to user collections list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194936 (https://phabricator.wikimedia.org/T91777) [20:58:33] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: NPE in TextSelectedShareAdapter.onTextSelected - https://phabricator.wikimedia.org/T91767#1096764 (10Dbrant) a:3Dbrant [20:59:00] (03PS1) 10Florianschmidtwelzow: WIP: Add basic features to mobile wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194945 (https://phabricator.wikimedia.org/T91752) [20:59:15] 6Mobile-Web: Section message boxes are hidden - https://phabricator.wikimedia.org/T91536#1096769 (10TheDJ) 5Resolved>3declined [21:00:07] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add basic features to mobile wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194945 (https://phabricator.wikimedia.org/T91752) (owner: 10Florianschmidtwelzow) [21:01:06] 6Mobile-Web: Section message boxes are hidden - https://phabricator.wikimedia.org/T91536#1089629 (10TheDJ) Reclassified closure as declined I don't know. I find this somewhat shortsighted. If you ARE doing this, then do it only for phone sizes. But the whole closure sounds a bit like: "Yes we know the boat is l... [21:01:38] bgerstle: coreyfloyd setting up av... [21:01:45] ok [21:02:08] 6Mobile-Web: Section message boxes are hidden - https://phabricator.wikimedia.org/T91536#1096771 (10TheDJ) Another report, this time concerning tmbox being fully hidden: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Invisible_templates [21:02:35] 10Wikipedia-App-Android-App, 6WMF-Legal: Share A Fact images do not include license or attribution info about the image - https://phabricator.wikimedia.org/T91811#1096780 (10Krenair) [21:06:05] 6Mobile-Web: Section message boxes are hidden - https://phabricator.wikimedia.org/T91536#1096803 (10TheDJ) To put it in a different way, ignoring problems like this, in this way, is what led to shit storms when MMV and the typography refresh finally went live. It's ill advised. [21:10:32] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: NPE in TextSelectedShareAdapter.onTextSelected - https://phabricator.wikimedia.org/T91767#1096822 (10Dbrant) (Reproduced on emulator running 4.2) [21:11:09] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-Android: As a user, I'd like lead sentences to be consistent so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1096830 (10bearND) How will a reader, in addition to seeing the transfor... [21:14:02] "Section message boxes are hidden" ok, in my role as a "senior" consultant on community stuff, i'm telling you. pay attention to this. it's important :) [21:15:16] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-Android: As a user, I'd like lead sentences to be consistent so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1096833 (10Deskana) @bearND Exactly. :-) We'll discuss this, and other... [21:19:16] afk for lunch [21:22:57] 10Wikipedia-App-Android-App, 6WMF-Legal: Share A Fact images do not include license or attribution info about the image - https://phabricator.wikimedia.org/T91811#1096838 (10Deskana) 5Open>3Resolved a:3Deskana In terms of satisfying our legal obligations for attribution, I've been in close consultation w... [21:33:18] 10Wikipedia-App-Android-App, 6WMF-Legal: Share A Fact images do not include license or attribution info about the image - https://phabricator.wikimedia.org/T91811#1096863 (10Ragesoss) Could we embed attribution data as EXIF? It seems like if we're going to bother mentioning a license at all for this little sn... [21:46:25] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Add image attribution info to the image metadata of Share a Fact images - https://phabricator.wikimedia.org/T91821#1096894 (10Deskana) 3NEW [21:49:13] 10Wikipedia-App-Android-App, 6WMF-Legal: Share A Fact images do not include license or attribution info about the image - https://phabricator.wikimedia.org/T91811#1096901 (10Deskana) >>! In T91811#1096863, @Ragesoss wrote: > Could we embed attribution data as EXIF? Nice idea. I've heard that Twitter strips im... [21:50:24] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Add image attribution info to the image metadata of Share a Fact images - https://phabricator.wikimedia.org/T91821#1096894 (10Deskana) [21:55:45] (03PS1) 10Dbrant: Fix crash when highlighting text for sharing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194963 (https://phabricator.wikimedia.org/T91767) [21:59:06] (03PS2) 10Dbrant: Fix crash when highlighting text for sharing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194963 (https://phabricator.wikimedia.org/T91767) [22:02:03] bearND: hey i’ve got some things i have to wrap up this afternoon - could we reschedule for monday? [22:02:24] mhurd: sure. np [22:02:32] bearND: sry :( [22:03:23] bearND: if you have a chance to add that 2nd query and copy the lite file let me know and i’ll try to hack on it over the weekend [22:04:46] mhurd: I've already copied the lite file over, and am pulling in the lead section transform for startes [22:04:49] starters [22:05:22] bearND: awesome! [22:06:05] bearND: quick hangout? [22:16:27] (03CR) 10Jdlrobson: [C: 04-1] Add watchlist to user collections list (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194936 (https://phabricator.wikimedia.org/T91777) (owner: 10Robmoen) [22:18:32] (03PS4) 10Jdlrobson: Hygiene: Make special pages group 'other' [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194938 [22:18:47] (03PS1) 10Yurik: Implemented action=query & list=collectionpages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194964 [22:18:55] jdlrobson2, ^ [22:19:02] hey yurik :D [22:19:05] supports existing watchlist + [22:19:08] collections [22:19:09] ! [22:19:45] pls merge all, otherwise might get confusing with the rebasing [22:19:50] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make special pages group 'other' [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194938 (owner: 10Jdlrobson) [22:19:53] should we kill $wgAPIModules['gather'] ? [22:19:56] patch 2 & 3 are baesd on 1 [22:19:58] or is there useful stuff there [22:20:00] up to you [22:20:12] haven't looked into it [22:20:19] keep it for now [22:20:24] doesn't hurt, just don't use it [22:20:29] i will look at it later [22:21:28] jdlrobson2, i'm off to bed [22:21:41] yurik: thanks a bunch for your work this week :D [22:21:52] ill try and have some review done for you for monday [22:22:33] jdlrobson2, unless there is something major, could you merge all 3 patches [22:22:47] it will be easier for everyone to start working on it [22:22:55] sure. ill leave comments though if i do so be sure to read through them [22:22:57] and i will fix issues as they occure [22:23:01] sure [22:23:09] night [22:23:37] night! :D\ [22:23:39] jdlrobson2, btw, there might be a minor merge conflict between 2 & 3 - two lines should be one after another [22:23:52] you will see [22:40:13] (03PS1) 10Bmansurov: Resolve router deferred on back [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194968 (https://phabricator.wikimedia.org/T91421) [22:47:15] bmansurov: yo [22:47:29] what's up [22:48:15] bmansurov: are wikigrok users supposed expected to be logged-in? [22:48:50] aharoni: depends on the config, we have an option to allow anons too, but I'm not sure if it's turned on [22:49:04] Maryana would know better [22:49:10] I was translating the messages now. [22:49:22] It generally looks good, and translatable, [22:49:24] aharoni: any specific one? [22:49:25] aharoni: no [22:49:37] we show it to both logged in & out users [22:49:38] but it would be really nice to make them gender-aware. [22:50:06] ah, for logged in folks? [22:50:15] because they are very personal and have some imperatives (in some languages imperatives need gender) [22:50:21] so yeah, it would be nice. [22:50:34] agreed! [22:51:16] it would work only for logged-in users, unless you devise some other smart way to let users tell us how they want to be addressed. [22:51:26] not super-essential, but would be nice. [22:52:01] (03PS5) 10Jdlrobson: Hygiene: Make special pages group 'other' [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194938 [22:52:07] i wonder how other web properties' lack of concern for that is impacting language these days.. i was surprised at how many women i heard saying "obrigadO" instead of "obrigadA" in brazil & wondered if that was partly the influence of bad/no i18n.. [22:52:59] anyway, meta question :) [22:53:33] practically speaking, yes, if there's an easy way to detect logged in user gender & translate accordingly, that would be great [22:54:45] Google+ and Facebook have gender info, but we aren't getting near that, right? :) [22:55:21] I wish browsers had it in some way. [22:58:12] mmm instant commons broken for me again. doh [22:59:35] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Mobile apps should use "download" rather than "heart" icon for offline bookmarking - https://phabricator.wikimedia.org/T91834#1097159 (10Jaredzimmerman-WMF) 3NEW [23:01:02] jdlrobson: about that Gather test. there is a new version of selenium out and it seems to be wreaking some havoc on any WMF features that have an overlay. afaict, there is a javascript listener that triggers the overlay, and Chrome isn't waiting for the js properly. [23:01:13] oh dears :( [23:01:16] can we roll back? [23:01:35] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Mobile apps should use "download" rather than "heart" icon for offline bookmarking - https://phabricator.wikimedia.org/T91834#1097168 (10violetto) {F57326} [23:01:47] jdlrobson: well, the older version doesn't support any of the last few version of Firefox. browsers suck. [23:02:46] jdlrobson: Zeljko and I were digging into this earlier today. I'm either going to add some sleep() statements, file an upstream bug, go to Plan B, or all of the above. but not today. [23:03:01] :-/ [23:03:45] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Mobile apps should use "download" rather than "heart" icon for offline bookmarking - https://phabricator.wikimedia.org/T91834#1097176 (10Deskana) I'm curious to hear what @vibhabamba and @msyed have to say about this, considering that they were the ones tha... [23:11:51] (03PS5) 10Fjalapeno: TOC performance Bug:T91087 Bug:T91330 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 (owner: 10Mhurd) [23:42:29] Deskana: omg, i just saw s page's email… best thing i've seen all day [23:42:58] * Deskana goes looking for S's email [23:43:31] Yeah S just won...everything...forever [23:44:18] Whoa. [23:46:58] Maryana: That's incredible. I missed it. [23:48:44] though i suspect all british men are 1 degree of visual separation from david tennant [23:49:01] give or take a few degrees