[00:08:48] Maryana: Is that wishful thinking because you like David Tennant, perhaps? [00:12:27] what? me? no, i, uh.. [00:12:30] * Maryana ducks [00:13:25] MaxSem: https://gerrit.wikimedia.org/r/#/c/189161/ please? [00:15:57] (03PS1) 10Jdlrobson: Add context to watchstar overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194985 (https://phabricator.wikimedia.org/T91302) [00:23:59] (03CR) 10Dr0ptp4kt: "Scrolling rapidly through the TOC caused a sort of disjointed scrolling experience. I've asked @mhurd to comment out the relevant code cau" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 (owner: 10Mhurd) [00:27:01] 6Mobile-Web, 10VisualEditor: Mobile VE - Back and Next buttons should align to top toolbar - https://phabricator.wikimedia.org/T91841#1097328 (10KHammerstein) 3NEW [00:31:20] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Mobile VE - Back and Next buttons should align to top toolbar - https://phabricator.wikimedia.org/T91841#1097336 (10Krenair) [00:34:05] 6Mobile-Web, 10VisualEditor: Mobile VE - Context toolbars are misaligned and confusing users - https://phabricator.wikimedia.org/T91842#1097338 (10KHammerstein) 3NEW [00:37:57] 6Mobile-Web, 10VisualEditor: Mobile VE - tapping a different context item should indicate change - https://phabricator.wikimedia.org/T91843#1097345 (10KHammerstein) 3NEW [00:38:38] (03PS6) 10Bmansurov: Expose the header template as a module for other extensions to use [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193289 [00:40:07] 6Mobile-Web, 10VisualEditor: Mobile VE - Link inspector should have a back or cancel button - https://phabricator.wikimedia.org/T91844#1097351 (10KHammerstein) 3NEW [00:41:50] 6Mobile-Web, 10VisualEditor: Mobile VE - Context Toolbar titles are messed up - https://phabricator.wikimedia.org/T91845#1097358 (10KHammerstein) 3NEW [00:43:52] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Handle nested parentheses and square brackets in Share a Fact even better - https://phabricator.wikimedia.org/T91846#1097372 (10dr0ptp4kt) [00:46:16] 6Mobile-Web, 10VisualEditor: Mobile VE - Toolbar buttons are the incorrect sizes - https://phabricator.wikimedia.org/T91847#1097374 (10KHammerstein) 3NEW [00:46:43] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Trim event logging string length for snippets to 99 characters - https://phabricator.wikimedia.org/T91848#1097381 (10dr0ptp4kt) 3NEW [00:49:27] (03CR) 10Dr0ptp4kt: [C: 04-1 V: 04-1] "An attempt was made to try to reduce the scroll issue, but no luck. Let's pick back up on this next week. We'll cut the TestFlight interna" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 (owner: 10Mhurd) [00:49:38] (03CR) 10Mhurd: [C: 04-1 V: 04-1] "The latest amendment to this patch is broken." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 (owner: 10Mhurd) [00:52:26] (03CR) 10Jdlrobson: [C: 04-1] Expose the header template as a module for other extensions to use (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193289 (owner: 10Bmansurov) [00:53:06] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Mobile VE - Cite dialogue fields are buggy - https://phabricator.wikimedia.org/T91849#1097395 (10KHammerstein) 3NEW [00:53:47] (03CR) 10Jdlrobson: [C: 04-1] "I'm really reluctant to make any changes to the router without tests." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194968 (https://phabricator.wikimedia.org/T91421) (owner: 10Bmansurov) [00:54:37] (03CR) 10Bmansurov: Expose the header template as a module for other extensions to use (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193289 (owner: 10Bmansurov) [00:54:44] (03CR) 10Jdlrobson: Resolve router deferred on back (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194968 (https://phabricator.wikimedia.org/T91421) (owner: 10Bmansurov) [00:56:00] (03CR) 10Bmansurov: "This ain't no guess work, it's pure science." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194968 (https://phabricator.wikimedia.org/T91421) (owner: 10Bmansurov) [00:56:20] https://gerrit.wikimedia.org/r/#/c/193017/ < Deskana do you want me to pick up this work? [00:56:28] bmansurov: lol science. i don't see the science hah :) [00:56:54] jdlrobson2: you can see it if you look within lol [00:57:01] with your heart [01:05:51] (03CR) 10Mhurd: "-1'ed for the third item:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 (owner: 10Mhurd) [01:17:07] (03CR) 10Jdlrobson: [C: 04-1] "Thanks for this Florian." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192095 (https://phabricator.wikimedia.org/T87508) (owner: 10Florianschmidtwelzow) [01:25:51] Why doesn't MF have a version number? [01:26:23] v1 [01:26:29] Reedy: It's called wmf/1.25wmf20. :-) [01:27:11] And when it's on 3rd party wikis that don't show gitinfo... [01:27:23] Then ignore them. :-) [01:28:33] It wasn't them reporting bugs as such [01:28:40] Just wondering what's there [01:41:59] (03PS1) 10Jdlrobson: Implemented api action=editcollection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194999 (https://phabricator.wikimedia.org/T91304) [01:42:19] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Mobile apps should use "download" rather than "heart" icon for offline bookmarking - https://phabricator.wikimedia.org/T91834#1097536 (10Jaredzimmerman-WMF) I'm curious too… [01:44:33] (03PS2) 10Jdlrobson: Implemented api action=editcollection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194999 (https://phabricator.wikimedia.org/T91304) [01:47:24] (03CR) 10Jdlrobson: [C: 031] "Yurik I hope you don't mind but I had to refactor your patch to make sense of it and be able to review it. All I've done is create private" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194999 (https://phabricator.wikimedia.org/T91304) (owner: 10Jdlrobson) [01:48:27] (03CR) 10Jdlrobson: [C: 04-1] "Yuri I got a bit confused when reading this patch so I created https://gerrit.wikimedia.org/r/#/c/194999/ which is basically the same but " (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194874 (https://phabricator.wikimedia.org/T91304) (owner: 10Yurik) [01:50:06] (03CR) 10Jdlrobson: "Sorry.. I wanted to get more review for you for Monday morning. I'm hoping Joaquin will be able to help you." (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194964 (owner: 10Yurik) [01:52:59] (03CR) 10Jdlrobson: "(Also be sure to change the author so you get credit for this work :-))" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194999 (https://phabricator.wikimedia.org/T91304) (owner: 10Jdlrobson) [02:10:05] (03CR) 10Krinkle: Register qunit tests and phpunit tests on Jenkins (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (https://phabricator.wikimedia.org/T91745) (owner: 10Jhernandez) [02:12:16] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Mobile apps should use "download" rather than "heart" icon for offline bookmarking - https://phabricator.wikimedia.org/T91834#1097564 (10Mhurd) Yeah, that download icon seems like a major step back. [02:28:08] bgerstle: mhurd http://junecloud.com/software/safari/betafill.html [02:30:18] Or HockeyApp 😛 [02:32:59] coreyfloyd: bgerstle hehe [02:33:55] bgerstle: coreyfloyd i just don’t understand how this many years have gone by and things like this are still so cumbersome… [02:35:23] bgerstle: coreyfloyd why apple? why?! [02:35:48] Lol [02:35:52] mhurd: it's what happens when you ignore take infrastructure and focus on features 😉 [02:36:08] bgerstle: HAHAHAHAH! [02:36:22] Tech damnit Siri [02:36:38] bgerstle: and the “best comeback of the week” award goes to [02:37:01] :) [02:42:12] mhurd what really grinds my gears is that apple still doesn't give you an HTTP Interface for interacting w/ iTC [02:42:25] at least uploading binaries or maintaining parity w/ TF features [02:42:44] TF even had logging capabilities for analytics and a "TF Live" beta thing [02:43:04] who knows, maybe TF will be a focal point of the March 9th press event [05:37:48] (03PS1) 10Krinkle: grunt: Clean up and pin npm dependencies [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195015 [05:37:50] (03PS1) 10Krinkle: grunt: Make jshint pass [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195016 [05:38:00] (03PS2) 10Krinkle: grunt: Make jshint pass [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195016 (https://phabricator.wikimedia.org/T71838) [06:28:23] (03CR) 10Krinkle: "recheck" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195016 (https://phabricator.wikimedia.org/T71838) (owner: 10Krinkle) [08:36:29] (03PS7) 10Mhurd: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [08:36:31] (03CR) 10jenkins-bot: [V: 04-1] Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [08:43:16] (03PS8) 10Mhurd: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [13:53:51] 6Mobile-Web: Anchors works not corretly in mobile version of web page - https://phabricator.wikimedia.org/T91882#1098057 (10Perekhoden) [14:13:46] 6Mobile-Web: Issues with replying to talk page topics with ajax spinner - https://phabricator.wikimedia.org/T91531#1098072 (10Florian) Hmm, maybe i misunderstand something, but i can't reproduce any problem? If i reply to a discussion i see the ajax loader as long as it takes to save my reply and load the new di... [14:19:51] (03PS1) 10Florianschmidtwelzow: Hygiene: Don't commit Gemfile.lock [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195037 [14:24:03] (03CR) 10Florianschmidtwelzow: TWN: Use own message for terms of use link in license warning (editor and talk) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190831 (owner: 10Florianschmidtwelzow) [14:25:28] (03PS9) 10Florianschmidtwelzow: TWN: Use own message for terms of use link in license warning (editor and talk) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190831 [14:35:16] (03Abandoned) 10Florianschmidtwelzow: Move Editor Cta to the end of the editing process [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192095 (https://phabricator.wikimedia.org/T87508) (owner: 10Florianschmidtwelzow) [14:35:20] 6Mobile-Web, 10MobileFrontend-Feature-requests, 7Design, 5Patch-For-Review: Remove mobile editing "call to registration" CTA - https://phabricator.wikimedia.org/T87508#1098077 (10Florian) > Can we technically attribute an edit post-save to a user who then logs in or make an account? Not that i know a stand... [14:42:36] (03PS1) 10Sumit: Break word added to main heading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195038 (https://phabricator.wikimedia.org/T91281) [14:43:37] 6Mobile-Web, 5Patch-For-Review: Page actions overlaps long titles - https://phabricator.wikimedia.org/T91281#1098091 (10Sumit) The overlap is probably due to long word not breaking, therefore a word-wrap of break word added to top level heading [15:11:36] 6Mobile-Web, 10Flow, 7I18n: the message mobile-frontend-last-modified-with-user-just-now appears unnecessarily on the top of Flow mobile web pages - https://phabricator.wikimedia.org/T91886#1098129 (10Amire80) 3NEW [16:06:16] (03PS5) 10Yurik: Implemented api action=editcollection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194874 (https://phabricator.wikimedia.org/T91304) [16:22:21] (03CR) 10Yurik: [C: 032] Implemented api action=editcollection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194874 (https://phabricator.wikimedia.org/T91304) (owner: 10Yurik) [16:23:29] (03Merged) 10jenkins-bot: Implemented api action=editcollection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194874 (https://phabricator.wikimedia.org/T91304) (owner: 10Yurik) [16:27:28] (03PS3) 10Yurik: action=query & list=collections implementation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 [16:33:20] 6Mobile-Web, 10Flow, 7I18n: the message mobile-frontend-last-modified-with-user-just-now appears unnecessarily on the top of Flow mobile web pages - https://phabricator.wikimedia.org/T91886#1098180 (10Quiddity) Sidenote: in the MF beta, the "last edited" strapline has been moved to the bottom of all pages. [16:36:06] 6Mobile-Web: Anchors works not corretly in mobile version of web page - https://phabricator.wikimedia.org/T91882#1098185 (10Perekhoden) This issue can be cause by "Contents" is expanding after page was loaded and scrolled to anchor by browser itself. So after "Contents" is expanded it puts down page content afte... [16:44:51] (03PS4) 10Yurik: action=query & list=collections implementation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 [16:55:47] 6Mobile-Web, 10Flow, 7I18n: the message mobile-frontend-last-modified-with-user-just-now appears unnecessarily on the top of Flow mobile web pages - https://phabricator.wikimedia.org/T91886#1098233 (10Amire80) [16:56:39] (03PS2) 10Yurik: Implemented action=query & list=collectionpages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194964 [16:57:09] (03CR) 10Yurik: Implemented action=query & list=collectionpages (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194964 (owner: 10Yurik) [17:00:44] (03CR) 10Yurik: "Applied some changes to Iaf6cc4553f2563fb2c9ffce2eac40eb13122253a" (037 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194999 (https://phabricator.wikimedia.org/T91304) (owner: 10Jdlrobson) [17:00:54] (03Abandoned) 10Yurik: Implemented api action=editcollection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194999 (https://phabricator.wikimedia.org/T91304) (owner: 10Jdlrobson) [18:46:02] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1098331 (10Sumit) Just a curious question, the wikivoyage home page uses the banner template( http://en.wikivoyage.org/wiki/Template:Banner ) to render the banners... [19:37:26] (03PS1) 10Saltymule: Don't invoke native bridge if there is selected text [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195060 (https://phabricator.wikimedia.org/T91605) [19:43:31] 6Mobile-Web, 10MediaWiki-Categories, 5Patch-For-Review: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1098438 (10matmarex) >>! In T55130#1092267, @Edokter wrote: > That hurts... :) > > https://developer.mozilla.org/en-US/docs/Web/CSS/... [19:50:44] 6Mobile-Web, 10MobileFrontend-Feature-requests, 5Patch-For-Review: Remove last edited pageimage from Special:Userprofile - https://phabricator.wikimedia.org/T90801#1098441 (10Peteforsyth) @Maryana, your description above includes this suggestion: "A longer-term fix might be to create a way to flag/blacklist... [20:33:28] 10MobileFrontend-Feature-requests, 10UI-Standardization, 7Accessibility, 7Design: Identify the best diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1098461 (10Nemo_bis) [20:45:26] 10MobileFrontend-Feature-requests, 10UI-Standardization, 7Accessibility, 7Design: Identify the best diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1098475 (10Nemo_bis) Core trumps extensions, so there is no doubt about what's the standard. It seems you want to propose a change?... [20:48:04] bearND: hey! [21:11:38] 6Mobile-Web, 10MediaWiki-Categories, 5Patch-For-Review: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1098494 (10Edokter) It works in so far that the paragraphs are not broken up. In the context of pagebreaks, columns are treated as pa... [21:36:09] (03CR) 10Deskana: [C: 031] "Fixes the bug in question." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195060 (https://phabricator.wikimedia.org/T91605) (owner: 10Saltymule) [21:36:12] mhurd: hey [21:36:52] bearND: quick hangout? [21:36:58] 10MobileFrontend-Feature-requests, 10UI-Standardization, 7Accessibility, 7Design: Identify the best diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1098526 (10Jdlrobson) Where does that logic come from? :) Core was built ten years ago when we had different display technologies a... [21:37:32] mhurd: can we do it a bit later. need to hangout with someone in Europe before they go to bed [21:37:36] ? [21:41:06] bearND: oops got disconnected [21:42:05] 10Wikipedia-App-iOS-App: The side of the "Quick facts" box are cut off - https://phabricator.wikimedia.org/T91907#1098528 (10Deskana) 3NEW [21:42:22] Deskana: ha i was just going to tackle that :) [21:42:52] mhurd: Excellent! [21:43:27] mhurd: You could also review this, if you like: https://gerrit.wikimedia.org/r/#/c/195060/ [21:43:31] Deskana: oh corey and my performance patches didn’t make the release last night - so things will be even faster next week [21:43:50] mhurd: Patch from a volunteer. Seems to fix the bug in question from my perspective. [21:44:15] Deskana: i saw that and tagged adam since he’s dealt with text selection more than i have. it does look good though! [21:44:16] :) [21:59:35] 10MobileFrontend-Feature-requests, 10UI-Standardization, 7Accessibility, 7Design: Identify the best diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1098553 (10Nemo_bis) [21:59:47] Deskana, hey [22:10:41] Deskana: fun fact: in the obama html there are 381 occurences of “ ” [22:22:37] mhurd: wat [22:22:46] Deskana: quick hangout? [22:22:50] ... hello? [22:23:00] Krenair: ...hi! [22:23:43] When do you next plan to release a stable android app, roughly? quite soon? [22:23:56] mhurd: Sure! [22:24:19] Krenair: We're targeting 30th March right now. [22:24:25] okay [22:24:31] do you plan to do another beta before then? [22:25:55] Krenair: Yeah, I think so. [22:26:11] I'd quite like to get https://gerrit.wikimedia.org/r/#/c/194963/ into beta quickly, if not backported into the current branch [22:30:29] Krenair: That shouldn't be a problem. [22:30:47] Krenair: Once it's merged we can just push another beta from master. [22:33:01] mhurd: i'm done with the other hangout [22:41:32] bearND: If you're working and have time to review this patch this afternoon, that'd be great: https://gerrit.wikimedia.org/r/#/c/194963/ [22:41:59] Krenair: Deskana: yep, I'm going to look at that patch soon [22:42:11] bearND: Thanks! [22:42:11] Deskana: Tsk, stop making your devs work on a Saturday. :-) [22:42:41] James_F: Think of the users, James! [22:42:46] James_F: Think of the users... [22:43:03] Think of the users who won't be served well in bearND needs a month off from your hectoring! ;-) [22:43:42] ^_^ [22:44:55] James_F: A month off sounds like a good deal for a few hours on Saturday ;) [22:45:00] * James_F grins. [22:45:20] bearND: I'm not sure it was an offer. Also, I seem to be 'making' MatmaRex work, so… [22:46:04] James_F: I had noticed. ;-) [22:46:45] bummer [22:47:49] Time to go to the dentist. [22:47:51] Eugh. [22:47:57] Enjoy [22:48:15] on Saturday? [22:48:37] bearND: Yeah, they had appointments today for some reason. [22:48:42] bearND: I was surprised too. [22:48:48] Ta ta! [22:49:05] I'm just glad it's not because of an emergency [23:02:12] (03PS3) 10BearND: Fix crash when highlighting text for sharing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194963 (https://phabricator.wikimedia.org/T91767) (owner: 10Dbrant) [23:04:37] (03CR) 10BearND: [C: 032] "The style changes don't seem to make a difference on my 5.0 device but they don't seem to hurt anything. I still see the action item text " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194963 (https://phabricator.wikimedia.org/T91767) (owner: 10Dbrant) [23:06:20] (03Merged) 10jenkins-bot: Fix crash when highlighting text for sharing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194963 (https://phabricator.wikimedia.org/T91767) (owner: 10Dbrant) [23:13:03] (03PS11) 10BearND: Single "read next" item at the bottom of articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193974 (owner: 10Dbrant) [23:13:21] (03CR) 10BearND: [C: 032] Single "read next" item at the bottom of articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193974 (owner: 10Dbrant) [23:13:43] (03Merged) 10jenkins-bot: Single "read next" item at the bottom of articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/193974 (owner: 10Dbrant) [23:13:55] (03PS5) 10BearND: Update event logging for Read Next. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194201 (owner: 10Dbrant)