[01:31:49] (03PS1) 10Yurik: Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 [01:32:11] (03CR) 10jenkins-bot: [V: 04-1] Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (owner: 10Yurik) [01:42:45] (03PS2) 10Yurik: Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) [01:43:06] (03CR) 10jenkins-bot: [V: 04-1] Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [02:20:27] bearND: hey! [03:57:15] mhurd: hello [03:57:25] bearND: hey! [05:39:25] 10Wikipedia-App-Android-App, 3Roadmap: Production release for Android Wikipedia app in March (provisional) - https://phabricator.wikimedia.org/T91693#1099522 (10Eloquence) Do we have a projected "week of" ETA yet? [05:39:48] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap: Production release for iOS Wikipedia app in March (provisional) - https://phabricator.wikimedia.org/T86692#1099524 (10Eloquence) As for Android, do we have a projected "week of" ETA yet? [06:03:24] 10Wikipedia-App-Android-App, 3Roadmap: Production release for Android Wikipedia app in March (provisional) - https://phabricator.wikimedia.org/T91693#1099527 (10Deskana) Current plan is for both releases to take place on 30th March. We're on track for that, provided that Apple takes less than two weeks to revi... [06:03:28] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap: Production release for iOS Wikipedia app in March (provisional) - https://phabricator.wikimedia.org/T86692#1099528 (10Deskana) Current plan is for both releases to take place on 30th March. We're on track for that, provided that Apple takes less... [08:52:28] good morning! [08:52:38] good morning! [09:03:38] (03PS1) 10Jhernandez: Hygiene: Fix use of __FILE__ [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195220 [09:04:44] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Fix use of __FILE__ [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195220 (owner: 10Jhernandez) [09:05:34] (03CR) 10Jhernandez: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195220 (owner: 10Jhernandez) [09:06:01] (03CR) 10Jhernandez: Register qunit tests and phpunit tests on Jenkins (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194850 (https://phabricator.wikimedia.org/T91745) (owner: 10Jhernandez) [09:19:58] morning [09:20:07] hey joakino [09:20:16] hi phuedx [09:20:20] how was the weekend [09:20:38] good [09:20:41] productive [09:20:50] a lot of diy [09:20:56] george has a new bed, we have more kitchen storage [09:20:59] how about yours? [09:23:12] phuedx: really quiet :) sofa, reading, movies [09:23:21] no need to show off ;0 [09:23:37] saw 'the imitation game', alan turin's movie, it is pretty good [09:23:56] its on good quality already [09:24:04] yeah? i'll watch it when it hits netflix/amazon prime ;) [09:26:47] george has this bed: http://www.ikea.com/gb/en/catalog/products/80253809/ [09:26:50] complete with tent [09:28:32] phuedx: no torrenting? [09:28:39] 10MobileFrontend-Feature-requests, 10UI-Standardization, 7Accessibility, 7Design: Identify the best diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1099646 (10TheDJ) [09:28:49] joakino: i did at uni, but i don't any more [09:29:00] i use torrents to download legal content, obvs! [09:29:15] cool bed :D [09:30:18] phuedx: obviously me too http://i.imgur.com/l81IVZo.jpg?1 [09:30:30] http://i.imgur.com/l81IVZo.jpg [09:37:59] ;) [11:51:27] ok [11:51:34] taking george and harry to a father's group [11:51:35] bbl [12:23:53] (03CR) 10MZMcBride: "Jon: I don't understand your comment. In your final paragraph, you say the only issue you see is the inclusion of images, but in the prece" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194451 (https://phabricator.wikimedia.org/T85929) (owner: 10Legoktm) [12:53:12] (03CR) 10Jdlrobson: [C: 032] Hygiene: Fix use of __FILE__ [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195220 (owner: 10Jhernandez) [12:54:18] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Fix use of __FILE__ [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195220 (owner: 10Jhernandez) [12:57:14] (03PS5) 10Jdlrobson: Promote TalkOverlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [12:58:32] (03CR) 10jenkins-bot: [V: 04-1] Promote TalkOverlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [13:01:43] (03PS3) 10Yurik: Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) [13:02:04] (03CR) 10jenkins-bot: [V: 04-1] Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [13:06:02] (03CR) 10Jdlrobson: [C: 031] "Browser tests work fine (feel free to split out into separate patch if you want those merged asap)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [13:23:36] (03CR) 10Florianschmidtwelzow: "> Browser tests work fine (feel free to split out into separate patch if you want those merged asap)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [13:23:48] (03CR) 10Florianschmidtwelzow: [C: 04-1] Promote TalkOverlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [13:50:21] (03PS1) 10Bgerstle: center images w/ white background [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) [14:19:17] (03CR) 10Bgerstle: [C: 04-1] "broken on iOS 6, stand by..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) (owner: 10Bgerstle) [14:37:23] backsies [14:47:31] (03CR) 10Phuedx: "If we care about IE8/9, we'll need the following as well:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195038 (https://phabricator.wikimedia.org/T91281) (owner: 10Sumit) [14:55:35] (03PS2) 10Sumit: Break word added to main heading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195038 (https://phabricator.wikimedia.org/T91281) [15:14:20] Hi dbrant. Have you had a chance to look at my patch? [15:14:32] bearND: yep! looking now [15:14:36] bearND: beta update today? [15:15:16] dbrant: yes, as soon as this is merged. I'm doing a TWN snc in the meantime [15:15:26] bearND: cool [15:18:49] (03CR) 10Dbrant: [C: 032] Just log the read next items actually shown [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195078 (owner: 10BearND) [15:19:08] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195267 [15:19:18] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195268 [15:31:57] (03CR) 10Phuedx: [C: 04-1] "This is a good start. My comments aren't about the approach, but about the organisation of the code." (037 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [15:32:44] (03CR) 10Phuedx: "That said, varying the cache by device isn't an acceptable solution." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [15:37:35] dbrant: not too happy with the de and lb translations of read next. It translates to Read next section [15:38:23] dbrant: I'll probably push out another qq update [15:38:38] (03PS2) 10BearND: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195267 [15:38:45] (03CR) 10BearND: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195267 (owner: 10BearND) [15:38:49] after this ^ [15:39:11] bearND: hmm... yeah, the qq string could be better :( [15:40:08] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195267 (owner: 10BearND) [15:51:59] (03PS1) 10BearND: Update qq for read_next [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195274 [15:52:10] dbrant: What do you think about ^? [15:52:43] bearND: sure! much better [15:53:05] dbrant: feel free to +2 [15:54:46] (03CR) 10Dbrant: [C: 032] Update qq for read_next [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195274 (owner: 10BearND) [15:55:08] (03Merged) 10jenkins-bot: Update qq for read_next [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195274 (owner: 10BearND) [15:56:30] dbrant: would you like to kick off the beta release or do you want me to do it? [15:57:03] bearND: sure, I can take care of this one. everything good to go? [15:57:21] dbrant: great. Yes, all good to go. [15:58:04] (03CR) 10Phuedx: [C: 032] Break word added to main heading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195038 (https://phabricator.wikimedia.org/T91281) (owner: 10Sumit) [15:58:55] (03PS2) 10Bgerstle: center images w/ white background [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) [15:59:19] (03CR) 10jenkins-bot: [V: 04-1] Break word added to main heading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195038 (https://phabricator.wikimedia.org/T91281) (owner: 10Sumit) [16:02:13] (03PS1) 10Dbrant: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195277 [16:03:24] (03CR) 10Dbrant: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195277 (owner: 10Dbrant) [16:03:47] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195277 (owner: 10Dbrant) [16:06:05] (03PS3) 10Bgerstle: center images w/ white background [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) [16:06:53] coreyfloyd: i think i've done it [16:07:14] well, i don't want to say more in fear of jinxing myself [16:07:27] suffice it to say that i'd love some feedback on that patch there ^ [16:16:15] i bought three bags of coffee beans at the beginning of last week [16:16:36] supplies are already dwindling [16:16:42] i need to kick this habit :/ [16:16:56] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195038 (https://phabricator.wikimedia.org/T91281) (owner: 10Sumit) [16:20:14] (03CR) 10Phuedx: [C: 032] "*prays to the god of Continuous Integration*" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195038 (https://phabricator.wikimedia.org/T91281) (owner: 10Sumit) [16:20:28] who says you can't have fun at work? [16:21:26] (03Merged) 10jenkins-bot: Break word added to main heading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195038 (https://phabricator.wikimedia.org/T91281) (owner: 10Sumit) [16:22:36] phuedx: i recently made an adjustment to my pouring technique [16:22:41] following Blue Bottle's recs [16:22:44] (on their website) [16:22:48] seems to make a difference *shrug* [16:23:00] basically just changed how i bloom the coffee [16:23:27] bgerstle: link [16:23:28] ? [16:23:35] 1 sec... [16:23:48] https://bluebottlecoffee.com/preparation-guides/chemex [16:24:01] bearND: Deskana: beta published [16:24:04] hm, my coarseness might nto be the same.. [16:24:06] \o/ [16:24:35] (03PS4) 10Bgerstle: center images w/ white background [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) [16:24:38] coreyfloyd: sorry, made some pre-emptive refactor updates 6 [16:24:39] ^* [16:25:36] cool [16:25:43] ill take a look [16:25:52] bgerstle: ^ [16:25:59] thanks [16:26:52] coreyfloyd: i added some categories you might like [16:30:12] (03CR) 10Jdlrobson: [C: 04-1] "oops found slight issue" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [16:30:24] \o joakino [16:31:47] (03PS1) 10Cmcmahon: Revert "Hygiene: Don't commit Gemfile.lock" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195294 [16:33:12] (03CR) 10jenkins-bot: [V: 04-1] Revert "Hygiene: Don't commit Gemfile.lock" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195294 (owner: 10Cmcmahon) [16:33:34] phuedx: jdlrobson we need Gemfile.lock in the repo, removing it broke the browser test builds in Jenkins ^^ [16:33:49] (03CR) 10Zfilipin: [C: 031] "Gemfile.lock should be commited. See Bundler documentation. http://bundler.io/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195294 (owner: 10Cmcmahon) [16:34:19] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195294 (owner: 10Cmcmahon) [16:34:47] chrismcmahon: that was mibad, i think committing lock files is a good thing, but we ignore the others [16:34:51] (03PS6) 10Jdlrobson: Remove all images and recent uploads from UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193017 (https://phabricator.wikimedia.org/T90801) (owner: 10Deskana) [16:34:57] once that's checked i'll +2 it [16:35:00] sorry again! [16:35:16] there are still some very bogus tests for file uploads still in the repo, at some point we should remove those in a nice way [16:35:22] no problem! [16:36:00] check yourself before you wreck yourself phuedx [16:37:07] (03CR) 10jenkins-bot: [V: 04-1] Remove all images and recent uploads from UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193017 (https://phabricator.wikimedia.org/T90801) (owner: 10Deskana) [16:37:36] coreyfloyd: would you please code review https://gerrit.wikimedia.org/r/#/c/193323/ ? i'll review after you're good with it [16:38:25] dr0ptp4kt: will do [16:38:39] hi jdlrobson [16:38:44] \o [16:40:09] (03CR) 10Phuedx: [C: 032] Revert "Hygiene: Don't commit Gemfile.lock" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195294 (owner: 10Cmcmahon) [16:40:23] anyone ever seen aaron patterson's ruby talks? [16:40:33] coreyfloyd: after that, would it be possible to address the request made by monte in https://gerrit.wikimedia.org/r/#/c/193344/ ? i _really_ want to get that patch into the tf build as well. understood you'll need a little time to review 193323 first [16:40:47] he said that the best way of getting to the top of the charts for commits on a project was to get things merged and then reverted [16:40:52] * phuedx looks at Florian ;) [16:40:52] bgerstle: i'm going to test https://gerrit.wikimedia.org/r/#/c/195254/ [16:41:21] (03CR) 10jenkins-bot: [V: 04-1] Revert "Hygiene: Don't commit Gemfile.lock" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195294 (owner: 10Cmcmahon) [16:41:41] dr0ptp4kt: k [16:42:14] dr0ptp4kt: I've been testing on my iPhone 6 (iOS 8), iPod touch 4 (iOS 6), and about to fire up my iPad (iOS 8) [16:42:34] thanks flow! [16:42:46] dr0ptp4kt: coreyfloyd i've been thinking of commiting a little file that has a sort of test plan in it for the image gallery [16:42:52] chrismcmahon: the -hhvm tests are failing intermitently [16:42:56] so that people who change it can easily verify regressions [16:43:01] * bgerstle cough cough [16:43:08] bgerstle: :) [16:43:13] sound like an ok idea? [16:43:23] mornin' Maryana. I see that Dario has left a note in the WikiGrok talk today saying that he has two conflicts at that time. Should we move our meeting today to tomorrow, to our weekly check-in, or some other time tomorrow that he can join, too? [16:43:32] bgerstle: yes; i imagine you can express it in 30 minutes or less? [16:43:42] yeah, i'll do it right now [16:43:52] bgerstle: ok, no other code changes on that patch, right? [16:44:05] dr0ptp4kt: i don't believe so [16:44:05] phuedx: yeah, "Unable to fork, can't test merge" I'm not sure what that means. [16:44:06] bgerstle: that is, the only difference when you add the test plan will be that you added a test plan [16:44:12] dr0ptp4kt: yep [16:44:16] maybe some comments [16:44:21] bgerstle: thx [16:44:26] not sure if i should do it as a markdown/mediawiki file or header comments [16:44:34] (03CR) 10Jdlrobson: [C: 032] "We can always reinstate the last upload later, moving this along and getting read of the controversial image seems like the more important" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193017 (https://phabricator.wikimedia.org/T90801) (owner: 10Deskana) [16:44:35] chrismcmahon: also if you look at the full log, then you'll see a load of flow unit tests failing [16:44:43] thinking comments specific to the relevant classes [16:44:58] happy Monday! [16:45:01] bgerstle: md or wikitext good so that youi can point elena at a GitHub URL [16:45:22] (03CR) 10Jhernandez: [C: 032] Hygiene: Update Gruntfile for jscs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194914 (owner: 10Jdlrobson) [16:45:22] dr0ptp4kt: +1 good point [16:45:43] bgerstle: maybe have the header refer to the md / wikitext file so that the code reader knows to look for it [16:45:47] (03Merged) 10jenkins-bot: Remove all images and recent uploads from UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193017 (https://phabricator.wikimedia.org/T90801) (owner: 10Deskana) [16:45:59] dr0ptp4kt: yep [16:46:28] dr0ptp4kt: looks OK on my iPad, writing test docs now [16:48:46] (03CR) 10Phuedx: "Is there a high-level overview of how the response storage and aggregation is expected to work anywhere? Just so I can verify the behaviou" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [16:48:55] (03Merged) 10jenkins-bot: Hygiene: Update Gruntfile for jscs [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194914 (owner: 10Jdlrobson) [16:49:27] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195294 (owner: 10Cmcmahon) [16:52:38] thanks phuedx I think that did it [16:52:55] (03CR) 10Phuedx: [C: 032] Revert "Hygiene: Don't commit Gemfile.lock" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195294 (owner: 10Cmcmahon) [16:53:35] * phuedx crosses fingers [16:54:12] (03Merged) 10jenkins-bot: Revert "Hygiene: Don't commit Gemfile.lock" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195294 (owner: 10Cmcmahon) [17:00:10] leila: yeah, i'll look for another time [17:01:11] phuedx don't forget us [17:01:46] interneeeet [17:02:15] joakino: what pages did you need deleting on beta labs? [17:03:14] jdlrobson: http://en.m.wikipedia.beta.wmflabs.org/wiki/User:Jhernandez/GatherCollections.json only i think [17:03:21] lemme see if i can [17:03:42] done [17:03:46] joakino: \o/ [17:04:11] so joakino rmoen https://phabricator.wikimedia.org/T91777 and https://phabricator.wikimedia.org/T91765 are our top priority i'd say [17:04:21] as J K will be able to test it [17:05:18] oh joakino so i [17:05:21] so my patch attempts to fix https://phabricator.wikimedia.org/T91765 and part T9177 [17:05:23] i've seen that oojs error before [17:05:26] part of [17:05:28] it's because watch is a property in firefox [17:05:36] this keeps coming up.. i thought the oojs team fixed it though :-/ [17:05:56] just needs to add a message when there are no public lists [17:06:30] jdlrobson: wha? [17:07:01] rmoen: do you want review? it is on -1needsmoredev [17:07:13] https://phabricator.wikimedia.org/T75034 < joakino [17:07:29] I have a question, jdlrobson: Are we planning on storing the Watchlist in the DB or json also ? [17:07:35] rmoen: database [17:07:36] it's private [17:08:03] jdlrobson: to confirm, in addition to storing the watchlist where it normally is we will be storing a duplicate? [17:08:37] jdlrobson: are you sure? i didn't see "this.bindings[event].slice is not a function" but that this.bindings was null when trying to do a hasOwn to it [17:08:38] rmoen: so yurik is sorting out a database backend, the idea is for the time being we will store watchlist in exactly the same place [17:08:40] bgerstle: it shouldn't be part of this patch (unless it's a regression) but is there any way to make the images in the image viewer be crisp right out the gate? for example, on the two-dimensional space article, it seems for many of the images, as i swipe right i first see a sort of blurry version of the image, and then shortly thereafter i see a crisp version replace it. i guess maybe monte's latest image interception code will handle t [17:08:41] 'for free'. [17:08:56] joakino: i'm not sure what the issue is but i guess that's related and worth looking into [17:09:05] rmoen: new collections will be stored in new database table [17:09:09] (03CR) 10Dr0ptp4kt: [V: 031] "Looks good. Mind doing a git reset HEAD on the main storyboard file?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) (owner: 10Bgerstle) [17:09:10] dr0ptp4kt: i don't know how mhurd's code would work [17:09:19] exactly the same place ? can you clarifiy. . it either means exactly the same place as now or the same as other collections [17:09:19] bgerstle: it's mainly magic [17:09:22] dr0ptp4kt: but the high-res versions aren't pre-fetched [17:09:28] dr0ptp4kt: magic makes me nervous :-/ [17:09:29] jdlrobson: gonna review this now https://phabricator.wikimedia.org/T91302 [17:09:37] dr0ptp4kt: laziness ftw [17:09:40] Reason i'm asking is because of you comment on https://gerrit.wikimedia.org/r/#/c/194936/3/includes/stores/UserPageCollectionsList.php [17:09:44] rmoen: watchlist will be stored in same place as status quo (e.g. watchlist table) meta data for watchlist in new collections table [17:09:45] dr0ptp4kt: although we could try prefetching neighbors [17:09:48] eventually, as an optimization [17:09:58] dr0ptp4kt: but, once it's fetched & cached, you'll see it right off the bat [17:10:05] i.e. we don't show the low-res one anymore [17:10:20] rmoen: the confusion comes from the fact we have this interim storage [17:10:20] jdlrobson: right. So in theory, I have to load it everytime a list of collections is created to be able to show it on the special page... [17:10:34] dr0ptp4kt: yeah, i'll reset the storyboard [17:10:45] dr0ptp4kt: just noticed one small issue w/ the image gradient not updating while zooming [17:10:50] should be a 1 line change [17:11:21] rmoen: i see. let me take another look [17:11:25] friday was pretty manic [17:11:29] jdlrobson: So getting the watchlist in the hook will not solve our problems [17:11:42] yeh makes sense [17:11:59] and it's /UserPageCollectionsList not /UserPageCollections :) (those names still confuse the feck out of me :-)) [17:12:01] I need to resolve the issue in the overlay for the watchlist collection info [17:12:20] let me test again. you're probably right that i'm wrong [17:12:39] k, when you test keep in mind the overlay is borked [17:13:02] jdlrobson: still don't know what could be causing that [17:13:29] i'm looking into that right now [17:13:50] jdlrobson: rmoen: question. when the api starts being done (like, right now), we'll consume that from php doing faux requests? [17:14:01] (03PS2) 10Jdlrobson: Hygiene: Fix use of __FILE__ [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195220 (owner: 10Jhernandez) [17:14:20] (03CR) 10Jdlrobson: [C: 031] Hygiene: Fix use of __FILE__ [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195220 (owner: 10Jhernandez) [17:14:26] kristenlans: ? [17:14:35] phuedx: standup! [17:14:44] dammit [17:14:45] (03CR) 10Jdlrobson: [C: 032] "attempt 2" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195220 (owner: 10Jhernandez) [17:14:53] hah [17:14:59] joakino: I think so. Is the api handling storage or is it using our stores ? [17:15:03] so i owe 14 dollars? [17:15:09] phuedx: correct [17:15:19] whatever [17:15:23] rmoen: doing its thing, not using our stores from what i can tell [17:15:24] monopoly money [17:15:30] :P [17:15:40] hmm, perhaps we should introduce the concept of compound interest... [17:15:40] maryana kaldari did you guys want to try to get together today to do a story prio? [17:15:49] (03Merged) 10jenkins-bot: Hygiene: Fix use of __FILE__ [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195220 (owner: 10Jhernandez) [17:15:59] (03PS4) 10Jdlrobson: Add watchlist to user collections list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194936 (https://phabricator.wikimedia.org/T91777) (owner: 10Robmoen) [17:16:00] kristenlans: yeah, not a bad idea.. [17:16:02] * phuedx tries to cover up the fact that he didn't know about whatever timezone change has clearly happened [17:16:12] joakino: hmm then yeah we will need to make faux requests or rewire it to use our stores.. not sure what best route is. Seems like we are letting Yuri make those decisions ? [17:16:13] compound interest or story prioritisation? [17:16:56] joakino: oh he just sent an email [17:17:13] why does mobile mode not work for me anymore?! [17:25:17] rmoen: so the issue was that it says "[object Object] ?" [17:25:31] jdlrobson: yes i think I have fixed it [17:25:35] cool. [17:25:43] jdlrobson: rmoen: so yuri says "Please start using API exclusively instead of going to the json pages directly" [17:25:44] ping me when patch is posted [17:25:57] yep [17:26:04] will [17:26:05] joakino: yeh we will hopefully get that sorted by end of today [17:26:18] all we have to do is replace the clientside api code with the right calls [17:27:53] tim cook "It’s just the beginning of many changes coming to the world of television" ... apple TV (set)? [17:28:20] (03PS5) 10Robmoen: Add watchlist to user collections list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194936 (https://phabricator.wikimedia.org/T91777) [17:28:32] jdlrobson: ^ [17:28:51] cool [17:28:56] just talking to yuri [17:29:11] seems watchlist title/description will not be editable for time being (which i think is fine) [17:29:25] (03CR) 10jenkins-bot: [V: 04-1] Add watchlist to user collections list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194936 (https://phabricator.wikimedia.org/T91777) (owner: 10Robmoen) [17:30:00] (03PS5) 10Bgerstle: center images w/ white background [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) [17:30:40] new Apple "ResearchKit" framework is open source \o/ [17:30:55] also, apple's new landing page w/ video & liveblog is pretty nice [17:30:58] rmoen: i have two watchlists now with that patch haha :) [17:31:05] let me try a new user [17:31:08] jdlrobson: because you still have watchlist in your json [17:31:27] its unclear whether we will be storing it in json or not... [17:31:45] it seems, this will be rewired anyway [17:32:18] NEW APPLE NOTEBOOK YA'LL [17:32:44] made of gold... [17:32:46] WHUUUT [17:33:00] pics [17:33:03] bgerstle: well there is my new laptop [17:33:15] rmoen apple.com now [17:33:23] edge-to-edge (i'm assuming retina) [17:33:37] only question is do I get gold? [17:33:57] bearND: Ping! Release meeting. :-) [17:34:05] just "Macbook" no "Air" [17:34:11] i'm there now [17:34:12] lol sorry my browser doesn't support livestreamning [17:34:15] a new magsafe port..?? :-( [17:34:22] rmoen you need to use Safari [17:34:28] only safari can do this [17:34:30] hah [17:34:32] wow wtf dude [17:34:32] ah nice, gold & graphite versions [17:36:29] omg new keyboar [17:36:30] d [17:36:52] tis a beautiful keyboard [17:37:09] bgerstle: oh god not another one [17:37:13] a bigger scape key [17:37:18] jdlrobson: might not be, hard to tel [17:37:27] i wouldn't be surprised. [17:37:47] tis a beautiful display.. [17:37:52] such a nice looking laptop... http://reactiongifs.us/wp-content/uploads/2013/02/popcorn_stephen_colbert.gif [17:38:07] bgerstle: you have animated gifs for every occasion [17:38:09] rmoen no vertical bezel [17:38:16] jdlrobson: i learned from the best [17:38:46] may the force touch trackpad be with you [17:38:56] just waiting for the "its a beautiful trackpad" [17:39:30] joakino: read my mind lol [17:39:41] OH SHIT [17:39:43] WIKIPEDIA NAME DROP [17:39:47] wo force clicking [17:39:57] xDD [17:40:02] force click me bro [17:40:20] "Unfortunately the laptop is so thin, that we don't recommend you put too much 'force' in your clicks.." [17:40:48] (03CR) 10Fjalapeno: [C: 04-1] "Mostly organizational things" (0312 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [17:40:50] UOOOOOOOOOOOOOOOOOO FAST FORWARD FORCE PRESSURE [17:40:51] omg [17:41:02] lol someone bought forceclick.com just now.. [17:41:36] "fanless" [17:41:46] o shit it's gonna melt [17:41:53] it's our least repairable mac ever!! [17:42:28] no graphics? [17:42:43] ugh can someone please invent new batteries so we can actually get hardware in our chassis? [17:42:48] wow that's a intel M for Mierda http://en.wikipedia.org/wiki/Spanish_profanity#Mierda [17:43:15] haha [17:44:19] there is no way that notebook can run mediawiki-vagrant [17:44:38] haha stream video w/ airplay AND MELT YOUR PANTS OFF [17:44:57] jdlrobson: here we go about power [17:45:02] new connector.. [17:45:07] uhh WHAT [17:45:17] wat [17:45:25] i mean http://i.imgur.com/wm9Srgj.gif [17:45:32] standard my ass [17:45:44] ADAPTERS FOR ALL THE THINGS [17:45:56] i hate adapters [17:46:04] xD now you only need 5 [17:46:37] why do people clap to gold [17:46:53] because they invested in it? [17:47:19] but at the same time... "1.3 GHZ GOLLY GEE WIZ" [17:47:25] I CAN FINALLY RUN QUAKE 3!! [17:47:26] here comes johnny [17:47:44] (03PS47) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [17:47:59] joakino: rmoen "Uncaught TypeError: Cannot read property '0' of undefined" when I try and create a new collection with your patch [17:48:05] (rmoen: your patch) [17:48:21] jdlrobson: uhhh ok [17:48:22] "The 12" Macbook, for rich people who type in coffee shops." [17:48:24] looking [17:48:40] https://phabricator.wikimedia.org/T91858 < rmoen [17:48:42] probably tha [17:48:55] (03CR) 10jenkins-bot: [V: 04-1] Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [17:49:25] jdo you get that error w/o my patch jdlrobson ? [17:49:43] no but i want to double check we don't save the watchlist before +2ing [17:51:15] (03CR) 10Jdlrobson: [C: 031] "Looks good but until https://phabricator.wikimedia.org/T91858 is resolved I can't double check we don't write the watchlist to a public us" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194936 (https://phabricator.wikimedia.org/T91777) (owner: 10Robmoen) [17:51:24] ^ rmoen [17:51:27] jdlrobson: creating collection works for me. . [17:51:33] rmoen: oh really? [17:51:34] for a new user? [17:51:44] jdlrobson: yeah i'm not on master? [17:51:57] ahh i see why [17:52:08] rmoen: let me fix quick [17:52:53] mhurd: new CPUs for existing Macbooks! [17:52:59] faster SSDs! [17:53:04] damnit, just missed out on that :-/ [17:53:16] including the new trackpad!! :-(((( [17:53:17] i'm gonna toss my air now [17:53:19] worthless [17:53:31] joakino: mine might have an "accident" [17:53:57] jdlrobson: making another patch for "no public watchlists" [17:54:43] rmoen: we have public watchlists?! :-S which bug? [17:56:02] jdlrobson: "no public watchlists" is in the https://phabricator.wikimedia.org/T91777 [17:56:21] /watchlists/collections [17:56:54] part of this is getting your watchlist on special:gather, the other bit is creating a msg [17:57:36] dr0ptp4kt: i pushed up the test plan, whaddya think? [17:57:44] kinda went cucumber-crazy [17:57:52] (03PS48) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [17:58:10] (03PS6) 10Robmoen: Add watchlist to user collections list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194936 (https://phabricator.wikimedia.org/T91777) [17:59:24] bgerstle: gotta run to a meeting, but i bet your gherkin syntax is flawless [17:59:37] bgerstle: let mhurd know in case you're ready for his code review [17:59:43] yep [17:59:50] bgerstle: k checking... [18:00:53] mhurd: https://gerrit.wikimedia.org/r/#/c/195254/ [18:02:36] dbrant: Ping. :-) [18:03:05] Deskana: 1 sec; getting a snack [18:05:25] kristenlans: Has the showcase list been cleared out or are thos topics for today already? That always confuses me on showcase day. [18:06:32] bearND not sure. Tomasz usualy manages that. And I coudln't make the last showcase, so I can't think back and compare ;-( I am assuming those are the correct topics for today. [18:07:18] kristenlans: to me most of the items look old [18:07:58] I think we should ad a date on it [18:08:06] s/ad/add/ [18:08:30] jdlrobson: i'm having problems with https://gerrit.wikimedia.org/r/#/c/194985/ it is not loading the collectionsApi js correctly [18:08:38] joakino: 1s [18:09:38] (03CR) 10Mhurd: "Added comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) (owner: 10Bgerstle) [18:10:29] (03CR) 10Bgerstle: center images w/ white background (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) (owner: 10Bgerstle) [18:10:40] bearnd I jiggulated the etherpad a bit [18:11:05] kristenlans: great. ty [18:11:14] joakino: so what issue are you having? [18:11:18] (03PS2) 10Jdlrobson: Add context to watchstar overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194985 (https://phabricator.wikimedia.org/T91302) [18:12:14] jdlrobson: load an article page, wanted to test the change on the watchstar overlay, i get that loading of GET http://localhost:8080/w/extensions/Gather/ext.gather.watchstar/CollectionsApi.js fails [18:13:22] mm looks like the file is wrong are you in debug mode? [18:13:41] joakino: unrelated bug from sound of it - i don't show extension.json [18:13:46] do you have same issue on master? [18:13:50] "i'll review the margins/padding of the main elements" i thought [18:13:58] jdlrobson: let me check [18:14:02] how long could it possibly take [18:14:39] mhurd: fixed autolayout comment you made in latest PS [18:14:48] bgerstle: cool! [18:15:08] dbrant: in GalleryItem shouldn't there be a break after line 88? [18:15:58] jdlrobson: crap its broken on master too [18:16:00] wtf [18:16:26] :-/ [18:16:35] joakino: i blame extension.json [18:16:38] prob somethign wrong in there [18:17:24] jdlrobson: oh maybe it was the code i added to localsetttings to test yuris patch, that makes loading extension.json locally [18:17:29] grrrrrr [18:17:34] kaldari, MaxSem: yt? want to chat what's left to do on the response recording patch? [18:17:57] bgerstle: quick hangout? [18:18:07] phuedx: I’m planning on going over it in more detail today [18:18:09] phuedx, sure! [18:18:44] mhurd sure [18:19:08] kaldari, MaxSem: hangout or irc? [18:19:30] or i could wait for kaldari's review and do some end-to-end testing? [18:19:32] bearND: not sure what you're seeing... is there not a line break there? [18:19:43] jdlrobson: rmoen: we should all probably have this set up on local settings so taht we don't break extension.json (gather loading code) https://gist.github.com/joakin/7b54b9e14c0bd25d478a [18:20:01] dbrant: I mean a "break;" statement to finish the for loop early [18:20:36] joakino: ncie [18:20:37] dbrant: the question is really do you want to use the first URL or the last URL found [18:20:37] nice [18:21:52] dbrant: I think the first URL found provide the original video that was uploaded, the last one provides a small res version [18:22:07] dr0ptp4kt: i tried resetting the storyboard, but nothing happened [18:22:15] (03CR) 10Jdlrobson: "Still poking around at that but first reactions" (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 (owner: 10Yurik) [18:22:18] bearND: oh right! sorry; ideally we would want the webm resolution that is best suited for the device [18:22:37] the diff doesn't seem to show any actual changes (i.e. XML attributes are the same. there's just one add'l element) [18:22:40] phuedx, kaldari: hangout for time saving? [18:22:40] phuedx: It looks like most of the meat is in ResponseStoreDB.php, so would be give that file a thorough look if you haven’t already [18:23:17] MaxSem: sure, should we do it now, or after my review (might need to be tomorrow for Sam) [18:23:40] i can do now but i'll be putting george to bed soon [18:23:57] so tomorrow [18:23:59] ? [18:24:06] dbrant: ok [18:24:51] dbrant: i guess for now this is fine to use the last one. If we used the original size it would be too much data to download [18:25:23] tomo is good for me [18:25:29] ok [18:25:40] but please review today! ;P [18:26:08] i have once ;) but i shall again! [18:26:46] jdlrobson: rmoen: definitely a extension.json issue, I can't figure out what is wrong :( i've just disabled loading gather via json and just using php loading for now [18:28:28] (03CR) 10Fjalapeno: [C: 04-1] "Sorry my comments are on a previous version… time lag" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) (owner: 10Bgerstle) [18:28:42] (03PS1) 10Robmoen: Create no public lists view and render when user has no public lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195322 [18:28:55] (03PS1) 10Jdlrobson: Tweak to EditorApi to support editing of pages that do not exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195323 (https://phabricator.wikimedia.org/T91858) [18:29:03] (03CR) 10Fjalapeno: [C: 031] Fix sides of collapsed tables cut off. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195188 (owner: 10Mhurd) [18:30:34] (03PS1) 10Cmcmahon: QA: recent versions of Chrome don't wait for event listeners [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195324 [18:31:20] (03PS1) 10Jdlrobson: Support creation of initial collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195325 (https://phabricator.wikimedia.org/T91858) [18:32:46] (03CR) 10Jdlrobson: [C: 04-1] "Take a look at CollectionsUserPageJSONApi and https://gerrit.wikimedia.org/r/195325 when I first load with a new user it's fine but as soo" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194936 (https://phabricator.wikimedia.org/T91777) (owner: 10Robmoen) [18:33:17] Deskana: have you had a chance to tinker with WikiWand on iOS ? [18:33:29] (03CR) 10Jdlrobson: "(I suspect this change probably needs to also change the js to stop storing the watchlist in User:RogerRabbit/GatherCollections.json )" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194936 (https://phabricator.wikimedia.org/T91777) (owner: 10Robmoen) [18:34:14] (03CR) 10Jhernandez: [C: 032] "Very cool!" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194985 (https://phabricator.wikimedia.org/T91302) (owner: 10Jdlrobson) [18:34:36] bgerstle: you may need to do git reset HEAD^ [18:35:12] rmoen: joakino getting real weird behaviour on creation. No idea what's up [18:35:13] right! [18:35:20] dr0ptp4kt: duh [18:35:27] jdlrobson, joakino: looking [18:35:34] jdlrobson: doing what? [18:35:38] mw.config.values.wgGatherCollections is always returing a list of one collection for me [18:35:45] even though i should have 3 [18:36:28] (03CR) 10Fjalapeno: "Adam wrote "An attempt was made to try to reduce the scroll issue, but no luck. Let's pick back up on this next week. We'll cut the TestFl" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 (owner: 10Mhurd) [18:36:39] dr0ptp4kt: ^ [18:36:41] tfinc: They've had a version in the app store for a while, actually. [18:36:50] tfinc: I guess they've officially released the "stable" version. [18:37:03] Deskana: what are we seeing traffic stats wise from it ? [18:38:06] (03CR) 10Mhurd: [C: 031] center images w/ white background [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) (owner: 10Bgerstle) [18:38:21] tfinc: That would be a good question for Analytics. [18:39:23] gonna get george to bed [18:39:45] Deskana: it would be. we're going to see people get both excited and critical of the differences between the two apps and having data will be critical to the conversation [18:39:45] (03PS2) 10Cmcmahon: QA: recent versions of Chrome don't wait for event listeners [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195324 [18:39:57] Deskana: how is the analytics request queue these days? [18:39:57] (03CR) 10Mhurd: "Tried to remove this bit:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 (owner: 10Mhurd) [18:40:15] coreyfloyd: ^ [18:41:01] ahhh rmoen it's because User:RogerRabbit/GatherCollections/1.json doesn't exist [18:41:03] mhurd: can you give me the actual changes - worried that you werent able to fix the problem [18:41:12] tfinc: Analytics Research could probably handle this with a fairly reasonable turnaround as an ad-hoc request. [18:41:14] mhurd: not sure my change will be much different [18:41:35] jdlrobson: i'm getting all of it [18:41:37] oh [18:41:41] is it? [18:42:05] jdlrobson: oh yeah if there is no "full" collection it's not adding it there [18:42:17] (03Merged) 10jenkins-bot: Add context to watchstar overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194985 (https://phabricator.wikimedia.org/T91302) (owner: 10Jdlrobson) [18:42:21] jdlrobson: i had to add the null check because it was blowing up on me on a non existing json [18:43:02] joakino: one json to rule them all would save the day [18:43:05] coreyfloyd: tried to remove the change to the scroll sync behavior - had about 5 minutes to do so and wasn’t able to in time. the scroll sync change made the toc unusable on adams device. i recommend we table that part of the patch for now [18:43:24] * jdlrobson gtta grab lunch 1min [18:43:38] jdlrobson: maybe [18:43:44] seems pointless though [18:44:00] coreyfloyd: saw you comments on my patch. amending... [18:44:54] mhurd: do you have the patch you attempted? or can you tell me the line numbers you altered - not sure I can repro and want to make sure I fix the issue if I can't [18:45:19] dr0ptp4kt: what is your iOS 8 device? [18:45:39] mhurd: that way I know what didnt work [18:45:40] (03PS6) 10Bgerstle: center images w/ white background [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) [18:45:51] dr0ptp4kt: reset storyboard and added some more comments [18:45:52] Deskana: is that a phab task for other ? [18:45:59] coreyfloyd: iphone 5c running ios 8 [18:46:03] iirc [18:46:21] tfinc: For the traffic analysis? I can put one in [18:46:57] Deskana: yup, re-occuring daily is fine. i don [18:47:07] i don't have their UA but i doubt that will be hard to find [18:50:58] coreyfloyd: i didn’t save it - i was just trying to unwind the bits i mentioned in my comment on the patch [18:53:31] mhurd: thanks [18:54:56] joakino: yeh i don't know what to do [18:56:59] coreyfloyd: i can't find your comments [18:57:01] did you -1? [18:59:56] bgerstle: yeah they were on the previous version [19:00:03] or did they not actually post… [19:00:09] didn't see them posted :-( [19:00:18] just your comment saying they were in a prev version [19:00:43] (03CR) 10Fjalapeno: "Sorry - these comments didn't even post because i started on the old revision" (0314 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) (owner: 10Bgerstle) [19:00:50] bgerstle: there they are [19:00:55] coreyfloyd: is there a way to make it so that we /only/ deal with the article load / above the fold / don't hog resources-thus-making-spinner-last-longer-than-ncessary case for the table of contents? [19:01:09] coreyfloyd: either as a standalone patch, or with the current patch reduced? [19:01:25] dr0ptp4kt: we should be able to do that [19:01:46] dr0ptp4kt: i can do that as a separate patch [19:02:31] coreyfloyd: sweet, lemme know when it's ready for review [19:04:28] https://etherpad.wikimedia.org/p/MobileShowcase [19:05:17] dr0ptp4kt: let me make a ticket for that - or does it already exist? [19:07:48] coreyfloyd: i think either of https://phabricator.wikimedia.org/T91087 or https://phabricator.wikimedia.org/T91330 captures it in as one requirement. pick one. [19:31:35] (03PS7) 10Bgerstle: center images w/ white background [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) [19:32:12] psst coreyfloyd ^ [19:32:24] bgerstle: go ti [19:32:25] it [19:32:27] got [19:32:28] got it [19:32:42] coreyfloyd: too much coffee? [19:32:44] that was the hardest 5 letters i ever typed [19:32:47] hahaha [19:32:53] 6 characters, though [19:33:10] coreyfloyd: you need one of them new-fangled Macbook's w/ that butterfly lever [19:33:19] s/'// [19:34:42] (03PS8) 10Bgerstle: center images w/ white background [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) [19:34:48] ^ minor typo [19:37:49] (03CR) 10Bgerstle: [C: 04-1] "sorry getting fast and loose here... don't merge this patch" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) (owner: 10Bgerstle) [19:44:31] (03CR) 10Jdlrobson: [C: 032] "Merging we can deal with duplicate watchlists appearing in list in future patch." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194936 (https://phabricator.wikimedia.org/T91777) (owner: 10Robmoen) [19:46:19] (03Merged) 10jenkins-bot: Add watchlist to user collections list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194936 (https://phabricator.wikimedia.org/T91777) (owner: 10Robmoen) [19:56:49] MaxSem: how do you run update.php within vagrant? [19:57:17] kaldari: vagrant git-update is the easiest way [19:57:37] but you can also run mwscript update.php --wiki=wiki [19:58:16] thanks [19:58:21] the git-update version will run update.php against all of the local wikis if you have multiple setup [19:59:19] bd808: Yeah, I was hoping for a lighterwieght method, so I’ll try mwscript update.php --wiki=wiki [20:00:18] kaldari: `foreachwiki update.php --quick --doshared` will do all the wikis [20:00:37] * bd808 had to look it up in /usr/local/bin/run-git-update [20:05:28] (03CR) 10Fjalapeno: center images w/ white background (038 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) (owner: 10Bgerstle) [20:16:37] dbrant, bearND: I just chatted to Greg and he recommended Dan Duvall (marxarelli) to chat to us about how to do release management. :-) [20:17:18] dbrant, bearND: I'll send out an email summarising our discussion, and you guys can think about what you want to ask him. :-) [20:17:33] Deskana: cool! thanks [20:18:36] coreyfloyd: so i removed the wmf_setHidden thing you didn't like, but now the hidden changes aren't animating [20:18:39] (03CR) 10Jhernandez: [C: 032] Tweak to EditorApi to support editing of pages that do not exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195323 (https://phabricator.wikimedia.org/T91858) (owner: 10Jdlrobson) [20:19:01] (03CR) 10Jhernandez: [C: 032] Support creation of initial collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195325 (https://phabricator.wikimedia.org/T91858) (owner: 10Jdlrobson) [20:19:31] bgerstle: i dont think you can animate hidden [20:19:38] bgerstle: you can animate alpha [20:19:50] jdlrobson: dudes with cool hair haha ^ [20:19:54] mergeds [20:19:59] hm.. [20:20:09] i kinda liked having an easy way to animate hidden w/o also touching the alpha [20:20:13] bgerstle: and set hidden when it completes (if you want or just leave the alpha 0 if it doesnt affect performance) [20:20:49] so only set alpha when it's animated? [20:21:05] bgerstle: yeah apple didnt really design the hidden property for animation - it was meant to remove the view from the rendering tree [20:21:13] bgerstle: yeah [20:21:21] hrmmm [20:21:27] so, we could do it either way.. [20:21:46] meh, i'm not crazy about involving the alpha property [20:22:01] but i'm not sure if it's a good trade-off to use the CAAnimation API either [20:22:13] i'll just use the alpha property [20:22:17] bgerstle: well it is the api apple created to animate fading in out of views [20:22:25] right [20:22:33] which is what i was doing [20:22:56] bgerstle: yeah if you still want to set hidden, you can do it in the completion block [20:23:12] coreyfloyd: any update on the page load / above the fold thing speed up for toc? [20:23:44] dr0ptp4kt: working on it now [20:24:34] coreyfloyd, please do ping mhurd when ready. this is a good quick win for the 3 pm sf cutoff today [20:31:00] JonKatz, around? [20:31:34] yurik hi yes. is now better for you? [20:31:48] JonKatz, if you are around, sure ) [20:32:07] yurik sure! I'll ping you on hangout. [20:32:12] excellent [20:32:34] coreyfloyd: hey quick hangout? [20:32:53] dr0ptp4kt: will do - also the flicker you saw - was it in the toc or the webview? I'm trying to make sure this change actually fixes the issue you saw [20:33:33] tfinc: are you coming to the 1:1? [20:33:44] joakino: i'm in the hangout but don't see you [20:33:55] (03CR) 10Robmoen: [C: 04-1] "This fails as UpdaterHooks key in $wgAutoloadClasses expects the schema folder to be in includes." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [20:34:01] coreyfloyd: i have a proposal for the toc bits [20:34:48] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Fix sides of collapsed tables cut off. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195188 (owner: 10Mhurd) [20:36:01] ok restarting hangout on ff. wait one sec [20:37:34] (03Abandoned) 10Robmoen: Add gather db tables and schema update hook [extensions/Gather] - 10https://gerrit.wikimedia.org/r/193315 (https://phabricator.wikimedia.org/T91308) (owner: 10Robmoen) [20:39:42] bearND: When are you chatting to gwicke about deployment of our service? Want me to set up a quick meeting? [20:39:43] (03Abandoned) 10Robmoen: Create db store for collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/192711 (owner: 10Robmoen) [20:40:25] Deskana: was going to send an email soon. But yeah, meeting would be good. [20:40:29] Deskana, still don't see you in trello the card is here: https://trello.com/c/lDeaYKDA/248-spike-where-does-pageimages-selection-algorithm-need-improvements [20:41:31] dbrant: Do you happen to have any article examples that have license data of media files set to NonFree? [20:43:08] joakino: lost you [20:43:14] coreyfloyd: it was in the toc. maybe you want to jump on a hangout so i can show? [20:43:23] OuKB: Oops, I joined the Phab project, not the board. [20:43:42] dr0ptp4kt: yeah - one sec [20:44:34] dr0ptp4kt: ok - im ready - call whenever [20:44:42] coreyfloyd: ok, briefly [20:44:55] bearND: hmm, don't think i've seen any, actually... [20:45:01] (03PS4) 10Robmoen: Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [20:45:27] (03CR) 10Robmoen: [C: 031] Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [20:45:37] (03Merged) 10jenkins-bot: Tweak to EditorApi to support editing of pages that do not exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195323 (https://phabricator.wikimedia.org/T91858) (owner: 10Jdlrobson) [20:45:39] dr0ptp4kt: have we been seeing any crashes on HockeyApp? i still never got an invite [20:45:40] (03Merged) 10jenkins-bot: Support creation of initial collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195325 (https://phabricator.wikimedia.org/T91858) (owner: 10Jdlrobson) [20:45:54] bgerstle: not yet, no [20:46:02] bgerstle: other than my own that i can see [20:46:09] ok [20:46:25] coreyfloyd: i'm downloading the old patch and putting it on my device [20:46:37] (03PS2) 10Robmoen: Create no public lists view and render when user has no public lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195322 [20:46:46] (03CR) 10jenkins-bot: [V: 04-1] Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [20:46:53] dbrant: ok. When you implemented the gallery fetch tasks you must have seen something to base this on. Docs? [20:47:18] bearND: Gabriel said Marko would be best to help, so I'll set that up. [20:47:35] Deskana: great. [20:48:07] bearND: i based it on the MediaViewer implementation on desktop. i'll point you to the exact file... [20:48:15] Deskana: I'll send some email out too, so Marko has more context. [20:51:04] rmoen, hmm, its stuborn )) [20:51:55] bearND: loosely based on this (at least the license portion): https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMultimediaViewer/6d51eefe39b96be416c7eea7c06fa91629654a04/resources%2Fmmv%2Fmodel%2Fmmv.model.License.js [20:53:11] dr0ptp4kt: my phone is dead [20:53:14] actually charging [20:53:16] coreyfloyd: oh man [20:53:21] dr0ptp4kt: let me restart [20:53:49] coreyfloyd: i usually close all chrome windows, then do an cmd+shift+del, then remove everything. then kill chrome, then start chrome [20:54:07] coreyfloyd: that's usually sufficient, even if it destroys all of my cookies for the enterprisey systems i log into [20:54:21] dr0ptp4kt: ok - thnaks let me try and call you again [20:54:42] rmoen: yurik: i'm calling it for the day [20:54:42] see you tomorrow guys [20:54:53] joakino, (( [20:54:55] joakino: see you :) [20:55:04] joakino, i will head to bed soon as well [20:55:11] did you have any q for me & my patches? [20:56:22] yurik are you a gatherer now? [20:57:49] kristenlans, hunter [20:58:23] farmer, scavenger [21:00:55] rmoen, around? [21:01:11] yurik: yes [21:01:15] whats up ? [21:01:20] rmoen, i will move schema into includes [21:01:30] if you think its related to being there [21:01:36] funky bug [21:01:42] yurik: i really don't know if it should be there [21:01:57] hmm... it could be related to something else [21:02:03] I added "../" before schema and it works now [21:02:09] if you look at Gather.php [21:02:17] rmoen, it didn't pass the tests [21:02:19] see how its autoloading the classes [21:02:20] oh [21:02:25] and it was working on my machine before [21:03:02] yurik: it didn't work for me when I ran update.php, when i changed the path, update.php worked [21:03:11] strange... [21:03:12] hmmm [21:03:23] looking, maybe it needs an absolute path [21:03:24] sec [21:04:13] (03PS2) 10Bmansurov: Resolve router deferred on back [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194968 (https://phabricator.wikimedia.org/T91421) [21:04:23] yurik: imo, I think you put schema in the right place [21:05:11] brb phone call [21:05:59] rmoen, actually you did the right thing - I have the extension loaded via extension.json, and you have it loaded via require "gather.php" --- we should really abandon this duality - i had a bug in the gather.php path [21:07:38] yurik: Hmmm yeah in LocalSettings.php i'm explicitly running from extension.json. But for some reason update.php works off Gather.php [21:08:09] yurik: oh no wait, i'm doing both [21:08:43] yurik: that could be why ;/ [21:08:46] :) [21:08:54] yeah, but jenkns still fails [21:09:05] who's the DB expert here ) [21:12:09] rmoen, sorry, crashed irc [21:12:28] yurik: no worries. [21:12:59] so who knows why jenkns is complaining here... Krinkle ? https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/6049/console [21:13:25] yurik: syntax error in db file [21:13:32] in your sql patch presumably [21:13:40] 00:00:27.895 Function: DatabaseBase::sourceFile( /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm@2/src/extensions/Gather/schema/gather_list.sql ) [21:13:40] 00:00:27.896 Error: 1 near "AUTOINCREMENT": syntax error [21:13:40] 00:00:27.896 ' in /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm@2/src/includes/db/Database.php:1249 [21:13:40] Krinkle, but it works fine locally [21:13:44] yurik: sqlite? [21:13:48] mysql [21:13:51] oh [21:13:52] :) [21:13:54] hmm, great [21:14:10] looking through core's sql... [21:14:30] does sqlite supports autoincrement i wonder [21:15:13] yurik: yes [21:15:23] perhaps you need primary key first ? [21:15:32] yurik: https://www.sqlite.org/autoinc.html [21:15:52] From reading that just a guess. [21:15:57] eh, how the hell it get merged? [21:16:14] ah, not merged:P [21:16:23] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Add image attribution info to the image metadata of Share a Fact images - https://phabricator.wikimedia.org/T91821#1101550 (10Deskana) This might be tricky on iOS for technical reasons. It might be easier on Android. [21:16:49] seems AUTOINCREMENT vs AUTO_INCREMENT [21:17:21] yurik, autoincrement is valid sqlite syntax, it's just pcky about order [21:17:28] *picky [21:17:40] coreyfloyd: just finalizing some design stuff w/ vibha [21:17:54] OuKB, do you know if its possible to test sqlite on vagrant? [21:17:58] but one question... any hints on how pass touches through a view? [21:18:04] e.g. this gradient view is blocking interaction [21:18:11] just do PRIMARY KEY AUTO_INCREMENT [21:18:17] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Replace "Content is available under CC BY-SA 3.0" text at bottom of article with CC icon. (per Tomasz) - https://phabricator.wikimedia.org/T91729#1101561 (10KLans_WMF) p:5Triage>3Normal [21:18:17] does setting interactionEnabled to NO fix that? [21:18:25] not that I know of [21:18:25] bgerstle: set the gradient userinteractionenabled to no [21:18:30] k [21:18:35] wasn't sure if that would pass through touche [21:18:37] touches* [21:18:44] bgerstle: i think it will [21:18:47] yurik, OuKB: so its PRIMARY KEY AUTO_INCREMENT (in that order ?) [21:18:48] Deskana: A good product manager knows to say No :) [21:18:54] yup [21:19:04] aharoni: :-) [21:19:18] Deskana: although I'd prefer https://phabricator.wikimedia.org/T91971 to be "lowest" rather than declined, because the problem is real. [21:19:32] (03PS5) 10Yurik: Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) [21:20:04] OuKB, thanks! we ought to have vagrant do that ) [21:20:51] aharoni: I think that makes sense, if we repurpose the task slightly. [21:20:53] aharoni: Hold on... [21:20:54] mhurd: coreyfloyd pro tip: use shift while option-pinching in the simulator to move your touch points w/o separating them [21:21:20] bgerstle: ya that’s handy! [21:21:41] 10Wikipedia-App-Android-App, 7I18n: Find alternative solution for translating the Android app description other than using a single large message in our translation files - https://phabricator.wikimedia.org/T91971#1101591 (10Deskana) [21:21:50] 10Wikipedia-App-Android-App, 7I18n: Find alternative solution for translating the Android app description other than using a single large message in our translation files - https://phabricator.wikimedia.org/T91971#1100090 (10Deskana) 5declined>3Open [21:21:56] 10Wikipedia-App-Android-App, 7I18n: Find alternative solution for translating the Android app description other than using a single large message in our translation files - https://phabricator.wikimedia.org/T91971#1100090 (10Deskana) p:5Triage>3Lowest [21:21:59] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Mobile VE - Save page title wrapping weirdly - https://phabricator.wikimedia.org/T92016#1101596 (10KHammerstein) 3NEW [21:22:00] rmoen, passes )) [21:22:06] mhurd got it, thanks! [21:22:21] not sure where i got the idea that userInteraction disabled views still blocked touches *shrug* [21:22:23] bgerstle: yay! [21:22:29] aharoni: Does that work? ^ [21:22:31] i've done crazy workarounds before w/ custom subclasses overriding hitTest... [21:22:46] bgerstle: it would if the view was a child of the interaction no view iirc [21:22:50] yurik, sorry I haven't reviewed it fully yet, was busy [21:22:56] doing it now [21:23:06] OuKB, thx! Should be simple enough )) [21:23:07] bgerstle: your gradient is prob a sibling though [21:23:14] 'tis [21:25:01] 10Wikipedia-App-Android-App, 10Wikipedia-App-Localization-or-Translation-or-Language, 7I18n: Special case Traditional and Simplified Chinese in all language handling - https://phabricator.wikimedia.org/T62743#1101627 (10Deskana) 5Open>3Invalid a:3Deskana This bug has insufficient context for us to act... [21:25:02] 10Wikipedia-App-Localization-or-Translation-or-Language, 7Tracking: Support language variants (LanguageConverter) - https://phabricator.wikimedia.org/T64416#1101630 (10Deskana) [21:26:18] 10Wikipedia-App-Android-App: "This page does not exist" on clickthrough from Google search results. - https://phabricator.wikimedia.org/T89734#1101634 (10Deskana) 5Open>3Resolved Well, the user who reported this has said it's fixed, and we never managed to reproduce it, so I'm re-marking as resolved. [21:26:29] (03PS6) 10Fjalapeno: TOC performance Bug:T91087 Bug:T91330 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 (owner: 10Mhurd) [21:26:31] (03CR) 10Robmoen: [C: 031] "LG2M. I like the flexibility this schema affords. Waiting for others to comment." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [21:28:35] Deskana: thanks, this works [21:29:09] 10Wikipedia-App-Android-App: Option to start Wikipedia app without loading the Today page - https://phabricator.wikimedia.org/T89362#1101654 (10Deskana) p:5Triage>3Low [21:29:23] I'm still kinda unhappy about the low priority, but it really should be my responsibility to make different use cases easier ;) [21:30:17] 10Wikipedia-App-Android-App, 10Wikimedia-Search: the app doesn't tell that no matching titles were found - https://phabricator.wikimedia.org/T91973#1101668 (10bearND) We could probably add ListView headers to better visually delineate between title and full text search: Title search: [res1] [res2] ... Full te... [21:31:07] (03CR) 10Jdlrobson: [C: 032] Create no public lists view and render when user has no public lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195322 (owner: 10Robmoen) [21:31:11] mhurd bgerstle anything you need from me? [21:31:28] just working on design stuff w/ vibha [21:31:30] code's nearly done [21:31:45] (03CR) 10MaxSem: [C: 04-1] "Also, just a reminder that it must not be merged without a DBA review." (036 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [21:31:52] 10Wikipedia-App-Android-App: ArrayIndexOutOfBoundsException crashes from android.view.MotionEvent.getX/android.view.MotionEvent.getY - https://phabricator.wikimedia.org/T88904#1101682 (10Deskana) p:5Triage>3Normal This isn't an issue in our code. @dbrant will look in to this and file a bug report with Google... [21:32:01] 10Wikipedia-App-Android-App: ArrayIndexOutOfBoundsException crashes from android.view.MotionEvent.getX/android.view.MotionEvent.getY - https://phabricator.wikimedia.org/T88904#1101685 (10Deskana) a:3Dbrant [21:32:02] coreyfloyd: working on the comments you left on my lead image patch. will review your amendment to toc patch in a bit. so, no :) [21:32:25] 10Wikipedia-App-Android-App: Double-tap search text hides it behind buttons - https://phabricator.wikimedia.org/T88768#1101695 (10Deskana) p:5Triage>3Low [21:32:40] (03Merged) 10jenkins-bot: Create no public lists view and render when user has no public lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195322 (owner: 10Robmoen) [21:32:55] 10Wikipedia-App-Android-App, 5Patch-For-Review: 'Similar pages' link produces 'This page does not exist' - https://phabricator.wikimedia.org/T88636#1101709 (10Deskana) 5Open>3Resolved a:3Deskana [21:33:12] OuKB, flaggedRevs ext does the same thing kinda - has one dir for all the schema stuff. But ok [21:33:23] (03PS6) 10Jdlrobson: Hygiene: Make special pages group 'other' [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194938 [21:33:34] rmoen: care to take a look ? ^ [21:33:46] looking jdlrobson [21:34:35] OuKB, come to think of it - i think the PHP file should be in the same dir because it knows in which order those SQL files should apply [21:34:58] as SQL patches grow, this one file knows the real order of how to apply them [21:35:46] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Leading images displayed blurry due to low resolution of the original file - https://phabricator.wikimedia.org/T87827#1101747 (10Deskana) p:5Normal>3Low This is a problem. But I'm not sure what the best solution is... [21:35:54] aharoni: Thank you. :-) [21:36:31] (03CR) 10Robmoen: [C: 032] Hygiene: Make special pages group 'other' [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194938 (owner: 10Jdlrobson) [21:36:37] thanks rmoen [21:36:41] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Mobile VE - Toolbar icons too close, tap area too small - https://phabricator.wikimedia.org/T92027#1101767 (10KHammerstein) 3NEW [21:36:43] jdlrobson: what do we have to do to eliminate the collection-card-overlay flashing over "Collections" ? [21:37:00] that bugs the crap out of me [21:37:46] yurik: did you see my comments on https://gerrit.wikimedia.org/r/#/c/194928/4/includes/api/ApiQueryCollections.php ? [21:38:03] (03Merged) 10jenkins-bot: Hygiene: Make special pages group 'other' [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194938 (owner: 10Jdlrobson) [21:38:03] rmoen: raise a bug would be a good start describing the problem and then just fix it :) [21:38:08] jdlrobson, yep, thx, was about to reply after the schema [21:38:09] annoyance is a good motivator :D [21:38:17] jdlrobson: aye [21:38:39] 10Wikipedia-App-iOS-App: Performance: UI locks while typing a search Term - https://phabricator.wikimedia.org/T91775#1101792 (10Deskana) @Fjalapeno Did you fix this one already? [21:39:05] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Performance: UI locks while typing a search Term - https://phabricator.wikimedia.org/T91775#1101795 (10Deskana) p:5Triage>3Normal [21:39:07] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Performance: UI locks while typing a search Term - https://phabricator.wikimedia.org/T91775#1101799 (10KLans_WMF) [21:39:07] Deskana: no [21:39:21] Deskana: i can work on it though [21:39:32] mhurd: Did you fix this one? https://phabricator.wikimedia.org/T91702 [21:39:58] Deskana: yes i believe so… lemme confirm... [21:40:47] coreyfloyd: What've you got going on at the minute? The current sprint board wasn't enlightening. [21:41:12] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Some map images cause the entire webview to be scrollable left to right - https://phabricator.wikimedia.org/T91702#1093698 (10KLans_WMF) [21:41:22] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Some map images cause the entire webview to be scrollable left to right - https://phabricator.wikimedia.org/T91702#1101813 (10Deskana) p:5Triage>3Normal [21:42:03] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Some map images cause the entire webview to be scrollable left to right - https://phabricator.wikimedia.org/T91702#1101816 (10KLans_WMF) Was this actually fixed? [21:42:10] Deskana: just fixing up a toc ticket that was in review also adam asked me to make the spinner disappear before setting up the toc [21:42:25] Deskana: thats all just waiting to be reviewed now -im about to pick up my next ticket [21:42:34] coreyfloyd: Cool, going for that one would be nice then! [21:42:44] Deskana: on it [21:43:43] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: UI locks while typing a search Term - https://phabricator.wikimedia.org/T91775#1101829 (10Fjalapeno) a:3Fjalapeno [21:44:05] 6Mobile-Web, 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1101831 (10violetto) This patch will solve this task cc: @prtksxna @kaldari https://gerrit.wikimedia.org/r/#/c/194753/ [21:44:44] 10Wikipedia-App-iOS-App: Incorrect crop for a leading image - https://phabricator.wikimedia.org/T91436#1101842 (10Deskana) p:5Triage>3Low [21:44:47] Deskana: looks like https://phabricator.wikimedia.org/T91702 is still an issue [21:46:31] 10Wikipedia-App-iOS-App: RTL - shift the content info labels to the right - https://phabricator.wikimedia.org/T91435#1101853 (10Deskana) p:5Triage>3Normal [21:46:59] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: UI locks while typing a search Term - https://phabricator.wikimedia.org/T91775#1096012 (10Fjalapeno) Note: an iPhone 4 on iOS 7 performs better, but not great [21:47:37] 10Wikipedia-App-iOS-App: Incorrect crop for a leading image - https://phabricator.wikimedia.org/T91436#1101861 (10Mhurd) This is unclear. One is tablet, one is phone. The width of phones is always more narrow, so that difference is apples to oranges. The height is calculated by percentage, so those will differ... [21:48:19] (03PS1) 10Jdlrobson: Hygiene: Rename functions in ApiEditCollection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195452 [21:48:31] yurik, so why does it have to be in the same directory? [21:48:49] OuKB, keeps related things together [21:48:55] easier not to forget to update [21:48:59] mmm [21:49:03] define related [21:49:05] 10Wikipedia-App-Android-App, 6Mobile-Apps, 10Wikimedia-Hackathon-2015: Create Wikipedia Lite app. - https://phabricator.wikimedia.org/T90758#1101865 (10Deskana) [21:49:14] to me, php files relate with each other:P [21:49:24] to me, data relates to code :) [21:49:37] 10Wikipedia-App-iOS-App: Support no images mode - https://phabricator.wikimedia.org/T92030#1101868 (10dr0ptp4kt) 3NEW [21:49:38] maintenance (sql) relates to each other [21:49:46] mmm [21:49:53] whereas it has nothing to do with the regular operations (includes/) [21:49:56] example of other extensions doing that? [21:50:01] flaggedrevs [21:50:05] mine way seems standard [21:50:07] 10Wikipedia-App-iOS-App: Support no images mode - https://phabricator.wikimedia.org/T92030#1101878 (10KLans_WMF) p:5Triage>3Low [21:50:14] 10Wikipedia-App-iOS-App: In article page images are low quality - https://phabricator.wikimedia.org/T89521#1101881 (10Deskana) p:5Triage>3Normal Was this fixed in the course of fixing other bugs? @bgerstle-WMF might know. [21:50:20] fr is antiquated:P [21:50:34] coreyfloyd: bgerstle xcode update! [21:51:36] 10Wikipedia-App-iOS-App: Load first section before loading remaining sections - https://phabricator.wikimedia.org/T92031#1101889 (10dr0ptp4kt) 3NEW [21:51:52] 10Wikipedia-App-iOS-App: Load first section before loading remaining sections - https://phabricator.wikimedia.org/T92031#1101897 (10Deskana) p:5Triage>3Normal [21:52:16] OuKB, yeah, but its a good example of what happens when you have many sql patches )) [21:52:34] mhurd: any reason we still have the old data scheme project embedded in the project? [21:53:04] OuKB, another thing - i'm thinking of how to do the line items - the problem is that if i add notifications to it, i run into the problem of checking against all items if i have updated them [21:53:22] sorry, i meant - if you have two lists, both having the same page, i need to email you just once [21:53:46] coreyfloyd: so it can read old format when users upgrade - brion wrote an importer that runs [21:53:52] thus not sure if i am ready yet to take over the watchlist table [21:53:52] on updgrade [21:54:49] mhurd: gotcha [21:54:50] mhurd: coreyfloyd ok, got design approval for the current state of image gallery [21:54:52] dr0ptp4kt: Can you review this? https://gerrit.wikimedia.org/r/#/c/195060/ [21:54:56] had to tweak some gradients some more [21:55:03] bgerstle: yay! [21:55:13] Deskana: will do [21:55:28] dr0ptp4kt: FWIW I tested it and it worked, so functionally it was fine for me in the simulator [21:55:31] coreyfloyd: i think doing the "animate alpha then set hidden" dance will add a bit of cruft to the code [21:55:38] Deskana: will do (cc Saltymule), later this afternoon [21:55:50] if it's alright w/ you i'm going to revert to the older approach and simply animate the hidden property [21:56:10] or, let me try something... [21:56:36] coreyfloyd, mhurd, bgerstle: are https://gerrit.wikimedia.org/r/#/c/193344/ , https://gerrit.wikimedia.org/r/#/c/195254/ , or https://gerrit.wikimedia.org/r/#/c/193323/ ready to be merged? [21:56:55] dr0ptp4kt: give me 5 minutes! [21:56:57] dr0ptp4kt: checking... [21:57:38] dr0ptp4kt: my patch (https://gerrit.wikimedia.org/r/#/c/193323/) will not be ready in time [21:58:04] bgerstle: i think brion and corey’s are however. checking corey’s now on device [21:58:09] dr0ptp4kt: i should be good if i can get reviewed [21:58:15] coreyfloyd: on it [21:59:11] bgerstle: yeah? was the snippet i posted not sufficient? [21:59:43] coreyfloyd: it would work, but i would also need to set the alpha of the description & owner labels [22:00:08] unless we enable UIView group opacity, which isn't generally recommended [22:00:54] unless... [22:01:00] bgerstle: hmm - dont quite follow - why do the other ones impact this? [22:01:15] coreyfloyd: because they need to be hidden as well [22:01:17] bgerstle: or why arent they all set at the same time anyways if they are animating together? [22:01:35] that's what i'm thinking now, i can expose one property whcih sets all 3 [22:01:38] and a hidden property which sets all 3 [22:02:05] brion, http://store.apple.com/us/product/MJ1K2AM/A/usb-c-digital-av-multiport-adapter [22:02:09] booo! :P [22:02:18] bgerstle: you probly dont even need a property, just a method "fadeOutAnimated:" [22:02:27] and set them all in the method [22:02:45] (03CR) 10Jdlrobson: [C: 04-1] "Unrecognized value for parameter 'list': collectionpages" (036 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194964 (owner: 10Yurik) [22:03:10] i think we're saying the same thing.. [22:03:14] let me do it real quick and post a review [22:03:44] bgerstle: yeah probabaly [22:03:54] https://www.irccloud.com/pastebin/zXcgDu0s [22:04:22] bgerstle ^ [22:04:47] bgerstle: oooooor you can put them all in a container view and just set the alpha on that [22:04:58] ^ that's essentially what i'm doing [22:05:01] bgerstle: is normally how i would corrdinate several view's opacity [22:05:21] the add'l problem is that the detail chrome has add'l logic about whether it should be hidden [22:05:40] e.g. i hide the gradient view if there's no owner/license & description info [22:05:50] (so i don't show the gradient on its own) [22:05:56] (03CR) 10Jdlrobson: Implemented action=query & list=collectionpages (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194964 (owner: 10Yurik) [22:05:56] but i can refactor that logic [22:06:03] bgerstle: ahh - gotcha [22:06:09] (03PS6) 10Yurik: Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) [22:06:58] (03CR) 10Yurik: Database schema for gather lists (036 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [22:07:27] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: UI locks while typing a search Term - https://phabricator.wikimedia.org/T91775#1101952 (10Fjalapeno) Other note: iPhone 3GS (which is a phone that cant upgrade to iOS 7) is even worse. [22:07:38] (03CR) 10Jdlrobson: [C: 031] "it seems to work but i'd like a bit more clarity/abstraction and polish in the code before merging (see earlier comments)" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 (owner: 10Yurik) [22:08:15] OuKB, updated schema, see if you like it better ) [22:09:23] bgerstle: coreyfloyd dr0ptp4kt xcode update *seems* a bit snappier… [22:09:41] woohoo! [22:10:21] yurik, I have a vague feeling that 2 last indexes are duplicative: https://gerrit.wikimedia.org/r/#/c/195192/6/schema/gather_list_item.sql [22:11:22] OuKB, ??? [22:12:03] OuKB, #2 is the index per user group, #3 is title first [22:12:25] having the id as the last element of the index allows proper querying [22:12:38] mmm, example of queries? [22:14:29] coreyfloyd: skipping hidden and just setting alpha should simplify things [22:14:31] "hidden or alpha - Change the transparency of the view as a whole rather than hiding or applying alpha to your view’s rendered content." [22:14:34] good enough for me [22:14:52] hitTest apparently also ignores views w/ alpha less than 0.1 or something [22:15:10] bgerstle: yeah thats a documented threshold [22:15:23] bgerstle: yeah i normally only go to hidden when performance requires it [22:15:34] when's that? [22:15:46] (03PS9) 10Bgerstle: center images w/ white background [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) [22:15:50] coreyfloyd: last hurrah? ^ [22:15:52] mhurd: ^ [22:15:57] bgerstle: cool! [22:16:09] OuKB, i remember dealing with this issue when writing various api queries -- the problem is with continuation - if you iterate through duplicate items, you need a way to stop in the middle, and know where to continue [22:16:14] coreyfloyd: mhurd i ditched all the fancy gradient start stuff (no more ascii art :-/) [22:16:20] lol [22:16:23] KISS ftw [22:16:58] hmm ok [22:17:10] OuKB, besides, when i lookup by title, I need to know what list it belongs to - thous i will need the ID. Having the ID in the index prevents an extra DB IO [22:17:23] now that i think about it... having a separate class for the detail overlay is kind of silly [22:17:27] i might kill that in a future refactor [22:17:41] it was basically a way for me to figure out the description & owner label layout in IB [22:17:47] but i could move the whole cell into IB too [22:17:54] later.. [22:18:01] and then use cases mature and you will need to retrieve another field, and bang - need to cover them too:P [22:18:21] 20 minutes late, still hoping to get on the release train.. [22:18:29] OuKB, that's why i don't have any extra fields in that table )) [22:19:11] think of how DB works - it needs to identify the record uniquely - thus if you havea non-unique index, there must be some extra id [22:19:31] (03PS1) 10Robmoen: WIP: A user can delete their own collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195459 (https://phabricator.wikimedia.org/T91776) [22:19:45] if i make a unique index, it shouldn't need any extra info (even though the primary key contains stuff like order) [22:20:10] but we should bug a dba for this [22:22:22] jdlrobson, around? [22:22:56] (03PS7) 10Mhurd: TOC performance Bug:T91087 Bug:T91330 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 [22:23:07] coreyfloyd: ^ quick amendment [22:23:19] (03CR) 10Fjalapeno: [C: 031] "looks good" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) (owner: 10Bgerstle) [22:23:25] yay! [22:23:54] yurik: yup [22:24:04] dr0ptp4kt: i amended https://gerrit.wikimedia.org/r/193344 [22:24:33] mhurd: stand by your earlier +1? want to make it a +2? ;-) [22:24:45] jdlrobson, try this: compare includes/api/ApiQueryWatchlistRaw.php extensions/Gather/includes/api/ApiQueryCollectionPages.php [22:24:51] bgerstle: gimme one minute… checking it out now [22:24:57] (03CR) 10Fjalapeno: [C: 031] TOC performance Bug:T91087 Bug:T91330 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 (owner: 10Mhurd) [22:25:23] jdlrobson, i basically copied the functionality so that we have everything watchlist does from the start, and modify it a bit to support our use case [22:25:40] if i start cutting things off, it will be longer, and more error prone [22:25:46] yurik that's kinda what i mean.. that legacy code is nasty let's write it in a much nicer way from the start :-) [22:25:47] (03PS8) 10Mhurd: TOC performance Bug:T91087 Bug:T91330 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 [22:25:59] (03PS2) 10Bmansurov: WIP: Preload banner images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) [22:26:01] (03CR) 10Mhurd: [C: 031 V: 031] TOC performance Bug:T91087 Bug:T91330 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 (owner: 10Mhurd) [22:26:16] jdlrobson, it takes longer to write "nice" code - its always much better to work from stuff that already works. And "nasty" is a very nontechy term :)) [22:26:17] the nice thing about starting afresh is you can start with non-confusing code so inheriting confusing code is an antipattern [22:26:37] that's find yurik i'd rather we took a little longer and made things nicer from the get go :) [22:27:02] meanwhile, xkcd is still funny: http://xkcd.com/ [22:27:08] we're not sure how watchlist fits into this so i'd rather remove the notification related code - an entire new model may be needed when multiple lists are in play [22:27:55] go jdlrobson go. +1,000,000. now to write the tests first... :-) [22:27:56] jdlrobson, well, than we have an option of either writing something good looking that will be tossed out because at the end it will turn out that we should have gone a different route from early on, or we can have something functioning and polish later. At this point we can still easily change api to what we need, but speed is more important than cutting away functionality that actually might be useful [22:27:59] (03CR) 10jenkins-bot: [V: 04-1] WIP: Preload banner images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [22:28:18] bgerstle: lol [22:28:20] (03PS1) 10Jdlrobson: Show anon cta to anons again [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195463 (https://phabricator.wikimedia.org/T91998) [22:28:41] coreyfloyd: also, somebody came out w/ a hilarious new product go w/ the new fanless Macbooks. it's called: iMonFire [22:28:43] (03PS10) 10Mhurd: center images w/ white background [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) (owner: 10Bgerstle) [22:28:55] (shamelessly stolen from a comment one of my friend's made on FB) [22:28:58] (03CR) 10Mhurd: [C: 031] center images w/ white background [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) (owner: 10Bgerstle) [22:29:17] mhurd: you're the second +1, care to do the honors? [22:29:19] bgerstle: i figure its a good way to save on a vasectomy [22:29:26] coreyfloyd: hahaha! [22:29:32] jdlrobson, i think we should try things first, have an MVP that runs, and later decide that API should be different / smaller / etc. Lets concentrate on MVP. I understand that code very well (having written it myself many years ago), and i know it has been vetted by many others over time, so lets stick with that and modify it to fit our needs. Than we can cut things off [22:29:32] it's their plan!! [22:29:41] bgerstle: ya [22:29:43] yurik: yeh but your api is not an MVP :) [22:29:44] the government is using apple to sterilize all the rich terrorists [22:29:47] it does more than it needs to [22:30:02] if you understand it well it should be easy to remove the things that are misleading [22:30:06] (03CR) 10Mhurd: [C: 032 V: 032] center images w/ white background [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195254 (https://phabricator.wikimedia.org/T91128) (owner: 10Bgerstle) [22:30:10] woohoo \o/ [22:30:17] anything regarding timestamps in the collections api concerns me right now - as this hasn't been thought about at all yet [22:30:21] and i'm not sure how it's going to work [22:30:25] coreyfloyd: mhurd dr0ptp4kt anything i can do to help? [22:30:33] otherwise it's about dog park time [22:30:36] bgerstle: review https://gerrit.wikimedia.org/r/#/c/195060/ ? [22:30:40] dr0ptp4kt: ^ [22:30:41] jdlrobson, it is - because cutting things off takes longer :)) [22:30:46] bgerstle: apple is designing a new human from the ground up with smooth edges - no genitalia. [22:30:47] and it's still light out! (silver lining of DST) [22:30:51] not quite we could cause us issues on long term [22:30:52] coreyfloyd: lol [22:30:55] coreyfloyd: hahaha [22:31:04] coreyfloyd: ROUND ALL THE CORNERS! [22:31:13] :) [22:31:17] coreyfloyd: and he has one port for all the inputs [22:31:17] for instance one of the things that has been discussed is getting notifications when a collection changes members - this is not covered by watchlist notification timestamp which works completely differently, [22:31:27] mhurd: bgerstle no more "weird" connectors [22:31:28] or dongles [22:31:31] hahahah [22:31:52] jdlrobson, why would it cause us issues?? It works as it is, if we find that a certain flag/option is not needed/causes issues, we remove it. At this point, lets concentrate on getting the DB support and new functionality. [22:32:08] bgerstle: would you mind looking at https://gerrit.wikimedia.org/r/#/c/195016/ and https://gerrit.wikimedia.org/r/#/c/195015/ ? npm / grunt patches from timo [22:32:11] yurik: because at this current time collection != watchlist - it is a reader feature [22:32:15] (03PS9) 10Dr0ptp4kt: TOC performance Bug:T91087 Bug:T91330 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 (owner: 10Mhurd) [22:32:16] mhurd: i saw those this morning [22:32:19] Krinkle: you're my hero [22:32:28] :) they look good! [22:32:31] bgerstle: mhurd dr0ptp4kt speaking of light - im going walk the dog before the sun goes down bb in an hour - need anything else before i go? [22:32:40] jdlrobson, think of it this way: if you need something fast, you should take a off-the-shelve library that does something similar, and modify it just enough to do what you need. Lets not rewrite the library itself, as that will take longer :) [22:32:41] all i care about right now is storing articles in a set. i don't want to set false expectations [22:32:43] coreyfloyd: i'm all good here [22:32:49] coreyfloyd: bgerstle nothing needed here. ttyl [22:32:50] coreyfloyd: i’m good. gonna address rest of your comments on my patch in the mean time [22:32:57] coreyfloyd: thanks again for the feedback! [22:32:57] mhurd: i'm going review those first, then i might need to rebase Saltymule's patch to pass jshint [22:33:10] bgerstle: k [22:33:12] yurik: i really dont see why this will take long since you wrote this - i could have copied and pasted from watchlist myself :P [22:33:20] mhurd: cool - ill check out your patch and be working on the search performance when i get back [22:33:40] mhurd: ready when you are [22:33:44] coreyfloyd: awesome! [22:34:03] coreyfloyd: what was the search performance story? [22:34:21] bearND: cool! 5 min? [22:34:24] bgerstle: You're welcome [22:34:29] mhurd: cool [22:34:39] bgerstle: As soon as they're merged I'll flip the flag to make the job voting so it stays enforced [22:34:44] rmoen: (y) thanks for posting patches early :) [22:34:49] Krinkle: sa-weet [22:34:53] jdlrobson: yep [22:34:58] i stepped away for a sec [22:35:03] Krinkle: soon we'll hook up a Mac for jenkins and we can run tests & such for the native code as well [22:35:11] will probably need to consolidate the jobs at that point [22:35:16] Looking forward to it :) [22:35:22] you're tellin' me [22:35:23] (03PS2) 10Jdlrobson: Show anon cta to anons again [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195463 (https://phabricator.wikimedia.org/T91998) [22:35:30] (03PS3) 10Jdlrobson: Show anon cta to anons again [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195463 (https://phabricator.wikimedia.org/T91998) [22:35:40] Hehe, yeah, can only imagine your position. [22:36:54] bgerstle: Are the tests runnable locally? [22:37:00] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] TOC performance Bug:T91087 Bug:T91330 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193344 (owner: 10Mhurd) [22:37:08] (for you and other devs I mean) [22:37:40] Krinkle: yes, but I think a couple aren't even passing [22:37:53] dr0ptp4kt: i think some of the HTML parsing stuff you wrote is borked [22:37:54] brb [22:38:04] bgerstle: What kind of tests do you run / how long does it take to run? [22:38:07] Krinkle: i added a makefile recently, so at least you can "make test" [22:38:14] Krinkle: we only have a smattering of unit tests atm [22:38:24] *really* want to get us on Sauce so we can run appium tests [22:38:30] bgerstle: yes, the regexes need to be updated for nested parentheses and nested square brakets [22:38:33] do some functional testing to catch regressions [22:38:36] s/brakets/brackets/ [22:38:46] bgerstle: regexgressions [22:38:53] regexregretsy [22:38:55] regrexions? [22:39:48] (03CR) 10Bmansurov: WIP: Preload banner images (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [22:40:30] mhurd: dr0ptp4kt drop the "ship it" hammer on https://gerrit.wikimedia.org/r/#/c/195015/? [22:40:57] bgerstle: haha ok [22:41:04] (03PS2) 10Mhurd: grunt: Clean up and pin npm dependencies [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195015 (owner: 10Krinkle) [22:41:17] mhurd: will follow up shortly for 1-2 npm/jshint punch [22:41:32] bgerstle: :) [22:42:45] (03CR) 10Mhurd: [C: 032 V: 032] grunt: Clean up and pin npm dependencies [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195015 (owner: 10Krinkle) [22:43:47] Krinkle: coupla questions [22:43:49] why "node": true? [22:44:32] in the jshintrc [22:44:34] bgerstle: Aye, because it's sure wouldn't run without errors in a regular browser. It uses module and exports. [22:44:45] ah ha, right [22:44:49] cuz we're browserifyin' [22:44:59] But not node, yeah [22:45:24] seems OK for now, definitely a great start [22:45:38] i don't remember all the jshint flags i usually setup [22:45:50] just glad to see "lint free" [22:46:11] bgerstle: Yeah, I'd recommend making it a little less tolerant. "node" whitelists more than you need. [22:46:15] (03CR) 10Bgerstle: [C: 031] "http://i.imgur.com/T4rYutM.gif" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195016 (https://phabricator.wikimedia.org/T71838) (owner: 10Krinkle) [22:46:30] Krinkle: GIF for you ^ [22:46:38] :D [22:46:41] mhurd: hammer please! [22:46:58] then the last web patch [22:47:28] on second thought [22:47:30] (03PS3) 10Mhurd: grunt: Make jshint pass [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195016 (https://phabricator.wikimedia.org/T71838) (owner: 10Krinkle) [22:47:30] mhurd: Remember not to use V+2 though, only C+2. Jenkins merges for you :) [22:47:33] mhurd: dr0ptp4kt alright if i review that last patch tomorrow? [22:47:43] bgerstle: ya! [22:47:48] ok, thanks [22:47:52] dog park train's leaving [22:48:00] see you guys tomorrow o/ [22:48:15] bgerstle: sounds good ttyl [22:48:40] Krinkle: ah! ok! :) [22:50:26] (03Abandoned) 10BearND: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/187413 (owner: 10BearND) [22:50:35] (03Abandoned) 10BearND: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193509 (owner: 10BearND) [22:50:44] (03Abandoned) 10BearND: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/194699 (owner: 10BearND) [22:57:35] (03PS2) 10Mhurd: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195268 (owner: 10BearND) [22:58:05] (03CR) 10Mhurd: [C: 032] Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195268 (owner: 10BearND) [22:58:59] (03CR) 10Jdlrobson: [C: 04-1] "I still don't get this... if this is for browsers which do not fire popstate we should feature / browser detect against those browsers - n" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194968 (https://phabricator.wikimedia.org/T91421) (owner: 10Bmansurov) [23:03:13] (03CR) 10Kaldari: [C: 04-1] "Does not seem to support multiple responses from the same page correctly." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [23:05:14] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Mobile apps should use "download" rather than "heart" icon for offline bookmarking - https://phabricator.wikimedia.org/T91834#1102140 (10Vibhabamba) We specifically vetoed the download icon, because it looks like it will initiate a desktop download process.... [23:07:15] (03PS1) 10Robmoen: hygiene: transform messages to text [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195476 [23:15:59] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: 4.0.6..3 - deleting a selected Saved page takes >20 sec - https://phabricator.wikimedia.org/T91100#1102157 (10Etonkovidova) I re-checked it with 4.0.7.3 on mini iPad - not happening anymore. The bug is invalid(or resolved). [23:20:49] (03PS2) 10Jdlrobson: Hygiene: transform messages to text [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195476 (owner: 10Robmoen) [23:23:37] (03CR) 10Bmansurov: "OK, let me first clarify that I'm not radically changing the existing behavior and there is no need to panic. All existing tests are passi" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194968 (https://phabricator.wikimedia.org/T91421) (owner: 10Bmansurov) [23:34:41] bmansurov: you are not being cautious enough with this change [23:35:11] it really isn't clear at all to the reviewer why this works and the qunit test doesn't give me any confidence. [23:35:20] you are changing Router so that /is/ radical [23:35:27] that code hasn't changed in a long time [23:35:36] jdlrobson: have you read the code? [23:35:43] and it glued into every workflow. it has the possibility to break editing workflow [23:35:54] yes of course i have and it doesn't make any sense [23:36:08] jdlrobson: what part is not clear to you? [23:36:24] the fundamental: why wouldn't a popstate fire [23:36:36] it's in the w3c spec [23:36:37] jdlrobson: I explained it to you in the comment [23:36:40] jdlrobson, sorry, had to step away for a bit... reading back [23:36:57] jdlrobson: a lot of things are in w3c spec but it doesn't mean that all browsers respect that [23:37:04] (03CR) 10Kaldari: Recording user responses (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [23:37:06] you mean “Sometimes onpopstate is not fired by history.back(), for example in IE11.” [23:37:11] that's not very descriptive :) [23:37:17] jdlrobson: no, the comment in gerrit [23:37:20] why is it not fired? Where is this documented [23:37:23] if you want i can update the commit message [23:37:25] comments in gerrit mean nothing bmansurov [23:37:29] they need to be in the code itself [23:37:42] sure i'll update the commit message if that's your problem [23:37:45] think of the next poor baha that comes along and reads it :) [23:38:29] this sort of thing should really be in the code- when i'm looking at a timeout i want to know why there is a timeout [23:39:37] and skimming through your comment it sounds like it would be better to set the hash using replaceState rather than window.location = '#foo' ? ? [23:40:40] not all browsers support replaceState, do they? [23:43:36] (03CR) 10Krinkle: "recheck" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195016 (https://phabricator.wikimedia.org/T71838) (owner: 10Krinkle) [23:43:40] sure, same with popstate - not sure exactly what the deal is but timeouts should really be a last resort [23:43:52] mhurd: It's now voting ^ [23:44:08] Krinkle: yay! [23:49:11] (03CR) 10Kaldari: Recording user responses (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [23:51:55] (03CR) 10Kaldari: Recording user responses (032 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [23:52:47] bgerstle: I tried browserify:true locally instead of node:true. Getting an error for illegal use of console. [23:52:53] Is that genuine or not? [23:53:15] In Node there's always a console. In browsers there is not. But maybe your environment is providing it? [23:53:34] If so, I'll add globals: console, otherwise, we should probably remove it from production code [23:54:38] 6Mobile-Web, 10MediaWiki-Categories, 5Patch-For-Review: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1102370 (10PeterBowman) I may have spotted another issue: expanding subcategories make other elements "jump" between columns, sometim... [23:55:06] (03PS3) 10Bmansurov: Resolve router deferred on back [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194968 (https://phabricator.wikimedia.org/T91421) [23:55:08] mhurd: anything for me to check out or are you still good? [23:55:31] coreyfloyd: not quite yet :) [23:55:36] mhurd: also you been to yosemite? [23:55:43] coreyfloyd: oh yeah! [23:56:15] mhurd: cool - thinking about a trip there this summer - might pick your brain on some stuf [23:56:24] (03PS1) 10Jdlrobson: Don't repeat Watchlist in existing collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195488 (https://phabricator.wikimedia.org/T92035) [23:56:28] coreyfloyd: for sure! [23:57:08] (03PS5) 10Yurik: action=query & list=collections implementation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 [23:58:01] (03CR) 10Yurik: action=query & list=collections implementation (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 (owner: 10Yurik) [23:58:36] jdlrobson, ^ [23:58:51] yurik_: cool looking :)