[00:01:31] (03PS6) 10Yurik: action=query & list=lists implementation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 [00:02:16] Deskana: coreyfloyd bgerstle mhurd i'm heading out [00:09:55] (03PS4) 10Krinkle: grunt: Make jshint pass [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195016 (https://phabricator.wikimedia.org/T71838) [00:10:16] (03CR) 10Krinkle: "Should be good to go, though investigate that console.log call later. Might be a problem." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195016 (https://phabricator.wikimedia.org/T71838) (owner: 10Krinkle) [00:13:18] (03PS3) 10Bmansurov: WIP: Preload banner images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) [00:13:44] (03CR) 10Bmansurov: WIP: Preload banner images (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [00:14:32] (03CR) 10jenkins-bot: [V: 04-1] WIP: Preload banner images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [00:16:40] (03CR) 10Jdlrobson: [C: 04-1] "This patch looks like it should work but I'm unable to verify it does." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195488 (https://phabricator.wikimedia.org/T92035) (owner: 10Jdlrobson) [00:19:43] (03PS2) 10Robmoen: WIP: A user can delete their own collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195459 (https://phabricator.wikimedia.org/T91776) [00:19:59] (03CR) 10Jdlrobson: [C: 04-1] action=query & list=lists implementation (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 (owner: 10Yurik) [00:20:00] jdlrobson: ^ any ideas why my buttons are duplicated in the overlay? [00:21:04] jdlrobson: going to take a break. Hope to finish that tonight. [00:21:29] rmoen: i dunno Gathers been acting all weird to me today [00:21:36] right now it's throwing a fatal and i have no idea where the fatal is [00:21:40] i think i'm gonna call it a night :( [00:21:41] :( [00:21:43] yeah [00:21:48] (03PS49) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [00:21:49] start fresh tomorrow ;) [00:21:54] kaldari, [00:21:56] ^^ [00:22:03] (03CR) 10Jdlrobson: [C: 04-1] Resolve router deferred on back (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194968 (https://phabricator.wikimedia.org/T91421) (owner: 10Bmansurov) [00:22:14] (03CR) 10Bmansurov: "Is it still a WIP or ready for review?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [00:22:39] bbl [00:24:06] (03PS50) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [00:25:12] (03PS4) 10Bmansurov: Resolve router deferred on back [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194968 (https://phabricator.wikimedia.org/T91421) [00:26:18] jdlrobson: let's talk about https://gerrit.wikimedia.org/r/#/c/193289/ when you get a chance [00:27:15] (03CR) 10Yurik: "Re "lets cut this feature because its not used for lists" -- this module (as discussed with MaxSem re db schema) is envisioned as a eventu" (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194964 (owner: 10Yurik) [00:28:59] 6Mobile-Web: Mobile editing - cursor is not visible and jumps around weirdly - https://phabricator.wikimedia.org/T92052#1102445 (10KHammerstein) 3NEW a:3KLans_WMF [00:30:31] 6Mobile-Web: Trim image descriptions - https://phabricator.wikimedia.org/T92053#1102460 (10MaxSem) 3NEW [00:30:42] (03CR) 10Bmansurov: TWN: Use own message for terms of use link in license warning (editor and talk) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190831 (owner: 10Florianschmidtwelzow) [00:39:25] (03PS9) 10Mhurd: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [00:39:44] (03PS10) 10Mhurd: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [00:40:50] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 5Patch-For-Review: svg images do not display information in Image Gallery view - https://phabricator.wikimedia.org/T90298#1102486 (10Etonkovidova) Checked on iPad mini with 4.0.7.4 - all info is displayed. The sample image (from Water article) is display... [00:41:03] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 5Patch-For-Review: svg images do not display information in Image Gallery view - https://phabricator.wikimedia.org/T90298#1102487 (10Etonkovidova) 5Open>3Resolved [00:49:47] (03PS1) 10Bmansurov: Do not hide coordinates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195495 (https://phabricator.wikimedia.org/T91481) [00:56:53] (03CR) 10MaxSem: [C: 04-1] "This needs design input. In principle, I'm all for it, however the destination of coordinates link is completely mobile-unfriendly GeoHack" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195495 (https://phabricator.wikimedia.org/T91481) (owner: 10Bmansurov) [00:58:01] (03CR) 10Bmansurov: "Thanks Max, @MSyed ping." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195495 (https://phabricator.wikimedia.org/T91481) (owner: 10Bmansurov) [00:58:34] 6Mobile-Web, 5Patch-For-Review: Display coordinates in mobile version - https://phabricator.wikimedia.org/T91481#1102516 (10bmansurov) @MSyed, where should I put the coordinates? [01:00:09] Does anyone have any data on how many Wikidata items have descriptions? [01:00:15] kaldari? [01:00:25] DarTar? [01:00:34] hey [01:00:37] Deskana, I can run a query [01:00:43] MaxSem: Yes please! [01:00:46] thanks MaxSem :) [01:00:52] do you need english or...? [01:01:04] Deskana: yeah I was going to ask the same [01:01:14] MaxSem: Did you see my other comments in patchset 48? [01:01:22] MaxSem: English is good, yeah. [01:01:23] yep [01:01:35] cool, just want to make sure they weren’t missed [01:01:55] in general, I was going to comment heavily on schema once the rest is reviewed, right before submitting for dba review [01:02:34] MaxSem: any thoughts on the comments here: https://gerrit.wikimedia.org/r/#/c/177448/48/includes/ResponseStoreDB.php [01:03:22] ehm, actually missed those [01:03:27] thanks for poking [01:03:57] let's discuss tomorrow whether we need score in the table at all [01:04:45] sure. also, there was one more comment here: https://gerrit.wikimedia.org/r/#/c/177448/48/sql/wikigrok_aggregation.sql [01:05:35] (03CR) 10MaxSem: Recording user responses (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [01:43:42] tfinc: https://www.mediawiki.org/wiki/Talk:Wikimedia_Engineering/2014-15_Goals/Q4#In-line_Wikidata_description_editing_on_the_Wikipedia_app [02:09:03] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Mobile apps should use "download" rather than "heart" icon for offline bookmarking - https://phabricator.wikimedia.org/T91834#1102558 (10Jaredzimmerman-WMF) hmm, I can see the bookmark icon (thankfully we have one of those) but the heart has always seemed a... [02:28:04] (03PS3) 10Yurik: Implemented action=query & list=listpages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194964 [02:31:23] (03PS7) 10Yurik: action=query & list=lists implementation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 [02:31:47] (03CR) 10Yurik: action=query & list=lists implementation (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 (owner: 10Yurik) [03:09:18] (03PS1) 10Yurik: Renamed api action=editcollection -> editlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195499 [03:12:26] (03PS2) 10Yurik: Renamed api action=editcollection -> editlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195499 [04:00:02] 10MobileFrontend-Feature-requests: Special:UserLogin includes messages from inappropriate components on mobile - https://phabricator.wikimedia.org/T92056#1102577 (10Jidanni) 3NEW [04:30:08] (03CR) 10Tim Starling: [C: 031] "> MWException itself, however, is merely an obsolete wrapper for plain Exception that used to needed in order to have tracking, hashing an" [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/184062 (owner: 10Ori.livneh) [04:40:29] (03PS7) 10Yurik: Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) [05:04:34] (03CR) 10Springle: [C: 04-1] Database schema for gather lists (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [05:15:37] 10Wikipedia-App-Android-App, 7I18n: Find alternative solution for translating the Android app description other than using a single large message in our translation files - https://phabricator.wikimedia.org/T91971#1103397 (10bearND) I agree that it would be good to remove this info from the regular strings.xml... [06:22:07] (03PS11) 10Mhurd: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [06:24:28] (03PS12) 10Mhurd: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [06:25:46] bgerstle: do you have the uncrustify pre-commit hook setup? [07:52:33] (03PS13) 10Mhurd: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [07:55:44] (03PS14) 10Mhurd: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [08:02:18] (03CR) 10Mhurd: "Almost finished addressing corey's comments. Will wrap up in morning." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [09:27:08] morning! [09:27:11] hi phuedx [09:38:10] morning all [09:38:18] hey joakino [09:38:30] o/ [09:48:18] phuedx: are you going to the safeguard meeting now? [09:48:46] joakino: i'm expecting a plumber to turn up, so i'm going to go to the one in the afternoon [09:48:55] 👍 [09:58:20] there is no hangout link :S [09:58:54] joakino: Its a dial-in meeting [09:59:09] prtksxna: wtf is that [09:59:10] joakino: See the PDF in the first mail on that thread. [09:59:20] prtksxna: ok [09:59:35] joakino: Ancient technology that required phones and cryptic numbers. [10:01:18] prtksxna: wat is going on [10:01:22] nobody is in there lol [10:01:27] are you attending? [10:01:35] joakino: You need a meeting pin to enter. We don't know what it is [10:01:44] joakino: I want to :P [10:01:57] prtksxna: so i get my land line and call somewhere? [10:02:06] joakino: Did it not ask you for a PIN? [10:02:23] joakino: I guess. There is no number for India, so I am using Skype [10:02:28] prtksxna: i don't even know how to get started [10:02:45] 1) Find a pay phone on the street :P [10:03:20] prtksxna: those don't exist anymore hehe [10:03:27] prtksxna: so where did you call from skype [10:03:44] The US number [10:03:59] joakino: The one in the second PDF [10:05:08] prtksxna: update me if you get in [10:05:48] joakino: IF! Follow the thread, no one know the pin anyway [10:06:54] *knows [10:08:21] prtksxna: should we suggest an irc channel on the mailing list to bitch about this? [10:08:26] #wikimedia-office maybe? [10:08:35] joakino: -staff is already on it :P [10:09:16] prtksxna: hmm that one doesn't show up on my channel list [10:09:49] i must be invited [10:09:53] joakino: I think its protected, yeah [10:10:10] joakino: Ask Deskana|Away or quiddity [10:10:17] prtksxna: thx [10:10:38] Deskana|Away: quiddity: can you invite me to -staff please? [10:33:35] so joakino is this actually happening? [10:33:58] phuedx: nope [10:34:03] still waiting [10:34:12] it is ridiculous [10:35:03] the people that we are going to learn about them being our employers set up a dial-up conference with password at the caller's cost without giving the password [10:35:14] doesn't inspire much confidence... [10:40:03] :/ [10:41:59] phuedx: postponed for tomorrow (or this afternoon i guess) [10:42:32] :/ [10:52:26] (03PS8) 10Yurik: Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) [10:52:30] (03CR) 10Yurik: Database schema for gather lists (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [11:00:42] (03CR) 10Phuedx: [C: 032] QA: recent versions of Chrome don't wait for event listeners [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195324 (owner: 10Cmcmahon) [11:01:49] (03Merged) 10jenkins-bot: QA: recent versions of Chrome don't wait for event listeners [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195324 (owner: 10Cmcmahon) [11:05:23] gonna make a cup of coffee [11:39:10] (03CR) 10Jhernandez: [C: 032] Show anon cta to anons again [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195463 (https://phabricator.wikimedia.org/T91998) (owner: 10Jdlrobson) [11:40:13] (03Merged) 10jenkins-bot: Show anon cta to anons again [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195463 (https://phabricator.wikimedia.org/T91998) (owner: 10Jdlrobson) [11:45:49] (03Abandoned) 10Phuedx: [WIP] Give all content the same gutter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194899 (owner: 10Phuedx) [11:53:10] joakino, morning ) [11:53:22] morning yurik_ ! [11:53:42] joakino, do you know who is working on adapting gather to api? [11:54:06] yurik_: what do you mean? [11:54:31] like changing the special page to use api, changing js to call api to get data, etc? [11:57:30] yurik_: we'll create tasks for that! [11:57:48] joakino, tasks are good, but who will actually do the work? :) [11:57:51] ATM nobody, we're polishing the frontend [11:57:58] yurik_: me, jon and rob [11:58:07] jdlrobson rmoen [11:58:44] hehe. I am a bit worried that you are building a fairly complex model that won't fit with the api when you start the migration [11:59:15] yurik_: can you expand on that? [12:00:07] well, for example "count" is a fairly expensive operation on large datasets [12:00:22] thus we want to minimize its use to where it is actually needed [12:00:46] things like that are not inherent into the model [12:00:49] correct [12:01:33] yurik_: where exactly are you referring to [12:01:57] yurik_: we won't do count anywhere, in the lists table we will need to cache the list length though [12:02:41] yurik_: do you want to meet later and clarify exactly what we expect? maybe it is hard to extract "intent" from the code that is there now, that's easy to solve [12:02:46] right, but how do you keep that list length? Usually people don't store count, instead doing a "select count(*) from table where ..." [12:03:07] yurik_: isn't that count expensive? [12:03:13] exactly )) [12:03:29] but the problem is that if you keep it separate, it is very likely to be out of sync [12:03:49] at least it tends to get out of sync fairly quickly due to bugs [12:04:01] yurik_: yep, so when editing (adding item, removing item) a collection, we'll need to update that field too [12:04:03] yurik_: aha [12:04:53] yurik_: well it's a requirement to show the count of a list when listing the lists so we have to figure it out :D [12:05:22] joakino, would a "over 500" be a good enough solution? [12:05:32] e.g. 0-500 shows exact, or 500+ [12:06:02] yurik_: maybe an acceptable compromise could be when editing a collection, instead of inc/dec the count field (which could be brittle) we do a count and update it on the lists table [12:06:20] yurik_: we shouldn't limit ourselves on the ui right now [12:06:37] still brittle - watchlist table is not under our control [12:06:56] i will see how count is done for the watchlist [12:06:57] yurik_: so the problem is counting the watchlist table? or our tables? [12:07:37] from what i remember from many years back, we always tried to avoid counting at all costs, but not by introducing a stored count [12:08:06] the watchlist table could be changed in other ways - i don't know everything that updates that table [12:08:15] our table is easier [12:10:02] just do the correct thing for our tables [12:10:16] )) [12:10:25] yurik_: and if for watchlist it is difficult then just ignore it for now, return 0 [12:10:53] yurik_: we'll call it a bug, report to PM design, maybe we'll hide the count on the watchlist on the UI for now [12:11:08] nah, can be done. I'm more worried about when we start migrating to the api - otherwise we have two parallel developments that will be diverging as time goes by [12:11:14] yurik_: we'll come up with something, having the watchlist there is a problem some times [12:11:52] yurik_: from what I know we are not touching backend (stores, models, api) at the moment, waiting on the api bits to be more fleshed out [12:12:03] yurik_: so that's on hold, don't worry [12:12:31] will talk about that on standup today to confirm, but that's what I understand we are doing [12:12:43] thats good - the reason i raised this is because i saw a change to the model files [12:12:52] (some func was added) [12:12:55] yurik_: we've been fleshing out the UI these days while you touch the api [12:13:02] oki [12:13:16] yurik_: probably a temporary bit for signing off things for the PMs & design [12:13:32] cool, thx [12:13:34] yurik_: i'll catch up with you later, gotta run now [12:13:47] yurik_: :D [12:14:33] l8r [12:31:17] 10Wikipedia-App-Android-App, 7I18n: Find alternative solution for translating the Android app description other than using a single large message in our translation files - https://phabricator.wikimedia.org/T91971#1104147 (10Nikerabbit) For how to use page translation, please see https://www.mediawiki.org/wiki... [12:33:03] Krenair: around ? [12:38:21] 10Wikipedia-App-Android-App: Allow saved pages in mobile to be organized - https://phabricator.wikimedia.org/T92255#1104153 (10Matanya) 3NEW [13:44:19] 10Wikipedia-App-Android-App: add a toolbox to mobile to allow printing, downloading etc - https://phabricator.wikimedia.org/T92266#1104286 (10Matanya) 3NEW [13:44:57] 10Wikipedia-App-Android-App: create a way to access all my saved pages online with a login in a desktop browser - https://phabricator.wikimedia.org/T92256#1104293 (10Matanya) [13:47:27] (03PS1) 10Phuedx: [WIP] Footer tweaks [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/195552 [14:10:50] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Zero, 7Design: only show features related to Zero if Zero is relevant in this context - https://phabricator.wikimedia.org/T92267#1104328 (10Amire80) 3NEW [14:12:39] 10Wikipedia-App-General-or-Unknown, 6Zero: Wikipedia app user not aware of using Wikipedia Zero - https://phabricator.wikimedia.org/T88241#1104335 (10Amire80) @nemo_bis, T88280 is probably an incorrect bug reference. [14:12:58] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Zero, 7Design: only show features related to Zero if Zero is relevant in this context - https://phabricator.wikimedia.org/T92267#1104340 (10Amire80) Issue T88241, reported by @nemo_bis, sounds related. [14:13:29] 10Wikipedia-App-General-or-Unknown, 6Zero: Wikipedia app user not aware of using Wikipedia Zero - https://phabricator.wikimedia.org/T88241#1006814 (10Amire80) Related: T92267. [14:53:59] 6Mobile-Web, 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, and 5 others: there should be a comparison of clicks count on interlanguage on different platforms - https://phabricator.wikimedia.org/T78351#1104526 (10Aklapper) [15:00:16] (03CR) 10Phuedx: "Tested locally and confirmed that response storage is working and aggregation is mostly working - there's no path through the code that in" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [15:22:34] 6Mobile-Web, 7Design: Styling regression in new editor tutorial - https://phabricator.wikimedia.org/T91141#1104643 (10phuedx) The arrow position should've been fixed by [194574](https://gerrit.wikimedia.org/r/194574). [15:37:24] 6Mobile-Web: The mobile Web wikicode editor loses the user-entered text - https://phabricator.wikimedia.org/T88949#1104690 (10phuedx) [15:54:43] 6Mobile-Web, 10MediaWiki-Categories, 5Patch-For-Review: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1104741 (10Edokter) That is somewhat expected; columns actually behave as one long page, which have basically been cut into three pie... [15:56:17] yo phuedx [15:56:23] hey joakino [15:56:30] just came back for the meeting [16:00:39] 6Mobile-Web, 10Flow, 7I18n: the message mobile-frontend-last-modified-with-user-just-now appears unnecessarily on the top of Flow mobile web pages - https://phabricator.wikimedia.org/T91886#1104773 (10phuedx) This appears to be caused by that page having a revision ID of `0`, though I'm not sure why that's t... [16:16:16] 10MobileFrontend-Feature-requests, 10MediaWiki-extensions-Collection, 6Wikisource, 7Mobile: A link should be provided to create a book from mobile - https://phabricator.wikimedia.org/T62249#1104860 (10Aklapper) [16:16:26] 10MobileFrontend-Feature-requests, 10MediaWiki-extensions-Collection, 6Wikisource, 7Mobile: download a book from mobile should be possible - https://phabricator.wikimedia.org/T62250#1104865 (10Aklapper) [16:17:46] 10MobileFrontend-stable, 6Wikisource: Empty XHTML tag br in mobile view - https://phabricator.wikimedia.org/T38018#1104945 (10Aklapper) [16:28:05] (03CR) 10Bgerstle: [C: 031] "looks good" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195016 (https://phabricator.wikimedia.org/T71838) (owner: 10Krinkle) [16:50:17] joakino: sup [16:50:30] hi jdlrobson [16:50:40] here figuring out safeguard stuff [16:51:07] safeguard for? [16:51:51] (03PS3) 10Jdlrobson: Hygiene: Renamed api action=editcollection -> editlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195499 (owner: 10Yurik) [16:52:22] jdlrobson: they are changing HR stuff [16:52:34] (03CR) 10Jdlrobson: [C: 031] "need to test" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195499 (owner: 10Yurik) [16:53:01] jdlrobson: hr/payroll stuff related to remote workers [16:53:27] jdlrobson: employement status, intermediary, salary conversions to local currency, everything. Or stay like business entity lose benefits, paid time, and who knows what else [16:53:47] joakino: not all benefits [16:53:59] but yeah, travel becomes a business expense [16:54:18] (03CR) 10Jdlrobson: action=query & list=lists implementation (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 (owner: 10Yurik) [16:54:41] phuedx: paid time off is important, i know it wasn't supposed to be there with the kind of contract, but that is something that affects salary by a sizable amount [16:55:11] that's why I said it seems like a drastic and big change to me, and want more info [16:55:33] sorry - brain is fuzzy, you're totally right [16:55:53] anyway, will see [16:56:11] (03CR) 10Jdlrobson: action=query & list=lists implementation (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 (owner: 10Yurik) [16:56:38] phuedx: joakino :( [16:59:01] (03CR) 10Yurik: action=query & list=lists implementation (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 (owner: 10Yurik) [16:59:05] jdlrobson: headaches [16:59:46] talking of headaches i have no idea what is happening to my vagrant [17:00:36] :/ [17:00:43] jdlrobson: I was talking with yurik before, he's concerned we evolve backend logic while he's doing api (he saw some changes to a model), I assured him that we are working on the frontend mainly and will work on integrating the api with the existing backend/frontend as the services start coming up (we're mostly not touching backend logic/json/crap), is that right? [17:00:43] jdlrobson: still or is this a new issue? [17:00:53] jdlrobson: kill it with fire [17:01:10] phuedx: i just removed Gather from LocalSettings [17:01:11] jdlrobson, rm -rf * [17:01:15] but somehow it is still alive [17:01:26] jdlrobson: [17:01:26] https://www.google.co.uk/search?q=nuke+it+from+orbit&espv=2&biw=1920&bih=958&tbm=isch&imgil=WIGEyUaRtfguIM%253A%253BR-iKY0maNVywTM%253Bhttp%25253A%25252F%25252Fmatthewwarlick.deviantart.com%25252Fart%25252FKeep-Calm-and-Nuke-It-From-Orbit-338057869&source=iu&pf=m&fir=WIGEyUaRtfguIM%253A%252CR-iKY0maNVywTM%252C_&usg=__qU2mkD80y0R5QJi-NyqPHJI2vCc%3D&ved=0CCoQy [17:01:26] jc&ei=USP_VJCEL8SP7AbeloCoBQ#imgrc=WIGEyUaRtfguIM%253A%3BR-iKY0maNVywTM%3Bhttp%253A%252F%252Fth02.deviantart.net%252Ffs70%252FPRE%252Fi%252F2012%252F321%252F8%252F0%252Fkeep_calm_and_nuke_it_from_orbit_by_matthewwarlick-d5l9r4d.jpg%3Bhttp%253A%252F%252Fmatthewwarlick.deviantart.com%252Fart%252FKeep-Calm-and-Nuke-It-From-Orbit-338057869%3B1191%3B670 [17:01:27] and changes i make to Gather are having no effect! [17:01:30] :/ [17:01:34] stupid irc client [17:01:41] or in windows parlance - Ctrl+A, Shift+Delete [17:02:16] joakino: that's correct though - we are iterating on frontend right now. Plan is to switch over backend when API's and database we need are in place [17:02:30] then we'll regroup - throw away code / refactor code / assemble new and improved code [17:03:08] jdlrobson, i think we shouldn't wait for DB backend, can do it with user pages [17:04:44] yurik: i'd rather do that - less disruptive [17:04:50] we have a hell of a lot of frontend problems to work out still [17:05:10] okay so now I can't access Special:Gather... [17:05:34] yurik: jdlrobson: with the endpoints in place we can start migrating while the db gets figured out, could be good too [17:08:57] dbrant|food: would you like me to resend that itunes connect invitation? essentially, you're gonna need to create a new apple id with your @wikimedia.org address. and install the testflight app on your ios device. and, when you get the tf wikipedia beta notification email, open the url in that email on your ios device [17:09:08] dbrant|food: pardon my tableside manners [17:11:05] (03PS2) 10Jdlrobson: Don't repeat Watchlist in existing collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195488 (https://phabricator.wikimedia.org/T92035) [17:11:20] ok no idea what was wrong with vagrant yesterday but this is workig today ^ [17:11:52] yurik: ok i'm free if you want to chat [17:12:07] does it make sense for joakino to join since you guys seem to have been chatting? [17:12:09] jdlrobson, sure [17:12:18] are hangouts working for you today yurik? [17:12:56] dr0ptp4kt: installing as we speak! (sorry for delaying) [17:17:02] dbrant|food: mwahahaha [17:22:35] (03PS1) 10Bmansurov: Restore anchor position [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195596 (https://phabricator.wikimedia.org/T91882) [17:25:18] dr0ptp4kt: installed! (and working) [17:25:43] dbrant|food: awwwww yeeeeeeeah boiiiii [17:28:08] jdlrobso_: are you guys talking? [17:34:15] (03CR) 10Bgerstle: [C: 031] "looks good, doesn't cause any side-effects AFAICT" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195060 (https://phabricator.wikimedia.org/T91605) (owner: 10Saltymule) [17:37:37] phuedx: hey sam [17:44:51] (03CR) 10Brion VIBBER: [C: 031] "I can confirm this fixes the search bug described in T91421 on my Windows Phone 8.1 Update and Windows 10 Tech Preview test phones." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194968 (https://phabricator.wikimedia.org/T91421) (owner: 10Bmansurov) [17:45:17] rmoen: ping me when you are in [17:45:45] jdlrobso_: i'm in just eating some cereal [17:46:18] rmoen: okay, i'm going to focus on helping yuri with api stuff today. I really need your help clearing out the frontend bugs we have - right now the product is not usable and we need to sort that out [17:46:49] jdlrobso_: sure thing [17:46:56] i'm getting stressed haha :-) thanks [17:47:10] jdlrobso_, chill )) [17:47:13] rmoen: the bugs are probably more important then collection deletion right now [17:47:14] its all good [17:47:28] since the current workflows are a bit of a mess on the frontend [17:47:51] jdlrobso_: thats ok, i can let the deletion chill for a bit [17:48:00] sweet [17:48:34] joakino: you're polishing https://phabricator.wikimedia.org/T90990 right? [17:48:50] jdlrobso_: yeps [17:49:06] (see my comment there about blue vs green - we really shouldn't be still having this discussion :-)) [17:49:09] (03CR) 10Kaldari: "I've updated the coding conventions:" [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/184062 (owner: 10Ori.livneh) [17:49:17] what do we do with the betalabsOnlyOOJS exception [17:49:23] jdlrobso_: i'm going to jump into some bugs in a sec. The bugs you are talking about are in ready for dev ? [17:49:30] ok sweet. gonna take a look at yuri's patches now [17:49:35] rmoen: yup all in ready for dev in order [17:50:24] yurik: i'm gonna attempt to write some patches on top of yours that make special pages use api okay? This will also let me test and give you the use case you need [17:50:40] ^ +1 [17:51:01] jdlrobso_, lets merge first - since there are no api users, it won't break any existing code, and will make further development easier [17:51:06] ok [17:51:12] its ok to merge even if it doesn't work :))) [17:51:15] (03CR) 10Jdlrobson: [C: 032] Hygiene: Renamed api action=editcollection -> editlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195499 (owner: 10Yurik) [17:51:36] jdlrobso_, if you merge all patches (except DB), i will fix the merge conflict [17:51:44] (03CR) 10Jdlrobson: [C: 032] action=query & list=lists implementation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 (owner: 10Yurik) [17:52:17] (03Merged) 10jenkins-bot: Hygiene: Renamed api action=editcollection -> editlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195499 (owner: 10Yurik) [17:52:19] (03CR) 10jenkins-bot: [V: 04-1] action=query & list=lists implementation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 (owner: 10Yurik) [17:52:46] yurik: can you drop the changed stuff from https://gerrit.wikimedia.org/r/#/c/194964/3/includes/api/ApiQueryListPages.php ? [17:52:52] $prop['changed']? [17:53:03] then i'm happy to merge [17:53:44] kaldari: hey [17:54:38] (03CR) 10Jdlrobson: [C: 04-1] "Please drop all the changed stuff" (036 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194964 (owner: 10Yurik) [17:55:09] kaldari: sup? [17:55:55] https://gerrit.wikimedia.org/r/#/c/194928/ < yurik needs rebase [17:56:02] jdlrobso_, on it [17:56:09] phuedx: one sec [17:58:50] (03PS1) 10Jdlrobson: Hygiene: Don't pass manifest by reference [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195609 [17:58:52] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Don't pass manifest by reference [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195609 (owner: 10Jdlrobson) [17:59:20] jdlrobso_: hi :) [17:59:26] hey FlorianSW :D [17:59:41] jdlrobso_: have you some minutes? I want to discuss something about https://phabricator.wikimedia.org/T91796 :) [17:59:45] i feel like i haven't seen you in a while due to all this Gather stuff but thanks for pushing along the talk page stuff i appreciate it [17:59:49] phuedx: just wondering if you wanted to chat about the WikiGrok response code Max is working on. [17:59:51] of course let me take a look [18:00:15] kaldari: sure i do, can we do it an hour? i've got to get george to bed [18:00:15] phuedx: Max wanted to get our thoughts on it, but his laptop just crashed or something [18:00:18] FlorianSW: are you going to attempt to do it !? :D [18:00:24] and it's a bath night [18:00:25] phuedx: sure [18:00:31] phuedx: no rush [18:00:42] jdlrobso_: i played around, because i thought: "It can't be so difficult" :P [18:00:53] \o/ [18:01:04] but here's the main problem: [18:01:19] kaldari: i'll be back in about an hour [18:01:48] (03PS8) 10Yurik: action=query & list=lists implementation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 [18:01:51] jdlrobso_, [18:01:53] ^^ [18:02:36] (03CR) 10Kaldari: [C: 04-1] "Multiple responses for the same page are correctly recording now, but wga_response_count isn't incremented (confirmed original report from" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [18:02:37] (03CR) 10Jdlrobson: [C: 032] action=query & list=lists implementation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 (owner: 10Yurik) [18:02:47] for saving we need to return the plain text with all line breaks, and there is no standard way of doing it (as far as i know). jQueryies .text() strips out line breaks (it seems to implement textContent property of W3C). The great news: I love Google chrome and they implemented innerText, which exactly doing, what we want and returns the text like we need it. [18:03:54] (03Merged) 10jenkins-bot: action=query & list=lists implementation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194928 (owner: 10Yurik) [18:03:56] but innerText isn't available on FF, Opera and Safari :( and there is no property/function doing the same. Do you know a way (or maybe you already did it?), how to handle this properly without introducing millions of hacky workarounds? [18:03:58] mmmmm...... could you restrict this to Google Chrome only? [18:04:01] jdlrobso_: ^ [18:04:18] jdlrobso_: possible (that was my first thought too :P) [18:04:36] it would be in beta mode only, so for testing maybe Chrome is enough for now? [18:05:29] FlorianSW: yup that's enough [18:05:37] FlorianSW: the idea would be to prove it as a concept [18:05:42] show it increases edits for that browser [18:05:52] then we can do the difficult thing of working out how to make it work on other browsers :) [18:06:25] ok :) Let me finish some code-design work and upload the change to discuss the approach with inline comments :) [18:08:10] (03PS2) 10Dr0ptp4kt: Don't invoke native bridge if there is selected text [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195060 (https://phabricator.wikimedia.org/T91605) (owner: 10Saltymule) [18:08:15] (03CR) 10jenkins-bot: [V: 04-1] Don't invoke native bridge if there is selected text [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195060 (https://phabricator.wikimedia.org/T91605) (owner: 10Saltymule) [18:09:11] jdlrobson: FlorianSW: browser editing is really hard, I think implementing a codemirror mode for wiki text and just loading codemirror there could be the easiest way [18:09:21] there is already a tiddly wiki mode :D http://codemirror.net/mode/tiddlywiki/index.html [18:09:30] kristenlans: your jshint linting caught one! https://gerrit.wikimedia.org/r/#/c/195060/2 [18:09:32] oops [18:09:37] meant for Krinkle|detached [18:10:04] joakino: yeh that would also make sense FlorianSW [18:10:05] (03PS2) 10Jdlrobson: Hygiene: Don't pass manifest by reference [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195609 [18:10:15] (03CR) 10Bgerstle: "Saltymule please fix jshint errors and resubmit. You can run it by going to the "www" directory and running "grunt jshint."" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195060 (https://phabricator.wikimedia.org/T91605) (owner: 10Saltymule) [18:10:17] joakino: yeh i think one of my old work colleagues made that! [18:10:34] jdlrobson: FlorianSW: also that would entail contributing to another OSS project so that's good too [18:10:38] hmm, how big is the library? *looking* [18:10:54] FlorianSW: it would just load when editing [18:11:03] FlorianSW: and library size doesn't matter too much at this point - we just want to see if it impacts editing [18:11:19] joakino: i don't want to use all my data of my limited plan just to edit :P [18:11:51] FlorianSW: ooh the hyperbole xD [18:12:25] yeah, ok, _I_ have a lot of data :P But... :D Just saying :P [18:14:03] joakino: jdlrobson ok, 146kB compressed, seems to be reasonable :) [18:14:49] FlorianSW: in here https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.0.0/codemirror.min.js i see 50kb transferred, so i'm guessing zipped is 50kb [18:15:06] (03PS1) 10Bgerstle: clean up image gallery [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195614 [18:15:29] mhurd: dr0ptp4kt time for a quick review? ^ [18:15:35] just missed some linting stuff yesterday [18:15:38] joakino: i think i have a revision with some addons :/ [18:15:41] bgerstle: sure [18:15:48] mhurd i think you asked me about the commit hook yesterday [18:16:04] (03CR) 10Dr0ptp4kt: "Tested on the following and it doesn't seem to break things, although @mhurd, please test." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195060 (https://phabricator.wikimedia.org/T91605) (owner: 10Saltymule) [18:16:05] i disabled it, but maybe i'll add it as a pre-push hook instead [18:16:13] joakino: jdlrobson should CodeMirror loaded from the official cdn or commited to our git? [18:16:15] FlorianSW: it says 146kb size as you said, but 50 transferred yep [18:16:16] dr0ptp4kt: i tested that one too [18:16:21] bgerstle: oh yeah! i saw those bits in my diff when i rebased on master [18:16:44] (03CR) 10Mhurd: [C: 031] clean up image gallery [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195614 (owner: 10Bgerstle) [18:16:46] (03CR) 10Jdlrobson: [C: 04-1] "has issues when you have watchlist in your user json - may be worth revisiting when moved away from current storage model" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195609 (owner: 10Jdlrobson) [18:16:48] dr0ptp4kt: ^ [18:17:28] joakino: ah, ok, but not every server supports compressing :D (ok, i'm quiet now :P) [18:17:40] haha [18:18:01] bgerstle: is the strong reference required? [18:18:24] dr0ptp4kt: the retain policy could be omitted, but having "weak" is misleading (as corey pointed out) [18:18:40] dr0ptp4kt: it's essentially a convenience getter which casts the view's layer to a CAGradientLayer [18:18:57] i would define it as a method, but defining a property gets you code completion for dot syntax [18:19:06] which i think is acceptable to use in this case [18:20:04] FlorianSW: http://www.mediawiki.org/wiki/Extension:CodeMirror [18:20:41] FlorianSW: http://test.foxway.org/w/index.php5?title=Sandbox:CodeMirror&action=edit [18:21:19] joakino: :D That's all we need and much more! [18:21:24] FlorianSW: there is surely something we can use from there [18:21:24] bgerstle: k [18:21:26] ye [18:21:30] bgerstle: now i'll actually run it :) [18:21:57] FlorianSW: now i want that everywhere [18:22:17] i'm wondering if we should simply install this extension (after a (security-)review), or just re-use the mediawiki mode? [18:22:23] jdlrobson, joakino ^^ [18:22:51] installing extensions might be very heavyweight :-/ [18:23:02] worth exploring though [18:23:14] bgerstle: LOL [18:23:18] i don't know much about that extension [18:23:25] but sounds promisin! [18:23:28] jdlrobson: that's what i mean :) So re-use mediawiki mode? It's licensed under gpl [18:23:34] kristenlans: what's so funny? [18:23:45] FlorianSW: explore how it does it and if we can load the scripts from MF scripts [18:23:54] bgerstle how helpful my jshint linting is! [18:24:05] FlorianSW: or grab the codemirror mode and publish it to codemirror repo, that would be good too [18:24:11] FlorianSW: seems fairly well done :D [18:24:16] haha [18:24:26] joakino: it uses ResourceLoader :D [18:24:27] kristenlans: also, while i've got your attention... what sprint are we on right now? :-/ [18:24:53] ah i guess 52 doesn't end until this week [18:24:55] friday* [18:25:06] bgerstle: you've got it all figured out ;-) [18:25:08] there's just so much talk about 53 going on i get confused [18:25:33] FlorianSW: then after installed should be a mw.loader.using away [18:25:34] i just keep chanting in my head (like Dory from finding nemo) "Just keep coding, just keep coding..." [18:25:39] looks promising [18:25:46] i figure the rest will sort itself out [18:26:00] joakino: let me test it :) [18:26:05] but basically yes [18:27:52] bgerstle: lulz. We can tweak the communications about future sprints to make it more clear where we're at in the cycle. [18:28:40] * kristenlans makes muttering noises about doing daily standups and a sprint kickoff meeting [18:29:51] * bgerstle echoes kristenlans' muttering [18:29:56] kristenlans: did you make you spaghettieis? :) [18:30:39] Not yet FlorianSW :-) Will you be in Lyon? Shoudl we try to fidn some then? [18:31:21] * FlorianSW runs away crying [18:31:26] kristenlans: no :( [18:31:36] i'm not in Lyon, i have no time :( [18:32:08] Awwwww bummer FlorianSW :'( [18:32:35] :( [18:32:54] :( [18:33:02] FlorianSW: there must be a way to get you to lyon!! what do we need to do!? :) [18:34:26] jdlrobson: give me more day's in this month :( That's the only way doing it, i need these day's to do the project(s) at work :( [18:36:06] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] clean up image gallery [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195614 (owner: 10Bgerstle) [18:37:43] (03PS51) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [18:37:49] bearND|food: i think i recall you and mhurd talking translation stuff the other day, but i'm not sure. did you guys define any sort of process around that? if not, you really shouldn't have to feel burdened to verify the translations on ios. i can even take over that task to relieve mhurd (mhurd, would that help you?) [18:38:53] (03PS1) 10Jdlrobson: API lists=lists tweaks [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195620 [18:38:55] (03PS1) 10Jdlrobson: WIP: Special:Gather and collections overlay should use API [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195621 [18:39:04] bearND|food: also, what do _you_ personally do when the incoming translations are broken? do you just fix them and amend the patch? where? [18:39:09] FlorianSW: could you do that work from the hackathon? :D [18:39:13] ^ yurik [18:39:26] (03CR) 10Jdlrobson: [C: 04-1] "See todo notes in commit message" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195621 (owner: 10Jdlrobson) [18:39:30] bearND|food: ...that is, i'm wondering how you handle that on android. i assume (you know what they say about that) that a similar process could be followed on ios [18:40:03] (03CR) 10Jdlrobson: [C: 032] Hygiene: transform messages to text [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195476 (owner: 10Robmoen) [18:40:05] jdlrobson: unfortunately not :( i need my equipment and the most important thing: the cars :( [18:40:55] jdlrobson: rmoen: yurik: gotta leave, sorry [18:40:55] thanks dr0ptp4kt [18:40:59] i'll continue tomorrow [18:41:01] bgerstle: yw [18:41:05] (03Merged) 10jenkins-bot: Hygiene: transform messages to text [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195476 (owner: 10Robmoen) [18:41:10] ok joakino [18:41:12] night! [18:41:20] mhurd dr0ptp4kt i'm starting to suspect that HockeyApp is the "Simulator is still running so eff off" problem [18:41:20] have a nice day [18:41:34] joakino: ciao :) [18:41:49] bgerstle: no i’ve had this problem since xcode 6 came out [18:42:05] orly [18:42:09] i just recently started encountering it [18:42:20] bgerstle: lucky [18:42:31] still disabling "setupCrashReporting" when TARGET_IPHONE_SIMULATOR [18:42:32] bgerstle: it’s been driving me nuts for months [18:42:36] i'm onto you... hockeyapp [18:42:41] haha [18:42:55] (03CR) 10Jdlrobson: "Haven't tested but apart from my comment looks okay." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195596 (https://phabricator.wikimedia.org/T91882) (owner: 10Bmansurov) [18:46:14] bgerstle: yeah, i was seeing it before. but still, "and that's what happens when you try to add crash reporting" [18:46:19] ;) [18:46:31] hehe [18:46:44] "Back to you, Jim" [18:47:32] (03PS2) 10Jdlrobson: Hygiene: Rename functions in ApiEditCollection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195452 [18:49:26] (03PS52) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [18:51:27] (03PS4) 10Yurik: Implemented action=query & list=listpages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194964 [18:51:28] jdlrobson, 6 [18:51:30] ^ [18:51:55] MaxSem, who are the DBAs other than springle? [18:52:11] nobody [18:52:31] (03CR) 10Jdlrobson: [C: 031] "Need to test. Lunch first :-)" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194964 (owner: 10Yurik) [18:57:32] (03PS1) 10Jdlrobson: Fix visual feedback for creating a new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195625 (https://phabricator.wikimedia.org/T92034) [18:57:34] (03PS1) 10Jdlrobson: Hygiene: Cleanup unused template parameter [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195626 [19:01:04] mhurd: dr0ptp4kt is elena on IRC? [19:01:30] bgerstle: hmm not sure [19:05:20] bgerstle: mhurd, i thought sometimes she hangs out here as etonkovidova, but don't see that handle. i'll email her about that [19:06:04] kaldari, MaxSem: hangouty hangout? [19:06:40] k [19:07:27] mhurd just got that AST thingy [19:07:30] interesting [19:08:55] bgerstle: ast? [19:10:27] i thought you said you ran into it [19:10:39] AST stands for Abstract Syntax Tree, something w/ the module cache [19:10:41] cleaning fixes it [19:11:49] bgerstle: hmm i dont recall… lost in memory fog of inscrutable xcode dump msgs [19:16:30] oh interesting [19:16:41] mhurd dr0ptp4kt looks like elena found an article w/ more than 50 images :-P [19:16:56] the monet one has...a lot, i'm guessing [19:17:01] bgerstle: hehe not surprised [19:17:02] i set the cap (perhaps too conservatively) at 50 [19:17:11] bgerstle: ah i see [19:17:11] i think android's is 200 [19:17:19] bgerstle: one billion [19:17:27] ;) [19:17:28] mhurd: maybe now's a good time t implement pagination? [19:17:36] MaxSem: i would use the "continue" arg to do that, right/ [19:17:40] bgerstle: nope [19:18:00] mhurd why not? [19:18:09] bgerstle: quick hangout? [19:18:14] sure [19:23:56] (03PS1) 10Dr0ptp4kt: Revise HockeyApp question posed to user [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195633 [19:24:03] ^ mhurd pls +2 [19:25:54] ping kaldari, MaxSem [19:26:06] it's 7:30pm here, i was hoping to wrap up soonish :) [19:31:53] phuedx, just back from lunch. we can talk soon, after kaldari finishes his luch too [19:33:03] also, when I worked remotely I used to start after you ended =) [19:34:27] (03PS1) 10Robmoen: Add scrollable element to collections content overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195638 (https://phabricator.wikimedia.org/T92050) [19:40:38] (03CR) 10Robmoen: "One question." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195488 (https://phabricator.wikimedia.org/T92035) (owner: 10Jdlrobson) [19:42:22] phuedx: ready to meet [19:42:36] woo [19:42:44] where shall we three meet? [19:44:02] phuedx: max is setting up a hangut [19:44:16] phuedx: should show up on calendar or email sopn [19:44:18] soon [19:44:38] i'll check my email sopn [19:45:42] :D [19:47:13] bgerstle: Continental Drift (novel) [19:48:00] brbs lunch [19:48:39] (03CR) 10Mhurd: [C: 032] Revise HockeyApp question posed to user [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195633 (owner: 10Dr0ptp4kt) [19:53:56] Deskana|Away: re https://www.mediawiki.org/wiki/Talk:Wikimedia_Engineering/2014-15_Goals/Q4#In-line_Wikidata_description_editing_on_the_Wikipedia_app is there anyone in particular we should involve in the prioritization discussions (eg tech leads, designers?) [19:55:35] brion: hey, how would i check that "continue" is implemented for imageinfo? [19:56:09] hmm [19:56:46] bgerstle: i think continue will only be available on a base query used as a generator for imageinfo [19:56:58] since imageinfo just takes a specific list of titles i’d think they all go in at once? [19:56:59] i’m not sure :) [19:57:10] http://i.imgur.com/wm9Srgj.gif [19:57:24] hehe [19:57:46] ok i do see a continue parameter in ApiQueryImageInfo.php [19:57:50] but i’m not sure how it acts :) [19:58:21] well, if *you're* not sure.. [19:58:34] mhurd claude monet's article has 69 images [19:58:36] exactly [19:58:47] bgerstle: haha nice [19:58:51] the main editor must have a sense of humor :-P [19:58:52] ok if i’m reading the source correctly, it’ll take the list from the ‘titles’ parameter and trim it if it’s too long [19:59:00] lemme try that in a direct query and see what it does [20:00:45] ehh that probably will die out with a query too big [20:00:53] oh wait that can be POSTed [20:01:05] ok i don’t have the infrastructure to test that many just yet ;) [20:01:08] brion here's a pastebin of the titles i'm trying to get: [20:01:09] File:Claude%20Monet%201899%20Nadar%20crop.jpg%7CFile:Claude%20Monet,%20Impression,%20soleil%20levant.jpg%7CFile:Claude%20Monet%20-%20Camille.JPG%7CFile:Monet%20dejeunersurlherbe.jpg%7CFile:Claude%20Monet-Madame%20Monet%20en%20costume%20japonais.jpg%7CFile:Monet,%20Claude%20-%20View%20At%20Rouelles,%20Le%20Havre%20(1858).jpg%7CFile:Claude%20Monet%20-%20Mouth% [20:01:09] 20of%20the%20Seine.jpg%7CFile:Claude%20Monet%20024.jpg%7CFile:Claude%20Monet%20022.jpg%7CFile:Claude%20Monet%20-%20Jardin%20%C3%A0%20Sainte-Adresse.jpg%7CFile:Claude%20Monet%20-%20The%20Luncheon%20-%20Google%20Art%20Project.jpg%7CFile:Claude%20Monet%20La%20Grenouill%C3%A9re.jpg%7CFile:Claude%20Monet%20-%20The%20Magpie%20-%20Google%20Art%20Project.jpg%7CFile: [20:01:09] Claude%20Monet,%201870,%20Le%20port%20de%20Trouville%20(Breakwater%20at%20Trouville,%20Low%20Tide),%20oil%20on%20canvas,%2054%20x%2065.7%20cm,%20Museum%20of%20Fine%20Arts,%20Budapest%7CFile:Claude%20Monet%20002.jpg%7CFile:Claude%20Monet%20-%20Jean%20Monet%20on%20his%20Hobby%20Horse.jpg%7CFile:Claude%20Monet%20-%20Springtime%20-%20Google%20Art%20Project.jpg%7 [20:01:09] CFile:Claude%20Monet,%201879,%20Camille%20sur%20son%20lit%20de%20mort,%20oil%20on%20canvas,%2090%20x%2068%20cm,%20Mus%C3%A9e%20d'Orsay,%20Paris.jpg%7CFile:Pierre-Auguste%20Renoir,%201875,%20Claude%20Monet,%20oil%20on%20canvas,%2084%20x%2060.5%20cm,%20Mus%C3%A9e%20d'Orsay,%20Paris%7CFile:Claude%20Monet,%201873,%20Camille%20Monet%20on%20a%20Bench,%20oil%20on%2 [20:01:09] 0canvas,%2060.6%20x%2080%7CFile:Claude%20Monet%20-%20The%20Artist's%20House%20at%20Argenteuil.jpg%7CFile:Claude%20Monet%20037.jpg%7CFile:Pont%20Argenteuil%20Monet%201.jpg%7CFile:Claude%20Monet%20The%20Studio%20Boat.jpg%7CFile:Claude%20Monet%20-%20Flowered%20Riverbank,%20Argenteuil.jpg%7CFile:Claude%20Monet%20003.jpg%7CFile:Monet%20-%20Vetheuil%20im%20Nebel.j [20:01:10] pg%7CFile:Claude%20Monet%20023.jpg%7CFile:Monet%20-%20Im%20Garten%20-%201895.jpeg%7CFile:1914-26%20Claude%20Monet%20Agapanthus%20MOMA%20NY%20anagoria.JPG%7CFile:Claude%20Monet%20-%20Les%20arceaux%20de%20roses,%20Giverny%20(Les%20arceaux%20fleuris).jpg%7CFile:Water-Lilies-and-Japanese-Bridge-(1897-1899)-Monet.jpg%7CFile:Monet%20-%20Seerosen%201906.jpg%7CFile: [20:01:10] Monet%20-%20Seerosen6.jpg%7CFile:Nympheas%2071293%203.jpg%7CFile:Monet%20-%20Seerosen5.jpg%7CFile:Monet%20in%20Garden,%20New%20York%20Times,%201922.JPG%7CFile:Nymph%C3%A9as%20reflets%20de%20saule%201916-19.jpg%7CFile:Claude%20Monet,%20Water-Lily%20Pond%20and%20Weeping%20Willow.JPG%7CFile:Claude%20Monet,%20Weeping%20Willow.JPG%7CFile:Claude%20Monet%20Weeping% [20:01:11] 20Willow.jpg%7CFile:Monet%20-%20Das%20Haus%20in%20den%20Rosen.jpeg%7CFile:Monet-%20Der%20Rosenweg%20in%20Giverny.jpeg%7CFile:1920-22%20Claude%20Monet%20The%20Japanese%20Footbridge%20MOMA%20NY%20anagoria.JPG%7CFile:Monet%20-%20Garten%20in%20Giverny.jpg%7CFile:Claude%20Monet%20-%20Rouen%20Cathedral,%20Facade%20(Sunset).JPG%7CFile:La%20Gare%20Saint-Lazare.jpg%7 [20:01:11] CFile:Arrival%20of%20the%20Normandy%20Train,%20Gare%20Saint-Lazare%201877%20Claude%20Monet.jpg%7CFile:Claude%20Monet%20The%20Cliffs%20at%20Etretat.jpg%7CFile:Monet%20-%20Segelboote%20hinter%20der%20Nadel%20bei%20Eretat%201885.jpg%7CFile:Claude%20Monet,%20Grainstacks%20in%20the%20Sunlight,%20Morning%20Effect,%201890,%20oil%20on%20canvas%2065%20x%20100%20cm.jp [20:01:12] g%7CFile:1270%20Wheatstacks,%201890-91,%2065.8%20x%20101%20cm,%2025%207-8%20x%2039%203-4%20in,%20The%20Art%20Institute%20of%20Chicago%7CFile:Claude%20Monet%20-%20Les%20Peupliers.jpg%7CFile:Monet%20Poplars%20on%20the%20River%20Epte.jpg%7CFile:Claude%20Monet%20-%20Branch%20of%20the%20Seine%20near%20Giverny.JPG%7CFile:Claude%20Monet%20-%20Morning%20on%20the%20S [20:01:12] eine%20-%20Google%20Art%20Project.jpg%7CFile:Charing%20Cross%20Bridge,%20Monet.jpg%7CFile:Claude%20Monet%20-%20Charing%20Cross%20Bridge%20(Saint%20Louis).jpg%7CFile:Claude%20Monet%20-%20Houses%20of%20Parliament,%20London.jpg%7CFile:Claude%20Monet%20015.jpg%7CFile:Claude%20Monet,%20Le%20Grand%20Canal.jpg%7CFile:Monet%20Grand%20Canal%20Legion%20of%20Honor.jpg% [20:01:13] 7CFile:Le%20bassin%20aux%20nymph%C3%A9as%20-%20Claude%20Monet.jpg%7CFile:WLA%20metmuseum%20Water%20Lilies%20by%20Claude%20Monet.jpg%7CFile:Claude%20Monet%20-%20Water%20Lilies,%201917-1919.JPG%7CFile:Claude%20Monet%20044.jpg%7CFile:Claude%20Monet,%20Water%20Lilies,%20ca.%201915-1926%7CFile:Claude%20Monet,%20The%20Water%20Lily%20Pond,%20c.%201917-19,%20frame%2 [20:01:13] 0cropped,%20Google%20Art%20Project%7CFile:Claude%20Monet,%20Impression,%20soleil%20levant,%201872.jpg [20:01:14] GSHH [20:01:14] SORRY [20:01:16] lol [20:01:17] heh [20:01:18] damnit IRCCLOUD [20:01:23] so helpful ;) [20:01:25] wow [20:01:31] take that! [20:01:36] irc cloud should let you put it in a pastebin [20:01:47] read: put it in a friggin' pastebin [20:01:56] g'night folks [20:02:06] i am orf [20:02:38] dr0ptp4kt: sorry it took a while to respond. So, mhurd merged the latest translation patch, and I abandoned the older ones yesterday. [20:02:43] http://pastebin.com/k2yRfmh7 [20:02:45] brion ^ [20:04:02] dr0ptp4kt: we have not come up with a good process yet. On Android I self-merge the translations. As a (Android) team we decided that string changes and version bumps are OK to self-merge. [20:04:05] ok lemme try that [20:04:35] brion there's an iicontinue FWIW [20:07:24] bgerstle: it looks like iicontinue is used for if there are a lot of images for each page….? seems odd since that shouldn’t really, um, happen :D [20:07:44] http://pastebin.com/VQMvS27e <- ok this query just shoving all the titles in doesn’t seem to use a continue breakup [20:07:47] dr0ptp4kt: When there are issues with the string I try to change the strings directly on TWN, with a comment why. [20:07:52] dr0ptp4kt: example: https://translatewiki.net/w/i.php?title=Wikimedia%3AWikipedia-android-strings-last_updated_text%2Fzh-hans&diff=5843734&oldid=5843013 [20:08:12] brion right, looks like i need to actually paginate this myself [20:08:19] funnnnnn [20:08:28] bgerstle: is there a max number of titles it’ll take before it explodes? [20:08:28] since i'm given the explicit list of filenames to fetch [20:08:39] dr0ptp4kt: ^ is an older one. Now I also prepend the string with !!FUZZY!!, which flags the translation for the translators to look at again [20:08:40] brion depends on device and RAM [20:08:43] heh [20:08:48] well that sounds fun to deal with :) [20:09:01] oh wait! the limit i'm hitting isn't even a request limit that i set [20:09:10] it's a limit on the number of titles you can fetch at once for a query—period [20:09:16] aho [20:09:22] at least that should be a consistent limit, i think [20:09:28] dr0ptp4kt: example for !!FUZZY!!: https://translatewiki.net/w/i.php?title=Wikimedia:Wikipedia-android-strings-gallery_license_text/pt-br&diff=prev&oldid=6026741 [20:09:30] bgerstle: huh! [20:09:34] interesting [20:09:43] mediawiki api: keeping things interesting ;) [20:09:47] "Too many values supplied for parameter 'titles': the limit is 50" [20:09:48] hehe [20:10:01] client-side pagination, GO! [20:10:13] dr0ptp4kt: in the above case I didn't even change the string but added a comment why I think it should be changed. [20:10:14] mhurd bearND hurry up w/ that damn node service already [20:10:18] bgerstle: ACTIVATE THE DEVICE! [20:10:28] lol [20:11:04] OTOH it would also be nice if we had a "give me the images for ${title || pageId}" [20:11:19] which didn't quite behave like i expected when i first started working on this [20:12:00] dr0ptp4kt: it depends on how serious the change is. If it breaks the app I tend to change the string myself. Sometimes even just directly on the Android side. But then I'd have to remember to feed it back to TWN [20:12:12] bgerstle: maybe chat with bearND or dbrant [20:12:20] right [20:12:27] or just look at the code.. [20:12:28] bgerstle: would love to but more is planned next sprint [20:12:50] bearND: bgerstle mhurd dbrant|brb, i gotta disconnect briefly. will review chat history once done with a task [20:12:51] well un-plan the non-service stuff :-P [20:12:56] dr0ptp4kt: k [20:13:01] can't we just change your title and make you the official back-end dev :-P [20:13:08] k [20:13:13] dr0ptp4kt: k [20:15:33] bearND: how are you guys populating the gallery w/ images? [20:15:37] and/or fetching image info? [20:15:42] i see you're fetching imageinfo by title [20:15:47] but same for the "GalleryCollection" [20:15:57] which i assume is "fetch N gallery 'items' for $title" [20:17:09] bgerstle: the Java code for Android spcifically was witten by dbrant|brb so he can tellyou, but from what I remember and from porting that to JS [20:17:12] oops [20:17:17] was still editing that [20:17:19] k [20:18:07] bgerstle: the Java code for Android spcifically was written by dbrant|brb so he can tell best. I did port most of the code to JS but it's not complete yet [20:19:04] first it gets the collection info and then the Android code makes a request to get the details for for each item (at least on the Java side) [20:19:28] wait [20:19:34] so for the Monet article [20:19:40] you would fetch a "gallery" of 69 items [20:19:45] My JS code makes only up to 3 requests. The initial one then one for all images and another one for all videos [20:19:46] then send 69 requests for the info of each? [20:20:50] That's how I remember it from looking at the Java code. But let me look... [20:21:13] as they're presented, it seems [20:21:19] each GalleryItemFragment will create a corresponding fetch task [20:21:42] jdlrobson: do you have a minute? [20:21:44] there's also some weird searching/processing of the results of the "images" request [20:22:13] in GalleryActivity#applyGalleryCollection() [20:22:29] (seriously you guys should check out Guava :-P ) [20:22:37] codezee: sure [20:23:15] jdlrobson: just a small question, once the pagebanner extension is made, can the task of replacing the template functionality with that of extension be somehow automated? [20:23:26] codezee: i suspect so [20:23:48] sort of thing that could easily be done by a bot (really it would just be a case of removing usage of that template) [20:24:07] also, I guess, something would need to be done about the template code which will in any case exist within wikitext of each of the pages [20:24:13] ok, I get it [20:24:29] we delegate it to the bot [20:25:52] jdlrobson: also, just letting you know that though the task still requires a lot of community feedback, I'm going ahead and creating an initial draft on my namespace just to chalk out the exact steps and keep updating it as it develope [20:26:49] chrismcmahon, greg-g: Could one of you add myself and jdlrobson to the importer user group on beta labs? [20:26:55] pagebanner extension ? is that different thand CentralNotice ? [20:27:06] kaldari: will do [20:27:11] thanks! [20:27:51] codezee: sounds good :) the wikivoyage community seems super friendly and helpful, i'm happy to support it if we get one of them to assist us to ensure we meet their requirements [20:27:52] thedj: I believe pagebanner is for images, ala WikiVoyage [20:27:55] bgerstle: sorry i missed the conversation. did bearND answer your question? [20:27:59] ah that [20:28:06] thedj: yeh the idea is to replace wikivoyage's banner templates [20:28:07] (03PS1) 10Jdlrobson: Create interface should be on a single line on smaller screens [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195654 [20:28:15] put it in a generic extension which works nicely on mobile [20:28:22] jdlrobson: for both mobile and desktop ? [20:28:25] yup [20:28:31] cool [20:28:33] dbrant: not yet, I think, but it would be best if you continued. Still have a huge backlog of emails to answer [20:28:35] dbrant: no worries, he basically did. [20:28:50] and hopefully combine it with the stuff we've been fiddling around with in alpha for mobile (but that's not so important) [20:29:03] kaldari: user "kaldari" has lots and lots of rights on beta labs now [20:29:11] good work [20:29:15] Hit "prop=images" then fetch individual "prop=imageinfo" for each gallery item [20:29:19] jdlrobson: alright, till then I'll do my work :) [20:29:21] what I can tell you that this would be simpler in the future if we adopt the node service. [20:29:25] bgerstle: ^ [20:29:34] hear, hear [20:29:56] user 'jdlrobson' also has lots of rights now [20:30:42] bearND: thanks for the feedback on twn. ok, so we should (1) amend tranlation patches if errors and (2) prepend with !!FUZZY!! in twn with an explanation as to why it's !!FUZZY!!. i suppose the onus is also on us to update the qqq file in case we're not offering clear instructions to translators [20:30:42] dbrant: if I understand this correctly the galler collection send off one request per image viewed to get the details. So if you have 69 items but you only look at the first 10 then the app sends off 11 total requests for metadata (not counting image/video files) [20:30:51] bearND: gotta disconnect again [20:31:00] bearND: that is correct [20:31:08] chrismcmahon: with rights come obligations, i'd say, make him work for you :) [20:31:20] bearND: I'm no Android dev but that's what I gathered. [20:31:30] thedj: that's why they get all the rights :) [20:31:54] dbrant: bgerstle: good. then we are in agreement [20:31:55] chrismcmahon: i dont have that one :( [20:32:11] i dont have import rights [20:32:17] jdlrobson: how so? [20:32:24] no idea [20:32:52] jdlrobson: I am looking at your page and importer is checked [20:33:11] https://phabricator.wikimedia.org/T92309 < chrismcmahon [20:33:14] jdlrobson: log in and see this page? http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special%3AUserRights&user=jdlrobson [20:33:33] ohh wait [20:33:43] someone must have changed something in last 10 mins [20:34:09] yay! [20:38:07] jdlrobson: I just did [20:39:14] kaldari: haven't read scrollback, can you file a ticket if it isn't already taken care of? [20:39:42] bearND: ok, im back [20:40:23] dr0ptp4kt: great [20:41:17] dr0ptp4kt: What you wrote last before you disconnected is good [20:41:31] greg-g: Should be taken care of already. Thanks! [20:41:43] bearND: thx. mhurd, do you want me to handle incoming translations on ios? [20:41:52] mhurd: i'm over on couch [20:42:03] mhurd: just sayin' [20:42:40] dr0ptp4kt: I think it would be best to have one iOS eng. as point of contact for me to ping about dealing with translations (getting them merged, fixing problems) [20:43:07] thanks chrismcmahon :D [20:43:15] Well, my landline Internet is out :-/ [20:43:37] Dog walk is happening early today! Will try again when I get back [20:43:43] dr0ptp4kt: As I shows mhurd, on Android I have a unit test to make sure the parameters in the translations match up with the original English text [20:44:21] dr0ptp4kt: that's more an issue on Android since the parameter syntax is very confusing, esp. to outsiders [20:44:34] dr0ptp4kt: on IOS you have it easy ($1, $2, ...) [20:46:10] bearND: yeah, mostly. do you just run the test locally, or is it part of a voting job? [20:46:28] dr0ptp4kt: For Android Deskana|Away also write a missing-qq.py script [20:47:16] dr0ptp4kt: I just run the test locally. Actually we don't have a Jenkins job for tests yet unfortunately. [20:48:34] dr0ptp4kt: It's pending but haven't heard from our CI guys in a while (https://phabricator.wikimedia.org/T88494) [20:49:54] dr0ptp4kt: The test I wrote is a JUnit test and would be part of our regular test suite if we were able to run it on a server. [21:02:14] jdlrobson2: Any hope for https://gerrit.wikimedia.org/r/#/c/180647/ ? [21:32:15] jdlrobson2: I grepped Flow, but it doesn’t look like they are currently using mediawiki.template, unless I’m missing something. [21:36:50] jdlrobson2: ping^ [21:37:03] hey kaldari no they use handlebars [21:37:07] which has a dependency on mediawiki.template [21:37:14] it may even still be in Mantle [21:37:18] jdlrobson2: oh [21:37:41] ergg https://phabricator.wikimedia.org/T85890 [21:37:56] yeah, you’re right [21:38:49] kaldari, I was thinking: if claim=null, what should action be? [21:40:02] "do nothing"? [21:41:15] bgerstle: have a second? [21:41:44] MaxSem: hmm [21:44:29] MaxSem: action=null? [21:44:36] mmmm [21:44:56] elegant, but not intuitive? :P [21:50:31] Walking the dogs right now. Be back in a bit. [21:50:37] bgerstle: no worry [21:51:36] Also my ISP has been down [21:51:52] bgerstle: doh! [21:53:13] jhobs: will you be in lyon? [21:53:33] jdlrobson2: unfortunately, no [21:53:50] jhobs: :( [21:53:59] any trips to sf anytime soon? [21:54:06] none planned [21:54:32] :( [21:54:36] jhobs: we need beers! [21:54:42] haha I agree! [22:05:57] The_Real_NSA: are you watching me? [22:05:59] lols [22:06:29] Don't mind me. [22:06:32] Just lurking [22:06:40] I'm not logging or anything [22:06:43] haha [22:07:03] mhurd: back, and so is the internet \o/ [22:07:11] bgerstle: yay! [22:07:18] hangout? [22:07:26] bgerstle: ya [22:08:15] bgerstle: I'll be watching [22:08:35] So make sure you're presentable! [22:11:50] etonkovi_: hi there < bgerstle mhurd [22:13:14] dr0ptp4kt: hello :) [22:14:46] ok, that's my sign to leave today :D [22:18:20] hi etonkovi_! [22:19:10] kristenlans: hello :) [22:21:50] jdlrobson2, lspid, not id [22:26:29] (03PS2) 10Bmansurov: Restore anchor position [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195596 (https://phabricator.wikimedia.org/T91882) [22:26:35] (03CR) 10Robmoen: "I've spent 1.5 hours trying various ways. I've also tried absolute inside a relative and couldn't get the positioning right. It's not as" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195638 (https://phabricator.wikimedia.org/T92050) (owner: 10Robmoen) [22:26:41] (03PS5) 10Dr0ptp4kt: grunt: Make jshint pass [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195016 (https://phabricator.wikimedia.org/T71838) (owner: 10Krinkle) [22:27:01] (03CR) 10Dr0ptp4kt: [C: 04-1] "@Saltymule, putting the -1 here so we don't accidentally merge - see @bgerstle comment about jshint." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195060 (https://phabricator.wikimedia.org/T91605) (owner: 10Saltymule) [22:27:17] (03CR) 10Robmoen: [C: 04-1] "flagging so you'll see my comment." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195488 (https://phabricator.wikimedia.org/T92035) (owner: 10Jdlrobson) [22:27:23] (03CR) 10Robmoen: Add scrollable element to collections content overlay (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195638 (https://phabricator.wikimedia.org/T92050) (owner: 10Robmoen) [22:27:57] (03CR) 10Dr0ptp4kt: [C: 032] "Code looks good and it runs fine in the simulator, thanks @Krinkle." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195016 (https://phabricator.wikimedia.org/T71838) (owner: 10Krinkle) [22:28:07] helooooooooooo jenkins [22:28:09] (03PS1) 10Bmansurov: Use updated schema [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/195678 (https://phabricator.wikimedia.org/T86855) [22:28:43] (03PS53) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [22:28:52] (03CR) 10jenkins-bot: [V: 04-1] Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [22:29:14] (03CR) 10Robmoen: [C: 032] "Ok after chatting with Jon about this, the intention is clear to me now. Just making sure watchlist its not in the list twice. For not i" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195488 (https://phabricator.wikimedia.org/T92035) (owner: 10Jdlrobson) [22:29:20] (03Merged) 10jenkins-bot: Don't repeat Watchlist in existing collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195488 (https://phabricator.wikimedia.org/T92035) (owner: 10Jdlrobson) [22:29:24] (03CR) 10Robmoen: [C: 032] "Awesome!! This was really bugging me." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195664 (https://phabricator.wikimedia.org/T92029) (owner: 10Jdlrobson) [22:29:28] (03PS1) 10Bmansurov: Use view events [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/195772 (https://phabricator.wikimedia.org/T88296) [22:29:30] (03CR) 10jenkins-bot: [V: 04-1] Use view events [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/195772 (https://phabricator.wikimedia.org/T88296) (owner: 10Bmansurov) [22:29:38] (03CR) 10Robmoen: [C: 032] Hygiene: Cleanup how modules are added [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195662 (owner: 10Jdlrobson) [22:29:40] (03CR) 10Robmoen: [C: 032] Hygiene: Remove dead css [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195663 (owner: 10Jdlrobson) [22:30:58] (03PS1) 10Dr0ptp4kt: Truncate logged share text at 99 characters [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195777 [22:31:55] bgerstle: mhurd ^ would you please quick review? bgerstle first, mhurd second. bgerstle, yeah i know, gotta do other bugfixes. trying to do small patches [22:32:29] dr0ptp4kt: ya know [22:32:36] it would really help if you did smaller patches [22:32:43] i mean 6 lines added and 2 removed? [22:32:49] WHAT AM I SUPPOSED TO DO W/ ALL THAT DIFF? [22:35:49] dr0ptp4kt: i left a comment, not sure why it's not bouncing back here [22:36:01] dr0ptp4kt: also, is there a way to check *all* log message fields to ensure their lengths aren't too long? [22:36:30] (e.g. in the superclass impl?) [22:37:14] hi etonkovidova! did you see the tickets i moved to "Ready for Signoff" that i was unable to repro? [22:48:05] mhurd: you're fixing -[MWKImage isCached] to not read & throw away image data, right? [22:48:07] or should i do that? [22:52:34] mhurd y'hurd me? ^ [22:53:21] bgerstle: i fixed [22:53:30] ok [22:53:34] is your patch up yet? [22:53:48] bgerstle: lemme push my latest [22:54:39] mhurd: i think i've got my stuff where i want it [22:54:49] if you'd rather just try it out [22:57:10] bgerstle: my patch is still WIP - but i just pushed latest here https://gerrit.wikimedia.org/r/#/c/193323 [22:57:22] ok, i'll leave my changes up then [22:57:29] bgerstle: i may be wrong about “-[MWKImage isCached] “ [22:57:35] lemme see. [22:57:49] dr0ptp4kt: did you see my comment on your patch? [22:58:23] mhurd looks like you changed isCached to a sane implementation ;-) [22:58:32] bgerstle: yay! [22:58:39] bgerstle: i strive for sanity [22:59:04] before MWKImage was all like http://www.blogcdn.com/www.urlesque.com/media/2010/12/deal-with-it.jpg [22:59:17] jdlrobson2, ping [23:00:18] bgerstle: hehe [23:02:26] bgerstle: yep, see it, will do [23:03:09] mhurd posted here as a draft change https://gerrit.wikimedia.org/r/195790 [23:03:29] mhurd check out the diff, and see the console messages to verify it does what you expect (it should) [23:03:30] bgerstle: we don't need to update all strings, only the ones that are known to become too long. that said, figuring out an elegant way to do that would be nice. i think basic code generation on the logging schema might be simple [23:03:37] er, one approach [23:03:43] dr0ptp4kt: JSON SCHEMA!!!! [23:03:47] CAN I PLEASE?! [23:04:02] JSON SCHEMA ALL THE THINGS [23:04:07] sorry, i uh [23:04:10] got a bit carried away there [23:04:46] dr0ptp4kt: we could do unit tests as well [23:04:49] simple [23:05:26] shared behavior for all event logging "model" classes: "when serialized to JSON, all stringified values are less than N chars" [23:05:33] should be easy enough to do [23:06:16] mhurd wanna give my patch a quick glance before i check out? [23:06:29] about dinner time o'er here [23:11:20] bgerstle: right. there's other fine grained business logic, but getting that kind of stuff in place would save programmer time and error. on a related note: nuria (hi!) in analytics is submitting a bug to make there be warnings at the server for overlong string fields; that way the programmer can go back and fix client source code as appropriate (remember, event logging events return a 204 as a fire-n-forget) [23:11:45] right [23:12:20] dr0ptp4kt: the task is here: https://phabricator.wikimedia.org/T91918 [23:12:24] great that we can get support from the back-end to help us find these things :-) [23:12:52] bgerstle, dr0ptp4kt : let me read back a abit ... [23:13:12] nuria: TL;DR; get server feedback when log payloads are too big [23:13:14] right dr0ptp4kt ? [23:13:20] mhurd last call, heading out shortly [23:13:47] bgerstle: server feedback per event? that seems overkill [23:13:57] bgerstle: hey just got back [23:14:07] bgerstle: checking... [23:14:29] bgerstle: these are 204's in varnish just in case you think they are going elsewhere [23:14:31] "make there be warnings at the server for overlong string fields" [23:14:57] bgerstle: that the client receives? [23:14:58] i interpreted that as "if the client sends an event payload which can't be serialized or exceeds some threshold, they get a warning" [23:15:09] bgerstle: did you tag me on the patch? [23:15:15] mhurd nope, lemme do that [23:15:27] done [23:15:35] bgerstle: got it [23:15:54] nuria: dr0ptp4kt i'll let you two sort it out ;-) [23:16:45] bgerstle: what it's teh usage of getting warnings at other than dev time? [23:17:07] bgerstle: compiling.. [23:17:21] nuria: we'll definitely to do at least some of that [23:17:26] Maryana: http://sf.eater.com/2015/3/3/8143043/millennium-new-location-rockridge-vegan-kickstarter [23:17:31] bgerstle: at dev time, sure, so developers can get prompt feedback. [23:17:48] bgerstle: in prod.... mmmm... it's like sending warnings to /dev/null [23:17:55] nuria and i'm sure we can be creative about how we test that all logging schema implementations truncate appropriate (using shared behaviors in unit tests as i alluded to above) [23:18:20] i was thinking that "in the wild" we might be sending log payloads we didn't expect [23:18:32] bgerstle: client side yes. Certatinly. [23:18:35] and AFAIK there's 0 feedback on when they are too big, malformed, etc. [23:18:54] bgerstle: no, there is a dev server you can use now [23:19:10] bgerstle: that does validation, it's been working for at least a year. let me send link [23:19:18] bgerstle: seems legit [23:19:31] nuria thanks, but no need to get into the weeds now. dr0ptp4kt and i were just spitballing [23:19:53] we'll harden up the client side as best we can, and maybe later we can sync up about how to get validation for "real" log messages [23:20:25] bgerstle: Ok, so you know the devserver is easy to setup: http://www.mediawiki.org/wiki/Extension:EventLogging/Guide#Installing_the_EventLogging_devserver [23:20:32] bgerstle: i +1’ed it [23:20:44] bgerstle: it's on us to update it to give you an error if event is too long [23:20:49] nuria: bookmarked, thanks! [23:21:03] mhurd: it was a draft patch, should i publish it? [23:21:04] dr0ptp4kt: have a minute to review https://gerrit.wikimedia.org/r/#/c/195790/ ? [23:21:12] lol oops [23:21:14] yeah [23:21:28] didn’t notice status draft [23:21:31] ok mhurd it's published [23:21:39] feel free to merge or incorporate into your patch as you see fit [23:22:01] bgerstle: k [23:22:03] bgerstle: thanks! [23:22:08] dr0ptp4kt: need anything before i slip away into the night? [23:22:25] bgerstle: nah, have a good night. [23:22:28] mhurd: will look at that patch [23:22:34] dr0ptp4kt: thanks! [23:23:03] k, later! [23:33:31] Hey Max, I’ve been thinking more about the schemas, and it seems like it would be actually be easier to do duplicate detection if positiive and null responses were combined into 1 aggregation row. Could you explain why you were thinking that it would be more difficult that way? [23:33:35] MaxSem: ^ [23:33:53] dr0ptp4kt: do you want to just amend https://gerrit.wikimedia.org/r/#/c/195060/ so we can merge? [23:49:20] jdlrobson2, ping [23:51:31] MaxSem: I think the way you have implemented it is good. I just wanted to think through another option with you since you were saying that you felt like the current solution isn’t elegant. We don’t need to rewrite what you have though. It’s probably better than my idea anyway :)