[00:14:08] jdlrobson2, possibly this one's for you? https://phabricator.wikimedia.org/T92347 [00:16:39] oh dear [00:16:53] what username quiddity ? [00:17:01] "quiddity" [00:17:50] try refreshing [00:18:00] jdlrobson2 is MIA [00:18:09] That works, thank you! [00:18:25] quiddity: cool i'll update bug [00:18:43] cheers, hopefully it was unique, and useful-in-the-end! >.> [00:19:18] quiddity: very useful [00:19:22] i fixed by clearing the user json [00:19:27] you ended up with invalid stuff somehow [00:19:56] * quiddity clicks ALLLL the buttons! :D [04:54:48] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: UI locks while typing a search Term - https://phabricator.wikimedia.org/T91775#1107281 (10Fjalapeno) Source of the slow down has been found We are using autolayout to size the cells - but we are doing the offscreen cell method (iOS 6 compatib... [07:53:57] (03CR) 10Mhurd: "almost done i promise :) will amend in the morning." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [08:19:26] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: UI locks while typing a search Term - https://phabricator.wikimedia.org/T91775#1108661 (10Mhurd) Let's hold off on any refactors of these cell layouts until we have a chance to talk. Background: We do indeed, by design, vary the search resul... [08:22:02] 10MobileFrontend-Feature-requests: Make MobileFrontend add a mobile rel=alternative to the desktop version instead of noindexing mobile pages - https://phabricator.wikimedia.org/T91183#1108666 (10Florian) 5Resolved>3Open Can someone check the behavior on wikisource.org (group1, the change was deployed yester... [08:22:12] 10MobileFrontend-Feature-requests: Make MobileFrontend add a mobile rel=alternative to the desktop version instead of noindexing mobile pages - https://phabricator.wikimedia.org/T91183#1108668 (10Florian) p:5Triage>3High [08:22:31] 6Mobile-Web, 10MobileFrontend-Feature-requests: Make MobileFrontend add a mobile rel=alternative to the desktop version instead of noindexing mobile pages - https://phabricator.wikimedia.org/T91183#1076112 (10Florian) [08:35:18] 6Mobile-Web: Deemphasise wikitext markup in editor - https://phabricator.wikimedia.org/T91796#1108698 (10Pastakhov) Thanks you for adding me here. The CodeMirror library is awesome. Originally I wanted syntax highlighting and auto completion for the PhpTags extension. But I couldn't leave gray wikitext markup a... [08:41:45] 6Mobile-Web, 10MediaWiki-Categories, 5Patch-For-Review: Categories should not be rendered in a table (do not display well on mobile) - https://phabricator.wikimedia.org/T55130#1108710 (10Edokter) It concerns both desktop and mobile, so i would say rename. [08:59:13] good morning! [10:01:38] morning joakino [10:06:02] hi phuedx [10:09:00] my email game has improved so much [10:09:07] select all, mark as read, archive [10:09:34] phuedx: lol [10:09:51] wikitech has been fairly low traffic but apps emails have increased a lot [10:09:52] xd [10:12:16] lol [10:24:52] (03CR) 10Phuedx: WIP: Preload banner images (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [10:25:19] gonna nip out to the shops and buy some nice sausages [10:25:34] sausage sandwich for breakfast! [10:46:59] (03PS1) 10Jhernandez: Fix edit/delete of collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195880 (https://phabricator.wikimedia.org/T90990) [11:08:39] (03CR) 10Florianschmidtwelzow: [C: 04-1] Register hogen.js via module name 'mediawiki.template.hogen' (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [11:12:16] (03CR) 10Saltymule: "I am having some issues:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195060 (https://phabricator.wikimedia.org/T91605) (owner: 10Saltymule) [11:15:24] (03CR) 10Phuedx: [C: 04-1] "This works well in Firefox Developer Edition 37.02a2 but not in Chrome 40.0.2214.115. Unfortunately, you're gonna have to battle against s" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195596 (https://phabricator.wikimedia.org/T91882) (owner: 10Bmansurov) [11:25:33] (03PS1) 10Jhernandez: Fix design issues [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195884 (https://phabricator.wikimedia.org/T91634) [11:27:50] (03CR) 10Phuedx: [C: 032] Hygiene: appendToElement standardisation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195795 (owner: 10Jdlrobson) [11:29:09] (03PS2) 10Jhernandez: Fix design issues (spacing and icon position) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195884 (https://phabricator.wikimedia.org/T91634) [11:29:29] (03Merged) 10jenkins-bot: Hygiene: appendToElement standardisation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195795 (owner: 10Jdlrobson) [11:29:56] joakino: what does "toundra" mean? [11:30:43] huh [11:30:51] i thought it was spanish [11:30:58] apparently google says otherwise [11:31:04] brb -- shoppps [11:31:53] phuedx: lol [11:32:03] bb [11:44:35] 10Wikipedia-App-Android-App: App does not catch edit conflicts, just overwrites - https://phabricator.wikimedia.org/T92373#1108938 (10Krenair) 3NEW [11:51:01] Not sure if we have anyone here able to read Chinese... but https://zh.wikipedia.org/wiki/User_talk:Tigerzeng/Bugs is relevant to the mobile apps [11:51:06] back [11:55:48] (03CR) 10Florianschmidtwelzow: [C: 032] Hygiene: Use more sensible defaults for content overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195785 (owner: 10Jdlrobson) [11:56:53] (03Merged) 10jenkins-bot: Hygiene: Use more sensible defaults for content overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195785 (owner: 10Jdlrobson) [12:09:50] 10Wikipedia-App-Android-App, 10MediaWiki-extensions-GeoData, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, and 4 others: GeoData should pull coordinates from Wikidata on sites with the Wikibase Client - https://phabricator.wikimedia.org/T35704#1108969 (10Tobi_WMDE_SW) [12:26:18] away for lunch [12:26:36] i'm out for lunch/gyjm [12:30:04] (03CR) 10Phuedx: [C: 031] "This LGTM." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194968 (https://phabricator.wikimedia.org/T91421) (owner: 10Bmansurov) [13:22:05] backsies [13:39:50] (03CR) 10Phuedx: [C: 04-1] Use updated schema (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/195678 (https://phabricator.wikimedia.org/T86855) (owner: 10Bmansurov) [13:40:52] (03PS2) 10Phuedx: Use latest version of MobileWebWikiGrokError schema [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/195678 (https://phabricator.wikimedia.org/T86855) (owner: 10Bmansurov) [13:41:06] (03CR) 10Phuedx: [C: 032] Use latest version of MobileWebWikiGrokError schema [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/195678 (https://phabricator.wikimedia.org/T86855) (owner: 10Bmansurov) [13:42:08] (03Merged) 10jenkins-bot: Use latest version of MobileWebWikiGrokError schema [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/195678 (https://phabricator.wikimedia.org/T86855) (owner: 10Bmansurov) [14:11:30] Saltymule: ping [14:12:32] (03PS3) 10Bgerstle: Don't invoke native bridge if there is selected text [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195060 (https://phabricator.wikimedia.org/T91605) (owner: 10Saltymule) [14:14:36] (03CR) 10Bgerstle: [C: 031] "rebased on top of master, which puts .jshintrc in the right directory. jshint now passes." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195060 (https://phabricator.wikimedia.org/T91605) (owner: 10Saltymule) [14:18:07] wha?! [14:18:22] virtualbox decided to drop a virtual machine image :/ [14:33:53] gwicke: hey! congrats on the REST deployment! [14:33:57] have a second for a couple questions? [15:03:34] dbrant: mornin' [15:03:45] hello! [15:04:06] in the android image gallery.. did you guys try making a "prop=imageinfo" request w/ the generator set to "images"? [15:04:52] also, have you pinged anyone on MW API team to ask if they could explain why things like the Wikipedia logo or various icons are returned by the "images" prop? [15:06:23] bgerstle: "generator=images" is exactly what we use to get the full list of images. [15:06:43] but why do a separate imageinfo request? [15:06:45] for each one? [15:07:04] it seems like you can get everything you need w/ prop=imageinfo & generator=images [15:07:20] https://en.wikipedia.org/wiki/Special:ApiSandbox#action=query&prop=imageinfo&format=json&iiprop=url%7Cdimensions&indexpageids=&titles=Claude%20Monet&generator=images&gimlimit=200] [15:07:33] even has "continue" functionality, it seems [15:07:50] bgerstle: to get the extended metadata. If we get all the data with the generator, it would become an extremely large payload. [15:08:15] dbrant are you using extmetadatafilter? [15:12:03] curl 'en.wikipedia.org/w/api.php?action=query&prop=imageinfo&format=json&iiprop=url%7Cdimensions%7Cextmetadata&iiextmetadatafilter=ImageDescription%7CArtist%7CLicense%7CLicenseUrl%7CLicenseShortName&titles=Claude%20Monet&generator=images&gimlimit=50' -o claude_monet_images.json [15:12:12] downloads 38192 bytes [15:12:34] you can even limit the number of responses and use continue to paginate them [15:12:36] * bgerstle tries it out.. [15:13:57] seems to work [15:14:35] bgerstle: sure, feel free to use that in your implementation. We might revisit it on our end. We're not using extmetadatafilter... only because we have a function to show the user all the metadata bits in a popup dialog. [15:14:43] ah ha [15:14:47] then yeah, might get a tad unruly [15:15:05] but, if you guys run into issues w/ latency and multiple round trips, i think this might help [15:15:15] yes indeed [15:15:50] or, we can roll it into our fancy new service which gives us the first N images w/ an optional "continue" URL [15:15:57] * bgerstle elbows bearND ^ [15:26:59] * bearND elbows bgerstle [15:27:11] * bgerstle elbows dbrant [15:27:18] now backsies [15:27:26] s/now/no/ [15:31:03] dbrant: what did you mean with "We're not using extmetadatafilter"? We **are** using it for license data and media information (More info...). [15:31:13] phuedx: my coffee friend, have you ever used an aeropress? [15:31:37] dbrant: oh i get it now. You're talking about a request param [15:32:03] dbrant: confused it with extmetadata [15:32:20] bearND: yep, i was referring to fetching an individual gallery item [15:39:37] bgerstle: hey! [15:39:47] yo! [15:39:59] just saw your message in the log [15:40:06] your team must be walking around w/ a lot of *swagger* after this release [15:40:13] ;-) [15:40:20] np [15:40:23] kristenlans: yes [15:40:31] bgerstle: ;) [15:40:39] bgerstle: you are, in fact, a monster [15:40:47] I actually had to look up the regular meaning of that word fairly recently [15:40:53] haha [15:41:06] gwicke: i was just wondering, why titles instead of pageids? [15:41:06] phuedx did you like it? I'm loving mine. [15:41:13] gwicke, bgerstle: i couldn't find any php server codegen stuff for swagger, which was a little disappointing [15:41:18] /server/ [15:41:20] not client [15:41:32] kristenlans: yes, emphatically yes [15:41:35] phuedx: i guess that would be a bit tough [15:41:40] i travel with my aeropress [15:41:42] you'd have to write adapters for each lib [15:41:47] bgerstle: page ids are problematic as all interaction with the api normally happens via the name [15:41:59] bgerstle: indeed, i assume that's the problem [15:42:24] which means that there are race conditions to consider when you save a change to a page that's also being renamed [15:42:57] in an eventually-consistent storage system it's easier to deal with names that don't change [15:42:58] gwicke: do we have zookeeper or a similar service? [15:43:15] we use cassandra without zookeeper [15:43:30] zookeeper doesn't scale across dcs [15:43:52] it would be okay at the low write volumes we have within a DC though [15:44:03] gwicke: i thought pageids didn't change and titles did? [15:44:15] depends on how you look at it [15:44:24] i create an article, it has a pageid [15:44:27] i change the title [15:44:27] basically all clients know the title, but few know the pageid [15:44:37] kristenlans: i find that the aeropress doesn't bring out the sour/fruit notes like a chemex does [15:44:40] the mapping from name to pageid is updated destructively in mw core [15:44:56] gwicke: but in my above scenario, the pageid stays the same? [15:45:01] for a citation, you normally expect to just be able to use the current url with oldid [15:45:09] but i can't put a chemex in a travel case [15:45:11] ;) [15:45:30] gwicke: i guess the way i would think of it is: titles are just an attribute, the pageid seems like the "unique identifier" [15:45:33] bgerstle: yes, it stays the same [15:45:34] which would never change [15:45:40] is that not the case? [15:45:41] but the old url will no longer find the page [15:45:55] and that other person that edited the page in the meantime might get an error [15:46:07] phuedx yeah I'm plannign on using the aeropress fro travelling...in my caravan [15:46:14] gwicke: sure, but that's because 1) we reload the entire page w/ the same URL/title [15:46:19] and 2) the client isn't using pageids [15:46:33] i guess i'm thinking clients should start using pageids [15:46:38] for some of these reasons [15:46:51] no redirects, no encoding/decoding/canonical representations [15:46:52] the other reason for not using pageids is performance, as we'd have to do another sequential request to resolve a title and timestamp (or oldid) to a pageid [15:47:17] assuming most requests remain title-based as they are now [15:47:24] right [15:47:45] we can still provide the linear history of a page [15:47:53] so it's not really a functional difference [15:47:57] i don't necessarily want the linear history in most cases, though [15:48:12] with linear I mean across renames [15:48:20] i just want $page (title or id).. ideally if modified since $revid [15:48:27] so effectively following the pageid [15:48:37] right [15:49:34] we hope to eventually provide stable citation urls that aren't completely id-based [15:50:14] basically, you should be able to retrieve page 'Main Page' as it looked yesterday at 12am [15:50:37] which is $mainPageID@$revID [15:50:53] or in REST page/[/] [15:50:59] there could be several $mainPageIDs associated with a given title over time [15:51:12] oh well we're talking about a separate feature now [15:51:27] we can provide the lookup by pageid as well [15:51:44] especially for clients where the URL isn't really exposed, it might be nice [15:51:46] but decided to optimize the API for the most common access pattern [15:52:02] sure [15:52:29] i guess i still don't understand why it's the common access pattern, except for the fact that we have a heavily browser-influenced history [15:52:36] where the URL was plainly visible in the address bar [15:52:52] and wiki/Barack_Obama is a lot more human-readable than wiki/01254357230458712 [15:52:54] a name is just more friendly as an identifier [15:53:09] sure, but at what cost? [15:53:24] imho the cost is pretty low [15:53:40] the cost of opaque ids would be higher [15:53:59] i guess we'd have to measure the cost across specific cases [15:54:07] for example, in html we link to page names, not ids [15:54:09] IMO there are cases where at least having a pageID handy would be very useful [15:54:21] gwicke: as a side-effect of markup using titles [15:54:25] right? [15:55:12] anyway, i think we've gotten a bit farther into this than i intended. [15:55:16] yeah, there are certainly use cases where a page id is useful [15:55:23] it's clear to me that there are some historical and technical reasons for using titles that i don't fully grasp yet [15:55:24] or a page name x revision or timestamp [15:56:11] bearND: gwicke have you guys been in touch at all? [15:56:15] if you ever tried to build a wiki using google docs you might appreciate the advantage of human-readable urls more ;) [15:56:18] regarding our "app service experiment" [15:56:41] gwicke: i can appreciate the ease-of-use of linking to inter-wiki articles by name, sure [15:57:10] bgerstle: yup, we have been chatting with bearND quite a bit [15:57:14] awesome [15:57:28] we are excited to help you publish that as an experimental end point asap [15:57:28] so, can haz mobile-app transform w/ aggregated image data plz? [15:57:47] i see, so we *are* doing the experiment as an endpoint in restbase [15:57:58] it's a separate service [15:58:01] but it runs as a separate service? [15:58:04] i see [15:58:23] restbase provides common public api and potentially storage in the future [15:58:58] and a way to pre-generate content right after an edit, so that the views are really fast as nothing remains to be done [15:59:28] got to run, ttyl! [15:59:40] k, later! [16:01:28] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 2 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1109694 (10dr0ptp4kt) [16:02:49] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - Android: [Spike 1 hr] Investigate building a Node.js service for mobile apps content - https://phabricator.wikimedia.org/T90228#1109698 (10dr0ptp4kt) [16:05:42] bgerstle: coreyfloyd you guys getting any errors when connecting to https://itunesconnect.apple.com/ ? i also noted this morning on my iphone that the Get button in the App Store app finishes pretty automatically, then Install finishes almost immediately, but nothing happens....whereas with the TestFlight app, a dialog is thrown that stuff can't be downloaded right now [16:06:02] dr0ptp4kt: haven't tried [16:07:09] just downloaded from TF w/o any issues [16:07:30] oh, apparently iTC Is down [16:07:37] "Http/1.1 Service Unavailable" [16:07:41] womp womp [16:09:48] use of the tf app to download is telling me: 'unable to download app' - "wikipedia beta" could not be downloaded at this time. - Done - Retry...womp womp [16:09:53] bgerstle: ^ [16:10:25] dr0ptp4kt: TF worked for me, but can't connect to iTC via chrome [16:11:38] bgerstle me iTC service unavailable via safari. i'm wondering if servers are under load for certain dns load-balanced locations. are you able to download apps with the app store app? [16:11:51] bgerstle: not just download, but also instlal [16:13:33] dr0ptp4kt: yeah. though when i tried to update one app it started/cancelled immediately [16:13:35] which is weird [16:13:41] but i downloaded a previous purchase just fine [16:15:31] bgerstle: yeah, i had a case of it apparently _actually_ *updating* an app, but then not removing the numerical indicator from the app store app's icon. in one case an existing app had the dot next to it indicatnig it was new, and in another, the dot flickered next to it until i tapped it. [16:15:43] * bgerstle shrugs [16:18:34] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: UI locks while typing a search Term - https://phabricator.wikimedia.org/T91775#1109736 (10dr0ptp4kt) Let's avoid truncation if we can. Let's prioritize this at the sprint 53 estimation meeting, unless we're done with everything in Sprint 52 alr... [16:20:28] brion sorry to keep bugging you about MW API stuff, feel free to redirect, but i'm seeing some weird behavior w/ an images request [16:20:32] have a second? [16:20:49] sure what’s up [16:21:04] so, this query: https://en.wikipedia.org/wiki/Special:ApiSandbox#action=query&prop=imageinfo&format=json&iiprop=url%7Cdimensions%7Cextmetadata&iiextmetadatafilter=ImageDescription%7CArtist%7CLicense%7CLicenseUrl%7CLicenseShortName&titles=Claude%20Monet&generator=images&gimlimit=100 [16:21:07] works as i would expect [16:21:26] actually, let me try plugging the app URL into the API sandbox... [16:22:33] ok, well i can't quite do that [16:22:43] but here's the query i'm running in the app: https://en.wikipedia.org/w/api.php?action=query&continue=&format=json&generator=images&gimlimit=100&iiextmetadatafilter=License%7CLicenseUrl%7CLicenseShortName%7CImageDescription%7CArtist&iiprop=url%7Cextmetadata%7Cdimensions&iiurlwidth=1280&prop=imageinfo&titles=Claude%20Monet [16:23:07] for some reason, "title": "File:Monet - Garten in Giverny.jpg" [16:23:24] is fine in the first query, but is essentially empty in the second [16:23:27] even has a "missing" field [16:23:42] hmmmmmm interesting [16:23:52] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 2 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1109760 (10dr0ptp4kt) There's an update. See https://lists.wikimedia.org/pipermail/analytics/2015-March/003583.h... [16:24:51] bgerstle: i’m suspicious that there might be some weird generator limit going on [16:24:53] lemme check the source [16:26:17] bgerstle: ok imageinfo has an internal limit of processing 50 images at a time, it seems [16:26:43] and it looks like that doesn’t interact as expected with the ‘continue’ parameter on the generator, as the generator doesn’t know that imageinfo hit *its* limit :P [16:26:48] this is what we call “fun" [16:27:02] is it? [16:27:04] you need to get out more :-P [16:27:06] haha [16:27:25] bgerstle: try setting a limit on the generator of like 40 or something, see if that gets things working [16:27:43] iiuc that should avoid hitting the imageinfo internal limit, and you can just follow the continue params for the generator [16:29:51] (03CR) 10Krinkle: Register hogen.js via module name 'mediawiki.template.hogen' (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [16:31:38] brion: but unless i'm crazy [16:31:51] the sandbox is behaving different than whatever the app is hitting w/ what *seem* to be the same URL [16:32:30] whafu :D [16:33:10] AH HA [16:33:11] aaaaaaaaaahhhhhh [16:33:13] thumbnail [16:33:16] yes [16:33:18] :D [16:33:19] the iiurlwidth [16:33:31] the limit is on transforms, which is the thumbnailing operation [16:33:34] ╯‵Д′)╯彡┻━┻ [16:33:37] :D [16:34:37] ok [16:36:42] alright [16:36:56] * brion assumes bgerstle has been cursing for 5 minutes straight [16:37:03] dr0ptp4kt: if it makes you feel better I can't even download an app from the mac app store right now [16:37:03] the only problem with this [16:37:06] i *think* [16:37:23] is that i'm not 100% sure the order in which i need the images will match up w/ the order in which they're returned [16:37:30] by prop=imageinfo&generator=images [16:37:42] i’m fairly certain they won’t be in a useful order :) :( [16:37:52] probably something helpful like alphabetical [16:37:54] there is an "order" parameter on images [16:37:55] “thanks, database" [16:37:59] ascending/descending [16:38:06] brion: bgerstle they'll be eventually consistent, for arbitrary definitions of eventually consistent [16:38:12] hehe [16:38:18] brion: It's intended functionality for the generators to return things out of order, apparently. [16:38:23] "even a broken clock is right twice a day" [16:38:25] *ohgod* [16:38:32] * brion moves up “redo the whole damn api” on his todo list [16:38:32] brion: But at least there's an index in there now. That wasn't true six months ago... [16:40:21] yeah i don't even know what "ascending/descending" corresponds to [16:40:38] what i do know, is it's NOT the order in which images appear in the article [16:40:50] coreyfloyd: updated rights. Deskana bgerstle coreyfloyd i'm going to wait an hour or something to ensure that i myself can download the app via testflight. no need to add more pain for the external testers [16:41:01] dr0ptp4kt: k [16:41:02] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Mobile apps should use "download" rather than "heart" icon for offline bookmarking - https://phabricator.wikimedia.org/T91834#1109803 (10Fjalapeno) A heart is less boring for sure, but I do think that it doesn't clearly convey that its purpose is "save for... [16:41:36] dr0ptp4kt: thanks [16:41:39] brion: FWIW i bet the "transform" limit has something to do w/ the fact that you can only request 50 titles at a time [16:41:42] coincidence? i think not [16:41:54] suspicious [16:41:57] which is what led me to this place to begin with [16:42:01] heh [16:42:20] so i'm left w/ two options [16:42:49] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Mobile apps should use "download" rather than "heart" icon for offline bookmarking - https://phabricator.wikimedia.org/T91834#1109814 (10dr0ptp4kt) I'm indifferent, but if we were to explore this further, I wonder if a more conventional save floppy would ma... [16:42:50] 1) use my old approach of doing imageinfo requests for the specific images i need [16:42:56] and paginate them manually on the client [16:43:16] 2) batch request all the images at once by sending multiple 50-image requests at once and aggregate them all together [16:43:19] i vote for #1 [16:43:20] ay ay [16:43:32] the advantage of 1) is you can do a quick fetch of jsut what you need to start [16:43:36] yep [16:43:39] and then continue on in the background to get the rest [16:43:41] and lazily fetch the second batch [16:43:48] wherewas with 2) you have to wait in case the first image is last [16:43:55] yeah [16:44:21] if we had a service which gave us all of the data we needed as part of getting the article... [16:44:26] that'd be greeeeaaaaaat [16:44:27] :D [16:44:51] until then, we'll just implement it in ObjC and Android [16:44:53] in parallel [16:45:03] fun times :( [16:45:17] maybe i should just write it in C++ and we can write a bridge for both platforms ;-) [16:45:24] hehehe [16:45:29] have fun with android NDK :) [16:45:30] BARE METAL PROGRAMMING \m/ [16:45:37] hehe [16:46:08] brion: wouldn't necessarily need to. we can expose it as a RESTful API that the android/ObjC clients send "requests" to [16:46:25] interestingly, spotify's doing something like that to avoid NDK/ObjC++ nastiness [16:46:33] nice [16:46:37] JonKatz: standup? [16:46:39] whether it's sane... i can't really say [16:46:58] joakino: He's in this Q4 priorities meeting. [16:47:08] haven't worked enough w/ ObjC++ or NDK recently enough [16:47:36] brion: if it weren't for the iiurlwidth parameter, it would "just work" [16:47:42] is there any chance we could fix that? [16:48:03] well, i guess it's not worth it [16:48:06] bgerstle: possibly we can remove the limit in the case where we’re using a 404 thumbnail handler [16:48:09] 10Wikipedia-App-Android-App: Make it easier to access talk pages - https://phabricator.wikimedia.org/T89606#1109829 (10YMS) In conjunction with merging T92285 into this case: Please note that the problem does not only affect article talk pages, as this case's description suggests, but also user talk pages. It /... [16:48:12] but you’d still have to reorder things etc [16:48:40] because i would still be in the situation of having to fetch all the images to ensure that i get the one being displayed in the gallery [16:48:41] right [16:48:46] hrmph [16:49:03] so i'm gonna go for a walk and think about it. be back in time for standup [16:49:14] dr0ptp4kt: FYI i +1'd Saltymule's patch [16:49:18] should be OK to merge [16:49:33] there was some stuff going on w/ not being on top of latest master w/ the jshintrc changes [16:49:52] walk time, bbl [16:51:59] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 2 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1109863 (10DarTar) @dr0ptp4kt, awesome, can you document this parameter scheme somewhere on mediawiki.org or wik... [16:58:59] 6Mobile-Web, 5Patch-For-Review: Update Schema:MobileWebWikiGrokError now that WikiGrok has changed - https://phabricator.wikimedia.org/T86855#1109878 (10bmansurov) 5Open>3Resolved a:3bmansurov [17:04:45] 10Wikipedia-App-Android-App: App does not catch edit conflicts, just overwrites - https://phabricator.wikimedia.org/T92373#1109904 (10Deskana) [17:04:46] 10Wikipedia-App-Android-App, 10Wikipedia-App-General-or-Unknown, 10Wikipedia-App-Generic: Handle edit conflicts on the mobile app in some way - https://phabricator.wikimedia.org/T66281#1109905 (10Deskana) [17:04:56] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Handle edit conflicts on the mobile app in some way - https://phabricator.wikimedia.org/T66281#686962 (10Deskana) [17:07:40] yo yo yo [17:07:51] * jdlrobson looks at yuri's patch [17:08:06] \o/ [17:08:08] thanks Deskana about JonKatz before, hadn't read the email [17:08:10] which ) [17:08:25] yurik: the one i -1ed - so what do i need to prefix with? [17:08:33] see comment [17:08:38] api magic always confuses the hell out of me (yay for restbase etc ;-)) [17:08:54] hehe )) [17:08:54] joakino: Sure. :-) [17:09:10] i'm happy about restbase too - although it only took 10 years to write ;) [17:09:30] lol [17:10:20] 6Mobile-Web, 5Patch-For-Review: Display coordinates in mobile version - https://phabricator.wikimedia.org/T91481#1109943 (10Jdlrobson) These are currently hidden pending design input. They are too prominent in the display and to a lot of people geocoordinates are meaningless (not to mention that the geohack se... [17:10:24] jdlrobson, try this: http://localhost:8080/w/api.php?action=help&modules=editlist|query+lists [17:10:52] (03CR) 10Jdlrobson: [C: 04-1] "What Max said. As future guidance if something is in hacks.less it's there for a reason and it's worth exploring why." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195495 (https://phabricator.wikimedia.org/T91481) (owner: 10Bmansurov) [17:10:57] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android, 5Patch-For-Review: ArrayIndexOutOfBoundsException crashes from android.view.MotionEvent.getX/android.view.MotionEvent.getY - https://phabricator.wikimedia.org/T88904#1109945 (10Dbrant) [17:11:03] (03PS13) 10Phuedx: New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 [17:15:06] (03CR) 10Jdlrobson: [C: 031] "I dislike doing browser specific hacks as they end up being more trouble maintaining then they are worth (see ios keyboard hacks for examp" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194968 (https://phabricator.wikimedia.org/T91421) (owner: 10Bmansurov) [17:16:12] (03CR) 10Jdlrobson: [C: 032] Implemented action=query & list=listpages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194964 (owner: 10Yurik) [17:16:47] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Mobile apps should use "download" rather than "heart" icon for offline bookmarking - https://phabricator.wikimedia.org/T91834#1109982 (10MSyed) A "heart" icon lends itself better to a future collections feature on apps than a "download" or "bookmark" icon,... [17:17:37] (03Merged) 10jenkins-bot: Implemented action=query & list=listpages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194964 (owner: 10Yurik) [17:20:10] jdlrobson, try 195192 + 195839 [17:20:18] make sure to run update.php [17:21:29] jdlrobson, doing git review -d 195839 will get both of them [17:23:40] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: UI locks while typing a search Term - https://phabricator.wikimedia.org/T91775#1110039 (10Fjalapeno) @mhurd searched for "list of casualties" and I am still not seeing any variance in the cell size: {F82361} Do you see something different? [17:24:33] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Mobile apps should use "download" rather than "heart" icon for offline bookmarking - https://phabricator.wikimedia.org/T91834#1110046 (10Jaredzimmerman-WMF) @MSyed problem with that is that this access point currently has nothing to do with watchlist. [17:26:27] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Mobile apps should use "download" rather than "heart" icon for offline bookmarking - https://phabricator.wikimedia.org/T91834#1110070 (10MSyed) But that can change in the future. [17:28:02] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [PRODUCTION RELEASE BLOCKER] Verify data migrations work from old store release - https://phabricator.wikimedia.org/T91713#1110085 (10dr0ptp4kt) [17:28:34] yurik: 1s taking a look at joaquin's patch [17:28:56] mhurd: I just tried the search you recommended… can you check out my screenshot in the ticket? [17:29:04] (03PS2) 10Jdlrobson: Fix visual feedback for creating a new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195625 (https://phabricator.wikimedia.org/T92034) [17:29:12] (03CR) 10Jdlrobson: [C: 032] Fix visual feedback for creating a new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195625 (https://phabricator.wikimedia.org/T92034) (owner: 10Jdlrobson) [17:29:18] (03PS3) 10Jdlrobson: Fix visual feedback for creating a new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195625 (https://phabricator.wikimedia.org/T92034) [17:29:28] (03CR) 10Jdlrobson: [C: 031] Fix visual feedback for creating a new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195625 (https://phabricator.wikimedia.org/T92034) (owner: 10Jdlrobson) [17:29:33] (03CR) 10Jdlrobson: [C: 032] Fix visual feedback for creating a new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195625 (https://phabricator.wikimedia.org/T92034) (owner: 10Jdlrobson) [17:29:40] (03PS2) 10Jdlrobson: Hygiene: Cleanup unused template parameter [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195626 [17:29:46] (03CR) 10Bmansurov: "@Phuedx, I cannot reproduce this on Chrome Version 41.0.2272.76. Are you able to reproduce the bug only on the version you mentioned?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195596 (https://phabricator.wikimedia.org/T91882) (owner: 10Bmansurov) [17:30:06] (03Abandoned) 10Jdlrobson: Hygiene: Generalise API query in preparation for future work. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194415 (owner: 10Jdlrobson) [17:30:42] coreyfloyd: ya. still on the hangout - quick chat about android candidate i have to interview this afternoon. should be done in 15 min or so. [17:30:49] (03Merged) 10jenkins-bot: Fix visual feedback for creating a new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195625 (https://phabricator.wikimedia.org/T92034) (owner: 10Jdlrobson) [17:31:22] joakino: is there no chance of avoiding the negative margin on https://gerrit.wikimedia.org/r/195884 [17:31:27] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Cut TestFlight release with Crash Reporting to friends & family & WMF & external test team - https://phabricator.wikimedia.org/T91097#1110119 (10dr0ptp4kt) 5Open>3Resolved [17:32:27] jdlrobson: it is complicated, we could remove the padding-bottom of the h1 and add margin-top positive to .content in .collections-list [17:32:45] which element is .collection .content ? [17:32:55] jdlrobson: i liked better having the h1 behave properly [17:33:10] joakino: i can't find it in the DOM [17:33:17] oohh it's & [17:33:35] jdlrobson: so in a collection page .content gets .collection, and in the collections list it gets collections-list [17:33:55] joakino: so you are overriding MobileFrontend defaults? [17:34:15] jdlrobson: they already were, but the selectors were wrong (in specificity) [17:34:21] jdlrobson: but I think so [17:34:31] jdlrobson: there is also FIXME comments somebody placed there [17:34:36] joakino: better to put padding-bottom: 0; on #section_0 [17:35:00] jdlrobson: ok let me change it [17:35:31] phuedx: regarding the BannerImagesService file, should it live in the Includes dir? Or is there a better place for it? [17:35:34] jdlrobson: but then the FIXME doesn't make sense, since having the h1 without padding-bottom shouldn't be fixed on the skin [17:35:38] (03CR) 10Jdlrobson: [C: 04-1] Fix design issues (spacing and icon position) (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195884 (https://phabricator.wikimedia.org/T91634) (owner: 10Jhernandez) [17:35:40] ^ addded note joakino [17:35:59] basically keep it under // FIXME: Bad special page styling defaults. [17:36:06] bmansurov: for now, includes/BannerImage – keep it separate from includes/foo [17:36:19] k thanks [17:38:11] (03CR) 10Kaldari: [C: 04-1] "I'm not seeing anything recorded in wikigrok_aggregation with this latest patch." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [17:38:17] so jdlrobson in the collectionSSS page I add extra top margin to the .content? look at this for reference (wait a couple seconds) https://phab.wmfusercontent.org/file/data/5y2ubz2muojqf47wlbfh/PHID-FILE-zmmzojniylavbndkutks/qvnpdfhukefty4vc/coll-design-css.gif [17:38:56] from now on i'm gonna call them collection page and collectionSSSSS page [17:43:07] (03CR) 10Robmoen: [C: 032] Fix edit/delete of collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195880 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [17:43:29] (03PS2) 10Robmoen: Fix edit/delete of collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195880 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [17:45:33] yay, both my wife and i are able to download things via testflight [17:46:11] (03CR) 10Jdlrobson: [C: 032] Fix edit/delete of collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195880 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [17:47:14] (03Merged) 10jenkins-bot: Fix edit/delete of collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195880 (https://phabricator.wikimedia.org/T90990) (owner: 10Jhernandez) [17:47:25] Deskana|Away: mhurd coreyfloyd bgerstle_afk, about to invite the external testflight users in 3, 2, 1...0, -1, ... [17:47:44] dr0ptp4kt: oh god :) [17:51:40] yurik: http://127.0.0.1:8080/w/api.php?action=query&list=listpages&lspid=0 < is it possible to also get the title/description of the collection in the same response? [17:55:01] brion: i'm thinking we're dangerously close to maxing out the URL & query string too [17:55:10] hoping we don't run into any issues [17:55:33] i guess the absolute safest thing to do is what android is already doing: fetch the info one at a time [17:55:47] bgerstle: if you do a POST and put the query in the body that should help with that, but that might be ickier [17:55:58] brion: then it's not cacheable [17:56:05] ahhh bummer :) [17:56:09] assuming NSURLCache is caching the JSON, which i'm not sure of [17:56:21] (03PS3) 10Jhernandez: Fix design issues (spacing and icon position) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195884 (https://phabricator.wikimedia.org/T91634) [17:56:23] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Mobile apps should use "download" rather than "heart" icon for offline bookmarking - https://phabricator.wikimedia.org/T91834#1110237 (10Jaredzimmerman-WMF) @MSyed, if it means the same things on mobile and desktop, we should use the same icon. We have the... [17:56:23] and if it *is* i don't know how it's determining when to invalidate it [17:56:42] :( [17:57:51] jdlrobson: i've made it without the negative margin, but now re-reading your comment I'm not sure if you were ok with that but adding a FIXME in the negative margin [17:58:38] jdlrobson: have a look when you can https://gerrit.wikimedia.org/r/#/c/195884/2..3/resources/ext.gather.styles/collections.less [17:58:51] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: 4.0.6.3 Image Gallery- switching from a vertical view to horizontal loads a different picture - https://phabricator.wikimedia.org/T91106#1110247 (10Etonkovidova) Re-checked on 4.0.7.4 - all is good. [17:59:33] joakino: will take a look [17:59:33] (03PS2) 10Jdlrobson: WIP: Special:Gather and collections overlay should use API [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195621 [17:59:35] (03PS1) 10Jdlrobson: WIP: Create Special:Gather// via api [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195965 [18:00:10] joakino: looks fine [18:00:20] 👍 [18:03:25] (03PS4) 10Bmansurov: Load banner images on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) [18:04:59] (03CR) 10jenkins-bot: [V: 04-1] Load banner images on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [18:05:44] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 5Patch-For-Review: 4.0.6.3 Image gallery - images(svg) blurred on the black background - https://phabricator.wikimedia.org/T91128#1110282 (10Etonkovidova) Re-checked - 'Two-dimensional space' and 'Cat->Anatomy' on 4.0.7.4 - the images are displayed on a... [18:05:49] jdlrobson: rmoen: regarding https://phabricator.wikimedia.org/T92347 , the report states adding invalid json to GatherCollections.json breaks everything, which it does, should we care about this? we should be on the DB in a week tops [18:06:03] yeh it will cause fatals on beta labs [18:06:05] rmoen left lele [18:06:19] so they will get reported to us. They also suggest bugs in our code [18:06:23] it should know how to deal with bad data [18:06:27] jdlrobson: so do I implement json validations? [18:06:36] just some basic ones [18:06:39] just to throw them away in 3 days [18:06:41] ok [18:06:50] it should die silently [18:06:55] not explode [18:07:27] (plus who knows we may get stuck with user page json for longer than we hope to!) [18:07:28] brion interesting, the request i'm trying has the "Cache-control: private" header set [18:07:39] which is strange.. since there shouldn't be any user-specific data [18:07:51] urghle [18:07:52] it's just the images in an article [18:07:59] (03CR) 10Jdlrobson: [C: 032] Fix design issues (spacing and icon position) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195884 (https://phabricator.wikimedia.org/T91634) (owner: 10Jhernandez) [18:09:36] (03Merged) 10jenkins-bot: Fix design issues (spacing and icon position) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195884 (https://phabricator.wikimedia.org/T91634) (owner: 10Jhernandez) [18:09:57] also, there doesn't appear to be any cache-informing headers, e.g. etag or max-age [18:11:34] is that a varnish or mediawiki thing? [18:11:40] http://hatjitsu.wmflabs.org/41079 [18:17:23] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Cut store release with only the addition of HockeyApp - https://phabricator.wikimedia.org/T91094#1110331 (10dr0ptp4kt) [18:18:36] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Cut store release with only the addition of HockeyApp - https://phabricator.wikimedia.org/T91094#1074184 (10dr0ptp4kt) The beta has HockeyApp crash reporting integrated. The current 4.0.7.4 version verbiage is okay. The 4.0.7.5 version that will go in later... [18:21:48] yurik: ping you there? [18:21:59] what is the prefix is need to use for http://localhost:8080/w/api.php?action=help&modules=editlist [18:22:36] https://gist.github.com/jdlrobson/0fa5d9660906c86c6a78 < yurik not working [18:22:43] jdlrobson, yp [18:22:57] yp? [18:23:06] yes [18:23:15] where in the code do i work this out? [18:23:22] what is not working there? what's the erorr? [18:23:24] been grepping ApiEditList for so long [18:23:31] first, enable debug on your local machine [18:23:38] are you on vagrant? [18:23:40] see comment on the gist for response [18:23:44] invalidparammix [18:24:28] jdlrobson, a bit confused - what is "watch" ? [18:24:33] token [18:24:57] 2nd argument is data i'm sending in post [18:25:16] jdlrobson, do you know the full api request you are making? [18:25:29] any way you can give it to me in the form of api.php?...... [18:25:45] because i feel like there are other args missing in there [18:25:52] brion: j/k i was looking at "curl" response headers before [18:25:57] for the iOS app it's: "Cache-Control" = "private, s-maxage=0, max-age=0, must-revalidate"; [18:26:12] hah [18:26:25] that might be authenticated? do we use the same cookies for all reqs? [18:26:36] jdlrobson, or you can give it to me as a json dict - for all params [18:26:38] so "don't share it, and don't cache it for longer than 0 seconds. oh and be sure to check back w/ me before you return this as a cached response" [18:26:42] yurik: doing that now [18:26:42] 1s [18:26:46] thx [18:27:01] brion i'm not logged in.. [18:27:11] bgerstle: i think that’s our default for pages, it must be getting applied to api too [18:27:17] https://gist.github.com/jdlrobson/0fa5d9660906c86c6a78 < yurik check latest comments [18:27:19] (03PS11) 10Yurik: Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) [18:27:21] * brion adds another note to the ‘redo the whole damn api’ todo :P [18:27:35] haha [18:28:05] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Image map is not displayed correctly in Image Gallery view - https://phabricator.wikimedia.org/T90294#1110358 (10Etonkovidova) [18:28:15] brion: https://www.youtube.com/watch?v=fjsSr3z5nVk [18:28:34] :D [18:29:25] jdlrobson, right, so you are doing this: action=editlist & titles=Headings -- but you haven't given an ID, nor have you given it a label for the new list [18:29:44] if you give it a label but no id, it will create a new list [18:29:50] (03PS1) 10Jhernandez: Make JSON importing more robust to avoid runtime errors [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195970 (https://phabricator.wikimedia.org/T92347) [18:29:51] if you give it an id, it will find the existing one [18:30:13] yurik: mm wtf let me check what's going on there. I'm passing it in code [18:30:20] the parameter is id right? [18:30:39] yep [18:30:57] 10Wikipedia-App-iOS-App: Image map: better handling of image info? - https://phabricator.wikimedia.org/T92423#1110374 (10Etonkovidova) 3NEW [18:31:13] yurik: looking again [18:31:57] yurik don't freak out i've touched the json stuff but to make it not break the site for a user (there is users in beta labs already messing with the files and reporting bugs0 [18:32:02] yurik: it's magically working now - i think there must be an issue in the client side code :) [18:32:24] 10Wikipedia-App-iOS-App: Image map: better handling of image info? - https://phabricator.wikimedia.org/T92423#1110384 (10BGerstle-WMF) @VibhaBamba what should we do in this situation? Same as Android? [18:33:04] jdlrobson, are you playing with the db patch? [18:33:30] yurik: not yet i'm just switching over to the api [18:33:35] and raising bugs with the interface before we do that [18:33:38] in case any changes are needed [18:33:40] https://phabricator.wikimedia.org/T92424 < yurik [18:33:56] jdlrobson, its done in the db [18:34:00] not in the old one [18:34:02] maryana did you have to run to another meeting? [18:34:10] lets just switch to db )) [18:34:40] yurik: i want to prove the api works first [18:34:55] and so far there are limitations which should not be impacted by storage mechanism [18:35:19] but don't worry i will look at database changes before end of today [18:35:31] ok [18:35:57] (03CR) 10Dr0ptp4kt: [C: 032] Don't invoke native bridge if there is selected text [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195060 (https://phabricator.wikimedia.org/T91605) (owner: 10Saltymule) [18:38:01] (03PS4) 10Yurik: Store API data in database [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195839 [18:38:04] yurik: on basis there's no point to switching over to database until we can use it :) [18:38:40] jdlrobson, not sure i understood the last thing [18:38:58] basically https://phabricator.wikimedia.org/T92418 must be resolved before moving to database [18:39:04] check blocking bugs [18:39:13] http://hatjitsu.wmflabs.org/41079 [18:39:42] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Image map: set a slight delay and outline the area before redirecting - https://phabricator.wikimedia.org/T92426#1110432 (10Etonkovidova) 3NEW [18:40:59] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: UI locks while typing a search Term - https://phabricator.wikimedia.org/T91775#1110443 (10Fjalapeno) Attaching before and after photos of the instruments run. Reduced the time spent by the cpu calculating the height of search cells from 43.5% t... [18:41:25] (03PS1) 10Jhernandez: Do not open the editing overlay if the collection is a watchlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195975 (https://phabricator.wikimedia.org/T92414) [18:42:41] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Performance: UI locks while typing a search Term - https://phabricator.wikimedia.org/T91775#1110451 (10BGerstle-WMF) Wow, great work @Fjalapeno! Glad to see data on this as well. [18:42:45] (03PS3) 10Jdlrobson: WIP: Special:Gather and collections overlay should use API [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195621 [18:42:47] (03PS2) 10Jdlrobson: WIP: Create Special:Gather// via api [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195965 [18:42:49] (03PS1) 10Jdlrobson: Switch to API for adding/removing pages from collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195976 [18:42:51] (03PS1) 10Jdlrobson: Switch to API for editing a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195977 [18:42:53] (03PS1) 10Jdlrobson: WIP: Switch to API for creating collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195978 [18:44:25] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Image map is not displayed correctly in Image Gallery view - https://phabricator.wikimedia.org/T90294#1110465 (10Etonkovidova) Re-checked on 4.0.7.4 - the info for image map images is displayed. Still, Android provides more complete info, specifically, for... [18:47:40] (03CR) 10Jdlrobson: [C: 04-1] "Doesn't seem to be working..." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195976 (owner: 10Jdlrobson) [18:47:50] (03PS2) 10Jdlrobson: Switch to API for editing a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195977 [18:48:01] wheres rob? [18:48:06] joakino: that patch should be ready to go though [18:51:28] jdlrobson: i don't know, he disappeared [18:51:32] jdlrobson: which patch? [18:51:44] switch to api for editing a colleciton [18:53:05] jdlrobson: auto -1ed? [18:53:12] joakino: mmmm never mind then :) [18:53:18] jdlrobson: hahaha [18:53:20] im just gonna grab lunch and there's this nsa brown bag [18:53:27] so i'll biab [18:53:27] jdlrobson: i'm gonna be heading out for today [18:53:35] jdlrobson: will have a look tomorrow if it's ready [18:53:36] okay cool thanks for all your efforts today! :D [18:53:43] have a nice day! [19:01:12] (03PS1) 10Fjalapeno: Only calculate cell height if the length of the text will be "too long" to fit in a normal size cell. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195982 [19:04:52] (03CR) 10Fjalapeno: "Also mhurd - I know you have put a lot of work in there, but these are a couple drop in solutions developed by the community that already " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [19:05:30] (03CR) 10Jdlrobson: [C: 032] Make JSON importing more robust to avoid runtime errors [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195970 (https://phabricator.wikimedia.org/T92347) (owner: 10Jhernandez) [19:05:53] 10MobileFrontend-Feature-requests, 10UI-Standardization, 7Accessibility, 7Design: Identify the best diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1110563 (10Jaredzimmerman-WMF) The most common type of color vision limitation Protanopia (red-green color blindness) is no longer... [19:06:40] (03Merged) 10jenkins-bot: Make JSON importing more robust to avoid runtime errors [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195970 (https://phabricator.wikimedia.org/T92347) (owner: 10Jhernandez) [19:09:07] coreyfloyd: http://mortoray.com/2015/02/25/invented-here-syndrome/ ;) [19:09:11] brb [19:14:47] (03PS1) 10Yurik: Return status & ID on action=editlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195988 [19:14:50] jdlrobson, ^ [19:17:28] mhurd bgerstle dr0ptp4kt yeah we should definitely be looking to give back to the community not only by open sourcing our work, but by being users AND contributors to existing projects. Its the "other side" of open source. If everyone just open sourced there own components and never used anybody else's, we wouldn't really be sharing code in a meaningful way. [19:17:49] coreyfloyd: what's this in reference to? [19:18:00] your patch? [19:18:10] bgerstle: https://gerrit.wikimedia.org/r/193323 [19:18:14] my comment [19:19:09] bgerstle: mhurd dr0ptp4kt Actually the guys at Artsy wrote a good piece on this the other day. http://www.objc.io/issue-22/artsy.html [19:19:40] coreyfloyd: i saw artsy open sourced their app [19:19:43] pretty awesome [19:19:53] and eidolon is (IIRC) all FRP! [19:20:08] yeah - that seems pretty cool [19:20:13] they're doing some clever stuff w/ cocoapod-keys as well, which we might want if/when we use API keys for RESTbase [19:20:29] bgerstle: yeah I bookmarked the same stuff - lol [19:20:56] they're also doing a LOT of snapshot testing [19:21:03] * bgerstle cough cough we should too cough cough [19:21:46] oh and the use travis [19:22:22] also, these guys... [19:22:24] "During a weekend hike in Vienna..." [19:22:33] ya, rub it in our faces whydontchya [19:29:00] (03PS12) 10Yurik: Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) [19:29:29] (03CR) 10jenkins-bot: [V: 04-1] Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [19:31:22] (03PS13) 10Yurik: Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) [19:32:26] (03PS2) 10Dr0ptp4kt: Truncate logged share text at 99 characters [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195777 [19:32:48] (03PS5) 10Yurik: Store API data in database [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195839 [19:35:12] phuedx: Do you want update the commit message? https://gerrit.wikimedia.org/r/#/c/193373/ [19:35:27] (03PS14) 10Yurik: Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) [19:36:31] yurik: can you add bug number to https://gerrit.wikimedia.org/r/#/c/195988/1 ? [19:36:38] im having trouble following all the stuff you're doing :) [19:38:15] (03PS2) 10Yurik: Return status & ID on action=editlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195988 [19:38:16] jdlrobson, ^ [19:38:30] thanks yurik :D [19:38:43] (03PS14) 10Bmansurov: New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [19:41:01] (03CR) 10Jdlrobson: [C: 032] Do not open the editing overlay if the collection is a watchlist (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195975 (https://phabricator.wikimedia.org/T92414) (owner: 10Jhernandez) [19:42:07] (03Merged) 10jenkins-bot: Do not open the editing overlay if the collection is a watchlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195975 (https://phabricator.wikimedia.org/T92414) (owner: 10Jhernandez) [19:43:40] (03PS2) 10Jdlrobson: Switch to API for adding/removing pages from collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195976 [19:43:49] https://phabricator.wikimedia.org/T92433 < yurik in case you haven't seen [19:46:19] (03CR) 10Bmansurov: [C: 04-1] "This is what I see (even after clearing the cache): https://imgur.com/O73zqLf" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [19:49:56] jdlrobson, i don't see it [19:50:00] bleh [19:51:01] (03PS2) 10Jdlrobson: Switch to API for creating collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195978 [19:51:06] jdlrobson, still there? [19:51:15] i don't see the bug [19:51:19] it works for me [19:51:37] bgerstle: lol - yeah love that vienna line - but yeah also bookmarked that screen shot test lib [19:51:55] jdlrobson, i just did http://localhost:8080/w/api.php?action=editlist&id=1&token=b0b8d34948b6cce21f7e31dbe92c954f55009a40%2B\&titles=bbb - and it added "Bbb" to the user page [19:51:56] (03PS3) 10Jdlrobson: Switch to API for creating collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195978 [19:52:12] mmm what's going on then :-/ [19:52:19] i'm seeing no changes on my recent changes feed [19:52:31] (03CR) 10Jdlrobson: [C: 032] Return status & ID on action=editlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195988 (owner: 10Yurik) [19:52:32] yurik: on current master? [19:52:37] yep [19:52:51] and on the patch that i submitted a few min ago as well (the one that returns ids) [19:53:02] (03CR) 10jenkins-bot: [V: 04-1] Switch to API for creating collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195978 (owner: 10Jdlrobson) [19:53:29] (03Merged) 10jenkins-bot: Return status & ID on action=editlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195988 (owner: 10Yurik) [19:53:32] jdlrobson, i say we should switch to DB because we will have to debug just once than :D [19:53:48] no pressure though )) [19:53:56] besides, the last module is not ready yt [19:53:58] yet [19:54:00] (03PS4) 10Jdlrobson: Switch to API for creating collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195978 [19:54:06] (03PS1) 10Florianschmidtwelzow: Add CodeMirror for alpha users to better understand wikitext [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195995 (https://phabricator.wikimedia.org/T91796) [19:54:11] jdlrobson: ^ :D [19:54:48] (03PS15) 10Yurik: Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) [19:55:13] FlorianSW: \o/ can't wait to try it out :D [19:55:14] (03CR) 10jenkins-bot: [V: 04-1] Add CodeMirror for alpha users to better understand wikitext [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195995 (https://phabricator.wikimedia.org/T91796) (owner: 10Florianschmidtwelzow) [19:55:16] got ourselves a new pet, DJ Roomba! https://s-media-cache-ak0.pinimg.com/originals/35/be/a9/35bea9b548cb651ac67ebcb282ff42a4.jpg [19:55:37] FlorianSW: did you get my mail? [19:56:00] awjr_away: we such for not releasing our meeting room [19:56:06] jdlrobson: yeah, i'm happy to read your comments (jenkins already complaints :P) [19:56:09] what e-mail? :O [19:56:23] * FlorianSW is looking through his inbox [19:56:24] i sent to your t-online.de email [19:56:27] kristenlans: sorry for the major technology derp [19:56:41] in the office now & will sync up with kaldari + max when they're back from lunch [19:57:03] Maryana no problems. Just sent you an email update, seems liek we're in pretty good shape. [19:57:10] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Some map images cause the entire webview to be scrollable left to right - https://phabricator.wikimedia.org/T91702#1110786 (10Fjalapeno) @Klans_WMF no this was not fixed, just discovered. I put it in the backlog to be scheduled whenever. It is not a blocke... [19:58:23] yurik: not working for me.. same request [19:58:25] jdlrobson: got it, reading now :) [19:58:35] which page is it storing to yurik? [19:58:44] http://localhost:8080/wiki/User:Admin/GatherCollections.json [19:58:49] jdlrobson, ^ [19:59:41] yurik: items is null for me [20:00:02] jdlrobson, just in case, maybe it got messed up with all the updates - delete that page [20:00:25] yurik: i'd rather not if i've found an edge case - i'll try a new user [20:00:52] jdlrobson, sure, but we are maintainin two versions now, the logic is different with db [20:01:02] different bugs ) [20:01:30] but blocking us moving to db :-) [20:01:57] (03PS3) 10Robmoen: WIP: A user can delete their own collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195459 (https://phabricator.wikimedia.org/T91776) [20:02:06] (03CR) 10jenkins-bot: [V: 04-1] WIP: A user can delete their own collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195459 (https://phabricator.wikimedia.org/T91776) (owner: 10Robmoen) [20:02:51] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Some map images cause the entire webview to be scrollable left to right - https://phabricator.wikimedia.org/T91702#1110804 (10Fjalapeno) [20:03:30] kristenlans: updated this ticket to answer your question - also rewrote the description to conform to our new handy dandy bug requirements: https://phabricator.wikimedia.org/T91702 [20:04:46] Awesome, thanks coreyfloyd [20:05:16] jdlrobson, so is it working? [20:05:30] i think "null" for items prevents addining of the items [20:05:45] try setting items to [] [20:11:19] (03CR) 10Fjalapeno: "additional comments" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [20:12:14] coreyfloyd: ah thanks! i’ll be amending soon - had lunch [20:17:29] 6Mobile-Web, 7Design: Styling regression in new editor tutorial - https://phabricator.wikimedia.org/T91141#1110844 (10MSyed) Will work with @kaityhammerstein and attach a new mock here soon. [20:18:34] bmansurov: !!!!!!! ^ [20:18:52] cool [20:19:03] It's a miracle. [20:19:10] ;) [20:19:27] coreyfloyd: quick hangout? i have a category question... [20:19:34] Oh hey moushira! [20:19:52] mhurd: sure [20:25:50] yurik - it might be null issue sorry talking to jonkatz [20:26:46] jdlrobson, np. Let me know - its a oneliner to fix it, but might not be worth it [20:29:04] https://github.com/mysterioustrousers/MTGeometry [20:30:36] (03CR) 10BearND: [C: 04-1] "Would you mind adding the original 512x512 images to the repo somewhere (outside the app area, similar to icon. I would prefer to not lose" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195811 (owner: 10Dbrant) [20:35:13] hey millimetric! Do I recall that you were using some kind of virtual whiteboarding tool with analytics eng team? [20:35:28] millimetric ^ [20:36:00] milimetric: ah one 'l' :-) ^ [20:36:12] (03CR) 10BearND: [C: 04-1] Patch support-v4 crash in SwipeRefreshLayout. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195832 (https://phabricator.wikimedia.org/T88904) (owner: 10Dbrant) [20:38:08] hi kristenlans [20:38:41] yeah! http://whiteboardfox.com/ [20:38:59] (btw tab should auto-complete names in your IRC client) [20:39:35] milimetric: that is very cool, I didn't know such a thing existed [20:40:10] (03CR) 10BearND: [C: 04-1] "There's a bit too much white space (or in this case I'm tempted to say "blackspace", lol) for my taste above and below the wordmark." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194334 (owner: 10Dbrant) [20:41:02] @kaity you there? [20:41:37] @moiz? [20:41:57] milimetric: cool, thanks. I'm gonna check it out. Sometimes tab doesn't work for me ;-( [20:42:34] (03CR) 10BearND: [C: 032] Remove focus line from search views. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195814 (owner: 10Dbrant) [20:45:39] (03Merged) 10jenkins-bot: Remove focus line from search views. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195814 (owner: 10Dbrant) [20:46:18] kaldari: i can't trigger wikigrok with the query string, logged in or out, in stable or beta [20:46:32] on en.wiki? [20:46:34] on enwiki [20:46:50] did we turn it off intentionally? [20:47:31] no [20:47:51] :( [20:48:15] bgerstle: would you please re-review https://gerrit.wikimedia.org/r/#/c/195777/ ? [20:49:01] Maryana: what's the url you're trying? [20:49:10] bgerstle: i started on unit tests, but i'm getting various errors (simple one: comment out existing broken test class) and i don't want to divert resources to dealing with those errors that go back mainly to a new version of the ide and os [20:49:23] 10Wikipedia-App-iOS-App: 'Save pictures to device' on iOS from Image Gallery - https://phabricator.wikimedia.org/T92443#1110956 (10Etonkovidova) 3NEW [20:50:00] (03PS2) 10Dbrant: Update launcher icon. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195811 [20:50:10] bgerstle: that is, the process of actually running the unit tests is broken, in addition to one of the old unit test classes having fully broken tests [20:51:11] kaldari: i have no way to test this, then: https://trello.com/c/xGwY2peL/10-3-new-wikigrok-campaign-if-country-of-origin-is-uk-or-us-suggest-english-as-language-of-work [20:51:24] Maryana: sorry, meeting with Max [20:52:03] (03CR) 10Bgerstle: "just a minor comment on the API that might help w/ verbosity & reusability. add some simple unit tests for the category and I'll +1" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195777 (owner: 10Dr0ptp4kt) [20:52:13] dr0ptp4kt: oh shite [20:52:23] bgerstle: lol [20:52:33] hrmm [20:52:48] dr0ptp4kt: i was actually about to write some. let me take a look at your patch [20:53:20] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Image Gallery: indicate the first and the last image - https://phabricator.wikimedia.org/T92445#1110991 (10Etonkovidova) 3NEW [20:54:37] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Image map is not displayed correctly in Image Gallery view - https://phabricator.wikimedia.org/T90294#1111003 (10Etonkovidova) 5Open>3Resolved [20:56:04] dr0ptp4kt: just about fixed it [20:56:07] bgerstle: ha, yeah, i was going to create an auxiliary private method to handle the general case, but then was thinking, this is two methods and i'm adding more lines of code [20:56:15] bmansurov: moiz is on it [20:56:20] bgerstle: thx, i'm in meetings the next two hours [20:56:26] mhurd: dr0ptp4kt coreyfloyd: this was a semi recent change but as a reminder, you don't need to add *appilcation code* to the testing target anymore [20:56:30] bgerstle: you able to resubmit and then get mhurd to merge? [20:56:37] bgerstle: thx [20:56:38] dr0ptp4kt: prolly [20:56:45] just got testing target to compile [20:56:45] kaity: I have a question about https://trello.com/c/o0l0dKAd/23-3-stalled-alpha-beta-make-reference-dialog-scrollable What should the max height be? [20:56:45] bmansurov: actually i'll do it [20:56:48] dr0ptp4kt: do you mind if i make the changes? [20:56:50] if you're in meetings [20:56:52] i can add a couple tests too [20:56:58] should take but a minute [20:57:12] kaity: can you also give me the close button svg? thanks [20:57:14] bgerstle: don't feel compelled to fix the compilation and target mess if it's more than a 10 minute task. that can wait until we get through the to-do column for this sprint, imo [20:57:20] dr0ptp4kt: already done [20:57:31] bgerstle: great! gotta run [20:57:39] ok [20:57:54] 10Wikipedia-App-iOS-App: App MediaViewer jarringly loads cropped low quality image and then higher quality full size image - https://phabricator.wikimedia.org/T92446#1111014 (10Tfinc) 3NEW [20:58:42] (03PS4) 10Dbrant: Patch support-v4 crash in SwipeRefreshLayout. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195832 (https://phabricator.wikimedia.org/T88904) [20:58:48] bgerstle: quick hangout? [20:58:56] mhurd yeah sure [21:00:30] (03PS4) 10Robmoen: A user can delete their own collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195459 (https://phabricator.wikimedia.org/T91776) [21:00:34] (03CR) 10jenkins-bot: [V: 04-1] A user can delete their own collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195459 (https://phabricator.wikimedia.org/T91776) (owner: 10Robmoen) [21:01:21] (03PS5) 10Robmoen: WIP: A user can delete their own collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195459 (https://phabricator.wikimedia.org/T91776) [21:01:32] bmanurov: i tried it on bratt pit (en.m.wikipedia/org/wiki/Brad_Pitt?wikigrokversion=b [21:02:13] bmansurov: sure 1 minute [21:02:37] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: The side of the "Quick facts" box are cut off - https://phabricator.wikimedia.org/T91907#1111050 (10Etonkovidova) Verified on iPad mini with 4.0.7.4. [21:02:45] 10Wikipedia-App-Generic: [iOS] There is no section 1 in rXXXXXX - https://phabricator.wikimedia.org/T62935#1111051 (10Tfinc) 5Open>3Resolved a:3Tfinc This was resolved a while ago [21:02:47] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: The side of the "Quick facts" box are cut off - https://phabricator.wikimedia.org/T91907#1111054 (10Etonkovidova) 5Open>3Resolved [21:04:29] bgerstle: hangout froze :) [21:04:38] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Some articles about cities are broken in iOS app beta 4.0.6.3 - https://phabricator.wikimedia.org/T90032#1111071 (10Etonkovidova) Verified the fix on iPad mini with 4.0.7.4 [21:04:49] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Some articles about cities are broken in iOS app beta 4.0.6.3 - https://phabricator.wikimedia.org/T90032#1111072 (10Etonkovidova) 5Open>3Resolved [21:05:33] err, bmansurov ^ [21:05:39] Maryana: it's weird, I don't see any console errors [21:06:00] Maryana: I guess kaldari needs to take a look [21:06:19] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Saved pages UI corrupt when displayed during refresh. - https://phabricator.wikimedia.org/T90746#1111074 (10Fjalapeno) a:3Fjalapeno [21:07:36] bearND: the spacing around the left nav wordmark is explicitly dictated by Vibha :) [21:08:06] dbrant: oh well... [21:08:52] dbrant: have you tested it on a small device? [21:09:31] bmansurov: updated card with close button svg and max height 400 px [21:09:39] kaity: thanks [21:09:41] Deskana: pm? [21:09:46] sure! [21:10:41] Maryana: looking now [21:11:03] (03PS6) 10Yurik: Store API data in database [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195839 [21:11:24] jdlrobson, done with DB stuff, i'm sure there are bugs, but can be tested now )) [21:11:47] (03CR) 10Robmoen: [C: 04-1] "oh ffs" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195459 (https://phabricator.wikimedia.org/T91776) (owner: 10Robmoen) [21:13:15] (03CR) 10Fjalapeno: Truncate logged share text at 99 characters (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195777 (owner: 10Dr0ptp4kt) [21:13:39] (03PS3) 10BearND: Add wordmark to top of left nav menu. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194334 (owner: 10Dbrant) [21:14:15] (03CR) 10BearND: [C: 032] "Was concerned about small screen devices but checked it out on my Droid and seems ok in portrait mode." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194334 (owner: 10Dbrant) [21:14:36] (03Merged) 10jenkins-bot: Add wordmark to top of left nav menu. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/194334 (owner: 10Dbrant) [21:16:39] (03PS1) 10Robmoen: A user can delete their own collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196055 (https://phabricator.wikimedia.org/T91776) [21:16:57] 10Wikipedia-App-iOS-App: Image map: better handling of image info? - https://phabricator.wikimedia.org/T92423#1111101 (10Vibhabamba) For the short term we can copy Android. **Caveat:** Android is not ideal either. When you scroll within that small area, its full of links and you accidentally keep hitting a link. [21:17:31] (03Abandoned) 10Robmoen: WIP: A user can delete their own collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195459 (https://phabricator.wikimedia.org/T91776) (owner: 10Robmoen) [21:20:15] bgerstle: hmm could maybe animate between the smaller and higher res versions… :) [21:20:42] mhurd that's true too [21:21:04] bgerstle: hehe may be the quickest fix [21:21:11] mhurd if it's alright w/ you, can we hold off on discussing it more until someone starts working on it? [21:21:25] for some reason none of my gerrit things are bouncing back here [21:21:31] mhurd coreyfloyd please re-review: https://gerrit.wikimedia.org/r/#/c/195777/ [21:21:36] bgerstle: oh yeah, sorry - just popped into my head while i was updating my patch [21:21:38] made some refactoring changes and added unit tests [21:21:46] bgerstle: k [21:21:53] bgerstle: on it [21:22:02] I love the wording here: https://www.dropbox.com/s/8klq0b7dlg7zwg2/Screenshot%202015-03-11%2017.21.28.png?dl=0 [21:22:05] coreyfloyd: actually, i can move into NSString+Extras [21:22:17] LOL "probably" [21:22:24] i don't even.. [21:22:30] i guess they can't guarantee it [21:23:52] probably a lot [21:24:16] that's the new category we're in [21:24:25] oh woops whoops [21:24:28] mhurd coreyfloyd false alarm [21:24:32] didn't "push" my review [21:24:32] 1 sec [21:24:40] bgerstle: i was wondering… :) [21:25:15] (03PS3) 10Bgerstle: Truncate logged share text at 99 characters [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195777 (owner: 10Dr0ptp4kt) [21:25:16] TA DA ^^ mhurd coreyfloyd [21:25:29] 🎉 [21:25:37] yay IRC cloud emoji! 😄 [21:25:57] bgerstle: coreyfloyd oh god i was wondering why my interwebs were so slow… DAMN YOU LINK CONDITIONER!!!! [21:26:04] HAHAHAHA [21:26:09] i can't count how many times i've done that [21:26:21] mhurd: i don't know if it does this by default, but showing it in the menu bar helps [21:26:40] 10Wikipedia-App-iOS-App: Image map: better handling of image info? - https://phabricator.wikimedia.org/T92423#1111128 (10Fjalapeno) @Vibhabamba maybe we should redesign this for both iOS and Android to get it right now? Not sure if copying Android feature is trivial or not (brian?), but probably better to put t... [21:26:57] mhurd: LOL [21:26:59] bgerstle: it shows… just not enough. wish it turned the entire menu bar red [21:27:01] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Sometimes images don't show in image viewer - https://phabricator.wikimedia.org/T89914#1111130 (10Etonkovidova) Re-checked on iPad mini with 4.0.7.4 - the dark background is displayed between 'Barack Obama delivering his electoral victory speech..'(fifth i... [21:27:26] hmm [21:27:39] mhurd i met the guy who wrote NLC [21:27:45] joined spotify while i was there [21:27:55] he's actually really good friends w/ vibha [21:27:56] small world [21:28:46] dr0ptp4kt: just realized your patch's topic. you a gangsta [21:29:41] bgerstle: haha crazy [21:30:46] mhurd coreyfloyd this patch also fixes the unit testing target [21:30:59] * bgerstle makes a note to himself to create a pre-push hook for running the tests... [21:31:03] (03CR) 10Mhurd: [C: 031] Truncate logged share text at 99 characters [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195777 (owner: 10Dr0ptp4kt) [21:31:05] (03PS3) 10BearND: Update launcher icon. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195811 (owner: 10Dbrant) [21:31:08] * bgerstle and forcibly install it on everyone's machines [21:31:13] (03CR) 10BearND: [C: 032] Update launcher icon. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195811 (owner: 10Dbrant) [21:31:33] dbrant: just waiting on you [21:31:33] bgerstle: ha [21:31:36] (03Merged) 10jenkins-bot: Update launcher icon. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195811 (owner: 10Dbrant) [21:31:43] (03PS5) 10BearND: Patch support-v4 crash in SwipeRefreshLayout. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195832 (https://phabricator.wikimedia.org/T88904) (owner: 10Dbrant) [21:31:49] bgerstle: if we must :) [21:31:51] (03CR) 10BearND: [C: 032] Patch support-v4 crash in SwipeRefreshLayout. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195832 (https://phabricator.wikimedia.org/T88904) (owner: 10Dbrant) [21:31:56] (03CR) 10Fjalapeno: "Think we may be overdoing it with the string cats… see comments" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195777 (owner: 10Dr0ptp4kt) [21:32:35] (03Merged) 10jenkins-bot: Patch support-v4 crash in SwipeRefreshLayout. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195832 (https://phabricator.wikimedia.org/T88904) (owner: 10Dbrant) [21:32:39] coreyfloyd: FYI the "unsafe" version is "substringToIndex" [21:32:46] (i.e. the Foundation API) [21:32:52] bgerstle: ha [21:33:00] thought you implemented that yourself… nm [21:33:17] from substringToIndex: docs: "Raises an NSRangeException if (anIndex - 1) lies beyond the end of the receiver." [21:33:46] bgerstle: just to ket you know - T89914 "Sometimes images don't show in image viewer" - I guess the fix is not there yet ... [21:33:55] hm [21:34:08] bgerstle: spaced on that - not sure why i thought that was a private method in your implementation [21:34:12] etonkovidova: could you move it back to "To Do" then? i can have a look tomorrow [21:34:28] coreyfloyd: np, was a reasonable request [21:34:32] bgerstle: sure - thx! [21:34:40] no, thank YOU for testing! [21:35:51] wait etonkovidova that pathc should've been in the latest build.. [21:36:01] forgot to turn DJ roomba back on after my hangout [21:36:07] yeah, that what I was thinking... [21:36:09] hm, a dark background.. [21:36:19] coreyfloyd: YOU HAVE A DJ ROOMBA?! also you watch parks & rec? nice [21:36:41] etonkovidova: well, i guess we can reopen it and i'll have another look soon [21:36:53] (03PS1) 10Kaldari: Make sure WikiGrok can load when debugging/testing [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196070 [21:36:53] * bgerstle will start making P&R references now [21:37:06] 6Mobile-Web, 7Design: Styling regression in new editor tutorial - https://phabricator.wikimedia.org/T91141#1111176 (10KHammerstein) {F83105} Attached a mockup with updates. Background color #347BFF Text #FFF "No thanks" bold (like quiet button) Primary button has white background and #347BFF text tooltip sho... [21:37:22] coreyfloyd: so, your last comment about the enums, i think it's fine to have it separate. at least for now [21:37:35] or, let me have a look actually [21:38:05] coreyfloyd: where would you have me put the enum & convenience categories? [21:38:08] bgerstle: yeah ok let me know FYI - wasnt really about the enums, just the seperate category file [21:38:14] coreyfloyd: should i create a “C Methods” group / folder for those geometry bits? [21:38:38] coreyfloyd: ah, well the categories were just there as a convenience [21:38:39] bmansurov, Maryana: I think I found the problem with loading WikiGrok on en.wiki: https://gerrit.wikimedia.org/r/#/c/196070/ [21:38:53] (so you don't need to call safeSubstring.. w/ the enum) [21:39:27] mhurd soemthing like that works - anything that just expresses what they are maybe Geometry functions - or something - whatever… [21:39:29] bgerstle: didn’t you add some geometry methods in an earlier patch? wondering where i should add mine [21:39:32] that was rambling comment [21:39:40] coreyfloyd: no worry [21:39:43] (03PS5) 10Jdlrobson: Switch to API for creating collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195978 [21:39:45] (03PS3) 10Jdlrobson: Switch to API for adding/removing pages from collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195976 (https://phabricator.wikimedia.org/T92433) [21:39:47] (03PS3) 10Jdlrobson: Switch to API for editing a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195977 [21:39:55] mhurd: probably, i added WMFRoundingUtilities and WMFFrameUtils [21:39:59] something like that [21:39:59] MaxSem: Just want to make sure you saw my latest comments on https://gerrit.wikimedia.org/r/#/c/177448/ . Let me know if you need me to debug further. [21:40:11] i can never decide whether i'm OK w/ using Utils or too lazy to spell out Utilities [21:40:39] bgerstle: yeah - i would just put them in the funnel implementation - not even sure it needs a category - just pass the enum values to the substring method [21:40:55] bgerstle: ah. since my methods aren’t tied to views i put ‘em in WMFGeometry for now if that sounds ok [21:40:56] (03CR) 10jenkins-bot: [V: 04-1] Switch to API for adding/removing pages from collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195976 (https://phabricator.wikimedia.org/T92433) (owner: 10Jdlrobson) [21:41:21] coreyfloyd: so you're saying the enums should be in the funnel header? [21:41:26] and no categories? [21:41:35] in the implementation and no categories [21:41:38] dat higher level of abstraction, tho [21:41:50] in the impl? but they need to be visible [21:42:07] jdlrobson, #wikimedia-office [21:42:15] bgerstle: thought it just was needed in the funnel? [21:42:33] let me double check where it's used.. [21:42:40] (03PS3) 10BearND: Tweaks to gallery license icon and text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195821 (owner: 10Dbrant) [21:42:41] only currently used in the share funnel [21:42:47] (03CR) 10BearND: [C: 032] Tweaks to gallery license icon and text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195821 (owner: 10Dbrant) [21:42:55] but technically any funnel would need them [21:43:18] at the very least, the file should be renamed [21:43:22] (03Merged) 10jenkins-bot: Tweaks to gallery license icon and text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/195821 (owner: 10Dbrant) [21:43:23] to EventLoggingSubstrings or something [21:43:40] bearND: thx! [21:43:56] bgerstle: wmf_safeSubstringToIndex:WMFEventLoggingMaxStringLength_General [21:44:06] bgerstle: oh if other classes need them that is differrnt [21:44:07] right, i got you there [21:44:10] right that's what i'm saying [21:44:21] WMFShareFunnel is currently the only user [21:44:46] safeSubstring has lots of possible use cases, these could stay w/in EventLoggingFunnel subclasses [21:44:59] bmansurov: If you can do a quick review of https://gerrit.wikimedia.org/r/#/c/196070/, I’ll backport and schedule for SWAT deploy [21:45:06] bgerstle: oh safe substrig is mos def general [21:45:26] right [21:45:52] ok, we only need to use the enums in the event funnel subclasses [21:46:01] bgerstle: i dont know that publically exposing various string trunctation lengths is that useful, those will be different for different classes [21:46:17] ahhhh [21:46:20] i see where you're goin' [21:46:24] like one funnel may truncate to one length and another may do another length [21:46:28] just have the share funnel define it's own consts/enums [21:46:32] but [21:46:40] (03CR) 10Bmansurov: [C: 032] Make sure WikiGrok can load when debugging/testing [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196070 (owner: 10Kaldari) [21:46:44] one of the lengths is "general" [21:47:01] i.e. fields should try to be longer than 99 chars, according to analytics [21:47:12] and the hard limit i guess in MySQL is 191 [21:47:14] don't ask me why [21:47:23] (03CR) 10Jdlrobson: Database schema for gather lists (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [21:47:25] so any event logging schema would need to do this [21:47:36] *truly* doing this and enforcing it across all schemas is out of scope for now [21:47:41] (03Merged) 10jenkins-bot: Make sure WikiGrok can load when debugging/testing [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196070 (owner: 10Kaldari) [21:47:46] so, for now, how about i just put the enums in EventLoggingFunnel.h [21:47:56] and ditch the convenience categories [21:47:56] thats fine… [21:47:59] (03PS4) 10Jdlrobson: Switch to API for adding/removing pages from collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195976 (https://phabricator.wikimedia.org/T92433) [21:48:01] getting into semantic [21:48:01] s [21:48:28] bgerstle: in the future we may want to do truncation for all funnels automatically in the suepr class [21:48:37] so its always safe [21:48:44] coreyfloyd: yeah, w/ you 100% there [21:49:12] larger discussion tho [21:49:57] bgerstle: yeah… [21:50:19] kristenlans: curious how I interact with the phab team… do I just file a ticket with a request (in reference to bug ticket fields)? [21:50:44] (03PS2) 10Jdlrobson: A user can delete their own collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196055 (https://phabricator.wikimedia.org/T91776) (owner: 10Robmoen) [21:51:41] coreyfloyd: i mean there is a "quick" way to do it [21:51:54] (verifying string length at least) [21:52:11] but, thinking about it again, i really don't want to get into it w/ this patch [21:52:28] (03PS4) 10Bgerstle: Truncate logged share text at 99 characters [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195777 (owner: 10Dr0ptp4kt) [21:52:28] coreyfloyd: yeah just filing a ticket in the pHab project seems to work pretty well. Our local Phabmasters Andre and Quim are very responsive. [21:52:40] coreyfloyd: mhurd last hurrah (again) ^ [21:53:05] jdlrobson, any q for me ? [21:53:43] bgerstle: k [21:53:52] (03CR) 10Fjalapeno: [C: 031] "Gold Star!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195777 (owner: 10Dr0ptp4kt) [21:53:58] yay! [21:54:13] ⭐️ [21:55:13] (03CR) 10Yurik: Database schema for gather lists (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [21:55:16] coreyfloyd: what can i say? http://i.imgur.com/UDPjx.jpg [21:55:17] bgerstle: coreyfloyd ^ merge it? [21:55:25] mhurd: do eet [21:55:39] (03CR) 10Mhurd: [C: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195777 (owner: 10Dr0ptp4kt) [21:55:47] yay unit testing is fixed [21:55:50] do it [21:55:54] bgerstle: wohoo! [21:56:01] FYI, in case anyone wanted to write some [21:56:02] bgerstle: lol [21:56:03] you can [21:56:07] if you want to [21:56:20] or you can leave your friends behind [21:56:53] (03CR) 10Jdlrobson: [C: 04-1] "I rebased this on top of the Api rewrites I've been doing (as it seems they were operating inconsistently)" (035 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196055 (https://phabricator.wikimedia.org/T91776) (owner: 10Robmoen) [21:56:54] bgerstle: coreyfloyd now i can write “yo dawg” unit tests to unit test my unit rect methods… [21:57:17] haha [21:57:18] please do [21:57:33] yurik: i gotta run but i poked at the database patch not 100% sure about the blob approach - maybe mail me and the team with rationale around it and lets make a quick decision tomorrow morning? [21:57:36] dr0ptp4kt: has already set precedent w/ his "i-got-99-chars" patch [21:57:43] jdlrobson, i already replied [21:57:43] i've mostly got the frontend code using the api [21:57:58] excellente [21:58:07] the special pages still need wiring up (see blocking bugs on https://phabricator.wikimedia.org/T92418 [21:58:27] but once https://gerrit.wikimedia.org/r/195976 is merged we can start look at porting to database [21:58:39] jdlrobson, rationale is very simpele for the blob - experiment in a blob, and once columns have been determined (when we have a working viable product), we move them out of the blob and into their own columns [21:59:06] gotta run to take my dad to airport but will check my email later so mail anything there yurik (sorry!)! [21:59:17] ok [21:59:27] im hoping once joakin has looked ovr the patches the focus of tomorrow can be moving to database [22:01:48] (03PS1) 10Kaldari: Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196078 [22:02:43] bgerstle: btw - I did watch Parks and Rec… but those days are over… sniffle [22:04:18] (03PS2) 10Kaldari: Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196078 [22:05:18] bmansurov: actually came up with a slightly more logical way to handle it: https://gerrit.wikimedia.org/r/#/c/196078/ Sorry! [22:05:29] coreyfloyd: not for me! still making our way through it [22:05:33] slowly but surely [22:05:37] anything you say, kaldari ;) [22:05:59] bgerstle: probably the best final season and season finale of any show I know of [22:06:29] oh wow [22:06:32] that's encouraging [22:06:42] better than AD's "Save the bluths?" [22:06:50] (i haven't actually watched the most recent season, i'm awful) [22:07:02] kaldari: i suppose we don't care about version c? [22:07:29] coreyfloyd: also, that's a pretty strong statement, wouldn't have expected that from P&R [22:08:15] bmansurov: actually, with this new code we can turn on wgWikiGrokUIEnableInSidebar, but turn off wgWikiGrokUIEnable, and we’ll be able to test version C, but not show it to everyone. [22:09:21] since the code for adding WikiGrok C in the sidebar also checks self::isUIEnabled() [22:09:40] kaldari: yes, but the dialog itself in C is loaded via the hash [22:09:44] not query parameter [22:09:59] bmansurov: oh yeah :( [22:10:54] bgerstle: AD was really funny (I haven't watched the new season either - tried, but didnt get very far) - we were surprised as well… just very true to the show but still a good ending. [22:11:05] nice [22:11:28] bmansurov: maybe I should have it check if either wikigrokversion is set in the querystring or wikidataid? [22:12:18] kaldari: or maybe you can change && to || [22:12:19] coreyfloyd: mhurd dogs are getting crazy and i think i'm getting vision fatigue [22:12:26] (blurriness plus slight headache coming on) [22:12:27] kaldari: in the condition you wrote [22:12:37] gonna step out for the night, should have image pagination working sometime tomorrow [22:12:39] bgerstle: take a rest! see ya tomorrow! [22:12:43] kaldari: i'm not sure, maybe a bad idea [22:13:10] bmansurov: but then that would make it load for everyone if we enable debugging [22:13:47] kaldari: then yes, adding wikidataid should do it because version C doesn't remove query parameters [22:13:59] or even start version c with wikigrokversion query parameter [22:14:00] bmansurov: I’ll do that... [22:14:07] (03PS56) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [22:14:19] bmansurov: Oh that’s true [22:14:19] kaldari: so you amy even not to change anything [22:14:25] i'll just +2 [22:14:32] bmansurov: nice thinking :) [22:14:47] kaldari, https://gerrit.wikimedia.org/r/#/c/177448/55..56/includes/api/ApiResponse.php [22:14:48] kaldari: what about centralauth, should not it be a requirement for any case? [22:15:01] (03PS16) 10Mhurd: WIP: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [22:15:04] (03CR) 10jenkins-bot: [V: 04-1] WIP: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [22:15:32] bmansurov: it’s needed for really using WikiGrok (i.e. submitting data to a wikidata repo), but shouldn’t be required for UI testing/debugging [22:15:38] bmansurov, testing with CA is not the best experience in life:) [22:15:46] kaldari: ok [22:15:48] MaxSem: thanks [22:15:57] (03CR) 10Bmansurov: [C: 032] Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196078 (owner: 10Kaldari) [22:16:07] coreyfloyd: ^ changed to “WIP” since i’m still wrapping up a couple issues you commented on [22:16:57] (03Merged) 10jenkins-bot: Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196078 (owner: 10Kaldari) [22:17:45] (03PS1) 10Fjalapeno: Fix refresh icon visual glitch when navigating back to the saved pages list while a refresh in in progress [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196080 [22:18:41] (03PS17) 10Mhurd: WIP: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [22:18:50] ^rebased [22:19:52] (03PS1) 10Fjalapeno: Deployment target for sub project was too high (8.0) - this makes it match the main project (6.0) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196081 [22:20:12] (03PS2) 10Mhurd: Only calculate cell height if the length of the text will be "too long" to fit in a normal size cell. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195982 (owner: 10Fjalapeno) [22:20:15] (03CR) 10MaxSem: Database schema for gather lists (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [22:24:34] (03CR) 10Fjalapeno: "include comment" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [22:26:24] (03PS1) 10Dbrant: Update target SDK and AppCompat versions. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196086 [22:29:08] (03CR) 10Mhurd: Only calculate cell height if the length of the text will be "too long" to fit in a normal size cell. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195982 (owner: 10Fjalapeno) [22:29:23] (03PS2) 10Dbrant: Update target SDK and AppCompat versions. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196086 [22:29:25] MaxSem: http://i.imgur.com/lzlWr3X.jpg [22:29:26] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 2 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1111389 (10Fjalapeno) I was going to pick this up but its not clear what the actual issue is from the ticket des... [22:31:05] (03PS1) 10Kaldari: Make sure WikiGrok can load when debugging/testing [extensions/WikiGrok] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196088 [22:31:07] (03PS1) 10Kaldari: Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled [extensions/WikiGrok] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196089 [22:31:40] (03PS3) 10Fjalapeno: Only calculate cell height if the length of the text will be "too long" to fit in a normal size cell. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195982 [22:31:43] (03CR) 10Kaldari: [C: 032] Make sure WikiGrok can load when debugging/testing [extensions/WikiGrok] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196088 (owner: 10Kaldari) [22:32:13] mhurd: ^ [22:32:17] (03CR) 10Kaldari: [C: 032] Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled [extensions/WikiGrok] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196089 (owner: 10Kaldari) [22:32:22] (03CR) 10Mhurd: WIP: Move lead image inflation/face detection to background thread. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [22:32:49] (03Merged) 10jenkins-bot: Make sure WikiGrok can load when debugging/testing [extensions/WikiGrok] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196088 (owner: 10Kaldari) [22:33:09] (03CR) 10Yurik: Database schema for gather lists (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [22:33:19] (03Merged) 10jenkins-bot: Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled [extensions/WikiGrok] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196089 (owner: 10Kaldari) [22:34:42] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Some map images cause the entire webview to be scrollable left to right - https://phabricator.wikimedia.org/T91702#1111391 (10KLans_WMF) @deskana if you agree this is not a release blocker, can we put this in the bug backlog (or next sprint, or at the botto... [22:37:56] 10MobileFrontend-Feature-requests, 10UI-Standardization, 7Accessibility, 7Design: Identify the best diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1111399 (10TheDJ) @JaredZimmerman-WMF eh. that's like saying that color blind people should still be able to understand traffic lig... [22:38:09] (03CR) 10Mhurd: Only calculate cell height if the length of the text will be "too long" to fit in a normal size cell. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195982 (owner: 10Fjalapeno) [22:38:12] coreyfloyd: are you feeling OK about what to pick up next (noticed your comment fly by re: T90606)? [22:38:14] (03PS4) 10Mhurd: Only calculate cell height if the length of the text will be "too long" to fit in a normal size cell. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195982 (owner: 10Fjalapeno) [22:38:23] (03CR) 10Mhurd: [C: 031] Only calculate cell height if the length of the text will be "too long" to fit in a normal size cell. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195982 (owner: 10Fjalapeno) [22:38:32] dr0ptp4kt: ^ [22:39:00] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Image Gallery: indicate the first and the last image - https://phabricator.wikimedia.org/T92445#1111402 (10Deskana) p:5Triage>3Normal [22:39:17] mhurd: you rang? [22:39:34] kristenlans: actually yeah - feel like it would be helphful to review the todo list with the team - a lot of things that are "kinda" tasks in there [22:39:43] 10Wikipedia-App-iOS-App: 'Save pictures to device' on iOS from Image Gallery - https://phabricator.wikimedia.org/T92443#1111407 (10Deskana) p:5Triage>3Normal Would be a nice little enhancement to knock out. [22:41:31] (03PS1) 10Kaldari: Make sure WikiGrok can load when debugging/testing [extensions/WikiGrok] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/196091 [22:41:33] (03PS1) 10Kaldari: Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled [extensions/WikiGrok] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/196092 [22:42:52] (03CR) 10Kaldari: [C: 032] Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled [extensions/WikiGrok] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/196092 (owner: 10Kaldari) [22:43:13] (03Merged) 10jenkins-bot: Make sure WikiGrok can load when debugging/testing [extensions/WikiGrok] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/196091 (owner: 10Kaldari) [22:43:40] (03Merged) 10jenkins-bot: Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled [extensions/WikiGrok] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/196092 (owner: 10Kaldari) [22:43:50] dr0ptp4kt: mhurd bgerstle deskana coreyfloyd are you guys up for a quick TO DO column review (see coreyfloyd's comment 7 nuggets above). Was gonna suggest tomorrow AM but no bueno. [22:44:18] * kristenlans makes rumblings again about daily standups [22:44:58] kristenlans: agreed! [22:45:00] kristenlans: yes. can we please get tuesday and thursday standups at 1015? [22:45:27] kristenlans: im ok with doing this tomorrow have some stuff to keep me busy until then [22:46:26] ok coreyfloyd. dr0ptp4kt I'm happy to get T and Th on the calendar. I've heard thumbs up from everyone reuired at standup except deskana and mhurd. [22:48:51] http://media.giphy.com/media/VGs4AxrJBk9aw/giphy.gif [22:59:36] (03CR) 10Dr0ptp4kt: [C: 032] "Anecdotally, there's less lockup on an iOS 6 4S. For example, with the search "gerald is here president", it seemed to be more responsive " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/195982 (owner: 10Fjalapeno) [23:00:05] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Trim event logging string length for snippets to 99 characters - https://phabricator.wikimedia.org/T91848#1111445 (10dr0ptp4kt) 5Open>3Resolved [23:14:27] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 2 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1111463 (10dr0ptp4kt) I'll update the ticket description. [23:23:35] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 2 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1111532 (10dr0ptp4kt) [23:25:05] (03PS1) 10Bmansurov: Alpha, Beta: Make reference dialog scrollable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196098 [23:25:51] (03CR) 10Bmansurov: "https://gerrit.wikimedia.org/r/#/c/196098/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (https://phabricator.wikimedia.org/T87050) (owner: 10Robmoen) [23:26:03] (03CR) 10Bmansurov: "https://gerrit.wikimedia.org/r/#/c/196098/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178355 (owner: 10Robmoen) [23:26:55] 6Mobile-Web, 7Design: Styling regression in new editor tutorial - https://phabricator.wikimedia.org/T91141#1111542 (10bmansurov) @KHammerstein, thanks! [23:37:36] MaxSem: What table does Wikibase actually store the property values in? [23:37:56] page content [23:39:17] Krenair: done: https://gerrit.wikimedia.org/r/#/c/196106/ [23:39:24] oops, wrong channel [23:44:26] (03PS2) 10Mhurd: Deployment target for sub project was too high (8.0) - this makes it match the main project (6.0) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196081 (owner: 10Fjalapeno) [23:44:32] (03CR) 10Mhurd: [C: 031] Deployment target for sub project was too high (8.0) - this makes it match the main project (6.0) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196081 (owner: 10Fjalapeno) [23:54:45] (03PS1) 10Kaldari: Revert "Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled" [extensions/WikiGrok] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/196114 [23:55:00] (03PS1) 10Kaldari: Revert "Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled" [extensions/WikiGrok] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196116 [23:55:15] (03PS1) 10Kaldari: Revert "Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196117 [23:55:41] (03CR) 10Alex Monk: [C: 032] Revert "Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled" [extensions/WikiGrok] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/196114 (owner: 10Kaldari) [23:55:43] (03CR) 10Kaldari: [C: 032] Revert "Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196117 (owner: 10Kaldari) [23:56:04] (03CR) 10Kaldari: [C: 032] Revert "Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled" [extensions/WikiGrok] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196116 (owner: 10Kaldari) [23:58:02] (03Merged) 10jenkins-bot: Revert "Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled" [extensions/WikiGrok] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/196114 (owner: 10Kaldari) [23:58:48] (03Merged) 10jenkins-bot: Revert "Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196117 (owner: 10Kaldari) [23:58:50] (03Merged) 10jenkins-bot: Revert "Moving wgWikiGrokDebug check from onBeforePageDisplay to isUIEnabled" [extensions/WikiGrok] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196116 (owner: 10Kaldari)