[00:00:35] (03CR) 10Dr0ptp4kt: "It seems that the "Cancel" button is always there, irrespective of the refreshing status. That is to say:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196080 (owner: 10Fjalapeno) [00:19:49] 10MobileFrontend-Feature-requests, 10UI-Standardization, 7Accessibility, 7Design: Identify the best diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1111718 (10Jaredzimmerman-WMF) @TheDJ, I totally get that, my point was that it seems like colorblindness was being used as a reaso... [00:34:08] 10MobileFrontend-Feature-requests, 10UI-Standardization, 7Accessibility, 7Design: Identify the best diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1111740 (10MaxSem) 5Open>3Invalid a:3MaxSem As the partially colorblind guy who started all that fun in 2012: the semantics o... [00:35:49] (03CR) 10Fjalapeno: "hmmm… looking I didn't see that" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196080 (owner: 10Fjalapeno) [00:37:22] mhurd: you around? [00:37:31] coreyfloyd: ya [00:37:42] mhurd: can you reproduce adams bug? [00:37:51] https://gerrit.wikimedia.org/r/196080 [00:38:11] mhurd: the button is always in the right state for me [00:38:57] coreyfloyd: i’ll need a few minutes.. [00:39:28] mhurd: take your time [00:39:37] mhurd: just want to see if someone else can do it [00:40:00] coreyfloyd: gotch. will test as soon as i wrap this [00:49:58] (03PS2) 10Bmansurov: WIP: Alpha: Quickly lookup info about a wiki page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195818 [00:51:07] (03CR) 10jenkins-bot: [V: 04-1] WIP: Alpha: Quickly lookup info about a wiki page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195818 (owner: 10Bmansurov) [01:13:08] coreyfloyd: sorry i ran into an issue - i’m gonna have to finish up and check your bug in the morning - too sleepy :) [01:13:28] np - thats probabaly for the best [01:14:19] (03PS18) 10Mhurd: WIP: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [01:15:19] coreyfloyd: i just pushed my latest ^ but i had to back out a small refactor on that notification method we talked about ‘cause i broke it :) i’ve partially re-re-factored it so i promise it’s almost done for real this time :) [01:15:38] lol [01:15:44] mhurd: ok - will check out [01:15:47] *apparently i use a lot of smiley faces when i’m tired* [01:15:56] its a mask! [01:16:01] hahah [01:17:31] mhurd: is brion vibber near you? [01:17:43] coreyfloyd: no haven’t seen him today [01:17:56] hmmm… need him to accept the latest itunes agreement [01:19:37] coreyfloyd: i can log in [01:20:31] coreyfloyd: done [01:20:46] cool thanks [01:20:51] coreyfloyd: np [01:34:50] (03PS1) 10MaxSem: WIP: aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 [01:35:21] (03CR) 10jenkins-bot: [V: 04-1] WIP: aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 (owner: 10MaxSem) [02:13:09] 10MobileFrontend-Feature-requests, 10UI-Standardization, 7Accessibility, 7Design: Identify the best diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1111885 (10Jaredzimmerman-WMF) 5Invalid>3Open @MaxSem, I get what you're saying, and I totally think we should show in-line dif... [02:23:43] 6Mobile-Web, 7Design: Styling regression in new editor tutorial - https://phabricator.wikimedia.org/T91141#1111895 (10Jaredzimmerman-WMF) p:5Triage>3Normal [02:30:55] 6Mobile-Web, 7Performance: Nearby should be JS only - https://phabricator.wikimedia.org/T88432#1111901 (10Jaredzimmerman-WMF) [02:31:52] 6Mobile-Web, 7Performance: Nearby should be JS only - https://phabricator.wikimedia.org/T88432#1011511 (10Jaredzimmerman-WMF) Removed Design tag, as the description does not imply any changes to the appearance just the underlying technology. Re-add if I'm misunderstanding. [02:35:13] 10Wikipedia-App-iOS-App, 7Design: iOS app: Credits screen needs improvement - https://phabricator.wikimedia.org/T66391#1111912 (10Jaredzimmerman-WMF) 5Open>3Invalid a:3Jaredzimmerman-WMF This screen has already been totally redesigned, and looks nothing like the screenshot in the bug. [02:40:03] 10Wikipedia-App-iOS-App, 7Design: iOS app: Credits screen needs improvement - https://phabricator.wikimedia.org/T66391#1111916 (10Vibhabamba) This was already fixed. And its *extremely* priority right now. [02:46:04] 10MobileFrontend-Feature-requests, 7Browser-Support-Firefox, 7Design: Editing window text area indistinguishable from uneditable pages - https://phabricator.wikimedia.org/T71093#1111928 (10Jaredzimmerman-WMF) I don't understand this bug, can you please include a screenshot of the issue, perhaps with a versio... [02:46:48] 10MobileFrontend-Feature-requests, 7Browser-Support-Firefox, 7Design: Editing window text area indistinguishable from uneditable pages - https://phabricator.wikimedia.org/T71093#1111937 (10Jaredzimmerman-WMF) p:5Triage>3Low [02:55:11] (03CR) 10BearND: [C: 032] "Let's see if this works on the Alpha build server." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196086 (owner: 10Dbrant) [02:55:11] 10Wikipedia-App-iOS-App, 7Design: iOS app: Credits screen needs improvement - https://phabricator.wikimedia.org/T66391#1111940 (10Legoktm) 5Invalid>3Resolved [02:58:23] (03Merged) 10jenkins-bot: Update target SDK and AppCompat versions. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196086 (owner: 10Dbrant) [03:00:45] 10MobileFrontend-Feature-requests, 7Design: Offer to bounce desktop users back to desktop - https://phabricator.wikimedia.org/T72045#1111952 (10Jaredzimmerman-WMF) 5Open>3declined a:3Jaredzimmerman-WMF given the known, and standard (across mobile and desktop) place for the current switch i recommend not... [03:01:37] 10MobileFrontend-Feature-requests, 6WMF-Design, 7Design: Design suggestions for mobile user profile page - https://phabricator.wikimedia.org/T75185#1111957 (10Jaredzimmerman-WMF) p:5Triage>3Low [03:01:57] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Zero, 7Design: only show features related to Zero if Zero is relevant in this context - https://phabricator.wikimedia.org/T92267#1111960 (10Jaredzimmerman-WMF) p:5Triage>3Low [03:05:14] 6Mobile-Web, 6Commons, 10MediaWiki-Parser, 7Design: Display of images in categories on mobile web site present only one image per row starting at some resolution. - https://phabricator.wikimedia.org/T78174#1111967 (10Jaredzimmerman-WMF) p:5Triage>3Low [03:07:00] 10MobileFrontend-Feature-requests, 10UI-Standardization, 7Accessibility, 7Design: Identify the best diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1111972 (10Jaredzimmerman-WMF) p:5Triage>3Normal [03:08:00] 6Mobile-Web, 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1111994 (10Jaredzimmerman-WMF) p:5Triage>3High [03:23:27] 6Mobile-Web, 7Mobile: Clear search button is missing on mobile search once you swith to full-text Search - https://phabricator.wikimedia.org/T88631#1112021 (10Jaredzimmerman-WMF) [03:23:58] 6Mobile-Web, 7Mobile: Clear search button is missing on mobile search once you swith to full-text Search - https://phabricator.wikimedia.org/T88631#1016556 (10Jaredzimmerman-WMF) seems like a basic bug, the icon is missing, no design changes need. [03:25:35] (03PS1) 10BearND: Move link to MW API to better place in README [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196146 [03:25:52] (03PS1) 10BearND: Use Gradle SDK Manager Plugin [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196147 [03:29:25] (03PS1) 10BearND: Hygiene: SpUsage: Using dp instead of sp for text sizes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196148 [03:30:58] (03PS2) 10BearND: Hygiene: SpUsage: Using dp instead of sp for text sizes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196148 [03:32:47] (03PS1) 10BearND: Replace explicit type with '<>' [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196149 [03:32:49] (03PS1) 10BearND: Tackle some more inspection warnings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196150 [05:55:31] (03PS1) 10BearND: Tweak layout for Share A Fact [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196161 (https://phabricator.wikimedia.org/T91721) [09:23:33] 6Mobile-Web, 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, and 5 others: there should be a comparison of clicks count on interlanguage links on different platforms - https://phabricator.wikimedia.org/T78351#1112414 (10Amire80) [09:24:48] morning! [09:39:52] (03CR) 10Jhernandez: Do not open the editing overlay if the collection is a watchlist (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195975 (https://phabricator.wikimedia.org/T92414) (owner: 10Jhernandez) [09:43:48] (03PS1) 10Jhernandez: Hygiene: cleanup redundant else&return [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196184 [10:06:22] morning all [10:10:41] moar coffee required [10:10:48] how're you joakino? [10:11:20] 6Mobile-Web, 5Patch-For-Review: Deemphasise wikitext markup in editor - https://phabricator.wikimedia.org/T91796#1112478 (10Jhernandez) Cool stuff guys! @jdlrobson : - Would a patch applying this only to alpha be acceptable? We can add bucketing and metrics afterwards if alpha tests look good and @maryana is... [10:11:27] hi phuedx [10:11:29] (03CR) 10Phuedx: [C: 032] Hygiene: cleanup redundant else&return [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196184 (owner: 10Jhernandez) [10:12:05] phuedx: it takes me about 1 hour and a half to sort through emails/phabs/gerrits daily [10:12:09] it is a bit tiring [10:12:14] joakino: yup [10:12:30] (03Merged) 10jenkins-bot: Hygiene: cleanup redundant else&return [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196184 (owner: 10Jhernandez) [10:12:31] joakino: had my first major vagrant problem yesterday [10:12:35] well -- virtualbox problem [10:12:40] oh noes [10:12:46] what was it [10:12:57] the virtual hard drives for both of my mwv's became corrupted, not sure how [10:13:23] and now i can't set up wikidata entities for testing wikigrok :'( [10:14:43] crap [10:14:47] phuedx: so full reinstall [10:14:55] yup [10:15:03] i've been removing roles because vagrant is so slow... [10:15:13] i rebuilt a vm, which took ages [10:15:19] visual editor, wikidata, wikigrok, commons,... [10:15:26] and now i'm going through the set up procedure again [10:15:32] i feel you phuedx... [10:19:19] phuedx: have you seen this one? https://phabricator.wikimedia.org/T78733 [10:19:30] i'm following it to see if they come up to some magic incantation [10:22:53] vagrant up [10:23:01] time to make a cup of coffee… [10:23:03] and read my email [10:28:59] joakino: could you do me a favour? [10:29:27] take a look at your /etc/exports and tell me how many entries it has [10:30:03] phuedx: inside vagrant? [10:30:10] nope [10:30:11] host machine [10:31:16] 3, my 2 old broken vagrants and the current one [10:31:40] ok cook [10:31:41] *l [10:31:50] my old vagrant box had 50 :/ [10:31:54] phuedx: you can see the evolution https://gist.github.com/anonymous/9cf7ca1c994625c82773 [10:31:57] wtf why [10:32:20] i have /no/ idea [10:32:32] 1st vagrant, 2nd vagrant-clean, 3rd time gave up and just named it vagrant-DATE [10:32:42] fucking puppetvagrant [10:35:44] gmail has gone crazy and logged me out saying there are concurrent sessions on the wikimedia account :S [10:35:52] and in the log there is only my ip [10:36:07] :/ [10:36:15] i get kicked out of hangouts regularly : [10:36:16] :/ [10:42:13] (03CR) 10Jhernandez: "It's not updating both jsons index and details but i guess it doesn't matter since we are moving towards the api" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195977 (owner: 10Jdlrobson) [10:42:21] (03CR) 10Jhernandez: [C: 032] Switch to API for editing a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195977 (owner: 10Jdlrobson) [10:43:22] (03Merged) 10jenkins-bot: Switch to API for editing a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195977 (owner: 10Jdlrobson) [10:48:09] (03CR) 10Jhernandez: [C: 032] Switch to API for creating collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195978 (owner: 10Jdlrobson) [10:49:17] (03Merged) 10jenkins-bot: Switch to API for creating collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195978 (owner: 10Jdlrobson) [10:52:16] (03CR) 10Phuedx: [C: 032] "+2 now given the two other +1s and that wmf/1.25wmf21 has been cut." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194968 (https://phabricator.wikimedia.org/T91421) (owner: 10Bmansurov) [10:53:38] (03PS5) 10Jhernandez: Switch to API for adding/removing pages from collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195976 (https://phabricator.wikimedia.org/T92433) (owner: 10Jdlrobson) [10:53:40] (03Merged) 10jenkins-bot: Resolve router deferred on back [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194968 (https://phabricator.wikimedia.org/T91421) (owner: 10Bmansurov) [10:56:23] (03PS6) 10Jhernandez: Switch to API for adding/removing pages from collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195976 (https://phabricator.wikimedia.org/T92433) (owner: 10Jdlrobson) [10:58:27] still provisioning [11:05:11] phuedx you are a jinx [11:05:18] ? [11:05:27] have i remotely destroyed your machine? [11:05:30] suddenly vagrant has stopped responding to any requests, and wont come up [11:05:39] fuuuuuuuuuuck [11:05:55] phuedx: just kidding [11:07:23] save me jebusss https://31.media.tumblr.com/tumblr_lw3xmbd1O01qhvzo9o1_400.gif [11:13:55] (03CR) 10Jhernandez: [C: 032] "Looks good. The images dont show up on the collectionSSSS list but that's something with the api, not this patch." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195976 (https://phabricator.wikimedia.org/T92433) (owner: 10Jdlrobson) [11:15:09] (03Merged) 10jenkins-bot: Switch to API for adding/removing pages from collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195976 (https://phabricator.wikimedia.org/T92433) (owner: 10Jdlrobson) [11:16:51] (03PS4) 10Jhernandez: WIP: Special:Gather and collections overlay should use API [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195621 (owner: 10Jdlrobson) [11:17:09] (03PS3) 10Jhernandez: WIP: Create Special:Gather// via api [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195965 (owner: 10Jdlrobson) [12:36:35] gonna have lunch with lisa, george, and harry [13:47:23] 10MobileFrontend-Feature-requests, 10UI-Standardization, 7Accessibility, 7Design, 7user-notice: Identify the best diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1112937 (10He7d3r) [13:49:50] (03PS7) 10Yurik: Store API data in database [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195839 (https://phabricator.wikimedia.org/T91308) [13:49:52] (03CR) 10jenkins-bot: [V: 04-1] Store API data in database [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195839 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [13:50:30] (03PS16) 10Yurik: Database schema for gather lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) [13:55:50] 10Wikipedia-App-iOS-App: Image map: better handling of image info? - https://phabricator.wikimedia.org/T92423#1112961 (10BGerstle-WMF) Let's sync today on the cost of @Vibhabamba's "more ideal" solution vs. android's approach. Once we can compare, it will be easier to choose. Once we have rough estimates on ea... [13:57:37] 10Wikipedia-App-Android-App, 7I18n: Find alternative solution for translating the Android app description other than using a single large message in our translation files - https://phabricator.wikimedia.org/T91971#1112963 (10Nikerabbit) You can see summary at the top of the page. More detailed stats you can ge... [13:59:23] (03CR) 10Phuedx: [C: 04-1] "See inline for a couple of minors." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [13:59:49] 6Mobile-Web: On MobileFrontend, Template:sfrac introduces an extra/incorrect slash - https://phabricator.wikimedia.org/T92472#1112968 (10Aklapper) [14:00:00] 6Mobile-Web: On MobileFrontend, Template:sfrac introduces an extra/incorrect slash - https://phabricator.wikimedia.org/T92472#1111906 (10Aklapper) Can confirm with Firefox 36 on a laptop here. [14:05:56] (03PS8) 10Yurik: Store API data in database [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195839 (https://phabricator.wikimedia.org/T91308) [14:09:09] (03CR) 10Phuedx: Load banner images on page load (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [14:15:20] i might actually have a working wikigrok dev environment again! [14:17:22] joakino_: what do you think of neovim? [14:17:25] are you using it? [14:17:50] phuedx: i installed it some time ago, it's coming along nicely [14:18:03] still, cant use it, i have plugins i use that don't work there [14:18:11] boo [14:18:28] i haven't explored it – but i'm pretty dern excited about being able to use lua [14:25:59] there's a huge crane outside blocking the street [14:26:04] \o/ [14:57:40] (03CR) 10Dbrant: [C: 032] Move link to MW API to better place in README [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196146 (owner: 10BearND) [15:00:59] (03Merged) 10jenkins-bot: Move link to MW API to better place in README [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196146 (owner: 10BearND) [15:04:37] (03CR) 10Dbrant: [C: 032] Use Gradle SDK Manager Plugin [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196147 (owner: 10BearND) [15:05:09] (03Merged) 10jenkins-bot: Use Gradle SDK Manager Plugin [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196147 (owner: 10BearND) [15:07:47] (03CR) 10Dbrant: [C: 032] Hygiene: SpUsage: Using dp instead of sp for text sizes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196148 (owner: 10BearND) [15:13:38] (03CR) 10Dbrant: [C: 032] Replace explicit type with '<>' [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196149 (owner: 10BearND) [15:14:08] (03Merged) 10jenkins-bot: Replace explicit type with '<>' [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196149 (owner: 10BearND) [15:17:36] bgerstle: do you mind checking this out and let me know if you see the bug that Adam saw? I can't repro https://gerrit.wikimedia.org/r/#/c/196080/ [15:17:50] coreyfloyd: yeah, in a bit [15:21:13] (03CR) 10Phuedx: "@Bmansurov: I can no longer reproduce this – Chrome updated last night after I finally restarted my machine." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195596 (https://phabricator.wikimedia.org/T91882) (owner: 10Bmansurov) [15:23:45] (03CR) 10Phuedx: [C: 032] "Also tested in Safari 8.0.3 (10600.3.18)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195596 (https://phabricator.wikimedia.org/T91882) (owner: 10Bmansurov) [15:24:09] hey kristenlans [15:24:26] are you going to the lyon hackathon? [15:24:34] phuedx: Correct! [15:24:37] So excited [15:24:41] yeah!? [15:24:42] yeah! [15:24:49] YEEEEEAHHHHH!!!!!! [15:24:52] i'll be taking my aeropress [15:24:59] i will also buy some super-fresh beans [15:25:06] Um, *I'LL* be taking *MY* Aeropress [15:25:12] yeah!? [15:25:21] well i'll be taking my hario woodneck drip pot [15:25:22] my chemex [15:25:25] my v60 [15:25:27] EURO AEROPRESS HACKATHON PRESS OFF 2015!!! [15:25:28] (03Merged) 10jenkins-bot: Restore anchor position [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195596 (https://phabricator.wikimedia.org/T91882) (owner: 10Bmansurov) [15:25:34] my bialetti brikka [15:25:40] OK!? [15:25:44] * kristenlans might be out of her depth now [15:25:53] i won't really [15:26:06] however, i will be practicing from now until then [15:26:10] and tuning [15:26:21] phuedx: I've already started my training regimen [15:26:29] i'll also be buying a new headband so all of my hair doesn't get in the way [15:26:36] LOLOLOLOL [15:27:13] 6Mobile-Web: Going to a link with an anchor scroll to wrong position / viewport in mobile version - https://phabricator.wikimedia.org/T91882#1113185 (10phuedx) [15:27:22] 6Mobile-Web: Going to a link with an anchor scroll to wrong position / viewport in mobile version - https://phabricator.wikimedia.org/T91882#1113187 (10phuedx) 5Open>3Resolved a:3phuedx [15:29:13] gonna take a break [15:29:20] and go and watch the steel go into the loft [15:31:00] kristenlans: phuedx can i referree? [15:31:03] referee* [15:31:08] (i.e. drink all of the coffee) [15:31:16] bgerstle: totes [15:32:09] 6Mobile-Web: On MobileFrontend, wikipedia:en:Template:sfrac introduces an extra/incorrect slash - https://phabricator.wikimedia.org/T92472#1113198 (10Krenair) [15:39:40] 6Mobile-Web, 5Patch-For-Review: Search bar suggestions not working on Windows Phone 8.1 - https://phabricator.wikimedia.org/T91421#1113220 (10bmansurov) 5Open>3Resolved a:3bmansurov [15:39:44] bearND: hmm, something isn't looking quite right... [15:39:58] dbrant: what is it? [15:40:30] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 2 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1113222 (10Fjalapeno) @dr0ptp4kt thanks! [15:40:46] bearND: the hamburger icon at the top left has disappeared... and also the app is crashing when i click the edit pencil. :( but I don't know which patch has caused it. It only started happening when I did a full rebuild... [15:40:48] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 2 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1113225 (10Fjalapeno) a:3Fjalapeno [15:41:36] (03PS1) 10Fjalapeno: Addresses Bug:T90606 Now using different url parameters for sharing types. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196243 [15:41:42] dbrant: that's strange [15:41:48] bearND: probably has to do with the new sdk version and/or appcompat. I'm checking it out... [15:42:15] dbrant: ok, could be [15:45:47] w00t coreyfloyd first pagination unit test passed... now i can put it on hold and look at the bug [15:46:04] wohoo! nice [15:46:16] coreyfloyd: but i've already hit the classic "testing async code" problem ;-) [15:46:26] but, i've solved it elegantly before [15:46:37] backsies [15:46:58] bgerstle: I'm sure you have http://www.reactiongifs.com/r/cwclp.gif [15:47:07] rofl [15:47:09] well played, sir [15:47:30] http://mlkshk.com/r/97VP [15:47:42] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [PRODUCTION RELEASE BLOCKER] Verify data migrations work from old store release - https://phabricator.wikimedia.org/T91713#1113266 (10Fjalapeno) a:3Fjalapeno [15:47:43] coreyfloyd: that could be your dog ^ [15:48:39] bgerstle: that could be me [15:48:54] "on the internet, nobody knows you're a dog" [15:49:02] bgerstle: the hair and confusion proportions seem clsoe enough [15:49:07] lol [15:49:12] get some blonde dye and you're good [15:49:24] got work on your panting, though [15:49:28] got to work* [15:49:29] i always go for trench coat and fedora [15:50:00] dbrant: main page is all about shrooms today [15:50:54] bgerstle: i noticed! i see T. felleus all the time around here. [15:51:01] coreyfloyd: hm, it's either refreshing saved pages too fast, or i'm not seeing the progress after going back [15:51:35] dbrant: http://i.imgur.com/UDPjx.jpg [15:51:48] * bgerstle fires up NLC.. [15:52:25] coreyfloyd: the cancel button problem doesn't seem to be there [15:52:25] but [15:53:04] hm [15:53:17] yeah, the progress bar doesn't immediately show the current progress when re-entering the view [15:54:00] but i don't see the "cancel + refresh icon" bug anymore [15:55:13] coreyfloyd: would it be easy to update the progress view w/ current progress in -resumeRefresh? [15:56:20] bgerstle: thats what i do now i believe [15:56:31] not seeing it [15:56:38] bgerstle: oh i think it is in viewDidAppear [15:56:48] maybe you need more saved pages? [15:56:53] coreyfloyd: could be that you're setting it to 0 in -resumeRefresh [15:57:01] i also turned on the link conditioner [15:57:07] coreyfloyd: nope, saw it w/ NLC [15:57:25] going back to Saved pages showed "Updating" w/ 0 progress. then when the next page downloaded, it bumped up to the current progress [15:57:53] coreyfloyd: so you're calling "resumeRefresh" in viewDidAppear [15:58:01] but, you're not grabbing the current progress from the fetcher [15:58:14] bgerstle: oh yeah -that is true - it isn't updated until the next thing fired [15:58:22] yep, that's what i saw [15:58:44] (03CR) 10Bgerstle: [C: 031] "not seeing the original bug, but would be nice to address the progress update on viewDidAppear issue here too." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196080 (owner: 10Fjalapeno) [15:58:53] bgerstle: but you are not seeing the bug that adam saw? [15:59:01] coreyfloyd: not the original one i reported, no [15:59:17] bgerstle: adams comment says the refresh button was always there [15:59:22] ohhhh [15:59:25] wasn't looking for that (durr) [15:59:36] uno momento por favor [15:59:50] bgerstle: sorry - should have been more clear [15:59:59] https://www.irccloud.com/pastebin/EQiYLjBT [16:00:07] right, it says the cancel button is always there [16:00:11] which isn't what i saw [16:00:29] (03CR) 10Phuedx: [C: 032] Properly extend Dialog C [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/195783 (owner: 10Bmansurov) [16:00:36] wait.. i'm sorta confused. isn't that what we want? [16:00:50] bgerstle: cool thanks for looking - might look at addressing your other comment [16:00:51] update continues in the background, when you come back, you can see the current progress and optionally cancel it [16:01:19] although coreyfloyd [16:01:29] maybe you could move from viewDid to viewWillAppear? [16:01:35] (03Merged) 10jenkins-bot: Properly extend Dialog C [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/195783 (owner: 10Bmansurov) [16:01:41] i'm noticing the switch from one to the other right after the modal transition [16:01:48] i.e. the view should already be in "Updating" as it's being presented [16:02:53] also, there are some instances where you're using 0.25 as the duration instead of [CATransaction animationDuration] [16:03:11] if we move the resumeRefresh to viewWillAppear, you might want to disable those animations too [16:03:54] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [PRODUCTION RELEASE BLOCKER] Verify data migrations work from old store release - https://phabricator.wikimedia.org/T91713#1113320 (10dr0ptp4kt) @Fjalapeno, thanks for examining. In addition to your verification that data migrations occur safely for same-b... [16:09:29] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [PRODUCTION RELEASE BLOCKER] Verify data migrations work from old store release - https://phabricator.wikimedia.org/T91713#1113361 (10BGerstle-WMF) @dr0pp4kt @Fjalapeno how are we verifying that the data migration occurred and was successful during testing?... [16:09:59] whatever we do next on Phab, can it please involve auto-completion for mentions? [16:11:12] bgerstle: ugh, I know, right? [16:11:23] i can't imagine your pain [16:11:33] Come on Phab, it's 2015... [16:16:03] coreyfloyd: dr0ptp4kt afk for lunch [16:16:13] bgerstle https://secure.phabricator.com/T3725 [16:18:26] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android: Some buttons are barely visible in the Toolbar on Android 4.4.4 - https://phabricator.wikimedia.org/T92510#1113405 (10Deskana) 3NEW [16:18:49] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Some buttons are barely visible in the Toolbar on Android 4.4.4 - https://phabricator.wikimedia.org/T92510#1113412 (10Deskana) [16:19:07] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [PRODUCTION RELEASE BLOCKER] Verify data migrations work from old store release - https://phabricator.wikimedia.org/T91713#1113414 (10dr0ptp4kt) @BGerstle-WMF , yeah. I looked at Saved pages, Recent, search history, and logged in state (and verified that an... [16:19:18] bgerstle_lunch: while i have a morning latte [16:20:51] supp [16:21:51] bgerstle_lunch, kristenlans: what's this "auto-completion" you speak of [16:21:57] (03CR) 10Deskana: [C: 031] "Looks nice!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196161 (https://phabricator.wikimedia.org/T91721) (owner: 10BearND) [16:21:59] just memorise everyone's damn handles [16:22:07] for /all/ methods of communication [16:22:11] come on you guys [16:22:12] jeez [16:22:28] brb [16:23:41] (03CR) 10Deskana: "If what I'm asking for takes more than literally two minutes to do, don't bother, just merge. :-)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196161 (https://phabricator.wikimedia.org/T91721) (owner: 10BearND) [16:28:32] coreyfloyd: water's shut off at the apartment. good excuse not to do dishes, or the best excuse? [16:28:52] lol - the best! [16:30:06] (03CR) 10BearND: "I'd prefer to do that in a follow-up patch. The concern here is that we would also need to ensure that the text snippet doesn't overlap th" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196161 (https://phabricator.wikimedia.org/T91721) (owner: 10BearND) [16:42:14] coreyfloyd: TDD for the win! [16:42:25] integrated paginator w/ a base case where the number of images <= batch size [16:42:30] seems to work as it did before [16:42:39] 💪 [16:42:46] nice [16:42:52] now to add tests for the edge cases... [16:43:02] or... get ready to leave for PT :-( [16:43:14] oh btw, i found out some interesting stuff about the HSA [16:43:16] do you have that ins plan? [16:45:34] coreyfloyd: dr0ptp4kt in case anyone wants to have a glance at my ongoing pagination work: https://github.com/btgerst/apps-ios-wikipedia/tree/image-gallery-pagination [16:46:16] see some mockin' and stubbin' and testin' in action [16:46:53] zero, one, many, oops [16:49:51] coreyfloyd: FYI really liking uncrustify as a pre-push hook [16:50:12] we should add one for unit tests.. jus' sayin' [16:51:57] (03PS15) 10Phuedx: New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 [16:54:53] (03CR) 10Dr0ptp4kt: [C: 04-1] Addresses Bug:T90606 Now using different url parameters for sharing types. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196243 (owner: 10Fjalapeno) [16:55:29] (03CR) 10Dr0ptp4kt: Addresses Bug:T90606 Now using different url parameters for sharing types. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196243 (owner: 10Fjalapeno) [16:56:04] (03CR) 10Phuedx: "@Bmansurov: needed a rebase! I recently changed the menu markup to a huh-tuh-muh-luh 5