[00:00:15] jdlrobson: which points ? In regards to the spinner? Did you read my comments? [00:00:21] bearND: Yeah, it was rotating that messed it up. [00:00:31] bearND: And yeah, I saw it. Been really busy today, so was planning on responding later. In short, I see no problems with us deploying it to Labs while we wait for it to be possible to deploy it to production. [00:00:49] Deskana: good [00:00:53] rmoen: reading now, missed those somehow [00:01:47] coreyfloyd: mhurd i'm wrapping up. see you tomorrow. tomorrow morning let's get the lead image, crash fix (or disable ios 6 refresh button), and nested parens patches merged. i'll get an early start coreyfloyd to update that nested parens patch [00:01:50] bearND: I would've preferred for us to skip that Labs step, but if our choices are Labs or nothing, we should do Labs. :-) [00:02:00] Deskana: heading out. see you tomorrow [00:02:08] bearND: This is insane, btw. Thanks for letting me know about it! [00:02:12] Deskana: agreed [00:02:43] jdlrobson: in regards to the spinner, I see no reason why to use those methods in the other overlay. The spinner works with very little code. [00:03:28] (03CR) 10Jdlrobson: A user can delete their own collection (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196055 (https://phabricator.wikimedia.org/T91776) (owner: 10Robmoen) [00:03:30] ^ rmoen reply [00:04:20] rmoen: i just think we should be internally consistent for Gather [00:05:07] there was also a comment i made not on the code itself asking whether the confirm message should be centered - did you ask moiz about that? [00:05:14] jdlrobson: I agree. At the moment it is consistent. Have you tested it? [00:05:41] rmoen: it isn't... when you add an item to watchlist the entire overlay is replaced with spinner [00:06:37] jdlrobson: ok well, I can refactor the entire overlay system and base my commit off it if that is what it takes to have this merged [00:06:57] all i'm saying is hide the buttons rather than disabling them [00:07:19] i'll just merge and do it myself. Won't take longer than 5 minutes [00:07:30] (03CR) 10Jdlrobson: [C: 032] A user can delete their own collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196055 (https://phabricator.wikimedia.org/T91776) (owner: 10Robmoen) [00:08:36] (03Merged) 10jenkins-bot: A user can delete their own collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196055 (https://phabricator.wikimedia.org/T91776) (owner: 10Robmoen) [00:10:11] jdlrobson: you don't have to do it yourself. My point was it could be in a separate commit. I agree about having consistent behavior. Honestly didn't realize what you were saying [00:10:38] it's fine if i'm not being clear it's probably just easier to do it myself :-) [00:10:41] jdlrobson: until your last response in the patch [00:14:09] (03CR) 10Alex Monk: [C: 032] Fix closing the media viewer [extensions/MobileFrontend] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196448 (https://phabricator.wikimedia.org/T92346) (owner: 10Bmansurov) [00:19:13] (03CR) 10jenkins-bot: [V: 04-1] Fix closing the media viewer [extensions/MobileFrontend] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196448 (https://phabricator.wikimedia.org/T92346) (owner: 10Bmansurov) [00:24:56] (03CR) 10MaxSem: [V: 032] "Jenkins being flappy again." [extensions/MobileFrontend] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196448 (https://phabricator.wikimedia.org/T92346) (owner: 10Bmansurov) [00:24:59] (03PS1) 10Jdlrobson: WIP: Create a base class for our content overlays [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196495 [00:26:01] (03CR) 10jenkins-bot: [V: 04-1] WIP: Create a base class for our content overlays [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196495 (owner: 10Jdlrobson) [00:34:20] (03PS2) 10Jdlrobson: Create a base class for our content overlays [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196495 [00:34:22] (03PS1) 10Jdlrobson: Run jscs on Jenkins [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196500 [00:36:51] (03PS3) 10Bmansurov: Alpha: Quickly lookup a brief info about a wiki page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195818 [00:37:37] (03CR) 10Jdlrobson: [C: 04-1] "Arggg Gruntfile not setup grrr" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196500 (owner: 10Jdlrobson) [00:38:10] 6Mobile-Web: [GlobalTitleFail] RequestContext::getTitle called by MobileContext::isBlacklistedPageInternal/ContextSource::getTitle/RequestContext::getTitle with no title set. - https://phabricator.wikimedia.org/T78414#1115473 (10kaldari) MobileFrontendHooks::onRequestContextCreateSkin() is the culprit. The Reque... [00:39:38] MaxSem: FYI ^ [00:39:58] ok rmoen i;m heading off for the day. My eyes are playing up again and my brain is fried :) [00:40:06] jdlrobson: ;/ [00:40:18] rmoen: just sending an update mail to gatherers [00:40:28] jdlrobson: cookies are good for your eyes [00:40:33] kaldari, do you have a stack trace? [00:40:40] jdlrobson: i feel you on the eyes. Take it easy. I'm playing with trying to get listpages to show other users collections [00:46:11] ok mail sent [00:46:17] heading out for beeerrzz [00:46:18] see yas [00:49:10] (03PS1) 10Robmoen: WIP: I should be able to view other users public lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196502 (https://phabricator.wikimedia.org/T92543) [00:49:15] (03CR) 10jenkins-bot: [V: 04-1] WIP: I should be able to view other users public lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196502 (https://phabricator.wikimedia.org/T92543) (owner: 10Robmoen) [00:52:42] (03CR) 10Robmoen: [C: 04-1] "Needs extension.json updates" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196495 (owner: 10Jdlrobson) [00:54:38] (03PS2) 10Robmoen: Report duplicate list label name error [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196485 (owner: 10Yurik) [00:55:02] (03CR) 10Robmoen: [C: 032] Report duplicate list label name error [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196485 (owner: 10Yurik) [00:58:05] (03Merged) 10jenkins-bot: Report duplicate list label name error [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196485 (owner: 10Yurik) [01:01:16] (03PS4) 10Bmansurov: Alpha: Quickly lookup a brief info about a wiki page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195818 [01:11:56] Deskana, did wmf-legal sign off on deliberately stripping out parts of sentences like that? [01:12:34] Krenair: Mobile web and apps have been stripping content for years. This is nothing new. [01:12:49] deliberately, parts of sentences? [01:13:41] Not parts of sentences, no. But that's no different than stripping other things. [01:14:11] What's the problem, exactly? [01:16:12] I don't have a particular problem with it, but I would be very careful about stripping out parts of text like that [01:18:42] 6Mobile-Web: [GlobalTitleFail] RequestContext::getTitle called by MobileContext::isBlacklistedPageInternal/ContextSource::getTitle/RequestContext::getTitle with no title set. - https://phabricator.wikimedia.org/T78414#1115557 (10MaxSem) <3 ApiHelp: ``` #0 /vagrant/mediawiki/extensions/MobileFrontend/includes/M... [01:20:15] Krenair: Absolutely. We're going to have to closely test the heuristic we use for it. [01:21:29] 6Mobile-Web: [GlobalTitleFail] RequestContext::getTitle called by MobileContext::isBlacklistedPageInternal/ContextSource::getTitle/RequestContext::getTitle with no title set. - https://phabricator.wikimedia.org/T78414#1115558 (10MaxSem) I'm tempted to just plug this with an entry point check, but instead I would... [01:29:44] (03PS1) 10Fjalapeno: (WIP) Adding common global macros, functions, and imports. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196509 [01:36:18] (03CR) 10Yurik: [C: 032] Hygiene: Remove unused api module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196283 (owner: 10Jdlrobson) [01:37:23] (03Merged) 10jenkins-bot: Hygiene: Remove unused api module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196283 (owner: 10Jdlrobson) [01:48:45] (03PS1) 10Fjalapeno: Fixing iOS 6 crash bug [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196517 [02:00:03] 10MobileFrontend-Feature-requests, 10UI-Standardization, 7Accessibility, 7Design, 7user-notice: Identify the best diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1115603 (10Quiddity) >>! In T90948#1100702, @Jdlrobson wrote: > Can we dig out this documentation and get it in the... [02:06:27] 10MobileFrontend-Feature-requests, 10UI-Standardization, 7Accessibility, 7Design, 7user-notice: Identify the best diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1115606 (10He7d3r) >>! In T90948#1115603, @Quiddity wrote: > A toggle at the top of the diff page, would be nice. :... [02:32:38] 10MobileFrontend-Feature-requests, 10UI-Standardization, 7Accessibility, 7Design, 7user-notice: Identify the best diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1115634 (10Quiddity) >>! In T90948#1115606, @He7d3r wrote: >>>! In T90948#1115603, @Quiddity wrote: >> A toggle at... [04:02:10] 6Mobile-Web, 10Living-Style-Guide, 10Tool-Labs: npm version on tools-login.wmflabs.org is incompatible with MobileFrontend package.json used by the KSS styleguide - https://phabricator.wikimedia.org/T89093#1115717 (10yuvipanda) 5Open>3Resolved a:3yuvipanda Use tools-trusty.wmflabs.org for newer version... [04:39:20] 6Mobile-Web, 5Patch-For-Review: MobileFrontend fails to enable Edit buttons when incorrectly mixing section levels - https://phabricator.wikimedia.org/T91186#1115739 (10Florian) 5Open>3Resolved [05:04:00] (03PS1) 10Deskana: Don't crash if the user clicks on an invalid URL. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196524 (https://phabricator.wikimedia.org/T89156) [06:08:49] (03PS21) 10Mhurd: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [07:02:18] 10MobileFrontend-Feature-requests, 10UI-Standardization, 7Accessibility, 7Design, 7user-notice: Identify the best diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1115858 (10Jaredzimmerman-WMF) - We can tweak the colors so they don't hurt readability. - Blue and Yellow are... [07:28:19] 10Wikipedia-App-Android-App: Android alpha app crashes when clicking edit. version 12.03.2015 - https://phabricator.wikimedia.org/T92607#1115887 (10Matanya) 3NEW [08:44:58] morning! [09:41:53] (03PS3) 10Jhernandez: Hygiene: Delete all code relating to user page storage [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196458 (https://phabricator.wikimedia.org/T92575) (owner: 10Jdlrobson) [09:51:40] morning joakino_ [09:51:46] hi phuedx [10:01:08] (03CR) 10Jhernandez: [C: 032] "Sad panda is sad https://38.media.tumblr.com/tumblr_m82johBhQv1rycz0wo1_500.gif" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196458 (https://phabricator.wikimedia.org/T92575) (owner: 10Jdlrobson) [10:01:56] (03PS2) 10Jhernandez: Restore page images on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196477 (https://phabricator.wikimedia.org/T92542) (owner: 10Jdlrobson) [10:02:09] (03Merged) 10jenkins-bot: Hygiene: Delete all code relating to user page storage [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196458 (https://phabricator.wikimedia.org/T92575) (owner: 10Jdlrobson) [10:05:38] (03CR) 10Jhernandez: [C: 032] Restore page images on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196477 (https://phabricator.wikimedia.org/T92542) (owner: 10Jdlrobson) [10:06:39] (03Merged) 10jenkins-bot: Restore page images on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196477 (https://phabricator.wikimedia.org/T92542) (owner: 10Jdlrobson) [10:13:35] 10MobileFrontend-Feature-requests, 6Commons: Mobile website should display super-categories on categories on Wikimedia Commons - https://phabricator.wikimedia.org/T78175#1116139 (10Steinsplitter) p:5Triage>3Low [10:20:18] (03PS1) 10Jhernandez: Fix side spacing for pre-content (page title) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196552 (https://phabricator.wikimedia.org/T92559) [10:22:37] (03PS18) 10Phuedx: New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 [10:24:22] (03CR) 10Phuedx: "*isn't a scalable solution* sorry." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [10:31:16] (03PS1) 10Jhernandez: Disable privacy checkbox when editing a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196556 (https://phabricator.wikimedia.org/T92569) [10:42:57] (03PS1) 10Jhernandez: Implement privacy label on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196561 (https://phabricator.wikimedia.org/T92587) [11:18:34] having set up 3 environments for end-to-end testing wikigrok, i feel that i'm getting pretty damn good at it now [11:42:34] (03CR) 10Phuedx: [C: 04-1] "As well as in the inline the box shadow should be removed as per the mock." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196324 (https://phabricator.wikimedia.org/T91141) (owner: 10Bmansurov) [12:02:05] phuedx: is it documentend? [12:02:16] yeahhhp [12:02:26] not on wiki -- working on it [12:02:38] but i have notes in a gist [12:08:30] 10Wikipedia-App-General-or-Unknown: Adding buttons to support many programming languages - suggeston - https://phabricator.wikimedia.org/T92617#1116400 (10Ran_Cohen) 3NEW [12:12:12] phuedx: cool! just link to it from http://www.mediawiki.org/wiki/Extension:WikiGrok maybe at some point [12:12:27] joakino: noted [12:12:45] gonna have some lunch [12:54:47] (03PS1) 10Yurik: API ownershir/permissions implementation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196575 [12:55:03] joakino_, ^ ) [12:55:33] yurik: cool! [12:56:27] back [12:56:39] joakino_, could you try it out, see if you can spot anything? [12:57:10] yurik: yep, i'll have a look [12:59:54] joakino, btw, you might want to get cloaked - your ip is showing :) [13:00:30] yurik: ye i have to get around to that [13:00:41] yep, patch first)) [13:00:42] yurik: i filled a form but i don't remember if i did anything else [13:04:07] yurik: so if you edit the watchlist a new entry is created? [13:04:28] joakino, if you edit meta info about the watchlis [13:04:33] not pages add/remove [13:04:49] its transparent to you (should be) [13:05:12] you will still see only one "watchlist" entry [13:05:20] it will simply gain an extra id [13:05:26] yurik: they may have objections to the watchlist meta editing, they made me disable the title/description editing on the UI [13:05:40] title cannot be edited [13:05:47] description - up to you ) [13:06:59] i should probably return "iswatchlist" value to indicate that you can't edit the label [13:12:16] yurik: i'm trying in the api sandbox to do label=Ass&perm=private&description=Assssssss&titles=Burrito&token=28e5c3037cff736b703ab5c42a936cbf5502e1ec%2B%5C%5C with the token i got from http://localhost:8080/w/api.php?action=query&meta=tokens&type=watch but i'm getting invalid token [13:12:26] do i have to copy the token in a way? [13:12:46] you copied the token wrong [13:12:58] token should end with %2B\ [13:13:05] in the uri encoding [13:13:41] joakino, ^ [13:13:53] it seems you have copied an extra backslash [13:14:40] yurik: i copied the 28e5c3037cff736b703ab5c42a936cbf5502e1ec+\\ like that in the input [13:15:04] joakino, you forgot that the token is returned inside JSON [13:15:06] yurik: oki the double slash \\ [13:15:14] so \\ -> \ [13:15:18] yurik: yep it's scaping it, sorry [13:18:53] (03PS2) 10Yurik: API ownershir/permissions implementation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196575 [13:20:34] yurik: cool xD, editlist works good on watchlists and non-watchlists [13:20:52] joakino, minor update - please re-get [13:21:00] will show "watchlist":1 [13:22:13] http://i.imgur.com/pRGY0wG.png [13:22:15] ok [13:24:32] yurik: is there a way to get the new lists and the new items in lists from old to new? [13:24:54] how are they sorteD? [13:25:39] (03CR) 10Phuedx: [C: 032] Use view events [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/195772 (https://phabricator.wikimedia.org/T88296) (owner: 10Bmansurov) [13:25:43] joakino, lists - by label, listpages - by sortorder (currently simply adds at the bottom, but i have a plan to change that) [13:25:58] 6Mobile-Web, 10WikiGrok: WikiGrokDialogs not using View##event - https://phabricator.wikimedia.org/T88296#1116501 (10phuedx) [13:26:06] 6Mobile-Web, 10WikiGrok: WikiGrokDialogs not using View##event - https://phabricator.wikimedia.org/T88296#1116502 (10phuedx) 5Open>3Resolved a:3phuedx [13:26:09] yurik: ah ok, that'll be useful when we implement reordering [13:26:29] yurik: the lists are watchlist + labelorder right? [13:26:41] yes, it should be fairly easy to do "for these titles, position them after title X" [13:26:43] (03Merged) 10jenkins-bot: Use view events [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/195772 (https://phabricator.wikimedia.org/T88296) (owner: 10Bmansurov) [13:26:50] so you can do grop reorg [13:27:11] it takes 4 steps to close a task through merging [13:28:10] yurik: gotta go to lunch, sister is yelling at me [13:28:22] learn to yell back [13:28:22] yurik: i'll continue testing it later, it's a bit cumbersome :p [13:28:36] yeah [13:28:41] yurik: if I do it scales up quickly and women win [13:28:48] hehe [13:37:27] (03PS1) 10Sumit: MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) [13:41:08] (03CR) 10jenkins-bot: [V: 04-1] MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [13:48:24] (03CR) 10Florianschmidtwelzow: [C: 04-1] "I'm not an UI designer, but wouldn't it be possible to just truncate the text (we have a truncated-text css class) to trim the message aft" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [13:49:06] (03PS2) 10Sumit: MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) [13:49:20] (03CR) 10jenkins-bot: [V: 04-1] MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [13:50:53] (03CR) 10Sumit: [C: 04-1] "@Florian, alright, I'll change the way the truncation is done :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [13:54:00] English moment: "answer" is such a weird word [13:54:21] why is there a "W" in there? [14:11:20] bgerstle: the "swer" comes from the word swerian, to swear [14:11:41] bgerstle: http://www.etymonline.com/index.php?term=answer [14:11:48] phuedx: i don't care about history. we're cutting out the "X" and not looking back [14:11:52] "W"** [14:12:04] etymology is awesome [14:12:14] i think the x was cut out of answer some time ago [14:13:57] (03CR) 10Sumit: MediaViewer image description trimmed (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [14:14:14] phuedx: ಠ~ಠ [14:26:22] (03PS1) 10Yurik: Added article counts for list=lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196578 (https://phabricator.wikimedia.org/T92530) [14:26:29] joakino, ^ [14:28:33] (03PS2) 10Dbrant: Tweak layout for Share A Fact [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196161 (https://phabricator.wikimedia.org/T91721) (owner: 10BearND) [14:55:54] (03CR) 10Dbrant: [C: 032] Tweak layout for Share A Fact [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196161 (https://phabricator.wikimedia.org/T91721) (owner: 10BearND) [14:57:55] (03Merged) 10jenkins-bot: Tweak layout for Share A Fact [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196161 (https://phabricator.wikimedia.org/T91721) (owner: 10BearND) [14:59:14] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Some buttons are barely visible in the Toolbar on Android 4.4.4 - https://phabricator.wikimedia.org/T92510#1116660 (10Dbrant) a:3Dbrant [15:14:06] (03CR) 10Dbrant: [C: 032] Don't crash if the user clicks on an invalid URL. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196524 (https://phabricator.wikimedia.org/T89156) (owner: 10Deskana) [15:14:27] yurik: is it possible that I've seen a -1 in the count of an empty collection? https://gerrit.wikimedia.org/r/#/c/196578/ [15:14:40] joakino_, yes, for the watchlist [15:14:54] joakino_, come to think of it, it shoud be 0 [15:14:55] sec [15:15:05] yurik: also for normal collection [15:15:24] yurik: i added an item to a collection, removed it to leave the collection empty and the count is -1 :P [15:16:02] (03PS2) 10Yurik: Added article counts for list=lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196578 (https://phabricator.wikimedia.org/T92530) [15:16:04] joakino_, fixed [15:17:21] yurik: yep! [15:17:40] joakino_, what do you need for the image? [15:17:46] just to store a string? [15:17:55] 10Wikipedia-App-Android-App: Android alpha app crashes when clicking edit. version 12.03.2015 - https://phabricator.wikimedia.org/T92607#1116692 (10Dbrant) 5Open>3Resolved a:3Dbrant fixed by https://gerrit.wikimedia.org/r/196265 [15:18:36] yurik: file name can work, having file name, dimensions and url would be great [15:18:42] something like that [15:18:57] joakino_, file from the wiki? [15:19:22] kristenlans: hey, are we still on for health check next thursday? [15:19:30] just wanted to double check [15:20:07] yurik: in the php we are doing a wfFindFile with the file title from the wiki [15:20:29] yurik: for the JS consuming having filename, dimensions and url would be useful [15:21:31] for the count patch do you want anybody else to have a look? seems good to me (but i'm not well versed on backend) [15:22:34] joakino_, noone is well versed )) [15:22:37] merge it )) [15:22:45] and i can rebase the other patch off of it [15:22:54] joakino_, or merge the other patch first [15:23:05] this way i will fix count to work properly with other user's data [15:23:11] 10Wikipedia-App-Android-App, 5Patch-For-Review: Crash when clicking a link with a percent sign - https://phabricator.wikimedia.org/T89156#1116711 (10Deskana) 5Open>3Resolved a:3Deskana The solution we went for is kind of naive, but fixing the underlying problem is hard. At least the app won't crash any m... [15:23:20] yurik: let me continue testing the other one [15:23:25] ok [15:23:40] bgerstle: that is correct [15:24:17] k [15:25:14] (03CR) 10Jhernandez: [C: 031] "Reviewin' https://gerrit.wikimedia.org/r/#/c/196575/ first, but looks good" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196578 (https://phabricator.wikimedia.org/T92530) (owner: 10Yurik) [15:29:50] yurik: so for listpages, if i want to get the pages of a user's list, how do i get the lsptoken [15:30:09] yurik: can you update docs when you have a minute? I find them very useful https://www.mediawiki.org/wiki/Mobile_web_projects/Collections_Backend#action.3Deditlist [15:30:11] joakino_, you don't need the token for the public stuff [15:30:17] yurik: yea that works [15:32:02] joakino_, https://www.mediawiki.org/wiki/Special:Preferences#mw-prefsection-watchlist [15:32:40] yurik: ? [15:32:46] what do i do with that [15:32:47] that's your token [15:32:58] at least for the mediawiki [15:33:02] ah ok [15:33:31] yurik: so how do i get the items on a user's list? (public) this asks me for a token action=query&list=listpages&format=json&lspid=4&lspowner=User [15:34:01] joakino_, don't set the owner [15:34:44] i'm a bit unsure at this point if i should even allow owner without the token in this case [15:39:06] yurik: if the id is global to all lists then just id is fine [15:39:19] lists default to private right [15:39:20] joakino_, yep, it is global [15:39:33] joakino_, what do you mean about private? [15:40:48] yurik: if you don't specify anything when creating a list it is private [15:40:57] yep [15:45:01] yurik: why the rename from public to perm? [15:45:20] joakino_, because public=0 is true :( [15:45:27] and so is public=1 [15:45:30] if public is bool [15:45:42] plus it will allow us to have private lists for multiple users [15:45:46] if we decide to [15:45:58] k [15:51:58] kristenlans: am i needed at the android estimation? [15:52:06] kristenlans: ....and, good morning [15:55:29] yurik: fix the phpcs lint errors and i'll merge https://integration.wikimedia.org/ci/job/mwext-Gather-phpcs-HEAD/453/console [15:56:20] dr0ptp4kt: good morning! I do not think you are technically needed at the android estimation. I can't remember if we were going to try to get tech leads at both estimation meetings for some crossover? :P [15:56:25] joakino_, nah, these are bad - it doesn't know that things might need to be lined up with tabs+spaces [15:56:25] https://gerrit.wikimedia.org/r/#/c/196575 [15:56:47] the long lines can be fixed, but tabs i prefer the way phpstorm does them ) [15:57:18] kristenlans: thx. dbrant, do you recall on the last-friday-of-the-sprint estimation meetings if we were planning to have us both attend both android and ios? [15:57:25] yurik: i'd rather not have phpcs failing forever :( [15:57:33] kristenlans: dbrant, i'm gonna grab a coffee. bbiab [15:57:33] then it becomes pointless [15:57:43] joakino_, it is pointless imho )) [15:59:11] yurik: probably, but ATM we are using it [15:59:27] yurik: we can discuss with the team to remove it [15:59:38] dr0ptp4kt: kristenlans: i think it's ok if we just attend our respective platform meetings. [16:00:13] (for the record i hate mediawiki conventions and putting spaces everywhere, but phpcs kindof helps with that) [16:00:56] joakino_, phpstorm can be set up to observe those conventions [16:01:06] its the tabs+spaces that its having issues with [16:01:57] joakino_, from this url, what do you need? [16:02:03] http://en.wikipedia.org/w/api.php?action=query&titles=File:Albert%20Einstein%20Head.jpg&prop=imageinfo&iiprop=archivename|bitdepth|canonicaltitle|comment|commonmetadata|dimensions|extmetadata|iiprop|mediatype|metadata|meters:|mime|parsedcomment|sha1|size|thumbmime|timestamp|uploadwarning|url|user|userid [16:04:01] yurik: for the moment I think that width, height, url and canonicaltitle [16:04:30] sith canonicaltitle we get the Image object on php with wfFindFile and with the url, width, and height we can display the image from the JS [16:05:11] (03PS1) 10BearND: Fix issue where the bottom portion of About screen was white in dark mode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196586 [16:05:31] dbrant, kristenlans : works for me [16:05:52] (03PS1) 10Dbrant: Fix action mode menu item color. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196587 (https://phabricator.wikimedia.org/T92510) [16:06:03] dbrant: dr0ptp4kt me too :-) [16:06:17] (03CR) 10jenkins-bot: [V: 04-1] Fix action mode menu item color. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196587 (https://phabricator.wikimedia.org/T92510) (owner: 10Dbrant) [16:06:54] (03PS2) 10Dbrant: Fix action mode menu item color. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196587 (https://phabricator.wikimedia.org/T92510) [16:07:47] dr0ptp4kt, dbrant: I kind of wanted to have you both there for both of them, but I think it's reasonable to try it without and see whether that's a theoretical need or a practical one. :-) [16:08:19] yurik: i'm fixing the phpcs issues and merging, is that ok? [16:08:35] Deskana: thank you [16:08:57] Deska [16:09:00] haha [16:09:09] Deskana: those were my thoughts as well [16:09:14] keep it lean [16:09:39] ok [16:09:39] Deska [16:09:41] Deska [16:09:48] DESHANK IN DA HOUUUSE [16:09:50] (03PS3) 10Jhernandez: API ownershir/permissions implementation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196575 (owner: 10Yurik) [16:09:58] Wat! aww yeah! [16:11:07] (03CR) 10Jhernandez: [C: 032] API ownershir/permissions implementation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196575 (owner: 10Yurik) [16:11:29] joakino_, once merged, i will rebase count [16:12:17] (03Merged) 10jenkins-bot: API ownershir/permissions implementation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196575 (owner: 10Yurik) [16:12:35] ducking wifi [16:13:16] yurik: want to tackle the watchlist count thing in this one so that we can merge? https://gerrit.wikimedia.org/r/#/c/196578/ [16:13:33] ?? [16:13:38] i will rebase count in a sec [16:20:05] (03CR) 10Dr0ptp4kt: [C: 032] Fixing iOS 6 crash bug [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196517 (owner: 10Fjalapeno) [16:20:59] (03PS3) 10Dbrant: Fix action mode menu item color. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196587 (https://phabricator.wikimedia.org/T92510) [16:24:08] bgerstle: how's it looking for https://phabricator.wikimedia.org/T91124 and https://phabricator.wikimedia.org/T91313 for merge by 3 pm eastern time (12 pm san francisco)? [16:24:37] this requires pagination to fix, so might not be likely [16:24:58] coreyfloyd: bgerstle , would you please review https://gerrit.wikimedia.org/r/#/c/193323/ if you haven't started on that? [16:25:06] bgerstle: for both of those? [16:25:37] dr0ptp4kt: i haven't even started on RTL flipping [16:26:04] Sure [16:26:10] dr0ptp4kt: if i review 193323 i won't have time to do anything else. [16:26:24] looks like corey's on top of it [16:26:41] would i be the second reviewer? [16:26:55] (aside from jenkins-bot, but he doesn't count...yet) [16:27:21] bgerstle: able to do a quick video call? [16:28:33] sure [16:47:56] hey joakino thanks for the mail [16:48:03] looks like you had a busy productive day :) [16:48:37] morning jdlrobson [16:48:40] pretty hands on [16:49:56] :D [16:50:48] oohh db storage on beta labs now?! [16:51:12] (03PS4) 10Dr0ptp4kt: Address nested parentheses in Share a Fact [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196298 [16:52:06] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: [PRODUCTION RELEASE BLOCKER] Verify data migrations work from old store release - https://phabricator.wikimedia.org/T91713#1116887 (10dr0ptp4kt) I emailed internal TestFlight users about smoketesting the upgrade process. [16:54:12] (03CR) 10Jdlrobson: Fix side spacing for pre-content (page title) (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196552 (https://phabricator.wikimedia.org/T92559) (owner: 10Jhernandez) [16:54:14] ^ joakino [16:55:05] jdlrobson: you mean in MF? [16:55:18] yeh i'm not sure what's going on but we seem like we are fighting defaults [16:55:33] and i wonder if there is a better way to do it by letting MF take care of it [16:55:36] jdlrobson: yea the special page defaults on the header of the page are very weird [16:56:07] jdlrobson: all that css should probably go to MF and contest the design of gather vs other special pages with and without the changes to designers and have them choose [16:56:16] to make them consistent [16:56:41] (03CR) 10Jdlrobson: [C: 04-1] "It should always be disabled as right now we don't want to support the UI of toggling privacy status" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196556 (https://phabricator.wikimedia.org/T92569) (owner: 10Jhernandez) [16:57:27] jdlrobson: about ^, collections are private by default, i commented on the phab issue, so nothing will be seen [16:57:41] (by other people i mean [16:57:49] joakino: yeh so it sounds like we need the backend change? :) [16:58:18] (03CR) 10Jdlrobson: [C: 032] Implement privacy label on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196561 (https://phabricator.wikimedia.org/T92587) (owner: 10Jhernandez) [16:58:33] joakino: Jon's main concern was just making the ui possible to interact with [16:58:44] that's not in the MVP and we want to use it for moderation [16:59:06] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Wikipedia Android is contributed anonymous if username is in Korean - https://phabricator.wikimedia.org/T90428#1116893 (10bearND) a:3bearND [16:59:23] (03Merged) 10jenkins-bot: Implement privacy label on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196561 (https://phabricator.wikimedia.org/T92587) (owner: 10Jhernandez) [17:00:12] (03PS3) 10Yurik: Added article counts for list=lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196578 (https://phabricator.wikimedia.org/T92530) [17:00:16] joakino, % [17:00:19] ^ [17:00:40] k yurik [17:00:49] (03PS2) 10Bmansurov: Fix styling regression in new editor tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196324 (https://phabricator.wikimedia.org/T91141) [17:01:03] (03CR) 10Bmansurov: Fix styling regression in new editor tutorial (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196324 (https://phabricator.wikimedia.org/T91141) (owner: 10Bmansurov) [17:05:27] * FlorianSW waves around :D [17:07:50] kristenlans: you have to say "that would be GREAT" officespace style [17:07:52] (03PS2) 10Jdlrobson: I should be able to view other users public lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196502 (https://phabricator.wikimedia.org/T92543) (owner: 10Robmoen) [17:07:54] (03CR) 10jenkins-bot: [V: 04-1] I should be able to view other users public lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196502 (https://phabricator.wikimedia.org/T92543) (owner: 10Robmoen) [17:08:39] 6Mobile-Web, 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: Hover styles differ between MediaWiki UI buttons and OOjs UI buttons - https://phabricator.wikimedia.org/T92566#1116920 (10bmansurov) I vote for MediaWiki UI! [17:10:26] yurik: i have 10 articles in the watchlist but it's reporting 62 xD [17:10:38] 6Mobile-Web: MobileFrontend strips colours from a table on colours - https://phabricator.wikimedia.org/T87719#1116925 (10KLans_WMF) a:3bmansurov [17:11:15] (03CR) 10Bgerstle: [C: 04-1] "A lot of this is good, but I'd like to spend some time to go in and remove what I think are unnecessary abstractions on top of assertions/" (039 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196509 (owner: 10Fjalapeno) [17:11:20] joakino, its counting the "hidden" ones :)) [17:11:22] dono [17:11:40] 6Mobile-Web, 10MediaWiki-Special-pages, 7Mobile: Special:UserProfile not listed in Special:SpecialPages - https://phabricator.wikimedia.org/T87756#1116936 (10KLans_WMF) a:3MaxSem [17:13:59] (03PS3) 10Jdlrobson: WIP: I should be able to view other users public lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196502 (https://phabricator.wikimedia.org/T92543) (owner: 10Robmoen) [17:14:14] (03CR) 10Jdlrobson: [C: 04-1] "[d401dbb6] /wiki/Special:Gather/Bugsboxed UsageException from line 1306 of /vagrant/mediawiki/includes/api/ApiBase.php: Incorrect watchlis" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196502 (https://phabricator.wikimedia.org/T92543) (owner: 10Robmoen) [17:15:52] (03CR) 10Bgerstle: "MWKImage stuff looks good! Any chance we can separate that into a different patch for quick merge, then rebase this one on top? If there'" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [17:17:01] coreyfloyd: [17:17:11] sup? [17:17:14] oh standup! [17:18:38] what would be the equivalent of .on( 'click', $.proxy( this, 'emit', 'submit' ) using events map? [17:18:53] (03PS2) 10Jhernandez: Disable privacy checkbox when editing a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196556 (https://phabricator.wikimedia.org/T92569) [17:20:23] (03PS2) 10Jhernandez: Fix side spacing for pre-content (page title) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196552 (https://phabricator.wikimedia.org/T92559) [17:20:37] jdlrobson: ^ *2 [17:23:36] 6Mobile-Web, 10MediaWiki-Special-pages, 7Mobile: Special:UserProfile not listed in Special:SpecialPages - https://phabricator.wikimedia.org/T87756#1116981 (10MaxSem) 5Open>3declined This is intentional. Not every page should be listed, and we definitely dont want to expose it more while its mere existenc... [17:24:46] (03CR) 10Jdlrobson: [C: 032] Fix side spacing for pre-content (page title) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196552 (https://phabricator.wikimedia.org/T92559) (owner: 10Jhernandez) [17:25:06] (03CR) 10Jdlrobson: [C: 032] Disable privacy checkbox when editing a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196556 (https://phabricator.wikimedia.org/T92569) (owner: 10Jhernandez) [17:25:55] (03Merged) 10jenkins-bot: Fix side spacing for pre-content (page title) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196552 (https://phabricator.wikimedia.org/T92559) (owner: 10Jhernandez) [17:26:10] (03Merged) 10jenkins-bot: Disable privacy checkbox when editing a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196556 (https://phabricator.wikimedia.org/T92569) (owner: 10Jhernandez) [17:31:51] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Wikipedia Android is contributed anonymous if username is in Korean - https://phabricator.wikimedia.org/T90428#1117025 (10bearND) I cannot reproduce the issue with a Korean user name, see https://test.wikipedia.org/w/index.php?title=Test&diff=223933... [17:31:53] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196604 [17:32:42] 10Wikipedia-App-Android-App: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#764856 (10bearND) [17:32:43] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Wikipedia Android is contributed anonymous if username is in Korean - https://phabricator.wikimedia.org/T90428#1117029 (10bearND) [17:33:45] (03PS22) 10Mhurd: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 [17:38:05] (03CR) 10Bmansurov: [C: 04-1] "Everything looks great except /wiki/Special:MobileMenu is empty in stable when javascript is disabled. But, /wiki/Special:MobileMenu?mobil" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [17:39:08] bmansurov: ^ ??!?? [17:39:40] phuedx: i know, can you also reproduce it? [17:40:28] yurik: you there? [17:40:36] jdlrobson, yep [17:40:39] just added the images [17:40:42] fixing the counting bug [17:40:44] so the public/private stuff is all whacky [17:40:58] there is a bug in there that i already fixed too :) [17:41:02] sorry about that [17:41:03] is there any reason it wasn't implemented as a column [17:41:08] (Boolean) [17:41:09] (03CR) 10Florianschmidtwelzow: [C: 04-1] New-ish Special:MobileMenu page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [17:41:11] bmansurov, phuedx ^^ [17:41:13] oh gerrit, why are you showing me so many files when there's ZERO DIFF [17:41:14] a number of reasons [17:41:22] i guess they were changed in a previous patch set [17:41:24] 1) we don't know its going to be a boolean just yet [17:41:26] (03PS4) 10Jdlrobson: I should be able to view other users public lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196502 (https://phabricator.wikimedia.org/T92543) (owner: 10Robmoen) [17:41:28] (03PS1) 10Jdlrobson: Make new collections public by default [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196607 (https://phabricator.wikimedia.org/T92641) [17:41:38] it could be permission list (my friends can see it, etc) [17:41:45] FlorianSW: good catch! [17:41:46] after a bit, we can always migrate [17:41:55] bmansurov: that's what the bug is [17:42:30] yurik: i'm seeing entries in gl_info which use 'public': true and others that use "perm" private [17:42:31] it's confusing [17:42:47] 10MobileFrontend-Feature-requests, 10UI-Standardization, 7Accessibility, 7Design, 7user-notice: Identify the best diff style and use it everywhere - https://phabricator.wikimedia.org/T90948#1117075 (10Nemo_bis) [17:43:03] jdlrobson, yes, but that's only in dev, and i will clean them up soon [17:43:08] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-Android: As a user, I'd like lead sentences to be consistent so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1117077 (10KLans_WMF) [17:43:21] sec, let me finish with the patch, should fix many minor bugs [17:43:23] just the UI is working off 'public' [17:43:32] will need to refactor a bunch to get that working again [17:44:00] jdlrobson, there is a bug/feature in the core api that doesnot allow you to use a boolean parameter with false [17:44:11] it is either "present" (true), or "missing" (false) [17:44:26] which broke our model of only updating those things that are given as a parameter [17:44:31] thus, needed a different way [17:44:50] plus it lets us do things like "perm=customlist" ) [17:44:55] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-Android: As a user, I'd like lead sentences to be consistent so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1117091 (10Deskana) [17:44:56] admins, etc [17:45:01] or my friends [17:45:09] lots of more stuff is possible [17:45:18] bgerstle: if possible, i’d rather just get this lead image stuff merged rather than picking out the MWK bits :) [17:46:02] mhurd: sure, i haven't seen any major issues in your patch so far, but if this does need to go through another round or so, it would take me only a minute to factor it out and rebase your patch [17:46:03] yurik: let me know when you've fixed that then :) api is reporting all lists as private [17:46:13] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-Android: As a user, I'd like lead sentences to be consistent so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1096410 (10Deskana) [17:46:20] just wanted to offer it as an option [17:46:25] i'd like to get this merged too :-) [17:46:50] bgerstle: this has been though so many rounds already [17:47:04] bgerstle: my entire week has been rounds :) [17:47:17] i hear ya, which is why i'm only looking for show-stoppers [17:47:41] (03CR) 10Jdlrobson: [C: 04-1] "API is returning all lists as public blocked on https://phabricator.wikimedia.org/T92644" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196502 (https://phabricator.wikimedia.org/T92543) (owner: 10Robmoen) [17:47:42] bgerstle: the present state of lead image perfomance is a definite show stopper [17:47:45] all my comments so far are FYI or Did You Know That: kinda comments [17:47:50] lol [17:48:22] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-Android: As a user, I'd like lead sentences to be consistent so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1117109 (10KLans_WMF) [17:48:44] (03CR) 10Jdlrobson: "where's the perm patch?" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196578 (https://phabricator.wikimedia.org/T92530) (owner: 10Yurik) [17:48:49] (03PS4) 10Jdlrobson: Added article counts for list=lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196578 (https://phabricator.wikimedia.org/T92530) (owner: 10Yurik) [17:49:17] (03Abandoned) 10Jdlrobson: WIP: Describe API requests for adding/removing items for collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194404 (owner: 10Jdlrobson) [17:49:49] yurik: also claim cards in phabricator having trouble knowing what you are working on [17:50:44] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Services, 3Mobile-App-Sprint-53-Android: Deploy experimental version of mobile apps content service - https://phabricator.wikimedia.org/T91794#1117133 (10Deskana) [17:51:23] (03CR) 10Mhurd: [C: 032] Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196604 (owner: 10BearND) [17:51:31] dr0ptp4kt: ^ [17:51:56] (03PS5) 10Jdlrobson: Added article counts for list=lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196578 (https://phabricator.wikimedia.org/T92530) (owner: 10Yurik) [17:52:13] (03PS1) 10Sumit: PhotoUploadOverlay and Progress use View##event [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196609 (https://phabricator.wikimedia.org/T88568) [17:52:33] 6Mobile-Web: MobileFrontend strips colours from a table on colours - https://phabricator.wikimedia.org/T87719#1117153 (10bmansurov) @Nemo_bis, here are the two screenshots taken from the mobile and desktop sites respectively. Aside from the table borders I don't see much difference. Can you clarify what you mean... [17:52:35] (03CR) 10Jdlrobson: [C: 032] Added article counts for list=lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196578 (https://phabricator.wikimedia.org/T92530) (owner: 10Yurik) [17:53:01] mhurd: thx [17:53:40] (03Merged) 10jenkins-bot: Added article counts for list=lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196578 (https://phabricator.wikimedia.org/T92530) (owner: 10Yurik) [17:54:52] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Services, 3Mobile-App-Sprint-53-Android: Deploy experimental version of mobile apps content service - https://phabricator.wikimedia.org/T91794#1117165 (10KLans_WMF) [17:54:55] bgerstle: coreyfloyd dr0ptp4kt thoughts on switching our compiler release optimization level to ‘-Ofast’ ? [17:55:08] mhurd: what is it now? [17:55:22] bgerstle: fastest -O3 [17:55:55] bgerstle: -Ofast - “Fastest, Aggressive Optimizations: This setting enables 'Fastest' but also enables aggressive optimizations that may break strict standards compliance but should work well on well-behaved code." [17:56:10] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android: Epic: Onboarding, both generally and for Tweet A Fact - https://phabricator.wikimedia.org/T89985#1117167 (10KLans_WMF) [17:56:11] mhurd: right, i'm familiar with the settings.. [17:56:20] i would prefer that we wait [17:56:24] bgerstle: cool [17:56:27] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android: BLCKED: As an engaged reader, I'd like to know that I can share cards with interesting facts on. - https://phabricator.wikimedia.org/T89988#1117168 (10KLans_WMF) [17:56:28] the less we can change at this point, the better [17:56:35] definitely something to look into soon, though [17:56:45] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android: As a product owner, I'd like to know how well the Tweet A Fact onboarding did at exposing users to the feature - https://phabricator.wikimedia.org/T89989#1117169 (10KLans_WMF) [17:56:47] not sure why we *lowered* the setting to -O3 in the first palce [17:56:53] bgerstle: maybe next testflight release or something... [17:57:03] mhurd yeah [17:57:08] bgerstle: yeah i thought it was 0fast [17:57:18] bgerstle: could be mis-remembering thought [17:57:22] *though* [17:59:18] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android: Hook app up to experimental content service to test the service's viability [NEEDS MORE DEFINITION] - https://phabricator.wikimedia.org/T91798#1117186 (10Deskana) [17:59:32] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android: Hook app up to experimental content service to test the service's viability [NEEDS MORE DEFINITION] - https://phabricator.wikimedia.org/T91798#1096495 (10Deskana) [17:59:34] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android: Hook app up to experimental content service to test the service's viability [NEEDS MORE DEFINITION] - https://phabricator.wikimedia.org/T91798#1117190 (10KLans_WMF) [18:00:50] (03PS1) 10Yurik: Added article counts and images, bugfixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196610 (https://phabricator.wikimedia.org/T92530) [18:01:02] jdlrobson, ^ [18:01:03] let me tell you [18:01:15] toilets that actually flush are awesome [18:02:07] bgerstle: coreyfloydestimation [18:02:15] bah, sorry [18:02:23] (03CR) 10Jdlrobson: [C: 04-1] "Minor tweaks and this looks like it will be good to go! :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196609 (https://phabricator.wikimedia.org/T88568) (owner: 10Sumit) [18:03:13] (03PS2) 10Yurik: Added article counts and images, bugfixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196610 (https://phabricator.wikimedia.org/T92530) [18:04:41] jdlrobson, around? [18:04:44] (03PS58) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [18:05:02] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: iOS 6.1.3 4S refresh button freezes / crashes app - https://phabricator.wikimedia.org/T92584#1115366 (10dr0ptp4kt) [18:05:03] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196611 [18:05:09] (03PS19) 10Phuedx: New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 [18:05:19] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: iOS 6.1.3 4S refresh button freezes / crashes app - https://phabricator.wikimedia.org/T92584#1117215 (10dr0ptp4kt) 5Open>3Resolved [18:05:38] kaldari, phuedx: please provide your suggestions of future queries we might need today so that I could take them into account. otherwise, I will think my schema is perfect and get megalomaniacal:P [18:07:06] (03CR) 10Phuedx: "Yowza!!!1one Good catch @Bmansurov/@Florianschmidtwelzow!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [18:08:15] (03PS2) 10Sumit: PhotoUploadOverlay and Progress use View##event [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196609 (https://phabricator.wikimedia.org/T88568) [18:09:00] (03CR) 10Bmansurov: [C: 031] "I'll wait to see if someone else is also willing to review. If not, I'll merge later today." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [18:10:11] bmansurov: in the mocks the tutorial no longer has a box shadow [18:10:20] also, ta [18:10:33] phuedx: ok i'll remove it [18:10:37] bmansurov: sorry, for context, i'm talking about: https://gerrit.wikimedia.org/r/#/c/196324/2 [18:10:49] other than that +1 would review again [18:10:55] got it [18:11:41] (03CR) 10BearND: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196611 (owner: 10BearND) [18:12:16] (03CR) 10Florianschmidtwelzow: [C: 04-1] "breaks Font changer feature*, would you like to fix it here or in a follow up? :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [18:13:21] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196611 (owner: 10BearND) [18:13:23] (03PS3) 10Bmansurov: Fix styling regression in new editor tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196324 (https://phabricator.wikimedia.org/T91141) [18:13:25] phuedx: ^ [18:14:40] bmansurov: checking -- then i'll take a quick look at the font changer FlorianSW [18:14:50] cool [18:15:29] phuedx, bmansurov: it's a feature in alpha, so i would be ok with merging it, but with a fast follow up for font changer :) [18:16:41] (03CR) 10Yurik: [C: 032] Make new collections public by default [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196607 (https://phabricator.wikimedia.org/T92641) (owner: 10Jdlrobson) [18:16:49] bmansurov: take a look at the tutorial overlay in alpha/beta [18:17:00] looks like the css selector targeting the buttons is too specific [18:17:13] (or you could use mw-ui-button) [18:17:18] phuedx: ok [18:17:46] (03Merged) 10jenkins-bot: Make new collections public by default [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196607 (https://phabricator.wikimedia.org/T92641) (owner: 10Jdlrobson) [18:18:14] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Get iOS build server set up and serving alpha builds internally - https://phabricator.wikimedia.org/T91786#1117262 (10Deskana) [18:18:17] (03PS3) 10Jdlrobson: Added article counts and images, bugfixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196610 (https://phabricator.wikimedia.org/T92530) (owner: 10Yurik) [18:18:53] (03PS4) 10Yurik: Added article counts and images, bugfixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196610 (https://phabricator.wikimedia.org/T92530) [18:18:57] (03CR) 10Phuedx: [C: 04-1] "As discussed, in alpha/beta the CSS selectors targeting the buttons don't work – they use .stable." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196324 (https://phabricator.wikimedia.org/T91141) (owner: 10Bmansurov) [18:19:37] * phuedx is still trying to eat his dinner :/ [18:19:52] jdlrobso_, i'm still here, ping me if you need anything. I just rebased my patch in gerrit [18:21:08] (03PS5) 10Jdlrobson: Added article counts and images, bugfixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196610 (https://phabricator.wikimedia.org/T92646) (owner: 10Yurik) [18:21:26] (03CR) 10Jdlrobson: [C: 032] Added article counts and images, bugfixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196610 (https://phabricator.wikimedia.org/T92646) (owner: 10Yurik) [18:22:30] (03Merged) 10jenkins-bot: Added article counts and images, bugfixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196610 (https://phabricator.wikimedia.org/T92646) (owner: 10Yurik) [18:22:59] FlorianSW: i'm inclined to fix it in the patch as it targets alpha/beta explicitly [18:23:26] phuedx: ok, great! :) [18:23:39] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: [Spike: 1 hour] Audit fetchers to enable us to sunset iOS 6 support - https://phabricator.wikimedia.org/T91789#1117284 (10KLans_WMF) [18:24:20] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Audit fetchers to enable us to sunset iOS 6 support - https://phabricator.wikimedia.org/T91789#1096369 (10KLans_WMF) [18:26:15] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: [Spike 2hrs] Audit fetchers to enable us to sunset iOS 6 support - https://phabricator.wikimedia.org/T91789#1117289 (10dr0ptp4kt) [18:27:28] (03CR) 10Kaldari: [C: 032] Match the Roulette header with the new header in MF Beta [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/193294 (owner: 10Bmansurov) [18:27:46] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Get iOS build server set up and serving alpha builds internally - https://phabricator.wikimedia.org/T91786#1117291 (10KLans_WMF) [18:28:33] (03Merged) 10jenkins-bot: Match the Roulette header with the new header in MF Beta [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/193294 (owner: 10Bmansurov) [18:28:49] Deskana, https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8194589 [18:29:10] kaldari: oh, sam's patch hasn't been merged yet [18:29:25] bmansurov: yeah, I was looking at that [18:29:55] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Get iOS build server set up and serving alpha builds internally - https://phabricator.wikimedia.org/T91786#1117292 (10KLans_WMF) [18:31:11] FlorianSW: i'm not sure how to proceed with that one -- the font changer works, but, as you say, there ain't content to see it :/ [18:31:24] (03PS5) 10Jdlrobson: I should be able to view other users public lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196502 (https://phabricator.wikimedia.org/T92543) (owner: 10Robmoen) [18:31:50] phuedx, FlorianSW: why would that be related to that patch? Hasn’t it always been that way on Special:MobileMenu? [18:32:03] jdlrobso_, probles issues? [18:32:05] yeah, the problem is, that the menu isn't loaded on the same page anymore :/ So we need a way to go back to the page and load the font changer [18:32:08] kaldari: ^ [18:32:14] phuedx: ^ [18:32:53] maybe with a hash (windows.location = pagename + "/fontchange" [18:32:54] ? [18:33:00] FlorianSW: But if you actually went to Special:MobileMenu before (for example, if JS was disabled), wasn’t it the same? [18:33:07] dr0ptp4kt: i thought i merged https://gerrit.wikimedia.org/r/#/c/196604/ [18:33:55] kaldari: fontchanger is hidden by default and will be unhidden via JS to adress this problem :) [18:34:37] FlorianSW: i was thinking the same thing -- back to the page with #/fontchanger [18:35:01] i think that's the best approach for now, until we found a better position for the button :) [18:35:22] FlorianSW: Seems like it would be better to put on the settings page in the long-term [18:35:52] kaldari: +++++++++++ :D That was my first idea, too (see the associated task), but design said: Better on the page :D [18:36:07] :P [18:36:55] FlorianSW: hrrm, part of the same patch? [18:37:04] gotta go get george to bed [18:37:07] jdlrobso_: I’m getting a JS error on en.wiki stable from mobile.watchstar, BTW [18:37:22] jdlrobso_: on Special:MobileOptions [18:37:35] (03PS4) 10Bmansurov: Fix styling regression in new editor tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196324 (https://phabricator.wikimedia.org/T91141) [18:37:41] phuedx: i'm not sure, it can be a bit big ? Like i said, i'm ok with merging it and fix font changer in a next patch :) We just shouldn't forget it :D [18:38:37] kaldari: https://en.m.wikipedia.org/w/index.php?title=Special:MobileOptions&mobileaction=stable ??? no JS error :/ [18:39:29] be back in 20 minutes [18:39:30] bed time! [18:40:34] phuedx: ok :) [18:40:36] FlorianSW: interesting, it only throws the error if there is a returnto param (which there usually will be): http://en.m.wikipedia.org/w/index.php?title=Special:MobileOptions&returnto=Main+Page [18:41:02] (03PS3) 10Jdlrobson: Create a base class for our content overlays [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196495 (https://phabricator.wikimedia.org/T92651) [18:41:08] or maybe that’s not it.... [18:41:25] kaldari: there was a returnto while i'm testing, i replaced it with the mobileaction=stable, still don't see any errors :( [18:41:41] (03Abandoned) 10Jdlrobson: Run jscs on Jenkins [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196500 (owner: 10Jdlrobson) [18:42:01] kaldari: firefox or chrome? logged in? [18:42:05] (03Abandoned) 10Jdlrobson: Hygiene: Rename functions in ApiEditCollection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195452 (owner: 10Jdlrobson) [18:42:57] kaldari: ah, ok, you're not logged in, see it now, too :/ [18:42:58] FlorianSW: actually, I get a JS error from the URL you sent. Logged out, Firefox and Chrome [18:43:12] logged in no problem [18:44:30] kaldari: lol, can you test https://en.m.wikipedia.org/w/index.php?title=Special:MobileOptions&returnto=Main+Page&debug=true too?? don't see any error there :/ [18:46:01] (03CR) 10Florianschmidtwelzow: "Fixed it, now it has the same false margin as EditorOverlay, which should be fixed, too, but in another change?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193522 (https://phabricator.wikimedia.org/T91139) (owner: 10Florianschmidtwelzow) [18:47:35] (03PS4) 10Florianschmidtwelzow: Hygiene: Use same saving indication in TalkSectionAdd like in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193522 (https://phabricator.wikimedia.org/T91139) [18:47:56] kaldari: lol, can you test https://en.m.wikipedia.org/w/index.php?title=Special:MobileOptions&returnto=Main+Page&debug=true too?? don't see any error there :/ [18:50:21] jdlrobso_, ? any fixes needed? [18:51:00] FlorianSW: None of the designers have even heard of the Font change feature (nor had I). Where did it come from? [18:53:05] kaldari: https://phabricator.wikimedia.org/T50946 :O [18:53:17] jdlrobso_: hey, around? can you read https://phabricator.wikimedia.org/T92496#1117377 and review my patch there? mediawiki.ui-related [18:54:12] coreyfloyd: bgerstle dr0ptp4kt any review feedback for https://gerrit.wikimedia.org/r/#/c/193323/ ? [18:54:32] FlorianSW: Ah, looks like it was Jared. I didn’t ask him :) He usually isn’t involved in mobile design. [18:55:15] mhurd sorry ahd to grab lunch after meetings [18:55:19] was almost through [18:55:25] kaldari: violetto (May?) commented, too :D [18:55:27] bgerstle: no worry! [18:55:28] okay, take two [18:55:28] jdlrobson: hey, around? can you read https://phabricator.wikimedia.org/T92496#1117377 and review my patch there? mediawiki.ui-related [18:55:31] :) [18:57:34] mhurd: i'll test after the +1s are in on it [18:57:41] FlorianSW: You’re right, I only asked the designers who have been assigned to work on mobile: Moiz, Kaity, and Vibha. I’ll try to track down May or Jared to ask them about the best way to handle this. [18:57:53] dr0ptp4kt: k [18:57:55] * jdlrobso_ heads for lunch bbiab guys! [18:58:18] kaldari: ok, thanks :) I actually, by the way, trying to reproduce the JS error, but locally it's working (at least on master), trying wmf20 now [18:58:34] FlorianSW: In the meantime, I think we can merge the existing page and fix in a follow-up commit. What do you think? [18:59:05] kaldari: like i said, i'm ok with this :) Let me take a short look over the code and i merge it, ok? :) [19:00:09] FlorianSW: sounds good to me [19:00:18] jdlrobso_: wait! [19:00:24] mm? [19:00:29] jdlrobso_: where u at? [19:00:39] kaldari: WFM today i didn't have any meetings [19:00:47] kaldari: what do you need? [19:00:50] jdlrobso_: Oh, guess I can’t get lunch with you then :P [19:01:00] NM [19:01:02] haha :) okay [19:01:07] enjoy [19:01:10] jdlrobso_: can you bonk that again? tests were failing [19:01:28] jdlrobso_: also when you get back: https://phabricator.wikimedia.org/T92657 [19:01:43] (enjoy your lunch) [19:01:46] mhurd: working [19:01:48] kristenlans: hey meeting still on? [19:02:07] nhurd yes! [19:02:12] mhurd ^ [19:03:35] (03PS5) 10Bmansurov: Alpha: Quickly lookup a brief info about a wiki page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195818 [19:04:46] (03CR) 10Fjalapeno: "Added some comments, nothing crazy -I feel like these can be addressed post-merge." (0313 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [19:05:04] kaldari: btw: I can't reproduce the watchstar error locally :( [19:05:16] (03PS6) 10Bmansurov: Alpha: Quickly lookup a brief info about a wiki page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195818 [19:05:49] (03CR) 10Fjalapeno: [C: 031] "Left comments on the other reply - I am +1 ing because I think it is fair to address in a follow on patch. Would like to hear from Brian t" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [19:06:23] (03CR) 10Florianschmidtwelzow: "hmm, one little big thing, and one little little thing :D" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [19:16:33] mhurd: coreyfloyd bgerstle kristenlans Deskana|Away i updated the cards listed at https://phabricator.wikimedia.org/tag/mobile-app-sprint-53-ios/, please add to them as necessary [19:25:44] mhurd: coreyfloyd what have you guys been doing to test lead image perf? [19:26:07] i was just pruning my comments when i saw a new patch set came in, so i just need to go back and put in the important ones [19:26:26] there was one thing about "showImage:" being called on multiple threads i wanted to double check [19:32:09] mhurd coreyfloyd anyone have a slower iOS 8 device? [19:32:21] you can do screen recordings from your device to your mac if running iOS 8 and Yosemite [19:32:30] wanted to do A/B comparison between master & monte's patch [19:32:54] worried my iPhone 6 will be too fast though [19:37:29] dammit [19:37:56] water leaking from the ceiling again [19:45:53] bgerstle: i have an iPhone 5 - thats my slowest one [19:46:01] ok [19:46:11] coreyfloyd: would you try running a back-to-back test? [19:46:25] checkout master -> load a couple articles and watch the lead image [19:46:27] repeat on the patch [19:46:37] and record the iPhone screen using quicktime? [19:47:00] QuickTime -> New Video Recording (Opt+Cmd+N) -> Click drop-down next to record button and select your iPhone (which is plugged into your Mac) [19:47:24] (03PS20) 10Phuedx: New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 [19:47:29] FlorianSW: ^ [19:48:23] (03CR) 10Florianschmidtwelzow: [C: 032] New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [19:48:28] phuedx: ^^ [19:48:51] nice spots bee tee dubs [19:49:39] (03Merged) 10jenkins-bot: New-ish Special:MobileMenu page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193373 (owner: 10Phuedx) [19:56:42] mhurd which article(s) were you testing on? [19:57:20] bgerstle: hundreds of them? ;) [19:57:29] how about a couple? [19:58:21] can you see either of: https://www.dropbox.com/s/9vzjhr2rk9n5k1x/patch%20193323.mov?dl=0 [19:58:29] or https://www.dropbox.com/s/nqw43tyel9nr9v7/master%20trimmed.mov?dl=0 [19:58:46] mhurd and what device? [19:59:34] bgerstle: with link conditioner set to edge, barack obama, then i tap on african american. also i go through non-huge pages (not presidents) like “madonna del granduca” [19:59:54] ok [20:00:00] bgerstle: old ipod touch w ios 6, ios 7 sim, ios 8 phone [20:00:20] i'll try w/ the NLC after our meeting [20:00:48] jdlrobson, still there? [20:00:51] bgerstle: with link conditioner you can see the low res version being shown, then it gets clearer and clearer as the web view gets more images (for some articles) [20:00:53] yurik: yup [20:01:01] issues/concerns? [20:01:02] kaldari: bug/backlog grooming? [20:01:13] yep [20:01:18] you gotta pull me up on the magic screen :) [20:01:28] jdlrobson ^^^? [20:01:46] yurik: no issues, looking great so far. could do with your help merging some patches though [20:01:50] (simple changes) [20:02:03] * yurik is good with automatic +2ing [20:02:22] Maryana: sorry, forgot I was the only one here [20:02:55] jdlrobson, am i added to the patches? [20:02:59] hmm, having some trouble with the hangout [20:03:16] Maryana i see you! [20:03:22] (03PS1) 10Jdlrobson: Show all page images on a collection and extracts [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196634 (https://phabricator.wikimedia.org/T92654) [20:03:23] I'mtalkign and you can't hear me [20:03:26] ^ yurik that one [20:03:35] maryana i can hear you [20:03:56] Maryana: looks like i need to find chip :( [20:04:09] maryana can you see me? [20:04:13] yes [20:04:17] oh, not anymore [20:04:22] now i'm all alone [20:04:31] still no audio from you [20:04:36] wait, why am i typing this if you can hear me [20:05:39] yurik: still catching up with your api changes - bit slow but looking rad :-) [20:05:41] it's really coming together! [20:05:46] yurik: i've added you to all the patches [20:05:48] most are backend any how [20:05:52] so should be easy for you to review [20:06:19] jdlrobson, oki, but you are missing 'continue'=>'' in it [20:06:26] (03CR) 10Jdlrobson: [C: 031] I should be able to view other users public lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196502 (https://phabricator.wikimedia.org/T92543) (owner: 10Robmoen) [20:06:33] yurik: yeh we dont support pagination yet [20:06:33] most of the time, you are not using continuation prooperly at all [20:06:44] jdlrobson, that's fine, but add it [20:06:46] yurik: https://phabricator.wikimedia.org/T90903 [20:06:52] this way you don't get warnings [20:07:08] yurik: do you want to raise a more specific bug than that one? [20:07:18] my day is looking quite clear so will probably get round to it now :) [20:07:42] jdlrobson, basically whenever you call api, always include "continue" parameter with blank value [20:07:56] unless you are continuing, in which case you will do something more elaborate [20:08:02] ok i can add a blank value now if that makes sense [20:08:07] (to that patch) [20:08:07] yep [20:08:36] (03PS2) 10Jdlrobson: Show all page images on a collection and extracts [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196634 (https://phabricator.wikimedia.org/T92654) [20:08:38] ^ yurik [20:10:01] http://en.m.wikipedia.beta.wmflabs.org/w/api.php?action=query&generator=lists|listpages&glspid=0&prop=pageimages|extracts&explaintext=true&exintro=true < yurik can generators not work like this? [20:10:36] jdlrobson, generator is singular [20:10:40] oh yeh [20:10:40] http://en.m.wikipedia.beta.wmflabs.org/w/api.php?action=query&generator=listpages&list=lists&glspid=0&prop=pageimages|extracts&explaintext=true&exintro=true [20:10:44] me being stupid :) [20:10:48] (03CR) 10Bmansurov: [C: 031] Hygiene: Use same saving indication in TalkSectionAdd like in EditorOverlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193522 (https://phabricator.wikimedia.org/T91139) (owner: 10Florianschmidtwelzow) [20:12:26] jdlrobson, did you break beta? :) [20:12:46] not knowingly.. why?! :D [20:13:01] or is this russian humour again? :) [20:13:29] Deskana: of the parentheses examples in your spreadsheet, [[Taoiseach]] is probably the best example of something that would be useful to the general reader. [20:13:50] I've got a hunch that there probably aren't a lot of native English speakers outside of Ireland that know how to pronounce "Taoiseach". [20:13:58] "/ˈtiːʃəx/" is also not easily readable by all people, but that's a whole different gargantuan argument. [20:14:35] aharoni: Right. But the problem is that honestly that information is totally misplaced. [20:14:36] (03CR) 10Bmansurov: [C: 032] PhotoUploadOverlay and Progress use View##event [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196609 (https://phabricator.wikimedia.org/T88568) (owner: 10Sumit) [20:14:40] (I can't judge this fairly - my mother taught me IPA when I was five. For a very long time I thought that all mothers teach their children IPA when they are five. Boy was I wrong.) [20:15:46] yeah, I agree... it should just be kept in mind that it's not only for names of Russians, Arabs and Indians, but also for words that are much closer to English's own cultural sphere, and these may actually be trickier. [20:15:52] (03Merged) 10jenkins-bot: PhotoUploadOverlay and Progress use View##event [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196609 (https://phabricator.wikimedia.org/T88568) (owner: 10Sumit) [20:17:14] Deskana: i updated the sprint 52 ios code review column to have items for some of the bits in my patch for https://phabricator.wikimedia.org/T91328 [20:17:18] aharoni: Perhaps our somewhat sweeping change will motivate a serious discussion about the placement of this information. I'm working with Moushira to try to ensure that that happens. [20:17:29] aharoni: I will be disappointed if we make this change on the apps and that's the end of the discussion. [20:18:45] MaxSem: those indexes look ok to me [20:19:00] i'll comment if i think up some more outrageous queries i might want to do [20:19:04] but for now [20:19:08] phuedx, thank - what about our possible future needs? [20:19:09] jdlrobson, i tried your last query - seems to work, what's the issue? [20:19:50] yurik: no issue. me being dumb :) [20:19:52] jdlrobson, beta gave me error when i clicked it first [20:20:01] hence asked and went to check logstash [20:20:26] yurik: able to merge https://gerrit.wikimedia.org/r/196502 and https://gerrit.wikimedia.org/r/196634 [20:20:29] ?! [20:20:30] ok, good, going back to patches [20:20:32] MaxSem: contribution counts per campaign for reporting, maybe? [20:20:36] aharoni: And I appreciate your criticism. It keeps us honest about thinking through the repercussions of our changes. :-) [20:21:03] jdlrobson, why are you changing user to string?? [20:21:35] yurik: mmm i didn't do that that was rob [20:21:35] phuedx, that sounds too slow for a non-batched query anyway [20:21:38] not sure what he's doing there [20:21:40] can remove it [20:22:01] MaxSem: why does extracts sometimes return { '*' and sometimes not?! [20:22:10] Deskana: it's not negative criticism, just careful observations. I generally support the direction. I'm all for respecting traditions, but remembering that 2015 is not 1915. [20:23:05] aharoni: I meant criticism in the purest sense. (English could do with a word to distinguish between these, it seems!) [20:24:16] (03CR) 10Yurik: [C: 032] Show all page images on a collection and extracts [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196634 (https://phabricator.wikimedia.org/T92654) (owner: 10Jdlrobson) [20:24:33] (03PS1) 10Jdlrobson: Hygiene: Use one api request to access meta data and members for viewing collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196641 [20:25:08] (03PS6) 10Jdlrobson: I should be able to view other users public lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196502 (https://phabricator.wikimedia.org/T92543) (owner: 10Robmoen) [20:25:12] ^ yurik removed the type change [20:25:29] (03Merged) 10jenkins-bot: Show all page images on a collection and extracts [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196634 (https://phabricator.wikimedia.org/T92654) (owner: 10Jdlrobson) [20:25:54] jdlrobson, it shoudln't. examples? [20:26:14] MaxSem: it's doing it locally for some reason [20:26:23] but i can't replicate on production.. :-/ [20:26:34] reeeeeprooooowwwwww [20:26:47] poic or it didn't happen!:P [20:27:10] hmm, is it doing that locally due to a newer mw? [20:27:25] do you see it on beta? [20:27:32] MaxSem: i'll ping you if i think of anything else [20:27:45] ok thanks:) [20:27:52] 8:30 pm on friday isn't conducive to out of the box thinking :/ [20:27:56] (03CR) 10Yurik: [C: 032] I should be able to view other users public lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196502 (https://phabricator.wikimedia.org/T92543) (owner: 10Robmoen) [20:28:22] yurik: so this is all i need help from now -> https://phabricator.wikimedia.org/T92580 :) [20:28:33] gonna be idlin' for a while [20:28:34] phuedx: go enjoy your weekend! :D [20:28:42] jdlrobson: lots of diy [20:28:46] kristenlans, I don't think that creating spikes for bugs makes sense [20:28:55] and trying to get a plumber to install a new boiler :( [20:29:00] (03Merged) 10jenkins-bot: I should be able to view other users public lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196502 (https://phabricator.wikimedia.org/T92543) (owner: 10Robmoen) [20:29:03] oh [20:29:15] because until then, we haven't got heating :/ [20:30:29] * yurik is reading.. [20:32:01] gn folks, have lovely times [20:35:29] jdlrobson, found a bug somewhere... checking [20:35:34] cool! [20:37:44] jdlrobson, https://phabricator.wikimedia.org/P397 [20:40:17] kaldari: i really hate that search is now on a 2nd screen slowing me down so much dev wise since my vagrant is slow.. :( [20:40:31] also you have a heading "Site navigation" at the bottom of the page http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileMenu [20:40:41] jdlrobson, i think its that bug of extracts returinng '*' => text sometimes [20:40:55] yurik: you can replicate that? [20:41:02] jdlrobson, yep [20:41:22] $item->getExtract() returns an array of { '*' => 'text' } [20:41:56] jdlrobson, ^ [20:42:09] /home/yurik/v/mediawiki/extensions/Gather/includes/views/CollectionItemCard.php line 60 [20:42:21] jdlrobson, ^ [20:42:33] doesn't happen on beta labs though [20:42:34] which is weird [20:42:42] http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/Jdlrobson/5 < see extracts show fine [20:42:50] oh wait wtf [20:42:51] arg [20:42:55] running vagrant git-update just in case [20:43:02] yurik: i don't know what's going on [20:43:13] jdlrobson, the last patch i commited removed the [0] [20:43:28] for the extracts [20:43:35] do it with reset() though [20:44:14] but you should do it with a "if (is_array(xx)) xx=reset(xx) [20:44:16] jdlrobson, ^ [20:46:30] so yurik where is it going wrong? [20:46:38] http://en.m.wikipedia.beta.wmflabs.org/w/api.php?action=query&generator=listpages&list=lists&glspid=5&prop=pageimages|extracts&exlimit=50&explaintext=true&exintro=true&lstprop=label|description|public|image|count returns extract: "" [20:47:25] jdlrobson, https://gerrit.wikimedia.org/r/#/c/196634/2/includes/models/Collection.php,cm [20:47:47] just add an extra check there [20:48:00] jdlrobson, never mind, will do it in a sec [20:48:18] * jdlrobson confused , but why is check needed? [20:49:23] kaldari: bmansurov when do we get JavaScript search back in alpha? :-( [20:49:37] in meeting [20:49:48] not sure [20:50:40] jdlrobson: is search broken in alpha? [20:50:52] bmansurov: it always takes me to Special:MobileMenu [20:50:55] it feels broken [20:51:02] but i'm not sure if you guys meant to do that [20:51:04] jdlrobson: oh i see, it's a feature not a bug ;) [20:51:20] it is definitely broken in that "Site navigation" heading is at the bottom of the page [20:51:34] bmansurov: wait you have no plans to make this work with JS? [20:51:44] this is a terrible user experience!! [20:51:55] jdlrobson: i think we do, but we just completed the initial step [20:52:03] ok cool :) [20:52:06] i hope you do [20:52:21] also this won't scale [20:52:31] since special pages have no caching [20:53:03] do you have plans to render this in javascript before next deploy? this is gonna break my heart and force me out of lovely alpha into beta [20:53:07] jdlrobson: i'm sure we can build on sam's work and share templates with front end and back end [20:53:25] okay, feeling very disconnected with this work that's not wikigrok :-/ [20:53:32] jdlrobson: i don't know, i haven't seen a card about it, but we just talked i think [20:53:37] i hope we can find better ways to involve whole team in non-wikigrok changes [20:54:09] jdlrobson: yes, we welcome input from the Gather team, but you guys seem to be busy these days [20:54:37] your work is also pretty invisible to us since you are on Trello (i only look there when pinged) :-( [20:54:40] (03PS1) 10Yurik: Fixed extract ['*'] bug [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196656 [20:54:41] jdlrobson, ^ [20:55:02] yurik: why is this happening though? [20:55:11] i don't get it... seems like a bug in the api /extracts ? [20:55:26] i know it's happening but i can't work out what circumstances it happens in [20:55:27] jdlrobson: i think we should ask board admins to add you guys there too [20:55:31] jdlrobson, you are welcome to file a bug )) [20:55:51] bmansurov: it makes no difference - it's just one more place the team has to look [20:55:53] i'm in bed already, should get some rest at some time ) [20:56:00] we should probably do a full move to phabricator [20:56:09] i think that will help a lot [20:56:30] jdlrobson: actually, more than half of our work is already in phabricator [20:56:46] jdlrobson: you guys can start looking there [20:56:48] bmansurov: well not all of it :) [20:56:57] bmansurov: i've not seen a card for the new menu stuff :) [20:57:39] jdlrobson: https://trello.com/c/Isf8stWH/1-5-new-mobile-menu-page and https://trello.com/c/yv3DSeyf/2-3-new-page-header-in-beta-and-alpha [20:58:02] yurik: thanks fo your work today [20:58:07] bmansurov: that's my point - it's in trello :) [20:58:23] bmansurov: trello = invisible to entire Gather team we just have no time to dip in there :) [20:58:50] bmansurov: are you subscribed to Gather bugs btw? [20:58:50] jdlrobson: well to solve the problem at hand, you can just check those cards for now [20:58:57] just out of interest [20:58:58] jdlrobson: yes i am [20:59:09] jdlrobson, are you merging that patch above? [20:59:33] jdlrobson: i don't think it's that hard to check trello in this transition period [20:59:49] (03PS2) 10Jdlrobson: Fixed extract ['*'] bug [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196656 (owner: 10Yurik) [20:59:54] jdlrobson: at least it's not creating a lot of difficulties for our team [21:00:38] bmansurov: i don't think this solves the problem. I'm just letting you know it is causing difficulties for my team. We are all very disconnected from you guys and I will bring it up again in retrospective. You've probably noticed the lack of code review. From my perspective i'm just really finding it difficult when i code review to know what i'm reviewing [21:00:45] putting trello urls in cards might be a good interim solution [21:00:59] (03CR) 10Jdlrobson: [C: 032] Fixed extract ['*'] bug [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196656 (owner: 10Yurik) [21:01:36] jdlrobson: ok, we'll put trello urls for now [21:02:07] (03Merged) 10jenkins-bot: Fixed extract ['*'] bug [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196656 (owner: 10Yurik) [21:04:03] bmansurov: that will help with code review. I don't know how we can resolve changes in the direction of the site. [21:04:41] i'm a bit concerned about this new search, when i saw the card i thought the plan was to render the menu/search as an overlay and the way it's been implemented concerns me and i'm not sure if i should be concerned :) [21:05:16] jdlrobson: I think it's good that you're thinking of potential problems, I really appreciate it. [21:05:31] bmansurov: the bit that confuses me is we made the search icon link to Special:Search to help zero users after research from Adam [21:05:39] all that research has just been eradicated with this change [21:06:33] jdlrobson: I didn't know there was research about it, we should let the design team and Maryana know about it then [21:06:38] (03PS23) 10Dr0ptp4kt: Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [21:06:55] (03CR) 10Dr0ptp4kt: [C: 032] Move lead image inflation/face detection to background thread. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/193323 (owner: 10Mhurd) [21:07:02] jdlrobson: the way it’s being implemented is just to test the new layout. We have no idea if it will be used for real, thus we didn’t want to rewrite both the overlay and the MobileMenu page. [21:07:39] jdlrobson: sorry I’m late to the conversation. Hope that’s what you’re talking about [21:08:41] kaldari: mostly personal ;-) i was just lamenting how search experience is terrible now, and it's making things harder for me to test Gather since I use search to find pages to add to collections [21:08:58] wouldn't it have been cheaper just to make this JS only to start with? [21:09:44] jdlrobson: Possibly. If we decide to push this design up, we will definitely do an overlay version as well [21:10:11] kaldari: this just makes me not want to use alpha [21:10:34] jdlrobson: What’s the main reason? Because it’s slower? [21:10:35] i might have to hack up a js equivalent before i go insane hah [21:10:40] exactly [21:10:45] especially on my vagrant [21:10:51] (03PS4) 10BearND: Fix action mode menu item color. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196587 (https://phabricator.wikimedia.org/T92510) (owner: 10Dbrant) [21:10:54] which is completely b0rked due to the file caching issue [21:11:02] jdlrobson, looking at https://phabricator.wikimedia.org/T92580 - why do you need to know if a page is part of a collection? [21:11:17] jdlrobson: can you leave the search page open and open results in new tabs for now? [21:11:24] yurik: so when you go to a page you know which collections that page is [21:11:51] jdlrobson, when do you show that? [21:12:10] jdlrobson: You (or baha) could just add a feature flag to turn it off [21:12:12] yurik: log in visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Fox?mobileaction=alpha [21:12:14] and click watchstar [21:12:25] the green ticks next to your list are the collections the page is in [21:13:05] kaldari: it's not a big deal, maybe i'll grow to love it but my first reaction is "urggh!" :) [21:13:08] kaldari: yeah, i agree, that's a fast solution [21:13:38] JonKatz: http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/Jdlrobson/5 \o/ [21:14:15] awesome!!!! [21:17:38] it's not showing all the cuteness sadly JonKatz ;-) [21:18:11] (03CR) 10BearND: [C: 032] Fix action mode menu item color. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196587 (https://phabricator.wikimedia.org/T92510) (owner: 10Dbrant) [21:18:32] jdlrobson limited to 10? [21:18:49] coreyfloyd: can https://phabricator.wikimedia.org/T90746 go in “ready for signoff” column? [21:19:11] JonKatz: yup [21:20:24] JonKatz: feel free to start doing sign off now :) [21:20:53] (03Merged) 10jenkins-bot: Fix action mode menu item color. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196587 (https://phabricator.wikimedia.org/T92510) (owner: 10Dbrant) [21:20:55] Deskana, hello [21:22:24] bmansurov: kaldari omg you put the new header in beta too?!! [21:22:26] arggg [21:22:34] jdlrobson I have been gnoming away at it, but would like to talk through the few that have just a few minor issues...but are attached to a lot of points [21:22:47] why?! this is so not polished imo for beta [21:22:50] prtksxna: hey there, I was told you know a thing or two about hover cards [21:23:38] prtksxna: could you point me to the extension where this is implemented? we're considering implementing something similar in the apps [21:23:51] bgerstle: the “Wikipedia” scheme we have bundled has “Build Configuration” set to Debug. Do we need to add another “Wikipedia_Prod” scheme to the project so we can easily select scheme with “Build Configuration” set to Release? (so we get “Release” optimization level as opposed to -O0) [21:24:34] so we get “Release” optimization level as opposed to -O0 ***for releases*** [21:24:43] or is that done some other way? [21:24:45] jdlrobson: You’re probably right. Not sure why it’s jumping straight to beta. [21:25:06] kaldari: it's not meant to be? [21:25:38] kaldari: the card says beta and alpha [21:25:46] jdlrobson: Well, it is meant to be, according to the card, but that probably doesn’t make sense for this. I’ll ask Maryana about it. [21:26:02] see also https://phabricator.wikimedia.org/T92679 [21:26:15] coreyfloyd: ^ [21:26:31] kaldari: ? [21:26:58] Maryana: hang out? [21:27:10] sure, though we've got a meeting in 3 minutes anyway :) [21:27:22] could jump on early [21:28:25] kaldari: i'm on this hangout: https://plus.google.com/hangouts/_/wikimedia.org/wikigrok-q4?hceid=amthdHpAd2lraW1lZGlhLm9yZw.76pb31t0ofhgaect73g0raggrc [21:31:08] bmansurov: jdlrobson was tlakgin about the trello-> phab w/ kaldari and maryana earlier. Were you spying on us? ;-) [21:31:27] I think the momentum is no there, gonna send some mail about it [21:31:30] (porbably monday) [21:31:40] s/no/now [21:31:45] \o/ [21:31:56] THE TIME IS NIGH [21:32:35] bmansurov: kaldari / Maryana have said to move it to alpha only [21:32:42] we just had a quick chat [21:32:57] jdlrobson: ok [21:39:37] (03PS1) 10Bmansurov: Limit the new header to alpha only [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196697 [21:39:47] jdlrobson, kaldari if you guys can review ^ [21:41:19] kaldari: although unrelated, it would be nice to get this merged too https://gerrit.wikimedia.org/r/#/c/196098/ thanks [21:42:17] (03CR) 10Kaldari: [C: 031] "Still need to test" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196697 (owner: 10Bmansurov) [21:43:34] mhurd: coreyfloyd bgerstle - stable channel testflight pushed. please install "Wikipedia Mobile" from the app store if you haven't already, then go to different pages and do searches and save stuff and whatnot....then install the stable channel testflight to override it and see that the data upgrade works [21:43:42] mhurd the "archive" task for that scheme should use the release config [21:43:59] bgerstle: cool [21:44:09] you should only ever need two configs :-) [21:44:28] (i actually talked about this at the meetup last night, need to put slides together) [21:44:55] bgerstle: do you use it when you want to test performance with release optimization level? [21:45:12] mhurd, bgerstle, coreyfloyd: Adam and I just tested the migration from the old prod app to the new TestFlight release and it worked flawlessly. :-) [21:45:32] Deskana: WHAT WHAT!? that’s great! :) [21:45:43] saved pages, all the data, login, all persisted [21:45:54] mhurd you can tweak it locally i suppose, but i wouldn't commit it [21:45:57] Although my pages didn't have lead images display if I loaded them from saved pages [21:45:58] bgerstle: just 2 configs? What about shipping different features for an internal beta vs an external beta (for instance the crash button)? [21:46:03] i.e. change teh debug setting to -0? [21:46:14] coreyfloyd: environment variables and/or CLI overrides [21:46:17] mhurd: I love how you are suprised by that -lol [21:46:39] same for overriding InfoPlist values [21:46:42] bgerstle: so you are setting the envionment variables from the command line then? [21:47:02] https://github.com/btgerst/helloworld-ios/blob/master/Makefile#L22 [21:47:21] that overrides the "Icon files" value to change the icon [21:47:23] coreyfloyd: it worked the last half dozen times i tested it over the last couple months, so i wasn’t *really* super surprised. pleased though ;) [21:47:25] in the plist [21:48:00] dr0ptp4kt: do we know the commit the prod release is based on? [21:48:07] bgerstle: hang tight [21:48:10] i'd like to try w/ the debugger attached w/ breakpoints to be 100% sure [21:48:11] bgerstle: that makes sense for the CI part, but what if I need to debug a version of the app on the xcode debugger? How would I do that in this setup? [21:48:30] what exactly would you want to debug? [21:48:37] (why couldn't be at my meetup last night to ask me these questions?!) [21:48:43] (needed some more people to banter w/) [21:49:30] bgerstle: lets say there is a crash for an external tester - I need to make sure I am running with the same environment variables they are - how would I do that? [21:49:31] coreyfloyd: the other option is multiple configs, each w/ it's own xcconfig file [21:49:43] easier to share settings between xcconfig [21:50:13] coreyfloyd: well, you could locally modify code signing and run release on your device... but the chances that the bug wouldn't be reproducible in debug is low [21:50:15] bgerstle: so still > 2 configs - just specified the xcconfig file? [21:50:27] nope, N configs w/ N xcconfigs [21:50:37] but that still doesn't solve your case [21:50:57] well, it could, you'd just have to add another config / config-file pair [21:51:00] for your exact scenario [21:51:12] (xcconfig files can #include others, and override settings) [21:51:47] bgerstle: yeah usually we had different schemes for each build type (debug, alpha, beta, app store) and usually they require separate configs to turn those features on and off [21:52:04] but yeah, i would say 90+% of the time, you should be able to debug "production" bugs by simply running the debug config of the same target [21:52:26] 90% < 100% [21:52:37] coreyfloyd: a fair trade-off IMO [21:52:44] bgerstle: it is the tag stabletf/4.0.7.5-stabletf-2014-03-13 [21:52:44] easier to automate [21:52:45] bgerstle: seems cheap to have multiple configs [21:52:50] dr0ptp4kt: thanks! [21:53:17] bgerstle: you can still specific the config settings in the xcconfig files even if you have > 2 configs [21:53:24] coreyfloyd: right, i was mistakenly comparing to multiple configs w/o config files [21:53:44] coreyfloyd: but you can't avoid repeating yourself unless you use xcconfig [21:53:58] since you want the same optimization level (most likely) for all "release" configurations (alpha, beta, etc.) [21:54:05] code signing, etc. [21:54:23] bgerstle: yeah - gotcha - I'm all for the xcconfig files - just might need multiple configs so we can produce the same builds in the xcode UI as the command line. [21:54:24] tfinc, https://phabricator.wikimedia.org/tag/openstreetmap/board/ [21:54:27] not sure how well the xcconfig approach plays w/ cocoapods, though i think it's supported [21:54:36] MaxSem: thanks. i'll take a pass [21:54:41] bgerstle: yeah np with cocoapods [21:54:45] figured [21:54:52] bgerstle: you can actually specify which config to use [21:54:55] you just need t import it [21:54:59] (the pods config, i mean) [21:55:01] right/ [21:55:52] bgerstle: yeah i played around with this in a previous project - cocoapods will only have 2 configs, but in the pod file you specify "alpha config == release config" [21:55:59] or whatever [21:56:16] i thought cocoapods has N configs for N "link_with" targets [21:56:18] tfinc, lots of possible future cards depend on decisions in cards already outlined, otherwise there would've been much more:P [21:56:26] :) [21:56:58] bgerstle: maybe they changed it - it was that you picked which configs to map to the ones they provided - but they may support creating additional configs now [21:57:05] hmm [21:57:21] i was under the impression that they had one per anyway. *shrug* [21:57:32] OTOH, i have come to the opinion that we should commit the Pods folder [21:57:45] will make builds faster, and on-boarding easier [21:57:55] only need to touch ruby/cocoapods when updating Podfile & deps [21:58:19] bgerstle: "xcodeproj 'ProjectName', 'Ad Hoc' => :release, 'Release Candidate' => :release" [21:58:39] is how it was done last time I did it [21:58:55] hm. . . [21:59:30] bgerstle: agreed on the commiting cocoapods thing - i came to that conclusion myself not that long ago (think we discussed before) [21:59:37] yeah [21:59:50] i used to think GH recommended *against* it, but i found out it's actually the opposite [22:00:25] bgerstle: they probably were, but changed their mind like we all do… lol [22:02:20] k, gonna try this migration stuff now [22:04:25] (03CR) 10Jdlrobson: [C: 032] Limit the new header to alpha only [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196697 (owner: 10Bmansurov) [22:06:00] (03Merged) 10jenkins-bot: Limit the new header to alpha only [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196697 (owner: 10Bmansurov) [22:08:29] sorry dr0ptp4kt i mean the tag for the last App Store release [22:08:51] bgerstle: that was in 2014. the git project didn't introduce tags until last week [22:08:54] bgerstle: kidding [22:09:18] don't make me go through the commit history.. [22:09:22] bgerstle: i don't think there was a tag. that said, if you look at the git history from december you should be able to deduce roughly when that happened [22:09:25] bgerstle: oh snap [22:09:38] god help me.. [22:09:42] bgerstle: brion may also know; try him on gchat maybe? not sure if he's in today [22:11:15] i see a commit on 12-22 "fix for new build not remembering scroll position!" which is after "Fix for market build not remember scroll position" [22:11:44] lots of stuff about explosions [22:14:03] i don't even think i'd be able to build the project if i checked it out [22:14:17] i give up, to the app store [22:15:45] bgerstle: are you looking for the last market release hash? [22:15:54] mhurd yes [22:16:01] bgerstle: 1 minute... [22:17:05] Deskana|Away: dr0ptp4kt what pieces of persistent data did you check? [22:17:16] (want to make sure i'm getting everything) [22:18:15] bgerstle: i think it’s 056211487f3f4e41726c0e301f34b3c5ba4cf13e [22:18:43] somehow i didn't see that commit msg [22:18:43] thanks [22:19:19] bgerstle: i just went by the app store date of dec 5, then looked at commits around that time [22:19:46] bgerstle: the next commit was the mega data layer patch [22:19:47] mhurd: is that the day it was released or uploaded? [22:20:22] bgerstle: saved pages, recent, search history (click the x in the search bar), whether i'm still logged in, whether if i'm still logged in and i edit (e.g., improve grammar somewhere) the edit is attributed to my logged in id. try the image viewer as well to see that it basically holds up [22:20:59] bgerstle: not sure, i just know the next commit is the data layer mega patch ( https://github.com/montehurd/apps-ios-wikipedia/commit/d7f3fe67433e0a6d2179262b416af897083d400b ) which hasn’t been released to prod yet [22:21:05] bgerstle: mhurd dr0ptp4kt so far have not found any bugs on the update process. Taking a break now for family din din - will be back on afterwards, you can reach me on irc if needed. [22:21:17] coreyfloyd: enjoy family din din [22:21:22] coreyfloyd: see ya [22:21:34] coreyfloyd: i may break for a while as well [22:21:38] dr0ptp4kt: ^ [22:21:57] dr0ptp4kt: maybe we can add this to elena's regression test somewhere? [22:22:01] i mean, all those persistent entities [22:22:15] bgerstle: please do [22:22:21] mhurd: word. word to mhurd [22:22:29] lol [22:22:29] k [22:24:20] you guys so cray cray [22:27:34] here's a crazy question [22:27:38] we have no way to open a specifc article? [22:28:10] (03PS1) 10Bmansurov: Match header changes in MobileFrontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196700 [22:28:56] e.g. i want to edit my user page in the app [22:30:41] i guess we just search for it [22:30:44] (found mine) [22:31:24] (03PS59) 10MaxSem: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [22:39:59] does data migration take a long time? [22:40:37] dr0ptp4kt: ^ [22:41:39] bgerstle: it took i think 5-10 seconds on dan's device. on mine it was more like 3 seconds [22:41:49] bgerstle: how long is it taking for you? [22:42:09] been going for... i can't say how long because we don't log timestamps :-( [22:42:19] but, probably at least a minute [22:42:19] arrrg, keep forgetting set my nick back [22:42:25] though i should say, i ran from xcode not TF [22:42:33] and it triggered a thread safety assertion i added, so i had to force quit [22:42:44] and when i commented out the assertion and re-ran... i'm stuck [22:43:02] bgerstle: "don't do that" [22:43:11] bgerstle: in all seriousness, though... [22:43:38] bgerstle: you'll want to get the official app from the app store, do a bunch of stuff with that, then use the testflight app to get the 'wikipedia mobile' app to see if that works [22:43:58] bgerstle: i understand the desire to do it via xcode, to be sure...gives one more facts [22:44:08] i did that, but used the debugger to install over instead of TF [22:44:19] i can try again, disabling assertions [22:44:30] just to see if that forced crash corrupted the data somehow [22:45:13] i can see the disk is thrashing a bit [22:45:24] between 1-3 MB/s [22:45:33] so it' sdoing *something* [22:45:35] but i don't know what [22:46:06] what's our pastebin domain again? [22:47:39] i'm seeing this: http://pastebin.com/mChNuvCm [22:48:03] so yeah, probably something i did w/ crashing during migration [22:48:12] one more time.. [22:53:27] (03CR) 10Florianschmidtwelzow: Hygiene: Use same saving indication in TalkSectionAdd like in EditorOverlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193522 (https://phabricator.wikimedia.org/T91139) (owner: 10Florianschmidtwelzow) [22:55:50] JonKatz: around? [22:56:14] (03CR) 10Kaldari: [C: 04-1] Recording user responses (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [22:56:26] dr0ptp4kt: worked the second time around (from TF w/o triggering assertion crash during debug) [22:56:37] but, i guess if there is a crash during migration, user might get stuck and have to reinstall [22:56:50] bgerstle: phew. i blame your code for it working properly for a real upgrade [22:56:53] crash is probably somewhat unlikely though [22:57:14] bgerstle: i think in theory it's supposed to bail out gracefully if it has problems [22:57:22] dr0ptp4kt: my "code" was an assertion that an unsafe method was accessed off the main thread [22:57:30] which could cause nastier crashes, if the timing is wrong [22:57:57] but, it's possible that this method being called simultaneously on two threads is highly unlikely [22:58:29] (03PS1) 10BearND: Light theme chooser button was not labelled on 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196705 [23:00:45] dr0ptp4kt: i see a @try/catch which might help [23:02:53] dr0ptp4kt: is the page nav history supposed to be preserved? [23:02:55] i.e. back/forward [23:03:11] bgerstle: within reason [23:03:20] got nothin' [23:03:23] bgerstle: are you hitting any badness? [23:03:37] the app wasn't saving my scroll position before [23:03:42] even just scroll -> restart [23:03:47] so i consider that as already broken [23:03:54] and not related to migration [23:04:07] saved and recent seem intact though [23:04:23] hm [23:04:35] when i launch a page from saved pages, i didn't see lead image until i refreshed [23:05:05] dr0ptp4kt: this seems to happen 100% of the time [23:05:11] load any saved page after migration -> no lead image [23:05:29] rotate to/from landscape doesn't show it either [23:05:42] bgerstle: try a pull to refresh [23:05:55] that restores it [23:06:06] bgerstle: yay? [23:06:13] sorry, that's what i meant before by "until i refreshed" [23:06:19] dr0ptp4kt: seems the same w/ recent [23:06:19] MaxSem: hey, what kind of other 'service' pages are there? https://phabricator.wikimedia.org/T91300 [23:06:25] i loaded 3 other saved pages, no lead image [23:06:32] w/o refreshing, loaded the same 3 from recent [23:06:33] no lead image [23:06:50] mmmm [23:06:52] mm [23:07:06] aand the image gallery doesn't work [23:07:29] none, prolly? at least in mainspace... [23:08:28] yup [23:08:36] dr0ptp4kt: I'm almost done here I think. Be down soon. [23:08:38] dr0ptp4kt: image gallery is also broken until a refresh occurs [23:08:39] \o/ [23:10:30] dr0ptp4kt: can you repro? [23:10:38] let me write up the steps.. [23:10:47] should i file in phab? i've gotta run [23:11:22] MaxSem: also, should disambig pages not generate campaigns? That way wikigrok won't show [23:11:55] bgerstle: yeah, file something for that. maybe we can slip in a fix [23:12:30] k [23:12:40] especially w/ the gallery being broken, that sucks [23:12:42] in principle, it shouldn't as disambigs shoudln't have the appropriate properties in wikidata [23:12:44] hmmm [23:13:05] MaxSem: ok then I just need to make sure not to load modules [23:13:24] oh, so phab DOES have name auto-complete [23:13:26] ...in issue fields [23:13:30] so should be easy to add to comments too [23:13:33] does it play nice with rl caching? [23:13:55] MaxSem: not sure, but we are still loading modules dynamically [23:14:52] dr0ptp4kt: Deskana also we might want to bump to 4.1.0 instead of 4.0.7 [23:15:03] i just bumped to 4.0.7 to be different than 4.0.6 [23:15:07] i mean, we are adding a *few* new features [23:15:23] Hah, yeah [23:17:30] Works for me [23:19:38] 10Wikipedia-App-iOS-App: 4.0.7.5 previous edits display their time stamp +7hours - https://phabricator.wikimedia.org/T92696#1118352 (10Etonkovidova) 3NEW [23:19:54] 10Wikipedia-App-iOS-App: [4.0.7.5] Lead Image & Image Gallery features broken for migrated articles - https://phabricator.wikimedia.org/T92697#1118359 (10BGerstle-WMF) 3NEW [23:20:09] dr0ptp4kt: ^ [23:20:19] heading out now, have a great weekend everyone! [23:20:28] sorry to leave on a bad note :-( [23:20:33] bgerstle: Thanks Brian! Enjoy! [23:20:37] bgerstle: thanks. no, it's good to find stuff! [23:20:41] bgerstle: have a good weekend [23:20:49] you two/too ;-) [23:20:56] (i am horrible w/ [word]puns these days) [23:29:23] (03CR) 10Kaldari: [C: 032] TWN: Use own message for terms of use link in license warning (editor and talk) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190831 (owner: 10Florianschmidtwelzow) [23:31:48] tfinc: https://phabricator.wikimedia.org/T89914 [23:32:18] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Sometimes images don't show in image viewer - https://phabricator.wikimedia.org/T89914#1118373 (10Tfinc) Seeing this with [[en:Yosemite Valley]] across iPad mini and iPhone [23:34:49] (03Merged) 10jenkins-bot: TWN: Use own message for terms of use link in license warning (editor and talk) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190831 (owner: 10Florianschmidtwelzow) [23:41:29] dr0ptp4kt: http://etherpad.wikimedia.org/p/iOSAppDescription [23:51:51] (03CR) 10Kaldari: [C: 032] Alpha, Beta: Make reference dialog scrollable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196098 (owner: 10Bmansurov) [23:52:21] kaldari: thanks [23:53:02] (03Merged) 10jenkins-bot: Alpha, Beta: Make reference dialog scrollable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196098 (owner: 10Bmansurov) [23:58:55] 6Mobile-Web: Tappable area of close button on reference drawer is too small - https://phabricator.wikimedia.org/T92700#1118421 (10kaldari) 3NEW