[00:04:22] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android: Login/create account/captcha buttons not visible in 2.3 - https://phabricator.wikimedia.org/T92850#1123913 (10bearND) Upstream bug: https://code.google.com/p/android/issues/detail?id=160591 As mentioned there, we could use a gradient instead of a sol... [00:13:05] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1123946 (10Andyrom75) On https://it.wikivoyage.org we store the banner locally without using the one on wikidata because we add a description for each banner, so w... [00:15:58] (03CR) 10Bmansurov: "An alternative solution maybe to make the description text scrollable like in [1]." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [00:22:53] (03PS1) 10Jdlrobson: Illustrate collections when listing collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197256 (https://phabricator.wikimedia.org/T91675) [00:23:42] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: When I go to Special:Gather and see the collections I own they are illustrated with a page image - https://phabricator.wikimedia.org/T91675#1093022 (10Jdlrobson) Above patch simply sets an image when you create a new collection. More work needed. Please... [00:23:56] (03CR) 10jenkins-bot: [V: 04-1] Illustrate collections when listing collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197256 (https://phabricator.wikimedia.org/T91675) (owner: 10Jdlrobson) [00:25:03] 10Gather, 3Gather Sprint Diplodocus: Collections need a last modified and created field - https://phabricator.wikimedia.org/T92690#1123973 (10Jdlrobson) We may be able to lean on id and simply list collections by id so this is lower priority than originally thought. [00:25:27] MaxSem: did you have any time to check the nearby query funkiness? [00:27:01] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1123974 (10Jdlrobson) @yurik this is blocked - to support this we need some way of querying all collections on the system and surface the owner of those collections. e.g. http://127.0.0.1:8080/w/api... [00:28:46] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1123977 (10Yurik) for moderation, i propose we use log events instea [00:29:38] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1123980 (10Jdlrobson) @Yurik what's log events? [00:29:47] yurik: ^ :) [00:30:12] in a nutshell as i need to leave soon :) [00:30:42] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1123981 (10Jdlrobson) [00:31:54] MaxSem: Did you ping Sean? [00:32:05] eh [00:32:10] ok, let's do it [00:33:07] (03CR) 10MaxSem: "@Springle, can you please review the schema?" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [00:33:45] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1123987 (10Yurik) [[ https://en.wikipedia.org/w/index.php?title=Special:RecentChanges | RecentChanges ]] - it is already designed for all sorts of monitoring, and we can hide it by default (like wik... [00:34:26] mhurd, I have a suspicion that https://en.wikipedia.org/w/index.php?title=Template%3AInfobox_settlement&diff=651351017&oldid=649234335 broke it [00:34:39] * MaxSem BLAMES WIKIDATA [00:35:35] MaxSem: it’s a pretty bad bug… do we need to open a ticket or are you on it? [00:35:35] 3Gather Sprint Diplodocus, 5Patch-For-Review: Optimize Special:Gather/User/XXX loading - https://phabricator.wikimedia.org/T92862#1123990 (10Jdlrobson) Is https://gerrit.wikimedia.org/r/#/c/196641/ related to this? [00:35:40] dr0ptp4kt: ^ [00:37:07] reverted on wiki, will discuss with author. meanwhile, job queue should slowly repopulate [00:38:35] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1123993 (10Jdlrobson) @Yurik could you point at some sample code. This is an area none of us have explored so would be useful to see what effort this would entail and whether this is possible for @J... [00:39:06] MaxSem: thanks! [00:44:23] (03PS1) 10Mhurd: Fix to handle malformed Nearby query results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197259 [00:46:35] (03CR) 10Dr0ptp4kt: [C: 031 V: 031] "This is working for me on iOS 7 simulator, iOS 8.2 physical device, and iOS 6 physical device." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197244 (owner: 10Mhurd) [00:48:04] (03CR) 10Kaldari: [C: 04-1] "This works, but I would prefer that we make both the width and the height of the button follow the same method (and I prefer the method yo" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197214 (https://phabricator.wikimedia.org/T92700) (owner: 10Bmansurov) [00:51:13] (03CR) 10Dr0ptp4kt: [C: 032] Fix to handle malformed Nearby query results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197259 (owner: 10Mhurd) [00:55:11] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: image gallery UI doesn't flip to suit RTL languages - https://phabricator.wikimedia.org/T91313#1124030 (10dr0ptp4kt) To eliminate any potential confusion, the fix is targeted at the image gallery and not other parts of the UI, right? For example, the lead ima... [00:55:43] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: image gallery UI doesn't flip to suit RTL languages - https://phabricator.wikimedia.org/T91313#1124031 (10dr0ptp4kt) ...That is to say, the lead image that is above the article (whereas a lead image inside the image viewer might be a different case). [00:59:32] (03CR) 10Bmansurov: "So the button widths are 3.4em and there is a 1em margin on both sides. The min height is 1.4em without any margin. That's why I added the" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197214 (https://phabricator.wikimedia.org/T92700) (owner: 10Bmansurov) [01:01:02] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1124048 (10Yurik) Well, we can simply add an event with a custom tag to the RC - should be fairly simple to do, and nothing else. Adding something like "hide/show" list is fairly easy too (modeled o... [01:02:17] (03CR) 10Kaldari: [C: 04-1] Alpha: Quickly lookup a brief info about a wiki page (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195818 (owner: 10Bmansurov) [01:02:26] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: image gallery UI doesn't flip to suit RTL languages - https://phabricator.wikimedia.org/T91313#1124054 (10Deskana) >>! In T91313#1124030, @dr0ptp4kt wrote: > To eliminate any potential confusion, the fix is targeted at the image gallery and not other parts of... [01:03:35] EVIL FILLINGS [01:03:57] Hopefully they're adequately filled now. [01:06:59] Deskana: at first i thought you said filings. [01:07:11] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1124069 (10Jdlrobson) Note this extension doesn't need to be installed everywhere to start with so we could trial this on english wikivoyage first. Could the desc... [01:07:20] Deskana: i'm heading out of here...have a good night! [01:08:32] (03PS1) 10Mhurd: Icons for alpha and prod. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197263 [01:51:52] 10Wikipedia-App-Android-App: EGL-related crashes - https://phabricator.wikimedia.org/T74530#1124104 (10Krenair) [02:17:33] (03PS1) 10Bgerstle: implement RTL support for gallery [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197268 (https://phabricator.wikimedia.org/T91313) [02:20:22] (03PS2) 10Bgerstle: implement RTL support for gallery [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197268 (https://phabricator.wikimedia.org/T91313) [02:22:16] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1124114 (10Nicolas_Raoul) This description could be kept on Wikidata if there is a convenient UI to edit it from Wikivoyage. Of course, the description would be di... [02:32:23] (03CR) 10Bgerstle: [C: 031] "aside from a possibly unnecessary respondsToSelector: check, looks OK. left another comment about my uneasiness regarding the "effect all " (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197244 (owner: 10Mhurd) [02:32:41] bgerstle: ah cool. will check... [02:41:36] (03PS2) 10Mhurd: Fix so status bar tap causes web view to scroll to top on iOS 6 and 7. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197244 [02:41:42] bgerstle: amended [02:43:58] (03CR) 10Bgerstle: "i *think* I get why the fix works, but would appreciate some further clarification on how this jives w/ other image APIs tomorrow before +" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197006 (owner: 10Mhurd) [02:44:18] bgerstle: sounds good. ping me in the morning? [02:44:22] +1 [02:45:05] sometimes i hate apple.. [02:45:21] bgerstle: haha i know the feeling [02:45:25] "to enable this nifty 'scrolls to top' behavior, just set this property to YES" [02:45:34] "oh wait, you have multiple scroll views? nevermind" [02:45:38] lol [02:45:38] "oh and don't forget about this delegate" [02:45:42] "OH AND ONE MORE THING" [02:45:45] "HEY! LISTEN!" [02:46:17] out of curiosity, why does it think we have multiple scroll views besides the web view? [02:46:30] TOC? Read More? [02:46:36] yup [02:46:42] hrmph [02:47:05] and i suppose it's too tedious/unreliable to set all of their "scrollsToTop" = NO [02:47:20] and manually set their contentOffset properties from the WebViewController? [02:48:55] bgerstle: yeah that could work, until we forget the next time we add some scroll-y bit… at least this patch makes it more explicit what’s going on w/ the name “wmf_shouldScrollToTopOnStatusBarTap”. [02:49:35] yeah exactly [02:49:56] it's a trade-off [02:50:05] now we have views essentially competing w/ each-other [02:50:16] bgerstle: yeah. THANKS OBAMA! [02:50:20] one recursively disables another, which recursively re-enables it self next time it's on screen [02:50:33] etc. etc. [02:51:37] (03CR) 10Bgerstle: [C: 031] Fix so status bar tap causes web view to scroll to top on iOS 6 and 7. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197244 (owner: 10Mhurd) [02:51:41] bgerstle: since only one scroll view can ever react to status bar tap, i think it’s actually good that this method ensures the scroll view you want to be able to scroll-on-tap actually can [02:52:22] mhurd: i guess, i think we're just a special case that apple didn't optimize the API for [02:52:34] in their mind: only one scroll view at a time makes it easy [02:52:40] only one is in the hierarchy to respond at the event at once [02:53:10] or, it happens infrequently enough that you can locally special-case the child scrollViews to have scrollsToTop = NO and have their parent trigger it for them [02:55:00] mhurd outta steam for the day. see ya tomorrow [02:55:10] bgerstle: see ya! have a good night! [02:55:50] i think my Dr. Evil meme was the high point of my work day, though [02:55:50] pretty proud of that [02:55:59] bgerstle: lol [02:56:06] bgerstle: you do good work ;) [02:56:47] like i said, i learned from the best ;-) [02:57:09] one guy at my last job was renown in the company for his mastery of the GIF [02:57:13] and i was on his team [02:57:18] so essentially all day on IRC & slack [02:57:36] hahaha [02:57:49] black belt in GIFs [02:58:17] i told him i was doing him proud at my new job, and this was his response: http://i.imgur.com/lknhuhA.jpg [02:58:29] BAHAHAH [03:02:14] alright, and w/ that i'm outta here [03:02:15] o/ [03:07:43] (03CR) 10Fjalapeno: "Usually I like removing code and having a consistent API to perform the same task in multiple places." (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197244 (owner: 10Mhurd) [03:13:04] (03CR) 10Fjalapeno: "Why isn't the articles image list not getting updated?" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197006 (owner: 10Mhurd) [03:13:30] (03CR) 10Fjalapeno: [C: 031] Icons for alpha and prod. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197263 (owner: 10Mhurd) [03:22:41] (03CR) 10Fjalapeno: "Left some spruce up comments" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197005 (owner: 10Mhurd) [03:22:59] coreyfloyd: ah cool! thanks [03:23:34] mhurd: np -forgot about this earlier - sorry i am late [03:23:46] coreyfloyd: no worry! [05:48:37] (03PS1) 10Mhurd: Fix for expensive image data inflation for determing image size. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 [05:55:42] (03PS2) 10Mhurd: Fix for expensive image data inflation for determing image size. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 [06:39:26] 6Mobile-Web: MobileFrontend strips colours from a table on colours - https://phabricator.wikimedia.org/T87719#1124292 (10Nemo_bis) 5Open>3stalled >>! In T87719#1117153, @bmansurov wrote: > Can you clarify what you mean by 'spoilt'? I mean that there were no colours at all. I can't reproduce now, either: wer... [07:56:14] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1124332 (10Qgil) GSoC and Outreach have opened their application period, and we need to decide whether this project idea is on or out for this round. If you want a... [08:02:40] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1124333 (10Nicolas_Raoul) Qgil: I think there is matter for a GSoC task, and the benefits would be great for Wikivoyage but also as an experiment for all wikis. I... [08:52:03] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1124389 (10Andyrom75) Image description, more than image selection, are not objective data, so it should stay in the specific project. FYI description are managed... [08:54:00] (03PS1) 10OliverKeyes: Change the heading for privacy and terms to 'privacy and terms' [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197288 [09:13:24] (03CR) 10OliverKeyes: "(Note that I'm happy to amend the patch if Design or Product have thoughts on something other than 'Privacy and Terms' - my basic threshol" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197288 (owner: 10OliverKeyes) [09:31:40] morning! [09:40:25] hey joakino [09:41:49] hi phuedx [09:57:51] feeling really dense today... [10:02:42] joakino: i feel you [10:02:53] i had to leave quick last night because of water pipe problems [10:03:07] i haven't slept properly in a couple of months [10:03:12] buff [10:03:22] stresses of house work are really getting to me atm [10:03:29] can't seem to get started [10:03:45] anything in particular that's getting to you? [10:03:59] what's happening, broken stuff? [10:05:05] loft conversion [10:06:39] the noise is intolerable atm [10:06:44] going to bike to a coffee shop in a mo [10:06:48] just clearing down email [10:09:22] (03CR) 10Phuedx: [C: 032] "I haven't tested all of the commands but this looks good to me." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197092 (owner: 10Bmansurov) [10:10:32] (03Merged) 10jenkins-bot: Add dev-scripts for easy development [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197092 (owner: 10Bmansurov) [10:11:19] brb [10:12:08] constant interruptions [11:05:03] (03CR) 10Phuedx: [C: 032] Match header changes in MobileFrontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196700 (owner: 10Bmansurov) [11:06:16] (03Merged) 10jenkins-bot: Match header changes in MobileFrontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196700 (owner: 10Bmansurov) [11:06:30] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195995 (https://phabricator.wikimedia.org/T91796) (owner: 10Florianschmidtwelzow) [11:10:09] (03CR) 10Phuedx: "Hrrm:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195995 (https://phabricator.wikimedia.org/T91796) (owner: 10Florianschmidtwelzow) [11:10:24] ok gonna cycle to the shoppy shop [11:30:04] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1124852 (10Qgil) Good! We have a second mentor. Please add the skills needed and some microtasks, and we will add this task to the featured project ideas. [12:09:31] bleh – sketchy internet is sketchy [12:11:29] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Correct, i forgot to add the CodeMirror mode only, when CodeMirror is installed :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195995 (https://phabricator.wikimedia.org/T91796) (owner: 10Florianschmidtwelzow) [12:13:18] florian's gerriting while he's at work? [12:13:34] having my food made in front of me makes me feel special [12:16:21] 10Gather, 3Gather Sprint Diplodocus, 7Tracking: Tracking: Performance - https://phabricator.wikimedia.org/T92857#1124935 (10Aklapper) There already is a #Performance tag so I wonder why that is not used in combination (like [[ https://phabricator.wikimedia.org/maniphest/query/advanced/ | "In All Projects: Ga... [12:16:30] 10Gather, 3Gather Sprint Diplodocus, 7Tracking: Tracking: Performance in Gather - https://phabricator.wikimedia.org/T92857#1124937 (10Aklapper) [12:32:13] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1124953 (10NiharikaKohli) [12:33:28] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#831838 (10NiharikaKohli) @NIcolas_Raoul I added you as a co-mentor. Please add the skills needed and possible microtasks so we can open this to students. Thank you! [12:38:00] (03CR) 10Phuedx: Alpha: Load banner images on page load (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [12:38:08] (03CR) 10Phuedx: [C: 04-1] Alpha: Load banner images on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [12:53:35] 6Mobile-Web: Bug with border parameter for tables - https://phabricator.wikimedia.org/T92913#1125020 (10Aklapper) Please provide a link to where the problem can be seen. Also (probably unrelated in this case though), browser information always welcome :) [12:58:31] 6Mobile-Web: Bug with border parameter for tables - https://phabricator.wikimedia.org/T92913#1125033 (10Tvx1) Here is a link where you can see the problem: [https://en.m.wikipedia.org/wiki/2014_Formula_One_season#Teams_and_drivers] I generally use Safari as mobile browser, but through discussion with fellow ed... [13:02:16] (03CR) 10Bgerstle: "agree w/ corey's comments. thanks for following up on this, monte" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197005 (owner: 10Mhurd) [13:14:34] (03CR) 10Bgerstle: [C: 04-1] "def. a step in the right direction, but seem to be duplicating "isCached" logic in URLCache" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 (owner: 10Mhurd) [13:21:41] (03PS5) 10Phuedx: Footer changes [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/195552 [13:31:56] (03CR) 10Fjalapeno: Fix for expensive image data inflation for determing image size. (034 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 (owner: 10Mhurd) [13:42:05] (03CR) 10Florianschmidtwelzow: Alpha: Load banner images on page load (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [13:44:26] (03CR) 10Dbrant: [C: 032] Remove (R) from wordmark in ShareAFact image [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197098 (owner: 10BearND) [14:08:25] (03CR) 10Dbrant: [C: 032] Set text color in error popups for 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197077 (https://phabricator.wikimedia.org/T92851) (owner: 10BearND) [14:24:24] 6Mobile-Web: Table border parameter does not display right border on mobile - https://phabricator.wikimedia.org/T92913#1125251 (10Aklapper) p:5Normal>3Lowest [14:51:57] (03PS4) 10Dbrant: Cache pages on disk instead of ram. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196974 [15:26:17] dbrant: hey! [15:26:30] YuviPanda: hello! [15:26:33] dbrant: bearND just wanted to point out http://spdycheck.org/#en.wikipedia.org now :D very recent development :) [15:26:36] we have spdy enabled. [15:27:22] not sure what we can do, but am pretty sure we can use that to improve a lot of things in the apps :) [15:28:10] very interesting indeed [15:34:24] dbrant: yeah, so we can multiplex multiple requests (images, just content, etc) over one channel without re-connection overhead. [15:52:14] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android: Reuse the same WebView for visiting subsequent pages. - https://phabricator.wikimedia.org/T89828#1125513 (10Dbrant) a:3Dbrant [16:00:56] (03PS1) 10Dbrant: [WIP] Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 [16:06:36] (03CR) 10Phuedx: "@Jdlrobson, @MaxSem: what's going on with this patch?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192855 (owner: 10Jdlrobson) [16:09:10] dbrant: YuviPanda: That's so cool. Theoretically OkHttp handles that. AFAICS we don't have to change code. I do want to update it to the recently released 2.3.0 due to "Fix: Avoid crashing when cache writing fails due to a full disk." [16:09:50] bearND: yup :D you should test though, to make sure we’re making use of pipelining properly. Also the images / other requests are made by the webview, so that’s probably another channel... [16:12:04] 6Mobile-Web: MobileFrontend strips colours from a table on colours - https://phabricator.wikimedia.org/T87719#1125594 (10bmansurov) @Nemo_bis, I don't know of any changes related to this bug. Not sure about the component either. Please feel free to add one. [16:15:13] (03CR) 10Bmansurov: Alpha: Load banner images on page load (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [16:28:29] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1125628 (10JKatzWMF) @Yurik --do you have time to chat today about dev cost of this? part of the requirement includes T91444, will that be possible to have in the logs? @moushira - any concerns a... [16:28:33] (03PS2) 10Bmansurov: Make the tappable area of the reference drawer close button bigger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197214 (https://phabricator.wikimedia.org/T92700) [16:29:26] (03PS3) 10Bmansurov: Make the tappable area of the reference drawer close button bigger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197214 (https://phabricator.wikimedia.org/T92700) [16:29:48] (03PS3) 10Bgerstle: implement RTL support for gallery [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197268 (https://phabricator.wikimedia.org/T91313) [16:39:19] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: When I go to Special:Gather and see the collections I own they are illustrated with a page image - https://phabricator.wikimedia.org/T91675#1125663 (10Jhernandez) @jdlrobson I don't agree with the direction of this patch. For the UI the collection's ima... [16:40:42] (03CR) 10Jhernandez: "I don't agree about doing this in JS now. I've commented in https://phabricator.wikimedia.org/T91675#1125663" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197256 (https://phabricator.wikimedia.org/T91675) (owner: 10Jdlrobson) [16:44:26] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1125682 (10Jhernandez) I think we talked that having the collections appear on recent changes gives the community the sense that they need and have to moderate it, and I thought we were not going to... [16:45:44] [']p=;=p[]''''pk'k;p=kBV** [16:51:20] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1125689 (10JKatzWMF) @jhernandez. Maybe I misunderstood. Recent change is not something I want to push to, but "logs" is a separate feed that is more about record keeping and is not as actively pa... [16:51:44] (03Merged) 10jenkins-bot: Don't check watch status on special pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197221 (https://phabricator.wikimedia.org/T92580) (owner: 10Jdlrobson) [16:55:22] (03PS7) 10Bmansurov: Alpha: Quickly lookup a brief info about a wiki page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195818 [17:00:43] bmansurov: ping me when you want to chat botttzzz [17:00:52] phuedx: sure [17:02:22] 6Mobile-Web, 10MobileFrontend-Feature-requests, 10MediaWiki-ResourceLoader: ResourceLoaderImage module css rules should be more configurable - https://phabricator.wikimedia.org/T78215#1125720 (10matmarex) [17:03:14] (03PS4) 10Jhernandez: Hygiene: Use one api request to access meta data and members for viewing collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196641 (https://phabricator.wikimedia.org/T92580) (owner: 10Jdlrobson) [17:03:47] (03CR) 10Jhernandez: [C: 032] "Added fixme for improving the api query when bug https://phabricator.wikimedia.org/T92865 is resolved." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196641 (https://phabricator.wikimedia.org/T92580) (owner: 10Jdlrobson) [17:05:36] 3Gather Sprint Diplodocus, 5Patch-For-Review: Optimize Special:Gather/User/XXX loading - https://phabricator.wikimedia.org/T92862#1125726 (10Jhernandez) 5Open>3Resolved @jdlrobson yes, it was the same. I've added a fixme on your patch and merged it (so that we use lstids when the bug is solved). Closing... [17:10:56] (03Merged) 10jenkins-bot: Hygiene: Use one api request to access meta data and members for viewing collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196641 (https://phabricator.wikimedia.org/T92580) (owner: 10Jdlrobson) [17:11:20] (03PS3) 10Jhernandez: Reduce API requests on any given non-special page to 1 [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197222 (https://phabricator.wikimedia.org/T92580) (owner: 10Jdlrobson) [17:11:22] (03CR) 10jenkins-bot: [V: 04-1] Reduce API requests on any given non-special page to 1 [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197222 (https://phabricator.wikimedia.org/T92580) (owner: 10Jdlrobson) [17:12:58] (03PS4) 10Jhernandez: Reduce API requests on any given non-special page to 1 [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197222 (https://phabricator.wikimedia.org/T92580) (owner: 10Jdlrobson) [17:13:00] (03PS6) 10Jhernandez: Ability to see or filter on lists containing title [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196739 (owner: 10Yurik) [17:13:49] (03CR) 10Jhernandez: "Rebased with previous commit and master" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197222 (https://phabricator.wikimedia.org/T92580) (owner: 10Jdlrobson) [17:14:05] phuedx: wanna hang? [17:14:07] (03CR) 10jenkins-bot: [V: 04-1] Reduce API requests on any given non-special page to 1 [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197222 (https://phabricator.wikimedia.org/T92580) (owner: 10Jdlrobson) [17:14:10] joakino_, please don't submit my patches - makes it much harder to work - the owner of the patch should be responsible )) [17:14:14] bmansurov: yeeeeeah [17:14:27] (03CR) 10Jhernandez: "Crap, rebasing/cherrypicking the dependent commit I submitted this one... sorry" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196739 (owner: 10Yurik) [17:14:44] * yurik loves gerrit [17:14:51] ^ that [17:14:51] yurik: sorry, just wanted to rebase the dependent one :( [17:14:59] hehe, i hear u [17:17:35] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Configure & document iOS build hardware - https://phabricator.wikimedia.org/T92880#1125770 (10Fjalapeno) a:3Fjalapeno [17:18:15] (03CR) 10Jhernandez: [C: 031] "Looks good, will test when the previous patch is ready." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197222 (https://phabricator.wikimedia.org/T92580) (owner: 10Jdlrobson) [17:19:40] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Performance: onMakeGlobalVariablesScript causes too many internal hits to API - https://phabricator.wikimedia.org/T92580#1125774 (10Jhernandez) Merged patches, the one waiting for merging is https://gerrit.wikimedia.org/r/#/c/197222/ which has unmerged... [17:28:42] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Run unit tests before builds and save build reports for viewing - https://phabricator.wikimedia.org/T91788#1125795 (10KLans_WMF) We'll "get this for free" with some of the other work; this should be an acceptance criteria of https://phabricator.wikimedia.org/... [17:28:53] bmansurov: what's yer github username? [17:30:05] mhurd, let me wrap up my date formatter batch, then we can go through your patches? [17:30:10] s/batch/patch/ [17:30:34] bgerstle: sure! [17:31:09] bgerstle: i’ll grab coffee in the mean time [17:31:20] (03PS2) 10Dbrant: [WIP] Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 [17:33:06] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 (owner: 10Dbrant) [17:33:19] phuedx: 6ahodir [17:36:05] dbrant: you might like the first couple of changes in https://github.com/square/picasso/blob/master/CHANGELOG.md [17:37:53] bearND: yay!! that's very cool. we should update asap [17:38:04] dbrant: looking into it right now [17:39:00] (03PS5) 10Dbrant: Cache pages on disk instead of ram. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196974 [17:39:43] whoa, my inbox is asploded [17:41:58] (03PS3) 10Dbrant: [WIP] Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 [17:42:03] 10Gather: I see a share button at the top of the list - https://phabricator.wikimedia.org/T91002#1125933 (10JKatzWMF) [17:42:35] 10Gather: I see a share button at the top of the list - https://phabricator.wikimedia.org/T91002#1072394 (10JKatzWMF) [17:43:06] 10Gather: I see a share button at the top of the list - https://phabricator.wikimedia.org/T91002#1072394 (10JKatzWMF) @jdlrobson Apologies--updated description [17:43:44] (03PS1) 10Jhernandez: Fix overflow and scrolling in the content overlay. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197370 (https://phabricator.wikimedia.org/T92791) [17:43:52] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Fix scrolling behaviour - https://phabricator.wikimedia.org/T92791#1125945 (10Jhernandez) a:3Jhernandez [17:44:03] yurik are you around? [17:44:17] JonKatz, yep [17:44:58] yurik lets hop on a hangout. I would like to learn more about implications of logging collections [17:45:18] k [17:45:35] yurik cool, one sec [17:49:09] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Fix scrolling behaviour - https://phabricator.wikimedia.org/T92791#1125968 (10Jhernandez) Patch 197370 fixes the hidden areas on scroll and spacing. Here is how it was before patch (notice hidden area at the bottom of the modal): {F99375} Here it is f... [17:54:53] (03CR) 10Mhurd: implement RTL support for gallery (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197268 (https://phabricator.wikimedia.org/T91313) (owner: 10Bgerstle) [17:56:13] (03PS2) 10Mhurd: Some small cleanups. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197005 [17:56:25] Deskana: btw, here's the bug regarding automatic following of redirects in prefixsearch results: https://phabricator.wikimedia.org/T92796 [18:02:16] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Fix scrolling behaviour - https://phabricator.wikimedia.org/T92791#1125999 (10Jhernandez) @jkatzwmf I've been researching and it seems like consistently disabling scroll propagation to the content behind is fairly difficult and inconsistent across brows... [18:13:00] (03PS1) 10BearND: Updated SquareUp libraries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197376 [18:18:24] (03CR) 10Dr0ptp4kt: [C: 032] "I'm merging this in, but @Fjalapeno and @mhurd would you please follow up with each other in case of any code hygiene tasks?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197244 (owner: 10Mhurd) [18:18:43] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Fix scrolling behaviour - https://phabricator.wikimedia.org/T92791#1126018 (10Jhernandez) One possible hack to try if we actually tried to block the body would be applying this css to the body (via a class or directly) when the modal appeared: [18:18:49] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android: Login/create account/captcha buttons not visible in 2.3 - https://phabricator.wikimedia.org/T92850#1126019 (10bearND) The 'Got it' button in the ToC onboarding is affected, too. [18:19:11] (03PS1) 10BearND: Roll appcompat-v7 back to 21.0.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197377 [18:19:14] (03PS2) 10Dr0ptp4kt: Icons for alpha and prod. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197263 (owner: 10Mhurd) [18:25:18] (03PS3) 10Mhurd: Icons for alpha and prod. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197263 [18:25:26] dr0ptp4kt: ^ [18:36:41] (03PS4) 10Dr0ptp4kt: Icons for dev (default), alpha, and prod. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197263 (owner: 10Mhurd) [18:38:34] (03CR) 10Dr0ptp4kt: [C: 032] Icons for dev (default), alpha, and prod. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197263 (owner: 10Mhurd) [18:39:36] dr0ptp4kt: how do I push a branch to gerrit again - or am I not able to? [18:40:38] coreyfloyd: i'm not sure what magic the git review command uses under the hood to submit branches. but, as for submitting tags....git checkout -b throwawaybranch [18:40:43] do stuff, commit [18:41:23] (03PS3) 10Mhurd: Some small cleanups. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197005 [18:41:24] git tag -a -m "Tag: description" [18:41:30] git push gerrit [18:41:46] what if i tag commit that isn't on gerrit? [18:42:08] bgerstle: coreyfloyd i amended https://gerrit.wikimedia.org/r/197005 [18:42:37] dr0ptp4kt: will it also push the commits associated with the tag? [18:42:58] coreyfloyd: yes [18:44:07] (03CR) 10Dbrant: [C: 032] Updated SquareUp libraries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197376 (owner: 10BearND) [18:44:30] (03PS1) 10Yurik: Unit tests and a number of minor bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197384 [18:44:31] dr0ptp4kt: ok - that wont work anyways - i need a branch… [18:45:06] JonKatz, ^^ [18:45:14] hmm, where's gather team? [18:45:36] (03CR) 10jenkins-bot: [V: 04-1] Unit tests and a number of minor bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197384 (owner: 10Yurik) [18:48:22] (03PS1) 10Bgerstle: Fix NSDateFormatter issues [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197387 [18:48:31] (03PS2) 10Bgerstle: Fix NSDateFormatter issues [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197387 [18:48:42] (03CR) 10Dbrant: [C: 032] "agreed :(" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197377 (owner: 10BearND) [18:49:00] mhurd: sorry i had to eat lunch and do another minor task. sorry it took so long [18:49:17] the patch is up, but it's only 10 min until our process review meeting, which i'd like to prepare for [18:49:22] how about we have a code review extravaganza afterwards? [18:50:25] (03PS2) 10Yurik: Unit tests and a number of minor bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197384 (https://phabricator.wikimedia.org/T92830) [18:50:47] bgerstle: sure! [18:51:13] (03Merged) 10jenkins-bot: Roll appcompat-v7 back to 21.0.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197377 (owner: 10BearND) [18:51:35] (03CR) 10jenkins-bot: [V: 04-1] Unit tests and a number of minor bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197384 (https://phabricator.wikimedia.org/T92830) (owner: 10Yurik) [18:52:10] (03PS3) 10Bgerstle: Fix NSDateFormatter issues [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197387 [18:52:53] (03PS2) 10Mhurd: Fix for image saving bug. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197006 [18:53:06] (03PS4) 10Mhurd: Some small cleanups. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197005 [18:53:59] (03PS3) 10Mhurd: Fix for expensive image data inflation for determing image size. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 [18:55:19] (03PS6) 10Dbrant: Cache pages on disk instead of ram. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196974 [18:56:36] (03PS4) 10Dbrant: [WIP] Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 [18:57:06] (03PS3) 10Yurik: Unit tests and a number of minor bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197384 (https://phabricator.wikimedia.org/T92830) [18:58:55] coreyfloyd: you may want to look at http://www.mediawiki.org/wiki/Gerrit/Advanced_usage [18:59:51] coreyfloyd: also, there was an earlier version of the make-release.py script in the android project that i think created a release branch in gerrit. but i don't remember how it did that off the top of my head [19:00:05] coreyfloyd: disconnecting, reconnecting in hangout soon [19:01:31] (03PS1) 10Robmoen: Bind events to collections overlay only when created [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197390 [19:02:34] dbrant: [19:02:43] go here: https://plus.google.com/hangouts/_/wikimedia.org/team-process?authuser=0 [19:02:56] (03PS4) 10Yurik: Unit tests and a number of minor bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197384 (https://phabricator.wikimedia.org/T92830) [19:02:57] I forgot to add you to the invit to our prcss review meeting :-| [19:03:40] (03PS1) 10Aaron Schulz: Avoid master queries on page view for block checks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197392 [19:04:31] (03PS2) 10Aaron Schulz: Avoid master queries on page view for block checks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197392 (https://phabricator.wikimedia.org/T92357) [19:04:33] (03CR) 10jenkins-bot: [V: 04-1] Unit tests and a number of minor bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197384 (https://phabricator.wikimedia.org/T92830) (owner: 10Yurik) [19:06:27] (03CR) 10Legoktm: [C: 032] Avoid master queries on page view for block checks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197392 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz) [19:07:24] bgerstle: haha [19:07:49] (03Merged) 10jenkins-bot: Avoid master queries on page view for block checks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197392 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz) [19:13:27] mhurd: come grab noms [19:16:00] mhurd, seems to be resolved: https://en.wikipedia.org/w/api.php?action=query&prop=coordinates&coprimary=all&titles=Santa_Clara,_California [19:20:55] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Fix scrolling behaviour - https://phabricator.wikimedia.org/T92791#1126127 (10JKatzWMF) @jhernandez, not a big deal if we can't stop outside scrolling. Main issue is if a user can scroll up and down the overlay, which previously they could not. [19:22:35] (03CR) 10Florianschmidtwelzow: [C: 04-1] "I love this idea (always i try to use hovercards on mobile :P)!" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195818 (owner: 10Bmansurov) [19:24:05] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Read more autogenerated? suggestions don't make much sense outside of content namespaces - https://phabricator.wikimedia.org/T92787#1126146 (10Deskana) >>! In T92787#1123474, @Legoktm wrote: > Why mainspace as opposed to content namespaces? Because detecti... [19:24:35] (03CR) 10Florianschmidtwelzow: Infobox: Add link to commons category overlay (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197110 (https://phabricator.wikimedia.org/T92687) (owner: 10Florianschmidtwelzow) [19:26:03] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Read more autogenerated? suggestions don't make much sense outside of content namespaces - https://phabricator.wikimedia.org/T92787#1126150 (10Legoktm) You could just fetch https://www.mediawiki.org/w/api.php?action=query&meta=siteinfo&siprop=namespaces and... [19:36:31] (03CR) 10Florianschmidtwelzow: Promote TalkOverlay to stable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [19:40:47] sorry bmansurov -- george was super-tired [19:41:16] phuedx: np, i was just tinkering with your code [19:41:30] (03PS8) 10Bmansurov: Alpha: Quickly lookup a brief info about a wiki page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195818 [19:42:59] (03PS9) 10Bmansurov: Alpha: Quickly lookup a brief info about a wiki page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195818 [19:43:21] (03PS4) 10MaxSem: WIP: aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 [19:44:16] phuedx, ^^^ is actually very close to done, the only thing remaining is to actually invoke that aggregator. and think about a few things, oh yea [19:44:26] \o/ [19:44:37] any comments so far? [19:46:10] MaxSem: i'll shall give it a read after a short bouldering session [19:46:20] bouldering o_0 [19:46:42] also, why don't americans say "boldering"? [19:47:35] (03PS6) 10Florianschmidtwelzow: Promote TalkOverlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) [19:47:39] hah! [19:53:44] (03CR) 10jenkins-bot: [V: 04-1] Promote TalkOverlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [19:57:51] hi, who knows anyting about phpunit in composer.json? tests don't run, seems like missing param https://gerrit.wikimedia.org/r/#/c/197384/ [19:57:55] MaxSem, ^ :) [20:00:28] mmm, why are you adding phpunit to composer.json, yurik ? we have a special job for phpunit [20:01:45] bgerstle: saw your comment about recount!!!! scandal [20:01:53] :-P [20:02:00] MaxSem, per https://www.mediawiki.org/wiki/Continuous_integration/Test_entry_points [20:02:01] bgerstle: you are a Floridian... [20:02:02] i'm from FL, you should've known [20:02:04] hahahahaha [20:03:29] MaxSem, so should i remove it? [20:03:36] bgerstle: I wasn't counting/rolling up the subitems...but mayeb I shoudl have [20:03:49] no idea.... maybe Krinkle can help? ^^^ [20:03:50] i thought it was 6 w/o the sub-item [20:04:27] "* Release process + + +++" [20:04:30] ah damnit [20:04:32] MaxSem: What's up [20:04:42] something was weird w/ the pad or something [20:04:45] Krinkle, hi, who knows anyting about phpunit in composer.json? tests don't run, seems like missing param https://gerrit.wikimedia.org/r/#/c/197384/ [20:04:50] only by pasting it do i see the true count [20:04:56] * do you [20:05:34] yurik: Don't run phpunit from extension repos. [20:05:46] Remove it from composer.json, it doesn't work like that [20:06:02] Krinkle, https://www.mediawiki.org/wiki/Continuous_integration/Test_entry_points#Testing_PHP [20:06:04] Unless your extension is a standalone php-based project, it cannot and should not run phpunit. [20:06:20] It is an extension to MediaWiki, tests are run from there, not from the extension. [20:06:53] Krinkle, from where? yes, its an ext [20:07:05] yurik: It already runs tests. [20:07:10] (03PS5) 10Yurik: Unit tests and a number of minor bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197384 (https://phabricator.wikimedia.org/T92830) [20:07:14] "mediawiki-extensions-hhvm" [20:07:23] Keep composer.json for linting and phpcs [20:07:29] ok, removed, thx [20:08:04] Krinkle, do i need to do anything to enable phpunit on the ext/ [20:08:09] i just added ut [20:08:12] unittests [20:09:05] yurik: It is already enabled. [20:09:26] thx [20:09:30] Extensions plug into MediaWIki and register their tests there. Then runnining mediawiki-core's phpunit will include those extensions. [20:09:36] Same for QUnit. [20:14:19] mhurd just going over list of changes now [20:14:22] wanna hangout in a bit? [20:14:28] bgerstle: sure! [20:15:34] (03PS5) 10MaxSem: WIP: aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 [20:18:45] bgerstle: hangout now? [20:18:49] bgerstle: would you please send me the etherpad url from our regular friday meeting? i somehow misplaced the url and can't seem to find it in the calendar [20:18:59] mhurd mind if i go through some of your newer amendments first? [20:19:07] then we can discuss them [20:19:11] bgerstle: sure [20:19:13] kristenlans: when are the quarterly planning meetings again? [20:19:20] (03PS2) 10OliverKeyes: Change the heading for privacy and terms to 'privacy and terms' [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197288 [20:20:14] (03CR) 10Bgerstle: [C: 04-1] "there seems to be a regression in "fast-path/no-op" logic. see comment about !self.isPlaceholder" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197005 (owner: 10Mhurd) [20:21:38] mhurd ok, seems like that was the only one which was amended [20:21:43] lemme grab my charger [20:21:58] coreyfloyd: do you want to hop in on review? you mentioned some stuff on 2 of mhurd's patches [20:22:51] bgerstle: sure [20:23:26] coreyfloyd: although i think we're thinking along the same lines [20:23:52] jhobs: Hey Jeff, I’m ready for 1:1 whenever you are [20:24:01] feel free to skim my comments, and if you agree, you can wait until mhurd and i talk through it and see what, if any, changes come from that [20:24:54] kaldari: I've been in the hangout since 4, I just figured you got caught up in a meeting or something. I have another meeting in a few minutes that ends at 2:30 SF time, are you free after that? [20:25:27] jhobs: yes, sorry about that! I’m free at 2:30 [20:25:54] kaldari: totally fine, see you then [20:26:44] (03CR) 10Bgerstle: "disregard !self.isPlaceholder comment" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197005 (owner: 10Mhurd) [20:29:33] (03CR) 10Bgerstle: "no need for weakSelf here since block execution is guaranteed" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197005 (owner: 10Mhurd) [20:29:35] (03CR) 10Fjalapeno: [C: 031] Some small cleanups. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197005 (owner: 10Mhurd) [20:29:40] bearND: see my pm? [20:30:26] dbrant: just noticed [20:32:04] dbrant: looks my inline comments haven't made it since they were written for an earlier PS. Will update [20:32:15] https://gerrit.wikimedia.org/r/#/c/196974/ [20:32:45] (03CR) 10BearND: "Comments inline." (036 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196974 (owner: 10Dbrant) [20:33:01] dbrant: ah, found the right button, lol [20:33:42] lol [20:53:20] dbrant: 3/26 [20:56:43] (03CR) 10Bgerstle: "some comments about refactoring to clarify intent" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 (owner: 10Mhurd) [21:05:23] (03CR) 10Fjalapeno: "follow up to brians comment" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 (owner: 10Mhurd) [21:05:38] (03CR) 10Kaldari: [C: 032] Make the tappable area of the reference drawer close button bigger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197214 (https://phabricator.wikimedia.org/T92700) (owner: 10Bmansurov) [21:06:53] (03Merged) 10jenkins-bot: Make the tappable area of the reference drawer close button bigger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197214 (https://phabricator.wikimedia.org/T92700) (owner: 10Bmansurov) [21:07:45] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android: Login/create account/captcha buttons not visible in 2.3 - https://phabricator.wikimedia.org/T92850#1126557 (10bearND) 5Open>3stalled Gerrit patch to move back to previous appcompat version got merged: https://gerrit.wikimedia.org/r/#/c/197377/ Ke... [21:12:57] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Services, 3Mobile-App-Sprint-53-Android: Deploy experimental version of mobile apps content service - https://phabricator.wikimedia.org/T91794#1126569 (10bearND) a:3bearND [21:14:38] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Services, 3Mobile-App-Sprint-53-Android: Deploy experimental version of mobile apps content service - https://phabricator.wikimedia.org/T91794#1126581 (10yuvipanda) Does this depend on restbase? If so restbase itself needs to be deployed on beta [21:16:30] coreyfloyd: rofl @ your gif [21:17:09] dbrant: I needed a way to communicate my joy for you and bearND [21:18:35] (03CR) 10Kaldari: [C: 032] Alpha: Quickly lookup a brief info about a wiki page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195818 (owner: 10Bmansurov) [21:20:13] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Services, 3Mobile-App-Sprint-53-Android: Deploy experimental version of mobile apps content service - https://phabricator.wikimedia.org/T91794#1126591 (10GWicke) @yuvipanda, it doesn't absolutely depend on restbase, but for a consistent public API it w... [21:20:21] (03Merged) 10jenkins-bot: Alpha: Quickly lookup a brief info about a wiki page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195818 (owner: 10Bmansurov) [21:21:17] ^ woohoo, thanks for this feature bmansurov! :D [21:21:30] FlorianSW: yay, I'm excited too! [21:21:47] can't wait to see it on wikipedias :) [21:21:57] (03CR) 10Bgerstle: [C: 04-1] "there are some "big picture" concerns being hinted at here, but address the one refactor comment & add a "specs" file for testing some of " (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197006 (owner: 10Mhurd) [21:22:11] FlorianSW: that would be awesome [21:22:51] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Services, 3Mobile-App-Sprint-53-Android: Deploy experimental version of mobile apps content service - https://phabricator.wikimedia.org/T91794#1126596 (10bearND) @yuvipanda Yes, it does depend on RESTBase. @Mobrovac mentioned we could use https://wiki... [21:24:10] (03CR) 10Fjalapeno: [C: 031] Fix NSDateFormatter issues [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197387 (owner: 10Bgerstle) [21:27:52] (03CR) 10Fjalapeno: implement RTL support for gallery (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197268 (https://phabricator.wikimedia.org/T91313) (owner: 10Bgerstle) [21:28:07] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Services, 3Mobile-App-Sprint-53-Android: Deploy experimental version of mobile apps content service - https://phabricator.wikimedia.org/T91794#1126624 (10GWicke) @bearND, we do have a 'services' project too, but the problem is that there's afaik no con... [21:30:04] (03PS1) 10Yurik: Migrated from Gather.php to extension.json [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197417 [21:31:08] (03PS2) 10Yurik: Migrated from Gather.php to extension.json [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197417 (https://phabricator.wikimedia.org/T91802) [21:32:01] mhurd: http://alcatraz.io/ [21:32:10] mhurd: install then install vvdocumentor [21:32:28] mhurd: then you just need to type "///" above any method or property in the header [21:32:32] kaldari: ready for 1:1 when you are [21:32:34] (03CR) 10jenkins-bot: [V: 04-1] Migrated from Gather.php to extension.json [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197417 (https://phabricator.wikimedia.org/T91802) (owner: 10Yurik) [21:32:41] ok... [21:33:48] yurik: turns out the problem was caused by a link to a direct download for some reason [21:34:42] jhobs, can you work around it? [21:35:15] legoktm, https://gerrit.wikimedia.org/r/#/c/197417/ any thoughts [21:35:25] 10Wikipedia-App-Android-App, 6WMF-Legal: Share A Fact images do not include license or attribution info about the image - https://phabricator.wikimedia.org/T91811#1126648 (10Legoktm) 5Resolved>3declined Changing status to reflect intention. [21:36:12] yurik: extension.json doesn't support ResourceModuleSkinStyles yet, there's a bug for that. what's wrong with the remoteExtPath being Gather/resources ? Is Gather deployed in production yet? [21:36:36] yurik: yeah the link doesn't have to be a direct download so it's not a big deal, just weird [21:36:59] legoktm, not yet, but soon, wanted to migrate it. what should i do in it to make it work and remove dups? [21:38:27] legoktm, sorry, th ext is not in prod yet, we are rapidly moving towards deployment. The path - i have no idea which one is the right path - script suggested something different from what was in the file already. [21:38:44] legoktm, please advise on how it should be done [21:40:09] yurik: the extpath looks fine to me, I think it was wrong before. https://phabricator.wikimedia.org/T91566?workflow=create needs to be fixed, I can probably work on that today or tomorrow. [21:41:25] legoktm, how should i make this patch to the "workable" state? This way i will do partial migration now, and a bit later? Or is it all or nothing? [21:42:24] yurik: you could use the "callback" feature (https://www.mediawiki.org/wiki/Manual:Extension_registration#Customizing_registration) but that's just a hack, it would be much better if you just did it all at once [21:42:30] it should only be a few more days? [21:43:52] (03CR) 10Fjalapeno: [C: 031] implement RTL support for gallery [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197268 (https://phabricator.wikimedia.org/T91313) (owner: 10Bgerstle) [21:44:50] coreyfloyd: was afk. installing alcatraz now... [21:50:16] dr0ptp4kt: amending my outstanding patches... [21:51:31] bgerstle: we said https://gerrit.wikimedia.org/r/#/c/197005/ was good for now? [21:51:55] bgerstle: ah nevermind - i was going to add nil check for block [21:51:57] right [21:52:04] took me a second to remember [21:52:24] pick either assert or invoke-if-not-nil. [21:52:44] the latter is more in line w/ apple conventions [21:52:54] (if you agree with apple conventions ;-) ) [21:52:58] bgerstle: ya it’s what i’ve done in the past as well [21:54:09] (03PS5) 10Dr0ptp4kt: Address nested parentheses in Share a Fact [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196298 [21:55:00] legoktm, oki, thx, will wait [21:55:26] 6Mobile-Web, 6Services: Image-positioning service - https://phabricator.wikimedia.org/T88633#1126677 (10BGerstle-WMF) > ... and makes it convenient to retrieve alignment along with other image info (prop=imageinfo?) IMO this is a separate concern and we should stick to solving the root problem: helping the us... [21:56:46] (03CR) 10Yurik: "Per legoktm, doesn't support ResourceModuleSkinStyles, need to wait a few days." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197417 (https://phabricator.wikimedia.org/T91802) (owner: 10Yurik) [21:58:22] (03PS6) 10MaxSem: WIP: aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 [21:58:31] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Services, 3Mobile-App-Sprint-53-Android: Deploy experimental version of mobile apps content service - https://phabricator.wikimedia.org/T91794#1126679 (10GWicke) @bearND & I just chatted a bit about this on IRC & decided to set up a simple labs instanc... [22:00:25] (03PS6) 10Dr0ptp4kt: Address nested parentheses in Share a Fact [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196298 [22:00:32] 10Gather, 5Patch-For-Review: Use extension.json, deprecate use of Gather.php for registering config - https://phabricator.wikimedia.org/T91802#1126682 (10Yurik) [22:00:58] bgerstle: coreyfloyd ^^ would you please re-review? [22:01:38] (03PS2) 10Robmoen: Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 [22:03:40] (03PS3) 10Robmoen: Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 [22:05:06] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Handle nested parentheses in Share a Fact even better - https://phabricator.wikimedia.org/T91846#1126687 (10dr0ptp4kt) https://gerrit.wikimedia.org/r/#/c/196298/ [22:08:57] (03PS5) 10Mhurd: Some small cleanups. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197005 [22:09:39] bgerstle: coreyfloyd ^ amended to check if block is nil [22:09:53] dr0ptp4kt: sure [22:13:18] mhurd sorry was writing a small novel [22:13:42] mhurd in exchange, will you weigh in on (and if possible merge) my patches? [22:14:21] bgerstle: ya! [22:15:54] (03CR) 10Fjalapeno: [C: 031] "me likey" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196298 (owner: 10Dr0ptp4kt) [22:16:48] (03CR) 10Fjalapeno: [C: 031] Some small cleanups. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197005 (owner: 10Mhurd) [22:17:22] (03CR) 10Mhurd: [C: 032] Fix NSDateFormatter issues [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197387 (owner: 10Bgerstle) [22:17:43] dr0ptp4kt: mhurd: can you send me your certificates / private keys? [22:17:56] I need to install on the build server [22:18:35] (03CR) 10Bgerstle: [C: 031] "thanks for addressing my comments! just left one nit-picker if you're up for one more round" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197005 (owner: 10Mhurd) [22:19:00] dr0ptp4kt: mhurd - if you want to do it in one step you can just export your dev profile from xcode: https://www.dropbox.com/s/707oiej7fbm2w6v/Screenshot%202015-03-17%2018.18.42.png?dl=0 [22:19:21] coreyfloyd: i think i have the distro certs as well [22:19:32] dr0ptp4kt: if you're busy i can send [22:20:13] http://i.imgur.com/lhjhbB9.gif [22:21:41] coreyfloyd: lol ok just a sec... [22:23:55] (03CR) 10Bgerstle: [C: 031] "the tests...they're so...beautiful!" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196298 (owner: 10Dr0ptp4kt) [22:24:11] coreyfloyd: NICE! [22:24:14] i love colbert memes [22:25:00] i guess what i meant by "i have time for one more bug fix" was actually "i have time to write one email and review more patches" [22:25:26] d'oh need to rebase my RTL patch [22:27:54] (03PS4) 10Bgerstle: implement RTL support for gallery [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197268 (https://phabricator.wikimedia.org/T91313) [22:28:02] mhurd rebased ^ please +2 [22:28:04] coreyfloyd: it’s trying to export other keys which are associated with my itunes acct… [22:28:14] bgerstle: checking... [22:28:38] mhurd: oh yeah - if you have personal stuff in there it will suck it out [22:28:47] mhurd: in that case just do it from keychain utility [22:29:42] mhurd: http://www.aquafadas.com/en/documentation/sample-page/developer-apple-com-2/how-to-share-an-apple-certificate-and-its-private-key/ [22:30:27] (03CR) 10Mhurd: [C: 032] implement RTL support for gallery [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197268 (https://phabricator.wikimedia.org/T91313) (owner: 10Bgerstle) [22:31:31] mhurd coreyfloyd: i got mine exported, how should i send it? [22:31:43] (i.e. vibber's w/ the dist cert key) [22:31:51] (03CR) 10Dr0ptp4kt: Address nested parentheses in Share a Fact (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196298 (owner: 10Dr0ptp4kt) [22:34:35] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: image gallery UI doesn't flip to suit RTL languages - https://phabricator.wikimedia.org/T91313#1079644 (10BGerstle-WMF) [22:34:59] coreyfloyd: you get my msg? [22:37:52] coreyfloyd: email it to you [22:37:58] *emailed* [22:38:38] mhurd coreyfloyd dr0ptp4kt i'm heading out for the night. anything quick before i go? [22:39:00] bgerstle: i’m good! merged your patches. amending mine based on your comments [22:39:09] good night bgerstle! [22:39:17] mhurd did i re-review yours? [22:39:54] bgerstle: haven’t submitted yet. if i just add WMFDispatchUtilities.h/m as you suggested can i assume the +1 stands? [22:40:30] yeah definitely [22:40:36] that was a nit-pick anyway. i think i +1'd [22:41:11] i can look at https://gerrit.wikimedia.org/r/#/c/197006/ and https://gerrit.wikimedia.org/r/#/c/197277/ if you amend them [22:41:16] bgerstle: which message? [22:41:20] on gchat [22:41:39] bgerstle: cool. oh wait… how would you structure the WMFDispatchUtilities.h/m ? are these category on something? inline? [22:41:55] bgerstle: i'm good. you have a good night [22:42:05] mhurd C function [22:42:22] bgerstle: oh, duh :) [22:42:24] mhurd dispatch_async_main(optionalBlock) [22:42:37] coreyfloyd: i know you had some dispatch utils in that other patch [22:42:44] is that essentially how you did it? ^ [22:42:48] i still mean to go through that and amend it [22:43:05] bgerstle: k [22:43:12] actually... what does dispatch_(a)sync do if the block is nil? [22:43:50] mhurd now that i think about it... this isn't really worth refactoring into a shared utility [22:43:55] blocks can have many signatures [22:43:58] bgerstle: hehe ok if i just amend with a #todo comment ? [22:44:04] and the arguments you pass them can be from the surrounding scope [22:44:21] so... [22:44:22] haha [22:44:43] TBH i probably wouldn't have refactored that into a shared thing and just done the if (block) { block(); } inline [22:45:08] mhurd although... a macro would probably the MOST reusable, flexible solution [22:45:19] bgerstle: k. for now unwind that and add a #todo comment? [22:45:24] safe_invoke(block)(block, args, here) [22:45:36] unless you want to try your hand and macros ;-) [22:46:07] bgerstle: haha i just want to get to the remaining patches w/o staying till 11pm [22:46:13] actually i don't think a macro would work eitehr [22:46:14] either* [22:46:15] damnit [22:46:33] mhurd yeah... you shouldn't be staying so late! [22:46:38] burnout's bad, m'kay [22:47:53] bgerstle: k. adding a “#warning TODO” note and moving on [22:48:28] bgerstle: #warning TODO: - this should live in a "dispatch utilities" file, and not an ObjC instance method [22:50:05] (03PS6) 10Mhurd: Some small cleanups. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197005 [22:50:33] (03PS7) 10Mhurd: Some small cleanups. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197005 [22:50:43] bgerstle: yeah I had some dispatch short cuts. Need to clean that up though. [22:50:53] dr0ptp4kt: this is ready: https://gerrit.wikimedia.org/r/#/c/197005/ [22:51:20] bgerstle: I didn't have a method which checks for the block = nil though [22:51:34] k [22:52:06] mhurd: stop working! [22:54:11] coreyfloyd: lol [22:54:25] coreyfloyd: it’s only 4 here ;) [22:54:41] mhurd coreyfloyd: *evil scientist laugh* i've done it! https://www.irccloud.com/pastebin/K2Dn7P0J [22:54:54] not pretty, but ;-) [22:54:59] DRY TO THE EXTREME [22:55:16] bgerstle: hehe [22:55:35] i'll just leave that there ;-) while i got to the dog park [22:55:59] s/got/go/ [22:56:03] mhurd don't work til 11! [22:56:06] tis verboten [22:57:15] later folks o/ [22:59:26] (03PS3) 10Mhurd: Fix for image saving bug. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197006 [23:00:17] MaxSem: took a pass on the backlog, what's the email that you will be sending ? [23:05:14] (03CR) 10Dr0ptp4kt: [C: 032] Some small cleanups. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197005 (owner: 10Mhurd) [23:16:51] (03PS1) 10Nirzar: Article page scroll rate has been normalized [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197437 [23:17:15] (03PS2) 10Dr0ptp4kt: Article page scroll rate has been normalized [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197437 (owner: 10Nirzar) [23:22:01] (03CR) 10Jdlrobson: [C: 031] "Need to test. A few comments on how to improve this in meantime but all can be done in a follow up." (034 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [23:23:34] dr0ptp4kt mhurd off for the night. Might pop in later [23:23:46] mhurd: curfew is 8pm [23:24:09] (03CR) 10Jdlrobson: [C: 04-1] "More verbose edit summary might help me understand why you are doing this." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197390 (owner: 10Robmoen) [23:24:45] coreyfloyd: peace out [23:25:06] (03CR) 10Jdlrobson: [C: 04-1] "minor comment. Note I still need to test but looks fine." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197417 (https://phabricator.wikimedia.org/T91802) (owner: 10Yurik) [23:25:18] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Use extension.json, deprecate use of Gather.php for registering config - https://phabricator.wikimedia.org/T91802#1126879 (10Jdlrobson) [23:25:52] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Use extension.json, deprecate use of Gather.php for registering config - https://phabricator.wikimedia.org/T91802#1126881 (10Jdlrobson) a:3Yurik [23:27:03] (03CR) 10Jdlrobson: [C: 04-1] "Please add tests." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196739 (owner: 10Yurik) [23:30:26] (03CR) 10Yurik: "Please +2 https://gerrit.wikimedia.org/r/#/c/197384/ first" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196739 (owner: 10Yurik) [23:34:41] (03PS3) 10Yurik: Migrated from Gather.php to extension.json [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197417 (https://phabricator.wikimedia.org/T91802) [23:35:50] (03CR) 10jenkins-bot: [V: 04-1] Migrated from Gather.php to extension.json [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197417 (https://phabricator.wikimedia.org/T91802) (owner: 10Yurik) [23:45:25] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: When I go to Special:Gather and see the collections I own they are illustrated with a page image - https://phabricator.wikimedia.org/T91675#1126932 (10Jdlrobson) Yeah, I pretty much agree with you @JHernandez but do you think there is any value in just... [23:47:43] (03CR) 10Jdlrobson: [C: 032] "Tests good." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197384 (https://phabricator.wikimedia.org/T92830) (owner: 10Yurik) [23:48:51] (03Merged) 10jenkins-bot: Unit tests and a number of minor bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197384 (https://phabricator.wikimedia.org/T92830) (owner: 10Yurik) [23:49:17] 10Gather, 3Gather Sprint Diplodocus: API returning watchlist with id other than 0 - https://phabricator.wikimedia.org/T92888#1126936 (10Jdlrobson) @yurik I was hoping T92830 from the commit summary would fix my existing issue but it didn't :-/ [23:51:28] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: API unit tests - https://phabricator.wikimedia.org/T92830#1126942 (10Jdlrobson) @yurik this task is a bit open ended and it's hard to know what you are working on. Personally I'd prefer you closed this and fixed known bugs one at a time by introducing t... [23:54:56] 10Gather, 3Gather Sprint Diplodocus: watchlist overlay: design tweaks - https://phabricator.wikimedia.org/T92037#1126954 (10Jdlrobson) [23:55:09] 10Gather, 3Gather Sprint Diplodocus: watchlist overlay: design tweaks - https://phabricator.wikimedia.org/T92037#1102057 (10Jdlrobson) [23:55:42] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Fix scrolling behaviour - https://phabricator.wikimedia.org/T92791#1126959 (10Jdlrobson) @JHernandez to stop outside scrolling just look at how Overlay.js does it (clips the body to maximum height of 100%). Maybe what we have here isn't a ContentOverlay... [23:56:10] (03CR) 10Jdlrobson: [C: 04-1] "See bug report - this doesn't seem to be working." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197370 (https://phabricator.wikimedia.org/T92791) (owner: 10Jhernandez) [23:56:18] (03PS1) 10Yurik: Automatically run all phpunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197442 [23:56:47] (03CR) 10jenkins-bot: [V: 04-1] Automatically run all phpunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197442 (owner: 10Yurik) [23:57:07] (03CR) 10Jdlrobson: "(also this could really use a browser test)" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [23:59:14] (03PS2) 10Yurik: Automatically run all phpunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197442 [23:59:38] (03CR) 10jenkins-bot: [V: 04-1] Automatically run all phpunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197442 (owner: 10Yurik)