[00:00:21] coreyfloyd: was afk. see ya! [00:01:38] (03PS3) 10Yurik: Automatically run all phpunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197442 [00:02:33] (03CR) 10jenkins-bot: [V: 04-1] Automatically run all phpunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197442 (owner: 10Yurik) [00:08:42] 6Mobile-Web: Null edit results in JS error, hung editor on mobile (stable) - https://phabricator.wikimedia.org/T93029#1126965 (10kaldari) 3NEW [00:09:11] 10Gather, 3Gather Sprint Diplodocus: Event logging for hamburger "collections" link - https://phabricator.wikimedia.org/T92855#1126974 (10Jdlrobson) a:3Jdlrobson [00:10:49] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Article reader sees message/guidance about creating a collection so that they know the feature exists and the entry point - https://phabricator.wikimedia.org/T91015#1126977 (10Jdlrobson) @JKatzWMF the bug says nothing about enabling this for anons. Tal... [00:12:47] (03PS4) 10Mhurd: Fix for image saving bug. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197006 [00:13:25] (03CR) 10Jdlrobson: [C: 04-1] "Looks good but a few minor things to fix and quite a few things to check with JK (see my comment on bug report)." (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [00:13:48] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Article reader sees message/guidance about creating a collection so that they know the feature exists and the entry point - https://phabricator.wikimedia.org/T91015#1126981 (10Jdlrobson) In addition to above I notice two issues: * I think we should als... [00:15:37] 6Mobile-Web, 5Patch-For-Review: Tappable area of close button on reference drawer is too small - https://phabricator.wikimedia.org/T92700#1126993 (10bmansurov) 5Open>3Resolved [00:24:11] 6Mobile-Web: Null edit results in JS error, hung editor on mobile (stable) - https://phabricator.wikimedia.org/T93029#1127018 (10kaldari) [00:25:36] (03PS1) 10Kaldari: Allow null edits on mobile (same as desktop) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197446 (https://phabricator.wikimedia.org/T93029) [00:28:23] (03CR) 10Bmansurov: [C: 032] Footer changes [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/195552 (owner: 10Phuedx) [00:29:30] (03Merged) 10jenkins-bot: Footer changes [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/195552 (owner: 10Phuedx) [00:30:28] (03CR) 10Bmansurov: "Besides what you did, wouldn't it be better to resolve the request without going through the save processes?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197446 (https://phabricator.wikimedia.org/T93029) (owner: 10Kaldari) [00:34:15] (03PS4) 10Yurik: Automatically run all phpunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197442 [00:35:16] (03CR) 10jenkins-bot: [V: 04-1] Automatically run all phpunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197442 (owner: 10Yurik) [00:37:13] (03PS5) 10Mhurd: Fix for image saving bug. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197006 [00:38:34] (03CR) 10Mhurd: "The last 2 amendments refactored scheme-stripping into MWKImage, per Brian's comments." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197006 (owner: 10Mhurd) [00:39:26] (03PS6) 10Mhurd: Fix for image saving bug. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197006 [00:45:27] (03PS1) 10Jdlrobson: Generalise main menu logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197454 [00:45:29] (03PS1) 10Jdlrobson: Use new schema for main menu click tracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197455 [00:45:35] (03PS1) 10Jdlrobson: Enable event logging on collections link [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197456 (https://phabricator.wikimedia.org/T92855) [00:45:55] (03CR) 10Jdlrobson: [C: 04-1] "Please review dependencies first." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197456 (https://phabricator.wikimedia.org/T92855) (owner: 10Jdlrobson) [00:46:40] (03CR) 10jenkins-bot: [V: 04-1] Generalise main menu logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197454 (owner: 10Jdlrobson) [00:46:49] (03CR) 10jenkins-bot: [V: 04-1] Use new schema for main menu click tracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197455 (owner: 10Jdlrobson) [00:47:18] (03PS2) 10Jdlrobson: Use new schema for main menu click tracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197455 [00:47:20] (03PS2) 10Jdlrobson: Generalise main menu logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197454 [00:48:37] (03CR) 10jenkins-bot: [V: 04-1] Use new schema for main menu click tracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197455 (owner: 10Jdlrobson) [00:48:41] (03CR) 10jenkins-bot: [V: 04-1] Generalise main menu logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197454 (owner: 10Jdlrobson) [00:48:59] (03PS1) 10Jdlrobson: Enable Gather in beta site. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197457 (https://phabricator.wikimedia.org/T92881) [00:49:12] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Move Gather to beta mode - https://phabricator.wikimedia.org/T92881#1127095 (10Jdlrobson) a:3Jdlrobson [00:49:51] (03PS2) 10Jdlrobson: Enable Gather in beta site. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197457 (https://phabricator.wikimedia.org/T92881) [00:50:07] (03CR) 10Jdlrobson: [C: 04-1] "Should probably wait till Gather is a bit more polished before merging this." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197457 (https://phabricator.wikimedia.org/T92881) (owner: 10Jdlrobson) [00:55:52] 3Gather Sprint Diplodocus: Api bug when loading action=query&list=lists&lstids=X and logged in - https://phabricator.wikimedia.org/T92865#1127115 (10Jdlrobson) I can replicate on beta labs Making this query as anon and as logged in yields different results. http://en.m.wikipedia.beta.wmflabs.org/w/api.php?actio... [00:56:27] 3Gather Sprint Diplodocus: Inconsistent result for loading action=query&list=lists&lstids=X when logged in / anon - https://phabricator.wikimedia.org/T92865#1127116 (10Jdlrobson) [00:56:45] 10Gather, 3Gather Sprint Diplodocus: API returning watchlist with id other than 0 - https://phabricator.wikimedia.org/T92888#1127119 (10Jdlrobson) p:5Triage>3High [00:57:38] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1127122 (10Jdlrobson) @Yurik and @Moushira we could really use some feedback here to avoid this important piece of work getting blocked. Currently not sure how to continue... should we arrange a mee... [00:58:41] (03PS7) 10Mhurd: Fix for image saving bug. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197006 [00:59:12] 10Gather, 3Gather Sprint Diplodocus, 7Tracking: Tracking: Performance in Gather - https://phabricator.wikimedia.org/T92857#1127123 (10Jdlrobson) 5Open>3Invalid a:3Jdlrobson I'm not sure of the use of a tracking bug. We are using the workboard [1] to track bugs. Since there is only one bug this is track... [00:59:22] 10Gather, 7Tracking: Tracking: Performance in Gather - https://phabricator.wikimedia.org/T92857#1127126 (10Jdlrobson) [01:00:23] (03CR) 10Jdlrobson: "ping.. any reason why this is WIP?" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194498 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [01:01:26] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197222 (https://phabricator.wikimedia.org/T92580) (owner: 10Jdlrobson) [01:02:16] (03PS5) 10Jdlrobson: Reduce API requests on any given non-special page to 1 [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197222 (https://phabricator.wikimedia.org/T92580) [01:03:27] 6Mobile-Web, 10Flow: On mobile, the Flow notification's link takes you to the desktop version of the Flow page, even though the main (background) link takes you to the mobile one - https://phabricator.wikimedia.org/T93035#1127129 (10Jdforrester-WMF) 3NEW [01:04:56] (03PS7) 10Mhurd: Address nested parentheses in Share a Fact [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196298 (owner: 10Dr0ptp4kt) [01:05:20] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1127136 (10Yurik) @jdlrobson, i spoke with @jkatzwmf, and explained about RC feed. From the dev perspective, it will be very easy to implement - any time user modifies label / description of the PU... [01:05:51] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6WMF-Legal: Share a fact slaps CC icons on all images regardless of actual license - https://phabricator.wikimedia.org/T93015#1127137 (10Deskana) [01:05:54] 10Gather, 3Gather Sprint Diplodocus, 10Security-Reviews: Security review of Gather extension - https://phabricator.wikimedia.org/T91778#1127139 (10Jdlrobson) Scheduled for 10am Friday 20th March PST. Let me know if anyone else wants to join [01:05:57] 10Wikipedia-App-Android-App, 6WMF-Legal: Share A Fact images do not include license or attribution info about the image - https://phabricator.wikimedia.org/T91811#1127141 (10Deskana) [01:05:58] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6WMF-Legal: Share a fact slaps CC icons on all images regardless of actual license - https://phabricator.wikimedia.org/T93015#1126608 (10Deskana) [01:06:06] (03CR) 10Mhurd: [C: 032] Address nested parentheses in Share a Fact [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/196298 (owner: 10Dr0ptp4kt) [01:06:22] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6WMF-Legal: Share A Fact images do not include license or attribution info about the image - https://phabricator.wikimedia.org/T91811#1096747 (10Deskana) [01:07:43] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1127156 (10Jdlrobson) @JKatzWMF can you update the task report then so this is actionable? [01:08:13] (03PS8) 10Mhurd: Fix for image saving bug. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197006 [01:08:18] 10Gather, 3Gather Sprint Diplodocus: An admin is able to hide or unhide a list. - https://phabricator.wikimedia.org/T91444#1084346 (10Jdlrobson) Moving to analysis whilst T92782 is unclear. [01:09:01] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Performance: onMakeGlobalVariablesScript causes too many internal hits to API - https://phabricator.wikimedia.org/T92580#1115219 (10Jdlrobson) Moved back since the two other patches still need review/improvement [01:09:09] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression wmf21] VisualEditor in mobile doesn't load - https://phabricator.wikimedia.org/T93036#1127171 (10Jdforrester-WMF) [01:09:34] 10Gather, 3Gather Sprint Diplodocus: Populate gather with proper feature name - https://phabricator.wikimedia.org/T92665#1117715 (10Jdlrobson) Moved to in analysis since it is currently not actionable [01:10:47] 6Mobile-Web, 10Flow: On mobile, the Flow notification's link takes you to the desktop version of the Flow page, even though the main (background) link takes you to the mobile one - https://phabricator.wikimedia.org/T93035#1127182 (10Mattflaschen) Which notification was it (new topic, thanks, etc.)? [01:25:02] (03PS9) 10Mhurd: Fix for image saving bug. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197006 [01:25:48] (03PS10) 10Mhurd: Fix for image saving bug. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197006 [01:31:10] (03CR) 10Dr0ptp4kt: [C: 032] Fix for image saving bug. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197006 (owner: 10Mhurd) [01:54:46] (03PS4) 10Mhurd: Fix for expensive image data inflation for determing image size. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 [01:55:00] (03CR) 10Mhurd: "Rebased." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 (owner: 10Mhurd) [01:57:52] (03CR) 10Dbrant: Cache pages on disk instead of ram. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196974 (owner: 10Dbrant) [01:58:24] (03PS7) 10Dbrant: Cache pages on disk instead of ram. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196974 [02:04:56] (03PS7) 10Yurik: Ability to see if lists contain a title [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196739 [02:08:52] (03PS8) 10Dbrant: Cache pages on disk instead of ram. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196974 [02:42:33] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Handle edit conflicts on the mobile app in some way - https://phabricator.wikimedia.org/T66281#1127347 (10Krenair) Honestly I don't see why clients should even be allowed to just ignore conflict detection like this. Perhaps it's an upstream #MediaWiki-API i... [02:46:25] 10Gather, 3Gather Sprint Diplodocus: An admin is able to hide or unhide a list. - https://phabricator.wikimedia.org/T91444#1127354 (10Yurik) We could introduce a security right, something like "gather-admin", and permit additional capabilities by the api. Users with that right could be allowed to * edit label... [03:16:29] (03PS5) 10Mhurd: Fix for expensive image data inflation for determing image size. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 [03:17:31] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1127384 (10Nicolas_Raoul) [04:03:27] (03PS6) 10Mhurd: Fix for expensive image data inflation for determing image size. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 [04:41:28] (03PS7) 10Mhurd: Fix for expensive image data inflation for determing image size. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 [06:31:46] (03CR) 10Florianschmidtwelzow: [C: 031] "Bmansurov: Not really, null edits are sometimes an important instrument, see https://en.wikipedia.org/wiki/Wikipedia:Purge#Null_edit" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197446 (https://phabricator.wikimedia.org/T93029) (owner: 10Kaldari) [06:37:07] (03CR) 10Kaldari: "@Bmansurov: Sometimes null edits are needed for various reasons. For example, I noticed this bug because I was trying to force a links upd" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197446 (https://phabricator.wikimedia.org/T93029) (owner: 10Kaldari) [06:39:01] (03PS8) 10Mhurd: Fix for expensive image data inflation for determing image size. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 [07:23:43] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1127564 (10Qgil) @Nicolas_Raoul, @Jdlrobson, the microtasks listed in the description look like steps for implementing the actual project idea. We are talking abou... [07:24:45] (03CR) 10Mhurd: [C: 04-1] "This is out of sync with the pattern used in Safari and the Mail app. I'd like to wait until we have a chance to try out the idea Jared an" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197437 (owner: 10Nirzar) [07:50:34] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1127580 (10Nicolas_Raoul) If "Software development" is too broad, how about asking for PHP skills? Although I feel that anyone with software development skills can... [07:53:32] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1127592 (10Nicolas_Raoul) [09:07:36] (03CR) 10Mhurd: Article page scroll rate has been normalized [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197437 (owner: 10Nirzar) [09:51:10] morning [09:51:37] phuedx: o/ [09:58:39] hey prtksxna [09:58:43] how's it going? [09:59:10] phuedx: Good. Style guide stuff. What about you? [09:59:19] How were St. Patrick's Day celebrations? [09:59:23] hah [09:59:30] non-existant for me :) [09:59:36] wikigrok foo for me [09:59:38] all day long [10:02:03] oh [10:02:13] Is that nearing completion? [10:11:54] prtksxna: … jein [10:12:14] translation: yesno [10:12:23] it's getting there :) [10:12:43] :) [10:12:47] What language is that? [10:13:36] german [10:13:50] ja + nein = jein :D [10:18:19] :) [12:06:56] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: When I go to Special:Gather and see the collections I own they are illustrated with a page image - https://phabricator.wikimedia.org/T91675#1128238 (10Jhernandez) From the JSON pages days I think moiz and jonk saw it and didn't complain about the design... [12:09:43] 6Mobile-Web: PLURAL support for MobileFrontend licensing messages - https://phabricator.wikimedia.org/T93058#1128241 (10Pikne) 3NEW [12:12:46] 6Mobile-Web: PLURAL support for MobileFrontend licensing messages - https://phabricator.wikimedia.org/T93058#1128254 (10Pikne) [12:15:44] 6Mobile-Web: PLURAL support for MobileFrontend licensing messages - https://phabricator.wikimedia.org/T93058#1128256 (10Pikne) [12:16:42] i hate vagrant [12:17:05] not really vagrant, but you understand [12:24:23] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Fix scrolling behaviour - https://phabricator.wikimedia.org/T92791#1128266 (10Jhernandez) Dang I forgot the left/right rule, fixin' it now if the vagrant gods allow me to [12:34:34] (03PS2) 10Jhernandez: Fix overflow and scrolling in the content overlay. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197370 (https://phabricator.wikimedia.org/T92791) [12:43:11] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: API unit tests framework - https://phabricator.wikimedia.org/T92830#1128300 (10Jhernandez) [12:48:13] (03PS3) 10Jhernandez: Generalise main menu logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197454 (owner: 10Jdlrobson) [13:04:04] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1128312 (10NiharikaKohli) [13:09:34] (03PS4) 10Jhernandez: Generalise main menu logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197454 (owner: 10Jdlrobson) [13:10:22] (03CR) 10Jhernandez: [C: 031] "Fixed lint errors and MainMenu.js for actually hijacking the links properly." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197454 (owner: 10Jdlrobson) [13:11:14] (03PS3) 10Jhernandez: Use new schema for main menu click tracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197455 (owner: 10Jdlrobson) [13:12:34] (03CR) 10Jhernandez: [C: 031] "This should be harmless to merge, worked a bit on the MF patch" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197456 (https://phabricator.wikimedia.org/T92855) (owner: 10Jdlrobson) [13:14:41] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Event logging for hamburger "collections" link - https://phabricator.wikimedia.org/T92855#1128344 (10Jhernandez) Dependencies from Mobile frontend: - Generalise main menu logging https://gerrit.wikimedia.org/r/#/c/197454/4 - New schema: https://gerrit.w... [13:28:57] (03PS5) 10Dbrant: [WIP] Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 [14:04:30] (03PS1) 10Yurik: API bugfix - doesn't show public list to another user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197523 (https://phabricator.wikimedia.org/T92865) [14:05:50] (03CR) 10jenkins-bot: [V: 04-1] API bugfix - doesn't show public list to another user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197523 (https://phabricator.wikimedia.org/T92865) (owner: 10Yurik) [14:07:22] (03PS2) 10Yurik: API bugfix - doesn't show public list to another user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197523 (https://phabricator.wikimedia.org/T92865) [14:08:30] (03CR) 10jenkins-bot: [V: 04-1] API bugfix - doesn't show public list to another user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197523 (https://phabricator.wikimedia.org/T92865) (owner: 10Yurik) [14:12:14] (03PS3) 10Yurik: API bugfix - doesn't show public list to another user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197523 (https://phabricator.wikimedia.org/T92865) [14:23:01] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Create a fastlane configuration file for iOS builds - https://phabricator.wikimedia.org/T92884#1128607 (10BGerstle-WMF) [14:23:21] bgerstle: coreyfloyd: morning! [14:23:28] mornin dbrant [14:23:36] so, every once in a while, I try updating the iOS app repo, and building/running it in the simulator... [14:23:48] dbrant why would do something as dangerous as that? ;-) [14:23:48] but now, it's failing to build. (the last time i tried was probably before the new year) [14:23:53] dbrant oh [14:23:56] sup [14:23:59] a lot has changed since then [14:24:04] dbrant did you try the README? [14:24:21] also, we were hoping to use one of you android folks as testers for our app's user-friendliness [14:24:29] lol [14:24:40] so, thanks for volunteering! ;-) [14:25:18] yep... when I do "make get-deps" from the command line, it's complaining that i don't have node/npm, but I definitely do. [14:25:28] dbrant must not be on your path [14:25:37] or the wrong version [14:26:05] dbrant it's looking for node v0.10* and npm version 1.4 [14:26:17] what do node -v and npm -version tell you? [14:26:34] * bgerstle makes note to improve node & npm check-deps tasks [14:26:47] oh wait [14:26:49] bgerstle: node = 0.12.0, npm = 2.5.1 [14:26:51] it should have told you! [14:26:56] uh whaa [14:27:05] ah [14:27:15] you're above the required minimum versions [14:27:20] but the check is looking exactly for 1.4 & v0.10 [14:27:30] i didn't even know there were node versions that high [14:28:03] dbrant i can either make the checks more lenient... (hard) or you can use nodenv to install the project's declared node and npm versions locally [14:28:15] 3Gather Sprint Diplodocus: Inconsistent result for loading action=query&list=lists&lstids=X when logged in / anon - https://phabricator.wikimedia.org/T92865#1128626 (10Yurik) https://gerrit.wikimedia.org/r/#/c/197523/ fixes it [14:28:30] (which is also recommended in the README in general for devs working on projects that depend on different versions of node & npm) [14:28:36] 3Gather Sprint Diplodocus, 5Patch-For-Review: Inconsistent result for loading action=query&list=lists&lstids=X when logged in / anon - https://phabricator.wikimedia.org/T92865#1128627 (10Yurik) [14:29:52] bgerstle: got node 0.12.0 as well. [14:30:15] bearND: well aren't both of you cool & bleeding edge ;-) [14:30:46] bgerstle: BTW, the services team is considering moving to iojs [14:30:54] bgerstle: also, when I try building the project from xcode, I get: "ld: library not found for -lPods-BlocksKit" [14:30:56] bearND: what what? [14:31:04] dbrant is because you couldnt' get-deps [14:31:08] which installs our third-party libs [14:31:12] one of which, is Blocks-Kit [14:31:21] sorry, BlocksKit [14:31:44] (i was able to install cocoapods separately, though) [14:31:58] bgerstle: https://iojs.org/en/index.html [14:31:59] dbrant: bearND coreyfloyd so what'll it be gents? the project can either not care about node & npm versions, or just ensure it's >= minVersion [14:32:22] bearND: so it's node w/ ES6 standard implementations? [14:32:34] bgerstle: yes [14:32:47] this is nice, i've heard good things about ES6: https://robots.thoughtbot.com/replace-coffeescript-with-es6 [14:33:10] bearND: great overview of ES6 features ^ [14:33:31] dbrant ok, so if you're gonna be a cowboy [14:33:32] bgerstle: anyways, my vote would be to make your stuff accept newer versions of node.js [14:33:38] you can run pod install yourself [14:33:50] yeah pod install from the command line will work fine [14:34:09] yep, did that... but ld is still complaining. [14:34:13] bearND: challenge accepted [14:34:18] dbrant: what's the error? [14:34:33] the library not found? [14:34:38] yep [14:34:52] can haz pastebin of pod install output? [14:34:59] yeha that will help [14:36:18] http://pastebin.com/6PF87snD [14:37:27] are you opening th eworkspace? [14:37:34] dbrant: or the project? [14:38:10] 3Gather Sprint Diplodocus, 5Patch-For-Review: Inconsistent result for loading action=query&list=lists&lstids=X when logged in / anon - https://phabricator.wikimedia.org/T92865#1128663 (10Yurik) @Aklapper - do you know why my patch didn't auto-add itself here? [14:38:19] dbrant: you need to open the workspace (which contains references to both projects) [14:39:44] aha, I closed & reopened the project, and now it builds! [14:42:38] bgerstle: coreyfloyd: ^ thx! [14:49:27] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Create a fastlane configuration file for iOS builds - https://phabricator.wikimedia.org/T92884#1128697 (10Fjalapeno) a:3Fjalapeno [14:50:16] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Configure & document iOS build hardware - https://phabricator.wikimedia.org/T92880#1128701 (10Fjalapeno) [14:51:04] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Create a fastlane configuration file for iOS builds - https://phabricator.wikimedia.org/T92884#1122670 (10Fjalapeno) [14:51:19] dbrant: bearND i'm going to file a ticket in our tech backlog for this [14:51:36] cool! [14:51:44] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Configure Jenkins for iOS builds - https://phabricator.wikimedia.org/T92882#1128710 (10Fjalapeno) [14:54:43] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Configure Jenkins for iOS builds - https://phabricator.wikimedia.org/T92882#1128717 (10BGerstle-WMF) [14:54:57] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Configure Jenkins for iOS builds - https://phabricator.wikimedia.org/T92882#1122640 (10BGerstle-WMF) Removed SCMSync plugin since it's out of scope. [14:56:42] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Run unit tests before builds and save build reports for viewing - https://phabricator.wikimedia.org/T91788#1128726 (10BGerstle-WMF) 5Open>3Invalid a:3BGerstle-WMF @KLans_WMF @Fjalapeno I added add'l acceptance criteria to T92884 which covers the tasks i... [14:58:18] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Configure Jenkins for iOS builds - https://phabricator.wikimedia.org/T92882#1128735 (10BGerstle-WMF) [14:59:08] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Configure Jenkins for iOS builds - https://phabricator.wikimedia.org/T92882#1122640 (10BGerstle-WMF) @Fjalapeno I added the "store test reports" criteria here instead of T91788 & T92884, since test report //storage// happens in Jenkins and not fastlane. [15:00:36] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Configure Jenkins for iOS builds - https://phabricator.wikimedia.org/T92882#1128742 (10BGerstle-WMF) @Fjalapeno, although getting proper test reports per-build can be a separate refinement which is out of scope for build server MVP. IMO as long as we have th... [15:05:58] 10Wikipedia-App-iOS-App: Fix dependency version checks in iOS Makefile - https://phabricator.wikimedia.org/T93077#1128760 (10BGerstle-WMF) 3NEW [15:06:49] 10Wikipedia-App-iOS-App: [Spike 4 hours] Self-hosted Quincy - https://phabricator.wikimedia.org/T90660#1128769 (10BGerstle-WMF) @dr0ptp4kt can we consider this task Invalid or Declined since we went w/ HockeyApp? [15:09:33] 10Wikipedia-App-iOS-App: Get build server to vote on patches - https://phabricator.wikimedia.org/T93078#1128774 (10BGerstle-WMF) 3NEW [15:10:28] don't panic, ^ isn't in the current sprint [15:10:38] just following up on some engineering backlog discussions [15:13:26] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197624 (owner: 10L10n-bot) [15:24:52] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197589 (owner: 10L10n-bot) [15:27:55] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/197582 (owner: 10L10n-bot) [15:30:23] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197574 (owner: 10L10n-bot) [15:53:10] (03PS6) 10Dbrant: [WIP] Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 [16:02:54] (03PS8) 10Yurik: Ability to see if lists contain a title [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196739 [16:11:01] (03CR) 10BearND: [C: 04-1] "Looks great. I would like to see a comment in the commit message regarding the decision to move to using the original title instead of the" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196974 (owner: 10Dbrant) [16:12:31] (03CR) 10Bgerstle: "can we add tests for MWKImage sizeVariant method we changed? otherwise just some minor comments/praises" (037 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 (owner: 10Mhurd) [16:14:59] 10Wikipedia-App-iOS-App: Standardize multi-line conditionals - https://phabricator.wikimedia.org/T93091#1129091 (10BGerstle-WMF) 3NEW [16:20:02] 10Wikipedia-App-iOS-App: Look into fix for ObjC message indentation - https://phabricator.wikimedia.org/T93092#1129123 (10BGerstle-WMF) 3NEW [16:20:30] (03CR) 10Bmansurov: "I wonder how extensions that insert menu items with JavaScript can enable event logging using this approach? Does that mean they have to r" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197454 (owner: 10Jdlrobson) [16:21:40] 10Wikipedia-App-iOS-App: Look into fix for ObjC message indentation - https://phabricator.wikimedia.org/T93092#1129142 (10BGerstle-WMF) [16:22:59] 10Wikipedia-App-iOS-App: Fix ternary operator crustification - https://phabricator.wikimedia.org/T93094#1129144 (10BGerstle-WMF) 3NEW [16:23:24] (03CR) 10Bmansurov: "OK, makes sense." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197446 (https://phabricator.wikimedia.org/T93029) (owner: 10Kaldari) [16:23:52] ok, enough not-coding, time to push some bits [16:24:21] (03PS9) 10Yurik: Ability to see if lists contain a title [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196739 [16:25:02] JonKatz, around? [16:26:57] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Article reader sees message/guidance about creating a collection so that they know the feature exists and the entry point - https://phabricator.wikimedia.org/T91015#1129160 (10JKatzWMF) @jdlrobson, @rmoen. You are right, the targeting criteria is "mob... [16:28:50] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Article reader sees message/guidance about creating a collection so that they know the feature exists and the entry point - https://phabricator.wikimedia.org/T91015#1129165 (10JKatzWMF) [16:34:34] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1129178 (10JKatzWMF) @jdlrobson. Yes, spoke to @yurik and @moushira yesterday. This is not ideal from my perspective--I wanted a separate feed, but it is acceptable if it is much cheaper. HOWEVER... [16:35:07] 10Gather, 3Gather Sprint Diplodocus: Issue installing Gather on new mediawiki instance - https://phabricator.wikimedia.org/T93095#1129179 (10Jdlrobson) 3NEW [16:37:22] 10Gather, 3Gather Sprint Diplodocus: An admin is able to hide or unhide a list. - https://phabricator.wikimedia.org/T91444#1129212 (10JKatzWMF) @yurik. Agreed that viewing private list is not on the table. Will talk to James Alexander about appropriate privelege requirements for hiding list. We want this t... [16:38:56] yurik hi- around! [16:39:09] JonKatz, hi, want to +2 a few patches? :) [16:39:15] not sure who else is in the house ) [16:39:23] oh, jdlrobson is here )) [16:39:33] fixed a few more bugs [16:39:38] yurik jld's your man. I don't have privs [16:40:08] JonKatz, ok. So have you decided to simply add items to logs? [16:40:17] btw, logs are more for admin operations [16:40:35] i like logs better than RC...is it same level of simplicity [16:40:47] to implement? [16:40:57] i think logs are not good here because of how we use them [16:41:41] logs - stay forever, report admin right changes and other things that allow community to monitor its higher ups [16:41:53] probably the biggest exception - page renames [16:42:01] yurik fair enough. RC is fine, per my note in phab. The only thing to confirm is that it is not hard to implement: √ [16:42:02] whereas RC - everything [16:42:07] √ = https://phabricator.wikimedia.org/T91444 [16:42:18] but RC gets autodeleted - which is ok in our case as well [16:42:37] JonKatz, won't know until i try, but shouldn't be too hard [16:42:48] \o [16:42:50] yurik rc gets autodeleted? that is not cool..need a record [16:43:18] JonKatz, if you want a full blown record, we need to implement history [16:43:30] same as wikidata did [16:44:11] in which case you will need to treat each list as a fake page, possibly in some magic namespace [16:44:17] (03PS4) 10Jdlrobson: API bugfix - doesn't show public list to another user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197523 (https://phabricator.wikimedia.org/T92865) (owner: 10Yurik) [16:44:34] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Inconsistent result for loading action=query&list=lists&lstids=X when logged in / anon - https://phabricator.wikimedia.org/T92865#1129225 (10Jdlrobson) [16:44:38] yurik not a record of admin events, but of creation of collections [16:44:51] lets talk more in standup if there is space [16:44:53] ok [16:45:29] (03CR) 10Robmoen: Bind events to collections overlay only when created (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197390 (owner: 10Robmoen) [16:50:08] (03PS1) 10Bgerstle: fix uncrustify errors [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197654 [16:50:35] (03CR) 10Phuedx: [C: 04-1] Allow null edits on mobile (same as desktop) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197446 (https://phabricator.wikimedia.org/T93029) (owner: 10Kaldari) [16:51:06] coreyfloyd: quick +1 plz ^ [16:55:06] (03PS9) 10Dbrant: Cache pages on disk instead of ram. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196974 [16:57:06] 6Mobile-Web: Mobile editing - cursor is not visible and jumps around weirdly - https://phabricator.wikimedia.org/T92052#1129296 (10KLans_WMF) a:5KLans_WMF>3None [17:00:31] (03CR) 10BearND: [C: 032] ":)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196974 (owner: 10Dbrant) [17:03:00] (03Merged) 10jenkins-bot: Cache pages on disk instead of ram. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196974 (owner: 10Dbrant) [17:03:14] hey yurik [17:03:23] hi [17:03:48] so basically https://phabricator.wikimedia.org/T92782 is going to be the basis for a discovery tool [17:04:02] i know moiz is keen for instance to setup twitter bots that tweet about newly created lists [17:04:18] so regardless of whether we use it for moderation this and https://phabricator.wikimedia.org/T92690 probably needs to happen [17:04:56] traffic is small for initial release (beta of mobile site) - JonKatz checked with analytics - probably about 1000 users at most [17:05:19] so integrating with recent changes is something we can keep talking about but don't necessarily need to do right away [17:05:26] jdlrobson: hey, feel like looking at https://gerrit.wikimedia.org/r/#/c/196627/ ? [17:05:44] MatmaRex: added it to my to do list for today :) [17:05:57] jdlrobson, for IRC bots and the like RC is fine - it has all that [17:06:09] sorry, twitter bots [17:06:29] doing it via RC will probably take me a few hours [17:06:54] whereas another column + sorting might require some rethinking [17:06:57] 10Gather, 3Gather Sprint Diplodocus: An admin is able to hide or unhide a list. - https://phabricator.wikimedia.org/T91444#1129321 (10Jdlrobson) @Yurik security right sounds good. I think just hiding a public list should be sufficient - that way we don't have to worry about people losing data and complaining a... [17:07:13] yurik: maybe so but i think we need https://phabricator.wikimedia.org/T92690 asap [17:07:36] and some way to use API to query all lists [17:07:39] not just user's lists [17:08:13] 3Gather Sprint Diplodocus: API: Need method to query all public lists - https://phabricator.wikimedia.org/T93100#1129322 (10Jdlrobson) 3NEW [17:08:20] jdlrobson, query all lists is easy, but please tell me of a story to use lastmodified timestamp (other than monitoring, because RC is designed for that, it supports patroling, etc) [17:08:22] https://phabricator.wikimedia.org/T93100 < yurik [17:09:05] 3Gather Sprint Diplodocus: API: Need method to query all public lists - https://phabricator.wikimedia.org/T93100#1129322 (10Jdlrobson) [17:09:15] 10Gather, 3Gather Sprint Diplodocus: API: Need method to query all public lists - https://phabricator.wikimedia.org/T93100#1129322 (10Jdlrobson) [17:09:33] yurik: really it's about discovery - rendering the lists with their image / title / description is more reader friendly then viewing recent changes [17:09:47] jdlrobson, that i am totally fine with [17:09:58] i'm asking about the timestamp [17:10:40] jdlrobson, i will work on T93100, but please merge the bugfix - rebasing it would be a massive pain [17:12:16] yurik: sure thing i will do so as soon as we've finished chatting :) [17:12:48] yurik: question about https://phabricator.wikimedia.org/T92888 [17:13:00] why is there a row for watchlist? I thought it was not possible to edit description/title for it [17:13:58] jdlrobson, description is editable, and so is public/private/image [17:14:04] i have implemented it a while ago ) [17:14:33] i said only title (label) is not [17:15:28] i'm finally here [17:15:33] 10Gather, 3Gather Sprint Diplodocus: (!!!) Ability to edit collection is broken - https://phabricator.wikimedia.org/T93101#1129343 (10Jdlrobson) 3NEW [17:15:34] wohoo, i finally moved from my remote environment to a local setup, hope i haven't forget something, but i think i can work like before :D [17:15:34] welcome! [17:15:43] hey joakino [17:15:46] where ya beeeeeeen!? [17:15:52] whatcha been dooooin? [17:16:03] changing city for the rest of the week [17:16:11] it's father's day here [17:16:15] tomorrow [17:17:56] 10Gather, 3Gather Sprint Diplodocus: Edit button should not be visible on Watchlist when viewed in collections - https://phabricator.wikimedia.org/T93102#1129355 (10Jdlrobson) 3NEW [17:17:58] (03CR) 10Phuedx: "@MaxSem: is this a thing?" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191957 (owner: 10MaxSem) [17:18:18] 10Gather, 3Gather Sprint Diplodocus: API returning watchlist with id other than 0 - https://phabricator.wikimedia.org/T92888#1129366 (10Jdlrobson) This is where the confusion has come from - it was my understanding that you couldn't edit description or change title of watchlist. I've created T93102 as we dont... [17:18:35] ok yurik looking at your patches now! [17:18:53] (03CR) 10MaxSem: "Almost! Also, forgot to commit tests." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191957 (owner: 10MaxSem) [17:19:04] can somebody tell me what's happened with the menu on alpha??? [17:19:07] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1129370 (10JKatzWMF) [17:19:29] hamburguer menu that is [17:19:40] pretty please [17:20:39] joakino: you there? [17:20:43] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Inconsistent result for loading action=query&list=lists&lstids=X when logged in / anon - https://phabricator.wikimedia.org/T92865#1129381 (10Jhernandez) @gerritbot went on holidays hah [17:20:44] yep [17:20:52] joakino: ill tell you about hamburger later but in mean time [17:21:04] could you check if this fixes your api issue? https://gerrit.wikimedia.org/r/#/c/197523/4 [17:21:10] i can't replicate locally [17:21:28] i moved off vagrant \o/ [17:22:09] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: image gallery UI doesn't flip to suit RTL languages - https://phabricator.wikimedia.org/T91313#1129385 (10Deskana) 5Open>3Resolved [17:22:15] MaxSem: If you want to update folks on the client-side HTML templating, here’s the patch https://gerrit.wikimedia.org/r/#/c/180647/ . 3rd party opinions are welcome. [17:22:18] jdlrobson: oki! [17:22:21] jdlrobson: howww [17:22:34] (03CR) 10Phuedx: "But I4e1e43453d0e6aeb3560971289650dbddf61cb65 is a thing too?" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191957 (owner: 10MaxSem) [17:22:36] joakino: i just downloaded MAMP [17:22:39] and installed a mediawiki instance on it [17:22:43] with memcached [17:22:44] super fast [17:22:47] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Inconsistent result for loading action=query&list=lists&lstids=X when logged in / anon - https://phabricator.wikimedia.org/T92865#1129387 (10Aklapper) >>! In T92865#1128663, @Yurik wrote: > @Aklapper - do you know why my patch didn't auto-add itself her... [17:22:53] jdlrobson: gotta get to that [17:23:03] today was specially painful [17:23:09] (03Abandoned) 10MaxSem: WIP: aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/191957 (owner: 10MaxSem) [17:23:11] (03CR) 10Jdlrobson: [C: 031] "Will +2 when Joaquin has verified fix to issue he reported" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197523 (https://phabricator.wikimedia.org/T92865) (owner: 10Yurik) [17:23:12] joakino: we temporarily de-awesomified the alpha menu [17:23:21] phuedx, don't know what's going on:P [17:23:35] :D [17:23:44] kaldari: so the only way to get to it is by clicking search on alpha, right? [17:24:30] (03PS10) 10Jdlrobson: Ability to see if lists contain a title [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196739 (owner: 10Yurik) [17:24:45] (03PS6) 10Jdlrobson: Reduce API requests on any given non-special page to 1 [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197222 (https://phabricator.wikimedia.org/T92580) [17:24:49] kaldari: are we measuring something? seems like a confusing change to me [17:25:03] joakino: yeh was confusing to me too. i already moaned about it :P [17:25:24] joakino: it’s for a design proof of concept that is still under development [17:25:26] joakino: focus! i need that fix verified :D [17:25:32] lol [17:25:43] jdlrobson: not my fault: ==> default: Mounting NFS shared folders... [17:25:44] we can moan after [17:25:48] joakino: booo [17:26:31] jdlrobson: it's like http://xkcd.com/303/ but with "Mounting NFS shared folders" or "Waiting for localhost:8080" depending on the moment of the day [17:27:08] could you pipe your irc moans onto the trello card? maybe with some sort of grouping function? [17:28:12] moans | irc | group_moans | trello [17:28:20] ^ programming! [17:28:24] finally [17:28:25] phuedx: yay! [17:29:53] (03PS7) 10Dbrant: [WIP] Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 [17:31:32] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Inconsistent result for loading action=query&list=lists&lstids=X when logged in / anon - https://phabricator.wikimedia.org/T92865#1129398 (10Jhernandez) http://localhost:8080/w/api.php?action=query&list=lists&format=jsonfm&lstprop=label%7Cdescription%7C... [17:31:55] (03CR) 10Jhernandez: [C: 04-1] "See bug comment:" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197523 (https://phabricator.wikimedia.org/T92865) (owner: 10Yurik) [17:32:14] yurik: jdlrobson ^^ this is happening, i'm guessing it is not what we want? [17:32:19] ^ yurik [17:33:09] joakino, hold on, is that a new bug? [17:33:14] lets keep the patches separate [17:33:23] joakino: bit confused lstowner=User should return the lists belonging to User [17:33:33] (which includes watchlist belong to User) is that not the case? [17:33:34] yurik: same thing [17:33:47] (03PS2) 10Florianschmidtwelzow: Infobox: Add link to commons category overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197110 (https://phabricator.wikimedia.org/T92687) [17:33:50] jdlrobson: so lstowner nullifies lstids?? cc/ yurik [17:34:10] joakino: oh i see [17:34:14] lstids should trump imo [17:34:22] joakino, if you supply lstowner + lstids, it give you an AND [17:34:22] your specifying an exact list [17:34:45] yurik: it shouldn't [17:34:51] it's providing extra unnecessary information [17:34:55] yurik: so a union or an intersection [17:35:02] intersection [17:35:07] if there is a list 8 which is not owned by User i would expect this to return empty list [17:35:14] ok then its a bug [17:35:17] if list 8 is owned by User it should return list 8 [17:35:22] yurik: should i open a new bug? [17:35:25] joakino: does this break anything existing? [17:35:30] if not i'd say open a new bug [17:35:34] hold on, i am confused, why would you ever need a union??? [17:35:42] jdlrobson: not that I can think of [17:35:52] jdlrobson: it's just api consistency [17:35:55] ok let's merge and let's take this conversation to another bug [17:36:00] k [17:36:02] 6Mobile-Web: PLURAL support for MobileFrontend licensing messages - https://phabricator.wikimedia.org/T93058#1129412 (10Florian) a:3Florian [17:36:03] API consistency is an intersection, not a union [17:36:08] i'm keen to bulldoze Gather through to completion :) [17:36:12] yurik: jdlrobson: you guys are talking the same thing, we all want intersection of criteria [17:36:22] exactly [17:36:24] joakino: raise a bug let's discuss it there [17:36:33] (03CR) 10Jhernandez: [C: 032] API bugfix - doesn't show public list to another user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197523 (https://phabricator.wikimedia.org/T92865) (owner: 10Yurik) [17:36:35] (03CR) 10Jdlrobson: [C: 032] "Talking on IRC we will open a new bug for this" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197523 (https://phabricator.wikimedia.org/T92865) (owner: 10Yurik) [17:37:03] joakino, jdlrobson, most of the API params act as intersection, not uniot [17:37:04] union [17:37:13] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Inconsistent result for loading action=query&list=lists&lstids=X when logged in / anon - https://phabricator.wikimedia.org/T92865#1129414 (10Jhernandez) Opening a new bug with my comments (which has to do with lstids combined with lstowner). This patch... [17:37:34] bgerstle: what's that ticket # ? [17:37:37] yurik: alright i'm opening a new bug with the lstowner and lstids combo [17:37:39] jdlrobson, https://gerrit.wikimedia.org/r/#/c/196739/ [17:37:51] lemme find it [17:38:04] https://phabricator.wikimedia.org/T88633 [17:38:10] yurik: patience yurik i'm already on it. your pinging only slows medown :) [17:38:11] 6Mobile-Web, 10Flow: On mobile, the Flow notification's link takes you to the desktop version of the Flow page, even though the main (background) link takes you to the mobile one - https://phabricator.wikimedia.org/T93035#1129417 (10Mattflaschen) p:5Triage>3Normal [17:38:16] :D [17:38:25] jdlrobson, i like pinging... [17:38:29] jdlrobson, such a satisfying sound [17:38:40] * yurik hides [17:39:19] (03Merged) 10jenkins-bot: API bugfix - doesn't show public list to another user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197523 (https://phabricator.wikimedia.org/T92865) (owner: 10Yurik) [17:41:30] (03CR) 10Bmansurov: Alpha: Load banner images on page load (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [17:42:18] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-Android: As a user, I'd like lead sentences to be consistent so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1129430 (10Deskana) [17:42:58] dbrant, bearND: ^ FYI [17:43:00] dbrant, bearND: I've changed the scope of the card slightly. We should only do this for the English Wikipedia for now. [17:43:14] dbrant, bearND: There's some stuff we didn't fully consider about other wikis, so it's better to just not do it for those wikis. [17:43:54] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1129435 (10Sushrutsg) Hi, I'm interested in working for this project idea. Could you please assign me to this... [17:43:56] Deskana: good [17:44:21] Deskana: probably a good idea [17:44:57] 3Gather Sprint Diplodocus: Incorrect result for loading action=query&list=lists&lstids=X&lstowner=YYY - https://phabricator.wikimedia.org/T93103#1129436 (10Jhernandez) 3NEW [17:45:31] jdlrobson: thanks btw for pushing the pagebanner stuff ahead :) I'll add my proposal for discussion and feedback [17:45:32] yurik: jdlrobson: ^ i put it in current sprint, in analysis [17:46:01] codezee: no worries. thanks for all your interest and energy to move that along. It's good to see such support from the wikivoyage community - should be a good fun collaboration [17:46:07] joakino: thankss! [17:46:10] (03CR) 10Phuedx: Alpha: Load banner images on page load (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [17:47:22] jdlrobson: yes, I'll add the project as a subtask, and we can finalize any remaining issues there [17:47:28] phuedx: I think the service should handle it. Do you agree? [17:47:48] phuedx: also, is there a better way of handling this without try and catch? [17:48:07] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1129464 (10NiharikaKohli) @Sushrutsg just jump in and start working on them. :) [17:48:47] bmansurov: i agree [17:48:49] (03CR) 10Jdlrobson: [C: 032] Ability to see if lists contain a title [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196739 (owner: 10Yurik) [17:48:57] bmansurov: you can test if a title exists by calling Title#exists [17:49:01] (03CR) 10Jdlrobson: [C: 04-1] "needs more work" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197222 (https://phabricator.wikimedia.org/T92580) (owner: 10Jdlrobson) [17:49:04] so you can pre-empty the exception [17:49:07] phuedx: cool [17:50:26] (03Merged) 10jenkins-bot: Ability to see if lists contain a title [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196739 (owner: 10Yurik) [17:51:27] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1129487 (10Sumit) 3NEW [17:52:19] MaxSem: so... dynamic maps :) [17:52:26] how you gonna do it? [17:52:37] milimetric, OSM [17:52:46] https://github.com/jdlrobson/WikiMaps < MaxSem free frontend editor for you to integrate :) [17:52:49] ah, cool. [17:53:21] 10MobileFrontend-Feature-requests, 10Wikidata, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1129498 (10NiharikaKohli) p:5Triage>3Normal a:3Sumit [17:56:17] 10MobileFrontend-Feature-requests, 10Wikidata, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1129523 (10Sumit) [17:57:42] 10MobileFrontend-Feature-requests, 10Wikidata, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1129487 (10Sumit) please add your comments and feedbacks on the specifications, and help improve this :) [17:59:04] (03CR) 10Mhurd: "Replied to comments." (034 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 (owner: 10Mhurd) [17:59:08] bgerstle: ^ [17:59:16] k [18:02:26] (03CR) 10Bmansurov: Alpha: Load banner images on page load (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [18:02:54] event logging: does anybody know difference between edit 'submit' and 'success' in mobile web EL? [18:03:54] mm mediawiki is weird. php maintenance/update.php seems for my newly setup MAMP instance for some reason is trying to access vagrant stuff wtf [18:04:26] jdlrobson: lol xD you cannot escape [18:04:47] bgerstle: quick hangout? [18:04:51] JonKatz: 'submit' occurs when the constructive (green) button on the preview section of the overlay is clicked. The button must be enabled for this event to fire. This begins the saving process. 'success' occurs when the edit is successfully saved to the server [18:04:58] JonKatz: https://meta.wikimedia.org/wiki/Schema:MobileWebEditing [18:05:20] bmansurov cool, thanks! [18:05:40] np [18:07:19] MM. "A database query error has occurred. This may indicate a bug in the software." how useful [18:07:25] mhurd yeah 1 sec [18:08:17] (03PS9) 10Mhurd: Fix for expensive image data inflation for determing image size. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 [18:08:28] joakino, around? [18:08:40] yurik: yep, tell me [18:08:45] joakino, trying to repo https://phabricator.wikimedia.org/T93103 [18:08:53] can you pull the latest master [18:08:57] and tell me if you still have it [18:09:27] yurik: yep, still happening [18:09:41] mhurd: lemme take a peek at your replies then i can ping you on gchat? [18:09:43] yurik: do i need to run update.php? [18:09:48] no [18:09:49] bgerstle: ya [18:09:53] k [18:10:05] dr0ptp4kt: mhurd also, please +1 this uncrustify fixes so we can all commit/push w/o using --no-verify [18:10:13] https://gerrit.wikimedia.org/r/#/c/197654/ [18:10:39] bgerstle: can that wait until we get my patch merged? [18:10:42] (03PS7) 10Jdlrobson: Reduce API requests on any given non-special page to 1 [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197222 (https://phabricator.wikimedia.org/T92580) [18:10:52] mhurd sure [18:10:59] bgerstle: k thx [18:14:33] joakino, lets try to figure this out, can you go to mysql? [18:14:55] yurik: sure [18:15:15] yurik: i edited watchlist at some point, so maybe that has something to do with it [18:15:22] possibly [18:15:40] but that watchlist shows as "0", so there is no record [18:15:58] oki [18:16:01] what do you want me to do [18:16:07] joakino, select * from gather_list; [18:16:20] (03CR) 10Dr0ptp4kt: [C: 032] fix uncrustify errors [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197654 (owner: 10Bgerstle) [18:16:25] how big is it? [18:16:33] (03PS8) 10Jdlrobson: Reduce API requests on any given non-special page to 1 [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197222 (https://phabricator.wikimedia.org/T92580) [18:16:42] yurik: 8 lists [18:16:50] yurik: https://gist.github.com/anonymous/f54251986d932d98630e [18:16:53] (03CR) 10Dr0ptp4kt: [V: 032] fix uncrustify errors [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197654 (owner: 10Bgerstle) [18:17:16] joakino, it cuts [18:17:29] i like the "Ass" label [18:17:33] XD [18:17:38] my favourite collection [18:17:57] (03CR) 10Jdlrobson: [C: 032] Fix overflow and scrolling in the content overlay. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197370 (https://phabricator.wikimedia.org/T92791) (owner: 10Jhernandez) [18:18:07] joakino, not everything pasted [18:18:09] could you cehck [18:18:29] yurik: grr terminal crap [18:19:00] (03PS10) 10Mhurd: Fix for expensive image data inflation for determing image size. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 [18:19:16] 10Gather, 3Gather Sprint Diplodocus: (!!!) Ability to edit collection is broken - https://phabricator.wikimedia.org/T93101#1129638 (10Jdlrobson) a:3Jdlrobson [18:19:17] bgerstle: ^ refactor for the URLCache bits [18:19:54] 10Gather, 3Gather Sprint Diplodocus: Edit button should not be visible on Watchlist when viewed in collections - https://phabricator.wikimedia.org/T93102#1129640 (10Jdlrobson) a:3Jdlrobson [18:19:58] joakino, also, please tell me user ID of the currently logged in user : http://localhost:8080/w/api.php?action=query&meta=userinfo [18:21:24] yurik: know how to copy the output of the select in the less pager? after that it's just lost [18:21:31] while in the sql repl [18:21:39] mhurd awesome, thanks! [18:21:46] joakino, can you make the terminal screen wider? [18:21:52] (03PS11) 10Mhurd: Fix for expensive image data inflation for determing image size. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 [18:21:57] smaller font? [18:22:05] bgerstle: ^ updated commit msg [18:22:14] yurik: lol [18:22:18] bgerstle: hangout? [18:22:41] yeah [18:23:17] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Fix scrolling behaviour - https://phabricator.wikimedia.org/T92791#1129647 (10JKatzWMF) @jhernandez I still can't scroll to the bottom of the list of collections on the overlay. [18:23:19] joakino, mysql --skip-pager [18:24:41] yurik: alright smaller font did it heh https://gist.github.com/joakin/de936f279627af1e869d [18:24:47] yurik: uu skip-pager [18:25:00] (03PS9) 10Jdlrobson: Reduce API requests on any given non-special page to 1 [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197222 (https://phabricator.wikimedia.org/T93101) [18:25:04] very nice [18:25:29] (03Merged) 10jenkins-bot: Fix overflow and scrolling in the content overlay. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197370 (https://phabricator.wikimedia.org/T92791) (owner: 10Jhernandez) [18:28:53] rmoen: that new feature guider almost done? [18:32:09] (03PS1) 10Florianschmidtwelzow: Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) [18:33:29] (03CR) 10Florianschmidtwelzow: [C: 04-1] Fix problems with license message (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [18:34:36] chrismcmahon: i bundle updated and now i'm hitting ": Failed to set the 'cookie' property on 'Document': Cookies are disabled inside 'data:' URLs." when i try to run browser tests [18:34:39] any ideas why? [18:35:38] (03PS2) 10Florianschmidtwelzow: Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) [18:36:07] 6Mobile-Web: Search workflow in alpha needs non-JavaScript fallback - https://phabricator.wikimedia.org/T92675#1129725 (10kaldari) @jdlrobson @Maryana I don't see what this bug has to do with non-JS functionality. ALL search interfaces in mobile on alpha have had an additional click added to their workflow. The... [18:36:31] joakino, ok, got it, fixing [18:36:56] ah, jdlrobson, you're on browser tests actually i read? :D One question: i finally setup browser tests locally, but if i run them, i see beta labs in firefox, is this correct? I thought it should run _really_ locally? Have i missed a setup-step? [18:38:02] FlorianSW: yeh.. for some reason my chrome driver is not working [18:38:04] not sure what happened [18:38:22] but they should load locally, yes? [18:39:47] 6Mobile-Web: Back button on Special:MobileMenu (alpha) doesn't work without JavaScript - https://phabricator.wikimedia.org/T93115#1129740 (10kaldari) 3NEW [18:40:23] (03PS12) 10Mhurd: Fix for expensive image data inflation for determing image size. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 [18:40:37] bgerstle: ^ i just commented out a line of console spam [18:41:02] mhurd while you're at it, can you change #if 1 to #if 0 in WMFImageGalleryViewController.m? [18:41:05] i didn't mean to commit that [18:41:11] no reason to be logging all the image cache hits/misses [18:41:11] bgerstle: ya [18:41:14] thanks [18:41:25] bgerstle: i was just looking at that actually :) [18:41:29] ;-) [18:41:46] or we can see if DEBUG && 1 [18:41:51] that way it's always off for release [18:41:58] s/see/write/ [18:42:09] 6Mobile-Web: "Last modified .." flashes on screen, then replaced by "Last modified .." - https://phabricator.wikimedia.org/T89310#1129749 (10Florian) Hmm, can't reproduce in Chrome 40.0.2214.115 m (oops, i should restart chrome to install updates :/). Btw: I see the message "Last edited...", did i do something w... [18:42:12] and we don't need to worry about committing it as 1 [18:42:44] 6Mobile-Web: Search workflow in alpha needs non-JavaScript fallback - https://phabricator.wikimedia.org/T92675#1129755 (10Jdlrobson) Sorry for using word "terrible" I didn't mean to offend. For background the Zero team noticed people were clicking the search icon with no text inputted. As a result of some change... [18:44:17] phuedx, you said you had comments about agregation? [18:44:58] (03PS13) 10Mhurd: Fix for expensive image data inflation for determing image size. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 [18:45:02] bgerstle: ^ [18:45:29] 6Mobile-Web: Search workflow in alpha needs non-JavaScript fallback - https://phabricator.wikimedia.org/T92675#1129766 (10Jdlrobson) (@maryana's suggestion would alleviate this somewhat. However note it may make the menu less discoverable by placing it under search results and may result in less taps if people... [18:45:57] mhurd: perfect, thanks [18:46:11] kaldari, if you wanted to deploy the rest of config changes, better reserve a place soon:) [18:46:25] MaxSem: will do [18:46:37] 6Mobile-Web: Mobile editing - cursor is not visible and jumps around weirdly - https://phabricator.wikimedia.org/T92052#1129769 (10Florian) Works very well on Android chrome (40.0.2214.109) and desktop chrome (40.0.2214.115 m). Maybe iOS related (i have no device/emulator to test). [18:47:14] jdlrobson: never seen that error, I'll take a look [18:47:26] (03PS2) 10Jdlrobson: Bind events to collections overlay only when created [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197390 (owner: 10Robmoen) [18:47:33] (03CR) 10Jdlrobson: [C: 032] Bind events to collections overlay only when created [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197390 (owner: 10Robmoen) [18:47:39] bgerstle: oops one more [18:47:40] (03CR) 10Jdlrobson: Bind events to collections overlay only when created (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197390 (owner: 10Robmoen) [18:48:13] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 5Patch-For-Review: [Regression wmf21] VisualEditor in mobile doesn't load - https://phabricator.wikimedia.org/T93036#1129772 (10Florian) 5Open>3Resolved All changes are merged and i can start VE on mobile on de.wiki, so i assume it is fixed? :) [18:48:16] chrismcmahon: can't seem to run in firefox either " unable to obtain stable firefox connection in 60 seconds (127.0.0.1:7055)" [18:48:19] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression wmf21] VisualEditor in mobile doesn't load - https://phabricator.wikimedia.org/T93036#1129774 (10Florian) [18:48:47] oh wait looks like my env vars are wrong [18:48:51] * jdlrobson hits himself [18:48:59] (03Merged) 10jenkins-bot: Bind events to collections overlay only when created [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197390 (owner: 10Robmoen) [18:49:00] 6Mobile-Web: Search workflow in alpha needs non-JavaScript fallback - https://phabricator.wikimedia.org/T92675#1129777 (10Maryana) > I just wanted to flag this as the last decision to change search in the above way was completely data driven and yielded great results and we should be careful in making these chan... [18:50:33] btw, i learned a nice git pro-tip today for deleting multiple branches: [18:50:43] 6Mobile-Web: Search workflow in alpha needs non-JavaScript fallback - https://phabricator.wikimedia.org/T92675#1129791 (10Jdlrobson) (Note: This was also raised when this feature was placed in beta so it seemed pushing it to stable was more imminent, I'm less concerned now it is in alpha) [18:50:48] (03PS14) 10Mhurd: Fix for expensive image data inflation for determing image size. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 [18:51:00] git for-each-ref --format="%(refname:short)" 'refs/heads/branch*' [18:51:03] bgerstle: ^ this gets most of the crufty console spam [18:51:10] k [18:51:11] haha [18:51:22] mhurd just got a CPU & I/O baseline [18:51:28] 6Mobile-Web: Search workflow in alpha needs non-JavaScript fallback - https://phabricator.wikimedia.org/T92675#1129798 (10Jdlrobson) Also note rendering issues in alpha: {F99965} [18:51:28] you can see all the little hits from teh iamges [18:51:29] jdlrobson: oh, yeah, there is also a bug. in your Gemfile.lock in the MobileFrontend directory, set the version of mediawiki_selenium to 0.4.2 not 1.0 [18:51:30] bgerstle: drum roll... [18:51:31] running your patch now.. [18:51:35] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 5WMF-deploy-2015-03-04_(1.25wmf20), 5WMF-deploy-2015-03-11_(1.25wmf21): [Regression wmf21] VisualEditor in mobile doesn't load - https://phabricator.wikimedia.org/T93036#1129799 (10Florian) [18:51:46] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 5WMF-deploy-2015-03-11_(1.25wmf21), 5WMF-deploy-2015-03-18_(1.25wmf22): [Regression wmf21] VisualEditor in mobile doesn't load - https://phabricator.wikimedia.org/T93036#1127162 (10Florian) [18:52:07] jdlrobson: we need to make sure not to grab 1.0 until we can merge that properly. I'll put in a patch. [18:52:54] chrismcmahon: this is Extension:Gather [18:53:51] jdlrobson: OK, still I think you want mediawiki_selenium 0.4.2 not 1.0, and talk to marxarelli about merging that in the near future [18:55:36] mhurd uploading two traces now for you (and anyone else who's interested) to look at [18:56:26] mhurd coreyfloyd dr0ptp4kt can you download & view this trace? https://www.dropbox.com/sh/45upzso0najkxn6/AAD-Ti8SoVu7vSTHZTIZxNgca?dl=0 [18:56:47] on it [18:57:33] bgerstle: had to add the .trace extension to the folder [18:57:37] jdlrobson: if you want to use mediawiki_selenium 1.0, i can help get you started. it's mostly backwards compatible aside from the environment var configuration [18:57:45] hm, ok [18:58:06] bgerstle: is that all you wanted or do you want us to inspect the trace too? [18:58:21] coreyfloyd: be my guest! :-) [18:58:45] bgerstle: seriously or are you trolling? [18:58:45] mhurd coreyfloyd i tapped the "Barack Obama" search result at around 15s [18:58:53] oh ok [18:58:54] coreyfloyd: that's my secret, i'm always trolling [18:59:06] bgerstle: what am i looking for - performance or a crash or wht? [18:59:15] difference in perf between runs 1 & 2 [19:00:18] (03PS6) 10Bmansurov: Alpha: Load banner images on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) [19:02:01] (03CR) 10jenkins-bot: [V: 04-1] Alpha: Load banner images on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [19:05:07] (03PS7) 10Bmansurov: Alpha: Load banner images on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) [19:10:26] MaxSem: after re-reading it, my comments weren't relevant [19:10:33] i'm reading over it again now that george is in bed [19:10:36] (03PS8) 10Bmansurov: Alpha: Load banner images on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) [19:17:57] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Fix scrolling behaviour - https://phabricator.wikimedia.org/T92791#1129883 (10Jdlrobson) Retry.. Patch hadn't been merged at time of your comment! [19:19:40] bgerstle: so was different code ran for each run, or was it the same code? [19:20:10] run 1 was master, run 2 was mhurd's patch [19:20:19] i'm seeing an overall decrease in CPU usage between 1 & 2 [19:20:30] i'm heading out for today! [19:20:33] but overall I/O seems the same, if not *slightly* worse due to increased usage of NSURLCache [19:20:34] see you guys tomorrow [19:20:43] but that's just on loading an article cold [19:20:57] we're trying to evaluate if subsequent articles load faster because common small UI images are cached [19:21:52] coreyfloyd: although i'm not 100% sure i'm interpreting the I/O Activity instrument data properly [19:22:01] was looking at the "Call Tree" view and seeing increase/decrease of different operations [19:22:11] but, that might be a percentage of total I/O, not total CPU [19:22:25] bgerstle: yeah - time profiler might help [19:22:29] so if CPU is down, we should be certain it's an improvement, but the I/O activity instrument tells us what's going on [19:22:48] bgerstle: so you can get a read on the stack traces in the app without worrying about the rest of the system [19:22:49] coreyfloyd: yeah we can try that too [19:23:16] coreyfloyd: true, i was trying to look specifically at disk utilization since that was the intent of the patch [19:24:14] 3Gather Sprint Diplodocus: Incorrect result for loading action=query&list=lists&lstids=X&lstowner=YYY - https://phabricator.wikimedia.org/T93103#1129907 (10Yurik) a:3Yurik [19:24:28] (03PS1) 10Yurik: Fixed API ids+owner shows watchlist in list result [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197715 [19:24:48] bgerstle: yeah with the io instrument the fopen / close and family are separate, so it is hard to add them together to see the true impact of the calling function [19:25:34] 3Gather Sprint Diplodocus: Incorrect result for loading action=query&list=lists&lstids=X&lstowner=YYY - https://phabricator.wikimedia.org/T93103#1129436 (10Yurik) Fixed in https://gerrit.wikimedia.org/r/197715 [19:25:43] yeah, i guess time profiler is better to figure out the diff in this case [19:25:48] then you could I/O to diagnose the problem [19:25:56] 3Gather Sprint Diplodocus, 5Patch-For-Review: Incorrect result for loading action=query&list=lists&lstids=X&lstowner=YYY - https://phabricator.wikimedia.org/T93103#1129915 (10Yurik) [19:25:59] bgerstle: actually nm - i can do twiddle some handles to get at it [19:26:30] coreyfloyd: you can see stack traces, but not overall impact of disk usage [19:26:55] (03PS1) 10Mhurd: Fix for image gallery sometimes not immediately showing cached file. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197716 [19:27:06] MaxSem: the structure seems ok to me, i'll keep an eye out for future patches [19:27:07] (03PS2) 10Mhurd: Fix for image gallery sometimes not immediately showing cached file. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197716 [19:27:16] there are some trivial comments i could make -- but it's a wip [19:27:34] bgerstle: https://www.dropbox.com/s/uq7i0fw55fo5mk4/Screenshot%202015-03-18%2015.27.15.png?dl=0 [19:27:46] https://www.dropbox.com/s/o8dhyyv58yp5vy6/Screenshot%202015-03-18%2015.27.25.png?dl=0 [19:27:48] (03CR) 10Mhurd: "Quick hack to make gallery always show largest cached variant. This is probably handled a better way?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197716 (owner: 10Mhurd) [19:31:47] coreyfloyd: but the "Total %" i think is out of all *I/O* actions [19:31:54] not CPU usage (as it is in the time profiler) [19:32:36] https://www.dropbox.com/s/axgbw6pk3lv9uxt/Screenshot%202015-03-18%2015.30.19.png?dl=0 [19:32:40] https://www.dropbox.com/s/6tubzzaudknvbjz/Screenshot%202015-03-18%2015.31.18.png?dl=0 [19:33:04] bgerstle: that is for the specified time period, 15 seconds on [19:33:18] yep [19:33:42] was looking at something similar [19:33:45] just w/ open/read/etc. [19:33:51] so we can use that to find out where we're doing I/O [19:33:55] but i just want to know if we're doing less [19:34:16] the CPU diff between the two seems to indicate that we are, but i guess i really need to look at a time profiler trace [19:34:24] * bgerstle note to self, always have a time profiler instrument... [19:35:36] coreyfloyd: running a time profiler diff test now [19:36:23] bgerstle: actually i forgot to sort that second screen shot - sorting and then adding the top 3 functions in each yeilds only a 2% difference [19:37:14] yeah probabaly some better stuff n the time profiler… [19:37:34] that's more or less consistent with what i found, but i'm not sure what that means for overall disk I/O [19:37:47] i.e. we might be doing more or less of certain kinds of I/O [19:38:44] running profiler on master... [19:40:30] (03PS8) 10Dbrant: [WIP] Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 [19:41:53] 10Wikipedia-App-Android-App: Display lead image on phablet sized screens - https://phabricator.wikimedia.org/T93122#1129943 (10kevinator) 3NEW [19:46:00] coreyfloyd: here's the time profiler diff https://www.dropbox.com/sh/6cyamcmob118jmj/AACQdIcM-U-KN_R7o0juEXfHa?dl=0 [19:47:20] calls to __open drop by ~30% [19:50:23] MaxSem: yt? [19:50:30] yep [19:53:13] https://gerrit.wikimedia.org/r/#/c/197454/4 < to answer your comment [19:53:42] so now the data attribute is responsible for event logging other extensions simply need to add a data attribute to enable the EL [19:54:19] yeah -- only really minor comments -- the aggregation seems ok [19:54:26] looking forward to using it! ;) [19:54:44] (03PS1) 10Jdlrobson: QA: Add edit collection browser tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197722 (https://phabricator.wikimedia.org/T93101) [19:54:58] coreyfloyd: also saw that calls to save objects in the data store (safeFile:atPath:byPerfoming:) drops about 50% [19:55:00] 10Gather, 3Gather Sprint Diplodocus: API: Need method to query all public lists - https://phabricator.wikimedia.org/T93100#1129976 (10Jdlrobson) p:5Triage>3High [19:55:07] so, i think this patch does what it set out to do [19:55:33] (03CR) 10Bgerstle: [C: 031] "instruments results indicate this was a net win!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 (owner: 10Mhurd) [19:56:19] would like to these kinds of high-level perf checks easier to do in the future... just hard to review these kinds of things w/o resorting to subjective assessment [19:56:28] and now.. break time [19:56:29] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Incorrect result for loading action=query&list=lists&lstids=X&lstowner=YYY - https://phabricator.wikimedia.org/T93103#1129978 (10Jdlrobson) [19:57:30] 10Wikipedia-App-Android-App: Display lead image on phablet sized screens - https://phabricator.wikimedia.org/T93122#1129979 (10kevinator) PS Blackberry runs android apps in an emulator and lets me alter the screen size the app sees (to potentially handle incompatibilities with running apps not designed for black... [19:58:33] 10Wikipedia-App-Android-App: Integrate with Google Now - https://phabricator.wikimedia.org/T91512#1129987 (10Tfinc) [19:58:51] 10Wikipedia-App-Android-App: Display lead image on squarish device screens - https://phabricator.wikimedia.org/T93122#1129996 (10kevinator) [20:02:49] bgerstle: for some reason that trace is broken [20:02:52] for me [20:04:37] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Setup WikidataPageBanner extension repository on Gerrit - https://phabricator.wikimedia.org/T93127#1130019 (10Jdlrobson) 3NEW [20:04:49] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata, 7Easy, and 2 others: Setup WikidataPageBanner extension repository on Gerrit - https://phabricator.wikimedia.org/T93127#1130019 (10Jdlrobson) [20:06:41] jdlrobson, fixed issue, pls review [20:06:52] minor code change, big tests change [20:07:10] implementing mode=all [20:07:12] yurik: k looking [20:09:00] 10Gather, 3Gather Sprint Diplodocus: Article Deletion handling - https://phabricator.wikimedia.org/T90992#1130054 (10Jdlrobson) a:3Jdlrobson [20:09:18] yurik: so the reason your bugs aren't auto updating.. [20:09:29] you need to put Bug: T... and then no new line between change id and bug number [20:09:29] is... [20:09:52] 10Wikipedia-App-Android-App: Display lead image on squarish device screens - https://phabricator.wikimedia.org/T93122#1130058 (10Dbrant) p:5Triage>3Normal Hmm, very interesting! We simply have a hard-coded minimum height threshold for displaying lead images (480dp). In your first screenshot, it looks like th... [20:09:53] i think its a bug ;) [20:09:59] (03PS2) 10Jdlrobson: Fixed API ids+owner shows watchlist in list result [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197715 (https://phabricator.wikimedia.org/T93103) (owner: 10Yurik) [20:10:12] https://gerrit.wikimedia.org/r/#/c/197715/1..2//COMMIT_MSG < yurik :) [20:10:37] jdlrobson, thx [20:10:45] coreyfloyd: how about https://www.dropbox.com/s/zwshj8r8fe79q8x/barack%20obama%20mhurd%20patch%20trace.trace.zip?dl=0 [20:11:15] bgerstle: got it [20:11:42] Deskana: so what's the verdict on image transitions? https://phabricator.wikimedia.org/T92446 [20:12:26] (03CR) 10Jdlrobson: [C: 032] Fixed API ids+owner shows watchlist in list result [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197715 (https://phabricator.wikimedia.org/T93103) (owner: 10Yurik) [20:13:31] (03Merged) 10jenkins-bot: Fixed API ids+owner shows watchlist in list result [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197715 (https://phabricator.wikimedia.org/T93103) (owner: 10Yurik) [20:13:44] jdlrobson, thx [20:13:45] bgerstle: yeah i see the 50% drop now [20:14:02] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1130080 (10Jdlrobson) Blocked on: T93100 [20:14:07] yep, nice work mhurd [20:14:18] 10Gather, 3Gather Sprint Diplodocus: API: Need method to query all public lists - https://phabricator.wikimedia.org/T93100#1129322 (10Jdlrobson) [20:14:27] a small step for the data layer, a giant leap for app performance ;-) [20:14:59] bgerstle: I've not had a lot of time to sit and think about it. Let's find 30 minutes of Vibha's time to talk through this. [20:15:08] ok [20:15:32] 10Gather, 3Gather Sprint Diplodocus: Only call API dynamically except for special:gather - https://phabricator.wikimedia.org/T92711#1118648 (10Jdlrobson) Let's re-evaluate this when T92580 is closed. From what I understand the concern is that core already makes a query for the watchlist status and we are addin... [20:16:46] 10Gather, 3Gather Sprint Diplodocus: Issue installing Gather on new mediawiki instance - https://phabricator.wikimedia.org/T93095#1129179 (10Jdlrobson) @yurik is this just a me issue or a real issue? [20:16:52] bmansurov: would it be possible for you to give me some numbers on how many claims we would potentially be pushing to Wikidata with a few different threshold values? I mainly want to get an idea of the minimum and maximum, so like (>=2, >=75%), (>=5, 80%), (>=10, >=90%). [20:17:10] 10Gather, 3Gather Sprint Diplodocus: Article Deletion handling - https://phabricator.wikimedia.org/T90992#1130093 (10Jdlrobson) a:5Jdlrobson>3None [20:17:12] kaldari: sure, let me get those numbers [20:17:12] (03PS1) 10Deskana: DO NOT MERGE - Wikidata description editing prototype [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197733 [20:17:27] bmansurov: but don’t actually push anything to Wikidata yet :) [20:17:28] (03CR) 10Deskana: [C: 04-2] "This is a prototype and should not be merged." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197733 (owner: 10Deskana) [20:17:33] kaldari: ok [20:18:09] (03CR) 10jenkins-bot: [V: 04-1] DO NOT MERGE - Wikidata description editing prototype [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197733 (owner: 10Deskana) [20:18:22] Nobody cares, Jerkins. [20:18:49] (03PS7) 10MaxSem: Claim aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 [20:19:00] WIP gone:P [20:19:28] 10Gather, 3Gather Sprint Diplodocus: Issue installing Gather on new mediawiki instance - https://phabricator.wikimedia.org/T93095#1130106 (10Yurik) Seems like a broken schema updated link. Try switching to require ".../Gather/Gather.php" instead of extension.json loading [20:20:15] (03CR) 10jenkins-bot: [V: 04-1] Claim aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 (owner: 10MaxSem) [20:22:24] 2, 75% = 2680 5, 80% = 602 10, 90% = 103 [20:22:27] kaldari: ^ [20:25:40] jdlrobson, do you want mode=all sorted by user+label or by listid ? [20:25:55] that was userid+label [20:26:03] yurik: ideally last modified timestamp... [20:26:18] where last modified is currently just a modification to the gather_lists table [20:26:40] mhurd i'm amending your patch https://gerrit.wikimedia.org/r/#/c/197716/2 to put the largestCachedVariant in a different place [20:26:50] i changed my mind about not using uniqueLargestVariants [20:27:03] i'm moving your approach into the conditional where we use the "stub" as a fallback [20:27:20] and instead of using the stub (which might not be cached) we use it's largest cached variant [20:27:38] this way, we only search for the largest cached variant when we need it, instead of all the time for every cell [20:27:53] mhurd can you point me to a couple articles where this was happening? [20:28:06] (03PS4) 10Robmoen: Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 [20:28:37] (03PS8) 10MaxSem: Claim aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 [20:29:29] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Article reader sees message/guidance about creating a collection so that they know the feature exists and the entry point - https://phabricator.wikimedia.org/T91015#1130132 (10rmoen) @JKatzWMF: Should clicking the watchstar also dismiss the CTA like th... [20:29:51] kaldari, phuedx: I'm done ^^^ :P [20:30:11] MaxSem: what even... [20:30:15] whoa! [20:31:00] (03PS5) 10Robmoen: Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 [20:35:38] (03PS6) 10Robmoen: Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 [20:35:43] 10Gather, 3Gather Sprint Diplodocus: Fatal error relating to API (bad id) - https://phabricator.wikimedia.org/T93135#1130157 (10Jdlrobson) 3NEW [20:37:20] (03PS2) 10Jdlrobson: Surface page images in collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197256 [20:37:22] (03PS1) 10Jdlrobson: Limit API query to just return the required Collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197735 [20:37:32] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Performance: onMakeGlobalVariablesScript causes too many internal hits to API - https://phabricator.wikimedia.org/T92580#1130171 (10Jdlrobson) Somewhat related: https://gerrit.wikimedia.org/r/197735 [20:38:29] (03PS3) 10Jdlrobson: Surface page images in collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197256 [20:38:34] (03PS2) 10Jdlrobson: Limit API query to just return the required Collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197735 [20:39:38] coreyfloyd: my bad, got distracted [20:39:43] mhurd seems like it happens on "picasso's blue period" and your approach fixed it. [20:39:45] coreyfloyd: my bad, got distracted [20:39:47] coreyfloyd: joining now [20:39:50] np [20:40:27] (03PS3) 10Bgerstle: Fix for image gallery sometimes not immediately showing cached file. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197716 (owner: 10Mhurd) [20:41:25] (03PS1) 10Yurik: API: list=lists & lstmode=all gets all lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197738 (https://phabricator.wikimedia.org/T93100) [20:41:29] jdlrobson, ^ [20:42:02] jdlrobson, the ordering is done by list id, but once i add additional fields, we will switch it [20:46:30] (03CR) 10Jdlrobson: Article reader sees guidance about creating a collection (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [20:51:12] Deskana: so i went ahead and changed some of the logic so that images are always sized to fit the screen (even if they're small) [20:51:51] looks good enough in most cases and make the transition essentially seamless (similar to the scenario i described before where the image info was in the cache) [20:52:14] Deskana: if you want to grab vibha for a quick hangout i can demonstrate in the simulator [20:54:58] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Article reader sees message/guidance about creating a collection so that they know the feature exists and the entry point - https://phabricator.wikimedia.org/T91015#1130234 (10JKatzWMF) yes--good catch! [20:55:56] (03CR) 10Jdlrobson: [C: 04-1] "Doesn't work for anons" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [20:56:58] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: API: Need method to query all public lists - https://phabricator.wikimedia.org/T93100#1130240 (10Jdlrobson) a:3Yurik Please be sure to assign yourself to tasks so we don't duplicate effort. [20:57:25] jdlrobson, someone else is working on api??? [20:57:52] yurik: i've been tweaking a few bits with respect to another story [20:58:03] i'm gaining confidence \;-) [20:58:09] * yurik is scared [20:58:21] just in general, if you assign yourself i know what's coming up and what i need to review :) [20:58:28] ok [20:58:47] * jdlrobson has eye pain again and is going for a quick walk. brb [20:58:52] jdlrobson, i will probably add modified_ts & [20:59:03] perm fieds [20:59:05] fields [20:59:21] jdlrobson: you wear glasses? [20:59:34] jdlrobson: i used to get eye-fatigue headaches, got better after i got a pair of specs [20:59:46] bgerstle: She's working on something with Adam right now. Go ahead and schedule something with her, and put me on as optional and I'll see if I can make it. [20:59:51] bgerstle: My calendar is insaaaaane [21:00:03] k [21:07:49] (03CR) 10Mhurd: [C: 031] Fix for image gallery sometimes not immediately showing cached file. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197716 (owner: 10Mhurd) [21:10:15] (03CR) 10Aude: "nitpick" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197733 (owner: 10Deskana) [21:12:38] (03CR) 10Deskana: DO NOT MERGE - Wikidata description editing prototype (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197733 (owner: 10Deskana) [21:14:47] (03CR) 10Aude: DO NOT MERGE - Wikidata description editing prototype (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197733 (owner: 10Deskana) [21:21:41] (03PS1) 10Mhurd: Fix for iPad search result thumbnail height scale factor. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197753 [21:22:03] bgerstle: im wearing contacts but yeh i have glasses [21:22:11] right [21:22:28] i spent whole day yesterday with just glasses on in hope they'd recover [21:22:29] (03PS15) 10Mhurd: Fix for expensive image data inflation for determing image size. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 [21:22:38] i'm seeing optiicians next week [21:32:59] (03CR) 10Dr0ptp4kt: [C: 032] Fix for expensive image data inflation for determing image size. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197277 (owner: 10Mhurd) [21:33:21] (03PS4) 10Dr0ptp4kt: Fix for image gallery sometimes not immediately showing cached file. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197716 (owner: 10Mhurd) [21:33:41] (03PS1) 10MaxSem: WIP: submission [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 [21:34:01] * MaxSem scratches head [21:34:21] aude, how do I tell a ChangeOp what user is making the edit? [21:35:15] 10Gather, 3Gather Sprint C_, 5Patch-For-Review: Adding to new collection workflow - https://phabricator.wikimedia.org/T91296#1130321 (10JKatzWMF) [21:35:16] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Fix scrolling behaviour - https://phabricator.wikimedia.org/T92791#1130320 (10JKatzWMF) 5Open>3Resolved [21:36:15] MaxSem: huh? [21:36:41] i am not sure but also not sure you should need to deal with ChangeOp [21:36:55] would need to see your patch [21:37:08] aude, https://gerrit.wikimedia.org/r/197760 [21:37:29] k [21:37:43] (the patch is obviously not yet working) [21:37:56] i would look at WikiPageEntityStore [21:38:06] it can handle the entire save operation [21:38:50] daniel might have other suggestion [21:38:53] hmm, Daniel said I should use ChangeOp [21:38:55] :P [21:38:59] oh [21:40:16] or what about a faux api request? [21:40:39] I started with API. I'd rather kill myself [21:41:22] the API itself is OK, but faux request quickly got intolerable [21:42:46] we first drafted https://gerrit.wikimedia.org/r/#/c/190104/1/includes/SubmissionJob.php :163 but Daniel said I should use ChangeOp because it has error checking [21:42:47] :/ [21:43:01] i think ChangeOp is unrelated to user [21:43:18] 8-0 [21:43:19] the api will apply a changeop to an entity [21:43:27] and then save the entity [21:43:35] ahhhh! [21:43:48] take a look at what the EditEntity api module does (and it's base classes) [21:44:17] it ends up at ApiWikibase::attemptSaveEntity [21:45:21] well, that's what I started with. very hard to follow due to too many files [21:45:28] in ideal world, the code in the api would be factored out and be reusable for you [21:45:34] yeah [21:45:42] btw, I found a bug in ChangeOpClaim: if( !$claims->hasClaimWithGuid( $this->claim->getGuid() ) ) { [21:45:42] $newClaimList = $this->addClaim( $claims, $summary ); [21:45:42] } else { [21:45:42] $newClaimList = $this->setClaim( $claims, $summary ); [21:45:43] } [21:45:44] (03CR) 10Dr0ptp4kt: [C: 032] Fix for image gallery sometimes not immediately showing cached file. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197716 (owner: 10Mhurd) [21:46:03] :/ [21:46:05] oh, add vs. set [21:46:10] never mind [21:46:17] (03PS2) 10Dr0ptp4kt: Fix for iPad search result thumbnail height scale factor. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197753 (owner: 10Mhurd) [21:46:30] this is some of our oldest and not so nice code [21:47:15] mhurd dr0ptp4kt coreyfloyd good news everyone! i've enabled static analysis on build [21:47:24] so now we can see more fun errors :-) [21:47:35] bgerstle: ast in the house [21:48:05] what what [21:48:13] bgerstle: and YOU get a call graph, and YOU get a call graph [21:48:17] haha [21:48:55] only 12 static analyzer warnings, though [21:50:00] (03CR) 10Dr0ptp4kt: [C: 032] Fix for iPad search result thumbnail height scale factor. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197753 (owner: 10Mhurd) [21:50:20] (03CR) 10Dr0ptp4kt: [V: 032] Fix for iPad search result thumbnail height scale factor. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197753 (owner: 10Mhurd) [21:52:26] (03PS7) 10Florianschmidtwelzow: Promote TalkOverlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) [21:58:32] (03PS7) 10Robmoen: Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 [22:00:19] (03PS1) 10Bgerstle: fix image size transitions [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197763 (https://phabricator.wikimedia.org/T92446) [22:13:21] coreyfloyd: mhurd dr0ptp4kt is there anything we can do to help w/ resubmission stuff? [22:13:25] since it sounds like we're resubmitting? [22:13:34] or are we just submitting (w/o the "re") [22:13:41] bgerstle: coreyfloyd mhurd, i'm cutting testflight builds. [22:13:54] dr0ptp4kt: from current master? [22:14:02] bgerstle: yes [22:14:25] dr0ptp4kt: this is a new release candidate, right? [22:14:31] bgerstle: Deskana is going through considerations with comms on whether the 13-march build is what's used or we pre-emptively resubmit [22:15:21] dr0ptp4kt: ok, i didn't know we were cutting a new release today [22:15:35] i just posted a patch for the image size transition fix, but it doesn't seem like it'll make it in [22:16:46] also, i'm guessing this new build won't have HockeyApp crash reporting, since i didn't see a patch to turn it on, and it seems like we're waiting to hear back from legal about account termination policy? [22:17:13] bgerstle: is this the scaling you just discussed with vibha? did she clear it? [22:17:48] dr0ptp4kt: she seemed unsure about edge case handling [22:18:25] i'd also like to know a few more articles where this happened, as i couldn't really reproduce the issue w/ the "Monarch Engineering Co." article [22:19:36] 10Gather, 3Gather Sprint Diplodocus: Article Deletion handling - https://phabricator.wikimedia.org/T90992#1130455 (10rmoen) a:3rmoen [22:20:54] coreyfloyd: are you wrapping up for the day (don't feel compelled to stay on if you are wrapping up)? if not, would you please review https://gerrit.wikimedia.org/r/#/c/197763 ? both style and on several device form factors and OSes. cc bgerstle. bgerstle, i'm not sure about various cases. i have seen the small image pops to larger image thing several times on various articles (naturally, i did not write that down), if that's what you're [22:20:54] wondering about for more issues. [22:21:23] dr0ptp4kt: yeah, that's the issue [22:21:39] mhurd: ^^ would you please review as well? [22:21:47] dr0ptp4kt: bgerstle sure [22:21:48] (03PS2) 10Bgerstle: fix image size transitions [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197763 (https://phabricator.wikimedia.org/T92446) [22:21:53] rebased ^ [22:22:11] jdlrobson, any updates on the patch? [22:22:52] yurik: im trying to make sense of why https://phabricator.wikimedia.org/T93135 happens [22:23:04] bgerstle: if the patch can get through the meatgrinder in the next hour or so AND and we're going to in fact resubmit for production release, then i'm happy to rebuild. but to hedge bets, i'm building the tfbeta as well as the tf "production" stuff. i'm in the middle of the tfbeta process [22:23:06] then ill take a look [22:23:21] cc mhurd coreyfloyd ^^ [22:23:53] dr0ptp4kt: i can look [22:24:19] dr0ptp4kt: bgerstle testing now... [22:24:35] mhurd coreyfloyd i'd recommend checkout out master first to see if you can find any "poppers" [22:24:39] and paste them here so i can verify [22:28:10] mhurd dr0ptp4kt coreyfloyd i'm having a hard time finding articles w/ images that pop as described in https://phabricator.wikimedia.org/T92446 [22:28:10] jdlrobson, can you find out the api call that's being made for that issue? [22:29:42] i'm hitting the same issue elsewhere but Collection::newFromApi [22:30:22] bgerstle: one small bug [22:30:54] lay it on me [22:31:11] bgerstle: if you use network link conditioner to slow connection, and zoom in to the low res image before the high one is received, when the high res one arrives the image zoom resets [22:31:21] jdlrobson, api call, not the internal stuff. Also, note that we don't have unit tests for the listpages - so there might be a bug there [22:31:24] mhurd: not a bug, that's a feature ;-) [22:31:37] i haven't implemented re-zooming in that case [22:31:47] since it involves, you know, math [22:31:59] bgerstle: the image, i think, could/should just get clearer [22:32:13] bgerstle: not a blocker at all [22:32:14] mhurd indeed that's the desired effect [22:32:54] mhurd but, since the two images aren't the same size (i.e. one's just a more pixelated version of the other) i need to do some rect computation and re-zooming [22:33:18] bgerstle: we may be talking about 2 different things… nothing to worry over now [22:33:50] yurik: how can i see the internal api call [22:33:59] i've wrapped in a try catch block but it's not showing me the exception [22:34:00] k [22:34:15] def file it as an issue since it's an edge case we're (intentionally) not handling right now [22:34:16] jdlrobson, can you log all the params you send to the apimain? [22:34:33] do you have debugger attached? [22:34:36] (03PS3) 10Jdlrobson: Limit API query to just return the required Collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197735 [22:34:38] yurik: which debugger? [22:34:38] (03PS1) 10Jdlrobson: WIP: Illustrate collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) [22:34:47] it would be a non issue if i could size the lower-res version the same as the high-res, but i don't know the high-res size ahead of time [22:34:48] yurik: i usually just vardump :) [22:34:50] i use phpstorm [22:34:52] lol [22:35:02] yurik: it's super easy to replicate [22:35:10] mhurd did you find any "popping" articles? [22:35:14] just go to http://localhost:8888/w/index.php/Special:Gather/Yurik/3381137183713173 [22:35:20] its not about replicating, its about stepthrough - you are wasting tons of time without it [22:35:21] e.g. pick an id that doesn't exist [22:35:25] bgerstle: still searching… none so far [22:35:29] or articles where images look unacceptably pixelated? [22:35:36] yurik: well if you can replicate you don't have me as a middle man right/ [22:35:42] mhurd: i mean on master? so we can be 100% certain i fixed the bug [22:35:44] true, will look [22:35:51] yurik :) [22:35:51] bgerstle: no so far they all seem to get the clear version seamlessly [22:35:52] (03CR) 10jenkins-bot: [V: 04-1] Limit API query to just return the required Collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197735 (owner: 10Jdlrobson) [22:35:54] (03CR) 10jenkins-bot: [V: 04-1] WIP: Illustrate collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) (owner: 10Jdlrobson) [22:36:06] bgerstle: oh will test on master on my phone to find some... [22:36:07] yurik: looking at your patch now [22:36:10] gave up trying to work it out [22:36:31] yeah, i'm trying to find an article w/ a popping image, and then view the same article on my patch [22:39:15] bgerstle: found one - “Flight” article, “Physics” section, blimp image [22:39:23] great! thanks mhurd [22:39:53] bgerstle: yay! fixed in patch! [22:39:55] oh i was about to suggest the article from the ticket: https://phabricator.wikimedia.org/T92446 [22:40:02] bgerstle: ^ [22:40:05] coreyfloyd: i didn't see popping on that one, actually [22:40:13] mhurd i didn't see popping on the blimp, i'll try again [22:40:21] (03CR) 10Jdlrobson: [C: 04-1] "Running http://localhost:8888/w/api.php?action=query&list=lists&lstmode=all" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197738 (https://phabricator.wikimedia.org/T93100) (owner: 10Yurik) [22:40:23] oh, maybe because i'm on iPhone 6 [22:40:32] hmm - yeah may be device specific [22:40:54] bgerstle: coreyfloyd not happening on the monarch eng article on master for me [22:41:02] maybe older phones are slower and more noticiable [22:41:12] jdlrobson, i thought about including user's private lists, but i don't think this would be good [22:41:19] coreyfloyd: hmm pops for me on my iphone 6 [22:41:26] =all (=public) is for discovery [22:41:32] so the usage is very different [22:41:41] coreyfloyd: will push patch to it to confirm it fixes it... [22:41:44] mhurd what device are you on? [22:41:57] rechecking out master now… [22:41:59] tried the blimp on iPad & iPhone 6, no popping [22:42:07] yurik: yeh maybe we should just change parameter to =public [22:42:09] jdlrobson, owner will be a separate patch [22:42:13] i think that is clearer then? [22:42:22] mode=allpublic [22:42:23] bgerstle: coreyfloyd dr0ptp4kt the “dev” icon is soooooo handy [22:42:29] yes, thanks for adding that! [22:42:36] mhurd coreyfloyd package downstairs brb [22:42:36] yurik: as for owner, that's fine progress etc.. :) [22:42:38] bgerstle: it was adam’s idea [22:42:43] yurik: sounds good [22:44:54] bgerstle: coreyfloyd confirmed the patch fixed the jumpy “flight” blimp image on my iphone6! [22:44:59] 10Gather, 3Gather Sprint Diplodocus: Caching issues? - https://phabricator.wikimedia.org/T92573#1130500 (10Jdlrobson) Can replicate this pretty consistently. Not sure how to avoid issue though since this is because of the browser cache. If you hard refresh it appears again. Loading this dynamically as Yurik ha... [22:45:01] (03PS2) 10Yurik: API: list=lists & lstmode=allpublic gets all lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197738 (https://phabricator.wikimedia.org/T93100) [22:45:03] jdlrobson, ^ [22:45:29] mhurd: bgerstle: almost done confirming [22:45:30] … [22:46:03] back [22:46:40] yurik: looking [22:46:51] mhurd if you say so, i still didn't see the blimp jump on master [22:46:54] kaldari: templating patch - shall we start a wikitech thread to resolve this bikeshed? [22:46:57] would that help? [22:47:44] bgerstle: mhurd huzah! [22:47:46] (03CR) 10Jdlrobson: [C: 032] API: list=lists & lstmode=allpublic gets all lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197738 (https://phabricator.wikimedia.org/T93100) (owner: 10Yurik) [22:48:11] (03CR) 10Florianschmidtwelzow: Alpha: Quickly lookup a brief info about a wiki page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195818 (owner: 10Bmansurov) [22:48:37] 10Gather, 3Gather Sprint Diplodocus: Include owner of lists when using lstmode api parameter - https://phabricator.wikimedia.org/T93148#1130510 (10Jdlrobson) 3NEW [22:48:51] (03CR) 10Fjalapeno: [C: 031] "No blockers - 1 comment" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197763 (https://phabricator.wikimedia.org/T92446) (owner: 10Bgerstle) [22:49:02] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1130522 (10Jdlrobson) [22:49:05] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: API: Need method to query all public lists - https://phabricator.wikimedia.org/T93100#1130518 (10Jdlrobson) 5Open>3Resolved Created T93148 for the owner issue. [22:49:33] jdlrobson: I asked TrevorParscal and Roan if they had any opinions on it, but haven’t heard anything from them yet. It’s probably a bit complicated to discuss on wiki-tech, but we may have to resort to that. [22:49:44] (03Merged) 10jenkins-bot: API: list=lists & lstmode=allpublic gets all lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197738 (https://phabricator.wikimedia.org/T93100) (owner: 10Yurik) [22:49:50] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1120229 (10Jdlrobson) Work can commence on this card now. Use http://localhost:8888/w/api.php?action=query&list=lists&lstmode=allpublic api query. owner information and sorting by modified/created... [22:50:10] (03CR) 10Mhurd: [C: 031] fix image size transitions [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197763 (https://phabricator.wikimedia.org/T92446) (owner: 10Bgerstle) [22:50:15] kaldari: it just seems to be do we use a registry or abuse RL names [22:50:21] dr0ptp4kt: ^ [22:51:17] jdlrobson: so you’re OK with the automatic compiler loading? (and just need to decide on the registration system?) [22:51:43] (03CR) 10Bmansurov: Alpha: Quickly lookup a brief info about a wiki page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195818 (owner: 10Bmansurov) [22:52:20] (03CR) 10Bgerstle: "reply" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197763 (https://phabricator.wikimedia.org/T92446) (owner: 10Bgerstle) [22:52:44] coreyfloyd: ^ it was for a static analysis warning, i realize now there was a potentially more elegant way to do it [22:53:02] (rely on matchingImage not being nil and use that as they dictionary key) [22:53:02] bgerstle: gotcha, np [22:53:16] i also wasn't crazy about adding the extra conditional [22:53:36] soon we will have nullability annotations (or swift) and all will be well [22:53:44] bgerstle: are you resubmitting? cc coreyfloyd mhurd [22:53:49] bgerstle: or is it done? [22:53:52] done [22:53:56] bgerstle: thx [22:54:13] dr0ptp4kt: SHIPIT! [22:54:18] (03CR) 10Jdlrobson: [C: 04-1] "* Whacky positioned as you've noticed." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [22:54:19] ;) [22:54:20] (03CR) 10Dr0ptp4kt: [C: 032] fix image size transitions [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197763 (https://phabricator.wikimedia.org/T92446) (owner: 10Bgerstle) [22:54:39] 6Mobile-Web, 10WikiGrok, 5Patch-For-Review: Don't ever show WikiGrok on disambig pages - https://phabricator.wikimedia.org/T91300#1130548 (10bmansurov) a:3bmansurov [22:54:45] (03CR) 10jenkins-bot: [V: 04-1] Don't load WikiGrok on disambiguation pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [22:54:49] dr0ptp4kt: keep in mind we might want vibha et. al to go through a few articles w/ the new behavior to ensure we don't end up w/ any common edge cases that are unacceptable [22:55:09] (03CR) 10OliverKeyes: "Poke" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197288 (owner: 10OliverKeyes) [22:55:42] (03CR) 10Jdlrobson: "I think once https://gerrit.wikimedia.org/r/197222 is merged this should be merged." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197457 (https://phabricator.wikimedia.org/T92881) (owner: 10Jdlrobson) [22:56:47] kaldari: i'm just completely exhausted from this whole thing and want to move on with my life [22:56:56] right now all i care about is making sure mobile doesn't blow up [22:57:25] mhurd coreyfloyd dr0ptp4kt i'm gonna head out now [22:57:33] bgerstle: would this be an acceptable way of wording the enhancement? i realize there's more to it than that, but less is usually more for descriptions... [22:57:41] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197442 (owner: 10Yurik) [22:57:42] bgerstle: "Lower resolution gallery images now more smoothly transition to higher resolution and better fill the screen" [22:57:50] dr0ptp4kt: sounds good to me [22:58:02] jdlrobson, that one is broken [22:58:12] yurik: yeh thought id poke it anyway [22:58:14] because we use different database in testing (( [22:58:17] now i need to work out this api exception issue [22:58:30] jdlrobson, i'm looking, seems like there are other issues as well [22:58:40] (03CR) 10jenkins-bot: [V: 04-1] Automatically run all phpunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197442 (owner: 10Yurik) [22:58:48] i haven't tested listpages much [22:59:30] dr0ptp4kt mhurd bgerstle ok i am heading out for the night [22:59:42] bgerstle: coreyfloyd mhurd - night [22:59:48] o/ [22:59:50] 'night [22:59:59] g'night [23:00:01] coreyfloyd: see ya! [23:04:40] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS, 5Patch-For-Review: App MediaViewer jarringly loads cropped low quality image and then higher quality full size image - https://phabricator.wikimedia.org/T92446#1130600 (10Mhurd) a:3BGerstle-WMF [23:05:04] bgerstle: ^ i tagged you on this and moved it to “ready for signoff" [23:05:21] 10Gather, 3Gather Sprint Diplodocus: watchlist overlay: design tweaks - https://phabricator.wikimedia.org/T92037#1130601 (10Jdlrobson) [23:05:57] 10Gather, 3Gather Sprint Diplodocus: Disable create collection button until text is entered - https://phabricator.wikimedia.org/T93150#1130602 (10Jdlrobson) 3NEW [23:06:57] 10Gather, 3Gather Sprint Diplodocus: watchlist overlay: design tweaks - https://phabricator.wikimedia.org/T92037#1102057 (10Jdlrobson) [23:07:25] 10Gather, 3Gather Sprint Diplodocus: Tablet design issues - https://phabricator.wikimedia.org/T93152#1130619 (10Jdlrobson) 3NEW [23:08:48] 10Gather, 3Gather Sprint Diplodocus: watchlist overlay: design tweaks - https://phabricator.wikimedia.org/T92037#1130627 (10Jdlrobson) @JKatzWMF and @MSyed what does "square the photo in the extract" mean? Can you provide an example on beta labs? Also can you clarify the vague "there should be a white translu... [23:09:14] 10Gather, 3Gather Sprint Diplodocus: watchlist overlay: design tweaks - https://phabricator.wikimedia.org/T92037#1130630 (10Jdlrobson) [23:09:31] (03PS1) 10Jdlrobson: Design tweaks for enter new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197795 [23:09:54] (03PS2) 10Jdlrobson: Design tweaks for enter new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197795 (https://phabricator.wikimedia.org/T92037) [23:10:28] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: watchlist overlay: design tweaks - https://phabricator.wikimedia.org/T92037#1130636 (10Jdlrobson) a:3Jdlrobson [23:18:08] jdlrobson, ok, regarding the failure [23:18:20] you are making this api call: &action=query&list=lists&lstprop=label|description|public|image&prop=pageimages|extracts&generator=listpages&glspid=57&explaintext=1&exintro=1&exchars=140&glsplimit=50&exlimit=50&pilimit=50&continue= [23:18:32] (which is yet another proof why you should dump the model you use) [23:19:19] 10Gather, 3Gather Sprint Diplodocus: Get database schema reviewed for production - https://phabricator.wikimedia.org/T93154#1130667 (10Jdlrobson) 3NEW a:3Yurik [23:19:55] jdlrobson, still there? [23:20:01] yurik: yup [23:20:11] yurik: what's wrong with that api call? [23:20:14] bmansurov: let me know if you get a chance to generate those bot numbers. I want to use them for the bot request. [23:20:31] you ask for list=lists without being logged in [23:20:35] kaldari: I gave them to you already, look above [23:20:36] and without specifying an id [23:20:55] bmansurov: oops. sorry i missed them.... [23:21:00] np [23:21:05] wait that's been run as an anon? [23:21:20] oh wait [23:21:37] jdlrobson, &lstids=57 will fix it [23:21:48] yurik: please review https://gerrit.wikimedia.org/r/#/c/197222/ [23:22:04] yurik: i'm getting tired of talking about 2 similar but not the same thing [23:22:45] it's getting me all confused :-/ [23:23:32] there's also a fixme in collections.php about exactly this [23:24:35] yurik: even whith lstids it seems to be throwing an exception [23:24:38] (03PS1) 10Robmoen: Article Deletion handling [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197802 [23:25:57] jdlrobson, you are trying to replicate all database & permissioning & filtering & other functions in the model... when you add paging, you will simply toss it out... but ohh well )) [23:26:13] yurik: https://gist.github.com/jdlrobson/84d5a37bc63dc7dbcc7b [23:26:20] i just retried my query with the lstids= [23:26:21] and it worked [23:26:31] Fatal exception of type UsageException [23:26:46] right, because you weren't logged in [23:28:25] yurik: i am logged in [23:28:31] http://localhost:8888/w/api.php?action=query&list=lists&lstprop=label|description|public|image&lstids=999&prop=pageimages|extracts&generator=listpages&glspid=999&explaintext=1&exintro=1&exchars=140&glsplimit=50&exlimit=50&pilimit=50&continue= gives me [23:28:34] "code": "glspbadid", [23:28:41] (Error) which is expected [23:28:43] jdlrobson, yes, but it fails when you are not [23:28:48] why is it throwing an exception? [23:29:39] yurik: it shouldn't matter. if the list is private it should say not found [23:29:46] it shouldn't throw an exception [23:29:57] (03CR) 10jenkins-bot: [V: 04-1] Article Deletion handling [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197802 (owner: 10Robmoen) [23:30:01] jdlrobson, of course it should [23:30:12] yurik: it should explode in the users face? of course not [23:30:17] if you say give me my lists, and you are not logged in, it will throw an error [23:30:27] it doesn't explode into users face [23:30:42] it explodes into devs face by giving them a proper error [23:30:43] yurik: http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/Jdlrobson/531313 is exploding in your face [23:30:55] that's because you are not handling the errors )) [23:30:59] i'm asking for the id 531313 [23:31:11] yurik: this is what im asking [23:31:18] im catching it in a try block [23:31:21] is that not handling errors? [23:31:32] or is there something else i need to know about this frustrating api [23:31:35] and how to use it [23:33:04] (03CR) 10Bmansurov: "recheck" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [23:34:40] jdlrobson, here's the fix [23:34:43] use Exception; [23:35:00] add that line at the top of the Collection.php [23:35:10] lol. the irony :) [23:35:11] and next time use a proper IDE, it will show you those errors [23:35:43] and please get rid of the model, its a waste [23:38:00] (03PS1) 10Jdlrobson: Use Exception [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197806 (https://phabricator.wikimedia.org/T93135) [23:38:14] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Fatal error relating to API (bad id) - https://phabricator.wikimedia.org/T93135#1130709 (10Jdlrobson) a:3Jdlrobson [23:38:42] yurik: in a perfect world i would not have to touch php and have no need for an IDE [23:38:56] bgerstle: i may have just cut the html parsing time in half :) [23:39:22] jdlrobson, and that's where you are wrong. chrome/FF is an IDE. But for big projects you need a proper one [23:39:27] dr0ptp4kt: ^ [23:39:56] (03CR) 10Yurik: [C: 032] Use Exception [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197806 (https://phabricator.wikimedia.org/T93135) (owner: 10Jdlrobson) [23:40:14] dr0ptp4kt: bgerstle from ~ 0.11 to ~0.06 [23:40:29] jdlrobson, get rid of line 141 https://gerrit.wikimedia.org/r/#/c/197222/9/includes/Gather.hooks.php,cm [23:40:30] dr0ptp4kt: bgerstle on obama article [23:41:00] (03PS2) 10Jdlrobson: WIP: Illustrate collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) [23:41:02] (03PS4) 10Jdlrobson: Surface page images in collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197256 [23:41:45] yurik: done [23:41:46] (03PS10) 10Jdlrobson: Reduce API requests on any given non-special page to 1 [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197222 (https://phabricator.wikimedia.org/T93101) [23:42:16] jdlrobson, why do you need to inject js code for special pages? [23:42:38] it turns out we use it to edit collections [23:42:46] it's gonna need some follow up patches [23:42:56] but currently editing is broken [23:43:08] we use what to edit collections?? [23:43:11] special:login ? [23:43:16] (03CR) 10jenkins-bot: [V: 04-1] WIP: Illustrate collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) (owner: 10Jdlrobson) [23:43:18] yurik: don't worry i'm on it [23:43:30] once that patch is merged i'll document what needs to happen and why it's the case [23:43:47] but it seems the editor uses it to lookup information on the collection [23:43:55] which is not ideal [23:43:59] (03Merged) 10jenkins-bot: Use Exception [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197806 (https://phabricator.wikimedia.org/T93135) (owner: 10Jdlrobson) [23:45:16] yurik: https://phabricator.wikimedia.org/T92711 will lead to that [23:46:37] (03CR) 10Yurik: [C: 032] Reduce API requests on any given non-special page to 1 [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197222 (https://phabricator.wikimedia.org/T93101) (owner: 10Jdlrobson) [23:47:17] mhurd: cool [23:47:50] (03Merged) 10jenkins-bot: Reduce API requests on any given non-special page to 1 [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197222 (https://phabricator.wikimedia.org/T93101) (owner: 10Jdlrobson) [23:49:06] 10Gather, 3Gather Sprint Diplodocus: Disable create collection button until text is entered - https://phabricator.wikimedia.org/T93150#1130723 (10rmoen) a:3rmoen [23:49:42] (03PS1) 10Robmoen: Disable create collection button until text is entered [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197808 [23:50:18] (03PS3) 10Jdlrobson: WIP: Illustrate collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) [23:50:20] (03PS5) 10Jdlrobson: Surface page images in collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197256 [23:50:45] (03Abandoned) 10Jdlrobson: Limit API query to just return the required Collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197735 (owner: 10Jdlrobson) [23:51:55] (03CR) 10jenkins-bot: [V: 04-1] WIP: Illustrate collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) (owner: 10Jdlrobson) [23:52:43] (03PS1) 10Yurik: Proper check for label being a watchlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197809 [23:52:44] jdlrobson, ^ [23:53:36] 10Gather, 3Gather Sprint Diplodocus: Special pages hit the API one two many times. - https://phabricator.wikimedia.org/T93155#1130732 (10Jdlrobson) 3NEW [23:54:18] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Performance: onMakeGlobalVariablesScript causes too many internal hits to API - https://phabricator.wikimedia.org/T92580#1115219 (10Jdlrobson) See T93155 and T92711 for remaining issues. [23:54:22] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Performance: onMakeGlobalVariablesScript causes too many internal hits to API - https://phabricator.wikimedia.org/T92580#1130747 (10Jdlrobson) 5Open>3Resolved [23:54:35] 10Gather, 3Gather Sprint Diplodocus: Special pages hit the API one two many times. - https://phabricator.wikimedia.org/T93155#1130749 (10Jdlrobson) p:5Triage>3High [23:55:45] 10Gather, 3Gather Sprint Diplodocus: Only call API dynamically except for special:gather - https://phabricator.wikimedia.org/T92711#1118648 (10Jdlrobson) Okay so now visiting http://localhost:8888/w/index.php/Headings leads to a single call to the api via CollectionsList::newFromApi In existing form we can pr... [23:55:51] thanks yurik [23:55:57] i'm slightly more sane now [23:56:28] no worries, that's what i'm here for... ;) [23:56:55] (03CR) 10Jdlrobson: [C: 031] "Need to test and play around with this patch." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197809 (owner: 10Yurik) [23:57:18] jdlrobson, just commit it - it passes the tests [23:57:27] not worth the time [23:57:30] (03CR) 10Jdlrobson: [C: 031] "just need to test" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197808 (owner: 10Robmoen)