[00:05:32] (03PS2) 10Robmoen: Article Deletion handling [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197802 [00:06:14] mhurd: wtf [00:06:21] mhurd: Random image. [00:06:21] Deskana: ? [00:06:26] mhurd: Food security! [00:06:29] Deskana: haha [00:07:46] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: (!!!) Ability to edit collection is broken - https://phabricator.wikimedia.org/T93101#1130763 (10Jdlrobson) 5Open>3Resolved [00:07:48] jdlrobson: part of these mobile editor qunit tests don’t make sense to me. any chance I could run them by you? [00:11:52] (03PS1) 10Yurik: Fixed API editlist incorrect new DB rows bug [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197812 [00:11:58] jdlrobson, ^ - important [00:14:25] rmoen, if jdlrobson is not around, pls +2 ^^ -- important [00:18:53] yurik: on it was just talking to ori [00:19:09] tell him i said hi [00:19:19] yurik: can you explain the patch and the bug it's fixing? [00:19:27] jdlrobson, its in the comment [00:19:49] if you do the api as i described, all titles will be added with the gl_id = 0 [00:19:52] i see [00:19:57] make sure you add tests :P [00:19:57] instead of proper one [00:20:06] jdlrobson, i will - later [00:20:06] tests shouldn't come afterwards :P [00:20:12] (03CR) 10Jdlrobson: [C: 032] Fixed API editlist incorrect new DB rows bug [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197812 (owner: 10Yurik) [00:20:36] yurik: as for this one - https://gerrit.wikimedia.org/r/#/c/197809/ [00:20:42] when can the label be an empty string? [00:20:53] it seems via api you can't do that [00:21:31] jdlrobson, in the database, all watchlists are stored with label === '' [00:21:40] that's how i tell them apart [00:22:03] (03Merged) 10jenkins-bot: Fixed API editlist incorrect new DB rows bug [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197812 (owner: 10Yurik) [00:22:06] watchlist shouldn't support editing of label/description [00:22:23] watchlists don't allow label changes for exactly that reason [00:22:40] because internally they keep label='' [00:22:53] descriptions - we could disable editing, or just leave it as is [00:22:56] why would a watchlist have an entry in gather_lists [00:23:04] it doesn't need to [00:23:04] if you want to make it public [00:23:14] no plans to do that yet [00:23:19] it just complicates things [00:23:28] well, its already implemented and in production, you are welcome not to use it [00:23:33] ideally all this stuff should replace the need for the watchlist table [00:23:58] yurik: okay but JonKatz doesn't want to use that nor support that i think [00:24:15] i'm just worried if we create an exepctation you can via the api that will take us down a rabbit hole [00:24:30] nah, api is for advanced users [00:24:35] e.g. OMG you made my watchlist public and it doesn't say so in Special:Watchlist [00:24:39] if someone wants to hack around it, its fine [00:25:08] we could disable making it public with an extra if at the top, but leave the capability in place [00:25:20] all api calls already take into account that a watchlist can be public [00:25:34] (03CR) 10Jdlrobson: [C: 032] Proper check for label being a watchlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197809 (owner: 10Yurik) [00:25:50] so if you say "give me all the lists of the user X, and that X made their watchlist public, it will be listed just like any other list" [00:25:59] yurik: i think it's better to explicitly drop the support for that. The watchlist is a special non-deletable/renamable collection [00:26:00] i took all the complexity out of your code by doing this [00:26:19] (03CR) 10Jdlrobson: [C: 032] Disable create collection button until text is entered [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197808 (owner: 10Robmoen) [00:26:38] jdlrobson, but that's my point - most of your interface doesn't even need to worry that its a watchlist [00:27:01] (03Merged) 10jenkins-bot: Proper check for label being a watchlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197809 (owner: 10Yurik) [00:27:07] you can simply show it together with all other lists, and support most of the functions like description, public/private, etc [00:27:29] you don't need to special case it anywhere except one spot - renaming the label [00:27:29] (03Merged) 10jenkins-bot: Disable create collection button until text is entered [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197808 (owner: 10Robmoen) [00:27:37] other stuff can work transparently [00:28:23] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: (!!!) Ability to edit collection is broken - https://phabricator.wikimedia.org/T93101#1129343 (10Jdlrobson) Please someeone review the browser tests at https://gerrit.wikimedia.org/r/197722 [00:28:53] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: watchlist overlay: design tweaks - https://phabricator.wikimedia.org/T92037#1130824 (10Jdlrobson) [00:28:54] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Disable create collection button until text is entered - https://phabricator.wikimedia.org/T93150#1130823 (10Jdlrobson) 5Open>3Resolved [00:29:03] yurik this stuff has to be thought out as there are a few places that watchlist is treated differently. I don't think we are ready to open up this capability yet, and Jon brings up the point that if someone makes their watchlist public and then we stop supporting it..then they're upset. [00:30:00] Is it hard to put a protection against this for now? (with the agreed goal that watchlist can one day have very little difference) [00:30:06] JonKatz, we can easily disable all watchlist editing [00:30:34] yurik: all we want to support with watchlist via our api is adding and removing members [00:30:40] JonKatz, my point is that right now you already have to explicitly support the difference between watchlist and nonwatchlist everywhere in code [00:30:46] any edit functionality e.g. label/description/privacy should throw an error for time being [00:30:57] that would be easy to add, sure [00:31:00] we are not utilising it on the frontend [00:31:02] yurik: perfect [00:31:08] yurik: should i create a card? [00:31:45] yurik you make a good point--it's a messy situation, but until we work out hte implications I think we need the scaffolding. [00:31:48] i'm just worried that if we add that, you will put tons of IF() statements everywhere to make sure you are not editing anything about watchlist - and that would be more costly to maintain than simply make watchlists behave identical to other lists [00:32:10] 10Gather, 3Gather Sprint Diplodocus: Editing watchlist meta data should not be possible via the API - https://phabricator.wikimedia.org/T93161#1130826 (10Jdlrobson) 3NEW [00:32:15] ^ yurik JonKatz [00:32:23] i see, but i think its a mistake [00:32:36] will add an if statemnt [00:32:43] yurik: the ultimate goal would be to not need a watchlist table and share tables for collection and watchlist (which is the multiple lists RFC) [00:33:01] so yes we'll have if statements in the meantime, but np provided there are tests [00:33:07] jdlrobson, i doubt that can happen easily due to the notification nature of the watchlist [00:34:24] 10Gather, 3Gather Sprint Diplodocus: Populate gather with proper feature name - https://phabricator.wikimedia.org/T92665#1130835 (10Jdlrobson) [00:34:34] jdlrobson, JonKatz, let me clarify - the ONLY reason you think we shouldn't treat them the same is because someone might be upset they made their watchlist public and later we decided to disable? [00:34:54] just so that we have it in the card [00:35:04] actually, lets make a card and put the discussion there [00:36:12] (03CR) 10Jdlrobson: [C: 032] Article Deletion handling [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197802 (owner: 10Robmoen) [00:36:45] (03CR) 10Jdlrobson: "Also I think we need to hide the link but asking for guidance in bug." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197802 (owner: 10Robmoen) [00:37:22] yurik the reason is that watchlist is currently a different thing with a different usecsae, context and history. we know we can't treat them the same in all respects given that history, so rather than meddle with it in the pilot phase, we want to keep it simple by not changing any of the functionality of the watchlist. [00:37:48] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Article Deletion handling - https://phabricator.wikimedia.org/T90992#1130838 (10Jdlrobson) Merged @rmoen's patch Just to check - @JKatzWMF missing pages show a read more link. Should this be present so the user can navigate to the page and remove the pa... [00:38:08] (03Merged) 10jenkins-bot: Article Deletion handling [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197802 (owner: 10Robmoen) [00:38:29] JonKatz, but i don't propose to change the watchlist functionality - but you already introduced them when you show them as part of the watchlist. So what do you want to do about images for example? My solution allows for images to be set on the watchlist [00:38:45] *part of the lists [00:38:48] mhurd: just transferred the GH repo for the service to https://github.com/wikimedia/service-mobileapp-node. You may want to fork from there [00:39:07] bearND: that’s great! will do! [00:39:08] gwicke: ^ [00:39:52] bearND: hangout later this week to hack a bit more? [00:39:53] mhurd: it's now HTML based, with two blocks of JS for metadata. One at the beginning and another one at the end [00:39:54] yurik: images can be determined without the api on the fly if necessary. [00:40:00] mhurd: sure [00:40:02] i'm still trying to work that out now [00:40:17] jdlrobson, sigh, all that complexity (( [00:40:17] bearND: cool! [00:40:29] mhurd: I haven't done any more DOM manipulations besides adding the section anchors [00:40:36] and section headlines [00:40:58] yurik: or maybe Watchlist don't need a page image. [00:41:05] whatever's easiest [00:41:32] imho easiest is to treat them all the same - you won't ever have to deal with the diffs [00:41:38] bearND|food: nice that it worked! [00:41:53] yurik: the privacy concerns me. The watchlist database table is understood to be private at the moment [00:42:04] i don't like the idea of an extension re-defining that and i think that will be sure to piss people off [00:42:08] jdlrobson, i can disable the public on the list [00:42:08] it's a hornets nest [00:42:13] the rest i don't really care about [00:42:20] ok, will disable public [00:42:56] ^ fine with me as long as okay with JonKatz. We are not surfacing it in UI but i'm not too bothered about people adding descriptions to their watchlist for whatever reason [00:43:03] (via API not UI) [00:43:15] works for me [00:43:28] yurik jdlrobson thanks! [00:43:32] thx [00:46:32] (03PS2) 10Kaldari: Allow null edits on mobile (same as desktop) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197446 (https://phabricator.wikimedia.org/T93029) [00:47:20] yurik is $wgEnableWriteAPI=true on production? [00:47:36] jdlrobson, of course [00:47:47] cool it doesn't seem to be in a default install [00:48:04] jdlrobson, use vagrant ;) [00:48:31] yurik: see https://phabricator.wikimedia.org/T78733 [00:48:36] that stopped me using it [00:49:15] noapiwrite: Editing of this wiki through the API is disabled. Make sure the $wgEnableWriteAPI=true; statement is included in the wiki's LocalSettings.php file [00:49:17] yurik: mmm [00:49:20] i've enabled it [00:49:53] jdlrobson, on vagrant, try enabling the "zend" role [00:50:02] yurik: i'm not using vagrant [00:50:06] switches back to the proper php [00:51:27] (03PS4) 10Jdlrobson: WIP: Illustrate collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) [00:51:29] (03PS6) 10Jdlrobson: Surface page images in collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197256 [00:52:36] (03CR) 10jenkins-bot: [V: 04-1] WIP: Illustrate collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) (owner: 10Jdlrobson) [00:54:38] 10Gather: Login page should show collection specific message - https://phabricator.wikimedia.org/T91085#1130861 (10JKatzWMF) 5Open>3Resolved [00:55:37] (03CR) 10Jdlrobson: [C: 04-1] "The value is set..." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) (owner: 10Jdlrobson) [01:00:40] 10Gather, 3Gather Sprint Diplodocus: API: disallow making watchlist public - https://phabricator.wikimedia.org/T93161#1130872 (10Yurik) [01:01:38] 6Mobile-Web: Search workflow in alpha needs non-JavaScript fallback - https://phabricator.wikimedia.org/T92675#1130882 (10kaldari) I still have no idea what is being asked for by this bug. The search workflow in alpha already has a non-JavaScript fallback. The new design just added an extra step to both it and t... [01:02:19] (03CR) 10Bmansurov: [C: 032] Allow null edits on mobile (same as desktop) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197446 (https://phabricator.wikimedia.org/T93029) (owner: 10Kaldari) [01:03:32] (03PS1) 10Mhurd: WIP: speed up html parse. Prune html before HPPLE parse. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197823 [01:03:34] (03Merged) 10jenkins-bot: Allow null edits on mobile (same as desktop) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197446 (https://phabricator.wikimedia.org/T93029) (owner: 10Kaldari) [01:05:10] (03CR) 10Mhurd: "If it looks legit, I will add tests, move "fastReduceToImgTagsOnlyFromHTML" to better place and rename it." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197823 (owner: 10Mhurd) [01:05:52] bgerstle: coreyfloyd ^ [01:06:01] heading out [01:06:54] (03PS1) 10Yurik: Prevent watchlist from becoming public [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197824 (https://phabricator.wikimedia.org/T93161) [01:10:32] 10Gather: Add members to a collection using a search interface - https://phabricator.wikimedia.org/T90991#1130909 (10Yurik) Keep in mind, just in case it might be useful, that since action=editlist accepts generator, you could add all (up to a limit, but continuable) results of the generator to a list. Including... [02:16:01] 6Mobile-Web, 10Flow: On mobile, the Flow notification's link takes you to the desktop version of the Flow page, even though the main (background) link takes you to the mobile one - https://phabricator.wikimedia.org/T93035#1130971 (10Quiddity) [02:16:21] 6Mobile-Web, 10Flow: On mobile, the Flow notification's link takes you to the desktop version of the Flow page, even though the main (background) link takes you to the mobile one - https://phabricator.wikimedia.org/T93035#1127129 (10Quiddity) I've added a description, with details [03:08:28] 10MobileFrontend-Feature-requests, 10Wikidata, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1131015 (10Nicolas_Raoul) [03:08:55] (03PS9) 10Dbrant: Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 [03:29:50] (03PS1) 10BearND: WIP: Add Talk link at bottom of page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197851 [03:34:20] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-Android: As a user, I'd like lead sentences to be consistent so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1131022 (10Dbrant) a:3Dbrant [04:10:07] Deskana: Have you played with the latest reuse WebView patch (https://gerrit.wikimedia.org/r/#/c/197346/)? I'm wondering if you notice anything. [04:10:46] bearND: Not yet. [04:56:33] 6Mobile-Web, 10Flow: On mobile, the Flow notification's link takes you to the desktop version of the Flow page, even though the main (background) link takes you to the mobile one - https://phabricator.wikimedia.org/T93035#1131037 (10EBernhardson) we should be able to write a test that renders all the possible... [05:01:30] (03CR) 10Deskana: [C: 04-1] "Tested this on my Nexus 4 Android 4.4.4 emulator and it seems good. Things seem a lot faster." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 (owner: 10Dbrant) [05:27:51] 6Mobile-Web, 5Patch-For-Review: Null edit results in JS error, hung editor on mobile (stable) - https://phabricator.wikimedia.org/T93029#1131043 (10Florian) 5Open>3Resolved a:3Florian [05:28:31] 6Mobile-Web: Null edit results in JS error, hung editor on mobile (stable) - https://phabricator.wikimedia.org/T93029#1126965 (10Florian) [07:21:57] 6Mobile-Web, 10MobileFrontend-Feature-requests: MobileFrontend strips colours from a table on colours - https://phabricator.wikimedia.org/T87719#1131088 (10Nemo_bis) [07:22:21] 6Mobile-Web, 10MobileFrontend-Feature-requests: MobileFrontend strips colours from a table on colours - https://phabricator.wikimedia.org/T87719#1131089 (10Nemo_bis) 5stalled>3Resolved Oh well, marking resolved. I've asked the user to tell us, if it isn't. https://it.wikipedia.org/w/index.php?title=Discuss... [07:49:51] 10Wikipedia-App-iOS-App: Saved pages can show Wikidata descriptions. - https://phabricator.wikimedia.org/T93170#1131101 (10Vibhabamba) 3NEW a:3Mhurd [08:26:04] 10Wikipedia-App-iOS-App: Missing Tap highlights on lists - https://phabricator.wikimedia.org/T93173#1131133 (10Vibhabamba) 3NEW a:3dr0ptp4kt [09:36:14] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1131269 (10Qgil) [09:42:23] morning! [10:07:00] hey joakino [10:07:06] how're you doing? [10:12:06] hi phuedx [10:12:12] having some problems with the wifi :( [10:22:42] :( [10:54:08] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Incorrect result for loading action=query&list=lists&lstids=X&lstowner=YYY - https://phabricator.wikimedia.org/T93103#1131502 (10Jhernandez) Awesome, thanks @yurik [11:03:09] 10Gather, 3Gather Sprint Diplodocus: Only call API dynamically except for special:gather - https://phabricator.wikimedia.org/T92711#1131517 (10Jhernandez) @jdlrobson awesome that we are at this point already. How do we measure this? Or is it a matter of opinions from experience? In any case, whatever we decid... [11:07:36] (03Abandoned) 10Jhernandez: WIP: A more optimal Collection::newFromApi [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197085 (https://phabricator.wikimedia.org/T92862) (owner: 10Jhernandez) [11:10:01] (03CR) 10Jhernandez: [C: 04-1] "@jdlrobson needs more work and possibly more feedback from @msyed See bug: T91384" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194498 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [11:22:26] (03CR) 10Jhernandez: "For menu items added via Javascript it is as simple as before (if it was" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197454 (owner: 10Jdlrobson) [11:48:30] should i have another cup of coffee? [11:48:33] i think so [11:48:35] (03PS2) 10Jhernandez: QA: Add edit collection browser tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197722 (https://phabricator.wikimedia.org/T93101) (owner: 10Jdlrobson) [12:12:20] (03PS3) 10Jhernandez: QA: Add edit collection browser tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197722 (https://phabricator.wikimedia.org/T93101) (owner: 10Jdlrobson) [12:13:50] (03CR) 10Jhernandez: [C: 032] "Removed useless Given." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197722 (https://phabricator.wikimedia.org/T93101) (owner: 10Jdlrobson) [12:14:52] (03Merged) 10jenkins-bot: QA: Add edit collection browser tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197722 (https://phabricator.wikimedia.org/T93101) (owner: 10Jdlrobson) [12:16:25] (03PS1) 10Jhernandez: Update gems and fix mediawiki-selenium version [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197887 [12:18:29] 3Gather Sprint Diplodocus: Update gem dependencies and fix Gemfile - https://phabricator.wikimedia.org/T93195#1131629 (10Jhernandez) 3NEW a:3Jhernandez [12:19:06] (03PS2) 10Jhernandez: Update gems and fix mediawiki-selenium version [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197887 (https://phabricator.wikimedia.org/T93195) [12:35:41] (03PS3) 10Jhernandez: Design tweaks for enter new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197795 (https://phabricator.wikimedia.org/T92037) (owner: 10Jdlrobson) [12:35:58] breaking for lunch [12:36:29] (03CR) 10Jhernandez: "Some issues in PS2" (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197795 (https://phabricator.wikimedia.org/T92037) (owner: 10Jdlrobson) [12:36:53] (03CR) 10Jhernandez: "PS3 is rebased against master to have the bugfix for editing collections" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197795 (https://phabricator.wikimedia.org/T92037) (owner: 10Jdlrobson) [12:38:55] (03PS4) 10Jhernandez: Design tweaks for enter new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197795 (https://phabricator.wikimedia.org/T92037) (owner: 10Jdlrobson) [12:39:48] (03PS1) 10Jhernandez: Design tweaks for watchstar overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197892 (https://phabricator.wikimedia.org/T92037) [12:41:33] (03CR) 10Jhernandez: [C: 032] "I've split the max-width on a follow up patch linked to the same bug. Will post comments there and in the bug with a gif of the problems." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197795 (https://phabricator.wikimedia.org/T92037) (owner: 10Jdlrobson) [12:42:34] (03Merged) 10jenkins-bot: Design tweaks for enter new collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197795 (https://phabricator.wikimedia.org/T92037) (owner: 10Jdlrobson) [12:46:29] (03CR) 10Dbrant: [C: 04-1] "Technically, the "smallest possible change" would be to modify a single bit, whereas this patch modifies no fewer than three bits (totally" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196979 (owner: 10Niedzielski) [12:49:47] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: watchlist overlay: design tweaks - https://phabricator.wikimedia.org/T92037#1131670 (10Jhernandez) @jdlrobson I've merged Design tweaks for enter new collection https://gerrit.wikimedia.org/r/197795 but split the max-width of the overlay to a new patchs... [12:51:12] (03CR) 10Jhernandez: [C: 04-1] "Extracted from previous patch. Broken ATM." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197892 (https://phabricator.wikimedia.org/T92037) (owner: 10Jhernandez) [12:53:53] (03CR) 10Jhernandez: [C: 032] "Hell yeah" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197457 (https://phabricator.wikimedia.org/T92881) (owner: 10Jdlrobson) [12:55:02] (03Merged) 10jenkins-bot: Enable Gather in beta site. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197457 (https://phabricator.wikimedia.org/T92881) (owner: 10Jdlrobson) [12:57:30] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Move Gather to beta mode - https://phabricator.wikimedia.org/T92881#1131682 (10Jhernandez) Wohooo 👏🍻!!! ☑️ Merged 😁👍 [13:27:18] (03CR) 10Niedzielski: "LOL :) This is the only file I found that was incorrectly marked executable. One shouldn't be able to run "./icon-svgs/32/random.svg". I'm" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196979 (owner: 10Niedzielski) [13:38:46] (03CR) 10Dbrant: "oh i see! i didn't notice that this svg file was the only one with the incorrect mode. I'll be happy to merge, but it looks like the patch" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196979 (owner: 10Niedzielski) [13:47:53] (03PS2) 10Niedzielski: Remove executable bit on image file. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196979 [13:48:53] (03CR) 10Dbrant: [C: 032] Remove executable bit on image file. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196979 (owner: 10Niedzielski) [13:51:32] (03CR) 10Niedzielski: "Rebased, woot! I'll look into scripts *missing* their executable bits as I become a little bit more familiar with what's in the repo for a" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196979 (owner: 10Niedzielski) [13:52:10] (03Merged) 10jenkins-bot: Remove executable bit on image file. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/196979 (owner: 10Niedzielski) [13:55:50] (03PS3) 10Sumit: MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) [13:56:08] (03CR) 10jenkins-bot: [V: 04-1] MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [13:57:43] (03PS4) 10Sumit: MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) [14:01:04] back -- have been chatting window positions with builders [14:01:06] bleh [14:02:20] (03PS5) 10Sumit: MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) [14:03:32] (03PS6) 10Sumit: MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) [14:21:46] 10Wikipedia-App-Android-App: EGL-related crashes - https://phabricator.wikimedia.org/T74530#1131867 (10Krenair) [14:59:11] (03PS10) 10Dbrant: Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 [15:23:15] (03PS1) 10Dbrant: Make text in certain TextViews selectable (for copying) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197912 [15:32:06] 10MobileFrontend-Feature-requests, 7Tracking: [Tracking] Obstacles to enable anonymous editing for MobileFrontend users - https://phabricator.wikimedia.org/T55069#1132094 (10Nemo_bis) 5Open>3Resolved Per the conclusion at https://meta.wikimedia.org/w/index.php?title=Wikimedia_Forum&oldid=11628429#Proposal:... [15:42:54] (03CR) 10Phuedx: [C: 04-1] "Looking good! See inline." (0310 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 (owner: 10MaxSem) [15:59:16] (03CR) 10Jdlrobson: [C: 031] Prevent watchlist from becoming public [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197824 (https://phabricator.wikimedia.org/T93161) (owner: 10Yurik) [15:59:41] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: API: disallow making watchlist public - https://phabricator.wikimedia.org/T93161#1132181 (10Jdlrobson) a:3Yurik [16:00:14] (03CR) 10Jdlrobson: [C: 032] Update gems and fix mediawiki-selenium version [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197887 (https://phabricator.wikimedia.org/T93195) (owner: 10Jhernandez) [16:00:34] 3Gather Sprint Diplodocus, 5Patch-For-Review: Update gem dependencies and fix Gemfile - https://phabricator.wikimedia.org/T93195#1132190 (10Jdlrobson) 5Open>3Resolved [16:01:51] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Event logging for hamburger "collections" link - https://phabricator.wikimedia.org/T92855#1132199 (10Jdlrobson) ping @kaldari [16:06:00] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10MediaWiki-API, 6MediaWiki-Core-Team, 5Patch-For-Review: Allow triggering of user password reset email via the API - https://phabricator.wikimedia.org/T32788#1132210 (10ksmith) Can we decide whether this patch is going to move forward or be abandoned... [16:06:48] phuedx I'm making an aeropress [16:07:19] kristenlans: your making an aeropress!? [16:07:22] that's impressive [16:07:41] i'm fairly sure aerobie has them machined though, because you need the cylinder to have a good seal [16:07:48] Hahaha I saw that coming; I'm amking a cup of coffee with an aeropress, that is! [16:10:14] (03Merged) 10jenkins-bot: Update gems and fix mediawiki-selenium version [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197887 (https://phabricator.wikimedia.org/T93195) (owner: 10Jhernandez) [16:14:44] (03CR) 10Phuedx: [C: 031] "What do you think about my comment inline?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197454 (owner: 10Jdlrobson) [16:17:41] (03CR) 10Phuedx: [C: 032] Use new schema for main menu click tracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197455 (owner: 10Jdlrobson) [16:24:34] (03CR) 10Bgerstle: [C: 04-1] "can we talk about this? i'm worried about edge cases we might hit by preprocessing the HTML using regex-like logic, which might be a poor " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197823 (owner: 10Mhurd) [16:30:41] (03CR) 10Phuedx: [C: 04-1] "Minors (really!) inline." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [16:40:14] yo's [16:40:19] hellow [16:45:50] jdlrobson: JonKatz: standup? [16:54:53] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10MediaWiki-API, 6MediaWiki-Core-Team, 5Patch-For-Review: Allow triggering of user password reset email via the API - https://phabricator.wikimedia.org/T32788#1132387 (10Anomie) There are two unrelated issues with respect to the patch: * Architectural... [16:56:15] (03CR) 10Phuedx: [C: 04-1] "What's the reason for the change to the Event Logging schema registration code? Either remove it from the patch or add the reason to the c" (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [16:59:38] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Configure & document iOS build hardware - https://phabricator.wikimedia.org/T92880#1132401 (10Fjalapeno) [17:00:06] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Configure & document iOS build hardware - https://phabricator.wikimedia.org/T92880#1122608 (10Fjalapeno) You can review docs here: https://www.mediawiki.org/w/index.php?title=Wikimedia_Apps/Team/iOS/CI [17:00:54] (03CR) 10Deskana: [C: 04-1] "Better! But the lead image and web view are fading out and in at different times, which is fairly jarring. Can you fix that?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 (owner: 10Dbrant) [17:01:23] (03CR) 10Jdlrobson: "Ping @MaxSem I have an open question." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192855 (owner: 10Jdlrobson) [17:01:47] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Configure Jenkins for iOS builds - https://phabricator.wikimedia.org/T92882#1132410 (10Fjalapeno) a:3Fjalapeno [17:02:48] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Image thumbnail urls should be included where applicable in wikidata API response for commonsMedia - https://phabricator.wikimedia.org/T76827#1132412 (10Jdlrobson) Ping @MaxSem @Brion would this really fry the cluster? Could thumb.php not si... [17:04:01] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Create a fastlane configuration file for iOS builds - https://phabricator.wikimedia.org/T92884#1132414 (10Fjalapeno) [17:04:29] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Create a fastlane configuration file for iOS builds - https://phabricator.wikimedia.org/T92884#1122670 (10Fjalapeno) [17:05:04] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Image thumbnail urls should be included where applicable in wikidata API response for commonsMedia - https://phabricator.wikimedia.org/T76827#1132428 (10brion) Hmm, well if thumb.php redirected you'd have an extra round-trip plus the overhea... [17:05:21] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Article Deletion handling - https://phabricator.wikimedia.org/T90992#1132429 (10JKatzWMF) @rmoen, @jdlrobson. Another great catch! I don't think we want to keep the link. Page was probably deleted for a reason. [17:05:28] (03CR) 10Bmansurov: "@Jhernandez, that's not generalization then. Now you have two different ways of doing it: one with data attributes, the other is just by u" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197454 (owner: 10Jdlrobson) [17:05:50] (03CR) 10BearND: [C: 04-1] "Can I haz more? (At least the version string in the about activity.)" (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197912 (owner: 10Dbrant) [17:06:47] jdlrobson2: hey, can we chat in 5 minutes? Need coffee [17:10:12] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Image thumbnail urls should be included where applicable in wikidata API response for commonsMedia - https://phabricator.wikimedia.org/T76827#1132442 (10brion) (If the redirect gets cached that'd still have the roundtrip, though the first re... [17:10:44] (03CR) 10Phuedx: Generalise main menu logging (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197454 (owner: 10Jdlrobson) [17:13:20] (03CR) 10Jdlrobson: [C: 032] Prevent watchlist from becoming public [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197824 (https://phabricator.wikimedia.org/T93161) (owner: 10Yurik) [17:13:34] joakino_: is project wide list of collections clear? [17:13:45] 3Gather Sprint Diplodocus: Can't access public collections on beta labs - https://phabricator.wikimedia.org/T93222#1132458 (10Jhernandez) 3NEW [17:14:08] jdlrobson2: i think so [17:14:14] jdlrobson2: new special page? [17:14:23] or same page with different url [17:14:30] (03Merged) 10jenkins-bot: Prevent watchlist from becoming public [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197824 (https://phabricator.wikimedia.org/T93161) (owner: 10Yurik) [17:14:40] joakino_: new special page probably easier [17:14:44] k [17:14:46] unless you want to repurpose Special:Gather [17:14:52] i'll grab that then [17:15:09] joakino_: actually we don't want to repurpose Special:Gather it will complicate the sign up workflow [17:15:14] since we wont know the username beforehand [17:15:20] yep [17:15:48] Unless we want to change the url structure [17:16:39] (03PS1) 10Dbrant: [WIP] Remove parenthetical information from lead sentences. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197945 [17:16:56] joakino_: i can replicate the public collection bug [17:17:06] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1132471 (10Jhernandez) a:3Jhernandez [17:17:41] jdlrobson2: back [17:17:58] (03PS1) 10Jdlrobson: Add content class to error pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197948 [17:17:59] rmoen: okay how do you want to do this [17:18:00] (03CR) 10Bmansurov: "I'll add a comment about schemas in the commit message. My reasoning was that there is no need to register a schema if we are not showing " (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [17:18:15] rmoen: want to hangout quickly for 15 mins [17:18:22] jdlrobson2: yeah quick hangout [17:18:34] jdlrobson2: gr yep can replicate locally, seems like i didn't notice that i was logged in [17:18:49] jdlrobson2: i'll make [17:19:10] 3Gather Sprint Diplodocus: Can't access public collections on beta labs - https://phabricator.wikimedia.org/T93222#1132479 (10Jhernandez) Replicated locally by me and @jdlrobson. Gonna investigate [17:19:17] 3Gather Sprint Diplodocus: Can't access public collections on beta labs - https://phabricator.wikimedia.org/T93222#1132480 (10Jhernandez) a:3Jhernandez [17:20:02] (03PS2) 10Bmansurov: Don't load WikiGrok on disambiguation pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) [17:21:07] (03CR) 10jenkins-bot: [V: 04-1] Don't load WikiGrok on disambiguation pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [17:23:06] (03CR) 10Bmansurov: MediaViewer image description trimmed (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [17:24:35] (03PS2) 10Dbrant: Make text in certain TextViews selectable (for copying) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197912 [17:26:04] (03CR) 10Bmansurov: "Any idea why Jenkins is failing?" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [17:28:05] jdlrobson2: try catch was swallowing errors [17:28:08] grf [17:30:26] mhurd: are you all in on the official switch to Phab? [17:30:31] bgerstle: hangout? [17:30:36] sure [17:33:16] (03CR) 10Deskana: [C: 04-1] "Looks good! I found some issues which I've listed below. I'm fine with either tackling them as part of this patch or in a subsequent patch" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197945 (owner: 10Dbrant) [17:34:37] (03CR) 10Jdlrobson: "This patch probably shouldn't have been merged. setInterval it's masking other issues that we are now discovering in Gather" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194574 (https://phabricator.wikimedia.org/T91047) (owner: 10Bmansurov) [17:34:59] (03CR) 10Phuedx: [C: 031] "LGTM. Need to test locally though." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [17:35:09] (03PS1) 10Jhernandez: Fix api usage (was causing fetching a collection to fail) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197955 (https://phabricator.wikimedia.org/T93222) [17:35:40] (03CR) 10Dbrant: "@Deskana, It would be quite difficult (if not impossible) to perfectly synchronize the transition of the WebView contents with the transit" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 (owner: 10Dbrant) [17:36:30] (03CR) 10Bmansurov: Correct the arrow position of the editor tutorial (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194574 (https://phabricator.wikimedia.org/T91047) (owner: 10Bmansurov) [17:37:01] rmoen: reverting that patch stops the $$$ redraws [17:37:13] really that should be wrapped in a $.ready [17:37:21] or it should make sure the edit button has fully loaded beforehand [17:37:29] there are three jdlrobsons? [17:37:40] phuedx: just three :) [17:37:54] more code review bandwidth \o/ [17:38:17] jdlrobson3: can you ping me the patch ? [17:39:07] 6Mobile-Web: PageActionOverlay unnecessarily causing re-rendering of page every second - https://phabricator.wikimedia.org/T93223#1132512 (10Jdlrobson) 3NEW [17:39:26] 6Mobile-Web: PageActionOverlay unnecessarily causing re-rendering of page every second - https://phabricator.wikimedia.org/T93223#1132521 (10Jdlrobson) Introduced by https://gerrit.wikimedia.org/r/#/c/194574/2 [17:39:30] https://phabricator.wikimedia.org/T93223 < rmoen cc. bmansurov [17:40:15] rmoen: as for positioning i think there's a bug there too [17:40:17] it should be closer [17:40:18] (03CR) 10Deskana: "I'm a little wary to merge because this isn't possible to put behind a feature flag, and we're putting ourselves on the clock to have it r" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 (owner: 10Dbrant) [17:40:20] not have this gap [17:41:31] 3Gather Sprint Diplodocus: Anonymous user sees Edit & Delete buttons on a public collection - https://phabricator.wikimedia.org/T93224#1132536 (10Jhernandez) 3NEW a:3Jhernandez [17:43:34] (03PS1) 10Jhernandez: Fix user passed to views\Collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197959 (https://phabricator.wikimedia.org/T93224) [17:44:14] 10Gather, 5Patch-For-Review: Responsive design for Special:Gather (important because shares might be desktop) - https://phabricator.wikimedia.org/T91384#1132555 (10JKatzWMF) [17:44:15] mhurd: i didn't even notice it, but thanks for adding the largetstCachedVariant thnig to WMFShareCardViewController.m [17:45:39] (03CR) 10Dbrant: "@Deskana," [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197945 (owner: 10Dbrant) [17:45:52] (03CR) 10MaxSem: "https://upload.wikimedia.org/wikipedia/en/thumb/b/bc/Wiki.png/100px-Wiki.png" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192855 (owner: 10Jdlrobson) [17:46:17] jdlrobson3, rmoen, joakino_, bmansurov, MaxSem: https://beta.talky.io/wikimedia-mobile -- just trying it out [17:46:30] 10Gather, 3Gather Sprint E: Add members to a collection using a search interface - https://phabricator.wikimedia.org/T90991#1132569 (10Jdlrobson) [17:46:37] 3Gather Sprint Diplodocus, 5Patch-For-Review: Anonymous user sees Edit & Delete buttons on a public collection - https://phabricator.wikimedia.org/T93224#1132536 (10Jhernandez) Obviously until T93222 has been merged this will be hard to test 😭 [17:46:53] 3Gather Sprint Diplodocus, 5Patch-For-Review: Can't access public collections on beta labs - https://phabricator.wikimedia.org/T93222#1132458 (10Jhernandez) [17:46:55] 3Gather Sprint Diplodocus, 5Patch-For-Review: Anonymous user sees Edit & Delete buttons on a public collection - https://phabricator.wikimedia.org/T93224#1132574 (10Jhernandez) [17:46:57] 10Gather, 3Gather Sprint E: Add members to a collection using a search interface - https://phabricator.wikimedia.org/T90991#1072316 (10Jdlrobson) @MSyed and @JKatzWMF to review and update the workflow. [17:47:01] 10Gather, 3Gather Sprint E: Add members to a collection using a search interface - https://phabricator.wikimedia.org/T90991#1132577 (10Jdlrobson) [17:47:09] phuedx: can't see anyone [17:47:18] 10Gather, 3Gather Sprint E, 5Patch-For-Review: Responsive design for Special:Gather (important because shares might be desktop) - https://phabricator.wikimedia.org/T91384#1132582 (10JKatzWMF) [17:47:22] bmansurov: webrtc chats [17:47:42] &yet did a bloggy blog about it, wanted to test [17:48:00] k [17:48:02] phuedx: are you there? [17:48:09] i cant see anybody [17:48:30] joakino_: connecting [17:49:02] joakino_: can you see anything? [17:49:14] MaxSem is trolling with music i think [17:49:22] that was joakino_ [17:49:23] phuedx: 2 little x that look like something useful for closing cams [17:49:34] MaxSem: phuedx oops sorry [17:49:44] can you see me? [17:49:44] 10Gather, 3Gather Sprint E: When sharing on web ensure illustration for share is page image of collection - https://phabricator.wikimedia.org/T93226#1132587 (10Jdlrobson) 3NEW [17:49:51] 10Gather, 3Gather Sprint E: When sharing on web ensure illustration for share is page image of collection - https://phabricator.wikimedia.org/T93226#1132595 (10Jdlrobson) [17:49:55] I actually had https://play.spotify.com/album/2NCR7QfWaPMHWSxPk0ayAP open but not playing [17:50:20] joakino_: no longer there [17:50:35] webrtc doesn't seem to destroy my machine like google hangouts do [17:50:48] (03PS7) 10Sumit: MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) [17:51:00] (03CR) 10Bmansurov: [C: 031] Infobox: Add link to commons category overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197110 (https://phabricator.wikimedia.org/T92687) (owner: 10Florianschmidtwelzow) [17:51:03] that's because hangouts are always so busy spying on you! [17:51:20] phuedx: it doesn't destroy mine neither because i couldn't see shit xD [17:51:27] (03PS8) 10Sumit: MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) [17:51:49] (03CR) 10Deskana: "Having the reference still function even when it's not being displayed is just as weird. I think we should just not worry about that for n" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197945 (owner: 10Dbrant) [17:52:09] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 3 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1132599 (10dr0ptp4kt) [17:52:42] joakino_, MaxSem: lololol [17:52:57] 10Gather, 3Gather Sprint Diplodocus: Proper collection sharing format/content - https://phabricator.wikimedia.org/T91696#1132600 (10Jdlrobson) [17:53:05] 10Gather, 3Gather Sprint E: Proper collection sharing format/content - https://phabricator.wikimedia.org/T91696#1093507 (10Jdlrobson) [17:53:30] 10Gather, 3Gather Sprint E: Proper collection sharing format/content - https://phabricator.wikimedia.org/T91696#1093507 (10Jdlrobson) [17:53:33] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 3 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1063059 (10dr0ptp4kt) [17:53:45] 10Gather, 3Gather Sprint E, 5Patch-For-Review: [placeholder] Responsive design for Special:Gather (important because shares might be desktop) - https://phabricator.wikimedia.org/T91384#1132607 (10Jdlrobson) [17:54:06] 10Gather, 3Gather Sprint E: Proper collection sharing format/content - https://phabricator.wikimedia.org/T91696#1093507 (10Jdlrobson) [17:54:07] 10Gather, 3Gather Sprint E: When sharing on web ensure illustration for share is page image of collection - https://phabricator.wikimedia.org/T93226#1132610 (10Jdlrobson) [17:55:29] back in a bit -- bath time [17:56:50] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 3 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1132651 (10dr0ptp4kt) a:3dr0ptp4kt [17:58:27] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: API: disallow making watchlist public - https://phabricator.wikimedia.org/T93161#1132673 (10Jdlrobson) 5Open>3Resolved [17:59:20] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Fatal error relating to API (bad id) - https://phabricator.wikimedia.org/T93135#1132682 (10Jdlrobson) 5Open>3Resolved [18:00:03] (03CR) 10Florianschmidtwelzow: Fix problems with license message (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [18:00:42] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Edit button should not be visible on Watchlist when viewed in collections - https://phabricator.wikimedia.org/T93102#1132688 (10Jdlrobson) @JKatzWMF can you check this is fixed? [18:01:02] 3Gather Sprint Diplodocus, 5Patch-For-Review: Optimize Special:Gather/User/XXX loading - https://phabricator.wikimedia.org/T92862#1132693 (10Jdlrobson) [18:01:03] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Inconsistent result for loading action=query&list=lists&lstids=X when logged in / anon - https://phabricator.wikimedia.org/T92865#1132691 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [18:04:24] 10Gather: Event logging for collection creation (placeholder) - https://phabricator.wikimedia.org/T92780#1132713 (10Jdlrobson) Is this not the same for T92742 ? [18:05:43] (03PS3) 10Florianschmidtwelzow: Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) [18:08:10] 10Gather, 3Gather Sprint Diplodocus: List edit/creation validation - https://phabricator.wikimedia.org/T92779#1132730 (10Jdlrobson) [18:09:53] (03CR) 10Bmansurov: [C: 04-1] Promote TalkOverlay to stable (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [18:10:03] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Deletion overlay broken, prevents editing of collections - https://phabricator.wikimedia.org/T92651#1132758 (10Jdlrobson) 5Open>3Resolved [18:10:20] 10Gather: Track when user clicks on article from collection - https://phabricator.wikimedia.org/T90998#1132761 (10JKatzWMF) [18:11:30] 10Gather: Upon click on hamburger menu item for collections, log event with event_name "Collections". https://meta.wikimedia.org/wiki/Schema:MobileWebMainMenuClickTracking - https://phabricator.wikimedia.org/T90999#1132769 (10Jdlrobson) [18:11:31] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Event logging for hamburger "collections" link - https://phabricator.wikimedia.org/T92855#1132770 (10Jdlrobson) [18:12:31] 10Gather, 3Gather Sprint E: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1132773 (10Jdlrobson) [18:13:38] (03PS2) 10Bgerstle: WIP: speed up html parse. Prune html before HPPLE parse. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197823 (owner: 10Mhurd) [18:17:15] 10Gather: Let people create collection before asking them to sign up. - https://phabricator.wikimedia.org/T93233#1132786 (10JKatzWMF) 3NEW [18:21:45] mhurd coreyfloyd dr0ptp4kt going afk for a bit [18:26:09] (03PS1) 10Robmoen: Revert "Correct the arrow position of the editor tutorial" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197970 [18:27:08] 6Mobile-Web: PageActionOverlay unnecessarily causing re-rendering of page every second - https://phabricator.wikimedia.org/T93223#1132823 (10rmoen) Patch to revert https://gerrit.wikimedia.org/r/#/c/197970/ [18:29:26] (03CR) 10Bmansurov: [C: 04-1] "Reverting re-introduces the original bug [1]. I think you should fix the original bug with your commit." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197970 (owner: 10Robmoen) [18:30:17] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Saved pages can show Wikidata descriptions. - https://phabricator.wikimedia.org/T93170#1132827 (10Mhurd) [18:35:35] 10MobileFrontend-Feature-requests, 10Wikidata, 7Easy: Setup WikidataPageBanner extension repository on Gerrit - https://phabricator.wikimedia.org/T93127#1132873 (10NiharikaKohli) [18:38:57] 10Gather, 3Gather Sprint Diplodocus: Placeholder: Notify user of list being public before they create it! - https://phabricator.wikimedia.org/T93239#1132885 (10JKatzWMF) 3NEW a:3JKatzWMF [18:41:30] (03CR) 10MaxSem: Claim aggregation (038 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 (owner: 10MaxSem) [18:42:57] (03CR) 10Bmansurov: [C: 04-1] MediaViewer image description trimmed (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [18:47:13] (03PS1) 10Robmoen: M.deferredArray, a place for all async loading things to live [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197979 [18:47:49] ^ Hoping this idea doesn't get squashed like a bug [18:48:12] 6Mobile-Web: Image description is not inserted into the right div - https://phabricator.wikimedia.org/T93241#1132927 (10bmansurov) 3NEW [18:48:20] (03CR) 10jenkins-bot: [V: 04-1] M.deferredArray, a place for all async loading things to live [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197979 (owner: 10Robmoen) [18:48:55] (03CR) 10Bmansurov: "Also, you may want to remove 'truncated-text' class from the 'p' in ImageOverlay.hogan." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [18:52:58] (03CR) 10Bmansurov: "Also, I think we'll need a link to the bug the commit message is talking about." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197455 (owner: 10Jdlrobson) [18:53:21] kaity maryana jonkatz kaldari: anything on the docket for mobile web design review today? Next sprint plan is to run new wikigrok campaigns in stable + spikes and prototype-y stuff coming out of Q4 planning. Anythign related to that we shoudl get a jump on? [18:54:13] MaxSem: any noises from springle? [18:56:26] nope [18:56:34] will poke directly today [18:56:35] kristenlans: we wanted to talk about the new search stuff a bit [18:56:48] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Edit button should not be visible on Watchlist when viewed in collections - https://phabricator.wikimedia.org/T93102#1132969 (10JKatzWMF) I am still having this issue. My watchlist links to Diablanco/26 (and I can edit it) [18:56:56] there are some issues with the alpha UX that we prolly just need to collaboratively resolve [18:58:13] kristenlans nothing on my docket [18:58:58] backsies [19:00:30] 10Gather, 3Gather Sprint Diplodocus: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1132988 (10Jhernandez) @yurik @jdlrobson : When querying **action=query&list=lists&lstmode=allpublic&lstprop=label|description|public** I need the owner to be able to link to the actual list :S HAL... [19:01:43] 10Wikipedia-App-iOS-App: On word selection, show 'Wiktionary' and on tap show quick definition - https://phabricator.wikimedia.org/T93247#1132998 (10dr0ptp4kt) 3NEW [19:03:45] (03PS8) 10Robmoen: WIP: Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 [19:04:02] (03CR) 10jenkins-bot: [V: 04-1] WIP: Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [19:04:40] 10Wikipedia-App-iOS-App: Make Xcode setup pain free for external contributors - https://phabricator.wikimedia.org/T93249#1133022 (10dr0ptp4kt) 3NEW [19:07:41] (03CR) 10Phuedx: Claim aggregation (033 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 (owner: 10MaxSem) [19:07:58] and people say it's hard to have a conversation on gerrit! [19:08:02] hey!? hey!? [19:08:40] MaxSem: have you poked springle? [19:12:11] (03CR) 10Phuedx: "17:21:00 1) ResourcesTest::testMissingDependencies" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [19:12:24] (03CR) 10Phuedx: Don't load WikiGrok on disambiguation pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [19:13:08] (03PS2) 10Robmoen: A place for tracking asynchronously loading things [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197979 [19:13:25] bmansurov: you should check the full console log to see all phpunit errors [19:13:46] the link that's placed into a the gerrit comment is to the tail of the log [19:13:54] right at the tip top there's a link to the full log [19:14:19] usually there's so much spam about skipped test that the errors (which are at the top of the phpunit output) aren't shown :/ [19:14:50] where are the gatherers... [19:14:53] grrf [19:16:35] phuedx: ok thanks [19:18:57] (03PS1) 10Jhernandez: WIP: Gather moderation page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197990 (https://phabricator.wikimedia.org/T92782) [19:19:52] (03PS3) 10Bmansurov: Don't load WikiGrok on disambiguation pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) [19:20:05] (03CR) 10Jhernandez: [C: 04-1] "See current status: http://i.imgur.com/8p53YUE.png" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197990 (https://phabricator.wikimedia.org/T92782) (owner: 10Jhernandez) [19:22:05] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1133079 (10Jhernandez) See attached patch. Current status ➡️ http://i.imgur.com/8p53YUE.png Really need the owner to be able to link to the collection and direct the person to... [19:26:34] leavinggg [19:26:45] byee joakino_ [19:26:46] jdlrobson3: there was nobody around, sent you an email with an update [19:26:49] sorry just gotta out meetings [19:26:53] no problemo [19:26:56] we'll pick up where you left off! [19:26:58] have a nice day! [19:28:05] ping phuedx care to take a look at https://phabricator.wikimedia.org/T92855 ? [19:29:33] (03CR) 10Phuedx: "If you run md5.js through the Google Closure compiler then its size drops from 3.71KB gzipped to 1.42KB gzipped (61.79%!)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192855 (owner: 10Jdlrobson) [19:29:47] jdlrobson3: shall take a look [19:29:56] it's 7:30 pm though, don't expect miracles ;) [19:30:06] (03CR) 10Jdlrobson: [C: 032] Fix api usage (was causing fetching a collection to fail) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197955 (https://phabricator.wikimedia.org/T93222) (owner: 10Jhernandez) [19:30:10] thanks phuedx i can't find kaldari [19:30:12] otherwise i'd bug him [19:30:32] jdlrobson3: i've put some comments on that patch already [19:30:37] as has bmansurov :) [19:30:52] 3Gather Sprint Diplodocus: Add browser test for anon user viewing a collection - https://phabricator.wikimedia.org/T93254#1133093 (10Jdlrobson) 3NEW a:3Jhernandez [19:31:04] the dependant patch is already c+2 [19:32:05] bmansurov: what method would you suggest for https://gerrit.wikimedia.org/r/#/c/197454/ that allows the flexibility of this model for other extensions to register new items? [19:32:15] i really need to get this card moving [19:32:46] i'm not sure how Gather would extend the MainMenu class [19:33:52] jdlrobson3: why not just call mainMenuSchema.hijackLink from Gather directly [19:34:12] jdlrobson3: i'm quite fond of the thing i put inline – i'm also a-ok with data attributes [19:34:46] (03CR) 10MaxSem: Claim aggregation (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 (owner: 10MaxSem) [19:35:23] phuedx: the problem with using $( 'body' ) is it doesn't live update when things change [19:35:53] jdlrobson3: clicks bubble all the way up to the top unless prevented [19:35:59] in terms of #mw-mf-page-left [data-event-name] vs if statement i'm agnostic [19:36:34] phuedx: you'd need data-event-schema too [19:36:47] and schemas take different data [19:37:21] bmansurov: as for calling it directly... I don't want Gather to know anything about MobileFrontend [19:37:26] jdlrobson3: then leave it tied to $( 'nav' ) [19:37:27] I want to break the dependency tree there asap [19:37:31] (for now) [19:37:48] or #mw-mf-page-left or whatever [19:37:51] phuedx: but then you are using MainMenu model [19:37:51] jdlrobson3: don't use use any MobileFrontend methods at all? Like module require? [19:38:03] bmansurov: we do right now, but I want to kill that asap [19:38:07] I think using modules from other extensions is OK [19:38:10] extensions should only really depend on core [19:38:25] this was one of my big concerns with writing Gather outside MobileFrontend [19:38:32] ^^ disagree [19:38:37] Mantle was a complete clusterf**k [19:38:57] phuedx: well let me put it this way - Gather needs to work on desktop [19:39:39] ok… [19:39:45] so any knowledge of MobileFrontend in the code is bad :-) [19:40:06] jdlrobson3: I think the best way forward is to move mobilefront end components to core and start releasing versions of MF. Your code already depends on MF right now [19:40:12] yes we use M.require but i'm hoping this can lead to us moving stuff into core in OOJS friendly ways - i'm not too concerned about fixing that at some point [19:40:31] since there is a big ux standardisation effort [19:40:58] jdlrobson3: the thing is you change still depends on the mobile front end schema [19:41:06] it doesn't depend [19:41:13] it just slots in if it's there [19:41:21] it will work fine without it [19:41:25] yeah, but does logging work on desktop? [19:41:31] of course it does [19:41:41] EventLogging is not mobile only [19:42:01] jdlrobson3: i mean do have code in desktop where you're logging gather link clicks? [19:42:10] no and i don't care about that [19:42:23] all i care about is it not breaking in desktop :) [19:42:26] jdlrobson3: heh, you care about not depending on MF but you don't actually use desktop [19:42:34] overthink imo [19:42:38] i dont understand what you are saying... [19:42:49] jdlrobson3: i'd say that any knowledge of mf in your /core/ code is bad -- presentation code, however, would be fine imo [19:43:04] jdlrobson3: you say you don't want to depend on MF because you want Gather to work on desktop, but you don't have code that works on desktop [19:43:28] the other way to do this is for MobileFrontend to do what it does with everything else in the menu [19:43:33] if Gather exists add this item [19:43:41] and then add the data attribute itself [19:43:58] e.g. MobileFrontend defines its main menu [19:44:02] based on what it knows to exist [19:44:10] would that be better? [19:44:37] and we kill MinervaDiscoveryTools [19:44:51] and re-evaluate menu customisation at a later point [19:45:02] we already have class_exists( 'GeoData' ) for Nearby [19:45:10] yes, that might be a better solution [19:45:11] so flip the dependency to keep gather simple? [19:45:14] phuedx: ? [19:45:59] if that came across negatively, i didn't mean in that way [19:46:06] yeh so we delegate all decisions about main menu generation to SkinMinerva [19:46:31] in future we could even explore a configuration variable for the main menu [19:46:39] as you say, we do it for geodata [19:46:50] let me write an alternative patch then.. 1 s [19:47:47] bmansurov, jdlrobson: we'll keep minervadiscoverytools around for wikigrok, right? [19:48:20] phuedx: yes we need it [19:48:43] I think jon meant the other hook that they created [19:48:48] oh right [19:48:50] ta [19:48:55] cool [19:48:57] wellp [19:48:58] MobilePersonalTools [19:49:09] i'm orf for the night [19:49:12] i will see y'all tomo [19:49:16] night [19:49:22] bmansurov: i'll be testing page images stuff [19:49:26] \o/ [19:49:30] hi5 [19:49:40] phuedx: for the time being but i'd be keen for you guys to kill that hook and do the same [19:50:12] jdlrobson: task plz [19:50:15] g'night [19:50:19] <3 [19:50:29] phuedx: of course ;-) [19:55:54] 10Wikipedia-App-iOS-App, 7Documentation: Make Xcode setup pain free for external contributors - https://phabricator.wikimedia.org/T93249#1133138 (10Dereckson) [19:56:11] (03PS1) 10Jdlrobson: Delegate main menu generation to MobileFrontend + generalise EL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 [19:58:32] 10Gather, 3Gather Sprint Diplodocus, 6Mobile-Web, 10WikiGrok: SkinMinerva should makes it own decisions about rendering the main menu - https://phabricator.wikimedia.org/T93257#1133140 (10Jdlrobson) 3NEW [19:58:49] (03PS2) 10Jdlrobson: Delegate main menu generation to MobileFrontend + generalise EL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) [19:59:31] (03CR) 10Jdlrobson: "Alternative patch at https://gerrit.wikimedia.org/r/#/c/197998/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197454 (owner: 10Jdlrobson) [20:00:23] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Event logging for hamburger "collections" link - https://phabricator.wikimedia.org/T92855#1133156 (10Jdlrobson) We're bikeshedding over the approach. See also T93257 [20:00:34] 10Gather, 3Gather Sprint Diplodocus, 6Mobile-Web, 10WikiGrok, 5Patch-For-Review: SkinMinerva should makes it own decisions about rendering the main menu - https://phabricator.wikimedia.org/T93257#1133158 (10Jdlrobson) a:3Jdlrobson [20:00:53] (03CR) 10Jdlrobson: [C: 031] Fix api usage (was causing fetching a collection to fail) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197955 (https://phabricator.wikimedia.org/T93222) (owner: 10Jhernandez) [20:01:00] (03CR) 10Jdlrobson: [C: 032] Fix api usage (was causing fetching a collection to fail) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197955 (https://phabricator.wikimedia.org/T93222) (owner: 10Jhernandez) [20:01:04] kristenlans: oh crap, i forgot kaldari is out today :( [20:01:15] design review needs him [20:01:31] can we move that meeting (and add jon k to it)? [20:01:56] (03CR) 10Jdlrobson: [C: 032] Fix user passed to views\Collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197959 (https://phabricator.wikimedia.org/T93224) (owner: 10Jhernandez) [20:02:12] (03Merged) 10jenkins-bot: Fix api usage (was causing fetching a collection to fail) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197955 (https://phabricator.wikimedia.org/T93222) (owner: 10Jhernandez) [20:02:25] 3Gather Sprint Diplodocus, 5Patch-For-Review: Anonymous user sees Edit & Delete buttons on a public collection - https://phabricator.wikimedia.org/T93224#1133166 (10Jdlrobson) [20:02:26] 3Gather Sprint Diplodocus, 5Patch-For-Review: Can't access public collections on beta labs - https://phabricator.wikimedia.org/T93222#1133165 (10Jdlrobson) 5Open>3Resolved [20:04:02] 6Mobile-Web: Image description is not inserted into the correct paragraph - https://phabricator.wikimedia.org/T93241#1133169 (10bmansurov) [20:04:55] Maryana: jonk and I are in a hangout ;-) [20:07:05] (03Merged) 10jenkins-bot: Fix user passed to views\Collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197959 (https://phabricator.wikimedia.org/T93224) (owner: 10Jhernandez) [20:07:07] maryana: we can move to tomorrow [20:07:52] kristenlans: let's do that [20:08:05] 3Gather Sprint Diplodocus: Add browser test for anon user viewing a collection - https://phabricator.wikimedia.org/T93254#1133180 (10Jdlrobson) a:5Jhernandez>3None [20:09:23] (03CR) 10Florianschmidtwelzow: Promote TalkOverlay to stable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [20:09:31] maryana: do you happen to have kaity and Moiz in your sights? [20:09:40] i just let kaity know [20:09:43] not sure where moiz is [20:09:52] jdlrobson: just a quick note, I don't think a horizontal TOC on mobile would be good, therefore I've left out that part as is for now [20:11:06] 6Mobile-Web, 5Patch-For-Review: EditorTutorial false arrow position - https://phabricator.wikimedia.org/T91047#1133183 (10Jdlrobson) 5Resolved>3Open This is not fixed at all. {F100797} {F100799} {F100801} {F100804} [20:13:52] (03CR) 10Jdlrobson: [C: 032] Hygiene: Use same saving indication in TalkSectionAdd like in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193522 (https://phabricator.wikimedia.org/T91139) (owner: 10Florianschmidtwelzow) [20:14:50] 6Mobile-Web, 5Patch-For-Review: Glitchy talk overlay behaviour - https://phabricator.wikimedia.org/T91139#1133186 (10Florian) 5Open>3Resolved [20:14:56] 6Mobile-Web: Glitchy talk overlay behaviour - https://phabricator.wikimedia.org/T91139#1074936 (10Florian) [20:15:21] 6Mobile-Web: md5 library should be removed from MobileFrontend - https://phabricator.wikimedia.org/T93258#1133189 (10Jdlrobson) 3NEW [20:15:26] (03Merged) 10jenkins-bot: Hygiene: Use same saving indication in TalkSectionAdd like in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193522 (https://phabricator.wikimedia.org/T91139) (owner: 10Florianschmidtwelzow) [20:15:30] (03PS2) 10Jdlrobson: Remove the md5 library [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192855 (https://phabricator.wikimedia.org/T93258) [20:15:42] (03Abandoned) 10Jdlrobson: Remove the md5 library [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/192855 (https://phabricator.wikimedia.org/T93258) (owner: 10Jdlrobson) [20:16:10] (03CR) 10Bmansurov: [C: 04-1] Fix problems with license message (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [20:18:03] bmansurov: i'm going to +2 https://gerrit.wikimedia.org/r/197970 - i tested the patch and the rendering in stable is much better with the reversion [20:18:13] and stable is the most important [20:18:36] alpha and beta are very broken in current master - https://phabricator.wikimedia.org/T91047#1133183 [20:18:37] jdlrobson: ok, please don't forget to reopen the bug [20:18:42] bmansurov: already have :) [20:19:15] (03CR) 10Jdlrobson: [C: 032] "The rendering in stable is better with this reverted so I'm going to +2 (I've told Baha this :-)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197970 (owner: 10Robmoen) [20:20:17] 6Mobile-Web, 5Patch-For-Review: EditorTutorial false arrow position - https://phabricator.wikimedia.org/T91047#1133209 (10Jdlrobson) I've reverted the patch. Stable is okay now, but beta and alpha have positioning problems @rmoen should hopefully be able to fix this. [20:20:39] 3Gather Sprint Diplodocus, 6Mobile-Web, 5Patch-For-Review: EditorTutorial false arrow position - https://phabricator.wikimedia.org/T91047#1133212 (10Jdlrobson) [20:20:52] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198075 (owner: 10L10n-bot) [20:21:35] 10MobileFrontend-Feature-requests, 7Accessibility, 7Browser-Support-Apple-Safari, 7Design: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#1133215 (10Jdlrobson) [20:21:57] 10Gather, 3Gather Sprint Diplodocus: Special pages hit the API one two many times. - https://phabricator.wikimedia.org/T93155#1133217 (10Jdlrobson) a:3Jdlrobson [20:24:16] (03CR) 10Bmansurov: "Does that mean every deferred that makes a DOM change should register itself in the array? Why not instead emit an event after the Banner " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197979 (owner: 10Robmoen) [20:24:27] (03Merged) 10jenkins-bot: Revert "Correct the arrow position of the editor tutorial" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197970 (owner: 10Robmoen) [20:26:24] (03PS11) 10Dbrant: Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 [20:29:43] (03CR) 10Bmansurov: Delegate main menu generation to MobileFrontend + generalise EL (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) (owner: 10Jdlrobson) [20:30:56] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198048 (owner: 10L10n-bot) [20:32:50] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/198039 (owner: 10L10n-bot) [20:34:45] (03PS1) 10Jdlrobson: Only hit API once on special pages. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198079 [20:34:59] (03PS2) 10Jdlrobson: Only hit API once on special pages. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198079 (https://phabricator.wikimedia.org/T93155) [20:37:05] mhurd you there? [20:38:25] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198028 (owner: 10L10n-bot) [20:38:43] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Saved pages UI corrupt when displayed during refresh. - https://phabricator.wikimedia.org/T90746#1133256 (10Etonkovidova) Checked on iPad mini with 4.0.7.6 - iOS 8.2 [20:39:51] (03CR) 10Jdlrobson: "I'm not sure we want this.. This was what events were supposed to be for." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197979 (owner: 10Robmoen) [20:41:59] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Edit button should not be visible on Watchlist when viewed in collections - https://phabricator.wikimedia.org/T93102#1133258 (10JKatzWMF) @jdlrobson FYI^^ [20:42:08] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Wikidata description running off screen, images look 200% wide - https://phabricator.wikimedia.org/T91588#1133260 (10Etonkovidova) Checked on iPad mini with 4.0.7.6 - iOS 8.2 [20:43:01] (03Abandoned) 10Bmansurov: Do not hide coordinates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195495 (https://phabricator.wikimedia.org/T91481) (owner: 10Bmansurov) [20:44:17] kristenlans: ya! [20:45:09] mhurd: are you in to transition to Phab? [20:45:21] kristenlans: ? [20:45:30] (from trello, makignit official) [20:45:45] 10MobileFrontend-Feature-requests, 7Mobile: MobileFrontend doesn't do URL updating for redirects - https://phabricator.wikimedia.org/T93262#1133265 (10MZMcBride) 3NEW [20:45:47] kristenlans: didn’t we already do this? [20:46:51] kristenlans: regardless, yes, just not for the design board [20:46:51] mhurd hehehe we are *technically* still in the trial phase of Phab, so I'm just confrimign that people are cool with it before takign the final steps of updating documentation, migrating our trello cards to phab etc. [20:47:13] kristenlans: gotcha [20:47:35] Yay! WE did it! [20:50:09] (03PS1) 10Dbrant: Apply a Ken Burns effect to the lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198082 [20:50:34] (03PS2) 10Jdlrobson: Design tweaks for watchstar overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197892 (https://phabricator.wikimedia.org/T92037) (owner: 10Jhernandez) [20:51:04] jdlrobson: back from lunch [20:51:14] 3Gather Sprint Diplodocus, 5Patch-For-Review: Anonymous user sees Edit & Delete buttons on a public collection - https://phabricator.wikimedia.org/T93224#1133283 (10Jdlrobson) 5Open>3Resolved [20:51:42] 10Gather, 3Gather Sprint Diplodocus: Include owner of lists when using lstmode api parameter - https://phabricator.wikimedia.org/T93148#1133287 (10Jdlrobson) a:3Yurik [20:51:50] 10MobileFrontend-Feature-requests, 7Mobile: MobileFrontend doesn't do URL updating for redirects - https://phabricator.wikimedia.org/T93262#1133290 (10MZMcBride) @Aklapper: Is there a tracking task for differences between mobile and desktop? I think there is, but I searched for a while and can't find it. :-(... [20:52:04] 10Gather, 3Gather Sprint Diplodocus: Collections need a last modified and created field - https://phabricator.wikimedia.org/T92690#1133292 (10Jdlrobson) a:3Yurik Yurik said on gchat he's working on this. [20:52:56] 10Gather, 3Gather Sprint Diplodocus: Add gather-admin security right and allow those users to hide public lists. - https://phabricator.wikimedia.org/T93263#1133294 (10Jdlrobson) 3NEW [20:53:18] 10Gather, 3Gather Sprint Diplodocus: Add gather-admin security right and allow those users to hide public lists. - https://phabricator.wikimedia.org/T93263#1133294 (10Jdlrobson) a:3Yurik @Yurik tells me he's working on this on gchat. [20:54:46] 10Gather, 3Gather Sprint Diplodocus: Only call API dynamically except for special:gather - https://phabricator.wikimedia.org/T92711#1133303 (10Jdlrobson) I'm not sure. I'm trying to understand this from @yurik better but am not getting a clearer picture. Obviously if we switch to using a JavaScript ajax reques... [20:54:53] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: watchlist overlay: design tweaks - https://phabricator.wikimedia.org/T92037#1133304 (10JKatzWMF) @jdlrobson, this is what the white translucent overlay refers to: the space between the edges of the interaction rectangle and the edges of the screen that... [20:54:56] 10Gather, 3Gather Sprint Diplodocus: Only call API dynamically except for special:gather - https://phabricator.wikimedia.org/T92711#1133305 (10Jdlrobson) (especially given currently in beta) [20:58:02] (03PS2) 10Dbrant: Apply a Ken Burns effect to the lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198082 [20:59:21] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: watchlist overlay: design tweaks - https://phabricator.wikimedia.org/T92037#1133311 (10JKatzWMF) @jdlrobson, Here is an example of a rectangular image in the excerpt: {F100861} Ideally it would be square, as here: {F100863} [21:00:46] Deskana: are you available to meet today? [21:00:53] i scheduled a 4:30 [21:01:18] kaity: Yep! I am working from home, so I'll be on the hangout. [21:02:00] Deskana: ok thanks! [21:02:54] https://etherpad.wikimedia.org/p/app_q3_health_check [21:03:03] https://docs.google.com/a/wikimedia.org/spreadsheets/d/1w68UX3VgZm_vKsYUNdB7AygumVoi84jGntc2DzHyE8Q/edit#gid=728329856 [21:08:00] 10Gather: Gather documentation page needs an update - https://phabricator.wikimedia.org/T93264#1133316 (10bmansurov) 3NEW [21:14:21] (03CR) 10Robmoen: "Bmansurov, because ContentOverlays know nothing about BannerImage. Furthermore, they know nothing about things that may be asynchronously " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197979 (owner: 10Robmoen) [21:16:49] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS: Sometimes images don't show in image viewer - https://phabricator.wikimedia.org/T89914#1133348 (10Etonkovidova) Verified on iPad mini with 4.0.7.6 - iOS 8.2 for [[en:Yosemite Valley]] and Barack Obama(Arabic) - Image Gallery displays images one after anot... [21:16:53] (03CR) 10Aaron Schulz: Database schema for gather lists (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [21:34:36] (03PS2) 10Robmoen: WIP: Gather moderation page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197990 (https://phabricator.wikimedia.org/T92782) (owner: 10Jhernandez) [21:38:58] 10Gather, 3Gather Sprint Diplodocus: Get database schema reviewed for production - https://phabricator.wikimedia.org/T93154#1133427 (10Jdlrobson) [21:45:55] 10MobileFrontend-Feature-requests, 10Wikidata: Setup WikidataPageBanner extension repository on Gerrit - https://phabricator.wikimedia.org/T93127#1133454 (10Dereckson) [21:50:13] (03CR) 10Bmansurov: "That's why you should emit an event, for example, 'domChanged' when the banner image is ready. In general anything that updates the DOM sh" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197979 (owner: 10Robmoen) [21:50:17] 10Gather: improve scroll on watchlist overlay - https://phabricator.wikimedia.org/T92642#1133505 (10Jaredzimmerman-WMF) [21:52:59] 10Gather: improve scroll on watchlist overlay - https://phabricator.wikimedia.org/T92642#1133569 (10Jaredzimmerman-WMF) [21:53:11] 10Gather: improve scroll on watchlist overlay - https://phabricator.wikimedia.org/T92642#1117007 (10Jaredzimmerman-WMF) [21:53:45] 6Mobile-Web: Special:MobileOptions throwing JS error from mobile.watchstar in stable - https://phabricator.wikimedia.org/T92657#1133574 (10bmansurov) I have a feeling that this bug is gone because load.php version in beta is 8 days old as you can see in the URL. [21:56:17] (03PS3) 10Jdlrobson: POC/WIP: Add Special:GatherEditFeed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196732 [21:57:17] (03CR) 10jenkins-bot: [V: 04-1] POC/WIP: Add Special:GatherEditFeed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196732 (owner: 10Jdlrobson) [21:57:32] 3Gather Sprint Diplodocus, 6Mobile-Web, 5Patch-For-Review: EditorTutorial false arrow position - https://phabricator.wikimedia.org/T91047#1133610 (10Jdlrobson) So @rmoen and I chatted about this. The issue is BannerImage causes the window to resize as the image pushes the rest of the content down. Both Banne... [22:00:28] (03PS1) 10Robmoen: Return owner of collection in lstmode=allpublic [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198111 [22:01:36] (03CR) 10jenkins-bot: [V: 04-1] Return owner of collection in lstmode=allpublic [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198111 (owner: 10Robmoen) [22:02:16] (03PS3) 10Robmoen: Gather moderation page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197990 (https://phabricator.wikimedia.org/T92782) (owner: 10Jhernandez) [22:03:24] (03CR) 10jenkins-bot: [V: 04-1] Gather moderation page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197990 (https://phabricator.wikimedia.org/T92782) (owner: 10Jhernandez) [22:03:49] jdlrobson: I made a patch which adds the owner to the api results, and then rebase joaquins patch off that. aside from jenkins complaint, it works :) [22:04:02] sweet :D [22:04:28] rmoen: i think i found a workaround to the banner issu [22:04:45] jdlrobson: happy to hear [22:05:52] (03PS2) 10Robmoen: Return owner of collection in lstmode=allpublic [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198111 [22:06:54] rmoen: im just gonna delay the rendering [22:07:25] (03PS4) 10Robmoen: Gather moderation page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197990 (https://phabricator.wikimedia.org/T92782) (owner: 10Jhernandez) [22:07:42] still not sure what long term fix it [22:10:42] (03PS9) 10Jdlrobson: Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [22:10:47] ^ rmoen thoughts on that? [22:11:16] jdlrobson: looking [22:11:38] (03CR) 10jenkins-bot: [V: 04-1] Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [22:12:24] (03PS10) 10Jdlrobson: Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [22:12:26] (03CR) 10jenkins-bot: [V: 04-1] Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [22:13:42] (03PS11) 10Jdlrobson: Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [22:13:44] (03CR) 10jenkins-bot: [V: 04-1] Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [22:16:31] (03PS12) 10Jdlrobson: Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [22:17:33] (03PS13) 10Jdlrobson: Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [22:18:41] jdlrobson: did that fix it ? because I wasn't seeing the watchstar, trying the new one [22:19:05] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Move Gather to beta mode - https://phabricator.wikimedia.org/T92881#1133659 (10Jdlrobson) Pushing collections to left menu is handled in https://gerrit.wikimedia.org/r/#/c/197998/ [22:19:13] jdlrobson: hmmm still no watchstar.. not sure what is going on ;/ [22:19:22] (03PS3) 10Jdlrobson: Delegate main menu generation to MobileFrontend + generalise EL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) [22:20:59] rmoen: in beta or alpha? [22:21:33] jdlrobson: in general. Just checking out the patch [22:21:44] on master, watchstar is present [22:22:40] (03PS4) 10Jdlrobson: Delegate main menu generation to MobileFrontend + generalise EL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) [22:22:51] mmm i rebased it [22:22:56] let me check if that fixed it [22:23:24] your right it's broken [22:23:29] ;/ [22:25:13] rmoen: fix on way :)D [22:25:47] jdlrobson: ok, so since we've both touched it should we let joaquin merge it ? [22:25:53] ;) [22:25:56] (03PS14) 10Jdlrobson: Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [22:26:03] rmoen: yeh we can +1 it both :) [22:26:11] I'm good with that [22:26:54] (03CR) 10Jdlrobson: [C: 031] "Joaquin: This works fine in beta, in alpha there is a bit of a gap." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [22:27:06] let's clean out the sprint and then come back to the fucker that is https://phabricator.wikimedia.org/T91047 :) [22:29:05] 10Gather, 3Gather Sprint Diplodocus: Watchstar content overlay should make page content transparent - https://phabricator.wikimedia.org/T93287#1133679 (10Jdlrobson) 3NEW a:3Jdlrobson [22:29:18] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: watchlist overlay: design tweaks - https://phabricator.wikimedia.org/T92037#1133686 (10Jdlrobson) [22:31:04] (03PS3) 10Jdlrobson: Return owner of collection in lstmode=allpublic [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198111 (owner: 10Robmoen) [22:31:12] (03CR) 10Jdlrobson: [C: 032] Return owner of collection in lstmode=allpublic [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198111 (owner: 10Robmoen) [22:31:25] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Include owner of lists when using lstmode api parameter - https://phabricator.wikimedia.org/T93148#1133697 (10Jdlrobson) a:5Yurik>3rmoen [22:32:21] (03Merged) 10jenkins-bot: Return owner of collection in lstmode=allpublic [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198111 (owner: 10Robmoen) [22:33:12] (03PS5) 10Jdlrobson: Gather moderation page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197990 (https://phabricator.wikimedia.org/T92782) (owner: 10Jhernandez) [22:36:24] 10Gather, 3Gather Sprint Diplodocus: Tablet heading design issue - https://phabricator.wikimedia.org/T93152#1133720 (10Jdlrobson) [22:41:25] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1133737 (10Jdlrobson) I wouldn't call the page gather moderation. Call it all gather lists or something similar and more generic. @JKatzWMF any ideas? [22:41:39] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1133740 (10rmoen) This is currently listing by id and it works. Can sorting by last updated be a separate task? We are waiting on T92690. [22:43:55] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Edit button should not be visible on Watchlist when viewed in collections - https://phabricator.wikimedia.org/T93102#1133745 (10JKatzWMF) 5Open>3Resolved ah, @jdlrobson showed me how to reset this and it's not coming back. [22:48:55] calling admins? can anyone go into betawmflabs and delete this page? trying to test its impact on collections that include it [22:49:07] http://en.m.wikipedia.beta.wmflabs.org/wiki/Page_that_should_be_removed [22:50:36] JonKatz: Done. [22:50:48] Deskana thanks! [22:55:52] 6Mobile-Web: Overlays not designed to be run from head - https://phabricator.wikimedia.org/T88295#1133815 (10bmansurov) a:3bmansurov [22:56:36] (03PS1) 10Bmansurov: Show Overlays only after the DOM is ready [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198132 (https://phabricator.wikimedia.org/T88295) [22:57:18] 3Gather Sprint Diplodocus: deleted article issues - https://phabricator.wikimedia.org/T93295#1133825 (10JKatzWMF) 3NEW [22:57:38] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Article Deletion handling - https://phabricator.wikimedia.org/T90992#1133833 (10JKatzWMF) @rmoen, @jdlrobson. The deleted page gets pushed to the top of my collections even though the rest of the list is in alphabetical order. Just filed a task agains... [22:58:29] (03PS9) 10MaxSem: Claim aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 [22:59:20] 3Gather Sprint Diplodocus: only 10 collections appear on "gather" page - https://phabricator.wikimedia.org/T93296#1133836 (10JKatzWMF) 3NEW [23:11:04] 6Mobile-Web: Table border parameter does not display right border on mobile - https://phabricator.wikimedia.org/T92913#1133903 (10Tvx1) p:5Lowest>3Normal [23:11:09] (03PS1) 10Bmansurov: Load Mobile event emitter in the head [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198136 (https://phabricator.wikimedia.org/T89310) [23:11:21] 3Gather Sprint Diplodocus: only 10 collections appear on "gather" page - https://phabricator.wikimedia.org/T93296#1133909 (10Jdlrobson) We'll need to add pagination of some sort I suspect. At most we can show 50 because of the page image hard limit. [23:11:31] 6Mobile-Web, 5Patch-For-Review: "Last modified .." flashes on screen, then replaced by "Last modified .." - https://phabricator.wikimedia.org/T89310#1133910 (10bmansurov) a:3bmansurov [23:12:07] 3Gather Sprint Diplodocus: deleted article issues - https://phabricator.wikimedia.org/T93295#1133913 (10Jdlrobson) How should the collection be ordered? By title? Currently it is arbitrary. [23:12:35] (03PS15) 10Robmoen: Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 [23:13:01] 6Mobile-Web, 5Patch-For-Review: "Last modified .." flashes on screen, then replaced by "Last modified .." - https://phabricator.wikimedia.org/T89310#1033151 (10bmansurov) @Florian, you have to keep staring at the screen, the flash is instantaneous. [23:13:14] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1133916 (10Jdlrobson) @rmoen That's fine. Will update and create another card. [23:13:36] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1133917 (10Jdlrobson) [23:13:46] (03CR) 10Robmoen: [C: 031] "Jon and I have both touched this. Latest patch added call to refreshPointerArrow, otherwise arrow was horribly positioned." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [23:13:56] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Project wide list of collections should be sorted by last modified date - https://phabricator.wikimedia.org/T93303#1133918 (10Jdlrobson) 3NEW a:3Jhernandez [23:14:10] (03CR) 10Bmansurov: [C: 04-1] "Please see my comment from the earlier patch." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) (owner: 10Jdlrobson) [23:14:33] 10Gather, 3Gather Sprint Diplodocus: Collections need a last modified and created field - https://phabricator.wikimedia.org/T92690#1133926 (10Jdlrobson) [23:14:34] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Project wide list of collections should be sorted by last modified date - https://phabricator.wikimedia.org/T93303#1133918 (10Jdlrobson) [23:17:35] 10Wikipedia-App-Android-App, 6Release-Engineering, 10Wikimedia-Hackathon-2015: Create end-to-end test for Wikipedia Android app - https://phabricator.wikimedia.org/T90177#1133937 (10Etonkovidova) The question came from iOS App team: Do we have the similar ticket for iOS App? Or iOS App test automation is alr... [23:18:09] JonKatz: around? [23:22:36] (03PS1) 10Jdlrobson: Center the page image thumbnail [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198141 (https://phabricator.wikimedia.org/T92037) [23:24:23] jdlrobson in a meeting..out soon [23:24:26] k [23:24:49] (03PS6) 10Jdlrobson: Gather global collections page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197990 (https://phabricator.wikimedia.org/T92782) (owner: 10Jhernandez) [23:27:23] 6Mobile-Web, 7Easy, 7Mobile: Clear search button is missing on mobile search once you swith to full-text Search - https://phabricator.wikimedia.org/T88631#1133982 (10bmansurov) a:3bmansurov [23:28:15] (03CR) 10Jdlrobson: [C: 04-1] Gather global collections page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197990 (https://phabricator.wikimedia.org/T92782) (owner: 10Jhernandez) [23:29:02] 10Gather, 3Gather Sprint Diplodocus: Tablet heading design issue - https://phabricator.wikimedia.org/T93152#1133995 (10Jdlrobson) a:3Jdlrobson [23:29:36] (03PS1) 10Bmansurov: Don't hide the clear button when the search input is not empty [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198143 (https://phabricator.wikimedia.org/T88631) [23:37:00] (03PS1) 10Jdlrobson: Dont fight heading styles [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198145 (https://phabricator.wikimedia.org/T93152) [23:38:09] 3Gather Sprint Diplodocus: Add browser test for anon user viewing a collection - https://phabricator.wikimedia.org/T93254#1134029 (10Jdlrobson) a:3Jdlrobson [23:41:43] (03PS1) 10Robmoen: Show colletions menu item in beta [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198146 [23:42:15] 6Mobile-Web: On MobileFrontend, wikipedia:en:Template:sfrac introduces an extra/incorrect slash - https://phabricator.wikimedia.org/T92472#1134041 (10bmansurov) @Thnidu, I don't see what you mean. I've taken two screenshots, they look similar to me: Desktop: {F101029} Mobile: {F101032} Am I looking at the wro... [23:43:26] (03CR) 10Robmoen: [C: 032] Dont fight heading styles [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198145 (https://phabricator.wikimedia.org/T93152) (owner: 10Jdlrobson) [23:44:32] (03Merged) 10jenkins-bot: Dont fight heading styles [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198145 (https://phabricator.wikimedia.org/T93152) (owner: 10Jdlrobson) [23:45:19] 10Gather: infinite scroll for user collections (pagination) - https://phabricator.wikimedia.org/T93309#1134050 (10JKatzWMF) 3NEW [23:45:22] bmansurov, he refers to invocation of these templates, not the syntax itself:) [23:46:06] 3Gather Sprint Diplodocus: only 10 collections appear on "gather" page - https://phabricator.wikimedia.org/T93296#1134058 (10JKatzWMF) Okay lets open up to 50 for now. But I added a pagination alternative to the backlog: T93309 [23:47:07] MaxSem: you mean the line after 'to get'? [23:47:58] I mean that you made screenshots of {{template}} [23:48:44] MaxSem: I see, but the next line also looks similar in both desktop and mobile [23:48:50] (03CR) 10Robmoen: [C: 032] Center the page image thumbnail [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198141 (https://phabricator.wikimedia.org/T92037) (owner: 10Jdlrobson) [23:50:33] (03Abandoned) 10Deskana: DO NOT MERGE - Wikidata description editing prototype [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197733 (owner: 10Deskana) [23:51:22] (03PS2) 10Jdlrobson: Show collections menu item in beta [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198146 (https://phabricator.wikimedia.org/T92881) (owner: 10Robmoen) [23:51:24] (03PS3) 10Robmoen: Design tweaks for watchstar overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197892 (https://phabricator.wikimedia.org/T92037) (owner: 10Jhernandez) [23:51:31] (03CR) 10Springle: Recording user responses (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [23:51:42] (03CR) 10Jdlrobson: [C: 032] "Note: https://gerrit.wikimedia.org/r/#/c/197998/" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198146 (https://phabricator.wikimedia.org/T92881) (owner: 10Robmoen) [23:52:50] (03Merged) 10jenkins-bot: Show collections menu item in beta [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198146 (https://phabricator.wikimedia.org/T92881) (owner: 10Robmoen) [23:53:05] (03CR) 10Robmoen: [C: 032] Design tweaks for watchstar overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197892 (https://phabricator.wikimedia.org/T92037) (owner: 10Jhernandez) [23:53:21] (03PS2) 10Robmoen: Center the page image thumbnail [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198141 (https://phabricator.wikimedia.org/T92037) (owner: 10Jdlrobson) [23:54:23] 10Gather, 3Gather Sprint Diplodocus: Get database schema reviewed for production - https://phabricator.wikimedia.org/T93154#1134092 (10Jdlrobson) Just reached out to Sean to ask if we can get some of his time for this. [23:54:23] (03Merged) 10jenkins-bot: Design tweaks for watchstar overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197892 (https://phabricator.wikimedia.org/T92037) (owner: 10Jhernandez) [23:54:39] (03PS2) 10Robmoen: Add content class to error pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197948 (owner: 10Jdlrobson) [23:54:46] (03CR) 10Robmoen: [C: 032] Add content class to error pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197948 (owner: 10Jdlrobson) [23:55:15] Deskana: [23:55:23] mhurd: [23:55:25] Deskana: hey do you have a minute? [23:55:27] lol [23:55:30] mhurd: Yes! [23:56:16] mhurd: Hangout, or IRC? [23:57:09] (03CR) 10Jdlrobson: Gather global collections page (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197990 (https://phabricator.wikimedia.org/T92782) (owner: 10Jhernandez) [23:57:32] (03Merged) 10jenkins-bot: Add content class to error pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197948 (owner: 10Jdlrobson) [23:57:49] (03PS3) 10Robmoen: Only hit API once on special pages. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198079 (https://phabricator.wikimedia.org/T93155) (owner: 10Jdlrobson) [23:58:35] (03CR) 10MaxSem: Recording user responses (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [23:59:07] (03PS1) 10Jdlrobson: QA: Add browser test for anon user viewing a public collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198156 [23:59:39] 3Gather Sprint Diplodocus: Add browser test for anon user viewing a collection - https://phabricator.wikimedia.org/T93254#1133093 (10Jdlrobson) Easiest way to do this is to piggy back off T92782 [23:59:45] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1120229 (10Jdlrobson) [23:59:46] 3Gather Sprint Diplodocus: Add browser test for anon user viewing a collection - https://phabricator.wikimedia.org/T93254#1134105 (10Jdlrobson)