[00:00:03] 10Gather, 3Gather Sprint Diplodocus: Design tweaks for Vector skin - https://phabricator.wikimedia.org/T92883#1134108 (10Jdlrobson) a:3Jdlrobson [00:00:13] (03CR) 10Robmoen: [C: 032] Only hit API once on special pages. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198079 (https://phabricator.wikimedia.org/T93155) (owner: 10Jdlrobson) [00:00:40] 10Gather, 3Gather Sprint Diplodocus: Design tweaks for Vector skin - https://phabricator.wikimedia.org/T92883#1122656 (10Jdlrobson) a:5Jdlrobson>3None [00:01:22] (03Merged) 10jenkins-bot: Only hit API once on special pages. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198079 (https://phabricator.wikimedia.org/T93155) (owner: 10Jdlrobson) [00:01:50] 3Gather Sprint Diplodocus: only 10 collections appear on "gather" page - https://phabricator.wikimedia.org/T93296#1134120 (10Jdlrobson) Seriously pagination is not this difficult. We should just add it from the get-go! :P [00:02:17] 3Gather Sprint Diplodocus: only 10 collections appear on "gather" page - https://phabricator.wikimedia.org/T93296#1134121 (10Jdlrobson) [00:02:50] 3Gather Sprint Diplodocus: only 10 collections appear on "gather" page - https://phabricator.wikimedia.org/T93296#1133836 (10Jdlrobson) [00:02:57] 10Gather, 3Gather Sprint Diplodocus: only 10 collections appear on "gather" page - https://phabricator.wikimedia.org/T93296#1133836 (10Jdlrobson) [00:03:25] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Project wide list of collections should be sorted by last modified date - https://phabricator.wikimedia.org/T93303#1134127 (10Jdlrobson) a:5Jhernandez>3None [00:04:00] 10Gather, 3Gather Sprint Diplodocus: List edit/creation validation - https://phabricator.wikimedia.org/T92779#1134128 (10Jdlrobson) @yurik do we have any limits on the server side? We can certainly add client side validation for this. [00:04:09] 6Mobile-Web: Location template disregarded in collapsed sections - https://phabricator.wikimedia.org/T88320#1134131 (10bmansurov) In order for the location template to be under the summary heading it should reside in the same div as the previous table (Information template). Right now we (MF) just take the headi... [00:04:44] bgerstle: you around? [00:04:55] 10Gather, 3Gather Sprint Diplodocus: Only call API dynamically except for special:gather - https://phabricator.wikimedia.org/T92711#1134139 (10Jdlrobson) a:3Jdlrobson [00:05:14] 10Gather, 3Gather Sprint Diplodocus: Only call API dynamically except for special:gather - https://phabricator.wikimedia.org/T92711#1118648 (10Jdlrobson) I'll explore this as fixing this will also fix T92573 [00:05:25] 10Gather, 3Gather Sprint Diplodocus: Caching issues? - https://phabricator.wikimedia.org/T92573#1134143 (10Jdlrobson) a:3Jdlrobson [00:08:56] MaxSem: Isn't this already fixed? https://phabricator.wikimedia.org/T91142 [00:09:09] MaxSem: your comment "// Flood protection: no more than 2 responses per minute per user" [00:09:38] nah, the bug about the number of claims per request [00:09:44] 10Gather, 3Gather Sprint Diplodocus: Event logging for Gather onboarding - https://phabricator.wikimedia.org/T92742#1134146 (10rmoen) The schema needs broken up. [00:10:13] MaxSem: ok thanks [00:11:57] bearND: dbrant|bbl what did you enter for 'accomodation' on the form for the hackathon? [00:11:58] (03CR) 10Springle: [C: 031] Recording user responses (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [00:12:11] MaxSem: what should the default be? 4 or no limit or..? [00:12:43] matching the UI? [00:12:52] ok 4 then [00:14:06] (03CR) 10Kaldari: [C: 032] Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [00:14:30] dr0ptp4kt: I think you're supposed to use the same option you did when you filled out Quim's or Rachel's form. My circumstances are a bit more complicated so that probably doesn't help you. [00:15:54] bearND: meaning that if i marked single room on the other form, i should mark single room on this form? [00:17:52] dr0ptp4kt: That's what I remember from Rachel's email. I would check with her. If you want to share a room with someone then they probably don't mind, I guess. [00:17:54] (03Merged) 10jenkins-bot: Recording user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [00:18:39] dr0ptp4kt: I chose to share a room. I'm planning on sharing with James_F. [00:18:53] Unless he's changed his mind! [00:20:55] Deskana: Aww. [00:21:02] Deskana: You're not /that/ bad. :-) [00:24:27] \o/ [00:26:44] (03PS1) 10Bmansurov: Cap the number of claims WikiGrokResponse API should accept [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198163 (https://phabricator.wikimedia.org/T91142) [00:26:45] (03CR) 10jenkins-bot: [V: 04-1] Cap the number of claims WikiGrokResponse API should accept [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198163 (https://phabricator.wikimedia.org/T91142) (owner: 10Bmansurov) [00:26:55] 6Mobile-Web, 10WikiGrok, 5Patch-For-Review: wikigrokresponse API should cap the number of claims accepted - https://phabricator.wikimedia.org/T91142#1134177 (10bmansurov) a:3bmansurov [00:29:37] MaxSem: Might be ./includes/skins/MinervaTemplateAlpha.php: echo $templateParser->processTemplate( 'header', $args ); [00:29:41] (03PS1) 10Jdlrobson: Hygiene: Remove inherited functions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198164 [00:29:43] (03PS1) 10Jdlrobson: Defer loading of collections till watchlist click [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198165 (https://phabricator.wikimedia.org/T92573) [00:31:05] (03PS2) 10Jdlrobson: Defer loading of collections till watchlist click [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198165 (https://phabricator.wikimedia.org/T92573) [00:31:14] (03PS2) 10Bmansurov: Cap the number of claims WikiGrokResponse API should accept [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198163 (https://phabricator.wikimedia.org/T91142) [00:31:41] JonKatz: https://phabricator.wikimedia.org/T93295 [00:31:51] jdlrobson, can do some more fun work now ;) [00:32:00] yurik_: mm? [00:32:07] yurik_: i'm wrapping up for day [00:32:15] getting back to fixing bugs - was busy with other things [00:32:23] jdlrobson, q for you: [00:32:32] i have been updating DB [00:32:33] yurik https://phabricator.wikimedia.org/T92690 and https://phabricator.wikimedia.org/T93263 are the only things we really care about right now [00:32:43] (apart from getting through schema review) [00:32:58] i need to add two fields to the DB before depl [00:33:04] yurik_: modified and created? [00:33:06] no [00:33:09] modified and permission [00:33:17] cool, aaron was asking about permission [00:33:17] created does not need to be sorted by [00:33:20] and why it was in the blob [00:33:25] yurik_: not yet ;-) [00:33:35] exactly, and i don't forsee it just yet [00:33:47] you have proven the need for the perm & modified field [00:33:47] yurik_: it will be... [00:33:50] * yurik_ gives a cookie [00:33:59] ;) [00:34:04] aaaanyway [00:34:07] question - [00:34:11] sure [00:34:16] be quick cos im wrapping up :) [00:34:18] do you want to wipe the DB, or do a proper update procedure [00:34:39] 3Gather Sprint Diplodocus: deleted article issues - https://phabricator.wikimedia.org/T93295#1134209 (10JKatzWMF) If it's not too hard, I think the last one should go to the bottom. Justification: Generally the most important items on the list come to mind first The ones that come to mind later are the ones... [00:34:48] i can simply tell you to dump the existing table and recreate, or can do the longer route of properly updating table [00:35:06] yurik_: wipe away [00:35:08] takes much longer dev time, but is the "right way" when doing in-production schema changes [00:35:17] we are in beta labs [00:35:20] ok, might have to manually update labs [00:35:23] data is not guaranteed [00:35:26] exactly )) [00:35:33] jdlrobson thanks for the heads up [00:35:43] yurik_: just drop a note to joaquin and rob so they don't get confused by missing data [00:35:49] (when it's done) [00:35:56] btw, might be a manual step involved, or maybe i will update it with a update.php [00:36:36] jdlrobson, ok, will look at the patches [00:36:41] also, please use API: prefix [00:36:46] for all the api related tasks [00:36:50] easier to spot [00:36:55] without a group [00:37:35] jdlrobson ^ [00:39:49] 10Gather, 3Gather Sprint Diplodocus: Deleted pages should appear at bottom of the collection - https://phabricator.wikimedia.org/T93295#1134236 (10Jdlrobson) [00:41:22] 10Gather, 3Gather Sprint Diplodocus: Watchstar content overlay should make page content transparent - https://phabricator.wikimedia.org/T93287#1134244 (10JKatzWMF) not a blocker [00:46:12] 10Gather, 3Gather Sprint Diplodocus: Deleted pages should appear at bottom of the collection - https://phabricator.wikimedia.org/T93295#1134250 (10Yurik) I have support in the database for ordering, but it hasn't been exposed via the API yet. To add/move non-watchlist pages to a list, `action=editlist & titles... [00:46:34] 10Gather, 3Gather Sprint Diplodocus, 10Wikimedia-Extension-setup, 3Roadmap, 7user-notice: Enable Extension:Gather (article lists) on English Wikipedia Mobile Beta - https://phabricator.wikimedia.org/T91341#1134252 (10Jdlrobson) @greg "Make sure the extension is automatically branched. [1]" Newbie questio... [00:46:39] 10Gather, 3Gather Sprint Diplodocus, 10Wikimedia-Extension-setup, 3Roadmap, 7user-notice: Enable Extension:Gather (article lists) on English Wikipedia Mobile Beta - https://phabricator.wikimedia.org/T91341#1134253 (10Jdlrobson) a:3Jdlrobson [00:47:45] (03CR) 10Jdlrobson: [C: 032] Center the page image thumbnail [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198141 (https://phabricator.wikimedia.org/T92037) (owner: 10Jdlrobson) [00:55:43] (03Merged) 10jenkins-bot: Center the page image thumbnail [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198141 (https://phabricator.wikimedia.org/T92037) (owner: 10Jdlrobson) [01:02:22] 10Gather, 3Gather Sprint Diplodocus: Deleted pages should appear at bottom of the collection - https://phabricator.wikimedia.org/T93295#1134267 (10Jdlrobson) Sorting can happen in PHP Please dont focus too much on the sorting use case for the POC. I'm already not sure about the existing schema for the ordering... [01:10:16] (03PS3) 10Dbrant: Apply a Ken Burns effect to the lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198082 [01:13:44] 10Gather, 3Gather Sprint Diplodocus: Deleted pages should appear at bottom of the collection - https://phabricator.wikimedia.org/T93295#1134274 (10Yurik) @jdlrobson, you cannot sort unless you load the entire list content - and that could be thousands. Also, you cannot sort in any way other than by title + del... [01:22:26] (03PS2) 10Dbrant: [WIP] Remove parenthetical information from lead sentences. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197945 [01:25:19] 10MobileFrontend-Feature-requests, 5Patch-For-Review: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#1134298 (10Jdlrobson) [01:26:32] (03CR) 10Yurik: Database schema for gather lists (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [02:26:28] (03PS3) 10Mhurd: WIP: speed up html parse. Prune html before HPPLE parse. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197823 [02:28:56] (03CR) 10Mhurd: "Updated the regex. Also, once I modified my hack to handle edge cases, it was slower than the regex. Follow-on amendment will reduce the p" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197823 (owner: 10Mhurd) [02:50:25] (03PS4) 10Mhurd: WIP: speed up html parse. Prune html before HPPLE parse. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197823 [02:53:31] (03CR) 10Mhurd: "Removed the testing flags. Cleaned up WMFInjectArticleWithImagesFromSection logic a bit more." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197823 (owner: 10Mhurd) [02:54:06] (03CR) 10Mhurd: "Oh, removed the hack as well." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197823 (owner: 10Mhurd) [03:00:37] (03CR) 10OliverKeyes: "I'm being informed that nobody sees any particular need to change this, because nobody sees what the problem is. It would perhaps be usefu" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197288 (owner: 10OliverKeyes) [03:08:36] (03CR) 10Springle: Database schema for gather lists (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/195192 (https://phabricator.wikimedia.org/T91308) (owner: 10Yurik) [03:23:00] (03PS5) 10Mhurd: WIP: speed up html parse. Prune html before HPPLE parse. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197823 [03:30:32] (03PS6) 10Mhurd: Speed up html parse. Prune html before HPPLE parse. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197823 [03:34:04] 10MobileFrontend-Feature-requests, 6WMF-Design-Research, 5Patch-For-Review: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#1134414 (10Jaredzimmerman-WMF) [03:37:37] 10MobileFrontend-Feature-requests, 6WMF-Design-Research, 5Patch-For-Review: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#1134417 (10Jaredzimmerman-WMF) Status : Abandoned… Design Research needs this to keep on track in Q4, @KLans_WMF thoughts on when this will get... [03:50:27] 10MobileFrontend-Feature-requests, 6WMF-Design-Research, 5Patch-For-Review: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#1134433 (10Jdlrobson) Jared if you look at the patch and comments baha had issues getting VE working at the time when he tried to do this in hi... [03:51:09] 10MobileFrontend-Feature-requests, 6WMF-Design-Research, 5Patch-For-Review: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#1134437 (10Jdlrobson) (Also we need design guidance from your team on how to display the header :)) [03:55:26] 10MobileFrontend-Feature-requests, 6WMF-Design-Research, 5Patch-For-Review: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#1134455 (10Jaredzimmerman-WMF) copied from dupe… Early talks with Ed & Jon said this would be a simple task, and would greatly improve the abi... [04:08:07] (03PS1) 10Yurik: Added gl_perm & gl_updated columns to gather_list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 [04:08:33] (03CR) 10jenkins-bot: [V: 04-1] Added gl_perm & gl_updated columns to gather_list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (owner: 10Yurik) [04:29:05] 10Gather, 3Gather Sprint Diplodocus: List edit/creation validation - https://phabricator.wikimedia.org/T92779#1134478 (10Yurik) @jdlrobson, i don't check for label/description text length. Easy to add. There is a validation that this list already exists, but current implementation allows you to use this call t... [05:11:44] (03CR) 10Legoktm: [C: 031] Change the heading for privacy and terms to 'privacy and terms' [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197288 (owner: 10OliverKeyes) [05:15:12] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: As a curious apps reader, I'd like a feed of interesting articles so the app can entertain me. - https://phabricator.wikimedia.org/T93327#1134525 (10Deskana) 3NEW [05:17:04] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: As a user if I change my wiki language through More, the search field should be empty or the results refreshed next time I try to search - https://phabricator.wikimedia.org/T92290#1134541 (10Deskana) [05:19:52] 10Wikipedia-App-iOS-App: There is no way to refresh saved pages in the iOS app - https://phabricator.wikimedia.org/T71403#1134549 (10Deskana) 5Open>3Resolved a:3Deskana This will be included in the next app release on 30th March 2015. [05:20:46] 10Wikipedia-App-iOS-App: iOS app: Trying to clear saved pages caused a crash - https://phabricator.wikimedia.org/T73850#1134553 (10Deskana) 5Open>3Resolved a:3Deskana This bug is so old that I'm almost certain it's been fixed. [05:21:21] 10Wikipedia-App-iOS-App, 5Patch-For-Review: iOS App: App sometimes loads cached versions of pages instead of loading new ones - https://phabricator.wikimedia.org/T70230#1134556 (10Deskana) 5Open>3Resolved a:3Deskana [05:22:12] 10Wikipedia-App-iOS-App, 7Easy: "Other" edit summary field should be a multi-line text box - https://phabricator.wikimedia.org/T71275#1134558 (10Deskana) [05:23:27] 10Wikipedia-App-iOS-App: iOS App: Visiting a page you've already visited returns you to that scroll position - https://phabricator.wikimedia.org/T68903#1134561 (10Deskana) 5Open>3Resolved a:3Deskana This was fixed a while back. [05:25:17] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: On word selection, show 'Wiktionary' and on tap show quick definition - https://phabricator.wikimedia.org/T93247#1134574 (10Deskana) [05:25:52] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: The Wikipedia app should handle Wiktionary links better - https://phabricator.wikimedia.org/T86283#1134577 (10Deskana) [05:25:53] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: On word selection, show 'Wiktionary' and on tap show quick definition - https://phabricator.wikimedia.org/T93247#1132998 (10Deskana) [05:27:13] 10Wikipedia-App-iOS-App: Mobile app edit inserting JSON blob - https://phabricator.wikimedia.org/T84997#1134580 (10Deskana) 5Open>3Invalid a:3Deskana I think this is either user error or a problem with the user's OS. Either way, nothing we can fix. [05:36:46] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Saved pages can show Wikidata descriptions. - https://phabricator.wikimedia.org/T93170#1134586 (10Deskana) a:5Mhurd>3None [05:37:00] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Saved pages can show Wikidata descriptions. - https://phabricator.wikimedia.org/T93170#1131101 (10Deskana) a:3Mhurd [05:37:05] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Saved pages can show Wikidata descriptions. - https://phabricator.wikimedia.org/T93170#1131101 (10Deskana) Oops. [06:55:50] 6Mobile-Web, 7Graphite: "No data" on MobileFrontend gdash - https://phabricator.wikimedia.org/T93328#1134627 (10Nemo_bis) 3NEW [06:56:01] (03PS2) 10Yurik: Added gl_perm & gl_updated columns to gather_list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 [06:56:26] (03CR) 10jenkins-bot: [V: 04-1] Added gl_perm & gl_updated columns to gather_list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (owner: 10Yurik) [07:30:32] (03CR) 10Florianschmidtwelzow: "one question :)" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [07:41:02] (03PS1) 10Mhurd: Update to scroll indicator color per Vibha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198196 [07:41:26] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Update color of scroll indicator on IOS - https://phabricator.wikimedia.org/T91705#1134695 (10Mhurd) [07:42:35] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Update color of scroll indicator on IOS - https://phabricator.wikimedia.org/T91705#1093990 (10Mhurd) https://gerrit.wikimedia.org/r/#/c/198196/ [07:43:53] (03PS2) 10Mhurd: Update to scroll indicator color per Vibha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198196 [07:58:34] (03PS3) 10Yurik: Added gl_perm & gl_updated columns to gather_list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (https://phabricator.wikimedia.org/T93303) [07:59:11] (03CR) 10jenkins-bot: [V: 04-1] Added gl_perm & gl_updated columns to gather_list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (https://phabricator.wikimedia.org/T93303) (owner: 10Yurik) [08:12:01] (03PS4) 10Yurik: Added gl_perm & gl_updated columns to gather_list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (https://phabricator.wikimedia.org/T93303) [08:12:23] (03CR) 10jenkins-bot: [V: 04-1] Added gl_perm & gl_updated columns to gather_list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (https://phabricator.wikimedia.org/T93303) (owner: 10Yurik) [08:25:15] (03PS8) 10Florianschmidtwelzow: Promote TalkOverlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) [08:55:12] good morning! [09:15:27] (03PS7) 10Jhernandez: Gather global collections page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197990 (https://phabricator.wikimedia.org/T92782) [09:17:23] (03CR) 10Jhernandez: [C: 032] "Renamed the page to GatherLists as suggested in the task and i18n'd it." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197990 (https://phabricator.wikimedia.org/T92782) (owner: 10Jhernandez) [09:17:39] (03CR) 10Jhernandez: Gather global collections page (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197990 (https://phabricator.wikimedia.org/T92782) (owner: 10Jhernandez) [09:17:55] (03PS2) 10Jhernandez: QA: Add browser test for anon user viewing a public collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198156 (owner: 10Jdlrobson) [09:18:26] (03Merged) 10jenkins-bot: Gather global collections page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197990 (https://phabricator.wikimedia.org/T92782) (owner: 10Jhernandez) [09:24:18] (03PS1) 10Jhernandez: Remove traces of moderation name on files [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198205 [09:24:48] (03CR) 10Jhernandez: [C: 032] "Forgot to rename this references on the previous commit" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198205 (owner: 10Jhernandez) [09:25:59] (03Merged) 10jenkins-bot: Remove traces of moderation name on files [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198205 (owner: 10Jhernandez) [09:27:01] 6Mobile-Web, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), 5Patch-For-Review: Captcha positioning is inconsistent between JavaScript and non-JavaScript users - https://phabricator.wikimedia.org/T85192#1134828 (10Nemo_bis) Thanks for the explanation. [09:28:56] (03CR) 10Jhernandez: "Rebased on master, gonna rename the *moderation*, retest and merge" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198156 (owner: 10Jdlrobson) [09:29:30] (03PS3) 10Jhernandez: QA: Add browser test for anon user viewing a public collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198156 (owner: 10Jdlrobson) [09:29:58] (03CR) 10Jhernandez: [C: 032] QA: Add browser test for anon user viewing a public collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198156 (owner: 10Jdlrobson) [09:31:03] (03Merged) 10jenkins-bot: QA: Add browser test for anon user viewing a public collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198156 (owner: 10Jdlrobson) [09:31:49] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: project-wide list of collections - https://phabricator.wikimedia.org/T92782#1134838 (10Jhernandez) Renamed the page to Special:GatherLists and i18n'd it. Merged 👍 Thanks @rmoen! [09:34:12] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Project-wide list of collections - https://phabricator.wikimedia.org/T92782#1134840 (10Jhernandez) [09:35:30] 3Gather Sprint Diplodocus: Add browser test for anon user viewing a collection - https://phabricator.wikimedia.org/T93254#1134843 (10Jhernandez) Done in https://gerrit.wikimedia.org/r/#/c/198156/ QA: Add browser test for anon user viewing a public collection Which is merged. [09:41:08] phuedx: what is going on with the main menu patches [09:42:14] (03CR) 10Jhernandez: "@jdlrobson I'm confused now, what do we exactly want?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197454 (owner: 10Jdlrobson) [10:10:50] (03CR) 10Jhernandez: [C: 032] "Looks good, I'll do some follow up patches with some things I want to touch" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [10:11:57] (03Merged) 10jenkins-bot: Article reader sees guidance about creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197247 (owner: 10Robmoen) [10:12:09] joakino: ? [10:12:16] sorry -- i've just got here [10:12:24] phuedx: nah don't worry [10:12:34] the event logging main menu patches, confuse me [10:18:58] 6Mobile-Web, 10Wikimedia-Site-requests, 7user-notice: Set $wgMFAnonymousEditing = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1134894 (10Aklapper) [10:22:24] i think we discussed making skinminerva aware of the gather extension [10:22:35] but i haven't read through the second patch yet [10:28:11] holy shit [10:28:16] response storage landed! [10:28:22] where's the damn email!? [10:46:19] phuedx: what is that [10:46:50] wikigrok response storage and initial aggregation [10:47:02] aggregation patch is looking better too [10:51:52] (03CR) 10Phuedx: [C: 04-1] "Teeny-tiny change required. Other than that this is looking good." (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [11:00:09] (03PS1) 10Jhernandez: Extract WatchstarPageActionOverlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198209 [11:01:46] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Article reader sees message/guidance about creating a collection so that they know the feature exists and the entry point - https://phabricator.wikimedia.org/T91015#1135015 (10Jhernandez) Gerrit bot has gone AWOL but https://gerrit.wikimedia.org/r/#/c/... [11:02:06] (03PS2) 10Jhernandez: Extract WatchstarPageActionOverlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198209 (https://phabricator.wikimedia.org/T91015) [11:03:30] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Article reader sees message/guidance about creating a collection so that they know the feature exists and the entry point - https://phabricator.wikimedia.org/T91015#1135022 (10Jhernandez) @jdlrobson @rmoen have a look when you can ⬆️. Behavior should b... [11:05:36] i'm out for lunch and stuff [11:05:38] bb! [11:21:26] 10Wikipedia-App-Android-App, 6Release-Engineering, 10Wikimedia-Hackathon-2015: Create end-to-end test for Wikipedia Android app - https://phabricator.wikimedia.org/T90177#1135051 (10zeljkofilipin) @etonkovidova: we do not have a similar ticket for ios, feel free to create one! [11:23:12] (03CR) 10Phuedx: [C: 04-1] "Nice!" (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198163 (https://phabricator.wikimedia.org/T91142) (owner: 10Bmansurov) [11:50:36] (03PS1) 10Amire80: Add a space in a
tag in a message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198214 [11:51:54] aharoni: ^ are you self +2ing that or would you like someone else? [12:30:29] heading out for lunch [13:27:21] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: The Wikipedia app should handle Wiktionary links better - https://phabricator.wikimedia.org/T86283#1135215 (10dr0ptp4kt) n.b., the purpose of https://phabricator.wikimedia.org/T93247 merged into this ticket is to allow the user to select arbitrary text (not... [13:36:59] (03CR) 10Florianschmidtwelzow: [C: 032] Add a space in a
tag in a message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198214 (owner: 10Amire80) [13:39:08] (03CR) 10Dr0ptp4kt: "@Deskana, your feedback requested." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197288 (owner: 10OliverKeyes) [13:40:20] (03Merged) 10jenkins-bot: Add a space in a
tag in a message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198214 (owner: 10Amire80) [14:31:16] 10Wikipedia-App-Android-App: latest android alpha 19.3.2015 doesn't update main page unless device is rebooted - https://phabricator.wikimedia.org/T93356#1135299 (10Matanya) 3NEW [14:36:18] (03PS5) 10Yurik: Added gl_perm & gl_updated columns to gather_list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (https://phabricator.wikimedia.org/T93303) [14:36:40] (03CR) 10jenkins-bot: [V: 04-1] Added gl_perm & gl_updated columns to gather_list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (https://phabricator.wikimedia.org/T93303) (owner: 10Yurik) [14:37:51] 10Wikipedia-App-Android-App: latest android alpha 19.3.2015 doesn't update main page unless device is rebooted - https://phabricator.wikimedia.org/T93356#1135332 (10Matanya) tested on more devices, and on some even reboot doesn't help. [14:39:40] 10Wikipedia-App-Android-App: latest android alpha 19.3.2015 doesn't update main page unless device is rebooted - https://phabricator.wikimedia.org/T93356#1135338 (10Dbrant) p:5Triage>3High Indeed, this is because we are now caching pages on the device. We'll have to make a special case for the Main Page. Not... [14:51:19] finally back online [14:51:29] "crowded channel" my foot [14:53:51] (03PS6) 10Yurik: Added gl_perm & gl_updated columns to gather_list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (https://phabricator.wikimedia.org/T93303) [15:00:25] (03CR) 10Bmansurov: Cap the number of claims WikiGrokResponse API should accept (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198163 (https://phabricator.wikimedia.org/T91142) (owner: 10Bmansurov) [15:02:25] (03CR) 10Bmansurov: Fix problems with license message (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [15:03:08] (03CR) 10Bmansurov: Fix problems with license message (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [15:25:35] 6Mobile-Web, 10Wikimedia-Site-requests, 3Roadmap, 7user-notice: Set $wgMFAnonymousEditing = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1135521 (10greg) [15:38:18] (03CR) 10Phuedx: [C: 032] Don't hide the clear button when the search input is not empty [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198143 (https://phabricator.wikimedia.org/T88631) (owner: 10Bmansurov) [15:38:34] 6Mobile-Web, 7Easy, 7Mobile: Clear search button is missing on mobile search once you swith to full-text Search - https://phabricator.wikimedia.org/T88631#1135548 (10phuedx) [15:39:37] (03Merged) 10jenkins-bot: Don't hide the clear button when the search input is not empty [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198143 (https://phabricator.wikimedia.org/T88631) (owner: 10Bmansurov) [15:43:01] 10Gather, 3Gather Sprint Diplodocus, 10Wikimedia-Extension-setup, 3Roadmap, 7user-notice: Enable Extension:Gather (article lists) on English Wikipedia Mobile Beta - https://phabricator.wikimedia.org/T91341#1135555 (10greg) Tentatively scheduled for 2015-03-24 10:00 SF (ie: the mobile window, just because... [15:43:14] 10Gather, 3Gather Sprint Diplodocus, 10Wikimedia-Extension-setup, 3Roadmap, 7user-notice: Enable Extension:Gather (article lists) on English Wikipedia Mobile Beta - https://phabricator.wikimedia.org/T91341#1135556 (10greg) >>! In T91341#1134252, @Jdlrobson wrote: > @greg "Make sure the extension is autom... [15:43:33] (03CR) 10Phuedx: Cap the number of claims WikiGrokResponse API should accept (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198163 (https://phabricator.wikimedia.org/T91142) (owner: 10Bmansurov) [15:43:59] 6Mobile-Web, 7Easy, 7Mobile: Clear search button is missing on mobile search once you swith to full-text Search - https://phabricator.wikimedia.org/T88631#1135557 (10phuedx) 5Open>3Resolved [15:46:47] (03CR) 10BearND: [C: 031] "Code looks good, hence the +1." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 (owner: 10Dbrant) [15:56:40] (03PS7) 10Yurik: Added gl_perm & gl_updated columns to gather_list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (https://phabricator.wikimedia.org/T93303) [15:59:32] joakino, around? [15:59:39] hi yurik_! [15:59:45] hi )) want to +2 https://gerrit.wikimedia.org/r/#/c/198181/ [16:00:24] yurik_: 5 minutes, i'm in the middle of a patch, i'll have a look soon [16:00:31] thx [16:05:52] yurik_: lolz http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/Jhernandez/42 [16:08:29] joakino, hehe, i think you might need a face detection there ;) [16:12:03] 3Gather Sprint Diplodocus: Editing a user's public collection shows the collection as private - https://phabricator.wikimedia.org/T93372#1135617 (10Jhernandez) 3NEW [16:12:54] 3Gather Sprint Diplodocus: Editing a user's public collection shows the collection as private - https://phabricator.wikimedia.org/T93372#1135624 (10Jhernandez) Privacy/public concerns should be addressed soon and before release! cc/ @JKatzWmf [16:13:29] 10Gather, 3Gather Sprint Diplodocus: An admin is able to hide or unhide a list. - https://phabricator.wikimedia.org/T91444#1135626 (10Jhernandez) I'm working in the evolution of the previous patch for the UI of hiding lists [16:16:18] (03CR) 10BearND: [C: 032] Make text in certain TextViews selectable (for copying) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197912 (owner: 10Dbrant) [16:19:10] (03Merged) 10jenkins-bot: Make text in certain TextViews selectable (for copying) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197912 (owner: 10Dbrant) [16:19:14] 10Wikipedia-App-Android-App, 6Release-Engineering, 10Wikimedia-Hackathon-2015: Create end-to-end test for Wikipedia Android app - https://phabricator.wikimedia.org/T90177#1135634 (10BGerstle-WMF) I have experience with setting up Appium for iOS and had been hoping to do so soon. Happy to help! [16:20:27] 10Wikipedia-App-Android-App, 6Release-Engineering, 10Wikimedia-Hackathon-2015: Create end-to-end test for Wikipedia Android app - https://phabricator.wikimedia.org/T90177#1135638 (10BGerstle-WMF) Also, would be nice to leverage Vagrant here for faster and more reliable tests. [16:21:59] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Revamp xcode & makefile for build tasks - https://phabricator.wikimedia.org/T92886#1135647 (10Fjalapeno) Discussed this in detail with Brian on Monday. Fastlane's "fastfile" essentially is the make file and this ticket can most likely be scoped to setting up... [16:23:00] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Create a fastlane configuration file for iOS builds - https://phabricator.wikimedia.org/T92884#1135648 (10Fjalapeno) [16:23:04] 10Gather, 3Gather Sprint Diplodocus: An admin is able to hide or unhide a list. - https://phabricator.wikimedia.org/T91444#1135649 (10Yurik) i will get this done in an hr or so on the api front [16:26:13] dr0ptp4kt, bgerstle, coreyfloyd: FYI I sent out a thread for you to nominate anything you think is a release blocker. [16:26:15] dr0ptp4kt, bgerstle, coreyfloyd: Since there was a sentiment expressed in yesterday's health check that we've not adequate discussed those. [16:26:20] dr0ptp4kt, bgerstle, coreyfloyd: I'm heading into the office now, so I'll see you when I get there! [16:26:35] Deskana: cool thanks! [16:27:01] k, thanks Deskana! [16:27:41] (03CR) 10BearND: [C: 032] Apply a Ken Burns effect to the lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198082 (owner: 10Dbrant) [16:28:01] (03Merged) 10jenkins-bot: Apply a Ken Burns effect to the lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198082 (owner: 10Dbrant) [16:28:37] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Create a fastlane configuration file for iOS builds - https://phabricator.wikimedia.org/T92884#1135663 (10Fjalapeno) [16:30:28] Deskana: dbrant|brb: Do we have everything merged that would go into the stable release (besides translations of course)? [16:31:17] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android: Hook app up to experimental content service to test the service's viability [NEEDS MORE DEFINITION] - https://phabricator.wikimedia.org/T91798#1135669 (10bearND) a:3bearND [16:34:48] (03CR) 10Bmansurov: Cap the number of claims WikiGrokResponse API should accept (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198163 (https://phabricator.wikimedia.org/T91142) (owner: 10Bmansurov) [16:35:13] phuedx: Maryana bmansurov maxsem kaldari w00t!!!!!!!!! https://gerrit.wikimedia.org/r/#/c/177448/ ermagerd!!!!!!!!!!!!!!! [16:35:30] INORITE!? [16:35:34] nice! [16:35:47] where's the hugzzz email [16:35:50] ? [16:36:11] 💕💕👍😜⛄️🎉👏 [16:36:20] bmansurov: when you say you'll ping design: do you mean for copy? [16:36:32] we have an error pane for wikigrok/roulette [16:36:33] phuedx: yes, the error message mock [16:36:50] phuedx: the thing is it is not an error [16:37:13] phuedx: there won't be a case where the user will see the error message [16:37:26] phuedx: because the front end has the limit too [16:38:14] kristenlans: nice list of emoticons [16:38:26] heheh thanks bmansurov [16:38:27] (03PS1) 10Jhernandez: WIP: Admin can hide a public list in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) [16:38:47] 6Mobile-Web, 10WikiGrok, 5Patch-For-Review: wikigrokresponse API should cap the number of claims accepted - https://phabricator.wikimedia.org/T91142#1135701 (10bmansurov) @MSyed #Design, @phuedx thinks we need to inform the user if the user is submitting claims more than the predefined limit. Could you pleas... [16:39:40] (03CR) 10jenkins-bot: [V: 04-1] WIP: Admin can hide a public list in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [16:39:41] oh-oh, snowing in nyc [16:40:05] bmansurov: oh no! [16:40:20] oh yes, snow is good, I love snow [16:40:29] bmansurov: it is an error -- the request contains bad data [16:40:31] no bmansurov no! [16:40:36] ;) [16:40:49] phuedx: how can it contain a bad data when there is no way for it to contain it? [16:41:36] kristenlans: is there a way to see the activity on a projects board? [16:41:41] on phabricator that is [16:42:21] joakino_: do you mean like a feed of activity? eg https://phabricator.wikimedia.org/project/feed/67/ [16:42:23] (03CR) 10Bmansurov: Don't load WikiGrok on disambiguation pages (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [16:42:57] kristenlans: yeah, how do i get there from https://phabricator.wikimedia.org/project/sprint/profile/1101/ or https://phabricator.wikimedia.org/project/sprint/board/1101/ [16:43:18] with the url manually works https://phabricator.wikimedia.org/project/feed/1101/ [16:43:30] joakino see those icons on the left side? click the one that loosk iek a newspapaer [16:43:34] there is a way for it to contain it -- and the server shouldn't assume that the client is well behaved [16:43:37] is there a less magical and prone to be forgotten way? [16:44:03] ooo thanks kristenlans [16:44:14] joakino that's K-Phab to you ;-) [16:44:30] bearND: I'd like to resolve this before production: https://phabricator.wikimedia.org/T93356 [16:44:50] kristenlans: http://media.giphy.com/media/l81c35iP3v2tq/giphy.gif [16:45:03] i just learned that that left menu is not the normal phab menu [16:45:09] joakino lol [16:45:09] (03PS4) 10Bmansurov: Don't load WikiGrok on disambiguation pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) [16:45:11] phabricator UI is a trainwreck [16:49:30] 6Mobile-Web, 10WikiGrok, 5Patch-For-Review: wikigrokresponse API should cap the number of claims accepted - https://phabricator.wikimedia.org/T91142#1135722 (10phuedx) @bmansurov If the API returns an error, then the error pane is shown, which might be enough, given that it already covers all of the errors t... [16:49:42] joakino_, any q about my patch? want to get it in before doing massive rework of another part [16:49:53] dbrant: ok, let's move it into the current sprint then /cc: Deskana|Away [16:50:58] bearND: yep... [16:51:04] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android: latest android alpha 19.3.2015 doesn't update main page unless device is rebooted - https://phabricator.wikimedia.org/T93356#1135723 (10Dbrant) [16:52:47] yurik on it [16:53:53] 6Mobile-Web, 10WikiGrok, 5Patch-For-Review: wikigrokresponse API should cap the number of claims accepted - https://phabricator.wikimedia.org/T91142#1135735 (10bmansurov) OK, makes sense. [16:55:31] coreyfloyd: dr0ptp4kt i don't know about you guys, but i'm regretting turning on static analysis on build [16:55:42] it's constantly giving me weird errors that are only fixed by cleaning [16:55:50] so i'm going to turn it off in my next patch [16:55:58] since we'll have a build server soon that does it for us ;-) [16:56:24] yurik_: so should i run update php with this patch? [16:56:33] joakino, yep [16:56:54] hey guys [16:57:08] anything i need to merge before security reviewing with chris? [16:57:37] jdlrobson, i think https://gerrit.wikimedia.org/r/#/c/198181/ [16:57:44] joakino is reviewing it now [16:58:17] hi jdlrobson [16:58:19] jdlrobson, i'm also working on allowing editlist for admins [16:58:25] should be another hr or so [16:58:41] writing comprehensive unit tests for editlist [16:58:51] he left lol [16:58:56] yurik_: that's great [16:59:29] (03CR) 10OliverKeyes: "Thanks Adam :). Yep, I should also have mentioned that it's not just a term with racist origins, but one with racist origins that refers t" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197288 (owner: 10OliverKeyes) [16:59:55] hi jdlrobson [16:59:56] jdlrobson, i'm also working on allowing editlist for admins [16:59:56] should be another hr or so [16:59:56] writing comprehensive unit tests for editlist [17:00:33] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android: latest android alpha 19.3.2015 doesn't update main page unless device is rebooted - https://phabricator.wikimedia.org/T93356#1135755 (10Dbrant) a:3Dbrant [17:00:58] kristenlans: will be one minute late [17:01:10] i've got a very tired boy with me waiting for his mummy to get in the door [17:01:25] (03PS3) 10Bmansurov: Cap the number of claims WikiGrokResponse API should accept [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198163 (https://phabricator.wikimedia.org/T91142) [17:02:28] yurik_: this query now returns empty (and i have public lists): http://localhost:8080/w/api.php?action=query&list=lists&lstmode=allpublic [17:03:08] joakino, checking... i should have unit tests for mode=allpublic, tbd [17:03:15] yurik_: also as a logged in user calling http://localhost:8080/w/api.php?action=query&list=lists&lstprop=updated returns the updated as -> "image": "2015-03-20T17:01:36Z" [17:03:31] i'm guessing that 'image' should be 'updated' [17:05:01] joakino, the second thing fixed. [17:05:08] checking the mode=all [17:05:35] cool [17:08:39] (03PS1) 10Florianschmidtwelzow: Hygiene: Remove util.query and use core functions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198251 [17:08:52] (03PS8) 10Yurik: Added gl_perm & gl_updated columns to gather_list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (https://phabricator.wikimedia.org/T93303) [17:08:55] joakino, fixed a few minor things [17:08:59] ^^ [17:09:09] k [17:09:57] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove util.query and use core functions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198251 (owner: 10Florianschmidtwelzow) [17:11:06] joakino, btw, i tried the public mode - i can see the pub lists fine, please recheck if you can still see them [17:11:16] might have been related to another minor issue [17:12:10] 6Mobile-Web: New Alpha mobilemenu doesn't save search queries - https://phabricator.wikimedia.org/T93381#1135769 (10Florian) 3NEW [17:12:37] yurik_: my lists are all private because magic [17:12:53] joakino, i might have messed up with the update script [17:13:16] hehe [17:13:26] not a biggie, we are testing :D [17:13:37] in prod will have to be VERY careful though :D [17:14:07] yurik_: when querying http://localhost:8080/w/api.php?action=query&list=lists&lstprop=public|updated the updated date always increases [17:14:18] is that because those lists didn't have an update date before? [17:14:37] it's like it is just getting now() [17:15:09] joakino, probably a bug somewhere in the edit list - i will fix it separatelly as part of the adminship change [17:15:10] (03PS2) 10Florianschmidtwelzow: Hygiene: Remove util.query and use core functions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198251 [17:15:43] 6Mobile-Web, 5Patch-For-Review: md5 library should be removed from MobileFrontend - https://phabricator.wikimedia.org/T93258#1135780 (10phuedx) From my last comment on [192855](https://gerrit.wikimedia.org/r/192855): > If you run md5.js through the Google Closure compiler then its size drops from 3.71KB gzipp... [17:15:51] yurik_: cant do much more and gotta leave, i'd like to have somebody else have a look [17:15:55] i'm in a rush [17:16:00] (03PS4) 10Bmansurov: Cap the number of claims WikiGrokResponse API should accept [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198163 (https://phabricator.wikimedia.org/T91142) [17:16:04] ok, jdlrobson its on your plate now :) [17:16:15] sorry yurik_ [17:16:16] joakino, thx for catching all these issues [17:16:22] np [17:16:24] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove util.query and use core functions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198251 (owner: 10Florianschmidtwelzow) [17:16:28] alright people see you on monday! [17:16:31] have a nice weekend [17:16:42] bearND: stnad! [17:17:27] man george is having a terrible day today :( [17:18:01] (03PS3) 10Florianschmidtwelzow: Hygiene: Remove util.query and use core functions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198251 [17:18:51] * FlorianSW slaps himself: I need to setup make test locally... I need to setup make tests locally... I need to setup tests locally [17:19:01] (03PS5) 10Bmansurov: Cap the number of claims WikiGrokResponse API should accept [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198163 (https://phabricator.wikimedia.org/T91142) [17:19:24] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove util.query and use core functions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198251 (owner: 10Florianschmidtwelzow) [17:19:40] phuedx: maybe he wants friday drinks? [17:20:06] (03PS9) 10Yurik: Added gl_perm & gl_updated columns to gather_list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (https://phabricator.wikimedia.org/T93303) [17:20:18] dbrant is there a way to use snapshots to "fake" the transition? [17:20:33] kristenlans: that phuedx character laying down some numbers about his coffee habit: https://twitter.com/phuedx/status/578955891585781761 [17:20:35] i.e. render a view/fragment to an image and use that as an stand-in for the webview [17:21:39] (03PS4) 10Florianschmidtwelzow: Hygiene: Remove util.query and use core functions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198251 [17:22:48] rmoen, hi, important patch https://gerrit.wikimedia.org/r/#/c/198181/ [17:22:55] when you have a chance :) [17:23:00] yurik_: ok [17:23:59] yurik_: I'll look at it in a few minutes, still kinda waking up. [17:24:09] kaldari: in order to generate the list of wikidata items we'll be updating, I need the number of responses and percent agreement values. Doe 10 and 80% sound good? [17:24:32] rmoen, i heard cold/hot contrast shower does magic... always hated it though ) [17:24:47] yurik_: yep, i'm about to do just that [17:25:09] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Create a fastlane configuration file for iOS builds - https://phabricator.wikimedia.org/T92884#1135796 (10Fjalapeno) [17:25:43] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Configure Jenkins for iOS builds - https://phabricator.wikimedia.org/T92882#1135797 (10Fjalapeno) [17:26:51] coreyfloyd: we should probably just commit the pods repo [17:27:18] also, i heard back from antoine regarding that jenkins infra. might be worth looking into soonish [17:29:51] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Create a fastlane configuration file for iOS builds - https://phabricator.wikimedia.org/T92884#1135803 (10Fjalapeno) [17:30:50] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Configure Jenkins for iOS builds - https://phabricator.wikimedia.org/T92882#1135807 (10Fjalapeno) [17:31:44] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Configure Jenkins for iOS builds - https://phabricator.wikimedia.org/T92882#1122640 (10Fjalapeno) @BGerstle-WMF - changed this slightly, The saving of the artifacts is actually done by fastlane. Jenkins must be setup to view the artifacts that fastlane produces [17:35:20] https://phabricator.wikimedia.org/project/sprint/board/782/query/bE24QjugTPbC/ [17:35:22] mhurd ^ [17:35:28] https://docs.google.com/a/wikimedia.org/document/d/1hiwNMpbK0e2MANhtiLXa5qfGBvHvtebuI-NeJKrGkUo/edit#heading=h.tnl4gk92v5ea [17:35:33] mhurd dr0ptp4kt ^ [17:36:30] 3Gather Sprint Diplodocus: User cannot make their list public (even via API) if moderator has made it public. - https://phabricator.wikimedia.org/T93382#1135816 (10JKatzWMF) 3NEW [17:36:41] 10Gather, 3Gather Sprint Diplodocus: User cannot make their list public (even via API) if moderator has made it public. - https://phabricator.wikimedia.org/T93382#1135827 (10JKatzWMF) [17:38:19] 6Mobile-Web, 10WikiGrok: Aggregation results - https://phabricator.wikimedia.org/T93383#1135830 (10bmansurov) 3NEW [17:39:30] kaldari: ^ results [17:40:02] bmansurov: thanks! [17:40:18] kaldari: np, let me know if you need the data for different numbers [17:42:23] 10Gather, 3Gather Sprint Diplodocus: Gather edits to list name or description (and list creation) go through abusefilter - https://phabricator.wikimedia.org/T93385#1135856 (10JKatzWMF) 3NEW a:3Jdlrobson [17:45:21] yurik_: rmoen we just had security review. 2 bugs we'll need to fix up. [17:45:33] good [17:45:40] looking at yurik_'s patch [17:45:42] i was worried we were perfect [17:45:48] lols [17:50:30] 6Mobile-Web, 5Patch-For-Review: md5 library should be removed from MobileFrontend - https://phabricator.wikimedia.org/T93258#1135901 (10Jdlrobson) The Gzipping is not really the issue. I just don't think we should need a library for this sort of thing... Every little adds to the payload (Bear grillz remember)!... [17:50:44] (03CR) 10Deskana: [C: 032] Change the heading for privacy and terms to 'privacy and terms' [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197288 (owner: 10OliverKeyes) [17:53:07] bmansurov: is that list limited to 100 edits on purpose, or just by coincidence? [17:53:20] actually I guess it’s 99 edits [17:53:21] kaldari: no limit [17:53:24] cool [17:53:47] bmansurov: I’ll throw 1 extra one in there to make it 100 :) [17:54:02] kaldari: you know 99 is a beautiful number [17:54:06] haha [17:54:10] :) [17:54:37] phuedx: especially in islam :) [17:54:38] there are even songs about that number [17:54:43] oops, wrong person [17:54:58] kaldari: yes, odd numbers are beautiful [17:54:58] bmansurov: ^ [17:55:24] kaldari: and the reason you had in mind [17:56:05] 99 is a lucky number [17:56:22] phuedx: i assume you won a lottery? [17:56:30] no no [17:56:38] 99 really is a lucky number: https://en.wikipedia.org/wiki/Lucky_number [17:56:46] :D [17:56:49] cool [17:57:25] 10Gather, 3Gather Sprint Diplodocus: Gather edits to list name or description (and list creation) go through abusefilter - https://phabricator.wikimedia.org/T93385#1135951 (10Jdlrobson) p:5Triage>3High [17:58:13] 10Gather, 3Gather Sprint Diplodocus: User cannot make their list public (even via API) if moderator has made it public. - https://phabricator.wikimedia.org/T93382#1135816 (10Jdlrobson) [17:58:45] (03CR) 10Deskana: [C: 031] "I'd say the fade out is now a bit sudden and could be tweaked, but this is looking a lot better and I think it would be fine to go out to " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 (owner: 10Dbrant) [17:58:49] 10Gather, 3Gather Sprint Diplodocus: Gather edits to list name or description (and list creation) go through abusefilter - https://phabricator.wikimedia.org/T93385#1135856 (10Jdlrobson) @csteipp said he will post a code sample here but from what I understand it's a simple hook that we need to run in the edit a... [17:59:01] 10Gather, 3Gather Sprint Diplodocus: User cannot make their list public (even via API) if moderator has made it public. - https://phabricator.wikimedia.org/T93382#1135961 (10Jdlrobson) p:5Triage>3High [18:01:49] bmansurov: it looks like the properties it’s going to delete are ‘studio album’ and ‘live album’, not ‘album’ [18:02:08] 10Wikipedia-App-iOS-App: [Spike 4 hours] Self-hosted Quincy - https://phabricator.wikimedia.org/T90660#1135962 (10BGerstle-WMF) 5Open>3declined Continuing with HockeyApp for the foreseeable future. Should that change, we will revisit Quincy. [18:02:09] kaldari: ok, i might have output the wrong property value [18:02:12] let me recheck [18:02:36] 10Wikipedia-App-iOS-App: Get build server to vote on patches - https://phabricator.wikimedia.org/T93078#1135965 (10BGerstle-WMF) [18:02:48] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Setup iOS build server and distribute alpha builds internally - https://phabricator.wikimedia.org/T91786#1135969 (10BGerstle-WMF) [18:02:49] 10Wikipedia-App-iOS-App: Get build server to vote on patches - https://phabricator.wikimedia.org/T93078#1128774 (10BGerstle-WMF) [18:04:19] kaldari: fixed it in the wiki page [18:04:48] bmansurov: thanks! [18:05:05] 10Gather, 3Gather Sprint E: Make Special:GatherList responsive - https://phabricator.wikimedia.org/T93389#1135979 (10Jdlrobson) 3NEW [18:05:27] 10Gather, 3Gather Sprint Diplodocus: Issue installing Gather on new mediawiki instance - https://phabricator.wikimedia.org/T93095#1135987 (10Jdlrobson) 5Open>3Invalid a:3Jdlrobson Not sure what's going on here. I blame my setup. [18:06:32] 10Wikipedia-App-iOS-App: Get build server to vote on patches - https://phabricator.wikimedia.org/T93078#1135994 (10BGerstle-WMF) [18:06:33] 10Wikipedia-App-iOS-App: Build and test all Gerrit patch sets - https://phabricator.wikimedia.org/T91790#1135993 (10BGerstle-WMF) [18:07:32] 10Wikipedia-App-iOS-App, 7Documentation: Make Xcode setup pain free for external contributors - https://phabricator.wikimedia.org/T93249#1136003 (10BGerstle-WMF) Might be accomplished as part of T91786 [18:08:14] 10Gather, 3Gather Sprint Diplodocus, 10Security-Reviews: Security review of Gather extension - https://phabricator.wikimedia.org/T91778#1136005 (10Jdlrobson) 5Open>3Resolved Sat down with Chris T93382 and T93385 are the two blockers for deploying to production. The latter doesn't need to be blocking prov... [18:08:15] 10Gather, 3Gather Sprint Diplodocus, 10Wikimedia-Extension-setup, 3Roadmap, 7user-notice: Enable Extension:Gather (article lists) on English Wikipedia Mobile Beta - https://phabricator.wikimedia.org/T91341#1136010 (10Jdlrobson) [18:08:49] gonna get george to bed [18:09:36] 3Gather Sprint Diplodocus: Editing a user's public collection shows the collection as private - https://phabricator.wikimedia.org/T93372#1136020 (10Jdlrobson) a:3Jdlrobson [18:11:46] 10Gather, 3Gather Sprint Diplodocus: User cannot make their list public (even via API) if moderator has made it private - https://phabricator.wikimedia.org/T93382#1136038 (10Jdlrobson) [18:13:33] 10Gather: On edit collection overlay, the box is labeled "public" instead of private - https://phabricator.wikimedia.org/T93391#1136059 (10JKatzWMF) 3NEW [18:13:44] 3Gather Sprint Diplodocus: Editing a user's public collection shows the collection as private - https://phabricator.wikimedia.org/T93372#1136068 (10JKatzWMF) @jhernandez. I agree with this bug. While we are fixing it--can we reverse the title as explained here: T93391 [18:14:39] 10Gather, 3Gather Sprint E: Deleted pages should appear at bottom of the collection - https://phabricator.wikimedia.org/T93295#1136078 (10JKatzWMF) [18:15:01] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: As a curious apps reader, I'd like a feed of articles/facts/images so that I can learn more about topics I'm interested in. - https://phabricator.wikimedia.org/T93327#1136079 (10KHammerstein) [18:15:10] 10Gather, 3Gather Sprint E: Watchstar content overlay should make page content transparent - https://phabricator.wikimedia.org/T93287#1136082 (10JKatzWMF) [18:18:23] 10Gather, 3Gather Sprint Diplodocus: List edit/creation validation - https://phabricator.wikimedia.org/T92779#1136105 (10JKatzWMF) @jdlrobson could move to next sprint if we need to from my perspective, but know it might create legacy issues on the backend. [18:19:30] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Project wide list of collections should be sorted by last modified date - https://phabricator.wikimedia.org/T93303#1136122 (10JKatzWMF) @jdlrobson I think we can move this requirement to next sprint, but see it is a "patch" and not a bug. Move if it he... [18:28:44] jdlrobso_, ping [18:30:30] hey yurik_ [18:30:44] hi, any thoughts the patch? [18:31:10] make sure you run update.php [18:31:54] yurik_: i [18:31:59] yurik_: i've asked aaron to look at it [18:32:10] and asked rmoen to validate it by building https://phabricator.wikimedia.org/T93382 [18:32:28] rmoen: am happy to do that task if you'd rather do something else [18:33:51] (03CR) 10Jdlrobson: [C: 031] "Let's make sure this gets merged before https://gerrit.wikimedia.org/r/#/c/180647/ if this is indeed the way forward" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [18:34:59] https://phabricator.wikimedia.org/T93327 [18:35:01] bearND ^ [18:37:46] bmansurov: if you have a chance, could you also output a list based on (5+80%)? [18:37:59] kaldari: sure [18:38:14] Should have about 600 edits if I remember [18:38:27] let's see [18:40:07] jdlrobso_: i'll grab https://phabricator.wikimedia.org/T91444 [18:40:17] (03PS1) 10Jdlrobson: Use public not isPublic when rendering checkbox [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198271 (https://phabricator.wikimedia.org/T93372) [18:40:26] sweet thanks rmoen [18:40:57] ^ yurik_ there you go. When that's done we'll be able to prove the api is working as needed :) [18:40:59] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: An admin is able to hide or unhide a list. - https://phabricator.wikimedia.org/T91444#1136202 (10rmoen) a:3rmoen [18:41:33] brb 5 mins [18:41:51] jdlrobso_, you want me to +2 it?? I have no clue what it does, but sure )) [18:44:09] kaldari: i've updated the wiki page [18:45:17] kaldari: 602 qualified claims, but only 415 claims that will be updated [18:45:36] kaldari: because the remaining claims already exist in wikidata [18:45:52] jdlrobso_, ? so should i merge it?/ [18:46:02] yurik_: no don't self merge [18:46:15] jdlrobso_, i meant your "ispublic" micro patch [18:46:30] yurik_: oh sorry i wasnt pointing to that ptch [18:46:35] was point to rmoen comment [18:46:52] (03CR) 10Jdlrobson: [C: 04-1] "my bad needs slight fix" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [18:47:16] jdlrobso_, i haven't implemented it yet - working on adding unit tests for editlist - don't want to touch it until that's done [18:50:53] (03PS3) 10Jdlrobson: Register hogan.js via module name 'mediawiki.template.hogan' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [18:50:55] (03PS1) 10Jdlrobson: Introduce mediawiki.template.hogan in preparation for templates in core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198277 [18:52:40] (03PS4) 10Jdlrobson: Drop use of mobile.templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [18:54:16] (03CR) 10Kaldari: [C: 032] Introduce mediawiki.template.hogan in preparation for templates in core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198277 (owner: 10Jdlrobson) [18:55:17] yurik_: did you see https://phabricator.wikimedia.org/T93382 ? [18:55:39] jdlrobso_, no, thx, will think of how to keep it [18:56:03] (03PS5) 10Jdlrobson: Drop use of mobile.templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [18:56:10] cool - yurik_ apparently that blocks us going to production [18:56:22] jdlrobso_, please create a phabricator issue for each API call [18:56:26] change [18:57:00] jdlrobso_, also, if you introduce "not allowed to make public", you need interface "view those that i made non-public" [18:57:12] (03CR) 10jenkins-bot: [V: 04-1] Drop use of mobile.templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [18:57:16] and allow admins to re-enable it :(( [18:57:28] yurik_: i'm not sure i follow. it's only a temporary measure. we'll review it later [18:57:38] just add a user right for changing private/public status [18:57:46] jdlrobso_, if i made a list, and an admin made it private, my list is stuck [18:57:49] and make sure no users have it by defualt [18:57:50] i cannot fix the problem [18:57:52] yurik_: that's the idea [18:58:00] that's the whole point = it's moderation [18:58:03] the admin cannot re-enable it because they cannot see it [18:58:21] yurik_: in future yeh we'll need a way to change that [18:58:24] but it's not important for time being [18:58:26] yeah. [18:58:46] it's only going to be used in situations where people post phone numbers / social security numbers etc [18:58:47] in any case, jdlrobso_ , pls create api issues (prefixed with API: in title) for any api change request [18:58:52] yurik_: np [18:59:01] otherwise they will get burried with UI and other items [18:59:03] thx [18:59:05] 10Gather, 3Gather Sprint Diplodocus: API: User cannot make their list public (even via API) if moderator has made it private - https://phabricator.wikimedia.org/T93382#1136253 (10Jdlrobson) [18:59:15] whatever makes you work best :) [18:59:26] jdlrobso_, and you are welcome to assign them to me from the start ) [18:59:31] 10Gather, 3Gather Sprint Diplodocus: API: Gather edits to list name or description (and list creation) go through abusefilter - https://phabricator.wikimedia.org/T93385#1136254 (10Jdlrobson) [18:59:41] ^ yurik_ this one i think rmoen or i can take if necessary [18:59:45] jdlrobso_, are you saying i haven't so far;) ??? [18:59:49] (03Merged) 10jenkins-bot: Introduce mediawiki.template.hogan in preparation for templates in core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198277 (owner: 10Jdlrobson) [19:01:54] 10Wikipedia-App-General-or-Unknown: Adding buttons to support many programming languages - suggeston - https://phabricator.wikimedia.org/T92617#1136266 (10Aklapper) Thanks for taking the time to report this! I see that this was also brought up on https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_... [19:04:41] (03CR) 10Jdlrobson: [C: 032] "I checked WikiGrok and MobileFrontend and neither use this function." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198251 (owner: 10Florianschmidtwelzow) [19:06:18] (03Merged) 10jenkins-bot: Hygiene: Remove util.query and use core functions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198251 (owner: 10Florianschmidtwelzow) [19:18:40] Mike Ash's Q&A from today is .... scary D: https://www.mikeash.com/pyblog/friday-qa-2015-03-20-preprocessor-abuse-and-optional-parentheses.html [19:18:45] coreyfloyd: ^ [19:19:03] but, the "ONCE" macro at the end is pretty cool [19:31:20] (03PS1) 10Yurik: In phpunit, mobile frontend crashes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198290 [19:34:58] MaxSem, https://gerrit.wikimedia.org/r/#/c/198290 [19:35:19] MaxSem, i have no idea how to test it - but it fixed the phpunit issue [19:35:35] not even sure what it does )) [19:40:35] bgerstle: have a minute to kick the tires on https://gerrit.wikimedia.org/r/#/c/197823/ again? [19:40:56] 10Wikipedia-App-iOS-App: RTL Image Gallery: Image descriptions are displayed in English - https://phabricator.wikimedia.org/T93413#1136492 (10Etonkovidova) 3NEW [19:41:08] mhurd sorry i did have one comment.. [19:41:20] (03CR) 10Bgerstle: "test assertion question" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197823 (owner: 10Mhurd) [19:41:40] bgerstle: ah cool … checking ... [19:44:02] (03CR) 10Mhurd: Speed up html parse. Prune html before HPPLE parse. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197823 (owner: 10Mhurd) [19:44:06] bgerstle: ^ [19:48:30] mhurd, quick hangout? [19:48:36] bgerstle: ya! [19:48:59] dept [19:49:01] adsflkj [19:49:09] irccloud server is down for me :( [19:50:55] vs. or [19:50:57] mhurd ^ [19:51:47] 10MobileFrontend-Feature-requests: Gallery tags do not honour their 'spec' - https://phabricator.wikimedia.org/T56796#1136515 (10Tgr) [19:52:18] brb, going to get a snack [19:53:44] 10Gather, 3Gather Sprint Diplodocus: API: Gather edits to list name or description (and list creation) go through abusefilter - https://phabricator.wikimedia.org/T93385#1136526 (10csteipp) In the simplest form, it would be something like: ``` $vars = new AbuseFilterVariableHolder(); $vars->addHolders( AbuseFi... [19:58:53] (03CR) 10Jdlrobson: [C: 04-1] A place for tracking asynchronously loading things [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197979 (owner: 10Robmoen) [19:59:33] (03CR) 10Jdlrobson: [C: 032] Infobox: Add link to commons category overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197110 (https://phabricator.wikimedia.org/T92687) (owner: 10Florianschmidtwelzow) [20:00:00] 6Mobile-Web, 5Patch-For-Review: No entry point for commons category - https://phabricator.wikimedia.org/T92687#1136536 (10Jdlrobson) 5Open>3Resolved [20:01:44] (03Merged) 10jenkins-bot: Infobox: Add link to commons category overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197110 (https://phabricator.wikimedia.org/T92687) (owner: 10Florianschmidtwelzow) [20:01:59] yurik_, does that failure just happen locally? [20:02:08] MaxSem, yep [20:02:14] grmbl [20:02:16] i haven't tried running phpunit on server [20:02:37] MaxSem, it fails if i run MainApi with incorrect params [20:02:50] ApiMain throws an error, and some hook handles it [20:02:53] this is very weird because the skin should be pointing to the same context [20:03:07] so title should be the same [20:03:22] should == is, but should !== is [20:04:17] kaldari: are you guys in the meeting? i'm having trouble getting on the hangout for some reason [20:04:32] Maryana_: yeah, I’ll let them know [20:04:49] gonna head orf [20:04:53] g'night folks [20:04:57] will be idlin' on the weekend [20:07:16] (03CR) 10Jdlrobson: [C: 04-1] "Please add a comment as we may want to revisit this if we move the last modified bar to the bottom of the page." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198136 (https://phabricator.wikimedia.org/T89310) (owner: 10Bmansurov) [20:09:09] phuedx: have a good weekend [20:09:14] (03CR) 10Jdlrobson: [C: 032] Show Overlays only after the DOM is ready [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198132 (https://phabricator.wikimedia.org/T88295) (owner: 10Bmansurov) [20:10:57] (03CR) 10Jdlrobson: [C: 04-1] "Discussion button rendering oddly." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [20:11:38] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Project wide list of collections should be sorted by last modified date - https://phabricator.wikimedia.org/T93303#1136599 (10Jdlrobson) a:3Jdlrobson [20:11:44] 10Gather, 3Gather Sprint Diplodocus: Project wide list of collections should be sorted by last modified date - https://phabricator.wikimedia.org/T93303#1133918 (10Jdlrobson) [20:11:56] 10Gather, 3Gather Sprint Diplodocus: Project wide list of collections should be sorted by last modified date - https://phabricator.wikimedia.org/T93303#1133918 (10Jdlrobson) I'm going to do this in order to test Yuri's patch :) [20:12:31] jdlrobson, rmoen was looking at it [20:12:43] yurik_: he was looking at the perms bit [20:12:49] i'm gonna look at the modified field [20:12:56] jdlrobson: correct [20:13:03] yurik_: i ran php maintenance/update.php was it meant to wipe my data? [20:13:09] as it hasn't [20:13:11] which surprised me :) [20:13:18] it didn't [20:13:28] jdlrobson, i decided to go the long route and try to learn the updating infrastructure [20:13:31] jdlrobson: previous lists are private [20:13:32] now [20:13:51] might have made a minor mistake somewhere, don't +2 just yet - i will recheck once i'm done with the tests [20:13:53] err after running update.php [20:14:07] perm = 0 aka private [20:14:12] updater should have taken care of the perm bit migration [20:14:35] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: As a curious apps reader, I'd like a feed of articles/facts/images so that I can learn more about topics I'm interested in. - https://phabricator.wikimedia.org/T93327#1136613 (10KHammerstein) [20:14:48] (03PS10) 10Jdlrobson: Added gl_perm & gl_updated columns to gather_list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (https://phabricator.wikimedia.org/T93303) (owner: 10Yurik) [20:15:10] jdlrobson, ?? [20:15:28] yurik_: i just needed to rebase it. needed some changes that have happened since [20:15:47] (03Merged) 10jenkins-bot: Show Overlays only after the DOM is ready [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198132 (https://phabricator.wikimedia.org/T88295) (owner: 10Bmansurov) [20:15:53] did it using ui :P [20:15:58] shoot, i should have rebased it [20:16:16] jdlrobson, the problem with rebase is that i need to make sure to re-get that patch, otherwise next time i commit i might override it with the older stuff [20:16:26] hence, rebases by multiple people are dangerous [20:16:30] could cause a lot of confusion [20:16:41] yurik_: true especially if you're currently working on it [20:16:46] exactyl [20:16:54] Rebase your rebase on top of the rebase. [20:16:57] tis fixable [20:17:01] yurik_: well working off a non-latest version of Gather is also stupid [20:17:06] you'll end up having lots of rebase conflicts [20:17:13] and probably duplicate work [20:17:19] rebasing is the first thing i do when i look at a patch [20:17:20] yurik_: worst case you just push yours and rebase again [20:17:32] (03CR) 10Aaron Schulz: "New fields like fine to me" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (https://phabricator.wikimedia.org/T93303) (owner: 10Yurik) [20:17:32] jdlrobson: same [20:17:33] yurik_: you just need to rebase yours on latest master before pushing [20:17:35] not a big deal [20:17:47] jdlrobson, you will have rebase conflicts regardless - and it doesn't matter if you do rebase after every change or not. It is ok to do rebases, just lets keep the author rebasing [20:18:03] whoever the author of the patch is [20:18:10] sometimes a patch needs to be rebased before merge.. [20:18:29] if the author isn't present thats a problem then [20:18:30] two execeptions - right before merge (assuming you are merging), or if you hand off the patch to another person [20:18:31] we cannot have that rule [20:18:39] rmoen, yep ) [20:19:01] unless its marked WIP. rebase all day [20:19:26] meh, any patch is a WIP when its being reviewed - you tell me bugs, and i resubmit right away [20:20:48] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: As a curious apps reader, I'd like a feed of articles/facts/images so that I can learn more about topics I'm interested in. - https://phabricator.wikimedia.org/T93327#1136635 (10KHammerstein) [20:23:02] dr0ptp4kt: you should see a HockeyApp invite for WMF in your inbox [20:24:03] dr0ptp4kt: once i get the corp card were done with the setup for our account. feel free to add users as needed [20:24:07] coreyfloyd: --^ [20:29:28] yurik_: any reason timestamp is stored in the format it is? [20:29:34] seems inconsistent with recentchanges / watchlist [20:29:42] jdlrobson, it should be te same [20:30:20] looking [20:30:29] yurik_: wait [20:30:30] you're right [20:30:37] i'm doing it wrong [20:30:46] using new MWTimestamp wrong i mean [20:31:19] yurik_: how do i take a date in an api response and turn it into a MWTimestamp ? [20:32:31] not sure, wfTimestamp ? [20:32:37] wfTimestamp( TS_ISO_8601, $timestamp ); ? [20:32:50] new MWTimestamp( $ts ) actually should work [20:33:02] MaxSem, ? [20:33:08] sorry to bug you :)) [20:33:43] ? [20:33:52] sorry, I'm in a meeting [20:34:01] its ok, no prob [20:34:05] jdlrobson, ^^ [20:34:37] yurik_, also, have you tried that title thingie with https://gerrit.wikimedia.org/r/#/c/196738/ ? [20:34:45] k it's working now don't worry [20:36:03] MaxSem, i will try rerunning with the latest just in case [20:37:43] (03PS1) 10Jdlrobson: Surface last updated time in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198363 (https://phabricator.wikimedia.org/T93303) [20:39:00] (03PS1) 10Jdlrobson: Avoid flash of unstyled content [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198372 [20:39:09] (03PS2) 10Jdlrobson: Avoid flash of unstyled content [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198372 [20:39:14] ^ rmoen speedy merge? [20:39:21] sure [20:39:23] (03PS3) 10Jdlrobson: Avoid flash of unstyled content on Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198372 [20:39:28] jdlrobson: sure [20:40:16] (03CR) 10Jdlrobson: [C: 031] "This works for last modified." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (https://phabricator.wikimedia.org/T93303) (owner: 10Yurik) [20:40:18] jdlrobson: this removes 'ext.gather.lists' does it get re-added somewhere ? [20:40:35] i didn't test as i'm currently wrapping hiding thing [20:41:05] rmoen: it's already added [20:41:08] in the line below it [20:41:09] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198375 (owner: 10L10n-bot) [20:41:16] what's status of https://phabricator.wikimedia.org/T93263 yurik_ ? [20:41:49] jdlrobson: " Move lists.less into ext.gather.styles" i'm not seeing anything move [20:41:54] i'm just seeing 3 lines being removed [20:41:56] is this right? [20:42:12] jdlrobson, i have been working on getting editlist unittests so that i can safely change the editlist [20:42:15] just want to confirm you didn't forget to git -a somethign [20:42:23] (03CR) 10Jdlrobson: [C: 032] Extract WatchstarPageActionOverlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198209 (https://phabricator.wikimedia.org/T91015) (owner: 10Jhernandez) [20:42:23] needs a bit more time [20:42:24] commit msg confused me [20:42:46] rmoen: sorry :) [20:42:52] speedy delivery is trying to be speedy ;) [20:42:56] lol [20:43:15] rmoen: oh wit [20:43:25] (03PS4) 10Jdlrobson: Avoid flash of unstyled content [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198372 [20:43:34] thanks for actually testing ;-) [20:43:49] yeah [20:43:53] (03PS5) 10Jdlrobson: Avoid flash of unstyled content [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198372 [20:44:18] rmoen: so yeh i said on the previous patch that we should load all the special styles together [20:44:49] not much value in not doing that as the two page will then have different urls for their stylesheets so no local browser caching exploitation [20:45:22] yurik_: if you've got any WIP patches that kinda work they'd be useful to push up so we can start validating them and building features of them [20:45:25] *off them [20:45:44] https://phabricator.wikimedia.org/T91444 needs to know how api for https://phabricator.wikimedia.org/T93263 will work for example [20:46:06] bah, gerrit won't let me push my change as i've rebased the stack and its detecting no changes on yuriks patch.. [20:46:22] 10Gather, 3Gather Sprint Diplodocus: Event logging for Gather onboarding - https://phabricator.wikimedia.org/T92742#1136747 (10Jdlrobson) a:3Jdlrobson [20:46:42] (03CR) 10Robmoen: [C: 032] Avoid flash of unstyled content [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198372 (owner: 10Jdlrobson) [20:47:05] jdlrobson, i would say that db patch is the biggest WIP [20:47:50] ok just ate lunch / worked at the pub, walking home.. bb in 5 minutes [20:48:13] (03PS1) 10Bmansurov: Re-start versioning the extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 [20:49:34] (03PS1) 10Deskana: Hygiene: Add @NonNull annotation to two methods in LanguagePreference [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198384 [20:52:20] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198343 (owner: 10L10n-bot) [20:54:24] (03PS7) 10Mhurd: Speed up html parse. Prune html before HPPLE parse. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197823 [20:54:49] 6Mobile-Web: Revisit box-sizing: border-box for everything in MobileFrontend - https://phabricator.wikimedia.org/T86366#1136772 (10Jdlrobson) Moving to view doesn't seem to have caused any major issues. Happy to start using view-border-box everywhere if this speeds up fixing the bug in VE. Any thoughts on this?... [20:54:56] bgerstle: amended ^ [20:55:15] (03CR) 10Bgerstle: [C: 031] Speed up html parse. Prune html before HPPLE parse. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197823 (owner: 10Mhurd) [20:55:52] (03PS8) 10Mhurd: Speed up html parse. Prune html before HPPLE parse. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197823 [20:56:11] (03Merged) 10jenkins-bot: Extract WatchstarPageActionOverlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198209 (https://phabricator.wikimedia.org/T91015) (owner: 10Jhernandez) [20:56:46] bgerstle: hangout? [20:56:55] mhurd yeah sure [20:58:02] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198327 (owner: 10L10n-bot) [20:58:19] mhurd: 0562114 [21:00:10] (03Merged) 10jenkins-bot: Avoid flash of unstyled content [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198372 (owner: 10Jdlrobson) [21:08:14] (03PS2) 10Robmoen: WIP: Admin can hide a public list in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [21:09:20] (03CR) 10jenkins-bot: [V: 04-1] WIP: Admin can hide a public list in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [21:09:22] (03PS2) 10Bmansurov: Load Mobile event emitter in the head [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198136 (https://phabricator.wikimedia.org/T89310) [21:09:35] mhurd git reset --hard [21:09:42] mhurd git clean -dffx [21:09:46] 6Mobile-Web, 5Patch-For-Review: Overlays not designed to be run from head - https://phabricator.wikimedia.org/T88295#1136795 (10bmansurov) 5Open>3Resolved [21:09:48] ^ delete everything not tracked in git [21:11:15] (03CR) 10Robmoen: "Privacy setting works along with editing privacy. See my updates to. https://gerrit.wikimedia.org/r/#/c/198246 Note: it is currently no" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (https://phabricator.wikimedia.org/T93303) (owner: 10Yurik) [21:11:56] (03CR) 10Robmoen: [C: 031] "Only issue is previously created lists are marked as private. That can be fixed with a simple db update on beta labs though and will not " [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (https://phabricator.wikimedia.org/T93303) (owner: 10Yurik) [21:12:15] jdlrobson, rmoen let me just check if i could quickly fix updating script to keep public lists [21:13:05] by all means [21:14:28] (03CR) 10Robmoen: "doh warnings! I will fix before i remove wip" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [21:15:14] 10Gather, 3Gather Sprint E: Special:GatherLists should use views and models - https://phabricator.wikimedia.org/T93422#1136805 (10Jdlrobson) 3NEW [21:15:23] 10Gather, 3Gather Sprint Diplodocus: only 10 collections appear on "gather" page - https://phabricator.wikimedia.org/T93296#1136815 (10Jdlrobson) a:3Jdlrobson [21:16:31] 6Mobile-Web: Start versioning MobileFrontend - https://phabricator.wikimedia.org/T93423#1136818 (10bmansurov) 3NEW a:3bmansurov [21:16:58] (03PS2) 10Bmansurov: Re-start versioning the extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) [21:18:15] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: watchlist overlay: design tweaks - https://phabricator.wikimedia.org/T92037#1136829 (10Jdlrobson) [21:18:35] 3Gather Sprint E: More design tweaks to collections content overlay - https://phabricator.wikimedia.org/T93424#1136830 (10Jdlrobson) 3NEW [21:18:53] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: watchlist overlay: design tweaks - https://phabricator.wikimedia.org/T92037#1102057 (10Jdlrobson) Optional issues captured in T93424 [21:21:30] (03PS1) 10Jdlrobson: Up limit of collections shown to 50. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198392 (https://phabricator.wikimedia.org/T93296) [21:22:38] 10Gather, 3Gather Sprint E: Pagination of all the things - https://phabricator.wikimedia.org/T93426#1136854 (10Jdlrobson) 3NEW [21:22:54] 10Gather, 3Gather Sprint E: Pagination of all the things - https://phabricator.wikimedia.org/T93426#1136862 (10Jdlrobson) [21:23:17] 10Gather, 3Gather Sprint E: Pagination of all the things - https://phabricator.wikimedia.org/T93426#1136854 (10Jdlrobson) @aaron we talked in real life about having hard limits for things in collections. Are there any you would like to impose before we do this? [21:30:11] 10Gather, 3Gather Sprint E: Pagination of all the things - https://phabricator.wikimedia.org/T93426#1136924 (10aaron) We can start modest and raise it later. Would 1000 suffice? [21:32:35] rmoen, jdlrobson, no idea why public is not kept - works fine on my machine ( [21:32:42] ok, go ahead and merge [21:34:59] https://docs.google.com/a/wikimedia.org/spreadsheets/d/1w68UX3VgZm_vKsYUNdB7AygumVoi84jGntc2DzHyE8Q/edit#gid=728329856 [21:35:12] https://etherpad.wikimedia.org/p/app_q3_health_check [21:35:50] ethersheets.googlemedia.comorg [21:41:32] 3Gather Sprint Diplodocus: Update schema to incorporate feedback from Aaron and Sean - https://phabricator.wikimedia.org/T93434#1136951 (10Jdlrobson) 3NEW a:3Yurik [21:43:59] (03CR) 10Jdlrobson: [C: 032] "Aaron says this is fine as long as we revisit indexes. Tracked inhttps://phabricator.wikimedia.org/T93434" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (https://phabricator.wikimedia.org/T93303) (owner: 10Yurik) [21:45:04] (03Merged) 10jenkins-bot: Added gl_perm & gl_updated columns to gather_list [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198181 (https://phabricator.wikimedia.org/T93303) (owner: 10Yurik) [21:45:29] (03PS3) 10Robmoen: Admin can hide a public list in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [21:45:43] ^ still need to fix warnings [21:46:33] (03CR) 10jenkins-bot: [V: 04-1] Admin can hide a public list in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [21:48:17] (03PS4) 10Robmoen: Admin can hide a public list in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [21:49:02] 6Mobile-Web, 10Flow, 7I18n: the message mobile-frontend-last-modified-with-user-just-now appears unnecessarily on the top of Flow mobile web pages - https://phabricator.wikimedia.org/T91886#1136970 (10Amire80) [21:49:17] (03CR) 10jenkins-bot: [V: 04-1] Admin can hide a public list in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [21:49:34] 6Mobile-Web: Start versioning MobileFrontend - https://phabricator.wikimedia.org/T93423#1136971 (10bmansurov) https://gerrit.wikimedia.org/r/#/c/198382/ [21:54:33] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: An admin is able to hide or unhide a list. - https://phabricator.wikimedia.org/T91444#1136999 (10rmoen) Based of db change. Added api method and request. Shows toast on success or fail, and added messages. Added sysop permission and checking in canHid... [21:55:42] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Collections need a last modified and created field - https://phabricator.wikimedia.org/T92690#1137002 (10Jdlrobson) 5Open>3Resolved [21:55:43] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Project wide list of collections should be sorted by last modified date - https://phabricator.wikimedia.org/T93303#1137003 (10Jdlrobson) [21:56:01] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Collections need a last modified and created field - https://phabricator.wikimedia.org/T92690#1118235 (10Jdlrobson) They have an updated field but not a created. Created can be added later if and when needed. [21:58:34] mhurd: https://etherpad.wikimedia.org/p/app_q3_health_check [21:58:51] (03CR) 10Jdlrobson: [C: 032] Load Mobile event emitter in the head [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198136 (https://phabricator.wikimedia.org/T89310) (owner: 10Bmansurov) [21:59:02] 6Mobile-Web, 5Patch-For-Review: "Last modified .." flashes on screen, then replaced by "Last modified .." - https://phabricator.wikimedia.org/T89310#1137022 (10Jdlrobson) 5Open>3Resolved [22:00:15] (03Merged) 10jenkins-bot: Load Mobile event emitter in the head [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198136 (https://phabricator.wikimedia.org/T89310) (owner: 10Bmansurov) [22:01:13] (03CR) 10Robmoen: "@Bmansurov So we should emit 'domChanged' on Skin for example ? Then have everything that cares about DOM changes subscribe to Skin.on('" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197979 (owner: 10Robmoen) [22:04:04] dbrant|bbl: I guess we hold off beta until Monday? [22:04:09] (03CR) 10Bmansurov: "Yes, something like M.emit( 'domChanged' ) after some change in the DOM, and somewhere else listen to it with M.on( 'domChanged' ). Howeve" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197979 (owner: 10Robmoen) [22:05:03] (03CR) 10Robmoen: "Re emitting events:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197979 (owner: 10Robmoen) [22:07:25] (03CR) 10Bmansurov: "I doubt 5 scripts will call domChanged when something the user does changes the dom. For example, when a banner image is loaded, domChange" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197979 (owner: 10Robmoen) [22:11:49] (03CR) 10Robmoen: "You may be right. But at least this implementation is future proof. My point it is, pub/sub events isn't the only way to do something an" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197979 (owner: 10Robmoen) [22:14:23] (03PS9) 10Florianschmidtwelzow: Promote TalkOverlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) [22:15:56] 6Mobile-Web: Make unit tests to check that our server-side mustache templates can be compiled without blowing up - https://phabricator.wikimedia.org/T93445#1137102 (10kaldari) 3NEW a:3kaldari [22:16:21] jdlrobson: hi :) About your comment ("We need to be more careful now and probably use mw.deprecate for this sort of thing in future!") on https://gerrit.wikimedia.org/r/#/c/198251/ : Maybe it's a good idea to run unit tests of gather, wikigrok and MF together? At least for the submit job? [22:17:35] FlorianSW: i think it does already [22:17:41] but it still might not catch everything [22:17:48] when we change stuff in core we use mw.deprecate [22:18:03] it might be good practice to start addressing it in MobileFrontend now (although it's a pain :)) [22:19:00] jdlrobson: yeah, sure, but it would help us identifying problems :) Yep, maybe i create a section in our mobile coding convention about deprecating features (the same in php, too, or does WikiGrok and/or Gather doesn't depend on php functions in MF?) [22:20:57] (03CR) 10Florianschmidtwelzow: Fix problems with license message (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [22:21:47] bmansurov: ^ can you take a look? [22:22:19] mhurd restarting my machine brb [22:22:36] FlorianSW: I've read your comment, it's your call at this stage. [22:22:55] FlorianSW: I think it doesn't hurt to try FALSE [22:23:17] JonKatz: maryana kaldari kaity|away I will NOT make it to design review this eve, will catch up with you next week. [22:24:02] bmansurov: ok, thanks :) [22:25:09] (03PS3) 10Mhurd: Update to scroll indicator color per Vibha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198196 [22:27:08] FlorianSW: sounds good! :D [22:30:59] bgerstle: hangout? [22:31:05] sure [22:31:14] just about to debug some data migration [22:39:14] (03PS4) 10Florianschmidtwelzow: Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) [22:47:12] mhurd bgerstle bearND Deskana dbrant|bbl kristenlans we should check this place out when we are in Lyon: https://www.youtube.com/watch?v=1YCOT5LasKc [22:47:47] coreyfloyd: lol!!! [22:48:13] coreyfloyd: i gotta get that wig [22:48:28] coreyfloyd: cholocate cigarette [22:48:30] BAHAHAHA [22:48:49] lol [22:49:23] hahah [22:49:24] mhurd: how long will it take you to submit your patch? "one half hour, two half hour" [22:49:26] lol nick kroll's hilarious [22:49:30] lol [22:49:41] coreyfloyd: hockeyapp is approved and paid for [22:49:56] lolol [22:50:01] w00t tfinc! [22:50:11] "we can as much eat as much as we want and never get heavy because olive oil" [22:50:27] i leave it in your guys capable hands now to do good [22:50:36] coreyfloyd: mhurd there's a sequel https://www.youtube.com/watch?v=GSZoshxXSlg [22:50:41] tfinc we'll do you proud [22:50:49] tfinc: woohoo! [22:50:59] thanks [22:55:58] coreyfloyd: totally gotta check out the spotted ox. Joaquin can coach us on our euroskillZ. I'm pretty sure he smokes about 50 chocolate cigarettes per day. [22:56:18] kristenlans: ROFL [22:57:01] mhurd in that wig would be...amazing...and terrifying [22:57:22] lol [23:03:54] Deskana|Away: we fixed the bug! https://dl-web.dropbox.com/get/Screenshots/yosemite%20nat'l%20park%20NO.png?_subject_uid=9282324&w=AADljP_AhzBAiufbLulnRT4US-_WIAgZ32-FBAbeyVz8WQ [23:04:14] can we ship an easter egg of making all migrated article images a picture of grumpy cat instead? [23:05:11] kristenlans: ^ [23:06:45] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Project wide list of collections should be sorted by last modified date - https://phabricator.wikimedia.org/T93303#1137241 (10Jdlrobson) https://gerrit.wikimedia.org/r/198363 still needs to be merged [23:06:53] jdlrobson: with the recent change to util.query you guys should update the gather code too [23:11:19] (03PS1) 10Jdlrobson: Add EventLogging to gather star workflow, error handling fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198421 (https://phabricator.wikimedia.org/T92742) [23:11:53] (03CR) 10jenkins-bot: [V: 04-1] Add EventLogging to gather star workflow, error handling fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198421 (https://phabricator.wikimedia.org/T92742) (owner: 10Jdlrobson) [23:11:54] 6Mobile-Web, 10WikiGrok: Update WikiGrok not to use MobileFrontend util.query - https://phabricator.wikimedia.org/T93449#1137254 (10bmansurov) 3NEW [23:14:47] (03PS10) 10MaxSem: Claim aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 [23:18:21] (03CR) 10Fjalapeno: [C: 031] "nice cleanup as well!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198196 (owner: 10Mhurd) [23:18:37] (03PS2) 10Jdlrobson: Add EventLogging to gather star workflow, error handling fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198421 (https://phabricator.wikimedia.org/T92742) [23:19:12] (03CR) 10jenkins-bot: [V: 04-1] Add EventLogging to gather star workflow, error handling fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198421 (https://phabricator.wikimedia.org/T92742) (owner: 10Jdlrobson) [23:21:15] (03PS3) 10Jdlrobson: Add EventLogging to gather star workflow, error handling fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198421 (https://phabricator.wikimedia.org/T92742) [23:21:53] (03CR) 10jenkins-bot: [V: 04-1] Add EventLogging to gather star workflow, error handling fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198421 (https://phabricator.wikimedia.org/T92742) (owner: 10Jdlrobson) [23:22:55] (03PS1) 10Bmansurov: Replace mw.MobileFrontend.util.query with mw.util.getParamValue [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198429 (https://phabricator.wikimedia.org/T93449) [23:23:38] dr0ptp4kt: hi [23:24:16] which beta should I test - 4.0.7.6? [23:25:20] (03PS1) 10Robmoen: WIP: List creation and editing validation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 [23:25:26] 10Gather, 3Gather Sprint Diplodocus: List edit/creation validation - https://phabricator.wikimedia.org/T92779#1137308 (10rmoen) a:3rmoen [23:25:53] (03CR) 10Fjalapeno: [C: 031] Speed up html parse. Prune html before HPPLE parse. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197823 (owner: 10Mhurd) [23:26:04] 3Gather Sprint Diplodocus: Add browser test for anon user viewing a collection - https://phabricator.wikimedia.org/T93254#1137324 (10Jdlrobson) https://integration.wikimedia.org/ci/job/browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/39/testReport/(root)/Anonymous%20users/Anons_can_see_my_p... [23:26:20] 3Gather Sprint Diplodocus, 5Patch-For-Review: Can't access public collections on beta labs - https://phabricator.wikimedia.org/T93222#1137327 (10Jdlrobson) [23:26:21] 3Gather Sprint Diplodocus: Add browser test for anon user viewing a collection - https://phabricator.wikimedia.org/T93254#1137326 (10Jdlrobson) 5Open>3Resolved [23:26:31] aharoni: the 4.0.7.6, yeah. i'm cutting a new testflight build tonight as well [23:26:46] I'm having some trouble with it actually [23:26:52] it says that it "cannot download it" [23:27:08] (03CR) 10Dr0ptp4kt: [C: 032] Speed up html parse. Prune html before HPPLE parse. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197823 (owner: 10Mhurd) [23:27:10] I'm wondering whether it has anything to do with my Apple ID [23:27:18] or some other issue [23:27:55] (03PS4) 10Dr0ptp4kt: Update to scroll indicator color per Vibha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198196 (owner: 10Mhurd) [23:28:12] (03CR) 10Dr0ptp4kt: [C: 032] Update to scroll indicator color per Vibha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198196 (owner: 10Mhurd) [23:28:24] dr0ptp4kt: the Apple ID that I have on this iPod is amir.aharoni@mail.huji.ac.il, and you added me as aaharoni@wikimedia.org . can it work together? [23:28:47] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: When I go to Special:Gather and see the collections I own they are illustrated with a page image - https://phabricator.wikimedia.org/T91675#1137335 (10Jdlrobson) @Joaquin feel free to take over this patch. Didn't get round to it today. [23:29:23] aharoni, yeah, just tap the link on the ios 8 device where you have the app TestFlight installed. it's a token that will be tagged to that device (well, there's more to it than that, but i digress) [23:29:49] 10Gather, 3Gather Sprint Diplodocus: Get database schema reviewed for production - https://phabricator.wikimedia.org/T93154#1137357 (10Jdlrobson) 5Open>3Resolved Seems T93434 is the main issue so calling this work done. Sean/Aaron please feel free to open specific bugs if you consider them a major problem... [23:30:05] hmmm [23:30:11] let me try again [23:30:13] (03PS1) 10Bgerstle: set article imageURL and save image list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 [23:30:21] mhurd coreyfloyd dr0ptp4kt ^ [23:30:30] fix (albeit a brute-force one) for the blocker [23:31:00] on it [23:31:12] dr0ptp4kt: do you need anything from me for hockey support? [23:31:28] coreyfloyd: i'll need a review shortly. [23:31:40] dr0ptp4kt: ok will be here [23:32:49] dr0ptp4kt: coreyfloyd trying to invite you to hangout to brief on testing procedure [23:33:26] bgerstle: ok [23:34:37] coreyfloyd: mhurd here's the 4.0.6 commit i'm testing on 0562114 [23:36:29] dr0ptp4kt: "Unable to Download App. Wikipedia Mobile could not be installed at this time. Done / Retry" [23:37:04] aharoni: try the one titled 'wikipedia beta'. did you receive an invitation for 'wikipedia beta' ? [23:40:07] I'm out for the weekend, see you in SF next week peeps! [23:41:20] dr0ptp4kt: so weird [23:41:27] it's supposed to be in the email, right? [23:41:29] (03PS1) 10Dr0ptp4kt: Add production support for crash reporting [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198435 [23:42:30] aharoni: yeah, if you search for "wikipedia beta" you will probably see it in your email. if no, lemme know and i'll remove then re-add you [23:42:56] ^^ coreyfloyd pleae verify with a +1 then have mhurd +2 [23:43:34] dr0ptp4kt: yep - looking now [23:44:00] 6Mobile-Web, 7Wikimedia-log-errors: TemplateParser spewing eval() errors - https://phabricator.wikimedia.org/T93436#1137461 (10Krenair) a:3kaldari [23:44:51] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: [4.0.7.5] Lead Image & Image Gallery features broken for migrated articles - https://phabricator.wikimedia.org/T92697#1137479 (10BGerstle-WMF) a:3BGerstle-WMF [23:45:13] coreyfloyd: i just added you as a user [23:45:17] 6Mobile-Web, 7Wikimedia-log-errors: TemplateParser spewing eval() errors - https://phabricator.wikimedia.org/T93436#1137485 (10kaldari) Haven't been able to reproduce locally yet. Relate bug: https://phabricator.wikimedia.org/T93445 [23:45:18] for org.wikimedia.wikipedia [23:45:22] ^ coreyfloyd [23:45:25] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: [4.0.7.5] Lead Image & Image Gallery features broken for migrated articles - https://phabricator.wikimedia.org/T92697#1118359 (10BGerstle-WMF) p:5Low>3High [23:45:37] dr0ptp4kt: was just about to ask [23:45:42] dr0ptp4kt: ok, I think I have 4.0.7.6 [23:46:32] (03PS2) 10Bgerstle: set article imageURL and save image list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 [23:47:31] dr0ptp4kt: im just going to run this real quick to make sure the app id is set correctly [23:48:10] coreyfloyd: k [23:49:18] 6Mobile-Web, 10Wikimedia-Site-requests, 3Roadmap, 7user-notice: Set $wgMFAnonymousEditing = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1137494 (10greg) @JKatzWMF: can I get your opinion on rollout strategy? Does this need a staggered rollout, or can/should it be a "do it every... [23:49:25] jdlrobson: https://office.wikimedia.org/wiki/Health_check_survey_results/FY2014-15_Q2 [23:50:43] (03PS3) 10Bgerstle: set article imageURL and save image list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 [23:51:05] (03CR) 10Fjalapeno: [C: 031] Add production support for crash reporting [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198435 (owner: 10Dr0ptp4kt) [23:51:13] ^ mhurd [23:51:18] pls +2 [23:51:31] dr0ptp4kt: can I expect audio to work in the app? for example in https://en.wikipedia.org/wiki/The_Well-Tempered_Clavier ? [23:51:50] aharoni: i think that doesn't work on ios. you may want to submit a bug [23:52:03] aharoni: whereas i think it's been working alright on android [23:52:03] (03CR) 10Mhurd: [C: 032] Add production support for crash reporting [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198435 (owner: 10Dr0ptp4kt) [23:52:06] mhurd: thx [23:52:31] coreyfloyd: dr0ptp4kt mhurd stepping out for a bit, but i'll be around if my patch blows something up [23:52:41] bgerstle: ttyl [23:52:45] the task is in "Code Review" in phab [23:52:49] you can follow the repro steps there [23:54:16] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: [4.0.7.5] Lead Image & Image Gallery features broken for migrated articles - https://phabricator.wikimedia.org/T92697#1137499 (10BGerstle-WMF) [23:55:24] 10Wikipedia-App-iOS-App: audio playback doesn't work in the iOS app - https://phabricator.wikimedia.org/T93454#1137501 (10Amire80) 3NEW [23:56:16] dr0ptp4kt: OK, so I do have 4.0.7.6, although I'm not sure that I have the internal one. [23:56:34] I really need to sleep now, but I'll test more on the weekend [23:56:50] aharoni: i think formally it's under your "internal" profile, although we've also sent that one to the external group :) [23:56:55] aharoni: have a good night's rest! [23:59:01] (03PS4) 10Bgerstle: set article imageURL and save image list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432