[00:03:03] (03PS11) 10MaxSem: Claim aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 [00:03:47] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [00:05:02] (03PS1) 10Kaldari: Fix WikiGrok since M.util.query has been removed [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198439 [00:06:59] bmansurov, phuedx: an emergency WikiGrok fix: https://gerrit.wikimedia.org/r/#/c/198439/ [00:07:15] kaldari: oh man i made a similar change [00:07:21] :) [00:07:26] kaldari: https://gerrit.wikimedia.org/r/#/c/198429/ [00:07:31] let me review yours [00:07:51] bmansurov: Yours is probably better. I didn’t bother fixing Roulette. [00:08:14] kaldari: ok, can you review it then? [00:09:02] bmansurov: hmm, it’s a little problematic that it doesn’t maintain the query string in roulette now [00:09:50] kaldari: yes, I agree, any ideas how we can make it better using the existing code? [00:10:12] bmansurov: no, that’s why I didn’t bother ;) I’ll add a comment on your patch… [00:10:19] ok [00:11:37] (03CR) 10Kaldari: [C: 04-1] Replace mw.MobileFrontend.util.query with mw.util.getParamValue (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198429 (https://phabricator.wikimedia.org/T93449) (owner: 10Bmansurov) [00:12:20] (03Abandoned) 10Kaldari: Fix WikiGrok since M.util.query has been removed [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198439 (owner: 10Kaldari) [00:12:52] 6Mobile-Web, 10Wikimedia-Site-requests, 3Roadmap, 7user-notice: Set $wgMFAnonymousEditing = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1137553 (10JKatzWMF) @greg I believe a staggered rollout is preferable (as this will have an unknown impact on edits), but defer to others as... [00:13:22] (03CR) 10Jdlrobson: "The impact of not using mw.deprecate :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198251 (owner: 10Florianschmidtwelzow) [00:15:03] 10Gather, 3Gather Sprint Diplodocus: Add gather-admin security right and allow those users to hide public lists. - https://phabricator.wikimedia.org/T93263#1137561 (10Jdlrobson) @Yurk what's the status of this? [00:15:07] (03PS2) 10Bmansurov: Replace mw.MobileFrontend.util.query with mw.util.getParamValue [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198429 (https://phabricator.wikimedia.org/T93449) [00:15:08] 10Gather, 3Gather Sprint Diplodocus: API: Add gather-admin security right and allow those users to hide public lists. - https://phabricator.wikimedia.org/T93263#1137562 (10Jdlrobson) [00:15:20] kaldari: ^ [00:15:41] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [00:16:26] (03CR) 10Kaldari: [C: 032] Replace mw.MobileFrontend.util.query with mw.util.getParamValue [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198429 (https://phabricator.wikimedia.org/T93449) (owner: 10Bmansurov) [00:19:30] 10Gather, 6MediaWiki-Core-Team: Quick perf review of Gather - https://phabricator.wikimedia.org/T93417#1137567 (10Aklapper) [00:29:09] (03CR) 10Bmansurov: "Gather still uses it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198251 (owner: 10Florianschmidtwelzow) [00:29:46] (03CR) 10Bmansurov: "Also, let's use mw.deprecate from now on." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198251 (owner: 10Florianschmidtwelzow) [00:30:54] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198421 (https://phabricator.wikimedia.org/T92742) (owner: 10Jdlrobson) [00:31:21] 6Mobile-Web, 5Patch-For-Review, 7Wikimedia-log-errors: TemplateParser spewing eval() errors - https://phabricator.wikimedia.org/T93436#1137605 (10kaldari) Looks like it's because Zend doesn't care about the closing PHP tag, but I guess HHVM does. [00:32:34] 6Mobile-Web, 7HHVM, 5Patch-For-Review, 7Wikimedia-log-errors: TemplateParser spewing eval() errors - https://phabricator.wikimedia.org/T93436#1137607 (10Krenair) [00:33:12] kaldari, ewwww [00:33:51] Krenair: Also created https://github.com/zordius/lightncandy/issues/144 [00:34:08] substr on code to put through eval, to get rid of known tags [00:34:58] (03Merged) 10jenkins-bot: Replace mw.MobileFrontend.util.query with mw.util.getParamValue [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198429 (https://phabricator.wikimedia.org/T93449) (owner: 10Bmansurov) [00:35:49] Krenair: This is why I wanted to use pre-compiled templates originally, but Timo didn’t like this idea [00:37:33] Krenair, MaxSem: lol, apparently I shouldn’t put “?>” in a comment :) [00:38:00] bgerstle: Wait, really? [00:38:01] is that the cause? [00:38:16] bgerstle: I got a 403 when I clicked on the link, which wasn't encouraging :-p [00:40:41] kaldari, so you think that Zend does not mind whether you use a closing tag or not, but HHVM disallows it? [00:40:42] 6Mobile-Web, 10Wikimedia-Site-requests, 3Roadmap, 7user-notice: Set $wgMFAnonymousEditing = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1137611 (10Moushira) 1. Do we want a user who clicks edit to go directly to an edit page? Or do we want to use the new feature as an opportuni... [00:41:08] Krenair: possibly. My new patch seems to break it in Zend though :P [00:41:46] hm: http://3v4l.org/1bUBl [00:42:50] hm, maybe it’s not that then [00:43:25] eval( 'echo \'hi\'; ?>' ); seems to work there [00:43:44] that code runs fine for me on mw1001 (hhvm 3.3.1) [00:45:00] Krenair: well, back to square 1 [00:45:05] http://3v4l.org/pOk2j also runs fine [00:45:41] everything breaks if you add yeah, we’re definitely stripping that though [00:47:17] Krenair: I guess I’ll just have to revert the use of TemplateParser in MobileFrontend until I can get to the bottom of this. I strongly suspect it has something to do with HHVM though. [00:47:48] 6Mobile-Web, 10Wikimedia-Site-requests, 3Roadmap, 7user-notice: Set $wgMFAnonymousEditing = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1137626 (10Florian) The problem in activating anonymous editing is, like Jon said on mobile-l[1], that the config var is cache related (it is... [00:48:15] :( [00:51:30] Deskana https://www.dropbox.com/s/ceglrg3p60oqazh/yosemite%20nat%27l%20park%20NO.png?dl=0 [00:51:53] Mhurd sitting down to eat now. How's it going? [00:51:53] (03PS1) 10Bmansurov: Add roulette query string to the next url [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198448 (https://phabricator.wikimedia.org/T93449) [00:52:00] kaldari: ^ [00:53:23] 6Mobile-Web, 10WikiGrok, 5Patch-For-Review: Update WikiGrok not to use MobileFrontend util.query - https://phabricator.wikimedia.org/T93449#1137640 (10bmansurov) 5Open>3Resolved a:3bmansurov [00:53:38] 6Mobile-Web, 7HHVM, 5Patch-For-Review, 7Wikimedia-log-errors: TemplateParser spewing eval() errors - https://phabricator.wikimedia.org/T93436#1137642 (10kaldari) Nevermind, looks like HHVM doesn't care about it either. Hmmm. [00:55:07] (03PS1) 10Bmansurov: WIP: Alpha experiment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198450 [00:57:29] (03PS2) 10Robmoen: List creation and editing validation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 [00:58:32] (03CR) 10jenkins-bot: [V: 04-1] WIP: Alpha experiment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198450 (owner: 10Bmansurov) [01:01:07] bgerstle: Uh, yes, that makes sense. [01:01:17] bgerstle: It's definitely a lead image, that's true. [01:01:52] bgerstle: in the weeds :) [01:02:00] bgerstle: testing quick fix [01:11:37] 10Wikipedia-App-iOS-App: Image viewer image for lead image in "List of diplomatic missions in Russia" throws a 414 error - https://phabricator.wikimedia.org/T93462#1137666 (10dr0ptp4kt) 3NEW [01:12:02] 10Wikipedia-App-iOS-App: Image viewer image for lead image in "List of diplomatic missions in Russia" throws a 414 error - https://phabricator.wikimedia.org/T93462#1137674 (10dr0ptp4kt) p:5Triage>3Low [01:22:28] (03CR) 10Florianschmidtwelzow: "-> https://www.mediawiki.org/wiki/Mobile_web/Coding_conventions#Code_deprecation (as a start) :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198251 (owner: 10Florianschmidtwelzow) [01:33:55] 6Mobile-Web, 10Wikimedia-Site-requests, 3Roadmap, 7user-notice: Set $wgMFAnonymousEditing = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1137685 (10greg) a:3Jdlrobson >>! In T93210#1137626, @Florian wrote: > The problem in activating anonymous editing is, like Jon said on mobi... [01:39:30] 6Mobile-Web, 10Wikimedia-Site-requests, 3Roadmap, 7user-notice: Set $wgMFAnonymousEditing = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1137696 (10Jdlrobson) It's not just config changes it is probably php/js changes too. In terms of my time you'll have to okay that with @JKat... [01:42:41] 6Mobile-Web, 10Wikimedia-Site-requests, 3Roadmap, 7user-notice: Set $wgMFAnonymousEditing = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1137697 (10Jdlrobson) a:5Jdlrobson>3None I don't want to give the false impression I'm doing this yet. I'm super swamped with work right now. [01:46:53] 6Mobile-Web, 10Wikimedia-Site-requests, 3Roadmap, 7user-notice: Set $wgMFAnonymousEditing = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1132138 (10greg) >>! In T93210#1137696, @Jdlrobson wrote: > It's not just config changes it is probably php/js changes too. > > In terms of m... [01:49:53] 6Mobile-Web, 10Wikimedia-Site-requests, 3Roadmap, 7user-notice: Set $wgMFAnonymousEditing = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1137701 (10Jdlrobson) Thanks @greg April - June seems much more realistic. Also I echo @Moushira particularly 1. Would be great if @jaredzimm... [01:51:33] mhurd back after dinner. can i help w/ anything? [01:51:45] bgerstle: quick hangout? [01:52:20] mhurd sure [01:52:47] 6Mobile-Web, 10Wikimedia-Site-requests, 3Roadmap, 7user-notice: Set $wgMFAnonymousEditing = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1137703 (10Jdlrobson) Mmm.. Also looks buggy just tried to get past through the first screen on Italian Wikipedia and couldn't do it on my nex... [01:56:06] (03CR) 10Bmansurov: "Follow up: https://gerrit.wikimedia.org/r/#/c/198448/" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198429 (https://phabricator.wikimedia.org/T93449) (owner: 10Bmansurov) [02:15:44] (03PS5) 10Mhurd: set article imageURL and save image list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 (owner: 10Bgerstle) [02:16:00] (03PS6) 10Mhurd: set article imageURL and save image list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 (owner: 10Bgerstle) [02:21:46] coreyfloyd: i think i got it working: https://gerrit.wikimedia.org/r/#/c/198432/ [02:22:06] coreyfloyd: brian’s gonna test it out this weekend and maybe write some unit tests [02:22:35] coreyfloyd: if you have time to put it through it’s paces as well that would be awesome [02:22:52] *its* haha [02:24:06] Yeah I'll give it a spin. What worked? [02:24:35] mhurd: ^ [02:27:02] coreyfloyd: what we talked about worked. pulling the article save out of the loop. [02:27:21] coreyfloyd: images.plist seems to get updated properly as far as i can tell [02:28:33] ok - thats cool - just looked though it - seems straight forward [02:28:36] will give a spin [02:31:07] mhurd: you should upload your documents folder and the resulting data folder to the ticket [02:31:34] just so we have an example input and output data [02:31:35] coreyfloyd: ah. good idea [02:32:43] mhurd: do we know why there are still repeats for the images (it looks like the lead image is the only one repeated) [02:33:19] coreyfloyd: not 100% sure [02:33:38] mhurd: yeah the lead image gets repeated exactly 5 times for each article [02:33:47] at least that is a repeatable bug [02:34:19] mhurd: so all looks good to me. [02:34:22] coreyfloyd: it could be related to the “article.images is doubling up - never getting reset (on refresh)” bug from earlier [02:34:30] yeah [02:34:32] coreyfloyd: i’ll work on that one tomorrow a bit [02:34:42] mhurd: no you must take a day off [02:34:52] coreyfloyd: haha ok sunday [02:34:58] coreyfloyd: or monday [02:35:12] mhurd: yeah get some angry rock climbing in [02:35:21] mhurd: good work on this [02:35:22] coreyfloyd: lol will do [02:35:26] coreyfloyd: thanks! [02:35:40] coreyfloyd: thanks for the help!! [02:35:41] :) [02:36:02] mhurd: np - im back to assembling my new desk… enjoy the weekend [02:36:12] coreyfloyd: yay! [02:36:18] coreyfloyd: see ya! [02:36:28] later [05:54:26] (03Restored) 10Deskana: DO NOT MERGE - Wikidata description editing prototype [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197733 (owner: 10Deskana) [05:54:33] (03PS2) 10Deskana: DO NOT MERGE - Wikidata description editing prototype [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197733 [05:57:21] (03CR) 10jenkins-bot: [V: 04-1] DO NOT MERGE - Wikidata description editing prototype [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197733 (owner: 10Deskana) [06:18:01] (03CR) 10Krinkle: "https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/8134/console" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198421 (https://phabricator.wikimedia.org/T92742) (owner: 10Jdlrobson) [06:27:23] (03PS6) 10Krinkle: Remove dependency on mobile.templates where hogan is used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 [06:30:54] (03CR) 10jenkins-bot: [V: 04-1] Remove dependency on mobile.templates where hogan is used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [13:15:48] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1138097 (10NiharikaKohli) We're holding an IRC meeting on [March 25, at 1700 UTC](http://www.timeanddate.com/... [17:02:17] (03PS9) 10Sumit: MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) [17:02:36] (03CR) 10jenkins-bot: [V: 04-1] MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [17:04:01] (03PS10) 10Sumit: MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) [17:05:58] 10MobileFrontend-Feature-requests, 7Mobile: MobileFrontend doesn't do URL updating for redirects - https://phabricator.wikimedia.org/T93262#1138207 (10matmarex) 'mediawiki.action.view.redirect' would need a mobile target, for starters. Dunno if it will work correctly if we do just that. [18:03:54] 10Wikipedia-App-Android-App: EGL-related crashes - https://phabricator.wikimedia.org/T74530#1138258 (10Krenair) [19:00:39] Deskana|Away, bearND|bbl: Do you know, what he means? https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8220808&OTRSAgentInterface=10cf918c6f5b5d82905aae2a61911c81de :? [19:13:42] (03CR) 10Florianschmidtwelzow: [C: 04-1] MediaViewer image description trimmed (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [19:58:46] FlorianSW: not sure what he means either. Is he talking about the version number or the functionality? [19:59:14] i think he means the version numbers, but i don't know any "beta channel"? [20:01:00] (03PS11) 10Sumit: MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) [20:11:07] FlorianSW: The version numbers include the channel name (alpha, beta, r for production release) ). So, the version strings will always be different. You could see the channel as a type of release, but I think the name comes more from the value we set in the User Agent to help distinguish those releases for analytics purposes [20:12:53] bearND: ok, i will ask him, what exactly he means (maybe he mean that :)) :) Thanks for your answer! [20:13:20] FlorianSW: thanks [20:19:14] FlorianSW: How do you reply to a note (Notiz) in OTRS? E.g. in https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8221887;ArticleID=9752551;ZoomExpand=1 I want to reply to your latest note. [20:20:10] bearND: just click "Notitz" or "Note" (depends on your interface language) :) [20:20:35] FlorianSW: But how do you set the To: field of the note? [20:20:59] FlorianSW: you sent one to me [20:21:39] bearND: really? I just clicked "Notitz" and type my note :) I haven't filled out any other fields in this form :D [20:21:52] FlorianSW: ah, ok [20:22:02] bearND: ah, it's because you're the owner :) [20:22:12] FlorianSW: I see [20:23:21] FlorianSW: ok, just wanted to mention to you that he was using the production app. As I mentioned earlier you can see that in the version string (r=production) [20:23:59] FlorianSW: The beta has made some changes there, and that code should be rolled out at the end of this month to production. [20:25:35] ah, ok :) [20:33:31] I think I am going to work on those AbuseFilter-related crashes [20:33:47] Have you guys gone any testing about how the app behaves when it hits one of those errors? [20:34:34] 10Wikipedia-App-Android-App: EGL-related crashes - https://phabricator.wikimedia.org/T74530#1138396 (10Krenair) [20:39:46] Krenair: you mean Android? We've got an automated test for that: TriggerAbuseFilterTest. [20:40:03] yeah but it's still not working and causing crashes [20:40:13] I've seen at least two recently but hadn't yet got around to debugging it [20:40:27] Krenair: Would you like to check if the scenario you ran into is covered? Which abuse filter is triggered? [20:41:00] https://en.wikipedia.org/wiki/Special:AbuseFilter/636 was the cause in both cases [20:45:22] Krenair: We probably should add more testing there. Would you mind filing a Phab task with the link to the abuse filter? [20:46:15] Am trying to see if I can build the current master and load it on my phone first [20:48:44] Failed to set up Android modules in project 'WikipediaAndroid': Unsupported method: BaseArtifact.getJavaCompileTaskName(). [20:48:44] The version of Gradle you connect to does not support that method. [20:48:44] To resolve the problem you can change/upgrade the target version of Gradle you connect to. [20:48:45] hm [20:49:06] bearND ? [20:50:16] Krenair: what's your Android Studio version? [20:50:27] I've got 1.1.0 [20:50:47] 0.8.6 :/ [20:51:13] Krenair: a ton has changed since then. I guess you know what to do [20:51:27] yeah.. :) [21:11:41] bearND, if I can't fix it I'll create a task [21:11:50] But commits that fix things are better than tasks [21:14:22] (03CR) 10Florianschmidtwelzow: [C: 032] "Thanks! :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [21:14:32] 6Mobile-Web, 5Patch-For-Review: Trim image descriptions - https://phabricator.wikimedia.org/T92053#1138465 (10Florian) 5Open>3Resolved a:3Florian [21:15:15] 6Mobile-Web, 5Patch-For-Review: Trim image descriptions - https://phabricator.wikimedia.org/T92053#1102460 (10Florian) a:5Florian>3Sumit [21:18:16] (03CR) 10jenkins-bot: [V: 04-1] MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [21:27:42] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [22:09:10] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Flow, 6Mobile-Apps: Flow is broken on the mobile app - https://phabricator.wikimedia.org/T73754#1138584 (10Amire80) [22:57:49] 6Mobile-Web, 7Easy: Special:History on the desktop shows repeated user icon - https://phabricator.wikimedia.org/T93495#1138658 (10Amire80) 3NEW [22:58:35] (03PS1) 10Amire80: Add background-repeat: no-repeat for SpecialHistory on the desktop [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198536 (https://phabricator.wikimedia.org/T93495) [23:00:32] (03CR) 10jenkins-bot: [V: 04-1] Add background-repeat: no-repeat for SpecialHistory on the desktop [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198536 (https://phabricator.wikimedia.org/T93495) (owner: 10Amire80) [23:05:40] (03CR) 10Amire80: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198536 (https://phabricator.wikimedia.org/T93495) (owner: 10Amire80)