[00:42:32] (03PS1) 10Yurik: API Unittests and bugfixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198667 [01:35:48] 6Mobile-Web, 7HHVM, 5Patch-For-Review, 7Wikimedia-log-errors: TemplateParser spewing eval() errors - https://phabricator.wikimedia.org/T93436#1139768 (10Legoktm) I updated https://gerrit.wikimedia.org/r/198658 with a fix + tests. [01:40:45] 10MobileFrontend-Feature-requests: Mobile Beta completely blocks TOC on talk pages - https://phabricator.wikimedia.org/T93551#1139769 (10Thnidu) 3NEW [01:42:56] 6Mobile-Web, 10MediaWiki-Unit-tests: Make unit tests to check that our server-side mustache templates can be compiled without blowing up - https://phabricator.wikimedia.org/T93445#1139777 (10Legoktm) AFAICT there's no registry of server-side templates right? So it would just be a recursive directory iterator l... [01:54:44] (03CR) 10Legoktm: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198607 (owner: 10L10n-bot) [01:54:54] 6Mobile-Web, 7HHVM, 5Patch-For-Review, 7Wikimedia-log-errors: TemplateParser spewing eval() errors - https://phabricator.wikimedia.org/T93436#1139781 (10Krinkle) 5Open>3Resolved [01:55:13] (03CR) 10Krinkle: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198536 (https://phabricator.wikimedia.org/T93495) (owner: 10Amire80) [01:55:53] (03CR) 10Legoktm: [C: 032] Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198607 (owner: 10L10n-bot) [01:59:25] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198607 (owner: 10L10n-bot) [03:03:18] (03PS1) 10Deskana: Don't crash when the AbuseFilter emits an arbitrary error code. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198676 (https://phabricator.wikimedia.org/T93539) [03:03:55] 10Wikipedia-App-Android-App, 5Patch-For-Review: RuntimeException: Unknown abusefilter response! from editing.AbuseFilterEditResult.getType - https://phabricator.wikimedia.org/T93539#1139835 (10Deskana) a:3Deskana [03:04:04] 10Wikipedia-App-Android-App, 5Patch-For-Review: RuntimeException: Unknown abusefilter response! from editing.AbuseFilterEditResult.getType - https://phabricator.wikimedia.org/T93539#1139531 (10Deskana) p:5Triage>3Normal [03:04:21] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android, 5Patch-For-Review: RuntimeException: Unknown abusefilter response! from editing.AbuseFilterEditResult.getType - https://phabricator.wikimedia.org/T93539#1139531 (10Deskana) [03:05:28] (03CR) 10Alex Monk: "This doesn't appear to provide any mechanism to show the custom warning to the user?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198676 (https://phabricator.wikimedia.org/T93539) (owner: 10Deskana) [03:17:59] (03CR) 10Deskana: "Alex: That's correct. Showing the custom warning in the app is next to impossible due to the AbuseFilter API returning arbitrary HTML as t" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198676 (https://phabricator.wikimedia.org/T93539) (owner: 10Deskana) [03:25:03] (03CR) 10Alex Monk: "I don't think there's a lot of improvement that can be made on the AbuseFilter side of that. It's not just the API, AbuseFilter must deal " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198676 (https://phabricator.wikimedia.org/T93539) (owner: 10Deskana) [03:31:09] 10Gather: Placeholder: A user is able to reorder the collections in their list from the edit screen - https://phabricator.wikimedia.org/T93164#1139860 (10JKatzWMF) Thanks @Krenair. Just added. [03:35:50] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android, 5Patch-For-Review: RuntimeException: Unknown abusefilter response! from editing.AbuseFilterEditResult.getType - https://phabricator.wikimedia.org/T93539#1139862 (10Deskana) I've verified that this doesn't cause the iOS app to crash, but the app does... [03:40:02] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Article reader sees message/guidance about creating a collection so that they know the feature exists and the entry point - https://phabricator.wikimedia.org/T91015#1139866 (10JKatzWMF) @rmoen, @jhernandez, how do i test this/trigger? [03:43:39] 3Gather Sprint Diplodocus, 5Patch-For-Review: Can't access public collections on beta labs - https://phabricator.wikimedia.org/T93222#1139868 (10JKatzWMF) I opened private window, went to url above, then changed setting to beta/alpha and I am seeing the page below: {F102910} [03:45:51] (03PS2) 10Alex Monk: Add background-repeat: no-repeat for SpecialHistory on the desktop [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198536 (https://phabricator.wikimedia.org/T93495) (owner: 10Amire80) [03:49:40] (03CR) 10jenkins-bot: [V: 04-1] Add background-repeat: no-repeat for SpecialHistory on the desktop [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198536 (https://phabricator.wikimedia.org/T93495) (owner: 10Amire80) [05:59:48] 6Mobile-Web, 10Continuous-Integration, 10MediaWiki-General-or-Unknown, 5Patch-For-Review: MobileFrontend commits fail in qunit in Jenkins - https://phabricator.wikimedia.org/T93511#1139927 (10Amire80) Could this failure in ContentTranslation also be related? - https://gerrit.wikimedia.org/r/#/c/198187/ [06:12:05] (03PS1) 10Krinkle: user: Update sessionId test to match updated length in MediaWiki core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198690 [06:16:22] 10MobileFrontend-Feature-requests, 7Tracking: [Tracking] Obstacles to enable anonymous editing for MobileFrontend users - https://phabricator.wikimedia.org/T55069#1139937 (10Nemo_bis) [06:17:18] 10MobileFrontend-Feature-requests, 7Tracking: [Tracking] Obstacles to enable anonymous editing for MobileFrontend users - https://phabricator.wikimedia.org/T55069#569273 (10Nemo_bis) [06:17:20] 6Mobile-Web, 10Wikimedia-Site-requests, 3Roadmap, 7user-notice: Set $wgMFAnonymousEditing = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1132138 (10Nemo_bis) [06:21:36] (03CR) 10Krinkle: "There's another failing test behind that one, fixed in I951f0b8720de20." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198536 (https://phabricator.wikimedia.org/T93495) (owner: 10Amire80) [06:28:39] 6Mobile-Web, 10Wikimedia-Site-requests, 3Roadmap, 7user-notice: Set $wgMFAnonymousEditing = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1139964 (10Nemo_bis) a:3Nemo_bis >>! In T93210#1137703, @Jdlrobson wrote: > Mmm.. Also looks buggy just tried to get past through the first... [07:22:34] 6Mobile-Web, 10Wikimedia-Site-requests, 5Patch-For-Review, 3Roadmap, 7user-notice: Set $wgMFAnonymousEditing = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1139995 (10Nemo_bis) Added the gerrit link to https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=prev&oldi... [09:21:50] good morning [09:28:01] 6Mobile-Web, 10Flow: the "All" tab on MobileFrontend watchlist shows Flow gibberish topic ID links - https://phabricator.wikimedia.org/T93565#1140108 (10Amire80) [09:28:55] 6Mobile-Web, 10Flow: the "All" tab on MobileFrontend watchlist shows Flow gibberish topic ID links - https://phabricator.wikimedia.org/T93565#1140094 (10Amire80) [09:28:56] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Tracking: Flow issues on mobile web (tracking) - https://phabricator.wikimedia.org/T93430#1140113 (10Amire80) [09:42:17] 10MobileFrontend-Feature-requests, 10Wikidata, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1140132 (10Qgil) @Sumit, thank you for this project proposal. Have you got a chance to complete one or more microtasks? I am not the right p... [09:44:37] 6Mobile-Web, 10Flow: the "All" tab on MobileFrontend watchlist shows Flow gibberish topic ID links - https://phabricator.wikimedia.org/T93565#1140136 (10Amire80) Come to think of it, ideally the notifications for Flow on mobile should be so good that a watchlist for talk pages shouldn't be needed at all :) [09:49:31] (03CR) 10Florianschmidtwelzow: [C: 032] user: Update sessionId test to match updated length in MediaWiki core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198690 (owner: 10Krinkle) [09:50:39] 6Mobile-Web: MobileFrontend shouldn't check sessionid length in qunit tests - https://phabricator.wikimedia.org/T93569#1140166 (10Florian) 3NEW [09:52:32] (03Merged) 10jenkins-bot: user: Update sessionId test to match updated length in MediaWiki core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198690 (owner: 10Krinkle) [09:52:42] (03PS3) 10Florianschmidtwelzow: Add background-repeat: no-repeat for SpecialHistory on the desktop [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198536 (https://phabricator.wikimedia.org/T93495) (owner: 10Amire80) [09:52:58] (03PS2) 10Florianschmidtwelzow: Hygiene: Stub all Api calls in qunit test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198660 [09:53:03] (03PS12) 10Florianschmidtwelzow: MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [09:53:06] (03PS2) 10Florianschmidtwelzow: word-break: normal in page headings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198548 (owner: 10Amire80) [09:53:08] (03PS2) 10Florianschmidtwelzow: Show namespace in the Special:MobileLanguages header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198540 (owner: 10Alex Monk) [09:53:25] (03PS7) 10Florianschmidtwelzow: Remove dependency on mobile.templates where hogan is used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [09:53:27] (03PS2) 10Florianschmidtwelzow: WIP: Alpha experiment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198450 (owner: 10Bmansurov) [09:53:29] (03PS5) 10Florianschmidtwelzow: Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) [09:56:38] (03CR) 10Florianschmidtwelzow: "See also:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198690 (owner: 10Krinkle) [09:56:57] (03CR) 10jenkins-bot: [V: 04-1] word-break: normal in page headings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198548 (owner: 10Amire80) [09:57:06] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Stub all Api calls in qunit test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198660 (owner: 10Florianschmidtwelzow) [09:59:15] (03CR) 10jenkins-bot: [V: 04-1] Show namespace in the Special:MobileLanguages header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198540 (owner: 10Alex Monk) [09:59:38] (03CR) 10Florianschmidtwelzow: [C: 032] Add background-repeat: no-repeat for SpecialHistory on the desktop [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198536 (https://phabricator.wikimedia.org/T93495) (owner: 10Amire80) [10:00:05] (03CR) 10Florianschmidtwelzow: MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [10:00:42] (03CR) 10jenkins-bot: [V: 04-1] Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [10:00:45] (03CR) 10Florianschmidtwelzow: [C: 032] "do your thing, jenkins :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [10:00:47] (03CR) 10jenkins-bot: [V: 04-1] WIP: Alpha experiment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198450 (owner: 10Bmansurov) [10:01:37] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198548 (owner: 10Amire80) [10:01:39] (03CR) 10jenkins-bot: [V: 04-1] Add background-repeat: no-repeat for SpecialHistory on the desktop [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198536 (https://phabricator.wikimedia.org/T93495) (owner: 10Amire80) [10:02:38] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198540 (owner: 10Alex Monk) [10:02:57] (03Merged) 10jenkins-bot: MediaViewer image description trimmed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/196576 (https://phabricator.wikimedia.org/T92053) (owner: 10Sumit) [10:03:57] 6Mobile-Web: Trim image descriptions - https://phabricator.wikimedia.org/T92053#1140184 (10Sumit) 5Open>3Resolved [10:04:44] (03PS6) 10Florianschmidtwelzow: Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) [10:05:12] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198540 (owner: 10Alex Monk) [10:06:41] (03CR) 10jenkins-bot: [V: 04-1] Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [10:07:20] 6Mobile-Web: MobileFrontend shouldn't check sessionid length in qunit tests - https://phabricator.wikimedia.org/T93569#1140190 (10Florian) a:3Florian [10:15:44] (03CR) 10Florianschmidtwelzow: [C: 032] Show namespace in the Special:MobileLanguages header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198540 (owner: 10Alex Monk) [10:17:53] (03Merged) 10jenkins-bot: Show namespace in the Special:MobileLanguages header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198540 (owner: 10Alex Monk) [10:18:48] (03PS1) 10Florianschmidtwelzow: Hygiene: Don't check sessionid length [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198698 [10:19:08] (03PS2) 10Florianschmidtwelzow: Hygiene: Don't check sessionid length [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198698 (https://phabricator.wikimedia.org/T93569) [10:33:14] 6Mobile-Web, 6Mobile-Apps, 7Mobile, 7notice, 7user-notice: Creating Newsletter for mobile - https://phabricator.wikimedia.org/T93529#1140235 (10Qgil) > Should it sync with Technews Ideally, every piece of tech news should sync with Tech News. [10:56:50] joakino, around? [10:57:07] yep [10:57:08] hi yurik [10:57:12] hey )) [10:57:16] want to merge something? [10:57:30] joakino, https://gerrit.wikimedia.org/r/#/c/198667/ [10:57:38] i don't want to mix it with the next patch [10:57:52] that one doesn't change functionality, only fixes tons of minor bugs [10:58:08] let me have a look [10:58:16] thx [11:13:56] yurik: looks fine, and I think it fixed the breaking browser tests [11:14:01] let me run them and i'll merge [11:14:08] sure [11:14:11] thx [11:23:53] (03CR) 10Yurik: Admin can hide a public list in Special:GatherLists (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [11:36:30] (03CR) 10Jhernandez: [C: 032] "Also fixes the broken browser tests" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198667 (owner: 10Yurik) [11:38:28] (03Merged) 10jenkins-bot: API Unittests and bugfixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198667 (owner: 10Yurik) [12:14:55] (03CR) 10Hoo man: [C: 031] "Looks ok to me to do it like this and the code also looks ok, but I have not enough knowledge about the code base to approve." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198676 (https://phabricator.wikimedia.org/T93539) (owner: 10Deskana) [12:39:24] gtg docto4 [12:39:27] doctor [14:28:44] 6Mobile-Web, 6Mobile-Apps, 7Mobile, 7notice, 7user-notice: Creating Newsletter for mobile - https://phabricator.wikimedia.org/T93529#1140537 (10Moushira) @ Qgil, so you are suggesting this grows as a mobile section of Tech News? [14:49:32] 6Mobile-Web, 6Mobile-Apps, 7Mobile, 7user-notice: Creating Newsletter for mobile - https://phabricator.wikimedia.org/T93529#1140580 (10gpaumier) [14:56:34] 6Mobile-Web, 6Mobile-Apps, 7Mobile, 7user-notice: Creating Newsletter for mobile - https://phabricator.wikimedia.org/T93529#1140589 (10Qgil) You could start making sure that Mobile tech news are featured in Tech News, and then analyze whether you need something bigger separate. [15:11:28] (03CR) 10Dbrant: [C: 032] Hygiene: Add @NonNull annotation to two methods in LanguagePreference [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198384 (owner: 10Deskana) [15:14:09] (03PS1) 10Aude: Don't say "MobileFrontend Infobox alpha edit" for Wikidata description edits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198732 [15:16:20] (03PS1) 10Aude: "View on WikiData" => "View on Wikidata", not camel case [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198734 [15:17:00] (03CR) 10jenkins-bot: [V: 04-1] Don't say "MobileFrontend Infobox alpha edit" for Wikidata description edits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198732 (owner: 10Aude) [15:18:21] seems qunit tests are broken and seems unrelated [15:18:41] (03CR) 10Dbrant: [C: 04-1] Don't crash when the AbuseFilter emits an arbitrary error code. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198676 (https://phabricator.wikimedia.org/T93539) (owner: 10Deskana) [15:19:41] (03CR) 10jenkins-bot: [V: 04-1] "View on WikiData" => "View on Wikidata", not camel case [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198734 (owner: 10Aude) [15:20:21] (03CR) 10Aude: "i don't see how the qunit tests are at all related to this patch." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198732 (owner: 10Aude) [15:24:17] (03PS1) 10Aude: Remove "short sentence" from wikidata description i18n message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198735 [15:26:12] (03CR) 10jenkins-bot: [V: 04-1] Remove "short sentence" from wikidata description i18n message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198735 (owner: 10Aude) [15:26:41] (03PS2) 10Deskana: Don't crash when the AbuseFilter emits an arbitrary error code. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198676 (https://phabricator.wikimedia.org/T93539) [15:28:15] (03CR) 10Deskana: "@DBrant: Done. I kept it as a separate clause, as they are functionally different cases, and we probably want to try to do some detection " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198676 (https://phabricator.wikimedia.org/T93539) (owner: 10Deskana) [15:37:41] (03CR) 10BearND: [C: 04-1] "I'd love to see a test added to TriggerAbuseFilterTest. What are the steps to reproduce on testwiki?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198676 (https://phabricator.wikimedia.org/T93539) (owner: 10Deskana) [15:48:16] (03PS1) 10Dbrant: Don't load Main Page from cache, except on screen rotation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198739 (https://phabricator.wikimedia.org/T93356) [15:48:21] phuedx 2 weeks of jury duty! That's intense... [15:58:49] (03CR) 10BearND: Don't load Main Page from cache, except on screen rotation. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198739 (https://phabricator.wikimedia.org/T93356) (owner: 10Dbrant) [16:08:16] (03PS2) 10Dbrant: Don't load Main Page from cache, except on screen rotation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198739 (https://phabricator.wikimedia.org/T93356) [16:15:59] (03CR) 10BearND: [C: 032] Don't load Main Page from cache, except on screen rotation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198739 (https://phabricator.wikimedia.org/T93356) (owner: 10Dbrant) [16:16:20] (03Merged) 10jenkins-bot: Don't load Main Page from cache, except on screen rotation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198739 (https://phabricator.wikimedia.org/T93356) (owner: 10Dbrant) [16:18:05] (03PS2) 10Hoo man: Don't say "MobileFrontend Infobox alpha edit" for Wikidata description edits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198732 (owner: 10Aude) [16:18:20] (03CR) 10Hoo man: "Qunit failures have been fixed on master." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198732 (owner: 10Aude) [16:18:29] (03PS2) 10Hoo man: "View on WikiData" => "View on Wikidata", not camel case [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198734 (owner: 10Aude) [16:19:38] 6Mobile-Web, 6Phabricator, 6Project-Creators: MobileFrontend needs a generic component - https://phabricator.wikimedia.org/T91373#1141402 (10chasemp) 5Open>3stalled [16:19:44] 6Mobile-Web, 6Phabricator, 6Project-Creators: MobileFrontend needs a generic component - https://phabricator.wikimedia.org/T91373#1081272 (10chasemp) p:5Triage>3Normal [16:20:07] (03CR) 10Hoo man: Don't say "MobileFrontend Infobox alpha edit" for Wikidata description edits (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198732 (owner: 10Aude) [16:20:36] (03CR) 10jenkins-bot: [V: 04-1] Don't say "MobileFrontend Infobox alpha edit" for Wikidata description edits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198732 (owner: 10Aude) [16:21:45] (03PS3) 10Aude: Don't say "MobileFrontend Infobox alpha edit" for Wikidata description edits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198732 [16:22:21] (03CR) 10Aude: Don't say "MobileFrontend Infobox alpha edit" for Wikidata description edits (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198732 (owner: 10Aude) [16:23:47] (03CR) 10jenkins-bot: [V: 04-1] Don't say "MobileFrontend Infobox alpha edit" for Wikidata description edits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198732 (owner: 10Aude) [16:27:23] (03CR) 10Deskana: "The abuse filter that I set up for this is triggered if you add the string "appcrashtest" to a page on testwiki." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198676 (https://phabricator.wikimedia.org/T93539) (owner: 10Deskana) [16:39:36] (03PS3) 10Florianschmidtwelzow: "View on WikiData" => "View on Wikidata", not camel case [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198734 (owner: 10Aude) [16:39:57] (03PS2) 10Florianschmidtwelzow: Remove "short sentence" from wikidata description i18n message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198735 (owner: 10Aude) [16:41:22] (03CR) 10Kaldari: [C: 032] "View on WikiData" => "View on Wikidata", not camel case [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198734 (owner: 10Aude) [16:41:44] (03CR) 10jenkins-bot: [V: 04-1] "View on WikiData" => "View on Wikidata", not camel case [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198734 (owner: 10Aude) [16:42:17] (03CR) 10Florianschmidtwelzow: [C: 032] Remove "short sentence" from wikidata description i18n message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198735 (owner: 10Aude) [16:44:19] (03CR) 10Florianschmidtwelzow: [C: 032] Don't say "MobileFrontend Infobox alpha edit" for Wikidata description edits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198732 (owner: 10Aude) [16:44:53] (03CR) 10Hoo man: [C: 031] Hygiene: Don't check sessionid length [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198698 (https://phabricator.wikimedia.org/T93569) (owner: 10Florianschmidtwelzow) [16:45:31] phuedx: can you look at this ^ change please? :) [16:47:02] (03Merged) 10jenkins-bot: Don't say "MobileFrontend Infobox alpha edit" for Wikidata description edits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198732 (owner: 10Aude) [16:47:04] (03CR) 10jenkins-bot: [V: 04-1] "View on WikiData" => "View on Wikidata", not camel case [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198734 (owner: 10Aude) [16:47:06] (03CR) 10jenkins-bot: [V: 04-1] Remove "short sentence" from wikidata description i18n message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198735 (owner: 10Aude) [16:48:33] (03CR) 10BearND: "@Deskana: thank you for setting up the filter" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198676 (https://phabricator.wikimedia.org/T93539) (owner: 10Deskana) [17:00:57] (03CR) 10Deskana: [C: 04-1] "@BearND: That's strange. Not only did I never see that exception myself during my testing, but it's not even coming from the code I change" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198676 (https://phabricator.wikimedia.org/T93539) (owner: 10Deskana) [17:01:44] o/ [17:02:23] (03CR) 10BearND: "@Deskana All it needs is to change DoEditTask:65 to just check for edit.has("code")" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198676 (https://phabricator.wikimedia.org/T93539) (owner: 10Deskana) [17:04:55] 6Mobile-Web, 10Wikimedia-Site-requests, 5Patch-For-Review, 3Roadmap, 7user-notice: Set $wgMFAnonymousEditing = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1141597 (10Florian) >>! In T93210#1139964, @Nemo_bis wrote: > As we want a staggered release, there might be no urgent ne... [17:06:05] hi jdlrobson :) [17:06:15] 10Gather, 3Gather Sprint Diplodocus: Deprecated M.query breaking Gather - https://phabricator.wikimedia.org/T93508#1141611 (10Jdlrobson) a:3Jdlrobson [17:06:33] hey FlorianSW :D [17:06:51] how are you? (yeah, i want something from you :P) [17:10:22] (03PS1) 10Jdlrobson: Regression: address upstream change [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198752 [17:10:33] FlorianSW: i'm good what do you need? [17:10:55] can you take a look at https://gerrit.wikimedia.org/r/#/c/198698/2 ?? i'm wondering if this would solve our merge problems :/ [17:10:57] ^ joakino rmoen can you +2 that so we can fix browser tests? [17:11:03] > https://gerrit.wikimedia.org/r/198752 < this [17:11:10] FlorianSW: taking a look [17:11:23] why does this impact merge problems? [17:11:40] jdlrobson: sure [17:11:51] jdlrobson: i thought they were good [17:11:52] gr [17:12:08] FlorianSW: it's testing a different thing now.. [17:12:09] because the sessionid changed from 32 to 16 bits, i've merged the change by krinkle (which changed it), but it seems, that jenkins sometimes use 32 and sometimes 16 bits to check :( [17:12:14] https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/ < joakino [17:12:28] (03CR) 10Jhernandez: [C: 032] Regression: address upstream change [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198752 (owner: 10Jdlrobson) [17:12:29] jdlrobson: right :) the length of the sessionid is checked in mediawiki core now [17:12:38] FlorianSW: you'd be better dropping the test altogether [17:12:43] we shouldn't be testing localStorage here [17:12:54] FlorianSW: phuedx wrote this i think [17:13:03] so would be good to get his opinion but i say just drop the test case [17:13:42] jdlrobson: ok, i thought about it, but if you're ok with it :) [17:13:59] (03CR) 10Jdlrobson: [C: 04-1] "The newly introduced test tests something different so i would suggest removing it. Will delegate to phuedx he can override my -1 with a +" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198698 (https://phabricator.wikimedia.org/T93569) (owner: 10Florianschmidtwelzow) [17:14:06] i'll upload a new ps and add phuedx as a reviewer :) [17:14:08] ^ FlorianSW will let phuedx decide :) [17:14:13] :P [17:14:19] just a query, does MF have a documentation of a general workflow of its templates and js? [17:14:30] jdlrobson: btw, i got free on 22 May :D [17:14:31] FlorianSW: did your managers get back yet? are you getting excited about lyon? [17:14:34] yay! :D [17:14:49] codezee: run make docs in MF directory [17:15:10] FlorianSW: ok, will do [17:15:18] jdlrobson: can't wait anymore (again this year :D) [17:15:24] (03CR) 10Krinkle: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198536 (https://phabricator.wikimedia.org/T93495) (owner: 10Amire80) [17:15:34] (03CR) 10Krinkle: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198660 (owner: 10Florianschmidtwelzow) [17:15:35] 10Gather, 3Gather Sprint Diplodocus: Deprecated M.query breaking Gather - https://phabricator.wikimedia.org/T93508#1141632 (10Jdlrobson) Whoops forgot to add bug - https://gerrit.wikimedia.org/r/#/c/198752/ [17:17:42] (03PS2) 10Jdlrobson: Regression: address upstream change [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198752 (https://phabricator.wikimedia.org/T93508) [17:17:58] (03PS3) 10Jdlrobson: Regression: address upstream change [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198752 (https://phabricator.wikimedia.org/T93508) [17:18:05] (03CR) 10Jdlrobson: [C: 032] Regression: address upstream change [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198752 (https://phabricator.wikimedia.org/T93508) (owner: 10Jdlrobson) [17:18:13] (03CR) 10Florianschmidtwelzow: [C: 031] Regression: address upstream change [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198752 (https://phabricator.wikimedia.org/T93508) (owner: 10Jdlrobson) [17:18:35] (03CR) 10Florianschmidtwelzow: Add background-repeat: no-repeat for SpecialHistory on the desktop [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198536 (https://phabricator.wikimedia.org/T93495) (owner: 10Amire80) [17:18:40] (03CR) 10Florianschmidtwelzow: [C: 032] Add background-repeat: no-repeat for SpecialHistory on the desktop [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198536 (https://phabricator.wikimedia.org/T93495) (owner: 10Amire80) [17:19:06] FlorianSW: fwiw this was my biggest concern about splitting up MobileFrontend into multiple extensions. we'll have to be more careful with deprecation now :-/\ [17:20:02] 6Mobile-Web, 10WikiGrok: Aggregation results - https://phabricator.wikimedia.org/T93383#1141681 (10Maryana) 5Open>3Resolved [17:20:05] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198754 [17:20:13] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198755 [17:20:23] jdlrobson: yeah :/ But i think there are good points for both sides, MF is already a huge repo, adding more and more features (which aren't really the purpose of MobileFrontend), isn't very good in several points, but now we can't work like before, anymore, that's right [17:20:44] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198734 (owner: 10Aude) [17:21:47] jdlrobson: did you see my first draft for deprecation on mediawiki.org MobileFrontend coding conventions? [17:22:20] 6Mobile-Web: PageActionOverlay unnecessarily causing re-rendering of page every second - https://phabricator.wikimedia.org/T93223#1141697 (10MaxSem) 5Open>3Resolved a:3MaxSem Revert has been merged. [17:22:53] (03CR) 10Florianschmidtwelzow: [C: 032] "View on WikiData" => "View on Wikidata", not camel case [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198734 (owner: 10Aude) [17:23:06] aude: you around? [17:23:13] FlorianSW: yup :) was happy to see that [17:23:27] jdlrobson: apart from android, mobile frontend, and wikigrok, does anything else also come under mobile frontend? [17:23:50] codezee: android ? [17:23:58] do you mean come under mobile? [17:24:08] jdlrobson: yes, sorry for the confusion :P [17:24:11] the mobile team primarily works on Gather, Wikigrok, MobileFrontend [17:24:17] Android and ios apps [17:24:18] 6Mobile-Web: Not obvious when in alpha/beta - https://phabricator.wikimedia.org/T92679#1141710 (10Maryana) Stub here for discussion at the next design review: https://trello.com/c/X2elvfFw/257-beta-alpha-designation [17:24:22] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [17:24:28] 6Mobile-Web: Not obvious when in alpha/beta - https://phabricator.wikimedia.org/T92679#1141711 (10Maryana) 5Open>3Resolved [17:24:36] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198450 (owner: 10Bmansurov) [17:25:23] (03Merged) 10jenkins-bot: Regression: address upstream change [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198752 (https://phabricator.wikimedia.org/T93508) (owner: 10Jdlrobson) [17:25:25] (03Merged) 10jenkins-bot: Add background-repeat: no-repeat for SpecialHistory on the desktop [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198536 (https://phabricator.wikimedia.org/T93495) (owner: 10Amire80) [17:26:41] (03CR) 10Alex Monk: "Only you have edited that filter: https://test.wikipedia.org/wiki/Special:AbuseFilter/history/152" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198676 (https://phabricator.wikimedia.org/T93539) (owner: 10Deskana) [17:27:05] (03PS3) 10Florianschmidtwelzow: WIP: Alpha experiment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198450 (owner: 10Bmansurov) [17:28:24] dbrant: is there any way to define the caching logic in the API? [17:29:09] (03CR) 10jenkins-bot: [V: 04-1] WIP: Alpha experiment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198450 (owner: 10Bmansurov) [17:29:18] i'm not familiar w/ the various ways you can request an article, but i'd at least hope we can use cache-control info in the request/response for a given article [17:29:35] (if not now, then would be nice to track some kind of issue for it) [17:29:41] FlorianSW: hey, I'm not sure why it's failing, but that's ok. I don't even know what it will look like [17:30:21] Deskana|Away: tomorrow is not a good day for me for meetings. would you please do the rescheduling for a different day? [17:30:25] (03CR) 10BearND: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198754 (owner: 10BearND) [17:30:28] bmansurov: you mean your WIP change? It's because it's based on an old master of MF :) After the rebase it should pass (at least doesn't fail with the sessionid error :P) [17:30:35] but thanks for the info :D [17:30:37] dbrant i'd like to avoid having duplicate client-side cache/cache-invalidation implementations if at all possible :-) [17:30:40] (03Merged) 10jenkins-bot: "View on WikiData" => "View on Wikidata", not camel case [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198734 (owner: 10Aude) [17:30:42] (03CR) 10jenkins-bot: [V: 04-1] Remove "short sentence" from wikidata description i18n message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198735 (owner: 10Aude) [17:30:49] FlorianSW: i see [17:30:50] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198754 (owner: 10BearND) [17:31:08] bmansurov: yap, now it's "just" npm, i suggest some unused/undefined vars [17:31:11] mhurd hangout? [17:31:16] FlorianSW: ok [17:31:21] ya [17:31:35] (03PS3) 10Florianschmidtwelzow: Remove "short sentence" from wikidata description i18n message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198735 (owner: 10Aude) [17:32:26] 6Mobile-Web, 6Mobile-Apps, 7Mobile, 7user-notice: Creating Newsletter for mobile - https://phabricator.wikimedia.org/T93529#1141748 (10gpaumier) I think this could a great opportunity to think about the larger picture and reorganize community newsletters and communications from the perspective of the CEP t... [17:33:35] (03CR) 10jenkins-bot: [V: 04-1] Remove "short sentence" from wikidata description i18n message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198735 (owner: 10Aude) [17:38:08] 10Gather: Invalid argument supplied for foreach() in Collection.php - https://phabricator.wikimedia.org/T93603#1141788 (10MaxSem) [17:38:13] dbrant, bearND: Amending that patch now. [17:38:31] (03CR) 10Florianschmidtwelzow: [C: 031] "there is some unused space if there are long words in the header, but i think the most important point should be, to have the title readab" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198548 (owner: 10Amire80) [17:39:08] 10Gather: Undefined property: stdClass::$perm in ApiQueryListPages.php - https://phabricator.wikimedia.org/T93604#1141799 (10MaxSem) 3NEW [17:40:04] 10Gather: Undefined property: Gather\models\Collection::$this in Collection.php - https://phabricator.wikimedia.org/T93606#1141816 (10MaxSem) 3NEW [17:40:37] jdlrobson, im in ur fabrikatorz, spammin ur bugz [17:40:49] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile, 7Tracking: Intermittent problem with navigating between topics with TOC - https://phabricator.wikimedia.org/T93502#1141832 (10EBernhardson) p:5Triage>3Normal [17:41:26] MaxSem: which bugs? [17:41:30] ^^^^ [17:41:58] cool. cheers MaxSem [17:42:08] let me know when you are done :) [17:42:18] MaxSem: The TemplateParser errors are gone from fatalmonitor now. No idea why. [17:42:23] dbrant, bearND: How do I test the test that I just wrote? [17:42:46] kaldari: it was fixed, see [17:42:48] jdlrobson, that's all for now [17:43:10] Deskana: did you add a test method to TriggerAbuseFilterTest? [17:43:12] kaldari: https://phabricator.wikimedia.org/T93511 [17:43:15] bearND: Yeah. [17:44:21] Deskana: The easiest way is to right click on the class name and the select "Run 'TriggerAbuseFilterTest'" [17:44:42] 10Gather: after user adds page to collection, they can visit collection via link in toast - https://phabricator.wikimedia.org/T93165#1141891 (10Jdlrobson) As discussed in real life toast's cannot have links... I'd suggest rewording this to not show a solution but to present the problem which i think is to make i... [17:45:03] 6Mobile-Web, 10Flow: the "All" tab on MobileFrontend watchlist shows Flow gibberish topic ID links - https://phabricator.wikimedia.org/T93565#1141894 (10EBernhardson) p:5Triage>3Normal Part of the fix for this T59154, it is not a complete solution but i think it would help to at least have sensible titles... [17:45:15] 10Gather, 3Gather Sprint Diplodocus: Invalid argument supplied for foreach() in Collection.php - https://phabricator.wikimedia.org/T93603#1141899 (10Jdlrobson) [17:45:23] 10Gather, 3Gather Sprint Diplodocus: Undefined property: stdClass::$perm in ApiQueryListPages.php - https://phabricator.wikimedia.org/T93604#1141902 (10Jdlrobson) [17:45:27] bearND: Cool. It passed! [17:45:32] 10Gather, 3Gather Sprint Diplodocus: Undefined property: Gather\models\Collection::$this in Collection.php - https://phabricator.wikimedia.org/T93606#1141906 (10Jdlrobson) [17:45:34] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Tracking: Flow issues on mobile web (tracking) - https://phabricator.wikimedia.org/T93430#1141908 (10EBernhardson) p:5Triage>3Normal [17:46:01] Deskana: that should run all the tests in that class. If you just want to run one test method then you do the same by right clicking on that method. Anywhere inside the method would work, too, btw. [17:46:08] (03PS3) 10Deskana: Don't crash when the AbuseFilter emits an arbitrary error code. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198676 (https://phabricator.wikimedia.org/T93539) [17:46:08] Deskana: nice! [17:46:49] bearND: ^ That should do it [17:46:52] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Deprecated M.query breaking Gather - https://phabricator.wikimedia.org/T93508#1141918 (10Jdlrobson) 5Open>3Resolved Kicked off https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauc... [17:47:02] Deskana: checking... [17:47:39] dr0ptp4kt, mhurd, bgerstle, coreyfloyd: Moving on to compute statistics about how many saved pages people have. They won't be perfect because of the way the data is recorded, but it will give us a sense for the state of affairs. :-) [17:49:01] 10Gather, 3Gather Sprint C_, 5Patch-For-Review: Adding to new collection workflow - https://phabricator.wikimedia.org/T91296#1141934 (10JKatzWMF) [17:49:02] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: watchlist overlay: design tweaks - https://phabricator.wikimedia.org/T92037#1141933 (10JKatzWMF) 5Open>3Resolved [17:49:24] dr0ptp4kt, mhurd, bgerstle, coreyfloyd: Holy crap, I think I've already got the data lying around in a spreadsheet from the app's launch. [17:49:39] Deskana: woohoo! [17:50:10] This kills the browser. [17:50:23] hey rmoen, is there a reason I don't see collections here: http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:GatherLists [17:50:31] want to sign off on the card. [17:50:40] JonKatz: looking [17:50:58] JonKatz: probably because new ones need to be created ? [17:51:16] 6Mobile-Web, 5Patch-For-Review: MobileFrontend shouldn't check sessionid length in qunit tests - https://phabricator.wikimedia.org/T93569#1141959 (10Krinkle) It looks like now that the MobileFrontend tests are fixed with that patch, it is now the Thanks extension that is failing with the opposite error: {T935... [17:51:37] JonKatz: assuming that other collections were marked private [17:51:44] rmoen cool, i'll give it a word. Same questoin btw, for the notification overlay from card: https://phabricator.wikimedia.org/T91015 [17:52:51] rmoen great, a new collection showing up now. [17:53:10] dr0ptp4kt, mhurd, bgerstle, coreyfloyd: Median number of saved pages imported by users last time was 1. [17:53:21] dr0ptp4kt, mhurd, bgerstle, coreyfloyd: And that's only if you count the people who imported more than 0. [17:53:28] Deskana: "imported by users"? [17:53:35] 3Gather Sprint Diplodocus: Add browser test for anon user viewing a collection - https://phabricator.wikimedia.org/T93254#1141981 (10JKatzWMF) [17:53:37] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: An admin is able to hide or unhide a list. - https://phabricator.wikimedia.org/T91444#1141982 (10JKatzWMF) [17:53:40] dr0ptp4kt, mhurd, bgerstle, coreyfloyd: Sorry, let me back up. [17:53:44] Deskana: and this data is "sitting around" i.e. how recent is it? [17:53:49] JonKatz: this happened when Yurik added permissions to the lists [17:53:56] 6Mobile-Web, 10Wikimedia-Site-requests, 5Patch-For-Review, 3Roadmap, 7user-notice: Set $wgMFAnonymousEditing = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1141984 (10Jdlrobson) I'm pretty sure if the option is moved to the RL startup module (using the Resourceloader hook the... [17:54:14] dr0ptp4kt, mhurd, bgerstle, coreyfloyd: The old PhoneGap app also had saved pages. When we launched the native app, we had an importer that imported titles of saved pages, but not content. [17:54:20] JonKatz: previous ones had no perms so they defaulted to perm = 0 [17:54:21] dr0ptp4kt, mhurd, bgerstle, coreyfloyd: This data is from that. [17:54:50] dr0ptp4kt, mhurd, bgerstle, coreyfloyd: So back then the median number of pages imported was 0. Or, 1 if you only count the people who had more than 0 pages. [17:55:10] rmoen when does pagination kick in for the collections-all list? [17:55:42] Deskana: ok. there's something else, though [17:55:52] Deskana: the migration runs on all saved *and recent* article entities [17:56:03] (03PS4) 10BearND: Don't crash when the AbuseFilter emits an arbitrary error code. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198676 (https://phabricator.wikimedia.org/T93539) (owner: 10Deskana) [17:56:07] so, AFAIK (mhurd dr0ptp4kt can confirm) we save up to 100 recent articles [17:56:47] (03CR) 10BearND: [C: 032] "Nice. Thanks for adding the abuse filter and test" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198676 (https://phabricator.wikimedia.org/T93539) (owner: 10Deskana) [17:56:48] JonKatz: not sure pagination is worked in here yet. I think we discussed pulling that out of the card but never did [17:56:58] JonKatz: checking [17:57:03] Deskana: also, it would be even better to know the average number of saved pages across all users [17:57:04] (03CR) 10Krinkle: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198735 (owner: 10Aude) [17:57:41] (03Merged) 10jenkins-bot: Don't crash when the AbuseFilter emits an arbitrary error code. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198676 (https://phabricator.wikimedia.org/T93539) (owner: 10Deskana) [17:57:43] JonKatz: pagination is a concept yet to be introduced for gather in general. We have backend support i believe, just not being utilized yet [17:58:22] Deskana: unless we log every add/delete to saved pages (perhaps w/ a current count), i don't think we can say w/ confidence what the average impact "Saved" articles will be on migration [17:58:42] Deskana: did you want ShareAFact in production? /cc: dbrant [17:59:00] although, give that our worst-case from "Recent" alone is 100 articles (AFAIK), then i think we can say that performance is a moderate concern at the very least [17:59:11] 6Mobile-Web, 5Patch-For-Review: MobileFrontend shouldn't check sessionid length in qunit tests - https://phabricator.wikimedia.org/T93569#1142031 (10Florian) This patch isn't merged, yet, so it shouldn't interfere other tests? And MobileFrontend sometimes have the same problem, see e.g.: https://integration.wi... [18:00:40] okay thanks. I'll pull that into another card. [18:00:51] rmoen ^ [18:00:56] joakino: rmoen bunch off patches of mine need reviewing :) [18:00:56] (03CR) 10Florianschmidtwelzow: Remove "short sentence" from wikidata description i18n message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198735 (owner: 10Aude) [18:00:58] 10Gather: When public user visits another users collections page the Page header says "[usernames] collections" - https://phabricator.wikimedia.org/T93619#1142063 (10JKatzWMF) 3NEW [18:01:07] (03CR) 10Florianschmidtwelzow: [C: 032] Remove "short sentence" from wikidata description i18n message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198735 (owner: 10Aude) [18:01:46] (03CR) 10Jdlrobson: [C: 04-1] "Please add qunit tests" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 (owner: 10Robmoen) [18:02:05] 10Gather: List of all collectoins (projectwide) is paginated - https://phabricator.wikimedia.org/T93620#1142073 (10JKatzWMF) 3NEW [18:02:37] dbrant: will be back in about an hour. Feel free to run a beta release if Deskana thinks we've got everything ready for production next week. Or I can do it after I'm back. [18:03:00] bearND: sure, I can do it. [18:03:11] jdlrobson: k [18:03:12] (03Merged) 10jenkins-bot: Remove "short sentence" from wikidata description i18n message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198735 (owner: 10Aude) [18:03:23] jdlrobson: I'll take a look then add some validation tests to my patch [18:05:26] (03CR) 10Jdlrobson: List creation and editing validation (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 (owner: 10Robmoen) [18:05:46] would be really good to get https://gerrit.wikimedia.org/r/198421 merged [18:05:50] as i want to test the EventLogging :) [18:06:13] really quick reviews are: https://gerrit.wikimedia.org/r/198392 https://gerrit.wikimedia.org/r/198271 amd https://gerrit.wikimedia.org/r/198164 [18:08:31] (03CR) 10Jhernandez: [C: 032] Up limit of collections shown to 50. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198392 (https://phabricator.wikimedia.org/T93296) (owner: 10Jdlrobson) [18:09:00] (03CR) 10Jhernandez: [C: 032] Use public not isPublic when rendering checkbox [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198271 (https://phabricator.wikimedia.org/T93372) (owner: 10Jdlrobson) [18:09:36] (03Merged) 10jenkins-bot: Up limit of collections shown to 50. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198392 (https://phabricator.wikimedia.org/T93296) (owner: 10Jdlrobson) [18:09:40] (03CR) 10Robmoen: [C: 04-1] "Aside from Krinkles warning above. what is api action editlistz?" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198421 (https://phabricator.wikimedia.org/T92742) (owner: 10Jdlrobson) [18:10:30] (03CR) 10Jhernandez: [C: 032] Hygiene: Remove inherited functions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198164 (owner: 10Jdlrobson) [18:10:50] (03Merged) 10jenkins-bot: Use public not isPublic when rendering checkbox [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198271 (https://phabricator.wikimedia.org/T93372) (owner: 10Jdlrobson) [18:12:01] rmoen how do you trigger the gather notification overlay? [18:12:14] Have no collections [18:12:29] JonKatz: ^ [18:12:43] (03CR) 10Bmansurov: Fix problems with license message (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [18:13:03] (03Merged) 10jenkins-bot: Hygiene: Remove inherited functions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198164 (owner: 10Jdlrobson) [18:13:56] (03PS4) 10Jdlrobson: Add EventLogging to gather star workflow, error handling fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198421 (https://phabricator.wikimedia.org/T92742) [18:15:13] (03CR) 10Jdlrobson: [C: 032] word-break: normal in page headings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198548 (owner: 10Amire80) [18:15:27] (03CR) 10jenkins-bot: [V: 04-1] Add EventLogging to gather star workflow, error handling fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198421 (https://phabricator.wikimedia.org/T92742) (owner: 10Jdlrobson) [18:15:57] (03CR) 10Jdlrobson: [C: 032] Hygiene: Stub all Api calls in qunit test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198660 (owner: 10Florianschmidtwelzow) [18:16:36] (03CR) 10Bmansurov: "I think the reason why window.load didn't work is because banner images are not part of the initial HTML, they get added after the DOM is " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197979 (owner: 10Robmoen) [18:16:53] rmoen thanks, got it. There is something weird with my chrome private browsing where wikipedia seems to recognize me anyway [18:17:00] (03PS1) 10Florianschmidtwelzow: Allow swiping in ImageOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198763 [18:18:07] (03Merged) 10jenkins-bot: word-break: normal in page headings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198548 (owner: 10Amire80) [18:18:23] jdlrobson: JonKatz: rmoen: i'm going to stop for today, been having a bad brain day [18:18:35] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Article reader sees message/guidance about creating a collection so that they know the feature exists and the entry point - https://phabricator.wikimedia.org/T91015#1142138 (10JKatzWMF) 5Open>3Resolved [18:18:45] joakino feel better, dude [18:18:45] (03PS5) 10Jdlrobson: Delegate main menu generation to MobileFrontend + generalise EL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) [18:19:24] joakino: :( [18:19:29] joakino: see you tomorrow! [18:19:35] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Move Gather to beta mode - https://phabricator.wikimedia.org/T92881#1142140 (10JKatzWMF) 5Open>3Resolved [18:19:54] Deskana: do we want to promote share-a-fact to production? The beta (release candidate) is otherwise ready to go. [18:19:58] Deskana: not sure if you saw my messages, but TL;DR; migration also needs to process "Recent" articles, which AFAIK can number up to 100. would be great to get more recent "Saved" numbers, but either way i'm focusing on functionality first, then performance [18:20:03] at the very least we won't regress [18:20:08] 6Mobile-Web, 10Continuous-Integration, 10Thanks, 7Mobile: MediaWiki Thanks extension test failure: Failing to assert that session ID is 16 chars long - https://phabricator.wikimedia.org/T93594#1142143 (10Krinkle) [18:20:13] dbrant: For the release on the 30th, yes. [18:20:17] dbrant: We should sneak that in now. [18:20:24] 6Mobile-Web, 10Continuous-Integration, 10Thanks, 7Mobile: MediaWiki Thanks extension test failure: Failing to assert that session ID is 16 chars long - https://phabricator.wikimedia.org/T93594#1141331 (10Krinkle) It's now causing MobileFrontend qunit-mobile job to fail as well. Same error. [18:20:29] (03CR) 10Jdlrobson: [C: 04-1] Allow swiping in ImageOverlayNew (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198763 (owner: 10Florianschmidtwelzow) [18:20:35] (03PS1) 10Florianschmidtwelzow: Fix close button in ImageOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198767 [18:20:39] bgerstle: Indeed! Adam and I were discussing this. [18:21:01] (03CR) 10jenkins-bot: [V: 04-1] Delegate main menu generation to MobileFrontend + generalise EL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) (owner: 10Jdlrobson) [18:21:10] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Article Deletion handling - https://phabricator.wikimedia.org/T90992#1142147 (10JKatzWMF) 5Open>3Resolved [18:21:12] k, thanks. i'll update you guys when i amend the patch again with the unit tests i added over the weekend [18:21:26] 6Mobile-Web, 10Continuous-Integration, 10MediaWiki-General-or-Unknown, 5Patch-For-Review: MobileFrontend commits fail in qunit in Jenkins - https://phabricator.wikimedia.org/T93511#1142151 (10Krinkle) {T93594} is causing MobileFrontend qunit-mobile job to fail still. [18:21:32] dr0ptp4kt, mhurd, bgerstle, coreyfloyd: FYI, I'm calling it. This release isn't happening now. There are too many unknowns. We'll go ahead with Android on the 30th, but iOS will be ready when it's ready. [18:21:39] (03Merged) 10jenkins-bot: Hygiene: Stub all Api calls in qunit test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198660 (owner: 10Florianschmidtwelzow) [18:21:54] dr0ptp4kt, mhurd, bgerstle, coreyfloyd: More detailed plan of action to come soon. In the mean time, keep preparing the app for a release "soon". :-) [18:22:12] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Tablet heading design issue - https://phabricator.wikimedia.org/T93152#1142160 (10JKatzWMF) 5Open>3Resolved [18:22:20] Deskana: it was implied before, but we're essentially under a feature freeze then? [18:22:32] and any new code into master should be bug fixes [18:22:40] or low-risk changes [18:23:21] jdlrobson "ready for signoff" tasks that have a user as client (aka I can sign off on) are all in "done"! [18:23:48] bgerstle: New features don't matter now. Our only goal is to get this ready for release. [18:24:01] 6Mobile-Web, 10Continuous-Integration, 10Thanks, 7Mobile: MediaWiki Thanks extension test failure: Failing to assert that session ID is 16 chars long - https://phabricator.wikimedia.org/T93594#1142176 (10Jdlrobson) [18:24:02] 6Mobile-Web, 10Continuous-Integration, 10MediaWiki-General-or-Unknown, 5Patch-For-Review: MobileFrontend commits fail in qunit in Jenkins - https://phabricator.wikimedia.org/T93511#1142177 (10Jdlrobson) [18:24:10] Deskana: gotchya. i've only got bug-fixes slated anyway, just wanted to make sure [18:24:29] 6Mobile-Web, 5Patch-For-Review: MobileFrontend shouldn't check sessionid length in qunit tests - https://phabricator.wikimedia.org/T93569#1142179 (10Jdlrobson) [18:24:30] 6Mobile-Web, 10Continuous-Integration, 10MediaWiki-General-or-Unknown, 5Patch-For-Review: MobileFrontend commits fail in qunit in Jenkins - https://phabricator.wikimedia.org/T93511#1138991 (10Jdlrobson) [18:24:37] Deskana: also, not that it's necessary, but i support this decision :-) [18:25:01] bgerstle: I just said to Adam that I think I've only really started fully understanding what it is that you guys have been saying to me. [18:25:44] bgerstle: Ahh, alignment, it's a beautiful thing. [18:25:58] That said, we need to get this out ASAP. I just think at this stage we can't predict a date. [18:26:01] Deskana: would be interesting to do a "post-mortem" on this to hear what could've been done better in terms of comms [18:26:21] anything engineering could've done to better communicate [18:26:44] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android, 5Patch-For-Review: RuntimeException: Unknown abusefilter response! from editing.AbuseFilterEditResult.getType - https://phabricator.wikimedia.org/T93539#1142193 (10Deskana) 5Open>3Resolved This is "resolved" in the sense that the app doesn't cra... [18:27:01] (03PS1) 10Mhurd: Don't collapse nested tables. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198772 [18:27:18] Deskana: amen to that. let's squash some bugs [18:27:20] 10Gather: after user adds page to collection, they can visit collection via link in toast - https://phabricator.wikimedia.org/T93165#1142200 (10JKatzWMF) @jdlrobson good call. [18:27:45] 6Mobile-Web, 10Continuous-Integration, 10MediaWiki-General-or-Unknown, 5Patch-For-Review: MobileFrontend commits fail in qunit in Jenkins - https://phabricator.wikimedia.org/T93511#1142202 (10Raymond) [18:27:48] 6Mobile-Web, 10Continuous-Integration, 10Thanks, 7Mobile: MediaWiki Thanks extension test failure: Failing to assert that session ID is 16 chars long - https://phabricator.wikimedia.org/T93594#1142204 (10Mattflaschen) Neither of these have anything to do with the Thanks extension, except that MobileFronten... [18:28:21] 6Mobile-Web, 10Continuous-Integration, 7Mobile: MediaWiki MobileFrontend test failure: Failing to assert that session ID is 16 chars long - https://phabricator.wikimedia.org/T93594#1142211 (10Mattflaschen) [18:28:32] phuedx: youstill around? [18:28:44] keen to get https://gerrit.wikimedia.org/r/#/c/198698/ wrapped up as it's impacting other projects [18:28:53] FlorianSW: i think we should just drop that test [18:29:26] Deskana dr0ptp4kt what can I do to help - I can pause on server stuff and help get this out the door [18:29:54] 10Wikipedia-App-iOS-App: Alignment for descriptions in galleries is offset - https://phabricator.wikimedia.org/T93624#1142220 (10Vibhabamba) 3NEW a:3BGerstle-WMF [18:30:24] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Deprecated M.query breaking Gather - https://phabricator.wikimedia.org/T93508#1138944 (10Jdlrobson) Green again. [18:30:47] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: only 10 collections appear on "gather" page - https://phabricator.wikimedia.org/T93296#1142234 (10Jdlrobson) 5Open>3Resolved [18:31:10] (03PS1) 10Dbrant: Promote share-a-fact to production. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198774 [18:31:35] bgerstle: could you use a hand from coreyfloyd on your patch resubmission? [18:31:56] 3Gather Sprint Diplodocus: Editing a user's public collection shows the collection as private - https://phabricator.wikimedia.org/T93372#1142237 (10Jdlrobson) 5Open>3Resolved Fixed by https://gerrit.wikimedia.org/r/198271 [18:32:06] dr0ptp4kt: still working out some issues discovered during unit testing [18:32:29] dr0ptp4kt: the problem in two words: "side effects" [18:32:43] (03CR) 10Jdlrobson: [C: 04-1] "needs rebase grrr" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198165 (https://phabricator.wikimedia.org/T92573) (owner: 10Jdlrobson) [18:33:02] bgerstle: mmmhmm [18:33:05] (03PS6) 10Jdlrobson: Delegate main menu generation to MobileFrontend + generalise EL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) [18:33:46] kaldari: ping again on https://phabricator.wikimedia.org/T93257 after you've merged the template patch [18:35:48] (03CR) 10jenkins-bot: [V: 04-1] Delegate main menu generation to MobileFrontend + generalise EL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) (owner: 10Jdlrobson) [18:36:49] 10Gather, 3Gather Sprint Diplodocus: API: User cannot make their list public (even via API) if moderator has made it private - https://phabricator.wikimedia.org/T93382#1142268 (10Jdlrobson) a:3Yurik [18:37:04] 10Gather, 3Gather Sprint Diplodocus: API: User cannot make their list public (even via API) if moderator has made it private - https://phabricator.wikimedia.org/T93382#1135816 (10Jdlrobson) @Yurik just to double check... you're working on this right? [18:37:28] 10Gather: after user adds page to collection, there is a one-click way to immediately visit that collection to edit - https://phabricator.wikimedia.org/T93165#1142272 (10JKatzWMF) [18:38:17] jdlrobson: sorry, was working on swipe :) Ok, let's do this! :) [18:38:28] coreyfloyd: sounds like bgerstle is working independently on his thing for the moment. bgerstle, if you need coreyfloyd on the thing you're working on you should give him a holler! otherwise, coreyfloyd, i think for you and me we can work on our own stuff independently until bgerstle and mhurd tell us to do some code review [18:39:00] dr0ptp4kt: coreyfloyd: right, i don't think there's much to do be done in parallel on this right now [18:39:29] i just need to figure out the least-invasive way to get these article images properly migrated [18:39:38] 10Gather: user who creates a new collection is shown an overlay showing them to click on the hamburger menu to visit their collections. - https://phabricator.wikimedia.org/T93628#1142280 (10JKatzWMF) 3NEW [18:40:26] mhurd: coreyfloyd from now on we refer to bgerstle as 'the surgeon' [18:40:36] lol [18:40:56] no kidding, would love some laparoscopic equipment right about now.. [18:41:16] or some vital signs! (*cough* automated regression tests *cough*) [18:45:00] (03CR) 10Jdlrobson: [C: 04-1] "also needs a rebase." (035 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [18:47:27] (03PS3) 10Jdlrobson: Defer loading of collections till watchlist click [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198165 (https://phabricator.wikimedia.org/T92573) [18:48:52] (03PS3) 10Florianschmidtwelzow: Hygiene: Don't check sessionid length [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198698 (https://phabricator.wikimedia.org/T93569) [18:49:54] 10Gather, 3Gather Sprint Diplodocus: Announce beta deployment on wikitech-l, enwp vp - https://phabricator.wikimedia.org/T93631#1142326 (10Moushira) 3NEW a:3Moushira [18:51:11] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Don't check sessionid length [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198698 (https://phabricator.wikimedia.org/T93569) (owner: 10Florianschmidtwelzow) [18:55:17] 10Gather, 3Gather Sprint Diplodocus: Announce beta deployment on wikitech-l, enwp vp - https://phabricator.wikimedia.org/T93631#1142344 (10Moushira) [18:55:17] 10Gather, 3Gather Sprint Diplodocus: Populate gather with proper feature name - https://phabricator.wikimedia.org/T92665#1142345 (10Moushira) [18:55:31] (03PS4) 10Florianschmidtwelzow: Hygiene: Don't check sessionid length [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198698 (https://phabricator.wikimedia.org/T93569) [18:56:38] bgerstle: hangout? [18:56:57] bgerstle: one line change proposal [18:57:08] 10Gather, 3Gather Sprint Diplodocus: Populate gather with proper feature name - https://phabricator.wikimedia.org/T92665#1117715 (10Moushira) We also need to document research/analysis done on this, and link it to product mw page. [18:57:22] mhurd let me push the tests i have right now, and you can try it? [18:57:32] bgerstle: sounds good [18:58:07] dr0ptp4kt: lol - the surgeon it is [18:58:33] dr0ptp4kt: bgerstle sorry for the time delay, was in a hangout [19:00:19] mhurd just pushed [19:00:26] mhurd pull from my branch and see if you can get the tests to pass :-) [19:00:42] branch name is image-migration-tests [19:00:49] on my fork (btgerst/apps-ios...) [19:01:13] coreyfloyd: I think mhurd and bgerstle are best placed to tell you what you can help with. Thank you, sir! :-) [19:01:15] mhurd the next step would be to add more sections & images to the test [19:01:26] 10Gather, 3Gather Sprint Diplodocus: Undefined property: Gather\models\Collection::$this in Collection.php - https://phabricator.wikimedia.org/T93606#1142371 (10Jdlrobson) a:3Jdlrobson [19:01:31] 10Wikipedia-App-iOS-App: Whitespace when flicking left to invoke TOC - https://phabricator.wikimedia.org/T93632#1142372 (10Vibhabamba) 3NEW a:3Mhurd [19:01:54] 10Wikipedia-App-iOS-App: Whitespace when trying to invoke TOC - https://phabricator.wikimedia.org/T93632#1142380 (10Vibhabamba) [19:02:11] mhurd FYI i also realized that the thumbnail & other images *need* to be in the image list, otherwise "largestVariant" et. al won't work [19:02:18] (since it queries the image's article's image list) [19:02:29] so we should probably add some unit tests for that as well [19:02:40] 10Wikipedia-App-iOS-App: Whitespace when trying to invoke TOC - https://phabricator.wikimedia.org/T93632#1142372 (10Vibhabamba) Experienced this issue on the Sir Charlie Chaplin article [19:03:13] coreyfloyd: dr0ptp4kt you guys can play along if you like :-) first one to get the tests to pass wins! [19:03:26] (and then other people can try breaking it) [19:04:01] (03CR) 10Fjalapeno: [C: 031] Don't collapse nested tables. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198772 (owner: 10Mhurd) [19:04:28] bgerstle: is this the current patch set? [19:04:37] coreyfloyd: no [19:04:44] i switched to working off my fork [19:04:46] 10Gather: When public user visits another users collections page the Page header says "[usernames] collections" - https://phabricator.wikimedia.org/T93618#1142386 (10Aklapper) @JKatzWMF: Please always associate [[ https://phabricator.wikimedia.org/project/query/active/ | projects ]] to tasks. [19:04:48] (03PS1) 10Jdlrobson: Address PHP notice due to use of this [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198787 (https://phabricator.wikimedia.org/T93606) [19:04:54] so i could have a more granular history [19:05:06] (in case i mess something up and need to roll back) [19:05:09] or, you know, so other people can push commits [19:05:17] i added all of you as collaborators to my fork [19:05:31] (03CR) 10Jdlrobson: [C: 032] Hygiene: Don't check sessionid length [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198698 (https://phabricator.wikimedia.org/T93569) (owner: 10Florianschmidtwelzow) [19:05:51] (03PS7) 10Jdlrobson: Surface page images in collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197256 [19:06:42] 10Gather, 3Gather Sprint Diplodocus: API: Undefined property: stdClass::$perm in ApiQueryListPages.php - https://phabricator.wikimedia.org/T93604#1142400 (10Jdlrobson) a:3Yurik [19:06:57] 10Gather, 3Gather Sprint Diplodocus: API: Undefined property: stdClass::$perm in ApiQueryListPages.php - https://phabricator.wikimedia.org/T93604#1141799 (10Jdlrobson) Ping @yurik who is currently working on the api. [19:09:53] dbrant|brb: Once you've got the beta built, could you also build a production release immediately afterwards and upload it to our prod channel? [19:09:56] 10Gather, 3Gather Sprint Diplodocus: Populate gather with proper feature name - https://phabricator.wikimedia.org/T92665#1142410 (10Jdlrobson) Is this actionable now @JKatzWMF ? We should hurry up and fix the i18n qqq messages asap. [19:10:00] dbrant|brb: I want to contact Google and ask them about featuring. [19:10:44] bgerstle: coreyfloyd dr0ptp4kt running to lunch. back in ~1hr [19:10:53] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(proposals)#Bring_back_recognition_to_mobile_WP_version.21 [19:12:19] thedj: app or mobile web? [19:12:44] jdlrobson: Mobile web. App has nothing like this. [19:13:00] mmm wonder why they think it has disappeared. [19:13:10] jdlrobson: Wasn't that an experiment in the beta/alpha channel? [19:13:19] i guess using beta yeh [19:13:36] Although that begs the question "Why was the user randomly getting beta?" [19:14:33] wasn't it green before ? [19:14:53] me no longer has it green. perhaps that's what's throwing off the user... [19:15:00] coreyfloyd: you there? [19:15:21] thedj: posted it on design mailing list [19:15:30] it's moved to bottom of page in beta [19:15:36] that might be the source of confusion [19:15:43] anyway heading off to lunch now. talk laters :) [19:16:01] ah yes, it was on top in stable and beta, and now it's at the bottom in beta [19:17:52] dr0ptp4kt: yeah [19:20:13] (03Merged) 10jenkins-bot: Hygiene: Don't check sessionid length [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198698 (https://phabricator.wikimedia.org/T93569) (owner: 10Florianschmidtwelzow) [19:21:27] coreyfloyd: calling on video [19:27:41] (03PS2) 10Florianschmidtwelzow: Add Swipe module and use it in ImageOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198763 [19:29:22] (03PS3) 10Florianschmidtwelzow: Add Swipe module and use it in ImageOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198763 [19:29:58] (03PS1) 10Fjalapeno: Update podfile.lock to most recent version of cocoapods [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198802 [19:31:32] coreyfloyd: swift frameworks, yo [19:31:35] thedj: the bar should be green, if the last edit isn't older than X hours/days :) [19:31:46] (03CR) 10jenkins-bot: [V: 04-1] Add Swipe module and use it in ImageOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198763 (owner: 10Florianschmidtwelzow) [19:31:52] coreyfloyd: do you know what the deal is w/ embedded frameworks, swift, & cocoapods? [19:32:15] bgerstle: is this a Seinfeld reference? [19:32:20] corn nuts? [19:32:27] Deskana, bearND can you take a look at https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8077601# ??? I'm not sure, if we can do anything, i can't reproduce such problems on three devices, all animations are smooth :) [19:32:40] coreyfloyd: isn't everything a Seinfeld reference at this point? [19:32:45] seriously though, it wasn't [19:32:59] bgerstle: lol - not really - it just doesn't work right now - but until then, carthage [19:33:06] i was toying around w/ CocoaLumberjack (which recently bumped to 2.0 and added swift support) [19:33:16] coreyfloyd: you can add swift frameworks w/ CP though [19:33:17] bgerstle: coolio [19:33:20] as of 0.36 IIRC [19:33:29] we should use cocoa lumberjack, btw [19:33:32] it's awesome [19:34:06] (03PS4) 10Florianschmidtwelzow: Add Swipe module and use it in ImageOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198763 [19:34:11] FlorianSW: ah, that's what the color is about. [19:34:17] bgerstle: it isn't supported yet, but I think you can with some workaround. Until it is supported most people are using carthage to add swift libs. [19:34:44] thedj: yap, and after the time (sorry, i don't know the exact time range, but it's somewhere in the code :P) it should be grey :) [19:35:30] coreyfloyd: http://blog.cocoapods.org/CocoaPods-0.36/ [19:35:34] TL;DR: CocoaPods 0.36 has been released, with the long-awaited support for Frameworks and Swift. [19:35:48] ^ from the link [19:35:50] brion: i've been looking at VideoJS a bit.. i'm jealous..... [19:36:11] thedj: i should check that out, can probably plug ogv.js into it [19:36:12] bearND: merge plz: https://gerrit.wikimedia.org/r/198774 [19:36:27] bearND: didn't want to self-merge that one [19:36:47] brion: so i now have opened an 'evaluate embedplayer alternatives' tickt [19:36:54] \o/ yay [19:37:24] (03PS5) 10Florianschmidtwelzow: Add Swipe module and use it in ImageOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198763 [19:37:49] brion: i think it will be quicker to rewrite everything based on VideoJS, than to beat embedplayer into shape [19:38:01] you are probably right thedj :P [19:38:27] 6Mobile-Web, 10Continuous-Integration, 10MediaWiki-General-or-Unknown, 5Patch-For-Review: MobileFrontend commits fail in qunit in Jenkins - https://phabricator.wikimedia.org/T93511#1142515 (10Florian) [19:38:28] 6Mobile-Web, 5Patch-For-Review: MobileFrontend shouldn't check sessionid length in qunit tests - https://phabricator.wikimedia.org/T93569#1142513 (10Florian) 5Open>3Resolved This is fixed now, i think other projects (like Thanks) will pass tests now, too :) [19:39:17] brion: in theory there is little difference, but the code of so many of the newer plugins is so much cleaner and better designed. really shows the maturity of the .JS communities lately. [19:41:11] :) [19:44:38] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 3 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1063059 (10dr0ptp4kt) https://gerrit.wikimedia.org/r/#/c/198805/ under review. [19:45:21] dbrant: Can you let me know about my uploading plan when you get a chance? :-) [19:45:56] FlorianSW: Me neither. I'm curious what device he's running; some devices simply don't properly support Lollipop. [19:46:19] Moto G (or X) [19:46:23] Deskana: yep, waiting on bearND to merge the patch that promotes share-a-fact to production. [19:46:36] Deskana: Moto G :) [19:47:02] dbrant: Excellent! [19:47:17] FlorianSW: Could you try to get him to make a screen recording? "App isn't fast enough" is not actionable for us. [19:47:33] dbrant: Looking... When you upload a draft for the production release you could try the beta tap. Then we could try an incremental rollout [19:48:05] (03CR) 10Kaldari: "@Jdlrobson: Would it be possible to split the "Generalises event logging" changes out into a separate patch?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) (owner: 10Jdlrobson) [19:48:11] Deskana: i can try :) I'll open a bug, if he did it and there is really a problem (we can solve) :) Thanks! [19:49:24] bgerstle dr0ptp4kt sad that this is still useful to me on an almost daily basis: http://fuckingblocksyntax.com [19:49:40] coreyfloyd: Xcode's typedef block snippet doesn't do it for you? [19:49:59] coreyfloyd: don't worry, swift function declarations are way simplier [19:50:10] FlorianSW: Yeah, absolutely. But we can't fix it unless we know more, and a video would help *a lot* with that. [19:50:20] (03CR) 10BearND: [C: 032] Promote share-a-fact to production. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198774 (owner: 10Dbrant) [19:50:59] fetchURL(url: NSURL, then: (NSURLResponse) -> Void) [19:51:10] oh i can't wait [19:51:11] haha [19:54:31] (03Merged) 10jenkins-bot: Promote share-a-fact to production. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198774 (owner: 10Dbrant) [19:55:06] dbrant: ready ^ [19:55:12] thx! [19:56:06] (03PS1) 10Dbrant: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198808 [19:56:49] (03CR) 10Dbrant: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/198808 (owner: 10Dbrant) [20:07:57] Deskana: I've uploaded the production apk as a "draft" to the Play Store. [20:19:56] 10Gather: new collection entry design tweak - https://phabricator.wikimedia.org/T93651#1142705 (10JKatzWMF) [20:20:08] 10Wikipedia-App-iOS-App: Descriptions for images are not visible in IOS Gallery - https://phabricator.wikimedia.org/T93652#1142708 (10Vibhabamba) 3NEW a:3BGerstle-WMF [20:22:52] dbrant, bearND: Excellent! Any objection to me contacting Google? [20:23:06] Deskana: none at all [20:23:08] Deskana: none [20:23:32] Deskana: bearND: p.s. beta is published [20:23:40] dbrant: \o/ [20:23:50] Deskana: can we use this mechanism to also send the prod apk to TSG? [20:24:40] TSG? [20:24:45] oh right, duh. [20:24:45] dbrant: The Specialists Guild [20:24:48] lol [20:24:49] dbrant, bearND: I would love for that to happen. Do you want to reach out to Andy yourselves? I could be your middleman, but I think I'd just get in the way. [20:25:27] Deskana: I don't have Andy's email address yet, I think [20:25:59] bearND: I sent it in PM. [20:26:12] Deskana: bearND: I do think we should start taking advantage of the "beta testing" feature of the Play store. [20:26:23] Deskana: thanks [20:26:34] coreyfloyd: do you happen to have the phabricator ticket for getting those extra bug reporting fields to be part of a "template" or part of the ui....handy? [20:26:57] bearND: Please add me to cc and let me know how I can help. I feel like this might be more efficient if you guys are the ones driving the interaction with them, but let me know if you disagree with that. [20:26:58] dbrant: yes. Could you upload it there as well? [20:27:00] coreyfloyd: i'm about to email mobile-l and wanted to point to it if it's been created (i think it was?). if it hasn't been created yet, no problem, just will note the mediawiki.org page only [20:27:12] (in addition to the pertinent part of the thread) [20:27:20] dr0ptp4kt: https://phabricator.wikimedia.org/T92708 [20:27:28] coreyfloyd: thx [20:27:37] dbrant: I would like to try the stage rollout if it makes sense from a product perspective this time (cc: Deskana) [20:27:43] dr0ptp4kt: it also lead to this one for types of tickets: https://phabricator.wikimedia.org/T93499 [20:27:56] dr0ptp4kt: might be good to reference that as well [20:28:31] dbrant: Deskana: and I think we we publish to "beta testing" of the production app then we could share it that way with TSG [20:28:34] and Elena [20:28:39] bearND: We've got big comms around this, we can't afford a staged rollout this time. [20:28:39] coreyfloyd: will do [20:28:42] and whoever wants to test [20:28:57] bearND: Deskana: yep, that would simplify things a bit [20:29:01] dr0ptp4kt: Thanks, will be good to get some other peoples opinions. [20:29:02] bearND: How does the beta channel of the production app work for the user? [20:29:07] Deskana: ok. [20:29:35] Deskana: I think we would need to set up a google group for it and if you join it then you get the beta test apk instead [20:29:57] Deskana: yuvi did that for alpha a long time ago [20:30:22] Deskana: dbrant: we could also reuse the old alpha group, come to think of it [20:31:42] bearND: it won't let me upload an APK to the beta channel, because there's a production draft with the same version code. I would need to delete the draft. Deskana, would Google be ok with pulling the APK out of the beta channel? [20:32:09] dbrant: or the 'alpha testing' one [20:32:35] dbrant: Hmm, I want to make things as easy for Google as possible so they can just say "Yes" to us. I think it's safer just to leave the draft in there for now. [20:34:17] dbrant: plz upload the stable apk to r.mw.o [20:35:39] (03PS7) 10Jdlrobson: Delegate main menu generation to MobileFrontend + generalise EL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) [20:36:18] bearND: I thought that was for when the release actually takes place, and not for release candidates? [20:36:27] mhurd getting close to passing tests... [20:37:44] dbrant: ok, that would be fine, but then you would have to send the apk to TSG since you're the only one who got it [20:40:32] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 3 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1142810 (10dr0ptp4kt) Reserved codes now listed at https://www.mediawiki.org/wiki/Provenance [20:48:43] mhurd holy shit [20:48:48] it's a bit hacky atm, but tests are passing [20:49:05] i'll push what i've got, but have 1:1 w/ tomasz now [20:49:09] will clean it up when i'm back [20:49:27] bearND: I suppose it can't really hurt to just upload it to stable... it's there now. [20:50:43] mhurd i'm actually thinking about consolidating SchemaConverter and OldDataSchemaMigrator [20:50:58] they were only separated before because the OldDataSchemaMigrator was in a separate project [20:51:31] Deskana: that's fine, then. But we should really start making use of the Beta channel after this release. That way we'll be able to give TSG (or anyone) a link to become a tester. (I don't think it requires a Google group anymore) [20:51:33] mhurd coreyfloyd would you guys be able to run some manual migration tests w/ my latest? [20:51:56] dbrant: great. You probably also want to run the --push --prod script since the script is taking the current date for the lables. [20:52:09] 10Wikipedia-App-iOS-App: Description text is not normalized in galleries. - https://phabricator.wikimedia.org/T93662#1142843 (10Vibhabamba) 3NEW a:3BGerstle-WMF [20:52:24] bearND: done [20:52:34] bgerstle: in a bit - working on the progess now [20:52:37] k [20:52:41] dbrant, bearND: In a word... yes. [20:52:41] the progress? [20:52:45] as in migration progress? [20:52:57] dbrant: thanks [20:53:19] Deskana: yes to what question? [20:54:55] (03PS1) 10Fjalapeno: Stop running Static analysis on building… lets leave that to the build server [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198920 [20:55:13] dbrant: do you want me to send email to TSG re: the new apk? [20:55:29] bearND: sure, please [20:56:31] 10Wikipedia-App-Android-App, 10MediaWiki-API, 10MediaWiki-User-login-and-signup: Logging in using a temporary password is reported as "incorrect password" - https://phabricator.wikimedia.org/T67857#1142867 (10Aklapper) p:5Triage>3Low [21:01:11] dbrant: we're waiting for the room. may be a couple minutes [21:04:10] dbrant: We're coming. Sorry. Some inconsiderate person scheduled a meeting over ours. [21:04:20] Deskana: np! [21:05:29] dbrant: Hangouts isn't working... [21:09:48] dbrant: https://phabricator.wikimedia.org/T93662 [21:09:57] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198421 (https://phabricator.wikimedia.org/T92742) (owner: 10Jdlrobson) [21:11:22] (03PS5) 10Jdlrobson: Add EventLogging to gather star workflow, error handling fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198421 (https://phabricator.wikimedia.org/T92742) [21:11:24] (03PS1) 10Jdlrobson: Run AbuseFilter filters against Gather titles and descriptions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199079 (https://phabricator.wikimedia.org/T93606) [21:11:29] dbrant: hmm, i don't see the draft apk in the dev console [21:12:37] bearND: i definitely do... on different computers, too [21:13:25] 10Wikipedia-App-iOS-App: Description text is not normalized in galleries. - https://phabricator.wikimedia.org/T93662#1142923 (10Deskana) p:5Triage>3Normal Verified that these problems don't exist on Android. This is because Android can use fromHtml() in the Html library to change the HTML into a format amena... [21:15:34] (03PS2) 10MaxSem: WIP: submission [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 [21:15:37] (03CR) 10jenkins-bot: [V: 04-1] WIP: submission [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 (owner: 10MaxSem) [21:16:57] bgerstle: coreyfloyd dr0ptp4kt Deskana sry lunch went long [21:17:21] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/199121 (owner: 10L10n-bot) [21:17:23] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/199120 (owner: 10L10n-bot) [21:18:13] mhurd: premium fuel for premium engines. [21:18:21] dbrant: https://phabricator.wikimedia.org/T93652 [21:18:22] dr0ptp4kt: haha [21:18:33] dr0ptp4kt: i did eat well :) [21:18:51] 10Wikipedia-App-iOS-App: Descriptions for images are not visible in IOS Gallery - https://phabricator.wikimedia.org/T93652#1142933 (10Deskana) p:5Triage>3Low The image has no description on Commons. We can probably scrape the description from the article and display that conditionally. Not super high priorit... [21:19:13] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Mobile-Apps, 7Tracking: Hackathon-able / volunteer-worthy tasks for Mobile Apps - https://phabricator.wikimedia.org/T91510#1142935 (10Dbrant) [21:19:13] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Descriptions for images are not visible in iOS Gallery when Commons file page has no description - https://phabricator.wikimedia.org/T93652#1142936 (10Dbrant) [21:19:16] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Descriptions for images are not visible in iOS Gallery when Commons file page has no description - https://phabricator.wikimedia.org/T93652#1142937 (10Deskana) a:5BGerstle-WMF>3None [21:19:22] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/199109 (owner: 10L10n-bot) [21:19:47] dr0ptp4kt: this patch should be good to go: https://gerrit.wikimedia.org/r/#/c/198772/ [21:20:49] (03CR) 10Mhurd: [C: 031] Stop running Static analysis on building… lets leave that to the build server [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198920 (owner: 10Fjalapeno) [21:20:53] 10Wikipedia-App-iOS-App: Alignment for descriptions in galleries is offset - https://phabricator.wikimedia.org/T93624#1142947 (10Deskana) p:5Triage>3Normal Next release. [21:21:25] (03CR) 10Mhurd: [C: 031] Update podfile.lock to most recent version of cocoapods [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198802 (owner: 10Fjalapeno) [21:21:43] 10Wikipedia-App-iOS-App: audio playback doesn't work in the iOS app - https://phabricator.wikimedia.org/T93454#1142960 (10Deskana) [21:21:44] 10Wikipedia-App-iOS-App: [iOS app] Media files do not work - https://phabricator.wikimedia.org/T68722#1142961 (10Deskana) [21:21:55] bgerstle: have a minute for hangout? [21:24:40] 10Wikipedia-App-iOS-App: RTL Image Gallery: Image descriptions are displayed in English - https://phabricator.wikimedia.org/T93413#1142974 (10Deskana) It's not clear what we should do with this. The reason this is happening is because the Commons page has no Hebrew description, so it falls back to English. If t... [21:24:55] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: RTL Image Gallery: Image descriptions are displayed in English - https://phabricator.wikimedia.org/T93413#1142976 (10Deskana) [21:25:21] 10Wikipedia-App-iOS-App: Missing Tap highlights on lists - https://phabricator.wikimedia.org/T93173#1142979 (10Deskana) p:5Triage>3Normal [21:27:03] 10Wikipedia-App-iOS-App, 6WMF-Design: Logo for Wikipedia app isn't right - https://phabricator.wikimedia.org/T92294#1142992 (10Deskana) [21:27:37] bgerstle: mhurd - pushed some changes for progress… but i can't get the UI to update it seems because migration happens on the main thread - any way to get that on the background thread? [21:28:33] 10Wikipedia-App-iOS-App, 6WMF-Design: Logo for Wikipedia app isn't right - https://phabricator.wikimedia.org/T92294#1142995 (10Deskana) 5Open>3stalled As far as we're aware, this is correct. So, I'm marking this as stalled. @Vibhabamba can comment and either close as invalid (if the icon is correct), or re... [21:28:46] (03PS1) 10MaxSem: Fix an overly flamboyant name:P [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/199123 [21:28:59] (03PS8) 10Jdlrobson: Delegate main menu generation to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) [21:29:01] (03PS1) 10Jdlrobson: Hygiene: Generalise EventLogging for main menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199124 [21:29:06] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: As a user if I change my wiki language through More, the search field should be empty or the results refreshed next time I try to search - https://phabricator.wikimedia.org/T92290#1143005 (10Deskana) p:5Triage>3Normal [21:29:09] bgerstle mhurd basically we need to convert the API for the OldDataSchemaMigrator to have async call back methods (FYI my branch is in brains repo) [21:29:19] dbrant: https://phabricator.wikimedia.org/T92290 [21:29:54] (03PS2) 10Jdlrobson: Hygiene: Generalise EventLogging for main menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199124 (https://phabricator.wikimedia.org/T92855) [21:30:09] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: As a user if I change my wiki language through More, the search field should be empty or the results refreshed next time I try to search - https://phabricator.wikimedia.org/T92290#1143011 (10Dbrant) [21:30:10] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Mobile-Apps, 7Tracking: Hackathon-able / volunteer-worthy tasks for Mobile Apps - https://phabricator.wikimedia.org/T91510#1143010 (10Dbrant) [21:30:10] coreyfloyd: k will check [21:30:24] coreyfloyd: oh can you give me the link? [21:30:50] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Zero, 7Design: only show features related to Zero if Zero is relevant in this context - https://phabricator.wikimedia.org/T92267#1143013 (10Deskana) 5Open>3declined a:3Deskana This sounds sensible. I wish we'd got it into the first release. :-)... [21:31:24] coreyfloyd: hangout? [21:31:25] mhurd: https://github.com/btgerst/apps-ios-wikipedia/tree/feature/migration-progress [21:31:32] mhurd: sure [21:32:49] 10Wikipedia-App-iOS-App: [iOS app] Media files do not work - https://phabricator.wikimedia.org/T68722#1143019 (10Deskana) p:5Triage>3Normal [21:33:44] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Update color of scroll indicator on IOS - https://phabricator.wikimedia.org/T91705#1143021 (10Deskana) 5Open>3Resolved [21:33:59] Deskana: The number of bugs that I opened, James_F closed as WONTFIX, and were eventually fixed is... nonzero :) [21:34:04] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS, 5Patch-For-Review: App MediaViewer jarringly loads cropped low quality image and then higher quality full size image - https://phabricator.wikimedia.org/T92446#1143026 (10Deskana) 5Open>3Resolved [21:35:13] (03PS2) 10Jdlrobson: Run AbuseFilter filters against Gather titles and descriptions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199079 (https://phabricator.wikimedia.org/T93385) [21:35:19] Deskana: but seriously, uploading Open Well-Tempered Clavier to Commons made me think: do we have something like a playlist feature? [21:35:31] coreyfloyd: who's brain? ;-P [21:35:42] anywhere - desktop, mobile. [21:35:47] 10Wikipedia-App-iOS-App: In article scrolling performance around images is jerky and inconsistent - https://phabricator.wikimedia.org/T89518#1143045 (10Deskana) 5Open>3Resolved a:3Deskana We think this is resolved now. We can't reproduce it any more. @Tfinc Can you retest with the latest beta and tell us... [21:36:00] aharoni: no, we have very little when it comes to multimedia [21:36:13] coreyfloyd: so the entire migration (syncMigration) happens in the background [21:36:24] aharoni: Indeed, my say is only as final as anything is final in iterative software development... ;-) [21:36:27] you can add intermittent "progress" callbacks to the main thread from w/in there [21:36:38] 10Wikipedia-App-iOS-App: Whitespace when trying to invoke TOC - https://phabricator.wikimedia.org/T93632#1143056 (10dr0ptp4kt) Is this still an issue? Can this be reproduced in the simulator? If so, same version as in bug? Steps to reproduce? [21:36:40] aharoni: FWIW, Adam Baso (former Zero developer, now iOS developer) agreed with my rationale. :-) [21:36:44] aharoni: but i suggest filing a ticket for m3u8 support :) [21:36:58] bgerstle: mhurd just told me the core data is pulling from the main context [21:37:08] (03PS1) 10Bartosz Dziewoński: Use ResourceLoaderImageModule's CSS selector templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199130 (https://phabricator.wikimedia.org/T78215) [21:37:09] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap: Production release for iOS Wikipedia app on 30th March 2015 - https://phabricator.wikimedia.org/T86692#1143069 (10Deskana) [21:37:10] 10Wikipedia-App-iOS-App: Left side of search icon is cut off on top when tapping search - https://phabricator.wikimedia.org/T89515#1143066 (10Deskana) 5Open>3Resolved a:3Deskana Fixed! [21:37:14] (03PS1) 10Bartosz Dziewoński: Use ResourceLoaderImageModule's CSS selector templates [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199131 (https://phabricator.wikimedia.org/T78215) [21:37:23] We have the whole 48 files of the Well-Tempered Clavier, and probably some more works of music or video that consist of several files... playing them in one click or tap would be pretty nice. [21:37:38] James_F: we're using RLImageModule.. [21:37:56] coreyfloyd: hrm, so it is... even though it's in the background [21:37:57] aharoni: you need file support, edit support, and playback support. all three things would be missing :( [21:38:04] 10Gather, 6Mobile-Web, 10MobileFrontend-Feature-requests, 10MediaWiki-ResourceLoader, 5Patch-For-Review: ResourceLoaderImage module css rules should be more configurable - https://phabricator.wikimedia.org/T78215#1143072 (10matmarex) The Gather extension has the same hack. [21:38:09] 10Wikipedia-App-iOS-App: Inconsistent image file display on the image file page - https://phabricator.wikimedia.org/T89193#1143075 (10Deskana) p:5Triage>3Lowest This page is now so obscured by virtue of the image gallery that this is a much lower priority issue. [21:38:29] (03CR) 10Jdlrobson: "\o/" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199131 (https://phabricator.wikimedia.org/T78215) (owner: 10Bartosz Dziewoński) [21:38:31] hi. [21:38:53] bgerstle: still might be hiting the main thread internally [21:38:54] thedj: actually, a few lines of JS that play all the files in a category one after another would be an OK start [21:39:10] bgerstle: i mos def cannot get the UI to update whilst it is running [21:39:18] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android, 5Patch-For-Review: latest android alpha 19.3.2015 doesn't update main page unless device is rebooted - https://phabricator.wikimedia.org/T93356#1143083 (10Deskana) 5Open>3Resolved Resolved. We don't cache the main page anymore, except on screen... [21:39:31] aharoni: good luck working the javascript player :) [21:40:21] i've spent about 60hours getting it to be more RL compliant in order to prep it for live preview and VE. it's a piece of shit :) [21:40:27] (03CR) 10jenkins-bot: [V: 04-1] Use ResourceLoaderImageModule's CSS selector templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199130 (https://phabricator.wikimedia.org/T78215) (owner: 10Bartosz Dziewoński) [21:41:15] (03CR) 10Jdlrobson: [C: 031] "Shouldn't be merged until dependency is merged." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199131 (https://phabricator.wikimedia.org/T78215) (owner: 10Bartosz Dziewoński) [21:41:22] coreyfloyd: hehe because it uses the "MainQueue confinement setting, which blocks the background thread, does work on main, then returns [21:41:40] bgerstle: bing bong! [21:42:01] 10Wikipedia-App-iOS-App: Whitespace when trying to invoke TOC - https://phabricator.wikimedia.org/T93632#1143086 (10Vibhabamba) I dont have an Iphone 5, ios 7, latest beta anymore Please verify using a simulator. [21:43:03] (03CR) 10jenkins-bot: [V: 04-1] Use ResourceLoaderImageModule's CSS selector templates [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199131 (https://phabricator.wikimedia.org/T78215) (owner: 10Bartosz Dziewoński) [21:43:15] dr0ptp4kt: have you added the wprov parameter to the iOS app? [21:43:22] bearND: i have, yes [21:44:07] MatmaRex: oh, those changes to RL image module be fancy :) [21:44:09] mhurd bgerstle dr0ptp4kt taking a break in a few - need to walk the dog before he bites my face off [21:44:21] coreyfloyd: beware the dog [21:44:28] coreyfloyd: haha [21:44:30] coreyfloyd: we can try changing the background code to create its own MOC (i.e. not a child of the main context) [21:44:46] should do what you're after [21:44:50] bgerstle: i’m taking a peek at that now [21:44:50] w/o effecting anything [21:44:56] 10Wikipedia-App-Android-App: Remove 'More information' from overflow menu in image gallery - https://phabricator.wikimedia.org/T86810#1143112 (10Deskana) [21:45:06] mhurd should only need to create a new MOC w/ the same persistent store as the main MOC [21:45:17] dr0ptp4kt:what the gerrit link? [21:45:17] as long as they have the same persistent store, data should be the same [21:45:21] what's [21:45:33] 10Wikipedia-App-Android-App: Remove 'More information' from overflow menu in image gallery - https://phabricator.wikimedia.org/T86810#977038 (10Deskana) In fact, we've decided this doesn't really support any use case, and we can just remove it. [21:46:35] bgerstle: you shoudl be able to just init the MOC to private queue mode [21:46:42] 10Wikipedia-App-Android-App: share via Google+ error - https://phabricator.wikimedia.org/T87319#1143124 (10Deskana) 5Open>3Invalid a:3Deskana This bug lacks sufficient context for us to reproduce it, so I have closed it as invalid. @Shizhao Please provide steps to reproduce this, and we can reopen and inv... [21:46:49] bgerstle: instead of doing parent child stuff [21:46:54] coreyfloyd: just creating it is enough, it's owned by whatever thread calls -init [21:47:09] coreyfloyd: we actually can't do parent/child because the "MainQueue" confinement type prevents it [21:47:43] bgerstle: coreyfloyd corey walk your dog! ;) [21:47:55] coreyfloyd: parent/child isn't needed here since we're not propagating updates anyway. [21:47:58] and yeah, go walk your 🐶 [21:48:08] bgerstle: hangout and we can chat about this? [21:48:13] bearND: https://gerrit.wikimedia.org/r/#/c/196243/ [21:48:13] mhurd sure [21:48:37] 10Wikipedia-App-Android-App: IndexOutOfBoundsException: setSpan (? ... ?) ends beyond length ? crash - https://phabricator.wikimedia.org/T87286#1143131 (10Deskana) 5Open>3Invalid a:3Deskana These stack traces do not mention our code at all. Unfortunately we lack sufficient context to reproduce this, or eve... [21:49:25] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 3 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1143136 (10dr0ptp4kt) The iOS code update was https://gerrit.wikimedia.org/r/#/c/196243/, by the way. [21:51:02] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Search in different languages: clearer indication that a user is searching in language specific Wiki? - https://phabricator.wikimedia.org/T92528#1143149 (10Deskana) [21:51:02] 10Wikipedia-App-Android-App, 10Wikimania-Hackathon-2015, 10Wikimedia-Hackathon-2015, 7Design: Add an easier and faster way to change the search language - https://phabricator.wikimedia.org/T87154#1143150 (10Deskana) [21:53:07] 10Wikipedia-App-Android-App: Rotating screen during saved pages refresh causes it to cancel refreshing - https://phabricator.wikimedia.org/T87123#984328 (10Deskana) It's been a while since we touched this code and we're not really too sure what the problem is. [21:53:11] MaxSem: Can you reply to this inquiry on the WikiGrok talk page (concerns a db error): https://www.mediawiki.org/wiki/Extension_talk:WikiGrok [21:54:02] eh, reply to a month-old post about a transitive issue? [21:55:04] MaxSem: I assume it’s reolved now, so feel free to just say it’s fixed if it is. [21:55:47] 10Wikipedia-App-Android-App: IllegalArgumentException: pointerIndex out of range crashes - https://phabricator.wikimedia.org/T86166#1143168 (10Deskana) 5Open>3Resolved We think this is fixed now. If these issues occur in our latest production release (planned for 30th March), please reopen this. [21:57:36] 10Wikipedia-App-Android-App: Out of space errors causing app to crash - https://phabricator.wikimedia.org/T87073#1143171 (10Deskana) It's possible that this was fixed due to our work on T89826, but actually @DBrant is sceptical that these errors are actually due to the device being out of space. Either way, ther... [21:57:43] 10Wikipedia-App-Android-App: Out of space errors causing app to crash - https://phabricator.wikimedia.org/T87073#1143175 (10Deskana) p:5Triage>3Normal [21:58:10] dr0ptp4kt: thanks. I'll make the same change for Android. There we only use the URL in the image share case, BTW. So no sfta1 needed AFAICS. [21:58:53] 10Wikipedia-App-Android-App, 6Mobile-Apps: Edit pencil showing up on top of infoboxes. - https://phabricator.wikimedia.org/T87068#1143181 (10Deskana) 5Open>3Resolved This is fixed! [22:00:26] (03CR) 10Florianschmidtwelzow: [C: 04-1] Fix problems with license message (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [22:01:54] 10Wikipedia-App-Android-App: IndexOutOfBoundsException: setSpan (? ... ?) ends beyond length ? crash - https://phabricator.wikimedia.org/T87286#1143198 (10TheDJ) Usually this means that copy/paste or autosuggest/autocorrect of either android itself or the custom keyboard that the user is using is doing something... [22:02:05] bearND: Dan says he can see it in his console... [22:02:51] dbrant: just checked again. I see it now [22:04:36] jdlrobson, back online [22:06:37] (03PS1) 10BearND: Avoid cache fragmenting URLs for Share a Fact shares [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/199140 (https://phabricator.wikimedia.org/T90606) [22:07:32] Deskana: Do we need this^ for production? [22:13:47] MaxSem: resources/src/mediawiki.less/mediawiki.mixins.less [22:13:50] L11 [22:13:56] L40 rather [22:14:35] 10Wikipedia-App-iOS-App: In article scrolling performance around images is jerky and inconsistent - https://phabricator.wikimedia.org/T89518#1143246 (10Etonkovidova) Checked on 'Barack Obama' and 'Impressionism' articles - iPad mini 8.2 with 4.0.7.8. Scrolling up and down looks quite smooth. [22:16:31] 6Mobile-Web, 10Flow, 10UI-Standardization, 10Vector: Should be a standard way to access tablet browser width threshold - https://phabricator.wikimedia.org/T93675#1143254 (10Jdlrobson) 3NEW [22:19:00] mhurd bgerstle back [22:19:48] mhurd bgerstle did you guys make any changes to the background stuff? [22:20:03] or do you want me to do it? [22:21:03] 10Gather, 3Gather Sprint Diplodocus: Design tweaks for Vector skin - https://phabricator.wikimedia.org/T92883#1143309 (10Jdlrobson) a:3Jdlrobson [22:21:40] (03PS1) 10Jdlrobson: Tweaks for Vector skin styling [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199143 (https://phabricator.wikimedia.org/T92883) [22:21:53] 10Wikipedia-App-Android-App: Imagemap does not fit the screen - https://phabricator.wikimedia.org/T87066#1143319 (10Etonkovidova) [22:22:14] 10Gather, 3Gather Sprint Diplodocus: Populate gather with proper feature name - https://phabricator.wikimedia.org/T92665#1143321 (10JKatzWMF) @jdlrobson Feel free to drop the i18n stuff. Let's operate under the assumption that collections is the name we are going with. [22:22:15] MaxSem: https://gerrit.wikimedia.org/r/198787 < rmoen [22:22:34] 10Gather, 3Gather Sprint Diplodocus: Populate gather with proper feature name - https://phabricator.wikimedia.org/T92665#1143323 (10Jdlrobson) a:3Jdlrobson [22:22:45] (03CR) 10MaxSem: [C: 032] Address PHP notice due to use of this [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198787 (https://phabricator.wikimedia.org/T93606) (owner: 10Jdlrobson) [22:22:49] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198974 (owner: 10L10n-bot) [22:23:37] (03CR) 10jenkins-bot: [V: 04-1] Tweaks for Vector skin styling [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199143 (https://phabricator.wikimedia.org/T92883) (owner: 10Jdlrobson) [22:23:50] (03PS1) 10Jdlrobson: i18n: Drop experimental qqq code messages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199145 [22:24:10] ^ aharoni don't suppose you can help me speed up some translations for Gather? [22:24:23] aharoni: am looking forward to seeing some language based lists from you when Gather goes live :-) [22:24:31] ya ba da ba d [22:24:32] oo [22:24:42] that gerrit patch? [22:24:50] oh, qqq [22:24:55] 10Gather, 3Gather Sprint Diplodocus: Invalid argument supplied for foreach() in Collection.php - https://phabricator.wikimedia.org/T93603#1143335 (10Jdlrobson) a:3Jdlrobson [22:25:29] (03PS2) 10Jdlrobson: Address PHP notice due to use of this [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198787 (https://phabricator.wikimedia.org/T93606) [22:25:32] thanks MaxSem [22:25:33] looking [22:25:36] (03CR) 10Jdlrobson: [C: 032] Address PHP notice due to use of this [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198787 (https://phabricator.wikimedia.org/T93606) (owner: 10Jdlrobson) [22:26:06] (03CR) 10jenkins-bot: [V: 04-1] i18n: Drop experimental qqq code messages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199145 (owner: 10Jdlrobson) [22:26:32] (03CR) 10Robmoen: [C: 032] i18n: Drop experimental qqq code messages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199145 (owner: 10Jdlrobson) [22:26:53] (03CR) 10Amire80: "Go home Jenkins, you're drunk." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199145 (owner: 10Jdlrobson) [22:27:12] jdlrobson: I'll just remove it in translatewiki. [22:27:28] aharoni: until then http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/Jdlrobson/5 [22:27:29] :) [22:27:39] 10Gather, 3Gather Sprint Diplodocus: Populate gather with proper feature name - https://phabricator.wikimedia.org/T92665#1143351 (10Moushira) Can we just wait a sec until we publish survey result on mw..:) [22:27:52] well what do you know [22:27:55] gather actually works [22:28:05] let me ask a very very very simple question [22:28:10] (03CR) 10Dr0ptp4kt: [C: 032] Don't collapse nested tables. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198772 (owner: 10Mhurd) [22:28:16] 10Gather, 3Gather Sprint Diplodocus: Populate gather with proper feature name - https://phabricator.wikimedia.org/T92665#1143355 (10Jdlrobson) I'd rather we fixed this asap. Every day experimental qqq codes are in place we lose out on translations and non-English speakers see a broken product. [22:28:21] gather haz lists of articles, does it? [22:28:27] 3Gather Sprint Diplodocus, 6Mobile-Web, 5Patch-For-Review: EditorTutorial false arrow position - https://phabricator.wikimedia.org/T91047#1143356 (10Jdlrobson) a:5bmansurov>3Jdlrobson [22:28:44] because generic lists of articles is something that I care very much about for ContentTranslation [22:28:48] (03PS2) 10Dr0ptp4kt: Stop running Static analysis on building… lets leave that to the build server [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198920 (owner: 10Fjalapeno) [22:28:53] (03CR) 10Dr0ptp4kt: [C: 032] Stop running Static analysis on building… lets leave that to the build server [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198920 (owner: 10Fjalapeno) [22:29:29] (03PS2) 10Dr0ptp4kt: Update podfile.lock to most recent version of cocoapods [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198802 (owner: 10Fjalapeno) [22:29:35] (03CR) 10Dr0ptp4kt: [C: 032] Update podfile.lock to most recent version of cocoapods [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198802 (owner: 10Fjalapeno) [22:29:48] jdlrobson: ^ [22:30:49] jdlrobson: "Label for count of collection on list of all collections" - is it the number of collections? items in a collection? items in all collections? [22:31:36] dbrant: bearND did you guys see https://gerrit.wikimedia.org/r/#/c/198772/1 ? [22:31:37] 10Gather, 3Gather Sprint Diplodocus: Populate gather with proper feature name - https://phabricator.wikimedia.org/T92665#1143366 (10JKatzWMF) @moushira this is not fixing the name permanently, just allowing i18n to occur. On the other hand, this is only going out on english beta, so i18n isn't an issue for now. [22:33:14] (03CR) 10Jdlrobson: [C: 04-1] "i'll fix up." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198767 (owner: 10Florianschmidtwelzow) [22:33:22] (03PS2) 10Jdlrobson: Fix close button in ImageOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198767 (owner: 10Florianschmidtwelzow) [22:33:38] mhurd: not yet. I believe dbrant created a patch to do something similar for Android a while ago [22:34:12] (03CR) 10Robmoen: "Does this need to be in a RL module ? How does this load?" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199143 (https://phabricator.wikimedia.org/T92883) (owner: 10Jdlrobson) [22:34:27] bearND: load the san francisco article and go to the climate section for quick check if you want [22:34:49] 6Mobile-Web, 10Flow: the "All" tab on MobileFrontend watchlist shows Flow gibberish topic ID links - https://phabricator.wikimedia.org/T93565#1143374 (10DannyH) I think we just need to play Whac-a-Mole with these places. Adding words to the unique ID won't really make this mobile page a lot better. It should s... [22:35:00] 6Mobile-Web, 6Collaboration-Team, 10Flow: the "All" tab on MobileFrontend watchlist shows Flow gibberish topic ID links - https://phabricator.wikimedia.org/T93565#1143375 (10DannyH) [22:35:17] jdlrobson: Which one of your patches would you like reviewed so your head doesn't explode? [22:36:09] (03CR) 10Jdlrobson: [C: 032] "It's not the best solution but I can't think of a better one right now :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198767 (owner: 10Florianschmidtwelzow) [22:36:42] jdlrobson: looking/testing the abuse filter patch now [22:37:59] (03CR) 10Jdlrobson: ""I thought there was common agreement that MobileFrontend is the wrong extension for Special:UserProfile. What harm is there in moving thi" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194451 (https://phabricator.wikimedia.org/T85929) (owner: 10Legoktm) [22:38:37] (03CR) 10Jdlrobson: [C: 032] Remove dependency on mobile.templates where hogan is used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [22:39:25] mhurd: yes. Just checked the first infobox in [[San Francisco]], and it's not nested on Android [22:39:29] (03CR) 10Jdlrobson: [C: 04-1] "just saw comment. yeh we should remove all usages of mobile.template" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [22:39:39] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/198944 (owner: 10L10n-bot) [22:39:43] bearND: yay! [22:39:48] rmoen: ping? [22:40:02] eh ? [22:40:15] mhurd: i have not compared your solution with dbrant's. You may want to check out our transforms.js code [22:40:16] bearND: able to get on video for a little bit? [22:40:18] jdlrobson: ive been pinging you [22:40:22] bearND: k [22:40:26] bearND: good idea [22:40:34] dr0ptp4kt: in a minute [22:41:15] jdlrobson: did you need something ? [22:41:47] rmoen, if you need anything, i'm online [22:41:57] trying to get the show|hide list [22:42:22] dr0ptp4kt: ready [22:42:35] yurik: ok thanks. right. Did you add the permission group in an api patch, that I can base off of ? [22:43:05] dr0ptp4kt: batcave? [22:43:05] rmoen, i am adding it there, yes [22:43:11] bearND: k [22:43:25] rmoen, if you need it for the frontend, simply check the userinfo api if the user has it [22:43:41] the name is 'gather-hidelist' [22:43:45] ok [22:45:58] rmoen: you have? [22:46:00] i have no pings [22:46:06] did you ping my alterego jdlrobson2 ? [22:46:09] nope [22:46:18] jdlrobson: scroll up [22:46:25] aharoni thanks btw [22:46:29] did that ping you ? [22:46:50] rmoen: ah i see :) rammed between 2 commits [22:47:12] rmoen: so yeh i'm juggling too many things [22:47:20] same [22:47:31] so i don't really mind what, i just want to get stuff off my plate. I've reviewed all your existing patches [22:47:31] coreyfloyd: sorry was out walking the dog as well [22:47:36] jdlrobson: trying to give you the reviews and fix up my existing work [22:47:42] just put a coupla sweet po-tay-toes in the oven [22:47:50] did you take a crack at it? [22:47:55] bgerstle: np - i picked up the background thread stuff [22:48:00] k, how goes it? [22:48:11] bgerstle: just a sec ordering thai food… [22:48:33] coreyfloyd: yum, i just had some thai foods [22:48:38] (03CR) 10CSteipp: [C: 031] "Concept looks good, thanks!" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199079 (https://phabricator.wikimedia.org/T93385) (owner: 10Jdlrobson) [22:48:51] rmoen https://gerrit.wikimedia.org/r/198363 and https://gerrit.wikimedia.org/r/199143 should be quick but i'd really appreciate you looking at https://gerrit.wikimedia.org/r/198165 [22:49:32] jdlrobson: hmm i did leave a question on https://gerrit.wikimedia.org/r/#/c/199143/ [22:49:49] (03PS2) 10Jdlrobson: Tweaks for Vector skin styling [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199143 (https://phabricator.wikimedia.org/T92883) [22:49:51] (03CR) 10jenkins-bot: [V: 04-1] Tweaks for Vector skin styling [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199143 (https://phabricator.wikimedia.org/T92883) (owner: 10Jdlrobson) [22:49:53] rmoen: yup just answered [22:51:06] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199143 (https://phabricator.wikimedia.org/T92883) (owner: 10Jdlrobson) [22:51:10] jdlrobson: shoot I already looked at https://gerrit.wikimedia.org/r/#/c/198165 Friday. sorry i didn't merge it [22:51:39] just going to pull it one more time [22:51:47] (03CR) 10Jdlrobson: [C: 031] Address PHP notice due to use of this [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198787 (https://phabricator.wikimedia.org/T93606) (owner: 10Jdlrobson) [22:51:55] (03CR) 10Kaldari: [C: 04-1] Fix problems with license message (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [22:52:05] (03CR) 10Jdlrobson: [C: 032] Address PHP notice due to use of this [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198787 (https://phabricator.wikimedia.org/T93606) (owner: 10Jdlrobson) [22:52:23] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198903 (owner: 10L10n-bot) [22:53:14] 6Mobile-Web, 10Continuous-Integration, 10MediaWiki-General-or-Unknown, 5Patch-For-Review: MobileFrontend commits fail in qunit in Jenkins - https://phabricator.wikimedia.org/T93511#1143421 (10Jdlrobson) Should be working now? [22:53:27] rmoen: np [22:53:55] rmoen: also https://gerrit.wikimedia.org/r/197256 is tiny [22:54:11] jdlrobson: 1 sec, getting an error on the rejig. [22:54:32] typical jenkins is being laggy again and not merging shit :-/ [22:57:27] (03CR) 10Robmoen: [C: 04-1] "So this is a problem for the tutorial. It expects wgCollections to exist on a non special page. Currently throws an error: Uncaught Typ" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198165 (https://phabricator.wikimedia.org/T92573) (owner: 10Jdlrobson) [22:58:24] (03PS2) 10Dr0ptp4kt: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198755 (owner: 10BearND) [22:58:24] (03CR) 10Robmoen: [C: 032] Surface page images in collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197256 (owner: 10Jdlrobson) [22:59:24] (03CR) 10jenkins-bot: [V: 04-1] Address PHP notice due to use of this [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198787 (https://phabricator.wikimedia.org/T93606) (owner: 10Jdlrobson) [22:59:27] (03CR) 10jenkins-bot: [V: 04-1] i18n: Drop experimental qqq code messages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199145 (owner: 10Jdlrobson) [23:00:06] (03CR) 10Jdlrobson: [C: 031] "Maryana can we merge this with your blessing?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [23:00:12] bgerstle: just about to fire it up after my changes… [23:01:46] (03CR) 10Robmoen: [C: 032] "Thank you!! this was bugging me." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199143 (https://phabricator.wikimedia.org/T92883) (owner: 10Jdlrobson) [23:03:25] (03CR) 10Robmoen: [C: 031] Run AbuseFilter filters against Gather titles and descriptions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199079 (https://phabricator.wikimedia.org/T93385) (owner: 10Jdlrobson) [23:04:11] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap: Next production release for iOS Wikipedia app - https://phabricator.wikimedia.org/T86692#1143452 (10Deskana) [23:04:28] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap: Next production release for iOS Wikipedia app - https://phabricator.wikimedia.org/T86692#974271 (10Deskana) I have changed the title of this task to reflect the unfortunate reality that this is not ready to ship right now. [23:04:43] (03CR) 10jenkins-bot: [V: 04-1] Fix close button in ImageOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198767 (owner: 10Florianschmidtwelzow) [23:04:49] (03CR) 10jenkins-bot: [V: 04-1] Remove dependency on mobile.templates where hogan is used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [23:04:54] (03CR) 10jenkins-bot: [V: 04-1] Surface page images in collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197256 (owner: 10Jdlrobson) [23:04:56] (03CR) 10jenkins-bot: [V: 04-1] Tweaks for Vector skin styling [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199143 (https://phabricator.wikimedia.org/T92883) (owner: 10Jdlrobson) [23:05:34] 10Wikipedia-App-Android-App, 3Roadmap: Production release for Android Wikipedia app on 30th March 2015 - https://phabricator.wikimedia.org/T91693#1143463 (10Deskana) In spite of what happened to the iOS release, this one is still on track for the 30th. [23:05:50] (03CR) 10Kaldari: Fix problems with license message (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [23:09:28] (03CR) 10Robmoen: [C: 032] Add EventLogging to gather star workflow, error handling fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198421 (https://phabricator.wikimedia.org/T92742) (owner: 10Jdlrobson) [23:11:50] (03Merged) 10jenkins-bot: Add EventLogging to gather star workflow, error handling fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198421 (https://phabricator.wikimedia.org/T92742) (owner: 10Jdlrobson) [23:12:56] (03PS1) 10Jdlrobson: Make page action overlay pointer position correctly. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199155 (https://phabricator.wikimedia.org/T91047) [23:15:23] (03CR) 10jenkins-bot: [V: 04-1] Make page action overlay pointer position correctly. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199155 (https://phabricator.wikimedia.org/T91047) (owner: 10Jdlrobson) [23:16:39] (03CR) 10Dr0ptp4kt: [C: 032] Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198755 (owner: 10BearND) [23:17:17] (03PS1) 10Mhurd: Fix for recent "glasses" icon (when no recent items) being too small. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199156 [23:18:23] (03PS2) 10Mhurd: Fix for recent "glasses" icon (when no recent items) being too small. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199156 [23:18:35] dr0ptp4kt: ^ [23:18:41] (03Abandoned) 10Jdlrobson: Generalise main menu logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197454 (owner: 10Jdlrobson) [23:19:43] (03PS4) 10Jdlrobson: Use new schema for main menu click tracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197455 [23:19:55] (03CR) 10Jdlrobson: [C: 032] "Doesn't need dependency. Backwards compatible." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197455 (owner: 10Jdlrobson) [23:20:16] (03CR) 10Bmansurov: [C: 04-1] "This partially solves the problem. You should also re-render the arrow after items in page-actions are rendered." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199155 (https://phabricator.wikimedia.org/T91047) (owner: 10Jdlrobson) [23:20:33] (03CR) 10Dr0ptp4kt: [C: 032] Fix for recent "glasses" icon (when no recent items) being too small. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199156 (owner: 10Mhurd) [23:21:42] bmansurov: i'm confused [23:22:05] PageActionOverlay is created in javascripts/modules/tutorials/init.js [23:22:10] which is in module mobile.newusers [23:22:18] which specifies mobile.editor as a dependency [23:22:28] so page action icons will always be loaded at the time it is created [23:22:44] jdlrobson: yes, and it should point to the pencil icon, but the pencil gets pushed when watchstar or upload icons are rendered [23:23:05] jdlrobson: "Label for count of collection on list of all collections" - is it the number of collections? items in a collection? items in all collections? [23:23:07] but aren't they all loaded at the same time..? [23:23:13] jdlrobson: no guarantee [23:23:15] aharoni: items in collection [23:23:18] cool [23:23:22] jdlrobson: sometimes earlier sometimes later [23:23:23] bmansurov: ok i'll take another look. i thought that was guaranteed [23:23:32] (03PS1) 10Robmoen: Kill onPersonalTools hook as this is being removed on MF [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199159 [23:23:38] bmansurov: we can guarantee it by changing dependencies if necessary.. [23:23:39] (03PS1) 10Bgerstle: use pessimistic version specifiers [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199160 [23:24:06] (03CR) 10Robmoen: [C: 032] "Merging as https://gerrit.wikimedia.org/r/199159 effectively kills the usage MobilePersonalTools hook" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) (owner: 10Jdlrobson) [23:24:24] jdlrobson: I'm not sure. Maybe emit couple more events after each of those buttons are rendered [23:24:59] (03CR) 10Bgerstle: "this is a follow-up from corey's patch that fixes our Gemfile to install the cocoapods version required by Podfile. I also updated our ve" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199160 (owner: 10Bgerstle) [23:26:36] 6Mobile-Web, 10Analytics: Update main menu schema to include collections for limn graphs - https://phabricator.wikimedia.org/T93690#1143524 (10Jdlrobson) 3NEW [23:27:04] (03CR) 10Kaldari: [C: 04-1] "Honestly, I'm pretty skeptical of this change since I think inserting items into menus is one of the few cases where using hooks actually " (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) (owner: 10Jdlrobson) [23:27:15] (03CR) 10Jdlrobson: "see https://phabricator.wikimedia.org/T93690" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197455 (owner: 10Jdlrobson) [23:27:51] wtf is up with jenkins This change was unable to be automatically merged with the current state of the repository [23:28:40] (03CR) 10MaxSem: [C: 04-1] "Agree with Kaldari, this is scary and fragile." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) (owner: 10Jdlrobson) [23:28:42] it broke [23:28:52] it can be safely ignored [23:28:59] releng channel was sorting it out [23:31:54] (03PS3) 10Jdlrobson: Address PHP notice due to use of this [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198787 (https://phabricator.wikimedia.org/T93606) [23:32:00] (03CR) 10Jdlrobson: [C: 031] Address PHP notice due to use of this [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198787 (https://phabricator.wikimedia.org/T93606) (owner: 10Jdlrobson) [23:32:05] (03CR) 10Jdlrobson: [C: 032] Address PHP notice due to use of this [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198787 (https://phabricator.wikimedia.org/T93606) (owner: 10Jdlrobson) [23:34:39] 10Gather, 6MediaWiki-Core-Team: Quick perf review of Gather - https://phabricator.wikimedia.org/T93417#1143544 (10aaron) Would be nice to clean up the primary key as mentioned in CR of course. [23:36:48] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Toggle flag in HockeyApp when iOS update goes live - https://phabricator.wikimedia.org/T93692#1143559 (10dr0ptp4kt) 3NEW [23:36:55] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Toggle flag in HockeyApp when iOS update goes live - https://phabricator.wikimedia.org/T93692#1143566 (10dr0ptp4kt) [23:40:57] 10Wikipedia-App-Android-App: Imagemap does not fit the screen - https://phabricator.wikimedia.org/T87066#1143587 (10bearND) Some redeeming observations: * You can scroll the imagemap horizontally. * In gallery view the image is correctly resized (you can enter it via the other image in the article then swipe left). [23:43:07] (03PS1) 10Robmoen: Watchstar and tutorial were throwing error on special pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199170 [23:43:38] (03Abandoned) 10Amire80: i18n: Drop experimental qqq code messages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199145 (owner: 10Jdlrobson) [23:46:03] rmoen: so what's happening in https://gerrit.wikimedia.org/r/#/c/199170/1/resources/ext.gather.watchstar/init.js ? [23:46:17] is this vector? [23:46:58] 10Gather, 6MediaWiki-Core-Team: Quick perf review of Gather - https://phabricator.wikimedia.org/T93417#1143630 (10Jdlrobson) @aaron T93434 [23:47:50] jdlrobson2: Timo says there’s a security upgrade going on, so everything is stalled in the meantime [23:48:06] any idea of when fixed? [23:49:33] jdlrobson2: this is just on a special page. watchstar is being loaded, also it is asking if it should show tutorial when its not even an article to begin with. [23:49:53] 10Gather, 3Gather Sprint Diplodocus, 6Mobile-Web, 10WikiGrok, 5Patch-For-Review: SkinMinerva should makes it own decisions about rendering the main menu - https://phabricator.wikimedia.org/T93257#1143649 (10kaldari) Max and I don't really agree with the approach here. Let's figure out a better solution f... [23:50:01] jdlrobson2: see how i moved watchstar bit into pageIsArticle block ? [23:50:36] rmoen: it is? but it checks for ca-watch .. [23:50:53] jdlrobson2: are you not getting the erro ? [23:50:55] error [23:51:02] This fixes it for me [23:51:09] http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather that one? [23:51:13] i see... mmm [23:51:27] brb 1 min [23:51:45] rmoen: why not just wrap it all in !page.inNamespace( 'special' ) ? https://gerrit.wikimedia.org/r/#/c/199170/1/resources/ext.gather.watchstar/init.js [23:52:23] (03CR) 10Jdlrobson: Watchstar and tutorial were throwing error on special pages (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199170 (owner: 10Robmoen) [23:52:29] rmoen: but yep i can reproduce now [23:53:13] (03CR) 10Jdlrobson: "Thanks Amir!" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199145 (owner: 10Jdlrobson) [23:53:29] 10Gather, 3Gather Sprint Diplodocus: Populate gather with proper feature name - https://phabricator.wikimedia.org/T92665#1143653 (10Jdlrobson) Amir has updated them on translate wiki. Not sure if anything more to do here JK? [23:53:37] jdlrobson2: ok. i will redo it [23:53:56] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Event logging for Gather onboarding - https://phabricator.wikimedia.org/T92742#1143655 (10Jdlrobson) 5Open>3Resolved [23:56:17] (03PS2) 10Robmoen: Watchstar and tutorial were throwing error on special pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199170 [23:58:08] (03CR) 10Dr0ptp4kt: [C: 032] Avoid cache fragmenting URLs for Share a Fact shares [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/199140 (https://phabricator.wikimedia.org/T90606) (owner: 10BearND) [23:59:56] (03PS3) 10Robmoen: Tweaks for Vector skin styling [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199143 (https://phabricator.wikimedia.org/T92883) (owner: 10Jdlrobson)