[00:00:07] (03PS8) 10Robmoen: Surface page images in collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197256 (owner: 10Jdlrobson) [00:00:18] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Event logging for Gather onboarding - https://phabricator.wikimedia.org/T92742#1119233 (10Jdlrobson) Should be possible to verify by ssh deployment-eventlogging02.eqiad.wmflabs https://meta.wikimedia.org/wiki/Schema:GatherClicks Seems to be an error ho... [00:02:00] (03CR) 10Jdlrobson: Watchstar and tutorial were throwing error on special pages (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199170 (owner: 10Robmoen) [00:02:42] 10Gather, 3Gather Sprint Diplodocus: Populate gather with proper feature name - https://phabricator.wikimedia.org/T92665#1143682 (10JKatzWMF) Excellent, I think we're good, but let's not sign off until we have notified the community. [00:02:53] (03CR) 10Jdlrobson: [C: 032] Tweaks for Vector skin styling [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199143 (https://phabricator.wikimedia.org/T92883) (owner: 10Jdlrobson) [00:04:59] (03CR) 10Kaldari: [C: 04-1] "This seems overly complicated for a first iteration. To meet the acceptance criteria for https://trello.com/c/jeQcrXx8/1-8-aggregate-wikig" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 (owner: 10MaxSem) [00:06:39] (03CR) 10Jdlrobson: "I discussed this with Kaldari and we are being very schizophrenic in how we do this sort of thing. We already use the class_exist methods " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) (owner: 10Jdlrobson) [00:07:05] (03CR) 10MaxSem: "Mmm, 'consensus users' can be removed then, but not rejection criteria, because the lack of it would result in an infinite accumulation of" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 (owner: 10MaxSem) [00:09:35] (03CR) 10Kaldari: "@Jdlrobson: I'm fine with settling this later, but I still want my comments :P" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) (owner: 10Jdlrobson) [00:09:55] (03PS12) 10MaxSem: Claim aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 [00:10:04] kaldari, ^^ [00:10:04] mhurd bad news, bumped the number of sections & images per section up and the tests failed [00:10:24] debugging now.. [00:10:35] bgerstle: hmm [00:13:07] oh, and another problem [00:13:19] the section images (appear to be) getting imported out of order? [00:13:31] since we're doing "for (section in article.section)" [00:13:38] where article.section is a NSSet [00:13:47] same for the images [00:18:14] (03Merged) 10jenkins-bot: Use new schema for main menu click tracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197455 (owner: 10Jdlrobson) [00:18:41] bgerstle: i’m pretty sure they’re in correct order in old core data store [00:19:42] mhurd they have an "index" property which i think determines their order [00:19:54] IIRC you can't store ordered data in CoreData [00:20:06] or at least, it's not guaranteed [00:20:06] (03Merged) 10jenkins-bot: Address PHP notice due to use of this [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198787 (https://phabricator.wikimedia.org/T93606) (owner: 10Jdlrobson) [00:20:19] mhurd which is why all "to many" relationships are sets and not arrays [00:20:31] bgerstle: gimme a sec… [00:22:43] bgerstle: see line 23 here https://github.com/montehurd/apps-ios-wikipedia/blob/32cfec7fef56f39857f661269b1e1c6f25bd195d/wikipedia/Categories/Article%2BConvenience.m [00:23:14] mhurd right, you need to set sort descriptors explicitly [00:23:25] bgerstle: yup. can you just yank that method? [00:23:37] mhurd i'm writing some getter conveniences of my own [00:24:49] bgerstle: k. just note lines 23 and 25 for working image sort by section [00:24:49] https://github.com/btgerst/apps-ios-wikipedia/blob/image-migration-tests/wikipedia/Categories/Article%2BConvenienceAccessors.m#L18 [00:24:51] mhurd ^ [00:25:32] bgerstle: looks like you have a handle on it. just wanted to point out a working method :) [00:25:53] mhurd i'm glad you did, confirmed i'm using the correct props for sorting [00:25:59] i thought i was, but more confident now :-) [00:26:05] bgerstle: yay! :) [00:26:17] for some reason, the migration is bailing out after the 1st not-thumbnail image.. [00:26:26] it's not continuing in the for loop [00:26:46] mhurd just pushed if you want to play around w/ it [00:27:04] bmansurov: so i can't work out the issue with https://gerrit.wikimedia.org/r/#/c/199155/ [00:27:20] the only time page actions changes position is when the upload icon gets removed which is only when uploads is enabled [00:27:25] is that what you are talking about? [00:27:44] (03PS1) 10Yurik: API mode=hidelist & showlist for action=editlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199174 (https://phabricator.wikimedia.org/T93382) [00:27:45] bgerstle: are you fetching more than one? [00:27:48] jdlrobson2: yes, and watchstar too [00:28:05] jdlrobson2, rmoen JonKatz_ ^^^ [00:28:11] mmm [00:28:32] mhurd i'm not fetching anything. i thought the migrator was being passed an array of articles from a fetch request [00:28:34] yurik: yaay i'll have a chance to look soon [00:28:45] i assumed that going through the properties would "fault" the images from the store [00:29:06] bgerstle: nvm. it should fault them as you described… [00:29:13] jdlrobson2, file another issue - add allhidden mode to the action=lists [00:29:22] mhurd IMO there are too many "faults" going on here [00:29:28] bgerstle: for sure [00:29:29] * bgerstle runs away from the horrible pun [00:29:33] lol [00:29:38] (03CR) 10jenkins-bot: [V: 04-1] API mode=hidelist & showlist for action=editlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199174 (https://phabricator.wikimedia.org/T93382) (owner: 10Yurik) [00:29:52] yurik: file a bug otherwise i will forget [00:29:59] too many things going on :) [00:30:05] jdlrobson2, internet is painfuly slow ( [00:30:31] mhurd my current theory is that it has to do w/ how i'm creating the "dummy" article/sections [00:30:39] i'm not managing the relationships properly [00:30:45] so it's a test problem [00:30:47] bgerstle: note line 1413 here: https://github.com/montehurd/apps-ios-wikipedia/blob/32cfec7fef56f39857f661269b1e1c6f25bd195d/wikipedia/View%20Controllers/WebView/WebViewController.m [00:30:54] but, i ended up finding the "out of order" issue anyway :-P [00:31:16] bgerstle: “sectionImage.image.imageData.data” to fault the actual image data [00:31:20] mhurd FYI you can link to specific line if you click it in the gutter [00:31:26] yurik: mail me then with subject create bug :) [00:31:29] bgerstle: ah cool [00:31:32] mhurd yeah, i'm doing that and asserting the correct image data [00:31:39] did you see my "wat?" comment [00:31:40] bgerstle: coo [00:31:42] l [00:32:02] bgerstle: where? [00:32:06] imageData.imageData = image [00:32:20] http://i.imgur.com/wm9Srgj.gif [00:32:20] (03PS2) 10Yurik: API mode=hidelist & showlist for action=editlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199174 (https://phabricator.wikimedia.org/T93382) [00:32:44] the imageData's relationship to its "image" is under its "imageData" property [00:32:57] try to not to think about it too much or your head might hurt [00:33:13] mine certainly does.. [00:33:14] bgerstle: i understand why, but it does make my head hurt :) [00:33:23] bgerstle: not worth going in to [00:33:57] 10Gather: API: For list=lists, add mode=allhidden - https://phabricator.wikimedia.org/T93704#1143718 (10Yurik) 3NEW [00:34:32] (03PS2) 10Jdlrobson: Make page action overlay pointer position correctly. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199155 (https://phabricator.wikimedia.org/T91047) [00:34:46] ^ bmansurov will require a change to Gather as well [00:34:54] 10Gather: API: Log when list gets hidden by an admin - https://phabricator.wikimedia.org/T93705#1143727 (10Yurik) 3NEW [00:36:42] (03CR) 10jenkins-bot: [V: 04-1] Make page action overlay pointer position correctly. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199155 (https://phabricator.wikimedia.org/T91047) (owner: 10Jdlrobson) [00:39:29] (03PS3) 10Jdlrobson: Make page action overlay pointer position correctly. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199155 (https://phabricator.wikimedia.org/T91047) [00:39:56] (03CR) 10Jdlrobson: [C: 031] Tweaks for Vector skin styling [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199143 (https://phabricator.wikimedia.org/T92883) (owner: 10Jdlrobson) [00:40:01] (03PS4) 10Jdlrobson: Tweaks for Vector skin styling [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199143 (https://phabricator.wikimedia.org/T92883) [00:40:06] (03CR) 10Jdlrobson: [C: 032] Tweaks for Vector skin styling [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199143 (https://phabricator.wikimedia.org/T92883) (owner: 10Jdlrobson) [00:40:18] (03CR) 10Bmansurov: Make page action overlay pointer position correctly. (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199155 (https://phabricator.wikimedia.org/T91047) (owner: 10Jdlrobson) [00:40:21] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Invalid argument supplied for foreach() in Collection.php - https://phabricator.wikimedia.org/T93603#1143741 (10Jdlrobson) 5Open>3Resolved [00:40:33] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Only call API dynamically except for special:gather - https://phabricator.wikimedia.org/T92711#1143742 (10Yurik) @jdlrobson, "Going to the database directly" is identical to making an API call - after all, thats exactly what API does for you - it makes... [00:41:45] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: When I go to Special:Gather and see the collections I own they are illustrated with a page image - https://phabricator.wikimedia.org/T91675#1143749 (10Jdlrobson) a:5Jdlrobson>3None [00:42:07] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Event logging for Gather onboarding - https://phabricator.wikimedia.org/T92742#1143750 (10Jdlrobson) 5Resolved>3Open [00:43:00] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: [SchemaGatherClicks] Missing or empty schema - https://phabricator.wikimedia.org/T93706#1143751 (10Jdlrobson) 3NEW a:3Jdlrobson [00:43:28] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Special pages hit the API one two many times. - https://phabricator.wikimedia.org/T93155#1143763 (10Jdlrobson) 5Open>3Resolved [00:43:44] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Incorrect result for loading action=query&list=lists&lstids=X&lstowner=YYY - https://phabricator.wikimedia.org/T93103#1143764 (10Jdlrobson) 5Open>3Resolved [00:44:46] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Undefined property: Gather\models\Collection::$this in Collection.php - https://phabricator.wikimedia.org/T93606#1143766 (10Jdlrobson) 5Open>3Resolved [00:45:39] (03CR) 10Jdlrobson: [C: 04-1] "Sigh needs rebase" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198363 (https://phabricator.wikimedia.org/T93303) (owner: 10Jdlrobson) [00:46:48] (03PS3) 10Jdlrobson: Hygiene: Generalise EventLogging for main menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199124 (https://phabricator.wikimedia.org/T92855) [00:47:05] (03CR) 10Jdlrobson: [C: 032] "Rebased off master. Reapplying Kaldaris' +2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199124 (https://phabricator.wikimedia.org/T92855) (owner: 10Jdlrobson) [00:47:51] (03PS2) 10Jdlrobson: Enable event logging on collections link [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197456 (https://phabricator.wikimedia.org/T92855) [00:47:53] (03PS1) 10MaxSem: Fix notices on bogus language codes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199177 (https://phabricator.wikimedia.org/T93500) [00:48:33] 10Gather, 3Gather Sprint Diplodocus: API: Undefined property: stdClass::$perm in ApiQueryListPages.php - https://phabricator.wikimedia.org/T93604#1143772 (10Yurik) Is it still happening after this morning's fix? [00:48:59] 10Gather, 3Gather Sprint Diplodocus: API: Undefined property: stdClass::$perm in ApiQueryListPages.php - https://phabricator.wikimedia.org/T93604#1143779 (10Jdlrobson) Ping @MaxSem [00:49:29] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Only call API dynamically except for special:gather - https://phabricator.wikimedia.org/T92711#1143781 (10Jdlrobson) K well the patch once merged will defer it till click. [00:50:11] (03Merged) 10jenkins-bot: Tweaks for Vector skin styling [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199143 (https://phabricator.wikimedia.org/T92883) (owner: 10Jdlrobson) [00:50:19] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Generalise EventLogging for main menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199124 (https://phabricator.wikimedia.org/T92855) (owner: 10Jdlrobson) [00:50:29] mhurd bgerstle_away progress is done [00:51:05] (03CR) 10Jdlrobson: [C: 04-1] "We're bikeshedding over on MobileFrontend so let's revisit this after the bikeshed has run its course." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199159 (owner: 10Robmoen) [00:51:11] 10Gather, 3Gather Sprint Diplodocus: API: Undefined property: stdClass::$perm in ApiQueryListPages.php - https://phabricator.wikimedia.org/T93604#1143786 (10MaxSem) 5Open>3Resolved Don't see any. Will reopen if resurfaces. [00:51:56] (03PS2) 10Jdlrobson: Surface last updated time in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198363 (https://phabricator.wikimedia.org/T93303) [00:52:34] 10Gather, 3Gather Sprint Diplodocus: Placeholder: Notify user of list being public before they create it! - https://phabricator.wikimedia.org/T93239#1143789 (10JKatzWMF) [00:52:54] 10Gather, 3Gather Sprint Diplodocus: Notify user of list being public before they create it! - https://phabricator.wikimedia.org/T93239#1143800 (10JKatzWMF) [00:52:55] 10Gather, 3Gather Sprint Diplodocus: API: Undefined property: stdClass::$perm in ApiQueryListPages.php - https://phabricator.wikimedia.org/T93604#1143799 (10Yurik) @maxsem, I suspect it was fixed by https://gerrit.wikimedia.org/r/#/c/198667/ [00:53:22] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Design tweaks for Vector skin - https://phabricator.wikimedia.org/T92883#1143802 (10Jdlrobson) 5Open>3Resolved [00:53:58] (03PS9) 10Jdlrobson: Surface page images in collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197256 [00:54:04] (03CR) 10Jdlrobson: [C: 032] Surface page images in collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197256 (owner: 10Jdlrobson) [00:54:05] jdlrobson2, rmoen, any q for me? or off to bed i go [00:54:32] i have a flight in 11 hrs [00:54:56] can't skip on my beauty sleep [00:55:18] (03Merged) 10jenkins-bot: Surface page images in collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197256 (owner: 10Jdlrobson) [00:55:56] yurik: get some sleep. Going to take me a while to go through it. Plus, we probably want to have multiple eyes on it [00:56:25] rmoen, ok. The good thing - it passes all the unittests i threw at it :D [00:57:39] kaldari: https://gerrit.wikimedia.org/r/#/c/199124/ [00:57:49] coreyfloyd: yay! [00:58:04] coreyfloyd: will check in morning. gonna head out a bit early today [00:58:15] (03PS4) 10Kaldari: Hygiene: Generalise EventLogging for main menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199124 (https://phabricator.wikimedia.org/T92855) (owner: 10Jdlrobson) [00:58:22] (03CR) 10Kaldari: [C: 032] Hygiene: Generalise EventLogging for main menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199124 (https://phabricator.wikimedia.org/T92855) (owner: 10Jdlrobson) [00:58:36] (03CR) 10Jdlrobson: [C: 032] Enable event logging on collections link [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197456 (https://phabricator.wikimedia.org/T92855) (owner: 10Jdlrobson) [00:58:41] (03PS3) 10Jdlrobson: Enable event logging on collections link [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197456 (https://phabricator.wikimedia.org/T92855) [00:58:52] (03CR) 10Jdlrobson: [C: 031] Enable event logging on collections link [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197456 (https://phabricator.wikimedia.org/T92855) (owner: 10Jdlrobson) [00:58:56] (03CR) 10Jdlrobson: [C: 032] Enable event logging on collections link [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197456 (https://phabricator.wikimedia.org/T92855) (owner: 10Jdlrobson) [00:59:30] (03CR) 10Bmansurov: [C: 04-1] "Please see my comments in patchset 2." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199155 (https://phabricator.wikimedia.org/T91047) (owner: 10Jdlrobson) [00:59:49] rmoen: did you see my comment https://gerrit.wikimedia.org/r/#/c/199170/ ? [01:00:51] jdlrobson2: no actually. 1 sec 4 followup [01:01:21] (03CR) 10Jdlrobson: Make page action overlay pointer position correctly. (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199155 (https://phabricator.wikimedia.org/T91047) (owner: 10Jdlrobson) [01:02:56] (03Merged) 10jenkins-bot: Hygiene: Generalise EventLogging for main menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199124 (https://phabricator.wikimedia.org/T92855) (owner: 10Jdlrobson) [01:02:59] (03Merged) 10jenkins-bot: Enable event logging on collections link [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197456 (https://phabricator.wikimedia.org/T92855) (owner: 10Jdlrobson) [01:04:29] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Event logging for hamburger "collections" link - https://phabricator.wikimedia.org/T92855#1122056 (10Jdlrobson) This should be working. @JKatzWMF can you verify. I managed to navigate another path around the bikeshed to get this merged. [01:04:59] rmoen: i'm heading off [01:05:05] i'll merge on the move [01:05:11] (03PS3) 10Robmoen: Only init watchstar on a non special page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199170 [01:06:58] (03CR) 10jenkins-bot: [V: 04-1] Only init watchstar on a non special page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199170 (owner: 10Robmoen) [01:07:26] (03CR) 10Fjalapeno: [C: 031] use pessimistic version specifiers [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199160 (owner: 10Bgerstle) [01:08:23] (03CR) 10Fjalapeno: "migration progress with text is up, also I added a commit on top that adds a progress bar. feel free to use whichever you like. Focker out" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 (owner: 10Bgerstle) [01:45:52] 13 Undefined property: Gather\models\Collection::$this in /srv/mediawiki/php-master/extensions/Gather/includes/models/Collection.php on li [01:45:52] ne 95 [01:45:53] 13 Invalid argument supplied for foreach() in /srv/mediawiki/php-master/extensions/Gather/includes/models/Collection.php on line 97 [01:45:57] from deployment-prep [02:47:52] (03CR) 10MZMcBride: "This is mind-boggling. You're willing to hobble this feature by removing images (cf. ), but outrigh" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194451 (https://phabricator.wikimedia.org/T85929) (owner: 10Legoktm) [03:46:56] (03CR) 10Krinkle: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199170 (owner: 10Robmoen) [04:43:55] 10Wikipedia-App-Android-App: Add option to reload an article - https://phabricator.wikimedia.org/T70627#1144071 (10Deskana) a:5Dbrant>3None [04:44:40] 10Wikipedia-App-Android-App: Enable save of pictures for "saved pages" - https://phabricator.wikimedia.org/T70288#1144088 (10Deskana) a:5Deskana>3None [04:45:12] 10Wikipedia-App-Android-App: Unparseable date crashes - https://phabricator.wikimedia.org/T69372#1144104 (10Deskana) p:5Triage>3Normal a:5Dbrant>3None [04:45:19] 10Wikipedia-App-Android-App: NPEs from page.PageViewFragment.commonSectionFetchOnCatch - https://phabricator.wikimedia.org/T69807#1144107 (10Deskana) p:5Triage>3Normal a:5Dbrant>3None [04:45:40] 10Wikipedia-App-Android-App: Handle the "Search" key (on 2.x devices) - https://phabricator.wikimedia.org/T69324#1144116 (10Deskana) p:5Triage>3Normal a:5Dbrant>3None [04:46:53] 10Wikipedia-App-Android-App: App occasionally closes when too much Activity state is stored. - https://phabricator.wikimedia.org/T68732#1144160 (10Deskana) p:5Triage>3Normal a:5Dbrant>3None [04:47:40] 10Wikipedia-App-Android-App: Refactor PageActivity.onWikipediaZeroInterstitialEvent - https://phabricator.wikimedia.org/T68081#1144189 (10Deskana) p:5Triage>3Normal a:5Dbrant>3None [04:49:28] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android: Hook app up to experimental content service to test the service's viability - https://phabricator.wikimedia.org/T91798#1144202 (10Deskana) [04:49:50] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android, 5Patch-For-Review: Text in error popups not visible in 2.3 - https://phabricator.wikimedia.org/T92851#1144207 (10Deskana) 5Open>3Resolved [04:50:09] 10Wikipedia-App-Android-App: App unexpectedly closes on Samsung Galaxy Ace II X (S7560M) - https://phabricator.wikimedia.org/T76279#1144211 (10Deskana) [04:50:10] 10Wikipedia-App-Android-App: android.os.TransactionTooLargeException (when editing a large page?) - https://phabricator.wikimedia.org/T68872#1144212 (10Deskana) [04:50:11] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android: Cache visited pages in filesystem instead of ram. - https://phabricator.wikimedia.org/T89826#1144209 (10Deskana) 5Open>3Resolved [04:50:12] 10Wikipedia-App-Android-App: OutOfMemoryError crashes from some IO/string building code - https://phabricator.wikimedia.org/T86442#1144213 (10Deskana) [04:57:48] 10Wikipedia-App-Android-App: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1144217 (10Ragesoss) p:5Triage>3High I still run into this. Accidentally not saving your edits under your own account is a pretty significant bug. [04:59:31] Whoops. I locked myself out of this bug by changing the security: https://phabricator.wikimedia.org/T75086 [05:02:16] why did you do that? [05:10:45] (03CR) 10Legoktm: [C: 032] Localisation updates from https://translatewiki.net. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198903 (owner: 10L10n-bot) [05:39:07] Krenair: I did it because it's a bug that results in accidentally posting edits with your IP address when you think you're logged in. So security 'none' didn't seem right. [05:39:33] didn't realize that would mean I couldn't view it any more. [06:56:58] (03CR) 10Florianschmidtwelzow: [C: 04-1] "undefined fixed, but there is now another one :P" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199177 (https://phabricator.wikimedia.org/T93500) (owner: 10MaxSem) [07:01:04] (03PS3) 10Florianschmidtwelzow: Fix close button in ImageOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198767 [07:02:25] (03CR) 10Florianschmidtwelzow: [C: 032] "re-submit" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198767 (owner: 10Florianschmidtwelzow) [07:04:53] (03CR) 10Florianschmidtwelzow: Fix problems with license message (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [07:05:19] (03Merged) 10jenkins-bot: Fix close button in ImageOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198767 (owner: 10Florianschmidtwelzow) [07:16:34] (03CR) 10Florianschmidtwelzow: [C: 04-1] Alpha: Load banner images on page load (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [08:56:13] 6Mobile-Web, 10Flow, 10MediaWiki-General-or-Unknown, 10UI-Standardization, 10Vector: Should be a standard way to access tablet browser width threshold - https://phabricator.wikimedia.org/T93675#1144481 (10Florian) [09:22:16] (03PS1) 10Florianschmidtwelzow: Move wgMFEditorOptions to ResourceLoaderGetConfigVars hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199227 (https://phabricator.wikimedia.org/T93210) [09:24:17] (03CR) 10jenkins-bot: [V: 04-1] Move wgMFEditorOptions to ResourceLoaderGetConfigVars hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199227 (https://phabricator.wikimedia.org/T93210) (owner: 10Florianschmidtwelzow) [09:32:21] (03PS3) 10Yurik: API mode=hidelist & showlist for action=editlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199174 (https://phabricator.wikimedia.org/T93382) [09:36:15] (03PS1) 10Yurik: API added lists query mode=allhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199233 (https://phabricator.wikimedia.org/T93704) [11:28:06] (03PS1) 10Amire80: Add a full stop to a message for consistency [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199249 [11:35:15] (03CR) 10Jhernandez: [C: 032] "I've updated https://www.mediawiki.org/wiki/Extension:Gather#Installation with the extension.json snippet." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199174 (https://phabricator.wikimedia.org/T93382) (owner: 10Yurik) [11:36:04] (03PS1) 10Amire80: Add credits to i18n files [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199252 [11:40:46] (03Merged) 10jenkins-bot: API mode=hidelist & showlist for action=editlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199174 (https://phabricator.wikimedia.org/T93382) (owner: 10Yurik) [11:46:10] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: API: User cannot make their list public (even via API) if moderator has made it private - https://phabricator.wikimedia.org/T93382#1144732 (10Jhernandez) @jkatzwmf Lists now have a permission of public, private or hidden. A list can only become hidden b... [11:46:53] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: API: User cannot make their list public or private (even via API) if moderator has made it hidden - https://phabricator.wikimedia.org/T93382#1144734 (10Jhernandez) [11:50:14] (03CR) 10Jhernandez: [C: 032] Add a full stop to a message for consistency [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199249 (owner: 10Amire80) [11:51:48] ragesoss, do you want me to open https://phabricator.wikimedia.org/T75086 up again? [11:52:13] Assuming you intended to mark it as a privacy issue, rather than making the task itself private [12:23:12] 3Gather Sprint Diplodocus: JS error on special pages without the 'wgGatherCollections' variable - https://phabricator.wikimedia.org/T93738#1144773 (10Jhernandez) 3NEW [12:34:21] (03PS5) 10Jhernandez: Admin can hide a public list in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) [12:34:23] (03CR) 10jenkins-bot: [V: 04-1] Admin can hide a public list in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [12:34:41] (03CR) 10Jhernandez: Admin can hide a public list in Special:GatherLists (034 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [12:36:34] (03PS6) 10Jhernandez: Admin can hide a public list in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) [12:37:56] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: An admin is able to hide or unhide a list. - https://phabricator.wikimedia.org/T91444#1144816 (10Jhernandez) a:5rmoen>3Jhernandez [12:47:24] (03CR) 10Florianschmidtwelzow: Admin can hide a public list in Special:GatherLists (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [12:47:49] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: An admin is able to hide or unhide a list. - https://phabricator.wikimedia.org/T91444#1144822 (10Jhernandez) Patch rebased on working API and fixed/completed from rob's work. Review here: >>! In T91444#1135699, @gerritbot wrote: > Change 198246 had a r... [12:48:08] (03CR) 10Jhernandez: [C: 031] "Alrighty, this is mergeable IMO, uses the merged api for the hidden lists." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [12:52:47] (03CR) 10Jhernandez: "Thanks for the comments Florian! Addressed them." (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [12:52:53] (03PS7) 10Jhernandez: Admin can hide a public list in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) [12:59:17] (03PS1) 10Jhernandez: Fix JS error when wgGatherCollections is not defined [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199257 (https://phabricator.wikimedia.org/T93738) [12:59:24] 3Gather Sprint Diplodocus, 5Patch-For-Review: JS error on special pages without the 'wgGatherCollections' variable - https://phabricator.wikimedia.org/T93738#1144851 (10Jhernandez) a:3Jhernandez [12:59:52] alright out to the gym. BB [13:01:27] (03CR) 10Florianschmidtwelzow: [C: 031] "haven't tested, but looks good." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [13:12:09] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199227 (https://phabricator.wikimedia.org/T93210) (owner: 10Florianschmidtwelzow) [13:24:19] (03PS7) 10Bgerstle: set article imageURL and save image list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 (https://phabricator.wikimedia.org/T92697) [13:25:24] (03CR) 10Bgerstle: "pushed new unit tests (which are now passing). please run manual migration tests in addition to code review" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 (https://phabricator.wikimedia.org/T92697) (owner: 10Bgerstle) [15:31:17] (03PS12) 10Dbrant: Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 [15:31:20] (03CR) 10jenkins-bot: [V: 04-1] Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 (owner: 10Dbrant) [15:32:53] (03PS13) 10Dbrant: Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 [15:37:09] (03PS3) 10Dbrant: [WIP] Remove parenthetical information from lead sentences. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197945 [15:47:39] (03PS4) 10Dbrant: Remove parenthetical information from lead sentences. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197945 (https://phabricator.wikimedia.org/T91792) [15:49:26] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Revamp xcode & makefile for build tasks - https://phabricator.wikimedia.org/T92886#1145262 (10Fjalapeno) a:3Fjalapeno [15:59:22] (03PS1) 10Dbrant: Fix transform of video links in pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/199274 [16:04:09] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1145309 (10NiharikaKohli) Hello! The IRC meeting tomorrow has been shifted to #wikimedia-ect channel. Looking... [16:04:48] (03PS2) 10Amire80: Add credits to i18n files [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199252 [16:06:31] (03PS1) 10Fjalapeno: Setup Xcode to use config files - setting the bundle id based on the configuration. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199276 [16:06:49] bgerstle_afk: ^ [16:08:49] coreyfloyd: k, will take a look after we get this migration stuff wrapped up [16:31:06] (03PS2) 10Fjalapeno: Setup Xcode to use config files - setting the bundle id based on the configuration. - support alpha config in cocoapods - inhibit pod warnings [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199276 [16:32:34] coreyfloyd: couple of questions about the xcconfig patch [16:32:54] 1) do we really need xcconfigs at this point? wouldn't it be sufficient to set the values in the project's settings? [16:33:13] xcconfigs are great for sharing settings *between config*, if we're not doing that, then i don't really see much of a reason for it [16:34:39] bgerstle: LOL - i could put them in the build settigns, and in fact started to, but remembered that you said you wanted to use configs after we talked the other day, so added them now. [16:35:18] yeah, i sorta changed my mind :-P [16:35:26] it's an extra layer of indirection we don't need quite yet [16:35:59] we could even specify one xcconfig for "release" configurations, and put overrides in the build settings [16:36:43] anyway, sorry for the confusion :-P [16:37:29] the other thing, was that i don't think we need the special "alpha" pods workaround [16:37:49] which is also related to the inhibit_all_warnings! [16:37:53] (03PS3) 10Fjalapeno: Setup Xcode to use config files - setting the bundle id based on the configuration. - support alpha config in cocoapods - inhibit pod warnings - Update Schemes to use specified build configurations [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199276 [16:38:32] Maryana leaving us? :o [16:38:34] coreyfloyd: what's different across the schemes? just the "Run" config? [16:39:04] bgerstle: ok feel free to change the settings setup how you want… all I need to be able to do is be able to access the different build configs from the command line and be able to access them via schemes in the xcode UI. [16:39:53] the first part is easy, "-configuration (Release|Debug|...)" [16:40:04] (or however you pass that arg to xcodebuild in fastlane) [16:40:22] bgerstle: from my experience you should explicitly specify which configs you need xcode to map to, if you don't the result is undefined - removing it might work, but it is dumb luck [16:40:39] coreyfloyd: there's a xcodeproj setting for "configuration to use for command line builds [16:40:41] which is the default [16:40:48] but you can specify it explicitly w/ that flag ^ [16:41:02] hangout? [16:41:04] sure [16:45:53] (03CR) 10Bmansurov: Make page action overlay pointer position correctly. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199155 (https://phabricator.wikimedia.org/T91047) (owner: 10Jdlrobson) [17:02:03] 10Gather, 3Gather Sprint Diplodocus: Provide appropriate groups or individuals with - https://phabricator.wikimedia.org/T93771#1145531 (10JKatzWMF) 3NEW [17:07:34] phuedx: still meting up? [17:08:21] dr0ptp4kt: ping [17:08:33] bgerstle: what's up [17:08:34] can we get a quick +2 on https://gerrit.wikimedia.org/r/#/c/199160/ ? [17:08:49] follow-on patch for something coreyfloyd merged yesterday [17:09:23] dr0ptp4kt: also, your emails says you're working w/ baha all day. does that mean you're not available to review the article migration patch? (https://gerrit.wikimedia.org/r/#/c/198432/) [17:10:33] (03PS4) 10Fjalapeno: (WIP) Setup Xcode to use config files - setting the bundle id based on the configuration. - support alpha config in cocoapods - inhibit pod warnings - Update Schemes to use specified build configurations [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199276 [17:10:45] bgerstle: let's do this: get +1s from mhurd and coreyfloyd, and then i'll sneak a peak while we break for my lunch [17:10:52] ok [17:11:01] bgerstle: please make sure they test on ios 6, ios 7, and ios 8 [17:11:09] bgerstle: and you should do the same yourself, of course [17:11:24] dr0ptp4kt: yep, tested on the iOS 8 sim, will use my iOS 6 iPod now [17:12:11] dr0ptp4kt: i did my work in 2 commits, the first adds progress as text, the second replaces the spinner with a progress bar - take it or leave it, dealers choice. [17:14:30] bgerstle: whoa - if you do want to use config files, this is the bees knees… http://jamesdempsey.net/2015/01/31/generating-xcode-build-configuration-files-with-buildsettingextractor-xcodeproj-to-xcconfig/ [17:14:32] 10Gather, 3Gather Sprint Diplodocus: Provide appropriate groups or individuals with 'gather-admin' priveleges - https://phabricator.wikimedia.org/T93771#1145572 (10JKatzWMF) [17:16:23] coreyfloyd: that's pretty cool, would be useful to copy & modify settings across configs (though you'd probably be best off removing redundant settings) [17:17:23] \o [17:18:14] (03PS1) 10Dbrant: Resolve redirects when doing prefixsearch. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/199285 [17:18:24] jdlrobson2: o/ [17:18:45] 10Wikipedia-App-iOS-App: Run unit tests before builds and save build reports for viewing - https://phabricator.wikimedia.org/T91788#1145597 (10Deskana) [17:18:49] (03PS4) 10Jdlrobson: Only init watchstar on a non special page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199170 (https://phabricator.wikimedia.org/T93738) (owner: 10Robmoen) [17:18:57] (03CR) 10Jdlrobson: [C: 032] Only init watchstar on a non special page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199170 (https://phabricator.wikimedia.org/T93738) (owner: 10Robmoen) [17:19:26] (03CR) 10Jdlrobson: [C: 04-1] "https://gerrit.wikimedia.org/r/#/c/199170/ is probably better since it avoids calling the code altogether on the special page where not ne" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199257 (https://phabricator.wikimedia.org/T93738) (owner: 10Jhernandez) [17:19:47] (03PS3) 10Jdlrobson: i18n: Add credits to i18n files [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199252 (owner: 10Amire80) [17:19:54] (03CR) 10Jdlrobson: [C: 032] i18n: Add credits to i18n files [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199252 (owner: 10Amire80) [17:21:04] joakino: can you take a look at https://gerrit.wikimedia.org/r/#/c/199079/ ? just check it works as expected. Not sure how we'll get it merged otherwise? Maybe kaldari can help :) [17:30:36] (03Merged) 10jenkins-bot: Only init watchstar on a non special page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199170 (https://phabricator.wikimedia.org/T93738) (owner: 10Robmoen) [17:30:38] (03Merged) 10jenkins-bot: i18n: Add credits to i18n files [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199252 (owner: 10Amire80) [17:32:51] coreyfloyd: i'm going to test on my iOS 6 ipod now. will you try on iOS 7 sim/device? [17:32:57] i did iOS 8 sim (iPhone 6) earlier [17:35:06] dr0ptp4kt: should we upload the next alpha build to the "stable" app ID? that way elena et. al can download the app from the app store, build a history/saved database, then download the bug fix from TF stable? [17:41:41] (03PS1) 10Fjalapeno: Add text progress to migration Move migration to background thread / context [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199299 [17:42:53] (03PS1) 10Fjalapeno: Add progress line to data migration [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199300 [17:43:49] bgerstle: yes [17:43:54] dr0ptp4kt: ^^ [17:45:21] bgerstle: yeah, let us use that plan. it will be important that we (1) cancel the current stable submission, (2) add the testflight, (3) do the testing, THEN (4) resubmit the app. there seems to be a glitch in the client tf app allowing one to reinstall on top of a build otherwise [17:46:02] 10Gather, 3Gather Sprint Diplodocus: Update url schemas - https://phabricator.wikimedia.org/T93774#1145796 (10Jdlrobson) 3NEW [17:46:19] dr0ptp4kt: you're saying the "tfbeta" app id is installing over the app store version? [17:47:32] bgerstle: no, i'm referring to org.wikimedia.wikipedia. i'll handle steps 1-4 :) [17:47:52] k [17:48:10] about to test on iOS 6 now.. [17:48:33] 3Gather Sprint Diplodocus: Provide appropriate groups or individuals with 'gather-admin' priveleges - https://phabricator.wikimedia.org/T93771#1145827 (10Jdlrobson) [17:48:47] 3Gather Sprint Diplodocus: Provide appropriate groups or individuals with 'gather-admin' priveleges - https://phabricator.wikimedia.org/T93771#1145531 (10Jdlrobson) (Removed project since it doesn't require any changes to Gather) [17:49:38] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Project wide list of collections should be sorted by last modified date - https://phabricator.wikimedia.org/T93303#1133918 (10Jdlrobson) https://gerrit.wikimedia.org/r/198363 **still** needs to be merged [17:53:03] (03PS4) 10Jdlrobson: Make page action overlay pointer position correctly. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199155 (https://phabricator.wikimedia.org/T91047) [17:53:43] 10Gather, 6Mobile-Web, 10WikiGrok, 5Patch-For-Review: SkinMinerva should makes it own decisions about rendering the main menu - https://phabricator.wikimedia.org/T93257#1145887 (10Jdlrobson) [17:54:14] 3Gather Sprint Diplodocus, 5Patch-For-Review: JS error on special pages without the 'wgGatherCollections' variable - https://phabricator.wikimedia.org/T93738#1145889 (10Jdlrobson) 5Open>3Resolved [17:55:29] coreyfloyd: just hit an assertion while migrating the "glacier nat'l park" article. has to do w/ the order images are imported. debugging now [17:55:58] (03PS8) 10Fjalapeno: set article imageURL and save image list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 (https://phabricator.wikimedia.org/T92697) (owner: 10Bgerstle) [17:56:08] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Services, 3Mobile-App-Sprint-53-Android: Deploy experimental version of mobile apps content service - https://phabricator.wikimedia.org/T91794#1145896 (10bearND) Yippeeee! The nodejs service is running on labs. Example: https://appservice.wmflabs.org/e... [17:56:19] (03PS4) 10Jdlrobson: Defer loading of collections till watchlist click [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198165 (https://phabricator.wikimedia.org/T92573) [17:56:34] bgerstle: ^ that removed a broken file in the build phase - may have been present on your lappy, but not mine [17:56:45] hm, interesting [17:57:26] bgerstle: wait - need to relink… [17:57:41] bgerstle: it was linking to your wikipedia-ios-2 folder [17:57:48] oh weird [17:57:54] path should've been relative [17:57:58] are any other files doing that? [17:58:37] apparently all the OldDataSchemaMigrator files are [17:58:39] coreyfloyd: want me to fix it? [17:58:54] (03PS9) 10Fjalapeno: set article imageURL and save image list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 (https://phabricator.wikimedia.org/T92697) (owner: 10Bgerstle) [17:58:59] bgerstle: done [17:59:33] bgerstle: do you have a documents folder you want me to test? [17:59:35] hm, the path is still showing up in the project.pbxprojf or me [17:59:46] running grep -r 'wikipedia-ios-2' Wikipedia.xcodeproj [17:59:48] weird… [18:02:24] coreyfloyd: fixed it, the "Data Migration" group was pointing to ".." [18:02:27] * bgerstle faceplams [18:02:31] palms* [18:03:35] coreyfloyd: ^ [18:03:49] ahh… [18:03:53] ok [18:04:05] coreyfloyd: uploading an .xcarchive you can test w/ [18:04:22] debugging something in the meantime [18:04:31] k [18:05:07] coreyfloyd: https://www.dropbox.com/s/buo8orplkv1o3p5/org.wikimedia.wikipedia.developer%202015-03-24%2013.43.40.633.xcappdata.zip?dl=0 [18:05:23] you should be able to build & run the patch right on top of that to try migration [18:05:40] install via Xcode -> Devices [18:07:04] dr0ptp4kt: mhurd can we please get a +2 on https://gerrit.wikimedia.org/r/#/c/199160/ ? i keep getting "sandbox out of sync" when pulling changes [18:07:16] mhurd: you got it? [18:07:48] as a side note, when do coreyfloyd and I get our +2 hammers? [18:10:46] (03PS11) 10Bgerstle: set article imageURL and save image list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 (https://phabricator.wikimedia.org/T92697) [18:11:06] coreyfloyd: *seriously* fixed the olddatamigrator project issue ^. also re-committed the Podfile.lock to prevent sandbox errors while the other patch is getting merged [18:11:24] hammer time http://nintendolegend.com/wp-content/uploads/2013/07/ice_climber.gif [18:11:50] i actually never played ice climbers [18:11:56] except as a character(s) in Smash Bros. Melee [18:12:42] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Services, 3Mobile-App-Sprint-53-Android: Deploy experimental version of mobile apps content service - https://phabricator.wikimedia.org/T91794#1145998 (10mobrovac) Good! I'll put some work in tomorrow to create various init scripts (upstart/systemd) so... [18:17:28] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Services, 3Mobile-App-Sprint-53-Android: Deploy experimental version of mobile apps content service - https://phabricator.wikimedia.org/T91794#1146003 (10GWicke) @mobrovac, lets try to generalize / template init scripts for service-runner services to a... [18:18:42] (03PS3) 10MaxSem: WIP: submission [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 [18:18:44] (03CR) 10jenkins-bot: [V: 04-1] WIP: submission [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 (owner: 10MaxSem) [18:18:48] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Services, 3Mobile-App-Sprint-53-Android: Deploy experimental version of mobile apps content service - https://phabricator.wikimedia.org/T91794#1146019 (10mobrovac) >>! In T91794#1146003, @GWicke wrote: > @mobrovac, lets try to generalize / template ini... [18:19:25] Maryana, yer at home? still recovering? :P [18:19:47] dbrant|brb, bearND: If I build the app on the command line, where does the APK go? [18:19:56] dbrant|brb, bearND: The build seemed to succeed but I can't find it. [18:19:57] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Services, 3Mobile-App-Sprint-53-Android: Deploy experimental version of mobile apps content service - https://phabricator.wikimedia.org/T91794#1146020 (10GWicke) @mobrovac: kk, great! [18:20:21] Deskana: [repo_dir]/releases [18:20:35] dbrant: There's nothing in that folder. :-/ [18:20:37] Deskana: wikipedia/build/outputs/apk [18:20:55] bearND: And that folder doesn't exist. [18:21:06] Deskana: dbrant: the releases folder is only used by the make-release.py script [18:21:14] dan-garry:android-wikipedia dgarry$ ./gradlew -q assembleAlphaDebug [18:21:14] signing.properties not found [18:21:14] Note: Some input files use or override a deprecated API. [18:21:16] Note: Recompile with -Xlint:deprecation for details. [18:21:18] Note: Some input files use unchecked or unsafe operations. [18:21:20] Note: Recompile with -Xlint:unchecked for details. [18:21:22] That's what I got. [18:21:26] But the /releases folder is empty. [18:21:37] Deskana: wikipedia/build/outputs/apk [18:22:12] Deskana: which part of the path does not exist? [18:22:37] outputs/ doesn't exist [18:23:01] (03CR) 10Jhernandez: "Agreed, but given that Object.keys(null) throws an exception I don't think this null check is unnecessary. Whatever you guys want @jdlrobs" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199257 (https://phabricator.wikimedia.org/T93738) (owner: 10Jhernandez) [18:23:40] Deskana: so, you only have intermediate and such in the build folder? That looks like the build did not succeed [18:24:19] Correct. intermediates is the only thing [18:24:23] Deskana: there's the "build" folder just under the repo dir, but also under [repo dir]/wikipedia/build/outputs/apk [18:25:14] Deskana: yeah, what dbrant said. Make sure you check the one inside the wikipedia (=app) folder [18:25:34] I'm an idiot. [18:25:36] Thank you. [18:26:19] 6Mobile-Web: Image description is not inserted into the correct paragraph - https://phabricator.wikimedia.org/T93241#1146044 (10Sumit) The image given has a long author description which is appearing in license section, as for the description, the image does have one, but it isn't shown in mobile image viewer,(... [18:32:51] bgerstle: what causes the thumbnail assertion to be hit - I mean I can read the assertion message, but where do I look to fix it [18:33:34] coreyfloyd: the problem *i think* and you can confirm, is that even though savedArticle contains an article we just imported, the "containsObject:" test never passes, so we will import it a second time [18:33:39] so the article is read from the data store [18:33:51] (03CR) 10Kaldari: Fix problems with license message (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [18:33:59] and then since all of the image-related stuff is append only, we get dupe & out-of-order images [18:34:30] so, we can either do a hack where we alloc/init the article instead of reading it from the data store, but IMO the root cause should be addressed [18:34:50] although i'm reluctant to fix it, now that i think about it, as it could have farther reaching implications.. [18:35:23] well, i'll try it the "right" way first [18:36:23] bmansurov: I left a comment on this patch: https://gerrit.wikimedia.org/r/#/c/199178/ [18:36:34] bmansurov: It's entirely possible I'm simply misunderstanding, but I thought I'd ask anyway. :-) [18:37:10] bgerstle: ok - gotcha - anything you need me to fix while you are working on this? Otherwise I will pluck one of those tickets out of the backlog [18:37:35] coreyfloyd: if you confirmed everything else seems to work, then i can focus on this for a bit and ping you [18:37:40] although i should probably break for lunchat this point [18:38:05] bgerstle: ok - let me comment that line out and run again… [18:38:50] 6Mobile-Web: Lists should have greater line-height to improve readability - https://phabricator.wikimedia.org/T93784#1146093 (10KHammerstein) 3NEW [18:38:52] bgerstle: yeah everything else looks good [18:39:21] k [18:39:37] (03PS2) 10Bgerstle: use pessimistic version specifiers [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199160 [18:39:51] dr0ptp4kt: mhurd rebased ^ [18:40:00] bgerstle: sorry was afk [18:40:06] (03CR) 10Jhernandez: [C: 031] "Works great" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199079 (https://phabricator.wikimedia.org/T93385) (owner: 10Jdlrobson) [18:40:11] np [18:40:57] (03CR) 10Mhurd: [C: 032] use pessimistic version specifiers [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199160 (owner: 10Bgerstle) [18:41:20] woohoo [18:46:52] 6Mobile-Web: Multiple column layouts should be ignored on mobile - https://phabricator.wikimedia.org/T93786#1146118 (10KHammerstein) 3NEW [18:53:05] bgerstle: where does the image meta get loaded - is that a seperate fetcher? [18:53:26] coreyfloyd: WMFImageInfoFetcher + WMFImageInfoResponseSerializer [18:53:41] bgerstle: thanls [18:53:50] (03PS3) 10Robmoen: List creation and editing validation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 [19:03:49] 10Wikipedia-App-iOS-App: 4.0.7.8 - NSURLErrorDomain error code -999 with the first login - https://phabricator.wikimedia.org/T93789#1146165 (10Etonkovidova) 3NEW [19:10:40] bgerstle: where are you stripping the html from the image description? [19:11:34] coreyfloyd: i would've thought in the response serializer [19:11:35] bgerstle: nm found it [19:11:37] def not in the model [19:16:14] (03CR) 10Jhernandez: [C: 032] "Awesome." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199233 (https://phabricator.wikimedia.org/T93704) (owner: 10Yurik) [19:18:03] (03Merged) 10jenkins-bot: API added lists query mode=allhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199233 (https://phabricator.wikimedia.org/T93704) (owner: 10Yurik) [19:21:42] 10Gather, 3Gather Sprint Diplodocus: API: Correctly respond when I do not have the gather-hide-list right. - https://phabricator.wikimedia.org/T93793#1146248 (10Jdlrobson) 3NEW [19:22:12] 10Gather, 3Gather Sprint Diplodocus: Update url schemas - https://phabricator.wikimedia.org/T93774#1146257 (10Jhernandez) I'll take on this tomorrow if nobody has :D [19:23:02] (03CR) 10Jdlrobson: [C: 032] Admin can hide a public list in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [19:23:39] 10Gather, 3Gather Sprint Diplodocus: PHP warnings on Special:GatherLists - https://phabricator.wikimedia.org/T93794#1146259 (10Jdlrobson) 3NEW [19:24:49] anyone seen rmoen today? [19:25:23] Deskana: thanks for the comment, I have replied in the patch. [19:25:37] 3Gather Sprint Diplodocus: Provide appropriate groups or individuals with 'gather-admin' priveleges - https://phabricator.wikimedia.org/T93771#1146273 (10Jdlrobson) a:3JKatzWMF @JKatzWMF by default all sysops have this right. Let me know if that's not a good enough default. Can I assign this to you? [19:26:32] (03Merged) 10jenkins-bot: Admin can hide a public list in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198246 (https://phabricator.wikimedia.org/T91444) (owner: 10Jhernandez) [19:26:36] 10Gather, 3Gather Sprint Diplodocus: Admin tools do not show up in Special:GatherList on Vector or mobile stable - https://phabricator.wikimedia.org/T93795#1146276 (10Jdlrobson) 3NEW [19:27:01] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: An admin is able to hide or unhide a list. - https://phabricator.wikimedia.org/T91444#1146292 (10Jdlrobson) 5Open>3Resolved One slight issue with this is captured in T93795 [19:28:15] jdlrobson2: nopee [19:28:20] jdlrobson2: i'm heading out [19:28:24] joakino: :( i rreaallllyy need him today [19:28:25] do you need anything? [19:28:34] :( [19:28:46] joakino: no you go you've done enough :) https://gerrit.wikimedia.org/r/#/c/198165/ has been driving me mad [19:28:50] has sat there for so long [19:30:13] jdlrobson2: do you mind if i take over it tomorrow? [19:30:40] jdlrobson2: if you can send me an email later with stuff i can take over, the -1 column is packed [19:31:32] joakino: no [19:31:34] no problen [19:31:35] :) [19:31:43] i'm sure rmoen will turn up [19:31:45] 👍 [19:31:54] have a nice day! [19:36:24] (03CR) 10Jdlrobson: [C: 04-1] "I'm going to fix this up before merging." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 (owner: 10Robmoen) [19:37:19] (03PS4) 10Jdlrobson: List creation and editing validation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 (owner: 10Robmoen) [19:37:21] (03CR) 10jenkins-bot: [V: 04-1] List creation and editing validation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 (owner: 10Robmoen) [19:39:28] (03PS7) 10Florianschmidtwelzow: Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) [19:40:11] (03PS5) 10Jdlrobson: List creation and editing validation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 (owner: 10Robmoen) [19:41:04] (03CR) 10Jdlrobson: [C: 04-1] "-1 ing to get your attention about this concern" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 (owner: 10Robmoen) [19:41:26] 10Gather, 3Gather Sprint Diplodocus: Toast should clip long collection titles - https://phabricator.wikimedia.org/T93797#1146310 (10Jdlrobson) 3NEW [19:41:40] (03CR) 10jenkins-bot: [V: 04-1] Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [19:42:09] (03CR) 10jenkins-bot: [V: 04-1] List creation and editing validation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 (owner: 10Robmoen) [19:44:25] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Description text is not normalized in galleries. - https://phabricator.wikimedia.org/T93662#1146319 (10Fjalapeno) a:5BGerstle-WMF>3Fjalapeno [19:45:22] (03PS1) 10Florianschmidtwelzow: Alternative syntax such as "X" should not be used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199315 [19:45:53] coreyfloyd: mhurd dr0ptp4kt has anyone tried going to the background during a migration and then resuming? [19:46:22] bgerstle: no [19:46:28] bgerstle: i haven't, but that's a very good thing to test [19:48:16] bgerstle: i have not [19:52:40] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [19:53:53] mhurd dr0ptp4kt bgerstle FYI this is the sound I setup for xcode to play when tests fail… https://www.youtube.com/watch?v=1ytCEuuW2_A [19:54:31] coreyfloyd: lol!!! [19:54:34] coreyfloyd: seriously? [19:54:39] that's awesome [19:54:41] coreyfloyd: i love it [19:54:45] yep [19:55:28] coreyfloyd: :) [19:56:59] if you are going to fail, fail in style [19:58:02] (03PS8) 10Florianschmidtwelzow: Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) [20:01:52] (03PS14) 10Dbrant: Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 [20:02:55] 10Gather: Use extension.json, deprecate use of Gather.php for registering config - https://phabricator.wikimedia.org/T91802#1146397 (10Jdlrobson) a:5Yurik>3None [20:03:30] 3Gather Sprint Diplodocus: Update schema to incorporate feedback from Aaron and Sean - https://phabricator.wikimedia.org/T93434#1146403 (10Jdlrobson) Ping. @yurik what is happening with this? [20:06:58] (03CR) 10Phuedx: [C: 032] "Lolololol!" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/199123 (owner: 10MaxSem) [20:08:51] (03Merged) 10jenkins-bot: Fix an overly flamboyant name:P [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/199123 (owner: 10MaxSem) [20:13:43] mhurd dr0ptp4kt coreyfloyd observe how global state and race conditions combine to form this horrifically beautiful stack trace: https://www.dropbox.com/s/kmd0kyeqyj41f30/article%20image%20list%20race%20condition.png?dl=0 [20:13:50] (03CR) 10Phuedx: [C: 031] "MaxSem, Kaldari{,2}: is there any way we can make this more efficient, i.e. not hit the DB? I've had a wee look around the codebase but ha" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [20:14:03] bgerstle: i’d rather not ;) [20:14:11] which thread will create the image list first? who will save it to disk? [20:14:54] dbrant: are you planning more changes for the single WebView patch (https://gerrit.wikimedia.org/r/#/c/197346/14)? [20:15:30] bearND: nope! it's ready. [20:15:59] mhurd it appears as though the data migration isn't completely blocking the rest of the app launch execution flow [20:16:15] i.e. when i start up the app to do a migration, the main VC tries to reload the current article [20:16:52] (03CR) 10Robmoen: "Thanks for feedback. I agree that the API needs support for this." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 (owner: 10Robmoen) [20:17:12] jdlrobson2: also, my tests are not running and I cannot figure out why [20:17:13] dbrant: ok, great. I'm going to base my patch onto this. Should we wait merging it until next week/closer to the actual release? [20:18:29] bearND: yeah, probably wait til next week [20:19:12] bgerstle: inside the migrateData method add “[context.mainContext performBlockAndWait:” at the very start and capture everything in the method [20:19:18] mhurd specifically "reloadCurrentArticleInvalidatingCache:" is called in viewDidLoad regardless of whether or not migration is happening [20:19:18] (03PS3) 10Deskana: DO NOT MERGE - Wikidata description editing prototype [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197733 [20:19:35] mhurd we don't want to literally block the main thread [20:19:48] ideally, we would not do *anything* w/ the main app until data migration is finished [20:19:50] (03CR) 10jenkins-bot: [V: 04-1] DO NOT MERGE - Wikidata description editing prototype [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197733 (owner: 10Deskana) [20:19:55] but since we're triggering the migration from the main view controller... [20:20:14] mhurd can you think of an easy way we can defer the WebViewController instantiation until after data migration is done? [20:20:24] bgerstle: ah, checking… [20:22:18] rmoen: yo [20:22:49] jdlrobson2: see my ping above ? [20:22:50] (03CR) 10MaxSem: [C: 04-1] "Yep, ParserOutput has the properties." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [20:22:59] phuedx, ^ [20:23:52] rmoen: just saw comment about tests [20:24:00] rmoen: will take a look [20:24:02] kaldari: https://phabricator.wikimedia.org/T93385 [20:24:09] https://gerrit.wikimedia.org/r/199079 < kaldari [20:24:27] jdlrobson2: thanks [20:24:41] rmoen: in mean time can you push https://gerrit.wikimedia.org/r/#/c/198363/ through so we can close out that card? [20:24:53] ergg actually wait i've got yet another rebase issue [20:24:58] (03CR) 10Jdlrobson: [C: 04-1] Surface last updated time in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198363 (https://phabricator.wikimedia.org/T93303) (owner: 10Jdlrobson) [20:25:17] yuri said that https://gerrit.wikimedia.org/r/198165 was a blocker for moving to production too [20:25:21] so would appreciate that getting merged [20:25:58] then we just have to work out the page images stuff, warning stuff and EL stuff [20:26:06] everything else is not vital [20:26:54] rmoen: so in terms of your comment - is there any value in adding this? it will only work on the last 10 lists [20:27:22] i'm not sure why the tests wouldn't be running [20:27:28] jdlrobson2: yeah it describes the api needed for validating [20:27:39] also it does work if they have less than 10 collections [20:27:51] thats why there is a fixme on it. [20:28:06] what happens if you give it an existing name and it's not in those 10 collections [20:28:08] does it throw an error? [20:28:30] (03CR) 10Kaldari: [C: 04-1] Run AbuseFilter filters against Gather titles and descriptions (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199079 (https://phabricator.wikimedia.org/T93385) (owner: 10Jdlrobson) [20:28:43] no, because it deems it as valid.. is this a trick question ? how can it throw an error if it doesn't know about it ? [20:29:54] so the api allows the creation of lists with multiple names? [20:30:22] with /duplicate/ names [20:31:20] (03PS4) 10Deskana: DO NOT MERGE - Wikidata description editing prototype [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197733 [20:31:28] * bgerstle dons his surgical gloves [20:31:46] (03CR) 10jenkins-bot: [V: 04-1] DO NOT MERGE - Wikidata description editing prototype [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197733 (owner: 10Deskana) [20:32:19] rmoen in terms of tests they are failing due to a syntax error from what i see (but note jenkins doesn't run them https://phabricator.wikimedia.org/T91708) [20:32:57] jdlrobson2: thanks [20:33:01] Uncaught SyntaxError: Unexpected token : in CollectionsApi L139 [20:33:29] jdlrobson2: I see that now thank you [20:33:31] bad rebase prob my bad return this.postWithToken( 'watch', { [20:33:32] dbrant: Did you see the email from Google? [20:33:53] Deskana: yep!! I can take care of updating the screenshots and hi-res icon. [20:35:02] Deskana: Vibha suggests using [[Atlantic puffin]] as the subject for screenshots. Any objections? [20:35:27] dbrant: excellent. You could use the same screenshots for the beta app as well. (Just the hi-res launcher icons needs to be different) [20:35:28] rmoen: in terms of the duplicate names, it feels weird merging something which only works under certain circumstances. I really feel like we should do that bit in the api. I'm fine merging it provided we create a bug documenting the issues with the current approach. [20:35:45] dbrant: Nope! [20:36:50] jdlrobson2: I understand, I completely agree the api is not complete. We have wrote code before which described an api, which is why this seemed appropriate. [20:40:43] bmansurov, was that you: https://www.wikidata.org/w/index.php?title=Q10800557&diff=204702901&oldid=204276283 ? [20:41:35] MaxSem: yeah, i was testing the script [20:41:53] got the subject id wrong ;) [20:42:14] careful, don't be blocked as a vandal! :P [20:42:26] (03PS3) 10Jdlrobson: Run AbuseFilter filters against Gather titles and descriptions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199079 (https://phabricator.wikimedia.org/T93385) [20:42:27] MaxSem: it was your WikiGrok account haha [20:42:32] ^ kaldari [20:42:44] not mine. it belongs to your employer ;) [20:43:03] no one would block themselves then [20:43:08] (03PS5) 10Jdlrobson: Defer loading of collections till watchlist click [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198165 (https://phabricator.wikimedia.org/T92573) [20:44:36] dbrant, bearND: Nice work, you too! [20:44:39] *two [20:45:03] Deskana: thx! (I'll believe it when I see it!) [20:45:09] dbrant: Yes ;-) [20:45:09] :) [20:45:28] (03PS3) 10Jdlrobson: Surface last updated time in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198363 (https://phabricator.wikimedia.org/T93303) [20:45:41] (03PS1) 10Fjalapeno: Fix Bug T93662 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199324 [20:47:17] dr0ptp4kt: ^ [20:47:58] dr0ptp4kt bgerstle mhurd I'm out for a bit… need to break. You guys need anything before I bounce? [20:48:11] coreyfloyd: no i’m good [20:48:17] coreyfloyd: no, hope to get this VC stuff done and take a break soon myself [20:48:23] coreyfloyd: nah, i'm good. talking with bmansurov all day... [20:48:25] ok [20:48:40] dr0ptp4kt: mhurd ok - I have several patches up for however can look them over [20:49:02] coreyfloyd: will do [20:49:15] (03CR) 10jenkins-bot: [V: 04-1] Surface last updated time in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198363 (https://phabricator.wikimedia.org/T93303) (owner: 10Jdlrobson) [20:52:17] (03PS5) 10Deskana: DO NOT MERGE - Wikidata description editing prototype [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197733 [20:53:45] (03PS6) 10Jdlrobson: Defer loading of collections till watchlist click [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198165 (https://phabricator.wikimedia.org/T92573) [20:54:08] (03CR) 10jenkins-bot: [V: 04-1] DO NOT MERGE - Wikidata description editing prototype [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197733 (owner: 10Deskana) [20:56:03] mhurd i think i got it! [20:57:01] the transition isn't too great, but it works [20:57:47] bgerstle: yay! [20:58:17] mhurd i think i'm going to push what i have and then take a break [20:58:34] bgerstle: sounds good [20:58:35] the current flow is needsMigration -> data migrator -> migration done -> show rootVC w/ splash image -> webview [20:58:44] (03CR) 10Robmoen: [C: 032] Defer loading of collections till watchlist click [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198165 (https://phabricator.wikimedia.org/T92573) (owner: 10Jdlrobson) [20:59:00] so, we can definitely spruce up the migration a bit and make the transition a bit more seamless [20:59:04] bgerstle: could even skip the splash? no worry for now though [20:59:09] mhurd yeah [20:59:25] bgerstle: takeabreak! [20:59:31] :) [20:59:32] k want to have a crack at it? [20:59:37] bgerstle: sure [20:59:46] bgerstle: is it up on gerrit? [21:00:11] mhurd will be shortly [21:00:18] bgerstle: cool [21:00:30] mhurd here's the data i've been using to test: https://www.dropbox.com/s/48oxunt9ez966dc/4.0.6%20test%20data.zip?dl=0 [21:00:35] you can install it in the sim or on a device [21:01:13] bgerstle: ah thanks. use the “replace container” in device manager [21:01:26] iirc [21:01:55] mhurd precisely [21:02:03] yay [21:02:04] and right click -> show package contents -> copy/paste for sim [21:02:17] bgerstle: ah thanks [21:02:31] (03PS12) 10Bgerstle: set article imageURL and save image list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 (https://phabricator.wikimedia.org/T92697) [21:02:33] mhurd ^ [21:02:39] bgerstle: woohoo! [21:03:02] (03PS1) 10Robmoen: Inform the user when they are creating a public collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199328 [21:04:09] mhurd i'm going to step out for a bit, but ping me if you have a question (or just call my cell, might be easier) [21:04:22] bgerstle: sounds good! thx! [21:04:44] (03PS13) 10Bgerstle: set article imageURL and save image list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 (https://phabricator.wikimedia.org/T92697) [21:05:32] (03PS14) 10Bgerstle: set article imageURL and save image list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 (https://phabricator.wikimedia.org/T92697) [21:05:38] mhurd just rebasing & fixing something that conflicted w/ my earlier patch (the one about version specifiers) [21:05:45] now i'm stepping out [21:05:48] bgerstle: see ya! [21:08:54] 10Wikipedia-App-Android-App: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1146550 (10Krenair) Have discussed with @Ragesoss, marking this as private was an accident. There's nothing exploitable here. [21:08:55] 10Wikipedia-App-Android-App: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1146551 (10Krenair) [21:09:04] (03PS4) 10Robmoen: Surface last updated time in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198363 (https://phabricator.wikimedia.org/T93303) (owner: 10Jdlrobson) [21:10:37] (03CR) 10Robmoen: [C: 032] Run AbuseFilter filters against Gather titles and descriptions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199079 (https://phabricator.wikimedia.org/T93385) (owner: 10Jdlrobson) [21:16:09] (03PS5) 10Jdlrobson: Make page action overlay pointer position correctly. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199155 (https://phabricator.wikimedia.org/T91047) [21:17:11] (03CR) 10Jdlrobson: [C: 032] Inform the user when they are creating a public collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199328 (owner: 10Robmoen) [21:17:46] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Notify user of list being public before they create it! - https://phabricator.wikimedia.org/T93239#1146578 (10Jdlrobson) a:5JKatzWMF>3rmoen [21:18:48] 10Gather, 3Gather Sprint Diplodocus: PHP warnings on Special:GatherLists - https://phabricator.wikimedia.org/T93794#1146595 (10rmoen) a:3rmoen [21:20:18] Deskana: update complete. [21:20:37] bearND: got to run for a bit; i'll update the beta screenshots later [21:20:59] dbrant: sounds good. Thanks [21:21:52] (03PS1) 10Robmoen: Resolve php and hhvm warnings on Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199361 [21:22:41] dbrant|brb: We probably need to rewrite the "What's new", right? [21:22:44] dbrant|brb: It doesn't seem right. [21:23:07] (03CR) 10Robmoen: [C: 032] Surface last updated time in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198363 (https://phabricator.wikimedia.org/T93303) (owner: 10Jdlrobson) [21:25:13] dr0ptp4kt: Can you add Katie Horn and Sherah Smith to the iOS beta? They're curious about it! [21:30:11] (03CR) 10Jdlrobson: [C: 04-1] "One more thing.. I'm using this to replicate:" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199361 (owner: 10Robmoen) [21:30:14] greg-g: yo [21:30:20] greg-g: got a minute? [21:30:34] ish, what's up? [21:30:58] greg-g: so i've been talking with MaxSem about deploying Gather to testwiki on thursday and then deploying to english wikipedia on Monday [21:31:01] would that be okay [21:31:11] we're keen to deploy Gather at start of week so we can respond better to issues [21:31:22] thursday makes us uncomfortable because of closeness to weekend [21:31:26] for mobile beta still? [21:31:31] greg-g: correct [21:31:36] gotcha, sure thing [21:31:38] also gonna mail out to ops about the plan [21:31:44] * greg-g nods [21:31:45] so should i schedule it using the usual wiki page? [21:31:46] good idea [21:31:51] anyone else i need to let know? [21:32:11] moushira is writing to village pump [21:32:14] I think that's it! (and yeah, wiki page update appreciated) [21:32:19] perfect [21:33:04] all the fixes Csteipp needed are in the jenkins stalled job queue [21:33:17] :) [21:34:02] (03CR) 10Jdlrobson: [C: 032] Surface last updated time in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198363 (https://phabricator.wikimedia.org/T93303) (owner: 10Jdlrobson) [21:34:14] yeah am doing VPT, WP:Mobile, and WP:AN, and wikitech-l all pointing to FAQ https://www.mediawiki.org/wiki/Extension:Gather_FAQ [21:38:20] Deskana: ha, just saw your message. for katie, sounds like you're talking to her about android. i'll reach out to sherah [21:39:30] Deskana: emailed sherah [21:39:43] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: [SchemaGatherClicks] Missing or empty schema - https://phabricator.wikimedia.org/T93706#1146634 (10Jdlrobson) Apparently the issue is because we don't add the dependency `schema.GatherClicks` - we'll need to conditionally add that as a dependency just... [21:40:58] ^ MaxSem you see all that? [21:41:06] wooh [21:41:07] wut [21:41:15] where am i? [21:41:18] who am i? [21:41:28] 14:30 [21:41:31] just tell me the time:) [21:41:52] greg-g: MaxSem evening swat okay? [21:42:08] what swat? [21:42:49] greg-g: or shall we schedule a different time for deploying Gather on Monday 23rd? [21:43:44] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: [SchemaGatherClicks] Missing or empty schema - https://phabricator.wikimedia.org/T93706#1146646 (10Jdlrobson) a:5Jdlrobson>3None [21:44:08] (03Merged) 10jenkins-bot: Run AbuseFilter filters against Gather titles and descriptions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199079 (https://phabricator.wikimedia.org/T93385) (owner: 10Jdlrobson) [21:44:56] btw, greg-g: I need to bump WikiGrok today because it requires a schema change before tomorrow's train - is it ok to swat? [21:46:50] 10Gather: API: For list=lists, add mode=allhidden - https://phabricator.wikimedia.org/T93704#1146660 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [21:49:32] we lost greg-g :/ [21:50:20] (03Merged) 10jenkins-bot: Inform the user when they are creating a public collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199328 (owner: 10Robmoen) [21:50:22] (03CR) 10Jdlrobson: [C: 032] Resolve php and hhvm warnings on Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199361 (owner: 10Robmoen) [21:52:42] MaxSem: jdlrobson2 sorry, for gather and wikigrok updates, those sound like they could use their own slot to not make swat confusing [21:52:47] (03CR) 10Jdlrobson: [C: 032] Move wgMFEditorOptions to ResourceLoaderGetConfigVars hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199227 (https://phabricator.wikimedia.org/T93210) (owner: 10Florianschmidtwelzow) [21:52:58] greg-g: so how do i setup a new slot? [21:53:04] greg-g, so when? now ok? [21:53:06] (sorry for the newbie question) [21:53:30] jdlrobson2: pick a time that works on the wikitech deployments calendar page [21:53:34] https://wikitech.wikimedia.org/wiki/Deployments [21:53:39] MaxSem: for wikigrok, sure, if it's open [21:53:59] by work does that mean work for me and max and not clash with other slots? [21:54:10] greg-g, thanks - on it [21:54:24] kaldari_away, yer needed for testing [21:54:42] MaxSem: still in interview, can you cover? [21:55:00] kaldari_away, waiting till :00:P [21:57:45] 10Wikipedia-App-Android-App, 6CA-team: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1146682 (10Ragesoss) [21:59:21] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: [SchemaGatherClicks] Missing or empty schema - https://phabricator.wikimedia.org/T93706#1146686 (10rmoen) a:3rmoen [22:00:03] 3Gather Sprint Diplodocus: Provide appropriate groups or individuals with 'gather-admin' priveleges - https://phabricator.wikimedia.org/T93771#1146691 (10JKatzWMF) @jdlrobson Despite my earlier hint, I think this should be assigned to admins for now. That seems appropriately limited. Do you know who should plac... [22:01:43] 10Gather, 3Gather Sprint Diplodocus, 10Wikimedia-Extension-setup, 3Roadmap, and 2 others: Enable Extension:Gather (article lists) on English Wikipedia Mobile Beta - https://phabricator.wikimedia.org/T91341#1146692 (10Jdlrobson) Scheduled deployment for Monday 23rd. @MaxSem will oversee it. https://wikitech... [22:06:35] mhurd ping [22:06:41] bgerstle: hey! [22:06:43] 10Gather: Change the "Collections" icon in left nav menu - https://phabricator.wikimedia.org/T93813#1146718 (10MSyed) [22:07:02] just got back from the dog park, gonna work for a bit before breaking again for dinner [22:07:10] have you done any testing on the patch perchance? [22:07:22] bgerstle: cool - i haven’t had a chance to test the patch yet [22:07:39] k [22:08:19] kaldari: bmansurov https://gerrit.wikimedia.org/r/199155 when you have some time? [22:10:24] mhurd shall we try to wrap this patch up now, then? [22:10:50] bgerstle: sure give me 5 min and i’ll stash my current stuff and check that branch out [22:11:03] ok [22:11:23] mhurd i'm going to try to clean up the app delegate changes i made in the meantime [22:11:27] (03CR) 10Jdlrobson: "The feature is maintained. It's not broken and it's heavily used [1]. Removing a feature blindly != cleaning up." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194451 (https://phabricator.wikimedia.org/T85929) (owner: 10Legoktm) [22:15:01] (03PS1) 10Yurik: lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 [22:16:01] (03PS2) 10Yurik: lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 [22:18:01] (03CR) 10jenkins-bot: [V: 04-1] lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (owner: 10Yurik) [22:18:23] jdlrobson2, https://gerrit.wikimedia.org/r/#/c/199510/ [22:18:26] just landed [22:18:55] yeh, we noapiwrite: Editing of this wiki through the API is disabled. Make sure the $wgEnableWriteAPI=true; statement is included in the wiki's LocalSettings.php file < yurik i'm still hitting this error [22:19:02] despite having is set to true :-/ [22:19:07] yurik: wil ltake a look [22:19:15] (yay tests!) [22:19:45] jdlrobson2, are you using post or get? post should be required [22:19:54] and when are you hitting that error? [22:21:07] it should be post [22:21:31] (03PS5) 10Jdlrobson: WIP: Illustrate collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) [22:21:32] ^ yurik [22:21:54] yurik: L102 [22:22:04] 10Gather: Placeholder/IGNORE: Assorted string replacements - https://phabricator.wikimedia.org/T93817#1146816 (10JKatzWMF) 3NEW [22:22:22] (03PS3) 10Yurik: lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 [22:23:37] (03Merged) 10jenkins-bot: Surface last updated time in Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198363 (https://phabricator.wikimedia.org/T93303) (owner: 10Jdlrobson) [22:23:42] 10Gather: Change the "Collections" icon in left nav menu - https://phabricator.wikimedia.org/T93813#1146834 (10JKatzWMF) This is where the icon should go: {F103775} [22:23:43] jdlrobson2, need to track it down, could you come up with a repo? [22:24:33] (03CR) 10jenkins-bot: [V: 04-1] WIP: Illustrate collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) (owner: 10Jdlrobson) [22:24:56] jdlrobson2, is it from the special page? you need to instantiate api with a "true" parameter [22:24:58] 10Gather: user who creates a new collection is shown an overlay showing them to click on the hamburger menu to visit their collections. - https://phabricator.wikimedia.org/T93628#1146859 (10JKatzWMF) @msyed, we need a mock of this. [22:25:14] yurik: ooohh i do? [22:25:39] https://gerrit.wikimedia.org/r/#/c/197777/5/includes/specials/SpecialGather.php L103 isn't the third argument the true one? [22:25:51] dbrant|brb, bearND: "Read next" was feature flagged to not show in production, right? [22:26:01] (03CR) 10Florianschmidtwelzow: [C: 032] Make page action overlay pointer position correctly. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199155 (https://phabricator.wikimedia.org/T91047) (owner: 10Jdlrobson) [22:26:05] jdlrobson2, heading to the customs, later [22:26:22] (03CR) 10jenkins-bot: [V: 04-1] Resolve php and hhvm warnings on Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199361 (owner: 10Robmoen) [22:26:27] jdlrobson2, please review the patch i just submitted [22:27:51] (03CR) 10Jdlrobson: [C: 04-1] "needs rebase" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199361 (owner: 10Robmoen) [22:28:02] dbrant|brb, bearND: Never mind, found out my answer is "Yes, it is flagged". :-) [22:28:05] (03CR) 10Jdlrobson: [C: 032] Defer loading of collections till watchlist click [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198165 (https://phabricator.wikimedia.org/T92573) (owner: 10Jdlrobson) [22:28:06] Deskana: correct. to see the list of feature flagged code I just grep for WikipediaApp.RELEASE_PROD. In this case BottomContentHandler.useNewBottomContent() [22:28:39] (03CR) 10Jdlrobson: lstprop=owner and a few bug fixes (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (owner: 10Yurik) [22:30:47] (03Merged) 10jenkins-bot: Move wgMFEditorOptions to ResourceLoaderGetConfigVars hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199227 (https://phabricator.wikimedia.org/T93210) (owner: 10Florianschmidtwelzow) [22:30:54] 6Mobile-Web: Editor Tutorial: Space bewteen banner and editor pencil is always different in stable/beta/alpha - https://phabricator.wikimedia.org/T93820#1146886 (10Florian) 3NEW [22:30:55] (03CR) 10Jdlrobson: [C: 04-1] "See comments on PS2." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (owner: 10Yurik) [22:31:59] (03CR) 10Jdlrobson: Alternative syntax such as "X" should not be used (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199315 (owner: 10Florianschmidtwelzow) [22:33:10] mhurd make get-deps [22:35:08] which pod [22:35:24] sudo gem install cocoapods -v 0.36 [22:39:26] (03PS1) 10Florianschmidtwelzow: Re-add clear:both to beta page-secondary-actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199516 (https://phabricator.wikimedia.org/T88499) [22:39:42] jdlrobson2: ^ ? :) [22:40:22] (03CR) 10Florianschmidtwelzow: [C: 04-1] Alternative syntax such as "X" should not be used (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199315 (owner: 10Florianschmidtwelzow) [22:40:30] wooo, claim saving works! woo, works incorrectly! [22:41:02] FlorianSW: what about stable? [22:41:05] doesn't it need it too? [22:42:50] jdlrobson2: we hadn't it in stable, we could add it, but this would only affect the buttons (actually they appears directly after the content, no matter, if there is something with float:right). Should i add it? [22:43:24] (03PS2) 10Florianschmidtwelzow: Alternative syntax such as "X" should not be used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199315 [22:43:38] i haven't tried it - i just wondered why it's applying to stable [22:43:57] (03PS3) 10Jdlrobson: Hygiene: Alternative syntax such as "X" should not be used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199315 (owner: 10Florianschmidtwelzow) [22:44:04] (03CR) 10Jdlrobson: [C: 032] Hygiene: Alternative syntax such as "X" should not be used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199315 (owner: 10Florianschmidtwelzow) [22:44:25] the main reason why we have this css rule is the "last edited by" bar; in stable it is at the top of the page, so normally no need for stable mode (at the moment) :) [22:46:03] (03PS6) 10Jdlrobson: Illustrate collections (suboptimal but good enough approach) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) [22:46:59] 10Wikipedia-App-Android-App, 6CA-team: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1146922 (10Mpaulson) Hi All - It would be great if we could prioritize this bug a little more. It has privacy and Creative Commons licensing implications. Please ping me if you... [22:47:27] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: When I go to Special:Gather and see the collections I own they are illustrated with a page image - https://phabricator.wikimedia.org/T91675#1146924 (10Jdlrobson) a:3Jdlrobson [22:47:58] (03CR) 10jenkins-bot: [V: 04-1] Illustrate collections (suboptimal but good enough approach) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) (owner: 10Jdlrobson) [22:49:08] (03PS15) 10Bgerstle: set article imageURL and save image list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 (https://phabricator.wikimedia.org/T92697) [22:49:22] 10Gather, 3Gather Sprint Diplodocus: After hiding list I cannot unhide it - https://phabricator.wikimedia.org/T93821#1146928 (10Jdlrobson) 3NEW [22:50:47] 3Gather Sprint Diplodocus: My hidden lists disappear from Special:Gather - https://phabricator.wikimedia.org/T93822#1146937 (10Jdlrobson) 3NEW [22:52:07] (03CR) 10Jdlrobson: [C: 031] "errr" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198165 (https://phabricator.wikimedia.org/T92573) (owner: 10Jdlrobson) [22:52:12] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198165 (https://phabricator.wikimedia.org/T92573) (owner: 10Jdlrobson) [22:54:45] (03PS1) 10MaxSem: Fix fatal [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/199519 [22:55:10] 10Wikipedia-App-Android-App, 6CA-team: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1146952 (10Krenair) [22:55:38] (03CR) 10Kaldari: [C: 032] Fix fatal [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/199519 (owner: 10MaxSem) [22:56:58] (03PS1) 10MaxSem: Fix fatal [extensions/WikiGrok] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199521 [22:57:05] (03CR) 10MaxSem: [C: 032] Fix fatal [extensions/WikiGrok] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199521 (owner: 10MaxSem) [22:57:23] (03PS1) 10MaxSem: Fix fatal [extensions/WikiGrok] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/199522 [22:57:29] (03CR) 10MaxSem: [C: 032] Fix fatal [extensions/WikiGrok] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/199522 (owner: 10MaxSem) [22:57:49] 6Mobile-Web: Image description is not inserted into the correct paragraph - https://phabricator.wikimedia.org/T93241#1146953 (10bmansurov) I'm not exactly sure, but I don't think we need that long of a license info, but we do need the image description. @Maryana, maybe able to clarify. [22:58:32] (03CR) 10MaxSem: [V: 032] Fix fatal [extensions/WikiGrok] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199521 (owner: 10MaxSem) [22:58:42] (03CR) 10MaxSem: [V: 032] Fix fatal [extensions/WikiGrok] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/199522 (owner: 10MaxSem) [22:58:45] (03PS16) 10Bgerstle: set article imageURL and save image list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 (https://phabricator.wikimedia.org/T92697) [23:02:38] (03PS17) 10Bgerstle: set article imageURL and save image list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 (https://phabricator.wikimedia.org/T92697) [23:05:03] 10Wikipedia-App-Android-App, 6CA-team: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1146992 (10Deskana) 5Open>3stalled >>! In T75086#1146922, @Mpaulson wrote: > Hi All - It would be great if we could prioritize this bug a little more. It has privacy and Cre... [23:06:16] (03PS7) 10Jdlrobson: Illustrate collections (suboptimal but good enough approach) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) [23:06:35] coreyfloyd: ping [23:08:15] (03PS1) 10Robmoen: Add schema depedency to logging [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199525 [23:08:23] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 3 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1147030 (10dr0ptp4kt) https://gerrit.wikimedia.org/r/#/c/198805/ submitted for review for Varnish. [23:08:27] (03Merged) 10jenkins-bot: Make page action overlay pointer position correctly. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199155 (https://phabricator.wikimedia.org/T91047) (owner: 10Jdlrobson) [23:09:18] (03PS2) 10Robmoen: Add schema depedency to logging [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199525 [23:12:13] (03CR) 10jenkins-bot: [V: 04-1] Illustrate collections (suboptimal but good enough approach) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) (owner: 10Jdlrobson) [23:14:33] bgerstle: yo [23:14:42] coreyfloyd: was just rebasing your changes off my last patch [23:14:44] just about got it [23:14:54] ok [23:14:59] only needed to resolve conflicts for the OldDataSchemaMigrator path issue and other minor bits [23:16:32] 6Mobile-Web, 10WikiGrok: Bogus claims are saved - https://phabricator.wikimedia.org/T93825#1147065 (10MaxSem) [23:16:48] bgerstle: ok - let me know if you need me to do it - should i test your patch some more? [23:16:52] 3Gather Sprint Diplodocus: Provide appropriate groups or individuals with 'gather-admin' priveleges - https://phabricator.wikimedia.org/T93771#1147070 (10Moushira) done already https://en.wikipedia.org/wiki/Wikipedia:Administrators%27_noticeboard#Extension:Gather_launching_on_beta [23:17:00] 10Wikipedia-App-Android-App, 6CA-team, 10MediaWiki-API, 10MediaWiki-User-login-and-signup: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1147071 (10Deskana) [23:17:08] coreyfloyd: if you're up for it. i'm gonna start dinner in a sec [23:17:40] k yeah - will give it a go [23:18:46] 10Gather, 3Gather Sprint Diplodocus: Announce beta deployment on wikitech-l, enwp vp - https://phabricator.wikimedia.org/T93631#1147079 (10Moushira) Announced : https://en.wikipedia.org/wiki/Wikipedia:Administrators%27_noticeboard#Extension:Gather_launching_on_beta https://en.wikipedia.org/wiki/Wikipedia:Villa... [23:18:50] 6Mobile-Web: Text breaking in middle of the word on mobile beta - https://phabricator.wikimedia.org/T93826#1147080 (10KHammerstein) 3NEW [23:19:39] 10Gather, 3Gather Sprint Diplodocus: Populate gather with proper feature name - https://phabricator.wikimedia.org/T92665#1147091 (10Moushira) published renaming survey results https://www.mediawiki.org/wiki/Extension%CB%90Gather/renaming_survey [23:19:54] (03Merged) 10jenkins-bot: Hygiene: Alternative syntax such as "X" should not be used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199315 (owner: 10Florianschmidtwelzow) [23:23:03] coreyfloyd: meh rebase isn't going well. losing patience. can try again after its "parent" patch is finally merged [23:23:37] bgerstle: yeah dont worry about it - let me finish this testing first [23:23:56] mhurd: did you run into anything yet testing the patch? or what data are you testing? [23:26:43] (03PS1) 10Jdlrobson: Register EL schema ResourceLoader module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199532 (https://phabricator.wikimedia.org/T93706) [23:27:25] coreyfloyd: i put some app data archives up on dropbox https://www.dropbox.com/s/48oxunt9ez966dc/4.0.6%20test%20data.zip?dl=0 [23:27:27] (03CR) 10Jdlrobson: [C: 04-1] "This won't work where EL is installed." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199525 (owner: 10Robmoen) [23:27:46] bgerstle: cool thanks [23:27:50] (03Abandoned) 10Jdlrobson: Fix JS error when wgGatherCollections is not defined [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199257 (https://phabricator.wikimedia.org/T93738) (owner: 10Jhernandez) [23:28:02] which you can use on device or sim [23:28:56] (03PS7) 10Jdlrobson: Defer loading of collections till watchlist click [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198165 (https://phabricator.wikimedia.org/T92573) [23:29:09] (03CR) 10Jdlrobson: [C: 032] Defer loading of collections till watchlist click [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198165 (https://phabricator.wikimedia.org/T92573) (owner: 10Jdlrobson) [23:31:52] bgerstle: was anything going on with "allowedGroupsForAction" [23:32:04] (03CR) 10Mhurd: [C: 031] set article imageURL and save image list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 (https://phabricator.wikimedia.org/T92697) (owner: 10Bgerstle) [23:32:06] coreyfloyd: what do you mean? [23:32:16] (03CR) 10Robmoen: [C: 04-1] "This doesn't work. You need to change the name of the schema from SchemaGatherClicks to GatherClicks in SchemaGather.js" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199532 (https://phabricator.wikimedia.org/T93706) (owner: 10Jdlrobson) [23:32:38] did you edit any lines of code like that - im investigating a crash… not during import, after [23:32:47] (03PS4) 10Yurik: lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 [23:32:56] (03CR) 10Yurik: lstprop=owner and a few bug fixes (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (owner: 10Yurik) [23:33:05] coreyfloyd: so, i wrote a comment about it because i was confused how the protection status is migrated [23:33:32] (03CR) 10Krinkle: [C: 032] Defer loading of collections till watchlist click [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198165 (https://phabricator.wikimedia.org/T92573) (owner: 10Jdlrobson) [23:33:34] (03PS2) 10Jdlrobson: Register EL schema ResourceLoader module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199532 (https://phabricator.wikimedia.org/T93706) [23:33:40] but you can see the "protection status" is migrated the same way it was before: [23:33:50] bgerstle: that method is supposed to return an array, currently returning a string [23:33:54] from OldDataSchema.m in the diff https://www.irccloud.com/pastebin/wztJIXtP [23:33:58] coreyfloyd: yeah... i noticed that [23:34:20] oh yeah! [23:34:22] coreyfloyd: feel free to update it and amend the tests [23:34:24] thats it… [23:34:34] (03PS5) 10Yurik: lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 [23:34:38] i wrote a comment along the lines of "umm.. is this correct?" [23:34:53] hoping some sleuthy reviewer would figure out what was supposed to happen ;-) [23:34:59] jdlrobson2, fixed ^ [23:35:04] guess i got lazy and didn't investigate it thoroughly enough [23:35:12] jdlrobson2, let me see if i can repo your bug [23:35:35] (03Abandoned) 10Robmoen: Add schema depedency to logging [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199525 (owner: 10Robmoen) [23:35:59] coreyfloyd: that pastebin can now be found in -[OldDataSchemaMigrator exportArticle] [23:36:57] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Clicking add to collection on message guider throws JS exception - https://phabricator.wikimedia.org/T93827#1147115 (10Jdlrobson) 3NEW a:3rmoen [23:37:24] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Article reader sees message/guidance about creating a collection so that they know the feature exists and the entry point - https://phabricator.wikimedia.org/T91015#1147122 (10Jdlrobson) 5Resolved>3declined @JKatzWMF noticed slight regression with... [23:40:07] 3Gather Sprint Diplodocus: My hidden lists disappear from Special:Gather - https://phabricator.wikimedia.org/T93822#1147128 (10Yurik) The "ed-o3" test tests for this, will try to repo by hand [23:40:17] 10Wikipedia-App-Android-App, 6CA-team, 10MediaWiki-API, 10MediaWiki-User-login-and-signup: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1147130 (10Deskana) @bd808 will see if someone more familiar with the edit API can help us debug this. It may be that we'... [23:40:45] bgerstle: how do you test class type with hamcrest? [23:40:58] coreyfloyd not sure if there's a matcher for that.. [23:41:26] ahha [23:41:35] is(instanceOf(class)) [23:41:39] 10Gather, 3Gather Sprint Diplodocus: No indication that a collection is private or hidden - https://phabricator.wikimedia.org/T93828#1147132 (10Jdlrobson) 3NEW [23:41:47] the "is" being optional [23:41:54] coreyfloyd: ^ [23:42:11] dunka [23:42:14] 10Wikipedia-App-iOS-App: Incorrect crop for a leading image - https://phabricator.wikimedia.org/T91436#1147141 (10Etonkovidova) The two attached samples display crop and/or scale problems - important images' details were cut off: - on the first image - people's figures are not fully displayed - on the second... [23:42:31] 3Gather Sprint Diplodocus: My hidden lists disappear from Special:Gather - https://phabricator.wikimedia.org/T93822#1147142 (10Jdlrobson) 5Open>3Invalid a:3Jdlrobson Yeh cannot replicate any more so closing. [23:43:07] 10Wikipedia-App-Android-App, 6CA-team, 10MediaWiki-API, 10MediaWiki-User-login-and-signup: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1147146 (10MaxSem) Add assert=user to edit requests from users who are supposed to be logged in? That would fail the edit... [23:43:24] (03PS3) 10Jdlrobson: Resolve php and hhvm warnings on Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199361 (owner: 10Robmoen) [23:43:37] (03CR) 10Jdlrobson: [C: 032] Resolve php and hhvm warnings on Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199361 (owner: 10Robmoen) [23:44:02] (03CR) 10Jdlrobson: [C: 04-1] Resolve php and hhvm warnings on Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199361 (owner: 10Robmoen) [23:44:33] (03PS4) 10Jdlrobson: Resolve php and hhvm warnings on Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199361 (owner: 10Robmoen) [23:45:08] (03CR) 10Jdlrobson: [C: 032] Resolve php and hhvm warnings on Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199361 (owner: 10Robmoen) [23:45:17] 10Wikipedia-App-Android-App, 6CA-team, 10MediaWiki-API, 10MediaWiki-User-login-and-signup: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1147158 (10Deskana) >>! In T75086#1147146, @MaxSem wrote: > Add assert=user to edit requests from users who are supposed... [23:45:35] 10Gather, 3Gather Sprint Diplodocus: After hiding list I cannot unhide it - https://phabricator.wikimedia.org/T93821#1147160 (10Jdlrobson) a:3Jdlrobson [23:45:43] 10Wikipedia-App-Android-App, 6CA-team, 10MediaWiki-API, 6MediaWiki-API-Team, 10MediaWiki-User-login-and-signup: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1147161 (10bd808) [23:46:16] 10Wikipedia-App-iOS-App: Cut off leading images - https://phabricator.wikimedia.org/T93829#1147166 (10Etonkovidova) 3NEW [23:46:56] (03PS1) 10Fjalapeno: Crash after migration - this value is supposed to be an array. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199536 [23:50:26] (03CR) 10Fjalapeno: [C: 031] "+1 is based on testing functionality - didn't rigorously go through the code itself. Will be doing that after we get the release pushed to" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 (https://phabricator.wikimedia.org/T92697) (owner: 10Bgerstle) [23:50:28] 6Mobile-Web: Page titles breaking in middle of the word on mobile beta - https://phabricator.wikimedia.org/T93826#1147187 (10KHammerstein) [23:50:38] (03CR) 10Yurik: [C: 04-1] "I'm getting test failures all of a sudden. Checking." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (owner: 10Yurik) [23:50:40] 6Mobile-Web: Page titles breaking in middle of the word on mobile beta - https://phabricator.wikimedia.org/T93826#1147080 (10KHammerstein) [23:50:43] (03Merged) 10jenkins-bot: Defer loading of collections till watchlist click [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198165 (https://phabricator.wikimedia.org/T92573) (owner: 10Jdlrobson) [23:51:01] bgerstle: submitted the patch [23:51:08] will now rebase mine [23:51:16] (03PS1) 10Robmoen: Fix JS exception when tutorial loads [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199537 [23:51:44] @mhurd you still around? [23:51:53] coreyfloyd: ya! [23:51:57] (03PS2) 10Robmoen: Fix JS exception when tutorial loads [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199537 [23:52:03] coreyfloyd: but what about allowed actions? [23:52:15] mhurd: where are you with brian's patch? [23:52:26] coreyfloyd: i +1’ed [23:52:34] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: [SchemaGatherClicks] Missing or empty schema - https://phabricator.wikimedia.org/T93706#1147201 (10rmoen) a:5rmoen>3Jdlrobson [23:52:39] mhurd: i +1ed… if you can +1 we can get all these other patches pushed thtough [23:52:42] tonight [23:52:53] bgerstle: not sure what you mean [23:53:16] mhurd: im starting to rebase my patches on brians most recent change set [23:53:25] The crash you found? [23:53:37] coreyfloyd: adam’s checking it [23:53:49] coreyfloyd: rebase away :) [23:53:55] (03Merged) 10jenkins-bot: Resolve php and hhvm warnings on Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199361 (owner: 10Robmoen) [23:54:00] mhurd: thanks! [23:56:27] (03CR) 10Robmoen: [C: 04-1] Fix JS exception when tutorial loads [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199537 (owner: 10Robmoen) [23:58:20] (03Abandoned) 10Robmoen: Fix JS exception when tutorial loads [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199537 (owner: 10Robmoen) [23:58:34] coreyfloyd: oh i see, you submitted a patch on top of mine (not amended) [23:58:56] k, going to focus on prepping dinner now o/