[00:01:28] (03CR) 10Robmoen: [C: 04-1] "Hmm not sure what is up with that. I had to change the name on my patch. Are you not getting this error everytime you click the star?" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199532 (https://phabricator.wikimedia.org/T93706) (owner: 10Jdlrobson) [00:02:28] (03CR) 10Dr0ptp4kt: [C: 04-1 V: 04-1] "For some reason, swiping through the image gallery in the article "Jellyfish" is producing a crash after about the 12th/13th image (the on" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199324 (owner: 10Fjalapeno) [00:02:31] (03PS1) 10Mhurd: Fix for article section image data not being saved. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199540 [00:02:47] bgerstle_away: coreyfloyd dr0ptp4kt ^ fix for article saving regression [00:03:13] (03PS2) 10Mhurd: Fix for article section image data not being saved. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199540 [00:15:45] (03PS2) 10Fjalapeno: Add text progress to migration Move migration to background thread / context [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199299 [00:17:43] (03CR) 10Bmansurov: "@MaxSem, can you tell me how to get the page properties using ParserOutput? $parserOutput->getProperties() returns an empty array. Thanks." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [00:20:30] (03PS2) 10Fjalapeno: Add progress line to data migration [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199300 [00:20:52] (03PS1) 10Jdlrobson: Kill PHP warning [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199546 [00:20:55] ^ MaxSem quick merge for me? [00:20:58] super straightforward [00:21:33] (03CR) 10MaxSem: [C: 032] Kill PHP warning [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199546 (owner: 10Jdlrobson) [00:21:44] (03CR) 10Bmansurov: Alpha: Load banner images on page load (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [00:22:09] (03PS1) 10Jdlrobson: Add Special:GatherLists/hidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199547 (https://phabricator.wikimedia.org/T93795) [00:22:23] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Admin tools do not show up in Special:GatherList on Vector or mobile stable - https://phabricator.wikimedia.org/T93795#1147266 (10Jdlrobson) a:3Jdlrobson [00:22:46] (03PS9) 10Bmansurov: Alpha: Load banner images on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) [00:22:47] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: PHP warnings on Special:GatherLists - https://phabricator.wikimedia.org/T93794#1147271 (10Jdlrobson) 5Open>3Resolved [00:22:52] (03CR) 10Fjalapeno: "Monte can you add some info the commit message to why you made the changes that you did?" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199540 (owner: 10Mhurd) [00:23:14] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Include owner of lists when using lstmode api parameter - https://phabricator.wikimedia.org/T93148#1147273 (10Jdlrobson) 5Open>3Resolved [00:23:35] 10Wikipedia-App-Android-App, 6CA-team, 10MediaWiki-API, 6MediaWiki-API-Team, 10MediaWiki-User-login-and-signup: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1147278 (10Legoktm) My guess is that people are logging out on desktop and that the app is not not... [00:23:36] mhurd: also rebased my changes [00:25:15] 10Gather, 3Gather Sprint Diplodocus: Toast should clip long collection titles - https://phabricator.wikimedia.org/T93797#1147283 (10JKatzWMF) **Solution: show ellipse "..." after 30 characters. If its a simple tweak, make shorter rather than cutting off mid-word.** "An Airbus A320 operated by Germanwings, a b... [00:25:38] (03CR) 10Fjalapeno: "@dr0ptp4kt checking the crash out now and thanks for catching the missing license - forgot to paste that from the file. will push that up " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199324 (owner: 10Fjalapeno) [00:26:10] coreyfloyd: will do [00:26:13] 10Gather, 3Gather Sprint Diplodocus: No indication that a collection is private or hidden on the list itself - https://phabricator.wikimedia.org/T93828#1147284 (10Jdlrobson) [00:26:32] (03CR) 10Bmansurov: [C: 031] Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [00:26:38] 10Gather: No indication that a collection is private or hidden on the list itself - https://phabricator.wikimedia.org/T93828#1147288 (10JKatzWMF) [00:28:19] 10Gather, 3Gather Sprint Diplodocus: API: Correctly respond when I do not have the gather-hide-list right. - https://phabricator.wikimedia.org/T93793#1147290 (10JKatzWMF) 5Open>3declined a:3JKatzWMF I think this is fine. An anonymous user should be able to see the list of visible collections. [00:28:21] (03PS3) 10Jdlrobson: Register EL schema ResourceLoader module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199532 (https://phabricator.wikimedia.org/T93706) [00:29:20] 10Gather, 3Gather Sprint Diplodocus: API: Correctly respond when I do not have the gather-hide-list right. - https://phabricator.wikimedia.org/T93793#1147294 (10Jdlrobson) 5declined>3Open Let's keep this in backlog. It's more confusing to a developer. It doesn't impact users in anyway (hence being in devel... [00:29:40] 10Gather: API: Correctly respond when I do not have the gather-hide-list right. - https://phabricator.wikimedia.org/T93793#1147296 (10Jdlrobson) [00:32:29] (03CR) 10Bmansurov: [C: 031] "I think it's Skin's job to decide what to show or not. So +1 from me as long as you address Kaldari's comments." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) (owner: 10Jdlrobson) [00:32:55] 10Gather, 3Gather Sprint Diplodocus: Announce beta deployment on wikitech-l, enwp vp - https://phabricator.wikimedia.org/T93631#1147300 (10JKatzWMF) @moushira So just need to send this email to wikitech-l? https://office.wikimedia.org/wiki/User:MElamrawy_%28WMF%29/Gather_announcement [00:33:22] 10Gather: Toast should clip long collection titles - https://phabricator.wikimedia.org/T93797#1147301 (10JKatzWMF) [00:33:44] (03CR) 10jenkins-bot: [V: 04-1] Alpha: Load banner images on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [00:35:15] (03CR) 10Fjalapeno: "@dr0ptp4kt - looks like this bug is in master, not on my branch. Will look into it anyways, but the offending method is:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199324 (owner: 10Fjalapeno) [00:36:00] mhurd: you want to look into this crash that adam found? its in some code you submitted last week: [00:36:04] https://www.irccloud.com/pastebin/4nkgeXvz [00:36:23] mhurd: that assertion is firing [00:36:36] coreyfloyd: i’ll check [00:36:47] mhurd: im not too sure where to start… figure you know better than me [00:36:48] (03CR) 10Bmansurov: [C: 031] "Needs Maryana's blessing." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [00:36:49] thanks [00:36:57] coreyfloyd: np [00:37:45] mhurd: follow thedirections of opening up the jellyfish article and swiping through the images… only crashes on ios 8, not 7 [00:37:53] i found from testing [00:38:07] coreyfloyd: will try it [00:38:54] (03PS10) 10Bmansurov: Alpha: Load banner images on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) [00:39:53] (03PS1) 10Yurik: Refactored abuse string testing code [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199549 [00:40:07] (03PS6) 10Yurik: lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 [00:40:40] (03PS1) 10MaxSem: Fix value fail [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/199550 (https://phabricator.wikimedia.org/T93825) [00:40:48] kaldari, ^ [00:41:58] 10Wikipedia-App-Android-App, 6CA-team, 10MediaWiki-API, 6MediaWiki-API-Team, 10MediaWiki-User-login-and-signup: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1147312 (10Krenair) 5stalled>3Open I just reproduced the issue by doing exactly what @legoktm... [00:42:36] (03PS2) 10Fjalapeno: Fix Bug T93662 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199324 [00:43:45] mhurd: ok - im out - leave some notes on your patch and i will review in the morning. all my patches are up to date - i can address any extra feedback in the morning too. [00:45:08] (03CR) 10MaxSem: "Mmm, in such case it's also sin's job to know everything about everything, which is not exactly what we want from a piece of software:)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) (owner: 10Jdlrobson) [00:46:32] mhurd: also if you dont finish that new bug let me know and i can take a crack at it too… [00:48:08] coreyfloyd: in meeting. hangout in 10 min? [00:54:59] (03CR) 10jenkins-bot: [V: 04-1] Add Special:GatherLists/hidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199547 (https://phabricator.wikimedia.org/T93795) (owner: 10Jdlrobson) [00:59:12] (03Merged) 10jenkins-bot: Kill PHP warning [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199546 (owner: 10Jdlrobson) [01:05:14] 10Wikipedia-App-Android-App, 6CA-team, 10MediaWiki-API, 6MediaWiki-API-Team, 10MediaWiki-User-login-and-signup: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#764856 (10Anomie) >>! In T75086#1147158, @Deskana wrote: > I would rather fix the actual problem s... [01:08:28] coreyfloyd: you around? [01:08:53] 10Wikipedia-App-Android-App, 6CA-team, 10MediaWiki-API, 6MediaWiki-API-Team, 10MediaWiki-User-login-and-signup: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1147374 (10Dbrant) I can probably spare a few cycles on this during our unstructured sprint. [01:09:36] Maryana: you around? [01:12:05] 10Wikipedia-App-Android-App, 6CA-team, 10MediaWiki-API, 6MediaWiki-API-Team, 10MediaWiki-User-login-and-signup: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1147383 (10Deskana) Sounds like this has enough definition for us to move on it now. Thanks everyone! [01:17:40] i see some entries in the logs like [01:17:42] Fatal error: Class undefined: WikiGrok\WikibaseClientConnector in /srv/mediawiki/php-1.25wmf21/extensions/WikiGrok/includes/QuestionPicker.php on line 18 [01:18:00] but perhaps that is resolved already? [01:18:24] (03CR) 10Mhurd: "The exception in "(UIImage*)asUIImage" should not be a problem. I added it to get a sense for the "don't inflate every image to determine " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199324 (owner: 10Fjalapeno) [01:21:25] 10Gather: API: Correctly respond when I do not have the gather-hide-list right. - https://phabricator.wikimedia.org/T93793#1147418 (10Yurik) I think I already changed that behaviour as part of the last patch [01:22:54] (03PS2) 10Yurik: Refactored abuse string testing code [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199549 (https://phabricator.wikimedia.org/T93385) [01:28:11] (03PS2) 10MaxSem: Fix value fail [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/199550 (https://phabricator.wikimedia.org/T93825) [01:28:35] mhurd: https://docs.google.com/a/wikimedia.org/spreadsheets/d/18P1i_Svi_L0W1L_2cMA748lD8OOnDP5IZKYolnpf_i8/edit [01:38:46] (03PS1) 10Yurik: Yuri's vanity + missing qqq for a rights msg [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199558 [01:39:10] (03PS3) 10Mhurd: Fix for article section image data saving regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199540 [01:49:05] (03PS4) 10Mhurd: Fix for article section image data saving regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199540 [01:50:52] (03PS5) 10Mhurd: Fix for article section image data saving regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199540 [02:15:16] (03CR) 10Wctaiwan: "I think removing it is the right thing to do. It doesn't provide much useful information about an editor compared to their user page or th" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194451 (https://phabricator.wikimedia.org/T85929) (owner: 10Legoktm) [02:25:27] 6Mobile-Web, 10MobileFrontend-Feature-requests, 7Easy, 5Patch-For-Review: Get rid of Special:UserProfile - https://phabricator.wikimedia.org/T90753#1147465 (10wctaiwan) [02:27:39] 6Mobile-Web, 10MobileFrontend-Feature-requests, 7Easy, 5Patch-For-Review: Get rid of Special:UserProfile - https://phabricator.wikimedia.org/T90753#1147467 (10wctaiwan) [02:45:07] (03CR) 10Kaldari: [C: 04-1] "If getting the info from the ParserOutput doesn't work for some reason, you can also use DisambiguatorHooks::isDisambiguationPage(), which" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [05:23:34] 6Mobile-Web, 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: Hover styles differ between MediaWiki UI buttons and OOjs UI buttons - https://phabricator.wikimedia.org/T92566#1147749 (10Prtksxna) [05:25:21] 6Mobile-Web, 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: Hover styles differ between MediaWiki UI buttons and OOjs UI buttons - https://phabricator.wikimedia.org/T92566#1114885 (10Prtksxna) @violetto, looking at M31 I am not sure which one is right. Could you please see the screenshots and pic... [05:31:21] (03CR) 10Florianschmidtwelzow: Alpha: Load banner images on page load (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [06:19:07] (03CR) 10Jdlrobson: [C: 032] Yuri's vanity + missing qqq for a rights msg [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199558 (owner: 10Yurik) [06:20:53] (03Merged) 10jenkins-bot: Yuri's vanity + missing qqq for a rights msg [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199558 (owner: 10Yurik) [07:14:06] 10Gather, 3Gather Sprint Diplodocus, 10Wikimedia-Extension-setup, 3Roadmap, and 2 others: Enable Extension:Gather (article lists) on English Wikipedia Mobile Beta - https://phabricator.wikimedia.org/T91341#1147842 (10Nemo_bis) As usual, I think [[https://meta.wikimedia.org/wiki/Community_Engagement_%28Prod... [08:04:11] 10Wikipedia-App-Android-App, 10Wikimania-Hackathon-2015, 10Wikimedia-Hackathon-2015, 7Design: Add an easier and faster way to change the search language - https://phabricator.wikimedia.org/T87154#1147882 (10Pginer-WMF) I have taken a look at the information from the description (I don't have an OTRS accoun... [08:29:59] 10Gather, 3Gather Sprint Diplodocus, 10Wikimedia-Extension-setup, 3Roadmap, and 2 others: Enable Extension:Gather (article lists) on English Wikipedia Mobile Beta - https://phabricator.wikimedia.org/T91341#1147895 (10TheDJ) @Nemo_bis, it's for 'beta users of the mobile site for the time being'. I'm good w... [08:59:47] 6Mobile-Web, 6Collaboration-Team, 10Flow: an inline external link in square brackets without a title doesn't appear in Flow pages on mobile web - https://phabricator.wikimedia.org/T93856#1147952 (10Amire80) 3NEW [09:37:20] 6Mobile-Web, 7Graphite: "No data" on MobileFrontend gdash - https://phabricator.wikimedia.org/T93328#1148068 (10fgiunchedi) I suspect this is a duplicate of T85641 (a bug nevertheless!) [09:40:59] 10Wikipedia-App-Android-App, 10Wikimania-Hackathon-2015, 10Wikimedia-Hackathon-2015, 7Design: Add an easier and faster way to change the search language - https://phabricator.wikimedia.org/T87154#1148087 (10AlexLippert) FWIW ... Problem description: The problem we want to solve is to make the use of the W... [09:45:18] 6Mobile-Web, 10MobileFrontend-Feature-requests, 5Patch-For-Review: Get rid of Special:UserProfile - https://phabricator.wikimedia.org/T90753#1148110 (10Qgil) [10:04:39] (03PS2) 10Jhernandez: Add Special:GatherLists/hidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199547 (https://phabricator.wikimedia.org/T93795) (owner: 10Jdlrobson) [10:05:53] (03CR) 10Jhernandez: "Fixed jslint and removed the icons in the button since it wasn't working consistently, and made the buttons have mw-ui styles." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199547 (https://phabricator.wikimedia.org/T93795) (owner: 10Jdlrobson) [10:07:07] 10Gather, 7Easy, 7I18n: clarify the qqq documentation for right-gather-hidelist - https://phabricator.wikimedia.org/T93865#1148169 (10Amire80) 3NEW [10:55:11] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Clicking add to collection on message guider throws JS exception - https://phabricator.wikimedia.org/T93827#1148252 (10Jhernandez) @rmoen moved this to signoff since you commented on the patch that this has been resolved on MF. If it is not that way ple... [10:56:34] 10Gather, 3Gather Sprint Diplodocus: Update url schemas - https://phabricator.wikimedia.org/T93774#1148253 (10Jhernandez) a:3Jhernandez [10:57:20] (03CR) 10Jhernandez: [C: 032] Add Special:GatherLists/hidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199547 (https://phabricator.wikimedia.org/T93795) (owner: 10Jdlrobson) [10:59:06] (03Merged) 10jenkins-bot: Add Special:GatherLists/hidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199547 (https://phabricator.wikimedia.org/T93795) (owner: 10Jdlrobson) [11:55:15] (03CR) 10Phuedx: [C: 032] "Nice work!" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198163 (https://phabricator.wikimedia.org/T91142) (owner: 10Bmansurov) [11:56:57] (03Merged) 10jenkins-bot: Cap the number of claims WikiGrokResponse API should accept [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198163 (https://phabricator.wikimedia.org/T91142) (owner: 10Bmansurov) [12:02:14] (03CR) 10Phuedx: [C: 032] Fix value fail [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/199550 (https://phabricator.wikimedia.org/T93825) (owner: 10MaxSem) [12:03:55] (03Merged) 10jenkins-bot: Fix value fail [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/199550 (https://phabricator.wikimedia.org/T93825) (owner: 10MaxSem) [12:08:27] 6Mobile-Web, 10WikiGrok: Bogus claims are saved - https://phabricator.wikimedia.org/T93825#1148425 (10phuedx) a:3MaxSem [12:16:12] joakino, PING [12:16:18] oops, caps ) [12:17:00] yo yurik [12:17:05] i'm about to leave :P [12:17:13] are you in SF [12:17:14] ? [12:17:17] joakino, NYC [12:17:24] awesome [12:17:32] did you have a cahnce to look at my patches? [12:17:34] from yesterday? [12:18:32] joakino, ? [12:18:49] although, its ok, no rush, will chat when you get back ) [12:18:57] i merged the allhidden and such [12:19:01] not today not [12:22:16] 10Gather, 7Easy, 7I18n: clarify the qqq documentation for right-gather-hidelist - https://phabricator.wikimedia.org/T93865#1148441 (10Yurik) Changed the wording on translatewiki. Is that good? [12:22:39] joakino, there are two patches pending [12:23:01] hope we can get them in before release. Also, I will work on the final DB touches [12:23:04] yurik: oki, I'll have a look after lunch :D [12:23:08] thx [12:23:24] bon appetit [12:28:00] (03PS1) 10Jhernandez: Update url schemas on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199610 (https://phabricator.wikimedia.org/T93774) [12:29:25] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Update url schemas - https://phabricator.wikimedia.org/T93774#1148446 (10Jhernandez) As stated in the patch: > Update url schemas on Special:Gather > > Mainly, user lists and a user list now are prefixed, so that we can have other > prefixes, like /al... [12:47:37] 10Gather, 7Easy, 7I18n: clarify the qqq documentation for right-gather-hidelist - https://phabricator.wikimedia.org/T93865#1148475 (10Amire80) 5Open>3Resolved a:3Yurik [12:47:45] 10Gather, 7Easy, 7I18n: clarify the qqq documentation for right-gather-hidelist - https://phabricator.wikimedia.org/T93865#1148169 (10Amire80) Thanks! [12:59:42] (03PS2) 10Bgerstle: Crash after migration - this value is supposed to be an array. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199536 (owner: 10Fjalapeno) [13:16:08] 10Gather, 3Gather Sprint Diplodocus, 10Wikimedia-Extension-setup, 3Roadmap, and 2 others: Enable Extension:Gather (article lists) on English Wikipedia Mobile Beta - https://phabricator.wikimedia.org/T91341#1148529 (10Moushira) hmm, just in case, how long would it take to disable the extension temporarily,... [13:30:17] 10Gather, 3Gather Sprint Diplodocus, 10Wikimedia-Extension-setup, 3Roadmap, and 2 others: Enable Extension:Gather (article lists) on English Wikipedia Mobile Beta - https://phabricator.wikimedia.org/T91341#1148581 (10Aklapper) >>! In T91341#1148529, @Moushira wrote: > just in case, how long would it take t... [13:30:57] 6Mobile-Web, 10WikiGrok: Bogus claims are saved - https://phabricator.wikimedia.org/T93825#1148583 (10phuedx) 5Open>3Resolved [13:38:36] (03CR) 10Bgerstle: "coreyfloyd I amended the patch to make the protection status assertion stronger and get checked in the other tests. can you provide some r" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199536 (owner: 10Fjalapeno) [13:47:45] 6Mobile-Web, 7Browser-Tests: Issue with Chrome driver with resizing window - https://phabricator.wikimedia.org/T88288#1148624 (10zeljkofilipin) p:5Triage>3Normal [14:03:42] 6Mobile-Web, 7Browser-Tests: MobileFrontend Selenium tests do not use page object pattern - https://phabricator.wikimedia.org/T65620#1148737 (10zeljkofilipin) [14:38:41] (03CR) 10Fjalapeno: [C: 031] Crash after migration - this value is supposed to be an array. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199536 (owner: 10Fjalapeno) [14:43:57] joakino, hi, any thoughts about https://gerrit.wikimedia.org/r/#/c/199510/ and https://gerrit.wikimedia.org/r/#/c/199549/ [14:44:11] i'm about to head to a coffee shop, time to get some work done ) [14:58:56] (03PS1) 10Yurik: Fixed lspnamespace param bug for list=listpages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199615 [14:59:15] joakino, very minor bug very annoying bug ^ [15:46:07] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Clicking add to collection on message guider throws JS exception - https://phabricator.wikimedia.org/T93827#1149186 (10Jdlrobson) @jhernandez @rmoen still an issue To replicate clear local storage Then visit http://en.m.wikipedia.beta.wmflabs.org/wiki/... [15:46:18] \o [15:46:42] (03PS8) 10Jdlrobson: Illustrate collections (suboptimal but good enough approach) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) [15:47:02] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: When I go to Special:Gather and see the collections I own they are illustrated with a page image - https://phabricator.wikimedia.org/T91675#1149190 (10Jdlrobson) https://gerrit.wikimedia.org/r/#/c/197777/ [15:47:11] (03CR) 10Deskana: [C: 031] "SHIP IT" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/199285 (owner: 10Dbrant) [15:48:06] 3Gather Sprint Diplodocus: Editor guider confusing browser tests - https://phabricator.wikimedia.org/T93898#1149195 (10Jdlrobson) 3NEW [15:48:16] 10Gather, 3Gather Sprint Diplodocus: Editor guider confusing browser tests - https://phabricator.wikimedia.org/T93898#1149203 (10Jdlrobson) [15:48:24] (03CR) 10jenkins-bot: [V: 04-1] Illustrate collections (suboptimal but good enough approach) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) (owner: 10Jdlrobson) [15:51:45] (03CR) 10Jdlrobson: [C: 032] Fixed lspnamespace param bug for list=listpages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199615 (owner: 10Yurik) [15:52:04] thanks yurik for the prompt fixes :) [15:52:24] jdlrobson2, that one was very easy, plus i'm not a big fan of crashing bugs ) [15:52:34] yeh i see :) [15:52:40] that was the one that worried me the most [15:52:44] the others seemed nice to haves [15:53:19] yurik: can you associate your patch with https://phabricator.wikimedia.org/T93793 ? [15:54:30] (03PS7) 10Yurik: lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (https://phabricator.wikimedia.org/T93793) [15:54:32] jdlrobson2, ^ [15:56:57] (03CR) 10BearND: [C: 032] Resolve redirects when doing prefixsearch. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/199285 (owner: 10Dbrant) [15:57:08] (03Merged) 10jenkins-bot: Fixed lspnamespace param bug for list=listpages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199615 (owner: 10Yurik) [15:58:12] (03CR) 10Anomie: lstprop=owner and a few bug fixes (038 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (https://phabricator.wikimedia.org/T93793) (owner: 10Yurik) [16:00:10] (03Merged) 10jenkins-bot: Resolve redirects when doing prefixsearch. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/199285 (owner: 10Dbrant) [16:00:34] (03CR) 10Jdlrobson: "I can confirm it fixes the bug :)" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (https://phabricator.wikimedia.org/T93793) (owner: 10Yurik) [16:00:50] 10Gather, 5Patch-For-Review: API: Correctly respond when I do not have the gather-hide-list right. - https://phabricator.wikimedia.org/T93793#1149244 (10Jdlrobson) Yup confirmed. That does fix it. [16:00:55] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: API: Correctly respond when I do not have the gather-hide-list right. - https://phabricator.wikimedia.org/T93793#1149245 (10Jdlrobson) [16:01:29] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: API: Correctly respond when I do not have the gather-hide-list right. - https://phabricator.wikimedia.org/T93793#1149249 (10Jdlrobson) a:5JKatzWMF>3Yurik [16:05:01] (03CR) 10Jdlrobson: [C: 04-1] "minor complaints" (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199549 (https://phabricator.wikimedia.org/T93385) (owner: 10Yurik) [16:08:36] (03PS2) 10BearND: Fix transform of video links in pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/199274 (owner: 10Dbrant) [16:08:44] (03CR) 10BearND: [C: 032] Fix transform of video links in pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/199274 (owner: 10Dbrant) [16:09:05] (03Merged) 10jenkins-bot: Fix transform of video links in pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/199274 (owner: 10Dbrant) [16:09:30] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Revamp xcode & makefile for build tasks - https://phabricator.wikimedia.org/T92886#1149301 (10Fjalapeno) Started this and pushed a patch that I needed to move forward with other tasks. Marked it as WIP, if Brian gets finished with his stuff, he can hop on this. [16:09:47] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Revamp xcode & makefile for build tasks - https://phabricator.wikimedia.org/T92886#1149303 (10Fjalapeno) a:5Fjalapeno>3None [16:10:39] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Create a fastlane configuration file for iOS builds - https://phabricator.wikimedia.org/T92884#1149304 (10Fjalapeno) [16:11:50] (03PS3) 10Yurik: Refactored abuse string testing code [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199549 (https://phabricator.wikimedia.org/T93385) [16:11:56] (03CR) 10Yurik: Refactored abuse string testing code (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199549 (https://phabricator.wikimedia.org/T93385) (owner: 10Yurik) [16:12:03] jdlrobson2, ^ [16:12:11] jdlrobson, ^ [16:12:42] yurik: much clearer! thanks :D [16:18:03] 6Mobile-Web, 7Easy, 5Patch-For-Review: Special:History on the desktop shows repeated user icon - https://phabricator.wikimedia.org/T93495#1149317 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [16:19:16] 10Gather, 3Gather Sprint Diplodocus: Editor guider confusing browser tests - https://phabricator.wikimedia.org/T93898#1149326 (10Jdlrobson) [16:20:26] (03CR) 10Jdlrobson: [C: 032] Refactored abuse string testing code [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199549 (https://phabricator.wikimedia.org/T93385) (owner: 10Yurik) [16:22:42] (03CR) 10Jdlrobson: lstprop=owner and a few bug fixes (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (https://phabricator.wikimedia.org/T93793) (owner: 10Yurik) [16:22:51] (03CR) 10Jdlrobson: [C: 04-1] "See Anomies comments" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (https://phabricator.wikimedia.org/T93793) (owner: 10Yurik) [16:23:06] (03Merged) 10jenkins-bot: Refactored abuse string testing code [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199549 (https://phabricator.wikimedia.org/T93385) (owner: 10Yurik) [16:23:43] jdlrobson, won't be able to fix that soon - only urgent matters today [16:24:14] yurik: np it's not a blocker [16:24:23] yurik: but Aaron keeps asking me to ask you to change the schema [16:24:32] yes, the schema is burning [16:24:36] https://phabricator.wikimedia.org/T93434 < that is super urgent according to him :) [16:24:54] yurik: but looks like we've almost done it :) very proud of everyone! :) [16:27:55] (03CR) 10Jdlrobson: [C: 032] Update url schemas on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199610 (https://phabricator.wikimedia.org/T93774) (owner: 10Jhernandez) [16:29:02] (03PS5) 10BearND: Remove parenthetical information from lead sentences. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197945 (https://phabricator.wikimedia.org/T91792) (owner: 10Dbrant) [16:29:20] (03CR) 10BearND: [C: 032] Remove parenthetical information from lead sentences. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197945 (https://phabricator.wikimedia.org/T91792) (owner: 10Dbrant) [16:29:54] (03Merged) 10jenkins-bot: Update url schemas on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199610 (https://phabricator.wikimedia.org/T93774) (owner: 10Jhernandez) [16:29:56] (03Merged) 10jenkins-bot: Remove parenthetical information from lead sentences. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197945 (https://phabricator.wikimedia.org/T91792) (owner: 10Dbrant) [16:30:28] (03PS1) 10Jdlrobson: Avoid fatal error when a collection has an image associated with it [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199628 [16:31:27] (03PS9) 10Jdlrobson: Illustrate collections (suboptimal but good enough approach) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) [16:33:25] (03CR) 10jenkins-bot: [V: 04-1] Illustrate collections (suboptimal but good enough approach) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) (owner: 10Jdlrobson) [16:36:02] (03PS10) 10Jdlrobson: Illustrate collections (suboptimal but good enough approach) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) [16:37:12] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Update url schemas - https://phabricator.wikimedia.org/T93774#1149409 (10Jdlrobson) @moushira @JKatzWMF note the new URLs: http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/by/Jdlrobson http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather... [16:44:18] (03PS1) 10Yurik: Require gather-hidelist right for mode=allhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199630 (https://phabricator.wikimedia.org/T93793) [16:44:30] (03PS8) 10Yurik: lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 [16:44:32] (03CR) 10jenkins-bot: [V: 04-1] lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (owner: 10Yurik) [16:44:50] jdlrobson, ^^ [16:44:56] yo jdlrobson yurik im back [16:50:57] (03PS6) 10Jdlrobson: List creation and editing validation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 (owner: 10Robmoen) [16:52:49] (03CR) 10jenkins-bot: [V: 04-1] List creation and editing validation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 (owner: 10Robmoen) [17:02:25] jdlrobson: i'm gonna have a look at images https://gerrit.wikimedia.org/r/#/c/197777/ [17:02:38] jdlrobson: sorry I kind of forgot to work on that patch for days [17:02:48] thanks joakino [17:03:36] jdlrobson: do we have a task to properly do this on the api and remove this? Lets let yurik figure out the performance bits and constraints and we'll adapt [17:03:50] like, in the future [17:04:06] joakino, do what? [17:04:39] (03CR) 10Jhernandez: [C: 032] Avoid fatal error when a collection has an image associated with it [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199628 (owner: 10Jdlrobson) [17:05:09] yurik: so basically in the short term the image for a collection will be the first page image in the collection [17:05:10] yurik: on create/update a list (adding or removing items) api should update the list lstimage [17:05:29] (we don't provide a ui for editing the image yet) [17:05:39] could be some time till that [17:05:46] brb making tea [17:05:53] the problem is finding the first page image on a collection sounds horrible performancewise [17:05:58] from the api perspective you can simply add an image while creating updating the list [17:06:12] yurik: but you also have to reset it when you remove an item from the collection [17:06:15] :-/ [17:06:24] i see [17:06:28] and what if someone does edit it via the api? [17:06:37] how do we know not to override it [17:06:40] it becomes very messy [17:06:50] yeah it is a bit problematic [17:06:54] the hack right now that I have proposed is when you render a collection, we update it then [17:07:01] (render your own collection) [17:07:01] jdlrobson, it would become messy regardless - either it is automatic or it is manual [17:07:12] since you already have the page images available from viewing it [17:07:14] (03Merged) 10jenkins-bot: Avoid fatal error when a collection has an image associated with it [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199628 (owner: 10Jdlrobson) [17:07:15] i guess we can introduce the automatic mode [17:07:17] so it only requires one write command [17:07:36] downside is if you don't view your collection before sharing it there will be no illustration [17:08:23] yurik: jdlrobson: i think this needs to go through jkatz so that he knows about the tradeoffs of the user story, and possible ways to do this [17:08:24] ok, how about this (should be easy enough to do) - if you use the "image" params of the editlist, the list switches to "manual" image selection mode [17:08:51] otherwise, it automatically figures out the image to show [17:09:00] yurik: that sounds ideal [17:09:13] ok, will see what i can do and when. [17:09:20] probably won't be done for the next 20 hrs [17:09:43] k, we'll merge the manual aproach for now and revise when that's done, don't worry yurik [17:10:05] ok [17:10:15] (03CR) 10Fjalapeno: "Sorry Monte should have been a bit more clear - I can see "What" you fixed and "Why" you fixed it" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199540 (owner: 10Mhurd) [17:10:45] yurik: +++++ [17:10:58] yurik: i'll create a card [17:11:07] jdlrobson, ok [17:11:12] joakino: i've told jk about the current non-ideal situation [17:11:28] cool [17:11:32] jdlrobson, joakino, is there a code already that pics an image for a given article? [17:11:54] yurik: kinda.. [17:12:02] php? [17:12:06] you can either create a new collection Collection::newFromApi [17:12:09] but that also gets other stuff [17:12:15] or you can directly call PageImage pai [17:12:17] *api [17:12:40] yurik we had a store that fetched images for articles [17:12:43] let me find it [17:14:22] 10Gather, 6Mobile-Web, 10Analytics: Update main menu schema to include collections for limn graphs - https://phabricator.wikimedia.org/T93690#1149518 (10bmansurov) [17:15:38] 10Gather: Allow collection image to be automatic or manual - https://phabricator.wikimedia.org/T93912#1149527 (10Jdlrobson) 3NEW [17:17:34] yurik: found this on the git history https://gist.github.com/joakin/8480aee1d475e7bc0646 [17:18:25] yurik: there is a similar method on the PageImages extension api but it is private [17:22:37] 6Mobile-Web, 10Analytics, 5Patch-For-Review: Update main menu schema to include collections for limn graphs - https://phabricator.wikimedia.org/T93690#1149557 (10Jdlrobson) [17:22:46] 3Gather Sprint E, 6Mobile-Web, 10Analytics, 5Patch-For-Review: Update main menu schema to include collections for limn graphs - https://phabricator.wikimedia.org/T93690#1143524 (10Jdlrobson) [17:29:01] jdlrobson: the images patch updates the api every time the collection is loaded? [17:29:21] i mean, it calls the api once for every collection display [17:29:38] (03PS2) 10Florianschmidtwelzow: Add CodeMirror for alpha users to better understand wikitext [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195995 (https://phabricator.wikimedia.org/T91796) [17:29:52] joakino: every time the collection is loaded ... by the owner of the collection [17:30:03] yeh it's not ideal but it needs to take into account changes [17:30:22] jdlrobson: o yea, missed that bit. [17:30:30] i can improve it further.. [17:30:37] i could update it so it only writes when the suggested image is different from the current image [17:30:46] let me take a quick look [17:30:54] jdlrobson: that may be interesting [17:31:16] jdlrobson: also, this just works for the first page which is what we show now, right? first 50 items [17:31:19] mhurd coreyfloyd i'll review some of your patches while you review mine [17:31:27] correct [17:31:32] if we had pagination every page the owner visited would change the image [17:31:34] jdlrobson: oki [17:31:57] jdlrobson: gonna test it, looks good to merge, do you want to add the !== current image check? [17:32:19] mhurd when you're done reviewing testing my patch, would you put up a phab ticket or something for the bug your patch fixes so i can verify it? otherwise the code seems OK and there shouldn't be much of a performance hit since AFAIK we're only saving an extra few plist files [17:32:42] bgerstle: k [17:32:58] coreyfloyd: same for yours https://gerrit.wikimedia.org/r/#/c/199536/, i'm not sure how to repro the crash (which i guess is in articlefetcher, but i have no idea how that would happen) [17:34:40] (03CR) 10Jdlrobson: [C: 04-1] "mm it's in mw.eventLog.schemas but still getting the error" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199532 (https://phabricator.wikimedia.org/T93706) (owner: 10Jdlrobson) [17:34:40] mhurd: you want to talk real quick - i got 10 minutes [17:34:47] bgerstle: you want to hangout too [17:34:59] sure [17:37:47] joakino: almost done the check [17:37:59] 10Gather, 3Gather Sprint Diplodocus: Links on full gather list not updated for new url schema - https://phabricator.wikimedia.org/T93914#1149594 (10JKatzWMF) 3NEW [17:39:08] jdlrobson: 👍 [17:39:11] works fine here [17:40:19] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Update url schemas - https://phabricator.wikimedia.org/T93774#1149613 (10JKatzWMF) @jdlrobson I thought the goal was to have the project-wide lists be http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/all... or Gather/all/public, Gather/all/hid... [17:41:12] (03PS1) 10Florianschmidtwelzow: Hygiene: Don't add Echo modules, if Echo isn't installed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199640 [17:43:22] jdlrobson: rmoen: testing out i saw this http://i.imgur.com/sh01DuJ.png on beta, that's what happens with the tutorial :( [17:43:28] (03PS11) 10Jdlrobson: Illustrate collections (suboptimal but good enough approach) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) [17:43:32] ^ joakino boooom [17:43:37] jdlrobson: 👍 [17:43:53] joakino: yeh the guider has been playing up all week bmansurov and FlorianSW have been looking at it too [17:44:02] i'm sure we can work it out today [17:44:25] joakino: so i put it in a private function to make it easier to kill in future [17:44:31] $imageChanged is the main change i introduced [17:44:31] awesome [17:45:02] what i've been looking at? *confused* [17:45:07] (03PS12) 10Jdlrobson: Illustrate collections (suboptimal but good enough approach) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) [17:45:21] ^ this slight tweak makes sure we only save if suggested image is not null [17:45:28] oh wait that's bad [17:45:28] (03CR) 10Fjalapeno: [C: 031] "Monte explained over hangout" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199540 (owner: 10Mhurd) [17:45:39] we need that i guess since $suggestedImage might be null if a page gets removed [17:45:53] (03PS13) 10Jdlrobson: Illustrate collections (suboptimal but good enough approach) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) [17:46:10] ^ yeh so this is best i can do. [17:46:27] bgerstle: oh, did you have anything else for me before i test? [17:46:35] mhurd nope [17:46:40] bgerstle: hehe cool [17:47:14] * Deskana sighs [17:47:21] argg head scrambled. [17:47:27] I am not impressed that I have just been asked to cancel our planning session the day before it is set to occur. [17:47:41] FlorianSW: talking about https://phabricator.wikimedia.org/T91047 [17:47:50] still lots of issues it seems :/ [17:48:34] jdlrobson: unfortunately, yes :( [17:49:24] 6Mobile-Web: Editor Tutorial: Space bewteen banner and editor pencil is always different in stable/beta/alpha - https://phabricator.wikimedia.org/T93820#1149644 (10Florian) [17:49:25] 3Gather Sprint Diplodocus, 6Mobile-Web, 5Patch-For-Review: EditorTutorial false arrow position - https://phabricator.wikimedia.org/T91047#1149645 (10Florian) [17:50:18] joakino: it looks better in chrome [17:50:55] dr0ptp4kt: corey +1’ed https://gerrit.wikimedia.org/r/#/c/199540/ [17:50:57] jdlrobson: that was chrome :S [17:51:09] mm [17:52:09] jdlrobson: this is ma firefox on beta http://i.imgur.com/u5gWnbG.png [17:52:10] 3Gather Sprint Diplodocus, 6Mobile-Web, 5Patch-For-Review: EditorTutorial false arrow position - https://phabricator.wikimedia.org/T91047#1149656 (10Jdlrobson) Mm.. this still seems problematic in alpha & beta See http://en.m.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?mobileaction=beta with local storag... [17:52:22] same shit, different smell [17:52:31] bHAHhahah ANNOYING [17:52:33] xD [17:52:42] * jdlrobson goes to grab some breakfast. [17:52:51] i'll be back in 10 [17:53:09] 6Mobile-Web, 7Easy: Special:History on the desktop shows repeated user icon - https://phabricator.wikimedia.org/T93495#1149660 (10Amire80) a:5Jdlrobson>3Amire80 [17:53:10] btw this is handy for php regexes http://www.phpliveregex.com/ [17:53:14] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: When sharing articles on mobile apps by email, use the page title as the subject - https://phabricator.wikimedia.org/T91081#1149663 (10Deskana) [17:54:41] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: "Nearby" feature does not work in Android Wikipedia Beta when language is Armenian and some other languages - https://phabricator.wikimedia.org/T89703#1149672 (10Deskana) [17:55:46] (03CR) 10Jhernandez: [C: 032] Illustrate collections (suboptimal but good enough approach) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) (owner: 10Jdlrobson) [17:56:30] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: When I go to Special:Gather and see the collections I own they are illustrated with a page image - https://phabricator.wikimedia.org/T91675#1149677 (10Jhernandez) Here we go [17:56:37] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: "Nearby" feature does not work in Android Wikipedia Beta when language is Armenian and some other languages - https://phabricator.wikimedia.org/T89703#1043195 (10Deskana) I'm guessing that this is the same problem that we had on other wikis, namely that the... [17:57:34] (03Merged) 10jenkins-bot: Illustrate collections (suboptimal but good enough approach) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197777 (https://phabricator.wikimedia.org/T91675) (owner: 10Jdlrobson) [17:58:41] mhurd: https://gerrit.wikimedia.org/r/#/c/199540 looks okay to me, but bgerstle, would you please review in gerrit to ensure no adverse interactions? [17:58:55] dr0ptp4kt: yep [17:58:58] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: When I go to Special:Gather and see the collections I own they are illustrated with a page image - https://phabricator.wikimedia.org/T91675#1149690 (10Jhernandez) [18:00:09] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: When I go to Special:Gather and see the collections I own they are illustrated with a page image - https://phabricator.wikimedia.org/T91675#1093022 (10Jhernandez) We'll open a task to do this properly on the api on update/create and remove this way of u... [18:02:20] having trouble getting the hang-out to work [18:11:28] am looking at the EL issue now [18:12:46] (03CR) 10Dr0ptp4kt: "@Fjalapeno / @coreyfloyd, thanks for adding the license verbiage. But, what about the restriction in it? How do we reconcile this license'" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199324 (owner: 10Fjalapeno) [18:13:13] (03PS1) 10Florianschmidtwelzow: Fix function on undefined when click "Add to collection" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199646 [18:13:24] Deskana: coreyfloyd ^^ i'll reach out to legal [18:13:24] wohoo, first change to Gather :D [18:13:31] FlorianSW: :) [18:14:03] (03CR) 10Jdlrobson: [C: 032] Fix function on undefined when click "Add to collection" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199646 (owner: 10Florianschmidtwelzow) [18:14:06] he scoressssssss!!! [18:14:29] (03PS2) 10Jdlrobson: Fix function on undefined when click "Add to collection" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199646 (https://phabricator.wikimedia.org/T93827) (owner: 10Florianschmidtwelzow) [18:14:39] (03CR) 10Jdlrobson: [C: 031] Fix function on undefined when click "Add to collection" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199646 (https://phabricator.wikimedia.org/T93827) (owner: 10Florianschmidtwelzow) [18:14:44] (03CR) 10Jdlrobson: [C: 032] Fix function on undefined when click "Add to collection" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199646 (https://phabricator.wikimedia.org/T93827) (owner: 10Florianschmidtwelzow) [18:15:03] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Clicking add to collection on message guider throws JS exception - https://phabricator.wikimedia.org/T93827#1149805 (10Jdlrobson) a:5rmoen>3Florian [18:15:33] http://hatjitsu.wmflabs.org/64597 [18:15:47] (03CR) 10Jdlrobson: [C: 032] Require gather-hidelist right for mode=allhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199630 (https://phabricator.wikimedia.org/T93793) (owner: 10Yurik) [18:16:41] so rmoen for list validation shall we just drop the check if the collection name is already in use? as yurik said i think that we should make this happen on the API, but limiting titles/description seem like a good use of frontend validation [18:17:02] crap, i was basically just doing https://gerrit.wikimedia.org/r/#/c/199646/, didn't know I was removed [18:17:03] (03CR) 10Dr0ptp4kt: [C: 04-1 V: 04-1] "Actually, it seems https://github.com/mwaterfall/MWFeedParser/blob/master/LICENSE.txt also has this same restriction: "2. This Software ca" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199324 (owner: 10Fjalapeno) [18:17:49] jdlrobson, rmoen - in general - let api do any kind of data logic validation. Only provide the most basic validation on the front end. Also, soonish we should revisit error messages [18:17:51] jdlrobson: shoudln't the fontend be able to query if a title exists? Or have we decided we would just throw an error when adding ? [18:17:58] api should be returning all the errors in the localized way [18:18:04] (03CR) 10Dr0ptp4kt: Fix Bug T93662 (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199324 (owner: 10Fjalapeno) [18:18:26] rmoen: it should just throw an error when you try to do that. [18:18:31] jdlrobson: ok [18:18:35] (03Merged) 10jenkins-bot: Fix function on undefined when click "Add to collection" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199646 (https://phabricator.wikimedia.org/T93827) (owner: 10Florianschmidtwelzow) [18:18:42] i think it's rare that this will happen [18:18:42] I'll remove [18:18:55] rmoen, try to add - if it fails - show an error. Unless of course you want something more elaborate like a status text "green - can be created" / "red - already exists, pick a different name" [18:19:41] (03Merged) 10jenkins-bot: Require gather-hidelist right for mode=allhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199630 (https://phabricator.wikimedia.org/T93793) (owner: 10Yurik) [18:22:13] 10Gather: user who creates a new collection is shown an overlay showing them to click on the hamburger menu to visit their collections. - https://phabricator.wikimedia.org/T93628#1149834 (10MSyed) a:3MSyed [18:23:34] (03PS9) 10Yurik: lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 [18:24:19] (03PS4) 10Jdlrobson: Register EL schema ResourceLoader module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199532 (https://phabricator.wikimedia.org/T93706) [18:24:35] bmansurov, http://hatjitsu.wmflabs.org/64597 [18:24:38] http://hatjitsu.wmflabs.org/64597 [18:25:09] (03PS5) 10Jdlrobson: Register EL schema ResourceLoader module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199532 (https://phabricator.wikimedia.org/T93706) [18:25:22] jdlrobson: rmoen: yurik: gonna be heading out soon [18:25:35] joakino: np! I fixed the EL issue ^ :D [18:25:55] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Article reader sees message/guidance about creating a collection so that they know the feature exists and the entry point - https://phabricator.wikimedia.org/T91015#1149846 (10Jdlrobson) [18:25:56] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Clicking add to collection on message guider throws JS exception - https://phabricator.wikimedia.org/T93827#1149845 (10Jdlrobson) 5Open>3Resolved [18:25:59] let me see [18:26:53] that just leaves fixing the database schema and working out what's going on with the editor guider [18:27:16] gret [18:27:18] great [18:27:20] almost done [18:27:45] i'll do testing if there is nothing really important, and i'll try to get more browser tests, I think we are missing cases [18:28:27] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: API: Correctly respond when I do not have the gather-hide-list right. - https://phabricator.wikimedia.org/T93793#1149862 (10Jdlrobson) 5Open>3Resolved [18:28:47] yep should switch focus to tests of all sorts [18:29:25] (03CR) 10Jhernandez: [C: 031] "Looks good, can't test because I don't have EL right now." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199532 (https://phabricator.wikimedia.org/T93706) (owner: 10Jdlrobson) [18:29:32] and hygieney stuff i guess [18:29:43] yea [18:29:52] 10Gather, 3Gather Sprint Diplodocus: Links on full gather list not updated for new url schema - https://phabricator.wikimedia.org/T93914#1149864 (10Jdlrobson) a:3Jdlrobson [18:30:39] (03PS1) 10Jdlrobson: Fix broken urls on Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199650 (https://phabricator.wikimedia.org/T93914) [18:30:41] ^ joakino [18:30:59] 3Gather Sprint Diplodocus, 6Mobile-Web, 5Patch-For-Review: EditorTutorial false arrow position - https://phabricator.wikimedia.org/T91047#1149873 (10Jdlrobson) a:5Jdlrobson>3None [18:31:06] jdlrobson: oops forgot about those [18:31:32] (03CR) 10Jhernandez: [C: 032] Fix broken urls on Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199650 (https://phabricator.wikimedia.org/T93914) (owner: 10Jdlrobson) [18:32:23] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Caching issues? - https://phabricator.wikimedia.org/T92573#1149884 (10Jdlrobson) 5Open>3Resolved The issue is no longer present [18:33:17] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Update url schemas - https://phabricator.wikimedia.org/T93774#1149888 (10Jdlrobson) Sorry that URL does still work it just redirects to GatherLists temporarily... We're cleaning that up next sprint. [18:34:10] 10Gather, 3Gather Sprint E: Special:GatherLists should use views and models - https://phabricator.wikimedia.org/T93422#1149903 (10Jdlrobson) [18:34:22] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Update url schemas - https://phabricator.wikimedia.org/T93774#1149910 (10Jdlrobson) (see T93422) [18:35:13] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Project wide list of collections should be sorted by last modified date - https://phabricator.wikimedia.org/T93303#1149916 (10Jdlrobson) 5Open>3Resolved [18:35:14] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Project-wide list of collections - https://phabricator.wikimedia.org/T92782#1149917 (10Jdlrobson) [18:35:44] 10Gather, 7Tracking: Tracking: Performance in Gather - https://phabricator.wikimedia.org/T92857#1149922 (10Jdlrobson) [18:35:45] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Only call API dynamically except for special:gather - https://phabricator.wikimedia.org/T92711#1149921 (10Jdlrobson) 5Open>3Resolved [18:35:51] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: An admin is able to hide or unhide a list. - https://phabricator.wikimedia.org/T91444#1149925 (10Jdlrobson) [18:35:52] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: API: Add gather-admin security right and allow those users to hide public lists. - https://phabricator.wikimedia.org/T93263#1149924 (10Jdlrobson) 5Open>3Resolved [18:36:22] (03Merged) 10jenkins-bot: Fix broken urls on Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199650 (https://phabricator.wikimedia.org/T93914) (owner: 10Jdlrobson) [18:36:57] (03PS6) 10Bgerstle: Fix for article section image data saving regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199540 (owner: 10Mhurd) [18:37:43] (03CR) 10Bgerstle: "mhurd i amended the patch because the assertion was throwing false negatives. see below (using improved assertion message):" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199540 (owner: 10Mhurd) [18:38:10] bgerstle: cool! [18:38:15] (03CR) 10Bgerstle: "i probably should've put it in a separate patch, but it was interfering w/ me testing this one" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199540 (owner: 10Mhurd) [18:38:25] bgerstle: no worry [18:38:52] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: API: Gather edits to list name or description (and list creation) go through abusefilter - https://phabricator.wikimedia.org/T93385#1149948 (10Jdlrobson) 5Open>3Resolved @JKatzWMF do you want to test and sign off? I've setup a rule on beta labs such... [18:39:23] (03CR) 10Bgerstle: [C: 031] "looks like section Images.plist are back! nice work :-)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199540 (owner: 10Mhurd) [18:40:01] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Admin tools do not show up in Special:GatherList on Vector or mobile stable - https://phabricator.wikimedia.org/T93795#1149953 (10Jdlrobson) 5Open>3Resolved [18:44:14] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: API: User cannot make their list public or private (even via API) if moderator has made it hidden - https://phabricator.wikimedia.org/T93382#1149989 (10Jdlrobson) 5Open>3Resolved [18:45:08] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: After hiding list I cannot unhide it - https://phabricator.wikimedia.org/T93821#1150004 (10Jdlrobson) 5Open>3Resolved Now possible at http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:GatherLists/hidden [18:45:23] 6Mobile-Web, 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: Hover styles differ between MediaWiki UI buttons and OOjs UI buttons - https://phabricator.wikimedia.org/T92566#1150009 (10Nirzar) @kaldari I don't think the screenshots attached in task description are the hover styles. they are :focus... [18:46:51] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: When I go to Special:Gather and see the collections I own they are illustrated with a page image - https://phabricator.wikimedia.org/T91675#1150019 (10Jdlrobson) Note to test this you'll have to visit your collections one by one - then any images will b... [18:48:39] alright bb! [18:49:39] (03PS7) 10Robmoen: List creation and editing validation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 [18:49:58] (03PS8) 10Robmoen: List creation and editing validation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 [18:50:19] mhurd: sorry I forgot to commit a linting fix for the patch I amended and was in the middle of testing when internet went out 😡 [18:50:44] bgerstle: ah no problem, just wrapping up import testing [18:52:26] I blame coreyfloyd for the outage since [18:52:28] He caused [18:52:39] ... Me to mention my ISP [18:52:50] (03CR) 10jenkins-bot: [V: 04-1] List creation and editing validation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 (owner: 10Robmoen) [18:52:53] And a la beetlejuice, they appeared to make my life miserable [18:53:16] And apparently I suck a phone typing [18:53:56] 6Mobile-Web: Override needed to prevent mobile version from changing ambox text to "this page has some issues" - https://phabricator.wikimedia.org/T93922#1150073 (10Aklapper) {{ambox}} is hidden by default according to T68747#702268. Is this the same as {T65556} (which was supposed to be fixed but maybe broke a... [18:55:44] bgerstle: https://gerrit.wikimedia.org/r/#/c/198432/ looks good. i saw we merge it [18:55:51] *say* [18:56:02] (03PS6) 10Jdlrobson: Register EL schema ResourceLoader module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199532 (https://phabricator.wikimedia.org/T93706) [18:56:49] (03PS9) 10Robmoen: List creation and editing validation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 [18:57:30] (03PS7) 10Robmoen: Register EL schema ResourceLoader module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199532 (https://phabricator.wikimedia.org/T93706) (owner: 10Jdlrobson) [18:57:39] (03CR) 10Jdlrobson: List creation and editing validation (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 (owner: 10Robmoen) [18:58:08] (03CR) 10Jdlrobson: "I'll fix this up then merge." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 (owner: 10Robmoen) [18:58:36] (03CR) 10Robmoen: [C: 032] Register EL schema ResourceLoader module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199532 (https://phabricator.wikimedia.org/T93706) (owner: 10Jdlrobson) [18:58:46] (03PS10) 10Jdlrobson: List creation and editing validation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 (owner: 10Robmoen) [18:59:00] (03CR) 10Jdlrobson: [C: 032] List creation and editing validation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 (owner: 10Robmoen) [18:59:06] brb lunches [19:01:55] (03PS1) 10Florianschmidtwelzow: Fix actions on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199659 [19:07:56] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Links on full gather list not updated for new url schema - https://phabricator.wikimedia.org/T93914#1150146 (10Jdlrobson) 5Open>3Resolved [19:08:48] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Notify user of list being public before they create it! - https://phabricator.wikimedia.org/T93239#1150156 (10Jdlrobson) 5Open>3Resolved [19:08:52] (03PS1) 10Florianschmidtwelzow: Fix undefined length on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199663 [19:09:08] (03PS1) 10Yurik: Reworked database schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199664 (https://phabricator.wikimedia.org/T93434) [19:09:12] jdlrobson, ^ [19:09:26] yurik: \o/ my hero [19:10:01] * yurik feels the need of some spinach just about now... [19:10:10] (03PS2) 10Florianschmidtwelzow: Fix undefined length on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199663 [19:11:31] (03CR) 10jenkins-bot: [V: 04-1] Reworked database schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199664 (https://phabricator.wikimedia.org/T93434) (owner: 10Yurik) [19:12:13] (03Merged) 10jenkins-bot: Register EL schema ResourceLoader module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199532 (https://phabricator.wikimedia.org/T93706) (owner: 10Jdlrobson) [19:12:15] (03Merged) 10jenkins-bot: List creation and editing validation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/198430 (owner: 10Robmoen) [19:12:17] yurik: i'm pinging aaron [19:12:40] * yurik paging dr aaron... (in a hospital voice) [19:13:21] (03PS2) 10Yurik: Reworked database schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199664 (https://phabricator.wikimedia.org/T93434) [19:13:23] (03CR) 10Fjalapeno: "Adam… Feel free to follow up with legal, but I am definitely am not seeing any way that we are violating this part of license in question:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199324 (owner: 10Fjalapeno) [19:13:32] dr0ptp4kt: ^ [19:14:16] (03CR) 10Jdlrobson: [C: 04-1] "Out of interest Florian where are you seeing this error? mw.config.get( 'wgGatherCollections' ); should always be true... :-S" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199663 (owner: 10Florianschmidtwelzow) [19:15:15] FlorianSW: you around? [19:15:54] * FlorianSW reporting for duty [19:15:57] jdlrobson: :D [19:16:08] FlorianSW: hey :) just made a slight suggestion to your patch [19:16:24] i'm just wondering why mw.config.values.wgGatherCollections has an id that's a string [19:16:29] that seems to be the bug here :) [19:17:24] FlorianSW: ahhh i think i see the issue [19:18:08] jdlrobson, btw, i really feel we should standardise on the names... like s/collection/list/ ... [19:18:33] otherwise it is all over the place... and max suggested we don't use collection because of some silly conflict, but regardless, it should be the same all aroudn [19:18:35] yurik: talk to Jon K i'm not touching naming with a barge pole [19:18:46] they did a survey [19:18:51] oh boy [19:18:52] collections won outright [19:19:01] jdlrobson: i haven't looked where 'wgGatherCollections' is set :/ So probably there is a problem. [19:19:01] than why am i using lists??? [19:19:02] grr [19:19:11] yurik: i did tell you.. [19:19:12] it should be consistent ((( [19:19:14] but you listened to MaxSem :) [19:19:19] heh [19:19:20] i tried to help you.. :P [19:19:27] FlorianSW: SpecialGather::renderUserCollection passes an id that is a string not an integer [19:19:30] i could still rename it... not hard [19:19:58] once DB in prod, we won't be able to rename it [19:20:06] 6Mobile-Web: Override needed to prevent mobile version from changing ambox text to "this page has some issues" - https://phabricator.wikimedia.org/T93922#1150212 (10TheDJ) No the problem the user is describing, is that not all amboxes are 'issues' per se (the word issues has an implication of negativity). As an... [19:21:08] (03CR) 10Jdlrobson: [C: 04-1] Fix actions on Special:Gather (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199659 (owner: 10Florianschmidtwelzow) [19:21:16] MaxSem, any thoughts of why i shouldn't rename list->collection.../ [19:21:17] ? [19:21:21] ah, ok, let me look :) To https://gerrit.wikimedia.org/r/#/c/199663 I have opened it with #/collection/0/edit that's why i got this error. I think ext.gather.special shouldn't be loaded on the special page's overview list, so i think we should just load it, if we show a collection? :) [19:21:42] * yurik thinks typing "list" is shorter... [19:23:22] * yurik is lazy, will keep it as is :) [19:23:43] 6Mobile-Web: Override needed to prevent mobile version from changing ambox text to "this page has some issues" - https://phabricator.wikimedia.org/T93922#1150239 (10Jdlrobson) Is there a better class to use? Information boxes do not render well either. In the talk page 'this page has issues' is changed to 'about... [19:24:05] (03PS3) 10Yurik: Reworked database schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199664 (https://phabricator.wikimedia.org/T93434) [19:24:25] 6Mobile-Web: Override needed to prevent mobile version from changing ambox text to "this page has some issues" - https://phabricator.wikimedia.org/T93922#1150243 (10Jdlrobson) How easy would it be to add a class to all page issue templates? e.g. amboxissue Are the templates shared across projects? [19:25:51] 3Gather Sprint Diplodocus: Edit workflow broken - https://phabricator.wikimedia.org/T93933#1150255 (10Jdlrobson) 3NEW a:3Florian [19:26:07] (03PS3) 10Jdlrobson: Fix undefined length on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199663 (https://phabricator.wikimedia.org/T93933) (owner: 10Florianschmidtwelzow) [19:26:15] ^ FlorianSW thats the bug you are fixing :) [19:26:48] jdlrobson: ok :D [19:28:11] (03PS10) 10Jdlrobson: lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (owner: 10Yurik) [19:31:03] 10Gather, 3Gather Sprint Diplodocus: Editor guider confusing browser tests - https://phabricator.wikimedia.org/T93898#1150292 (10Jdlrobson) I'm not sure how this happened. Waiting to see if fixed in next build. [19:31:55] (03PS2) 10Florianschmidtwelzow: Fix actions on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199659 [19:31:57] (03CR) 10jenkins-bot: [V: 04-1] Fix actions on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199659 (owner: 10Florianschmidtwelzow) [19:33:58] (03PS3) 10Florianschmidtwelzow: Fix actions on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199659 [19:36:05] 6Mobile-Web: Override needed to prevent mobile version from changing ambox text to "this page has some issues" - https://phabricator.wikimedia.org/T93922#1150330 (10TheDJ) @jdlrobson On talk pages, you do not have ambox'es, these are tmbox'es and they carry a corresponding class to indicate their different natur... [19:36:39] (03CR) 10jenkins-bot: [V: 04-1] Fix actions on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199659 (owner: 10Florianschmidtwelzow) [19:39:05] jdlrobson: actually, mboxes are pretty well separated and properly meta'ed. We can definetly make small changes there if required. biggest problem there would be the forks accross multiple wiki languages. [19:40:41] 3Gather Sprint Diplodocus, 6Mobile-Web, 5Patch-For-Review: EditorTutorial false arrow position - https://phabricator.wikimedia.org/T91047#1150363 (10Jdlrobson) Mmm.. the positioning seems to have no method to its madness. Here are some tests I just ran... For watchstar: beta: push left by 18px alpha: pushe... [19:40:42] (03PS4) 10Florianschmidtwelzow: Fix undefined length on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199663 (https://phabricator.wikimedia.org/T93933) [19:40:53] thedj: :-/ [19:41:17] (03PS4) 10Florianschmidtwelzow: Fix actions on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199659 [19:41:20] thedj: could this use some variation of article emblems in some way? [19:42:03] sure, if you can find a reasonably 'domain agnostic' way to describe issues. [19:42:08] (03CR) 10Jdlrobson: [C: 04-1] "also update commit message :)" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199659 (owner: 10Florianschmidtwelzow) [19:42:16] thedj: :-SSSS [19:42:46] well i think i already mentioned parts of it :) [19:43:10] (03CR) 10jenkins-bot: [V: 04-1] Fix undefined length on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199663 (https://phabricator.wikimedia.org/T93933) (owner: 10Florianschmidtwelzow) [19:43:45] (03CR) 10Florianschmidtwelzow: Fix actions on Special:Gather (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199659 (owner: 10Florianschmidtwelzow) [19:43:52] jdlrobson: ^ don't be greedy :D [19:44:14] priority, reason (procedural, content etc), page/section, cause (most specific sub type), tracking category, date, + html and I think you have all you need [19:44:43] (03PS5) 10Florianschmidtwelzow: Fix actions on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199659 [19:45:02] short vs. long description, and 'action' (to make an issue actionable), might be other aspects. [19:46:51] jdlrobson: now, that we don't need the id anymore (https://gerrit.wikimedia.org/r/#/c/199663/4/resources/ext.gather.special/init.js) should be remove it from the link? [19:48:46] thedj: if i remember correctly when we implemented it this way it was for the other projects [19:49:05] thedj: we could make it customisable [19:49:18] that way we could fix on a per wiki basis [19:49:30] (on short term) [19:49:53] could be an option yes. [19:50:56] (03CR) 10Jdlrobson: Fix actions on Special:Gather (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199659 (owner: 10Florianschmidtwelzow) [19:51:00] (03PS5) 10Florianschmidtwelzow: Fix undefined length on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199663 (https://phabricator.wikimedia.org/T93933) [19:52:34] (03CR) 10Jdlrobson: [C: 032] Fix actions on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199659 (owner: 10Florianschmidtwelzow) [19:53:23] 10Gather, 3Gather Sprint Diplodocus: Editor guider confusing browser tests - https://phabricator.wikimedia.org/T93898#1150420 (10Jdlrobson) Waiting on https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/52/ [19:54:31] (03PS6) 10Florianschmidtwelzow: Fix actions on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199659 [19:54:54] yurik, both terms are misleading: list is too generic, collection is strongly associated with a particular extension [19:55:17] MaxSem, ohh well, keeping as is [19:56:50] jdlrobson: can you -2 this fast? https://gerrit.wikimedia.org/r/#/c/199659/6 [19:57:00] i forgot to add the second message to Resources :D [19:57:04] (03CR) 10Jdlrobson: [C: 04-2] Fix actions on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199659 (owner: 10Florianschmidtwelzow) [19:57:11] done [19:57:22] thx [19:57:55] (03CR) 10Jdlrobson: [C: 04-1] Fix undefined length on Special:Gather (034 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199663 (https://phabricator.wikimedia.org/T93933) (owner: 10Florianschmidtwelzow) [19:58:04] (03PS7) 10Florianschmidtwelzow: Fix actions on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199659 [20:01:42] (03CR) 10Florianschmidtwelzow: Fix undefined length on Special:Gather (034 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199663 (https://phabricator.wikimedia.org/T93933) (owner: 10Florianschmidtwelzow) [20:02:21] mhurd coreyfloyd i'm back, and so is the internet! [20:09:55] (03PS6) 10Florianschmidtwelzow: Fix undefined length on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199663 (https://phabricator.wikimedia.org/T93933) [20:11:28] (03CR) 10Florianschmidtwelzow: [C: 04-1] Fix undefined length on Special:Gather (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199663 (https://phabricator.wikimedia.org/T93933) (owner: 10Florianschmidtwelzow) [20:12:13] Am I even here? [20:13:28] kristenlans: is that an existential question? [20:14:52] coreyfloyd: yep [20:16:27] kristenlans: http://38.media.tumblr.com/tumblr_m6v046HDsA1rozk7ho3_500.gif [20:17:05] kristenlans: better check on your parents in 1955… [20:17:27] phuedx: i got my coffee machine!!! [20:20:38] (03CR) 10Jdlrobson: [C: 032] Fix actions on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199659 (owner: 10Florianschmidtwelzow) [20:21:10] * jdlrobson heding to office. see you in a bit. [20:24:35] (03Merged) 10jenkins-bot: Fix actions on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199659 (owner: 10Florianschmidtwelzow) [20:30:44] (03PS1) 10Florianschmidtwelzow: Fix typing error [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199683 [20:33:13] (03CR) 10Robmoen: "The key difference is that I can depend on a whole bunch of deferred things and have a single response when they are resolved." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197979 (owner: 10Robmoen) [20:33:35] mhurd coreyfloyd dr0ptp4kt is anything left for https://gerrit.wikimedia.org/r/#/c/198432/ ? [20:34:00] dr0ptp4kt: Having some hangout issues here... [20:34:13] bgerstle: i looked through the code, and i'm going to test it in about an hour or less [20:34:13] bgerstle: not on my end [20:34:23] dr0ptp4kt: do you deliver? [20:34:48] coreyfloyd: :) [20:34:57] (03CR) 10Fjalapeno: [C: 031] "re-+1" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199540 (owner: 10Mhurd) [20:35:28] (03Abandoned) 10Robmoen: A place for tracking asynchronously loading things [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197979 (owner: 10Robmoen) [20:39:43] 6Mobile-Web: Page titles breaking in middle of the word on mobile beta - https://phabricator.wikimedia.org/T93826#1150668 (10bmansurov) @KHammerstein, how should we handle cases where a word doesn't fit in a line by itself either? [20:48:02] * MaxSem pokes aude [20:48:11] hi [20:49:14] aude, can you help me with https://gerrit.wikimedia.org/r/#/c/197760/3/includes/WikibaseRepoConnector.php please? how do I tell if a claim already exists in StatementList? [20:49:39] looking [20:51:28] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Configure Jenkins for iOS builds - https://phabricator.wikimedia.org/T92882#1150710 (10Fjalapeno) [20:52:41] 6Mobile-Web: Page titles breaking in middle of the word on mobile beta - https://phabricator.wikimedia.org/T93826#1150726 (10KHammerstein) @bmansurov they should be hyphenated [20:53:42] (03CR) 10Mhurd: "Getting an assert on line 174 of OldDataSchemaMigrator.m" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199300 (owner: 10Fjalapeno) [20:55:35] MaxSem: there are some classes in DataModel like "Claims" that appear to support this, but think those are deprecated [20:55:36] (03CR) 10Fjalapeno: "@mhurd I defer to you and bgerstle on this one:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199300 (owner: 10Fjalapeno) [20:55:39] i would not use them [20:56:02] mhurd: bgerstle ^ not sure about the assertion stuff here… [20:56:03] and not sure what to use instead at the moment, but suggest to ask thiemo [20:56:16] mhurd: do we need them or not? [20:56:19] coreyfloyd: i’ll have to lean on brian for that as well… [20:56:55] (03CR) 10Bgerstle: "coreyfloyd mhurd: FYI the assertion is fixed in my latest patch of the main fix" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199300 (owner: 10Fjalapeno) [20:57:07] mhurd: ok looks like a rebase… [20:57:50] coreyfloyd: mhurd are we waiting on dr0ptp4kt to review the preceding patch to merge it? [20:58:18] if so, dr0ptp4kt: let me know if you want to talk through the changes [20:58:21] aude, thanks - hmm. this is complicated :0 [20:58:37] in the meantime, https://gerrit.wikimedia.org/r/#/c/199540/ is good to go IMO [20:58:38] bgerstle: good point, i will wait… mhurd you want to comment that line out and continue your test. I'll wait for brians patch to be merged before rebasing [20:58:53] i think we are eliminating having Claim as a separate thing in data model [20:58:55] coreyfloyd: no need to wait since your patch depends on mine anyway [20:59:00] you'll have to do it sooner or later ;-P [20:59:02] since a statement = claim (but statement has more things) [20:59:08] bgerstle: yes waiting on adam [20:59:15] so, 1) the code is somewhat unstable [20:59:18] bgerstle: he said he wanted to test [20:59:18] bgerstle: yeah was going to wait and see if adam finds anything… [20:59:32] 2) i am not sure the current recommended way [20:59:37] sick of rebasing… [20:59:50] coreyfloyd: i hear ya [20:59:52] 3) would be happier if you could reuse more of our code in wikibase and not duplicate [21:00:02] coreyfloyd: sorry, but you brought it on yourself for working on top of an unstable patch :-P [21:00:11] IOW sorry my patch was unstable [21:10:14] lol [21:10:53] bgerstle: I'm a masochist [21:11:28] apparently... [21:12:44] 3Gather Sprint Diplodocus, 5Patch-For-Review: Edit workflow broken - https://phabricator.wikimedia.org/T93933#1150797 (10Jdlrobson) p:5Triage>3High Annoyingly the workflow is still broken. When I click save I get `Uncaught TypeError: undefined is not a function` [21:12:48] rmoen: https://phabricator.wikimedia.org/T93933 :( [21:13:20] jdlrobson2: :( [21:13:44] can you take a look? I'm taking a look at EL. FYI have an opticians appointment at 2.45pm but will be working late to make up for it [21:13:59] jdlrobson2: yeah. i'm also working on the pointer [21:14:10] thingy.. testing now [21:15:12] mhurd FWIW i didn't change anything and the tests succeeded [21:15:13] *shrug* [21:15:21] (when the article has no sections or thumbnail) [21:15:24] no assertion [21:15:52] bgerstle: huh [21:16:25] 3Gather Sprint Diplodocus: Scrolling glitch - https://phabricator.wikimedia.org/T93948#1150816 (10Jdlrobson) 3NEW [21:17:23] mhurd you said it wasn't happening on my latest patch? [21:17:44] bgerstle: right - i saw it on corey’s progess patch [21:17:52] mhurd but, not on mine, right? [21:17:58] bgerstle: not yours [21:18:02] because looking again at this assertion, it should be solid [21:18:33] i.e. if we have a thumbnail, and it's not the first image, blow up [21:18:39] if we don't have a thumbnail, doesn't matter [21:18:46] bgerstle: ya should be good [21:19:24] the case you saw where we had a thumbnail but the image list was empty must be either a bug in the migration code or a side effect caused by WebViewController, both of which now seem to be fixed [21:19:58] (03PS18) 10Bgerstle: set article imageURL and save image list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 (https://phabricator.wikimedia.org/T92697) [21:20:01] dr0ptp4kt: mhurd coreyfloyd don't panic, just adding more tests ^ [21:20:14] can never have too many tests! [21:20:15] bgerstle: lol [21:20:18] :) [21:20:30] bgerstle: good thing i didnt rebase… [21:20:37] coreyfloyd: it was only one file different [21:20:40] you should've been fine [21:20:53] but, i thought you were a masochist. aren't you disappointed? :-P [21:23:59] (03CR) 10Aaron Schulz: Reworked database schema (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199664 (https://phabricator.wikimedia.org/T93434) (owner: 10Yurik) [21:24:07] rmoen: worked it out [21:24:08] typp [21:24:34] (03PS1) 10Jdlrobson: Regression: Fix typo, fix editing workflow [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199743 (https://phabricator.wikimedia.org/T93933) [21:24:36] jdlrobson2: what task ? [21:24:38] oh [21:24:39] ^ rmoen if you could merge [21:24:40] coreyfloyd: did you try using wmf_htmlTextNodes instead of the MWFeed thingy? [21:24:41] nice [21:24:45] i'll write a test to stop that happening again [21:24:55] i ask because this looks essentially like regex/manual HTML/XML parsing [21:25:02] (03CR) 10Robmoen: [C: 032] Regression: Fix typo, fix editing workflow [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199743 (https://phabricator.wikimedia.org/T93933) (owner: 10Jdlrobson) [21:25:06] jdlrobson2: thanks [21:25:19] unless i'm reading this wrong, we should use hpple instead, which uses libxml which I would think is safer [21:25:53] i'm also not seeing where the category you added is being used [21:26:19] oh nvm found it [21:26:24] 10Gather, 3Gather Sprint Diplodocus: Editor guider confusing browser tests - https://phabricator.wikimedia.org/T93898#1150867 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson Yup that particular test passed. The only failing test is due to T93933 [21:26:32] my global search thingy was broken by my custom search scope [21:27:11] 10Gather, 3Gather Sprint Diplodocus: Add browser test for edit workflow - https://phabricator.wikimedia.org/T93949#1150874 (10Jdlrobson) 3NEW a:3Florian [21:27:28] hm, i guess we were using hpple before.. [21:27:34] what was wrong w/ it? [21:27:37] 10Gather, 3Gather Sprint Diplodocus: Add browser test for edit workflow - https://phabricator.wikimedia.org/T93949#1150874 (10Jdlrobson) a:5Florian>3None [21:28:01] be back in 40mins - heading for opticians appointment. [21:28:29] (03PS2) 10Florianschmidtwelzow: Fix typing error [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199683 (https://phabricator.wikimedia.org/T93933) [21:28:41] (03Abandoned) 10Florianschmidtwelzow: Fix typing error [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199683 (https://phabricator.wikimedia.org/T93933) (owner: 10Florianschmidtwelzow) [21:28:51] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: [SchemaGatherClicks] Missing or empty schema - https://phabricator.wikimedia.org/T93706#1150887 (10Jdlrobson) Events for this are showing up in the beta event logging schema. I've fired off all the events other than edit (which is broken) Will poke agai... [21:29:22] (03Merged) 10jenkins-bot: Regression: Fix typo, fix editing workflow [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199743 (https://phabricator.wikimedia.org/T93933) (owner: 10Jdlrobson) [21:30:17] ahh i see what the problem is... interesting [21:30:33] the previous code was dumbly joining all text nodes together, instead of adding a newline for "p" elements, etc. [21:31:37] (03PS4) 10Yurik: Reworked database schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199664 (https://phabricator.wikimedia.org/T93434) [21:32:19] coreyfloyd: wow this is borderline HTML -> RTF conversion [21:32:26] (03CR) 10Yurik: Reworked database schema (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199664 (https://phabricator.wikimedia.org/T93434) (owner: 10Yurik) [21:32:59] rmoen, ^ [21:33:24] 3Gather Sprint Diplodocus, 6Mobile-Web, 5Patch-For-Review: EditorTutorial false arrow position - https://phabricator.wikimedia.org/T91047#1150907 (10rmoen) a:3rmoen [21:33:41] coreyfloyd: just found this http://stackoverflow.com/questions/25879837/how-to-display-html-formatted-text-in-ios-label, iOS 7 only though :-((( [21:33:43] yurik: sec [21:34:41] bgerstle: yeah - i have used this before to display decently formatted html as plain text - avoiding web views / attributed strings [21:36:09] bgerstle: doh - some good stuff is available for the newer os versions… soon… [21:36:17] (03CR) 10Aaron Schulz: [C: 031] Reworked database schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199664 (https://phabricator.wikimedia.org/T93434) (owner: 10Yurik) [21:36:20] yeah, the attributed string thing seems pretty good [21:36:22] soon.. [21:40:03] 10Gather, 3Gather Sprint Diplodocus: Cannot submit collection edits - https://phabricator.wikimedia.org/T93951#1150953 (10JKatzWMF) 3NEW [21:40:17] (03PS1) 10Robmoen: Center ContentOverlay arrow alignment on element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199747 [21:40:24] 10Gather, 3Gather Sprint Diplodocus: Cannot submit collection edits - https://phabricator.wikimedia.org/T93951#1150969 (10JKatzWMF) [21:40:25] 10Gather, 3Gather Sprint Diplodocus: List edit/creation validation - https://phabricator.wikimedia.org/T92779#1150968 (10JKatzWMF) [21:40:42] dbrant|brb, bearND, dr0ptp4kt, mhurd, bgerstle, coreyfloyd, moushira, kitchen sink, everyone in the world: Design review is cancelled today. [21:40:57] Deskana: thx [21:41:02] Deskana: roger that [21:42:51] (03PS1) 10Robmoen: Don't show gather tutorial when showing edit tutorial overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199748 [21:43:13] Deskana: gotchya [21:44:27] (03CR) 10Bgerstle: [C: 031] "pending license review, but i also don't see a problem. i would love it if we could mark this code so that we can replace it with HTML at" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199324 (owner: 10Fjalapeno) [21:44:42] 10Gather, 3Gather Sprint Diplodocus: collection images in list of collections should scale to match width of collection title - https://phabricator.wikimedia.org/T93953#1151001 (10JKatzWMF) 3NEW [21:44:43] rmoen, i say go for it - aaron +1ed :) [21:44:46] https://gerrit.wikimedia.org/r/#/c/199664/ [21:44:52] Gotta run a quick errand, be back in about 20 minutes [21:44:53] yurik: looking now [21:45:13] (03PS1) 10Mhurd: Fix for lead image title glitch. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199750 [21:45:21] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Update url schemas - https://phabricator.wikimedia.org/T93774#1151012 (10JKatzWMF) 5Open>3Resolved [21:46:39] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: After hiding list I cannot unhide it - https://phabricator.wikimedia.org/T93821#1151018 (10JKatzWMF) Can someone with admin access on betalabs screenshot this for me? [21:47:31] dr0ptp4kt coreyfloyd bgerstle : tiny patch fixing an occasional lead image layout gitch: https://gerrit.wikimedia.org/r/199750 [21:47:34] coreyfloyd: you might want to contribute some of those unit tests you wrote to the original author :-P [21:48:37] yurik: i see no issues. going to test [21:49:36] dr0ptp4kt: i'm glad you're being so thorough, but if it hasn't broken by now, perhaps we should release it so other people can test? that way we can get more coverage (and potentially find bugs faster) while we review this other outstanding patches [21:49:46] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: API: Gather edits to list name or description (and list creation) go through abusefilter - https://phabricator.wikimedia.org/T93385#1151032 (10JKatzWMF) beautiful. [21:49:48] s/this/these/ [21:50:05] bgerstle: i'm just doing the ios 6 validation now [21:50:11] ok, cool [21:50:16] so far so good, then? [21:51:06] anything we could be testing in parallel? [21:51:22] dr0ptp4kt: ^ [21:52:28] bgerstle: the other patches that are based on it, if not doing so already [21:52:42] dr0ptp4kt: they're waiting to rebase until this is merged [21:52:49] (03CR) 10Robmoen: [C: 032] Reworked database schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199664 (https://phabricator.wikimedia.org/T93434) (owner: 10Yurik) [21:52:54] and there's only one, AFAIK [21:53:26] bgerstle: mhurd confirmed he tested on ios 6 physical device, so here it goes [21:53:50] (03CR) 10Dr0ptp4kt: [C: 032] "To follow up on standup, @Fjalapeno noted he did actually review code but his comments are not related to this patch per se." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/198432 (https://phabricator.wikimedia.org/T92697) (owner: 10Bgerstle) [21:54:48] (03Merged) 10jenkins-bot: Reworked database schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199664 (https://phabricator.wikimedia.org/T93434) (owner: 10Yurik) [21:54:53] Back! [21:55:12] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Project wide list of collections should be sorted by last modified date - https://phabricator.wikimedia.org/T93303#1151086 (10JKatzWMF) Can't sign off until I can edit...T93951 [21:55:13] coreyfloyd: bgerstle mhurd ^^^ rebase time [21:55:14] awesome, now let's merge some of these others and cuta build [21:55:49] bgerstle: dr0ptp4kt coreyfloyd my 2 patches should be ready as well :) [21:56:34] mhurd i think one of yours should be ready to go review-wise [21:56:51] coreyfloyd: and myself both +1'd https://gerrit.wikimedia.org/r/#/c/199540/ [21:57:14] we also need to run some perf tests on migration and decide whether or not to skip it for "recent" articles [21:57:22] (i.e. only migrate saved to preserve offline functionality" [22:00:27] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Design tweaks for Vector skin - https://phabricator.wikimedia.org/T92883#1151120 (10JKatzWMF) @jdlrobson. I am not sure what the acceptance criteria are, but the edit/delete buttons do not work. This is not a blocker for release. [22:00:35] mhurd why do you need to call "layoutIfNeeded" on a label after you set the text? [22:00:48] or is the problem the lead image view's height? [22:01:24] bgerstle: comment it out and see :) [22:01:52] mhurd i was hoping to not reverse engineer your patch in order to review it ;-) [22:02:02] bgerstle: haha fair enough [22:02:03] (03PS2) 10Dr0ptp4kt: Fix for lead image title glitch. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199750 (owner: 10Mhurd) [22:02:49] bgerstle: so, on further reflection, i’d have to comment it out and see ‘cause i can’t remember off the top of my head :) [22:02:56] haha [22:03:02] bgerstle: hold on... [22:03:02] don't you love it when that happens? ;-) [22:03:26] hehe [22:03:31] but, what i was getting at, is that usually you need to call "sizeToFit" on a label or let autolayout handle it via its intrinsic content size [22:03:41] not layoutIfNeeded [22:04:28] 10Gather, 3Gather Sprint Diplodocus: List edit/creation validation - https://phabricator.wikimedia.org/T92779#1151160 (10JKatzWMF) @rmoen. This seemed to cut off my description at 241 characters (but the defined max above is 280). What is the max you set? [22:04:46] 10Gather, 3Gather Sprint Diplodocus: List edit/creation validation - https://phabricator.wikimedia.org/T92779#1151167 (10JKatzWMF) [22:04:47] nevermind we don't need to get into this now, just wondering what changed in this patch [22:04:47] 10Gather, 3Gather Sprint Diplodocus: Cannot submit collection edits - https://phabricator.wikimedia.org/T93951#1151164 (10JKatzWMF) 5Open>3Invalid a:3JKatzWMF Seems to have resolved itself [22:05:42] (03CR) 10Dr0ptp4kt: [C: 032] Fix for lead image title glitch. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199750 (owner: 10Mhurd) [22:05:56] (03CR) 10Dr0ptp4kt: [V: 032] Fix for lead image title glitch. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199750 (owner: 10Mhurd) [22:06:06] dr0ptp4kt: um, was still reviewing that one. but OK [22:06:32] bgerstle: still looking in to it - will submit follow-on patch and let you now in a minute or 2 what i’ve found... [22:06:48] bgerstle: sorry about that [22:06:48] 10Gather, 3Gather Sprint Diplodocus: List edit/creation validation - https://phabricator.wikimedia.org/T92779#1151176 (10JKatzWMF) @rmoen, looks like it might be 180. It should be 280 [22:06:57] mhurd dr0ptp4kt just merged it, so you'll need to create a new patch [22:07:07] bgerstle: ya i see [22:07:14] coreyfloyd: FYI i'm rebasing https://gerrit.wikimedia.org/r/#/c/199536/ [22:07:24] since i wanted to look into the edit/protectionstatus bug a bi tmore [22:07:58] (03PS1) 10Robmoen: Increase the description character limit to 280 [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199757 [22:08:31] (03PS7) 10Dr0ptp4kt: Fix for article section image data saving regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199540 (owner: 10Mhurd) [22:08:32] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: List edit/creation validation - https://phabricator.wikimedia.org/T92779#1151193 (10rmoen) @JKatzWMF oops. I increased it in the above patch. [22:09:10] bgerstle: dunka [22:09:54] bgerstle: you may be right about the layoutIfNeeded. testing on older ios versions real quick... [22:10:17] mhurd: not sure if it's related, but it might be easier to move the height adjustment into layoutSubviews [22:10:35] bgerstle: ya i’ve done that before… [22:10:38] gotchya [22:10:45] (03PS3) 10Fjalapeno: Add text progress to migration Move migration to background thread / context [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199299 [22:11:03] and then you can just rely on viewDidLayoutSubviews in its view controller. but there's probably something i'm missing [22:11:31] mhurd bgerstle ^ [22:11:36] coreyfloyd: on it [22:11:54] 10Gather, 3Gather Sprint Diplodocus: Announce beta deployment on wikitech-l, enwp vp - https://phabricator.wikimedia.org/T93631#1151211 (10JKatzWMF) [22:11:55] 10Gather, 3Gather Sprint Diplodocus: Populate gather with proper feature name - https://phabricator.wikimedia.org/T92665#1151210 (10JKatzWMF) 5Open>3Resolved [22:12:06] (03PS3) 10Fjalapeno: Add progress line to data migration [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199300 [22:15:05] bgerstle: coreyfloyd mhurd any problem with me merging https://gerrit.wikimedia.org/r/#/c/199540/ ? [22:15:14] bgerstle: i think neither of those layoutIfNeeded calls are necessary any longer [22:16:09] mhurd i switched to another review since this was merged. i can have a look once you post a new patch (w/ reviewer notes ;-P) [22:16:12] bgerstle: coreyfloyd.....mhurd said https://gerrit.wikimedia.org/r/#/c/199540/ should be good to merge, but just wanted to make sure you're ready for it [22:16:56] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: API: Gather edits to list name or description (and list creation) go through abusefilter - https://phabricator.wikimedia.org/T93385#1151226 (10JKatzWMF) @jdlrobson---this doesn't seem to work on "Edit". I cannot hit submit, but I do not get a message. [22:16:58] dr0ptp4kt: i haven't reviewed it yet, but i'm not too worried about it [22:17:08] if you think and corey think it's good, then go ahead [22:17:12] (03CR) 10Jdlrobson: [C: 032] Increase the description character limit to 280 [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199757 (owner: 10Robmoen) [22:17:18] bgerstle: ya i just found issues with removing the layoutIfNeeded calls - will experiment a bit more... [22:17:23] yeah i +1'd it [22:17:23] (03PS3) 10Bgerstle: Crash after migration - this value is supposed to be an array. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199536 (owner: 10Fjalapeno) [22:17:34] gah it's a code review frenzy [22:17:50] (03CR) 10Dr0ptp4kt: [C: 032] Fix for article section image data saving regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199540 (owner: 10Mhurd) [22:17:52] coreyfloyd: but it's your patch, right? [22:17:53] oh wait [22:17:54] that one [22:17:54] yeah [22:17:59] (03CR) 10Dr0ptp4kt: [V: 032] Fix for article section image data saving regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199540 (owner: 10Mhurd) [22:18:02] (03PS1) 10Bmansurov: Hyphenate page titles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199761 (https://phabricator.wikimedia.org/T93826) [22:18:08] that was good to go [22:18:48] coreyfloyd is https://gerrit.wikimedia.org/r/#/c/199300/ rebased and ready for review? (was dependent on the release blocker patch) [22:19:49] (03Merged) 10jenkins-bot: Increase the description character limit to 280 [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199757 (owner: 10Robmoen) [22:19:49] 10Gather, 3Gather Sprint Diplodocus: Cannot submit collection edits - https://phabricator.wikimedia.org/T93951#1151234 (10Jdlrobson) [22:22:00] MaxSem: want me to +2 your hierator patch? [22:22:18] would appreciate that! :) [22:22:26] bgerstle: hangout? [22:22:31] MaxSem: done [22:22:37] mhurd about the lead image thing? [22:22:39] thanks:) [22:22:44] bgerstle: coreyfloyd mhurd able to get on a video call? [22:22:48] bgerstle: ya i think i have a handle on it [22:22:54] sure [22:22:56] dr0ptp4kt: ya [22:23:01] bgerstle: you? [22:23:06] bgerstle: able [22:23:07] bgerstle: to [22:23:10] bgerstle: get [22:23:15] bgerstle: on a video call, too? [22:23:29] i [22:23:31] think [22:23:32] so [22:23:34] bgerstle: g [22:23:36] bgerstle: r [22:23:38] l [22:23:39] o [22:23:39] bgerstle: eaaaat [22:23:40] l [22:23:53] i think everyone else hates on this channel hates us right now [22:24:04] damnit [22:24:07] everyone else on* [22:24:55] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Design tweaks for Vector skin - https://phabricator.wikimedia.org/T92883#1151262 (10Jdlrobson) WFM: {F104495} [22:25:36] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: An admin is able to hide or unhide a list. - https://phabricator.wikimedia.org/T91444#1151265 (10Jdlrobson) WFM: {F104495} [22:26:13] (03PS1) 10Bmansurov: Make list items easy to read by adding margin-bottom [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199765 (https://phabricator.wikimedia.org/T93784) [22:29:08] 10Gather, 3Gather Sprint Diplodocus: collection images in list of collections should scale to match width of collection title - https://phabricator.wikimedia.org/T93953#1151301 (10Jdlrobson) What article are you using that has the cheese on it? The code should be no different, I think this is a problem specifi... [22:29:21] 3Gather Sprint Diplodocus, 5Patch-For-Review: Update schema to incorporate feedback from Aaron and Sean - https://phabricator.wikimedia.org/T93434#1151303 (10Jdlrobson) 5Open>3Resolved [22:30:01] 3Gather Sprint Diplodocus, 5Patch-For-Review: Edit workflow broken - https://phabricator.wikimedia.org/T93933#1151313 (10Jdlrobson) 5Open>3Resolved This is now working. [22:33:37] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Edit/delete buttons do not work when in Vector skin - https://phabricator.wikimedia.org/T93960#1151322 (10Jdlrobson) 3NEW a:3Jdlrobson [22:33:40] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Design tweaks for Vector skin - https://phabricator.wikimedia.org/T92883#1151329 (10JKatzWMF) excellent! [22:33:52] 6Mobile-Web, 5Patch-For-Review: Lists should have greater line-height to improve readability - https://phabricator.wikimedia.org/T93784#1151331 (10KHammerstein) @bmansurov Can you attach a screenshot when finished? Just want to make sure it looks alright. Thanks! [22:34:29] 10Gather, 3Gather Sprint Diplodocus: collection images in list of collections should scale to match width of collection title - https://phabricator.wikimedia.org/T93953#1151336 (10Jdlrobson) On Vector they repeat when the image is small - not sure what's better. {F104503} [22:35:11] (03PS4) 10Dr0ptp4kt: Add text progress to migration Move migration to background thread / context [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199299 (owner: 10Fjalapeno) [22:43:54] coreyfloyd: interestingly, it doesn't crash, but WebKit will internally catch the exception and bail out w/ a log to teh console [22:44:37] 10Gather, 3Gather Sprint Diplodocus, 10Wikimedia-Extension-setup, 3Roadmap, and 2 others: Enable Extension:Gather (article lists) on English Wikipedia Mobile Beta - https://phabricator.wikimedia.org/T91341#1080503 (10JKatzWMF) @eloquence. We are pushing back 2 days in order to deploy on test wiki first.... [22:46:17] (03CR) 10Bgerstle: [C: 031] "didn't actually crash the app for me, but this does fix an exception thrown in WebKit which results in a console log and prevents the "You" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199536 (owner: 10Fjalapeno) [22:46:23] mhurd dr0ptp4kt ^ [22:46:38] will follow up w/ "editable" later... probably after dinner [22:46:52] dr0ptp4kt: mhurd or you guys can take a crack at it, but i've gotta break for now [22:47:02] bgerstle: sounds good! [22:49:29] (03CR) 10Bgerstle: [C: 031] "no changes to app delegate, so OK there. don't have time to review core data stuff now, but don't consider my review blocking." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199299 (owner: 10Fjalapeno) [22:49:43] MaxSem, do mobile targets have any effect for addModuleStyles, or does CSS get added to mobile regardless if we use addModuleStyles? [22:49:51] coreyfloyd: mhurd dr0ptp4kt bbl o/ [22:50:18] superm401, RL should honor targets [22:51:13] MaxSem, okay, thanks. [22:53:49] Maryana: You around? [22:54:38] (03PS2) 10Bmansurov: Make list items easy to read by adding margin-bottom [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199765 (https://phabricator.wikimedia.org/T93784) [22:54:43] 6Mobile-Web, 5Patch-For-Review: Lists should have greater line-height to improve readability - https://phabricator.wikimedia.org/T93784#1151388 (10bmansurov) Here you go: {F104523} Note that there is no space after the last list item. [22:59:27] (03CR) 10Jdlrobson: [C: 032] Don't show gather tutorial when showing edit tutorial overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199748 (owner: 10Robmoen) [23:00:39] whoops. stole opticians eye patch accidentally [23:00:54] rmoen: any ideas what's gong on with the editor tutorial? :/ [23:00:54] WIN [23:00:57] 6Mobile-Web, 5Patch-For-Review: Lists should have greater line-height to improve readability - https://phabricator.wikimedia.org/T93784#1151394 (10KHammerstein) @bmansurov That looks great! Would this go into beta first? [23:02:28] 6Mobile-Web, 5Patch-For-Review: Lists should have greater line-height to improve readability - https://phabricator.wikimedia.org/T93784#1151403 (10bmansurov) @KHammerstein, I did it for stable. Do you want it to go to beta first? [23:02:31] jdlrobson|away: in regards to the centering, i have a patch which addresses that. The height thing is bugging me though. I tried various things to get it working better in alpha [23:02:34] (03Merged) 10jenkins-bot: Don't show gather tutorial when showing edit tutorial overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199748 (owner: 10Robmoen) [23:03:21] brb, relocating [23:08:55] 6Mobile-Web, 5Patch-For-Review: Lists should have greater line-height to improve readability - https://phabricator.wikimedia.org/T93784#1151408 (10KHammerstein) @bmansurov Stable first is fine. Can we decrease it down to 10 px? [23:12:28] jdlrobson|away: oh what the heck. now the edit overlay is pointing at the star in beta because the watchlist loads after it is positioned [23:12:48] 6Mobile-Web, 6Collaboration-Team, 10Flow: an inline external link in square brackets without a title doesn't appear in Flow pages on mobile web - https://phabricator.wikimedia.org/T93856#1151411 (10Mattflaschen) [23:13:15] (03PS1) 10Bmansurov: Fix table borders [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) [23:14:37] 6Mobile-Web, 6Collaboration-Team, 10Flow: an inline external link in square brackets without a title doesn't appear in Flow pages on mobile web - https://phabricator.wikimedia.org/T93856#1151433 (10EBernhardson) i think the patch for T93723 might fix this as well, but i'm not sure how to get the full mobile... [23:15:19] (03PS3) 10Bmansurov: Make list items easy to read by adding margin-bottom [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199765 (https://phabricator.wikimedia.org/T93784) [23:15:53] 6Mobile-Web, 5Patch-For-Review: Lists should have greater line-height to improve readability - https://phabricator.wikimedia.org/T93784#1151435 (10bmansurov) Here is the 10px one: {F104551} [23:16:49] 6Mobile-Web, 5Patch-For-Review: Table border parameter does not display right border on mobile - https://phabricator.wikimedia.org/T92913#1151447 (10bmansurov) a:3bmansurov [23:16:55] 6Mobile-Web, 5Patch-For-Review: Page titles breaking in middle of the word on mobile beta - https://phabricator.wikimedia.org/T93826#1151449 (10bmansurov) a:3bmansurov [23:17:03] 6Mobile-Web, 5Patch-For-Review: Lists should have greater line-height to improve readability - https://phabricator.wikimedia.org/T93784#1151451 (10bmansurov) a:3bmansurov [23:19:17] 6Mobile-Web, 6Collaboration-Team: Mobile should not completely blank mediawiki.skinning.content.parsoid - https://phabricator.wikimedia.org/T93968#1151468 (10Mattflaschen) 3NEW [23:19:23] 10Gather, 3Gather Sprint Diplodocus: Add browser test for edit workflow - https://phabricator.wikimedia.org/T93949#1151477 (10Jdlrobson) a:3Jdlrobson [23:19:46] 6Mobile-Web, 6Collaboration-Team: Mobile should not completely blank mediawiki.skinning.content.parsoid - https://phabricator.wikimedia.org/T93968#1151468 (10Mattflaschen) [23:21:07] 6Mobile-Web, 5Patch-For-Review: Lists should have greater line-height to improve readability - https://phabricator.wikimedia.org/T93784#1151487 (10KHammerstein) @bmansurov That looks great. Thank you! [23:23:05] (03PS1) 10Yurik: Implemented length limitation for label & desc [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199784 (https://phabricator.wikimedia.org/T92779) [23:23:14] rmoen, ^ [23:23:22] jdlrobson, ^ [23:23:43] 6Mobile-Web, 6Collaboration-Team, 10Flow: an inline external link in square brackets without a title doesn't appear in Flow pages on mobile web - https://phabricator.wikimedia.org/T93856#1151513 (10Mattflaschen) >>! In T93856#1151433, @EBernhardson wrote: > i think the patch for T93723 might fix this as well... [23:25:03] (03PS13) 10MaxSem: Claim aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 [23:29:02] (03CR) 10Dr0ptp4kt: [V: 04-1] "Recents and Saved pages don't migrate such that the user can see them. Sometimes tapping on Recents causes the app to crash." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199299 (owner: 10Fjalapeno) [23:29:22] (03PS1) 10Legoktm: Add "composer test" command to run phpcs and make it pass [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/199788 (https://phabricator.wikimedia.org/T90943) [23:29:58] 6Mobile-Web, 10WikiGrok, 10Wikidata.org: Create FAQ page for WikiGrok on wikidata.org - https://phabricator.wikimedia.org/T93972#1151539 (10kaldari) 3NEW a:3Moushira [23:30:02] (03CR) 10Dr0ptp4kt: "To add more context, the tip of master does successful migrations." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199299 (owner: 10Fjalapeno) [23:30:26] dr0ptp4kt: do you have a crash log? [23:30:54] coreyfloyd: the crash occurred once, and now i can't make it happen again. [23:31:06] coreyfloyd: will capture that if i come across it again, though [23:31:07] dr0ptp4kt: also this sounds suspicously like this: https://gerrit.wikimedia.org/r/#/c/199536/ [23:31:40] dr0ptp4kt: please test my patch for migration errors AFTER we merge that in - since we know there is a crash bug [23:31:44] coreyfloyd: i wonder if the answer is to merge that, then rebase yours on top of it. what do you think mhurd and coreyfloyd ? [23:31:54] dr0ptp4kt: yep [23:33:26] coreyfloyd: i’m getting a crash with https://gerrit.wikimedia.org/r/#/c/199536/ - trying to track it down… [23:33:36] coreyfloyd: i'm going to hold off on merge of that until mhurd is done testing with it. BUT, i will do a manual rebase locally and see if migration works any better. [23:34:10] mhurd: ditto what i just said to adam [23:34:20] mhurd: lets get the crash fixed merged first [23:34:27] then we can see if that is the cause [23:35:09] coreyfloyd: i may be confused, but isn’t https://gerrit.wikimedia.org/r/#/c/199536/ the crash fix you’re talking about? that patch crashes for me [23:36:01] mhurd: oh yeah - thats different my bad - you have a stack trace? [23:36:43] coreyfloyd: getting… [23:38:04] * coreyfloyd 'starts to sweat' [23:44:47] (03PS1) 10Jdlrobson: QA: Browser test for edit workflow [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199794 [23:45:19] coreyfloyd, after rebase: frowny heart face on saved pages and no migrated recent pages (besides the current one, which is a freebie) :( ...no crash surfaced in this one trial [23:45:52] dr0ptp4kt: can you send me your documents directory? [23:46:01] dr0ptp4kt: so I can test your data [23:47:25] (03PS1) 10Robmoen: In beta, watchstar loads late and is edit tut is positioned incorrectly [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199795 [23:48:00] 6Mobile-Web: Multiple column layouts should be ignored on mobile - https://phabricator.wikimedia.org/T93786#1151677 (10bmansurov) Single column layout for both tablet and mobile? Doesn't tablet landscape have enough space to display multi-column layout? [23:48:34] 3Gather Sprint Diplodocus, 6Mobile-Web, 5Patch-For-Review: EditorTutorial false arrow position - https://phabricator.wikimedia.org/T91047#1151683 (10rmoen) Also related patch https://gerrit.wikimedia.org/r/#/c/199747/ for centering the arrow on the element. [23:48:37] 10Gather, 3Gather Sprint Diplodocus: Announce beta deployment on wikitech-l, enwp vp - https://phabricator.wikimedia.org/T93631#1151684 (10Moushira) 5Open>3Resolved [23:49:51] jdlrobson: ok so the editor tutorial bug / centering issue is resolved.. 2 patches in gerrit related to this. the top positioning is issue in alpha remains. I'm going to take off in a bit for an appointment [23:49:52] coreyfloyd: will do. on your side, try this, too: (1) remove org.wikimedia.wikipedia app from ios device. (2) install org.wikimedia.wikipedia from app store. (3) browse around, save things, etc. (4) close app and install on top of that with bundle id org.wikimedia.wikipedia [23:50:48] (03PS2) 10Jdlrobson: QA: Browser test for edit workflow [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199794 (https://phabricator.wikimedia.org/T93949) [23:50:49] dr0ptp4kt: will do - just that you have a known crasher - so I know I can repro with your documents data [23:50:52] coreyfloyd: you probably want to change the scheme to release in order to avoid asserts and such. otherwise, i think you can get by commenting out the oldschemadatamigrator thng [23:51:08] coreyfloyd: yeah, i don't know that i can reproduce the crash. but i can reproduce the data not migrating [23:51:11] * Deskana breathes deep. [23:51:19] What a day. [23:52:30] Deskana: so if your deep breathing isn't related to irc discussion, here's a recap. [23:52:30] dr0ptp4kt: OS and device? [23:52:38] Deskana: one moment, actually [23:52:46] coreyfloyd: 8.3 on a physical 5c [23:52:58] dr0ptp4kt: No, it's not. Big existential stuff. [23:53:37] Deskana: i see. or i do not. but i understand. [23:54:10] dr0ptp4kt: can you reconfirm the issue in a production OS? [23:54:30] i.e. <=8.2 [23:54:46] coreyfloyd: /me slaps brain. i meant 8.2 [23:54:56] dr0ptp4kt: lol - thanks [23:58:24] coreyfloyd: blargh, do you know a quick way to get the data from an app installed via the app store? it's easy in Devices if it's installed from Xcode, but was wondering if you have a point-n-click solution for official store apps [23:59:11] coreyfloyd: what i could do is try to go back roughly to the commit that's in the appstore. do we have that handy anywhere? i can't remember what came of that the other day [23:59:17] no - there is an app that used to do it, but not sure - easier to build from the previous version [23:59:50] https://www.irccloud.com/pastebin/MCcpBhoq [23:59:59] dr0ptp4kt: ^