[00:00:22] dr0ptp4kt: are we commenting that out or what? never heard back from anyone for sure [00:02:38] coreyfloyd: ya not sure why thumbnail would have to “first in artifcle’s image list”… [00:02:53] dr0ptp4kt: no need to test the missing data issue on device, you can repro in the sim. Looks like when it was rebased, it ddin't quite get stitched back together right…looking now [00:02:55] coreyfloyd: for the sake of not being annoyed when pushing to one's device from xcode in debug mode it seems okay to me to comment it out. mhurd, that okay with you? [00:03:33] coreyfloyd: that's a simpler explanation :) [00:03:39] coreyfloyd: for the data migration [00:04:16] coreyfloyd: of course when i rebased on top of the don't crash patch i had to fix a one line merge conflict, but that was no biggie. if the gerrit rebase broke something that's gross [00:04:41] dr0ptp4kt: yeah - rebasing sucks… it loosk like migration isnt even happening now [00:05:02] (03PS2) 10Robmoen: Center ContentOverlay arrow alignment on element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199747 [00:05:08] 6Mobile-Web: Multiple column layouts should be ignored on mobile - https://phabricator.wikimedia.org/T93786#1151760 (10KHammerstein) @bmansurov Thanks for clarifying, just on phones. Anything larger can display multiple columns. Does that make sense? [00:05:40] interesting: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ODWmcKNQl0I/R5a1a_CEACMJ [00:06:18] chrome is going to implement pointerevents. [00:06:32] (03CR) 10Jdlrobson: Hyphenate page titles (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199761 (https://phabricator.wikimedia.org/T93826) (owner: 10Bmansurov) [00:06:35] 6Mobile-Web: Multiple column layouts should be ignored on mobile - https://phabricator.wikimedia.org/T93786#1151763 (10bmansurov) Yes, thanks. [00:07:17] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Event logging for Gather onboarding - https://phabricator.wikimedia.org/T92742#1151771 (10JKatzWMF) 5Open>3Resolved [00:09:30] coreyfloyd: i gotta get running home shortly. i'll pop back on later. if you can get these patches (https://gerrit.wikimedia.org/r/199299, https://gerrit.wikimedia.org/r/199536, https://gerrit.wikimedia.org/r/199300) in mint condition, mhurd could you take care of the +2s? i'll sync with Deskana on whether to cut the rc [00:09:39] mhurd: coreyfloyd bgerstle_afk c u online later [00:09:52] dr0ptp4kt: will do capn [00:17:11] (03PS14) 10MaxSem: Claim aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 [00:17:15] kaldari, ^ [00:22:07] (03CR) 10Kaldari: [C: 032] Claim aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 (owner: 10MaxSem) [00:27:49] (03Merged) 10jenkins-bot: Claim aggregation [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/196136 (owner: 10MaxSem) [00:30:59] (03PS1) 10Jdlrobson: Don't call api on Gather watchstar load. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199805 [00:31:14] (03PS2) 10Jdlrobson: Don't call api on Gather watchstar load. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199805 [00:34:15] mhurd: sooo… its fixed but git review is locking up on me now… [00:34:32] mhurd: going to restart… bb in a few [00:34:41] coreyfloyd: k [00:35:18] (03PS3) 10Jdlrobson: Don't call api on Gather watchstar load. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199805 [00:37:45] (03PS5) 10Fjalapeno: Add text progress to migration Move migration to background thread / context Hold reference to schema convertor [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199299 [00:37:55] mhurd: ^ [00:38:05] coreyfloyd: cool! [00:38:14] coreyfloyd: will checkit [00:38:32] mhurd: should be good to go now, will be floating around if anything else is needed [00:38:40] coreyfloyd: cool thanks! [00:38:41] 10Gather, 3Gather Sprint Diplodocus: Blue tutorial indicator positioned incorrectly in Chrome when star is green - https://phabricator.wikimedia.org/T93987#1151840 (10Jdlrobson) 3NEW [00:39:02] http://stream1.gifsoup.com/view2/3225337/staypuft-o.gif [00:39:30] 10Gather, 3Gather Sprint Diplodocus: Blue tutorial indicator positioned incorrectly in Chrome when star is green - https://phabricator.wikimedia.org/T93987#1151848 (10Jdlrobson) I would suggest adding the transformation in javascript... [00:40:08] (03CR) 10Jdlrobson: [C: 032] "Rob turns out my issue was chrome specific when the star is green.. see... https://phabricator.wikimedia.org/T93987" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199747 (owner: 10Robmoen) [00:40:15] (03PS4) 10MaxSem: WIP: submission [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 [00:40:21] 3Gather Sprint Diplodocus, 6Mobile-Web, 5Patch-For-Review: EditorTutorial false arrow position - https://phabricator.wikimedia.org/T91047#1151852 (10Jdlrobson) @rmoen turns out my issue was chrome specific when the star is green.. see... https://phabricator.wikimedia.org/T93987 This works but please see my... [00:41:28] (03CR) 10jenkins-bot: [V: 04-1] WIP: submission [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 (owner: 10MaxSem) [00:42:23] (03Merged) 10jenkins-bot: Center ContentOverlay arrow alignment on element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199747 (owner: 10Robmoen) [00:46:10] 10Gather, 6Mobile-Web: Mobile site freezes up when resizing window on Gather-enabled pages - https://phabricator.wikimedia.org/T93988#1151863 (10kaldari) 3NEW [00:46:57] 10Gather, 6Mobile-Web: Mobile site freezes up when resizing window on Gather-enabled pages - https://phabricator.wikimedia.org/T93988#1151876 (10MaxSem) p:5Triage>3Unbreak! [00:47:50] 10Gather, 3Gather Sprint Diplodocus: no event fires when user clicks watchstar (at least while logged out) - https://phabricator.wikimedia.org/T93989#1151884 (10JKatzWMF) 3NEW [00:49:13] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Event logging for hamburger "collections" link - https://phabricator.wikimedia.org/T92855#1151892 (10JKatzWMF) 5Open>3Resolved [00:49:49] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Only call API dynamically except for special:gather - https://phabricator.wikimedia.org/T92711#1151901 (10JKatzWMF) @jdlrobson - not my place to sign off on this. [00:55:00] 10Gather, 6Mobile-Web: Mobile site freezes up when resizing window on Gather-enabled pages - https://phabricator.wikimedia.org/T93988#1151921 (10Jdlrobson) a:3Jdlrobson You can replicate this without Gather http://localhost:8888/w/index.php?title=Headings&article_action=signup-edit&mobileaction=stable so th... [00:55:08] 3Gather Sprint Diplodocus, 6Mobile-Web: Mobile site freezes up when resizing window on Gather-enabled pages - https://phabricator.wikimedia.org/T93988#1151923 (10Jdlrobson) [00:56:21] 10Gather, 6Mobile-Web: Gather intro tutorial should probably not be shown on MediaWiki namespace pages - https://phabricator.wikimedia.org/T93990#1151924 (10kaldari) 3NEW [01:08:23] (03PS1) 10Mhurd: Fix for crash when thumb fetcher had error. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199810 [01:10:18] 3Gather Sprint Diplodocus, 6Mobile-Web: Mobile site freezes up when anything bound to resize event (add debouncing) - https://phabricator.wikimedia.org/T93988#1151952 (10Jdlrobson) [01:10:27] 3Gather Sprint Diplodocus, 6Mobile-Web: Mobile site freezes up when anything bound to resize event (add debouncing) - https://phabricator.wikimedia.org/T93988#1151863 (10Jdlrobson) Got it. As suspected nothing to do with Gather. [01:10:42] (03PS2) 10Mhurd: Fix for crash when thumb fetcher had error. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199810 [01:11:36] (03PS1) 10Jdlrobson: Debounce resize events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199811 (https://phabricator.wikimedia.org/T93988) [01:11:38] (03PS1) 10Jdlrobson: Fixes to the page action tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199812 (https://phabricator.wikimedia.org/T91047) [01:12:28] (03PS4) 10Mhurd: Crash after migration - this value is supposed to be an array. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199536 (owner: 10Fjalapeno) [01:12:47] (03PS6) 10Mhurd: Add text progress to migration Move migration to background thread / context Hold reference to schema convertor [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199299 (owner: 10Fjalapeno) [01:13:41] coreyfloyd: look like this needs to be rebased: https://gerrit.wikimedia.org/r/#/c/199300/ [01:18:25] (03PS1) 10Jdlrobson: Make collections overlay less glitchy [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199813 (https://phabricator.wikimedia.org/T93948) [01:18:57] (03CR) 10Mhurd: "Caused crash when migrating "John Tyler" article from old data store." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199810 (owner: 10Mhurd) [01:20:30] mhurd: http://www.quickmeme.com/img/7e/7ec3f9aad4d1fa85ccbbc7e417a481b35defcb2fd9889b4b076d7bcf48591d50.jpg [01:20:52] coreyfloyd: lol i know i tried :) [01:21:09] mhurd: gimme a minute [01:21:15] coreyfloyd: no rush [01:21:27] mhurd: maybe not for you [01:21:36] i ran out of midnight oil [01:21:53] 3Gather Sprint Diplodocus, 5Patch-For-Review: Scrolling glitch - https://phabricator.wikimedia.org/T93948#1151972 (10Jdlrobson) a:3Jdlrobson [01:22:05] coreyfloyd: oh, yeah, tomorrow morning’s fine. i should go home anyway :) [01:22:43] (03CR) 10Jdlrobson: [C: 04-1] "Something much more sinister is going on - the watchstar is firing an unnecessary API request! eek! we shouldn't do that!" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199795 (owner: 10Robmoen) [01:23:16] (03PS4) 10Fjalapeno: Add progress line to data migration [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199300 [01:23:26] mhurd: ^ [01:23:31] (03CR) 10Mhurd: "Rather, this fixes the crash I first found when migrating the "John Tyler" article from ye olde data store." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199810 (owner: 10Mhurd) [01:23:40] coreyfloyd: cool thanks! [01:24:28] coreyfloyd: hehe now relax. we can pick this up in the morning [01:25:09] mhurd: naaa, ill just pick fights on the mailing list on my iPad while i watch Archer on the couch. [01:25:18] lol [01:25:47] coreyfloyd: best line of the day [01:25:57] :) [01:27:17] mhurd: https://www.youtube.com/watch?v=EIzei3vAqRY [01:29:06] coreyfloyd: hahaha [01:39:49] coreyfloyd: so i think the crash i was seeing earlier when i used your patch ( https://gerrit.wikimedia.org/r/#/c/199299 ) was caused by something unrelated to your patch. i tracked down the issue and posted a fix here: https://gerrit.wikimedia.org/r/#/c/199810/ [01:45:51] (03CR) 10Mhurd: [C: 031] "Looks like it's working." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199299 (owner: 10Fjalapeno) [02:26:04] 10Wikipedia-App-Android-App: Add forward button - https://phabricator.wikimedia.org/T93992#1152041 (10bearND) 3NEW [02:29:00] (03PS5) 10Mhurd: Add progress line to data migration [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199300 (owner: 10Fjalapeno) [02:29:14] (03PS6) 10Mhurd: Add progress line to data migration [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199300 (owner: 10Fjalapeno) [02:35:20] (03CR) 10Mhurd: "Corey! Apologies if I messed this up, but I appending with patch set 5 to make the Xib work in landscape - the constraints were a bit off." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199300 (owner: 10Fjalapeno) [02:42:28] (03CR) 10Mhurd: [C: 031] Add progress line to data migration [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199300 (owner: 10Fjalapeno) [02:45:08] 10Wikipedia-App-Android-App: Add forward button - https://phabricator.wikimedia.org/T93992#1152063 (10Krenair) This feels like a duplicate, though I can't find anything else. [04:03:02] (03CR) 10Dr0ptp4kt: [C: 032] Add text progress to migration Move migration to background thread / context Hold reference to schema convertor [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199299 (owner: 10Fjalapeno) [04:26:43] (03CR) 10Dr0ptp4kt: [C: 032] "Seems to be working." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199300 (owner: 10Fjalapeno) [04:26:59] (03CR) 10Dr0ptp4kt: [V: 032] "Seems to be working." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199300 (owner: 10Fjalapeno) [04:30:05] (03CR) 10Dr0ptp4kt: "@Fjalapeno, did you come to a resolution on this patch with @mhurd?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199536 (owner: 10Fjalapeno) [04:31:53] (03CR) 10Dr0ptp4kt: "@Fjalapeno, @bgerstle pending your +1s I'll get this merged in." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199810 (owner: 10Mhurd) [04:33:09] (03CR) 10Fjalapeno: "@Dr0ptp4kt - From Monte on IRC:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199536 (owner: 10Fjalapeno) [04:33:34] dr0ptp4kt: ^ [04:33:39] coreyfloyd: word [04:38:49] (03PS5) 10Dr0ptp4kt: Crash after migration - this value is supposed to be an array. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199536 (owner: 10Fjalapeno) [04:54:06] (03CR) 10Dr0ptp4kt: [C: 032] "As the four of us discussed, the correct edit status needs to be captured to keep Saved pages from always having the lock pencil on them, " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199536 (owner: 10Fjalapeno) [04:54:58] (03PS3) 10Dr0ptp4kt: Fix for crash when thumb fetcher had error. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199810 (owner: 10Mhurd) [05:20:48] (03CR) 10Florianschmidtwelzow: [C: 031] "Haven't tested, but code looks good." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199794 (https://phabricator.wikimedia.org/T93949) (owner: 10Jdlrobson) [05:24:36] (03CR) 10Florianschmidtwelzow: [C: 031] Don't call api on Gather watchstar load. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199805 (owner: 10Jdlrobson) [05:27:20] 10Wikipedia-App-iOS-App: Tap on result after microphone based search crashes app if mic panel not dismissed first - https://phabricator.wikimedia.org/T94003#1152255 (10dr0ptp4kt) 3NEW [05:28:20] 10Wikipedia-App-iOS-App: Tap on result after microphone based search crashes app if mic panel not dismissed first - https://phabricator.wikimedia.org/T94003#1152263 (10dr0ptp4kt) p:5Triage>3High [08:21:15] 6Mobile-Web, 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: Hover styles differ between MediaWiki UI buttons and OOjs UI buttons - https://phabricator.wikimedia.org/T92566#1152426 (10Prtksxna) [08:22:07] 6Mobile-Web, 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: Hover styles differ between MediaWiki UI buttons and OOjs UI buttons - https://phabricator.wikimedia.org/T92566#1114885 (10Prtksxna) >>! In T92566#1150009, @Nirzar wrote: > @kaldari I don't think the screenshots attached in task descript... [10:29:13] good morning! [10:49:50] (03CR) 10Jhernandez: [C: 032] "OMG there is a 3rd party library! WOHOO \(סּںסּَ` )/ۜ" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199811 (https://phabricator.wikimedia.org/T93988) (owner: 10Jdlrobson) [10:51:07] loving the ascii faces ٩(^‿^)۶ [10:51:56] (03Merged) 10jenkins-bot: Debounce resize events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199811 (https://phabricator.wikimedia.org/T93988) (owner: 10Jdlrobson) [11:36:40] (03CR) 10Jhernandez: [C: 032] Fixes to the page action tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199812 (https://phabricator.wikimedia.org/T91047) (owner: 10Jdlrobson) [11:37:28] 3Gather Sprint Diplodocus, 6Mobile-Web, 5Patch-For-Review: EditorTutorial false arrow position - https://phabricator.wikimedia.org/T91047#1152668 (10Jhernandez) Seems to work much better than before. Moving to signoff [11:38:30] (03Merged) 10jenkins-bot: Fixes to the page action tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199812 (https://phabricator.wikimedia.org/T91047) (owner: 10Jdlrobson) [11:42:02] (03CR) 10Jhernandez: [C: 032] "Works fine. Please jdlrobson open task for fixing the watchstar inheritance FIXME for the backlog" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199805 (owner: 10Jdlrobson) [11:43:53] (03Merged) 10jenkins-bot: Don't call api on Gather watchstar load. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199805 (owner: 10Jdlrobson) [11:45:22] (03CR) 10Jhernandez: [C: 032] "i don't like classing the html, but it really is the only way to disable scrolling..." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199813 (https://phabricator.wikimedia.org/T93948) (owner: 10Jdlrobson) [11:47:07] (03Merged) 10jenkins-bot: Make collections overlay less glitchy [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199813 (https://phabricator.wikimedia.org/T93948) (owner: 10Jdlrobson) [12:08:12] 6Mobile-Web, 7Browser-Tests: Spoof the physical geolocation on QA tests - https://phabricator.wikimedia.org/T60720#1152723 (10zeljkofilipin) [12:09:15] 6Mobile-Web, 10Echo, 10Flow, 7Browser-Tests: Move user agent assignment to Ruby gem - https://phabricator.wikimedia.org/T73531#1152726 (10zeljkofilipin) [12:10:12] 6Mobile-Web, 7Browser-Tests: update Mobile tests to run against local envs as well as beta - https://phabricator.wikimedia.org/T56349#1152729 (10zeljkofilipin) [12:10:39] 6Mobile-Web, 7Browser-Tests: refactor "upload file" step to mediawiki_selenium gem - https://phabricator.wikimedia.org/T64888#1152730 (10zeljkofilipin) [12:11:13] 6Mobile-Web, 7Browser-Tests: Figure how to get WebDriver to spoof browser geolocation preferences - https://phabricator.wikimedia.org/T59333#1152731 (10zeljkofilipin) [12:14:17] 6Mobile-Web, 10Echo, 10Flow, 6Release-Engineering, 7Browser-Tests: Move user_agent string manipulation to the Ruby gem - https://phabricator.wikimedia.org/T678#1152739 (10zeljkofilipin) [12:39:57] does Wikipedia Zero allow editing? [12:40:09] it doesnt seem to say anything on any page that Ive found [13:46:00] 10Wikipedia-App-Android-App: Added § symbol to 'See more' in the Image Gallery - https://phabricator.wikimedia.org/T93682#1152926 (10Aklapper) [14:12:19] coreyfloyd: i just hit a weird exception breakpoint after migration. was that something you fixed? [14:18:31] bgerstle: is it what monte submitted a patch for? [14:18:40] what patch? [14:20:51] bgerstle: https://gerrit.wikimedia.org/r/#/c/199810/ [14:21:00] oh [14:21:05] yeah i'm looking at that now [14:21:10] the crash i saw was in core data's save though [14:21:18] sorry wasn't a crash [14:21:28] i just hit a breakpoint in the call to save the master context for some reason [14:21:38] and the only ones i had active were "all exceptions" [14:21:48] didn't crash the app though, so i'm not sure what happened [14:21:57] i just remember you mentioning a crash so i wanted to make sure it wasn't a known issue [14:22:07] i'll look into it more and post back if there's a problem [14:22:45] (03CR) 10Bgerstle: [C: 04-1] "question about when we're checking the URL. other code is checking nil/empty before invoking the fetcher, so i suggest we do that instead " (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199810 (owner: 10Mhurd) [14:36:24] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS, 5Patch-For-Review: Description text is not normalized in galleries. - https://phabricator.wikimedia.org/T93662#1153034 (10BGerstle-WMF) [14:40:39] (03PS11) 10Yurik: lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 [14:43:48] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: Improving the Gallery UX - https://phabricator.wikimedia.org/T91329#1153059 (10BGerstle-WMF) @Deskana @vibhabamba those features sound great! I have a few more: * As a user, I can navigate directly from an image in the gallery to its corresponding section... [14:45:39] 10Wikipedia-App-iOS-App, 7Documentation: Make iOS project setup pain free for external contributors - https://phabricator.wikimedia.org/T93249#1153068 (10BGerstle-WMF) [14:46:14] bgerstle: core data frequently throws internal exceptions [14:46:34] 10Wikipedia-App-iOS-App, 7Documentation: Make iOS project setup pain free for external contributors - https://phabricator.wikimedia.org/T93249#1133022 (10BGerstle-WMF) I was thinking we could commit the "Pods" folder, which would remove CocoaPods as a build dependency. Very easy to do, @Fjalapeno you have any... [14:46:42] coreyfloyd: ah, right [14:47:29] bgerstle: in fact I have an exception break point that only breaks on non-internal core data exceptions. [14:47:40] nice [14:51:32] bgerstle: symbol:objc_exception_throw condition:(BOOL)(! (BOOL)[[(NSException *)$eax className] hasPrefix:@”_NSCoreData”]) action:po *(id *)($esp + 4) [14:51:49] ... [14:51:56] where in the world did you find that? [14:52:02] also, gist please [14:53:31] 10Wikipedia-App-iOS-App, 7Documentation: Make iOS project setup pain free for external contributors - https://phabricator.wikimedia.org/T93249#1153108 (10Fjalapeno) no sir! i also think this is a good idea also because we can put our dependencies under source control so we can always build, even if cocoapods... [15:10:59] 10Gather, 3Gather Sprint Diplodocus: no event fires when user clicks watchstar (at least while logged out) - https://phabricator.wikimedia.org/T93989#1153180 (10Jdlrobson) MM. Not sure if that was intentional or not. All anonymous clicks would be a lot of EventLogging traffic. What information would this give... [15:12:22] (03CR) 10Jdlrobson: [C: 032] Re-add clear:both to beta page-secondary-actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199516 (https://phabricator.wikimedia.org/T88499) (owner: 10Florianschmidtwelzow) [15:14:19] (03Merged) 10jenkins-bot: Re-add clear:both to beta page-secondary-actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199516 (https://phabricator.wikimedia.org/T88499) (owner: 10Florianschmidtwelzow) [15:14:58] 10Wikipedia-App-iOS-App: Load first section before loading remaining sections - https://phabricator.wikimedia.org/T92031#1153192 (10BGerstle-WMF) Sorry, I might be missing context on this, but do we have any metrics to show the predicted performance improvement? Just like we did with native stuff, can we come u... [15:16:28] (03PS1) 10Amire80: Remove unnecessary quotes around user names [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199916 [15:16:31] (03CR) 10Jdlrobson: [C: 04-1] "mobile.notifications needs to be merged to" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199640 (owner: 10Florianschmidtwelzow) [15:16:47] (03CR) 10Jdlrobson: "*mobile.notifications needs to be /moved/ too" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199640 (owner: 10Florianschmidtwelzow) [15:17:18] 10Gather, 3Gather Sprint Diplodocus: no event fires when user clicks watchstar (at least while logged out) - https://phabricator.wikimedia.org/T93989#1153205 (10JKatzWMF) Not desperately need, but its pretty important as the watchlist star is the primary driver of signups on mobile. It used to be that for ever... [15:17:34] (03Abandoned) 10Jdlrobson: WIP: new extension registration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183906 (https://phabricator.wikimedia.org/T88057) (owner: 10MaxSem) [15:18:31] 10MobileFrontend-Feature-requests: Infobox editor should be inline - https://phabricator.wikimedia.org/T94034#1153207 (10Jdlrobson) 3NEW [15:18:43] (03PS5) 10Jdlrobson: WIP: Add inline editing to Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185823 (https://phabricator.wikimedia.org/T94034) (owner: 10Jhernandez) [15:18:51] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add inline editing to Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185823 (https://phabricator.wikimedia.org/T94034) (owner: 10Jhernandez) [15:18:53] (03Abandoned) 10Jdlrobson: WIP: Add inline editing to Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185823 (https://phabricator.wikimedia.org/T94034) (owner: 10Jhernandez) [15:19:41] (03CR) 10Jdlrobson: "Florian do you want to abandon this and talk about this at the Lyon hackathon. I have a plan that I think will make everyone happy. :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190670 (https://phabricator.wikimedia.org/T88270) (owner: 10Florianschmidtwelzow) [15:21:12] (03CR) 10Jdlrobson: [C: 04-1] Make list items easy to read by adding margin-bottom (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199765 (https://phabricator.wikimedia.org/T93784) (owner: 10Bmansurov) [15:23:47] 6Mobile-Web, 7Mobile: MobileFrontend doesn't do URL updating for redirects - https://phabricator.wikimedia.org/T93262#1153257 (10Jdlrobson) [15:26:10] 10MobileFrontend-Feature-requests, 10Vector: Switch to MobileFrontend when viewport is narrower than 694px - https://phabricator.wikimedia.org/T92894#1153262 (10Jdlrobson) We use varnish to do redirects and Varnish only knows about user agent so this is not possible with current technology stack. I see bbc new... [15:27:11] 10MobileFrontend-Feature-requests, 10Wikidata, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1153267 (10Jdlrobson) If anyone takes on the microtask associated with that and completes it I have plenty more to add and it would certainl... [15:28:26] 10MobileFrontend-Feature-requests, 10Wikidata, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1153279 (10Jdlrobson) (microtask being T93127) [15:28:52] 6Mobile-Web: Mobile Beta completely blocks TOC on talk pages - https://phabricator.wikimedia.org/T93551#1153285 (10Jdlrobson) [15:30:13] 10Wikipedia-App-iOS-App: [EPIC] Data Layer Improvements - https://phabricator.wikimedia.org/T94037#1153291 (10BGerstle-WMF) 3NEW [15:30:51] 10Wikipedia-App-iOS-App: [EPIC] Data Layer Improvements - https://phabricator.wikimedia.org/T94037#1153311 (10BGerstle-WMF) [15:32:37] 10Wikipedia-App-iOS-App, 7Documentation: [EPIC] Make iOS project setup pain free for external contributors - https://phabricator.wikimedia.org/T93249#1153319 (10BGerstle-WMF) [15:39:48] 10Wikipedia-App-iOS-App: Commit "Pods" folder to git - https://phabricator.wikimedia.org/T94039#1153333 (10BGerstle-WMF) 3NEW [15:40:33] does anyone know if there's a way to refer to all of a task's subtasks in Phab/ [15:40:46] (03CR) 10Jdlrobson: [C: 04-1] "This doesn't really address the bug it links to. This still feels suboptimal since there is still a flash of unstyled content whilst the i" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [15:41:26] (03PS3) 10Jdlrobson: Re-start versioning the extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) (owner: 10Bmansurov) [15:41:42] bgerstle: coreyfloyd Deskana|Away this in-flight wifi i paid for turns out to have a rather poor connection. so much so it's taking about 2-3 minutes to navigate from one email to the next. so my standup status via irc! - did code reviews. i'm waiting on +1s (bgerstle, coreyfloyd) before i +2 https://gerrit.wikimedia.org/r/199810 and proceed to cut testflight builds. if you guys determine with monte's in non-blocking for cutting a testfl [15:41:43] release, lemme know. [15:42:47] 10Wikipedia-App-iOS-App, 7Documentation: [EPIC] Make iOS project setup pain free for external contributors - https://phabricator.wikimedia.org/T93249#1153346 (10BGerstle-WMF) [15:42:57] bgerstle: coreyfloyd Deskana|Away i'm going to close my laptop for now, and try reconnecting later. doubt audio-only hangouts for the q4 planning will work on the plane, but maybe people will be done watching internet videos at that time so who knows [15:43:13] (03CR) 10Jdlrobson: [C: 04-1] Re-start versioning the extension (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) (owner: 10Bmansurov) [15:43:18] bgerstle: coreyfloyd Deskana|Away i'll check email and gerrit for status updates on change 199810 when i reconnect [15:43:22] dr0ptp4kt: ok - good luck [15:43:41] coreyfloyd: thank you, i'm going to need it LOL [15:43:51] dr0ptp4kt: have a safe flight [15:44:05] bgerstle: thank you [15:44:22] who's the phab expert here? [15:45:05] 10Wikipedia-App-iOS-App, 7Documentation: Fix dependency version checks in iOS Makefile - https://phabricator.wikimedia.org/T94040#1153350 (10BGerstle-WMF) 3NEW [15:45:27] 10Wikipedia-App-iOS-App, 7Documentation: [EPIC] Make iOS project setup pain free for external contributors - https://phabricator.wikimedia.org/T93249#1153356 (10BGerstle-WMF) [15:46:13] 10Wikipedia-App-iOS-App: Fix dependency version checks in iOS Makefile - https://phabricator.wikimedia.org/T93077#1153359 (10BGerstle-WMF) [15:46:13] 10Wikipedia-App-iOS-App, 7Documentation: Fix dependency version checks in iOS Makefile - https://phabricator.wikimedia.org/T94040#1153350 (10BGerstle-WMF) [15:46:48] 10Wikipedia-App-iOS-App, 7Documentation: [EPIC] Make iOS project setup pain free for external contributors - https://phabricator.wikimedia.org/T93249#1133022 (10BGerstle-WMF) [15:46:59] omg wikibugs plz [15:47:15] wikibugs http://i.imgur.com/NkeIb.jpg [15:47:15] (03CR) 10Jdlrobson: [C: 04-1] Fix table borders (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) (owner: 10Bmansurov) [15:47:43] (03PS2) 10Jdlrobson: i18n: Remove unnecessary quotes around user names [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199916 (owner: 10Amire80) [15:47:49] (03CR) 10Jdlrobson: [C: 032] i18n: Remove unnecessary quotes around user names [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199916 (owner: 10Amire80) [15:48:17] (03CR) 10Florianschmidtwelzow: "Hm? Not really, it doesn't depend on echo (if you just look at the dependencies tree). That it only works with Echo is another topic and s" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199640 (owner: 10Florianschmidtwelzow) [15:48:55] (03Merged) 10jenkins-bot: i18n: Remove unnecessary quotes around user names [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199916 (owner: 10Amire80) [15:49:06] (03CR) 10Fjalapeno: [C: 031] "repond to brians comments" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199810 (owner: 10Mhurd) [15:49:33] bgerstle: an average if "0" ^ [15:50:21] (03CR) 10Jdlrobson: [C: 031] "joakino and phuedx please take a look. I don't really like the fact hyphen isn't available anywhere but I can't find any reasons not too." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199761 (https://phabricator.wikimedia.org/T93826) (owner: 10Bmansurov) [15:51:58] (03CR) 10Bgerstle: Fix for crash when thumb fetcher had error. (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199810 (owner: 10Mhurd) [15:52:14] (03CR) 10Jdlrobson: [C: 032] "This is so frigging cool. :D:D:D:D:D:D:D:D" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195995 (https://phabricator.wikimedia.org/T91796) (owner: 10Florianschmidtwelzow) [15:52:33] (03CR) 10Fjalapeno: "Can we address or abandon? been open way too long." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190960 (owner: 10Rahdev) [15:54:06] (03Merged) 10jenkins-bot: Add CodeMirror for alpha users to better understand wikitext [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195995 (https://phabricator.wikimedia.org/T91796) (owner: 10Florianschmidtwelzow) [15:55:50] (03Abandoned) 10Florianschmidtwelzow: Change default watchlist from a-z to feed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190670 (https://phabricator.wikimedia.org/T88270) (owner: 10Florianschmidtwelzow) [15:55:52] (03CR) 10Jdlrobson: [C: 031] Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [15:56:02] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: [EPIC] Provision Mac mini as iOS build server - https://phabricator.wikimedia.org/T91786#1153387 (10BGerstle-WMF) [15:56:24] (03CR) 10Jdlrobson: [C: 031] "Haven't tested but looks good." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198763 (owner: 10Florianschmidtwelzow) [15:57:45] 10Gather, 3Gather Sprint Diplodocus: Gather intro tutorial should probably not be shown on MediaWiki namespace pages - https://phabricator.wikimedia.org/T93990#1153392 (10Jdlrobson) [15:57:47] (03CR) 10Fjalapeno: "bgerstle…" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199810 (owner: 10Mhurd) [15:58:23] 10Wikipedia-App-iOS-App: Tap on result after microphone based search crashes app if mic panel not dismissed first - https://phabricator.wikimedia.org/T94003#1153394 (10BGerstle-WMF) [15:58:43] 10Wikipedia-App-iOS-App: Tap on result after microphone based search crashes app if mic panel not dismissed first - https://phabricator.wikimedia.org/T94003#1152255 (10BGerstle-WMF) [16:00:26] (03CR) 10Bgerstle: "http://www.quickmeme.com/img/d6/d690cbb35e4b2d522bdda7e5c8322f0f1edbf0ddb778bd3f273b6dfe0743824a.jpg" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199810 (owner: 10Mhurd) [16:00:28] (03CR) 10Fjalapeno: "bgerstle…" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199810 (owner: 10Mhurd) [16:01:00] bgerstle: lol [16:01:12] damn you, gerrit [16:01:25] bgerstle: back in a bit… need to take the dog out [16:01:28] k [16:03:33] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: [EPIC] Provision Mac mini as iOS build server - https://phabricator.wikimedia.org/T91786#1153406 (10BGerstle-WMF) [16:03:34] 10Wikipedia-App-iOS-App: Document app build and release process - https://phabricator.wikimedia.org/T91096#1153407 (10BGerstle-WMF) [16:39:35] 10Wikipedia-App-iOS-App: In-app bug reporting - https://phabricator.wikimedia.org/T94043#1153500 (10BGerstle-WMF) 3NEW [16:41:54] 10MobileFrontend-Feature-requests, 10Wikidata, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1153514 (10Sumit) I've setup the boilerplate extension on my userspace at github, now filling in a request at https://www.mediawiki.org/wiki... [16:42:56] 10MobileFrontend-Feature-requests, 10Wikidata: Setup WikidataPageBanner extension repository on Gerrit - https://phabricator.wikimedia.org/T93127#1153515 (10Jdlrobson) a:3Sumit [16:43:35] phuedx: still on jury dooottiee? [16:44:17] hi hi [16:44:51] 10Wikipedia-App-iOS-App: Organize, filter, and store dev logs - https://phabricator.wikimedia.org/T94044#1153516 (10BGerstle-WMF) 3NEW [16:46:46] 10Wikipedia-App-iOS-App, 7Documentation: [EPIC] Make iOS project setup pain free for external contributors - https://phabricator.wikimedia.org/T93249#1153532 (10BGerstle-WMF) p:5Triage>3Low [16:47:01] 10Wikipedia-App-iOS-App: Get build server to vote on patches - https://phabricator.wikimedia.org/T93078#1153533 (10BGerstle-WMF) p:5Triage>3Normal [16:47:36] 10Wikipedia-App-iOS-App: [EPIC] Data Layer Improvements - https://phabricator.wikimedia.org/T94037#1153535 (10BGerstle-WMF) p:5Triage>3High [16:47:46] 10Wikipedia-App-iOS-App: Get build server to vote on patches - https://phabricator.wikimedia.org/T93078#1128774 (10BGerstle-WMF) p:5Normal>3High [16:48:31] 10Wikipedia-App-iOS-App: Organize, filter, and store dev logs - https://phabricator.wikimedia.org/T94044#1153538 (10BGerstle-WMF) p:5Triage>3Normal [16:48:36] 10Wikipedia-App-iOS-App: In-app bug reporting - https://phabricator.wikimedia.org/T94043#1153540 (10BGerstle-WMF) p:5Triage>3Normal [16:50:11] 10Wikipedia-App-iOS-App: Automate i18n patch acceptance and rejections - https://phabricator.wikimedia.org/T92317#1153548 (10BGerstle-WMF) p:5Triage>3Normal [16:55:57] 10Wikipedia-App-iOS-App: [EPIC] Discontinue iOS 6 support - https://phabricator.wikimedia.org/T94045#1153560 (10BGerstle-WMF) 3NEW [16:56:37] https://etherpad.wikimedia.org/p/q4planningnotes [16:56:46] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: [Spike 2hrs] Audit fetchers to enable us to sunset iOS 6 support - https://phabricator.wikimedia.org/T91789#1153573 (10BGerstle-WMF) [16:56:47] 10Wikipedia-App-iOS-App: [EPIC] Discontinue iOS 6 support - https://phabricator.wikimedia.org/T94045#1153572 (10BGerstle-WMF) [16:57:53] 10Wikipedia-App-iOS-App: Get feedback from users about iOS 6 - https://phabricator.wikimedia.org/T94046#1153579 (10BGerstle-WMF) 3NEW [16:59:53] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: [EPIC] Provision Mac mini as iOS build server - https://phabricator.wikimedia.org/T91786#1153594 (10BGerstle-WMF) [16:59:54] 10Wikipedia-App-iOS-App: [Blocked] Build and distribute beta build to external testers weekly - https://phabricator.wikimedia.org/T91791#1153593 (10BGerstle-WMF) [17:00:05] 10Wikipedia-App-iOS-App: Build and distribute beta build to external testers weekly - https://phabricator.wikimedia.org/T91791#1153595 (10BGerstle-WMF) [17:04:24] https://etherpad.wikimedia.org/p/q4planningnotes [17:06:43] phuedx: around? [17:06:50] phuedx: we're on hangout [17:07:19] (03CR) 10Jhernandez: [C: 04-1] "Compatibility is pretty bad as Jon pointed out http://caniuse.com/#search=hyphens but I don't think it is a problem to have better experie" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199761 (https://phabricator.wikimedia.org/T93826) (owner: 10Bmansurov) [17:08:40] bmansurov: i think he is on jury duty [17:08:54] joakino: ok thanks [17:09:23] 10Gather, 3Gather Sprint Diplodocus: no event fires when user clicks watchstar (at least while logged out) - https://phabricator.wikimedia.org/T93989#1153604 (10rmoen) a:3rmoen [17:09:24] 10Gather: Service API Placeholder - https://phabricator.wikimedia.org/T91011#1153607 (10Yurik) I agree that there should always be a mentioning if the backend (api) needs to change to support a given feature. That said, why is this a task? I don't think we can act on it - simply make it a rule of task creation. [17:13:46] 3Gather Sprint Diplodocus: Minimal responsive design for a collection page - https://phabricator.wikimedia.org/T94047#1153618 (10Jhernandez) 3NEW a:3Jhernandez [17:22:16] 10Gather: API: support automatic and manual images - https://phabricator.wikimedia.org/T93912#1153654 (10Yurik) [17:24:18] 10Gather, 3Gather Sprint E, 5Patch-For-Review: [placeholder] Responsive design for Special:Gather (important because shares might be desktop) - https://phabricator.wikimedia.org/T91384#1153670 (10MSyed) @Jhernandez @JKatzWMF Attaching a mock here for tablet view just to give some clarity around this. Let m... [17:26:11] (03CR) 10Yurik: lstprop=owner and a few bug fixes (039 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (owner: 10Yurik) [17:27:55] joakino, has everyone updated their databases? [17:28:04] rmoen, ^ [17:28:07] yurik: why? [17:28:14] schema change last night [17:28:25] will delete all the data and re-create everything [17:28:29] k [17:28:34] yurik: i tested and merged the patch so yes [17:28:37] yurik: in master already? [17:28:41] yes [17:28:42] yes [17:28:44] okii [17:29:01] rmoen, merging != running update.php [17:29:10] only beta auto-runs update [17:29:24] JonKatz, ^ [17:29:28] jdlrobson, ^ [17:29:39] in short - run update.php [17:29:58] and i will commit a patch that disables that - we can't go into production with a "delete table" command :) [17:31:13] kaity: is there an api at the server for that? or would the app effectively handle the logic instead of the server? [17:32:02] yurik: what's happened? [17:32:15] jdlrobson, nothing - yesterday's patch changes schema [17:32:22] so you need to apply it [17:32:23] what about it? [17:32:28] update.php [17:32:29] locally? of course. [17:32:35] yep [17:32:39] who hadn't applied it? [17:32:46] that's my question :) [17:33:02] ah :) [17:33:41] i'm on it, one sec [17:33:56] joakino, JonKatz, rmoen, jdlrobson: all, please confirm that you have ran update.php, because i want to submit a patch that will disable automatic update of the old schema [17:34:05] also, who else has gather? [17:34:34] jdlrobson: can we use this? seems that the basic functionality is everywhere http://caniuse.com/#search=columns [17:35:18] (03PS2) 10Jhernandez: WIP: Collection item cards are responsive (tablet) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194498 (https://phabricator.wikimedia.org/T91384) [17:36:39] yurik: i'm updating composer and update.php, i'll ping you when its done [17:36:51] joakino, if you ran it, its fine :) [17:37:20] yurik: done now [17:37:37] it's the one that dropped the tables, right [17:37:37] anyone else besides people above have gather installed? [17:37:41] joakino: yeh columns is fine [17:37:45] i don't think so [17:37:45] yep [17:37:46] just make sure degrades to single list [17:37:50] ok jdlrobson, yep [17:37:52] yurik: i confirm! [17:40:58] jdlrobson: JonKatz: i'm seeing that some horizontal pictures are getting styled as if they were vertical http://i.imgur.com/PepbRFe.png grrrrr [17:41:04] is that what you referred to? [17:42:26] i'm returned! [17:47:34] (03PS1) 10Yurik: Removed table autodrop if you have older schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199948 [17:47:45] 6Mobile-Web, 10Flow, 10MediaWiki-General-or-Unknown, 10UI-Standardization, 10Vector: Should be a standard way to access tablet browser width threshold - https://phabricator.wikimedia.org/T93675#1153758 (10DannyH) p:5Triage>3Low [17:47:47] jdlrobson, once everyone confirms ^^ [17:50:03] (03PS1) 10Robmoen: Log anon watchstar clicks to schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199949 [17:52:46] 10Gather, 3Gather Sprint Diplodocus: no event fires when user clicks watchstar (at least while logged out) - https://phabricator.wikimedia.org/T93989#1153777 (10rmoen) Patch in gerrit https://gerrit.wikimedia.org/r/#/c/199949/ Logging all user clicks now to watchstar. When the user is newly registered and we... [17:57:17] (03CR) 10Jdlrobson: [C: 04-1] Log anon watchstar clicks to schema (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199949 (owner: 10Robmoen) [17:57:23] (03PS2) 10Jdlrobson: Log anon watchstar clicks to schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199949 (https://phabricator.wikimedia.org/T93989) (owner: 10Robmoen) [18:01:47] yurik sorry was in a meeting. stupid question, how do I run "update.php"? [18:02:15] (03CR) 10Jdlrobson: [C: 032] Removed table autodrop if you have older schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199948 (owner: 10Yurik) [18:02:19] JonKatz, are you using vagrant? [18:02:49] yurik no don't have gather installed [18:02:52] you're good [18:07:07] 10Gather, 3Gather Sprint Diplodocus: Gather intro tutorial should probably not be shown on MediaWiki namespace pages - https://phabricator.wikimedia.org/T93990#1153807 (10Jdlrobson) a:3Jdlrobson [18:07:24] jdlrobson, go ahead with https://gerrit.wikimedia.org/r/#/c/199948/ [18:07:29] betalabs seems to be updated [18:08:06] funny, you already did [18:08:21] (03PS1) 10Jdlrobson: Only show tutorial on main namespace [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199958 (https://phabricator.wikimedia.org/T93990) [18:08:23] (03CR) 10Bmansurov: Fix table borders (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) (owner: 10Bmansurov) [18:08:30] (03PS2) 10Bmansurov: Fix wikitable table borders [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) [18:08:35] jdlrobson, rmoen, who wants to +2 my other patches? :) [18:11:20] 10Gather, 3Gather Sprint Diplodocus: collection images in list of collections should scale to match width of collection title - https://phabricator.wikimedia.org/T93953#1153827 (10JKatzWMF) @Jhernandez, @msyed here is an example where one image scales and the other does not....even with bad cropping, the adhe... [18:12:14] (03CR) 10Bmansurov: Make list items easy to read by adding margin-bottom (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199765 (https://phabricator.wikimedia.org/T93784) (owner: 10Bmansurov) [18:12:17] (03PS4) 10Bmansurov: Make list items easy to read by adding margin-bottom [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199765 (https://phabricator.wikimedia.org/T93784) [18:12:21] yurik: i think we're gonna wait till after the branch cut and only apply css/js changes after talking to MaxSem [18:13:11] jdlrobson, i don't think its a good idea - currently there is a hacky implementation of "owner" being pulled one at a time [18:13:21] joakino rmoen > https://gerrit.wikimedia.org/r/199958 [18:13:31] yurik: which patch are you talking about? [18:13:47] the length limitation patch can wait me thinks [18:13:48] jdlrobson, the big one that anomie has looked at [18:13:53] the other one mixes too many things [18:13:55] (03CR) 10jenkins-bot: [V: 04-1] Only show tutorial on main namespace [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199958 (https://phabricator.wikimedia.org/T93990) (owner: 10Jdlrobson) [18:13:58] length limitation is fine, but its easy to test [18:14:00] so i can't really grok if it's serious or not [18:14:06] (03PS3) 10Jhernandez: Collection item cards are responsive (tablet) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194498 (https://phabricator.wikimedia.org/T91384) [18:14:26] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199958 (https://phabricator.wikimedia.org/T93990) (owner: 10Jdlrobson) [18:14:32] jdlrobson, https://gerrit.wikimedia.org/r/#/c/199510/ [18:14:34] (03CR) 10Jhernandez: [C: 04-1] "Still iterating and asking for feedback on design" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194498 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [18:14:40] that's the important one [18:14:56] JonKatz: is moiz around? [18:14:57] (03CR) 10jenkins-bot: [V: 04-1] Collection item cards are responsive (tablet) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194498 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [18:15:05] its buggy, and very un-optimal at the moment [18:15:10] JonKatz: do we want the two columns in tablet portrait? [18:15:10] he's in app quarterly planning [18:15:11] yurik: if you can get anomie to merge it i'm fine [18:15:16] this is not my expertise.. [18:15:37] (03CR) 10Jdlrobson: [C: 031] "Anomie can you merge if this looks good?" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (owner: 10Yurik) [18:15:45] joakino can you show me screenshot? [18:15:54] JonKatz: looks like this more or less http://i.imgur.com/y8Nj35R.png [18:16:01] rmoen: did you see my feedback? [18:16:11] (03PS3) 10Robmoen: Log anon watchstar clicks to schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199949 [18:16:12] jdlrobson: Yes ^ [18:16:23] (03CR) 10jenkins-bot: [V: 04-1] Make list items easy to read by adding margin-bottom [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199765 (https://phabricator.wikimedia.org/T93784) (owner: 10Bmansurov) [18:16:37] (03CR) 10jenkins-bot: [V: 04-1] Log anon watchstar clicks to schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199949 (owner: 10Robmoen) [18:16:49] (03CR) 10jenkins-bot: [V: 04-1] Fix wikitable table borders [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) (owner: 10Bmansurov) [18:17:04] rmoen: sweet. testing [18:17:23] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: no event fires when user clicks watchstar (at least while logged out) - https://phabricator.wikimedia.org/T93989#1153851 (10JKatzWMF) @rmoen, thanks for asking. We do want to track that other click! It lets us know that they completed the login...--the... [18:17:30] jdlrobson: when user is anon user.getEditCount() returns null, this throws event logging error. So setting to 0 in that case.. think that is going to give us bad data ? [18:17:50] JonKatz: this is landscape http://i.imgur.com/Zb7IRwP.png [18:18:00] a bit wider and more square [18:18:01] joakino gimme 5 min and I'll get back to you [18:18:14] JonKatz: let me screenshot portrait without columns [18:18:34] brb, getting coffee [18:18:46] joakino that was what I was about to try to replicate, thanks! [18:19:06] (03CR) 10Legoktm: [C: 04-1] lstprop=owner and a few bug fixes (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (owner: 10Yurik) [18:21:35] (03PS2) 10Bmansurov: Hyphenate page titles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199761 (https://phabricator.wikimedia.org/T93826) [18:22:10] (03Merged) 10jenkins-bot: Removed table autodrop if you have older schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199948 (owner: 10Yurik) [18:22:37] joakino does it look anything like this? https://www.dropbox.com/s/e6n0qmfvsbcs4uv/Screenshot%202015-03-26%2011.19.43.png?dl=0 [18:22:54] (03CR) 10jenkins-bot: [V: 04-1] Hyphenate page titles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199761 (https://phabricator.wikimedia.org/T93826) (owner: 10Bmansurov) [18:23:09] joakino if so, I think it is a better experience that 2 columns. will double check with moiz. [18:24:00] JonKatz: similar, see http://i.imgur.com/1gIgxkg.gif no columns, and http://i.imgur.com/rQFskMD.gif columns [18:24:59] (03CR) 10Jdlrobson: [C: 04-1] "Breaks watchstar for logged in users (load.php?debug=false&lang=en&modules=ext.eventLogging|ext.eventLogging.subscriber|ext.gather.api%2C…" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199949 (owner: 10Robmoen) [18:25:03] JonKatz: joakino i think we need two columns for tablets [18:25:03] joakino it looks like moiz and I disagree. Will try to pull him out of meeting [18:25:18] (03PS4) 10Jdlrobson: Log anon watchstar clicks to schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199949 (https://phabricator.wikimedia.org/T93989) (owner: 10Robmoen) [18:25:20] moizsyed speak of the bearded devil! [18:25:32] (03PS2) 10Jdlrobson: Only show tutorial on main namespace [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199958 (https://phabricator.wikimedia.org/T93990) [18:25:37] ^ joakino [18:25:37] JonKatz: sorry in the q4 app planning meeting [18:25:49] moizsyed: we need to cut off by lunch time [18:25:52] JonKatz: whats the question, tho? [18:26:10] JonKatz: moizsyed: haha, report something around here https://phabricator.wikimedia.org/T94047 [18:26:22] moizsyed: columns on portrait ipad see http://i.imgur.com/1gIgxkg.gif no columns, and http://i.imgur.com/rQFskMD.gif columns [18:26:52] JonKatz: joakino, i vote for 2 columns [18:26:56] (03Restored) 10Legoktm: WIP: new extension registration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183906 (https://phabricator.wikimedia.org/T88057) (owner: 10MaxSem) [18:27:13] moizsyed joakino I agree the double column looks great for "list of collections.". [18:27:47] i added some mocks here: https://phabricator.wikimedia.org/T91384 [18:28:08] moizsyed joakino okay, sold [18:28:14] boom [18:29:15] moizsyed: JonKatz: so 2 columns on ipad always, we can revisit later [18:30:03] (03PS12) 10Yurik: lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 [18:30:45] (03CR) 10Bmansurov: [C: 04-1] "I agree with Jon's comment." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193657 (https://phabricator.wikimedia.org/T91178) (owner: 10Florianschmidtwelzow) [18:31:34] (03CR) 10Jforrester: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194498 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [18:31:40] (03CR) 10Jforrester: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199765 (https://phabricator.wikimedia.org/T93784) (owner: 10Bmansurov) [18:31:46] (03CR) 10Jforrester: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) (owner: 10Bmansurov) [18:31:51] (03CR) 10Jforrester: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199761 (https://phabricator.wikimedia.org/T93826) (owner: 10Bmansurov) [18:32:20] (03CR) 10Anomie: lstprop=owner and a few bug fixes (034 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (owner: 10Yurik) [18:32:26] (03CR) 10Anomie: [C: 04-1] lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (owner: 10Yurik) [18:35:52] 6Mobile-Web, 5Patch-For-Review: Convert MobileFrontend extension to use extension registration - https://phabricator.wikimedia.org/T88057#1153934 (10Jdlrobson) @legoktm different teams have different practices. The word 'abandon' is unfortunate as the patch is still available. Someone can always restore it whe... [18:37:13] joakino: that sounds good [18:37:26] it's so pretty on the ipad :D [18:37:41] 6Mobile-Web, 5Patch-For-Review: Convert MobileFrontend extension to use extension registration - https://phabricator.wikimedia.org/T88057#1153957 (10Legoktm) I've removed it from your review queue since it was distracting, and will re-add you as a reviewer once it's no longer a WIP. [18:39:23] (03PS4) 10Jhernandez: Collection item cards are responsive (tablet) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194498 (https://phabricator.wikimedia.org/T91384) [18:40:46] (03CR) 10Jhernandez: [C: 031] "This is ready for review. See http://i.imgur.com/rQFskMD.gif for how it is supposed to look on tablet." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194498 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [18:41:01] rmoen: joakino https://gerrit.wikimedia.org/r/#/c/199958/ :P [18:41:03] jdlrobson: hmm not sure why its throwing the error. I'm passing arguments to the parent method which should contain the event.. any ideas ? [18:41:22] 3Gather Sprint Diplodocus, 5Patch-For-Review: Minimal responsive design for a collection page - https://phabricator.wikimedia.org/T94047#1153970 (10Jhernandez) This is ready for review. See http://i.imgur.com/rQFskMD.gif for how it is supposed to look on tablet. Tested on chrome, firefox, and iOS8 ipad2 safari... [18:41:50] rmoen: maybe something to do with on action event? [18:42:02] (03CR) 10Jhernandez: [C: 032] Only show tutorial on main namespace [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199958 (https://phabricator.wikimedia.org/T93990) (owner: 10Jdlrobson) [18:42:30] rmoen: there is some code in init.js which looks suspect [18:42:55] jdlrobson: rmoen: tablet css is ready for review, should be quick https://phabricator.wikimedia.org/T94047 [18:42:58] actually mm that has ev too [18:43:01] joakino: yeh looking at it [18:43:07] jdlrobson: yeah [18:43:31] rmoen: take a look at Watchstar.js maybe a bug there [18:44:08] jdlrobson: will look more, arguments also being passed to onToggleStatusUser so idk currently.. [18:44:17] (03Merged) 10jenkins-bot: Only show tutorial on main namespace [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199958 (https://phabricator.wikimedia.org/T93990) (owner: 10Jdlrobson) [18:44:42] jdlrobson: wait don't merge [18:44:54] (03PS5) 10Jhernandez: Collection item cards are responsive (tablet) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194498 (https://phabricator.wikimedia.org/T91384) [18:45:06] jdlrobson: removed the text-align rules, those did nothing there [18:45:21] were from previous experiments [18:45:44] joakino: it just changes the collection page itself right? [18:45:51] it's a little weird with odd numbers, but i'm not sure how to fix that [18:45:52] yes [18:46:04] e.g. 1 item collection [18:46:07] jdlrobson: yea css columns are magic, sometimes it balances to the right [18:46:08] but it looks a lot better with more than 1 [18:46:13] oh let me see [18:46:31] happy to merge though ping me when you've removed them [18:47:00] jdlrobson: yeah with one item it looks weird [18:47:10] i don't think there's much we can do on css about that [18:47:33] jdlrobson: ps5 is uploaded and cleaned [18:52:43] 3Gather Sprint Diplodocus: Edit and delete buttons are currently broken on desktop skins - https://phabricator.wikimedia.org/T94063#1154001 (10Jdlrobson) 3NEW [18:53:38] (03PS1) 10Jdlrobson: Hide edit and delete buttons in Vector whilst they are broken [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199964 (https://phabricator.wikimedia.org/T93960) [18:53:44] ^ joakino [18:54:24] why does jenkins have to stall now :( [18:58:11] 6Mobile-Web, 5Patch-For-Review: Convert MobileFrontend extension to use extension registration - https://phabricator.wikimedia.org/T88057#1154034 (10Jdlrobson) @legoktm you make assumptions about my review queue. My review queue is every open patchset. Most of the mobile team use the same tool. I'm not sure wh... [18:58:34] (03Abandoned) 10Jdlrobson: WIP: new extension registration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183906 (https://phabricator.wikimedia.org/T88057) (owner: 10MaxSem) [18:58:40] 10Gather, 3Gather Sprint E, 5Patch-For-Review: [placeholder] Responsive design for Special:Gather (important because shares might be desktop) - https://phabricator.wikimedia.org/T91384#1154041 (10Jhernandez) @jkatzwmf @msyed In T94047 I've implemented the columns using css columns. That's the only way to ge... [18:59:46] 6Mobile-Web, 5Patch-For-Review: Convert MobileFrontend extension to use extension registration - https://phabricator.wikimedia.org/T88057#1154048 (10Jdlrobson) (I should note this is not anything personal. I want the extension.json to happen but I'm more confident it will happen this way by making it clear Max... [19:03:13] 10MobileFrontend-Feature-requests, 7Design, 5Patch-For-Review: Remove mobile editing "call to registration" CTA - https://phabricator.wikimedia.org/T87508#1154062 (10Jdlrobson) [19:03:17] jdlrobson: how are those buttons getting hidden? [19:03:36] i see a style='display:none' on the html :S [19:03:43] i don't understand the patch lol [19:03:47] css joakino :D [19:04:00] adds visible class [19:04:03] element.style { display: none; } [19:04:08] but you cant do this ^ [19:04:23] oh wait i missed a bit [19:05:45] (03Merged) 10jenkins-bot: Collection item cards are responsive (tablet) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/194498 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [19:06:29] jdlrobson: so vector adds display: none to the class, but collections.less .collection-actions.visible should override it to block, but somehow on vector the dom element .collection-actions has a inline style of display:none which overrides all css. How is that style being applied and how does that relate to the patch? [19:06:37] i mean, it works, but I want to understand why [19:06:50] (03PS2) 10Jdlrobson: Hide edit and delete buttons in Vector whilst they are broken [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199964 (https://phabricator.wikimedia.org/T93960) [19:07:03] anyway that was what i meant to do which is hopefully clearer ^ [19:07:15] it wasn't working on mobile :) [19:07:41] jdlrobson: http://i.imgur.com/tCh4o7z.png [19:07:47] oh let me look at the ps [19:09:41] jdlrobson: not working [19:10:02] jdlrobson: since we don't do jquery.show the display:none that we assign on the server overrides whatever we do on css [19:10:11] (on the server html) [19:10:44] probably removing the inline style on Collection view should be enough [19:12:25] joakino: you tried the new patch? [19:12:30] i got rid of that no? [19:13:10] i'm getting so confused :( [19:13:20] 6Mobile-Web, 5Patch-For-Review: Convert MobileFrontend extension to use extension registration - https://phabricator.wikimedia.org/T88057#1154088 (10Legoktm) >>! In T88057#1154034, @Jdlrobson wrote: > I'm not sure why the issue. If you want to revive the patch be my guest, but it has sat in the review queue fo... [19:13:59] sigh fail. [19:14:00] (03PS3) 10Jdlrobson: Hide edit and delete buttons in Vector whilst they are broken [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199964 (https://phabricator.wikimedia.org/T93960) [19:14:02] ^ joakino [19:14:13] jdlrobson: nope, see includes/views/Collection.php line 82 & 83 [19:14:21] k [19:14:35] haha yeah [19:14:51] 6Mobile-Web, 5Patch-For-Review: Convert MobileFrontend extension to use extension registration - https://phabricator.wikimedia.org/T88057#1154104 (10Jdlrobson) Okay, if you're reviving it that's different - assign yourself to the bug and feel free to restore it. [19:17:23] (03PS5) 10Robmoen: Log anon watchstar clicks to schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199949 (https://phabricator.wikimedia.org/T93989) [19:19:09] 3Gather Sprint Diplodocus: Heading spacing is off on vector - https://phabricator.wikimedia.org/T94069#1154111 (10Jhernandez) 3NEW a:3Jhernandez [19:19:33] (03PS1) 10Jhernandez: Style: Spacing issue in vector styles [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199974 (https://phabricator.wikimedia.org/T94069) [19:22:01] (03PS13) 10Yurik: lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 [19:22:53] 3Gather Sprint Diplodocus: Content spacing is too big on tablet - https://phabricator.wikimedia.org/T94070#1154130 (10Jhernandez) 3NEW a:3Jhernandez [19:23:10] 3Gather Sprint Diplodocus: Collection content spacing is too big on tablet - https://phabricator.wikimedia.org/T94070#1154139 (10Jhernandez) [19:24:11] (03CR) 10Robmoen: [C: 032] Hide edit and delete buttons in Vector whilst they are broken [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199964 (https://phabricator.wikimedia.org/T93960) (owner: 10Jdlrobson) [19:24:31] (03PS1) 10Jhernandez: Fix spacing of content on tablet [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199977 (https://phabricator.wikimedia.org/T94070) [19:24:52] 3Gather Sprint Diplodocus: Edit and delete buttons are currently broken on desktop skins - https://phabricator.wikimedia.org/T94063#1154146 (10rmoen) a:3Jdlrobson [19:25:03] 3Gather Sprint Diplodocus, 5Patch-For-Review: Collection content spacing is too big on tablet - https://phabricator.wikimedia.org/T94070#1154149 (10Jhernandez) p:5Triage>3Low [19:26:31] (03Merged) 10jenkins-bot: Hide edit and delete buttons in Vector whilst they are broken [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199964 (https://phabricator.wikimedia.org/T93960) (owner: 10Jdlrobson) [19:36:27] (03CR) 10Jdlrobson: [C: 04-1] Log anon watchstar clicks to schema (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199949 (https://phabricator.wikimedia.org/T93989) (owner: 10Robmoen) [19:42:43] 10Gather, 6Mobile-Web, 10MobileFrontend-Feature-requests, 10MediaWiki-ResourceLoader, 5Patch-For-Review: ResourceLoaderImage module css rules should be more configurable - https://phabricator.wikimedia.org/T78215#1154208 (10matmarex) [19:42:48] (03PS1) 10Jhernandez: Background size of collection images doesn't work properly. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199983 (https://phabricator.wikimedia.org/T93953) [19:45:37] (03CR) 10Bmansurov: "Thanks, @Kaldari. I'll try your suggestion once I hear back from @MaxSem. His solution seems more effective." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [19:46:26] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: collection images in list of collections should scale to match width of collection title - https://phabricator.wikimedia.org/T93953#1154260 (10Jhernandez) @jdlrobson @jkatzwmf For our use cases list-thumb-x and y wasn't cutting it since we actually have... [19:46:56] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: collection images in list of collections should scale to match width of collection title - https://phabricator.wikimedia.org/T93953#1154263 (10Jhernandez) a:3Jhernandez [19:47:22] i'm outahere [19:47:27] have a nice day [19:47:40] and review my patches, they are small style issues that drive me mad [19:56:39] i'm back online, via cellular tethering now. bgerstle: coreyfloyd Deskana|Away moizsyed bearND dbrant|food etonkovidova moushira [19:56:53] dr0ptp4kt: mhurd is in the meeting. drop in whenever [19:58:03] is there a hangout url? i'm trying the same url from earlier, not sure if there's a new one [20:00:10] moizsyed: etonkovidova would you mind running over if you're not there already and getting me the hangout url? [20:00:37] (or Deskana|Away in case you're watching irc)? [20:00:43] dr0ptp4kt: a sec [20:01:09] https://plus.google.com/hangouts/_/wikimedia.org/hold-app-q4?authuser=0 [20:01:50] does it work? [20:02:31] etonkovidova: yeah, i'm waiting there. heard from monte on gchat now he's finding out if we're gonna use the same url. thanks for checking out things for me! [20:02:49] np :) [20:08:56] (03CR) 10Bmansurov: Add Swipe module and use it in ImageOverlayNew (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198763 (owner: 10Florianschmidtwelzow) [20:10:51] dr0ptp4kt: https://www.mediawiki.org/wiki/Wikimedia_Engineering/OKR [20:11:17] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: [SchemaGatherClicks] Missing or empty schema - https://phabricator.wikimedia.org/T93706#1154330 (10JKatzWMF) @jdlrobson can't sign off on this one as not familiar with the problem, feel free to sign off if you feel it's resolved. [20:12:48] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Design tweaks for Vector skin - https://phabricator.wikimedia.org/T92883#1154335 (10JKatzWMF) [20:12:49] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Edit/delete buttons do not work when in Vector skin - https://phabricator.wikimedia.org/T93960#1154334 (10JKatzWMF) 5Open>3Resolved [20:15:00] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Gather intro tutorial should probably not be shown on MediaWiki namespace pages - https://phabricator.wikimedia.org/T93990#1154357 (10JKatzWMF) 5Open>3Resolved [20:16:03] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Edit/delete buttons do not work when in Vector skin - https://phabricator.wikimedia.org/T93960#1154359 (10JKatzWMF) [20:16:04] 3Gather Sprint Diplodocus: Edit and delete buttons are currently broken on desktop skins - https://phabricator.wikimedia.org/T94063#1154358 (10JKatzWMF) [20:16:54] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: When I go to Special:Gather and see the collections I own they are illustrated with a page image - https://phabricator.wikimedia.org/T91675#1154362 (10JKatzWMF) 5Open>3Resolved [20:26:27] 3Gather Sprint Diplodocus, 6Mobile-Web, 5Patch-For-Review: Mobile site freezes up when anything bound to resize event (add debouncing) - https://phabricator.wikimedia.org/T93988#1154411 (10kaldari) 5Open>3Resolved [20:27:09] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Zero-Archive, 6Zero-Team, 7Design: only show features related to Zero if Zero is relevant in this context - https://phabricator.wikimedia.org/T92267#1154420 (10Yurik) [20:27:15] 6Mobile-Web, 6Collaboration-Team, 6Editing, 6Engineering-Community, and 15 others: Create team projects for all teams participating in scrum of scrums - https://phabricator.wikimedia.org/T1211#1154422 (10Yurik) [20:27:58] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6Zero-Team, 7Design: only show features related to Zero if Zero is relevant in this context - https://phabricator.wikimedia.org/T92267#1104328 (10Yurik) [20:28:03] 6Mobile-Web, 6Collaboration-Team, 6Editing, 6Engineering-Community, and 14 others: Create team projects for all teams participating in scrum of scrums - https://phabricator.wikimedia.org/T1211#20962 (10Yurik) [20:31:32] 3Gather Sprint Diplodocus, 5Patch-For-Review: Scrolling glitch - https://phabricator.wikimedia.org/T93948#1154469 (10JKatzWMF) still see something wonky on desktop (last list is showing blank), but looks great on mobile chrome...I'm good to sign off on this. {F105905} [20:31:48] 3Gather Sprint Diplodocus, 5Patch-For-Review: Scrolling glitch - https://phabricator.wikimedia.org/T93948#1154471 (10JKatzWMF) 5Open>3Resolved [20:34:39] 6Mobile-Web: Migrate MobileFrontend templates from hogan to mustache - https://phabricator.wikimedia.org/T94086#1154496 (10kaldari) 3NEW [20:37:10] 3Gather Sprint Diplodocus, 5Patch-For-Review: Minimal responsive design for a collection page - https://phabricator.wikimedia.org/T94047#1154516 (10JKatzWMF) 5Open>3Resolved [20:37:15] 3Gather Sprint Diplodocus: Edit and delete buttons are currently broken on desktop skins - https://phabricator.wikimedia.org/T94063#1154521 (10Jdlrobson) 5duplicate>3Open Not same bug! We've not made it work! [20:37:41] 3Gather Sprint Diplodocus: Edit and delete buttons are currently broken on desktop skins - https://phabricator.wikimedia.org/T94063#1154525 (10Jdlrobson) (The other bug merely masks the problem). We need to actually make this work. [20:38:56] where's jdlrobson? [20:39:15] 10MobileFrontend-General-or-Unknown, 6Security: User's password in response html - https://phabricator.wikimedia.org/T72009#1154542 (10csteipp) [20:39:54] 10MobileFrontend-beta, 6Security: Mobile Table of Contents double unescapes encoded characters - https://phabricator.wikimedia.org/T67042#1154580 (10csteipp) [20:40:06] 10MobileFrontend-stable, 6Security: XSS vulnerability in mobile search - https://phabricator.wikimedia.org/T37673#1154589 (10csteipp) [20:41:25] 10Gather, 3Gather Sprint E, 5Patch-For-Review: [placeholder] Responsive design for Special:Gather (important because shares might be desktop) - https://phabricator.wikimedia.org/T91384#1154670 (10JKatzWMF) @jhernandez, just noting that the collections view (more important) is done but it looks like the list... [20:52:41] (03PS6) 10Robmoen: Log anon watchstar clicks to schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199949 (https://phabricator.wikimedia.org/T93989) [20:55:12] (03Abandoned) 10Robmoen: In beta, watchstar loads late and is edit tut is positioned incorrectly [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199795 (owner: 10Robmoen) [21:09:22] 6Mobile-Web, 6Collaboration-Team: Mobile should not completely blank mediawiki.skinning.content.parsoid - https://phabricator.wikimedia.org/T93968#1155063 (10kaldari) Why does mediawiki.skinning.content.parsoid still exist? Wasn't that supposed to be a temporary hack until parsoid and parser DOM models were sy... [21:15:01] bgerstle: coreyfloyd dbrant|food Won't be ready to reconvene with whole team :-( [21:15:44] kristenlans: as in, not today? [21:15:52] dbrant|food: coreyfloyd bgerstle you can get a sense of where things are on etherpad line 143 [21:15:54] 6Mobile-Web, 6Collaboration-Team, 10Parsoid: Mobile should not completely blank mediawiki.skinning.content.parsoid - https://phabricator.wikimedia.org/T93968#1155110 (10Mattflaschen) >>! In T93968#1155063, @kaldari wrote: > Why does mediawiki.skinning.content.parsoid still exist? Wasn't that supposed to be a... [21:16:14] dbrant, coreyfloyd bgerstle : yes as in not today, follow up TBD [21:19:56] k, going out for a bit [21:20:08] (03CR) 10Jdlrobson: [C: 032] Log anon watchstar clicks to schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199949 (https://phabricator.wikimedia.org/T93989) (owner: 10Robmoen) [21:22:14] (03Merged) 10jenkins-bot: Log anon watchstar clicks to schema [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199949 (https://phabricator.wikimedia.org/T93989) (owner: 10Robmoen) [21:25:32] (03PS1) 10Bmansurov: Ignore multicolumn layouts on small devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200030 (https://phabricator.wikimedia.org/T93786) [21:25:47] 6Mobile-Web, 5Patch-For-Review: Multiple column layouts should be ignored on mobile - https://phabricator.wikimedia.org/T93786#1155190 (10bmansurov) a:3bmansurov [21:26:28] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: no event fires when user clicks watchstar (at least while logged out) - https://phabricator.wikimedia.org/T93989#1155193 (10Jdlrobson) 5Open>3Resolved [21:26:48] 3Gather Sprint E: Edit and delete buttons are currently broken on desktop skins - https://phabricator.wikimedia.org/T94063#1155196 (10Jdlrobson) [21:27:17] 3Gather Sprint E: Spike: How can we stop Gather depending on MobileFrontend - https://phabricator.wikimedia.org/T94100#1155197 (10Jdlrobson) 3NEW [21:28:52] (03CR) 10Jdlrobson: [C: 032] Background size of collection images doesn't work properly. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199983 (https://phabricator.wikimedia.org/T93953) (owner: 10Jhernandez) [21:29:27] (03CR) 10Jdlrobson: [C: 032] Fix spacing of content on tablet [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199977 (https://phabricator.wikimedia.org/T94070) (owner: 10Jhernandez) [21:29:28] 6Mobile-Web, 6Collaboration-Team, 10Parsoid: Mobile should not completely blank mediawiki.skinning.content.parsoid - https://phabricator.wikimedia.org/T93968#1155208 (10kaldari) I don't mean they need to be the exact same HTML, I just mean that a year or so ago there was discussion about killing the two DOM... [21:29:54] (03Merged) 10jenkins-bot: Background size of collection images doesn't work properly. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199983 (https://phabricator.wikimedia.org/T93953) (owner: 10Jhernandez) [21:30:11] (03CR) 10Jdlrobson: [C: 032] Style: Spacing issue in vector styles [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199974 (https://phabricator.wikimedia.org/T94069) (owner: 10Jhernandez) [21:31:10] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: collection images in list of collections should scale to match width of collection title - https://phabricator.wikimedia.org/T93953#1155223 (10Jdlrobson) 5Open>3Resolved [21:35:37] (03CR) 10Jdlrobson: [C: 04-1] Ignore multicolumn layouts on small devices (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200030 (https://phabricator.wikimedia.org/T93786) (owner: 10Bmansurov) [21:36:19] 6Mobile-Web: 3rd parties shouldn't be subjected to hacks.less - https://phabricator.wikimedia.org/T94102#1155229 (10Jdlrobson) 3NEW [21:37:04] (03CR) 10Jdlrobson: [C: 032] Make list items easy to read by adding margin-bottom [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199765 (https://phabricator.wikimedia.org/T93784) (owner: 10Bmansurov) [21:40:26] (03CR) 10Jdlrobson: Fix wikitable table borders (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) (owner: 10Bmansurov) [21:40:52] (03CR) 10Jdlrobson: [C: 04-1] "have added other reviewers but we really should strive to eradicate the use of !important" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) (owner: 10Bmansurov) [21:41:39] (03CR) 10Jdlrobson: [C: 032] Hyphenate page titles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199761 (https://phabricator.wikimedia.org/T93826) (owner: 10Bmansurov) [21:45:16] (03Merged) 10jenkins-bot: Fix spacing of content on tablet [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199977 (https://phabricator.wikimedia.org/T94070) (owner: 10Jhernandez) [21:49:03] 6Mobile-Web, 5Patch-For-Review: Deemphasise wikitext markup in editor - https://phabricator.wikimedia.org/T91796#1155267 (10Jdlrobson) @Florian do we have to get this deployed now? I'm not seeing on beta labs [21:50:14] (03CR) 10Bmansurov: Fix wikitable table borders (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) (owner: 10Bmansurov) [21:50:59] (03CR) 10Bmansurov: "@Jdlrobson, the decision to override was done long time ago, and this patch was in beta first. I'm just adding the missing parts of the bo" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) (owner: 10Bmansurov) [21:53:14] (03CR) 10Jdlrobson: [V: 04-1] "Sure... but part of bug fixing should be cleaning up old mistakes." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) (owner: 10Bmansurov) [21:54:34] (03PS2) 10Bmansurov: Ignore multicolumn layouts on small devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200030 (https://phabricator.wikimedia.org/T93786) [21:55:50] 6Mobile-Web, 5Patch-For-Review: Deemphasise wikitext markup in editor - https://phabricator.wikimedia.org/T91796#1155292 (10Florian) @Jdlrobson: Without CodeMirror installed, you'll never the the new editor :) I uploaded https://gerrit.wikimedia.org/r/#/c/199941/ to make it able to install CodeMirror just as a... [21:57:57] bgerstle_afk: coreyfloyd you guys able to do a video hangout? [21:58:01] 10Gather, 3Gather Sprint Diplodocus: Blocked users should not be able to create or edit public lists - https://phabricator.wikimedia.org/T94105#1155311 (10Jdlrobson) 3NEW [21:58:13] 10Gather, 3Gather Sprint Diplodocus: Blocked users should not be able to create or edit public lists - https://phabricator.wikimedia.org/T94105#1155319 (10Jdlrobson) a:3Jdlrobson [21:58:14] dr0ptp4kt: yep [22:00:27] (03Merged) 10jenkins-bot: Style: Spacing issue in vector styles [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199974 (https://phabricator.wikimedia.org/T94069) (owner: 10Jhernandez) [22:00:31] dr0ptp4kt: hey [22:00:32] Yeah [22:00:42] bgerstle: monte needs 10 mins...he'll be back on irc when he gets back to his desk. bgerstle coreyfloyd that still work for you? [22:00:50] sure [22:00:59] dr0ptp4kt: yeah [22:01:23] (03Merged) 10jenkins-bot: Make list items easy to read by adding margin-bottom [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199765 (https://phabricator.wikimedia.org/T93784) (owner: 10Bmansurov) [22:02:06] bgerstle: coreyfloyd thx [22:04:45] 6Mobile-Web, 5Patch-For-Review: Lists should have greater line-height to improve readability - https://phabricator.wikimedia.org/T93784#1155344 (10bmansurov) 5Open>3Resolved [22:05:57] (03PS1) 10Jdlrobson: blocked users cannot manipulate collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200039 (https://phabricator.wikimedia.org/T94105) [22:06:00] ^ MaxSem [22:06:55] dr0ptp4kt: back [22:07:30] 10Gather, 3Gather Sprint E: Error handling broken on edit workflow - https://phabricator.wikimedia.org/T94106#1155353 (10Jdlrobson) 3NEW [22:08:06] bgerstle coreyfloyd mhurd to the "batcave" ... https://plus.google.com/hangouts/_/event/c5p2pudvb8s6ckluqf56v791em4 . [22:08:24] nanananananaan [22:08:47] (03CR) 10MaxSem: blocked users cannot manipulate collections (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200039 (https://phabricator.wikimedia.org/T94105) (owner: 10Jdlrobson) [22:09:30] (03PS2) 10Jdlrobson: blocked users cannot manipulate collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200039 (https://phabricator.wikimedia.org/T94105) [22:11:45] (03Merged) 10jenkins-bot: Hyphenate page titles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199761 (https://phabricator.wikimedia.org/T93826) (owner: 10Bmansurov) [22:12:09] 6Mobile-Web: {{hat}} and similar templates on Wikipedia are invisible to mobile web view. - https://phabricator.wikimedia.org/T94107#1155384 (10Thryduulf) 3NEW [22:12:15] 6Mobile-Web, 5Patch-For-Review: Page titles breaking in middle of the word on mobile beta - https://phabricator.wikimedia.org/T93826#1155391 (10bmansurov) 5Open>3Resolved [22:14:21] 6Mobile-Web, 6Collaboration-Team, 10Parsoid: Mobile should not completely blank mediawiki.skinning.content.parsoid - https://phabricator.wikimedia.org/T93968#1155395 (10Jdlrobson) Introduced in https://gerrit.wikimedia.org/r/#/c/138518/ fyi [22:16:58] (03PS3) 10Jdlrobson: blocked users cannot manipulate collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200039 (https://phabricator.wikimedia.org/T94105) [22:20:28] (03PS4) 10Jdlrobson: blocked users cannot manipulate collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200039 (https://phabricator.wikimedia.org/T94105) [22:21:10] (03CR) 10MaxSem: [C: 032] blocked users cannot manipulate collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200039 (https://phabricator.wikimedia.org/T94105) (owner: 10Jdlrobson) [22:21:21] (03PS1) 10MaxSem: blocked users cannot manipulate collections [extensions/Gather] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/200050 (https://phabricator.wikimedia.org/T94105) [22:21:30] (03CR) 10MaxSem: [C: 032] blocked users cannot manipulate collections [extensions/Gather] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/200050 (https://phabricator.wikimedia.org/T94105) (owner: 10MaxSem) [22:23:06] (03PS1) 10MaxSem: blocked users cannot manipulate collections [extensions/Gather] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/200051 (https://phabricator.wikimedia.org/T94105) [22:23:15] (03CR) 10MaxSem: [C: 032] blocked users cannot manipulate collections [extensions/Gather] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/200051 (https://phabricator.wikimedia.org/T94105) (owner: 10MaxSem) [22:23:38] 6Mobile-Web, 5Patch-For-Review: Watchstars not aligned in search - https://phabricator.wikimedia.org/T91178#1155423 (10Jdlrobson) Ping @florian what's the status of this? [22:24:04] bmansurov: mind if I take a shot at https://gerrit.wikimedia.org/r/#/c/199780/ ? I wrote most of those styles originally and I have an idea for how to simplify it. [22:24:26] coreyfloyd: this: https://phabricator.wikimedia.org/T94003 [22:24:38] kaldari: please and thanks [22:25:07] 6Mobile-Web, 5Patch-For-Review: Table border parameter does not display right border on mobile - https://phabricator.wikimedia.org/T92913#1155424 (10kaldari) a:5bmansurov>3kaldari [22:25:17] (03CR) 10Jdlrobson: "Add @media query as well?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200030 (https://phabricator.wikimedia.org/T93786) (owner: 10Bmansurov) [22:25:24] (03Merged) 10jenkins-bot: blocked users cannot manipulate collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200039 (https://phabricator.wikimedia.org/T94105) (owner: 10Jdlrobson) [22:25:27] (03Merged) 10jenkins-bot: blocked users cannot manipulate collections [extensions/Gather] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/200050 (https://phabricator.wikimedia.org/T94105) (owner: 10MaxSem) [22:25:55] (03CR) 10Bmansurov: Ignore multicolumn layouts on small devices (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200030 (https://phabricator.wikimedia.org/T93786) (owner: 10Bmansurov) [22:27:11] dr0ptp4kt: thanks [22:27:11] (03PS3) 10Bmansurov: Ignore multicolumn layouts on small devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200030 (https://phabricator.wikimedia.org/T93786) [22:27:57] Deskana|Away: ^^ would the but two steps up be a blocker for release? it's sort of an edge case. coreyfloyd is working it in any event, but wanted to know. we wanted to draw the line at 4 pm pacific time today, and i'd be cutting the testflight build tonight. in other news, mhurd is going to see how well 100 recent articles would migrate on an old ios 6 device in order to make a judgment call about whether to import recents or not [22:28:50] (03PS1) 10Aaron Schulz: Avoid needless master queries on page views [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200052 (https://phabricator.wikimedia.org/T92357) [22:31:32] 6Mobile-Web: The mobile Web wikicode editor loses the user-entered text - https://phabricator.wikimedia.org/T88949#1155473 (10Jdlrobson) Whether it is a JS overlay or an actual page makes no difference as we can use localStorage. Confirm exit windows do not work everywhere. There are lots of caveats. Also in mob... [22:32:07] 10Gather, 3Gather Sprint Diplodocus, 6Security, 5Patch-For-Review: Blocked users should not be able to create or edit public lists - https://phabricator.wikimedia.org/T94105#1155475 (10csteipp) [22:32:25] 3Gather Sprint Diplodocus, 6Mobile-Web, 5Patch-For-Review: EditorTutorial false arrow position - https://phabricator.wikimedia.org/T91047#1155486 (10Jdlrobson) 5Open>3Resolved [22:32:57] 6Mobile-Web, 10WikiGrok, 5Patch-For-Review: wikigrokresponse API should cap the number of claims accepted - https://phabricator.wikimedia.org/T91142#1155488 (10Jdlrobson) 5Open>3Resolved Patch was merged. Please reopen if not fixed. [22:33:20] (03CR) 10Bmansurov: "The real problem is to detect the user's screen size and load the optimal image. I'll abandon this patch for the sake of exploring the ext" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [22:33:27] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Event logging for Gather onboarding - https://phabricator.wikimedia.org/T92742#1155491 (10Jdlrobson) [22:33:29] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: [SchemaGatherClicks] Missing or empty schema - https://phabricator.wikimedia.org/T93706#1155490 (10Jdlrobson) 5Open>3Resolved [22:33:45] (03Abandoned) 10Bmansurov: Alpha: Load banner images on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [22:33:54] 10Gather, 3Gather Sprint Diplodocus, 6Security, 5Patch-For-Review: Blocked users should not be able to create or edit public lists - https://phabricator.wikimedia.org/T94105#1155496 (10Jdlrobson) 5Open>3Resolved [22:34:06] 6Mobile-Web, 5Patch-For-Review: Initial banner image should be delivered as part of the initial response - https://phabricator.wikimedia.org/T90698#1155497 (10bmansurov) a:5bmansurov>3None [22:35:24] (03CR) 10Bgerstle: [C: 031] Fix for crash when thumb fetcher had error. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199810 (owner: 10Mhurd) [22:38:03] (03Merged) 10jenkins-bot: blocked users cannot manipulate collections [extensions/Gather] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/200051 (https://phabricator.wikimedia.org/T94105) (owner: 10MaxSem) [22:40:04] rmoen: JonKatz we are live on test wiki [22:40:08] can you test? [22:40:16] (03CR) 10Florianschmidtwelzow: [C: 032] Avoid needless master queries on page views [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200052 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz) [22:44:32] ^ JonKatz rmoen ping? [22:50:02] 10Gather, 3Gather Sprint Diplodocus: Page action tutorial should be force closed by clicking the watchstar - https://phabricator.wikimedia.org/T94113#1155521 (10Jdlrobson) 3NEW [22:54:14] (03Merged) 10jenkins-bot: Avoid needless master queries on page views [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200052 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz) [22:56:24] (03CR) 10Dr0ptp4kt: [C: 032] Fix for crash when thumb fetcher had error. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199810 (owner: 10Mhurd) [23:02:10] 10MobileFrontend-Feature-requests, 5Patch-For-Review, 7notice, 7user-notice: Links to talk pages in mobile view - https://phabricator.wikimedia.org/T54165#1155565 (10gpaumier) [23:03:38] 10Wikipedia-App-iOS-App: Tap on result after microphone based search crashes app if mic panel not dismissed first - https://phabricator.wikimedia.org/T94003#1155583 (10Fjalapeno) Was hard to repro - looks like you need a slow network, or a fast tapper to see the bug. Race condition! The search controller is ref... [23:05:15] 10Gather: API: support page reordering - https://phabricator.wikimedia.org/T94117#1155585 (10Yurik) 3NEW [23:07:32] (03PS3) 10Kaldari: Fix wikitable table borders [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) (owner: 10Bmansurov) [23:16:18] (03PS1) 10Mhurd: Removed recent items from migrator import count. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200070 [23:19:50] (03CR) 10Fjalapeno: [C: 031] Removed recent items from migrator import count. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200070 (owner: 10Mhurd) [23:19:52] (03CR) 10Bgerstle: [C: 031] "do eeet" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200070 (owner: 10Mhurd) [23:20:01] (03PS2) 10Mhurd: Removed recent items from migrator import count. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200070 [23:20:09] (03CR) 10Mhurd: [C: 032] Removed recent items from migrator import count. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200070 (owner: 10Mhurd) [23:27:08] 10Gather, 3Gather Sprint Diplodocus: Blue tutorial indicator positioned incorrectly in Chrome when star is green - https://phabricator.wikimedia.org/T93987#1155639 (10rmoen) a:3rmoen [23:28:29] 10Gather, 3Gather Sprint Diplodocus: Page action tutorial should be force closed by clicking the watchstar - https://phabricator.wikimedia.org/T94113#1155644 (10rmoen) a:3rmoen [23:31:10] bgerstle: im not even seeing the jump on device [23:31:23] ok, good to know [23:31:33] bgerstle: but maybe its an old version… let me recheck [23:31:41] bgerstle: this bug is in master? [23:32:19] i believe so [23:32:48] coreyfloyd: mhurd going afk... the hunger is taking over now.. [23:33:05] http://stream1.gifsoup.com/view/179112/hulk-smash-o.gif [23:33:22] lol [23:39:53] mhurd: was adam going to do testflight tonight? [23:58:30] (03PS1) 10Robmoen: Prevent tutorial from showing if user clicks watchstar prior to load [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200077 [23:59:22] (03PS2) 10Robmoen: Prevent tutorial from showing if user clicks watchstar prior to load [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200077