[00:23:52] 10Gather: API: Incorrect result for listpages module - https://phabricator.wikimedia.org/T94124#1155751 (10Yurik) 3NEW [00:48:31] coreyfloyd: i think so, but later [00:48:39] coreyfloyd: sorry was afk. gotta run [00:48:42] again [01:03:28] MaxSem, blocking after connecting to the database? https://gerrit.wikimedia.org/r/#/c/200039/4/includes/api/ApiEditList.php,cm [01:03:48] when there is a method called checkPermissions() ? [01:03:53] come on :) [01:07:53] (03CR) 10Yurik: "This should NOT have been merged in this state. You check for user permissions outside of the function checkPermissions() for no apparent " [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200039 (https://phabricator.wikimedia.org/T94105) (owner: 10Jdlrobson) [01:14:25] (03PS1) 10Yurik: Fixing isBlocked() on ApiEditList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200087 (https://phabricator.wikimedia.org/T94105) [01:15:15] (03PS2) 10Yurik: Fixing isBlocked() on ApiEditList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200087 (https://phabricator.wikimedia.org/T94105) [01:35:51] pfft yurik - it works, right? ;) [01:36:03] meh [01:36:25] who needs those pesky classes and namespaces [01:36:48] also, that was during deployment: "CAN'T THINK NEED TO DELIVER" [01:37:01] in other words, I am mission oriented [01:37:13] MaxSem, https://gerrit.wikimedia.org/r/#/c/200087/ [01:37:26] we deployed? [01:37:30] interesting :) [01:37:35] i missed all the fun :) [01:37:46] please +2 ^ [01:38:14] (03CR) 10MaxSem: [C: 032] Fixing isBlocked() on ApiEditList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200087 (https://phabricator.wikimedia.org/T94105) (owner: 10Yurik) [01:38:29] MaxSem, en or test ? [01:39:12] (03Merged) 10jenkins-bot: Fixing isBlocked() on ApiEditList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200087 (https://phabricator.wikimedia.org/T94105) (owner: 10Yurik) [01:40:42] (03PS14) 10Yurik: lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 [02:10:12] (03PS15) 10Yurik: lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 [02:16:32] (03PS16) 10Yurik: lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 [04:38:42] 6Mobile-Web, 6Collaboration-Team, 10Parsoid: Mobile should not completely blank mediawiki.skinning.content.parsoid - https://phabricator.wikimedia.org/T93968#1156022 (10Mattflaschen) >>! In T93968#1155208, @kaldari wrote: > I don't mean they need to be the exact same HTML, I just mean that a year or so ago t... [05:11:51] (03PS1) 10Legoktm: Don't throw a plain \Exception [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200108 [05:11:53] (03PS1) 10Legoktm: Use User::equals() [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200109 [05:12:39] (03CR) 10jenkins-bot: [V: 04-1] Don't throw a plain \Exception [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200108 (owner: 10Legoktm) [05:12:41] (03CR) 10jenkins-bot: [V: 04-1] Use User::equals() [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200109 (owner: 10Legoktm) [05:19:39] (03PS2) 10Legoktm: Don't throw a plain \Exception [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200108 [05:19:41] (03PS2) 10Legoktm: Use User::equals() [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200109 [05:19:43] (03PS1) 10Legoktm: Don't access context in SpecialPage::__construct(), it's not set yet [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200112 [05:20:40] (03CR) 10jenkins-bot: [V: 04-1] Don't throw a plain \Exception [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200108 (owner: 10Legoktm) [05:20:42] (03CR) 10jenkins-bot: [V: 04-1] Use User::equals() [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200109 (owner: 10Legoktm) [05:20:45] (03CR) 10jenkins-bot: [V: 04-1] Don't access context in SpecialPage::__construct(), it's not set yet [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200112 (owner: 10Legoktm) [05:21:19] (03PS1) 10Legoktm: jenkins job validation, do not submit [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200113 [05:21:52] (03Abandoned) 10Legoktm: jenkins job validation, do not submit [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200113 (owner: 10Legoktm) [05:27:53] I blame jenkins. [05:35:32] (03PS2) 10Legoktm: Don't access context in SpecialPage::__construct(), it's not set yet [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200112 [05:35:34] (03PS3) 10Legoktm: Don't throw a plain \Exception [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200108 [05:35:36] (03PS3) 10Legoktm: Use User::equals() [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200109 [05:40:33] 6Mobile-Web, 5Patch-For-Review: Deemphasise wikitext markup in editor - https://phabricator.wikimedia.org/T91796#1156056 (10Pastakhov) I do not mind to change owner of CodeMirror repository to someone who will review changes on security before merging. If I'm not mistaken this is necessary in order to use it o... [08:27:44] 6Mobile-Web: The mobile Web wikicode editor loses the user-entered text - https://phabricator.wikimedia.org/T88949#1156135 (10TheDJ) @jdlrobson, I should have clarified that my comment was specifically meant towards this patchset: https://gerrit.wikimedia.org/r/190163, which to me looks almost identical to the c... [09:57:13] yo! [09:59:15] 6Mobile-Web, 7I18n: Mobile “infobox” experimental feature is not localized - https://phabricator.wikimedia.org/T94146#1156212 (10Mormegil) 3NEW [11:20:47] 10Gather, 10Continuous-Integration: Set up qunit Jenkins job for Extension:Gather - https://phabricator.wikimedia.org/T91708#1156365 (10Krinkle) [11:29:48] (03CR) 10Phuedx: [C: 032] Add "composer test" command to run phpcs and make it pass [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/199788 (https://phabricator.wikimedia.org/T90943) (owner: 10Legoktm) [11:31:36] (03Merged) 10jenkins-bot: Add "composer test" command to run phpcs and make it pass [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/199788 (https://phabricator.wikimedia.org/T90943) (owner: 10Legoktm) [11:49:17] 6Mobile-Web, 10Continuous-Integration, 7Browser-Tests, 7Tracking: Delete or fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1156443 (10zeljkofilipin) 3NEW a:3zeljkofilipin [11:54:20] 6Mobile-Web, 10Continuous-Integration, 7Browser-Tests, 7Tracking: Delete or fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1156475 (10zeljkofilipin) a:5zeljkofilipin>3None [11:57:43] (03CR) 10Phuedx: [C: 032] Add roulette query string to the next url [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198448 (https://phabricator.wikimedia.org/T93449) (owner: 10Bmansurov) [11:58:07] 6Mobile-Web, 10WikiGrok: Update WikiGrok not to use MobileFrontend util.query - https://phabricator.wikimedia.org/T93449#1156485 (10phuedx) [11:59:25] (03Merged) 10jenkins-bot: Add roulette query string to the next url [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/198448 (https://phabricator.wikimedia.org/T93449) (owner: 10Bmansurov) [12:28:14] (03PS1) 10Dr0ptp4kt: Update AFNetworking dependency [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200145 [12:30:07] (03CR) 10Dr0ptp4kt: [C: 032] Update AFNetworking dependency [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200145 (owner: 10Dr0ptp4kt) [13:01:33] 10Gather: API: support automatic and manual images - https://phabricator.wikimedia.org/T93912#1156593 (10Yurik) [14:12:28] 6Mobile-Web: The mobile Web wikicode editor loses the user-entered text - https://phabricator.wikimedia.org/T88949#1156778 (10Jdlrobson) I see... That's the first time I've seen that patch. @bmansurov @florian that should be fixed... That sort of code should be reusable. [14:14:15] (03CR) 10Jdlrobson: "I was on vacation when this merged but I think this should be reverted and replaced with the existing library in core or not exist at all." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190163 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [14:32:19] coreyfloyd: bgerstle okay if we reschedule the engineering backlog meeting to a mutually available time on monday or, failing mutual availability, tuesday? [14:33:04] dr0ptp4kt: i'm totally free on mon/tues [14:34:04] dr0ptp4kt: is it at all possible to move our "release cadence/process" meeting up earlier in the week as well? [14:34:40] not sure why our Q4 follow-up isn't until friday either [14:34:50] bgerstle: i can look for a mutually available time with a meeting room on that, yeah [14:34:59] i guess it's fine, since we're focusing on upcoming release [14:36:22] dr0ptp4kt: np [14:41:42] dbrant: you there? could you run the standup today? dan and kristen won't be there. my extended family is gathering for lunch at that time [14:43:45] dr0ptp4kt: lol actually I don't think I can make it either. I have an appointment from which i probably won't make it back in time [14:44:32] bgerstle: coreyfloyd would you please do a 'smoketest upgrade' via testflight for the 'wikipedia mobile' app? first install the store app, then browse around and save some stuff and whatnot. then close the 'wikipedia mobile' app, then open testflight and install on top. it worked for me [14:45:11] dbrant: ok...i therefore nominate agile COACH coreyfloyd .... coreyfloyd would you run the show this morning for the standup? [14:45:29] dr0ptp4kt: we can, and i was about to mention this in my email, but should we instead focus on enabling QA & beta users to test upgrade? [14:45:33] dbrant: ...while i have you here, would you be able to do a 'smoketest upgrade' of the wikipedia mobile app as well? [14:45:40] dbrant: ^^^ see up there [14:46:22] dr0ptp4kt: we should also provide instructions to save your app's data/container *before* migration so we can reproduce if something goes wrong [14:46:29] dr0ptp4kt: will do... [14:47:00] bgerstle: dan and monte advised against pushing an upgrade attempt to the external testing group, as it would be confusing. BUT, i can email the people on the internal testflight group for 'wikipedia mobile' to do this upgrade smoketest [14:47:15] dr0ptp4kt: why do we *not* want more people testing this? [14:47:19] we need instructions for TSG anyway [14:47:48] (and for us, i would argue) [14:50:25] dr0ptp4kt: yeah I'll do the standup. And also look at the upgrade for users. But agree with Brian, the best thing is to get more users testing this process. [14:50:49] bgerstle: this is incidental, but if we try to do an external testflight on the 'wikipedia mobile' build, we'll need to have that beta build go through full review [14:51:03] bgerstle: coreyfloyd able to get on the batcave? [14:52:20] dr0ptp4kt: yeah 1 sec [14:53:04] dr0ptp4kt: in the future all further requests for batcave meetings should take the form of a GIF [14:53:17] for example: https://38.media.tumblr.com/4b35828c44a79d92d78355aa49878a88/tumblr_ml01uld5a21rnm1ldo1_500.gif [14:57:31] Sorry can now [14:57:37] dr0ptp4kt: ^ [14:59:27] S'up dudes, just reading the logs... bgerstle coreyfloyd I really wanted to do the Q4 plannign debrief Monday or at the latest Tuesday but Friday was seriously the only available time. Dan is in a training T-Th :-( [15:01:24] bgerstle: coreyfloyd In the meantime, there will be emails with more info. [15:01:55] kristenlans_: awesome, thanks! [15:43:33] 10Wikipedia-App-Android-App: Exceptions from within getExternalCacheDir call in util.ShareUtils.clearFolder - https://phabricator.wikimedia.org/T94185#1157042 (10Krenair) 3NEW [15:48:14] shit [15:48:17] dr0ptp4kt: [15:48:22] hangout? [15:48:46] dr0ptp4kt: Did you do a pod update to get AfNetworking 2.5.2? [15:49:35] coreyfloyd: i did an afnetworking 2.5.2 upgrade, yes [15:50:15] dr0ptp4kt: ok, whew! [15:50:43] coreyfloyd: bgerstle the testflight external on 'wikipedia mobile' didn't prevent overlay...now commencing with formal store resubmission [15:51:11] dr0ptp4kt: http://p.fod4.com/p/media/a0e4c85568/siUqyccNSsSENSV3dta8_Forehead%20Airplane.gif [15:52:16] coreyfloyd: :) [15:55:29] (03PS1) 10Dbrant: Fix a couple issues with single WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200166 [15:57:07] 10Gather: API: support automatic and manual images - https://phabricator.wikimedia.org/T93912#1157095 (10Yurik) a:3Yurik [16:00:09] bgerstle: coreyfloyd awwwwww yeeeeeeeah, was even able to overlay install via testflight with the version just submitted for formal store review. i'll email people [16:01:37] bgerstle: coreyfloyd you able to install the app store version and then still upgrade via testflight 'wikipedia mobile' ? [16:02:19] dr0ptp4kt: checkin [16:03:13] Can check in a bit. Going afk [16:03:46] dr0ptp4kt: yep [16:04:33] coreyfloyd: that's great news. thanks! [16:05:55] dr0ptp4kt: np - i mean my thumbs are cramping from so much app installing, but I'll be ok… :) [16:07:44] 6Mobile-Web: The mobile Web wikicode editor loses the user-entered text - https://phabricator.wikimedia.org/T88949#1157102 (10Florian) I'll look into it :) [16:11:34] bgerstle-afk: coreyfloyd gotta take shower and then get on the road for the lunch. ttyl [16:14:38] 6Mobile-Web: Mobile MediaViewer: Close icon behavior is inconsistent - https://phabricator.wikimedia.org/T94188#1157110 (10Eloquence) 3NEW [16:17:10] coreyfloyd: excellet airplane gif [16:17:23] "Picked a bad week to stop sniffing glue..." [16:17:32] excellent, even [16:20:48] bgerstle: lol [16:20:59] its always a bad week to stop sniffing glue [16:31:08] 6Mobile-Web: Window on leave code in editor overlay should be reusable - https://phabricator.wikimedia.org/T94194#1157178 (10Jdlrobson) 3NEW [16:33:45] 6Mobile-Web: Window on leave code in editor overlay should be reusable - https://phabricator.wikimedia.org/T94194#1157186 (10Jdlrobson) (We may also want to consider dropping this code altogether - note that on mobile typically the only way to lose an edit is to close the window as there are no links to follow i... [16:34:00] 6Mobile-Web: Window on leave code in editor overlay should be reusable or dropped - https://phabricator.wikimedia.org/T94194#1157188 (10Jdlrobson) [16:36:36] coreyfloyd: bgerstle hey! [16:36:50] mhurd hey [16:36:57] mhurd: yo yo! [16:37:51] 6Mobile-Web: The mobile Web wikicode editor loses the user-entered text - https://phabricator.wikimedia.org/T88949#1157197 (10Jdlrobson) T94194 [16:38:07] bgerstle: coreyfloyd hey if we have a node version > 0.10 it’s giving a warning “node v0.10 and/or higher and npm 1.4 or higher” error [16:38:32] bgerstle: coreyfloyd bearnd has node 0.12 and sees this error [16:38:32] mhurd yeah there's task in the backlog for that [16:38:32] thanks [16:38:38] bgerstle: ah cool! [16:39:16] bgerstle: coreyfloyd i’ll be available after standup. [16:39:19] brb [16:40:23] k [16:54:26] 10MobileFrontend-Feature-requests, 10Wikidata: Setup WikidataPageBanner extension repository on Gerrit - https://phabricator.wikimedia.org/T93127#1157264 (10Sumit) Request for new gerrit repository for wikidata pagebanner extension can be tracked at the bottom of the table here: https://www.mediawiki.org/wiki/... [16:56:04] hello [17:02:12] (03PS1) 10Florianschmidtwelzow: Use mediawiki.confirmCloseWindow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200179 (https://phabricator.wikimedia.org/T88949) [17:03:59] (03CR) 10jenkins-bot: [V: 04-1] Use mediawiki.confirmCloseWindow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200179 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [17:05:46] (03CR) 10Florianschmidtwelzow: "Hi Max, i'm keen to merge this :) Can you update the change?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199177 (https://phabricator.wikimedia.org/T93500) (owner: 10MaxSem) [17:06:42] https://docs.google.com/a/wikimedia.org/presentation/d/1yKI-ilbs_JA8IKa9E5_no-THX9qbSCqvxUUQLADipMQ/edit#slide=id.g8fef878c5_0_134 [17:08:01] (03CR) 10jenkins-bot: [V: 04-1] Special Edit feed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 (owner: 10Jdlrobson) [17:14:38] https://etherpad.wikimedia.org/p/q4_checkin [17:16:00] https://etherpad.wikimedia.org/p/q4_checkin [17:16:25] (03PS7) 10Florianschmidtwelzow: Rework init script for Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199663 (https://phabricator.wikimedia.org/T93933) [17:17:15] FYI bernd mhurd here's the ticket for npm versions https://phabricator.wikimedia.org/T93249 [17:24:04] MaxSem: incanhaz your power? [17:29:46] bernd maybe a good time to have a "release" branch for your upcoming release? that way you can merge dbrant's patch to master w/o worrying about it blocking hot-fixes to the release (branch) [17:29:48] 10Gather, 3Gather Sprint Diplodocus, 10Wikimedia-Extension-setup, 3Roadmap, and 2 others: Enable Extension:Gather (article lists) on English Wikipedia Mobile Beta - https://phabricator.wikimedia.org/T91341#1157347 (10greg) FYI: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20150330T2300 c... [17:35:42] mhurd here's the release "progress" https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/iOS/Releases#App_Store [17:39:22] if I apply an event on an element using events map in a subclass of say Overlay, will the element get two handlers? [17:39:37] (03PS1) 10Bartosz Dziewoński: Get rid of 'type' stuff in ResourceLoaderImageModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200189 (https://phabricator.wikimedia.org/T94073) [17:39:47] (03PS1) 10Bartosz Dziewoński: Get rid of 'type' stuff in ResourceLoaderImageModule [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200190 (https://phabricator.wikimedia.org/T94073) [17:40:01] (03CR) 10jenkins-bot: [V: 04-1] Get rid of 'type' stuff in ResourceLoaderImageModule [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200190 (https://phabricator.wikimedia.org/T94073) (owner: 10Bartosz Dziewoński) [17:41:18] (03CR) 10jenkins-bot: [V: 04-1] Get rid of 'type' stuff in ResourceLoaderImageModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200189 (https://phabricator.wikimedia.org/T94073) (owner: 10Bartosz Dziewoński) [17:42:08] 10Wikipedia-App-Android-App, 10Wikimania-Hackathon-2015, 10Wikimedia-Hackathon-2015, 7Design: Add an easier and faster way to change the search language - https://phabricator.wikimedia.org/T87154#1157412 (10Pginer-WMF) Thanks for the details, @AlexLippert. The long press on search could work as a shortcu... [17:42:38] (03PS2) 10Bartosz Dziewoński: Use ResourceLoaderImageModule's CSS selector templates [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199131 (https://phabricator.wikimedia.org/T78215) [17:42:40] (03PS2) 10Bartosz Dziewoński: Get rid of 'type' stuff in ResourceLoaderImageModule [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200190 (https://phabricator.wikimedia.org/T94073) [17:43:26] (03CR) 10jenkins-bot: [V: 04-1] Use ResourceLoaderImageModule's CSS selector templates [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199131 (https://phabricator.wikimedia.org/T78215) (owner: 10Bartosz Dziewoński) [17:43:31] (03CR) 10jenkins-bot: [V: 04-1] Get rid of 'type' stuff in ResourceLoaderImageModule [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200190 (https://phabricator.wikimedia.org/T94073) (owner: 10Bartosz Dziewoński) [17:49:24] kaldari: https://gerrit.wikimedia.org/r/#/c/200188/2 [17:49:34] kaldari: you around? [17:49:51] in quarterly planning meeting [17:49:56] this change affects both MF and Gather [17:50:09] wanted to get someone on your team to +1 before we went ahead [17:50:43] TrevorParscal: I’ll post a note to the team. Thanks! [17:50:48] thanks [17:51:03] we want to get it out quick so other extensions aren't also affected by the change [17:51:10] enjoy your meeting [17:54:51] bearND: not sure if you saw my comment earlier: "maybe a good time to have a "release" branch for your upcoming release? that way you can merge dbrant's patch to master w/o worrying about it blocking hot-fixes to the release (branch)" [17:57:31] (03PS1) 10Florianschmidtwelzow: Hygiene: Don't load InfiniteScroll on _all_ pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 [17:58:20] bgerstle: yes, i saw it. Thank you. We just went upstairs a bit. Before we do that I think we'd want to have another versionCode bump commit. I'm leaning towards making another release with dbrant|brb's bug fixes before we merge the WebView patch. [17:59:01] 10Gather, 3Gather Sprint Diplodocus: Collections of users with special characters rendering with error - https://phabricator.wikimedia.org/T94206#1157475 (10Jdlrobson) 3NEW [17:59:30] k [18:00:10] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Don't load InfiniteScroll on _all_ pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 (owner: 10Florianschmidtwelzow) [18:00:12] what would be the most optimal line for closing an overlay? would this.emit('hide') work? [18:00:39] codezee: this.hide() should take care of hiding and emitting events [18:01:30] joakino: so if I use this.hide(), I can safely assume that the overlay would be closed? [18:01:47] codezee: i think so [18:01:53] joakino: thanks :) [18:07:41] (03PS1) 10Sumit: MediaViewer cancel button made to close viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200201 (https://phabricator.wikimedia.org/T94188) [18:07:57] (03CR) 10jenkins-bot: [V: 04-1] MediaViewer cancel button made to close viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200201 (https://phabricator.wikimedia.org/T94188) (owner: 10Sumit) [18:09:44] (03PS2) 10Sumit: MediaViewer cancel button made to close viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200201 (https://phabricator.wikimedia.org/T94188) [18:10:01] (03CR) 10jenkins-bot: [V: 04-1] MediaViewer cancel button made to close viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200201 (https://phabricator.wikimedia.org/T94188) (owner: 10Sumit) [18:10:42] (03PS3) 10Sumit: MediaViewer cancel button made to close viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200201 (https://phabricator.wikimedia.org/T94188) [18:12:54] (03PS2) 10Florianschmidtwelzow: Hygiene: Don't load InfiniteScroll on _all_ pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 [18:20:42] phuedx, https://www.youtube.com/watch?v=uqH_Y1TupoQ :P [18:23:46] 10Gather: QUnit test failing (Check invalid description is evaluated) - https://phabricator.wikimedia.org/T94210#1157552 (10Florian) 3NEW [18:24:39] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200179 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [18:26:22] 10Gather, 3Gather Sprint Diplodocus: QUnit test failing (Check invalid description is evaluated) - https://phabricator.wikimedia.org/T94210#1157574 (10Jdlrobson) [18:33:08] 6Mobile-Web, 10Continuous-Integration, 7Browser-Tests, 7Tracking: Delete or fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1157590 (10Jdlrobson) I started a mail thread about this. I think we should split the big one into smaller jobs. We also need to find a... [19:01:03] bgerstle: coreyfloyd may have a really bad crash bug :( i just tried a clean install on an ios 6 device and it crashes every time. can you confirm? [19:01:23] ruh roh [19:01:26] mhurd lemme try [19:01:31] mhurd you can't debug? [19:01:48] bgerstle: in meeting [19:01:54] bgerstle: here’s the error: dyld: Symbol not found: _OBJC_CLASS_$_NSURLSessionDataTask [19:01:54] Referenced from: /var/mobile/Applications/CDC1AB4A-64F9-483D-BD7F-8C344EEC7BB9/Wikipedia.app/Wikipedia [19:01:55] Expected in: /System/Library/Frameworks/Foundation.framework/Foundation [19:01:56] in /var/mobile/Applications/CDC1AB4A-64F9-483D-BD7F-8C344EEC7BB9/Wikipedia.app/Wikipedia [19:02:03] mhurd you can pastebin or something [19:02:08] but i'll try here [19:02:15] should be easy to repro based on what you've said [19:02:41] bgerstle: https://gist.github.com/montehurd/88ae1f8ee84993ceaaaf [19:03:02] oh shit, AFNetworking might not be iOS 6 compatible..>? [19:03:13] that can't be it.. [19:03:48] mhurd: dead battery, waiting for it to change [19:03:50] charge [19:04:46] mhurd: quick fix… bgerstle is on it [19:07:33] mhurd yep [19:07:41] right at startup [19:07:49] hard to tell where it's coming from, my guess is AFN [19:08:25] (03PS5) 10MaxSem: WIP: submission [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 [19:08:35] bgerstle: stack overflow had some hits when i searched on “dyld: Symbol not found:” [19:10:43] mhurd coreyfloyd stack trace https://www.irccloud.com/pastebin/UJmZbwWP [19:10:51] IOW at link time [19:11:02] bgerstle: ooooh [19:12:43] coreyfloyd: specs: https://github.com/CocoaPods/Specs/blob/master/Specs/AFNetworking/2.5.1/AFNetworking.podspec.json [19:12:57] (03CR) 10Florianschmidtwelzow: [C: 04-1] MediaViewer cancel button made to close viewer (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200201 (https://phabricator.wikimedia.org/T94188) (owner: 10Sumit) [19:20:31] (03PS1) 10Fjalapeno: Fix iOS 6 crash - remove nsurlsession classes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200221 [19:22:04] mhurd: test please^ [19:22:51] (03PS2) 10Fjalapeno: Fix iOS 6 crash - remove nsurlsession classes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200221 [19:26:08] coreyfloyd: will do [19:27:30] mhurd coreyfloyd I FOUND IT [19:27:39] this is why +load is evil [19:30:47] coreyfloyd: building... [19:30:49] (03CR) 10Bgerstle: [C: 031] "damn you +load" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200221 (owner: 10Fjalapeno) [19:31:00] mhurd drop the hammer on that shit (when you're done w/ the meeting) [19:31:28] bgerstle: k [19:32:11] bgerstle: coreyfloyd now i get “AFNetworking/AFNetworking.h” file not found error... [19:32:15] hmm [19:32:36] mhurd: pod update? [19:32:48] mhurd: if all else fails, delete the pods directory and podfile.lock [19:32:51] coreyfloyd: i did pod install, not update… hold one [19:32:56] *hold on* [19:33:48] mhurd: https://31.media.tumblr.com/918201d3222bacfcb5d039259dc51dee/tumblr_inline_n4q30hSbSe1qa43er.gif [19:34:11] bahahaha [19:34:38] (03CR) 10Jdlrobson: [C: 031] Get rid of 'type' stuff in ResourceLoaderImageModule [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200190 (https://phabricator.wikimedia.org/T94073) (owner: 10Bartosz Dziewoński) [19:35:29] kristenlans_ mhurd bgerstle that gif is our release process documentation I have been working on. [19:36:08] loading.. [19:36:24] BRILLIANT [19:37:40] coreyfloyd: deleting pods dir and lock file [19:38:30] coreyfloyd: still no luck :( [19:38:41] mhurd: did you delete? [19:38:51] coreyfloyd: https://plus.google.com/hangouts/_/event/c5p2pudvb8s6ckluqf56v791em4 [19:39:05] bgerstle: coreyfloyd mhurd, does https://gerrit.wikimedia.org/r/#/c/200221 need to be merged and then builds re-cut? [19:39:13] dr0ptp4kt: yep [19:39:20] dr0ptp4kt: i’m testing that patch [19:39:24] mhurd: thx [19:39:30] dr0ptp4kt: i still need to look into the "editiable" issue [19:39:36] maybe we can sneak that in too [19:39:41] dr0ptp4kt: corey and i hangout tracking it down [19:39:53] bgerstle: for migrated articles, right? [19:39:59] yeah [19:40:02] i mean, it's nbd [19:40:05] the workaround is to pull-to-refresh [19:40:11] and given teh number of people editing articles at the moment... [19:41:05] bgerstle: dr0ptp4kt corey found the issue and is amending [19:41:21] mhurd what was it? [19:41:59] bgerstle: i’ll let corey explain it once he amends [19:42:03] k [19:42:44] bgerstle: umbrella header is gone, we needed to do a clean build to get the error. [19:42:51] patch being uploaded now [19:42:52] ahhh [19:42:54] mhurd: ^ [19:43:05] * bgerstle sighs [19:43:08] damnit xcode [19:43:34] (03PS3) 10Fjalapeno: Fix iOS 6 crash - remove nsurlsession classes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200221 [19:43:34] bgerstle: mhurd whenever git review concludes its now 1 minute upload process [19:43:40] whoot! [19:44:10] oh jeez [19:44:16] sorry i used the umbrella header! it's all my fault! [19:44:21] * bgerstle hides head in shame [19:44:41] dr0ptp4kt: that should do it… [19:45:20] bgerstle: i shoulda verified it on ios 6 before pushing [19:45:25] dr0ptp4kt: mhurd coreyfloyd and i think i just fixed teh "editable" problem [19:45:28] literally, one line [19:45:43] dr0ptp4kt: let's just blame it on AFNetworking [19:45:49] dr0ptp4kt: i plan to submit a PR to fix the issue [19:46:11] (to AFN) [19:46:26] coreyfloyd: bgerstle dr0ptp4kt that fixed it [19:47:16] coreyfloyd: dr0ptp4kt bgerstle ok to merge it? [19:47:28] mhurd i say go unless we want to double check [19:47:30] mhurd: no issue here [19:47:33] dr0ptp4kt: ship it [19:47:35] dr0ptp4kt: i'm also cooking up a patch for editable [19:47:38] mhurd would you be able to test? [19:47:44] should be super quick [19:47:59] bgerstle: patch for editable? [19:48:28] (03CR) 10Mhurd: [C: 032] Fix iOS 6 crash - remove nsurlsession classes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200221 (owner: 10Fjalapeno) [19:48:50] (03CR) 10Jdlrobson: [C: 032] Don't throw a plain \Exception [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200108 (owner: 10Legoktm) [19:49:16] (03PS1) 10Bgerstle: all migrated articles editable fix [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200225 [19:49:18] mhurd ^ [19:49:22] (03CR) 10Jdlrobson: [C: 032] Use User::equals() [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200109 (owner: 10Legoktm) [19:49:52] mhurd: shall i hit submit on https://gerrit.wikimedia.org/r/#/c/200221/ ? looks like it didn't merge it. sometimes one has to force it to merge [19:50:03] mhurd: did gerrit give you a dark screen warning upon your +2? [19:50:05] dr0ptp4kt: ya [19:50:10] (03Merged) 10jenkins-bot: Don't throw a plain \Exception [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200108 (owner: 10Legoktm) [19:50:11] dr0ptp4kt: yes it did [19:50:11] mhurd: ok, i'll hit the button [19:50:24] dr0ptp4kt: thx [19:50:26] (03Merged) 10jenkins-bot: Use User::equals() [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200109 (owner: 10Legoktm) [19:50:41] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Fix iOS 6 crash - remove nsurlsession classes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200221 (owner: 10Fjalapeno) [19:50:52] (03CR) 10Jdlrobson: [C: 032] Rework init script for Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199663 (https://phabricator.wikimedia.org/T93933) (owner: 10Florianschmidtwelzow) [19:51:17] bgerstle: you may want to rebase https://gerrit.wikimedia.org/r/200225 before mhurd looks at that [19:51:32] (03PS2) 10Bgerstle: all migrated articles editable fix [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200225 [19:51:35] done [19:51:41] (03CR) 10Jdlrobson: [C: 032] Don't access context in SpecialPage::__construct(), it's not set yet [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200112 (owner: 10Legoktm) [19:51:47] mhurd: ^^ [19:51:57] (03Merged) 10jenkins-bot: Rework init script for Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199663 (https://phabricator.wikimedia.org/T93933) (owner: 10Florianschmidtwelzow) [19:52:15] jdlrobson: :D ty [19:52:41] (03Merged) 10jenkins-bot: Don't access context in SpecialPage::__construct(), it's not set yet [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200112 (owner: 10Legoktm) [19:54:02] bgerstle: coreyfloyd should “Podfile.lock” always be showing up as modfied when i do git status? weren’t we not tracking that file? [19:58:14] (03CR) 10Jdlrobson: Prevent tutorial from showing if user clicks watchstar prior to load (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200077 (owner: 10Robmoen) [20:00:27] mhurd no we're tracking it [20:00:28] what's the diff? [20:00:45] it's probably because you need to do pod update or update cocoapods itself [20:01:27] (03PS2) 10Jdlrobson: Special Edit feed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 [20:02:24] (03CR) 10jenkins-bot: [V: 04-1] Special Edit feed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 (owner: 10Jdlrobson) [20:03:43] (03CR) 10Fjalapeno: [C: 031] all migrated articles editable fix [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200225 (owner: 10Bgerstle) [20:07:19] MaxSem: http://etherpad.wikimedia.org/p/Wikigrok_Q4 [20:11:21] (03CR) 10Mhurd: [C: 032] all migrated articles editable fix [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200225 (owner: 10Bgerstle) [20:13:14] http://etherpad.wikimedia.org/p/Gather_Q4 [20:20:30] 10Gather, 3Gather Sprint Diplodocus: Collections of users with special characters rendering with error - https://phabricator.wikimedia.org/T94206#1157934 (10Jhernandez) a:3Jhernandez [20:20:42] (03PS1) 10Jhernandez: Fix url schemas [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200227 (https://phabricator.wikimedia.org/T94206) [20:20:50] mhurd we lost ya [20:21:54] 10Gather: No flagging mechanism for collections - https://phabricator.wikimedia.org/T94227#1157941 (10Jdlrobson) 3NEW [20:22:47] 10Gather: No way to moderate a certain collection from the collection itself - https://phabricator.wikimedia.org/T94228#1157951 (10Jdlrobson) 3NEW [20:25:25] 10Wikipedia-App-iOS-App, 7Documentation: As a contributor, I can run a Make goal to install system dependencies. - https://phabricator.wikimedia.org/T94229#1157959 (10BGerstle-WMF) 3NEW [20:27:57] 10Gather: GatherLists needs pagination - https://phabricator.wikimedia.org/T94230#1157965 (10rmoen) 3NEW [20:31:12] 10Wikipedia-App-iOS-App, 7Documentation: As a contributor, I can run a Make goal to install system dependencies. - https://phabricator.wikimedia.org/T94229#1157973 (10BGerstle-WMF) [20:31:51] 10Wikipedia-App-iOS-App, 7Documentation: Commit web "assets" folder to to git - https://phabricator.wikimedia.org/T94231#1157975 (10BGerstle-WMF) 3NEW [20:34:01] 10Gather: Feature flag to turn off - https://phabricator.wikimedia.org/T94232#1157984 (10Jdlrobson) 3NEW [20:34:21] 10Gather: Promote Gather to stable - https://phabricator.wikimedia.org/T94233#1157992 (10Jdlrobson) 3NEW [20:34:55] 10Gather: Resolve existential of watchlist/collections - https://phabricator.wikimedia.org/T94234#1158000 (10Jdlrobson) 3NEW [20:35:30] 10Gather: Resolve existential crisis of watchlist/collections - https://phabricator.wikimedia.org/T94234#1158008 (10KLans_WMF) [20:36:35] 10Gather: Beta feature for desktop to use Gather - https://phabricator.wikimedia.org/T94235#1158011 (10Jdlrobson) 3NEW [20:37:01] 10Gather, 3Gather Sprint E: Edit and delete buttons are currently broken on desktop skins - https://phabricator.wikimedia.org/T94063#1158019 (10Jdlrobson) [20:37:54] 10Gather: Spike: Explore ways to auto generate lists for communication purposes - https://phabricator.wikimedia.org/T94236#1158020 (10Jdlrobson) 3NEW [20:40:42] 10Gather: Analytic to see measure number of lists created - https://phabricator.wikimedia.org/T94237#1158034 (10Jdlrobson) 3NEW [20:41:33] 10Gather: Analytics to see number of bad lists created - https://phabricator.wikimedia.org/T94240#1158057 (10Jdlrobson) 3NEW [20:41:44] 10Gather: Analytics to see measure number of lists created - https://phabricator.wikimedia.org/T94237#1158065 (10KLans_WMF) [20:42:59] 10Gather: Refine what success looks like - https://phabricator.wikimedia.org/T94241#1158068 (10Jdlrobson) 3NEW [20:43:24] 10Gather: Feature for user to follow a collection - https://phabricator.wikimedia.org/T94243#1158084 (10rmoen) 3NEW [20:44:19] 10Gather: Display amount of followers on a collection - https://phabricator.wikimedia.org/T94244#1158094 (10rmoen) 3NEW [20:44:22] 10Gather: Reader analytics on collections pages and user collections page - https://phabricator.wikimedia.org/T94245#1158102 (10Jhernandez) 3NEW [20:52:52] moizsyed: go to the gather hangout [20:53:08] phuedx: oh, whats up [20:53:18] you're being requested [20:53:20] phuedx: link me bro [20:53:35] moizsyed: no -- they need you in the gather room [20:56:00] 10Gather: Tags for sharing lists - https://phabricator.wikimedia.org/T94247#1158145 (10Jhernandez) 3NEW [21:00:56] 10Gather: I can collect collections - https://phabricator.wikimedia.org/T94250#1158181 (10Jdlrobson) 3NEW [21:02:25] (03PS6) 10MaxSem: WIP: submission [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 [21:03:20] 10Gather: I get a notification when the contents of a collection I have subscribed to has changed - https://phabricator.wikimedia.org/T94252#1158197 (10Jdlrobson) 3NEW [21:05:02] 10Gather: Meta tags for sharing lists - https://phabricator.wikimedia.org/T94247#1158208 (10Jdlrobson) [21:07:01] 10Gather: Ability to fork a collection - https://phabricator.wikimedia.org/T94253#1158212 (10Jdlrobson) 3NEW [21:11:24] moizsyed: hey you around? [21:11:40] mhurd: in q4 mobile web planning meeting [21:11:43] mhurd: whats up [21:12:01] moizsyed: have to time to chat for ~5 min later today? [21:12:11] mhurd: for sure, i'll come get you [21:12:23] moizsyed: vibha too if possible? [21:12:27] moizsyed: cool [21:12:44] mhurd: vibha is not around today [21:13:02] moizsyed: ah, no worry. i’m gonna run grab food real quick, but i’ll be at my desk for rest of day [21:13:39] mhurd: cool [21:14:50] 10Gather: Resolve existential crisis of watchlist/collections - https://phabricator.wikimedia.org/T94234#1158233 (10Jdlrobson) [21:19:24] 10Gather: UI for reordering collections - https://phabricator.wikimedia.org/T94255#1158249 (10Jdlrobson) 3NEW [21:21:14] 10Gather, 10MediaWiki-extensions-PageImages, 10WikiGrok: Images generated by PageImages are not positioned correctly all the time - https://phabricator.wikimedia.org/T94256#1158263 (10Jdlrobson) 3NEW [21:23:41] 10Gather: Should be possible to make a public list private. - https://phabricator.wikimedia.org/T94257#1158276 (10Jdlrobson) 3NEW [21:24:38] 10Gather: Improve language around public/private - https://phabricator.wikimedia.org/T94258#1158285 (10Jdlrobson) 3NEW [21:24:50] 10Gather: Should be possible to make a public list private. - https://phabricator.wikimedia.org/T94257#1158293 (10Jdlrobson) [21:26:56] 10Gather: Identify when a collection has been hidden - https://phabricator.wikimedia.org/T94259#1158300 (10Jdlrobson) 3NEW [21:28:06] 10Gather: Record the user who hid a list - https://phabricator.wikimedia.org/T94260#1158308 (10Jdlrobson) 3NEW [21:29:23] 10Gather: API: When a collection gets hidden record the user who did it and the reason they did it - https://phabricator.wikimedia.org/T94262#1158327 (10Jdlrobson) 3NEW [21:30:03] 10Gather: No flagging mechanism for collections - https://phabricator.wikimedia.org/T94227#1158337 (10Jdlrobson) [21:31:55] 10Gather: List last collection on profile - https://phabricator.wikimedia.org/T94263#1158346 (10Jdlrobson) 3NEW [21:33:53] 10Gather: Should be able to get to list of collections belonging to a user from their collection - https://phabricator.wikimedia.org/T94264#1158356 (10Jdlrobson) 3NEW [21:47:02] (03PS7) 10MaxSem: Submission to Wikidata [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 [21:50:56] bgerstle: coreyfloyd mhurd stuff pushed to tf for 'wikipedia beta' internal and external. tf, formal appsstore release requested for 'wikipedia mobile [21:50:57] ' [21:51:06] dr0ptp4kt: yay! [21:51:16] bgerstle: gotta go. we've been driving baby around to get her nap in, but now we're going to be going in [21:51:36] bgerstle: coreyfloyd mhurd email me in case anything funny surfaces. gotta put phone on silent [21:51:45] dr0ptp4kt: k [21:55:20] 10Gather: It should be possible to see most followed collections - https://phabricator.wikimedia.org/T94270#1158436 (10Jdlrobson) 3NEW [21:56:59] 10Gather: Spike: How could we show a page listing most visited collections - https://phabricator.wikimedia.org/T94271#1158449 (10Jdlrobson) 3NEW [21:57:33] 10Gather: Should be possible to see the most recent updated collections - https://phabricator.wikimedia.org/T94272#1158461 (10Jdlrobson) 3NEW [22:05:54] https://etherpad.wikimedia.org/p/q4planningretro [22:14:34] MaxSem: submission is not a wip? [22:14:36] \o/ [22:16:53] phuedx, now you just have to review it! ;) [22:17:39] (03CR) 10Jdlrobson: [C: 032] Fix url schemas [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200227 (https://phabricator.wikimedia.org/T94206) (owner: 10Jhernandez) [22:29:38] 10Wikipedia-App-Android-App: EGL-related crashes - https://phabricator.wikimedia.org/T74530#1158569 (10Krenair) [22:31:46] (03Merged) 10jenkins-bot: Fix url schemas [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200227 (https://phabricator.wikimedia.org/T94206) (owner: 10Jhernandez) [22:47:07] MaxSem: can you please +2 https://gerrit.wikimedia.org/r/#/c/189161/ ? [22:47:37] MaxSem: also reply to my comment at https://gerrit.wikimedia.org/r/#/c/197790/ ? [22:47:55] MaxSem: sorry, but I need your help before you leave [22:48:28] bmansurov, I honestly know nothing about language converters, so I feel comfortable only about+1 [22:48:45] MaxSem: ok, thanks. Do you know who can review that patch? [22:49:13] I've added Nikla [22:49:14] s [22:49:40] looking ad disambig stuff [22:50:21] thanks [22:56:10] (03PS1) 10Mhurd: Hide loading spinner when using back-forward. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 [22:56:20] bgerstle: coreyfloyd ^ [22:57:35] bgerstle: coreyfloyd based on meeting w nizar and feedback from moiz. crap - forgot to ref phab ticket [22:59:04] (03PS2) 10Mhurd: Hide loading spinner when using back-forward. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 [22:59:38] (03CR) 10MaxSem: "$po in onOutputPageParserOutput as well as onLinksUpdate definitely has 'disambiguation' property on pages marked with __DISAMBIG__ for me" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [23:13:07] (03CR) 10Bgerstle: "comments" (039 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [23:13:57] (03CR) 10Bgerstle: [C: 04-1] "sorry most comments are on PS1, will +1 after phab ticket added for verification and API comments are addressed" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [23:17:17] 10Wikipedia-App-Android-App, 3Roadmap, 7notice: Production release for Android Wikipedia app on 30th March 2015 - https://phabricator.wikimedia.org/T91693#1158822 (10Liuxinyu970226) [23:17:49] (03CR) 10Mhurd: "Added responses." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [23:18:13] (03CR) 10Mhurd: "Gerrrrriiiitttt!!!!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [23:18:44] bgerstle: https://plus.google.com/hangouts/_/event/c5p2pudvb8s6ckluqf56v791em4 [23:18:50] bgerstle: if you have a sec [23:19:11] is that the bat cave? [23:19:18] bgerstle: ya [23:20:09] ya gotta use the GIF, man: https://insidecroydon.files.wordpress.com/2013/10/batsignal.jpg [23:20:17] bgerstle: lol [23:23:17] (03CR) 10Mhurd: Hide loading spinner when using back-forward. (035 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [23:23:30] (03PS5) 10Bmansurov: Don't load WikiGrok on disambiguation pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) [23:23:32] (03CR) 10jenkins-bot: [V: 04-1] Don't load WikiGrok on disambiguation pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [23:24:24] (03PS6) 10Bmansurov: Don't load WikiGrok on disambiguation pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) [23:28:26] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Collections of users with special characters rendering with error - https://phabricator.wikimedia.org/T94206#1158889 (10Jdlrobson) 5Open>3Resolved Note: We might need to convince @MaxSem to cherry pick this to the deployment branch. [23:29:37] (03CR) 10MaxSem: [C: 04-1] "Also, consider not picking questions in adition to not showing them?" (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [23:37:01] mhurd just in case it's not clear, this is what i meant by "lazy getter" https://github.com/wikimedia/apps-ios-wikipedia/blob/master/wikipedia/View%20Controllers/Image%20Gallery/WMFImageGalleryViewController.m#L127 [23:37:22] MaxSem: I don't quite understand. Isn't the patch already returning early enough not to pick questions? [23:38:14] bgerstle: lol [23:38:24] questions currently in use are slow, not fast ones, and are picked on LinksUdate [23:38:33] *LinkUpdate [23:38:39] *LinksUpdate [23:41:51] cool [23:43:35] (03PS3) 10Mhurd: Hide loading spinner when using back-forward. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 [23:43:50] bgerstle: ^ [23:47:21] (03PS7) 10Bmansurov: Don't load WikiGrok on disambiguation pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) [23:49:41] 10Gather, 3Gather Sprint Diplodocus: QUnit test failing (Check invalid description is evaluated) - https://phabricator.wikimedia.org/T94210#1158927 (10Jdlrobson) a:3Jdlrobson [23:50:56] (03PS1) 10Jdlrobson: Hygiene: Fix js linting, jsdocs and qunit [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200268 (https://phabricator.wikimedia.org/T94210) [23:51:54] 10Gather, 3Gather Sprint Diplodocus, 6Mobile-Web: Blue tutorial indicator positioned incorrectly in Chrome when pointing at a transformed element e.g. green watchstar - https://phabricator.wikimedia.org/T93987#1158931 (10Jdlrobson) [23:59:23] (03CR) 10Bgerstle: "just a couple more tweaks, sorry if i confused things w/ the lazy getter" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [23:59:37] mhurd i'm gonna be prepping dinner now, so might not respond rigth away [23:59:52] at this point, if those comments are addressed i'm fine w/ teh code, but don't have time to check functionality tonight. so i'll leave it to you