[02:29:53] (03PS1) 10Deskana: Add documentation to TriggerAbuseFilterTest class. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200506 [02:30:12] (03Abandoned) 10Deskana: DO NOT MERGE - Wikidata description editing prototype [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197733 (owner: 10Deskana) [02:39:47] 10Wikipedia-App-Android-App: Put current page name in box at top, instead of just "Search", on Android Beta Wikipedia App - https://phabricator.wikimedia.org/T89694#1161289 (10Deskana) Previously, we would leave the last thing that the user searched for in the search box, even after the user navigated to a page.... [02:40:04] 10Wikipedia-App-Android-App: Find some way to indicate to the user the title of the page they're currently on - https://phabricator.wikimedia.org/T89694#1161290 (10Deskana) [03:03:49] (03CR) 10Alex Monk: [C: 031] "When merged we should update those filters' notes to point to this code, asking people not to break them." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200506 (owner: 10Deskana) [04:50:34] 6Mobile-Web: Mobile MediaViewer: Close icon behavior is inconsistent - https://phabricator.wikimedia.org/T94188#1161346 (10Sumit) 5Open>3Resolved a:3Sumit [05:54:58] 10Gather: Page not found for public collection on testwiki - https://phabricator.wikimedia.org/T94378#1161372 (10Florian) 3NEW [06:21:25] 10Gather: Page not found for public collection on testwiki - https://phabricator.wikimedia.org/T94378#1161391 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson Thanks Florian! Yeh this is a nasty one. Luckily already fixed :) T94206 [06:21:45] 10Gather: Page not found for public collection on testwiki - https://phabricator.wikimedia.org/T94378#1161396 (10Jdlrobson) Thanks Florian! Yeh this is a nasty one. Luckily already fixed :) T94206 [07:24:11] 10Gather: Page not found for public collection on testwiki - https://phabricator.wikimedia.org/T94378#1161402 (10Florian) Ah, ok, that's why i couldn't reproduce it on my local environment :P Thanks! But this should be a duplicate then, right? :D [07:24:37] 10Gather: Page not found for public collection on testwiki - https://phabricator.wikimedia.org/T94378#1161405 (10Florian) [07:24:38] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Collections of users with special characters rendering with error - https://phabricator.wikimedia.org/T94206#1161406 (10Florian) [07:45:41] (03PS1) 10Florianschmidtwelzow: Add a link to Special:GatherLists to view hidden lists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200511 [09:01:22] 6Mobile-Web, 10Wikimedia-Site-requests, 5Patch-For-Review, 3Roadmap, and 2 others: Set $wgMFAnonymousEditing = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1161547 (10Nemo_bis) >>! In T93210#1160189, @Revi wrote: > Please exclude kowiki; Per the consensus [[ https://ko.wikipedia... [09:04:42] 6Mobile-Web, 10Wikimedia-Site-requests: Set $wgMFAnonymousEditing = false for kowiki - https://phabricator.wikimedia.org/T94388#1161548 (10Revi) 3NEW [09:07:44] 6Mobile-Web, 10Wikimedia-Site-requests, 5Patch-For-Review, 3Roadmap, and 2 others: Set $wgMFEditorOptions['anonymousEditing'] = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1161558 (10Florian) [09:08:12] 6Mobile-Web, 10Wikimedia-Site-requests: Set $wgMFEditorOptions['anonymousEditing'] = false for kowiki - https://phabricator.wikimedia.org/T94388#1161560 (10Florian) [09:08:32] 6Mobile-Web, 10Wikimedia-Site-requests, 5Patch-For-Review, 3Roadmap, and 2 others: Set $wgMFEditorOptions['anonymousEditing'] = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1161563 (10Nemo_bis) Missed one question: > So i would welcome it, if we are totally sure, that we don't... [09:11:00] good morning! [09:13:41] 6Mobile-Web, 10Wikimedia-Site-requests, 5Patch-For-Review, 3Roadmap, and 2 others: Set $wgMFEditorOptions['anonymousEditing'] = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1161570 (10Florian) @Nemo_bis: The "problem" (which would require to purge page caches) was resolved with... [09:14:33] 6Mobile-Web, 10Wikimedia-Site-requests, 5Patch-For-Review, 3Roadmap, and 2 others: Set $wgMFEditorOptions['anonymousEditing'] = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1161577 (10Nemo_bis) [09:14:35] 6Mobile-Web, 10Wikimedia-Site-requests: Set $wgMFEditorOptions['anonymousEditing'] = false for kowiki - https://phabricator.wikimedia.org/T94388#1161575 (10Nemo_bis) 5Open>3stalled Thanks. It's not clear what is being voted on, please reply on the discussion: https://ko.wikipedia.org/w/index.php?title=%EC%... [09:16:18] 6Mobile-Web, 10Wikimedia-Site-requests, 5Patch-For-Review, 3Roadmap, and 2 others: Set $wgMFEditorOptions['anonymousEditing'] = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1132138 (10Nemo_bis) [09:16:32] 6Mobile-Web, 10Wikimedia-Site-requests, 5Patch-For-Review, 3Roadmap, and 2 others: Set $wgMFEditorOptions['anonymousEditing'] = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1132138 (10Nemo_bis) [09:17:56] 6Mobile-Web, 10Wikimedia-Site-requests, 5Patch-For-Review, 3Roadmap, and 2 others: Set $wgMFEditorOptions['anonymousEditing'] = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1161583 (10Nemo_bis) >>! In T93210#1161570, @Florian wrote: > @Nemo_bis: The "problem" (which would requir... [09:27:33] (03CR) 10Phuedx: [C: 04-1] "Good work. I need to test this locally but it looks as if it covers everything." (035 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 (owner: 10MaxSem) [09:37:21] 3Gather Sprint E: Rename Owner labels (i18n concerns) - https://phabricator.wikimedia.org/T94391#1161630 (10Jhernandez) 3NEW [09:44:57] 6Mobile-Web, 10WikiGrok, 10Wikidata, 10Wikidata.org: Create FAQ page for WikiGrok on wikidata.org - https://phabricator.wikimedia.org/T93972#1161654 (10Lydia_Pintscher) [10:40:53] 10Gather, 3Gather Sprint E, 6Mobile-Web: Blue tutorial indicator positioned incorrectly in Chrome when pointing at a transformed element e.g. green watchstar - https://phabricator.wikimedia.org/T93987#1161813 (10Jhernandez) [10:47:02] 3Gather Sprint Diplodocus: Provide appropriate groups or individuals with 'gather-admin' priveleges - https://phabricator.wikimedia.org/T93771#1161838 (10Jhernandez) @jkatzwmf @moushira Moving this to ready for signoff on Gather sprint E. Feel free to move to Done If you consider so. [10:47:18] 3Gather Sprint E: Provide appropriate groups or individuals with 'gather-admin' priveleges - https://phabricator.wikimedia.org/T93771#1161839 (10Jhernandez) [10:49:29] 10Gather, 3Gather Sprint E, 5Patch-For-Review: Page action tutorial should be force closed by clicking the watchstar - https://phabricator.wikimedia.org/T94113#1161844 (10Jhernandez) [10:59:42] (03PS1) 10Ricordisamoa: Let's be less Wikipedia-centric [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200526 [10:59:47] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: Add browser test for edit workflow - https://phabricator.wikimedia.org/T93949#1161908 (10Jhernandez) I'm reviewing this but I'm having trouble running the tests. Investigating... [11:09:43] (03CR) 10Aude: [C: 04-1] "see comment, and agree that more tests would be nice" (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 (owner: 10MaxSem) [11:13:39] 6Mobile-Web, 6Collaboration-Team, 10Echo, 10Flow, 7Browser-Tests: Move user agent assignment to Ruby gem - https://phabricator.wikimedia.org/T73531#1161959 (10zeljkofilipin) [11:33:30] 3Gather Sprint E: Provide appropriate groups or individuals with 'gather-admin' priveleges - https://phabricator.wikimedia.org/T93771#1162015 (10Krenair) Are you intending to only deploy this extension to the English Wikipedia...? [12:11:51] 6Mobile-Web, 6Collaboration-Team, 10Echo, 10Flow, and 2 others: Move user_agent string manipulation to the Ruby gem - https://phabricator.wikimedia.org/T678#1162059 (10zeljkofilipin) [12:16:01] (03CR) 10Phuedx: [C: 04-1] "This change breaks Special:Uploads because, apparently, the infinite scroll module is loaded before mw.mobileFrontend is defined (!?)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 (owner: 10Florianschmidtwelzow) [12:24:55] hey joakino [12:26:18] i'm here but not -- y'know [12:26:26] (haven't been called for duty yet) [12:30:04] (03CR) 10Florianschmidtwelzow: "> This change breaks Special:Uploads because, apparently, the infinite scroll module is loaded before mw.mobileFrontend is defined (!?)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 (owner: 10Florianschmidtwelzow) [12:32:27] (03PS3) 10Florianschmidtwelzow: Hygiene: Don't load InfiniteScroll on _all_ pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 [12:42:11] (03CR) 10Phuedx: "As you've noted in your FIXME comment in EditorOverlayBase#hide, not showing the confirmation to the user when they close the editor is a " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200179 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [12:44:34] (03CR) 10Phuedx: "Unfortunately, it doesn't look like the (micro-) library provisions for showing the confirmation ad-hoc." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200179 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [12:46:05] (03CR) 10Phuedx: [C: 04-1] Use mediawiki.confirmCloseWindow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200179 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [12:57:36] (03CR) 10Phuedx: [C: 04-1] "This fix looks OK – it reduces the number of sources of information in the function. However, it only fixes one half of the problem: the m" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198290 (owner: 10Yurik) [13:01:52] yo phuedx [13:01:56] just came back from the gym [13:02:03] gonna go have lunch now [13:02:06] how are you doing [13:02:22] it's been about a week and a half we havent talked anything [13:02:48] I'll find you later to catch up :D\ [13:03:11] dbrant: good morning! [13:04:12] mholloway: hey there! welcome! [13:04:24] dbrant: thanks! [13:05:37] mholloway: we can wait until more SF folks join for formal introductions ;) [13:05:57] dbrant: sounds good [13:07:01] mholloway: bgerstle_afk and coreyfloyd are iOS devs. they're out of Miami and Philly respectively, so they're here on the earlier side, too [13:07:33] bgerstle_afk: coreyfloyd: ^ Michael has just joined the Android team [13:07:57] bgerstle_afk: coreyfloyd: good morning to both of you! in ann arbor, michigan here [13:09:14] coreyfloyd: oh wait, you've hoved, haven't you? [13:09:18] *moved [13:53:38] (03PS1) 10Dbrant: [WIP] Specify assert=user when submitting an edit. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200567 (https://phabricator.wikimedia.org/T75086) [13:59:10] dbrant only slightly. Just closer to Harrisburg now. [14:00:23] (03PS1) 10Dbrant: Fix possible crash when highlighting text to share. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200570 (https://phabricator.wikimedia.org/T94311) [14:04:54] (03PS1) 10Dbrant: Fix possible crash when failing to clear shared image folder. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200571 (https://phabricator.wikimedia.org/T94185) [14:05:53] 10Wikipedia-App-Android-App, 5Patch-For-Review: Exceptions from within getExternalCacheDir call in util.ShareUtils.clearFolder - https://phabricator.wikimedia.org/T94185#1162444 (10Dbrant) a:3Dbrant [14:05:56] 6Mobile-Web, 10Continuous-Integration, 7Browser-Tests, 7Tracking: Delete or fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1162445 (10zeljkofilipin) The thread, for reference: https://lists.wikimedia.org/pipermail/qa/2015-March/002204.html [14:06:12] 10Wikipedia-App-Android-App, 5Patch-For-Review: android.content.res.Resources$NotFoundException: Unable to find resource ID #0x54e - https://phabricator.wikimedia.org/T94311#1162453 (10Dbrant) a:3Dbrant [14:06:20] 6Mobile-Web, 10Continuous-Integration, 7Browser-Tests: Fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1162454 (10zeljkofilipin) [14:06:33] welcome mdholloway! [14:07:16] 6Mobile-Web, 10Continuous-Integration, 7Browser-Tests: Fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1156443 (10zeljkofilipin) Ok, no jobs will be deleted. :) Feel fee to reach out to #Release-Engineering team if you need help. Also, I have proposed //Workshop... [14:08:07] bgerstle: thanks! [14:25:59] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android, 5Patch-For-Review: Exceptions from within getExternalCacheDir call in util.ShareUtils.clearFolder - https://phabricator.wikimedia.org/T94185#1162583 (10Dbrant) [14:26:40] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-53-Android, 5Patch-For-Review: android.content.res.Resources$NotFoundException: Unable to find resource ID #0x54e - https://phabricator.wikimedia.org/T94311#1162584 (10Dbrant) [14:29:03] dbrant: Morning! [14:30:20] dbrant: I'm just updating the "What's new" [14:39:06] dbrant: Alright, I'm done. [14:42:25] 3Gather Sprint E: Provide appropriate groups or individuals with 'gather-admin' priveleges - https://phabricator.wikimedia.org/T93771#1162628 (10Moushira) @Krenair, as a first step, yes :). [14:52:33] 3Gather Sprint E: Provide appropriate groups or individuals with 'gather-admin' priveleges - https://phabricator.wikimedia.org/T93771#1162652 (10Krenair) enwiki first? That sounds completely backwards. enwiki is usually last. What's the rationale behind that? [14:54:47] Deskana: bearND: Morning Dan! Morning Bernd! [14:55:17] mdholloway: Good morning! Welcome to the team! [14:55:26] bearND: Thank you! [14:56:27] Deskana: awesome! i see the changes you made. [14:56:42] Deskana: bearND: are we ready to pull the trigger, then? [14:57:32] * Krenair_ waves [14:59:47] mdholloway: Krenair volunteers by sorting crash reports from users into actionable bugs in our bug tracker. He's awesome. [15:00:14] Krenair_: Hey Krenair! [15:03:31] dbrant: Are you talking about the store listing? I don't see any diffs, and the screenshot updates are already live AFAICS. Looks they are already published. [15:04:06] bearND: it's the "what's new" text under the version-98 apk. [15:04:14] mdholloway: Ah, good morning! [15:04:15] dbrant: ah [15:05:34] dbrant: Yes, that looks good to me. /cc: Deskana [15:06:10] just a heads-up, i'm going to hop off as mdholloway since just got on as mholloway in a standalone IRC client [15:07:08] mholloway: I added you to our staff list: https://wikimediafoundation.org/wiki/Template:Staff_and_contractors#Apps [15:08:04] 10Wikipedia-App-iOS-App: Add iCloud KeyChain support - https://phabricator.wikimedia.org/T94415#1162697 (10dr0ptp4kt) 3NEW [15:08:12] Deskana: ship it? [15:08:14] Deskana: cool [15:08:16] SHIP IT [15:08:40] dbrant: I'm liking LimeChat [15:09:12] mholloway: good! it does the job [15:09:30] Also, I just got my invite for the HR meeting and it's from 1-2pm Eastern (conflicting with our standup). Should I see if it can be moved? [15:10:19] Hmm, probably can't be since there are three others coming onboard, looks like [15:10:24] mholloway: There will be other people in that, so it's better that you just go to it. [15:10:34] mholloway: You can miss standup today. :-) [15:10:43] Deskana: ok [15:11:07] mholloway: One of the people in that meeting with you will be a guy called Yuvi. Say hi to him! He was our first Android engineer. :-) [15:11:19] ha! [15:11:22] Deskana: Oh, nice, will do! [15:11:49] Yuvi onboarded me [15:12:00] The circle is now complete. [15:12:30] Speaking of which, I need to make sure he's awake. [15:13:28] Deskana: bearND: shipped! @_@ [15:13:36] \o/ [15:14:00] \o/ [15:14:02] (updating release pages...) [15:14:32] Is mholloway a new android engineer? [15:14:41] dbrant: Deskana: we've got several good bugfixes already merged and a few queued up. What do you say if we pushed those out soon on beta, and then sometime later on production before we merge any new features? [15:14:51] Krenair_: yes [15:14:57] yay [15:15:41] (I mean, the existing ones are cool too, but another one is good :)) [15:15:48] bearND: Works for me. [15:16:26] bearND: Now that we've got a release out, let's keep up the cadence! First Monday of every sprint, gentlemen? :-) [15:16:37] bearND: Deskana: definitely! [15:16:43] dbrant, bearND: Making the prod APK at the same time as the beta really worked out, I think. Want to keep doing that? [15:16:44] Krenair_: Yes, I am [15:17:16] Right, time to get ready to head to the office. [15:17:18] Deskana: yes. That's seems like a good idea. I think we should also build the partner apks as well [15:17:25] cc dbrant^ [15:17:43] Deskana: bearND: yep, sounds good [15:19:14] dbrant: Is https://gerrit.wikimedia.org/r/#/c/200570 ready to be merged? [15:20:29] bearND: yes; we don't really have a way of reproducing it... but I believe this will fix it. [15:20:57] dbrant: ok, was just wondering why it's not in the code review column yet [15:21:08] bearND: ah! forgot to move them [15:21:22] moved [15:28:32] 6Mobile-Web, 6Collaboration-Team, 10Echo, 10Flow, and 2 others: Move user_agent string manipulation to the Ruby gem - https://phabricator.wikimedia.org/T678#1162755 (10zeljkofilipin) [[ https://github.com/wikimedia/mediawiki-extensions-Echo/blob/master/tests/browser/features/step_definitions/common_steps.r... [15:32:13] Deskana: forgive me if i misplaced it - is there a url for regression testing for tsg? i was thinking to go through that before calling them later today [15:32:28] Deskana: that is, a document or spreadsheet, that kind of thing [15:32:39] bearND: dbrant anything like this for android? ^ [15:33:17] dr0ptp4kt: Yes, I'll send you a link to the spreadsheet they used to test Android [15:33:23] ^ [15:33:29] bearND: thx cc Deskana [15:34:30] dr0ptp4kt: There is! But my Google Drive is playing up. [15:34:53] I can probably find it from my emails. [15:35:17] dr0ptp4kt: Here's an iOS one they did a while back: https://docs.google.com/a/wikimedia.org/spreadsheets/d/110-Ikr8VEZKPYxhdtmqJ7XOZA3vgy_-yB7N_bbwIqoM/edit#gid=1509453616 [15:36:18] dr0ptp4kt: sent you the link and the PDF of the Android test results (cc: Deskana) [15:36:35] Deskana: bearND thx! [15:37:29] dbrant, bearND: So, actually, when is the date when bearND is taking over as tech lead? [15:37:37] dbrant, bearND: End of this sprint? Or... now? [15:39:03] Deskana: bearND: i think it's... now! I was just about to send an email to that effect. He's already taken the role in the Q4 meetings. [15:39:58] dbrant: great. Good to know. Thanks! [15:40:03] and isn't the sprint over anyway? [15:40:04] dbrant: Just got my IT onboarding email [15:41:42] (03CR) 10BearND: [C: 032] Fix possible crash when highlighting text to share. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200570 (https://phabricator.wikimedia.org/T94311) (owner: 10Dbrant) [15:41:51] Works for me! [15:43:18] The tech lead is dead, long live the tech lead! [15:44:17] Holy crap my internet is totally fucked. [15:44:33] I'm not even sure if I'm connected right now. [15:44:40] We can see your messages [15:44:51] Is this real life? [15:46:05] Deskana: nope, just fantasy [15:47:43] mhurd dr0ptp4kt coreyfloyd FYI i did open a PR on AFNetworking for the iOS 6 crash: https://github.com/AFNetworking/AFNetworking/pull/2621 [15:47:47] just in case you wanted to +1 :-P [15:49:29] (03Merged) 10jenkins-bot: Fix possible crash when highlighting text to share. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200570 (https://phabricator.wikimedia.org/T94311) (owner: 10Dbrant) [15:49:55] 10MobileFrontend-Feature-requests: Unclickable "Next" button as unregistered user - https://phabricator.wikimedia.org/T94419#1162842 (10Nemo_bis) 3NEW [15:50:20] 3Gather Sprint E: Provide appropriate groups or individuals with 'gather-admin' priveleges - https://phabricator.wikimedia.org/T93771#1162850 (10JKatzWMF) Its beta only and we needed sufficient traffic for testing Sent from a mobile device [15:51:22] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Document CI Project Setup - https://phabricator.wikimedia.org/T94420#1162863 (10Fjalapeno) [15:52:32] * Deskana makes a mental note to not automatically ask dbrant random questions about Android studd now [15:52:34] *stuff [15:52:56] bgerstle: good job. probably best if i don't do the review on this. lack of familiarity with the internals of the library, also have lots of administrative stuff to do today [15:53:02] 10MobileFrontend-Feature-requests: Unclickable "Next" button as unregistered user - https://phabricator.wikimedia.org/T94419#1162870 (10Florian) a:3Florian Oops, i'll take a look [15:53:13] 6Mobile-Web: Unclickable "Next" button as unregistered user - https://phabricator.wikimedia.org/T94419#1162872 (10Florian) [15:53:18] Deskana: ohh, you still may! [15:53:23] dr0ptp4kt: sorry i didn't mean "review," i meant comment w/ a thumbsup or +1 for moral support :-P [15:53:43] wasn't expect people to be able to review a change to a third-party lib [15:53:49] expecting* [15:54:37] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Configure Jenkins for iOS builds - https://phabricator.wikimedia.org/T92882#1162874 (10Fjalapeno) [15:56:43] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Import Unit Test Reports into Jenkins from Fastlane - https://phabricator.wikimedia.org/T94421#1162876 (10Fjalapeno) 3NEW [15:57:06] 3Gather Sprint E: Provide appropriate groups or individuals with 'gather-admin' priveleges - https://phabricator.wikimedia.org/T93771#1162887 (10Jdlrobson) @krenair in addition to what Jon Katz said this is no different from enabling a beta feature. I expect a different strategy when and if we plan a full release. [15:57:09] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Configure Jenkins for iOS builds - https://phabricator.wikimedia.org/T92882#1122640 (10Fjalapeno) [15:58:20] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Document CI Project Setup - https://phabricator.wikimedia.org/T94420#1162894 (10Fjalapeno) p:5Triage>3Normal [15:59:17] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Create a fastlane configuration file for iOS builds - https://phabricator.wikimedia.org/T92884#1162896 (10Fjalapeno) [15:59:54] Heading to the office, see you soon! [16:01:54] (03CR) 10BearND: [C: 04-1] Fix possible crash when failing to clear shared image folder. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200571 (https://phabricator.wikimedia.org/T94185) (owner: 10Dbrant) [16:02:29] (03CR) 10Yurik: "I am not exactly sure how you want to deal with the missin title - i could only fix something i understood :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198290 (owner: 10Yurik) [16:04:18] All right, I'm off to grab lunch and do my HR orientation, talk to y'all in a bit [16:04:47] 10MobileFrontend-Feature-requests, 10Wikidata, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1162920 (10Sumit) [16:05:10] mholloway: sounds good [16:05:15] mholloway: later! [16:05:22] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Import Unit Test Reports into Jenkins from Fastlane - https://phabricator.wikimedia.org/T94421#1162923 (10Fjalapeno) p:5Triage>3Normal [16:08:03] 10MobileFrontend-Feature-requests, 10Wikidata: Setup WikidataPageBanner extension repository on Gerrit - https://phabricator.wikimedia.org/T93127#1162931 (10Sumit) The repository for wikidata pagebanner extension has been created and initialized with extension:BoilerPlate See https://git.wikimedia.org/tree/med... [16:08:49] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Create change log for CI builds - https://phabricator.wikimedia.org/T94423#1162932 (10Fjalapeno) 3NEW [16:09:06] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Create change log for CI builds - https://phabricator.wikimedia.org/T94423#1162939 (10Fjalapeno) p:5Triage>3Normal [16:09:49] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Revamp xcode configuration for CI - https://phabricator.wikimedia.org/T92886#1162943 (10Fjalapeno) [16:10:39] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Import Unit Test Reports into Jenkins from Fastlane - https://phabricator.wikimedia.org/T94421#1162947 (10Fjalapeno) [16:11:04] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Revamp xcode configuration for CI - https://phabricator.wikimedia.org/T92886#1122697 (10Fjalapeno) [16:12:08] 10MobileFrontend-Feature-requests, 10Wikidata, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1162956 (10Sumit) [16:16:02] moushira: are you around? [16:16:19] I am dr0dtd4kt [16:16:47] err, yes..she is around dr0ptp4kt [16:18:01] moushira: i just added you to the ios user list. do you see an email at the gmail account indicating as much? [16:18:08] 6Mobile-Web, 10VisualEditor: None of the toolbar buttons work when editing using VE in mobile view - https://phabricator.wikimedia.org/T94425#1162977 (10Glaisher) 3NEW [16:18:32] moushira: it will possibly make you fill out a form upon clicking any link it sent you [16:20:55] * moushira checking [16:21:10] 6Mobile-Web, 10VisualEditor: None of the toolbar buttons work when editing using VE in mobile view - https://phabricator.wikimedia.org/T94425#1162987 (10Glaisher) Hm, the bold/italic button does work but the icons are not visible. However, I don't see any effect when the link button is pressed (which does have... [16:24:20] got it dr0ptp4kt. [16:24:43] moushira: cool, once you're through that part of the process would you please let me know here on irc? [16:24:50] moushira: then i'll click some more buttons [16:24:57] cool. [16:30:15] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Create accounts for Build server - https://phabricator.wikimedia.org/T94426#1163013 (10Fjalapeno) 3NEW [16:30:38] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-53-iOS: Create accounts for Build server - https://phabricator.wikimedia.org/T94426#1163013 (10Fjalapeno) [16:30:57] 10Gather, 3Gather Sprint E, 10Wikimedia-Extension-setup, 3Roadmap, and 2 others: Enable Extension:Gather (article lists) on English Wikipedia Mobile Beta - https://phabricator.wikimedia.org/T91341#1163023 (10Jdlrobson) [16:32:18] (03CR) 10Jdlrobson: "lol :)" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200485 (https://phabricator.wikimedia.org/T94362) (owner: 10Florianschmidtwelzow) [16:33:07] 10Gather: Gather's qunit tests are failing - https://phabricator.wikimedia.org/T94331#1163035 (10Jdlrobson) [16:34:04] 10Gather, 3Gather Sprint E: API: Incorrect result for listpages module - https://phabricator.wikimedia.org/T94124#1163042 (10Jdlrobson) [16:34:23] 3Gather Sprint Diplodocus: Provide appropriate groups or individuals with 'gather-admin' priveleges - https://phabricator.wikimedia.org/T93771#1163046 (10JKatzWMF) 5Open>3Resolved [16:34:55] 10Gather, 3Gather Sprint E: No indication that a collection is private or hidden on the list itself - https://phabricator.wikimedia.org/T93828#1163051 (10Jdlrobson) [16:35:21] 10Gather, 3Gather Sprint E: Change the "Collections" icon in left nav menu - https://phabricator.wikimedia.org/T93813#1163055 (10Jdlrobson) [16:36:11] 10Gather, 3Gather Sprint E: Login page is not showing our custom i18n messages - https://phabricator.wikimedia.org/T90684#1163059 (10Jdlrobson) [16:36:12] bearND is Michael Holloway remote or in SF? [16:36:14] jdlrobson: Good morning to San Francisco! :D [16:37:01] 10Gather: extension.json and Gather.php need to be kept in sync - https://phabricator.wikimedia.org/T91339#1163061 (10Jdlrobson) 5Open>3Invalid a:3Jdlrobson Not an issue right now. extension.json got removed due to difficulties maintaining the two. [16:37:48] jdlrobson: in order to fix https://phabricator.wikimedia.org/T94419 i want to add browser tests, so that this doesn't happen again, but i have trouble in running browser tests :/ cucumber want to load 127.0.0.1:7055 (i assume that's the default vagrant?), but i don't use vagrant and i didn't find any information how to chnage it :/ [16:38:31] FlorianSW: it should work without vagrant [16:38:39] FlorianSW: depending on what fix is needed a qunit test may be better [16:38:46] i assume the button is disabled and that's why it's not clickable? [16:39:03] so we should add unit tests under what conditions the next button is clickable [16:39:20] jdlrobson: i thought about it too, but i want to test the workflow (click on edit without login, click on next and now you should see the edit preview), and i think a browser test is better? (i added a qunit test too) [16:40:01] jdlrobson: nope, the button isn't clickable, because it has the same class as the "edit withut login" button and how we handle it :) [16:40:10] the problem is fixed already ;) [16:40:11] kristenlans: he's remote [16:40:44] 6Mobile-Web, 7I18n: Links in mobile “infobox” experimental feature are not localized - https://phabricator.wikimedia.org/T94146#1163074 (10Jdlrobson) [16:40:57] jdlrobson: but the question is more generic, too (e.g. for other browser tests :P). Isn't it possible to change the default url to run browser tests from another location? [16:41:03] dr0ptp4kt: bgerstle not sure if you already have this or not, but you should: https://github.com/chockenberry/Provisioning/releases [16:41:17] FlorianSW: you should be able to set MEDIAWIKI_URL [16:41:28] bearND: ah from CO, right? [16:41:34] FlorianSW: but i think qunit tests are better if they make sense [16:41:40] kristenlans: nope [16:41:50] jdlrobson: set already, but doesn't change the url for browser tests [16:41:54] coreyfloyd: what is it? [16:42:31] jdlrobson: ok :) (But the question of how to get my browser test setup running is interesting nonetheless :D) [16:42:45] (03PS8) 10Bmansurov: Don't load WikiGrok on disambiguation pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) [16:43:00] bearND: Panama? Transylvania? Kyoto? [16:43:04] kristenlans: he's in your time zone [16:43:08] bgerstle: quicklook [16:43:11] for provisioning [16:43:12] kristenlans: see pm [16:43:15] oh [16:43:48] dr0ptp4kt: Can you send me the provisioning file you are using to submit builds to testflight? [16:43:53] hi hi [16:44:40] hi joakino [16:44:48] FlorianSW: i'm assuming you've read https://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing/Setup_instructions#Set_up_your_computer [16:44:54] it helped me [16:44:57] hi kristenlans! [16:45:00] hi joakino [16:45:24] kristenlans: i saw your email! answer is basically yes [16:45:33] joakino cool :-) [16:45:37] can we just skip the standup today? I'm P sure not much happened friday [16:45:43] ;) [16:45:58] 6Mobile-Web: Migrate MobileFrontend templates from hogan to mustache - https://phabricator.wikimedia.org/T94086#1163106 (10Jdlrobson) Just a note: we don't **need** to do anything and we shouldn't rush into anything. Technically by using hogan we are already using mustache since hogan is a subset of mustache. M... [16:46:14] (03CR) 10Florianschmidtwelzow: [C: 04-1] Fix special page names on Special:SpecialPages (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200485 (https://phabricator.wikimedia.org/T94362) (owner: 10Florianschmidtwelzow) [16:47:26] jdlrobson: i used https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/tests/browser/README.mediawiki ok, i should check this document, too, thanks ! :) [16:48:31] (03PS1) 10Florianschmidtwelzow: Fix Next button for anonymous users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200602 (https://phabricator.wikimedia.org/T94419) [16:49:19] (03PS2) 10Florianschmidtwelzow: Fix special page names on Special:SpecialPages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200485 (https://phabricator.wikimedia.org/T94362) [16:50:58] (03CR) 10Bmansurov: Add Swipe module and use it in ImageOverlayNew (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198763 (owner: 10Florianschmidtwelzow) [16:52:29] yo [16:54:11] coreyfloyd: message received. am working on it [16:54:51] 6Mobile-Web, 7Mobile: Broken upper bar/search bar on the experimental version of mobile. - https://phabricator.wikimedia.org/T94397#1163156 (10Jdlrobson) [16:55:23] 6Mobile-Web, 7Mobile: For mobile sites change "Last edited [...] by an anonymous user" to "[...] by an unregistered user" - https://phabricator.wikimedia.org/T94316#1163158 (10Jdlrobson) [16:55:24] dr0ptp4kt: thanks - quick question are you using a wild card provisioning profile? [16:55:53] 6Mobile-Web, 10MediaWiki-General-or-Unknown, 10VisualEditor, 7Mobile: The menu items are triggered when the click goes away then is released - https://phabricator.wikimedia.org/T93522#1163160 (10Jdlrobson) [16:56:08] coreyfloyd: yes [16:59:04] (03CR) 10Florianschmidtwelzow: Add Swipe module and use it in ImageOverlayNew (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198763 (owner: 10Florianschmidtwelzow) [17:00:44] phuedx [17:00:46] standup [17:00:54] kristenlans: i'm in the hangout? [17:01:02] phued [17:01:08] I beg to differ [17:01:16] https://plus.google.com/hangouts/_/calendar/d2lraW1lZGlhLm9yZ19yMWNvaHVib3JmYjlqcWMydHA0bmwxcXMxZ0Bncm91cC5jYWxlbmRhci5nb29nbGUuY29t.abvfhue9msa07tgt4d9v4s0u1g?authuser=0 [17:01:39] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile: action=history should not redirect to Special:History for Flow boards - https://phabricator.wikimedia.org/T93491#1163193 (10Jdlrobson) [17:02:50] (03PS6) 10Florianschmidtwelzow: Add Swipe module and use it in ImageOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198763 [17:02:56] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile: action=history should not redirect to Special:History for Flow boards - https://phabricator.wikimedia.org/T93491#1163198 (10EBernhardson) We provide actions to ContentHandler::getActionOverrides() to replace the history action [17:03:59] dr0ptp4kt: I'm doing a TWN sync and am noticing several iOS strings changed the message key but not the value. I think this causes a lot of unnecessary churn for the translators, and should be avoided in the future. [17:04:26] 10MobileFrontend-Feature-requests, 5Patch-For-Review, 7notice, 7user-notice: Links to talk pages in mobile view - https://phabricator.wikimedia.org/T54165#1163204 (10Jdlrobson) [17:04:55] bearND: noted. [17:05:35] dr0ptp4kt: I think I spoke too soon. Looks like it's the same message but the translations have been updated as well. I think that should work [17:05:42] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) (owner: 10Florianschmidtwelzow) [17:05:44] * FlorianSW prays to Jenkins [17:05:48] bearND: even better [17:07:38] jdlrobson: y [17:07:40] yo [17:07:57] I'm not driving you too crazy with all the Flow bugs? :) [17:09:09] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200611 [17:09:16] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200612 [17:10:20] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile: On mobile web, discussion link at bottom of subject page links to page which incorrectly says "There are no conversations about this page" - https://phabricator.wikimedia.org/T93501#1163253 (10Jdlrobson) [17:12:12] 10Gather, 3Gather Sprint E, 5Patch-For-Review: [placeholder] Responsive design for Special:Gather (important because shares might be desktop) - https://phabricator.wikimedia.org/T91384#1163276 (10Jdlrobson) @JKatzWMF what is the action on this card? We shouldn't really have placeholders in sprint :) [17:12:59] 6Mobile-Web, 7Mobile: For mobile sites change "Last edited [...] by an anonymous user" to "[...] by an unregistered user" - https://phabricator.wikimedia.org/T94316#1163279 (10KLans_WMF) a:3kaldari [17:13:38] 3Gather Sprint E: Rename Owner labels (i18n concerns) - https://phabricator.wikimedia.org/T94391#1163282 (10Jdlrobson) What do we use for watchlist? (as right now permission model is same) We've thought about allowing collaboration on lists but that's not going to happen any time soon bit definitely on roadmap a... [17:14:00] 6Mobile-Web, 7Mobile: Broken upper bar/search bar on the experimental version of mobile. - https://phabricator.wikimedia.org/T94397#1163283 (10KLans_WMF) a:3kaldari [17:14:21] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile: On mobile web, discussion link at bottom of subject page links to page which incorrectly says "There are no conversations about this page" - https://phabricator.wikimedia.org/T93501#1163286 (10Florian) a:3Florian If i understand Mattflaschen right, the c... [17:14:52] Deskana, who was the dev. you recommended review https://www.mediawiki.org/wiki/API:Page_info_in_search_results ? [17:17:04] 6Mobile-Web, 7Mobile: For mobile sites change "Last edited [...] by an anonymous user" to "[...] by an unregistered user" - https://phabricator.wikimedia.org/T94316#1163296 (10MaxSem) 5Open>3declined "Anonymous" is an established MediaWiki terminology. [17:17:38] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile: On mobile web, discussion link at bottom of subject page links to page which incorrectly says "There are no conversations about this page" - https://phabricator.wikimedia.org/T93501#1163298 (10Jdlrobson) We wouldn't check for flow-board - we'd check for wi... [17:18:23] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile: On mobile web, discussion link at bottom of subject page links to page which incorrectly says "There are no conversations about this page" - https://phabricator.wikimedia.org/T93501#1163304 (10Jdlrobson) http://www.w3.org/Protocols/rfc1341/4_Content-Type.h... [17:19:42] jdlrobson: rmoen: JonKatz: just got the call from the tow guy, gotta run to the garage before they close [17:19:57] do you mind if I skip kickoff? [17:20:17] joakino sounds like a classic fake excuse to me ;) [17:20:32] i'd love it to be [17:20:39] joakino haha, good luck [17:20:51] 👍 thx, i'll catch up later [17:21:05] joakino, JonKatz: the dog ate my homework, do you mind if i skip? [17:21:34] phuedx lol, jury duty is probably #2 on the list [17:21:57] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile: action=history should not redirect to Special:History for Flow boards - https://phabricator.wikimedia.org/T93491#1163314 (10Jdlrobson) So how would MobileFrontend and Flow decide who gets to override it...? [17:22:15] phuedx, I have to prep for the gather kickoff in 10, but hopefully you and I can connect 10 before the Wikigrok kickoff? [17:22:37] phuedx sorry this is so rushed--it will get smoother soon [17:22:37] (03CR) 10BearND: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200611 (owner: 10BearND) [17:22:50] JonKatz: you're doing the wikigrok kickoff? [17:22:59] * phuedx wasn't sure, so no pressure [17:23:07] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200611 (owner: 10BearND) [17:23:08] yes, we moved gather for that [17:23:14] okie poke [17:23:45] yeah, ping me and kaldari when yer ready :) [17:26:18] 10Wikipedia-App-Android-App: NPE from inside savedpages.RefreshPagesHandler call in savedpages.SavedPagesFragment.refreshSelected - https://phabricator.wikimedia.org/T94435#1163322 (10Krenair) 3NEW [17:27:23] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile: On mobile web, discussion link at bottom of subject page links to page which incorrectly says "There are no conversations about this page" - https://phabricator.wikimedia.org/T93501#1163340 (10Mattflaschen) >>! In T93501#1163304, @Jdlrobson wrote: > http:/... [17:31:50] phuedx: kaldari bmansurov do you guys wanna be totally cray and do this next sprint in Phab? [17:31:56] dr0ptp4kt: i can't find the email now, but did you want to settle that MWFeedParser issue during our backlog meeting? i ask because i'd rather talk the roadmap for our data layer improvements instead [17:32:03] kristenlans: yes [17:32:06] kristenlans: you MONSTER [17:32:08] the sooner we sort that stuff out the sooner we can start working on it [17:32:16] i.e. yes [17:32:22] ROAR [17:32:36] phuedx: bmansurov kaldari ok I'll get it prepped! [17:32:49] kristenlans: thanks [17:33:22] bgerstle: legal's reaching out to the developer about the license, and let's discuss it during eng backlog. data layer should be our first item after that, i think [17:33:22] 3Gather Sprint Diplodocus, 5Patch-For-Review: Collection content spacing is too big on tablet - https://phabricator.wikimedia.org/T94070#1163372 (10Jdlrobson) 5Open>3Resolved [17:33:30] 10Gather, 3Gather Sprint Diplodocus, 5Patch-For-Review: List edit/creation validation - https://phabricator.wikimedia.org/T92779#1163381 (10Jdlrobson) 5Open>3Resolved [17:33:35] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile: On mobile web, discussion link at bottom of subject page links to page which incorrectly says "There are no conversations about this page" - https://phabricator.wikimedia.org/T93501#1163382 (10Florian) >>! In T93501#1163298, @Jdlrobson wrote: > We wouldn't... [17:33:38] Deskana: around? able to jump into the batcave? [17:33:42] dr0ptp4kt: k, shouldn't take long, right? [17:33:49] bgerstle: nah [17:33:51] dr0ptp4kt: USE THE GIF [17:34:23] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Don't load InfiniteScroll on _all_ pages (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 (owner: 10Florianschmidtwelzow) [17:34:30] dr0ptp4kt: i mean, if you want to.. [17:35:02] kkll;9;[p99999lkiki9iiiiiiiiiiiiiiikiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiik [17:35:07] (03PS1) 10Florianschmidtwelzow: Don't load mobile.talk on pages with no wikitext talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200616 (https://phabricator.wikimedia.org/T93501) [17:35:35] https://phabricator.wikimedia.org/tag/gather_sprint_e/ [17:35:41] bgerstle: :) [17:35:51] sorry, my cat is trying to participate in discussions about wikimedia mobile technologies. [17:36:54] (03PS2) 10Dbrant: Fix possible crash when failing to clear shared image folder. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200571 (https://phabricator.wikimedia.org/T94185) [17:37:31] dr0ptp4kt: Sure! Let me run back in to the room I was just in. [17:37:55] 10Gather, 3Gather Sprint E: Add members to a collection using a search interface - https://phabricator.wikimedia.org/T90991#1163396 (10Jdlrobson) [17:38:25] 10Gather, 3Gather Sprint E: Add members to a collection using a search interface - https://phabricator.wikimedia.org/T90991#1072316 (10Jdlrobson) [17:38:44] kristenlans: i cleared out the signoff column except for max's aggregation & pushing to wd stuff, which kaldari needs to figure out how to make testable [17:39:14] http://hatjitsu.wmflabs.org/21172 < rmoen [17:39:30] Maryana you're the best [17:39:37] :'( [17:39:42] awww [17:39:51] :..( [17:39:56] last signoff! *sob* [17:40:07] :....................................( [17:40:27] b'bye Maryana [17:40:38] well, i'll still be around for another 2 weeks [17:40:40] lurkin [17:40:45] :D [17:41:29] (oh, that kind of signoff) [17:41:37] (but still.... :( ) [17:42:20] Maryana: wut ? [17:43:05] (03CR) 10Florianschmidtwelzow: Hygiene: Don't load InfiniteScroll on _all_ pages (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 (owner: 10Florianschmidtwelzow) [17:43:38] mholloway: greetings, glad to see you on here [17:44:15] ewwwww https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#WMF_donation_appeal_blocked_my_viewing_of_Wikipedia.2C_with_no_option_to_dismiss [17:44:18] (03PS4) 10Florianschmidtwelzow: Hygiene: Don't load InfiniteScroll on _all_ pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 [17:44:31] Maryana, JonKatz ^^^^ [17:44:34] 10Gather, 3Gather Sprint E: Add members to a collection using a search interface - https://phabricator.wikimedia.org/T90991#1163414 (10JKatzWMF) @msyed-- done button feels overloaded here. If you're in search and want to exit it, we should consider another method? [17:45:01] thedj: oh right, i guess you don't read the staff list :) i'm headed out from wikimedia. time to go explore new stuff beyond the wiki... [17:45:10] (03PS3) 10BearND: Fix possible crash when failing to clear shared image folder. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200571 (https://phabricator.wikimedia.org/T94185) (owner: 10Dbrant) [17:45:12] :( [17:45:16] (03CR) 10BearND: [C: 032] Fix possible crash when failing to clear shared image folder. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200571 (https://phabricator.wikimedia.org/T94185) (owner: 10Dbrant) [17:45:17] tfinc: hey tomasz! just out of hr/benefits mtg [17:45:37] (03Merged) 10jenkins-bot: Fix possible crash when failing to clear shared image folder. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200571 (https://phabricator.wikimedia.org/T94185) (owner: 10Dbrant) [17:45:57] Maryana: well hope you have fun, but i'll pout a bit if you don't mind :) [17:46:11] awww. hugs! [17:46:18] i'll still be around. can't kick me out of the wiki family [17:46:29] Maryana: :(( [17:46:37] well that is good to hear. [17:47:21] MaxSem: you should ping peter coombe from fr-tech about that [17:47:23] Maryana: oops, my ":((" is realted to your leave from wmf, not, that you're still around, that's great! [17:47:24] 10Gather, 3Gather Sprint E: Add members to a collection using a search interface - https://phabricator.wikimedia.org/T90991#1163430 (10JKatzWMF) @mysed @jdlrobson--I think the acceptance criteria clarify that when you click on an overlay that is what closes search. Or hitting back button. [17:47:32] haha FlorianSW :) [17:47:34] i got it [17:48:17] place for misunderstandings :P [17:48:24] Maryana: so whereto ? still SF ? [17:48:33] still figuring it out.. [17:48:35] mholloway: Great. Has dbrant shared the onboarding etherpad with you? [17:48:41] but yeah, somewhere local [17:48:49] bearND: yep, got it [17:49:19] Maryana: ok. well thank u at least, and hope to still see u around once in a while after the coming 2 weeks :) [17:49:29] (03CR) 10Bmansurov: [C: 032] Fix Next button for anonymous users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200602 (https://phabricator.wikimedia.org/T94419) (owner: 10Florianschmidtwelzow) [17:49:44] 10MobileFrontend-Feature-requests, 7Tracking: [Tracking] Obstacles to enable anonymous editing for MobileFrontend users - https://phabricator.wikimedia.org/T55069#1163444 (10bmansurov) [17:49:45] mholloway: feel free to mark off the items there that he's already covered with you and you feel comfortable with. Let me know how I can help. [17:49:45] 6Mobile-Web, 5Patch-For-Review: Unclickable "Next" button as unregistered user - https://phabricator.wikimedia.org/T94419#1163442 (10bmansurov) 5Open>3Resolved [17:49:56] thedj: for sure! and thanks to you, too, for all the good bug reports/discussions/debates :) [17:50:09] dr0ptp4kt: https://gerrit.wikimedia.org/r/#/c/200612 looks good. ok if i merge? [17:50:16] dr0ptp4kt: translations update [17:50:21] MaxSem: can we cherry pick this to wmf23? https://gerrit.wikimedia.org/r/#/c/200602/ [17:50:24] bearND: will do [17:50:28] mhurd: ship it, ship it, ship it, ship it [17:50:36] dr0ptp4kt: haha will do [17:50:45] (03CR) 10Mhurd: [C: 032] Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200612 (owner: 10BearND) [17:50:47] (03PS1) 10Florianschmidtwelzow: Fix Next button for anonymous users [extensions/MobileFrontend] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/200621 (https://phabricator.wikimedia.org/T94419) [17:50:55] dr0ptp4kt: done [17:50:57] (03Merged) 10jenkins-bot: Fix Next button for anonymous users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200602 (https://phabricator.wikimedia.org/T94419) (owner: 10Florianschmidtwelzow) [17:51:00] FlorianSW, yep, can nominate it for SWAT once it's reviewed [17:51:32] mhurd: thx [17:51:33] MaxSem: it's reviewed and cherry picked ^ (is there no mobile-window today?) [17:51:39] mholloway: hello! [17:51:55] ah yep - just not merged yet:) [17:51:58] dr0ptp4kt: hi! [17:52:34] MaxSem: yep, i'm too fast :D If you want: i can plan the swat on wikitech, if you're the responsible for it? :) [17:52:51] mholloway: great, your in good hands with dbrant [17:52:57] 10Gather, 3Gather Sprint E, 5Patch-For-Review: Responsive design for tiling Special:Gather list of collections - https://phabricator.wikimedia.org/T91384#1163465 (10Jdlrobson) [17:53:23] mholloway: lemme know if you need a hand with anything on the ios stuff. sounds like you and dbrant have already been powering through android stuff! [17:53:38] 10Gather, 3Gather Sprint E: Proper collection sharing format/content - https://phabricator.wikimedia.org/T91696#1163469 (10Jdlrobson) Take a look at microformats.org [17:53:46] mholloway: sometimes it's nice to use xcode for comparison of builds and whatnot. [17:54:23] (03CR) 10Bmansurov: Hygiene: Don't load InfiniteScroll on _all_ pages (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 (owner: 10Florianschmidtwelzow) [17:54:29] dr0ptp4kt: will do, thanks! yes, i'm nearly set up on the android stuff except for getting my gerrit login in order [17:54:37] 10Gather, 3Gather Sprint E: Change the "Collections" icon in left nav menu - https://phabricator.wikimedia.org/T93813#1163473 (10JKatzWMF) a:5JKatzWMF>3None [17:54:56] mholloway: excellent. happy coding :) [17:54:58] dr0ptp4kt: i haven't used xcode too much, so i know who to come to! [17:55:11] btw. web folks, i've considering changing the way the output for content headers. I'm guessing that will throw stuff into a fit for MF ? [17:55:42] wow, that's hardly English.... [17:56:11] 10Gather, 3Gather Sprint E, 5Patch-For-Review: Responsive design for tiling Special:Gather list of collections - https://phabricator.wikimedia.org/T91384#1163481 (10Jdlrobson) [17:56:12] btw. web folks, i'm considering changing the output for headers in content. I'm guessing that will throw stuff into a fit for MF ? [17:56:53] (03PS2) 10MaxSem: Fix Next button for anonymous users [extensions/MobileFrontend] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/200621 (https://phabricator.wikimedia.org/T94419) (owner: 10Florianschmidtwelzow) [17:57:13] FlorianSW, wmf23 only? ^^^ [17:57:56] MaxSem: anonymous editing is activated on itwiki only, and will be activated to all wikis with wmf23 deploy. I'm not sure, if we need to cherry pick it to wmf22, too? [17:58:06] thedj: probably -- we should make a task to investigate and cc you in [17:58:20] 10Gather, 3Gather Sprint E: Change the "Collections" icon in left nav menu - https://phabricator.wikimedia.org/T93813#1146710 (10Jdlrobson) [17:58:22] moushira: available? [17:58:41] dr0ptp4kt in a meeting, 20 min? [17:59:03] phuedx: prolly parsoid will also go bust on it, so it's gonna be a big change. i'll add some subtasks for the various projects. [17:59:16] thedj: ta :) [17:59:31] thedj: why the change? [17:59:59] because there is stuff inside , and it's causing too much issues for accessibility etc. [18:00:00] coreyfloyd: able to make it so that itunes connect will show the beta as 'wikipedia beta'? the drawing canvas background helps to distinguish it for people in itc, but the name of the app should be different. looks like an automated push overwrote the name [18:00:12] mholloway: welcome! [18:00:23] so instead the idea is to go with an inline h# inside of a header block, that can then contain buttons etc. [18:00:27] kristenlans: thank you! [18:00:40] 10Gather, 3Gather Sprint E: Log events on 'add by search' interface for Gather - https://phabricator.wikimedia.org/T94439#1163497 (10JKatzWMF) 3NEW [18:00:43] dr0ptp4kt: yeah will be able to do that… [18:01:11] it's one of our oldest bug reports, and we always shied away due to the parser cache poisoning. [18:01:22] coreyfloyd: cool. looks like the interface is saying the beta entitlement will be needed as well. i thought that was just built in these days, but maybe something has to be configured specially in fastlane [18:01:40] it's like chrome parts inside content, always a bit tricky. [18:01:50] thedj: :/ -- that makes sense [18:01:53] bleh [18:03:08] coreyfloyd: i just updated it manually in itc [18:03:28] 10Gather: Make Special:GatherList responsive - https://phabricator.wikimedia.org/T93389#1163521 (10Jdlrobson) [18:03:34] 6Mobile-Web, 7Mobile: For mobile sites change "Last edited [...] by an anonymous user" to "[...] by an unregistered user" - https://phabricator.wikimedia.org/T94316#1163531 (10Fixuture) >>! In T94316#1163296, @MaxSem wrote: > "Anonymous" is an established MediaWiki terminology. Well if it's faulty and/or misg... [18:03:53] 3Gather Sprint E, 6Mobile-Web: Log events on 'add by search' interface for Gather - https://phabricator.wikimedia.org/T94439#1163534 (10Jdlrobson) [18:03:55] (03CR) 10Bmansurov: [C: 032] Hygiene: Don't load InfiniteScroll on _all_ pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 (owner: 10Florianschmidtwelzow) [18:04:06] 10Gather, 3Gather Sprint E: Log events on 'add by search' interface for Gather - https://phabricator.wikimedia.org/T94439#1163497 (10Jdlrobson) [18:04:50] coreyfloyd: i think it may take a while for the system to reflect that in the 'my apps' section. all of the screens are now saying 'wikipedia beta', but not the 'my apps' screen just yet [18:05:36] dr0ptp4kt: yeah I am not sure - I'm still jiggling with some handles… so once I get some things figured out I can take a look. [18:06:02] 6Mobile-Web, 7Mobile: For mobile sites change "Last edited [...] by an anonymous user" to "[...] by an unregistered user" - https://phabricator.wikimedia.org/T94316#1163547 (10MaxSem) Then start a general discussion for MediaWiki, please. We don't want to deviate from the general conventions. [18:06:11] ..and dr0ptp4kt I just got the invitation to test the WP beta in testflight [18:06:54] dr0ptp4kt: where did you enter "Wikipedia Mobile" in the xcode project? [18:07:05] moushira: good [18:07:10] Maryana, JonKatz: what should be the edit summary for WG submissions? currently, it's "[[Project:WikiGrok|WikiGrok]] submission" but what do you think? [18:07:37] 10Gather, 3Gather Sprint E: Log events on 'add by search' interface for Gather - https://phabricator.wikimedia.org/T94439#1163563 (10JKatzWMF) [18:07:42] MaxSem: seems good to me [18:08:32] coreyfloyd: i didn't enter that in xcode. it's in the 'name' field in itc as i recall [18:08:48] 10Gather, 3Gather Sprint E: Log events on 'watchstar' across mobile skin. - https://phabricator.wikimedia.org/T94439#1163567 (10Jdlrobson) [18:08:49] coreyfloyd: that's not to say data of that nature was never entered into xcode somewhere [18:08:52] dr0ptp4kt: ok good, thats what i needed to know [18:08:55] 10Gather, 3Gather Sprint E, 6Mobile-Web: Log events on 'watchstar' across mobile skin. - https://phabricator.wikimedia.org/T94439#1163497 (10Jdlrobson) [18:08:59] coreyfloyd: cool [18:09:07] 10Gather, 3Gather Sprint E, 6Mobile-Web: Log events on 'watchstar' across mobile skin. - https://phabricator.wikimedia.org/T94439#1163497 (10Jdlrobson) [18:10:15] moushira: i just invited you for the one called 'wikipedia mobile' as well. 'wikipedia mobile' is the one for doing upgrade testing. [18:10:47] awesome dr0ptp4kt [18:11:38] moushira: for upgrade testing, you (1) install the official 'wikipedia mobile' from the app store, (2) browse and save a bunch of articles with that official 'wikipedia mobile', then (3) use testflight to install its 'wikipedia mobile' atop the store version. when it starts up it should show that it's doing a data migration, and with any luck your saved pages will be fully migrated (even for offline), with recents also migrated (but just [18:11:39] article titles...you will have to be online to get to the actual content) [18:12:15] 10Gather, 3Gather Sprint E, 6Mobile-Web: Log events on 'watchstar' across mobile skin. - https://phabricator.wikimedia.org/T94439#1163578 (10Jdlrobson) [18:13:41] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Don't load InfiniteScroll on _all_ pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 (owner: 10Florianschmidtwelzow) [18:13:51] 10Gather, 3Gather Sprint E: Pagination of all the things - https://phabricator.wikimedia.org/T93426#1163592 (10Jdlrobson) [18:15:24] 10Gather, 3Gather Sprint E: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1163611 (10Jdlrobson) We can use js for this [18:15:35] 10Gather, 3Gather Sprint E: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1163613 (10Jdlrobson) [18:16:10] OK dr0ptp4kt..lets see how this works :) [18:17:45] (03CR) 10Bmansurov: [C: 04-1] Add Swipe module and use it in ImageOverlayNew (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198763 (owner: 10Florianschmidtwelzow) [18:18:16] 3Gather Sprint E: More design tweaks to collections content overlay - https://phabricator.wikimedia.org/T93424#1163649 (10Jdlrobson) @msyed can you add a mock to show what these should look like. [18:19:32] 10Gather, 3Gather Sprint E: user who creates a new collection is shown an overlay showing them to click on the hamburger menu to visit their collections. - https://phabricator.wikimedia.org/T93628#1163666 (10JKatzWMF) [18:19:41] 10Gather, 3Gather Sprint E: user who creates a new collection is shown an overlay showing them to click on the hamburger menu to visit their collections. - https://phabricator.wikimedia.org/T93628#1142280 (10JKatzWMF) @msyed need a mock here [18:20:06] 10Gather, 3Gather Sprint E: No indication that a collection is private or hidden on the list itself - https://phabricator.wikimedia.org/T93828#1163673 (10Jdlrobson) a:3MSyed @msyed to provide mock [18:20:25] 3Gather Sprint E: More design tweaks to collections content overlay - https://phabricator.wikimedia.org/T93424#1163676 (10Jdlrobson) a:3MSyed @msyed to provide mock [18:21:31] 10Gather, 3Gather Sprint E: user who creates a new collection is shown an overlay showing them to click on the hamburger menu to visit their collections. - https://phabricator.wikimedia.org/T93628#1163689 (10Jdlrobson) [18:21:50] 10Gather, 3Gather Sprint E: user who creates a new collection is shown an overlay showing them to click on the hamburger menu to visit their collections. - https://phabricator.wikimedia.org/T93628#1142280 (10Jdlrobson) [18:21:51] kristenlans: I got pinged about a change to this Trello card, but I don’t see the change on the card: https://trello.com/c/5ribM3mq/251-1-link-to-a-wikigrok-help-page-from-wikigrok-edit-summaries [18:22:45] kristenlans: oh, nevermind, it was the Phab ticket [18:22:57] kaldari: you'll seeeeee.... [18:23:11] 10Gather, 3Gather Sprint E: user who creates a new collection is shown an overlay showing them to click on the hamburger menu to visit their collections. - https://phabricator.wikimedia.org/T93628#1142280 (10Jdlrobson) [18:27:01] dbrant: I'm all set up and ready for bug suggestions! [18:27:15] moushira: FYI, that meeting invite you just sent me is for a meeting over 24 hours long :-p [18:27:16] dr0ptp4kt: batcave? [18:27:25] (03CR) 10Bmansurov: [C: 031] Don't load mobile.talk on pages with no wikitext talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200616 (https://phabricator.wikimedia.org/T93501) (owner: 10Florianschmidtwelzow) [18:27:33] mhurd: for a minute or two, i can, here i go [18:27:36] mholloway: awesome! what's your gerrit username? (i'll add you to the relevant groups) [18:28:05] dbrant: it's Mholloway [18:30:09] dr0ptp4kt, bearND: Sorry for the last minute notice, but Kristen has a conflict for this meeting that's starting... now. I think we'll have to reschedule. [18:30:16] dr0ptp4kt, bearND: It seems she got left off the invite. :-( [18:30:32] kristenlans: I did a couple last-minute technical sign-offs [18:30:39] Deskana..yes, just sending a note to self, never send an invitation while actually being in another meeting. will edit :) [18:30:41] mhurd: hey monte! [18:31:14] Deskana: ok [18:31:19] kristenlans: ^ [18:31:56] kaldari awesome, thanks! [18:32:06] mholloway: heya! congrats on joining the team! very exciting :) [18:33:13] mhurd: thanks, i'm super stoked! [18:33:30] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile, 5Patch-For-Review: On mobile web, discussion link at bottom of subject page links to page which incorrectly says "There are no conversations about this page" - https://phabricator.wikimedia.org/T93501#1163811 (10Jdlrobson) Sorry for confusion @Mattflasch... [18:34:52] (03CR) 10Jdlrobson: [C: 032] Don't load mobile.talk on pages with no wikitext talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200616 (https://phabricator.wikimedia.org/T93501) (owner: 10Florianschmidtwelzow) [18:36:51] dr0ptp4kt: should we use different bundle identifiers for alpha and beta builds? (Meaning internal daily builds vs. the external weekly drops?) [18:37:26] dr0ptp4kt: I think so, because we want to show 2 differerent apps in testflight right? Alpha, Beta, and Wikipedia Mobile? [18:37:28] https://phabricator.wikimedia.org/tag/mobile-web-sprint-44-r/ [18:37:33] 3 i mean [18:37:39] dr0ptp4kt, bearND: Invite updated. [18:38:23] coreyfloyd: i think that makes sense. so you'd want to go create a separate itc record for that alpha build [18:38:43] dr0ptp4kt: ok will do… [18:38:46] coreyfloyd: cool [18:39:43] (03CR) 10Jdlrobson: [C: 04-1] "-1ing for attention" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200077 (owner: 10Robmoen) [18:45:44] (03PS8) 10Jdlrobson: Hygiene: Remove dependency on mobile.templates where hogan is used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [18:45:51] 10Wikipedia-App-Android-App, 5Patch-For-Review: Search bar translucency when scrolling over lead image causes animation lag on some devices? - https://phabricator.wikimedia.org/T91180#1163884 (10Dbrant) 5Open>3Resolved a:3Dbrant [18:46:28] (03Merged) 10jenkins-bot: Don't load mobile.talk on pages with no wikitext talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200616 (https://phabricator.wikimedia.org/T93501) (owner: 10Florianschmidtwelzow) [18:46:42] https://trello.com/c/D02xkWyA/254-2-mobile-menu-improvements-alpha [18:46:45] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android: Some buttons are barely visible in the Toolbar on Android 4.4.4 - https://phabricator.wikimedia.org/T92510#1163896 (10Dbrant) 5Open>3Resolved [18:47:25] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android, 5Patch-For-Review: Improve app icon to make it more material designesque - https://phabricator.wikimedia.org/T90809#1163898 (10Dbrant) 5Open>3Resolved [18:47:27] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove dependency on mobile.templates where hogan is used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [18:48:03] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android, 5Patch-For-Review: ArrayIndexOutOfBoundsException crashes from android.view.MotionEvent.getX/android.view.MotionEvent.getY - https://phabricator.wikimedia.org/T88904#1163910 (10Dbrant) 5Open>3Resolved [18:49:06] 10Wikipedia-App-Android-App, 3Mobile App Sprint 52 - Android, 5Patch-For-Review: Standardise the way the text is layed out in share cards on Android - https://phabricator.wikimedia.org/T91721#1163921 (10Dbrant) 5Open>3Resolved [18:50:59] http://hatjitsu.wmflabs.org/87298 [18:51:24] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile, 5Patch-For-Review: On mobile web, discussion link at bottom of subject page links to page which incorrectly says "There are no conversations about this page" - https://phabricator.wikimedia.org/T93501#1163938 (10Jdlrobson) Should be possible to test this... [18:54:22] (03PS9) 10Jdlrobson: Hygiene: Remove dependency on mobile.templates where hogan is used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [18:54:38] http://hatjitsu.wmflabs.org/87298 [18:56:40] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: QUnit test failing (Check invalid description is evaluated) - https://phabricator.wikimedia.org/T94210#1164005 (10Jdlrobson) [18:56:54] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Add browser test for edit workflow - https://phabricator.wikimedia.org/T93949#1164008 (10Jdlrobson) [18:57:29] 10Gather, 3Gather Sprint Enwiki, 6Mobile-Web: Blue tutorial indicator positioned incorrectly in Chrome when pointing at a transformed element e.g. green watchstar - https://phabricator.wikimedia.org/T93987#1164017 (10Jdlrobson) a:5rmoen>3None [18:57:31] (03PS2) 10Legoktm: Hygiene: Fix js linting, jsdocs and qunit [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200268 (https://phabricator.wikimedia.org/T94210) (owner: 10Jdlrobson) [18:57:50] 10Gather, 3Gather Sprint Enwiki: Edit and delete buttons are currently broken on desktop skins - https://phabricator.wikimedia.org/T94063#1164022 (10Jdlrobson) a:5Jdlrobson>3None [18:59:26] 10Wikipedia-App-Android-App: NPE from data.ContentPersister.upsert - https://phabricator.wikimedia.org/T70895#1164029 (10Dbrant) 5Open>3Resolved a:3Dbrant fixed by https://gerrit.wikimedia.org/r/192453 [19:02:38] (03CR) 10Jdlrobson: [C: 032] Fix special page names on Special:SpecialPages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200485 (https://phabricator.wikimedia.org/T94362) (owner: 10Florianschmidtwelzow) [19:04:23] (03CR) 10Bmansurov: [C: 04-1] "Names should be arranged alphabetically." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200485 (https://phabricator.wikimedia.org/T94362) (owner: 10Florianschmidtwelzow) [19:04:30] (03CR) 10Legoktm: [C: 032] "\o/ will make qunit voting" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200268 (https://phabricator.wikimedia.org/T94210) (owner: 10Jdlrobson) [19:04:36] (03CR) 10Jdlrobson: [C: 04-1] "Seems to be breaking my wiki?" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200511 (owner: 10Florianschmidtwelzow) [19:05:35] (03Merged) 10jenkins-bot: Fix special page names on Special:SpecialPages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200485 (https://phabricator.wikimedia.org/T94362) (owner: 10Florianschmidtwelzow) [19:06:45] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 (owner: 10Florianschmidtwelzow) [19:10:45] (03Merged) 10jenkins-bot: Hygiene: Fix js linting, jsdocs and qunit [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200268 (https://phabricator.wikimedia.org/T94210) (owner: 10Jdlrobson) [19:12:25] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: QUnit test failing (Check invalid description is evaluated) - https://phabricator.wikimedia.org/T94210#1164073 (10Legoktm) 5Open>3Resolved qunit is now voting \o/ [19:20:41] 6Mobile-Web, 10Wikimedia-Site-requests, 5Patch-For-Review, 3Roadmap, and 2 others: Set $wgMFEditorOptions['anonymousEditing'] = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1164119 (10JKatzWMF) Hi Everyone--I apologize for the delayed response. It took me some time to get up to... [19:23:48] https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0AqEdtQuSLdAxdGF0Unlob2MtRmZTeU4tODJXbk9rQ1E&usp=drive_web#gid=0 [19:25:45] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Tracking: Flow issues on mobile web (tracking) - https://phabricator.wikimedia.org/T93430#1164160 (10Florian) [19:25:46] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile, 5Patch-For-Review: On mobile web, discussion link at bottom of subject page links to page which incorrectly says "There are no conversations about this page" - https://phabricator.wikimedia.org/T93501#1164158 (10Florian) 5Open>3Resolved >>! In T93501... [19:30:26] (03PS1) 10Florianschmidtwelzow: Hygiene: Fix false comment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200650 [19:31:51] (03CR) 10Florianschmidtwelzow: "hmm, works for me (mw-core, MF and Gather on master (Gather with this change ahead)). Can you set wgShowExceptionDetails to true in your L" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200511 (owner: 10Florianschmidtwelzow) [19:33:06] (03CR) 10Bmansurov: [C: 032] Hygiene: Fix false comment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200650 (owner: 10Florianschmidtwelzow) [19:33:28] (03CR) 10Bmansurov: Hygiene: Don't load InfiniteScroll on _all_ pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 (owner: 10Florianschmidtwelzow) [19:33:35] (03CR) 10Bmansurov: [C: 032] Hygiene: Don't load InfiniteScroll on _all_ pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 (owner: 10Florianschmidtwelzow) [19:34:25] bmansurov: https://gerrit.wikimedia.org/r/#/c/200485/2 your comment: Do we have a guideline for that? :) [19:35:05] FlorianSW: no, isn't it easy to read a list of strings when it's ordered alphabetically? [19:35:37] bmansurov: sure, i'm working on a follow up, was just wondering if i missed something :D [19:35:55] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Fix false comment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200650 (owner: 10Florianschmidtwelzow) [19:36:06] FlorianSW: maybe there is a rule somewhere, but I'd ask the gather team before creating a follow up patch. [19:36:49] phuedx http://etherpad.wikimedia.org/p/Wikigrok_Q4 [19:36:49] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Don't load InfiniteScroll on _all_ pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 (owner: 10Florianschmidtwelzow) [19:36:51] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200650 (owner: 10Florianschmidtwelzow) [19:37:09] bmansurov: i'll ask on the task :) (It seems jenkins doesn't like you? :P) [19:37:24] FlorianSW: well, I don't like it either [19:38:08] 10Gather, 5Patch-For-Review: Missing label text for Gather special pages - https://phabricator.wikimedia.org/T94362#1164209 (10Florian) @Jdlrobson, @JHernandez: What do you think about @bmansurov's comment on https://gerrit.wikimedia.org/r/#/c/200485/ ? > Names should be arranged alphabetically. [19:38:15] bmansurov: :D true love :P [19:38:22] lol [19:39:02] JonKatz, jdlrobson - I am not able to edit it.m.wikipedia anonymously [19:39:08] tapping "Save" doesn't do anything [19:39:09] FlorianSW: I know why I say it. It's because my name is usually at the top this way haha [19:39:13] mhurd dr0ptp4kt coreyfloyd going for a quick walk, brb [19:39:26] bmansurov: lol, that' [19:39:26] bgerstle_afk: thx [19:39:33] that's right :D [19:39:50] bmansurov: want to try again? https://gerrit.wikimedia.org/r/#/c/200650/ :D [19:40:05] (03CR) 10Bmansurov: Hygiene: Fix false comment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200650 (owner: 10Florianschmidtwelzow) [19:40:09] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 (owner: 10Florianschmidtwelzow) [19:40:11] (03CR) 10Bmansurov: [C: 032] Hygiene: Fix false comment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200650 (owner: 10Florianschmidtwelzow) [19:40:26] lunch [19:40:28] * FlorianSW prays to Jenkins (second time today) [19:40:35] bon apetit bmansurov [19:40:44] ta [19:41:22] jdlrobson, hi, have you had a chance to merge that patch? anomie seems busy to merge, but i addressed his and legoktm objections [19:42:15] lunch [19:42:34] rmoen, lunch is important ) [19:42:36] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Fix false comment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200650 (owner: 10Florianschmidtwelzow) [19:43:04] yurik: i agree [19:47:34] (03CR) 10Florianschmidtwelzow: [C: 032] "try #2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200650 (owner: 10Florianschmidtwelzow) [19:49:19] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Fix false comment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200650 (owner: 10Florianschmidtwelzow) [19:51:27] MaxSem: do you plan the swat on wikitech? *wondering* [19:55:13] ... oh, it's fixed in master. So I can edit from mobile anonymously. [19:55:53] (03CR) 10Jdlrobson: "Turns out it was an issue with templates." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200511 (owner: 10Florianschmidtwelzow) [19:56:39] (03CR) 10Jdlrobson: [C: 032] Implemented length limitation for label & desc [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199784 (https://phabricator.wikimedia.org/T92779) (owner: 10Yurik) [19:56:56] jdlrobson, thx, can you review the other one pls too ) [19:57:44] (03CR) 10Legoktm: [C: 032] Hygiene: Fix false comment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200650 (owner: 10Florianschmidtwelzow) [19:58:28] FlorianSW: fixed the CI issue (see -releng), so re +2'd ^' [19:58:49] (03CR) 10Jdlrobson: [C: 031] "Can we split this out into multiple patchsets per bug fix rather than dump the changes into one big commit? I want to make it easier to ro" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (owner: 10Yurik) [19:58:50] legoktm: ah, great, thanks :) [19:59:26] (03Merged) 10jenkins-bot: Implemented length limitation for label & desc [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199784 (https://phabricator.wikimedia.org/T92779) (owner: 10Yurik) [19:59:26] jdlrobson, would be too hard [19:59:28] (03Merged) 10jenkins-bot: Hygiene: Fix false comment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200650 (owner: 10Florianschmidtwelzow) [20:01:24] 10Gather, 3Gather Sprint Enwiki: Proper collection sharing format/content - https://phabricator.wikimedia.org/T91696#1164344 (10Jdlrobson) a:3Jdlrobson [20:02:59] FlorianSW, yep - we list it in the swat list [20:03:44] MaxSem: hmm? which swat list? [20:04:01] FlorianSW: https://wikitech.wikimedia.org/wiki/Deployments [20:04:22] in https://wikitech.wikimedia.org/wiki/Deployments - don't worry, I'll do it myself now [20:04:42] legoktm: yeah, but it's missing there (i already know this list :P), i think i misunderstad something here :( [20:05:02] MaxSem: i don't want to interrupt your workflow :) [20:14:47] MaxSem, deploying? [20:14:53] just curious ) [20:23:20] nowwwpe [20:23:49] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 (owner: 10Florianschmidtwelzow) [20:23:55] (03CR) 10Bmansurov: [C: 032] Hygiene: Don't load InfiniteScroll on _all_ pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 (owner: 10Florianschmidtwelzow) [20:26:14] (03Merged) 10jenkins-bot: Hygiene: Don't load InfiniteScroll on _all_ pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200199 (owner: 10Florianschmidtwelzow) [20:37:27] (03PS1) 10Bmansurov: Don't log page-impression or widget-impression [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200731 (https://phabricator.wikimedia.org/T94443) [20:38:15] (03CR) 10MaxSem: Submission to Wikidata (034 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 (owner: 10MaxSem) [20:38:42] (03PS8) 10MaxSem: Submission to Wikidata [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 [20:42:54] 6Mobile-Web, 10Wikimedia-Site-requests, 5Patch-For-Review, 3Roadmap, and 2 others: Set $wgMFEditorOptions['anonymousEditing'] = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1164582 (10Amire80) >>! In T93210#1164119, @JKatzWMF wrote: > @amire80, any ideas around testing this for... [20:46:45] 10Wikipedia-App-Android-App, 7Easy: the languages list shows the languages in a suboptimal way - https://phabricator.wikimedia.org/T68917#1164648 (10Mholloway) a:3Mholloway [20:48:51] 10Wikipedia-App-Android-App, 7Easy: the languages list shows the languages in a suboptimal way - https://phabricator.wikimedia.org/T68917#1164657 (10Mholloway) Whoops, I didn't mean to change the Security here... [20:50:28] mholloway: lol don't worry about changing security; it's just something that Phabricator says for everything. [20:53:37] jdlrobson, i will merge https://gerrit.wikimedia.org/r/#/c/199510/ than - splitting it into patches is a massive pain [20:56:13] (03PS2) 10BearND: Add documentation to TriggerAbuseFilterTest class. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200506 (owner: 10Deskana) [20:56:40] (03CR) 10BearND: [C: 032] Add documentation to TriggerAbuseFilterTest class. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200506 (owner: 10Deskana) [20:59:03] (03Merged) 10jenkins-bot: Add documentation to TriggerAbuseFilterTest class. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200506 (owner: 10Deskana) [21:03:39] Deskana aka "DANDROID" [21:03:48] ar you ready to bug out? [21:03:53] kristenlans: I'm coming! [21:04:00] kristenlans: Toby meeting. [21:04:35] (03CR) 10Yurik: [C: 032] lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (owner: 10Yurik) [21:07:07] (03Merged) 10jenkins-bot: lstprop=owner and a few bug fixes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199510 (owner: 10Yurik)