[16:57:02] so we have 2 approaches - 1) switch all background images to image tags (benefits: user can select one of those images to share) [16:57:14] or 2) add an image to the top of the page with display: none [17:03:16] * Deskana sighs. [17:03:39] Every day there's something... [17:04:41] Deskana ruh roh [17:06:39] kaldari: r37 [17:09:34] (03PS1) 10Phuedx: [WIP] Add tests for WikibaseRepoConnector [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 [17:10:44] (03CR) 10Phuedx: "I've taken a stab at testing WikibaseRepoConnector here: https://gerrit.wikimedia.org/r/#/c/200886/" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 (https://phabricator.wikimedia.org/T94454) (owner: 10MaxSem) [17:11:17] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add tests for WikibaseRepoConnector [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (owner: 10Phuedx) [17:17:10] coreyfloyd: able to join the standup? [17:25:06] bgerstle_afk: coreyfloyd dr0ptp4kt what do you think about the "DWARF" build tweak mentioned here - https://labs.spotify.com/2013/11/04/shaving-off-time-from-the-ios-edit-build-test-cycle/ [17:27:16] (03CR) 10Phuedx: "These tests need to be cleaned up. There's also a bunch of missing tests around the interaction with the EntityStore." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (owner: 10Phuedx) [17:30:15] bgerstle: seems like a win… do it! [17:30:24] mhurd ditto [17:30:26] er mhurd do it! [17:30:34] someone do it [17:30:38] coreyfloyd: bgerstle will submit patch [17:30:56] mhurd: sorry saw spotify and assumed that was bgerstle … lol [17:31:09] coreyfloyd: lol [17:31:32] hehe [17:33:27] (03PS1) 10Mhurd: Only generate dSYM file with release config. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200893 [17:33:34] bgerstle: coreyfloyd dr0ptp4kt ^ [17:33:53] mhurd cool will review later [17:33:58] (03PS2) 10Mholloway: Display local article name in 'Read in other languages' list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200873 [17:34:25] (03CR) 10MaxSem: [WIP] Add tests for WikibaseRepoConnector (035 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (owner: 10Phuedx) [17:35:05] (03Abandoned) 10Fjalapeno: (WIP) Setup Xcode to use config files - setting the bundle id based on the configuration. - support alpha config in cocoapods - inhibit pod warnings - Update Schemes to use specified build configurations [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199276 (owner: 10Fjalapeno) [17:35:24] bearND: done! i went with option (b) [17:35:36] MaxSem: i agree with all of those comments -- wip is a wip [17:35:58] also, generating statementlists is /horrible/ [17:36:36] (03PS1) 10Fjalapeno: Setup Fastlane for CI [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200895 [17:36:54] jdlrobson, so what's the scoop? [17:36:59] (03CR) 10jenkins-bot: [V: 04-1] Setup Fastlane for CI [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200895 (owner: 10Fjalapeno) [17:37:13] mholloway: great! I'll probably let dbrant review this one since I'm in the middle of my own bigger patch [17:37:26] bearND: cool [17:39:56] bearND: in the meantime should i look around Phabricator and find something else to work on? not sure if dmitry had any other candidates in mind at the moment [17:40:38] mhurd: any idea what is going on here: https://gerrit.wikimedia.org/r/#/c/200895/ [17:41:13] mholloway: yes, you can look at the bug backlog in https://phabricator.wikimedia.org/project/board/489/. [17:41:15] coreyfloyd: tap on the joshing link [17:41:21] *jshint* [17:41:24] autocorrect [17:41:30] hehe [17:41:36] mhurd: i did - said the parent doesnt exist… but it is based on master [17:41:42] ? wat [17:41:44] * coreyfloyd shugs [17:41:45] weird [17:41:47] mholloway: while I look for additional tasks, you could probably take a little time to explore the JavaScript bridge code (and indeed the JavaScript transforms that we do), since I think that's the most learning-curvy portion of our code. [17:42:22] dbrant: will do [17:42:26] coreyfloyd: it's also complaining about things like "fastlane/snapshot.js: line 1, col 28, Missing semicolon." [17:42:49] coreyfloyd: it's very picky about syntax [17:42:54] oh god [17:43:29] mhurd coreyfloyd try putting jshint directive at the top of those files maybe? [17:43:49] although, most of those warnings should probably be fixed anyway ;-) [17:43:58] bgerstle: not familiar with jshint… more specific? [17:44:08] coreyfloyd: i can have a look later if you want [17:44:25] bgerstle: can you tell me what the jshint directive is? [17:45:03] coreyfloyd: doesn't appear there's a directive for "don't lint this file" AFAIK [17:45:25] coreyfloyd: link to the failing build? [17:45:55] (03PS2) 10Fjalapeno: Setup Fastlane for CI [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200895 [17:45:58] (03CR) 10jenkins-bot: [V: 04-1] Setup Fastlane for CI [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200895 (owner: 10Fjalapeno) [17:46:32] bgerstle: https://integration.wikimedia.org/ci/job/jshint/140/console [17:46:42] dbrant: so specifically in the www folder and in CommunicationBridge.java? [17:46:57] coreyfloyd: just amend working through its list of silly things like "fastlane/SnapshotHelper.js: line 6, col 23, ['width'] is better written in dot notation." [17:47:05] or the entire .../org/wikipedia/bridge folder? [17:47:19] mholloway: yep, just those [17:47:26] dbrant: cool [17:47:28] aha there is [17:47:55] coreyfloyd: oh or was that a bundled fastlane file? [17:48:14] coreyfloyd https://www.irccloud.com/pastebin/oSWMdhei [17:48:21] mhurd: yeah [17:48:29] ah [17:48:34] coreyfloyd: you can wrap the whole file in that for now [17:48:38] and i can clean it up later if you want [17:48:57] i'm not too worried about the snapshot stuff atm [17:48:59] bgerstle: ok - i may - i just tried to fix the semi colons and it is still complaining [17:49:06] coreyfloyd: are you able to run jshint locally? [17:49:36] bgerstle: no when i pushed - i fixed some of the errors and it still complained about them [17:50:38] (03PS3) 10Fjalapeno: Setup Fastlane for CI [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200895 [17:50:42] (03CR) 10jenkins-bot: [V: 04-1] Setup Fastlane for CI [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200895 (owner: 10Fjalapeno) [17:50:52] coreyfloyd: you can run it locally by navigating to the www folder in your terminal [17:50:56] and running grunt jshint [17:51:05] (assuming you have node/npm setup) [17:52:30] (03PS4) 10Fjalapeno: Setup Fastlane for CI [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200895 [17:53:04] ok done… [17:53:19] bgerstle: mhurd patch is up for review - let me know if you want me to walk you through this [17:59:32] coreyfloyd: mind if i tag everyone on it? [17:59:53] mhurd: lol- - yeah i always forget that [17:59:58] mhurd: can we auto tag people? [18:00:16] coreyfloyd: hmm not sure [18:00:24] would be nice [18:03:46] coreyfloyd: "gem 'cocoapods', '< 0.37'" ... less than? [18:04:26] mhurd: take the point releases… don't automatically update to the next major release [18:04:47] coreyfloyd: ah [18:05:29] mhurd: building and testing yours now [18:05:44] coreyfloyd: cool thx! [18:07:51] (03CR) 10Dbrant: [C: 04-1] "Looks very good so far! A couple notes:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200873 (owner: 10Mholloway) [18:07:52] mhurd coreyfloyd those should be pessimistic version specifiers now (i.e. '~> 0.36') [18:07:54] IIRC [18:08:19] (03CR) 10Mhurd: Setup Fastlane for CI (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200895 (owner: 10Fjalapeno) [18:08:26] (03CR) 10Fjalapeno: [C: 031] "Tested "Penguin" looks good to me" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200748 (owner: 10Mhurd) [18:08:51] coreyfloyd: yay [18:08:59] mhurd: sign? [18:09:35] coreyfloyd: oh what does sigh stand for? [18:10:01] (03CR) 10Bgerstle: "Gemfile question" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200895 (owner: 10Fjalapeno) [18:10:19] mhurd: thats the tool name… sigh… as in code sign… but with sadness [18:10:58] coreyfloyd: oh hahahah [18:12:03] (03PS5) 10Fjalapeno: Setup Fastlane for CI [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200895 [18:12:04] coreyfloyd: code signing always brings me sadness [18:12:27] (03CR) 10Fjalapeno: Setup Fastlane for CI (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200895 (owner: 10Fjalapeno) [18:12:37] mhurd: exactly [18:12:57] mhurd: do you want to hangout and i can walk you through? [18:13:03] coreyfloyd: ya [18:13:15] bgerstle: you want to join? [18:13:54] bgerstle: i kinda already wlked you and adam through, so you dont have to [18:13:55] coreyfloyd: sorry, now's not hte best time, about to push up my patch then grab lunch [18:14:05] bgerstle: np [18:14:09] coreyfloyd: i'm fine going through it on my own, shouldn't have too many questions [18:14:58] (03PS1) 10Bgerstle: paginate image info requests [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) [18:15:21] mhurd coreyfloyd dr0ptp4kt that one's a doozy, stand by while i update the description to be more dev-friendly [18:17:32] oh fancy, image banners in experimental i see ? [18:17:39] looks nice (bit slow though) [18:18:52] eh, ok, i don't know what the idea is for search/menu in experimental, but it feels very unnatural to me :) [18:21:02] * thedj charges his nexus7 (12 hours to go...) sh*t device [18:25:00] coreyfloyd: https://www.mediawiki.org/wiki/Git/Reviewers . what i personally do is have the apps/ios/wikipedia "New Changes" checkbox checked, but no others checked, so that i get emails when people start their patches [18:25:17] coreyfloyd: then i use https://gerrit.wikimedia.org/r/#/projects/apps/ios/wikipedia,dashboards/default:recent for seeing what's in the ios queue [18:26:36] coreyfloyd: sometimes i get ambitious and have settings > watched projects checked on multiple repos, but usually that induces email pain, so i've simplified it to just getting new changes on a specific project. [18:28:40] thedj: i've found the original power adapter and cable provide a full charge (some other cables do not). if you're on android os 5, you may also want to use the power saving feature. that's made a big difference for me [18:29:04] dr0ptp4kt: i lost my adapter :( [18:29:06] thedj: seems like one has to toggle power saving everytime after unplugging the device, though :( [18:29:12] thedj: i cry for you [18:29:27] dr0ptp4kt: i cry for android [18:29:49] luckily google has been reigning in the chaos a bit. [18:30:25] but especially tablet space is a mess. It's not wonder worldwide sales of tablets are collapsing with the cheap crap that has been dumped in the markter for the past 2 years [18:30:43] thedj: and big phones! [18:31:03] yup [18:31:05] thedj: os and app aesthetic fragmentation is really hard [18:31:11] thedj: hard to fix [18:31:14] thedj: hard to prevent [18:31:19] too [18:32:11] i had to help one of our customers setup wifi on this one sony device... even i was lost in 'how different' it was compared to the other phones. [18:33:07] going for a climby climb [18:33:14] toodles [18:35:04] phuedx: glhf [18:36:45] (03CR) 10Bmansurov: Re-start versioning the extension (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) (owner: 10Bmansurov) [18:37:02] jdlrobson: ^ left some comments [18:46:01] dr0ptp4kt: cool - thanks - yeah - would be nice if we didnt need to tag eachother [18:46:14] dr0ptp4kt: maybe we can all do what you do [18:47:57] jdlrobson, can you check if https://gerrit.wikimedia.org/r/#/c/200821/ makes things faster for you? [18:48:10] bgerstle: coreyfloyd mhurd Deskana switching to tethered connection in a bit. will drop then be back on [18:48:40] (03PS1) 10Mholloway: Add local language article name to 'Read in other languages' list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200917 (https://phabricator.wikimedia.org/T68917) [18:49:18] (03PS2) 10Jhernandez: Collection::newFromApi Make user optional [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200838 [18:52:26] hmm, i seem to have created a new gerrit entry on that last git review push... [18:53:26] bgerstle: coreyfloyd running to lunch [18:54:25] mholloway: Did you "git commit" or "git commit --amend"? [18:54:37] just "git commit" [18:55:37] Deskana: and it looks like I'll get to try again since I need to remove a bit of commented-out code... [18:57:17] mholloway: If you want to submit a new patch set to a commit that's already in gerrit, when when you switch your local branch you need to do "git commit --amend" instead of "git commit". [18:57:58] mholloway: Try changing some stuff in that patch you just submitted, and using "git commit --amend" instead, and I think you'll see what I mean. :-) [18:58:00] i see. [18:58:57] mhurd: bgerstle dr0ptp4kt FYI - my patch set has significant project file changes, so would like to get it merged as soon as we can so other devs can base new work off if it and avoid weird merge conflicts. [18:59:30] coreyfloyd: k [18:59:55] (03PS6) 10Fjalapeno: Setup Fastlane for CI [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200895 [19:00:04] (03PS2) 10Mholloway: Add local language article name to 'Read in other languages' list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200917 (https://phabricator.wikimedia.org/T68917) [19:00:07] minor stuff^ [19:00:37] (03CR) 10Jdlrobson: [C: 032] Collection::newFromApi Make user optional [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200838 (owner: 10Jhernandez) [19:00:42] bgerstle: mhurd, you got coreyfloyd's patch covered? if we need to fixes on the 4.1.0.2 (4.0.7.10) build for some reason, we can always branch from the appropriate tags [19:01:09] dr0ptp4kt: +1 on release branching if necessary. and yes, i'm about to review it now [19:01:12] mholloway: See what happened? It's now under "patch set 2". https://gerrit.wikimedia.org/r/#/c/200917/ [19:01:25] Deskana: yep [19:01:35] mholloway: And you can see the difference between the patches: https://gerrit.wikimedia.org/r/#/c/200917/1..2/wikipedia/src/main/java/org/wikipedia/interlanguage/LangLinksActivity.java [19:02:05] Deskana: ahh, that's cool [19:03:00] dr0ptp4kt: bgerstle mhurd important note… build number scheme will be changing my patch - the build number will be generated by jenkins (monotonically increasing integer) - Version number is untouched. [19:03:45] coreyfloyd: k. when you say it's generated by jenkins, do you mean the fast lane task that increments it? [19:04:06] bgerstle: the fast lane task sets it to the jenkins build number [19:04:18] coreyfloyd: does it actually change the file? [19:04:27] bgerstle: it does not commit changes [19:04:30] k [19:04:38] shouldn't even have to change the file, but can worry about that later [19:05:05] dr0ptp4kt: i can merge it when I get back from lunch. [19:05:07] bgerstle: it uses agvtool under the hood… so it does what agvtool does [19:05:21] dr0ptp4kt: unless u want to in the mean time. [19:06:46] (03Merged) 10jenkins-bot: Collection::newFromApi Make user optional [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200838 (owner: 10Jhernandez) [19:07:13] i guess it derives the Info.plist file location from the xcodeproj [19:07:16] and writes to it [19:07:19] interesting [19:11:08] (03PS1) 10Jdlrobson: Collection::newFromApi Make user optional [extensions/Gather] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/200927 [19:11:16] (03PS1) 10Jdlrobson: Collection::newFromApi Make user optional [extensions/Gather] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/200928 [19:12:12] Deskana: any way to clean up the mess i made and associate my new changes with the original patch in Gerrit? Or should I just leave it alone? [19:12:27] mholloway: got a few minutes? (batcave) [19:12:35] dbrant: sure [19:12:42] bgerstle: coreyfloyd mhurd , sorry connection dropped: coreyfloyd: SO, to continue the piece about adding people to gerrit changes automatically. i'm okay with it as long as the social protocol for getting actual reviews is to ask on irc (and get an ack; failing that follow up on email)...and importantly, indicating how urgently review is needed. coreyfloyd mhurd you okay with having our handles auto-added in gerrit? [19:12:43] [12:05PM] dr0ptp4kt: i mean, bgerstle and mhurd ^ [19:17:35] (03PS3) 10Mholloway: Display local article name in 'Read in other languages' list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200873 (https://phabricator.wikimedia.org/T68917) [19:18:52] (03Abandoned) 10Mholloway: Add local language article name to 'Read in other languages' list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200917 (https://phabricator.wikimedia.org/T68917) (owner: 10Mholloway) [19:21:43] yurik: around? [19:21:52] dr0ptp4kt: mhurd bgerstle did you guys print out your watch sizing guides yet? http://exactfitnessapps.com/try-it-on-apple-watch-sizing-guide.html [19:22:00] jdlrobson, si [19:22:04] yurik: trying to work out pagination. [19:22:13] coreyfloyd: ha [19:22:25] ...? [19:22:29] seems api expects a continue parameter of title? but i want to sort by modified http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:GatherLists [19:22:56] jdlrobson, the continue parameter is internal, and can change at any moment [19:23:09] never assume you know its meaning [19:23:20] i don't know it's meaning.. i'm asking the meaning :) [19:23:34] anything inside continue= should be opaque [19:23:35] maybe i shold rephrase.. how can i use the api to get at older stuff :) [19:23:47] what api call are you using? [19:23:55] can you past the actual request? [19:24:44] https://gist.github.com/jdlrobson/2e0560330fd836fb8bf1 < yurik [19:25:03] (03PS1) 10TheDJ: Limit hiding of sideboxes to sister sites [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200934 (https://phabricator.wikimedia.org/T94593) [19:26:43] (03Abandoned) 10Jdlrobson: POC/WIP: Add Special:GatherEditFeed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/196732 (owner: 10Jdlrobson) [19:28:59] yurik: soo? [19:29:02] jdlrobson, both allpublic & allhiden are sorted by the updated flag, in desc ourder [19:29:16] last updated field [19:29:55] i will see if i can easily implement the "reverse continue" option [19:30:38] so i can't currently do it? [19:31:03] paging forward - you can, but not backwards (at least - not easily) [19:31:28] mm ok i just use lstcontinue right? [19:31:34] to allow backwards paging, you must store the continue parameter for each page somehow [19:31:35] forward should be fine [19:31:39] forward is easy [19:31:40] kristenlans: just tried to connect but Hangouts says there's a problem [19:31:56] simply continue the query and show result [19:32:18] using lstcontinue ? [19:32:27] or both continue and lstcontinue [19:32:28] no, using continue [19:32:39] read up on how to continue query properly [19:32:40] mholloway: oh hangouts... [19:32:56] mholloway: sometimes switchign browsers helps me 0_o [19:33:01] sigh far too much reading involved in our api.. [19:33:01] I read that as: kristenlans: just tried to connect but Houston says there's a problem [19:33:04] http://www.mediawiki.org/wiki/API:Query#Continuing_queries [19:33:14] jdlrobson, ^ [19:33:22] thanks yurik [19:33:22] quiddity: lol [19:33:33] jdlrobson, could you check https://phabricator.wikimedia.org/T94518 please? Based on the timing (of appearing and disappearing symptom), I suspect it might be related to Gather somehow? [19:33:44] quiddity: hahaha i was thinking that myself. or HAL refusing. [19:36:22] yurik: working. seems to do what i need it to do [19:36:47] jdlrobson, when rendering a page, i suggest you show the "go to first" and "go to next" buttons. For "first" simply set the continue= [19:36:58] make sure you read that continuation section [19:38:21] coreyfloyd: sorry for the delay, but stuck doing health ins stuff [19:40:14] (03PS1) 10Jdlrobson: Add pagination to Special:GatherList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200943 (https://phabricator.wikimedia.org/T94515) [19:40:23] quiddity: not quite sure how this relates to Gather.. [19:41:34] quiddity: we don't load any code on desktop [19:41:36] jdlrobson, my thinking is: A) I only noticed it on enwiki during the brief hours that Gather was enabled there. B) I noticed it because I was playing with the watchlist star in mobile&desktop modes. [19:42:12] that's all. I just wanted to either eliminate (or confirm) gather as being relevant. :) [19:43:02] quiddity: annoyingly it keeps disappearing so i can't work out what's going on [19:43:09] yeah, ikr! [19:43:18] quiddity: i can't see any reason why Gather would interfere with those stlyes [19:43:34] okie. Thanks for checking/investigating. :) [19:43:51] i'll have a think over lunc [19:44:20] lunch. #goodplan. [19:58:11] (03CR) 10Yurik: [C: 04-1] Add pagination to Special:GatherList (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200943 (https://phabricator.wikimedia.org/T94515) (owner: 10Jdlrobson) [19:59:42] jdlrobson, basically, encode all the values inside the resulting "continue" block [19:59:51] inside the URL param [20:01:23] is rachel around? haven't seen her online [20:02:09] yurik: rachel who [20:02:15] ferrand [20:02:39] farrand [20:05:42] bgerstle: mhurdout for a bit - going to walk the dog and such [20:06:00] coreyfloyd: k ,reviewing your patch [20:16:11] (03CR) 10Jdlrobson: Add pagination to Special:GatherList (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200943 (https://phabricator.wikimedia.org/T94515) (owner: 10Jdlrobson) [20:25:08] bearND: dr0ptp4kt: i chatted with the guys from http://sirius.clarity-lab.org/ today and they want to dive into our iOS and Android code base. Is there anything that you would recommend past gerrit links? [20:26:55] yeah, fixed ogg audio only player on android ! [20:27:20] tfinc: is the linkbar on the top of that site trying to make you install scareware? [20:27:41] dbrant: ^ you? [20:27:44] tfinc: I would point them to the Github links. That way the README is nicely formatted. [20:28:05] bearND: k [20:28:10] bgerstle: dr0ptp4kt i'm back. should i merge corey's fastlane patch? [20:28:12] tfinc: otherwise, yeah, the github link. also suggest on iOS they'll probably be particularly interested in the *Fetcher.m classes [20:28:24] mhurd still looking at it [20:28:28] bgerstle: k [20:28:50] mhurd: yeah, once bgerstle [20:28:53] 's done [20:28:54] go for it [20:29:10] dr0ptp4kt: will do [20:29:41] tfinc: Are they planning to contribute to the apps? [20:29:41] tfinc: bearND did you get the scareware tactic on the linkbar on the top of that site? beware...you may want to use a crhome private browsing window for best sandboxing [20:29:55] (03CR) 10Yurik: Add pagination to Special:GatherList (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200943 (https://phabricator.wikimedia.org/T94515) (owner: 10Jdlrobson) [20:29:58] dr0ptp4kt: scareware tactic ? [20:30:12] dr0ptp4kt: didn't notice anything on the main page [20:30:34] tfinc: bearND i'm referring to the thing that says "Install/setup" [20:30:58] dr0ptp4kt: you mean their install instruction for their project ? [20:31:10] tfinc: bearND it could be some l33t people on this wifi network, though...may need to tunnel [20:31:25] dr0ptp4kt: i'm not seeing anything suspicious [20:31:46] tfinc: bearND dbrant AWESOME! okay, tunneling to begin shortly [20:33:46] tfinc: bearND dbrant problem solved. now i remember why i fear even wpa2 shared networks [20:33:56] :) [20:35:44] ha! [20:40:31] (03CR) 10BearND: [C: 04-1] "See inline comments." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200873 (https://phabricator.wikimedia.org/T68917) (owner: 10Mholloway) [20:44:52] coreyfloyd: do we need the fastlane/Android file? [20:44:56] looks empty [20:45:25] bgerstle: yes, I also secretly built an Android app last week… shhhh [20:45:50] bgerstle: no it created lots of files during the init process… not currently using that one [20:46:02] k [20:47:01] coreyfloyd: i don't know about using the build number from the jenkins job [20:47:08] we'll probably have different jobs for each lane [20:47:15] right? [20:47:25] and we want to be "promoting" builds from alpha -> beta w/ the same version [20:48:07] (03CR) 10Kaldari: "@Jdlrobson: I know this will load both libraries on Special:MobileOptions, which is why I chose to try this with the checkbox template rat" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200794 (owner: 10Kaldari) [20:49:25] also, i'm not crazy about committing things like our iTC emails to VCS [20:49:37] even w/o the password [20:50:33] bgerstle: maybe - but we haven't discussed it - i would say that if you want to make any organizational/process ideas (build numbering, xconfig files, where to API Keys and emails, etc…), lets discus and then do a follow on patches before we start using additional lanes. [20:50:49] k [20:50:54] (03PS2) 10Kaldari: Switching mobileoptions page to use core mustache compiler [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200794 [20:51:10] (03PS4) 10Mholloway: Display local article name in 'Read in other languages' list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200873 (https://phabricator.wikimedia.org/T68917) [20:51:51] coreyfloyd: right, probably better to merge this now, get it up and running, then make tweaks while we can make sure it still runs [20:51:53] bgerstle: personally i would like to do get API Keys and emails out of there too… maybe use that git repo thing we saw [20:52:05] cocoapods-keys or whatever? [20:52:26] i think… yeah something to remove all that info - also from our source code for things like hockey app [20:52:35] since we open source everything [20:52:39] yep [20:53:16] bgerstle: also there is a ticket to create jenkins accounts for ITC and gerrit… so we can swap my email out of there [20:53:26] good [20:53:40] (03CR) 10Kaldari: [C: 032] Don't load WikiGrok on disambiguation pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [20:54:59] (03CR) 10Fjalapeno: [C: 031] "But lets wait until the fastlane patch goes through since that makes a lot of project file changes." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200893 (owner: 10Mhurd) [20:57:22] (03PS5) 10Mholloway: Display local article name in 'Read in other languages' list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200873 (https://phabricator.wikimedia.org/T68917) [20:58:51] (03Merged) 10jenkins-bot: Don't load WikiGrok on disambiguation pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197790 (https://phabricator.wikimedia.org/T91300) (owner: 10Bmansurov) [20:59:03] coreyfloyd: do all the schemes do anything besides change the config? [20:59:14] (and the extension)? [20:59:16] bgerstle: no, that is all [20:59:19] ok [20:59:27] sorry, the extension is changed by teh config [20:59:38] bgerstle: yep [20:59:40] coreyfloyd: ok, i might make a couple small changes. is it easy for me to verify? [20:59:47] i want to kill the pods warnings [20:59:54] bgerstle: please do [21:00:15] (03CR) 10BearND: [C: 031] "Code looks good. I'll let Dbrant merge this one one he's ready." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200873 (https://phabricator.wikimedia.org/T68917) (owner: 10Mholloway) [21:00:32] bgerstle: to verify, you will have to push to my git repo, and then update the build job to look at the branch, and then kick off a manual build [21:00:44] coreyfloyd: could i also run it locally? [21:00:46] bgerstle: or push to your repo and change it to look at your branch [21:00:57] bgerstle: you can [21:01:08] how can i run alpha but force it to not upload anything? [21:01:26] bgerstle: comment out the deliver and hockey steps in the alpha lane [21:01:32] ok [21:07:44] coreyfloyd: do you know the diff between reset_git_repo and ensure_git_status_clean ? [21:08:01] nvm i guess one does git reset and another git clean [21:10:49] bgerstle: yep [21:10:56] bgerstle: nope [21:11:06] bgerstle: one does it, the other one checks if it is true [21:11:14] "ensure" [21:11:51] ahh [21:11:53] i see [21:16:18] (03CR) 10Dbrant: [C: 04-1] "Almost! Just one thing." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200873 (https://phabricator.wikimedia.org/T68917) (owner: 10Mholloway) [21:17:47] dbrant: thinking back to our chat yesterday, do we want to label this [WIP] and have a chat with a designer about the change as well? [21:21:48] mholloway: well, this particular change is minor enough that we can just merge it, and have the designers comment on it after the fact. [21:23:08] (03PS6) 10Mholloway: Display local article name in 'Read in other languages' list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200873 (https://phabricator.wikimedia.org/T68917) [21:24:10] mholloway: everything that gets merged becomes part of the Alpha version of the app, which the designers update on a regular basis. If they give us feedback, we're able to make tweaks (and merge them) before publishing the app to the Play Store. [21:25:28] dbrant: mholloway: yes, we still need to point the designers to the changes so they are aware of them. [21:25:32] dbrant: ah, i see. and yeah, it definitely looks better without the android:singleLine and android:ellipsize [21:26:21] (03CR) 10Kaldari: [C: 031] Submission to Wikidata [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 (https://phabricator.wikimedia.org/T94454) (owner: 10MaxSem) [21:30:34] dbrant: i looked back just now and found what i was referring to earlier about localization -- String.format() either uses the default local or lets you supply a locale. http://developer.android.com/reference/java/lang/String.html#format(java.util.Locale, java.lang.String, java.lang.Object...) [21:31:04] dbrant: link didn't come through but you get the idea [21:31:19] bearND: how do we usually go about alerting the designers to changes? [21:32:51] (03CR) 10Jdlrobson: [C: 032] Force labels to comply with the Title rules [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200783 (owner: 10Yurik) [21:33:03] (03CR) 10Jdlrobson: [C: 032] Hygiene: Improve Collection::isOwner [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200844 (https://phabricator.wikimedia.org/T94556) (owner: 10Jhernandez) [21:33:15] mholloway: so, I told Vibha that you're working on this change. She should be scheduling an intro meeting with you anyway, so you could discuss it then. [21:33:45] dbrant: perfect. [21:33:46] mholloway: but generally, you could tag them in a comment in the Phab task. [21:38:03] (03Merged) 10jenkins-bot: Force labels to comply with the Title rules [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200783 (owner: 10Yurik) [21:38:05] (03Merged) 10jenkins-bot: Hygiene: Improve Collection::isOwner [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200844 (https://phabricator.wikimedia.org/T94556) (owner: 10Jhernandez) [21:40:49] (03CR) 10Dbrant: [C: 032] "Off to a good start!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200873 (https://phabricator.wikimedia.org/T68917) (owner: 10Mholloway) [21:41:15] mholloway: congrats! :) [21:41:32] bearND: dbrant: thanks! [21:42:00] (03PS11) 10MaxSem: Submission to Wikidata [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 [21:46:50] (03PS2) 10Bgerstle: paginate image info requests [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) [21:47:16] coreyfloyd: mhurd dr0ptp4kt updated description. maybe one or two of you could have a look while i'm reviewing the fastlane patch? [21:49:21] bgerstle: on it [21:49:37] mhurd i left a brief "guide" in the commit msg [21:49:42] let me know if anything's unclear [21:49:47] bgerstle: will do [21:55:26] (03CR) 10MaxSem: [C: 031] Limit hiding of sideboxes to sister sites [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200934 (https://phabricator.wikimedia.org/T94593) (owner: 10TheDJ) [21:57:09] dr0ptp4kt: where is the production icon located? [21:58:23] coreyfloyd: wikipedia/Images.xcassets/AppIcon.appiconset/icon-prod.svg [22:02:57] (03PS2) 10Jdlrobson: Add pagination to Special:GatherList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200943 (https://phabricator.wikimedia.org/T94515) [22:02:59] (03PS1) 10Jdlrobson: Add pagination on Special:Gather for list of collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201045 [22:03:01] (03PS1) 10Jdlrobson: Pagination collection itself [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201046 (https://phabricator.wikimedia.org/T94515) [22:03:35] dr0ptp4kt: Ping. Meeting time. :-) [22:03:44] dr0ptp4kt: thanks [22:04:47] bgerstle: seems pretty solid testing thus far... [22:04:57] good :-) [22:05:18] bgerstle: have a minute to checkout https://gerrit.wikimedia.org/r/#/c/200748/ ? [22:08:42] (03CR) 10jenkins-bot: [V: 04-1] Add pagination on Special:Gather for list of collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201045 (owner: 10Jdlrobson) [22:09:27] (03CR) 10Mhurd: [C: 031] paginate image info requests [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) (owner: 10Bgerstle) [22:10:00] (03CR) 10jenkins-bot: [V: 04-1] Pagination collection itself [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201046 (https://phabricator.wikimedia.org/T94515) (owner: 10Jdlrobson) [22:10:04] (03CR) 10Bgerstle: "looks good, add some tests for a +1" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200748 (owner: 10Mhurd) [22:10:20] bgerstle: will do [22:11:18] mhurd there was one other comment about moving the sanitization into the serializer [22:11:24] otherwise looks good [22:11:31] bgerstle: k will check it [22:11:49] bgerstle: i'm going to lean on your review of corey's CI patch as you have more experience with such bits [22:11:57] k [22:12:02] mhurd i'm actually trying to patch it now [22:12:07] bgerstle: cool [22:12:07] but running into weird grunt issues [22:12:11] ah [22:12:52] weird [22:12:58] had to nuke node_modules and re-npm-install [22:17:05] (03PS2) 10Jdlrobson: Add pagination on Special:Gather for list of collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201045 [22:18:44] bearND, dr0ptp4kt, kristenlans: https://phabricator.wikimedia.org/T94630 [22:19:35] (03PS3) 10Jdlrobson: Add pagination on Special:Gather for list of collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201045 [22:22:05] (03PS4) 10Jdlrobson: Add pagination on Special:Gather for list of collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201045 [22:25:37] dr0ptp4kt: can you jump to the batcave for a sec? [22:25:48] bearND: here i come [22:25:57] (03PS2) 10MaxSem: Fix notices on bogus language codes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199177 (https://phabricator.wikimedia.org/T93500) [22:31:08] mhurd coreyfloyd dr0ptp4kt i need to step out for a bit [22:31:20] i was working on some amendments for the fastlane patch, but they could be follow-on [22:31:30] at this point i still consider it a WIP and we can merge it to master so other stuff is unblocked [22:31:48] bgerstle: sounds good [22:31:54] although [22:32:01] let me try one last thing.. [22:32:05] bgerstle: k [22:44:40] (03PS7) 10Bgerstle: Setup Fastlane for CI [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200895 (owner: 10Fjalapeno) [22:48:24] (03CR) 10Fjalapeno: "Various comments of varying degrees of importance" (0319 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) (owner: 10Bgerstle) [22:48:27] (03PS4) 10Mhurd: Collapse image gallery description whitespace. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200748 [22:48:37] bgerstle_afk: ^ tests added [22:50:44] (03PS2) 10Phuedx: Add tests for WikibaseRepoConnector [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 [22:51:32] (03CR) 10Phuedx: Add tests for WikibaseRepoConnector (033 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (owner: 10Phuedx) [22:53:03] (03CR) 10Phuedx: [C: 04-1] "There's still that bunch of tests missing covering the interaction with EntityStore." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (owner: 10Phuedx) [22:53:14] * phuedx goes to bed [22:53:18] that was fun though [22:54:56] phuedx, anything to say about my change? :P [22:56:05] (03PS3) 10Jdlrobson: Special Edit feed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 [22:56:32] (03PS4) 10Jdlrobson: Special Edit feed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 [22:57:22] (03PS5) 10Mhurd: Collapse image gallery description whitespace. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200748 [22:58:15] (03CR) 10Mhurd: Collapse image gallery description whitespace. (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200748 (owner: 10Mhurd) [22:58:52] (03CR) 10Fjalapeno: "@bgerstle - sorry I had no idea your changes would be that extensive… lets address these changes individually in follow on patches." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200895 (owner: 10Fjalapeno) [22:59:22] coreyfloyd: i amended https://gerrit.wikimedia.org/r/#/c/200748/ based on brian's comments. mind quick re-check? [23:00:14] MaxSem: question about Aggregator class if you have a sec [23:00:21] sure [23:01:58] (03PS6) 10Mhurd: Collapse image gallery description whitespace. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200748 [23:02:06] ^ removed cruft header reference [23:03:55] coreyfloyd: like you "WMFShuffle" comment :) [23:03:59] *your* [23:06:33] ha [23:08:48] (03PS8) 10Fjalapeno: Setup Fastlane for CI [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200895 [23:10:29] mhurd: can you +1 if you are done with my patch set? [23:10:39] coreyfloyd: ya [23:11:47] coreyfloyd: batcave? [23:12:37] bgerstle_afk: sorry had to revert your changes… changed a lot of things that I would rather address in discrete follow on patches. If you can review again and let me know if anything is broken and we can work on project changes and condensing of fastfile code later on. [23:12:39] mhurd: sure [23:12:44] (03PS1) 10Kaldari: Adding some comments to Aggregator::aggregate() [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201064 [23:13:51] coreyfloyd: sure [23:15:02] bgerstle_afk: will you be back on tonight? [23:15:27] (03CR) 10Catrope: [C: 032] Collection::newFromApi Make user optional [extensions/Gather] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/200927 (owner: 10Jdlrobson) [23:16:46] (03CR) 10Fjalapeno: [C: 031] Collapse image gallery description whitespace. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200748 (owner: 10Mhurd) [23:19:34] (03CR) 10Fjalapeno: Added wikidata descriptions to saved pages entries. (037 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 (owner: 10Mhurd) [23:24:41] (03CR) 10Catrope: [C: 032] Collection::newFromApi Make user optional [extensions/Gather] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/200928 (owner: 10Jdlrobson) [23:25:30] jdlrobson: any thoughts on https://gerrit.wikimedia.org/r/#/c/200794/ ? Should I just migrate all the MF templates at once (seems risky)? [23:27:11] coreyfloyd: maybe [23:28:03] (03Merged) 10jenkins-bot: Collection::newFromApi Make user optional [extensions/Gather] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/200927 (owner: 10Jdlrobson) [23:30:39] (03Abandoned) 10Kaldari: Switching mobileoptions page to use core mustache compiler [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200794 (owner: 10Kaldari) [23:31:30] (03Merged) 10jenkins-bot: Collection::newFromApi Make user optional [extensions/Gather] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/200928 (owner: 10Jdlrobson) [23:34:27] mhurd: Holy crap. [23:34:31] mhurd: There's a song named after you! [23:34:32] mhurd: https://www.youtube.com/watch?v=le34ygtODfI [23:35:07] It's... not very good. [23:35:41] bgerstle_afk: ok no worries… we can finish up this patch set in the morn… mhurd is defering to you on getting this approved. [23:40:16] coreyfloyd: I can sign on for a bit afte I get dinner started [23:40:40] But mhurd can merge, I'm fine with it [23:40:54] bgerstle_afk: if you want… but really it doesnt matter… nothing that cant wait until tomorrow [23:40:56] Deskana: lol [23:41:01] bgerstle_afk: k [23:41:05] mhurd: ^ [23:41:36] coreyfloyd: k just a sec... [23:43:33] coreyfloyd: bgerstle_afk merging... [23:44:06] (03CR) 10Mhurd: [C: 032] "+1 from Brian in irc." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200895 (owner: 10Fjalapeno) [23:45:37] arrg i keep getting booted off for some reason [23:47:45] (03CR) 10Fjalapeno: "Left 1 comment about the spinner class… everything else looks good" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [23:48:06] coreyfloyd: cool! i merged your patch [23:54:06] mhurd: dunka I'm off now [23:54:20] coreyfloyd: yw. see ya! [23:58:28] (03CR) 10MaxSem: [C: 032] Adding some comments to Aggregator::aggregate() [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201064 (owner: 10Kaldari)